repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
ScottPlot/ScottPlot
5,035
issue_to_patch
Exporting a heatmap as SVG outputs a smoothed svg. **Issue:** Exporting as a SVG smoothes the output, while the image format does not. **ScottPlot Version:** Nuget Scottplot version 5.0.55 **Code Sample:** ```cs ScottPlot.Plot myPlot = new ScottPlot.Plot(); double[,] data = { ...
Heatmap: Add independent rendering cell flags (#4950)
The issue described in #4950 is similar to that in #5020. SVG does not fully support pixel-based images, but the `Heatmap` rendering currently relies on `Drawing.BitmapFromArgbs()`. To address this, a new optional flag `IndependentCellRendering` has been added. When set to `true`, each cell is rendered independent...
4c4800c0187fb148f3093f977df9192669cbdf43
be9b7bff8087d0fdbae5d6ce7ca59037a13d6bdb
diff --git a/CHANGELOG.md b/CHANGELOG.md index 73d61fb62d..cb1b1ed556 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,6 +32,8 @@ _Not yet on NuGet..._ * Legend: Improve appearance of large markers in legends (#4999, #5031) @manaruto @winsrp * Cookbook: Improve developer experience when generating images using the...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Tests/Unit Tests/Extensions.cs", "src/ScottPlot5/ScottPlot5 Tests/Unit Tests/RenderTests/Plottable/HeatmapTests.cs", "src/ScottPlot5/ScottPlot5/Plottables/Heatmap.cs" ]
[ { "comment": "It may be something of a moot point, but it could be worth suppressing the bitmap generation in`Update()` calls when `IndependentCellRendering` is set. It is fairly expensive and it uses a significant amount of memory for large heatmaps. If this is already going to be dog-slow for large heatmaps (...
true
ScottPlot/ScottPlot
5,035
comment_to_fix
Heatmap: Add independent rendering cell flags (#4950)
It may be something of a moot point, but it could be worth suppressing the bitmap generation in`Update()` calls when `IndependentCellRendering` is set. It is fairly expensive and it uses a significant amount of memory for large heatmaps. If this is already going to be dog-slow for large heatmaps (which might be accepta...
4c4800c0187fb148f3093f977df9192669cbdf43
be9b7bff8087d0fdbae5d6ce7ca59037a13d6bdb
diff --git a/src/ScottPlot5/ScottPlot5/Plottables/Heatmap.cs b/src/ScottPlot5/ScottPlot5/Plottables/Heatmap.cs index 05b2394d0a..3126ed756d 100644 --- a/src/ScottPlot5/ScottPlot5/Plottables/Heatmap.cs +++ b/src/ScottPlot5/ScottPlot5/Plottables/Heatmap.cs @@ -135,7 +135,7 @@ public bool Smooth /// <summary> //...
[ "src/ScottPlot5/ScottPlot5/Plottables/Heatmap.cs" ]
[ { "comment": "It may be something of a moot point, but it could be worth suppressing the bitmap generation in`Update()` calls when `IndependentCellRendering` is set. It is fairly expensive and it uses a significant amount of memory for large heatmaps. If this is already going to be dog-slow for large heatmaps (...
true
ScottPlot/ScottPlot
5,035
comment_to_fix
Heatmap: Add independent rendering cell flags (#4950)
I think these should be cached in `Update` so that we don't pay as much performance cost if this is panned without data updates.
4c4800c0187fb148f3093f977df9192669cbdf43
be9b7bff8087d0fdbae5d6ce7ca59037a13d6bdb
diff --git a/src/ScottPlot5/ScottPlot5/Plottables/Heatmap.cs b/src/ScottPlot5/ScottPlot5/Plottables/Heatmap.cs index 05b2394d0a..3126ed756d 100644 --- a/src/ScottPlot5/ScottPlot5/Plottables/Heatmap.cs +++ b/src/ScottPlot5/ScottPlot5/Plottables/Heatmap.cs @@ -135,7 +135,7 @@ public bool Smooth /// <summary> //...
[ "src/ScottPlot5/ScottPlot5/Plottables/Heatmap.cs" ]
[ { "comment": "I think these should be cached in `Update` so that we don't pay as much performance cost if this is panned without data updates.", "path": "src/ScottPlot5/ScottPlot5/Plottables/Heatmap.cs", "hunk": "@@ -402,18 +411,49 @@ public Range? ManualRange\n }\n }\n \n+ /// <summary>\...
true
ScottPlot/ScottPlot
5,035
comment_to_fix
Heatmap: Add independent rendering cell flags (#4950)
This signature sets `IsAntialias = true` on its SKPaint, which gives a visible white border around the cells on my machine. You can use `Drawing.FillRectangle(SKCanvas, PixelRect, SKPaint, FillStyle)`, where you set `AntiAlias = false` on the FillStyle to get around this (and at the same time reuse the SKPaint acros...
4c4800c0187fb148f3093f977df9192669cbdf43
be9b7bff8087d0fdbae5d6ce7ca59037a13d6bdb
diff --git a/src/ScottPlot5/ScottPlot5/Plottables/Heatmap.cs b/src/ScottPlot5/ScottPlot5/Plottables/Heatmap.cs index 05b2394d0a..3126ed756d 100644 --- a/src/ScottPlot5/ScottPlot5/Plottables/Heatmap.cs +++ b/src/ScottPlot5/ScottPlot5/Plottables/Heatmap.cs @@ -135,7 +135,7 @@ public bool Smooth /// <summary> //...
[ "src/ScottPlot5/ScottPlot5/Plottables/Heatmap.cs" ]
[ { "comment": "This signature sets `IsAntialias = true` on its SKPaint, which gives a visible white border around the cells on my machine.\r\n\r\nYou can use `Drawing.FillRectangle(SKCanvas, PixelRect, SKPaint, FillStyle)`, where you set `AntiAlias = false` on the FillStyle to get around this (and at the same ti...
true
ScottPlot/ScottPlot
5,032
issue_to_patch
Tests: link to generated image files This is a surprisingly late realization, but I can include hyperlinks that point to local files in the test explorer summary window. This way tests that generate image outputs can have a link you can click to launch the image locally. ```cs string localImagePath = @"C:\path\to\you...
Tests: link to generated image files (#4882)
reslove #4882
774ba754dd01c42d66acf3d34c4d5d5634aaef3d
7fc62741e77dbd8bbabe639ee42b06d6a5e977f1
diff --git a/CHANGELOG.md b/CHANGELOG.md index f7ce781d65..d7a306cedf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,6 +30,7 @@ _Not yet on NuGet..._ * Font: Added `Fonts.Reset()` to restore default styling options (#5013) @aespitia * Legend: Respect marker size when a default marker shape is used (#5006, #5031)...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Cookbook/MultiplotRecipeBase.cs", "src/ScottPlot5/ScottPlot5 Cookbook/RecipeBase.cs", "src/ScottPlot5/ScottPlot5 Tests/Unit Tests/Extensions.cs" ]
[]
true
ScottPlot/ScottPlot
5,057
issue_to_patch
MarkerShapeOverride: disable line and fill styles
Extends #5006
0d05bcfbc9abec9d2fb79745cf250ee36dd8fe98
54a967434d8e223c7caa5ac337290a4aa9cb400d
diff --git a/src/ScottPlot5/ScottPlot5 Cookbook/Recipes/General/Legend.cs b/src/ScottPlot5/ScottPlot5 Cookbook/Recipes/General/Legend.cs index 08872484d5..434f2daaa5 100644 --- a/src/ScottPlot5/ScottPlot5 Cookbook/Recipes/General/Legend.cs +++ b/src/ScottPlot5/ScottPlot5 Cookbook/Recipes/General/Legend.cs @@ -121,6 +12...
[ "src/ScottPlot5/ScottPlot5 Cookbook/Recipes/General/Legend.cs", "src/ScottPlot5/ScottPlot5/Primitives/Legend.cs" ]
[]
true
ScottPlot/ScottPlot
5,056
issue_to_patch
Legend: Improve vertical item measurement
Extends #5031 to restore default spacing to legends unaffected by clipping due to large markers ```cs [Test] public void Test_LargeMarkers_ExpandLegendToFit() { Plot plot = new(); var xs = Generate.Consecutive(51); var ys1 = Generate.Sin(51); var ys2 = Generate.Cos(51); var sp1 = plot...
32537858951baafd4579df04f0f2cfa1ce862659
6e70408a19be04cb68ec242922c736688040d17b
diff --git a/CHANGELOG.md b/CHANGELOG.md index b62be5128f..b1adfe657e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,7 +29,7 @@ _Not yet on NuGet..._ * WinUI: Improved support for plots with transparent backgrounds (#5026, #5029) @diluculo * Font: Added `Fonts.Reset()` to restore default styling options (#5013) ...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Tests/Unit Tests/RenderTests/LegendTests.cs", "src/ScottPlot5/ScottPlot5/LegendLayouts/Wrapping.cs", "src/ScottPlot5/ScottPlot5/Primitives/Legend.cs" ]
[]
true
ScottPlot/ScottPlot
5,031
issue_to_patch
Marker size not fully displayed on legend. (shows cropped) **Issue:** I'm using scatter plot **ScottPlot Version: 5.0.55 using basic scatter and putting markers at size 15, make them not fit on legend box. <img width="431" height="74" alt="Image" src="https://github.com/user-attachments/assets/46a30310-34e0-4bc3-ac3...
Legend Restore MarkerStyle.Size behavior and fix marker clipping inside rectangle
This PR addresses a regression introduced after [PR #5006](https://github.com/ScottPlot/ScottPlot/pull/5006), where the MarkerStyle.Size property stopped taking effect when a MarkerShapeDefault was set. Fixes [#4999](https://github.com/ScottPlot/ScottPlot/issues/4999) (marker shape clipping by legend rectangle). ...
b8896c9e672af4dc436828119f3ba89a9bfa3a18
509c0a053a5bc5b16f510ef965ffacecaa77790a
diff --git a/CHANGELOG.md b/CHANGELOG.md index 73fe51038e..f7ce781d65 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -28,6 +28,8 @@ _Not yet on NuGet..._ * Polar Axis: Added a `Clockwise` property to support clockwise and counter-clockwise translation between Polar and Cartesian coordinates (#5028, #4884, #5046) @Cod...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5/LegendLayouts/Wrapping.cs", "src/ScottPlot5/ScottPlot5/Primitives/Legend.cs" ]
[]
true
ScottPlot/ScottPlot
5,053
issue_to_patch
Add OnLostFocus event handling to AvaPlot
Add OnLostFocus event handling to AvaPlot fix KeyState wrong After I switch windows using tab + alt, AvaPlot cannot get the key up event correctly, resulting in inconsistent behavior of mouse operations
33ca17b47b6de1a918359f97120ff742e400df02
d4823cb421db8a8e38c274a721bdfcd41a26a2a4
diff --git a/CHANGELOG.md b/CHANGELOG.md index 808c920ec0..b62be5128f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -36,6 +36,7 @@ _Not yet on NuGet..._ * Heatmap: Added `Heatmap.RenderStrategies.Rectangles` to improve SVG support by drawing each cell of a heatmap as a distinct rectangle (#4950, #5020, #5035) @Coder...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Avalonia/AvaPlot.cs" ]
[]
true
ScottPlot/ScottPlot
5,052
issue_to_patch
Fix the wrong location when HorizontalLine has a RightAxis and LabelOppositeAxis
This pr is to fix the incorrect position when HorizontalLine is using RightAxis The following are the specific manifestations before: <img width="475" height="746" alt="image" src="https://github.com/user-attachments/assets/a5662f52-ba47-4746-b216-39d2ce1a2c2a" /> after: <img width="356" height="746" alt="...
9e90e40f3ff7d8167ddce74f1101c128b50ec617
75d04d3db69f5045e237722cdbf2b16627254c5a
diff --git a/CHANGELOG.md b/CHANGELOG.md index 3784fe291d..808c920ec0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -35,6 +35,7 @@ _Not yet on NuGet..._ * Heatmap: Added a `RenderStrategy` property so users can use custom rendering logic (#5035) @bclehmann * Heatmap: Added `Heatmap.RenderStrategies.Rectangles` to i...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5/Plottables/HorizontalLine.cs" ]
[]
true
ScottPlot/ScottPlot
5,033
issue_to_patch
SignalSourceBase: GetLimitsX and GetLimitsY return min-min and not min-max. Is this intended? **Question:** Is this a copy and paste error or intended? It looks wrong to me: ``` public CoordinateRange GetLimitsX() { CoordinateRect rect = GetLimits().Rect; return new CoordinateRange(rect.Left, rect.Left); } pu...
SignalSourceBase: Fixed GetLimitsX and GetLimitsY (#4868)
reslove #4868 Fixed the following code: https://github.com/ScottPlot/ScottPlot/blob/3de647566c6e626c2fd5b0f0eea6309a3f78edcb/src/ScottPlot5/ScottPlot5/DataSources/SignalSourceBase.cs#L45-L55
bfd69c2eaea0cc788d0360641c884f44b2e5706a
ddc67cbdb21ea40388f6abdc9d8273683e3bd281
diff --git a/CHANGELOG.md b/CHANGELOG.md index d7a306cedf..73d61fb62d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -31,6 +31,7 @@ _Not yet on NuGet..._ * Legend: Respect marker size when a default marker shape is used (#5006, #5031) @manaruto @aespitia * Legend: Improve appearance of large markers in legends (#49...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5/DataSources/SignalSourceBase.cs" ]
[]
true
ScottPlot/ScottPlot
5,013
issue_to_patch
Fonts: Extend styling options (weight, slant, density, etc.)
This is a branch from #4873, where @Christoph-Wagner added support for more specialized fonts. Historically, the font resolver would only default to "Normal" or "Regular" width fonts, and would not appropriately find Condensed and other font widths. This PR updates that PR with some notes/feedback from @swharden in or...
972ccab300d0faa793f7b8b1ce59dfb665fcf360
d25830edad1d6f6297e3c6a2b5f82681120a29eb
diff --git a/CHANGELOG.md b/CHANGELOG.md index 3270dddd27..b97a0d7893 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ _Not yet on NuGet..._ * Drawing: Add `FillPath()` and `FillCircle()` and deprecate draw overloads that accept a `FillStyle` (#4987) @CoderPM2011 * GitHub: Create a `devconainer.json` fi...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Cookbook/Recipes/General/Styling.cs", "src/ScottPlot5/ScottPlot5/DataSourceUtilities.cs", "src/ScottPlot5/ScottPlot5/FontExtensions.cs", "src/ScottPlot5/ScottPlot5/FontResolvers/FileFontResolver.cs", "src/ScottPlot5/ScottPlot5/FontResolvers/SystemFontResolver.cs"...
[]
true
ScottPlot/ScottPlot
5,048
issue_to_patch
Fix: Fonts, Legend Markers, and Radar Rotation Direction
Quick PR to get things ready to publish packages soon: * Add option to reset fonts https://github.com/ScottPlot/ScottPlot/pull/5013#issuecomment-3194643993 * Minimize untended behavior changes for legend markers https://github.com/ScottPlot/ScottPlot/pull/5006 * Radar: use new polar plot rotation and clockwise featu...
a69387cb4fcfa5be240658f5b5b09a7e8419451d
bc098aea277cd4f6a0f45c643ae1ac9e8991ae12
diff --git a/CHANGELOG.md b/CHANGELOG.md index a5ba5a576a..73fe51038e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,6 +27,7 @@ _Not yet on NuGet..._ * Angle: Added `Inverted` property and support for `Angle` comparison using equality operators * Polar Axis: Added a `Clockwise` property to support clockwise and ...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Cookbook/RecipeBase.cs", "src/ScottPlot5/ScottPlot5 Cookbook/Recipes/General/Legend.cs", "src/ScottPlot5/ScottPlot5 Cookbook/Recipes/PlotTypes/Radar.cs", "src/ScottPlot5/ScottPlot5/Fonts.cs", "src/ScottPlot5/ScottPlot5/Plottables/Radar.cs", "src/ScottPlot5/Scot...
[]
true
SecWiki/windows-kernel-exploits
23
issue_to_patch
Update README.md
b8a46b8363b5d6f853ea9215ffe88069c2fb4b9c
056034a6636fafaa6af71519b31c4f7481892679
diff --git a/README.md b/README.md index 8f2069d..0c66a99 100644 --- a/README.md +++ b/README.md @@ -8,6 +8,7 @@ windows-kernel-exploits #### 漏洞列表 ##### #Security Bulletin&nbsp;&nbsp;&nbsp;#KB &nbsp;&nbsp;&nbsp;&nbsp;#Description&nbsp;&nbsp;&nbsp;&nbsp;#Operating System   +- [CVE-2019-1458](https://github.com/uname...
[ "README.md" ]
[]
true
SecWiki/windows-kernel-exploits
21
issue_to_patch
Add CVE-2019-0803
7c9a724ffcee92f48384eb1662d9bc587d3630dc
ad840c48d0982da9e84968e668b88f186db0c332
diff --git a/README.md b/README.md index 775fe2c..8f2069d 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ windows-kernel-exploits #### 漏洞列表 ##### #Security Bulletin&nbsp;&nbsp;&nbsp;#KB &nbsp;&nbsp;&nbsp;&nbsp;#Description&nbsp;&nbsp;&nbsp;&nbsp;#Operating System   - +- [CVE-2019-0803](https://github.com/Exp...
[ "README.md" ]
[]
true
SecWiki/windows-kernel-exploits
19
issue_to_patch
add CVE-2018-8639
1f872b8b32fbbc59adf828956e67c53462f52b71
3f03681aac002b2d3420bbc7ee865388c1a993b1
diff --git a/README.md b/README.md index 0a63c1c..775fe2c 100644 --- a/README.md +++ b/README.md @@ -8,6 +8,8 @@ windows-kernel-exploits #### 漏洞列表 ##### #Security Bulletin&nbsp;&nbsp;&nbsp;#KB &nbsp;&nbsp;&nbsp;&nbsp;#Description&nbsp;&nbsp;&nbsp;&nbsp;#Operating System   + +- [CVE-2018-8639](https://github.com/ze0...
[ "README.md" ]
[]
true
SecWiki/windows-kernel-exploits
18
issue_to_patch
Update README.md
add CVE-2018-1038
0c277a583ae29198614fbbc9274b299fbe92ada6
4b849492ed38b734e606d7e271cd113f631ecb29
diff --git a/README.md b/README.md index 9e94057..0a63c1c 100644 --- a/README.md +++ b/README.md @@ -8,9 +8,9 @@ windows-kernel-exploits #### 漏洞列表 ##### #Security Bulletin&nbsp;&nbsp;&nbsp;#KB &nbsp;&nbsp;&nbsp;&nbsp;#Description&nbsp;&nbsp;&nbsp;&nbsp;#Operating System   - +- [CVE-2018-1038](https://gist.github.co...
[ "README.md" ]
[]
true
SecWiki/windows-kernel-exploits
17
issue_to_patch
delete duplicate cve and add new
delete duplicate cve and add new
c684b51731a11e5e4d1e3c682e818675f50b8b19
d5884726ebea5a0a1b3215df402f7c7b4be9bbdc
diff --git a/CVE-2018-8453/4.mp4 b/CVE-2018-8453/4.mp4 deleted file mode 100644 index 68a9de1..0000000 Binary files a/CVE-2018-8453/4.mp4 and /dev/null differ diff --git a/CVE-2018-8453/README.md b/CVE-2018-8453/README.md deleted file mode 100644 index 5e04340..0000000 --- a/CVE-2018-8453/README.md +++ /dev/null @@ -1,...
[ "CVE-2018-8453/4.mp4", "CVE-2018-8453/README.md", "CVE-2018-8453/exp-x86_pool_fengshui/1.jpg", "CVE-2018-8453/exp-x86_pool_fengshui/2.jpg", "CVE-2018-8453/exp-x86_pool_fengshui/3.jpg", "CVE-2018-8453/exp-x86_pool_fengshui/4.mp4", "CVE-2018-8453/exp-x86_pool_fengshui/README.md", "CVE-2018-8453/exp-x86_...
[]
true
SecWiki/windows-kernel-exploits
16
issue_to_patch
Update README.md
增加MS17-010链接
cedc837aaf2e0efd002395bee95e3b86fb5ee743
7abf96f5e1877a861a8c32d064655ece0aaacee1
diff --git a/MS17-010/README.md b/MS17-010/README.md index 78088ab..aacdf42 100644 --- a/MS17-010/README.md +++ b/MS17-010/README.md @@ -21,3 +21,5 @@ msf exploit(ms17_010_eternalblue) > run ## References * [Windows2012上如何通过攻击ETERNALBLUE获得Meterpreter反弹](https://mp.weixin.qq.com/s?__biz=MzI5MzY2MzM0Mw%3D%3D&mid=224748...
[ "MS17-010/README.md" ]
[]
true
SecWiki/windows-kernel-exploits
15
issue_to_patch
增加 CVE-2018-8440 CVE-2018-8453 链接
790cfe761e2c928081bfbe33c8d37f40a2ae22d7
0129db7dd8d5d584bc967b35793c0730f6bc5d9f
diff --git a/README.md b/README.md index 8b9317d..57ea568 100644 --- a/README.md +++ b/README.md @@ -8,6 +8,9 @@ windows-kernel-exploits #### 漏洞列表 ##### #Security Bulletin&nbsp;&nbsp;&nbsp;#KB &nbsp;&nbsp;&nbsp;&nbsp;#Description&nbsp;&nbsp;&nbsp;&nbsp;#Operating System   + +- [CVE-2018-8453](https://github.com/ze0...
[ "README.md" ]
[]
true
SecWiki/windows-kernel-exploits
14
issue_to_patch
add CVE-2018-8453
a4e729a93aa38deb23eb17bfabcc7efd83757a4a
8c3b8e2404a9b41ccafa860e21cafff76dd98753
diff --git a/CVE-2018-8453/4.mp4 b/CVE-2018-8453/4.mp4 new file mode 100644 index 0000000..68a9de1 Binary files /dev/null and b/CVE-2018-8453/4.mp4 differ diff --git a/CVE-2018-8453/README.md b/CVE-2018-8453/README.md new file mode 100644 index 0000000..5e04340 --- /dev/null +++ b/CVE-2018-8453/README.md @@ -0,0 +1,14 ...
[ "CVE-2018-8453/4.mp4", "CVE-2018-8453/README.md", "CVE-2018-8453/exp-x86_pool_fengshui/1.jpg", "CVE-2018-8453/exp-x86_pool_fengshui/2.jpg", "CVE-2018-8453/exp-x86_pool_fengshui/3.jpg", "CVE-2018-8453/exp-x86_pool_fengshui/4.mp4", "CVE-2018-8453/exp-x86_pool_fengshui/README.md", "CVE-2018-8453/exp-x86_...
[]
true
SecWiki/windows-kernel-exploits
13
issue_to_patch
增加一个源代码reference
fa9a781ad78ee135334db6a57b85041a4b7c3d56
0276237fb3c51dca2844aa3e80efcc8257184243
diff --git a/CVE-2018-8120/README.md b/CVE-2018-8120/README.md index 51880f7..c56cd60 100644 --- a/CVE-2018-8120/README.md +++ b/CVE-2018-8120/README.md @@ -16,5 +16,6 @@ An elevation of privilege vulnerability exists in Windows when the Win32k compon ## Vulnerability reference +* [https://github.com/bigric3/cve-2...
[ "CVE-2018-8120/README.md" ]
[]
true
SecWiki/windows-kernel-exploits
7
issue_to_patch
补充 MS08-066 KB补丁号
3401bbd311d957fc98b1fa611711699b214cd867
3d64295082a4fec653e38509c7a020ef605b089b
diff --git a/README.md b/README.md index c49021f..66c3947 100644 --- a/README.md +++ b/README.md @@ -53,7 +53,7 @@ windows-kernel-exploits - [MS09-012](./MS09-012)  [KB959454]   [Chimichurri]  (Vista/win7/2008/Vista) - [MS08-068](./MS08-068)  [KB957097]   [Remote Code Execution]  (2000/XP) - [MS08-067](./MS08-06...
[ "README.md" ]
[]
true
Seldaek/monolog
2,040
issue_to_patch
Add file rotation by hour (FILE_PER_HOUR)
Rebased version of #2001 with the date-format validation regex fixed so month-only formats (FILE_PER_MONTH etc.) still validate, plus test coverage for the new FILE_PER_HOUR mode.
f3d2d3a3f51df9aac659af11b581c428c6a350e9
f50fa379ea203de5f1d1025ece1efb5cd003fce6
diff --git a/src/Monolog/Handler/RotatingFileHandler.php b/src/Monolog/Handler/RotatingFileHandler.php index 13915a9d3..ccc6c6837 100644 --- a/src/Monolog/Handler/RotatingFileHandler.php +++ b/src/Monolog/Handler/RotatingFileHandler.php @@ -28,6 +28,7 @@ */ class RotatingFileHandler extends StreamHandler { + pub...
[ "src/Monolog/Handler/RotatingFileHandler.php", "tests/Monolog/Handler/RotatingFileHandlerTest.php" ]
[]
diff --git a/tests/Monolog/Handler/RotatingFileHandlerTest.php b/tests/Monolog/Handler/RotatingFileHandlerTest.php index ae30f5cb8..2a737cdf6 100644 --- a/tests/Monolog/Handler/RotatingFileHandlerTest.php +++ b/tests/Monolog/Handler/RotatingFileHandlerTest.php @@ -139,6 +139,9 @@ public function testRotation($createFil...
true
Seldaek/monolog
2,016
issue_to_patch
StreamHandler doesn't handle non-blocking streams properly, truncating logs When writing large logs to a non-blocking stream, logs are often truncated. The exact length of the line that is actually written varies between calls. Here's a snippet that attempts to write around 1M characters to a non-blocking stream: ``...
Fix StreamHandler truncating writes on non-blocking streamsFix partial writes on non-blocking streams
Fixes partial log writes when using non-blocking streams by looping on `fwrite()` until the full record is written. Includes a regression test reproducing the issue. Fixes #2011
dd461a161be1be4fcf6ebde03b6686fbc48f1dfa
1fd7f693a38c1489fbbf853967555aa03f9ea721
diff --git a/src/Monolog/Handler/StreamHandler.php b/src/Monolog/Handler/StreamHandler.php index 6254944b7..2776cbf01 100644 --- a/src/Monolog/Handler/StreamHandler.php +++ b/src/Monolog/Handler/StreamHandler.php @@ -215,7 +215,26 @@ protected function write(LogRecord $record): void */ protected function str...
[ "src/Monolog/Handler/StreamHandler.php", "tests/Monolog/Handler/StreamHandlerTest.php" ]
[]
diff --git a/tests/Monolog/Handler/StreamHandlerTest.php b/tests/Monolog/Handler/StreamHandlerTest.php index bc47e8ed4..2f0c23bc3 100644 --- a/tests/Monolog/Handler/StreamHandlerTest.php +++ b/tests/Monolog/Handler/StreamHandlerTest.php @@ -377,4 +377,53 @@ public function testReopensFileIfInodeChanges() $data...
true
Seldaek/monolog
2,029
issue_to_patch
Add extension hooks to TelegramBotHandler for URL and curl headers
# Add extension hooks to `TelegramBotHandler` for API URL and curl headers ## Problem `TelegramBotHandler` used a `private const BOT_API` and hardcoded `self::BOT_API` directly inside `sendCurl()`, making it impossible to: - point the handler at a self-hosted Telegram Bot API server - inject custom HTTP headers...
68b974809baff3f071893de61447212e9e688ee7
9fa2a09df01eedf3b80e53d5eb61cc7edb3a24ed
diff --git a/src/Monolog/Handler/TelegramBotHandler.php b/src/Monolog/Handler/TelegramBotHandler.php index e6b23bc48..09318da83 100644 --- a/src/Monolog/Handler/TelegramBotHandler.php +++ b/src/Monolog/Handler/TelegramBotHandler.php @@ -251,17 +251,41 @@ protected function send(string $message): void } } ...
[ "src/Monolog/Handler/TelegramBotHandler.php" ]
[ { "comment": "I think this should be changed to:\r\n```php\r\n$url = $this->botApiUrl() . $this->apiKey . '/SendMessage';\r\n```", "path": "src/Monolog/Handler/TelegramBotHandler.php", "hunk": "@@ -251,17 +251,41 @@ protected function send(string $message): void\n }\n }\n \n+ /**\n+ *...
true
Seldaek/monolog
2,029
comment_to_fix
Add extension hooks to TelegramBotHandler for URL and curl headers
I think this should be changed to: ```php $url = $this->botApiUrl() . $this->apiKey . '/SendMessage'; ```
68b974809baff3f071893de61447212e9e688ee7
9fa2a09df01eedf3b80e53d5eb61cc7edb3a24ed
diff --git a/src/Monolog/Handler/TelegramBotHandler.php b/src/Monolog/Handler/TelegramBotHandler.php index e6b23bc48..09318da83 100644 --- a/src/Monolog/Handler/TelegramBotHandler.php +++ b/src/Monolog/Handler/TelegramBotHandler.php @@ -251,17 +251,41 @@ protected function send(string $message): void } } ...
[ "src/Monolog/Handler/TelegramBotHandler.php" ]
[ { "comment": "I think this should be changed to:\r\n```php\r\n$url = $this->botApiUrl() . $this->apiKey . '/SendMessage';\r\n```", "path": "src/Monolog/Handler/TelegramBotHandler.php", "hunk": "@@ -251,17 +251,41 @@ protected function send(string $message): void\n }\n }\n \n+ /**\n+ *...
true
Seldaek/monolog
2,029
comment_to_fix
Add extension hooks to TelegramBotHandler for URL and curl headers
```suggestion protected function getBotApiUrl(): string ```
68b974809baff3f071893de61447212e9e688ee7
9fa2a09df01eedf3b80e53d5eb61cc7edb3a24ed
diff --git a/src/Monolog/Handler/TelegramBotHandler.php b/src/Monolog/Handler/TelegramBotHandler.php index e6b23bc48..09318da83 100644 --- a/src/Monolog/Handler/TelegramBotHandler.php +++ b/src/Monolog/Handler/TelegramBotHandler.php @@ -251,17 +251,41 @@ protected function send(string $message): void } } ...
[ "src/Monolog/Handler/TelegramBotHandler.php" ]
[ { "comment": "```suggestion\n protected function getBotApiUrl(): string\n```", "path": "src/Monolog/Handler/TelegramBotHandler.php", "hunk": "@@ -251,17 +251,41 @@ protected function send(string $message): void\n }\n }\n \n+ /**\n+ * Returns the Telegram Bot API base URL.\n+ * ...
true
Seldaek/monolog
2,029
comment_to_fix
Add extension hooks to TelegramBotHandler for URL and curl headers
```suggestion $url = $this->getBotApiUrl() . $this->apiKey . '/SendMessage'; ```
68b974809baff3f071893de61447212e9e688ee7
9fa2a09df01eedf3b80e53d5eb61cc7edb3a24ed
diff --git a/src/Monolog/Handler/TelegramBotHandler.php b/src/Monolog/Handler/TelegramBotHandler.php index e6b23bc48..09318da83 100644 --- a/src/Monolog/Handler/TelegramBotHandler.php +++ b/src/Monolog/Handler/TelegramBotHandler.php @@ -251,17 +251,41 @@ protected function send(string $message): void } } ...
[ "src/Monolog/Handler/TelegramBotHandler.php" ]
[ { "comment": "```suggestion\n $url = $this->getBotApiUrl() . $this->apiKey . '/SendMessage';\n```", "path": "src/Monolog/Handler/TelegramBotHandler.php", "hunk": "@@ -251,17 +251,41 @@ protected function send(string $message): void\n }\n }\n \n+ /**\n+ * Returns the Telegram Bo...
true
Seldaek/monolog
2,030
issue_to_patch
TelegramBotHandler: silent failure when API returns non-JSON response ## Summary `TelegramBotHandler::sendCurl()` silently swallows errors when the Telegram API (or an intermediary proxy) returns a non-JSON response. The handler returns as if the message was sent successfully, with no exception and no indication of f...
Fix TelegramBotHandler swallowing errors on non-JSON responses (#2026)
Fixes #2026 ## What it solves `TelegramBotHandler::sendCurl()` was silently swallowing errors whenever the Telegram API or an upstream proxy returned a non-JSON body (Cloudflare 502 pages, Nginx error pages, truncated responses, etc.). `json_decode()` returned `null`, the guard `$result['ok'] === false` evaluated...
68b974809baff3f071893de61447212e9e688ee7
77f467cf7a30e78bf8e3d27add034500c9dfbc60
diff --git a/src/Monolog/Handler/TelegramBotHandler.php b/src/Monolog/Handler/TelegramBotHandler.php index e6b23bc48..37c78c1f8 100644 --- a/src/Monolog/Handler/TelegramBotHandler.php +++ b/src/Monolog/Handler/TelegramBotHandler.php @@ -256,7 +256,7 @@ protected function sendCurl(string $message): void if ('' ...
[ "src/Monolog/Handler/TelegramBotHandler.php", "tests/Monolog/Handler/TelegramBotHandlerTest.php" ]
[]
diff --git a/tests/Monolog/Handler/TelegramBotHandlerTest.php b/tests/Monolog/Handler/TelegramBotHandlerTest.php index ef0f79694..2cbf7684c 100644 --- a/tests/Monolog/Handler/TelegramBotHandlerTest.php +++ b/tests/Monolog/Handler/TelegramBotHandlerTest.php @@ -12,6 +12,7 @@ namespace Monolog\Handler; use Monolog\Le...
true
Seldaek/monolog
2,031
issue_to_patch
Fix AbstractProcessingHandler::handle() to call getBubble() instead of $this->bubble
## Summary - `AbstractProcessingHandler::handle()` was reading the protected `$bubble` property directly (`false === $this->bubble`) rather than calling `getBubble()` - This means subclasses that override `getBubble()` to dynamically control bubbling behaviour are silently bypassed - Fix: replace with `!$this->get...
68b974809baff3f071893de61447212e9e688ee7
f1f0582dbae2173a8c5b120f6589f3ca786bda12
diff --git a/src/Monolog/Handler/AbstractProcessingHandler.php b/src/Monolog/Handler/AbstractProcessingHandler.php index de13a76be..78bec3e6a 100644 --- a/src/Monolog/Handler/AbstractProcessingHandler.php +++ b/src/Monolog/Handler/AbstractProcessingHandler.php @@ -43,7 +43,7 @@ public function handle(LogRecord $record)...
[ "src/Monolog/Handler/AbstractProcessingHandler.php", "tests/Monolog/Handler/AbstractProcessingHandlerTest.php" ]
[]
diff --git a/tests/Monolog/Handler/AbstractProcessingHandlerTest.php b/tests/Monolog/Handler/AbstractProcessingHandlerTest.php index 9d7e29552..14d24c812 100644 --- a/tests/Monolog/Handler/AbstractProcessingHandlerTest.php +++ b/tests/Monolog/Handler/AbstractProcessingHandlerTest.php @@ -12,6 +12,7 @@ namespace Monolo...
true
Seldaek/monolog
2,033
issue_to_patch
Add zizmor security analysis + dependabot cooldown (2.x)
Same as the main-branch PR, applied to `2.x`: adds zizmor (pedantic) + dependabot cooldown and hardens the existing workflows (pinned actions, concurrency, persist-credentials, template-injection fixes). Known follow-up: `elastic/elastic-github-actions/elasticsearch` has no git tags, so zizmor still reports 2 `stale-a...
37308608e599f34a1a4845b16440047ec98a172a
3329492296fd66ccfcc97872f766a4ce318a82ee
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index b3b919c4c..6da3a456c 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -7,6 +7,10 @@ on: permissions: contents: read +concurrency: + group: ...
[ ".github/workflows/continuous-integration.yml", ".github/workflows/lint.yml", ".github/workflows/phpstan.yml", ".github/workflows/zizmor.yml", "tests/Monolog/Handler/ElasticaHandlerTest.php" ]
[]
diff --git a/tests/Monolog/Handler/ElasticaHandlerTest.php b/tests/Monolog/Handler/ElasticaHandlerTest.php index c03fefd09..0f9be7594 100644 --- a/tests/Monolog/Handler/ElasticaHandlerTest.php +++ b/tests/Monolog/Handler/ElasticaHandlerTest.php @@ -16,8 +16,6 @@ use Monolog\Test\TestCase; use Monolog\Logger; use Ela...
true
Seldaek/monolog
2,038
issue_to_patch
Fix Elasticsearch CI: runner JDK for cgroup-v2 startup, Elastica 8 test compat
## Problem The Elasticsearch CI jobs were failing. There were three layered causes, each masked by the previous one. ### 1. Elasticsearch won't start — bundled-JDK cgroup-v2 crash ES's **bundled JDK** crashes at startup on the `ubuntu-latest` runner's cgroup-v2 hierarchy: ``` JvmOptionsParser -> getOperatingSystemM...
7ad8efdf1fd64409122919a29c93da3f629ded72
5a69d04996e76cba7059bfd9c28e016998443036
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index cf4790518..9bf90c90e 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -135,15 +135,21 @@ jobs: env: ES_VERSION: ${{ matrix.es-...
[ ".github/workflows/continuous-integration.yml", "tests/Monolog/Handler/ElasticaHandlerTest.php" ]
[]
diff --git a/tests/Monolog/Handler/ElasticaHandlerTest.php b/tests/Monolog/Handler/ElasticaHandlerTest.php index eac80736d..7c539a5cc 100644 --- a/tests/Monolog/Handler/ElasticaHandlerTest.php +++ b/tests/Monolog/Handler/ElasticaHandlerTest.php @@ -15,8 +15,6 @@ use Monolog\Formatter\NormalizerFormatter; use Monolog\...
true
Seldaek/monolog
2,032
issue_to_patch
Add zizmor security analysis + dependabot cooldown
Adds a `zizmor` GitHub Actions security-analysis workflow (matching `composer/packagist`) and a 7-day `cooldown` on the github-actions dependabot config, and hardens the existing workflows so zizmor (pedantic) passes (actions pinned to commit SHAs, concurrency limits, `persist-credentials: false` on read-only checkouts...
1c92005a66349fa29b140b367bfe2d63d3108e11
54d5802582d7fea4510433df5cb5f090799b17d0
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index fed6dba10..cf4790518 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -10,6 +10,10 @@ permissions: env: COMPOSER_ROOT_VERSION: dev-main +con...
[ ".github/workflows/continuous-integration.yml", ".github/workflows/lint.yml", ".github/workflows/phpstan.yml", ".github/workflows/zizmor.yml" ]
[]
true
Seldaek/monolog
2,022
issue_to_patch
Fix missing timezone support in rotation date calculations
The fix for #1982 is incomplete because the `getNextRotation` method is not aware of the time zone which was set in the constructor. Consider the scenario of daily rotation where the server is set to UTC but the constructor is set to another zone. This results in log entries being recorded unexpectedly to a different d...
6db20ca029219dd8de378cea8e32ee149399ef1b
8e24ccf16d5c42c469806da581f1f274ea463ddb
diff --git a/src/Monolog/Handler/RotatingFileHandler.php b/src/Monolog/Handler/RotatingFileHandler.php index 401c10895..13915a9d3 100644 --- a/src/Monolog/Handler/RotatingFileHandler.php +++ b/src/Monolog/Handler/RotatingFileHandler.php @@ -226,9 +226,9 @@ protected function setDateFormat(string $dateFormat): void ...
[ "src/Monolog/Handler/RotatingFileHandler.php" ]
[]
true
Seldaek/monolog
2,024
issue_to_patch
Bump shivammathur/setup-php from 2.36.0 to 2.37.0
Bumps [shivammathur/setup-php](https://github.com/shivammathur/setup-php) from 2.36.0 to 2.37.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/shivammathur/setup-php/releases">shivammathur/setup-php's releases</a>.</em></p> <blockquote> <h2>2.37.0</h2> <h2>Changelog</h2> <ul...
6db20ca029219dd8de378cea8e32ee149399ef1b
7f2dd6775eae527220855a1990e5cba30760e91a
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 271b3636d..881b36234 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -58,7 +58,7 @@ jobs: with: mongodb-version: 5.0 - ...
[ ".github/workflows/continuous-integration.yml", ".github/workflows/lint.yml", ".github/workflows/phpstan.yml" ]
[]
true
Seldaek/monolog
2,023
issue_to_patch
Bump ramsey/composer-install from 3.1.1 to 4.0.0
Bumps [ramsey/composer-install](https://github.com/ramsey/composer-install) from 3.1.1 to 4.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ramsey/composer-install/releases">ramsey/composer-install's releases</a>.</em></p> <blockquote> <h2>4.0.0</h2> <h2>What's Changed</h...
6db20ca029219dd8de378cea8e32ee149399ef1b
4aeff7e6224e98506a8c85af20962ba0eb4505cc
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 271b3636d..246e6940f 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -73,7 +73,7 @@ jobs: run: | composer require --no-update...
[ ".github/workflows/continuous-integration.yml", ".github/workflows/phpstan.yml" ]
[]
true
Seldaek/monolog
2,020
issue_to_patch
Undefined array key in DeduplicationHandler Monolog version 3.6.0 Getting: Undefined array key 1 on line 117 in file /src/Monolog/Handler/DeduplicationHandler.php Undefined array key 2 on line 117 in file /src/Monolog/Handler/DeduplicationHandler.php It happens when there are too many errors in the deduplication fi...
Fix undefined array key in DeduplicationHandler with concurrent access
## Problem When multiple requests write to the deduplication store file simultaneously, partially written lines can be read by concurrent processes. This causes `Undefined array key 1` and `Undefined array key 2` errors on the `list($timestamp, $level, $message) = explode(':', $store[$i], 3)` line in `isDuplicate()`. ...
cb44e4a2eb355ded395275551d32d63a4ed393f2
259242a71e5759945a5bcd18e5b95c1edc8d6338
diff --git a/src/Monolog/Handler/DeduplicationHandler.php b/src/Monolog/Handler/DeduplicationHandler.php index 2b1d0b867..eaa8860de 100644 --- a/src/Monolog/Handler/DeduplicationHandler.php +++ b/src/Monolog/Handler/DeduplicationHandler.php @@ -82,7 +82,7 @@ public function flush(): void $passthru = $p...
[ "src/Monolog/Handler/DeduplicationHandler.php" ]
[]
true
Seldaek/monolog
2,019
issue_to_patch
Bump actions/checkout from 6.0.1 to 6.0.2
Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.1 to 6.0.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p> <blockquote> <h2>v6.0.2</h2> <h2>What's Changed</h2> <ul> <li>Add orchestrati...
cb44e4a2eb355ded395275551d32d63a4ed393f2
0e52702b170ec4148e9023eda4d6fc7edbbfea3f
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index fe53f8dc6..271b3636d 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -44,7 +44,7 @@ jobs: composer-options: "--ignore-platform-req=p...
[ ".github/workflows/continuous-integration.yml", ".github/workflows/lint.yml", ".github/workflows/phpstan.yml" ]
[]
true
Seldaek/monolog
2,015
issue_to_patch
feat(formatter): add maxTraceLength config option to NormalizerFormatter
Add maxTraceLength property to NormalizerFormatter to limit the number of stack trace frames included when normalizing exceptions. Allows users who need control over their log length to avoid truncating the log and causing invalid json syntax See comment here from about adding this feature https://github.com/Seld...
b321dd6749f0bf7189444158a3ce785cc16d69b0
108867b3552775777dea2c71e014e233147f440f
diff --git a/src/Monolog/Formatter/NormalizerFormatter.php b/src/Monolog/Formatter/NormalizerFormatter.php index 60da29cf7..faea9339d 100644 --- a/src/Monolog/Formatter/NormalizerFormatter.php +++ b/src/Monolog/Formatter/NormalizerFormatter.php @@ -28,6 +28,7 @@ class NormalizerFormatter implements FormatterInterface ...
[ "src/Monolog/Formatter/NormalizerFormatter.php", "tests/Monolog/Formatter/NormalizerFormatterTest.php" ]
[]
diff --git a/tests/Monolog/Formatter/NormalizerFormatterTest.php b/tests/Monolog/Formatter/NormalizerFormatterTest.php index 0395e1c20..482ea657e 100644 --- a/tests/Monolog/Formatter/NormalizerFormatterTest.php +++ b/tests/Monolog/Formatter/NormalizerFormatterTest.php @@ -439,6 +439,102 @@ public function testCanNormal...
true
Seldaek/monolog
2,009
issue_to_patch
Remove deprecated curl_close() usage for PHP 8.5 compatibility
This PR removes calls to `curl_close()`, which is deprecated in PHP 8.5 and has no effect anymore on CurlHandle objects since PHP 8.0. The behavior remains unchanged while preventing deprecation warnings on recent PHP versions. Happy to adjust the patch if needed.
0d529a75d32af31ec6c70b75e13369aa48ae3c3f
69e9abf3867e50eb30a05db065d91b587d2733d0
diff --git a/src/Monolog/Handler/Curl/Util.php b/src/Monolog/Handler/Curl/Util.php index 6d78cb154..2ef58877d 100644 --- a/src/Monolog/Handler/Curl/Util.php +++ b/src/Monolog/Handler/Curl/Util.php @@ -37,7 +37,7 @@ final class Util * @param CurlHandle $ch curl handler * @return bool|string @see curl_exec ...
[ "src/Monolog/Handler/Curl/Util.php", "src/Monolog/Handler/LogglyHandler.php" ]
[]
true
Seldaek/monolog
2,014
issue_to_patch
Bump actions/checkout from 6.0.0 to 6.0.1
Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.0 to 6.0.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p> <blockquote> <h2>v6.0.1</h2> <h2>What's Changed</h2> <ul> <li>Update all refe...
edf9cb618bd437196ea9ce91fafbf9576df784ce
cf508ada39d8b6bcac3c06320eb1c2db41a011ec
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 99b4d5766..fe53f8dc6 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -44,7 +44,7 @@ jobs: composer-options: "--ignore-platform-req=p...
[ ".github/workflows/continuous-integration.yml", ".github/workflows/lint.yml", ".github/workflows/phpstan.yml" ]
[]
true
Seldaek/monolog
2,013
issue_to_patch
Add NoDiscard attr, fixes #2012
cc @jaugustin
5991e41f28273cd23e531393f26e0b6069a08aba
32792591e060e9aaeb4cffbb3fa5354a229d6154
diff --git a/src/Monolog/Handler/TestHandler.php b/src/Monolog/Handler/TestHandler.php index eb5fb445c..cb95e79c0 100644 --- a/src/Monolog/Handler/TestHandler.php +++ b/src/Monolog/Handler/TestHandler.php @@ -15,6 +15,7 @@ use Monolog\Logger; use Psr\Log\LogLevel; use Monolog\LogRecord; +use NoDiscard; /** * Us...
[ "src/Monolog/Handler/TestHandler.php" ]
[]
true
Seldaek/monolog
1,971
issue_to_patch
Bump ramsey/composer-install from 3.1.0 to 3.1.1
Bumps [ramsey/composer-install](https://github.com/ramsey/composer-install) from 3.1.0 to 3.1.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ramsey/composer-install/releases">ramsey/composer-install's releases</a>.</em></p> <blockquote> <h2>3.1.1</h2> <h2>What's Changed</h...
05c6b188963c47b961d75a071c34e00a4b05c023
ee37828f7e4acf397dc2a1d263370278bc163b6a
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 77a7218e5..99b4d5766 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -73,7 +73,7 @@ jobs: run: | composer require --no-update...
[ ".github/workflows/continuous-integration.yml", ".github/workflows/phpstan.yml" ]
[]
true
Seldaek/monolog
1,968
issue_to_patch
JsonFormatter crashes when stringable object has an error Monolog version 3? When using JsonFormatter with a stringable object, if the toString() method throws an exception the whole normalization process crashes. We should not throw an exception while trying to log something.
Fix json formatter does not catch to string exceptions
JsonFormatter threw an exception when $object->toString() failed. I changed it to return the class of the object instead of the string representation if it was the case Closes https://github.com/Seldaek/monolog/issues/1969
2e97231b969e0ffdeff03329b808945b4ba55e38
492fd3093d8d44ce54882df30027c0edc3982cab
diff --git a/src/Monolog/Formatter/JsonFormatter.php b/src/Monolog/Formatter/JsonFormatter.php index b59639e17..fa11d0ef0 100644 --- a/src/Monolog/Formatter/JsonFormatter.php +++ b/src/Monolog/Formatter/JsonFormatter.php @@ -195,7 +195,11 @@ protected function normalize(mixed $data, int $depth = 0): mixed ...
[ "src/Monolog/Formatter/JsonFormatter.php", "tests/Monolog/Formatter/JsonFormatterTest.php" ]
[]
diff --git a/tests/Monolog/Formatter/JsonFormatterTest.php b/tests/Monolog/Formatter/JsonFormatterTest.php index 56cef2287..271881f06 100644 --- a/tests/Monolog/Formatter/JsonFormatterTest.php +++ b/tests/Monolog/Formatter/JsonFormatterTest.php @@ -11,6 +11,7 @@ namespace Monolog\Formatter; +use Exception; use Mo...
true
Seldaek/monolog
2,008
issue_to_patch
Bump supercharge/mongodb-github-action from 1.12.0 to 1.12.1
Bumps [supercharge/mongodb-github-action](https://github.com/supercharge/mongodb-github-action) from 1.12.0 to 1.12.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/supercharge/mongodb-github-action/releases">supercharge/mongodb-github-action's releases</a>.</em></p> <blockq...
0d529a75d32af31ec6c70b75e13369aa48ae3c3f
8912e0b786fc7735aa1687de94b4ff8c873013c7
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 0b67f88d2..145adc170 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -54,7 +54,7 @@ jobs: couchdb version: '2.3.1' - name: Ru...
[ ".github/workflows/continuous-integration.yml" ]
[]
true
Seldaek/monolog
2,007
issue_to_patch
Bump shivammathur/setup-php from 2.35.5 to 2.36.0
[//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [shivammathur/setup-php](https://gith...
0d529a75d32af31ec6c70b75e13369aa48ae3c3f
54ad31d6d944358cfe8bfe6dc3824fdabae051c3
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 0b67f88d2..4273ae9fb 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -58,7 +58,7 @@ jobs: with: mongodb-version: 5.0 - ...
[ ".github/workflows/continuous-integration.yml", ".github/workflows/lint.yml", ".github/workflows/phpstan.yml" ]
[]
true
Seldaek/monolog
2,006
issue_to_patch
Bump actions/checkout from 5.0.0 to 6.0.0
Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.0 to 6.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p> <blockquote> <h2>v6.0.0</h2> <h2>What's Changed</h2> <ul> <li>Update README t...
0d529a75d32af31ec6c70b75e13369aa48ae3c3f
d2ecbf680ec0fc8b4a359c92c1320cf09f196036
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 0b67f88d2..db3ce5870 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -44,7 +44,7 @@ jobs: composer-options: "--ignore-platform-req=p...
[ ".github/workflows/continuous-integration.yml", ".github/workflows/lint.yml", ".github/workflows/phpstan.yml" ]
[]
true
Seldaek/monolog
1,906
issue_to_patch
Normalize call normalizeRecord if necessary
Monolog version 3 Hello, When you format a logRecord with JsonFormater::format(), it calls: - NormalizeFormatter::format() - NormalizeFormatter::normalizeRecord() As a result, we get a nicely formatted record, including any exception data, if present. However, when we try to format an array of records ...
7af6f41cff2e7d74e3b77be8c0fa05f837dee0df
fd9abb80be06d62e6e4ffab4cb6ddb802b259684
diff --git a/src/Monolog/Formatter/JsonFormatter.php b/src/Monolog/Formatter/JsonFormatter.php index 238039f4e..35bcc1679 100644 --- a/src/Monolog/Formatter/JsonFormatter.php +++ b/src/Monolog/Formatter/JsonFormatter.php @@ -74,22 +74,7 @@ public function isAppendingNewlines(): bool */ public function format...
[ "src/Monolog/Formatter/JsonFormatter.php", "tests/Monolog/Formatter/JsonFormatterTest.php" ]
[]
diff --git a/tests/Monolog/Formatter/JsonFormatterTest.php b/tests/Monolog/Formatter/JsonFormatterTest.php index 9ce91c696..3e1cee28c 100644 --- a/tests/Monolog/Formatter/JsonFormatterTest.php +++ b/tests/Monolog/Formatter/JsonFormatterTest.php @@ -89,7 +89,8 @@ public function testFormatBatch() $this->get...
true
Seldaek/monolog
1,982
issue_to_patch
Rotate files based on timezone
Currently, file rotation is based on default timezone. The aim of this PR is to provide a way to force the timezone and thus, name the files based on a given timezone. This fix was done from 3.9.0 in case you would like to release a 3.9.1. It can be merged in `main` without conflict.
2e97231b969e0ffdeff03329b808945b4ba55e38
b18bf5225292af81cc7883d9cbd9819e517b3ba5
diff --git a/src/Monolog/Handler/RotatingFileHandler.php b/src/Monolog/Handler/RotatingFileHandler.php index f3e04557d..fe54f8a96 100644 --- a/src/Monolog/Handler/RotatingFileHandler.php +++ b/src/Monolog/Handler/RotatingFileHandler.php @@ -11,6 +11,7 @@ namespace Monolog\Handler; +use DateTimeZone; use InvalidAr...
[ "src/Monolog/Handler/RotatingFileHandler.php" ]
[]
true
Seldaek/monolog
1,998
issue_to_patch
Replace deprecated code in MongoDB classes and allow 2.0+
https://jira.mongodb.org/browse/PHPORM-398 This removes some deprecated code related to the MongoDB extension and library. Since Monolog requires PHP 8.1, I'm assuming it's kosher to also rely on mongodb/mongodb 1.21+ (same platform requirement).
2e97231b969e0ffdeff03329b808945b4ba55e38
f803103d48969a37bfd71162cfb789b72ffb18d6
diff --git a/composer.json b/composer.json index 9574a1b0d..b0fb2d7a5 100644 --- a/composer.json +++ b/composer.json @@ -24,7 +24,7 @@ "graylog2/gelf-php": "^1.4.2 || ^2.0", "guzzlehttp/guzzle": "^7.4.5", "guzzlehttp/psr7": "^2.2", - "mongodb/mongodb": "^1.8", + "mongodb/mongodb...
[ "composer.json", "src/Monolog/Formatter/MongoDBFormatter.php", "src/Monolog/Handler/MongoDBHandler.php", "tests/Monolog/Formatter/MongoDBFormatterTest.php", "tests/Monolog/Handler/MongoDBHandlerTest.php" ]
[ { "comment": "Extra parenthesis not necessary.\n```suggestion\n if (!class_exists(Client::class)) {\n```", "path": "tests/Monolog/Handler/MongoDBHandlerTest.php", "hunk": "@@ -27,20 +29,20 @@ public function testConstructorShouldThrowExceptionForInvalidMongo()\n \n public function testHandleW...
diff --git a/tests/Monolog/Formatter/MongoDBFormatterTest.php b/tests/Monolog/Formatter/MongoDBFormatterTest.php index 08f1de19b..6faf22f18 100644 --- a/tests/Monolog/Formatter/MongoDBFormatterTest.php +++ b/tests/Monolog/Formatter/MongoDBFormatterTest.php @@ -16,19 +16,14 @@ use MongoDB\BSON\UTCDateTime; use Monolog...
true
Seldaek/monolog
1,998
comment_to_fix
Replace deprecated code in MongoDB classes and allow 2.0+
Extra parenthesis not necessary. ```suggestion if (!class_exists(Client::class)) { ```
2e97231b969e0ffdeff03329b808945b4ba55e38
f803103d48969a37bfd71162cfb789b72ffb18d6
diff --git a/tests/Monolog/Handler/MongoDBHandlerTest.php b/tests/Monolog/Handler/MongoDBHandlerTest.php index 4c3483995..66f9c5a47 100644 --- a/tests/Monolog/Handler/MongoDBHandlerTest.php +++ b/tests/Monolog/Handler/MongoDBHandlerTest.php @@ -11,11 +11,13 @@ namespace Monolog\Handler; +use MongoDB\BSON\UTCDateTi...
[ "tests/Monolog/Handler/MongoDBHandlerTest.php" ]
[ { "comment": "Extra parenthesis not necessary.\n```suggestion\n if (!class_exists(Client::class)) {\n```", "path": "tests/Monolog/Handler/MongoDBHandlerTest.php", "hunk": "@@ -27,20 +29,20 @@ public function testConstructorShouldThrowExceptionForInvalidMongo()\n \n public function testHandleW...
true
Seldaek/monolog
1,998
comment_to_fix
Replace deprecated code in MongoDB classes and allow 2.0+
Should you add a conflict rule with `mongodb/mongodb < 1.21` or `ext-mongodb < 1.21`?
2e97231b969e0ffdeff03329b808945b4ba55e38
f803103d48969a37bfd71162cfb789b72ffb18d6
diff --git a/composer.json b/composer.json index 9574a1b0d..b0fb2d7a5 100644 --- a/composer.json +++ b/composer.json @@ -24,7 +24,7 @@ "graylog2/gelf-php": "^1.4.2 || ^2.0", "guzzlehttp/guzzle": "^7.4.5", "guzzlehttp/psr7": "^2.2", - "mongodb/mongodb": "^1.8", + "mongodb/mongodb...
[ "composer.json" ]
[ { "comment": "Should you add a conflict rule with `mongodb/mongodb < 1.21` or `ext-mongodb < 1.21`?", "path": "composer.json", "hunk": "", "resolving_sha": "f803103d48969a37bfd71162cfb789b72ffb18d6", "resolving_diff": "diff --git a/composer.json b/composer.json\nindex 9574a1b0d..b0fb2d7a5 100644...
true
Seldaek/monolog
1,998
comment_to_fix
Replace deprecated code in MongoDB classes and allow 2.0+
The conditional call is the best solution. ```suggestion $this->collection = $mongodb->(method_exists($mongodb, 'getCollection') ? 'getCollection' : 'selectCollection')($database, $collection); ```
2e97231b969e0ffdeff03329b808945b4ba55e38
f803103d48969a37bfd71162cfb789b72ffb18d6
diff --git a/src/Monolog/Handler/MongoDBHandler.php b/src/Monolog/Handler/MongoDBHandler.php index 33ab68c6d..3a1c085b7 100644 --- a/src/Monolog/Handler/MongoDBHandler.php +++ b/src/Monolog/Handler/MongoDBHandler.php @@ -11,9 +11,10 @@ namespace Monolog\Handler; +use MongoDB\Client; +use MongoDB\Collection; use M...
[ "src/Monolog/Handler/MongoDBHandler.php" ]
[ { "comment": "The conditional call is the best solution.\n```suggestion\n $this->collection = $mongodb->(method_exists($mongodb, 'getCollection') ? 'getCollection' : 'selectCollection')($database, $collection);\n```", "path": "src/Monolog/Handler/MongoDBHandler.php", "hunk": "@@ -50,7 +51,7 @...
true
Seldaek/monolog
1,998
comment_to_fix
Replace deprecated code in MongoDB classes and allow 2.0+
The change can be reverted since you added the conditional method name.
2e97231b969e0ffdeff03329b808945b4ba55e38
f803103d48969a37bfd71162cfb789b72ffb18d6
diff --git a/composer.json b/composer.json index 9574a1b0d..b0fb2d7a5 100644 --- a/composer.json +++ b/composer.json @@ -24,7 +24,7 @@ "graylog2/gelf-php": "^1.4.2 || ^2.0", "guzzlehttp/guzzle": "^7.4.5", "guzzlehttp/psr7": "^2.2", - "mongodb/mongodb": "^1.8", + "mongodb/mongodb...
[ "composer.json" ]
[ { "comment": "The change can be reverted since you added the conditional method name.", "path": "composer.json", "hunk": "@@ -24,7 +24,7 @@\n \"graylog2/gelf-php\": \"^1.4.2 || ^2.0\",\n \"guzzlehttp/guzzle\": \"^7.4.5\",\n \"guzzlehttp/psr7\": \"^2.2\",\n- \"mongodb/mongo...
true
Seldaek/monolog
1,998
comment_to_fix
Replace deprecated code in MongoDB classes and allow 2.0+
You can change this condition to use the phpunit attribute RequirePhpExtension.
2e97231b969e0ffdeff03329b808945b4ba55e38
f803103d48969a37bfd71162cfb789b72ffb18d6
diff --git a/tests/Monolog/Formatter/MongoDBFormatterTest.php b/tests/Monolog/Formatter/MongoDBFormatterTest.php index 08f1de19b..6faf22f18 100644 --- a/tests/Monolog/Formatter/MongoDBFormatterTest.php +++ b/tests/Monolog/Formatter/MongoDBFormatterTest.php @@ -16,19 +16,14 @@ use MongoDB\BSON\UTCDateTime; use Monolog...
[ "tests/Monolog/Formatter/MongoDBFormatterTest.php" ]
[ { "comment": "You can change this condition to use the phpunit attribute RequirePhpExtension.", "path": "tests/Monolog/Formatter/MongoDBFormatterTest.php", "hunk": "@@ -24,7 +24,7 @@ class MongoDBFormatterTest extends \\Monolog\\Test\\MonologTestCase\n {\n public function setUp(): void\n {\n- ...
true
Seldaek/monolog
2,000
issue_to_patch
feat: Add automatic empty directory cleanup in RotatingFileHandler
This PR adds automatic cleanup of empty parent directories when rotating log files in `RotatingFileHandler`. ## Motivation When using `RotatingFileHandler` with nested directory structures (e.g., using `dateFormat` like `Y/m/d` or `filenameFormat` like `{date}/{filename}` to organize logs by date), old log files ar...
2e97231b969e0ffdeff03329b808945b4ba55e38
9e9fe24897b8c419a648b72d4a1f7a128a5d44df
diff --git a/src/Monolog/Handler/RotatingFileHandler.php b/src/Monolog/Handler/RotatingFileHandler.php index f3e04557d..0464b376b 100644 --- a/src/Monolog/Handler/RotatingFileHandler.php +++ b/src/Monolog/Handler/RotatingFileHandler.php @@ -146,6 +146,8 @@ protected function rotate(): void return strcmp($b...
[ "src/Monolog/Handler/RotatingFileHandler.php" ]
[]
true
Seldaek/monolog
1,997
issue_to_patch
PHP 8.5 deprecated warning Monologversion : "version": "3.8.1", PHP 8.5 RC1 001+ Deprecated: The __sleep() serialization magic method has been deprecated. Implement __serialize() instead (or in addition, if support for old PHP versions is necessary) in vendor/monolog/monolog/src/Monolog/Handler/Handler.php on line 1...
Fix PHP 8.5 `__sleep` deprecation
This patch breaks any implementation of __sleep in child classes/user handlers. Should be warned in the release notes. Closes #1995
2e97231b969e0ffdeff03329b808945b4ba55e38
d8d0174ff1e8e7e96d91d5102737172726ef2709
diff --git a/src/Monolog/Handler/Handler.php b/src/Monolog/Handler/Handler.php index e89f969b8..8a4e7ab10 100644 --- a/src/Monolog/Handler/Handler.php +++ b/src/Monolog/Handler/Handler.php @@ -44,19 +44,10 @@ public function __destruct() } } - public function __sleep() + public function __serializ...
[ "src/Monolog/Handler/Handler.php", "tests/Monolog/Handler/StreamHandlerTest.php" ]
[ { "comment": "this call is useless. Monolog requires PHP 8.1+, and this call is a no-op in PHP 8 (and btw, it is *also* deprecated in PHP 8.5)", "path": "src/Monolog/Handler/Handler.php", "hunk": "@@ -44,19 +44,27 @@ public function __destruct()\n }\n }\n \n- public function __sleep()\n+ ...
diff --git a/tests/Monolog/Handler/StreamHandlerTest.php b/tests/Monolog/Handler/StreamHandlerTest.php index bdce21fd6..5a09530fc 100644 --- a/tests/Monolog/Handler/StreamHandlerTest.php +++ b/tests/Monolog/Handler/StreamHandlerTest.php @@ -67,7 +67,7 @@ public function testClose() /** * @covers Monolog\Ha...
true
Seldaek/monolog
1,997
comment_to_fix
Fix PHP 8.5 `__sleep` deprecation
this call is useless. Monolog requires PHP 8.1+, and this call is a no-op in PHP 8 (and btw, it is *also* deprecated in PHP 8.5)
2e97231b969e0ffdeff03329b808945b4ba55e38
d8d0174ff1e8e7e96d91d5102737172726ef2709
diff --git a/src/Monolog/Handler/Handler.php b/src/Monolog/Handler/Handler.php index e89f969b8..8a4e7ab10 100644 --- a/src/Monolog/Handler/Handler.php +++ b/src/Monolog/Handler/Handler.php @@ -44,19 +44,10 @@ public function __destruct() } } - public function __sleep() + public function __serializ...
[ "src/Monolog/Handler/Handler.php" ]
[ { "comment": "this call is useless. Monolog requires PHP 8.1+, and this call is a no-op in PHP 8 (and btw, it is *also* deprecated in PHP 8.5)", "path": "src/Monolog/Handler/Handler.php", "hunk": "@@ -44,19 +44,27 @@ public function __destruct()\n }\n }\n \n- public function __sleep()\n+ ...
true
Seldaek/monolog
1,999
issue_to_patch
Fix issue https://github.com/Seldaek/monolog/issues/1984
Fix issue https://github.com/Seldaek/monolog/issues/1984
2e97231b969e0ffdeff03329b808945b4ba55e38
841c55e9dd436d5de60a27d889266e9536e39806
diff --git a/src/Monolog/Handler/RotatingFileHandler.php b/src/Monolog/Handler/RotatingFileHandler.php index f3e04557d..3077338fb 100644 --- a/src/Monolog/Handler/RotatingFileHandler.php +++ b/src/Monolog/Handler/RotatingFileHandler.php @@ -151,7 +151,7 @@ protected function rotate(): void // suppress ...
[ "src/Monolog/Handler/RotatingFileHandler.php" ]
[ { "comment": "I left a related comment in https://github.com/Seldaek/monolog/issues/1984#issuecomment-3415594792, but I think this is a fix for a bug that inadvertently introduced when return types were added across the project.", "path": "src/Monolog/Handler/RotatingFileHandler.php", "hunk": "@@ -151,7...
true
Seldaek/monolog
1,970
issue_to_patch
Fix PHP 8.4 E_STRICT deprecation notices (2.x backport)
This back-ports https://github.com/Seldaek/monolog/pull/1921 to 2.x for PHP 8.4 compatibility. Thanks!
cd82b5069148dd811ef54b4b92ce1b3aad84209b
f3713d2c09634c64c179d30a9f080edaea52b594
diff --git a/src/Monolog/ErrorHandler.php b/src/Monolog/ErrorHandler.php index 1406d34e8..07424903b 100644 --- a/src/Monolog/ErrorHandler.php +++ b/src/Monolog/ErrorHandler.php @@ -168,7 +168,7 @@ protected function defaultErrorLevelMap(): array E_USER_ERROR => LogLevel::ERROR, E_USER_W...
[ "src/Monolog/ErrorHandler.php", "tests/Monolog/ErrorHandlerTest.php" ]
[]
diff --git a/tests/Monolog/ErrorHandlerTest.php b/tests/Monolog/ErrorHandlerTest.php index 05123f2af..b54ea2352 100644 --- a/tests/Monolog/ErrorHandlerTest.php +++ b/tests/Monolog/ErrorHandlerTest.php @@ -120,7 +120,7 @@ public function testCodeToString() $this->assertEquals('E_USER_ERROR', $method->invokeArgs...
true
Seldaek/monolog
1,980
issue_to_patch
Normalize DIRECTORY_SEPARATOR on file traces(exceptions)
When using `setBasePath($path)`, this PR makes Windows and Linux logs look the same.
6b44f0a0648cc88c13f7dba997d855b8ee2a64f2
3ee760ee2830a9e994e2050ee07dcd06fc82d832
diff --git a/src/Monolog/Formatter/LineFormatter.php b/src/Monolog/Formatter/LineFormatter.php index d26204a36..d44e7aef0 100644 --- a/src/Monolog/Formatter/LineFormatter.php +++ b/src/Monolog/Formatter/LineFormatter.php @@ -278,7 +278,7 @@ private function formatException(\Throwable $e): string $file = pr...
[ "src/Monolog/Formatter/LineFormatter.php" ]
[]
true
Seldaek/monolog
1,992
issue_to_patch
TelegramBotHandler: API returns error when long message is split with only whitespace Monolog 3.9. When I [split long messages](https://github.com/Seldaek/monolog/blob/3.9.0/src/Monolog/Handler/TelegramBotHandler.php#L117) and the split happens exactly at the ending part of the message, which happens to contain only ...
TelegramBotHandler: skipping messages containing only whitespace
#fixes https://github.com/Seldaek/monolog/issues/1991
2e97231b969e0ffdeff03329b808945b4ba55e38
713e6eb4faedb931d13ae59593f0acb9e6ddeb75
diff --git a/src/Monolog/Handler/TelegramBotHandler.php b/src/Monolog/Handler/TelegramBotHandler.php index dcca5d676..6e5a8d729 100644 --- a/src/Monolog/Handler/TelegramBotHandler.php +++ b/src/Monolog/Handler/TelegramBotHandler.php @@ -253,6 +253,10 @@ protected function send(string $message): void protected fu...
[ "src/Monolog/Handler/TelegramBotHandler.php" ]
[]
true
Seldaek/monolog
1,993
issue_to_patch
TelegramBotHandler: three dots replacement…
`…` instead of `...` makes the truncation part of the message 2 characters shorter, allowing for a bit longer actual message xd
2e97231b969e0ffdeff03329b808945b4ba55e38
f647f3e50dac4a1a57f83106402bb2bef9a1c446
diff --git a/src/Monolog/Handler/TelegramBotHandler.php b/src/Monolog/Handler/TelegramBotHandler.php index dcca5d676..c9a24702e 100644 --- a/src/Monolog/Handler/TelegramBotHandler.php +++ b/src/Monolog/Handler/TelegramBotHandler.php @@ -287,7 +287,7 @@ protected function sendCurl(string $message): void */ pr...
[ "src/Monolog/Handler/TelegramBotHandler.php" ]
[]
true
Seldaek/monolog
1,963
issue_to_patch
Add handling of inode changes to reopen files in StreamHandler
In log rotation processes, I don't always have control to reopen files when they are renamed or deleted. Therefore, if I don't want to truncate the file, I need a mechanism for the process writing to the log to detect that the file has changed. With this change, before performing a write operation, the process writi...
2e97231b969e0ffdeff03329b808945b4ba55e38
282fa69b5a9f49bcd0df6d942c3a9e57d3304525
diff --git a/src/Monolog/Handler/StreamHandler.php b/src/Monolog/Handler/StreamHandler.php index 6153cc285..10c9df84d 100644 --- a/src/Monolog/Handler/StreamHandler.php +++ b/src/Monolog/Handler/StreamHandler.php @@ -38,6 +38,7 @@ class StreamHandler extends AbstractProcessingHandler /** @var true|null */ pri...
[ "src/Monolog/Handler/StreamHandler.php", "tests/Monolog/Handler/StreamHandlerTest.php" ]
[]
diff --git a/tests/Monolog/Handler/StreamHandlerTest.php b/tests/Monolog/Handler/StreamHandlerTest.php index bdce21fd6..e2241234f 100644 --- a/tests/Monolog/Handler/StreamHandlerTest.php +++ b/tests/Monolog/Handler/StreamHandlerTest.php @@ -365,4 +365,16 @@ public function testSimpleOOMPrevention(): void i...
true
Seldaek/monolog
1,994
issue_to_patch
Add WebFramework to Framework Integrations
Add WebFramework found at https://web-framework.com to the Framework Integrations list in README. Support for logging is documented: https://web-framework.com/logging/
2e97231b969e0ffdeff03329b808945b4ba55e38
3897cf742c99730f8523b50384b97c72268f2c9c
diff --git a/README.md b/README.md index 9cbdd396f..0564f96f0 100644 --- a/README.md +++ b/README.md @@ -119,6 +119,7 @@ Bugs and feature request are tracked on [GitHub](https://github.com/Seldaek/mono - [Aimeos ecommerce framework](https://aimeos.org/) is usable with Monolog via the [ai-monolog](https://github.com/ai...
[ "README.md" ]
[]
true
Seldaek/monolog
1,979
issue_to_patch
Avoid empty espace on empty trace
When it comes empty it shows something like this ``` [stacktrace] " ```
2e97231b969e0ffdeff03329b808945b4ba55e38
1827a155fb89f9efb8f145a1cde20386ec6c3015
diff --git a/src/Monolog/Formatter/LineFormatter.php b/src/Monolog/Formatter/LineFormatter.php index fd9dc5bbd..d26204a36 100644 --- a/src/Monolog/Formatter/LineFormatter.php +++ b/src/Monolog/Formatter/LineFormatter.php @@ -303,6 +303,10 @@ private function stacktracesParser(\Throwable $e): string $trace ...
[ "src/Monolog/Formatter/LineFormatter.php" ]
[]
true
Seldaek/monolog
1,996
issue_to_patch
Bump shivammathur/setup-php from 2.32.0 to 2.35.5
Bumps [shivammathur/setup-php](https://github.com/shivammathur/setup-php) from 2.32.0 to 2.35.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/shivammathur/setup-php/releases">shivammathur/setup-php's releases</a>.</em></p> <blockquote> <h2>2.35.5</h2> <h2>Changelog</h2> <ul...
2e97231b969e0ffdeff03329b808945b4ba55e38
9f2e2f4d4cb4542d8b395f5263df2e001a4c9580
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 9d54a0622..5eb7b9821 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -58,7 +58,7 @@ jobs: with: mongodb-version: 5.0 - ...
[ ".github/workflows/continuous-integration.yml", ".github/workflows/lint.yml", ".github/workflows/phpstan.yml" ]
[]
true
Seldaek/monolog
1,975
issue_to_patch
Bump cobot/couchdb-action from 7474dc7782b9f8a84d10579dd91339820b2e6b7e to eaaa17cf8baf421e7fb07e2d869f5457bb6a4de5
Bumps [cobot/couchdb-action](https://github.com/cobot/couchdb-action) from 7474dc7782b9f8a84d10579dd91339820b2e6b7e to eaaa17cf8baf421e7fb07e2d869f5457bb6a4de5. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/cobot/couchdb-action/commit/eaaa17cf8baf421e7fb07e2d869f5457bb6a4de5"><code>eaaa17c</...
2e97231b969e0ffdeff03329b808945b4ba55e38
7f61bb2a5a3d60641da8c1cadf978e7f669973c9
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 9d54a0622..0913968ea 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -49,7 +49,7 @@ jobs: - name: Run CouchDB timeout-minutes: 3 ...
[ ".github/workflows/continuous-integration.yml" ]
[]
true
Seldaek/monolog
1,985
issue_to_patch
Bump actions/checkout from 4.2.2 to 5.0.0
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.2 to 5.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p> <blockquote> <h2>v5.0.0</h2> <h2>What's Changed</h2> <ul> <li>Update actions ...
2e97231b969e0ffdeff03329b808945b4ba55e38
29603b2238238c680b1a6293963839ef6e84331e
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 9d54a0622..9190a320f 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -44,7 +44,7 @@ jobs: composer-options: "--ignore-platform-req=p...
[ ".github/workflows/continuous-integration.yml", ".github/workflows/lint.yml", ".github/workflows/phpstan.yml" ]
[]
true
Seldaek/monolog
1,973
issue_to_patch
[GelfFormatter] Missing boolean values Monolog version: 3 The GELF Payload Specification does not support `bool` values as a addtional field. See https://go2docs.graylog.org/current/getting_in_log_data/gelf.html#GELFPayloadSpecification If a `bool` value is provided Graylog will simply drop it. Given the followin...
[GelfFormatter] Convert bool to int
Convert all `bool` values in `extra` and `context` to `int` to prevent Graylog from loosing them. Fixes #1972
2e97231b969e0ffdeff03329b808945b4ba55e38
cbf5725a6975289c6fe73ab285d4e4df82efeb5d
diff --git a/src/Monolog/Formatter/GelfMessageFormatter.php b/src/Monolog/Formatter/GelfMessageFormatter.php index 12a3b0a32..bf8ed2411 100644 --- a/src/Monolog/Formatter/GelfMessageFormatter.php +++ b/src/Monolog/Formatter/GelfMessageFormatter.php @@ -116,6 +116,7 @@ public function format(LogRecord $record): Message ...
[ "src/Monolog/Formatter/GelfMessageFormatter.php", "tests/Monolog/Formatter/GelfMessageFormatterTest.php" ]
[]
diff --git a/tests/Monolog/Formatter/GelfMessageFormatterTest.php b/tests/Monolog/Formatter/GelfMessageFormatterTest.php index a882e76c2..ee26ea4d9 100644 --- a/tests/Monolog/Formatter/GelfMessageFormatterTest.php +++ b/tests/Monolog/Formatter/GelfMessageFormatterTest.php @@ -87,7 +87,7 @@ public function testFormatWit...
true
Seldaek/monolog
1,941
issue_to_patch
Add `strtolower` for `fromName` match statement
Changes the `fromName` method to be case-insensitive for more flexible use.
548eeb3f1e313d943712b9fab0dc2e865a5a7bfc
db4bf1cdd13cb7a13657452b79b4dae53355ba36
diff --git a/src/Monolog/Level.php b/src/Monolog/Level.php index 5620bc4de..38a74fb8f 100644 --- a/src/Monolog/Level.php +++ b/src/Monolog/Level.php @@ -87,15 +87,15 @@ enum Level: int */ public static function fromName(string $name): self { - return match ($name) { - 'debug', 'Debug',...
[ "src/Monolog/Level.php" ]
[]
true
Seldaek/monolog
1,955
issue_to_patch
Remove deprecated setType method call in ElasticaFormatter
467e764fb6ebf5c931ba3edffda938ff755cad19
5f2615fd998149237dfefa55c30b662ee89fb9b8
diff --git a/src/Monolog/Formatter/ElasticaFormatter.php b/src/Monolog/Formatter/ElasticaFormatter.php index 759c97d19..a0fa4a9e1 100644 --- a/src/Monolog/Formatter/ElasticaFormatter.php +++ b/src/Monolog/Formatter/ElasticaFormatter.php @@ -77,10 +77,6 @@ protected function getDocument(array $record): Document { ...
[ "src/Monolog/Formatter/ElasticaFormatter.php" ]
[]
true
Seldaek/monolog
1,956
issue_to_patch
Updating while loops to have boolean conditions.
467e764fb6ebf5c931ba3edffda938ff755cad19
7d711136f47bb6e4f661fe2b46ccd7e7a7e904d2
diff --git a/src/Monolog/Formatter/LineFormatter.php b/src/Monolog/Formatter/LineFormatter.php index 8c671aa99..fd9dc5bbd 100644 --- a/src/Monolog/Formatter/LineFormatter.php +++ b/src/Monolog/Formatter/LineFormatter.php @@ -204,16 +204,15 @@ protected function normalizeException(\Throwable $e, int $depth = 0): string ...
[ "src/Monolog/Formatter/LineFormatter.php", "src/Monolog/Handler/Curl/Util.php" ]
[ { "comment": "This is broken. It does not stop the loop anymore when `$retries` reaches 0", "path": "src/Monolog/Handler/Curl/Util.php", "hunk": "@@ -37,9 +37,10 @@ final class Util\n * @param CurlHandle $ch curl handler\n * @return bool|string @see curl_exec\n */\n- public static fu...
true
Seldaek/monolog
1,956
comment_to_fix
Updating while loops to have boolean conditions.
This is broken. It does not stop the loop anymore when `$retries` reaches 0
467e764fb6ebf5c931ba3edffda938ff755cad19
7d711136f47bb6e4f661fe2b46ccd7e7a7e904d2
diff --git a/src/Monolog/Handler/Curl/Util.php b/src/Monolog/Handler/Curl/Util.php index f10281144..6d78cb154 100644 --- a/src/Monolog/Handler/Curl/Util.php +++ b/src/Monolog/Handler/Curl/Util.php @@ -37,9 +37,10 @@ final class Util * @param CurlHandle $ch curl handler * @return bool|string @see curl_exec...
[ "src/Monolog/Handler/Curl/Util.php" ]
[ { "comment": "This is broken. It does not stop the loop anymore when `$retries` reaches 0", "path": "src/Monolog/Handler/Curl/Util.php", "hunk": "@@ -37,9 +37,10 @@ final class Util\n * @param CurlHandle $ch curl handler\n * @return bool|string @see curl_exec\n */\n- public static fu...
true
Seldaek/monolog
1,956
comment_to_fix
Updating while loops to have boolean conditions.
this changes the logic because you are no longer incrementing the depth before that condition, while it was the case before.
467e764fb6ebf5c931ba3edffda938ff755cad19
7d711136f47bb6e4f661fe2b46ccd7e7a7e904d2
diff --git a/src/Monolog/Formatter/LineFormatter.php b/src/Monolog/Formatter/LineFormatter.php index 8c671aa99..fd9dc5bbd 100644 --- a/src/Monolog/Formatter/LineFormatter.php +++ b/src/Monolog/Formatter/LineFormatter.php @@ -204,16 +204,15 @@ protected function normalizeException(\Throwable $e, int $depth = 0): string ...
[ "src/Monolog/Formatter/LineFormatter.php" ]
[ { "comment": "this changes the logic because you are no longer incrementing the depth before that condition, while it was the case before.", "path": "src/Monolog/Formatter/LineFormatter.php", "hunk": "@@ -204,16 +204,19 @@ protected function normalizeException(\\Throwable $e, int $depth = 0): string\n ...
true
Seldaek/monolog
1,956
comment_to_fix
Updating while loops to have boolean conditions.
coding standards are off here
467e764fb6ebf5c931ba3edffda938ff755cad19
7d711136f47bb6e4f661fe2b46ccd7e7a7e904d2
diff --git a/src/Monolog/Formatter/LineFormatter.php b/src/Monolog/Formatter/LineFormatter.php index 8c671aa99..fd9dc5bbd 100644 --- a/src/Monolog/Formatter/LineFormatter.php +++ b/src/Monolog/Formatter/LineFormatter.php @@ -204,16 +204,15 @@ protected function normalizeException(\Throwable $e, int $depth = 0): string ...
[ "src/Monolog/Formatter/LineFormatter.php" ]
[ { "comment": "coding standards are off here", "path": "src/Monolog/Formatter/LineFormatter.php", "hunk": "@@ -204,16 +204,19 @@ protected function normalizeException(\\Throwable $e, int $depth = 0): string\n {\n $str = $this->formatException($e);\n \n- if (($previous = $e->getPrevious...
true
Seldaek/monolog
1,956
comment_to_fix
Updating while loops to have boolean conditions.
this is broken, because you restart with `$previous = $e->getPrevious();` at each iteration of the loop instead of using the modified `$previous`
467e764fb6ebf5c931ba3edffda938ff755cad19
7d711136f47bb6e4f661fe2b46ccd7e7a7e904d2
diff --git a/src/Monolog/Formatter/LineFormatter.php b/src/Monolog/Formatter/LineFormatter.php index 8c671aa99..fd9dc5bbd 100644 --- a/src/Monolog/Formatter/LineFormatter.php +++ b/src/Monolog/Formatter/LineFormatter.php @@ -204,16 +204,15 @@ protected function normalizeException(\Throwable $e, int $depth = 0): string ...
[ "src/Monolog/Formatter/LineFormatter.php" ]
[ { "comment": "this is broken, because you restart with `$previous = $e->getPrevious();` at each iteration of the loop instead of using the modified `$previous`", "path": "src/Monolog/Formatter/LineFormatter.php", "hunk": "@@ -204,16 +204,19 @@ protected function normalizeException(\\Throwable $e, int $d...
true
Seldaek/monolog
1,952
issue_to_patch
SendGrid V3 API
#1935
467e764fb6ebf5c931ba3edffda938ff755cad19
fdb4372717370793b263d005863aad1bd83f5468
diff --git a/src/Monolog/Handler/SendGridHandler.php b/src/Monolog/Handler/SendGridHandler.php index 9c3b8e6af..5847a585c 100644 --- a/src/Monolog/Handler/SendGridHandler.php +++ b/src/Monolog/Handler/SendGridHandler.php @@ -12,9 +12,10 @@ namespace Monolog\Handler; use Monolog\Level; +use Monolog\Utils; /** - *...
[ "src/Monolog/Handler/SendGridHandler.php" ]
[ { "comment": "Turning a protected property into a private one is a BC break.", "path": "src/Monolog/Handler/SendGridHandler.php", "hunk": "@@ -20,81 +20,58 @@\n */\n class SendGridHandler extends MailHandler\n {\n+ private const CONTENT_TYPE = 'Content-Type: application/json';\n /**\n- * The...
true
Seldaek/monolog
1,952
comment_to_fix
SendGrid V3 API
Turning a protected property into a private one is a BC break.
467e764fb6ebf5c931ba3edffda938ff755cad19
fdb4372717370793b263d005863aad1bd83f5468
diff --git a/src/Monolog/Handler/SendGridHandler.php b/src/Monolog/Handler/SendGridHandler.php index 9c3b8e6af..5847a585c 100644 --- a/src/Monolog/Handler/SendGridHandler.php +++ b/src/Monolog/Handler/SendGridHandler.php @@ -12,9 +12,10 @@ namespace Monolog\Handler; use Monolog\Level; +use Monolog\Utils; /** - *...
[ "src/Monolog/Handler/SendGridHandler.php" ]
[ { "comment": "Turning a protected property into a private one is a BC break.", "path": "src/Monolog/Handler/SendGridHandler.php", "hunk": "@@ -20,81 +20,58 @@\n */\n class SendGridHandler extends MailHandler\n {\n+ private const CONTENT_TYPE = 'Content-Type: application/json';\n /**\n- * The...
true
Seldaek/monolog
1,952
comment_to_fix
SendGrid V3 API
Removing the first constructor argument is a BC break which cannot be accepted in a minor version of the library.
467e764fb6ebf5c931ba3edffda938ff755cad19
fdb4372717370793b263d005863aad1bd83f5468
diff --git a/src/Monolog/Handler/SendGridHandler.php b/src/Monolog/Handler/SendGridHandler.php index 9c3b8e6af..5847a585c 100644 --- a/src/Monolog/Handler/SendGridHandler.php +++ b/src/Monolog/Handler/SendGridHandler.php @@ -12,9 +12,10 @@ namespace Monolog\Handler; use Monolog\Level; +use Monolog\Utils; /** - *...
[ "src/Monolog/Handler/SendGridHandler.php" ]
[ { "comment": "Removing the first constructor argument is a BC break which cannot be accepted in a minor version of the library.", "path": "src/Monolog/Handler/SendGridHandler.php", "hunk": "@@ -20,81 +20,58 @@\n */\n class SendGridHandler extends MailHandler\n {\n+ private const CONTENT_TYPE = 'Cont...
true
Seldaek/monolog
1,952
comment_to_fix
SendGrid V3 API
Redefining a `$bubble` property here does not make sense, as we want to use the property of the parent class. This parameter should not be a promoted property.
467e764fb6ebf5c931ba3edffda938ff755cad19
fdb4372717370793b263d005863aad1bd83f5468
diff --git a/src/Monolog/Handler/SendGridHandler.php b/src/Monolog/Handler/SendGridHandler.php index 9c3b8e6af..5847a585c 100644 --- a/src/Monolog/Handler/SendGridHandler.php +++ b/src/Monolog/Handler/SendGridHandler.php @@ -12,9 +12,10 @@ namespace Monolog\Handler; use Monolog\Level; +use Monolog\Utils; /** - *...
[ "src/Monolog/Handler/SendGridHandler.php" ]
[ { "comment": "Redefining a `$bubble` property here does not make sense, as we want to use the property of the parent class. This parameter should not be a promoted property.", "path": "src/Monolog/Handler/SendGridHandler.php", "hunk": "@@ -20,81 +20,58 @@\n */\n class SendGridHandler extends MailHandle...
true
Seldaek/monolog
1,952
comment_to_fix
SendGrid V3 API
Changing the parameter type from `string|array` to `array` is a BC break, that is not worth it IMO
467e764fb6ebf5c931ba3edffda938ff755cad19
fdb4372717370793b263d005863aad1bd83f5468
diff --git a/src/Monolog/Handler/SendGridHandler.php b/src/Monolog/Handler/SendGridHandler.php index 9c3b8e6af..5847a585c 100644 --- a/src/Monolog/Handler/SendGridHandler.php +++ b/src/Monolog/Handler/SendGridHandler.php @@ -12,9 +12,10 @@ namespace Monolog\Handler; use Monolog\Level; +use Monolog\Utils; /** - *...
[ "src/Monolog/Handler/SendGridHandler.php" ]
[ { "comment": "Changing the parameter type from `string|array` to `array` is a BC break, that is not worth it IMO", "path": "src/Monolog/Handler/SendGridHandler.php", "hunk": "@@ -20,81 +20,58 @@\n */\n class SendGridHandler extends MailHandler\n {\n+ private const CONTENT_TYPE = 'Content-Type: appli...
true
Seldaek/monolog
1,952
comment_to_fix
SendGrid V3 API
what is the reason to make this configurable ?
467e764fb6ebf5c931ba3edffda938ff755cad19
fdb4372717370793b263d005863aad1bd83f5468
diff --git a/src/Monolog/Handler/SendGridHandler.php b/src/Monolog/Handler/SendGridHandler.php index 9c3b8e6af..5847a585c 100644 --- a/src/Monolog/Handler/SendGridHandler.php +++ b/src/Monolog/Handler/SendGridHandler.php @@ -12,9 +12,10 @@ namespace Monolog\Handler; use Monolog\Level; +use Monolog\Utils; /** - *...
[ "src/Monolog/Handler/SendGridHandler.php" ]
[ { "comment": "what is the reason to make this configurable ?", "path": "src/Monolog/Handler/SendGridHandler.php", "hunk": "@@ -20,81 +20,58 @@\n */\n class SendGridHandler extends MailHandler\n {\n+ private const CONTENT_TYPE = 'Content-Type: application/json';\n /**\n- * The SendGrid API Us...
true
Seldaek/monolog
1,952
comment_to_fix
SendGrid V3 API
Should use `Utils::jsonEncode` instead of json_encode
467e764fb6ebf5c931ba3edffda938ff755cad19
fdb4372717370793b263d005863aad1bd83f5468
diff --git a/src/Monolog/Handler/SendGridHandler.php b/src/Monolog/Handler/SendGridHandler.php index 9c3b8e6af..5847a585c 100644 --- a/src/Monolog/Handler/SendGridHandler.php +++ b/src/Monolog/Handler/SendGridHandler.php @@ -12,9 +12,10 @@ namespace Monolog\Handler; use Monolog\Level; +use Monolog\Utils; /** - *...
[ "src/Monolog/Handler/SendGridHandler.php" ]
[ { "comment": "Should use `Utils::jsonEncode` instead of json_encode", "path": "src/Monolog/Handler/SendGridHandler.php", "hunk": "@@ -20,81 +20,58 @@\n */\n class SendGridHandler extends MailHandler\n {\n+ private const CONTENT_TYPE = 'Content-Type: application/json';\n /**\n- * The SendGrid...
true
Seldaek/monolog
1,952
comment_to_fix
SendGrid V3 API
turning a protected property into a protected readonly one is also a BC break. You need to keep it non-readonly.
467e764fb6ebf5c931ba3edffda938ff755cad19
fdb4372717370793b263d005863aad1bd83f5468
diff --git a/src/Monolog/Handler/SendGridHandler.php b/src/Monolog/Handler/SendGridHandler.php index 9c3b8e6af..5847a585c 100644 --- a/src/Monolog/Handler/SendGridHandler.php +++ b/src/Monolog/Handler/SendGridHandler.php @@ -12,9 +12,10 @@ namespace Monolog\Handler; use Monolog\Level; +use Monolog\Utils; /** - *...
[ "src/Monolog/Handler/SendGridHandler.php" ]
[ { "comment": "turning a protected property into a protected readonly one is also a BC break. You need to keep it non-readonly.", "path": "src/Monolog/Handler/SendGridHandler.php", "hunk": "@@ -20,81 +21,72 @@\n */\n class SendGridHandler extends MailHandler\n {\n+ private const CONTENT_TYPE = 'Conte...
true
Seldaek/monolog
1,952
comment_to_fix
SendGrid V3 API
```suggestion protected readonly string $subject, ```
467e764fb6ebf5c931ba3edffda938ff755cad19
fdb4372717370793b263d005863aad1bd83f5468
diff --git a/src/Monolog/Handler/SendGridHandler.php b/src/Monolog/Handler/SendGridHandler.php index 9c3b8e6af..5847a585c 100644 --- a/src/Monolog/Handler/SendGridHandler.php +++ b/src/Monolog/Handler/SendGridHandler.php @@ -12,9 +12,10 @@ namespace Monolog\Handler; use Monolog\Level; +use Monolog\Utils; /** - *...
[ "src/Monolog/Handler/SendGridHandler.php" ]
[ { "comment": "```suggestion\r\n protected readonly string $subject,\r\n```", "path": "src/Monolog/Handler/SendGridHandler.php", "hunk": "@@ -20,81 +21,72 @@\n */\n class SendGridHandler extends MailHandler\n {\n+ private const CONTENT_TYPE = 'Content-Type: application/json';\n+\n /**\n ...
true
Seldaek/monolog
1,952
comment_to_fix
SendGrid V3 API
this should also stay protected and non-readonly to avoid a BC break.
467e764fb6ebf5c931ba3edffda938ff755cad19
fdb4372717370793b263d005863aad1bd83f5468
diff --git a/src/Monolog/Handler/SendGridHandler.php b/src/Monolog/Handler/SendGridHandler.php index 9c3b8e6af..5847a585c 100644 --- a/src/Monolog/Handler/SendGridHandler.php +++ b/src/Monolog/Handler/SendGridHandler.php @@ -12,9 +12,10 @@ namespace Monolog\Handler; use Monolog\Level; +use Monolog\Utils; /** - *...
[ "src/Monolog/Handler/SendGridHandler.php" ]
[ { "comment": "this should also stay protected and non-readonly to avoid a BC break.", "path": "src/Monolog/Handler/SendGridHandler.php", "hunk": "@@ -20,81 +21,72 @@\n */\n class SendGridHandler extends MailHandler\n {\n+ private const CONTENT_TYPE = 'Content-Type: application/json';\n+\n /**\n ...
true
Seldaek/monolog
1,952
comment_to_fix
SendGrid V3 API
```suggestion protected string $from, ```
467e764fb6ebf5c931ba3edffda938ff755cad19
fdb4372717370793b263d005863aad1bd83f5468
diff --git a/src/Monolog/Handler/SendGridHandler.php b/src/Monolog/Handler/SendGridHandler.php index 9c3b8e6af..5847a585c 100644 --- a/src/Monolog/Handler/SendGridHandler.php +++ b/src/Monolog/Handler/SendGridHandler.php @@ -12,9 +12,10 @@ namespace Monolog\Handler; use Monolog\Level; +use Monolog\Utils; /** - *...
[ "src/Monolog/Handler/SendGridHandler.php" ]
[ { "comment": "```suggestion\r\n protected string $from,\r\n```", "path": "src/Monolog/Handler/SendGridHandler.php", "hunk": "@@ -20,81 +21,72 @@\n */\n class SendGridHandler extends MailHandler\n {\n+ private const CONTENT_TYPE = 'Content-Type: application/json';\n+\n /**\n * The Sen...
true
Seldaek/monolog
1,952
comment_to_fix
SendGrid V3 API
If there is no user anymore I'd mark this deprecated i think
467e764fb6ebf5c931ba3edffda938ff755cad19
fdb4372717370793b263d005863aad1bd83f5468
diff --git a/src/Monolog/Handler/SendGridHandler.php b/src/Monolog/Handler/SendGridHandler.php index 9c3b8e6af..5847a585c 100644 --- a/src/Monolog/Handler/SendGridHandler.php +++ b/src/Monolog/Handler/SendGridHandler.php @@ -12,9 +12,10 @@ namespace Monolog\Handler; use Monolog\Level; +use Monolog\Utils; /** - *...
[ "src/Monolog/Handler/SendGridHandler.php" ]
[ { "comment": "If there is no user anymore I'd mark this deprecated i think ", "path": "src/Monolog/Handler/SendGridHandler.php", "hunk": "@@ -20,81 +21,72 @@\n */\n class SendGridHandler extends MailHandler\n {\n+ private const CONTENT_TYPE = 'Content-Type: application/json';\n+\n /**\n * T...
true
Seldaek/monolog
1,953
issue_to_patch
Rename TestCase class to prevent import conflicts with PHPUnit's TestCase Monolog version 3 Write your question here. today I was stumbling over a problem of wrongly used `TestCase` class because autocompletion liked monologs class more then the phpunit one. this remindet me of a similar issue we had in the past wi...
Rename TestCase to MonologTestCase
closes https://github.com/Seldaek/monolog/issues/1951
45b5e0e33e5b95f82d7b99b304ae20ff26e31f3f
f9907934c9c803d751ce3c3253fd3fbb5664cf35
[ "src/Monolog/Test/MonologTestCase.php", "src/Monolog/Test/TestCase.php", "tests/Monolog/Attribute/AsMonologProcessorTest.php", "tests/Monolog/Attribute/WithMonologChannelTest.php", "tests/Monolog/Formatter/ChromePHPFormatterTest.php", "tests/Monolog/Formatter/ElasticaFormatterTest.php", "tests/Monolog/F...
[ { "comment": "Not needed anymore\r\n\r\n```suggestion\r\n```", "path": "src/Monolog/Test/MonologTestCase.php", "hunk": "@@ -0,0 +1,73 @@\n+<?php declare(strict_types=1);\n+\n+/*\n+ * This file is part of the Monolog package.\n+ *\n+ * (c) Jordi Boggiano <j.boggiano@seld.be>\n+ *\n+ * For the full copyri...
diff --git a/src/Monolog/Test/MonologTestCase.php b/src/Monolog/Test/MonologTestCase.php new file mode 100644 index 000000000..34c7724ea --- /dev/null +++ b/src/Monolog/Test/MonologTestCase.php @@ -0,0 +1,71 @@ +<?php declare(strict_types=1); + +/* + * This file is part of the Monolog package. + * + * (c) Jordi Boggian...
true
Seldaek/monolog
1,953
comment_to_fix
Rename TestCase to MonologTestCase
Not needed anymore ```suggestion ```
45b5e0e33e5b95f82d7b99b304ae20ff26e31f3f
f9907934c9c803d751ce3c3253fd3fbb5664cf35
diff --git a/src/Monolog/Test/MonologTestCase.php b/src/Monolog/Test/MonologTestCase.php new file mode 100644 index 000000000..34c7724ea --- /dev/null +++ b/src/Monolog/Test/MonologTestCase.php @@ -0,0 +1,71 @@ +<?php declare(strict_types=1); + +/* + * This file is part of the Monolog package. + * + * (c) Jordi Boggian...
[ "src/Monolog/Test/MonologTestCase.php" ]
[ { "comment": "Not needed anymore\r\n\r\n```suggestion\r\n```", "path": "src/Monolog/Test/MonologTestCase.php", "hunk": "@@ -0,0 +1,73 @@\n+<?php declare(strict_types=1);\n+\n+/*\n+ * This file is part of the Monolog package.\n+ *\n+ * (c) Jordi Boggiano <j.boggiano@seld.be>\n+ *\n+ * For the full copyri...
true
Seldaek/monolog
1,954
issue_to_patch
Fix build
~~not sure why the expectation no longer matches/changed~~ update: I think this changed with https://github.com/Seldaek/monolog/pull/1942
45b5e0e33e5b95f82d7b99b304ae20ff26e31f3f
630d613797d96e2424d3690b28fefd5802434e18
diff --git a/src/Monolog/Handler/BufferHandler.php b/src/Monolog/Handler/BufferHandler.php index 7b5ebbbe0..c799b6b9c 100644 --- a/src/Monolog/Handler/BufferHandler.php +++ b/src/Monolog/Handler/BufferHandler.php @@ -163,7 +163,7 @@ public function getFormatter(): FormatterInterface throw new \UnexpectedValueE...
[ "src/Monolog/Handler/BufferHandler.php", "tests/Monolog/Formatter/ElasticsearchFormatterTest.php" ]
[ { "comment": "baselined this error, as adding a new return type is likely a BC break", "path": "phpstan-baseline.neon", "hunk": "@@ -42,6 +42,12 @@ parameters:\n \t\t\tcount: 1\n \t\t\tpath: src/Monolog/Formatter/WildfireFormatter.php\n \n+\t\t-\n+\t\t\tmessage: '#^Method Monolog\\\\Handler\\\\BufferHan...
diff --git a/tests/Monolog/Formatter/ElasticsearchFormatterTest.php b/tests/Monolog/Formatter/ElasticsearchFormatterTest.php index 438bbfd39..1a53c66e5 100644 --- a/tests/Monolog/Formatter/ElasticsearchFormatterTest.php +++ b/tests/Monolog/Formatter/ElasticsearchFormatterTest.php @@ -34,7 +34,7 @@ public function testF...
true
Seldaek/monolog
1,942
issue_to_patch
Change datetime format from ISO 8601 to ATOM in ElasticsearchFormatter
ISO8601 is deprecated.
548eeb3f1e313d943712b9fab0dc2e865a5a7bfc
a029864297288a20b3686d4aeea7c4b4d334cd90
diff --git a/src/Monolog/Formatter/ElasticsearchFormatter.php b/src/Monolog/Formatter/ElasticsearchFormatter.php index 6c3eb9b2a..6326cf5d7 100644 --- a/src/Monolog/Formatter/ElasticsearchFormatter.php +++ b/src/Monolog/Formatter/ElasticsearchFormatter.php @@ -38,7 +38,7 @@ class ElasticsearchFormatter extends Normaliz...
[ "src/Monolog/Formatter/ElasticsearchFormatter.php", "tests/Monolog/Handler/ElasticaHandlerTest.php", "tests/Monolog/Handler/ElasticsearchHandlerTest.php" ]
[]
diff --git a/tests/Monolog/Handler/ElasticaHandlerTest.php b/tests/Monolog/Handler/ElasticaHandlerTest.php index 201f6ed98..0582912cc 100644 --- a/tests/Monolog/Handler/ElasticaHandlerTest.php +++ b/tests/Monolog/Handler/ElasticaHandlerTest.php @@ -167,7 +167,7 @@ public function testHandleIntegrationNewESVersion() ...
true
Seldaek/monolog
1,933
issue_to_patch
Fix ErrorLogHandler type hint: $messageType accepts only SAPI and OS
Introduced via f43e3d563776da6e696648025437ea0576dd1e9a
d97d5e9468aa7d10f95b2e0468f39afdbd08a4d1
0de95fe40da07df4313e7d1ccf55a221f68f0cfa
diff --git a/src/Monolog/Handler/ErrorLogHandler.php b/src/Monolog/Handler/ErrorLogHandler.php index a38c3f5e0..cd28ff6ac 100644 --- a/src/Monolog/Handler/ErrorLogHandler.php +++ b/src/Monolog/Handler/ErrorLogHandler.php @@ -27,12 +27,12 @@ class ErrorLogHandler extends AbstractProcessingHandler public const OPERA...
[ "src/Monolog/Handler/ErrorLogHandler.php" ]
[]
true
Seldaek/monolog
1,946
issue_to_patch
added possibility to set child handler after instantiation
Hello, this is to address #1943 - pretty straightforward. Also, can be easily backported to 2.x - please let me know if I should open another PR for 2.x branch
548eeb3f1e313d943712b9fab0dc2e865a5a7bfc
8e7cddca0f0b4e690fecb2a785c3a1627a75a113
diff --git a/src/Monolog/Handler/BufferHandler.php b/src/Monolog/Handler/BufferHandler.php index c241c32f2..7b5ebbbe0 100644 --- a/src/Monolog/Handler/BufferHandler.php +++ b/src/Monolog/Handler/BufferHandler.php @@ -162,4 +162,9 @@ public function getFormatter(): FormatterInterface throw new \UnexpectedValu...
[ "src/Monolog/Handler/BufferHandler.php", "tests/Monolog/Handler/BufferHandlerTest.php" ]
[]
diff --git a/tests/Monolog/Handler/BufferHandlerTest.php b/tests/Monolog/Handler/BufferHandlerTest.php index d36a27137..3f1bfb68f 100644 --- a/tests/Monolog/Handler/BufferHandlerTest.php +++ b/tests/Monolog/Handler/BufferHandlerTest.php @@ -155,4 +155,24 @@ public function testHandleUsesProcessors() $records =...
true
Seldaek/monolog
1,948
issue_to_patch
Add a mail() hook to NativeMailHandler.
The existing call to the global mail() function in NativeMailHandler::send() is replaced with a call to a protected method NativeMailHandler::mail() that takes the same parameters. The provided implementation of NativeMailHandler::mail() passes through to the global mail() function, leaving existing behavior completely...
548eeb3f1e313d943712b9fab0dc2e865a5a7bfc
2f2664857d1e41b6338916080fad8582d9cf5393
diff --git a/src/Monolog/Handler/NativeMailerHandler.php b/src/Monolog/Handler/NativeMailerHandler.php index c68b1ddd0..a5d1a9771 100644 --- a/src/Monolog/Handler/NativeMailerHandler.php +++ b/src/Monolog/Handler/NativeMailerHandler.php @@ -128,7 +128,7 @@ protected function send(string $content, array $records): void ...
[ "src/Monolog/Handler/NativeMailerHandler.php", "tests/Monolog/Handler/NativeMailerHandlerTest.php" ]
[]
diff --git a/tests/Monolog/Handler/NativeMailerHandlerTest.php b/tests/Monolog/Handler/NativeMailerHandlerTest.php index 81c1c04b1..03e288bcf 100644 --- a/tests/Monolog/Handler/NativeMailerHandlerTest.php +++ b/tests/Monolog/Handler/NativeMailerHandlerTest.php @@ -26,6 +26,21 @@ protected function setUp(): void ...
true
Seldaek/monolog
1,937
issue_to_patch
Bump supercharge/mongodb-github-action from 1.11.0 to 1.12.0
Bumps [supercharge/mongodb-github-action](https://github.com/supercharge/mongodb-github-action) from 1.11.0 to 1.12.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/supercharge/mongodb-github-action/releases">supercharge/mongodb-github-action's releases</a>.</em></p> <blockq...
d97d5e9468aa7d10f95b2e0468f39afdbd08a4d1
d1fd5678dbee9ed068739a10521cd0c768e183fa
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 17a1e424d..ddf677146 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -53,7 +53,7 @@ jobs: couchdb version: '2.3.1' - name: Ru...
[ ".github/workflows/continuous-integration.yml" ]
[]
true
SeleniumHQ/selenium
17,678
issue_to_patch
[grid] Add support Redis-backed for SessionQueue
<!-- Thanks for Contributing to Selenium! --> <!-- Please read our contribution guidelines: https://github.com/SeleniumHQ/selenium/blob/trunk/CONTRIBUTING.md --> ### 🔗 Related Issues <!-- Example: Fixes #1234 or Closes #5678 --> <!-- If the reason for this PR is not obvious, consider creating an issue for it fir...
18bb1d97d3db196522aa9b3873a350dc40d3ccb8
c1f31eea9b7e93644bd8804db31cb7436546ada0
diff --git a/.github/workflows/ci-grid.yml b/.github/workflows/ci-grid.yml index 6affc379afc0f..99206ab6caa94 100644 --- a/.github/workflows/ci-grid.yml +++ b/.github/workflows/ci-grid.yml @@ -19,3 +19,4 @@ jobs: --test_env=TESTCONTAINERS_RYUK_DISABLED=true //java/test/org/openqa/selenium/grid/distrib...
[ ".github/workflows/ci-grid.yml", "java/src/org/openqa/selenium/grid/sessionqueue/config/NewSessionQueueFlags.java", "java/src/org/openqa/selenium/grid/sessionqueue/config/NewSessionQueueOptions.java", "java/src/org/openqa/selenium/grid/sessionqueue/httpd/NewSessionQueueServer.java", "java/src/org/openqa/sel...
[ { "comment": "<img src=\"https://img.shields.io/badge/Action_required-634FD1?style=flat-square\" height=\"20px\" alt=\"Action required\">\n\n1\\. <b><i>addtoqueue</i></b> not exception-safe <code>📘 Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\n<b><i>RedisBackedNewSessionQueue.addToQueue</i></b> re...
diff --git a/java/test/org/openqa/selenium/grid/sessionqueue/redis/BUILD.bazel b/java/test/org/openqa/selenium/grid/sessionqueue/redis/BUILD.bazel new file mode 100644 index 0000000000000..7ac226faca5bb --- /dev/null +++ b/java/test/org/openqa/selenium/grid/sessionqueue/redis/BUILD.bazel @@ -0,0 +1,33 @@ +load("@rules_...
true
SeleniumHQ/selenium
17,678
comment_to_fix
[grid] Add support Redis-backed for SessionQueue
<img src="https://img.shields.io/badge/Action_required-634FD1?style=flat-square" height="20px" alt="Action required"> 1\. <b><i>addtoqueue</i></b> not exception-safe <code>📘 Rule violation</code> <code>☼ Reliability</code> <pre> <b><i>RedisBackedNewSessionQueue.addToQueue</i></b> registers per-request state in in-me...
18bb1d97d3db196522aa9b3873a350dc40d3ccb8
c1f31eea9b7e93644bd8804db31cb7436546ada0
diff --git a/java/src/org/openqa/selenium/grid/sessionqueue/redis/RedisBackedNewSessionQueue.java b/java/src/org/openqa/selenium/grid/sessionqueue/redis/RedisBackedNewSessionQueue.java new file mode 100644 index 0000000000000..f5a471553e19d --- /dev/null +++ b/java/src/org/openqa/selenium/grid/sessionqueue/redis/RedisB...
[ "java/src/org/openqa/selenium/grid/sessionqueue/redis/RedisBackedNewSessionQueue.java" ]
[ { "comment": "<img src=\"https://img.shields.io/badge/Action_required-634FD1?style=flat-square\" height=\"20px\" alt=\"Action required\">\n\n1\\. <b><i>addtoqueue</i></b> not exception-safe <code>📘 Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\n<b><i>RedisBackedNewSessionQueue.addToQueue</i></b> re...
true