repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
ScottArbeit/Grace
328
comment_to_fix
Add branch annotate API and SDK wrapper
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Nest branch schemas under components.schemas** With these entries de-indented to the `components` level, the aggregate OpenAPI document no longer defines `#/components/schemas/GetReferencesParameters` or `#/components/schemas/Annot...
2c0265092c07919370c9e89f089affd857e7e649
93f43484515f9122613be123e3b784cc6c479469
diff --git a/src/OpenAPI/Main.OpenAPI.yaml b/src/OpenAPI/Main.OpenAPI.yaml index 54b2717c..bde76df8 100644 --- a/src/OpenAPI/Main.OpenAPI.yaml +++ b/src/OpenAPI/Main.OpenAPI.yaml @@ -121,6 +121,8 @@ paths: $ref: './Branch.Paths.OpenAPI.yaml#/~1branch~1enableTag' /branch/delete: $ref: './Branch.Paths.OpenAP...
[ "src/OpenAPI/Main.OpenAPI.yaml" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Nest branch schemas under components.schemas**\n\nWith these entries de-indented to the `components` level, the aggregate OpenAPI document no longer defines `#/components/schemas/GetReferencesParameters` or `#/...
true
ScottArbeit/Grace
328
comment_to_fix
Add branch annotate API and SDK wrapper
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve budget boundary when truncating history** When a normal save/commit target has more than `MaxReferences` local ancestors, this slice drops the immediate predecessor of the first retained reference; because those records do...
2c0265092c07919370c9e89f089affd857e7e649
93f43484515f9122613be123e3b784cc6c479469
diff --git a/src/Grace.Server/Branch.Server.fs b/src/Grace.Server/Branch.Server.fs index 31e4d51a..29001878 100644 --- a/src/Grace.Server/Branch.Server.fs +++ b/src/Grace.Server/Branch.Server.fs @@ -6,12 +6,16 @@ open Grace.Actors.Constants open Grace.Actors.Extensions.ActorProxy open Grace.Actors.Interfaces open Gr...
[ "src/Grace.Server/Branch.Server.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve budget boundary when truncating history**\n\nWhen a normal save/commit target has more than `MaxReferences` local ancestors, this slice drops the immediate predecessor of the first retained reference; ...
true
ScottArbeit/Grace
328
comment_to_fix
Add branch annotate API and SDK wrapper
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Treat unreadable ancestors as annotation boundaries** When the target is a valid text file but an older retained reference has the same path as binary, oversized, or otherwise unmaterializable content, this propagates that ancestor...
2c0265092c07919370c9e89f089affd857e7e649
93f43484515f9122613be123e3b784cc6c479469
diff --git a/src/Grace.Server/Branch.Server.fs b/src/Grace.Server/Branch.Server.fs index 31e4d51a..29001878 100644 --- a/src/Grace.Server/Branch.Server.fs +++ b/src/Grace.Server/Branch.Server.fs @@ -6,12 +6,16 @@ open Grace.Actors.Constants open Grace.Actors.Extensions.ActorProxy open Grace.Actors.Interfaces open Gr...
[ "src/Grace.Server/Branch.Server.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Treat unreadable ancestors as annotation boundaries**\n\nWhen the target is a valid text file but an older retained reference has the same path as binary, oversized, or otherwise unmaterializable content, this ...
true
ScottArbeit/Grace
328
comment_to_fix
Add branch annotate API and SDK wrapper
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Remove duplicate aggregate schema refs** In the generated aggregate spec, this added block creates a second `components.schemas.AnnotateParameters`/`GetReferencesParameters` definition after the fully inlined schemas already presen...
2c0265092c07919370c9e89f089affd857e7e649
93f43484515f9122613be123e3b784cc6c479469
diff --git a/src/OpenAPI/Grace.OpenAPI.yaml b/src/OpenAPI/Grace.OpenAPI.yaml index df290888..c07e7aec 100644 --- a/src/OpenAPI/Grace.OpenAPI.yaml +++ b/src/OpenAPI/Grace.OpenAPI.yaml @@ -966,6 +966,46 @@ paths: $ref: '#/components/responses/400' '500': $ref: '#/components/responses/500' +...
[ "src/OpenAPI/Grace.OpenAPI.yaml" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Remove duplicate aggregate schema refs**\n\nIn the generated aggregate spec, this added block creates a second `components.schemas.AnnotateParameters`/`GetReferencesParameters` definition after the fully inline...
true
ScottArbeit/Grace
328
comment_to_fix
Add branch annotate API and SDK wrapper
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Do not expand synthetic budget links** When a local history window is truncated, `orderedHistoryWindow` now injects a synthetic `BasedOn` link on the oldest retained reference to represent the budget boundary, but this loop treats ...
2c0265092c07919370c9e89f089affd857e7e649
93f43484515f9122613be123e3b784cc6c479469
diff --git a/src/Grace.Server/Branch.Server.fs b/src/Grace.Server/Branch.Server.fs index 31e4d51a..29001878 100644 --- a/src/Grace.Server/Branch.Server.fs +++ b/src/Grace.Server/Branch.Server.fs @@ -6,12 +6,16 @@ open Grace.Actors.Constants open Grace.Actors.Extensions.ActorProxy open Grace.Actors.Interfaces open Gr...
[ "src/Grace.Server/Branch.Server.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Do not expand synthetic budget links**\n\nWhen a local history window is truncated, `orderedHistoryWindow` now injects a synthetic `BasedOn` link on the oldest retained reference to represent the budget boundar...
true
ScottArbeit/Grace
328
comment_to_fix
Add branch annotate API and SDK wrapper
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Record path-read authorization in manifest** Fresh evidence: the current Startup route composes both `requireBranchRead` and `requireAnnotatePathRead`, but the manifest records only `Authorized(BranchRead, Branch)`. The endpoint au...
2c0265092c07919370c9e89f089affd857e7e649
93f43484515f9122613be123e3b784cc6c479469
diff --git a/src/Grace.Server/Security/EndpointAuthorizationManifest.Server.fs b/src/Grace.Server/Security/EndpointAuthorizationManifest.Server.fs index dc79a167..7693f780 100644 --- a/src/Grace.Server/Security/EndpointAuthorizationManifest.Server.fs +++ b/src/Grace.Server/Security/EndpointAuthorizationManifest.Server....
[ "src/Grace.Server/Security/EndpointAuthorizationManifest.Server.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Record path-read authorization in manifest**\n\nFresh evidence: the current Startup route composes both `requireBranchRead` and `requireAnnotatePathRead`, but the manifest records only `Authorized(BranchRead, B...
true
ScottArbeit/Grace
328
comment_to_fix
Add branch annotate API and SDK wrapper
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Return a 400 when the annotate body is null** When an authenticated caller posts JSON `null` to `/branch/annotate`, `BindJsonAsync<AnnotateParameters>()` can return a null parameters object and this line dereferences it before the ...
2c0265092c07919370c9e89f089affd857e7e649
93f43484515f9122613be123e3b784cc6c479469
diff --git a/src/Grace.Server/Startup.Server.fs b/src/Grace.Server/Startup.Server.fs index 75018886..97e0875d 100644 --- a/src/Grace.Server/Startup.Server.fs +++ b/src/Grace.Server/Startup.Server.fs @@ -210,6 +210,26 @@ module Application = return StorageAuthorizationResources.downloadUriResource grace...
[ "src/Grace.Server/Startup.Server.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Return a 400 when the annotate body is null**\n\nWhen an authenticated caller posts JSON `null` to `/branch/annotate`, `BindJsonAsync<AnnotateParameters>()` can return a null parameters object and this line der...
true
ScottArbeit/Grace
327
issue_to_patch
[Branch annotate V1 S5] Traverse effective history attribution
## Summary - Add pure effective branch history traversal for annotation inputs, following `BasedOn` links from the target reference through authorized ancestors and returning explicit boundary kinds for missing parents, unauthorized ancestors, loops/repeated links, and traversal budget exhaustion. - Update annotation ...
78b39a58a9a30954141934a65da6a2f8595e81c6
73575d6eed3869a07f2966067f25308f4719717a
diff --git a/src/Grace.Server.Unit.Tests/AnnotationLineCore.Tests.fs b/src/Grace.Server.Unit.Tests/AnnotationLineCore.Tests.fs index faf8b3f2..6deebbcb 100644 --- a/src/Grace.Server.Unit.Tests/AnnotationLineCore.Tests.fs +++ b/src/Grace.Server.Unit.Tests/AnnotationLineCore.Tests.fs @@ -15,9 +15,11 @@ type AnnotationLin...
[ "src/Grace.Server.Unit.Tests/AnnotationLineCore.Tests.fs", "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve non-budget traversal boundaries**\n\nWhen `traverseEffectiveBranchHistory` stops at `UnauthorizedAncestor`, `MissingParentReference`, or `BasedOnLoopOrRepeatedLink`, it returns only the reachable suffi...
true
ScottArbeit/Grace
327
comment_to_fix
[Branch annotate V1 S5] Traverse effective history attribution
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve non-budget traversal boundaries** When `traverseEffectiveBranchHistory` stops at `UnauthorizedAncestor`, `MissingParentReference`, or `BasedOnLoopOrRepeatedLink`, it returns only the reachable suffix, often just the target...
78b39a58a9a30954141934a65da6a2f8595e81c6
73575d6eed3869a07f2966067f25308f4719717a
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs index 28e92631..9f62f364 100644 --- a/src/Grace.Shared/AnnotationLineCore.Shared.fs +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -14,6 +14,10 @@ module AnnotationLineCore = type AnnotationHistoryD...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve non-budget traversal boundaries**\n\nWhen `traverseEffectiveBranchHistory` stops at `UnauthorizedAncestor`, `MissingParentReference`, or `BasedOnLoopOrRepeatedLink`, it returns only the reachable suffi...
true
ScottArbeit/Grace
327
comment_to_fix
[Branch annotate V1 S5] Traverse effective history attribution
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Validate only the history kept by the budget** When `history.Length > maxReferences`, the implementation later traces only `history[history.Length - maxReferences ..]` and reports a `TraversalBudgetReached` boundary, but this loop ...
78b39a58a9a30954141934a65da6a2f8595e81c6
73575d6eed3869a07f2966067f25308f4719717a
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs index 28e92631..9f62f364 100644 --- a/src/Grace.Shared/AnnotationLineCore.Shared.fs +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -14,6 +14,10 @@ module AnnotationLineCore = type AnnotationHistoryD...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Validate only the history kept by the budget**\n\nWhen `history.Length > maxReferences`, the implementation later traces only `history[history.Length - maxReferences ..]` and reports a `TraversalBudgetReached` ...
true
ScottArbeit/Grace
326
issue_to_patch
[Branch annotate V1 S3] Build pure annotation line core
## Summary - Adds a pure `Grace.Shared.AnnotationLineCore` module for V1 exact-path annotation line handling. - Implements strict UTF-8/BOM handling, CRLF/CR normalization, visible 1-based line extraction, whitespace-sensitive comparison, continuity tracing, deterministic spans/source rows/boundaries, and exact cov...
91e95626a6f9ad7068dc68627fdcb92cf9b9a793
847fa6c33a77583ab7df5933bac15b23d1b56406
diff --git a/src/Grace.Server.Unit.Tests/AnnotationLineCore.Tests.fs b/src/Grace.Server.Unit.Tests/AnnotationLineCore.Tests.fs new file mode 100644 index 00000000..faf8b3f2 --- /dev/null +++ b/src/Grace.Server.Unit.Tests/AnnotationLineCore.Tests.fs @@ -0,0 +1,720 @@ +namespace Grace.Server.Tests + +open Grace.Shared.An...
[ "src/Grace.Server.Unit.Tests/AnnotationLineCore.Tests.fs", "src/Grace.Server.Unit.Tests/Grace.Server.Unit.Tests.fsproj", "src/Grace.Shared/AnnotationLineCore.Shared.fs", "src/Grace.Shared/Grace.Shared.fsproj" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Honor reference-type filters while tracing**\n\nWhen `buildAnnotation` is given mixed reference history (for example `ReferenceTypes = [| Commit |]` but a previous document is a `Save`), this comparison still l...
true
ScottArbeit/Grace
326
comment_to_fix
[Branch annotate V1 S3] Build pure annotation line core
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Honor reference-type filters while tracing** When `buildAnnotation` is given mixed reference history (for example `ReferenceTypes = [| Commit |]` but a previous document is a `Save`), this comparison still lets the filtered-out doc...
91e95626a6f9ad7068dc68627fdcb92cf9b9a793
847fa6c33a77583ab7df5933bac15b23d1b56406
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs new file mode 100644 index 00000000..28e92631 --- /dev/null +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -0,0 +1,608 @@ +namespace Grace.Shared + +open Grace.Shared.Utilities +open Grace.Types.Annotation...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Honor reference-type filters while tracing**\n\nWhen `buildAnnotation` is given mixed reference history (for example `ReferenceTypes = [| Commit |]` but a previous document is a `Save`), this comparison still l...
true
ScottArbeit/Grace
326
comment_to_fix
[Branch annotate V1 S3] Build pure annotation line core
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Enforce the source-reference budget** When `maxReferences` is smaller than the number of distinct references needed for the requested lines, this keeps every used source reference and then returns `Ok` even though `validate` reject...
91e95626a6f9ad7068dc68627fdcb92cf9b9a793
847fa6c33a77583ab7df5933bac15b23d1b56406
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs new file mode 100644 index 00000000..28e92631 --- /dev/null +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -0,0 +1,608 @@ +namespace Grace.Shared + +open Grace.Shared.Utilities +open Grace.Types.Annotation...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Enforce the source-reference budget**\n\nWhen `maxReferences` is smaller than the number of distinct references needed for the requested lines, this keeps every used source reference and then returns `Ok` even ...
true
ScottArbeit/Grace
326
comment_to_fix
[Branch annotate V1 S3] Build pure annotation line core
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Validate that history ends at the target reference** When `history` is non-empty but its last document belongs to a different `ReferenceId` than `targetReferenceId`, this still builds an annotation whose `TargetReferenceId` names o...
91e95626a6f9ad7068dc68627fdcb92cf9b9a793
847fa6c33a77583ab7df5933bac15b23d1b56406
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs new file mode 100644 index 00000000..28e92631 --- /dev/null +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -0,0 +1,608 @@ +namespace Grace.Shared + +open Grace.Shared.Utilities +open Grace.Types.Annotation...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Validate that history ends at the target reference**\n\nWhen `history` is non-empty but its last document belongs to a different `ReferenceId` than `targetReferenceId`, this still builds an annotation whose `Ta...
true
ScottArbeit/Grace
326
comment_to_fix
[Branch annotate V1 S3] Build pure annotation line core
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Skip excluded history before decoding content** When `ReferenceTypeFilter` excludes an intermediate history entry and that excluded document contains invalid UTF-8, this still decodes the raw `history` array and returns an error be...
91e95626a6f9ad7068dc68627fdcb92cf9b9a793
847fa6c33a77583ab7df5933bac15b23d1b56406
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs new file mode 100644 index 00000000..28e92631 --- /dev/null +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -0,0 +1,608 @@ +namespace Grace.Shared + +open Grace.Shared.Utilities +open Grace.Types.Annotation...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Skip excluded history before decoding content**\n\nWhen `ReferenceTypeFilter` excludes an intermediate history entry and that excluded document contains invalid UTF-8, this still decodes the raw `history` array...
true
ScottArbeit/Grace
326
comment_to_fix
[Branch annotate V1 S3] Build pure annotation line core
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Filter history before validating document paths** When a caller requests a filtered annotation, e.g. `ReferenceTypeFilter = [| Commit |]`, an excluded intermediate `Save` document with a different path still causes `buildAnnotation...
91e95626a6f9ad7068dc68627fdcb92cf9b9a793
847fa6c33a77583ab7df5933bac15b23d1b56406
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs new file mode 100644 index 00000000..28e92631 --- /dev/null +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -0,0 +1,608 @@ +namespace Grace.Shared + +open Grace.Shared.Utilities +open Grace.Types.Annotation...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Filter history before validating document paths**\n\nWhen a caller requests a filtered annotation, e.g. `ReferenceTypeFilter = [| Commit |]`, an excluded intermediate `Save` document with a different path still...
true
ScottArbeit/Grace
326
comment_to_fix
[Branch annotate V1 S3] Build pure annotation line core
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject unknown reference types before returning Ok** When the request has no `ReferenceTypeFilter`, this predicate accepts every persisted `SourceReference.ReferenceType`, including an unknown string. If that document is used as th...
91e95626a6f9ad7068dc68627fdcb92cf9b9a793
847fa6c33a77583ab7df5933bac15b23d1b56406
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs new file mode 100644 index 00000000..28e92631 --- /dev/null +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -0,0 +1,608 @@ +namespace Grace.Shared + +open Grace.Shared.Utilities +open Grace.Types.Annotation...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject unknown reference types before returning Ok**\n\nWhen the request has no `ReferenceTypeFilter`, this predicate accepts every persisted `SourceReference.ReferenceType`, including an unknown string. If tha...
true
ScottArbeit/Grace
326
comment_to_fix
[Branch annotate V1 S3] Build pure annotation line core
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject unknown target references past EOF** When `ReferenceTypeFilter` is empty and the target history document has an unknown `ReferenceType`, a request for lines past EOF (or an empty file) produces only `TargetLineMissing` bound...
91e95626a6f9ad7068dc68627fdcb92cf9b9a793
847fa6c33a77583ab7df5933bac15b23d1b56406
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs new file mode 100644 index 00000000..28e92631 --- /dev/null +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -0,0 +1,608 @@ +namespace Grace.Shared + +open Grace.Shared.Utilities +open Grace.Types.Annotation...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject unknown target references past EOF**\n\nWhen `ReferenceTypeFilter` is empty and the target history document has an unknown `ReferenceType`, a request for lines past EOF (or an empty file) produces only `...
true
ScottArbeit/Grace
326
comment_to_fix
[Branch annotate V1 S3] Build pure annotation line core
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Deduplicate repeated source references before budgeting** When the history array contains the same `SourceReferenceId` more than once and that id is used by a span, this collects every matching history entry rather than the distinc...
91e95626a6f9ad7068dc68627fdcb92cf9b9a793
847fa6c33a77583ab7df5933bac15b23d1b56406
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs new file mode 100644 index 00000000..28e92631 --- /dev/null +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -0,0 +1,608 @@ +namespace Grace.Shared + +open Grace.Shared.Utilities +open Grace.Types.Annotation...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Deduplicate repeated source references before budgeting**\n\nWhen the history array contains the same `SourceReferenceId` more than once and that id is used by a span, this collects every matching history entry...
true
ScottArbeit/Grace
326
comment_to_fix
[Branch annotate V1 S3] Build pure annotation line core
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject blank source reference ids** When a used history document has a blank `SourceReferenceId`, this loop only checks the reference type and `buildAnnotation` can return `Ok` with a `SourceReferences` entry that `validateLinkInte...
91e95626a6f9ad7068dc68627fdcb92cf9b9a793
847fa6c33a77583ab7df5933bac15b23d1b56406
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs new file mode 100644 index 00000000..28e92631 --- /dev/null +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -0,0 +1,608 @@ +namespace Grace.Shared + +open Grace.Shared.Utilities +open Grace.Types.Annotation...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject blank source reference ids**\n\nWhen a used history document has a blank `SourceReferenceId`, this loop only checks the reference type and `buildAnnotation` can return `Ok` with a `SourceReferences` entr...
true
ScottArbeit/Grace
326
comment_to_fix
[Branch annotate V1 S3] Build pure annotation line core
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Bound requested annotation ranges** When a caller passes a very large but otherwise valid range, e.g. `StartLine = 1` and `EndLine = 2_000_000` for an empty or short file, this builds one `AnnotationLineState` per requested line be...
91e95626a6f9ad7068dc68627fdcb92cf9b9a793
847fa6c33a77583ab7df5933bac15b23d1b56406
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs new file mode 100644 index 00000000..28e92631 --- /dev/null +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -0,0 +1,608 @@ +namespace Grace.Shared + +open Grace.Shared.Utilities +open Grace.Types.Annotation...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Bound requested annotation ranges**\n\nWhen a caller passes a very large but otherwise valid range, e.g. `StartLine = 1` and `EndLine = 2_000_000` for an empty or short file, this builds one `AnnotationLineStat...
true
ScottArbeit/Grace
326
comment_to_fix
[Branch annotate V1 S3] Build pure annotation line core
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve shifted unchanged lines across insertions** When an earlier edit inserts or deletes lines before unchanged content, this only compares the target line to the same 1-based line number in the previous document, so a history ...
91e95626a6f9ad7068dc68627fdcb92cf9b9a793
847fa6c33a77583ab7df5933bac15b23d1b56406
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs new file mode 100644 index 00000000..28e92631 --- /dev/null +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -0,0 +1,608 @@ +namespace Grace.Shared + +open Grace.Shared.Utilities +open Grace.Types.Annotation...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve shifted unchanged lines across insertions**\n\nWhen an earlier edit inserts or deletes lines before unchanged content, this only compares the target line to the same 1-based line number in the previous...
true
ScottArbeit/Grace
326
comment_to_fix
[Branch annotate V1 S3] Build pure annotation line core
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Bound longest-block alignment scans** When annotating a large file whose common content is shifted rather than matched by the prefix/suffix fast paths, this loop tries every old/new line pair and then extends each match in the inne...
91e95626a6f9ad7068dc68627fdcb92cf9b9a793
847fa6c33a77583ab7df5933bac15b23d1b56406
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs new file mode 100644 index 00000000..28e92631 --- /dev/null +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -0,0 +1,608 @@ +namespace Grace.Shared + +open Grace.Shared.Utilities +open Grace.Types.Annotation...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Bound longest-block alignment scans**\n\nWhen annotating a large file whose common content is shifted rather than matched by the prefix/suffix fast paths, this loop tries every old/new line pair and then extend...
true
ScottArbeit/Grace
326
comment_to_fix
[Branch annotate V1 S3] Build pure annotation line core
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve unchanged blocks between replacements** When unchanged lines are surrounded by edits on both sides, for example old `before\nkeep\nafter` to new `changed\nkeep\nchanged`, the prefix/suffix scans stop at the outer replaceme...
91e95626a6f9ad7068dc68627fdcb92cf9b9a793
847fa6c33a77583ab7df5933bac15b23d1b56406
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs new file mode 100644 index 00000000..28e92631 --- /dev/null +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -0,0 +1,608 @@ +namespace Grace.Shared + +open Grace.Shared.Utilities +open Grace.Types.Annotation...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve unchanged blocks between replacements**\n\nWhen unchanged lines are surrounded by edits on both sides, for example old `before\\nkeep\\nafter` to new `changed\\nkeep\\nchanged`, the prefix/suffix scans...
true
ScottArbeit/Grace
326
comment_to_fix
[Branch annotate V1 S3] Build pure annotation line core
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve anchored common blocks when an earlier tie fails** When a moved line ties the length of a later in-place unchanged block, this keeps only the first block encountered and the later `canAnchorBlock` guard drops it without tr...
91e95626a6f9ad7068dc68627fdcb92cf9b9a793
847fa6c33a77583ab7df5933bac15b23d1b56406
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs new file mode 100644 index 00000000..28e92631 --- /dev/null +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -0,0 +1,608 @@ +namespace Grace.Shared + +open Grace.Shared.Utilities +open Grace.Types.Annotation...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve anchored common blocks when an earlier tie fails**\n\nWhen a moved line ties the length of a later in-place unchanged block, this keeps only the first block encountered and the later `canAnchorBlock` g...
true
ScottArbeit/Grace
326
comment_to_fix
[Branch annotate V1 S3] Build pure annotation line core
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Return a boundary when shifted alignment exceeds the scan budget** When a shifted unchanged region is larger than the scan budget, this skips the block search and returns no alignment, so `traceLineSource` falls back to a resolved ...
91e95626a6f9ad7068dc68627fdcb92cf9b9a793
847fa6c33a77583ab7df5933bac15b23d1b56406
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs new file mode 100644 index 00000000..28e92631 --- /dev/null +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -0,0 +1,608 @@ +namespace Grace.Shared + +open Grace.Shared.Utilities +open Grace.Types.Annotation...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Return a boundary when shifted alignment exceeds the scan budget**\n\nWhen a shifted unchanged region is larger than the scan budget, this skips the block search and returns no alignment, so `traceLineSource` f...
true
ScottArbeit/Grace
326
comment_to_fix
[Branch annotate V1 S3] Build pure annotation line core
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Prefer anchored blocks over longer unanchored moves** When a longer moved block and a shorter anchored unchanged block both exist in the residual range, this update keeps the longer match even when `canAnchor` is false, and the cal...
91e95626a6f9ad7068dc68627fdcb92cf9b9a793
847fa6c33a77583ab7df5933bac15b23d1b56406
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs new file mode 100644 index 00000000..28e92631 --- /dev/null +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -0,0 +1,608 @@ +namespace Grace.Shared + +open Grace.Shared.Utilities +open Grace.Types.Annotation...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Prefer anchored blocks over longer unanchored moves**\n\nWhen a longer moved block and a shorter anchored unchanged block both exist in the residual range, this update keeps the longer match even when `canAncho...
true
ScottArbeit/Grace
326
comment_to_fix
[Branch annotate V1 S3] Build pure annotation line core
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Avoid whole-file alignment for tiny annotation ranges** When the annotated file is very large but the request covers only a small range, every adjacent history pair still allocates an alignment array for the entire current document...
91e95626a6f9ad7068dc68627fdcb92cf9b9a793
847fa6c33a77583ab7df5933bac15b23d1b56406
diff --git a/src/Grace.Shared/AnnotationLineCore.Shared.fs b/src/Grace.Shared/AnnotationLineCore.Shared.fs new file mode 100644 index 00000000..28e92631 --- /dev/null +++ b/src/Grace.Shared/AnnotationLineCore.Shared.fs @@ -0,0 +1,608 @@ +namespace Grace.Shared + +open Grace.Shared.Utilities +open Grace.Types.Annotation...
[ "src/Grace.Shared/AnnotationLineCore.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Avoid whole-file alignment for tiny annotation ranges**\n\nWhen the annotated file is very large but the request covers only a small range, every adjacent history pair still allocates an alignment array for the...
true
ScottArbeit/Grace
325
issue_to_patch
[Branch annotate V1 S4] Materialize server text content
## Summary - Adds an internal server materialization boundary for annotation target text. - Supports WholeFileContent and FileManifest-backed content using FileVersion.ContentReference as source of truth. - Rejects binary, invalid UTF-8, too-large, missing/unreadable, size/hash mismatch, missing manifest, unsupported ...
69340186e8ce6a5c1c12d7fb3c86c6293165ac25
87b3d211446253aca945d67ad66622a39beef389
diff --git a/src/Grace.Server.Unit.Tests/AnnotationMaterialization.Server.Tests.fs b/src/Grace.Server.Unit.Tests/AnnotationMaterialization.Server.Tests.fs new file mode 100644 index 00000000..6ac96c1e --- /dev/null +++ b/src/Grace.Server.Unit.Tests/AnnotationMaterialization.Server.Tests.fs @@ -0,0 +1,188 @@ +namespace ...
[ "src/Grace.Server.Unit.Tests/AnnotationMaterialization.Server.Tests.fs", "src/Grace.Server.Unit.Tests/Grace.Server.Unit.Tests.fsproj", "src/Grace.Server/AnnotationMaterialization.Server.fs", "src/Grace.Server/Grace.Server.fsproj" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Decompress whole-file text before validating**\n\nFor non-binary WholeFileContent uploaded through the normal SDK path, the blob payload is gzip-compressed before upload (`Storage.SDK.fs` sets `ContentEncoding ...
true
ScottArbeit/Grace
325
comment_to_fix
[Branch annotate V1 S4] Materialize server text content
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Decompress whole-file text before validating** For non-binary WholeFileContent uploaded through the normal SDK path, the blob payload is gzip-compressed before upload (`Storage.SDK.fs` sets `ContentEncoding = "gzip"` and writes a `...
69340186e8ce6a5c1c12d7fb3c86c6293165ac25
87b3d211446253aca945d67ad66622a39beef389
diff --git a/src/Grace.Server/AnnotationMaterialization.Server.fs b/src/Grace.Server/AnnotationMaterialization.Server.fs new file mode 100644 index 00000000..7365b96c --- /dev/null +++ b/src/Grace.Server/AnnotationMaterialization.Server.fs @@ -0,0 +1,276 @@ +namespace Grace.Server + +open Azure +open Grace.Actors.Servi...
[ "src/Grace.Server/AnnotationMaterialization.Server.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Decompress whole-file text before validating**\n\nFor non-binary WholeFileContent uploaded through the normal SDK path, the blob payload is gzip-compressed before upload (`Storage.SDK.fs` sets `ContentEncoding ...
true
ScottArbeit/Grace
324
issue_to_patch
[Branch annotate V1 S2] Define annotation DTOs and parameters
## Summary - Defines V1 branch annotation DTO contracts for line ranges, spans, boundaries, line/source rows, and source references. - Adds `/branch/annotate` parameter contract with max-reference defaults and bounds. - Adds focused contract tests for serialization shape, range/budget validation, line-text omission, a...
d369d4ab27944ac06b7a442ba91dc1a79b91bf75
64baa10ceaba993841184f7e9557a7f1fab6d664
diff --git a/src/Grace.Shared/Parameters/Branch.Parameters.fs b/src/Grace.Shared/Parameters/Branch.Parameters.fs index ddd1947b..2133aee2 100644 --- a/src/Grace.Shared/Parameters/Branch.Parameters.fs +++ b/src/Grace.Shared/Parameters/Branch.Parameters.fs @@ -1,8 +1,10 @@ namespace Grace.Shared.Parameters open Grace...
[ "src/Grace.Shared/Parameters/Branch.Parameters.fs", "src/Grace.Types.Tests/Annotation.Types.Tests.fs", "src/Grace.Types.Tests/Grace.Types.Tests.fsproj", "src/Grace.Types/Annotation.Types.fs", "src/Grace.Types/Grace.Types.fsproj" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Don’t require boundaries for every span**\n\nFor a fully resolved annotation, spans can have complete source attribution while `Boundaries` is empty; the project glossary defines boundaries as cases where Grace...
true
ScottArbeit/Grace
324
comment_to_fix
[Branch annotate V1 S2] Define annotation DTOs and parameters
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Don’t require boundaries for every span** For a fully resolved annotation, spans can have complete source attribution while `Boundaries` is empty; the project glossary defines boundaries as cases where Grace cannot fully prove one ...
d369d4ab27944ac06b7a442ba91dc1a79b91bf75
64baa10ceaba993841184f7e9557a7f1fab6d664
diff --git a/src/Grace.Types/Annotation.Types.fs b/src/Grace.Types/Annotation.Types.fs new file mode 100644 index 00000000..8991998b --- /dev/null +++ b/src/Grace.Types/Annotation.Types.fs @@ -0,0 +1,449 @@ +namespace Grace.Types + +open Grace.Types.Common +open Grace.Shared.Utilities +open global.MessagePack +open glo...
[ "src/Grace.Types/Annotation.Types.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Don’t require boundaries for every span**\n\nFor a fully resolved annotation, spans can have complete source attribution while `Boundaries` is empty; the project glossary defines boundaries as cases where Grace...
true
ScottArbeit/Grace
324
comment_to_fix
[Branch annotate V1 S2] Define annotation DTOs and parameters
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include the reference creator in source references** Branch annotation output is expected to expose the Reference creator when available, and `ReferenceDto` already persists that value as `CreatedBy`; this source-reference contract...
d369d4ab27944ac06b7a442ba91dc1a79b91bf75
64baa10ceaba993841184f7e9557a7f1fab6d664
diff --git a/src/Grace.Types/Annotation.Types.fs b/src/Grace.Types/Annotation.Types.fs new file mode 100644 index 00000000..8991998b --- /dev/null +++ b/src/Grace.Types/Annotation.Types.fs @@ -0,0 +1,449 @@ +namespace Grace.Types + +open Grace.Types.Common +open Grace.Shared.Utilities +open global.MessagePack +open glo...
[ "src/Grace.Types/Annotation.Types.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include the reference creator in source references**\n\nBranch annotation output is expected to expose the Reference creator when available, and `ReferenceDto` already persists that value as `CreatedBy`; this s...
true
ScottArbeit/Grace
324
comment_to_fix
[Branch annotate V1 S2] Define annotation DTOs and parameters
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Keep emitted spans inside the requested range** When a response asks for `RequestedLineRange = 10..12`, a span such as `100..101` still passes validation here because `validateLineRange` only checks that the range is positive and o...
d369d4ab27944ac06b7a442ba91dc1a79b91bf75
64baa10ceaba993841184f7e9557a7f1fab6d664
diff --git a/src/Grace.Types/Annotation.Types.fs b/src/Grace.Types/Annotation.Types.fs new file mode 100644 index 00000000..8991998b --- /dev/null +++ b/src/Grace.Types/Annotation.Types.fs @@ -0,0 +1,449 @@ +namespace Grace.Types + +open Grace.Types.Common +open Grace.Shared.Utilities +open global.MessagePack +open glo...
[ "src/Grace.Types/Annotation.Types.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Keep emitted spans inside the requested range**\n\nWhen a response asks for `RequestedLineRange = 10..12`, a span such as `100..101` still passes validation here because `validateLineRange` only checks that the...
true
ScottArbeit/Grace
324
comment_to_fix
[Branch annotate V1 S2] Define annotation DTOs and parameters
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject cross-path source rows for V1** For V1 exact-path annotation, source rows should stay at the annotated `RelativePath`; the context explicitly excludes rename/copy following and treats delete-plus-add or rename-like history a...
d369d4ab27944ac06b7a442ba91dc1a79b91bf75
64baa10ceaba993841184f7e9557a7f1fab6d664
diff --git a/src/Grace.Types/Annotation.Types.fs b/src/Grace.Types/Annotation.Types.fs new file mode 100644 index 00000000..8991998b --- /dev/null +++ b/src/Grace.Types/Annotation.Types.fs @@ -0,0 +1,449 @@ +namespace Grace.Types + +open Grace.Types.Common +open Grace.Shared.Utilities +open global.MessagePack +open glo...
[ "src/Grace.Types/Annotation.Types.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject cross-path source rows for V1**\n\nFor V1 exact-path annotation, source rows should stay at the annotated `RelativePath`; the context explicitly excludes rename/copy following and treats delete-plus-add ...
true
ScottArbeit/Grace
324
comment_to_fix
[Branch annotate V1 S2] Define annotation DTOs and parameters
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Enforce the emitted source-reference budget** `MaxReferences` is validated only as a parameter value, not against the result payload; an annotation with `MaxReferences = 1000` and 2000 `SourceReferences` still returns `Ok`. If late...
d369d4ab27944ac06b7a442ba91dc1a79b91bf75
64baa10ceaba993841184f7e9557a7f1fab6d664
diff --git a/src/Grace.Types/Annotation.Types.fs b/src/Grace.Types/Annotation.Types.fs new file mode 100644 index 00000000..8991998b --- /dev/null +++ b/src/Grace.Types/Annotation.Types.fs @@ -0,0 +1,449 @@ +namespace Grace.Types + +open Grace.Types.Common +open Grace.Shared.Utilities +open global.MessagePack +open glo...
[ "src/Grace.Types/Annotation.Types.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Enforce the emitted source-reference budget**\n\n`MaxReferences` is validated only as a parameter value, not against the result payload; an annotation with `MaxReferences = 1000` and 2000 `SourceReferences` sti...
true
ScottArbeit/Grace
324
comment_to_fix
[Branch annotate V1 S2] Define annotation DTOs and parameters
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject blank annotation identifiers** Because blank IDs are filtered out of duplicate detection and no later check rejects them, multiple source rows or references with `""` IDs can pass validation; sets built from those IDs then l...
d369d4ab27944ac06b7a442ba91dc1a79b91bf75
64baa10ceaba993841184f7e9557a7f1fab6d664
diff --git a/src/Grace.Types/Annotation.Types.fs b/src/Grace.Types/Annotation.Types.fs new file mode 100644 index 00000000..8991998b --- /dev/null +++ b/src/Grace.Types/Annotation.Types.fs @@ -0,0 +1,449 @@ +namespace Grace.Types + +open Grace.Types.Common +open Grace.Shared.Utilities +open global.MessagePack +open glo...
[ "src/Grace.Types/Annotation.Types.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject blank annotation identifiers**\n\nBecause blank IDs are filtered out of duplicate detection and no later check rejects them, multiple source rows or references with `\"\"` IDs can pass validation; sets b...
true
ScottArbeit/Grace
324
comment_to_fix
[Branch annotate V1 S2] Define annotation DTOs and parameters
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Hide computed LineRange from the wire contract** This public getter will be discovered by the JSON/OpenAPI surface for `AnnotateParameters`, so generated clients can see a duplicate `LineRange` field alongside `StartLine` and `EndL...
d369d4ab27944ac06b7a442ba91dc1a79b91bf75
64baa10ceaba993841184f7e9557a7f1fab6d664
diff --git a/src/Grace.Shared/Parameters/Branch.Parameters.fs b/src/Grace.Shared/Parameters/Branch.Parameters.fs index ddd1947b..2133aee2 100644 --- a/src/Grace.Shared/Parameters/Branch.Parameters.fs +++ b/src/Grace.Shared/Parameters/Branch.Parameters.fs @@ -1,8 +1,10 @@ namespace Grace.Shared.Parameters open Grace...
[ "src/Grace.Shared/Parameters/Branch.Parameters.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Hide computed LineRange from the wire contract**\n\nThis public getter will be discovered by the JSON/OpenAPI surface for `AnnotateParameters`, so generated clients can see a duplicate `LineRange` field alongsi...
true
ScottArbeit/Grace
324
comment_to_fix
[Branch annotate V1 S2] Define annotation DTOs and parameters
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Make annotation DTOs MessagePack-serializable** When this DTO is serialized through Grace's configured `Constants.messagePackSerializerOptions`, even `BranchAnnotationDto.Default` throws at runtime because the `ReferenceType` DU fo...
d369d4ab27944ac06b7a442ba91dc1a79b91bf75
64baa10ceaba993841184f7e9557a7f1fab6d664
diff --git a/src/Grace.Types/Annotation.Types.fs b/src/Grace.Types/Annotation.Types.fs new file mode 100644 index 00000000..8991998b --- /dev/null +++ b/src/Grace.Types/Annotation.Types.fs @@ -0,0 +1,449 @@ +namespace Grace.Types + +open Grace.Types.Common +open Grace.Shared.Utilities +open global.MessagePack +open glo...
[ "src/Grace.Types/Annotation.Types.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Make annotation DTOs MessagePack-serializable**\n\nWhen this DTO is serialized through Grace's configured `Constants.messagePackSerializerOptions`, even `BranchAnnotationDto.Default` throws at runtime because t...
true
ScottArbeit/Grace
324
comment_to_fix
[Branch annotate V1 S2] Define annotation DTOs and parameters
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Constrain all emitted target ranges to the request** This request-bound check only applies to `Spans`, so a DTO can still validate while returning `Lines` or `Boundaries` whose line numbers are outside `RequestedLineRange`. For `/b...
d369d4ab27944ac06b7a442ba91dc1a79b91bf75
64baa10ceaba993841184f7e9557a7f1fab6d664
diff --git a/src/Grace.Types/Annotation.Types.fs b/src/Grace.Types/Annotation.Types.fs new file mode 100644 index 00000000..8991998b --- /dev/null +++ b/src/Grace.Types/Annotation.Types.fs @@ -0,0 +1,449 @@ +namespace Grace.Types + +open Grace.Types.Common +open Grace.Shared.Utilities +open global.MessagePack +open glo...
[ "src/Grace.Types/Annotation.Types.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Constrain all emitted target ranges to the request**\n\nThis request-bound check only applies to `Spans`, so a DTO can still validate while returning `Lines` or `Boundaries` whose line numbers are outside `Requ...
true
ScottArbeit/Grace
324
comment_to_fix
[Branch annotate V1 S2] Define annotation DTOs and parameters
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Require source rows for resolved spans** For a span with an empty `BoundaryId`, this check only rejects source-row IDs that are present but missing; an empty `SourceRowIds` array passes validation. That allows a `/branch/annotate` ...
d369d4ab27944ac06b7a442ba91dc1a79b91bf75
64baa10ceaba993841184f7e9557a7f1fab6d664
diff --git a/src/Grace.Types/Annotation.Types.fs b/src/Grace.Types/Annotation.Types.fs new file mode 100644 index 00000000..8991998b --- /dev/null +++ b/src/Grace.Types/Annotation.Types.fs @@ -0,0 +1,449 @@ +namespace Grace.Types + +open Grace.Types.Common +open Grace.Shared.Utilities +open global.MessagePack +open glo...
[ "src/Grace.Types/Annotation.Types.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Require source rows for resolved spans**\n\nFor a span with an empty `BoundaryId`, this check only rejects source-row IDs that are present but missing; an empty `SourceRowIds` array passes validation. That allo...
true
ScottArbeit/Grace
324
comment_to_fix
[Branch annotate V1 S2] Define annotation DTOs and parameters
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject line text when not requested** When a response DTO is deserialized or built with record updates instead of `BranchAnnotationDto.Create`, `validate` still accepts `IncludeLineText = false` together with a non-empty `Lines` ar...
d369d4ab27944ac06b7a442ba91dc1a79b91bf75
64baa10ceaba993841184f7e9557a7f1fab6d664
diff --git a/src/Grace.Types/Annotation.Types.fs b/src/Grace.Types/Annotation.Types.fs new file mode 100644 index 00000000..8991998b --- /dev/null +++ b/src/Grace.Types/Annotation.Types.fs @@ -0,0 +1,449 @@ +namespace Grace.Types + +open Grace.Types.Common +open Grace.Shared.Utilities +open global.MessagePack +open glo...
[ "src/Grace.Types/Annotation.Types.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject line text when not requested**\n\nWhen a response DTO is deserialized or built with record updates instead of `BranchAnnotationDto.Create`, `validate` still accepts `IncludeLineText = false` together wit...
true
ScottArbeit/Grace
324
comment_to_fix
[Branch annotate V1 S2] Define annotation DTOs and parameters
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Validate string reference-type names** Because the DTO stores reference types as strings, any payload built from deserialization or record updates can now pass `validate` with values such as `ReferenceType = "Bogus"` or a bogus `Re...
d369d4ab27944ac06b7a442ba91dc1a79b91bf75
64baa10ceaba993841184f7e9557a7f1fab6d664
diff --git a/src/Grace.Types/Annotation.Types.fs b/src/Grace.Types/Annotation.Types.fs new file mode 100644 index 00000000..8991998b --- /dev/null +++ b/src/Grace.Types/Annotation.Types.fs @@ -0,0 +1,449 @@ +namespace Grace.Types + +open Grace.Types.Common +open Grace.Shared.Utilities +open global.MessagePack +open glo...
[ "src/Grace.Types/Annotation.Types.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Validate string reference-type names**\n\nBecause the DTO stores reference types as strings, any payload built from deserialization or record updates can now pass `validate` with values such as `ReferenceType =...
true
ScottArbeit/Grace
323
issue_to_patch
[Branch annotate V1 S1] Add Reference creator identity
## Summary - Adds optional Reference creator identity to `ReferenceDto`. - Populates `CreatedBy` from nonblank `ReferenceEvent.Metadata.Principal` on Created events only. - Preserves compatibility for old/default References and update/delete event replay. ## Issue Links Part of #313 Related to #314 ## Touched Paths...
4f340466cc2079141f97f56b458d7eebb9828a0b
fc995b1fe7a10b520c7cf7818abf7697c835d12d
diff --git a/src/Grace.Types.Tests/Grace.Types.Tests.fsproj b/src/Grace.Types.Tests/Grace.Types.Tests.fsproj index dc9999c5..87d7344b 100644 --- a/src/Grace.Types.Tests/Grace.Types.Tests.fsproj +++ b/src/Grace.Types.Tests/Grace.Types.Tests.fsproj @@ -14,6 +14,7 @@ <Compile Include="AssemblyInfo.fs" /> <Compil...
[ "src/Grace.Types.Tests/Grace.Types.Tests.fsproj", "src/Grace.Types.Tests/Reference.Types.Tests.fs", "src/Grace.Types/Reference.Types.fs", "src/OpenAPI/Dto.Components.OpenAPI.yaml", "src/OpenAPI/Grace.OpenAPI.3.1.2.yaml", "src/OpenAPI/Grace.OpenAPI.yaml", "src/OpenAPI/OpenAPI.ProofManifest.json" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Update ReferenceDto schema for CreatedBy**\n\nThis adds a public field that is serialized on `ReferenceDto` responses, but the checked-in OpenAPI `ReferenceDto` schemas still only list the previous fields (chec...
true
ScottArbeit/Grace
323
comment_to_fix
[Branch annotate V1 S1] Add Reference creator identity
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Update ReferenceDto schema for CreatedBy** This adds a public field that is serialized on `ReferenceDto` responses, but the checked-in OpenAPI `ReferenceDto` schemas still only list the previous fields (checked `src/OpenAPI/Dto.Com...
4f340466cc2079141f97f56b458d7eebb9828a0b
fc995b1fe7a10b520c7cf7818abf7697c835d12d
diff --git a/src/Grace.Types/Reference.Types.fs b/src/Grace.Types/Reference.Types.fs index a43d13c9..990f25d9 100644 --- a/src/Grace.Types/Reference.Types.fs +++ b/src/Grace.Types/Reference.Types.fs @@ -88,6 +88,7 @@ module Reference = ReferenceType: ReferenceType ReferenceText: ReferenceText ...
[ "src/Grace.Types/Reference.Types.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Update ReferenceDto schema for CreatedBy**\n\nThis adds a public field that is serialized on `ReferenceDto` responses, but the checked-in OpenAPI `ReferenceDto` schemas still only list the previous fields (chec...
true
ScottArbeit/Grace
323
comment_to_fix
[Branch annotate V1 S1] Add Reference creator identity
**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Make CreatedBy tolerant of old JSON** When upgrading an environment with actor state or API payloads serialized before this field existed, those `ReferenceDto` JSON objects will not contain `CreatedBy`; Grace's shared `JsonSerializ...
4f340466cc2079141f97f56b458d7eebb9828a0b
fc995b1fe7a10b520c7cf7818abf7697c835d12d
diff --git a/src/Grace.Types/Reference.Types.fs b/src/Grace.Types/Reference.Types.fs index a43d13c9..990f25d9 100644 --- a/src/Grace.Types/Reference.Types.fs +++ b/src/Grace.Types/Reference.Types.fs @@ -88,6 +88,7 @@ module Reference = ReferenceType: ReferenceType ReferenceText: ReferenceText ...
[ "src/Grace.Types/Reference.Types.fs" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Make CreatedBy tolerant of old JSON**\n\nWhen upgrading an environment with actor state or API payloads serialized before this field existed, those `ReferenceDto` JSON objects will not contain `CreatedBy`; Grac...
true
ScottArbeit/Grace
312
issue_to_patch
Update Aspire AppHost and modernize resource wiring Objective: - Update Grace's Aspire AppHost/tooling to the latest stable Aspire version available to the repo, then modernize or explicitly document any older Aspire constructs that can now be expressed more cleanly without changing runtime behavior. Context and evid...
Update Aspire AppHost SDK and Full validation progress output
## Summary Closes #311. - Aligns the Aspire AppHost SDK with the current coherent Aspire `13.4.3` package set already used by the AppHost and integration tests. - Adds lightweight progress output for `Grace.Server.Tests` during `validate -Full`, including setup, resource readiness, approximate test count, conclusion,...
7ada65caa60c28cf28c93779aee4d2f29c62c0d9
e5e55ad8db38b0ccc8caacf39ef98587df4105f7
diff --git a/scripts/validate.ps1 b/scripts/validate.ps1 index 162d7d3d..5f47dd96 100644 --- a/scripts/validate.ps1 +++ b/scripts/validate.ps1 @@ -249,6 +249,11 @@ function Invoke-SolutionTests([string]$Configuration, [bool]$IncludeFullTests) { Write-Host "Test target: src/Grace.slnx" Write-Host ("Test filt...
[ "scripts/validate.ps1", "src/Grace.Aspire.AppHost/Grace.Aspire.AppHost.csproj", "src/Grace.Server.Tests/AspireTestHost.fs", "src/Grace.Server.Tests/General.Server.Tests.fs" ]
[]
true
ScottArbeit/Grace
309
issue_to_patch
Make grace watch duplicate-safe and add --check Objective: - Update `grace watch` so duplicate starts fail clearly when the existing `grace watch` IPC file indicates a running watcher, and add `grace watch --check` so agents can verify watcher health without treating a running watcher as an error. Context and evidenc...
Make grace watch duplicate-safe and add --check
## Summary - Adds `grace watch --check` as a non-mutating health probe for the existing Grace watch IPC status file. - Makes ordinary `grace watch` fail before startup when the same IPC status source reports an already-running watcher. - Adds an atomic IPC startup claim so simultaneous `grace watch` launches cannot bo...
74df8ef4674a60b76816bf52c0655dc7bff49f93
ac44c16d1d5bb95054e29fe7bea795d75adea792
diff --git a/src/Grace.CLI.Tests/Watch.Tests.fs b/src/Grace.CLI.Tests/Watch.Tests.fs index 63d14de2..b038a985 100644 --- a/src/Grace.CLI.Tests/Watch.Tests.fs +++ b/src/Grace.CLI.Tests/Watch.Tests.fs @@ -15,6 +15,7 @@ open System.Collections.Generic open System.Diagnostics open System.IO open System.Text.Json +open S...
[ "src/Grace.CLI.Tests/Watch.Tests.fs", "src/Grace.CLI/Command/Services.CLI.fs", "src/Grace.CLI/Command/Watch.CLI.fs", "src/Grace.CLI/Program.CLI.fs", "src/Grace.CLI/Text.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Claim the watch status atomically before startup**\n\nWhen two `grace watch` invocations for the same branch start while no IPC file exists, both can complete this `getGraceWatchStatus` check before either reac...
true
ScottArbeit/Grace
309
comment_to_fix
Make grace watch duplicate-safe and add --check
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Claim the watch status atomically before startup** When two `grace watch` invocations for the same branch start while no IPC file exists, both can complete this `getGraceWatchStatus` check before either reaches the later `updateGra...
74df8ef4674a60b76816bf52c0655dc7bff49f93
ac44c16d1d5bb95054e29fe7bea795d75adea792
diff --git a/src/Grace.CLI/Command/Watch.CLI.fs b/src/Grace.CLI/Command/Watch.CLI.fs index 797f4df9..4a069946 100644 --- a/src/Grace.CLI/Command/Watch.CLI.fs +++ b/src/Grace.CLI/Command/Watch.CLI.fs @@ -42,6 +42,8 @@ open Grace.CLI.Text open Grace.Types.Automation module Watch = + exception private WatchCommandE...
[ "src/Grace.CLI/Command/Watch.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Claim the watch status atomically before startup**\n\nWhen two `grace watch` invocations for the same branch start while no IPC file exists, both can complete this `getGraceWatchStatus` check before either reac...
true
ScottArbeit/Grace
309
comment_to_fix
Make grace watch duplicate-safe and add --check
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Avoid publishing an empty watch status during startup** When a foreground `grace watch` claims the IPC file here, it writes `GraceStatus.Default` with a fresh timestamp, so any concurrent command that runs before the later real `up...
74df8ef4674a60b76816bf52c0655dc7bff49f93
ac44c16d1d5bb95054e29fe7bea795d75adea792
diff --git a/src/Grace.CLI/Command/Services.CLI.fs b/src/Grace.CLI/Command/Services.CLI.fs index 3cf6d2bb..d4f57062 100644 --- a/src/Grace.CLI/Command/Services.CLI.fs +++ b/src/Grace.CLI/Command/Services.CLI.fs @@ -70,6 +70,7 @@ module Services = type GraceWatchStatus = { UpdatedAt: Instant +...
[ "src/Grace.CLI/Command/Services.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Avoid publishing an empty watch status during startup**\n\nWhen a foreground `grace watch` claims the IPC file here, it writes `GraceStatus.Default` with a fresh timestamp, so any concurrent command that runs b...
true
ScottArbeit/Grace
309
comment_to_fix
Make grace watch duplicate-safe and add --check
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Keep JSON mode short-circuited for watch --check** When `grace watch --check` is combined with `--output Json` or `--select`, this new foreground-only guard no longer rejects JSON mode, so the command reaches `Watch.InvokeAsync` an...
74df8ef4674a60b76816bf52c0655dc7bff49f93
ac44c16d1d5bb95054e29fe7bea795d75adea792
diff --git a/src/Grace.CLI/Program.CLI.fs b/src/Grace.CLI/Program.CLI.fs index d4f8c413..1e1f7a1d 100644 --- a/src/Grace.CLI/Program.CLI.fs +++ b/src/Grace.CLI/Program.CLI.fs @@ -945,6 +945,11 @@ module GraceCommand = /// Checks if the command is a `grace watch` command. let isGraceWatch (parseResult: ParseRe...
[ "src/Grace.CLI/Program.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Keep JSON mode short-circuited for watch --check**\n\nWhen `grace watch --check` is combined with `--output Json` or `--select`, this new foreground-only guard no longer rejects JSON mode, so the command reache...
true
ScottArbeit/Grace
74
issue_to_patch
Require PRs to state tests added or explain no-test rationale ## Objective Update the Grace pull request template so every PR explicitly states either which tests were added or updated, or why no new tests were required. ## Context and evidence The current PR template asks for validation profile, focused validation...
Require PRs to state tests added or no-test rationale
## Linked issue Closes #73 ## Summary Updates the Grace PR authoring flow so every PR has to state whether tests were added or updated, or explain why no new tests were required. The companion PR-summary prompt now asks agents to report test coverage changes separately from validation commands. Also updates Grace c...
48d3cdf4841fa8f822c9db926313dd3cab143835
0df1539a74dfd64704680e1c510515ca1218b581
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index d0c084d0..aa280b34 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -21,6 +21,15 @@ Closes # - RED evidence or docs-only waiver: - Focused validation: +## Test coverage changes + +Choose one...
[ ".github/PULL_REQUEST_TEMPLATE.md", "AGENTS.md", "CONTRIBUTING.md", "docs/Development process.md", "prompts/Grace pull request summary.md" ]
[]
true
ScottArbeit/Grace
305
issue_to_patch
Close CLI JSON docs and inventory audit
## Summary - Adds user-facing and agent-facing documentation for Grace CLI machine-readable JSON output. - Documents `--schema`, `--examples`, and V1 `--select` behavior with accepted and rejected examples. - Adds registry-backed final inventory/freshness tests for command dispositions, source-only commands, V2 deferr...
501a810321f02b8272901d8dae28a4319f8a0621
1d38e0bf64a6b90dae4e9333316d421ebace5e79
diff --git a/README.md b/README.md index af6603fd..570d106a 100644 --- a/README.md +++ b/README.md @@ -169,17 +169,48 @@ The first-time steps below use **local emulators** and **test authentication** ( grace diff checkpoint ``` -### Verify the CLI can talk to the server - -Once you have `GRACE_SERVER_U...
[ "README.md", "docs/Machine-readable CLI output.md", "src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Clarify selected output is not enveloped**\n\nWhen users add `--select` (as shown in the examples just below), the CLI does not emit a `GraceReturnValue<T>` success envelope; `Common.renderOutput` takes the sel...
true
ScottArbeit/Grace
304
issue_to_patch
Audit common CLI JSON envelope behavior
## Summary - Adds an inventory-driven audit over every `CommonRenderOutputEnvelope` registry entry. - Verifies root-recursive `--output Json`, central success/failure JSON envelopes, and exit-code behavior. - Parses JSON stdout as-is, without stripping ANSI, markup, progress text, or other human output. - Adds represe...
871c0dbabafe28f7c4bcd49880efc7af8f997dff
06edaa8eabaea1ca0236ebbf88c5a1a371752778
diff --git a/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs b/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs index dcb84c87..443bfcb5 100644 --- a/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs +++ b/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs @@ -3,8 +3,12 @@ namespace Grace.CLI.Test...
[ "src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs", "src/Grace.CLI.Tests/Program.CLI.Tests.fs" ]
[]
true
ScottArbeit/Grace
303
issue_to_patch
Make maintenance and watch JSON output safe
## Summary - Migrates maintenance progress-heavy JSON paths to envelope-backed DTO output. - Adds JSON safety handling for `watch --output Json` so it returns one clean JSON error envelope instead of starting the continuous foreground watcher. - Updates output contract registry metadata and focused output-capture test...
3f99b7d135120fc5507741b1543bc1428dfd19b6
a8ab5539075237e011e9cda6dee09155cd5bee22
diff --git a/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs b/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs index f9042947..dcb84c87 100644 --- a/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs +++ b/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs @@ -45,10 +45,12 @@ module CommandOutputC...
[ "src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs", "src/Grace.CLI.Tests/Grace.CLI.Tests.fsproj", "src/Grace.CLI.Tests/Maintenance.CLI.Tests.fs", "src/Grace.CLI.Tests/Watch.Tests.fs", "src/Grace.CLI/Command/Common.CLI.fs", "src/Grace.CLI/Command/Maintenance.CLI.fs", "src/Grace.CLI/Command/Watch.CL...
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Preserve update-index side effects in JSON mode**\n\nWhen `grace maintenance update-index --output Json` is used, this new JSON branch returns after only rewriting the local status file and upserting the local ...
true
ScottArbeit/Grace
302
issue_to_patch
Migrate local CLI JSON outputs to envelopes
## Summary - Migrates local/ad hoc CLI JSON output backlog commands toward envelope-backed JSON contracts. - Replaces manual raw JSON for history commands with typed DTOs through `renderOutput`. - Adds explicit DTO output for alias, connect, repository init, and review report export behavior. - Updates command output ...
8d3d73e51f07738fbb2e4293123b0d5b19f1dd31
ac1bea23a4344a853082639ea31e359ba274e56c
diff --git a/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs b/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs index d20d8b5c..f9042947 100644 --- a/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs +++ b/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs @@ -45,15 +45,15 @@ module CommandOutputC...
[ "src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs", "src/Grace.CLI.Tests/Program.CLI.Tests.fs", "src/Grace.CLI/Command/Common.CLI.fs", "src/Grace.CLI/Command/Connect.CLI.fs", "src/Grace.CLI/Command/History.CLI.fs", "src/Grace.CLI/Command/Repository.CLI.fs", "src/Grace.CLI/Command/Review.CLI.fs", ...
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Propagate select projection failures**\n\nWhen `history show` or `history search` is used with `--select` and the selector cannot be projected (for example a missing ReturnValue property), `renderOutput` writes...
true
ScottArbeit/Grace
301
issue_to_patch
Implement CLI ReturnValue select projection
## Summary - Adds strict V1 `--select` parsing and evaluation for successful `ReturnValue` projection only. - Wires `--select` as a recursive root option and integrates it with the central JSON writer. - Adds parser, runtime, composition, and registry tests for projection success and error behavior. ## Related Issue ...
5e59ac02309df186b0d59e451d66fe0e481a9716
d137732eeacc84d9d9518bc6b53a63fe69f4781f
diff --git a/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs b/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs index 5d5c9c7e..d20d8b5c 100644 --- a/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs +++ b/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs @@ -178,6 +178,9 @@ module CommandOutputC...
[ "src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs", "src/Grace.CLI.Tests/Grace.CLI.Tests.fsproj", "src/Grace.CLI.Tests/Program.CLI.Tests.fs", "src/Grace.CLI.Tests/SelectProjection.CLI.Parsing.Tests.fs", "src/Grace.CLI/Command/Common.CLI.fs", "src/Grace.CLI/CommandOutputContract.CLI.fs", "src/Grace...
[]
true
ScottArbeit/Grace
300
issue_to_patch
Implement CLI schema and examples introspection
## Summary - Implements registry-backed `--schema` and `--examples` outputs for representative CLI output contracts. - Adds explicit metadata-incomplete/unsupported introspection states instead of silently claiming unavailable schema success. - Adds registry and CLI invocation coverage for schema/example output shape....
ac0e35e2793b3602301f5a89b97c4d29cccfca67
8b035233906bbc9d7d1a496360635566798fe600
diff --git a/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs b/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs index f9443873..5d5c9c7e 100644 --- a/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs +++ b/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs @@ -5,6 +5,7 @@ open Grace.CLI open Grac...
[ "src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs", "src/Grace.CLI.Tests/Program.CLI.Tests.fs", "src/Grace.CLI/CommandOutputContract.CLI.fs" ]
[]
true
ScottPlot/ScottPlot
5,233
issue_to_patch
Support Avalonia 12
There are a couple of breaking API changes that I had to resolve, mostly those to do with their dev tooling. Tested on MacOS, Windows.
07fc2274045921d1fa8040f90be7f76a3c74b722
ed285396b435f424748bc6b3fefe96869ea1e938
diff --git a/src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Avalonia/AvaPlot.cs b/src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Avalonia/AvaPlot.cs index f683cdccf9..3c0441b23e 100644 --- a/src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Avalonia/AvaPlot.cs +++ b/src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Avalonia/AvaPlot....
[ "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Avalonia/AvaPlot.cs", "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Avalonia/ScottPlot.Avalonia.csproj", "src/ScottPlot5/ScottPlot5 Demos/Avalonia Demo/App.axaml.cs", "src/ScottPlot5/ScottPlot5 Demos/Avalonia Demo/Avalonia Demo.csproj", "src/ScottPlot5/ScottPlot...
[]
true
ScottPlot/ScottPlot
5,215
issue_to_patch
Invisible lines should not be interactable
when an Interactable is marked as IsVisible=false we would still have mouse cursor changes and you could drag the line location even though it wasn't visible. Updated each of the interactive controls so that GetHandle bails if it's not visible.
5e5c884bd92c9843344e1a8924c32c5c74ada7b6
b81ba0b373f7d2e6cee592b0f505fb249abf3b03
diff --git a/CHANGELOG.md b/CHANGELOG.md index d506e96e49..410e45a8ad 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ ## ScottPlot 5.1.59 _Not yet published..._ +* Avalonia: Add support for Avalonia 12 (#5233) @bclehmann +* Avalonia: Implement cross-platform copy-to-clipboard (#5167) @bclehmann +* Intera...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5/Plottables/Interactive/InteractiveHorizontalLine.cs", "src/ScottPlot5/ScottPlot5/Plottables/Interactive/InteractiveHorizontalLineSegment.cs", "src/ScottPlot5/ScottPlot5/Plottables/Interactive/InteractiveHorizontalSpan.cs", "src/ScottPlot5/ScottPlot5/Plottables/Inte...
[ { "comment": "This looks like it belongs to a separate PR. You should be able to remove this by rebasing", "path": "src/ScottPlot5/ScottPlot5/Plottables/Interactive/InteractiveTrendLine.cs", "hunk": "@@ -0,0 +1,180 @@\n+namespace ScottPlot.Plottables.Interactive;\n+\n+/// <summary>\n+/// An infinite lin...
true
ScottPlot/ScottPlot
5,167
issue_to_patch
First-pass Avalonia copy-to-clipboard
Now that https://github.com/AvaloniaUI/Avalonia/pull/19930 has been merged I can tick a feature off my list (5 years later πŸ™ƒ). We'll have to think about how we ought to disable this behaviour on earlier Avalonia versions, or just require a version that has this. This implementation is hacky and I haven't cleaned it...
63b56cfa518f12f064aaf983afe53e6236081dec
4d49d12b112bff91092f4684011c22a69475d56f
diff --git a/src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Avalonia/AvaPlotMenu.cs b/src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Avalonia/AvaPlotMenu.cs index 2c43544f98..830cf96c1c 100644 --- a/src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Avalonia/AvaPlotMenu.cs +++ b/src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Avalo...
[ "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Avalonia/AvaPlotMenu.cs", "src/ScottPlot5/ScottPlot5/IO/BitmapHeader.cs", "src/ScottPlot5/ScottPlot5/Primitives/Image.cs" ]
[]
true
ScottPlot/ScottPlot
5,178
issue_to_patch
Fix missing "else" in MouseWheelZoom (MouseAxisManipulation.cs)
I suppose an "else" is missing in the MouseWheelZoom function: https://github.com/ScottPlot/ScottPlot/blob/main/src/ScottPlot5/ScottPlot5/Interactivity/MouseAxisManipulation.cs ```cs if (axisUnderMouse is not null) { if (ChangeOpposingAxesTogether && axisUnderMouse.IsHorizontal()) { plot.Axes.XAxes.ForEa...
d1f4a40593859ac159f4fccea69aac631f3d202e
4ebbf3d1474020d92a27337853cc51ae6a01ee5c
diff --git a/CHANGELOG.md b/CHANGELOG.md index 86a7c7a696..8f17ff7419 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ _Published on [NuGet](https://www.nuget.org/profiles/ScottPlot) on 2026-03-29_ * FillStyle: Reverted change from previous version to make this class public (#5126) @jurihock * Legend: Per...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5/Interactivity/MouseAxisManipulation.cs" ]
[]
true
ScottPlot/ScottPlot
4,962
issue_to_patch
Avalonia draggable points demo start fix
There was an unnecessary null check before create plottable.
bf79715e88cc1430b93bbd70b48670e28ed7ac19
a5cdf48c103b2fe7b970b07ad967417fa21b0fea
diff --git a/src/ScottPlot5/ScottPlot5 Demos/Avalonia Demo/Demos/DraggablePointsWindow.cs b/src/ScottPlot5/ScottPlot5 Demos/Avalonia Demo/Demos/DraggablePointsWindow.cs index 58fbcccddc..a15a855384 100644 --- a/src/ScottPlot5/ScottPlot5 Demos/Avalonia Demo/Demos/DraggablePointsWindow.cs +++ b/src/ScottPlot5/ScottPlot5 ...
[ "src/ScottPlot5/ScottPlot5 Demos/Avalonia Demo/Demos/DraggablePointsWindow.cs" ]
[]
true
ScottPlot/ScottPlot
5,144
issue_to_patch
Fix SnapToTicks Axis Rules after CoordinateRange was refactored
SnapToTicks Axis Rules handle the Min Max limits by checking if the axis is Inverted. This change is required due to PR https://github.com/ScottPlot/ScottPlot/pull/4316 Fixes Issue https://github.com/ScottPlot/ScottPlot/issues/5143
5bf432b390b55898b5931832e43d5a486a50e060
6068eb3b1ac6825c55f30258a9aaee03b75dc170
diff --git a/CHANGELOG.md b/CHANGELOG.md index 0472a60456..86a7c7a696 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,8 +3,9 @@ _Not yet published..._ ## ScottPlot 5.1.58 _Published on [NuGet](https://www.nuget.org/profiles/ScottPlot) on 2026-03-29_ -* FillStyle: reverted change from previous version to make thi...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5/AxisRules/SnapToTicksX.cs", "src/ScottPlot5/ScottPlot5/AxisRules/SnapToTicksY.cs" ]
[]
true
ScottPlot/ScottPlot
5,183
issue_to_patch
Make ContextMenuItems_get public
Allows users to Insert items anywhere in list, selectively remove default items, as well as rearrange them as desired. _set is still hidden in the interface.
ee935207d23a98b355bd433829f2535ed1d8a301
9d92e050ca811029b91c35a57f96110e8b4a20d2
diff --git a/CHANGELOG.md b/CHANGELOG.md index 50eb9bb05f..dae6e9c0ac 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ _Published on [NuGet](https://www.nuget.org/profiles/ScottPlot) on 2026-03-29_ * Axes: Improve SnapToTicks behavior for inverted axes (#5144, #4316, #5143) @BrianAtZetica @CoderPM2011 * A...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5/Interactivity/UserInputProcessor.cs", "src/ScottPlot5/ScottPlot5/Interfaces/IPlotMenu.cs" ]
[]
true
ScottPlot/ScottPlot
5,184
issue_to_patch
Don't show contextMenu if it's empty
Implementing a predicate to disable menu items and/or the whole menu looked like a pain with so many platforms. Opted to just clear my list when chart is empty and repop it when chart has content to display. Menu.ShowContextMenu would show an empty list if it had no items. Now it bails if the items list is empty...
f556b715afc0f3ca1bc8724ddf37285d3757edc2
3d0a01531c6b295b8b1266845102729d67617a42
diff --git a/CHANGELOG.md b/CHANGELOG.md index dae6e9c0ac..bbe8be1c13 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ _Published on [NuGet](https://www.nuget.org/profiles/ScottPlot) on 2026-03-29_ * Axes: Improve behavior of zooming while opposite axes are linked (#5178) @jurihock * Axes: Removed stray d...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Avalonia/AvaPlotMenu.cs", "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Eto/EtoPlotMenu.cs", "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Maui/MauiPlotMenu.cs", "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.WPF/WpfPlotMenu.cs", "src/ScottPlot5...
[]
true
ScottPlot/ScottPlot
5,194
issue_to_patch
Marker shapes
Added a couple sets of markers that are particularly useful on candlestick charts. The primary goals of the markers were: * encode in whether it is a buy or sell marker * don't obscure the vertical center of the candle (which hides a wick) * vertically symmetrical (to avoid perspective weighting that would skew the...
cc4c9a23c1e73fde68d74d84310f454bca6de162
bb15c7f3a0793037cfc0aae3a3e87a19e5c178ac
diff --git a/CHANGELOG.md b/CHANGELOG.md index 3d9e280938..9dd367cfac 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ _Published on [NuGet](https://www.nuget.org/profiles/ScottPlot) on 2026-03-29_ * Avalonia: Improve behavior of scroll wheel when interacting with plots nested in ScrollViewers (#5233) @A...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5/Markers/CircleWithLineLeft.cs", "src/ScottPlot5/ScottPlot5/Markers/CircleWithLineRight.cs", "src/ScottPlot5/ScottPlot5/Markers/TriangleWithLineLeft.cs", "src/ScottPlot5/ScottPlot5/Markers/TriangleWithLineRight.cs", "src/ScottPlot5/ScottPlot5/Primitives/MarkerShap...
[ { "comment": "I think this is a separate PR, you can do an interactive rebase so these changes don't have to be merged in a specific order.\r\n\r\nEspecially since this PR looks pretty uncontroversial and could be merged with little debate, while a new plottable would inevitably require a closer review.", "...
true
ScottPlot/ScottPlot
5,137
issue_to_patch
updating MarkerShapeOverride default color from black to FillColor of original item
This is to address issue #5136 This sample code shows the before and after with these updates. ```cs ScottPlot.Plot myPlot = new(); List<PieSlice> slices = [ new PieSlice() { Value = 5, FillColor = Colors.Red, Label = "Red", LegendText = "R" }, new PieSlice() { Value = 2, FillColor = Colors.Orange, Label...
859e4deb29ec33a694b50b425c0c46991d96388b
3a50a27e26f0d6fe6eac614d91dfffd11a992bf8
diff --git a/CHANGELOG.md b/CHANGELOG.md index f141350a87..0472a60456 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ _Not yet published..._ ## ScottPlot 5.1.58 _Published on [NuGet](https://www.nuget.org/profiles/ScottPlot) on 2026-03-29_ * FillStyle: reverted change from previous version to make this ...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Cookbook/Recipes/General/Legend.cs", "src/ScottPlot5/ScottPlot5/Primitives/Legend.cs" ]
[]
true
ScottPlot/ScottPlot
5,180
issue_to_patch
Removed superfluous Console.WriteLine in FloatingAxis.cs
Removed an artefact Console.WriteLine from the RenderVerticalAxis method in FloatingAxis.cs
8149ac89c97b78fc35c8dc5629782c32a38b6899
7cb56a3e3161784fb5aa149fe04ee646b762297d
diff --git a/CHANGELOG.md b/CHANGELOG.md index 8f17ff7419..50eb9bb05f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ _Published on [NuGet](https://www.nuget.org/profiles/ScottPlot) on 2026-03-29_ * Legend: Permit custom fill color when using MarkerShapeOverride (#5137, #5136) @aespitia * Axes: Improve S...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5/Plottables/FloatingAxis.cs" ]
[]
true
ScottPlot/ScottPlot
5,208
issue_to_patch
InteractiveVerticalLine: Add properties to customize label style
Hello, For my project, I wanted to add a vertical line that displays the X value, similar to an oscilloscope. InteractiveVerticalLine is easy to use and handles mouse interaction, but it doesn’t provide a LabelStyle property. Because of that, you can’t easily display the X value as text like you can with Vertical...
34a54a2909cf45ab28ab1740be901e8c7e0c29a8
2478f966eb110cc1a75a9c20b0ff2faf1f2bdde2
diff --git a/CHANGELOG.md b/CHANGELOG.md index 2be15498a0..e9496b3c1c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ _Published on [NuGet](https://www.nuget.org/profiles/ScottPlot) on 2026-03-29_ * WinUI: Improve support for multi-monitor and custom DPI scale detection (#5150) @diluculo * Markers: Add...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5/PlottableAdder.cs", "src/ScottPlot5/ScottPlot5/Plottables/Interactive/InteractiveVerticalLine.cs" ]
[]
true
ScottPlot/ScottPlot
5,211
issue_to_patch
Fix potential ArgumentOutOfRangeException in MicrophoneDemo
When I try to run **MicrophoneDemo** on my PC, it crashes with an `ArgumentOutOfRangeException`. ``` System.ArgumentOutOfRangeException:β€œvalue ('1') must be less than '1'. (Parameter 'value') Actual value was 1.” ``` This patch fixes the issue. When the number of available audio devices is greater than 0, it s...
3922987ab32cccdc516570a50194a3e23abd6a70
5a7c15a5410c63be40dadcf2fde679aedb5fc100
diff --git a/CHANGELOG.md b/CHANGELOG.md index bbe8be1c13..fa3e88e433 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ _Published on [NuGet](https://www.nuget.org/profiles/ScottPlot) on 2026-03-29_ * Axes: Removed stray debug statement from the in FloatingAxis class (#5180) @wi-fr * Controls: Exposed Us...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Demos/ScottPlot5 WinForms Demo/Demos/MicrophoneDemo.cs" ]
[]
true
ScottPlot/ScottPlot
5,196
issue_to_patch
Fixed the reversed rowSpan and colSpan parameters in FractionRect ctor
Corrected the reversed rowSpan and colSpan parameters in FractionRect constructor call. Renamed width and height vars for better clarity. And revised the advanced layout demo using GridCell's optional rowspan and colspan parameters. Also linked the axes together on those 3 demo plots. To view the revised demo: - R...
83cb71c625f3456b3e98f8fa329f97ce4502364e
ac232eceaadde658ea67ddf41e9e799ced830b6c
diff --git a/CHANGELOG.md b/CHANGELOG.md index 9dd367cfac..2be15498a0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ _Published on [NuGet](https://www.nuget.org/profiles/ScottPlot) on 2026-03-29_ * Heatmap: Improve axis alignment when using SVG output (#5145) @timmer98 * WinUI: Improve support for mul...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Demos/ScottPlot5 WinForms Demo/Demos/MultiplotAdvancedLayout.cs", "src/ScottPlot5/ScottPlot5/Primitives/GridCell.cs" ]
[ { "comment": "Are these lines intentionally included?", "path": "src/ScottPlot5/ScottPlot5 Demos/ScottPlot5 WinForms Demo/Demos/MultiplotAdvancedLayout.cs", "hunk": "@@ -58,11 +58,13 @@ void SetupGrid()\n void SetupMultiColumnSpan()\n {\n CustomGrid customGrid = new();\n- customGr...
true
ScottPlot/ScottPlot
5,196
comment_to_fix
Fixed the reversed rowSpan and colSpan parameters in FractionRect ctor
Are these lines intentionally included?
83cb71c625f3456b3e98f8fa329f97ce4502364e
ac232eceaadde658ea67ddf41e9e799ced830b6c
diff --git a/src/ScottPlot5/ScottPlot5 Demos/ScottPlot5 WinForms Demo/Demos/MultiplotAdvancedLayout.cs b/src/ScottPlot5/ScottPlot5 Demos/ScottPlot5 WinForms Demo/Demos/MultiplotAdvancedLayout.cs index 5a6a66dbc6..0c72a80fbf 100644 --- a/src/ScottPlot5/ScottPlot5 Demos/ScottPlot5 WinForms Demo/Demos/MultiplotAdvancedLay...
[ "src/ScottPlot5/ScottPlot5 Demos/ScottPlot5 WinForms Demo/Demos/MultiplotAdvancedLayout.cs" ]
[ { "comment": "Are these lines intentionally included?", "path": "src/ScottPlot5/ScottPlot5 Demos/ScottPlot5 WinForms Demo/Demos/MultiplotAdvancedLayout.cs", "hunk": "@@ -58,11 +58,13 @@ void SetupGrid()\n void SetupMultiColumnSpan()\n {\n CustomGrid customGrid = new();\n- customGr...
true
ScottPlot/ScottPlot
5,150
issue_to_patch
WinUI: User-defined ScaleFactor lost on monitor change **Problem** `XamlRoot.Changed` overwrites `Plot.ScaleFactor`, losing user zoom settings. ````cs // Start on 200% DPI monitor Plot.ScaleFactor = 2.0; // Auto DPI // User applies 150% zoom Plot.ScaleFactor = 3.0; // User set: 2.0 DPI Γ— 1.5 zoom // Move to 100%...
Winui preserve scalefactor
Fixes #5147 - Preserves user-defined scale factor when moving WinUI control between monitors with different DPI settings. ### Changes 1. Maintain user scale ratio across DPI changes in WinUI control - Track user-defined scale separately from system DPI using `_userScaleRatio` field - Preserve user scale ...
ab6c7fa82e8d855ec75671aafa7fba103f21539c
bcc0ac4e5286eab3a6e1546c373bc85d92b6071b
diff --git a/CHANGELOG.md b/CHANGELOG.md index 845a97b297..3d9e280938 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ _Published on [NuGet](https://www.nuget.org/profiles/ScottPlot) on 2026-03-29_ * Microphone Demo: Improve behavior on systems with no audio input devices (#5211) @myd7349 * Avalonia: Im...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.WinUI/WinUIPlot.cs", "src/ScottPlot5/ScottPlot5 Sandbox/Sandbox.WinUI.Desktop/MainPage.xaml", "src/ScottPlot5/ScottPlot5 Sandbox/Sandbox.WinUI.Desktop/MainPage.xaml.cs", "src/ScottPlot5/ScottPlot5 Sandbox/Sandbox.WinUI.Desktop/Sandbox.WinUI.Deskt...
[]
true
ScottPlot/ScottPlot
5,145
issue_to_patch
Bugfix: Fixed heatmap Rectangles Render Strategy.
As explained in my comment on Issue #4950 I noticed that the heatmap svg export shows a distorted image when exported to SVG with the IRenderStrategy of type Rectangles. The bug was that the RenderStrategy Rectangle used the normal width and height were CellWidth and CellHeight should have been used. |SVG Before ...
ab86638574ed93dcee24115d5074155d773c6eae
64f0c675a97bab4267d4c024a386f263c72355fe
diff --git a/CHANGELOG.md b/CHANGELOG.md index e78f17e7e5..845a97b297 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ _Published on [NuGet](https://www.nuget.org/profiles/ScottPlot) on 2026-03-29_ * Controls: Do not show right-click menu if it has zero items (#5184) @btarb24 * Microphone Demo: Improve ...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5/Plottables/Heatmap.cs" ]
[]
true
ScottPlot/ScottPlot
5,223
issue_to_patch
Fix wheel event bubbling in AvaPlot when nested in ScrollViewer
Set e.Handled = true in OnPointerWheelChanged to prevent the mouse wheel event from bubbling up to parent controls (e.g., ScrollViewer). Now when scrolling inside AvaPlot, only the plot responds to the wheel event without triggering the parent ScrollViewer.
05dda3c71f09770a20dcc9202b926d497a0233dd
c6332d6a051ef840ec44945955398bb96c048478
diff --git a/CHANGELOG.md b/CHANGELOG.md index fa3e88e433..e78f17e7e5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ _Published on [NuGet](https://www.nuget.org/profiles/ScottPlot) on 2026-03-29_ * Controls: Exposed UserInputProcessor.ContextMenuItems getter to support menu customization (#5183) @btarb...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Avalonia/AvaPlot.cs" ]
[]
true
ScottPlot/ScottPlot
5,126
issue_to_patch
Change the visibility of the FillStyle back to public
Please change the visibility of the `FillStyle` property back to public, as it was before the commit 2642eefbb2eeb6154be885e606018f40e7342ec9. The `LineStyle` property is already public, which allows the library user to customise the border line color. The same should also apply to the `FillStyle`. ```cs public...
a3a759ecb1de20a1b17de469928bf120e30d4c20
b610f624470ddf210d666dc456319b297ca7493e
diff --git a/CHANGELOG.md b/CHANGELOG.md index 989dcb8cbe..f141350a87 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,10 @@ +## ScottPlot 5.1.59 +_Not yet published..._ + +## ScottPlot 5.1.58 +_Published on [NuGet](https://www.nuget.org/profiles/ScottPlot) on 2026-03-29_ +* FillStyle: reverted change from previ...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5/Plottables/ZoomRectangle.cs" ]
[]
true
ScottPlot/ScottPlot
5,154
issue_to_patch
Target .NET 10
* Update all projects (and NuGet packages) to target .NET 10 * Resolve all warnings * Update CICD to support .NET 10 builds
08573406c963bc655759ebfbae7463e5c0a6b24e
807171c2e2e096f75c123c8a8e61aeb292187367
diff --git a/.github/workflows/bump-version.yaml b/.github/workflows/bump-version.yaml index 59bbbd96bc..90103942f2 100644 --- a/.github/workflows/bump-version.yaml +++ b/.github/workflows/bump-version.yaml @@ -20,7 +20,7 @@ jobs: - name: Setup .NET uses: actions/setup-dotnet@v4 with: - ...
[ ".github/workflows/bump-version.yaml", ".github/workflows/deploy-nuget.yaml", ".github/workflows/pr1.yaml", ".github/workflows/task-autoformat-check.yaml", ".github/workflows/task-autoformat-fix.yaml", ".github/workflows/task-code-metrics.yaml", ".github/workflows/task-full.yaml", "dev/LOC/loc.bat", ...
[]
true
ScottPlot/ScottPlot
2,656
issue_to_patch
Add a property 'ScaleY' , similar with the 'OffsetY', for the Signal class. ## Feature Suggestion **Feature description:** I want to dynamically set a plot scale (i.e. multiply 'ys' by a specific number before rendering) for a Signal without modifying its raw data 'ys', but currently it seems there is no built-in...
SP4 Signal: add `ScaleY` property
Hello I tried to implement #2642, I don't know if you need it, I just give it a try and I will appreciate a feedback Thanks you.
bd7c659dbb9ac568150b999ab8e5c06a3b00cdb2
1ef27da22e179bc4b46883fdfd9df49555209159
diff --git a/CHANGELOG.md b/CHANGELOG.md index 0446bd2cea..2358b500d0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ * WPF: Multi-target Framework 4.6.1 changed to 4.6.2 (#2685) * Axis: Added option to customize tick line width (#2643, #2654) _Thanks @Guillaume-Deville_ * Horizontal Span: Fixed `ToSt...
[ "CHANGELOG.md", "src/ScottPlot4/ScottPlot.Cookbook/Recipes/Plottable/Signal.cs", "src/ScottPlot4/ScottPlot.Cookbook/Recipes/Plottable/SignalXY.cs", "src/ScottPlot4/ScottPlot/Plottable/SignalPlotBase.cs", "src/ScottPlot4/ScottPlot/Plottable/SignalPlotXYGeneric.cs", "src/ScottPlot5/ScottPlot5/TODO.cs", "s...
[]
true
ScottPlot/ScottPlot
2,654
issue_to_patch
SP4 Ticks: add `LineWidth` field
Hello, this is my contribution for #2643. I also added a cookbook recipe.
0f67594186a776616bc1be4d908ce566a6905f1e
6e41b2f92b3272c3b710f240361812cb3607d2a6
diff --git a/CHANGELOG.md b/CHANGELOG.md index 46a236d352..f34e3feaf8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ * DataLogger: New type of scatter plot designed for infinitely growing X/Y datasets (#2377, #2641) * DataStreamer: New type of signal plot for displaying live data as it is shifted in (...
[ "CHANGELOG.md", "src/ScottPlot4/ScottPlot.Cookbook/Recipes/Axis.cs", "src/ScottPlot4/ScottPlot/Renderable/AxisTicks.cs", "src/ScottPlot4/ScottPlot/Renderable/AxisTicksRender.cs" ]
[]
true
ScottPlot/ScottPlot
2,657
issue_to_patch
SP4: Launch methods should not be extension methods For small single file top-level console apps I typically don't add `using ScottPlot;` so launching an auto-refreshing image viewer isn't available Rework this class to allow something like: ```cs ScottPlot.Plot plt = new(); plt.Launch.ImageFile(); ```
SP4: Improve launcher API
Hello, as asked in #2627 I removed the extension methods to move it to the launcher class. I removed the launcher extensions I don't know if this what you excepted from me since we modify the API of the project. Regards
b2f5339c49b132b1ff29d6e787e91c0861385a91
9654fc8c047504f7cf2c41ef4ad9f7420fc85fb8
diff --git a/CHANGELOG.md b/CHANGELOG.md index 2358b500d0..875d19be8c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ * Axis: Added option to customize tick line width (#2643, #2654) _Thanks @Guillaume-Deville_ * Horizontal Span: Fixed `ToString()` message _Thanks @RachamimYaakobov_ * Signal Plot: Add...
[ "CHANGELOG.md", "src/ScottPlot4/ScottPlot.Sandbox/ConsoleApp/Program.cs", "src/ScottPlot4/ScottPlot.WinForms/LauncherExtensions.cs", "src/ScottPlot4/ScottPlot/Launcher.cs" ]
[]
true
ScottPlot/ScottPlot
5,109
issue_to_patch
Fix crash when AvaPlot is focused a second time
This PR fixes issue #5105.
01cc8876868fbcf3d4f5160922f253bc0a744ba0
85ff648518e944aba5a56cef45f8f8235e1d2b6e
diff --git a/CHANGELOG.md b/CHANGELOG.md index cd2164eb5d..1b8fe36cd0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ _Not yet on NuGet..._ * Multiplot: Added a collection of `PreRenderActions` to facilitate synchronization of data between subplots (#5095) @NeilMacMullen * Histogram: Optimized bin coun...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Avalonia/AvaPlot.cs" ]
[]
true
ScottPlot/ScottPlot
3,921
issue_to_patch
BugFixes to Rotated SignalXY plots
Reolution for #3812 had introduced an incorrect final pixel location for rotated SignalXY plots. This was resolved by a swapping of Xs and Ys coordinates when defining the additional "lastPoint" value. _Note, we could consider renaming Xs and Ys to something like independentValues and dependentValues respectively. N...
42bff235a707dfd7ef1b1ee9bf02033f98e4a708
a044cf67a78be178689f96fccdc087ce7ec4a980
diff --git a/CHANGELOG.md b/CHANGELOG.md index eaf7dc9c82..fade6e71bb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,7 +32,7 @@ _Not yet on NuGet..._ * Scatter: Added `GetNearestX()` to the data source to help locate the point closest to the cursor's X position (#3807) @MatKinPro * Controls: Disable middle-click...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5/DataSources/SignalXYSourceDoubleArray.cs" ]
[]
true
ScottPlot/ScottPlot
4,112
issue_to_patch
SignalXY: Improvements to rending and handling of rotated plots
This PR resolves some minor and some major rendering artefacts that were occurrign in Rotated SignalXY plots. This incorporates changes made in a prevfious PR (#4102 ) that also attempted to refactor the plottable type to remove confusion between X and Y data types and X and Y axis directions. The main artefact was...
39a72c6fe8daa6ff2c0b48a8a68bcb09888deb6d
4d1e46f5b0232de7d51f3b1aada6cf12d6003d6d
diff --git a/CHANGELOG.md b/CHANGELOG.md index b176151a64..2bab525d35 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,6 +27,7 @@ _Not yet on NuGet..._ * PlottableAdder: Exposed `Plot` so users can create methods that extend `Plot.Add` which have access to the `Plot` itself (#4109, #4107) @DDiggs91 * AxisManager: ...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5/DataSources/SignalXYSourceDoubleArray.cs", "src/ScottPlot5/ScottPlot5/DataSources/SignalXYSourceGenericArray.cs", "src/ScottPlot5/ScottPlot5/Interfaces/ISignalXYSource.cs" ]
[]
true
ScottPlot/ScottPlot
3,919
issue_to_patch
Snap to ticks axis rule fixed
I previously implemented the axis rules SnapToTicksX and SnapToTicksY in #3547 . These had a few limitations, most notably: - panning was very jumpy - the tick interval sometimes changed as a result of the snap, which meant is wasn't snapping to a tick every time - it was untested with inverted axes - It had had ...
5e3461a600b4a6b79adb36c89fa4bb307609e3e1
07fc99355f0ea86179959339a975df31bba778cd
diff --git a/CHANGELOG.md b/CHANGELOG.md index 94f3b10c2c..eaf7dc9c82 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -39,6 +39,7 @@ _Not yet on NuGet..._ * Axis Lines: Separated `LegendText` from `LabelText` so items may be configured separately * Heatmap: Exposed `CellWidth` and `CellHeight` as an alternative sizin...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5/AxisRules/SnapToTicksX.cs", "src/ScottPlot5/ScottPlot5/AxisRules/SnapToTicksY.cs" ]
[]
true
ScottPlot/ScottPlot
4,125
issue_to_patch
RenderManager: Improve scaling for high density displays during axis events
Repeat renders (which occur if events change the axis limits since #3952 ) was resulting in repeated calls to canvas.Scale. If being run on a screen with a ScaleFactor larger than 1, this resulted in the plot size blowing up. Code to illustrate this (in WPF sandbox program) follows: ```cs public MainWind...
54a3b681af4058e1ef119fdaac2ae0e304b4d7cc
498462f6222271a6485684a1dc288f5c53b5e1af
diff --git a/CHANGELOG.md b/CHANGELOG.md index b8fa7262db..61807ef7d0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ _Not yet on NuGet..._ * DataLogger: Merged in numerous additional features (optional circular buffer, X and Y offset, etc.) from the experimental DataLogger (#4085, #4114) @drolevar * SVG...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5/Rendering/RenderManager.cs" ]
[]
true
ScottPlot/ScottPlot
3,547
issue_to_patch
New Axis rules
I required a graph to snap to integer number of tick intervals. The reason for this was so that a user of my graph could make multiple images from differnet data using reproducible axis limits (but without having to type in axis limits). For this I created two new Axis rules, SnapToTicksX and SnapToTicksY. These w...
a319fa6785cf2429eafdca59d84f63cdabb69c53
f311c97939ec12c50c4004f660c9c289d58c1333
diff --git a/CHANGELOG.md b/CHANGELOG.md index b316ab7541..80c2032ade 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ ## ScottPlot 5.0.24 * Ticks: Modified `NumericFixedInterval` to add support for inverted axes (#3567) @Alexander-png * Bar plot: Improved support for labels on horizontally oriented bar ...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Sandbox/Sandbox.WPF/MainWindow.xaml", "src/ScottPlot5/ScottPlot5 Sandbox/Sandbox.WPF/MainWindow.xaml.cs", "src/ScottPlot5/ScottPlot5/AxisRules/LockedBottom.cs", "src/ScottPlot5/ScottPlot5/AxisRules/LockedCenterX.cs", "src/ScottPlot5/ScottPlot5/AxisRules/LockedCen...
[]
true
ScottPlot/ScottPlot
5,107
issue_to_patch
Provide a Title for the Legend
Since I needed a legend title for our project (see #5106), I decided to dig deeper into the code and implemented it. I found the implementation quite straightforward because of the nice structure. If I missed something, please comment on what I could improve. I additionally already added a cookbook recipe for ...
2d95fad740d4552315672f3d2aaee9cfaf12a71c
2ff5770b555108339bd12d63ab98d1bc1d7987ca
diff --git a/src/ScottPlot5/ScottPlot5 Cookbook/Recipes/General/Legend.cs b/src/ScottPlot5/ScottPlot5 Cookbook/Recipes/General/Legend.cs index 434f2daaa5..7551e2390c 100644 --- a/src/ScottPlot5/ScottPlot5 Cookbook/Recipes/General/Legend.cs +++ b/src/ScottPlot5/ScottPlot5 Cookbook/Recipes/General/Legend.cs @@ -298,4 +29...
[ "src/ScottPlot5/ScottPlot5 Cookbook/Recipes/General/Legend.cs", "src/ScottPlot5/ScottPlot5/LegendLayouts/Wrapping.cs", "src/ScottPlot5/ScottPlot5/Primitives/Legend.cs", "src/ScottPlot5/ScottPlot5/Primitives/LegendLayout.cs" ]
[]
true
ScottPlot/ScottPlot
5,102
issue_to_patch
statistics: Improve performance for histogram data creation
Using fast index calculation instead of loop search. Below are the benchmark results: **Before(Loop search)** | Method | Points | BinCount | Mean | Error | Gen0 | Allocated | |---------------- |-------- |--------- |--------------:|------:|-------:|----------:| | CreateHistogram | 1000 | ...
50a4bc6f8a8a0bb6e47237026a3a07ccfee1c6d9
c5834b8315566a9c33cf8bed5be7026a1c1e88e0
diff --git a/src/ScottPlot5/ScottPlot5 Benchmarks/Benchmarks/Histogram.cs b/src/ScottPlot5/ScottPlot5 Benchmarks/Benchmarks/Histogram.cs new file mode 100644 index 0000000000..80d3972cf4 --- /dev/null +++ b/src/ScottPlot5/ScottPlot5 Benchmarks/Benchmarks/Histogram.cs @@ -0,0 +1,34 @@ +using BenchmarkDotNet.Attributes; ...
[ "src/ScottPlot5/ScottPlot5 Benchmarks/Benchmarks/Histogram.cs", "src/ScottPlot5/ScottPlot5/Statistics/Histogram.cs" ]
[]
true
ScottPlot/ScottPlot
5,095
issue_to_patch
Provide IShareableManager interface to allow sharing of information between plots in a multiplot
Multiplot currrently only allows _axis_ information to be shared across plots but there are many other things that a user might wish to share, for example cursor position or other changes brought about through interactive behaviour. This PR introduces an `IShareableManager` interface which has only one method; `Upda...
2d95fad740d4552315672f3d2aaee9cfaf12a71c
8f5fcf491c8d96cad40e72bd03dc8d8b0ed63668
diff --git a/CHANGELOG.md b/CHANGELOG.md index 298255f67e..822f7a9274 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ _Not yet on NuGet..._ * Palette: Added `Invert()` and `InvertHue()` to `IPalette` so palettes for light backgrounds can be reused for dark backgrounds (#5094) @NeilMacMullen * Colormap:...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Demos/Avalonia Demo/Demos/MultiPlotDraggableWindow.axaml.cs", "src/ScottPlot5/ScottPlot5/Interfaces/IMultiplot.cs", "src/ScottPlot5/ScottPlot5/Interfaces/IMultiplotPreRenderAction.cs", "src/ScottPlot5/ScottPlot5/Multiplot.cs", "src/ScottPlot5/ScottPlot5/Multiplot...
[]
true
ScottPlot/ScottPlot
5,094
issue_to_patch
Add supoprt for Palette.Invert() and Colormap.Invert()
This PR simply adds a version of ColorBlindFriendly palette with inverted colors. My main motivation was to avoid color 0 (black in ColorBlindFriendly) disappearing on dark backgrounds but it seemed sensible to invert other colors as well. It's hard to judge since I'm not color-blind myself but I asked a colleague ...
c3bc123bdce54662736b3dd370afd398d9874659
afa05b1bf4de3fa0e2bd001aabda961ccdcc55ad
diff --git a/CHANGELOG.md b/CHANGELOG.md index f7cb70e1c5..298255f67e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,9 @@ _Not yet on NuGet..._ * Interactive Plottables: Created a new collection of interactive plottables which do not require manually wiring mouse events to support hover and click-drag manipul...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Cookbook/Recipes/General/Styling.cs", "src/ScottPlot5/ScottPlot5/Colormaps/Inverted.cs", "src/ScottPlot5/ScottPlot5/Colormaps/InvertedHue.cs", "src/ScottPlot5/ScottPlot5/Interfaces/IColormap.cs", "src/ScottPlot5/ScottPlot5/Interfaces/IPalette.cs", "src/ScottPlo...
[]
true
ScottPlot/ScottPlot
5,091
issue_to_patch
ISignalXYSource: Allow IReadOnlyList implementations
Discussed in #5078, a breaking change seems fine here given that discussion.
036989f075efbaadc88dd6fe26cc4542084b5407
4ba1b6e5a2db6641823cf4857f4f81085c15f9ad
diff --git a/CHANGELOG.md b/CHANGELOG.md index 0bdec5f664..f7cb70e1c5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ _Not yet on NuGet..._ * Colormaps: Updated the Turbo colormap to use the identical color table published by the original author (#5075) @bclehmann * Interactive Plottables: Created a new ...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5/DataSources/SignalXYSourceDoubleArray.cs", "src/ScottPlot5/ScottPlot5/DataSources/SignalXYSourceGenericArray.cs", "src/ScottPlot5/ScottPlot5/DataSources/SignalXYSourceGenericList.cs", "src/ScottPlot5/ScottPlot5/Interfaces/ISignalXYSource.cs", "src/ScottPlot5/Scot...
[]
true
ScottPlot/ScottPlot
5,086
issue_to_patch
Interactive: rectangle
Extends #5084 ![interactive-rect](https://github.com/user-attachments/assets/8e4c8613-8304-4e57-b686-ec79e1ccb1ff)
6d0d08d3f744a9d62c58332fce40240963126f6b
607a3fd66f647b711778c673b5bd696401910597
diff --git a/src/ScottPlot5/ScottPlot5 Cookbook/Recipes/PlotTypes/InteractivePlottables.cs b/src/ScottPlot5/ScottPlot5 Cookbook/Recipes/PlotTypes/InteractivePlottables.cs index 1b88217fa4..548a3adeb3 100644 --- a/src/ScottPlot5/ScottPlot5 Cookbook/Recipes/PlotTypes/InteractivePlottables.cs +++ b/src/ScottPlot5/ScottPlo...
[ "src/ScottPlot5/ScottPlot5 Cookbook/Recipes/PlotTypes/InteractivePlottables.cs", "src/ScottPlot5/ScottPlot5/Generate.cs", "src/ScottPlot5/ScottPlot5/PlottableAdder.cs", "src/ScottPlot5/ScottPlot5/Plottables/Interactive/InteractiveRectangle.cs", "src/ScottPlot5/ScottPlot5/Primitives/CoordinateLine.cs", "sr...
[]
true
ScottPlot/ScottPlot
5,085
issue_to_patch
Horizontal and vertical line segments
Extends work started in #5084 ![horizontal-segment](https://github.com/user-attachments/assets/b3bb7c78-7ecc-4ae7-9173-95486f3132df)
6fec03c5ad40fb664dc3cbdd90692a52189b3df9
61a6c3bb74a4ead9f8da76ae59dd7086475765a7
diff --git a/src/ScottPlot5/ScottPlot5 Cookbook/Query.cs b/src/ScottPlot5/ScottPlot5 Cookbook/Query.cs index 3eac97620e..0a00bbc1ff 100644 --- a/src/ScottPlot5/ScottPlot5 Cookbook/Query.cs +++ b/src/ScottPlot5/ScottPlot5 Cookbook/Query.cs @@ -44,8 +44,9 @@ public static IEnumerable<ICategory> GetCategories() ...
[ "src/ScottPlot5/ScottPlot5 Cookbook/Query.cs", "src/ScottPlot5/ScottPlot5 Cookbook/Recipes/PlotTypes/InteractivePlottables.cs", "src/ScottPlot5/ScottPlot5/PlottableAdder.cs", "src/ScottPlot5/ScottPlot5/Plottables/Interactive/InteractiveHorizontalLine.cs", "src/ScottPlot5/ScottPlot5/Plottables/Interactive/In...
[]
true
ScottPlot/ScottPlot
5,084
issue_to_patch
Improve support for mouse-interactive plottables I've implemented a mouse interaction system multiple times in side projects over the last year. I'm going to use this issue to track implementing it in the core library. I'll keep discussion limited here, but demonstrate the features with code as this work matures.
Interactive plottables
Goals of this PR: * Create `IInteractivePlottable` that plottables can implement to gain mouse interactivity * Move all mouse interactivity logic into the user input processor * Allow users to add interactive plottables without wiring any events ![interactive](https://github.com/user-attachments/assets/82307d05-3...
c067b47ecde602a36a99a35894413fb75c444148
f232246baf1e8f20d218874ceb32d9633eb1893e
diff --git a/CHANGELOG.md b/CHANGELOG.md index 1b63bff02f..0bdec5f664 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,8 @@ _Not yet on NuGet..._ * Rendering: Significantly reduced the number of allocations by passing `Paint` throughout the render flow * NuGet: Bundle all third party license and copyright noti...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Avalonia/AvaPlot.cs", "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Avalonia/AvaPlotExtensions.cs", "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Blazor/BlazorPlotBase.cs", "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Eto/EtoPlot.cs", "src/Sco...
[]
true
ScottPlot/ScottPlot
5,075
issue_to_patch
Use real turbo colourmap
Per our discussions in discord this seems like the right move. I also updated the casing in the csproj of the notices directory. I did run a `dotnet pack` and the notices were included, but also it spooks me and I don't trust it. I did run it on MacOS, which is apparently case-insensitive but case-preserving. Apparentl...
85189fd4829dd90484bf363b48f8005e1b9aa6f4
825061d997320020f49d8df91617c1478d39a636
diff --git a/CHANGELOG.md b/CHANGELOG.md index 699d1ecfc4..1b63bff02f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,8 @@ _Not yet on NuGet..._ * Public methods that accepted `SkiaSharp.SKPaint` now accept `ScottPlot.Paint` * `Paint.MeasureText()` now returns a single `PixelRect` instead of using `out` varia...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Tests/Unit Tests/CodeTests/ThirdPartyLicenseTests.cs", "src/ScottPlot5/ScottPlot5/Colormaps/Turbo.cs", "src/ScottPlot5/ScottPlot5/Notices/LICENSE.txt", "src/ScottPlot5/ScottPlot5/Notices/NOTICES.txt", "src/ScottPlot5/ScottPlot5/Notices/ScottPlot.Collections.Circu...
[]
true
ScottPlot/ScottPlot
5,073
issue_to_patch
Include third-party license/copyright notices as discrete files in NuGet packages Two some source code files are licensed under BSD-3-Clause per license information in the file headers: https://github.com/ScottPlot/ScottPlot/blob/093994e1b020d2d1f349e4e0a06c9d67e2577b44/src/ScottPlot5/ScottPlot5/Palettes/Category10.c...
Automate extraction of licenses for inclusion as text files in NuGet packages
Resolves #5068
2642eefbb2eeb6154be885e606018f40e7342ec9
a21e1e5cf949ed318894a214c88f0785fd056415
diff --git a/CHANGELOG.md b/CHANGELOG.md index c156279dda..699d1ecfc4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ _Not yet on NuGet..._ * Public methods that accepted `SkiaSharp.SKPaint` now accept `ScottPlot.Paint` * `Paint.MeasureText()` now returns a single `PixelRect` instead of using `out` varia...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Tests/Unit Tests/CodeTests/ThirdPartyLicenseTests.cs", "src/ScottPlot5/ScottPlot5 Tests/Unit Tests/SourceCodeParsing.cs", "src/ScottPlot5/ScottPlot5/Collections/CircularBuffer.cs", "src/ScottPlot5/ScottPlot5/Colormaps/Algae.cs", "src/ScottPlot5/ScottPlot5/Colorma...
[]
true
ScottPlot/ScottPlot
5,042
issue_to_patch
Color.Opacity `Color` has a `WithOpacity()` method that takes a double [0, 1] but it should also have a complimentary `Opacity` property that returns `Alpha/255.0`. I want an easy way to do this: ```cs myColor = myColor.WithOpacity(myColor.Opacity/2); // reduce existing opacity ```
Colors: Adding color opacity property
This is to address the request in #5041, if I understood it correctly. Colors should now have an Opacity property that returns the Alpha/255 as a double ```cs Colors.Magenta.WithOpacity(Colors.Magenta.Opacity / 2); ```
2972b91e46891d20cfd387156be93582feac1c8c
55239f047e8249f22258fca787287f8350647024
diff --git a/CHANGELOG.md b/CHANGELOG.md index 7277b5c064..3784fe291d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -34,6 +34,7 @@ _Not yet on NuGet..._ * Signal: Improve horizontal range accuracy reported by signal plot data sources (#4868, #5033) @CoderPM2011, @dirk-de-bugger, @StendProg * Heatmap: Added a `Rende...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Cookbook/Recipes/General/ColorRecipes.cs", "src/ScottPlot5/ScottPlot5/Primitives/Color.cs" ]
[ { "comment": "I believe you want to divide by `255.0`, as this will currently do an integer divide, followed by a cast to double.\r\n\r\nThat means it will return 0 for every value of Alpha except for 255 (where it will return 1).", "path": "src/ScottPlot5/ScottPlot5/Primitives/Color.cs", "hunk": "@@ -2...
true
ScottPlot/ScottPlot
5,042
comment_to_fix
Colors: Adding color opacity property
I believe you want to divide by `255.0`, as this will currently do an integer divide, followed by a cast to double. That means it will return 0 for every value of Alpha except for 255 (where it will return 1).
2972b91e46891d20cfd387156be93582feac1c8c
55239f047e8249f22258fca787287f8350647024
diff --git a/src/ScottPlot5/ScottPlot5/Primitives/Color.cs b/src/ScottPlot5/ScottPlot5/Primitives/Color.cs index 8a1b97a0bd..339a572694 100644 --- a/src/ScottPlot5/ScottPlot5/Primitives/Color.cs +++ b/src/ScottPlot5/ScottPlot5/Primitives/Color.cs @@ -23,6 +23,14 @@ public uint ARGB } } + public doubl...
[ "src/ScottPlot5/ScottPlot5/Primitives/Color.cs" ]
[ { "comment": "I believe you want to divide by `255.0`, as this will currently do an integer divide, followed by a cast to double.\r\n\r\nThat means it will return 0 for every value of Alpha except for 255 (where it will return 1).", "path": "src/ScottPlot5/ScottPlot5/Primitives/Color.cs", "hunk": "@@ -2...
true
ScottPlot/ScottPlot
5,061
issue_to_patch
Upgrade to SkiaSharp 3 ScottPlot currently uses SkiaSharp 2 https://github.com/ScottPlot/ScottPlot/blob/e14607ff045dec126a639b719d674a9e36df48e0/src/ScottPlot5/ScottPlot5/ScottPlot.csproj#L51 Version 3 may resolve several issues * #4835 * #4952 * #4786 * #4584 * #4776
Update SkiaSharp 2β†’3 (and bump ScottPlot version 5.0β†’5.1)
* Update SkiaSharp from version 2 to version 3 * Update other dependencies (Avalonia, Uno, WinUI, etc) * Do not include .NET 6 builds in packages now that it is out of support **BREAKING CHANGES:** Upgrading to SkiaSharp 3 necessitated some breaking changes: * Virtually all references to `SkiaSharp.SKPaint` have ...
3cc63ab1ee9f085814407fc522c3e32c79e405bb
03d592f8ac5ffc0fb391e77bbf44bd5db0025ab1
diff --git a/CHANGELOG.md b/CHANGELOG.md index 5b27ede966..c156279dda 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ -## ScottPlot 5.0.57 +## ScottPlot 5.1.57 _Not yet on NuGet..._ +* The transition from ScottPlot `5.0` to `5.1` has breaking changes which are likely to affect advanced users who maintain ...
[ "CHANGELOG.md", "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Avalonia/ScottPlot.Avalonia.csproj", "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Blazor/ScottPlot.Blazor.csproj", "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Eto/ScottPlot.Eto.csproj", "src/ScottPlot5/ScottPlot5 Controls/ScottPlot.Maui/ScottP...
[]
true