repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
SeleniumHQ/selenium
17,678
comment_to_fix
[grid] Add support Redis-backed for SessionQueue
<img src="https://img.shields.io/badge/Action_required-634FD1?style=flat-square" height="20px" alt="Action required"> 1\. <b><i>clearall</i></b> deletes completion marker <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code> <pre> <b><i>RedisBackedNewSessionQueue.addToQueue</i></b> now unconditionally calls <b><i...
18bb1d97d3db196522aa9b3873a350dc40d3ccb8
c1f31eea9b7e93644bd8804db31cb7436546ada0
diff --git a/java/src/org/openqa/selenium/grid/sessionqueue/redis/RedisBackedNewSessionQueue.java b/java/src/org/openqa/selenium/grid/sessionqueue/redis/RedisBackedNewSessionQueue.java new file mode 100644 index 0000000000000..f5a471553e19d --- /dev/null +++ b/java/src/org/openqa/selenium/grid/sessionqueue/redis/RedisB...
[ "java/src/org/openqa/selenium/grid/sessionqueue/redis/RedisBackedNewSessionQueue.java" ]
[ { "comment": "<img src=\"https://img.shields.io/badge/Action_required-634FD1?style=flat-square\" height=\"20px\" alt=\"Action required\">\n\n1\\. <b><i>clearall</i></b> deletes completion marker <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\n<b><i>RedisBackedNewSessionQueue.addToQueue</i></...
true
SeleniumHQ/selenium
17,651
issue_to_patch
[py] terminate driver service process when start() fails to connect
### πŸ”— Related Issues Spotted by the Code Review agent in #17649. ### πŸ’₯ What does this PR do? `Service.start()` left the launched driver process running if it never became connectable. This terminates it before re-raising. ### πŸ”§ Implementation Notes Fixed in base `Service.start()` so all bindings' drivers are cover...
6008ae68f33ff216b74db744aeb33af74e63119d
60fc0c7c41d213de8a3cdc0836f2b97558511213
diff --git a/py/selenium/webdriver/common/service.py b/py/selenium/webdriver/common/service.py index 41d76ffac2113..aef101ea0f3f8 100644 --- a/py/selenium/webdriver/common/service.py +++ b/py/selenium/webdriver/common/service.py @@ -108,15 +108,22 @@ def start(self) -> None: self._start_process(self._path) ...
[ "py/selenium/webdriver/common/service.py", "py/test/unit/selenium/webdriver/common/service_tests.py" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Cleanup shutdown lacks timeout <code>🐞 Bug</code> <code>☼ Reliability</code>\n\n<pre>\nWhen <b><i>Service.start()</i></b> fails it now calls <b><i>stop()</i></b>, which c...
diff --git a/py/test/unit/selenium/webdriver/common/service_tests.py b/py/test/unit/selenium/webdriver/common/service_tests.py new file mode 100644 index 0000000000000..f695b7462ea78 --- /dev/null +++ b/py/test/unit/selenium/webdriver/common/service_tests.py @@ -0,0 +1,45 @@ +# Licensed to the Software Freedom Conserva...
true
SeleniumHQ/selenium
17,651
comment_to_fix
[py] terminate driver service process when start() fails to connect
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Cleanup shutdown lacks timeout <code>🐞 Bug</code> <code>☼ Reliability</code> <pre> When <b><i>Service.start()</i></b> fails it now calls <b><i>stop()</i></b>, which calls <b><i>send_remote_shutdown_co...
6008ae68f33ff216b74db744aeb33af74e63119d
60fc0c7c41d213de8a3cdc0836f2b97558511213
diff --git a/py/selenium/webdriver/common/service.py b/py/selenium/webdriver/common/service.py index 41d76ffac2113..aef101ea0f3f8 100644 --- a/py/selenium/webdriver/common/service.py +++ b/py/selenium/webdriver/common/service.py @@ -108,15 +108,22 @@ def start(self) -> None: self._start_process(self._path) ...
[ "py/selenium/webdriver/common/service.py" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Cleanup shutdown lacks timeout <code>🐞 Bug</code> <code>☼ Reliability</code>\n\n<pre>\nWhen <b><i>Service.start()</i></b> fails it now calls <b><i>stop()</i></b>, which c...
true
SeleniumHQ/selenium
17,656
issue_to_patch
[grid] add HtmlUnit browser logo to Grid UI
### Description Adds an HtmlUnit browser logo to the Grid UI so HtmlUnit nodes/sessions render a proper icon instead of the generic "unknown" browser icon. ### Changes - Added `javascript/grid-ui/src/assets/browsers/htmlunit.png` (16Γ—16 icon). - Added the import and a `case 'htmlunit':` branch in `javascript/grid-ui...
7ca11b99f1bf340f2ca6d91eed6a2adb0dc37002
33ce74f0e84b45d0399225b12977b4ce51716e83
diff --git a/javascript/grid-ui/src/assets/browsers/htmlunit.png b/javascript/grid-ui/src/assets/browsers/htmlunit.png new file mode 100644 index 0000000000000..b812f0fd89519 Binary files /dev/null and b/javascript/grid-ui/src/assets/browsers/htmlunit.png differ diff --git a/javascript/grid-ui/src/util/browser-logo.tsx...
[ "javascript/grid-ui/src/assets/browsers/htmlunit.png", "javascript/grid-ui/src/util/browser-logo.tsx" ]
[]
true
SeleniumHQ/selenium
17,658
issue_to_patch
[build] Automated Browser Version Update
This is an automated pull request to update pinned browsers and drivers Merge after verifying the new browser versions are properly passing the tests
887237c468022cb5e4637aa98404fac2de0c8d23
b4ef731990ec83b5272c31906cd1e28a4536f4e1
diff --git a/common/repositories.bzl b/common/repositories.bzl index 4d93652139d96..342f247d4a440 100644 --- a/common/repositories.bzl +++ b/common/repositories.bzl @@ -11,8 +11,8 @@ def pin_browsers(): http_archive( name = "linux_firefox", - url = "https://ftp.mozilla.org/pub/firefox/releases/15...
[ "common/repositories.bzl", "rb/spec/integration/selenium/webdriver/firefox/driver_spec.rb" ]
[]
diff --git a/rb/spec/integration/selenium/webdriver/firefox/driver_spec.rb b/rb/spec/integration/selenium/webdriver/firefox/driver_spec.rb index 66ca1c0721994..34d8b553f68b5 100644 --- a/rb/spec/integration/selenium/webdriver/firefox/driver_spec.rb +++ b/rb/spec/integration/selenium/webdriver/firefox/driver_spec.rb @@ ...
true
SeleniumHQ/selenium
17,669
issue_to_patch
[py] translate continue_request/continue_response kwargs to BiDi wire format
### πŸ”— Related Issues Follow-up to #17666 (both address kwargs handling in the high-level `driver.network` API). ### πŸ’₯ What does this PR do? Fixes the high-level `Request.continue_request` and `Response.continue_response` so their keyword arguments are translated to the BiDi wire format instead of being passed throu...
f53de51c263c5ab0e598253a46286777a794ede0
abd9e30f424d4c8dfdefe54c52fb87612865b805
diff --git a/py/private/_network_handlers.py b/py/private/_network_handlers.py index 7eaafdb0a4c5d..3c3ae69ecf91c 100644 --- a/py/private/_network_handlers.py +++ b/py/private/_network_handlers.py @@ -355,24 +355,42 @@ def provide_response(self, status=None, headers=None, body=None, reason_phrase=N self._s...
[ "py/private/_network_handlers.py", "py/test/unit/selenium/webdriver/common/bidi_network_tests.py" ]
[]
diff --git a/py/test/unit/selenium/webdriver/common/bidi_network_tests.py b/py/test/unit/selenium/webdriver/common/bidi_network_tests.py index 96648f2d859e7..a7e9f5be63bd2 100644 --- a/py/test/unit/selenium/webdriver/common/bidi_network_tests.py +++ b/py/test/unit/selenium/webdriver/common/bidi_network_tests.py @@ -209...
true
SeleniumHQ/selenium
17,657
issue_to_patch
[js] Expose BiDi CDDL ast and model as shared artifacts
### πŸ”— Related Issues Addresses #17654. In draft until #17574 is merged, since it is based on that code. ### πŸ’₯ What does this PR do? Parses the CDDL to expose two reusable artifacts, instead of being built in memory inside `create-bidi-src_ts` and discarded. Other bindings (Java/Ruby/Python) can then consume one sh...
c526eb203708a5e25957e79d3774a2333405c2af
4444bd05e79dfba0b70a81fd44206ec088d43a26
diff --git a/javascript/selenium-webdriver/generate_bidi.mjs b/javascript/selenium-webdriver/generate_bidi.mjs index 27dc63bfbce37..b982370069ac6 100644 --- a/javascript/selenium-webdriver/generate_bidi.mjs +++ b/javascript/selenium-webdriver/generate_bidi.mjs @@ -16,23 +16,13 @@ // under the License. /** - * Gener...
[ "javascript/selenium-webdriver/generate_bidi.mjs", "javascript/selenium-webdriver/private/generate_bidi.bzl" ]
[ { "comment": "extractCommands() computes hasParams by checking whether normalizeDottedName(paramsCddl) is in emptyParamTypes, but buildEmptyParamTypes() stores raw CDDL group names (def.Name). For dotted names (and for acronym-normalization cases) this comparison will never match, so empty param groups can be m...
true
SeleniumHQ/selenium
17,657
comment_to_fix
[js] Expose BiDi CDDL ast and model as shared artifacts
extractCommands() computes hasParams by checking whether normalizeDottedName(paramsCddl) is in emptyParamTypes, but buildEmptyParamTypes() stores raw CDDL group names (def.Name). For dotted names (and for acronym-normalization cases) this comparison will never match, so empty param groups can be misclassified as having...
c526eb203708a5e25957e79d3774a2333405c2af
4444bd05e79dfba0b70a81fd44206ec088d43a26
diff --git a/javascript/selenium-webdriver/generate_bidi.mjs b/javascript/selenium-webdriver/generate_bidi.mjs index 27dc63bfbce37..b982370069ac6 100644 --- a/javascript/selenium-webdriver/generate_bidi.mjs +++ b/javascript/selenium-webdriver/generate_bidi.mjs @@ -16,23 +16,13 @@ // under the License. /** - * Gener...
[ "javascript/selenium-webdriver/generate_bidi.mjs" ]
[ { "comment": "extractCommands() computes hasParams by checking whether normalizeDottedName(paramsCddl) is in emptyParamTypes, but buildEmptyParamTypes() stores raw CDDL group names (def.Name). For dotted names (and for acronym-normalization cases) this comparison will never match, so empty param groups can be m...
true
SeleniumHQ/selenium
17,657
comment_to_fix
[js] Expose BiDi CDDL ast and model as shared artifacts
_ARTIFACT_VISIBILITY is applied to the *_ast and *_json intermediate targets, but it does not include the JS package itself. Since create-bidi-src_ts depends on those targets in the same package, Bazel visibility checks can block the dependency and break the build. Include //visibility:private (or the calling package's...
c526eb203708a5e25957e79d3774a2333405c2af
4444bd05e79dfba0b70a81fd44206ec088d43a26
diff --git a/javascript/selenium-webdriver/private/generate_bidi.bzl b/javascript/selenium-webdriver/private/generate_bidi.bzl index dd19ece0a0c8f..4da82197f3630 100644 --- a/javascript/selenium-webdriver/private/generate_bidi.bzl +++ b/javascript/selenium-webdriver/private/generate_bidi.bzl @@ -2,6 +2,13 @@ load("@...
[ "javascript/selenium-webdriver/private/generate_bidi.bzl" ]
[ { "comment": "_ARTIFACT_VISIBILITY is applied to the *_ast and *_json intermediate targets, but it does not include the JS package itself. Since create-bidi-src_ts depends on those targets in the same package, Bazel visibility checks can block the dependency and break the build. Include //visibility:private (or...
true
SeleniumHQ/selenium
17,663
issue_to_patch
[πŸ› Bug]: The WebSocket connection in WebDriver is not closed when quitting the webdriver ### Description In the Python implementation, when I enable BiDi, I get an error log when calling WebDriver.quit(). Error log when using chromedriver: ``` websocket - ERROR - Thread-1 (run_socket) - _logging.py:77 - Connection...
[py][bidi]: close BiDi websocket on `quit()`
<!-- Thanks for Contributing to Selenium! --> <!-- Please read our contribution guidelines: https://github.com/SeleniumHQ/selenium/blob/trunk/CONTRIBUTING.md --> ### πŸ”— Related Issues <!-- Example: Fixes #1234 or Closes #5678 --> <!-- If the reason for this PR is not obvious, consider creating an issue for it fir...
8c504182a52a158e272b7e20da8dda5f85a07865
9b9ffc43e7487a46b2f21bcebe41448e325a37d7
diff --git a/py/selenium/webdriver/remote/webdriver.py b/py/selenium/webdriver/remote/webdriver.py index c471928a2218b..232637c313ee4 100644 --- a/py/selenium/webdriver/remote/webdriver.py +++ b/py/selenium/webdriver/remote/webdriver.py @@ -637,6 +637,11 @@ def close(self) -> None: def quit(self) -> None: ...
[ "py/selenium/webdriver/remote/webdriver.py", "py/selenium/webdriver/remote/websocket_connection.py", "py/test/selenium/webdriver/common/bidi_quit_tests.py" ]
[ { "comment": "<img src=\"https://img.shields.io/badge/Action_required-634FD1?style=flat-square\" height=\"20px\" alt=\"Action required\">\n\n1\\. <b><i>close()</i></b> ignores join timeout <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\n<b><i>WebSocketConnection.close()</i></b> joins the web...
diff --git a/py/test/selenium/webdriver/common/bidi_quit_tests.py b/py/test/selenium/webdriver/common/bidi_quit_tests.py new file mode 100644 index 0000000000000..3b5edddcbd94c --- /dev/null +++ b/py/test/selenium/webdriver/common/bidi_quit_tests.py @@ -0,0 +1,83 @@ +# Licensed to the Software Freedom Conservancy (SFC)...
true
SeleniumHQ/selenium
17,663
comment_to_fix
[py][bidi]: close BiDi websocket on `quit()`
<img src="https://img.shields.io/badge/Action_required-634FD1?style=flat-square" height="20px" alt="Action required"> 1\. <b><i>close()</i></b> ignores join timeout <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code> <pre> <b><i>WebSocketConnection.close()</i></b> joins the websocket thread with a timeout but d...
8c504182a52a158e272b7e20da8dda5f85a07865
9b9ffc43e7487a46b2f21bcebe41448e325a37d7
diff --git a/py/selenium/webdriver/remote/websocket_connection.py b/py/selenium/webdriver/remote/websocket_connection.py index 4119776ce39aa..5d3f75f761542 100644 --- a/py/selenium/webdriver/remote/websocket_connection.py +++ b/py/selenium/webdriver/remote/websocket_connection.py @@ -102,8 +102,16 @@ def __init__(self,...
[ "py/selenium/webdriver/remote/websocket_connection.py" ]
[ { "comment": "<img src=\"https://img.shields.io/badge/Action_required-634FD1?style=flat-square\" height=\"20px\" alt=\"Action required\">\n\n1\\. <b><i>close()</i></b> ignores join timeout <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\n<b><i>WebSocketConnection.close()</i></b> joins the web...
true
SeleniumHQ/selenium
17,663
comment_to_fix
[py][bidi]: close BiDi websocket on `quit()`
<img src="https://img.shields.io/badge/Action_required-634FD1?style=flat-square" height="20px" alt="Action required"> 1\. Log handlers can leak <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code> <pre> The test attaches <b><i>recorder</i></b> (<b><i>_WebSocketErrorRecorder</i></b>) to global loggers before ente...
8c504182a52a158e272b7e20da8dda5f85a07865
9b9ffc43e7487a46b2f21bcebe41448e325a37d7
diff --git a/py/test/selenium/webdriver/common/bidi_quit_tests.py b/py/test/selenium/webdriver/common/bidi_quit_tests.py new file mode 100644 index 0000000000000..3b5edddcbd94c --- /dev/null +++ b/py/test/selenium/webdriver/common/bidi_quit_tests.py @@ -0,0 +1,83 @@ +# Licensed to the Software Freedom Conservancy (SFC)...
[ "py/test/selenium/webdriver/common/bidi_quit_tests.py" ]
[ { "comment": "<img src=\"https://img.shields.io/badge/Action_required-634FD1?style=flat-square\" height=\"20px\" alt=\"Action required\">\n\n1\\. Log handlers can leak <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\nThe test attaches <b><i>recorder</i></b> (<b><i>_WebSocketErrorRecorder</i><...
true
SeleniumHQ/selenium
17,660
issue_to_patch
[py] use local webserver for BiDi network auth/header tests
### Description The BiDi network **authentication** and **extra-header** tests in `bidi_network_tests.py` navigated to `postman-echo.com`, an external service. This makes the tests flaky and dependent on outbound network access. This moves them onto the existing local `SimpleWebServer` so the whole suite runs on one m...
d33b3893886802b0e55c39120c0fedb846e493f2
4d59ee8de4c744a94e079b0b8f0e9e36444ad259
[ "py/test/selenium/webdriver/common/bidi_network_tests.py", "py/test/selenium/webdriver/common/webserver.py" ]
[]
diff --git a/py/test/selenium/webdriver/common/bidi_network_tests.py b/py/test/selenium/webdriver/common/bidi_network_tests.py index 83fb96c594a33..1d0592c9b25be 100644 --- a/py/test/selenium/webdriver/common/bidi_network_tests.py +++ b/py/test/selenium/webdriver/common/bidi_network_tests.py @@ -98,11 +98,11 @@ def cal...
true
SeleniumHQ/selenium
17,661
issue_to_patch
[py] make window position/rect tests robust on multi-monitor setups
### Description The Python window position/rect tests assumed the browser window lives at non-negative coordinates on the primary display and that the window manager honors an exact `set_window_position`. Neither assumption holds on a multi-monitor layout, so these tests fail on developer machines with a non-standard ...
d33b3893886802b0e55c39120c0fedb846e493f2
470f28c984ac14b93ae9bf7730a1c43cf2605652
[ "py/test/selenium/webdriver/common/api_example_tests.py", "py/test/selenium/webdriver/common/window_tests.py" ]
[]
diff --git a/py/test/selenium/webdriver/common/api_example_tests.py b/py/test/selenium/webdriver/common/api_example_tests.py index 5068eed506552..5999550fab1c9 100644 --- a/py/test/selenium/webdriver/common/api_example_tests.py +++ b/py/test/selenium/webdriver/common/api_example_tests.py @@ -243,19 +243,21 @@ def test_...
true
SeleniumHQ/selenium
17,585
issue_to_patch
[πŸš€ Feature]: Automatically prune Selenium Manager cache ### Description The Selenium cache (`~/.cache/selenium`) grows without bounds: I just have found and deleted 19 GB of old `chrome` and `chromedriver` versions :) I would like to impose a limit here, and automatically prune this directory by deleting everything...
[SM] Automatically prune cache entries older than 30 days
Selenium Manager now removes driver/browser version directories from the cache (~/.cache/selenium) that have not been modified in over 30 days. The prune runs on every invocation after clear-cache/clear-metadata, so the cache size is bounded without requiring manual intervention. Fixes #17196 <!-- Thanks for Cont...
7ca11b99f1bf340f2ca6d91eed6a2adb0dc37002
d7988b3e8363224317c19e9f66876715f50d9df9
diff --git a/rust/src/lib.rs b/rust/src/lib.rs index 2ea3dce8edcc4..a9a83ac99d543 100644 --- a/rust/src/lib.rs +++ b/rust/src/lib.rs @@ -35,7 +35,7 @@ use crate::lock::Lock; use crate::logger::Logger; use crate::metadata::{ create_browser_metadata, create_stats_metadata, get_browser_version_from_metadata, - g...
[ "rust/src/lib.rs", "rust/src/main.rs", "rust/src/metadata.rs" ]
[ { "comment": "I am not convinced of this part. What is `asset_name` in `CachedAsset`?\nMy idea was to add the new field (`last_used`) for browser and driver metadata (i.e., in `Browser` and `Driver` structs).", "path": "rust/src/metadata.rs", "hunk": "@@ -52,11 +52,24 @@ pub struct Driver {\n pub dr...
true
SeleniumHQ/selenium
17,585
comment_to_fix
[SM] Automatically prune cache entries older than 30 days
I am not convinced of this part. What is `asset_name` in `CachedAsset`? My idea was to add the new field (`last_used`) for browser and driver metadata (i.e., in `Browser` and `Driver` structs).
7ca11b99f1bf340f2ca6d91eed6a2adb0dc37002
d7988b3e8363224317c19e9f66876715f50d9df9
diff --git a/rust/src/metadata.rs b/rust/src/metadata.rs index 5362b48fc0d5c..8d9888d77839c 100644 --- a/rust/src/metadata.rs +++ b/rust/src/metadata.rs @@ -52,11 +52,24 @@ pub struct Driver { pub driver_ttl: u64, } +/// Records when a cached asset (driver or browser binary) was last used. +/// This section is ...
[ "rust/src/metadata.rs" ]
[ { "comment": "I am not convinced of this part. What is `asset_name` in `CachedAsset`?\nMy idea was to add the new field (`last_used`) for browser and driver metadata (i.e., in `Browser` and `Driver` structs).", "path": "rust/src/metadata.rs", "hunk": "@@ -52,11 +52,24 @@ pub struct Driver {\n pub dr...
true
SeleniumHQ/selenium
17,574
issue_to_patch
[js] Add Javascript/Typescript CDDL code generator for WebDriver BiDi
### πŸ”— Related Issues Related to #17487 Part of the CDDL WebDriver BiDi API generator. Implemented as defined in the spec https://gist.github.com/AutomatedTester/148437f846a3759f7678c7ff6debb210 ### πŸ’₯ What does this PR do? Adds a code generator (`generate_bidi.mjs`) that reads the merged WebDriver BiDi CDDL ...
bcafedd07de3004a7e0ccdaebaf02b801bd0b7cb
9af40fbec6987d20393d7d3213e912184b3f0232
diff --git a/.gitignore b/.gitignore index 9d68d997b743f..f8be517c10f03 100644 --- a/.gitignore +++ b/.gitignore @@ -100,6 +100,9 @@ obj/ *.aps launchSettings.json Generated/ +# Un-ignore the hand-written tests for the generated BiDi domain API (macOS +# case-insensitive filesystem would otherwise match "Generated/"...
[ ".gitignore", "javascript/selenium-webdriver/BUILD.bazel", "javascript/selenium-webdriver/bidi/index.js", "javascript/selenium-webdriver/generate_bidi.mjs", "javascript/selenium-webdriver/package.json", "javascript/selenium-webdriver/private/BUILD.bazel", "javascript/selenium-webdriver/private/bidi_enha...
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. <b><i>username!</i></b> in <b><i>continuewithauth</i></b> <code>πŸ“˜ Rule violation</code> <code>≑ Correctness</code>\n\n<pre>\nThe injected deprecated overload for <b><i>Ne...
diff --git a/javascript/selenium-webdriver/test/bidi/generated/browser_test.js b/javascript/selenium-webdriver/test/bidi/generated/browser_test.js new file mode 100644 index 0000000000000..1d0a36a9a86e9 --- /dev/null +++ b/javascript/selenium-webdriver/test/bidi/generated/browser_test.js @@ -0,0 +1,121 @@ +// Licensed ...
true
SeleniumHQ/selenium
17,574
comment_to_fix
[js] Add Javascript/Typescript CDDL code generator for WebDriver BiDi
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. <b><i>username!</i></b> in <b><i>continuewithauth</i></b> <code>πŸ“˜ Rule violation</code> <code>≑ Correctness</code> <pre> The injected deprecated overload for <b><i>Network.continueWithAuth</i></b> use...
bcafedd07de3004a7e0ccdaebaf02b801bd0b7cb
9af40fbec6987d20393d7d3213e912184b3f0232
diff --git a/javascript/selenium-webdriver/private/bidi_enhancements_manifest.json b/javascript/selenium-webdriver/private/bidi_enhancements_manifest.json new file mode 100644 index 0000000000000..9d5fd561b3bc7 --- /dev/null +++ b/javascript/selenium-webdriver/private/bidi_enhancements_manifest.json @@ -0,0 +1,123 @@ +...
[ "javascript/selenium-webdriver/private/bidi_enhancements_manifest.json" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. <b><i>username!</i></b> in <b><i>continuewithauth</i></b> <code>πŸ“˜ Rule violation</code> <code>≑ Correctness</code>\n\n<pre>\nThe injected deprecated overload for <b><i>Ne...
true
SeleniumHQ/selenium
17,574
comment_to_fix
[js] Add Javascript/Typescript CDDL code generator for WebDriver BiDi
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 2\. Empty context in back/forward <code>🐞 Bug</code> <code>≑ Correctness</code> <pre> The BrowsingContext enhancement methods back() and forward() always call traverseHistory with context: &#x27;&#x27; (e...
bcafedd07de3004a7e0ccdaebaf02b801bd0b7cb
9af40fbec6987d20393d7d3213e912184b3f0232
diff --git a/javascript/selenium-webdriver/private/bidi_enhancements_manifest.json b/javascript/selenium-webdriver/private/bidi_enhancements_manifest.json new file mode 100644 index 0000000000000..9d5fd561b3bc7 --- /dev/null +++ b/javascript/selenium-webdriver/private/bidi_enhancements_manifest.json @@ -0,0 +1,123 @@ +...
[ "javascript/selenium-webdriver/private/bidi_enhancements_manifest.json" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n2\\. Empty context in back/forward <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\nThe BrowsingContext enhancement methods back() and forward() always call traverseHis...
true
SeleniumHQ/selenium
17,574
comment_to_fix
[js] Add Javascript/Typescript CDDL code generator for WebDriver BiDi
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 3\. Continuewithauth ignores errors <code>🐞 Bug</code> <code>≑ Correctness</code> <pre> The Network enhancement overrides continueWithAuth() and calls this.bidi.send() directly without checking for BiDi e...
bcafedd07de3004a7e0ccdaebaf02b801bd0b7cb
9af40fbec6987d20393d7d3213e912184b3f0232
diff --git a/javascript/selenium-webdriver/private/bidi_enhancements_manifest.json b/javascript/selenium-webdriver/private/bidi_enhancements_manifest.json new file mode 100644 index 0000000000000..9d5fd561b3bc7 --- /dev/null +++ b/javascript/selenium-webdriver/private/bidi_enhancements_manifest.json @@ -0,0 +1,123 @@ +...
[ "javascript/selenium-webdriver/private/bidi_enhancements_manifest.json" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n3\\. Continuewithauth ignores errors <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\nThe Network enhancement overrides continueWithAuth() and calls this.bidi.send() di...
true
SeleniumHQ/selenium
17,574
comment_to_fix
[js] Add Javascript/Typescript CDDL code generator for WebDriver BiDi
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Event name can crash <code>🐞 Bug</code> <code>☼ Reliability</code> <pre> bidi/index.js now emits protocol events using payload.method as the EventEmitter event name; if a peer sends method === &#x27;e...
bcafedd07de3004a7e0ccdaebaf02b801bd0b7cb
9af40fbec6987d20393d7d3213e912184b3f0232
diff --git a/javascript/selenium-webdriver/bidi/index.js b/javascript/selenium-webdriver/bidi/index.js index a076ac6b215a3..4d41789a8253c 100644 --- a/javascript/selenium-webdriver/bidi/index.js +++ b/javascript/selenium-webdriver/bidi/index.js @@ -79,10 +79,31 @@ class Index extends EventEmitter { } ...
[ "javascript/selenium-webdriver/bidi/index.js" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Event name can crash <code>🐞 Bug</code> <code>☼ Reliability</code>\n\n<pre>\nbidi/index.js now emits protocol events using payload.method as the EventEmitter event name; ...
true
SeleniumHQ/selenium
17,646
issue_to_patch
[build] Automated Browser Version Update
This is an automated pull request to update pinned browsers and drivers Merge after verifying the new browser versions are properly passing the tests
6008ae68f33ff216b74db744aeb33af74e63119d
d1fa07a4fb7ad5322d763b969fe8e79f3abb0e5c
diff --git a/common/repositories.bzl b/common/repositories.bzl index 610d976e85737..4d93652139d96 100644 --- a/common/repositories.bzl +++ b/common/repositories.bzl @@ -50,8 +50,8 @@ js_library( http_archive( name = "linux_beta_firefox", - url = "https://ftp.mozilla.org/pub/firefox/releases/152.0...
[ "common/repositories.bzl" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Linux edge driver mismatch <code>🐞 Bug</code> <code>☼ Reliability</code>\n\n<pre>\nThis PR changes the pinned Linux EdgeDriver to 149.0.4022.50 while the pinned Linux Edg...
true
SeleniumHQ/selenium
17,646
comment_to_fix
[build] Automated Browser Version Update
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Linux edge driver mismatch <code>🐞 Bug</code> <code>☼ Reliability</code> <pre> This PR changes the pinned Linux EdgeDriver to 149.0.4022.50 while the pinned Linux Edge browser remains 149.0.4022.52, c...
6008ae68f33ff216b74db744aeb33af74e63119d
d1fa07a4fb7ad5322d763b969fe8e79f3abb0e5c
diff --git a/common/repositories.bzl b/common/repositories.bzl index 610d976e85737..4d93652139d96 100644 --- a/common/repositories.bzl +++ b/common/repositories.bzl @@ -50,8 +50,8 @@ js_library( http_archive( name = "linux_beta_firefox", - url = "https://ftp.mozilla.org/pub/firefox/releases/152.0...
[ "common/repositories.bzl" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Linux edge driver mismatch <code>🐞 Bug</code> <code>☼ Reliability</code>\n\n<pre>\nThis PR changes the pinned Linux EdgeDriver to 149.0.4022.50 while the pinned Linux Edg...
true
SeleniumHQ/selenium
17,645
issue_to_patch
[py] add Selenium Manager integration tests
### πŸ”— Related Issues Implements #16741 for Python Part of #17539 ### πŸ’₯ What does this PR do? * Adds integration test coverage of Selenium Manager via Driver Finder class ### πŸ”§ Implementation Notes * Because it goes through Driver Finder, the tests pass with and without pin_browsers being set by taking different...
c779dcd5ed35092a41196561c5bd5dbe0d0df500
b28e3cffe29555861796bdfaf60633a9c626293b
diff --git a/.github/workflows/ci-python.yml b/.github/workflows/ci-python.yml index 507bcd335c5be..1940e479e52f9 100644 --- a/.github/workflows/ci-python.yml +++ b/.github/workflows/ci-python.yml @@ -85,3 +85,19 @@ jobs: rerun-with-debug: true run: | bazel test --local_test_jobs 1 --flaky_test_a...
[ ".github/workflows/ci-python.yml", "py/BUILD.bazel", "py/test/selenium/webdriver/common/driver_finder_tests.py" ]
[ { "comment": "Why is the skips written differently between this test and the next test?", "path": "py/test/selenium/webdriver/common/driver_finder_tests.py", "hunk": "@@ -0,0 +1,103 @@\n+# Licensed to the Software Freedom Conservancy (SFC) under one\n+# or more contributor license agreements. See the N...
diff --git a/py/test/selenium/webdriver/common/driver_finder_tests.py b/py/test/selenium/webdriver/common/driver_finder_tests.py new file mode 100644 index 0000000000000..2f44d7def5768 --- /dev/null +++ b/py/test/selenium/webdriver/common/driver_finder_tests.py @@ -0,0 +1,103 @@ +# Licensed to the Software Freedom Cons...
true
SeleniumHQ/selenium
17,645
comment_to_fix
[py] add Selenium Manager integration tests
Why is the skips written differently between this test and the next test?
c779dcd5ed35092a41196561c5bd5dbe0d0df500
b28e3cffe29555861796bdfaf60633a9c626293b
diff --git a/py/test/selenium/webdriver/common/driver_finder_tests.py b/py/test/selenium/webdriver/common/driver_finder_tests.py new file mode 100644 index 0000000000000..2f44d7def5768 --- /dev/null +++ b/py/test/selenium/webdriver/common/driver_finder_tests.py @@ -0,0 +1,103 @@ +# Licensed to the Software Freedom Cons...
[ "py/test/selenium/webdriver/common/driver_finder_tests.py" ]
[ { "comment": "Why is the skips written differently between this test and the next test?", "path": "py/test/selenium/webdriver/common/driver_finder_tests.py", "hunk": "@@ -0,0 +1,103 @@\n+# Licensed to the Software Freedom Conservancy (SFC) under one\n+# or more contributor license agreements. See the N...
true
SeleniumHQ/selenium
17,640
issue_to_patch
[build] silence protobuf sun.misc.Unsafe warnings from Java compile workers
### πŸ”— Related Issues When #17598 bumped the build from JDK 21 to JDK 25, `sun.misc.Unsafe` access became a terminal-deprecation warning, so we're seeing thousands of `sun.misc.Unsafe` warnings the Java compile workers spam into the console: ``` WARNING: A terminally deprecated method in sun.misc.Unsafe has been call...
c678813e0d98df3e3d2f57681b933e47613b4bfe
42048212cc2cdded4edae64f95bc2e23546f45bd
diff --git a/.bazelrc b/.bazelrc index a3f257af58dc8..dcfff1576c319 100644 --- a/.bazelrc +++ b/.bazelrc @@ -20,12 +20,16 @@ build --enable_runfiles build --flag_alias=pin_browsers=//common:pin_browsers build --flag_alias=headless=//common:headless -# Set the default java toolchain +# Set the default java toolchain...
[ ".bazelrc", "common/remote-build/java/BUILD.bazel" ]
[]
true
SeleniumHQ/selenium
17,650
issue_to_patch
[build] keep pre-installed browsers on Windows, delete only drivers
Seeing some failures where the Windows deletion script results in a corrupted Firefox which breaks Selenium Manager. ### πŸ’₯ What does this PR do? Deleting browsers on Windows isn't as reliable, so this changes the script to only delete the drivers. This still exercises Selenium Manager, just using a different path; us...
c678813e0d98df3e3d2f57681b933e47613b4bfe
896f53c058954055dbfb09fb6698c53436829cc3
diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index edd8c9f5dadb3..e9573c25b8a5f 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -202,7 +202,7 @@ jobs: - name: Delete browsers and drivers if: inputs.os == 'ubuntu' || inputs.os == 'macos' ru...
[ ".github/workflows/bazel.yml", "scripts/github-actions/delete-browsers-drivers.ps1" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Empty driver path crash <code>🐞 Bug</code> <code>☼ Reliability</code>\n\n<pre>\ndelete-browsers-drivers.ps1 now builds $paths only from WebDriver env vars and calls Remov...
true
SeleniumHQ/selenium
17,650
comment_to_fix
[build] keep pre-installed browsers on Windows, delete only drivers
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Empty driver path crash <code>🐞 Bug</code> <code>☼ Reliability</code> <pre> delete-browsers-drivers.ps1 now builds $paths only from WebDriver env vars and calls Remove-Item unconditionally. If none of...
c678813e0d98df3e3d2f57681b933e47613b4bfe
896f53c058954055dbfb09fb6698c53436829cc3
diff --git a/scripts/github-actions/delete-browsers-drivers.ps1 b/scripts/github-actions/delete-browsers-drivers.ps1 index 965bcd0a82cee..5a5921c090318 100755 --- a/scripts/github-actions/delete-browsers-drivers.ps1 +++ b/scripts/github-actions/delete-browsers-drivers.ps1 @@ -1,17 +1,17 @@ #!/usr/bin/env pwsh # -# De...
[ "scripts/github-actions/delete-browsers-drivers.ps1" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Empty driver path crash <code>🐞 Bug</code> <code>☼ Reliability</code>\n\n<pre>\ndelete-browsers-drivers.ps1 now builds $paths only from WebDriver env vars and calls Remov...
true
SeleniumHQ/selenium
17,652
issue_to_patch
[dotnet] [bidi] Remove last obsoleted Type helper in Input module
### πŸ”— Related Issues <!-- Example: Fixes #1234 or Closes #5678 --> <!-- If the reason for this PR is not obvious, consider creating an issue for it first --> ### πŸ’₯ What does this PR do? This pull request makes a small change to the `KeySourceActions` record in `SourceActions.cs`, removing an obsolete helper m...
fd2e545186fb6909f8d09338afbd4c0215b9ae12
329c062d68ca38b4bcfb9991024278d30625cfbf
diff --git a/dotnet/src/webdriver/BiDi/Input/SourceActions.cs b/dotnet/src/webdriver/BiDi/Input/SourceActions.cs index b4d6d39376a4b..ed6b15858477c 100644 --- a/dotnet/src/webdriver/BiDi/Input/SourceActions.cs +++ b/dotnet/src/webdriver/BiDi/Input/SourceActions.cs @@ -41,14 +41,7 @@ public interface ISourceAction; pub...
[ "dotnet/src/webdriver/BiDi/Input/SourceActions.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Removed <b><i>keysourceactions.type()</i></b> <code>πŸ“˜ Rule violation</code> <code>≑ Correctness</code>\n\n<pre>\nThe public helper method <b><i>KeySourceActions.Type(stri...
true
SeleniumHQ/selenium
17,652
comment_to_fix
[dotnet] [bidi] Remove last obsoleted Type helper in Input module
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Removed <b><i>keysourceactions.type()</i></b> <code>πŸ“˜ Rule violation</code> <code>≑ Correctness</code> <pre> The public helper method <b><i>KeySourceActions.Type(string text)</i></b> was removed, whic...
fd2e545186fb6909f8d09338afbd4c0215b9ae12
329c062d68ca38b4bcfb9991024278d30625cfbf
diff --git a/dotnet/src/webdriver/BiDi/Input/SourceActions.cs b/dotnet/src/webdriver/BiDi/Input/SourceActions.cs index b4d6d39376a4b..ed6b15858477c 100644 --- a/dotnet/src/webdriver/BiDi/Input/SourceActions.cs +++ b/dotnet/src/webdriver/BiDi/Input/SourceActions.cs @@ -41,14 +41,7 @@ public interface ISourceAction; pub...
[ "dotnet/src/webdriver/BiDi/Input/SourceActions.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Removed <b><i>keysourceactions.type()</i></b> <code>πŸ“˜ Rule violation</code> <code>≑ Correctness</code>\n\n<pre>\nThe public helper method <b><i>KeySourceActions.Type(stri...
true
SeleniumHQ/selenium
17,636
issue_to_patch
[rb] create more obvious test guard keywords as aliases
As we've added guard names they have become too confusing; I find I have to look them up every time and that's not great ### πŸ’₯ What does this PR do? Adds four self-describing guard names for the Ruby spec suite and updates the specs to use them: - `skip_if:` β€” skip the example when the configuration matches - `skip...
c678813e0d98df3e3d2f57681b933e47613b4bfe
1149d56a373ecd0ef9701c15dc3eb792925ba9a9
diff --git a/rb/AGENTS.md b/rb/AGENTS.md index a9c92f3d597f9..c7d5186933166 100644 --- a/rb/AGENTS.md +++ b/rb/AGENTS.md @@ -49,3 +49,28 @@ Use YARD for public APIs: # @return [Type] description # @raise [ErrorClass] when condition ``` + +## Integration test guards + +Integration specs are guarded by RSpec metadata ...
[ "rb/AGENTS.md", "rb/lib/selenium/webdriver/support/guards.rb", "rb/lib/selenium/webdriver/support/guards/guard.rb", "rb/spec/integration/selenium/webdriver/action_builder_spec.rb", "rb/spec/integration/selenium/webdriver/bidi/browser_spec.rb", "rb/spec/integration/selenium/webdriver/bidi/browsing_context_...
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Wrong guard array semantics <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\nrb/AGENTS.md claims β€œArray of Hashes = OR (any matches)”, but the guard engine flatten...
diff --git a/rb/spec/integration/selenium/webdriver/action_builder_spec.rb b/rb/spec/integration/selenium/webdriver/action_builder_spec.rb index eede26c3ebcd7..0e973b242d3bb 100644 --- a/rb/spec/integration/selenium/webdriver/action_builder_spec.rb +++ b/rb/spec/integration/selenium/webdriver/action_builder_spec.rb @@ ...
true
SeleniumHQ/selenium
17,636
comment_to_fix
[rb] create more obvious test guard keywords as aliases
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Wrong guard array semantics <code>🐞 Bug</code> <code>≑ Correctness</code> <pre> rb/AGENTS.md claims β€œArray of Hashes = OR (any matches)”, but the guard engine flattens arrays into multiple Guard insta...
c678813e0d98df3e3d2f57681b933e47613b4bfe
1149d56a373ecd0ef9701c15dc3eb792925ba9a9
diff --git a/rb/AGENTS.md b/rb/AGENTS.md index a9c92f3d597f9..c7d5186933166 100644 --- a/rb/AGENTS.md +++ b/rb/AGENTS.md @@ -49,3 +49,28 @@ Use YARD for public APIs: # @return [Type] description # @raise [ErrorClass] when condition ``` + +## Integration test guards + +Integration specs are guarded by RSpec metadata ...
[ "rb/AGENTS.md" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Wrong guard array semantics <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\nrb/AGENTS.md claims β€œArray of Hashes = OR (any matches)”, but the guard engine flatten...
true
SeleniumHQ/selenium
17,644
issue_to_patch
[build] start X server before launching fluxbox
Tests that require a windows manager are frequently failing because Fluxbox is attempting to start before xvfb is ready This is a race condition and the failure is silent in the GitHub step, but logs: `Couldn't connect to XServer:99` ### πŸ’₯ What does this PR do? * Waits for the X server before starting fluxbox. ###...
c779dcd5ed35092a41196561c5bd5dbe0d0df500
3d00184621958c595c0318ff1772676ec246eab6
diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index b43b8c84c1341..edd8c9f5dadb3 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -171,8 +171,14 @@ jobs: - name: Setup Fluxbox and Xvfb if: inputs.needs-display && inputs.os == 'ubuntu' run: |...
[ ".github/workflows/bazel.yml" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. <b><i>xdpyinfo</i></b> loop never fails <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\nThe workflow’s X server readiness wait loop can time out withou...
true
SeleniumHQ/selenium
17,644
comment_to_fix
[build] start X server before launching fluxbox
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. <b><i>xdpyinfo</i></b> loop never fails <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code> <pre> The workflow’s X server readiness wait loop can time out without failing, so the step still proce...
c779dcd5ed35092a41196561c5bd5dbe0d0df500
3d00184621958c595c0318ff1772676ec246eab6
diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index b43b8c84c1341..edd8c9f5dadb3 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -171,8 +171,14 @@ jobs: - name: Setup Fluxbox and Xvfb if: inputs.needs-display && inputs.os == 'ubuntu' run: |...
[ ".github/workflows/bazel.yml" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. <b><i>xdpyinfo</i></b> loop never fails <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\nThe workflow’s X server readiness wait loop can time out withou...
true
SeleniumHQ/selenium
17,648
issue_to_patch
[dotnet] [bidi] Fix reflection based deserialization of additional data
Fixes: ``` System.InvalidOperationException: Reflection-based serialization has been disabled for this application. Either use the source generator APIs or explicitly configure the 'JsonSerializerOptions.TypeInfoResolver' property. ``` ### πŸ”— Related Issues <!-- Example: Fixes #1234 or Closes #5678 --> <!-- If ...
c779dcd5ed35092a41196561c5bd5dbe0d0df500
0e0ab029c02b492cc9428af671e2d54395563f09
diff --git a/dotnet/src/webdriver/BiDi/Broker.cs b/dotnet/src/webdriver/BiDi/Broker.cs index f000e960bd9fb..8ab5d7ea66aac 100644 --- a/dotnet/src/webdriver/BiDi/Broker.cs +++ b/dotnet/src/webdriver/BiDi/Broker.cs @@ -263,7 +263,7 @@ private void ProcessReceivedMessage(ReadOnlySpan<byte> data) var propN...
[ "dotnet/src/webdriver/BiDi/Broker.cs" ]
[]
true
SeleniumHQ/selenium
17,637
issue_to_patch
[build] aggregate all lint errors instead of failing fast
### πŸ’₯ What does this PR do? * Makes lint tasks report **every** failure in a single run instead of exiting at the first one. * Updates other multiple step tasks to use the new implementation instead of inline rescue/capture * Automatic console logging based on keyword ### πŸ”§ Implementation Notes * Hash of keyword t...
13c534493c66362a627c5e4ca4c87cc55cf94ff2
ee5dcf09e068350c02ffb28a6e5fb4a45871607a
diff --git a/Rakefile b/Rakefile index 837d34ef93434..18872ac755b3c 100644 --- a/Rakefile +++ b/Rakefile @@ -143,13 +143,17 @@ task :format do |_task, arguments| Rake::Task['all:format'].invoke(*args) end -desc 'Run linters (may auto-fix some issues; stricter checks than :format)' -task :lint do - puts 'Linting ...
[ "Rakefile", "rake_tasks/common.rb", "rake_tasks/dotnet.rake", "rake_tasks/python.rake", "rake_tasks/ruby.rake" ]
[]
true
SeleniumHQ/selenium
17,609
issue_to_patch
[build] Automated Browser Version Update
This is an automated pull request to update pinned browsers and drivers Merge after verifying the new browser versions are properly passing the tests
ea8554e4500fcd9bb1b5397949fb26972b756b01
75d76eace307b214866fbdcab7949dafa6155b1b
diff --git a/common/repositories.bzl b/common/repositories.bzl index 3bda44143af17..610d976e85737 100644 --- a/common/repositories.bzl +++ b/common/repositories.bzl @@ -11,8 +11,8 @@ def pin_browsers(): http_archive( name = "linux_firefox", - url = "https://ftp.mozilla.org/pub/firefox/releases/15...
[ "common/repositories.bzl", "javascript/selenium-webdriver/test/firefox/addon_test.js", "py/test/selenium/webdriver/firefox/ff_installs_addons_tests.py", "rb/spec/integration/selenium/webdriver/firefox/driver_spec.rb" ]
[]
diff --git a/javascript/selenium-webdriver/test/firefox/addon_test.js b/javascript/selenium-webdriver/test/firefox/addon_test.js index 136451e81c631..991f635046c8c 100644 --- a/javascript/selenium-webdriver/test/firefox/addon_test.js +++ b/javascript/selenium-webdriver/test/firefox/addon_test.js @@ -19,7 +19,7 @@ co...
true
SeleniumHQ/selenium
17,639
issue_to_patch
[java] correct deprecation annotations for JSON Wire error code APIs
### πŸ”— Related Issues While we wait for #17638 to remove deprecated Error code, we shouldn't spam users/clients with warnings they cannot address. ### πŸ’₯ What does this PR do? Corrects the deprecation annotations on the legacy JSON Wire Protocol error-code APIs so they match reality and our deprecation policy. No beha...
fb7c10cd3701998f5ff175c77650b44ca4895abd
445b8238cd3b6cdefa39d209707598ad3277488a
diff --git a/java/src/org/openqa/selenium/remote/ErrorCodes.java b/java/src/org/openqa/selenium/remote/ErrorCodes.java index 495ab8bd8e033..ba9ff569c4ce9 100644 --- a/java/src/org/openqa/selenium/remote/ErrorCodes.java +++ b/java/src/org/openqa/selenium/remote/ErrorCodes.java @@ -54,8 +54,15 @@ import org.openqa.selen...
[ "java/src/org/openqa/selenium/remote/ErrorCodes.java", "java/src/org/openqa/selenium/remote/Response.java" ]
[]
true
SeleniumHQ/selenium
17,635
issue_to_patch
[πŸ› Bug]: [dotnet] Exception for Safari/BiDi is weird ### Description System.UriFormatException : Invalid URI: The format of the URI could not be determined. at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind, UriCreationOptions& creationOptions) at System.Uri..ctor(String uriString) at OpenQA.S...
[dotnet] [bidi] Better exception message in case of malformed capability url
### πŸ”— Related Issues Fixes https://github.com/SeleniumHQ/selenium/issues/17634 ### πŸ’₯ What does this PR do? Adds guard for url provided by browser. ### πŸ”§ Implementation Notes And use `Uri` in contract as type safe. ### πŸ€– AI assistance <!-- Check one. See CONTRIBUTING.md for policy details. --> - [ ] ...
eff36c972dd5ee6406597ab1457124383fbb9ec3
ad4d865fce685281ab658735d62cedfa77e6a0e0
diff --git a/dotnet/src/webdriver/BiDi/BiDi.cs b/dotnet/src/webdriver/BiDi/BiDi.cs index aa357152b5410..93dd627890567 100644 --- a/dotnet/src/webdriver/BiDi/BiDi.cs +++ b/dotnet/src/webdriver/BiDi/BiDi.cs @@ -53,12 +53,14 @@ private BiDi() { } public Emulation.IEmulationModule Emulation => AsModule<Emulation.Emu...
[ "dotnet/src/webdriver/BiDi/BiDi.cs", "dotnet/src/webdriver/BiDi/WebDriver.Extensions.cs", "dotnet/test/webdriver/BUILD.bazel", "dotnet/test/webdriver/BiDi/SessionUnitTests.cs", "dotnet/test/webdriver/BiDi/WebDriverExtensionsTests.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Removed <b><i>connectasync(string)</i></b> overload <code>πŸ“˜ Rule violation</code> <code>βš™ Maintainability</code>\n\n<pre>\n<b><i>BiDi.ConnectAsync</i></b> was changed fro...
diff --git a/dotnet/test/webdriver/BUILD.bazel b/dotnet/test/webdriver/BUILD.bazel index a8aa647091b88..b1161a0f296e8 100644 --- a/dotnet/test/webdriver/BUILD.bazel +++ b/dotnet/test/webdriver/BUILD.bazel @@ -50,6 +50,7 @@ dotnet_nunit_test_suite( "//dotnet/src/webdriver:webdriver-net8.0", "//dotnet/t...
true
SeleniumHQ/selenium
17,635
comment_to_fix
[dotnet] [bidi] Better exception message in case of malformed capability url
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Removed <b><i>connectasync(string)</i></b> overload <code>πŸ“˜ Rule violation</code> <code>βš™ Maintainability</code> <pre> <b><i>BiDi.ConnectAsync</i></b> was changed from taking a <b><i>string url</i></b...
eff36c972dd5ee6406597ab1457124383fbb9ec3
ad4d865fce685281ab658735d62cedfa77e6a0e0
diff --git a/dotnet/src/webdriver/BiDi/BiDi.cs b/dotnet/src/webdriver/BiDi/BiDi.cs index aa357152b5410..93dd627890567 100644 --- a/dotnet/src/webdriver/BiDi/BiDi.cs +++ b/dotnet/src/webdriver/BiDi/BiDi.cs @@ -53,12 +53,14 @@ private BiDi() { } public Emulation.IEmulationModule Emulation => AsModule<Emulation.Emu...
[ "dotnet/src/webdriver/BiDi/BiDi.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Removed <b><i>connectasync(string)</i></b> overload <code>πŸ“˜ Rule violation</code> <code>βš™ Maintainability</code>\n\n<pre>\n<b><i>BiDi.ConnectAsync</i></b> was changed fro...
true
SeleniumHQ/selenium
17,550
issue_to_patch
[rb] streamline tests on github actions runners
### πŸ”— Related Issues Ruby implementation of #17539 Supersedes #16813 ### πŸ’₯ What does this PR do? Splits execution into two pieces: manual/scheduled and PR/Push * PR/Push * Runs "Smoke tests": se-manager and os-sensitive and unit tests on stable browser versions * Runs only affected targets within s...
cd46b71b09d0dcfae2c23d54a7e1f1f38cb5c125
8f2902e376d84bb7a28329e387452b28d6328cd0
diff --git a/.github/workflows/ci-ruby.yml b/.github/workflows/ci-ruby.yml index 0f6b3e5174a89..c6a3702fed30f 100644 --- a/.github/workflows/ci-ruby.yml +++ b/.github/workflows/ci-ruby.yml @@ -2,45 +2,41 @@ name: CI - Ruby on: workflow_call: + inputs: + targets: + required: true + type: stri...
[ ".github/workflows/ci-ruby.yml", ".github/workflows/ci.yml", "README.md", "rb/BUILD.bazel", "rb/spec/tests.bzl", "rb/spec/unit/selenium/webdriver/guard_spec.rb", "scripts/github-actions/bazel-test-if-targets.sh" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Bazel exit code 4 ignored <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\nThe <b><i>os-tests</i></b> job treats <b><i>bazel test</i></b> exit code <b><...
diff --git a/rb/spec/tests.bzl b/rb/spec/tests.bzl index 566130e77dee8..03b932b68e754 100644 --- a/rb/spec/tests.bzl +++ b/rb/spec/tests.bzl @@ -170,8 +170,8 @@ DEFAULT_BROWSERS = [b for b in BROWSERS.keys() if b not in ("ie", "safari-previe # Tags listed here apply only to the local target of the listed browsers. ...
true
SeleniumHQ/selenium
17,550
comment_to_fix
[rb] streamline tests on github actions runners
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Bazel exit code 4 ignored <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code> <pre> The <b><i>os-tests</i></b> job treats <b><i>bazel test</i></b> exit code <b><i>4</i></b> as success, which can ...
cd46b71b09d0dcfae2c23d54a7e1f1f38cb5c125
8f2902e376d84bb7a28329e387452b28d6328cd0
diff --git a/.github/workflows/ci-ruby.yml b/.github/workflows/ci-ruby.yml index 0f6b3e5174a89..c6a3702fed30f 100644 --- a/.github/workflows/ci-ruby.yml +++ b/.github/workflows/ci-ruby.yml @@ -2,45 +2,41 @@ name: CI - Ruby on: workflow_call: + inputs: + targets: + required: true + type: stri...
[ ".github/workflows/ci-ruby.yml" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Bazel exit code 4 ignored <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\nThe <b><i>os-tests</i></b> job treats <b><i>bazel test</i></b> exit code <b><...
true
SeleniumHQ/selenium
17,550
comment_to_fix
[rb] streamline tests on github actions runners
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 2\. Grep exits read-targets <code>🐞 Bug</code> <code>☼ Reliability</code> <pre> In ci.yml, process_binding assigns lang_targets via a pipeline containing grep; when there are no matching Ruby targets, gre...
cd46b71b09d0dcfae2c23d54a7e1f1f38cb5c125
8f2902e376d84bb7a28329e387452b28d6328cd0
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 13d69d5811387..304461decd699 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -65,7 +65,7 @@ jobs: java: ${{ steps.read.outputs.java }} grid: ${{ steps.read.outputs.grid }} py: ${{ steps.read.outputs.py }}...
[ ".github/workflows/ci.yml" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n2\\. Grep exits read-targets <code>🐞 Bug</code> <code>☼ Reliability</code>\n\n<pre>\nIn ci.yml, process_binding assigns lang_targets via a pipeline containing grep; when there...
true
SeleniumHQ/selenium
17,550
comment_to_fix
[rb] streamline tests on github actions runners
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 3\. Dispatch missing targets input <code>🐞 Bug</code> <code>≑ Correctness</code> <pre> ci-ruby.yml uses <b><i>${{ inputs.targets }}</i></b> in the os-tests Bazel command, but <b><i>targets</i></b> is only...
cd46b71b09d0dcfae2c23d54a7e1f1f38cb5c125
8f2902e376d84bb7a28329e387452b28d6328cd0
diff --git a/.github/workflows/ci-ruby.yml b/.github/workflows/ci-ruby.yml index 0f6b3e5174a89..c6a3702fed30f 100644 --- a/.github/workflows/ci-ruby.yml +++ b/.github/workflows/ci-ruby.yml @@ -2,45 +2,41 @@ name: CI - Ruby on: workflow_call: + inputs: + targets: + required: true + type: stri...
[ ".github/workflows/ci-ruby.yml" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n3\\. Dispatch missing targets input <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\nci-ruby.yml uses <b><i>${{ inputs.targets }}</i></b> in the os-tests Bazel command,...
true
SeleniumHQ/selenium
17,550
comment_to_fix
[rb] streamline tests on github actions runners
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 4\. Boolean passed as browser <code>🐞 Bug</code> <code>≑ Correctness</code> <pre> ci-ruby.yml sets <b><i>matrix.browser: true</i></b> (boolean) and passes it into bazel.yml where <b><i>browser</i></b> is ...
cd46b71b09d0dcfae2c23d54a7e1f1f38cb5c125
8f2902e376d84bb7a28329e387452b28d6328cd0
diff --git a/.github/workflows/ci-ruby.yml b/.github/workflows/ci-ruby.yml index 0f6b3e5174a89..c6a3702fed30f 100644 --- a/.github/workflows/ci-ruby.yml +++ b/.github/workflows/ci-ruby.yml @@ -2,45 +2,41 @@ name: CI - Ruby on: workflow_call: + inputs: + targets: + required: true + type: stri...
[ ".github/workflows/ci-ruby.yml" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n4\\. Boolean passed as browser <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\nci-ruby.yml sets <b><i>matrix.browser: true</i></b> (boolean) and passes it into bazel.y...
true
SeleniumHQ/selenium
17,550
comment_to_fix
[rb] streamline tests on github actions runners
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 5\. Macos runs safari-preview tests <code>🐞 Bug</code> <code>☼ Reliability</code> <pre> The macOS os-tests job includes <b><i>skip-rbe</i></b> as a positive <b><i>--test_tag_filters</i></b> value, which m...
cd46b71b09d0dcfae2c23d54a7e1f1f38cb5c125
8f2902e376d84bb7a28329e387452b28d6328cd0
diff --git a/.github/workflows/ci-ruby.yml b/.github/workflows/ci-ruby.yml index 0f6b3e5174a89..c6a3702fed30f 100644 --- a/.github/workflows/ci-ruby.yml +++ b/.github/workflows/ci-ruby.yml @@ -2,45 +2,41 @@ name: CI - Ruby on: workflow_call: + inputs: + targets: + required: true + type: stri...
[ ".github/workflows/ci-ruby.yml" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n5\\. Macos runs safari-preview tests <code>🐞 Bug</code> <code>☼ Reliability</code>\n\n<pre>\nThe macOS os-tests job includes <b><i>skip-rbe</i></b> as a positive <b><i>--test_...
true
SeleniumHQ/selenium
17,550
comment_to_fix
[rb] streamline tests on github actions runners
`os-tests` relies on `${{ inputs.targets }}`, but `targets` is only defined for `workflow_call`. When this workflow is triggered via `workflow_dispatch`, `inputs.targets` will be unset/empty, which can make the `bazel test` invocation fail due to having no targets. Define the same `targets` input (with the same default...
cd46b71b09d0dcfae2c23d54a7e1f1f38cb5c125
8f2902e376d84bb7a28329e387452b28d6328cd0
diff --git a/.github/workflows/ci-ruby.yml b/.github/workflows/ci-ruby.yml index 0f6b3e5174a89..c6a3702fed30f 100644 --- a/.github/workflows/ci-ruby.yml +++ b/.github/workflows/ci-ruby.yml @@ -2,45 +2,41 @@ name: CI - Ruby on: workflow_call: + inputs: + targets: + required: true + type: stri...
[ ".github/workflows/ci-ruby.yml" ]
[ { "comment": "`os-tests` relies on `${{ inputs.targets }}`, but `targets` is only defined for `workflow_call`. When this workflow is triggered via `workflow_dispatch`, `inputs.targets` will be unset/empty, which can make the `bazel test` invocation fail due to having no targets. Define the same `targets` input ...
true
SeleniumHQ/selenium
17,550
comment_to_fix
[rb] streamline tests on github actions runners
`browser: true` in the matrix is a YAML boolean, but the called reusable workflow (`.github/workflows/bazel.yml`) defines `browser` as a `string` input. Passing a boolean here can cause workflow input type validation failures. Use a string value instead (e.g., quote it as `'true'`, leave it empty, or pass an actual bro...
cd46b71b09d0dcfae2c23d54a7e1f1f38cb5c125
8f2902e376d84bb7a28329e387452b28d6328cd0
diff --git a/.github/workflows/ci-ruby.yml b/.github/workflows/ci-ruby.yml index 0f6b3e5174a89..c6a3702fed30f 100644 --- a/.github/workflows/ci-ruby.yml +++ b/.github/workflows/ci-ruby.yml @@ -2,45 +2,41 @@ name: CI - Ruby on: workflow_call: + inputs: + targets: + required: true + type: stri...
[ ".github/workflows/ci-ruby.yml" ]
[ { "comment": "`browser: true` in the matrix is a YAML boolean, but the called reusable workflow (`.github/workflows/bazel.yml`) defines `browser` as a `string` input. Passing a boolean here can cause workflow input type validation failures. Use a string value instead (e.g., quote it as `'true'`, leave it empty,...
true
SeleniumHQ/selenium
17,550
comment_to_fix
[rb] streamline tests on github actions runners
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Ie remote tests included <code>🐞 Bug</code> <code>≑ Correctness</code> <pre> The Windows <b><i>os-tests</i></b> job uses <b><i>--test_tag_filters=edge,edge-remote,unit,skip-rbe,-ie</i></b>, but IE rem...
cd46b71b09d0dcfae2c23d54a7e1f1f38cb5c125
8f2902e376d84bb7a28329e387452b28d6328cd0
diff --git a/.github/workflows/ci-ruby.yml b/.github/workflows/ci-ruby.yml index 0f6b3e5174a89..c6a3702fed30f 100644 --- a/.github/workflows/ci-ruby.yml +++ b/.github/workflows/ci-ruby.yml @@ -2,45 +2,41 @@ name: CI - Ruby on: workflow_call: + inputs: + targets: + required: true + type: stri...
[ ".github/workflows/ci-ruby.yml" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Ie remote tests included <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\nThe Windows <b><i>os-tests</i></b> job uses <b><i>--test_tag_filters=edge,edge-remote,uni...
true
SeleniumHQ/selenium
17,550
comment_to_fix
[rb] streamline tests on github actions runners
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Unvalidated <b><i>targets</i></b> shell injection <code>πŸ“˜ Rule violation</code> <code>⛨ Security</code> <pre> <b><i>workflow_dispatch</i></b> introduces a user-provided <b><i>targets</i></b> input tha...
cd46b71b09d0dcfae2c23d54a7e1f1f38cb5c125
8f2902e376d84bb7a28329e387452b28d6328cd0
diff --git a/.github/workflows/ci-ruby.yml b/.github/workflows/ci-ruby.yml index 0f6b3e5174a89..c6a3702fed30f 100644 --- a/.github/workflows/ci-ruby.yml +++ b/.github/workflows/ci-ruby.yml @@ -2,45 +2,41 @@ name: CI - Ruby on: workflow_call: + inputs: + targets: + required: true + type: stri...
[ ".github/workflows/ci-ruby.yml" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Unvalidated <b><i>targets</i></b> shell injection <code>πŸ“˜ Rule violation</code> <code>⛨ Security</code>\n\n<pre>\n<b><i>workflow_dispatch</i></b> introduces a user-provid...
true
SeleniumHQ/selenium
17,550
comment_to_fix
[rb] streamline tests on github actions runners
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Invalid <b><i>matrix.tag-filters</i></b> access <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code> <pre> The workflow references <b><i>matrix.tag-filters</i></b>, but matrix keys containing <b><...
cd46b71b09d0dcfae2c23d54a7e1f1f38cb5c125
8f2902e376d84bb7a28329e387452b28d6328cd0
diff --git a/.github/workflows/ci-ruby.yml b/.github/workflows/ci-ruby.yml index 0f6b3e5174a89..c6a3702fed30f 100644 --- a/.github/workflows/ci-ruby.yml +++ b/.github/workflows/ci-ruby.yml @@ -2,45 +2,41 @@ name: CI - Ruby on: workflow_call: + inputs: + targets: + required: true + type: stri...
[ ".github/workflows/ci-ruby.yml" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Invalid <b><i>matrix.tag-filters</i></b> access <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\nThe workflow references <b><i>matrix.tag-filters</i></b...
true
SeleniumHQ/selenium
17,550
comment_to_fix
[rb] streamline tests on github actions runners
`unit-tests` and `os-tests-full` are gated on `github.event_name == 'schedule'`, but this workflow is only triggered by `workflow_call`/`workflow_dispatch`. When invoked from `ci.yml` on a scheduled run, `github.event_name` in this reusable workflow will be `workflow_call`, so the β€œfull” suite will never run and the `s...
cd46b71b09d0dcfae2c23d54a7e1f1f38cb5c125
8f2902e376d84bb7a28329e387452b28d6328cd0
diff --git a/.github/workflows/ci-ruby.yml b/.github/workflows/ci-ruby.yml index 0f6b3e5174a89..c6a3702fed30f 100644 --- a/.github/workflows/ci-ruby.yml +++ b/.github/workflows/ci-ruby.yml @@ -2,45 +2,41 @@ name: CI - Ruby on: workflow_call: + inputs: + targets: + required: true + type: stri...
[ ".github/workflows/ci-ruby.yml" ]
[ { "comment": "`unit-tests` and `os-tests-full` are gated on `github.event_name == 'schedule'`, but this workflow is only triggered by `workflow_call`/`workflow_dispatch`. When invoked from `ci.yml` on a scheduled run, `github.event_name` in this reusable workflow will be `workflow_call`, so the β€œfull” suite wil...
true
SeleniumHQ/selenium
17,550
comment_to_fix
[rb] streamline tests on github actions runners
`ci-ruby.yml` now needs to distinguish PR/push β€œsmoke” runs vs scheduled/manual β€œfull” runs, but this caller only passes `targets`. Without also passing an explicit mode (or the original caller event name), the reusable workflow can’t reliably select the intended job set.
cd46b71b09d0dcfae2c23d54a7e1f1f38cb5c125
8f2902e376d84bb7a28329e387452b28d6328cd0
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 13d69d5811387..304461decd699 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -65,7 +65,7 @@ jobs: java: ${{ steps.read.outputs.java }} grid: ${{ steps.read.outputs.grid }} py: ${{ steps.read.outputs.py }}...
[ ".github/workflows/ci.yml" ]
[ { "comment": "`ci-ruby.yml` now needs to distinguish PR/push β€œsmoke” runs vs scheduled/manual β€œfull” runs, but this caller only passes `targets`. Without also passing an explicit mode (or the original caller event name), the reusable workflow can’t reliably select the intended job set.", "path": ".github/wo...
true
SeleniumHQ/selenium
17,550
comment_to_fix
[rb] streamline tests on github actions runners
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Schedule-gated jobs never run <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code> <pre> <b><i>ci-ruby.yml</i></b> is only invoked via <b><i>workflow_call</i></b> from <b><i>ci.yml</i></b>, but it...
cd46b71b09d0dcfae2c23d54a7e1f1f38cb5c125
8f2902e376d84bb7a28329e387452b28d6328cd0
diff --git a/.github/workflows/ci-ruby.yml b/.github/workflows/ci-ruby.yml index 0f6b3e5174a89..c6a3702fed30f 100644 --- a/.github/workflows/ci-ruby.yml +++ b/.github/workflows/ci-ruby.yml @@ -2,45 +2,41 @@ name: CI - Ruby on: workflow_call: + inputs: + targets: + required: true + type: stri...
[ ".github/workflows/ci-ruby.yml" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Schedule-gated jobs never run <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\n<b><i>ci-ruby.yml</i></b> is only invoked via <b><i>workflow_call</i></b>...
true
SeleniumHQ/selenium
17,550
comment_to_fix
[rb] streamline tests on github actions runners
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 2\. Safari setup skipped <code>🐞 Bug</code> <code>☼ Reliability</code> <pre> <b><i>os-tests-full</i></b> passes <b><i>browser: safari-local</i></b> into <b><i>bazel.yml</i></b>, but <b><i>bazel.yml</i></b...
cd46b71b09d0dcfae2c23d54a7e1f1f38cb5c125
8f2902e376d84bb7a28329e387452b28d6328cd0
diff --git a/.github/workflows/ci-ruby.yml b/.github/workflows/ci-ruby.yml index 0f6b3e5174a89..c6a3702fed30f 100644 --- a/.github/workflows/ci-ruby.yml +++ b/.github/workflows/ci-ruby.yml @@ -2,45 +2,41 @@ name: CI - Ruby on: workflow_call: + inputs: + targets: + required: true + type: stri...
[ ".github/workflows/ci-ruby.yml" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n2\\. Safari setup skipped <code>🐞 Bug</code> <code>☼ Reliability</code>\n\n<pre>\n<b><i>os-tests-full</i></b> passes <b><i>browser: safari-local</i></b> into <b><i>bazel.yml</...
true
SeleniumHQ/selenium
17,626
issue_to_patch
[build] make release pipeline rerun-safe
The primary failure pattern for releases recently is when one language fails to publish for some reason, the rest of the flow can't continue and everything needs to be processed manually. This will allow us to click "Rerun failed jobs" and it shouldn't break anything. ### πŸ’₯ What does this PR do? * Rescue the er...
6104d68845eb6eedbaa304ab14aeb6178cc5662e
92a9dbf4f9a5fc528f7eb991861255daab5db18c
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 820ea33f47537..a610be58796ff 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -66,20 +66,23 @@ jobs: secrets: SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} - create-language-tag: - n...
[ ".github/workflows/release.yml", "rake_tasks/node.rake", "rake_tasks/ruby.rake" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Java rerun blocks other releases <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\nThe publish matrix exits with an error on any rerun for the Java entry before it ...
true
SeleniumHQ/selenium
17,626
comment_to_fix
[build] make release pipeline rerun-safe
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Java rerun blocks other releases <code>🐞 Bug</code> <code>≑ Correctness</code> <pre> The publish matrix exits with an error on any rerun for the Java entry before it checks whether Java is actually be...
6104d68845eb6eedbaa304ab14aeb6178cc5662e
92a9dbf4f9a5fc528f7eb991861255daab5db18c
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 820ea33f47537..a610be58796ff 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -66,20 +66,23 @@ jobs: secrets: SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} - create-language-tag: - n...
[ ".github/workflows/release.yml" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Java rerun blocks other releases <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\nThe publish matrix exits with an error on any rerun for the Java entry before it ...
true
SeleniumHQ/selenium
17,626
comment_to_fix
[build] make release pipeline rerun-safe
`create-tag` is intended to create the release tag up-front, but `github-release-draft` can still start in parallel and may create the tag itself (release creation API auto-creates missing tags). To ensure the workflow no longer relies on the GitHub Release step to create the tag, make `github-release-draft` depend on ...
6104d68845eb6eedbaa304ab14aeb6178cc5662e
92a9dbf4f9a5fc528f7eb991861255daab5db18c
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 820ea33f47537..a610be58796ff 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -66,20 +66,23 @@ jobs: secrets: SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} - create-language-tag: - n...
[ ".github/workflows/release.yml" ]
[ { "comment": "`create-tag` is intended to create the release tag up-front, but `github-release-draft` can still start in parallel and may create the tag itself (release creation API auto-creates missing tags). To ensure the workflow no longer relies on the GitHub Release step to create the tag, make `github-rel...
true
SeleniumHQ/selenium
17,626
comment_to_fix
[build] make release pipeline rerun-safe
This job can still start before `create-tag` completes (it doesn't depend on it), so the release tasks may run without the tag having been created β€œat the beginning of the workflow”. Consider making `publish` depend on `create-tag` so tag creation is ordered ahead of package publishing.
6104d68845eb6eedbaa304ab14aeb6178cc5662e
92a9dbf4f9a5fc528f7eb991861255daab5db18c
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 820ea33f47537..a610be58796ff 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -66,20 +66,23 @@ jobs: secrets: SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} - create-language-tag: - n...
[ ".github/workflows/release.yml" ]
[ { "comment": "This job can still start before `create-tag` completes (it doesn't depend on it), so the release tasks may run without the tag having been created β€œat the beginning of the workflow”. Consider making `publish` depend on `create-tag` so tag creation is ordered ahead of package publishing.", "pat...
true
SeleniumHQ/selenium
17,626
comment_to_fix
[build] make release pipeline rerun-safe
`github.run_attempt` is a numeric context value; comparing it to the string `'1'` is needlessly brittle. Use a numeric comparison (e.g., `> 1`) to clearly express β€œrerun attempt”.
6104d68845eb6eedbaa304ab14aeb6178cc5662e
92a9dbf4f9a5fc528f7eb991861255daab5db18c
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 820ea33f47537..a610be58796ff 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -66,20 +66,23 @@ jobs: secrets: SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} - create-language-tag: - n...
[ ".github/workflows/release.yml" ]
[ { "comment": "`github.run_attempt` is a numeric context value; comparing it to the string `'1'` is needlessly brittle. Use a numeric comparison (e.g., `> 1`) to clearly express β€œrerun attempt”.", "path": ".github/workflows/release.yml", "hunk": "@@ -138,7 +141,16 @@ jobs:\n name: Publish ${{ matri...
true
SeleniumHQ/selenium
17,633
issue_to_patch
[dotnet] [bidi] Additional json data for event args
Decisions: - Remove concept of shared types, clear serializable `EventArgs` - `EventArgs` is central place for logical operations over json, now it is serializable ### πŸ”— Related Issues Contributes to https://github.com/SeleniumHQ/selenium/issues/16095 ### πŸ’₯ What does this PR do? This pull request refactors ...
822461158e132b185b41a14de9af5ece9e5b9027
c43973e64420eb0fda49575af9330be36a134e51
diff --git a/dotnet/src/webdriver/BiDi/Broker.cs b/dotnet/src/webdriver/BiDi/Broker.cs index df291ea3055fc..f000e960bd9fb 100644 --- a/dotnet/src/webdriver/BiDi/Broker.cs +++ b/dotnet/src/webdriver/BiDi/Broker.cs @@ -307,7 +307,7 @@ private void ProcessReceivedMessage(ReadOnlySpan<byte> data) case TypeEven...
[ "dotnet/src/webdriver/BiDi/Broker.cs", "dotnet/src/webdriver/BiDi/BrowsingContext/BrowsingContextEvent.cs", "dotnet/src/webdriver/BiDi/BrowsingContext/BrowsingContextModule.cs", "dotnet/src/webdriver/BiDi/BrowsingContext/ContextCreatedEvent.cs", "dotnet/src/webdriver/BiDi/BrowsingContext/ContextDestroyedEve...
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. <b><i>eventargs</i></b> made json-serializable <code>πŸ“Ž Requirement gap</code> <code>βš™ Maintainability</code>\n\n<pre>\n<b><i>EventArgs</i></b> is now directly JSON-deseri...
diff --git a/dotnet/test/webdriver/BiDi/FakeTransport.cs b/dotnet/test/webdriver/BiDi/FakeTransport.cs index 248f2634e81e3..50b7aab1effb3 100644 --- a/dotnet/test/webdriver/BiDi/FakeTransport.cs +++ b/dotnet/test/webdriver/BiDi/FakeTransport.cs @@ -48,6 +48,8 @@ internal sealed class FakeTransport : ITransport pri...
true
SeleniumHQ/selenium
17,633
comment_to_fix
[dotnet] [bidi] Additional json data for event args
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. <b><i>eventargs</i></b> made json-serializable <code>πŸ“Ž Requirement gap</code> <code>βš™ Maintainability</code> <pre> <b><i>EventArgs</i></b> is now directly JSON-deserializable (via <b><i>JsonExtensionD...
822461158e132b185b41a14de9af5ece9e5b9027
c43973e64420eb0fda49575af9330be36a134e51
diff --git a/dotnet/src/webdriver/BiDi/EventArgs.cs b/dotnet/src/webdriver/BiDi/EventArgs.cs index 9b78d23ef06e2..b3280b2d9ea78 100644 --- a/dotnet/src/webdriver/BiDi/EventArgs.cs +++ b/dotnet/src/webdriver/BiDi/EventArgs.cs @@ -17,6 +17,29 @@ // under the License. // </copyright> +using System.ComponentModel; +usi...
[ "dotnet/src/webdriver/BiDi/EventArgs.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. <b><i>eventargs</i></b> made json-serializable <code>πŸ“Ž Requirement gap</code> <code>βš™ Maintainability</code>\n\n<pre>\n<b><i>EventArgs</i></b> is now directly JSON-deseri...
true
SeleniumHQ/selenium
17,633
comment_to_fix
[dotnet] [bidi] Additional json data for event args
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 2\. <b><i>eventdescriptor.create</i></b> signature changed <code>πŸ“˜ Rule violation</code> <code>βš™ Maintainability</code> <pre> Public API <b><i>EventDescriptor&lt;TEventArgs&gt;.Create</i></b> removed the ...
822461158e132b185b41a14de9af5ece9e5b9027
c43973e64420eb0fda49575af9330be36a134e51
diff --git a/dotnet/src/webdriver/BiDi/EventDescriptor.cs b/dotnet/src/webdriver/BiDi/EventDescriptor.cs index e4116ee1645cc..6bd0d1a69ebc8 100644 --- a/dotnet/src/webdriver/BiDi/EventDescriptor.cs +++ b/dotnet/src/webdriver/BiDi/EventDescriptor.cs @@ -26,7 +26,6 @@ public abstract class EventDescriptor public str...
[ "dotnet/src/webdriver/BiDi/EventDescriptor.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n2\\. <b><i>eventdescriptor.create</i></b> signature changed <code>πŸ“˜ Rule violation</code> <code>βš™ Maintainability</code>\n\n<pre>\nPublic API <b><i>EventDescriptor&lt;TEventAr...
true
SeleniumHQ/selenium
17,633
comment_to_fix
[dotnet] [bidi] Additional json data for event args
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 3\. Wrong eventargs namespace <code>🐞 Bug</code> <code>≑ Correctness</code> <pre> <b><i>SomethingHappenedEventArgs</i></b> in SessionTests inherits from <b><i>Selenium.BiDi.EventArgs</i></b>, but the actu...
822461158e132b185b41a14de9af5ece9e5b9027
c43973e64420eb0fda49575af9330be36a134e51
diff --git a/dotnet/test/webdriver/BiDi/Session/SessionTests.cs b/dotnet/test/webdriver/BiDi/Session/SessionTests.cs index ccf839f718931..8e959a2ff5555 100644 --- a/dotnet/test/webdriver/BiDi/Session/SessionTests.cs +++ b/dotnet/test/webdriver/BiDi/Session/SessionTests.cs @@ -184,10 +184,9 @@ class CustomModule : Modul...
[ "dotnet/test/webdriver/BiDi/Session/SessionTests.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n3\\. Wrong eventargs namespace <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\n<b><i>SomethingHappenedEventArgs</i></b> in SessionTests inherits from <b><i>Selenium.Bi...
true
SeleniumHQ/selenium
17,632
issue_to_patch
[py] Add high-level BiDi network extra headers API
### πŸ”— Related Issues Follows #17629 (authentication handlers); final network-module phase of the BiDi Protocol API Design, following #17619 and #17623. ### πŸ’₯ What does this PR do? Adds the extra-headers API to `driver.network`, aligned with the Network Module section of the cross-binding BiDi API design: ```python ...
822461158e132b185b41a14de9af5ece9e5b9027
81afab81bd74c192dd3f83851fffd66104db4b99
diff --git a/py/private/_network_handlers.py b/py/private/_network_handlers.py index 25c21139a7990..7eaafdb0a4c5d 100644 --- a/py/private/_network_handlers.py +++ b/py/private/_network_handlers.py @@ -52,6 +52,12 @@ continued with action ``default`` so the browser's own behavior (usually the authentication prompt) ap...
[ "py/private/_network_handlers.py", "py/private/bidi_enhancements_manifest.py", "py/test/selenium/webdriver/common/bidi_network_tests.py", "py/test/unit/selenium/webdriver/common/bidi_network_tests.py" ]
[]
diff --git a/py/test/selenium/webdriver/common/bidi_network_tests.py b/py/test/selenium/webdriver/common/bidi_network_tests.py index 40656157c9312..83fb96c594a33 100644 --- a/py/test/selenium/webdriver/common/bidi_network_tests.py +++ b/py/test/selenium/webdriver/common/bidi_network_tests.py @@ -462,3 +462,44 @@ def te...
true
SeleniumHQ/selenium
17,629
issue_to_patch
[py] Add high-level BiDi network authentication handler API
### πŸ”— Related Issues Follows #17619 (request handlers) and #17623 (response handlers); Phase 3 of the BiDi Protocol API Design. ### πŸ’₯ What does this PR do? Adds the callback-based authentication handler API to `driver.network`, aligned with the Authentication Handling section of the cross-binding BiDi API design: `...
c1ffd8c3664b2b3913a06308e97966e72b0426d6
911800590ab3799655b29c1af69deb839dac5a19
diff --git a/py/private/_network_handlers.py b/py/private/_network_handlers.py index 52be89b2b7b8e..25c21139a7990 100644 --- a/py/private/_network_handlers.py +++ b/py/private/_network_handlers.py @@ -43,6 +43,15 @@ a new body), other mutations are applied via ``network.continueResponse``, and untouched responses are...
[ "py/private/_network_handlers.py", "py/private/bidi_enhancements_manifest.py", "py/test/selenium/webdriver/common/bidi_network_tests.py", "py/test/unit/selenium/webdriver/common/bidi_network_tests.py" ]
[]
diff --git a/py/test/selenium/webdriver/common/bidi_network_tests.py b/py/test/selenium/webdriver/common/bidi_network_tests.py index de8b6a305bacd..40656157c9312 100644 --- a/py/test/selenium/webdriver/common/bidi_network_tests.py +++ b/py/test/selenium/webdriver/common/bidi_network_tests.py @@ -94,6 +94,10 @@ def call...
true
SeleniumHQ/selenium
17,614
issue_to_patch
[dotnet] [bidi] Additional json data for commands/results
Supporting serialization of additional data (both on `params` and `envelope` levels) for commands and results. Usage: ```csharp await bidi.StatusAsync(new() { AdditionalData = new JsonObject { ["foo"] = "bar" } }); ``` or ```csharp await bidi.StatusAsync(new() { AdditionalData = """{"foo": "bar"...
2dddec9ab5320f6648c2982e6557c6bb46ed23eb
319e4f6aea51fda580cb4cf1adb8e2423b153bad
diff --git a/dotnet/src/webdriver/BiDi/AdditionalData.cs b/dotnet/src/webdriver/BiDi/AdditionalData.cs new file mode 100644 index 0000000000000..988075eda4f65 --- /dev/null +++ b/dotnet/src/webdriver/BiDi/AdditionalData.cs @@ -0,0 +1,95 @@ +// <copyright file="AdditionalData.cs" company="Selenium Committers"> +// Licen...
[ "dotnet/src/webdriver/BiDi/AdditionalData.cs", "dotnet/src/webdriver/BiDi/Broker.cs", "dotnet/src/webdriver/BiDi/Command.cs", "dotnet/test/webdriver/BiDi/SessionUnitTests.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Options additionaldata dropped <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\nCommandOptions.AdditionalData is never merged into the serialized &quot;params&quot...
diff --git a/dotnet/test/webdriver/BiDi/SessionUnitTests.cs b/dotnet/test/webdriver/BiDi/SessionUnitTests.cs index a8a11df3914d9..3e9a9f8bc71f0 100644 --- a/dotnet/test/webdriver/BiDi/SessionUnitTests.cs +++ b/dotnet/test/webdriver/BiDi/SessionUnitTests.cs @@ -17,6 +17,8 @@ // under the License. // </copyright> +us...
true
SeleniumHQ/selenium
17,614
comment_to_fix
[dotnet] [bidi] Additional json data for commands/results
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Options additionaldata dropped <code>🐞 Bug</code> <code>≑ Correctness</code> <pre> CommandOptions.AdditionalData is never merged into the serialized &quot;params&quot; object, so callers setting optio...
2dddec9ab5320f6648c2982e6557c6bb46ed23eb
319e4f6aea51fda580cb4cf1adb8e2423b153bad
diff --git a/dotnet/src/webdriver/BiDi/Command.cs b/dotnet/src/webdriver/BiDi/Command.cs index 36e5ab460aed5..147548b967071 100644 --- a/dotnet/src/webdriver/BiDi/Command.cs +++ b/dotnet/src/webdriver/BiDi/Command.cs @@ -17,6 +17,9 @@ // under the License. // </copyright> +using System.ComponentModel; +using System...
[ "dotnet/src/webdriver/BiDi/Command.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Options additionaldata dropped <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\nCommandOptions.AdditionalData is never merged into the serialized &quot;params&quot...
true
SeleniumHQ/selenium
17,614
comment_to_fix
[dotnet] [bidi] Additional json data for commands/results
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 2\. Reserved keys overridable <code>🐞 Bug</code> <code>☼ Reliability</code> <pre> Broker.ExecuteAsync writes options.AdditionalMessageData properties at the message root without filtering reserved keys, a...
2dddec9ab5320f6648c2982e6557c6bb46ed23eb
319e4f6aea51fda580cb4cf1adb8e2423b153bad
diff --git a/dotnet/src/webdriver/BiDi/Broker.cs b/dotnet/src/webdriver/BiDi/Broker.cs index c3ad598cadfd3..df291ea3055fc 100644 --- a/dotnet/src/webdriver/BiDi/Broker.cs +++ b/dotnet/src/webdriver/BiDi/Broker.cs @@ -96,7 +96,30 @@ public async Task<TResult> ExecuteAsync<TParameters, TResult>(Command<TParameter ...
[ "dotnet/src/webdriver/BiDi/Broker.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n2\\. Reserved keys overridable <code>🐞 Bug</code> <code>☼ Reliability</code>\n\n<pre>\nBroker.ExecuteAsync writes options.AdditionalMessageData properties at the message root ...
true
SeleniumHQ/selenium
17,614
comment_to_fix
[dotnet] [bidi] Additional json data for commands/results
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Trygetvalue throws on empty <code>🐞 Bug</code> <code>≑ Correctness</code> <pre> <b><i>AdditionalData.TryGetValue</i></b> calls <b><i>JsonElement.TryGetProperty</i></b> without guarding for non-object/...
2dddec9ab5320f6648c2982e6557c6bb46ed23eb
319e4f6aea51fda580cb4cf1adb8e2423b153bad
diff --git a/dotnet/src/webdriver/BiDi/AdditionalData.cs b/dotnet/src/webdriver/BiDi/AdditionalData.cs new file mode 100644 index 0000000000000..988075eda4f65 --- /dev/null +++ b/dotnet/src/webdriver/BiDi/AdditionalData.cs @@ -0,0 +1,95 @@ +// <copyright file="AdditionalData.cs" company="Selenium Committers"> +// Licen...
[ "dotnet/src/webdriver/BiDi/AdditionalData.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Trygetvalue throws on empty <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\n<b><i>AdditionalData.TryGetValue</i></b> calls <b><i>JsonElement.TryGetProperty</i></b...
true
SeleniumHQ/selenium
17,614
comment_to_fix
[dotnet] [bidi] Additional json data for commands/results
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. <b><i>stringsyntaxattribute</i></b> breaks multitarget build <code>πŸ“˜ Rule violation</code> <code>≑ Correctness</code> <pre> <b><i>AdditionalData</i></b> uses <b><i>StringSyntaxAttribute</i></b> on pub...
2dddec9ab5320f6648c2982e6557c6bb46ed23eb
319e4f6aea51fda580cb4cf1adb8e2423b153bad
diff --git a/dotnet/src/webdriver/BiDi/AdditionalData.cs b/dotnet/src/webdriver/BiDi/AdditionalData.cs new file mode 100644 index 0000000000000..988075eda4f65 --- /dev/null +++ b/dotnet/src/webdriver/BiDi/AdditionalData.cs @@ -0,0 +1,95 @@ +// <copyright file="AdditionalData.cs" company="Selenium Committers"> +// Licen...
[ "dotnet/src/webdriver/BiDi/AdditionalData.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. <b><i>stringsyntaxattribute</i></b> breaks multitarget build <code>πŸ“˜ Rule violation</code> <code>≑ Correctness</code>\n\n<pre>\n<b><i>AdditionalData</i></b> uses <b><i>St...
true
SeleniumHQ/selenium
17,614
comment_to_fix
[dotnet] [bidi] Additional json data for commands/results
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 2\. Non-object json silently dropped <code>🐞 Bug</code> <code>≑ Correctness</code> <pre> <b><i>AdditionalData(string json)</i></b> accepts any JSON root (including arrays/null/primitives), but the rest of...
2dddec9ab5320f6648c2982e6557c6bb46ed23eb
319e4f6aea51fda580cb4cf1adb8e2423b153bad
diff --git a/dotnet/src/webdriver/BiDi/AdditionalData.cs b/dotnet/src/webdriver/BiDi/AdditionalData.cs new file mode 100644 index 0000000000000..988075eda4f65 --- /dev/null +++ b/dotnet/src/webdriver/BiDi/AdditionalData.cs @@ -0,0 +1,95 @@ +// <copyright file="AdditionalData.cs" company="Selenium Committers"> +// Licen...
[ "dotnet/src/webdriver/BiDi/AdditionalData.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n2\\. Non-object json silently dropped <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\n<b><i>AdditionalData(string json)</i></b> accepts any JSON root (including arrays...
true
SeleniumHQ/selenium
17,614
comment_to_fix
[dotnet] [bidi] Additional json data for commands/results
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Extra field breaks parsing <code>🐞 Bug</code> <code>≑ Correctness</code> <pre> Broker.ProcessReceivedMessage deserializes unknown envelope properties using JsonSerializer.Deserialize(ref reader), whic...
2dddec9ab5320f6648c2982e6557c6bb46ed23eb
319e4f6aea51fda580cb4cf1adb8e2423b153bad
diff --git a/dotnet/src/webdriver/BiDi/Broker.cs b/dotnet/src/webdriver/BiDi/Broker.cs index c3ad598cadfd3..df291ea3055fc 100644 --- a/dotnet/src/webdriver/BiDi/Broker.cs +++ b/dotnet/src/webdriver/BiDi/Broker.cs @@ -96,7 +96,30 @@ public async Task<TResult> ExecuteAsync<TParameters, TResult>(Command<TParameter ...
[ "dotnet/src/webdriver/BiDi/Broker.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Extra field breaks parsing <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\nBroker.ProcessReceivedMessage deserializes unknown envelope properties using\nJsonSeria...
true
SeleniumHQ/selenium
17,614
comment_to_fix
[dotnet] [bidi] Additional json data for commands/results
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Params key collision possible <code>🐞 Bug</code> <code>≑ Correctness</code> <pre> Broker.ExecuteAsync merges CommandOptions.AdditionalData into Parameters.RawAdditionalData ([JsonExtensionData]) witho...
2dddec9ab5320f6648c2982e6557c6bb46ed23eb
319e4f6aea51fda580cb4cf1adb8e2423b153bad
diff --git a/dotnet/src/webdriver/BiDi/Broker.cs b/dotnet/src/webdriver/BiDi/Broker.cs index c3ad598cadfd3..df291ea3055fc 100644 --- a/dotnet/src/webdriver/BiDi/Broker.cs +++ b/dotnet/src/webdriver/BiDi/Broker.cs @@ -96,7 +96,30 @@ public async Task<TResult> ExecuteAsync<TParameters, TResult>(Command<TParameter ...
[ "dotnet/src/webdriver/BiDi/Broker.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Params key collision possible <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\nBroker.ExecuteAsync merges CommandOptions.AdditionalData into Parameters.RawAddition...
true
SeleniumHQ/selenium
17,614
comment_to_fix
[dotnet] [bidi] Additional json data for commands/results
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Wrong <b><i>additionalmessagedata</i></b> json assertion <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code> <pre> <b><i>CommandAdditionalMessageDataIsSerializedAsTopLevelFields</i></b> asserts a...
2dddec9ab5320f6648c2982e6557c6bb46ed23eb
319e4f6aea51fda580cb4cf1adb8e2423b153bad
diff --git a/dotnet/test/webdriver/BiDi/SessionUnitTests.cs b/dotnet/test/webdriver/BiDi/SessionUnitTests.cs index a8a11df3914d9..3e9a9f8bc71f0 100644 --- a/dotnet/test/webdriver/BiDi/SessionUnitTests.cs +++ b/dotnet/test/webdriver/BiDi/SessionUnitTests.cs @@ -17,6 +17,8 @@ // under the License. // </copyright> +us...
[ "dotnet/test/webdriver/BiDi/SessionUnitTests.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Wrong <b><i>additionalmessagedata</i></b> json assertion <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\n<b><i>CommandAdditionalMessageDataIsSerialized...
true
SeleniumHQ/selenium
17,624
issue_to_patch
[py] Align BiDi script module with the cross-binding API design
### πŸ”— Related Issues <!-- none --> ### πŸ’₯ What does this PR do? Aligns `driver.script` with the Script Module section of the BiDi Protocol API Design (Phase 5, following #17619 and #17623): - `add_error_handler(callback)` / `add_console_handler(callback)` deliver the doc's `ScriptError` / `ConsoleMessage` payloads c...
bcafedd07de3004a7e0ccdaebaf02b801bd0b7cb
426ffdc165b559ba89f802f3ceb8cbaed1e37489
diff --git a/py/BUILD.bazel b/py/BUILD.bazel index 0cacadd618347..6835e30127bbf 100644 --- a/py/BUILD.bazel +++ b/py/BUILD.bazel @@ -739,6 +739,7 @@ generate_bidi( extra_srcs = [ "//py/private:_event_manager.py", "//py/private:_network_handlers.py", + "//py/private:_script_handlers.py", ...
[ "py/BUILD.bazel", "py/private/BUILD.bazel", "py/private/_script_handlers.py", "py/private/bidi_enhancements_manifest.py", "py/test/selenium/webdriver/common/bidi_script_tests.py", "py/test/unit/selenium/webdriver/common/bidi_script_tests.py" ]
[]
diff --git a/py/test/selenium/webdriver/common/bidi_script_tests.py b/py/test/selenium/webdriver/common/bidi_script_tests.py index b0e9823efd661..a66842d06d693 100644 --- a/py/test/selenium/webdriver/common/bidi_script_tests.py +++ b/py/test/selenium/webdriver/common/bidi_script_tests.py @@ -1418,3 +1418,206 @@ def tes...
true
SeleniumHQ/selenium
17,623
issue_to_patch
[py] Add high-level BiDi network response handler API
### πŸ”— Related Issues <!-- none --> ### πŸ’₯ What does this PR do? Adds the doc-aligned high-level response interception API to `driver.network` (Phase 2 of the BiDi Protocol API Design, following #17619): - `add_response_handler(callback)` / `add_response_handler(url_patterns, callback)` with the same glob URL pattern...
db608302196e5a17faddd002bb0bcc7b0b09e9b8
3f7319670b4514e1c0ddec6144c0ca8f9034cc6c
diff --git a/py/private/_network_handlers.py b/py/private/_network_handlers.py index 6d4380a217870..52be89b2b7b8e 100644 --- a/py/private/_network_handlers.py +++ b/py/private/_network_handlers.py @@ -15,14 +15,15 @@ # specific language governing permissions and limitations # under the License. -"""High-level reque...
[ "py/private/_network_handlers.py", "py/private/bidi_enhancements_manifest.py", "py/test/selenium/webdriver/common/bidi_network_tests.py", "py/test/unit/selenium/webdriver/common/bidi_network_tests.py" ]
[]
diff --git a/py/test/selenium/webdriver/common/bidi_network_tests.py b/py/test/selenium/webdriver/common/bidi_network_tests.py index b909d0be48c1e..de8b6a305bacd 100644 --- a/py/test/selenium/webdriver/common/bidi_network_tests.py +++ b/py/test/selenium/webdriver/common/bidi_network_tests.py @@ -21,7 +21,7 @@ from s...
true
SeleniumHQ/selenium
17,627
issue_to_patch
[dotnet] [test] Introduce fake BiDi transport
And use it for some testing scenarios. Might be not elegant api, but it is OK for now. Also changed bidi options to factory instead of provided instance. It resolves ownership problems. ### πŸ’₯ What does this PR do? This pull request refactors and improves the BiDi (Bidirectional) WebDriver test suite by introduc...
db608302196e5a17faddd002bb0bcc7b0b09e9b8
1a5c307ed6c29f35b100e1e09002115927cb1c04
diff --git a/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs b/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs index a5f56b73d5935..23b7d433fde4f 100644 --- a/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs +++ b/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs @@ -46,17 +46,28 @@ public BiDiOptionsBuilder UseWebSocket(...
[ "dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs", "dotnet/test/webdriver/BiDi/FakeTransport.cs", "dotnet/test/webdriver/BiDi/Session/SessionTests.cs", "dotnet/test/webdriver/BiDi/SessionUnitTests.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. <b><i>usetransport</i></b> signature breaking change <code>πŸ“˜ Rule violation</code> <code>βš™ Maintainability</code>\n\n<pre>\n<b><i>BiDiOptionsBuilder.UseTransport</i></b> ...
diff --git a/dotnet/test/webdriver/BiDi/FakeTransport.cs b/dotnet/test/webdriver/BiDi/FakeTransport.cs new file mode 100644 index 0000000000000..248f2634e81e3 --- /dev/null +++ b/dotnet/test/webdriver/BiDi/FakeTransport.cs @@ -0,0 +1,126 @@ +// <copyright file="FakeTransport.cs" company="Selenium Committers"> +// Licen...
true
SeleniumHQ/selenium
17,627
comment_to_fix
[dotnet] [test] Introduce fake BiDi transport
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. <b><i>usetransport</i></b> signature breaking change <code>πŸ“˜ Rule violation</code> <code>βš™ Maintainability</code> <pre> <b><i>BiDiOptionsBuilder.UseTransport</i></b> now requires a <b><i>Func&lt;ITran...
db608302196e5a17faddd002bb0bcc7b0b09e9b8
1a5c307ed6c29f35b100e1e09002115927cb1c04
diff --git a/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs b/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs index a5f56b73d5935..23b7d433fde4f 100644 --- a/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs +++ b/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs @@ -46,17 +46,28 @@ public BiDiOptionsBuilder UseWebSocket(...
[ "dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. <b><i>usetransport</i></b> signature breaking change <code>πŸ“˜ Rule violation</code> <code>βš™ Maintainability</code>\n\n<pre>\n<b><i>BiDiOptionsBuilder.UseTransport</i></b> ...
true
SeleniumHQ/selenium
17,627
comment_to_fix
[dotnet] [test] Introduce fake BiDi transport
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 2\. Null transport factory result <code>🐞 Bug</code> <code>≑ Correctness</code> <pre> BiDiOptionsBuilder.UseTransport(Func&lt;ITransport&gt;) does not validate that the factory returns a non-null ITranspo...
db608302196e5a17faddd002bb0bcc7b0b09e9b8
1a5c307ed6c29f35b100e1e09002115927cb1c04
diff --git a/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs b/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs index a5f56b73d5935..23b7d433fde4f 100644 --- a/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs +++ b/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs @@ -46,17 +46,28 @@ public BiDiOptionsBuilder UseWebSocket(...
[ "dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n2\\. Null transport factory result <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\nBiDiOptionsBuilder.UseTransport(Func&lt;ITransport&gt;) does not validate that the f...
true
SeleniumHQ/selenium
17,625
issue_to_patch
[dotnet] [bidi] Possibility to use any external transport
2 reasons: - Anybody can provide transport implementation - Our internal testing ### πŸ’₯ What does this PR do? This pull request introduces improvements to the BiDi transport configuration in the WebDriver .NET implementation. The main changes add flexibility for specifying custom transport implementations and imp...
6104d68845eb6eedbaa304ab14aeb6178cc5662e
8513649356428591e1ce6570b0e14465731f20cc
diff --git a/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs b/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs index 96b17b516bb56..a5f56b73d5935 100644 --- a/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs +++ b/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs @@ -42,7 +42,26 @@ public sealed class BiDiOptionsBuilder ...
[ "dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs", "dotnet/src/webdriver/BiDi/ITransport.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. No transport null-check <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\nBiDiOptionsBuilder.UseTransport captures the provided transport without validating it, so ...
true
SeleniumHQ/selenium
17,625
comment_to_fix
[dotnet] [bidi] Possibility to use any external transport
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. No transport null-check <code>🐞 Bug</code> <code>≑ Correctness</code> <pre> BiDiOptionsBuilder.UseTransport captures the provided transport without validating it, so passing null makes TransportFactor...
6104d68845eb6eedbaa304ab14aeb6178cc5662e
8513649356428591e1ce6570b0e14465731f20cc
diff --git a/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs b/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs index 96b17b516bb56..a5f56b73d5935 100644 --- a/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs +++ b/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs @@ -42,7 +42,26 @@ public sealed class BiDiOptionsBuilder ...
[ "dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. No transport null-check <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\nBiDiOptionsBuilder.UseTransport captures the provided transport without validating it, so ...
true
SeleniumHQ/selenium
17,625
comment_to_fix
[dotnet] [bidi] Possibility to use any external transport
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. <b><i>usetransport</i></b> ignores cancellationtoken <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code> <pre> <b><i>BiDiOptionsBuilder.UseTransport(ITransport transport)</i></b> sets <b><i>Trans...
6104d68845eb6eedbaa304ab14aeb6178cc5662e
8513649356428591e1ce6570b0e14465731f20cc
diff --git a/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs b/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs index 96b17b516bb56..a5f56b73d5935 100644 --- a/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs +++ b/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs @@ -42,7 +42,26 @@ public sealed class BiDiOptionsBuilder ...
[ "dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. <b><i>usetransport</i></b> ignores cancellationtoken <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\n<b><i>BiDiOptionsBuilder.UseTransport(ITransport t...
true
SeleniumHQ/selenium
17,625
comment_to_fix
[dotnet] [bidi] Possibility to use any external transport
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Throwifnull tfm break <code>🐞 Bug</code> <code>≑ Correctness</code> <pre> <b><i>BiDiOptionsBuilder.UseTransport</i></b> uses <b><i>ArgumentNullException.ThrowIfNull</i></b>, which is unavailable on <b...
6104d68845eb6eedbaa304ab14aeb6178cc5662e
8513649356428591e1ce6570b0e14465731f20cc
diff --git a/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs b/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs index 96b17b516bb56..a5f56b73d5935 100644 --- a/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs +++ b/dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs @@ -42,7 +42,26 @@ public sealed class BiDiOptionsBuilder ...
[ "dotnet/src/webdriver/BiDi/BiDiOptionsBuilder.cs" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Throwifnull tfm break <code>🐞 Bug</code> <code>≑ Correctness</code>\n\n<pre>\n<b><i>BiDiOptionsBuilder.UseTransport</i></b> uses <b><i>ArgumentNullException.ThrowIfNull</...
true
SeleniumHQ/selenium
17,619
issue_to_patch
[py] Add high-level BiDi network request handler API
### πŸ”— Related Issues <!-- none --> ### πŸ’₯ What does this PR do? Adds the doc-aligned high-level request interception API to `driver.network` (Phase 1 of the BiDi Protocol API Design): - `add_request_handler(callback)` / `add_request_handler(url_patterns, callback)` with glob URL patterns (`*`, `**`, `?`) β€” translate...
9f6a51dbe9ad15466d3c59e0938f195e4387c8af
954a3d3c85c7e726a4937a1342fb08498401042d
diff --git a/py/BUILD.bazel b/py/BUILD.bazel index bcf7843873797..0cacadd618347 100644 --- a/py/BUILD.bazel +++ b/py/BUILD.bazel @@ -738,6 +738,7 @@ generate_bidi( ], extra_srcs = [ "//py/private:_event_manager.py", + "//py/private:_network_handlers.py", "//py/private:cdp.py", ],...
[ "py/BUILD.bazel", "py/private/BUILD.bazel", "py/private/_network_handlers.py", "py/private/bidi_enhancements_manifest.py", "py/test/selenium/webdriver/common/bidi_network_tests.py", "py/test/unit/selenium/webdriver/common/bidi_network_tests.py" ]
[]
diff --git a/py/test/selenium/webdriver/common/bidi_network_tests.py b/py/test/selenium/webdriver/common/bidi_network_tests.py index bdb06a5bd0544..b909d0be48c1e 100644 --- a/py/test/selenium/webdriver/common/bidi_network_tests.py +++ b/py/test/selenium/webdriver/common/bidi_network_tests.py @@ -155,3 +155,135 @@ def c...
true
SeleniumHQ/selenium
17,620
issue_to_patch
[build] only free disk space when needed
### πŸ”— Related Issues Based on the metrics gathered this past week from #17569 - None of the Windows or Mac runners are close to having space issues - ~95% of Linux jobs run on 145 GB runners where space is also not a concern - The issue is the ~5% of Linux jobs that get a 72 GB runner and leaves us with ~16 GB o...
9f6a51dbe9ad15466d3c59e0938f195e4387c8af
132fc491543c8c26a199413b388fce1d5774d9c5
diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index a17886395b6f6..f50ca177a8f5d 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -134,13 +134,6 @@ jobs: run: git pull origin "$GIT_REF" env: GIT_REF: ${{ github.ref }} - - name: Free...
[ ".github/workflows/bazel.yml", "scripts/github-actions/delete-browsers-drivers.ps1", "scripts/github-actions/delete-browsers-drivers.sh", "scripts/github-actions/disk-status.sh", "scripts/github-actions/free-disk-space.ps1", "scripts/github-actions/free-disk-space.sh" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. <b><i>free-disk-space.sh</i></b> hides failures <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\nThe Linux disk cleanup script does not use strict shell...
true
SeleniumHQ/selenium
17,620
comment_to_fix
[build] only free disk space when needed
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. <b><i>free-disk-space.sh</i></b> hides failures <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code> <pre> The Linux disk cleanup script does not use strict shell mode and does not check <b><i>sud...
9f6a51dbe9ad15466d3c59e0938f195e4387c8af
132fc491543c8c26a199413b388fce1d5774d9c5
diff --git a/scripts/github-actions/free-disk-space.sh b/scripts/github-actions/free-disk-space.sh index 1111243e6a1b0..92d4a5c74cfdb 100755 --- a/scripts/github-actions/free-disk-space.sh +++ b/scripts/github-actions/free-disk-space.sh @@ -1,66 +1,26 @@ #!/usr/bin/env bash +# +# Reclaim disk on Linux runners by delet...
[ "scripts/github-actions/free-disk-space.sh" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. <b><i>free-disk-space.sh</i></b> hides failures <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\nThe Linux disk cleanup script does not use strict shell...
true
SeleniumHQ/selenium
17,620
comment_to_fix
[build] only free disk space when needed
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 2\. <b><i>delete-browsers-drivers.sh</i></b> ignores errors <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code> <pre> The browser/driver deletion script does not validate inputs or command results, a...
9f6a51dbe9ad15466d3c59e0938f195e4387c8af
132fc491543c8c26a199413b388fce1d5774d9c5
diff --git a/scripts/github-actions/delete-browsers-drivers.sh b/scripts/github-actions/delete-browsers-drivers.sh new file mode 100755 index 0000000000000..8fa86737ef65f --- /dev/null +++ b/scripts/github-actions/delete-browsers-drivers.sh @@ -0,0 +1,22 @@ +#!/usr/bin/env bash +# +# Delete pre-installed browsers and W...
[ "scripts/github-actions/delete-browsers-drivers.sh" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n2\\. <b><i>delete-browsers-drivers.sh</i></b> ignores errors <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\nThe browser/driver deletion script does not val...
true
SeleniumHQ/selenium
17,620
comment_to_fix
[build] only free disk space when needed
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 3\. <b><i>delete-browsers-drivers.ps1</i></b> suppresses errors <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code> <pre> The Windows cleanup script suppresses all deletion errors via <b><i>-ErrorAct...
9f6a51dbe9ad15466d3c59e0938f195e4387c8af
132fc491543c8c26a199413b388fce1d5774d9c5
diff --git a/scripts/github-actions/delete-browsers-drivers.ps1 b/scripts/github-actions/delete-browsers-drivers.ps1 new file mode 100755 index 0000000000000..965bcd0a82cee --- /dev/null +++ b/scripts/github-actions/delete-browsers-drivers.ps1 @@ -0,0 +1,17 @@ +#!/usr/bin/env pwsh +# +# Delete pre-installed browsers an...
[ "scripts/github-actions/delete-browsers-drivers.ps1" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n3\\. <b><i>delete-browsers-drivers.ps1</i></b> suppresses errors <code>πŸ“˜ Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\nThe Windows cleanup script suppresses all d...
true
SeleniumHQ/selenium
17,621
issue_to_patch
[build] convert bazel.yml browser input to needs-display boolean
The assumption of one-browser-per-job isn't necessary now that we're doing everything with bazel, and it can result in some confusing behavior 16 jobs run bazel.yml and need a browser, 20 do not. Currently `inputs.browser` is used to: 1. Setup Fluxbox and xvfb in Ubuntu 2. Set resolution in Windows 3. Install ...
9f6a51dbe9ad15466d3c59e0938f195e4387c8af
3a34a0447183dd502a9651d135953823d7ad96cb
diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index a17886395b6f6..f9c83efb50672 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -21,11 +21,11 @@ on: required: false type: string default: ubuntu - browser: - description: One o...
[ ".github/workflows/bazel.yml", ".github/workflows/ci-dotnet.yml", ".github/workflows/ci-java.yml", ".github/workflows/ci-python.yml", ".github/workflows/ci-ruby.yml" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Removed <b><i>browser</i></b> workflow input <code>πŸ“˜ Rule violation</code> <code>βš™ Maintainability</code>\n\n<pre>\nThe reusable workflow <b><i>.github/workflows/bazel.ym...
true
SeleniumHQ/selenium
17,621
comment_to_fix
[build] convert bazel.yml browser input to needs-display boolean
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Removed <b><i>browser</i></b> workflow input <code>πŸ“˜ Rule violation</code> <code>βš™ Maintainability</code> <pre> The reusable workflow <b><i>.github/workflows/bazel.yml</i></b> removes/renames the <b><...
9f6a51dbe9ad15466d3c59e0938f195e4387c8af
3a34a0447183dd502a9651d135953823d7ad96cb
diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index a17886395b6f6..f9c83efb50672 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -21,11 +21,11 @@ on: required: false type: string default: ubuntu - browser: - description: One o...
[ ".github/workflows/bazel.yml" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Removed <b><i>browser</i></b> workflow input <code>πŸ“˜ Rule violation</code> <code>βš™ Maintainability</code>\n\n<pre>\nThe reusable workflow <b><i>.github/workflows/bazel.ym...
true
SeleniumHQ/selenium
17,617
issue_to_patch
trim agent formatting guidance
### πŸ”— Related Issues Pares back #17366 Every time my agent edits anything it runs a several minute format command completely unnecessarily (since I use a pre-push hook). I added to my `.local/AGENTS.md` file not to do that, but it wasn't listening to me, which makes sense when I see that the demand to do this is r...
702c97b349aec20783f304bdfbd40c72ef4fa5c2
c82c3fae967a8ce0762df7447435306f6082ffca
diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index 8eb926d6f5348..fe6a5c9218be4 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -1,2 +1,1 @@ -Always read AGENTS.md before answering. -After any code change, run or suggest running `./go format` to pr...
[ ".github/copilot-instructions.md", "AGENTS.md", "CLAUDE.local.md", "CLAUDE.md", "dotnet/AGENTS.md", "java/AGENTS.md", "javascript/selenium-webdriver/AGENTS.md", "py/AGENTS.md", "rb/AGENTS.md", "rust/AGENTS.md" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Format guidance mismatches ci <code>🐞 Bug</code> <code>βš™ Maintainability</code>\n\n<pre>\nAGENTS.md now claims running <b><i>./scripts/format.sh</i></b> before pushing av...
true
SeleniumHQ/selenium
17,617
comment_to_fix
trim agent formatting guidance
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Format guidance mismatches ci <code>🐞 Bug</code> <code>βš™ Maintainability</code> <pre> AGENTS.md now claims running <b><i>./scripts/format.sh</i></b> before pushing avoids CI formatter failures, but th...
702c97b349aec20783f304bdfbd40c72ef4fa5c2
c82c3fae967a8ce0762df7447435306f6082ffca
diff --git a/AGENTS.md b/AGENTS.md index 1a20a1d2b91c1..bd03391c95b72 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -66,27 +66,15 @@ See language-specific AGENTS.md for applicable logging usage This project does not follow semantic versioning (semver); before removing public functionality, mark it as deprecated with a mes...
[ "AGENTS.md" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Format guidance mismatches ci <code>🐞 Bug</code> <code>βš™ Maintainability</code>\n\n<pre>\nAGENTS.md now claims running <b><i>./scripts/format.sh</i></b> before pushing av...
true
SeleniumHQ/selenium
17,611
issue_to_patch
[py] Extract alert and color into dedicated libraries
## Summary Continues the Python Bazel target granularity work (P2c + P2f): - **P2c β€” `alert.py`**: Extracted into `//py:common_alert`. Lazy-imported `Alert` in `switch_to.py` (method body) and moved it to `TYPE_CHECKING` in `expected_conditions.py` so neither `//py:remote` nor `//py:support` carries the compile-time ...
a212f13dc84636f51b3a23fba0cdfd105df3b305
c63f117a12e481edd978b8f2d2686e3ae2b91818
diff --git a/py/BUILD.bazel b/py/BUILD.bazel index 190c359c69cf0..bcf7843873797 100644 --- a/py/BUILD.bazel +++ b/py/BUILD.bazel @@ -296,6 +296,7 @@ py_library( exclude = [ "selenium/webdriver/common/action_chains.py", "selenium/webdriver/common/actions/**", + "selenium/web...
[ "py/BUILD.bazel", "py/selenium/webdriver/remote/switch_to.py", "py/selenium/webdriver/support/expected_conditions.py" ]
[]
true
SeleniumHQ/selenium
17,618
issue_to_patch
Update geckodriver releases map including 0.37.0
<!-- Thanks for Contributing to Selenium! --> <!-- Please read our contribution guidelines: https://github.com/SeleniumHQ/selenium/blob/trunk/CONTRIBUTING.md --> ### πŸ”— Related Issues <!-- Example: Fixes #1234 or Closes #5678 --> <!-- If the reason for this PR is not obvious, consider creating an issue for it fir...
e64a80827ee4db3fc42f8b5422b98b5c5274b001
bbc3f37630af5a3f9059c1f86a0a0ce896c10d20
diff --git a/common/geckodriver/geckodriver-support.json b/common/geckodriver/geckodriver-support.json index 064a29ef8fa68..b6266f12b191f 100644 --- a/common/geckodriver/geckodriver-support.json +++ b/common/geckodriver/geckodriver-support.json @@ -1,8 +1,12 @@ { "geckodriver-releases": [ + { + "geckodriver...
[ "common/geckodriver/geckodriver-support.json" ]
[]
true
SeleniumHQ/selenium
17,615
issue_to_patch
[py] retry safaridriver startup in tests
### πŸ”— Related Issues #16768 (rb) and #17560 (py) When Safari 26.5 was released ~May 20, the Python Safari job started consistently failing across multiple runs. When I ran the Ruby Safari tests, they were also failing, so I guarded everything. Except things seem to be passing now, so I'm not sure what was going on pr...
1a85379d28668990d980f996490d1f581f656ab1
1b2d4c951c1a2ee23069f57e09236eb38fb0d070
diff --git a/py/conftest.py b/py/conftest.py index c1f53000e644e..198fc6d9ada48 100644 --- a/py/conftest.py +++ b/py/conftest.py @@ -17,10 +17,12 @@ import http.server import json +import logging import os import socketserver import sys import threading +import time import types from dataclasses import datacl...
[ "py/conftest.py", "py/test/selenium/webdriver/common/alerts_tests.py", "py/test/selenium/webdriver/common/click_scrolling_tests.py", "py/test/selenium/webdriver/common/click_tests.py", "py/test/selenium/webdriver/common/correct_event_firing_tests.py", "py/test/selenium/webdriver/common/element_attribute_t...
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Retry catches too narrowly <code>🐞 Bug</code> <code>☼ Reliability</code>\n\n<pre>\nDriver._start_local_driver retries only on WebDriverException, so any other exception t...
diff --git a/py/test/selenium/webdriver/common/alerts_tests.py b/py/test/selenium/webdriver/common/alerts_tests.py index ed96658621aae..c3ef08fa082c5 100644 --- a/py/test/selenium/webdriver/common/alerts_tests.py +++ b/py/test/selenium/webdriver/common/alerts_tests.py @@ -38,7 +38,6 @@ def close_alert(driver): ...
true
SeleniumHQ/selenium
17,615
comment_to_fix
[py] retry safaridriver startup in tests
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Retry catches too narrowly <code>🐞 Bug</code> <code>☼ Reliability</code> <pre> Driver._start_local_driver retries only on WebDriverException, so any other exception type raised during session creation...
1a85379d28668990d980f996490d1f581f656ab1
1b2d4c951c1a2ee23069f57e09236eb38fb0d070
diff --git a/py/conftest.py b/py/conftest.py index c1f53000e644e..198fc6d9ada48 100644 --- a/py/conftest.py +++ b/py/conftest.py @@ -17,10 +17,12 @@ import http.server import json +import logging import os import socketserver import sys import threading +import time import types from dataclasses import datacl...
[ "py/conftest.py" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Retry catches too narrowly <code>🐞 Bug</code> <code>☼ Reliability</code>\n\n<pre>\nDriver._start_local_driver retries only on WebDriverException, so any other exception t...
true
SeleniumHQ/selenium
17,616
issue_to_patch
[rb] Run unit tests as a single Bazel target instead of per-file
Ruby unit tests take a long time under Bazel, especially on Windows. Measured impact on the unit-test jobs on GitHub runner: | Job | Trunk (73 targets) | PR (1 target) | Ξ” | |---------------------| ------------------ |---------------|-------| | 3.3.11, windows | 13m 34s | 7m 10s ...
1a85379d28668990d980f996490d1f581f656ab1
124899559c75735d444af18e882dfd73bde91b1b
diff --git a/README.md b/README.md index 13c1277163902..426f99c889186 100644 --- a/README.md +++ b/README.md @@ -448,13 +448,14 @@ Test targets: | `bazel test //rb/spec/integration/... --test_tag_filters firefox-remote` | Run integration tests for remote Firefox only | | `bazel test //rb...
[ "README.md", "rb/spec/BUILD.bazel", "rb/spec/tests.bzl", "rb/spec/unit/BUILD.bazel", "rb/spec/unit/selenium/BUILD.bazel", "rb/spec/unit/selenium/devtools/BUILD.bazel", "rb/spec/unit/selenium/webdriver/BUILD.bazel", "rb/spec/unit/selenium/webdriver/bidi/BUILD.bazel", "rb/spec/unit/selenium/webdriver/...
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Edits under <b><i>third_party/firebug</i></b> <code>πŸ“˜ Rule violation</code> <code>βš™ Maintainability</code>\n\n<pre>\nThis PR modifies <b><i>third_party/firebug/BUILD.baze...
diff --git a/rb/spec/BUILD.bazel b/rb/spec/BUILD.bazel index 7d117d86c1180..767e410f54425 100644 --- a/rb/spec/BUILD.bazel +++ b/rb/spec/BUILD.bazel @@ -48,67 +48,8 @@ rb_library( "//rb/spec/integration/selenium/webdriver/remote:driver", "//rb/spec/integration/selenium/webdriver/remote:element", ...
true
SeleniumHQ/selenium
17,616
comment_to_fix
[rb] Run unit tests as a single Bazel target instead of per-file
<img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required"> 1\. Edits under <b><i>third_party/firebug</i></b> <code>πŸ“˜ Rule violation</code> <code>βš™ Maintainability</code> <pre> This PR modifies <b><i>third_party/firebug/BUILD.bazel</i></b> by changing <b><i>export...
1a85379d28668990d980f996490d1f581f656ab1
124899559c75735d444af18e882dfd73bde91b1b
diff --git a/third_party/firebug/BUILD.bazel b/third_party/firebug/BUILD.bazel index 89139af6577d7..8f08322109d98 100644 --- a/third_party/firebug/BUILD.bazel +++ b/third_party/firebug/BUILD.bazel @@ -9,6 +9,6 @@ exports_files( visibility = [ "//java/test/org/openqa/selenium/firefox:__pkg__", "//...
[ "third_party/firebug/BUILD.bazel" ]
[ { "comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Edits under <b><i>third_party/firebug</i></b> <code>πŸ“˜ Rule violation</code> <code>βš™ Maintainability</code>\n\n<pre>\nThis PR modifies <b><i>third_party/firebug/BUILD.baze...
true
SeleniumHQ/selenium
17,612
issue_to_patch
[build] Combine Rust build and test CI jobs
### πŸ’₯ What does this PR do? Combines the separate `build` job into the `tests` job in the Rust CI workflow (`.github/workflows/ci-rust.yml`). Previously there was a standalone `build` job running `bazel build //rust:selenium-manager`, with the `tests` matrix gated on it via `needs: build`. Since `bazel test //rust/....
aba540ca181d1c5c6daef841663837392b54ab99
a98e0ea143cb2d9ce772bb338e75a8109d1fe7b5
diff --git a/.github/workflows/ci-rust.yml b/.github/workflows/ci-rust.yml index f3aad33d1cea3..53067abe9bfb4 100644 --- a/.github/workflows/ci-rust.yml +++ b/.github/workflows/ci-rust.yml @@ -20,16 +20,8 @@ permissions: contents: read jobs: - build: - name: Build - uses: ./.github/workflows/bazel.yml - ...
[ ".github/workflows/ci-rust.yml" ]
[]
true