repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
Sylius/Sylius | 19,023 | issue_to_patch | [CS][DX] Refactor | This PR has been generated automatically.
For more details see [refactor.yaml](/Sylius/Sylius/blob/2.1/.github/workflows/refactor.yaml). | dd5184bd9186e2b834b2217b042f7c4b1f93cbf7 | 97ea3445afa8b9ca98642c3c72f16c7590d97bd2 | diff --git a/src/Sylius/Behat/Client/ResponseCheckerInterface.php b/src/Sylius/Behat/Client/ResponseCheckerInterface.php
index 0d06005fc47..404d6abc8bb 100644
--- a/src/Sylius/Behat/Client/ResponseCheckerInterface.php
+++ b/src/Sylius/Behat/Client/ResponseCheckerInterface.php
@@ -93,7 +93,7 @@ public function getRespon... | [
"src/Sylius/Behat/Client/ResponseCheckerInterface.php",
"src/Sylius/Bundle/ApiBundle/StateProvider/Shop/Payment/PaymentRequest/ItemProvider.php",
"src/Sylius/Bundle/ShopBundle/Twig/Component/Cart/FormComponent.php"
] | [] | true | ||
Sylius/Sylius | 19,047 | issue_to_patch | [Fix] Product Summary using wrong variant resolver | | Q | A
|-----------------|-----
| Branch? | 2.2
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
I encountered an issue where I'm using my own specific `sylius.resolver.product_variant`, I discover... | 80cfea8f52f8f94ef742ac397bbb3ff54496dc33 | 6a7c5cf6e37f1564dbde9eae1d19e1a8995bd24b | diff --git a/src/Sylius/Bundle/ShopBundle/Resources/config/services/twig/component/product.xml b/src/Sylius/Bundle/ShopBundle/Resources/config/services/twig/component/product.xml
index c045ade9fe9..be190ecef70 100644
--- a/src/Sylius/Bundle/ShopBundle/Resources/config/services/twig/component/product.xml
+++ b/src/Syliu... | [
"src/Sylius/Bundle/ShopBundle/Resources/config/services/twig/component/product.xml"
] | [] | true | ||
Sylius/Sylius | 19,032 | issue_to_patch | [DX] Catalog price display | | Q | A
|-----------------|-----
| Branch? | 2.3
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | yes
| Related tickets | mentioned in #18142
| License | MIT
## Summary
This PR implements **Alternative A** proposed in #18142 — a dedica... | bc95be8333a5d25dcd1ec09b5db10977ecf8b3cb | 85a9294c3fb9cddf9848cf3199d9fd73e716ad3e | diff --git a/UPGRADE-2.3.md b/UPGRADE-2.3.md
index f69dae7ebc2..ca208830509 100644
--- a/UPGRADE-2.3.md
+++ b/UPGRADE-2.3.md
@@ -55,8 +55,38 @@
The `StringInflector::nameToSlug()` method has been **deprecated** and will be removed in Sylius 3.0.
2. The `knplabs/gaufrette` and `knplabs/knp-gaufrette-bundle` packa... | [
"UPGRADE-2.3.md",
"src/Sylius/Bundle/ApiBundle/Resources/config/services/serializers.php",
"src/Sylius/Bundle/ApiBundle/Serializer/Normalizer/ProductVariantNormalizer.php",
"src/Sylius/Bundle/ApiBundle/tests/Serializer/Normalizer/ProductVariantNormalizerTest.php",
"src/Sylius/Bundle/CoreBundle/Resources/con... | [
{
"comment": "```suggestion\r\n private readonly ProductVariantPricesCalculatorInterface|CatalogPricesCalculatorInterface $priceCalculator,\r\n```\r\nLets allow both, with deprecation that it will be required to use CatalogPricesCalculatorInterface since 3.0?",
"path": "src/Sylius/Bundle/ApiBundle/Se... | diff --git a/src/Sylius/Bundle/ApiBundle/tests/Serializer/Normalizer/ProductVariantNormalizerTest.php b/src/Sylius/Bundle/ApiBundle/tests/Serializer/Normalizer/ProductVariantNormalizerTest.php
index adeafbdb190..5e3c1220617 100644
--- a/src/Sylius/Bundle/ApiBundle/tests/Serializer/Normalizer/ProductVariantNormalizerTes... | true | |
Sylius/Sylius | 19,032 | comment_to_fix | [DX] Catalog price display | ```suggestion
private readonly ProductVariantPricesCalculatorInterface|CatalogPricesCalculatorInterface $priceCalculator,
```
Lets allow both, with deprecation that it will be required to use CatalogPricesCalculatorInterface since 3.0? | bc95be8333a5d25dcd1ec09b5db10977ecf8b3cb | 85a9294c3fb9cddf9848cf3199d9fd73e716ad3e | diff --git a/src/Sylius/Bundle/ApiBundle/Serializer/Normalizer/ProductVariantNormalizer.php b/src/Sylius/Bundle/ApiBundle/Serializer/Normalizer/ProductVariantNormalizer.php
index eaf09e7c3d0..5780697765f 100644
--- a/src/Sylius/Bundle/ApiBundle/Serializer/Normalizer/ProductVariantNormalizer.php
+++ b/src/Sylius/Bundle/... | [
"src/Sylius/Bundle/ApiBundle/Serializer/Normalizer/ProductVariantNormalizer.php"
] | [
{
"comment": "```suggestion\r\n private readonly ProductVariantPricesCalculatorInterface|CatalogPricesCalculatorInterface $priceCalculator,\r\n```\r\nLets allow both, with deprecation that it will be required to use CatalogPricesCalculatorInterface since 3.0?",
"path": "src/Sylius/Bundle/ApiBundle/Se... | true | ||
Sylius/Sylius | 19,032 | comment_to_fix | [DX] Catalog price display | same here | bc95be8333a5d25dcd1ec09b5db10977ecf8b3cb | 85a9294c3fb9cddf9848cf3199d9fd73e716ad3e | diff --git a/src/Sylius/Bundle/CoreBundle/Twig/PriceExtension.php b/src/Sylius/Bundle/CoreBundle/Twig/PriceExtension.php
index edf21b376a6..4eeafe3530d 100644
--- a/src/Sylius/Bundle/CoreBundle/Twig/PriceExtension.php
+++ b/src/Sylius/Bundle/CoreBundle/Twig/PriceExtension.php
@@ -13,6 +13,7 @@
namespace Sylius\Bundl... | [
"src/Sylius/Bundle/CoreBundle/Twig/PriceExtension.php"
] | [
{
"comment": "same here",
"path": "src/Sylius/Bundle/CoreBundle/Twig/PriceExtension.php",
"hunk": "@@ -13,16 +13,17 @@\n \n namespace Sylius\\Bundle\\CoreBundle\\Twig;\n \n-use Sylius\\Component\\Core\\Calculator\\ProductVariantPricesCalculatorInterface;\n+use Sylius\\Component\\Core\\Calculator\\Catalo... | true | ||
Sylius/Sylius | 19,032 | comment_to_fix | [DX] Catalog price display | same here | bc95be8333a5d25dcd1ec09b5db10977ecf8b3cb | 85a9294c3fb9cddf9848cf3199d9fd73e716ad3e | diff --git a/src/Sylius/Bundle/ShopBundle/Twig/Component/Product/CardComponent.php b/src/Sylius/Bundle/ShopBundle/Twig/Component/Product/CardComponent.php
index 0d03b281492..de3728d7993 100644
--- a/src/Sylius/Bundle/ShopBundle/Twig/Component/Product/CardComponent.php
+++ b/src/Sylius/Bundle/ShopBundle/Twig/Component/P... | [
"src/Sylius/Bundle/ShopBundle/Twig/Component/Product/CardComponent.php"
] | [
{
"comment": "same here",
"path": "src/Sylius/Bundle/ShopBundle/Twig/Component/Product/CardComponent.php",
"hunk": "@@ -48,7 +48,7 @@ public function __construct(\n protected readonly ProductVariantResolverInterface $productVariantResolver,\n protected readonly ChannelContextInterface $c... | true | ||
Sylius/Sylius | 19,032 | comment_to_fix | [DX] Catalog price display | same here | bc95be8333a5d25dcd1ec09b5db10977ecf8b3cb | 85a9294c3fb9cddf9848cf3199d9fd73e716ad3e | diff --git a/src/Sylius/Bundle/ShopBundle/Twig/Component/Product/PriceComponent.php b/src/Sylius/Bundle/ShopBundle/Twig/Component/Product/PriceComponent.php
index 6c66da4231d..f4227f05235 100644
--- a/src/Sylius/Bundle/ShopBundle/Twig/Component/Product/PriceComponent.php
+++ b/src/Sylius/Bundle/ShopBundle/Twig/Componen... | [
"src/Sylius/Bundle/ShopBundle/Twig/Component/Product/PriceComponent.php"
] | [
{
"comment": "same here",
"path": "src/Sylius/Bundle/ShopBundle/Twig/Component/Product/PriceComponent.php",
"hunk": "@@ -43,7 +43,7 @@ class PriceComponent\n public bool $hasDiscount = false;\n \n public function __construct(\n- protected readonly ProductVariantPricesCalculatorInterface $... | true | ||
Sylius/Sylius | 19,032 | comment_to_fix | [DX] Catalog price display | same here | bc95be8333a5d25dcd1ec09b5db10977ecf8b3cb | 85a9294c3fb9cddf9848cf3199d9fd73e716ad3e | diff --git a/src/Sylius/Component/Core/Provider/ProductVariantMap/ProductVariantOriginalPriceMapProvider.php b/src/Sylius/Component/Core/Provider/ProductVariantMap/ProductVariantOriginalPriceMapProvider.php
index 196ff0c3886..2e658af3a32 100644
--- a/src/Sylius/Component/Core/Provider/ProductVariantMap/ProductVariantOr... | [
"src/Sylius/Component/Core/Provider/ProductVariantMap/ProductVariantOriginalPriceMapProvider.php"
] | [
{
"comment": "same here",
"path": "src/Sylius/Component/Core/Provider/ProductVariantMap/ProductVariantOriginalPriceMapProvider.php",
"hunk": "@@ -13,14 +13,15 @@\n \n namespace Sylius\\Component\\Core\\Provider\\ProductVariantMap;\n \n-use Sylius\\Component\\Core\\Calculator\\ProductVariantPricesCalcula... | true | ||
Sylius/Sylius | 19,032 | comment_to_fix | [DX] Catalog price display | same here | bc95be8333a5d25dcd1ec09b5db10977ecf8b3cb | 85a9294c3fb9cddf9848cf3199d9fd73e716ad3e | diff --git a/src/Sylius/Component/Core/Provider/ProductVariantMap/ProductVariantPriceMapProvider.php b/src/Sylius/Component/Core/Provider/ProductVariantMap/ProductVariantPriceMapProvider.php
index 6f289b5e519..95e30588f16 100644
--- a/src/Sylius/Component/Core/Provider/ProductVariantMap/ProductVariantPriceMapProvider.p... | [
"src/Sylius/Component/Core/Provider/ProductVariantMap/ProductVariantPriceMapProvider.php"
] | [
{
"comment": "same here",
"path": "src/Sylius/Component/Core/Provider/ProductVariantMap/ProductVariantPriceMapProvider.php",
"hunk": "@@ -13,14 +13,15 @@\n \n namespace Sylius\\Component\\Core\\Provider\\ProductVariantMap;\n \n-use Sylius\\Component\\Core\\Calculator\\ProductVariantPricesCalculatorInter... | true | ||
Sylius/Sylius | 19,032 | comment_to_fix | [DX] Catalog price display | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Deprecation message references a non-existent argument name.**
The message says `$priceCalculator`, but this constructor's parameter is `$productVariantPricesCalculator`. Developers reading the deprecation won't be able to map it to the actual argument. (The normali... | bc95be8333a5d25dcd1ec09b5db10977ecf8b3cb | 85a9294c3fb9cddf9848cf3199d9fd73e716ad3e | diff --git a/src/Sylius/Bundle/CoreBundle/Twig/PriceExtension.php b/src/Sylius/Bundle/CoreBundle/Twig/PriceExtension.php
index edf21b376a6..4eeafe3530d 100644
--- a/src/Sylius/Bundle/CoreBundle/Twig/PriceExtension.php
+++ b/src/Sylius/Bundle/CoreBundle/Twig/PriceExtension.php
@@ -13,6 +13,7 @@
namespace Sylius\Bundl... | [
"src/Sylius/Bundle/CoreBundle/Twig/PriceExtension.php"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Deprecation message references a non-existent argument name.**\n\nThe message says `$priceCalculator`, but this constructor's parameter is `$productVariantPricesCalculator`. Developers reading the deprecation won't be able to map it to the act... | true | ||
Sylius/Sylius | 19,032 | comment_to_fix | [DX] Catalog price display | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Deprecation message references the wrong parameter name.**
The message names `$priceCalculator`, but the constructor parameter is `$calculator`. Align it for clarity.
<details>
<summary>🔧 Proposed fix</summary>
```diff
- 'Passing an instance of "%s... | bc95be8333a5d25dcd1ec09b5db10977ecf8b3cb | 85a9294c3fb9cddf9848cf3199d9fd73e716ad3e | diff --git a/src/Sylius/Component/Core/Provider/ProductVariantMap/ProductVariantLowestPriceMapProvider.php b/src/Sylius/Component/Core/Provider/ProductVariantMap/ProductVariantLowestPriceMapProvider.php
index 114bdd85ed5..44c11e226d1 100644
--- a/src/Sylius/Component/Core/Provider/ProductVariantMap/ProductVariantLowest... | [
"src/Sylius/Component/Core/Provider/ProductVariantMap/ProductVariantLowestPriceMapProvider.php"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Deprecation message references the wrong parameter name.**\n\nThe message names `$priceCalculator`, but the constructor parameter is `$calculator`. Align it for clarity.\n\n<details>\n<summary>🔧 Proposed fix</summary>\n\n```diff\n- ... | true | ||
Sylius/Sylius | 19,032 | comment_to_fix | [DX] Catalog price display | lets add it at the end as now its in the middle of another section 😄 | bc95be8333a5d25dcd1ec09b5db10977ecf8b3cb | 85a9294c3fb9cddf9848cf3199d9fd73e716ad3e | diff --git a/UPGRADE-2.3.md b/UPGRADE-2.3.md
index f69dae7ebc2..ca208830509 100644
--- a/UPGRADE-2.3.md
+++ b/UPGRADE-2.3.md
@@ -55,8 +55,38 @@
The `StringInflector::nameToSlug()` method has been **deprecated** and will be removed in Sylius 3.0.
2. The `knplabs/gaufrette` and `knplabs/knp-gaufrette-bundle` packa... | [
"UPGRADE-2.3.md"
] | [
{
"comment": "lets add it at the end as now its in the middle of another section 😄 ",
"path": "UPGRADE-2.3.md",
"hunk": "",
"resolving_sha": "85a9294c3fb9cddf9848cf3199d9fd73e716ad3e",
"resolving_diff": "diff --git a/UPGRADE-2.3.md b/UPGRADE-2.3.md\nindex f69dae7ebc2..ca208830509 100644\n--- a/... | true | ||
Sylius/Sylius | 19,004 | issue_to_patch | feat(fixtures): Allow translations on product attributes & values | | Q | A
|-----------------|-----
| Branch? | 2.3
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
<!--
- Bug fixes must be submitted against the 1.14 or 2.1 branch
- Features and deprecations mu... | 297e5a06ba9ee2348cd30eb7dc11b2fa13e503f8 | 922ed066c14893e4664c10efcadac8fba1e2bb00 | diff --git a/src/Sylius/Bundle/CoreBundle/Fixture/Factory/ProductAttributeExampleFactory.php b/src/Sylius/Bundle/CoreBundle/Fixture/Factory/ProductAttributeExampleFactory.php
index 6187cd13948..858871c99e3 100644
--- a/src/Sylius/Bundle/CoreBundle/Fixture/Factory/ProductAttributeExampleFactory.php
+++ b/src/Sylius/Bund... | [
"src/Sylius/Bundle/CoreBundle/Fixture/Factory/ProductAttributeExampleFactory.php",
"src/Sylius/Bundle/CoreBundle/Fixture/Factory/ProductOptionExampleFactory.php",
"src/Sylius/Bundle/CoreBundle/Fixture/ProductAttributeFixture.php",
"src/Sylius/Bundle/CoreBundle/Fixture/ProductOptionFixture.php",
"src/Sylius/... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Preserve existing name when translation is missing.**\n\nLine 68 passes `null` when `$translation['name']` is absent, which can unset the attribute name for that locale. Since line 62 already set a base name for all locales, you should preserv... | diff --git a/tests/Fixture/ProductAttributeFixturesTest.php b/tests/Fixture/ProductAttributeFixturesTest.php
index 2b5d592d305..9012466ebd1 100644
--- a/tests/Fixture/ProductAttributeFixturesTest.php
+++ b/tests/Fixture/ProductAttributeFixturesTest.php
@@ -19,6 +19,7 @@
use Sylius\Bundle\FixturesBundle\Loader\SuiteLoa... | true | |
Sylius/Sylius | 19,004 | comment_to_fix | feat(fixtures): Allow translations on product attributes & values | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Preserve existing name when translation is missing.**
Line 68 passes `null` when `$translation['name']` is absent, which can unset the attribute name for that locale. Since line 62 already set a base name for all locales, you should preserve it when a translation do... | 297e5a06ba9ee2348cd30eb7dc11b2fa13e503f8 | 922ed066c14893e4664c10efcadac8fba1e2bb00 | diff --git a/src/Sylius/Bundle/CoreBundle/Fixture/Factory/ProductAttributeExampleFactory.php b/src/Sylius/Bundle/CoreBundle/Fixture/Factory/ProductAttributeExampleFactory.php
index 6187cd13948..858871c99e3 100644
--- a/src/Sylius/Bundle/CoreBundle/Fixture/Factory/ProductAttributeExampleFactory.php
+++ b/src/Sylius/Bund... | [
"src/Sylius/Bundle/CoreBundle/Fixture/Factory/ProductAttributeExampleFactory.php"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Preserve existing name when translation is missing.**\n\nLine 68 passes `null` when `$translation['name']` is absent, which can unset the attribute name for that locale. Since line 62 already set a base name for all locales, you should preserv... | true | ||
Sylius/Sylius | 19,004 | comment_to_fix | feat(fixtures): Allow translations on product attributes & values | lets add it to translatable one 😄 | 297e5a06ba9ee2348cd30eb7dc11b2fa13e503f8 | 922ed066c14893e4664c10efcadac8fba1e2bb00 | diff --git a/src/Sylius/Bundle/CoreBundle/Resources/config/app/fixtures/dress.yaml b/src/Sylius/Bundle/CoreBundle/Resources/config/app/fixtures/dress.yaml
index 9967e1aeb43..06ea7395c9a 100644
--- a/src/Sylius/Bundle/CoreBundle/Resources/config/app/fixtures/dress.yaml
+++ b/src/Sylius/Bundle/CoreBundle/Resources/config... | [
"src/Sylius/Bundle/CoreBundle/Resources/config/app/fixtures/dress.yaml"
] | [
{
"comment": "lets add it to translatable one 😄 ",
"path": "src/Sylius/Bundle/CoreBundle/Resources/config/app/fixtures/dress.yaml",
"hunk": "@@ -45,6 +45,11 @@ sylius_fixtures:\n code: 'length'\n type: 'integer'\n ... | true | ||
Sylius/Sylius | 18,955 | issue_to_patch | [UPMERGE] 2.2 -> 2.3 | This PR has been generated automatically.
For more details see [upmerge_pr.yaml](/Sylius/Sylius/blob/2.3/.github/workflows/upmerge_pr.yaml).
**Remember!** The upmerge should always be merged with using `Merge pull request` button.
In case of conflicts, please resolve them manually with usign the following commands:
`... | 5bac4c62cb6c5fa9a4c6a826af3a39e3e5cc799f | 280b4e55249154e8398a48b5ec8c70e476a1caa0 | diff --git a/CHANGELOG-2.1.md b/CHANGELOG-2.1.md
index e9799625efe..279b9d62b2a 100644
--- a/CHANGELOG-2.1.md
+++ b/CHANGELOG-2.1.md
@@ -1,5 +1,42 @@
# CHANGELOG FOR `2.1.X`
+## v2.1.15 (2026-06-02)
+
+#### Details
+
+- [#19038](https://github.com/Sylius/Sylius/pull/19038) [2.1] Prevent stale cart LiveComponents fro... | [
"CHANGELOG-2.1.md",
"CHANGELOG-2.2.md",
"UPGRADE-2.1.md",
"UPGRADE-2.2.md",
"UPGRADE-API-2.1.md",
"UPGRADE-API-2.2.md",
"composer.json",
"config/routes.yaml",
"features/shop/cart/shopping_cart/stale_live_component_prevents_completed_order_mutation.feature",
"features/shop/checkout/paying_for_order... | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Missing null check for payment method, inconsistent with CoreBundle validator.**\n\nThe CoreBundle validator (lines 43-48) explicitly handles the case where `$payment->getMethod()` returns `null` by continuing to the next payment. This ApiBundle validator ass... | diff --git a/src/Sylius/Bundle/ApiBundle/tests/Changer/PaymentMethodChangerTest.php b/src/Sylius/Bundle/ApiBundle/tests/Changer/PaymentMethodChangerTest.php
index f1e326e0556..fc82e7af3e5 100644
--- a/src/Sylius/Bundle/ApiBundle/tests/Changer/PaymentMethodChangerTest.php
+++ b/src/Sylius/Bundle/ApiBundle/tests/Changer/... | true | |
Sylius/Sylius | 18,955 | comment_to_fix | [UPMERGE] 2.2 -> 2.3 | _⚠️ Potential issue_ | _🟠 Major_
**Use the show route here, not the index route.**
`show_route_name` currently prefers `configuration.vars.index.route.name`, so the breadcrumb can link back to the listing page with `id` tacked on as a query parameter instead of linking to the resource show page.
<details>
<summary>... | 5bac4c62cb6c5fa9a4c6a826af3a39e3e5cc799f | 280b4e55249154e8398a48b5ec8c70e476a1caa0 | diff --git a/src/Sylius/Bundle/AdminBundle/templates/shared/crud/update/content/header/breadcrumbs.html.twig b/src/Sylius/Bundle/AdminBundle/templates/shared/crud/update/content/header/breadcrumbs.html.twig
index eb88fe93170..65a30021356 100644
--- a/src/Sylius/Bundle/AdminBundle/templates/shared/crud/update/content/he... | [
"src/Sylius/Bundle/AdminBundle/templates/shared/crud/update/content/header/breadcrumbs.html.twig"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Use the show route here, not the index route.**\n\n`show_route_name` currently prefers `configuration.vars.index.route.name`, so the breadcrumb can link back to the listing page with `id` tacked on as a query parameter instead of linking to the resource show ... | true | ||
Sylius/Sylius | 19,042 | issue_to_patch | [UPMERGE] 2.1 -> 2.2 | This PR has been generated automatically.
For more details see [upmerge_pr.yaml](/Sylius/Sylius/blob/2.3/.github/workflows/upmerge_pr.yaml).
**Remember!** The upmerge should always be merged with using `Merge pull request` button.
In case of conflicts, please resolve them manually with usign the following commands:
`... | 9315d9e1f42db8173093e7978d2891a370d9b127 | 197648f0ed649e0983ae853b5e2bb870a0b1dafb | diff --git a/CHANGELOG-2.1.md b/CHANGELOG-2.1.md
index 769fe3d3081..279b9d62b2a 100644
--- a/CHANGELOG-2.1.md
+++ b/CHANGELOG-2.1.md
@@ -1,5 +1,13 @@
# CHANGELOG FOR `2.1.X`
+## v2.1.15 (2026-06-02)
+
+#### Details
+
+- [#19038](https://github.com/Sylius/Sylius/pull/19038) [2.1] Prevent stale cart LiveComponents fro... | [
"CHANGELOG-2.1.md"
] | [] | true | ||
Sylius/Sylius | 19,041 | issue_to_patch | [UPMERGE] 2.1 -> 2.2 | This PR has been generated automatically.
For more details see [upmerge_pr.yaml](/Sylius/Sylius/blob/2.3/.github/workflows/upmerge_pr.yaml).
**Remember!** The upmerge should always be merged with using `Merge pull request` button.
In case of conflicts, please resolve them manually with usign the following commands:
`... | 5aa6e48fa3b70cbdb07823ee07fad174b281a6dd | 903f5f5d1e193470f8c92cc9f8b21e706de1f426 | diff --git a/UPGRADE-API-2.1.md b/UPGRADE-API-2.1.md
index d032b6bb701..1e233f02829 100644
--- a/UPGRADE-API-2.1.md
+++ b/UPGRADE-API-2.1.md
@@ -1,3 +1,26 @@
+# UPGRADE FROM `2.1.14` TO `2.1.15`
+
+## Security
+
+### Payment request ownership enforcement
+
+`GET /api/v2/shop/payment-requests/{hash}`, `PUT /api/v2/shop/... | [
"UPGRADE-API-2.1.md",
"features/shop/cart/shopping_cart/stale_live_component_prevents_completed_order_mutation.feature",
"src/Sylius/Behat/Context/Ui/Shop/StaleCartLiveComponentContext.php",
"src/Sylius/Behat/Resources/config/services/contexts/ui.xml",
"src/Sylius/Behat/Resources/config/suites/ui.yml",
"s... | [] | diff --git a/src/Sylius/Bundle/ApiBundle/tests/Changer/PaymentMethodChangerTest.php b/src/Sylius/Bundle/ApiBundle/tests/Changer/PaymentMethodChangerTest.php
index f1e326e0556..fc82e7af3e5 100644
--- a/src/Sylius/Bundle/ApiBundle/tests/Changer/PaymentMethodChangerTest.php
+++ b/src/Sylius/Bundle/ApiBundle/tests/Changer/... | true | |
Sylius/Sylius | 19,040 | issue_to_patch | [2.1] Check payment request ownership | | Q | A
|-----------------|-----
| Branch? | 2.1 <!-- see the comment below -->
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| License | MIT
<!--
- Bug fixes must be submitted against the 2.2 branch
- Features and deprecations must be submitted against ... | e8764931d7b1d5b56e3324d6b407b6ade086b5c2 | 0af90b6e96a936a48f0d8ccff5a18061266db80e | diff --git a/UPGRADE-API-2.1.md b/UPGRADE-API-2.1.md
index d032b6bb701..1e233f02829 100644
--- a/UPGRADE-API-2.1.md
+++ b/UPGRADE-API-2.1.md
@@ -1,3 +1,26 @@
+# UPGRADE FROM `2.1.14` TO `2.1.15`
+
+## Security
+
+### Payment request ownership enforcement
+
+`GET /api/v2/shop/payment-requests/{hash}`, `PUT /api/v2/shop/... | [
"UPGRADE-API-2.1.md",
"src/Sylius/Bundle/ApiBundle/CommandHandler/Payment/AddPaymentRequestHandler.php",
"src/Sylius/Bundle/ApiBundle/Doctrine/ORM/QueryExtension/Shop/PaymentRequest/ShopUserBasedExtension.php",
"src/Sylius/Bundle/ApiBundle/Doctrine/ORM/QueryExtension/Shop/PaymentRequest/VisitorBasedExtension.... | [] | diff --git a/src/Sylius/Bundle/ApiBundle/tests/CommandHandler/AddPaymentRequestHandlerTest.php b/src/Sylius/Bundle/ApiBundle/tests/CommandHandler/AddPaymentRequestHandlerTest.php
index 542934a1eac..162264c896d 100644
--- a/src/Sylius/Bundle/ApiBundle/tests/CommandHandler/AddPaymentRequestHandlerTest.php
+++ b/src/Syliu... | true | |
Sylius/Sylius | 19,039 | issue_to_patch | [2.1][API] Enforce channel eligibility check when changing payment method via account endpoint | | Q | A
|-----------------|-----
| Branch? | 2.1 <!-- see the comment below -->
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| License | MIT
<!--
- Bug fixes must be submitted against the 2.2 branch
- Features and deprecations must be submitted against... | c6ea41803e7dc2affe7d236500e82ad8be091344 | 177b60dbeb0e8e35d3402a80978cb49218335c8f | diff --git a/src/Sylius/Bundle/ApiBundle/Changer/PaymentMethodChanger.php b/src/Sylius/Bundle/ApiBundle/Changer/PaymentMethodChanger.php
index c6036b3f8e0..fe7c8a40cef 100644
--- a/src/Sylius/Bundle/ApiBundle/Changer/PaymentMethodChanger.php
+++ b/src/Sylius/Bundle/ApiBundle/Changer/PaymentMethodChanger.php
@@ -19,6 +1... | [
"src/Sylius/Bundle/ApiBundle/Changer/PaymentMethodChanger.php",
"src/Sylius/Bundle/ApiBundle/Resources/config/services.xml",
"src/Sylius/Bundle/ApiBundle/Resources/config/validation/ChangePaymentMethod.xml",
"src/Sylius/Bundle/ApiBundle/Validator/Constraints/ChosenPaymentMethodEligibilityValidator.php",
"sr... | [] | diff --git a/src/Sylius/Bundle/ApiBundle/tests/Changer/PaymentMethodChangerTest.php b/src/Sylius/Bundle/ApiBundle/tests/Changer/PaymentMethodChangerTest.php
index f1e326e0556..fc82e7af3e5 100644
--- a/src/Sylius/Bundle/ApiBundle/tests/Changer/PaymentMethodChangerTest.php
+++ b/src/Sylius/Bundle/ApiBundle/tests/Changer/... | true | |
Sylius/Sylius | 19,037 | issue_to_patch | [2.0][API] Enforce channel eligibility check when changing payment method via account endpoint | | Q | A
|-----------------|-----
| Branch? | 2.0 <!-- see the comment below -->
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| License | MIT
<!--
- Bug fixes must be submitted against the 2.2 branch
- Features and deprecations must be submitted against... | 1fb3414861cbdad35b507ca7e274df7fe90b18f9 | 3154b76f19368f9106ba5fdf917a9cbba352477c | diff --git a/src/Sylius/Bundle/ApiBundle/Changer/PaymentMethodChanger.php b/src/Sylius/Bundle/ApiBundle/Changer/PaymentMethodChanger.php
index c6036b3f8e0..fe7c8a40cef 100644
--- a/src/Sylius/Bundle/ApiBundle/Changer/PaymentMethodChanger.php
+++ b/src/Sylius/Bundle/ApiBundle/Changer/PaymentMethodChanger.php
@@ -19,6 +1... | [
"src/Sylius/Bundle/ApiBundle/Changer/PaymentMethodChanger.php",
"src/Sylius/Bundle/ApiBundle/Resources/config/services.xml",
"src/Sylius/Bundle/ApiBundle/Resources/config/validation/ChangePaymentMethod.xml",
"src/Sylius/Bundle/ApiBundle/Validator/Constraints/ChosenPaymentMethodEligibilityValidator.php",
"te... | [] | diff --git a/tests/Api/DataFixtures/ORM/payment_method/out_of_channel_payment_method.yaml b/tests/Api/DataFixtures/ORM/payment_method/out_of_channel_payment_method.yaml
new file mode 100644
index 00000000000..e339f3f81fb
--- /dev/null
+++ b/tests/Api/DataFixtures/ORM/payment_method/out_of_channel_payment_method.yaml
@@... | true | |
Sylius/Sylius | 19,036 | issue_to_patch | [2.0] Prevent stale cart LiveComponents from mutating completed orders | | Q | A
|-----------------|-----
| Branch? | 2.0 <!-- see the comment below -->
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| License | MIT
<!--
- Bug fixes must be submitted against the 2.2 branch
- Features and deprecations must be submitted against... | 0ee153ddb2ca70c48f1fcc6310a2935d05bac249 | bdf60d95f6d0ce46d0f9e97c81bc15477b8a8765 | diff --git a/features/shop/cart/shopping_cart/stale_live_component_prevents_completed_order_mutation.feature b/features/shop/cart/shopping_cart/stale_live_component_prevents_completed_order_mutation.feature
new file mode 100644
index 00000000000..0b5908557bc
--- /dev/null
+++ b/features/shop/cart/shopping_cart/stale_li... | [
"features/shop/cart/shopping_cart/stale_live_component_prevents_completed_order_mutation.feature",
"src/Sylius/Behat/Context/Ui/Shop/StaleCartLiveComponentContext.php",
"src/Sylius/Behat/Resources/config/services/contexts/ui.xml",
"src/Sylius/Behat/Resources/config/suites/ui.yml",
"src/Sylius/Behat/Resource... | [] | true | ||
Sylius/Sylius | 19,035 | issue_to_patch | [2.0] Check payment request ownership | | Q | A
|-----------------|-----
| Branch? | 2.0 <!-- see the comment below -->
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| License | MIT
<!--
- Bug fixes must be submitted against the 2.2 branch
- Features and deprecations must be submitted against... | 3b47d6f94edafb122df49dddf898600f69819046 | 04fd184814e0018674a534dec616eceeb3a033b4 | diff --git a/UPGRADE-API-2.0.md b/UPGRADE-API-2.0.md
index 6641f0fff06..2af317e877f 100644
--- a/UPGRADE-API-2.0.md
+++ b/UPGRADE-API-2.0.md
@@ -1,3 +1,26 @@
+# UPGRADE FROM `2.0.17` TO `2.0.18`
+
+## Security
+
+### Payment request ownership enforcement
+
+`GET /api/v2/shop/payment-requests/{hash}`, `PUT /api/v2/shop/... | [
"UPGRADE-API-2.0.md",
"src/Sylius/Bundle/ApiBundle/CommandHandler/Payment/AddPaymentRequestHandler.php",
"src/Sylius/Bundle/ApiBundle/Doctrine/ORM/QueryExtension/Shop/PaymentRequest/ShopUserBasedExtension.php",
"src/Sylius/Bundle/ApiBundle/Doctrine/ORM/QueryExtension/Shop/PaymentRequest/VisitorBasedExtension.... | [] | diff --git a/src/Sylius/Bundle/ApiBundle/Tests/CommandHandler/AddPaymentRequestHandlerTest.php b/src/Sylius/Bundle/ApiBundle/Tests/CommandHandler/AddPaymentRequestHandlerTest.php
index ba4c96d1b78..29408b8704a 100644
--- a/src/Sylius/Bundle/ApiBundle/Tests/CommandHandler/AddPaymentRequestHandlerTest.php
+++ b/src/Syliu... | true | |
Sylius/Sylius | 19,026 | issue_to_patch | [API] Slim down Swagger UI override and drop broken auto-auth JS | | Q | A
|-----------------|-----
| Branch? | 2.2
| Bug fix? | yes?
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
<!--
- Bug fixes must be submitted against the 2.2 branch
- Features and deprecations must be s... | 805b660545c2017b27be0f229b335417d9f42a8c | 3f1297c4090f0b49ef8abd1fb7c444d9e7312339 | diff --git a/templates/bundles/ApiPlatformBundle/SwaggerUi/index.html.twig b/templates/bundles/ApiPlatformBundle/SwaggerUi/index.html.twig
index d47cedbebeb..6073adcce8e 100644
--- a/templates/bundles/ApiPlatformBundle/SwaggerUi/index.html.twig
+++ b/templates/bundles/ApiPlatformBundle/SwaggerUi/index.html.twig
@@ -1,1... | [
"templates/bundles/ApiPlatformBundle/SwaggerUi/index.html.twig"
] | [] | true | ||
Sylius/Sylius | 19,025 | issue_to_patch | [API] Add regression tests for cross-customer cart item access | | Q | A
|-----------------|-----
| Branch? | 2.2
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
<!--
- Bug fixes must be submitted against the 2.2 branch
- Features and deprecations must be sub... | 45e654e83155a17c4ac0cbd46b1b6233736ade56 | 048b69ad441d0289d2db37d765094f04c7bbb122 | [
"tests/Api/Shop/Checkout/CartTest.php"
] | [] | diff --git a/tests/Api/Shop/Checkout/CartTest.php b/tests/Api/Shop/Checkout/CartTest.php
index 277ac253f93..090803deaaa 100644
--- a/tests/Api/Shop/Checkout/CartTest.php
+++ b/tests/Api/Shop/Checkout/CartTest.php
@@ -264,6 +264,64 @@ public function it_does_not_allow_to_remove_item_from_the_cart_if_invalid_order_
... | true | ||
Sylius/Sylius | 19,024 | issue_to_patch | [2.2] [AttributeBundle] make Add and Delete button translatable in product attribute select type | | Q | A
|-----------------|-----
| Branch? | 2.2
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | fixes #X
| License | MIT
**Description**
So far it wasnt possible to translate the "Add" and "Delete" button when ... | d57823973ada8bc73076ae4729b9c11391cbc494 | 8346daac297e754bd143bb2c23cb1e0189d95aca | diff --git a/src/Sylius/Bundle/AdminBundle/Form/Type/AttributeType/Configuration/SelectAttributeConfigurationType.php b/src/Sylius/Bundle/AdminBundle/Form/Type/AttributeType/Configuration/SelectAttributeConfigurationType.php
index 1a5af764965..8c8f6540229 100644
--- a/src/Sylius/Bundle/AdminBundle/Form/Type/AttributeTy... | [
"src/Sylius/Bundle/AdminBundle/Form/Type/AttributeType/Configuration/SelectAttributeConfigurationType.php",
"src/Sylius/Bundle/AdminBundle/templates/product_attribute/form_theme.html.twig",
"src/Sylius/Bundle/AttributeBundle/Resources/translations/messages.de.yml",
"src/Sylius/Bundle/AttributeBundle/Resources... | [] | true | ||
Sylius/Sylius | 19,015 | issue_to_patch | [Admin] Support clickable navbar notifications with translation parameters | | Q | A
|-----------------|-----
| Branch? | 2.3
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
Extends the admin navbar notifications contract so plugins can surface clickable, parameterized noti... | f4add488e41ca5aa362df1820119f1746b02a008 | d42ea9117e4c3ffdd569a390844390e63e6141f5 | diff --git a/src/Sylius/Bundle/AdminBundle/Notification/NotificationProviderInterface.php b/src/Sylius/Bundle/AdminBundle/Notification/NotificationProviderInterface.php
index 28d8cf3768a..e24e20fc262 100644
--- a/src/Sylius/Bundle/AdminBundle/Notification/NotificationProviderInterface.php
+++ b/src/Sylius/Bundle/AdminB... | [
"src/Sylius/Bundle/AdminBundle/Notification/NotificationProviderInterface.php",
"src/Sylius/Bundle/AdminBundle/Resources/config/app/twig_hooks/common/component/navbar.yaml",
"src/Sylius/Bundle/AdminBundle/templates/shared/components/navbar/notifications.html.twig",
"src/Sylius/Bundle/AdminBundle/templates/sha... | [
{
"comment": "How about also supporting plain urls?",
"path": "src/Sylius/Bundle/AdminBundle/Notification/NotificationProviderInterface.php",
"hunk": "@@ -16,6 +16,19 @@\n interface NotificationProviderInterface\n {\n /**\n+ * Each notification is identified by a string key. The value is a map t... | diff --git a/src/Sylius/Bundle/AdminBundle/tests/Twig/Component/Shared/Navbar/NotificationsComponentTest.php b/src/Sylius/Bundle/AdminBundle/tests/Twig/Component/Shared/Navbar/NotificationsComponentTest.php
index 1b916c0d727..98d0557c929 100644
--- a/src/Sylius/Bundle/AdminBundle/tests/Twig/Component/Shared/Navbar/Noti... | true | |
Sylius/Sylius | 19,015 | comment_to_fix | [Admin] Support clickable navbar notifications with translation parameters | How about also supporting plain urls? | f4add488e41ca5aa362df1820119f1746b02a008 | d42ea9117e4c3ffdd569a390844390e63e6141f5 | diff --git a/src/Sylius/Bundle/AdminBundle/Notification/NotificationProviderInterface.php b/src/Sylius/Bundle/AdminBundle/Notification/NotificationProviderInterface.php
index 28d8cf3768a..e24e20fc262 100644
--- a/src/Sylius/Bundle/AdminBundle/Notification/NotificationProviderInterface.php
+++ b/src/Sylius/Bundle/AdminB... | [
"src/Sylius/Bundle/AdminBundle/Notification/NotificationProviderInterface.php"
] | [
{
"comment": "How about also supporting plain urls?",
"path": "src/Sylius/Bundle/AdminBundle/Notification/NotificationProviderInterface.php",
"hunk": "@@ -16,6 +16,19 @@\n interface NotificationProviderInterface\n {\n /**\n+ * Each notification is identified by a string key. The value is a map t... | true | ||
Sylius/Sylius | 19,015 | comment_to_fix | [Admin] Support clickable navbar notifications with translation parameters | ```suggestion
{% set element = has_route ? 'a' : 'div' %}
```
? seems more in line with the wording we usually use | f4add488e41ca5aa362df1820119f1746b02a008 | d42ea9117e4c3ffdd569a390844390e63e6141f5 | diff --git a/src/Sylius/Bundle/AdminBundle/templates/shared/components/navbar/notifications/item.html.twig b/src/Sylius/Bundle/AdminBundle/templates/shared/components/navbar/notifications/item.html.twig
new file mode 100644
index 00000000000..a62e29c1d6e
--- /dev/null
+++ b/src/Sylius/Bundle/AdminBundle/templates/share... | [
"src/Sylius/Bundle/AdminBundle/templates/shared/components/navbar/notifications/item.html.twig"
] | [
{
"comment": "```suggestion\n{% set element = has_route ? 'a' : 'div' %}\n```\n? seems more in line with the wording we usually use",
"path": "src/Sylius/Bundle/AdminBundle/templates/shared/components/navbar/notifications/item.html.twig",
"hunk": "@@ -0,0 +1,17 @@\n+{% set notification = hookable_metada... | true | ||
Sylius/Sylius | 19,017 | issue_to_patch | Add appendError method to ResponseCheckerInterface | | Q | A
|-----------------|-----
| Branch? | 2.2
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
A missing interface method signature `appendError` is missing in the `ResponseCheckerInterface`, I d... | fd2a52305c51944654657eb01f3be71c5653dca6 | b07a3db6d297c9af81a59010e23e32d632c8f6f9 | diff --git a/src/Sylius/Behat/Client/ResponseCheckerInterface.php b/src/Sylius/Behat/Client/ResponseCheckerInterface.php
index e2c692ecb7b..0d06005fc47 100644
--- a/src/Sylius/Behat/Client/ResponseCheckerInterface.php
+++ b/src/Sylius/Behat/Client/ResponseCheckerInterface.php
@@ -93,6 +93,8 @@ public function getRespon... | [
"src/Sylius/Behat/Client/ResponseCheckerInterface.php"
] | [] | true | ||
Sylius/Sylius | 19,018 | issue_to_patch | [ApiBundle] Fix 404 on GET /shop/products/{code} when all associated products are disabled | | Q | A
|-----------------|-----
| Branch? | 2.2
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | https://github.com/Sylius/Sylius/issues/19013
| License | MIT
### Summary
`GET /api/v2/shop/products/{code}` r... | fd2a52305c51944654657eb01f3be71c5653dca6 | cb751d0bb7ad4eab7c13295ca8d97172ae6b7e5b | diff --git a/src/Sylius/Bundle/ApiBundle/Doctrine/ORM/QueryExtension/Shop/Product/EnabledWithinProductAssociationExtension.php b/src/Sylius/Bundle/ApiBundle/Doctrine/ORM/QueryExtension/Shop/Product/EnabledWithinProductAssociationExtension.php
index f064690fcca..7c802893915 100644
--- a/src/Sylius/Bundle/ApiBundle/Doctr... | [
"src/Sylius/Bundle/ApiBundle/Doctrine/ORM/QueryExtension/Shop/Product/EnabledWithinProductAssociationExtension.php",
"src/Sylius/Bundle/ApiBundle/tests/Doctrine/ORM/QueryExtension/Shop/Product/EnabledWithinProductAssociationExtensionTest.php",
"tests/Api/DataFixtures/ORM/product/product_with_only_disabled_assoc... | [] | diff --git a/src/Sylius/Bundle/ApiBundle/tests/Doctrine/ORM/QueryExtension/Shop/Product/EnabledWithinProductAssociationExtensionTest.php b/src/Sylius/Bundle/ApiBundle/tests/Doctrine/ORM/QueryExtension/Shop/Product/EnabledWithinProductAssociationExtensionTest.php
index 8f966e93434..046c2c786a5 100644
--- a/src/Sylius/Bu... | true | |
Sylius/Sylius | 19,001 | issue_to_patch | Bugfix/csrf token | | Q | A
|-----------------|-----
| Branch? | 2.2
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | https://github.com/Sylius/Sylius/pull/18324
| License | MIT
This PR removes hard-coded references to the **Symfony ... | cec31ee65010cd04fab0dbbdd6c9b1e036a35207 | 0b5709f4dc124c99261729c0ba687ba7c57cc84e | diff --git a/src/Sylius/Bundle/AdminBundle/Action/RemoveAvatarAction.php b/src/Sylius/Bundle/AdminBundle/Action/RemoveAvatarAction.php
index 99a39f710b3..ab4e3d3d782 100644
--- a/src/Sylius/Bundle/AdminBundle/Action/RemoveAvatarAction.php
+++ b/src/Sylius/Bundle/AdminBundle/Action/RemoveAvatarAction.php
@@ -28,7 +28,7 ... | [
"src/Sylius/Bundle/AdminBundle/Action/RemoveAvatarAction.php",
"src/Sylius/Bundle/AdminBundle/Action/ResendOrderConfirmationEmailAction.php",
"src/Sylius/Bundle/AdminBundle/Action/ResendShipmentConfirmationEmailAction.php",
"src/Sylius/Bundle/AdminBundle/Resources/config/services/controller.xml",
"src/Syliu... | [] | true | ||
Sylius/Sylius | 19,012 | issue_to_patch | [ApiBundle] Fix "Undefined array key 0" in PathPrefixProvider when path equals API route | | Q | A
|-----------------|-----
| Branch? | 2.2
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
## Description:
When the request path equals the configured API route exactly (e.g. /api/v2 — ... | fbf3e994db3f079ae1c0dfbca27fa3bb4ae69e64 | 5e41cb52070269f471ba2d636f7566ef2a25ff70 | diff --git a/src/Sylius/Bundle/ApiBundle/Provider/PathPrefixProvider.php b/src/Sylius/Bundle/ApiBundle/Provider/PathPrefixProvider.php
index 666ae697ee0..3ab312c1fb7 100644
--- a/src/Sylius/Bundle/ApiBundle/Provider/PathPrefixProvider.php
+++ b/src/Sylius/Bundle/ApiBundle/Provider/PathPrefixProvider.php
@@ -28,6 +28,10... | [
"src/Sylius/Bundle/ApiBundle/Provider/PathPrefixProvider.php",
"src/Sylius/Bundle/ApiBundle/tests/Provider/PathPrefixProviderTest.php"
] | [] | diff --git a/src/Sylius/Bundle/ApiBundle/tests/Provider/PathPrefixProviderTest.php b/src/Sylius/Bundle/ApiBundle/tests/Provider/PathPrefixProviderTest.php
index 30cfd9dcfc1..1dc8a536a6b 100644
--- a/src/Sylius/Bundle/ApiBundle/tests/Provider/PathPrefixProviderTest.php
+++ b/src/Sylius/Bundle/ApiBundle/tests/Provider/Pa... | true | |
Sylius/Sylius | 19,009 | issue_to_patch | [ApiBundle][Tests] Add regression test for anonymous cart pickup wit… | | Q | A
|-----------------|-----
| Branch? | 2.2
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | n/a
| License | MIT | cec31ee65010cd04fab0dbbdd6c9b1e036a35207 | bdf55e7f4389a0b0f56da67ab6f8674db491405c | [
"tests/Api/Shop/Checkout/CartTest.php"
] | [] | diff --git a/tests/Api/Shop/Checkout/CartTest.php b/tests/Api/Shop/Checkout/CartTest.php
index e3ac04c2ea3..277ac253f93 100644
--- a/tests/Api/Shop/Checkout/CartTest.php
+++ b/tests/Api/Shop/Checkout/CartTest.php
@@ -84,6 +84,32 @@ public function it_gets_existing_cart_if_customer_has_cart(): void
$this->asser... | true | ||
Sylius/Sylius | 19,007 | issue_to_patch | Relax version constraint for sylius-labs/doctrine-migrations-extra-bundle | | Q | A
|-----------------|-----
| Branch? | 2.3
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| License | MIT
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **Chores**
* Broadened dependency compatibil... | 34ec5039ed6b421c9afb6704bdc77de18ced51a2 | 1178a0adc18fd7b7e6c5593a0cbc5e3e675d8ad2 | diff --git a/composer.json b/composer.json
index aeb54b8abff..d34d6d781b9 100644
--- a/composer.json
+++ b/composer.json
@@ -73,7 +73,7 @@
"ramsey/uuid": "^4.7",
"stof/doctrine-extensions-bundle": "^1.12",
"sylius-labs/association-hydrator": "^1.2",
- "sylius-labs/doctrine-migrations-e... | [
"composer.json",
"src/Sylius/Bundle/CoreBundle/composer.json"
] | [] | true | ||
Sylius/Sylius | 19,005 | issue_to_patch | Builds reorganisation | | Q | A
|-----------------|-----
| Branch? | 2.3 <!-- see the comment below -->
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| License | MIT
<!--
- Bug fixes must be submitted against the 1.14 or 2.1 branch
- Features and deprecations must be submitted ... | 32fdbc4c749c836f353d83ceef94715e79b5af33 | 81a0deef68edc2354cb388f4358b085bdf3969a7 | diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index e94c59d7d7e..ac2b1b1b0fa 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,6 +1,6 @@
| Q | A
|-----------------|-----
-| Branch? | 1.14, 2.0 or 2.1 <!-- see the comment... | [
".github/PULL_REQUEST_TEMPLATE.md",
".github/workflows/ci__full.yaml",
".github/workflows/ci__full_1_14.yaml",
".github/workflows/ci__full_2_1.yaml",
".github/workflows/ci_e2e-mariadb.yaml",
".github/workflows/ci_e2e-mysql.yaml",
".github/workflows/ci_e2e-pgsql.yaml",
".github/workflows/ci_frontend.ya... | [] | true | ||
Sylius/Sylius | 18,988 | issue_to_patch | BUGFIX: Expose ShippingMethod *DeliveryTimeDays in admin API | | Q | A
|-----------------|-----
| Branch? | 2.2
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | fixes #18986
| License | MIT
<!--
- Bug fixes must be submitted against the 1.14 or 2.1 branch
- Features and d... | bead750c0becf8ed27b7ee119ed5aa1b3b0ec637 | c30e4a4f35f8d4697bdf601d7286cc6452b96adf | diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serialization/ShippingMethod.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serialization/ShippingMethod.xml
index 00df82d6dff..7091a3e3b61 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/serialization/ShippingMethod.xml
+++ b/src/Sylius/Bundle/Api... | [
"src/Sylius/Bundle/ApiBundle/Resources/config/serialization/ShippingMethod.xml",
"tests/Api/Admin/ShippingMethodsTest.php",
"tests/Api/Responses/admin/shipping_method/archive_shipping_method_response.json",
"tests/Api/Responses/admin/shipping_method/get_shipping_method_response.json",
"tests/Api/Responses/a... | [] | diff --git a/tests/Api/Admin/ShippingMethodsTest.php b/tests/Api/Admin/ShippingMethodsTest.php
index 041809e2cd7..b7a55f44705 100644
--- a/tests/Api/Admin/ShippingMethodsTest.php
+++ b/tests/Api/Admin/ShippingMethodsTest.php
@@ -598,6 +598,79 @@ public function it_does_not_update_shipping_methods_rules_with_wrong_types... | true | |
Sylius/Sylius | 18,990 | issue_to_patch | Fix attribute card style for product show | | Q | A
|-----------------|-----
| Branch? | 2.2
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| License | MIT
<!--
- Bug fixes must be submitted against the 1.14 or 2.1 branch
- Features and deprecations must be submitted agains... | 11373d8bf96a87d52dd03ed6156051e97896e39b | b9db109d013c61c4a42462e4f26fd8dfbfac9e5f | diff --git a/src/Sylius/Bundle/AdminBundle/templates/product/show/content/page_body/attributes.html.twig b/src/Sylius/Bundle/AdminBundle/templates/product/show/content/page_body/attributes.html.twig
index 444325338d8..5a5b7f4bf70 100644
--- a/src/Sylius/Bundle/AdminBundle/templates/product/show/content/page_body/attrib... | [
"src/Sylius/Bundle/AdminBundle/templates/product/show/content/page_body/attributes.html.twig"
] | [] | true | ||
Sylius/Sylius | 18,989 | issue_to_patch | Fix modals appearing behind backdrop on sticky page-header | | Q | A
|-----------------|-----
| Branch? | 2.2 <!-- see the comment below -->
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no/yes <!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets | fixes #X, partially #Y, mentioned in #Z
... | 11373d8bf96a87d52dd03ed6156051e97896e39b | 4655265e90083acc5f07849c0d0b5fe0876e358f | diff --git a/UPGRADE-2.2.md b/UPGRADE-2.2.md
index b059c121821..d45ffbd2069 100644
--- a/UPGRADE-2.2.md
+++ b/UPGRADE-2.2.md
@@ -53,6 +53,12 @@ SYLIUS_TELEMETRY_SALT=your-custom-salt
1. The `Sylius\Bundle\ReviewBundle\Updater\ReviewableRatingUpdaterInterface::updateFromReview()` method has been deprecated and will b... | [
"UPGRADE-2.2.md",
"src/Sylius/Behat/Element/Admin/Taxon/TreeElement.php",
"src/Sylius/Behat/Page/Admin/ShippingMethod/IndexPage.php",
"src/Sylius/Bundle/AdminBundle/Resources/assets/entrypoint.js",
"src/Sylius/Bundle/AdminBundle/Resources/assets/scripts/modal-portal.js",
"src/Sylius/Bundle/AdminBundle/Res... | [
{
"comment": "There is no way to keep this sticky header by simply changing the z-index ?",
"path": "src/Sylius/Bundle/AdminBundle/Resources/assets/styles/_layout.scss",
"hunk": "@@ -9,18 +9,9 @@\n \n .page-wrapper {\n .page-header {\n- position: sticky;\n- top: -1px;\n- z-index... | true | ||
Sylius/Sylius | 18,991 | issue_to_patch | FIX: [AdminBundle] add missing entry for ListAdminUsersCommand in services configuration | | Q | A
|-----------------|-----
| Branch? | 2.3
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | fixes #X, partially #Y, mentioned in #Z
| License | MIT
I noticed that in the `src/Sylius/Bundle/AdminBundle/Resource... | 50e3576804dd87753202404743d05622205b5831 | 723ea7ca26845616c62bd5b7503d824fbd7588fb | diff --git a/src/Sylius/Bundle/AdminBundle/Resources/config/services.php b/src/Sylius/Bundle/AdminBundle/Resources/config/services.php
index ab1c7e7ff15..e5431316269 100644
--- a/src/Sylius/Bundle/AdminBundle/Resources/config/services.php
+++ b/src/Sylius/Bundle/AdminBundle/Resources/config/services.php
@@ -18,6 +18,7 ... | [
"src/Sylius/Bundle/AdminBundle/Resources/config/services.php"
] | [
{
"comment": "```suggestion\n service('sylius.manager.admin_user'),\n```",
"path": "src/Sylius/Bundle/AdminBundle/Resources/config/services.php",
"hunk": "@@ -51,6 +52,16 @@\n ->tag('console.command')\n ;\n \n+ $services\n+ ->set('sylius_admin.console.command.list_admin_... | true | ||
Sylius/Sylius | 18,991 | comment_to_fix | FIX: [AdminBundle] add missing entry for ListAdminUsersCommand in services configuration | ```suggestion
service('sylius.manager.admin_user'),
``` | 50e3576804dd87753202404743d05622205b5831 | 723ea7ca26845616c62bd5b7503d824fbd7588fb | diff --git a/src/Sylius/Bundle/AdminBundle/Resources/config/services.php b/src/Sylius/Bundle/AdminBundle/Resources/config/services.php
index ab1c7e7ff15..e5431316269 100644
--- a/src/Sylius/Bundle/AdminBundle/Resources/config/services.php
+++ b/src/Sylius/Bundle/AdminBundle/Resources/config/services.php
@@ -18,6 +18,7 ... | [
"src/Sylius/Bundle/AdminBundle/Resources/config/services.php"
] | [
{
"comment": "```suggestion\n service('sylius.manager.admin_user'),\n```",
"path": "src/Sylius/Bundle/AdminBundle/Resources/config/services.php",
"hunk": "@@ -51,6 +52,16 @@\n ->tag('console.command')\n ;\n \n+ $services\n+ ->set('sylius_admin.console.command.list_admin_... | true | ||
Sylius/Sylius | 18,958 | issue_to_patch | [API] Make API Platform resource command classes overridable via container parameters | | Q | A
|-----------------|-----
| Branch? | 2.2
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
## Summary
Some API Platform resource definitions use command classes directly as the `class` att... | 7d6918b1009db6cad1e96fb59310c6bc3b9002e0 | 4e1955c5facef607b5d27a6d04f8aa79000a41b2 | diff --git a/UPGRADE-API-2.2.md b/UPGRADE-API-2.2.md
index 4efe842848f..85a3cc5f732 100644
--- a/UPGRADE-API-2.2.md
+++ b/UPGRADE-API-2.2.md
@@ -49,3 +49,22 @@ Additionally, the redundant `code` field has been removed from the error respons
- If your API client reads `response.data.code`, use `response.status` (HTTP h... | [
"UPGRADE-API-2.2.md",
"src/Sylius/Bundle/ApiBundle/Resources/config/api_platform/resources/admin/AdminUserPassword.xml",
"src/Sylius/Bundle/ApiBundle/Resources/config/api_platform/resources/shop/Contact.xml",
"src/Sylius/Bundle/ApiBundle/Resources/config/api_platform/resources/shop/CustomerPassword.xml",
"s... | [
{
"comment": "```suggestion\n sylius_api.command.account.reset_password.class: App\\Api\\Command\\CustomResetPassword\n```",
"path": "UPGRADE-API-2.2.md",
"hunk": "@@ -49,3 +49,22 @@ Additionally, the redundant `code` field has been removed from the error respons\n - If your API client reads `respons... | true | ||
Sylius/Sylius | 18,958 | comment_to_fix | [API] Make API Platform resource command classes overridable via container parameters | ```suggestion
sylius_api.command.account.reset_password.class: App\Api\Command\CustomResetPassword
``` | 7d6918b1009db6cad1e96fb59310c6bc3b9002e0 | 4e1955c5facef607b5d27a6d04f8aa79000a41b2 | diff --git a/UPGRADE-API-2.2.md b/UPGRADE-API-2.2.md
index 4efe842848f..85a3cc5f732 100644
--- a/UPGRADE-API-2.2.md
+++ b/UPGRADE-API-2.2.md
@@ -49,3 +49,22 @@ Additionally, the redundant `code` field has been removed from the error respons
- If your API client reads `response.data.code`, use `response.status` (HTTP h... | [
"UPGRADE-API-2.2.md"
] | [
{
"comment": "```suggestion\n sylius_api.command.account.reset_password.class: App\\Api\\Command\\CustomResetPassword\n```",
"path": "UPGRADE-API-2.2.md",
"hunk": "@@ -49,3 +49,22 @@ Additionally, the redundant `code` field has been removed from the error respons\n - If your API client reads `respons... | true | ||
Sylius/Sylius | 18,976 | issue_to_patch | [UPMERGE] 2.1 -> 2.2 | This PR has been generated automatically.
For more details see [upmerge_pr.yaml](/Sylius/Sylius/blob/2.3/.github/workflows/upmerge_pr.yaml).
**Remember!** The upmerge should always be merged with using `Merge pull request` button.
In case of conflicts, please resolve them manually with usign the following commands:
`... | cc98e12428e20ed1d44b3ba600d519e86333588d | ad1c62bb9eb7aac21112e6b6615ddbfdb6fbd53b | diff --git a/CHANGELOG-2.1.md b/CHANGELOG-2.1.md
index e9799625efe..769fe3d3081 100644
--- a/CHANGELOG-2.1.md
+++ b/CHANGELOG-2.1.md
@@ -1,5 +1,34 @@
# CHANGELOG FOR `2.1.X`
+## v2.1.14 (2026-04-10)
+
+#### Details
+
+- [#18579](https://github.com/Sylius/Sylius/pull/18579) Fix problem with empty taxon product index ... | [
"CHANGELOG-2.1.md"
] | [] | true | ||
Sylius/Sylius | 18,975 | issue_to_patch | [UPMERGE] 2.1 -> 2.2 | This PR has been generated automatically.
For more details see [upmerge_pr.yaml](/Sylius/Sylius/blob/2.3/.github/workflows/upmerge_pr.yaml).
**Remember!** The upmerge should always be merged with using `Merge pull request` button.
In case of conflicts, please resolve them manually with usign the following commands:
`... | 1c207a8901983b45aa6044a5becc1a44c1f1ae58 | 7b87b755574027703bcd697b05f9297fadbd036c | [
"src/Sylius/Bundle/ApiBundle/tests/Doctrine/ORM/Filter/ProductPriceOrderFilterTest.php",
"src/Sylius/Bundle/ApiBundle/tests/Doctrine/ORM/Filter/TranslationOrderNameAndLocaleFilterTest.php",
"src/Sylius/Bundle/ApiBundle/tests/Validator/Constraints/OrderProductEligibilityValidatorTest.php",
"src/Sylius/Bundle/C... | [] | diff --git a/src/Sylius/Bundle/ApiBundle/Tests/Doctrine/ORM/Filter/ProductPriceOrderFilterTest.php b/src/Sylius/Bundle/ApiBundle/tests/Doctrine/ORM/Filter/ProductPriceOrderFilterTest.php
similarity index 98%
rename from src/Sylius/Bundle/ApiBundle/Tests/Doctrine/ORM/Filter/ProductPriceOrderFilterTest.php
rename to src/... | true | ||
Sylius/Sylius | 18,974 | issue_to_patch | Unify Tests directory with tests | | Q | A
|-----------------|-----
| Branch? | 2.1 <!-- see the comment below -->
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| License | MIT
<!--
- Bug fixes must be submitted against the 1.14 or 2.1 branch
- Features and deprecations must be submitted... | 2731b50fbc82dc5dd01fec657a4eeab5dbf72e32 | a46c8f031dbeb1645e7799081ee43bff11f96ca4 | [
"src/Sylius/Bundle/ApiBundle/tests/Doctrine/ORM/Filter/ProductPriceOrderFilterTest.php",
"src/Sylius/Bundle/ApiBundle/tests/Doctrine/ORM/Filter/TranslationOrderNameAndLocaleFilterTest.php",
"src/Sylius/Bundle/ApiBundle/tests/Validator/Constraints/OrderProductEligibilityValidatorTest.php",
"src/Sylius/Bundle/C... | [] | diff --git a/src/Sylius/Bundle/ApiBundle/Tests/Doctrine/ORM/Filter/ProductPriceOrderFilterTest.php b/src/Sylius/Bundle/ApiBundle/tests/Doctrine/ORM/Filter/ProductPriceOrderFilterTest.php
similarity index 98%
rename from src/Sylius/Bundle/ApiBundle/Tests/Doctrine/ORM/Filter/ProductPriceOrderFilterTest.php
rename to src/... | true | ||
Sylius/Sylius | 18,973 | issue_to_patch | [UPMERGE] 2.1 -> 2.2 | This PR has been generated automatically.
For more details see [upmerge_pr.yaml](/Sylius/Sylius/blob/2.3/.github/workflows/upmerge_pr.yaml).
**Remember!** The upmerge should always be merged with using `Merge pull request` button.
In case of conflicts, please resolve them manually with usign the following commands:
`... | c112bfffb51081f3d14ac60e3ad703ef9a9db483 | 2731b50fbc82dc5dd01fec657a4eeab5dbf72e32 | diff --git a/config/routes.yaml b/config/routes.yaml
index e69de29bb2d..7963d9b08f4 100644
--- a/config/routes.yaml
+++ b/config/routes.yaml
@@ -0,0 +1,23 @@
+admin_basic_create:
+ path: /admin/basic/create
+ controller: Symfony\Bundle\FrameworkBundle\Controller\TemplateController
+ defaults:
+ template... | [
"config/routes.yaml",
"features/shop/checkout/skipping_payment_method_step_when_only_one_payment_method_is_available.feature",
"src/Sylius/Behat/Context/Api/Shop/CheckoutContext.php",
"src/Sylius/Behat/Context/Setup/PaymentContext.php",
"src/Sylius/Behat/Context/Ui/Shop/Checkout/CheckoutCompleteContext.php"... | [] | diff --git a/src/Sylius/Bundle/CoreBundle/tests/EventListener/Workflow/OrderCheckout/BlockSelectPaymentFromPaymentSkippedListenerTest.php b/src/Sylius/Bundle/CoreBundle/tests/EventListener/Workflow/OrderCheckout/BlockSelectPaymentFromPaymentSkippedListenerTest.php
new file mode 100644
index 00000000000..06b33e7a622
---... | true | |
Sylius/Sylius | 18,972 | issue_to_patch | Fix admin templates | | Q | A
|-----------------|-----
| Branch? | 2.1
| Bug fix? |yes
| New feature? | nos
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
Apply the fixes we did on Sylius stack:
- https://github.com/Sylius/Stack/pull/358
- https://githu... | baf1e9ca5d7b52d8b03cb6b86ac0f3d0fb1f7979 | 98ebb3fa8e15406201770715e2d70e70e2240520 | diff --git a/config/routes.yaml b/config/routes.yaml
index e69de29bb2d..7963d9b08f4 100644
--- a/config/routes.yaml
+++ b/config/routes.yaml
@@ -0,0 +1,23 @@
+admin_basic_create:
+ path: /admin/basic/create
+ controller: Symfony\Bundle\FrameworkBundle\Controller\TemplateController
+ defaults:
+ template... | [
"config/routes.yaml",
"src/Sylius/Bundle/AdminBundle/templates/shared/components/delete_modal.html.twig",
"src/Sylius/Bundle/AdminBundle/templates/shared/crud/common/content/form.html.twig",
"src/Sylius/Bundle/AdminBundle/templates/shared/crud/common/content/header/title_block/actions.html.twig",
"src/Syliu... | [
{
"comment": "When we have this simpler code:\n`{% set resource = hookable_metadata.context.resource|default(null) %}`\n\nAnd when the resource is invalid (validation failed), the resource var is null...\nThat small change fixed the CI.",
"path": "src/Sylius/Bundle/AdminBundle/templates/shared/crud/update/c... | diff --git a/tests/Functional/AdminBasicRouteTests.php b/tests/Functional/AdminBasicRouteTests.php
new file mode 100644
index 00000000000..06be7aaea4c
--- /dev/null
+++ b/tests/Functional/AdminBasicRouteTests.php
@@ -0,0 +1,89 @@
+<?php
+
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Sylius Sp. z o.o.
+ ... | true | |
Sylius/Sylius | 18,970 | issue_to_patch | Add email validation constraints to cart update | | Q | A
|-----------------|-----
| Branch? | 2.1
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | #18967
| License | MIT
| 82ef275a96aa2a1447dee11d733ac8aec90bc697 | 8a3ab3c62e12d48986be79df51601effd18aeeef | diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/validation/UpdateCart.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/validation/UpdateCart.xml
index 238c93027a4..cf77a2bb44a 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/validation/UpdateCart.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/conf... | [
"src/Sylius/Bundle/ApiBundle/Resources/config/validation/UpdateCart.xml",
"tests/Api/Shop/Checkout/CartTest.php"
] | [
{
"comment": "Lets add a test for this case, might be contract test or behat 🤔 ",
"path": "src/Sylius/Bundle/ApiBundle/Resources/config/validation/UpdateCart.xml",
"hunk": "@@ -28,6 +28,22 @@\n <constraint name=\"Sylius\\Bundle\\ApiBundle\\Validator\\Constraints\\UpdateCartEmailNotAllowed\">\n ... | diff --git a/tests/Api/Shop/Checkout/CartTest.php b/tests/Api/Shop/Checkout/CartTest.php
index 7c2d71e8240..3058beb6c89 100644
--- a/tests/Api/Shop/Checkout/CartTest.php
+++ b/tests/Api/Shop/Checkout/CartTest.php
@@ -499,6 +499,67 @@ public function it_does_not_allow_to_change_email_as_a_shop_user(): void
);
... | true | |
Sylius/Sylius | 18,970 | comment_to_fix | Add email validation constraints to cart update | Lets add a test for this case, might be contract test or behat 🤔 | 82ef275a96aa2a1447dee11d733ac8aec90bc697 | 8a3ab3c62e12d48986be79df51601effd18aeeef | diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/validation/UpdateCart.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/validation/UpdateCart.xml
index 238c93027a4..cf77a2bb44a 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/validation/UpdateCart.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/conf... | [
"src/Sylius/Bundle/ApiBundle/Resources/config/validation/UpdateCart.xml"
] | [
{
"comment": "Lets add a test for this case, might be contract test or behat 🤔 ",
"path": "src/Sylius/Bundle/ApiBundle/Resources/config/validation/UpdateCart.xml",
"hunk": "@@ -28,6 +28,22 @@\n <constraint name=\"Sylius\\Bundle\\ApiBundle\\Validator\\Constraints\\UpdateCartEmailNotAllowed\">\n ... | true | ||
Sylius/Sylius | 18,969 | issue_to_patch | Add missing status code mapping for OrderItemNotFoundException | | Q | A
|-----------------|-----
| Branch? | 2.1
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? |
| Related tickets | #18787
| License | MIT
| 82ef275a96aa2a1447dee11d733ac8aec90bc697 | bd194744e8789c94e802668f4cf3bdef47352d8e | diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/app/config.yaml b/src/Sylius/Bundle/ApiBundle/Resources/config/app/config.yaml
index 8fdd2ce318c..49c7f2fa0a1 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/app/config.yaml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/app/config.yaml
@@ -60,6 +6... | [
"src/Sylius/Bundle/ApiBundle/Resources/config/app/config.yaml"
] | [] | true | ||
Sylius/Sylius | 18,965 | issue_to_patch | Allow choosing different payment method with skip payment step when it gets disabled | | Q | A
|-----------------|-----
| Branch? | 2.1 <!-- see the comment below -->
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Related tickets | fixes #11678
| License | MIT
<!--
- Bug fixes must be submitted against the 1.14 or 2.1 branch
- Features ... | 82ef275a96aa2a1447dee11d733ac8aec90bc697 | e66addc9ce10ac40cbde2eebe11c57453bd7e6b7 | diff --git a/features/shop/checkout/skipping_payment_method_step_when_only_one_payment_method_is_available.feature b/features/shop/checkout/skipping_payment_method_step_when_only_one_payment_method_is_available.feature
index 5ba39e40f93..83ec67571d1 100644
--- a/features/shop/checkout/skipping_payment_method_step_when_... | [
"features/shop/checkout/skipping_payment_method_step_when_only_one_payment_method_is_available.feature",
"src/Sylius/Behat/Context/Api/Shop/CheckoutContext.php",
"src/Sylius/Behat/Context/Setup/PaymentContext.php",
"src/Sylius/Behat/Context/Ui/Shop/Checkout/CheckoutCompleteContext.php",
"src/Sylius/Bundle/C... | [
{
"comment": "When > Then > When > Then 😢 ",
"path": "features/shop/checkout/skipping_payment_method_step_when_only_one_payment_method_is_available.feature",
"hunk": "@@ -45,3 +45,35 @@ Feature: Skipping payment step when only one payment method is available\n When I complete addressing step wi... | diff --git a/src/Sylius/Bundle/CoreBundle/tests/EventListener/Workflow/OrderCheckout/BlockSelectPaymentFromPaymentSkippedListenerTest.php b/src/Sylius/Bundle/CoreBundle/tests/EventListener/Workflow/OrderCheckout/BlockSelectPaymentFromPaymentSkippedListenerTest.php
new file mode 100644
index 00000000000..06b33e7a622
---... | true | |
Sylius/Sylius | 18,965 | comment_to_fix | Allow choosing different payment method with skip payment step when it gets disabled | ```suggestion
/**
* @Given the payment method :paymentMethod is enabled
* @Given the payment method :paymentMethod gets enabled
*/
```
and use attributes for new steps | 82ef275a96aa2a1447dee11d733ac8aec90bc697 | e66addc9ce10ac40cbde2eebe11c57453bd7e6b7 | diff --git a/src/Sylius/Behat/Context/Setup/PaymentContext.php b/src/Sylius/Behat/Context/Setup/PaymentContext.php
index 15e07fe9bc4..6df592c6d14 100644
--- a/src/Sylius/Behat/Context/Setup/PaymentContext.php
+++ b/src/Sylius/Behat/Context/Setup/PaymentContext.php
@@ -123,6 +123,15 @@ public function theStoreHasAPaymen... | [
"src/Sylius/Behat/Context/Setup/PaymentContext.php"
] | [
{
"comment": "```suggestion\n /**\n * @Given the payment method :paymentMethod is enabled\n * @Given the payment method :paymentMethod gets enabled\n */\n```\nand use attributes for new steps",
"path": "src/Sylius/Behat/Context/Setup/PaymentContext.php",
"hunk": "@@ -123,6 +123,17 @@ publ... | true | ||
Sylius/Sylius | 18,965 | comment_to_fix | Allow choosing different payment method with skip payment step when it gets disabled | Missing unit test for this listener | 82ef275a96aa2a1447dee11d733ac8aec90bc697 | e66addc9ce10ac40cbde2eebe11c57453bd7e6b7 | diff --git a/src/Sylius/Bundle/CoreBundle/EventListener/Workflow/OrderCheckout/BlockSelectPaymentFromPaymentSkippedListener.php b/src/Sylius/Bundle/CoreBundle/EventListener/Workflow/OrderCheckout/BlockSelectPaymentFromPaymentSkippedListener.php
new file mode 100644
index 00000000000..90232471a61
--- /dev/null
+++ b/src... | [
"src/Sylius/Bundle/CoreBundle/EventListener/Workflow/OrderCheckout/BlockSelectPaymentFromPaymentSkippedListener.php"
] | [
{
"comment": "Missing unit test for this listener",
"path": "src/Sylius/Bundle/CoreBundle/EventListener/Workflow/OrderCheckout/BlockSelectPaymentFromPaymentSkippedListener.php",
"hunk": "@@ -0,0 +1,41 @@\n+<?php\n+\n+/*\n+ * This file is part of the Sylius package.\n+ *\n+ * (c) Sylius Sp. z o.o.\n+ *\n... | true | ||
Sylius/Sylius | 18,965 | comment_to_fix | Allow choosing different payment method with skip payment step when it gets disabled | If I’m not mistaken, this method is public because of Winzou; I wonder if it wouldn’t be better to move this check to a separate service, mainly for customisation purposes 🤔 | 82ef275a96aa2a1447dee11d733ac8aec90bc697 | e66addc9ce10ac40cbde2eebe11c57453bd7e6b7 | diff --git a/src/Sylius/Bundle/CoreBundle/EventListener/Workflow/OrderCheckout/BlockSelectPaymentFromPaymentSkippedListener.php b/src/Sylius/Bundle/CoreBundle/EventListener/Workflow/OrderCheckout/BlockSelectPaymentFromPaymentSkippedListener.php
new file mode 100644
index 00000000000..90232471a61
--- /dev/null
+++ b/src... | [
"src/Sylius/Bundle/CoreBundle/EventListener/Workflow/OrderCheckout/BlockSelectPaymentFromPaymentSkippedListener.php"
] | [
{
"comment": "If I’m not mistaken, this method is public because of Winzou; I wonder if it wouldn’t be better to move this check to a separate service, mainly for customisation purposes 🤔 ",
"path": "src/Sylius/Bundle/CoreBundle/EventListener/Workflow/OrderCheckout/BlockSelectPaymentFromPaymentSkippedListe... | true | ||
Sylius/Sylius | 18,921 | issue_to_patch | [Promotion] Add version locking to promotions and coupons | | Q | A
|-----------------|-----
| Branch? | 2.3
| Bug fix? | kinda
| New feature? | kinda
| BC breaks? | no
| Deprecations? | no
| Related tickets | -
| License | MIT
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeR... | 385a5e501fa2c535744271f4383fbc0eb229698e | 23792769f692a6006391165cf4c85042a556ac23 | diff --git a/src/Sylius/Bundle/CoreBundle/Doctrine/ORM/Promotion/Modifier/AtomicOrderPromotionsUsageModifier.php b/src/Sylius/Bundle/CoreBundle/Doctrine/ORM/Promotion/Modifier/AtomicOrderPromotionsUsageModifier.php
index 5d6eb06eb56..cc5ea664af7 100644
--- a/src/Sylius/Bundle/CoreBundle/Doctrine/ORM/Promotion/Modifier/... | [
"src/Sylius/Bundle/CoreBundle/Doctrine/ORM/Promotion/Modifier/AtomicOrderPromotionsUsageModifier.php",
"src/Sylius/Bundle/CoreBundle/Migrations/Version20260216120000.php",
"src/Sylius/Bundle/CoreBundle/Migrations/Version20260216120001.php",
"src/Sylius/Bundle/CoreBundle/Resources/config/doctrine/model/Promoti... | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Verify the mismatch between promotion collection element type and refreshAndLock signature.\n\nrg -n -C3 'function getPromotions\\s*\\(' src/Sylius/Component/C... | diff --git a/src/Sylius/Bundle/CoreBundle/tests/Doctrine/ORM/Promotion/Modifier/AtomicOrderPromotionsUsageModifierTest.php b/src/Sylius/Bundle/CoreBundle/tests/Doctrine/ORM/Promotion/Modifier/AtomicOrderPromotionsUsageModifierTest.php
new file mode 100644
index 00000000000..53fc890c757
--- /dev/null
+++ b/src/Sylius/Bu... | true | |
Sylius/Sylius | 18,921 | comment_to_fix | [Promotion] Add version locking to promotions and coupons | _⚠️ Potential issue_ | _🔴 Critical_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Verify the mismatch between promotion collection element type and refreshAndLock signature.
rg -n -C3 'function getPromotions\s*\(' src/Sylius/Component/Core/Model/OrderInterface.php
rg -n ... | 385a5e501fa2c535744271f4383fbc0eb229698e | 23792769f692a6006391165cf4c85042a556ac23 | diff --git a/src/Sylius/Bundle/CoreBundle/Doctrine/ORM/Promotion/Modifier/AtomicOrderPromotionsUsageModifier.php b/src/Sylius/Bundle/CoreBundle/Doctrine/ORM/Promotion/Modifier/AtomicOrderPromotionsUsageModifier.php
index 5d6eb06eb56..cc5ea664af7 100644
--- a/src/Sylius/Bundle/CoreBundle/Doctrine/ORM/Promotion/Modifier/... | [
"src/Sylius/Bundle/CoreBundle/Doctrine/ORM/Promotion/Modifier/AtomicOrderPromotionsUsageModifier.php"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Verify the mismatch between promotion collection element type and refreshAndLock signature.\n\nrg -n -C3 'function getPromotions\\s*\\(' src/Sylius/Component/C... | true | ||
Sylius/Sylius | 18,921 | comment_to_fix | [Promotion] Add version locking to promotions and coupons | _🛠️ Refactor suggestion_ | _🟠 Major_
**Add a native type to `$version` (currently untyped).**
Please type the property explicitly to match the accessor contract and avoid mixed runtime state.
<details>
<summary>Proposed fix</summary>
```diff
- /** `@var` int */
- protected $version = 1;
+ protected ?int... | 385a5e501fa2c535744271f4383fbc0eb229698e | 23792769f692a6006391165cf4c85042a556ac23 | diff --git a/src/Sylius/Component/Core/Model/PromotionCoupon.php b/src/Sylius/Component/Core/Model/PromotionCoupon.php
index 661655f677b..c29f716fe4a 100644
--- a/src/Sylius/Component/Core/Model/PromotionCoupon.php
+++ b/src/Sylius/Component/Core/Model/PromotionCoupon.php
@@ -17,6 +17,9 @@
class PromotionCoupon exte... | [
"src/Sylius/Component/Core/Model/PromotionCoupon.php"
] | [
{
"comment": "_🛠️ Refactor suggestion_ | _🟠 Major_\n\n**Add a native type to `$version` (currently untyped).**\n\nPlease type the property explicitly to match the accessor contract and avoid mixed runtime state.\n\n\n<details>\n<summary>Proposed fix</summary>\n\n```diff\n- /** `@var` int */\n- protected... | true | ||
Sylius/Sylius | 18,921 | comment_to_fix | [Promotion] Add version locking to promotions and coupons | _⚠️ Potential issue_ | _🟠 Major_
**This public interface change can break external implementations.**
Adding `VersionedInterface` to `PromotionCouponInterface` forces all third-party implementers to add version methods. Please either treat this as an explicit BC break (with release note) or introduce a deprecation p... | 385a5e501fa2c535744271f4383fbc0eb229698e | 23792769f692a6006391165cf4c85042a556ac23 | diff --git a/src/Sylius/Component/Core/Model/PromotionCouponInterface.php b/src/Sylius/Component/Core/Model/PromotionCouponInterface.php
index 4bb34efad94..2464262a6c9 100644
--- a/src/Sylius/Component/Core/Model/PromotionCouponInterface.php
+++ b/src/Sylius/Component/Core/Model/PromotionCouponInterface.php
@@ -14,8 +1... | [
"src/Sylius/Component/Core/Model/PromotionCouponInterface.php"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**This public interface change can break external implementations.**\n\nAdding `VersionedInterface` to `PromotionCouponInterface` forces all third-party implementers to add version methods. Please either treat this as an explicit BC break (with release note) or... | true | ||
Sylius/Sylius | 18,968 | issue_to_patch | [UPMERGE] 2.1 -> 2.2 | This PR has been generated automatically.
For more details see [upmerge_pr.yaml](/Sylius/Sylius/blob/2.3/.github/workflows/upmerge_pr.yaml).
**Remember!** The upmerge should always be merged with using `Merge pull request` button.
In case of conflicts, please resolve them manually with usign the following commands:
`... | 37d3ce70e8b02d7a28a2df5a679e0d54c97fe93e | 82ef275a96aa2a1447dee11d733ac8aec90bc697 | diff --git a/UPGRADE-2.1.md b/UPGRADE-2.1.md
index f4c1636dfcf..e98e6f35b27 100644
--- a/UPGRADE-2.1.md
+++ b/UPGRADE-2.1.md
@@ -1,5 +1,47 @@
# UPGRADE FROM `2.1.13` TO `2.1.14`
+### Admin resource translations
+
+Translations for admin-managed resources (such as product options, attributes, associations) are now re... | [
"UPGRADE-2.1.md",
"src/Sylius/Bundle/AdminBundle/Resources/config/grids/inventory.yml",
"src/Sylius/Bundle/AdminBundle/Resources/config/grids/payment_method.yml",
"src/Sylius/Bundle/AdminBundle/Resources/config/grids/product_association_type.yml",
"src/Sylius/Bundle/AdminBundle/Resources/config/grids/produc... | [] | true | ||
Sylius/Sylius | 18,922 | issue_to_patch | Unified name translations handling in admin grid index | | Q | A
|-----------------|-----
| Branch? | 2.1
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | fixes #17924
| License | MIT
<!--
- Bug fixes must be submitted against the 1.14 or 2.1 branch
- Features and dep... | 69c2aa78a6922c40be957c6523fbfdcff636261e | e804eb302674b0410470fe142a5d96855232ad96 | diff --git a/UPGRADE-2.1.md b/UPGRADE-2.1.md
index f152e968ddc..e98e6f35b27 100644
--- a/UPGRADE-2.1.md
+++ b/UPGRADE-2.1.md
@@ -1,5 +1,41 @@
# UPGRADE FROM `2.1.13` TO `2.1.14`
+### Admin resource translations
+
+Translations for admin-managed resources (such as product options, attributes, associations) are now re... | [
"UPGRADE-2.1.md",
"src/Sylius/Bundle/AdminBundle/Resources/config/grids/inventory.yml",
"src/Sylius/Bundle/AdminBundle/Resources/config/grids/payment_method.yml",
"src/Sylius/Bundle/AdminBundle/Resources/config/grids/product_association_type.yml",
"src/Sylius/Bundle/AdminBundle/Resources/config/grids/produc... | [
{
"comment": "All of these changes should be mentioned in the upgrade file",
"path": "src/Sylius/Bundle/AdminBundle/Resources/config/grids/payment_method.yml",
"hunk": "@@ -7,7 +7,7 @@ sylius_grid:\n class: \"%sylius.model.payment_method.class%\"\n repository:\n ... | true | ||
Sylius/Sylius | 18,900 | issue_to_patch | [CS][DX] Refactor | This PR has been generated automatically.
For more details see [refactor.yaml](/Sylius/Sylius/blob/2.1/.github/workflows/refactor.yaml). | 4facda433e48721b400a52dcadfc27da88da6853 | 4c451085f175369343156236ceab58f1fd9daa71 | [
"src/Sylius/Bundle/AdminBundle/Tests/Controller/NotificationControllerTest.php"
] | [] | diff --git a/src/Sylius/Bundle/AdminBundle/Tests/Controller/NotificationControllerTest.php b/src/Sylius/Bundle/AdminBundle/Tests/Controller/NotificationControllerTest.php
index b7f1074eff0..cd9e1fc0a35 100644
--- a/src/Sylius/Bundle/AdminBundle/Tests/Controller/NotificationControllerTest.php
+++ b/src/Sylius/Bundle/Adm... | true | ||
Sylius/Sylius | 18,940 | issue_to_patch | Restore missing page titles for admin resource show pages | | Q | A
|-----------------|-----
| Branch? | 1.14, 2.0 or 2.1 <!-- see the comment below -->
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | fixes #18934
| License | MIT
| d570c626b584498731ab5453cad00444957bbce2 | 5c0e79ff9ddb42fb3f668e36ca7302e036bec08e | diff --git a/UPGRADE-2.1.md b/UPGRADE-2.1.md
index f4c1636dfcf..f152e968ddc 100644
--- a/UPGRADE-2.1.md
+++ b/UPGRADE-2.1.md
@@ -1,5 +1,11 @@
# UPGRADE FROM `2.1.13` TO `2.1.14`
+### Restore missing admin resource show title
+
+A missing page title has been restored to the admin resource show pages (e.g. product, or... | [
"UPGRADE-2.1.md",
"src/Sylius/Bundle/AdminBundle/Resources/config/routing/catalog_promotion.yaml",
"src/Sylius/Bundle/AdminBundle/Resources/config/routing/customer.yml",
"src/Sylius/Bundle/AdminBundle/Resources/config/routing/order.yml",
"src/Sylius/Bundle/AdminBundle/Resources/config/routing/product.yml",
... | [] | true | ||
Sylius/Sylius | 18,947 | issue_to_patch | Remove usage of `behat/transliterator`
### Sylius version(s) affected
2.*
### Description
The package `behat/transliterator` is abandoned.
> Package behat/transliterator is abandoned, you should avoid using it. No replacement was suggested.
### How to reproduce
Install a fresh Sylius-standard and this warning wi... | Replace behat/transliterator with symfony/string | | Q | A
|-----------------|-----
| Branch? | 2.3
| Bug fix? | no
| New feature? | no
| BC breaks? | yes
| Deprecations? | no
| Related tickets | fixes #18944
| License | MIT
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary... | eaf5d3e8b819757f676ccb7ef8a9f49259190e7d | 66318fa388952257fe996d80a9e7f97bbea5d6d4 | diff --git a/UPGRADE-2.3.md b/UPGRADE-2.3.md
index 18c4cde7a33..3375fe28daf 100644
--- a/UPGRADE-2.3.md
+++ b/UPGRADE-2.3.md
@@ -2,7 +2,47 @@
## Dependencies
-1. The `knplabs/gaufrette` and `knplabs/knp-gaufrette-bundle` packages have been removed.
+1. The `behat/transliterator` package has been **deprecated** and... | [
"UPGRADE-2.3.md",
"src/Sylius/Behat/Context/Ui/Admin/ProductCreationContext.php",
"src/Sylius/Behat/Resources/config/services/contexts/ui/admin.php",
"src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php",
"src/Sylius/Bundle/AdminBundle/Resources/config/services.php",
"src/Sylius/Bundle/AdminBun... | [
{
"comment": "Is this still required ?",
"path": "src/Sylius/Component/Product/Generator/SlugGenerator.php",
"hunk": "@@ -13,15 +13,19 @@\n \n namespace Sylius\\Component\\Product\\Generator;\n \n-use Behat\\Transliterator\\Transliterator;\n+use Symfony\\Component\\String\\Slugger\\SluggerInterface;\n \... | diff --git a/src/Sylius/Bundle/AdminBundle/tests/Generator/TaxonSlugGeneratorTest.php b/src/Sylius/Bundle/AdminBundle/tests/Generator/TaxonSlugGeneratorTest.php
index 90a4cb4d5e7..37d0767c226 100644
--- a/src/Sylius/Bundle/AdminBundle/tests/Generator/TaxonSlugGeneratorTest.php
+++ b/src/Sylius/Bundle/AdminBundle/tests/... | true |
Sylius/Sylius | 18,947 | comment_to_fix | Replace behat/transliterator with symfony/string | Is this still required ? | eaf5d3e8b819757f676ccb7ef8a9f49259190e7d | 66318fa388952257fe996d80a9e7f97bbea5d6d4 | diff --git a/src/Sylius/Component/Product/Generator/SlugGenerator.php b/src/Sylius/Component/Product/Generator/SlugGenerator.php
index f99035564d5..82f122a1981 100644
--- a/src/Sylius/Component/Product/Generator/SlugGenerator.php
+++ b/src/Sylius/Component/Product/Generator/SlugGenerator.php
@@ -14,11 +14,29 @@
namesp... | [
"src/Sylius/Component/Product/Generator/SlugGenerator.php"
] | [
{
"comment": "Is this still required ?",
"path": "src/Sylius/Component/Product/Generator/SlugGenerator.php",
"hunk": "@@ -13,15 +13,19 @@\n \n namespace Sylius\\Component\\Product\\Generator;\n \n-use Behat\\Transliterator\\Transliterator;\n+use Symfony\\Component\\String\\Slugger\\SluggerInterface;\n \... | true | ||
Sylius/Sylius | 18,947 | comment_to_fix | Replace behat/transliterator with symfony/string | Is the `str_replace` still required ? | eaf5d3e8b819757f676ccb7ef8a9f49259190e7d | 66318fa388952257fe996d80a9e7f97bbea5d6d4 | diff --git a/src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php b/src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php
index d181fb7d775..c7e8a5d5b9f 100644
--- a/src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php
+++ b/src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php
@@ ... | [
"src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php"
] | [
{
"comment": "Is the `str_replace` still required ?",
"path": "src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php",
"hunk": "@@ -38,7 +40,6 @@ public function generate(string $name, string $localeCode, ?TaxonInterface $pare\n \n private function transliterate(string $string): string\n ... | true | ||
Sylius/Sylius | 18,947 | comment_to_fix | Replace behat/transliterator with symfony/string | Is the `str_replace` still required ? | eaf5d3e8b819757f676ccb7ef8a9f49259190e7d | 66318fa388952257fe996d80a9e7f97bbea5d6d4 | diff --git a/src/Sylius/Component/Taxonomy/Generator/TaxonSlugGenerator.php b/src/Sylius/Component/Taxonomy/Generator/TaxonSlugGenerator.php
index a90b7955dbf..0beab20ae41 100644
--- a/src/Sylius/Component/Taxonomy/Generator/TaxonSlugGenerator.php
+++ b/src/Sylius/Component/Taxonomy/Generator/TaxonSlugGenerator.php
@@ ... | [
"src/Sylius/Component/Taxonomy/Generator/TaxonSlugGenerator.php"
] | [
{
"comment": "Is the `str_replace` still required ?",
"path": "src/Sylius/Component/Taxonomy/Generator/TaxonSlugGenerator.php",
"hunk": "@@ -39,7 +43,6 @@ public function generate(TaxonInterface $taxon, ?string $locale = null): string\n \n private function transliterate(string $string): string\n ... | true | ||
Sylius/Sylius | 18,947 | comment_to_fix | Replace behat/transliterator with symfony/string | _⚠️ Potential issue_ | _🔴 Critical_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Search for all usages of StringInflector::nameToSlug in the codebase
echo "=== Searching for nameToSlug method calls ==="
rg -n 'nameToSlug' --type php
echo ""
echo "=== Checking if the me... | eaf5d3e8b819757f676ccb7ef8a9f49259190e7d | 66318fa388952257fe996d80a9e7f97bbea5d6d4 | diff --git a/UPGRADE-2.3.md b/UPGRADE-2.3.md
index 18c4cde7a33..3375fe28daf 100644
--- a/UPGRADE-2.3.md
+++ b/UPGRADE-2.3.md
@@ -2,7 +2,47 @@
## Dependencies
-1. The `knplabs/gaufrette` and `knplabs/knp-gaufrette-bundle` packages have been removed.
+1. The `behat/transliterator` package has been **deprecated** and... | [
"UPGRADE-2.3.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Search for all usages of StringInflector::nameToSlug in the codebase\n\necho \"=== Searching for nameToSlug method calls ===\"\nrg -n 'nameToSlug' --type php\n... | true | ||
Sylius/Sylius | 18,947 | comment_to_fix | Replace behat/transliterator with symfony/string | Shouldn't be nullable? | eaf5d3e8b819757f676ccb7ef8a9f49259190e7d | 66318fa388952257fe996d80a9e7f97bbea5d6d4 | diff --git a/src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php b/src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php
index d181fb7d775..c7e8a5d5b9f 100644
--- a/src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php
+++ b/src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php
@@ ... | [
"src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php"
] | [
{
"comment": "Shouldn't be nullable?",
"path": "src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php",
"hunk": "@@ -13,14 +13,16 @@\n \n namespace Sylius\\Bundle\\AdminBundle\\Generator;\n \n-use Behat\\Transliterator\\Transliterator;\n use Sylius\\Component\\Core\\Model\\TaxonInterface;\n use... | true | ||
Sylius/Sylius | 18,947 | comment_to_fix | Replace behat/transliterator with symfony/string | _⚠️ Potential issue_ | _🟡 Minor_
**Clarify contradictory language about slug generation.**
Line 7 states "All slug generation now uses `symfony/string`" but line 8 immediately says `behat/transliterator` "is still used as a fallback". This creates confusion about whether the old package is actually removed or still ... | eaf5d3e8b819757f676ccb7ef8a9f49259190e7d | 66318fa388952257fe996d80a9e7f97bbea5d6d4 | diff --git a/UPGRADE-2.3.md b/UPGRADE-2.3.md
index 18c4cde7a33..3375fe28daf 100644
--- a/UPGRADE-2.3.md
+++ b/UPGRADE-2.3.md
@@ -2,7 +2,47 @@
## Dependencies
-1. The `knplabs/gaufrette` and `knplabs/knp-gaufrette-bundle` packages have been removed.
+1. The `behat/transliterator` package has been **deprecated** and... | [
"UPGRADE-2.3.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Clarify contradictory language about slug generation.**\n\nLine 7 states \"All slug generation now uses `symfony/string`\" but line 8 immediately says `behat/transliterator` \"is still used as a fallback\". This creates confusion about whether the old package... | true | ||
Sylius/Sylius | 18,947 | comment_to_fix | Replace behat/transliterator with symfony/string | ```suggestion
trigger_deprecation(
'sylius/admin-bundle',
'2.3',
'Not passing a "%s" to "%s" is deprecated and will be required in Sylius 3.0.',
SluggerInterface:class,
self::class,
);
```
[Example](https://github.c... | eaf5d3e8b819757f676ccb7ef8a9f49259190e7d | 66318fa388952257fe996d80a9e7f97bbea5d6d4 | diff --git a/src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php b/src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php
index d181fb7d775..c7e8a5d5b9f 100644
--- a/src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php
+++ b/src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php
@@ ... | [
"src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php"
] | [
{
"comment": "```suggestion\n trigger_deprecation(\n 'sylius/admin-bundle',\n '2.3',\n 'Not passing a \"%s\" to \"%s\" is deprecated and will be required in Sylius 3.0.',\n SluggerInterface:class,\n self::class,\n )... | true | ||
Sylius/Sylius | 18,947 | comment_to_fix | Replace behat/transliterator with symfony/string | ```suggestion
private ?SluggerInterface $slugger = null
``` | eaf5d3e8b819757f676ccb7ef8a9f49259190e7d | 66318fa388952257fe996d80a9e7f97bbea5d6d4 | diff --git a/src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php b/src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php
index d181fb7d775..c7e8a5d5b9f 100644
--- a/src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php
+++ b/src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php
@@ ... | [
"src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php"
] | [
{
"comment": "```suggestion\n private ?SluggerInterface $slugger = null\n```",
"path": "src/Sylius/Bundle/AdminBundle/Generator/TaxonSlugGenerator.php",
"hunk": "@@ -16,11 +16,22 @@\n use Behat\\Transliterator\\Transliterator;\n use Sylius\\Component\\Core\\Model\\TaxonInterface;\n use Sylius\\Co... | true | ||
Sylius/Sylius | 18,947 | comment_to_fix | Replace behat/transliterator with symfony/string | ```suggestion
* @deprecated This method will be removed in 3.0 - use Symfony\Component\String\Slugger\SluggerInterface::slug() instead
```
https://github.com/Sylius/Sylius/blob/1.14/src/Sylius/Bundle/OrderBundle/Controller/OrderController.php#L236-L238 as a example | eaf5d3e8b819757f676ccb7ef8a9f49259190e7d | 66318fa388952257fe996d80a9e7f97bbea5d6d4 | diff --git a/src/Sylius/Component/Core/Formatter/StringInflector.php b/src/Sylius/Component/Core/Formatter/StringInflector.php
index e91a95d0e3a..b5103d628da 100644
--- a/src/Sylius/Component/Core/Formatter/StringInflector.php
+++ b/src/Sylius/Component/Core/Formatter/StringInflector.php
@@ -35,6 +35,9 @@ public static... | [
"src/Sylius/Component/Core/Formatter/StringInflector.php"
] | [
{
"comment": "```suggestion\n * @deprecated This method will be removed in 3.0 - use Symfony\\Component\\String\\Slugger\\SluggerInterface::slug() instead\n```\nhttps://github.com/Sylius/Sylius/blob/1.14/src/Sylius/Bundle/OrderBundle/Controller/OrderController.php#L236-L238 as a example",
"path": "src/S... | true | ||
Sylius/Sylius | 18,947 | comment_to_fix | Replace behat/transliterator with symfony/string | same like above | eaf5d3e8b819757f676ccb7ef8a9f49259190e7d | 66318fa388952257fe996d80a9e7f97bbea5d6d4 | diff --git a/src/Sylius/Component/Product/Generator/SlugGenerator.php b/src/Sylius/Component/Product/Generator/SlugGenerator.php
index f99035564d5..82f122a1981 100644
--- a/src/Sylius/Component/Product/Generator/SlugGenerator.php
+++ b/src/Sylius/Component/Product/Generator/SlugGenerator.php
@@ -14,11 +14,29 @@
namesp... | [
"src/Sylius/Component/Product/Generator/SlugGenerator.php"
] | [
{
"comment": "same like above",
"path": "src/Sylius/Component/Product/Generator/SlugGenerator.php",
"hunk": "@@ -14,11 +14,28 @@\n namespace Sylius\\Component\\Product\\Generator;\n \n use Behat\\Transliterator\\Transliterator;\n+use Symfony\\Component\\String\\Slugger\\SluggerInterface;\n \n final clas... | true | ||
Sylius/Sylius | 18,947 | comment_to_fix | Replace behat/transliterator with symfony/string | as above | eaf5d3e8b819757f676ccb7ef8a9f49259190e7d | 66318fa388952257fe996d80a9e7f97bbea5d6d4 | diff --git a/src/Sylius/Component/Taxonomy/Generator/TaxonSlugGenerator.php b/src/Sylius/Component/Taxonomy/Generator/TaxonSlugGenerator.php
index a90b7955dbf..0beab20ae41 100644
--- a/src/Sylius/Component/Taxonomy/Generator/TaxonSlugGenerator.php
+++ b/src/Sylius/Component/Taxonomy/Generator/TaxonSlugGenerator.php
@@ ... | [
"src/Sylius/Component/Taxonomy/Generator/TaxonSlugGenerator.php"
] | [
{
"comment": "as above",
"path": "src/Sylius/Component/Taxonomy/Generator/TaxonSlugGenerator.php",
"hunk": "@@ -15,10 +15,23 @@\n \n use Behat\\Transliterator\\Transliterator;\n use Sylius\\Component\\Taxonomy\\Model\\TaxonInterface;\n+use Symfony\\Component\\String\\Slugger\\SluggerInterface;\n use Web... | true | ||
Sylius/Sylius | 18,947 | comment_to_fix | Replace behat/transliterator with symfony/string | ```suggestion
'sylius/product',
``` | eaf5d3e8b819757f676ccb7ef8a9f49259190e7d | 66318fa388952257fe996d80a9e7f97bbea5d6d4 | diff --git a/src/Sylius/Component/Product/Generator/SlugGenerator.php b/src/Sylius/Component/Product/Generator/SlugGenerator.php
index f99035564d5..82f122a1981 100644
--- a/src/Sylius/Component/Product/Generator/SlugGenerator.php
+++ b/src/Sylius/Component/Product/Generator/SlugGenerator.php
@@ -14,11 +14,29 @@
namesp... | [
"src/Sylius/Component/Product/Generator/SlugGenerator.php"
] | [
{
"comment": "```suggestion\n 'sylius/product',\n```",
"path": "src/Sylius/Component/Product/Generator/SlugGenerator.php",
"hunk": "@@ -14,11 +14,29 @@\n namespace Sylius\\Component\\Product\\Generator;\n \n use Behat\\Transliterator\\Transliterator;\n+use Symfony\\Component\\String\\Slug... | true | ||
Sylius/Sylius | 18,947 | comment_to_fix | Replace behat/transliterator with symfony/string | ```suggestion
'sylius/taxonomy',
``` | eaf5d3e8b819757f676ccb7ef8a9f49259190e7d | 66318fa388952257fe996d80a9e7f97bbea5d6d4 | diff --git a/src/Sylius/Component/Taxonomy/Generator/TaxonSlugGenerator.php b/src/Sylius/Component/Taxonomy/Generator/TaxonSlugGenerator.php
index a90b7955dbf..0beab20ae41 100644
--- a/src/Sylius/Component/Taxonomy/Generator/TaxonSlugGenerator.php
+++ b/src/Sylius/Component/Taxonomy/Generator/TaxonSlugGenerator.php
@@ ... | [
"src/Sylius/Component/Taxonomy/Generator/TaxonSlugGenerator.php"
] | [
{
"comment": "```suggestion\n 'sylius/taxonomy',\n```",
"path": "src/Sylius/Component/Taxonomy/Generator/TaxonSlugGenerator.php",
"hunk": "@@ -15,10 +15,24 @@\n \n use Behat\\Transliterator\\Transliterator;\n use Sylius\\Component\\Taxonomy\\Model\\TaxonInterface;\n+use Symfony\\Component... | true | ||
Sylius/Sylius | 18,964 | issue_to_patch | [UPMERGE] 2.1 -> 2.2 | This PR has been generated automatically.
For more details see [upmerge_pr.yaml](/Sylius/Sylius/blob/2.3/.github/workflows/upmerge_pr.yaml).
**Remember!** The upmerge should always be merged with using `Merge pull request` button.
In case of conflicts, please resolve them manually with usign the following commands:
`... | 7d6918b1009db6cad1e96fb59310c6bc3b9002e0 | 3e62259af23ecd8cbcb31896b3c8744b6c6dad7c | diff --git a/src/Sylius/Bundle/ShopBundle/templates/shared/flashes.html.twig b/src/Sylius/Bundle/ShopBundle/templates/shared/flashes.html.twig
index 784e0c67ffe..06b3f4147b5 100644
--- a/src/Sylius/Bundle/ShopBundle/templates/shared/flashes.html.twig
+++ b/src/Sylius/Bundle/ShopBundle/templates/shared/flashes.html.twig... | [
"src/Sylius/Bundle/ShopBundle/templates/shared/flashes.html.twig"
] | [] | true | ||
Sylius/Sylius | 18,962 | issue_to_patch | Disable order by identifier by default | | Q | A
|-----------------|-----
| Branch? | 2.3
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | fixes #X, partially #Y, mentioned in #Z
| License | MIT
<!-- This is an auto-generated comment: release notes by code... | eaf5d3e8b819757f676ccb7ef8a9f49259190e7d | c813041a7970f20cf0327c710b289bbcff32b321 | diff --git a/UPGRADE-2.3.md b/UPGRADE-2.3.md
index 18c4cde7a33..d245ce4d9e2 100644
--- a/UPGRADE-2.3.md
+++ b/UPGRADE-2.3.md
@@ -1,5 +1,17 @@
# UPGRADE FROM `2.2` TO `2.3`
+## Configuration
+
+1. The default value of `sylius_core.order_by_identifier` has been changed from `true` to `false`. ([#18956](https://github.... | [
"UPGRADE-2.3.md",
"config/packages/test/_sylius.yaml",
"src/Sylius/Bundle/CoreBundle/DependencyInjection/Configuration.php",
"src/Sylius/Bundle/CoreBundle/tests/DependencyInjection/ConfigurationTest.php",
"src/Sylius/Bundle/CoreBundle/tests/DependencyInjection/SyliusCoreExtensionTest.php"
] | [] | diff --git a/config/packages/test/_sylius.yaml b/config/packages/test/_sylius.yaml
index c5a613a7d70..ac0a17b1476 100644
--- a/config/packages/test/_sylius.yaml
+++ b/config/packages/test/_sylius.yaml
@@ -25,3 +25,6 @@ sylius_payment:
encryption:
disabled_for_factories:
- online-disabled
+
+s... | true | |
Sylius/Sylius | 18,961 | issue_to_patch | Resolve flash alert correctly without breaking translation | | Q | A
|-----------------|-----
| Branch? | 2.1 <!-- see the comment below -->
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file -->
| License | MIT
<!--
- Bug fixes must be submitted ... | d570c626b584498731ab5453cad00444957bbce2 | 6da5daa0d709d2c7af7d52ea395fa869387c2d9f | diff --git a/src/Sylius/Bundle/ShopBundle/templates/shared/flashes.html.twig b/src/Sylius/Bundle/ShopBundle/templates/shared/flashes.html.twig
index 784e0c67ffe..06b3f4147b5 100644
--- a/src/Sylius/Bundle/ShopBundle/templates/shared/flashes.html.twig
+++ b/src/Sylius/Bundle/ShopBundle/templates/shared/flashes.html.twig... | [
"src/Sylius/Bundle/ShopBundle/templates/shared/flashes.html.twig"
] | [] | true | ||
Sylius/Sylius | 18,954 | issue_to_patch | [UPMERGE] 2.1 -> 2.2 | This PR has been generated automatically.
For more details see [upmerge_pr.yaml](/Sylius/Sylius/blob/2.3/.github/workflows/upmerge_pr.yaml).
**Remember!** The upmerge should always be merged with using `Merge pull request` button.
In case of conflicts, please resolve them manually with usign the following commands:
`... | fcbde944a068efbd06b4c7d531d8410c730957cf | d570c626b584498731ab5453cad00444957bbce2 | diff --git a/src/Sylius/Bundle/CoreBundle/Resources/config/services/mailer.xml b/src/Sylius/Bundle/CoreBundle/Resources/config/services/mailer.xml
index ab235c108b6..d1b85e017e4 100644
--- a/src/Sylius/Bundle/CoreBundle/Resources/config/services/mailer.xml
+++ b/src/Sylius/Bundle/CoreBundle/Resources/config/services/ma... | [
"src/Sylius/Bundle/CoreBundle/Resources/config/services/mailer.xml"
] | [] | true | ||
Sylius/Sylius | 18,948 | issue_to_patch | [UPMERGE] 2.3 -> symfony-8 | This PR has been generated automatically.
For more details see [upmerge_pr.yaml](/Sylius/Sylius/blob/2.3/.github/workflows/upmerge_pr.yaml).
**Remember!** The upmerge should always be merged with using `Merge pull request` button.
In case of conflicts, please resolve them manually with usign the following commands:
`... | 6098ae5bb5d50b43375d552e0e65d459b45a9041 | eaf5d3e8b819757f676ccb7ef8a9f49259190e7d | diff --git a/src/Sylius/Bundle/LocaleBundle/Context/RequestHeaderBasedLocaleContext.php b/src/Sylius/Bundle/LocaleBundle/Context/RequestHeaderBasedLocaleContext.php
index bd5b98a6ee5..fa9253d95ed 100644
--- a/src/Sylius/Bundle/LocaleBundle/Context/RequestHeaderBasedLocaleContext.php
+++ b/src/Sylius/Bundle/LocaleBundle... | [
"src/Sylius/Bundle/LocaleBundle/Context/RequestHeaderBasedLocaleContext.php",
"src/Sylius/Bundle/LocaleBundle/tests/Context/RequestHeaderBasedLocaleContextTest.php"
] | [] | diff --git a/src/Sylius/Bundle/LocaleBundle/tests/Context/RequestHeaderBasedLocaleContextTest.php b/src/Sylius/Bundle/LocaleBundle/tests/Context/RequestHeaderBasedLocaleContextTest.php
index 0689ab46d66..0359fdc6342 100644
--- a/src/Sylius/Bundle/LocaleBundle/tests/Context/RequestHeaderBasedLocaleContextTest.php
+++ b/... | true | |
TanStack/query | 10,927 | issue_to_patch | Next.js server action not getting executed
### Describe the bug
Please bear with me, because I have no idea how to best start. I've also done my best to narrow this down as much as possible, but I haven't been able to provide a minimal reproducible example.
# Setting the stage
We were noticing more and more lat... | docs(react-query): recommend against using server actions in queryFn | ## 🎯 Changes
Updates the Advanced Server Rendering guide to recommend against using Next.js Server Actions to fetch data in a `queryFn`. When called from the client, Server Actions run serially (not in parallel), which conflicts with how React Query fetches and refetches queries and can leave queries stuck pending ... | feb1efd804c1262106f72c8adc1d82a8ce9cfbb0 | f59500365f7152293862bb8fb1f3487235567539 | diff --git a/docs/framework/react/guides/advanced-ssr.md b/docs/framework/react/guides/advanced-ssr.md
index 05ed4aadb3c..e0fc37544c7 100644
--- a/docs/framework/react/guides/advanced-ssr.md
+++ b/docs/framework/react/guides/advanced-ssr.md
@@ -218,7 +218,7 @@ In the SSR guide, we noted that you could get rid of the bo... | [
"docs/framework/react/guides/advanced-ssr.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\n# Show the exact section around the referenced line in the docs file\nFILE=\"docs/framework/react/guides/advanced-ssr.md\"\nnl -ba \"$FILE\" | ... | true | |
TanStack/query | 10,927 | comment_to_fix | docs(react-query): recommend against using server actions in queryFn | _⚠️ Potential issue_ | _🟡 Minor_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
set -euo pipefail
# Show the exact section around the referenced line in the docs file
FILE="docs/framework/react/guides/advanced-ssr.md"
nl -ba "$FILE" | sed -n '190,260p'
```
Repository: TanS... | feb1efd804c1262106f72c8adc1d82a8ce9cfbb0 | f59500365f7152293862bb8fb1f3487235567539 | diff --git a/docs/framework/react/guides/advanced-ssr.md b/docs/framework/react/guides/advanced-ssr.md
index 05ed4aadb3c..e0fc37544c7 100644
--- a/docs/framework/react/guides/advanced-ssr.md
+++ b/docs/framework/react/guides/advanced-ssr.md
@@ -218,7 +218,7 @@ In the SSR guide, we noted that you could get rid of the bo... | [
"docs/framework/react/guides/advanced-ssr.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\n# Show the exact section around the referenced line in the docs file\nFILE=\"docs/framework/react/guides/advanced-ssr.md\"\nnl -ba \"$FILE\" | ... | true | ||
TanStack/query | 10,942 | issue_to_patch | test(lit-query): replace deprecated 'toThrowError' with 'toThrow' | ## 🎯 Changes
Replace the deprecated assertion alias `toThrowError` with its recommended counterpart `toThrow` across the lit-query test suite.
The alias is flagged `@deprecated` by `@vitest/expect`'s type definitions, which point to the replacement used here:
- `toThrowError` → `toThrow`
Affected files:
- `context-... | e5161df5200ba781964aed03cd3b69d09341c4ab | d5093c693984abcb5d209ab4f6f93383961013c9 | [
"packages/lit-query/src/tests/context-provider.test.ts",
"packages/lit-query/src/tests/mutation-controller.test.ts"
] | [] | diff --git a/packages/lit-query/src/tests/context-provider.test.ts b/packages/lit-query/src/tests/context-provider.test.ts
index 8428e0b75f1..a3bfbaa1154 100644
--- a/packages/lit-query/src/tests/context-provider.test.ts
+++ b/packages/lit-query/src/tests/context-provider.test.ts
@@ -46,7 +46,7 @@ describe('QueryClient... | true | ||
TanStack/query | 10,941 | issue_to_patch | test(angular-query-experimental): replace deprecated 'toBeCalledWith' with 'toHaveBeenCalledWith' | ## 🎯 Changes
Replace the deprecated assertion alias `toBeCalledWith` with its recommended counterpart `toHaveBeenCalledWith` in the angular-query-experimental test suite.
The alias is flagged `@deprecated` by `@vitest/expect`'s type definitions, which point to the replacement used here:
- `toBeCalledWith` → `toHaveB... | 43a4ea06508b8936f3b4e9f48fb45e3a3370b563 | 375dea67ea365cf327c7ae46eae884dd1a1a4b99 | [
"packages/angular-query-experimental/src/__tests__/inject-query.test.ts"
] | [] | diff --git a/packages/angular-query-experimental/src/__tests__/inject-query.test.ts b/packages/angular-query-experimental/src/__tests__/inject-query.test.ts
index a8bff8527b..fb7fd80a7b 100644
--- a/packages/angular-query-experimental/src/__tests__/inject-query.test.ts
+++ b/packages/angular-query-experimental/src/__te... | true | ||
TanStack/query | 10,940 | issue_to_patch | test(query-async-storage-persister): replace deprecated 'toBeCalledTimes' with 'toHaveBeenCalledTimes' | ## 🎯 Changes
Replace the deprecated assertion alias `toBeCalledTimes` with its recommended counterpart `toHaveBeenCalledTimes` in the query-async-storage-persister test suite.
The alias is flagged `@deprecated` by `@vitest/expect`'s type definitions, which point to the replacement used here:
- `toBeCalledTimes` → `t... | 43a4ea06508b8936f3b4e9f48fb45e3a3370b563 | 32ef6887f902065b2839530d7a1f6ffdd1db4746 | [
"packages/query-async-storage-persister/src/__tests__/asyncThrottle.test.ts"
] | [] | diff --git a/packages/query-async-storage-persister/src/__tests__/asyncThrottle.test.ts b/packages/query-async-storage-persister/src/__tests__/asyncThrottle.test.ts
index fe62502ab8d..1951ad15ed0 100644
--- a/packages/query-async-storage-persister/src/__tests__/asyncThrottle.test.ts
+++ b/packages/query-async-storage-p... | true | ||
TanStack/query | 10,939 | issue_to_patch | test(preact-query): replace deprecated 'toBeCalledTimes' with 'toHaveBeenCalledTimes' | ## 🎯 Changes
Replace the deprecated assertion alias `toBeCalledTimes` with its recommended counterpart `toHaveBeenCalledTimes` across the preact-query test suite.
The alias is flagged `@deprecated` by `@vitest/expect`'s type definitions, which point to the replacement used here:
- `toBeCalledTimes` → `toHaveBeenCall... | 43a4ea06508b8936f3b4e9f48fb45e3a3370b563 | 8b367dbfa1e9a3a4aef275a42799d73b28a57353 | [
"packages/preact-query/src/__tests__/useInfiniteQuery.test.tsx",
"packages/preact-query/src/__tests__/useQuery.test.tsx"
] | [] | diff --git a/packages/preact-query/src/__tests__/useInfiniteQuery.test.tsx b/packages/preact-query/src/__tests__/useInfiniteQuery.test.tsx
index 95346e7b00..5a96f0dbf0 100644
--- a/packages/preact-query/src/__tests__/useInfiniteQuery.test.tsx
+++ b/packages/preact-query/src/__tests__/useInfiniteQuery.test.tsx
@@ -976,7... | true | ||
TanStack/query | 10,938 | issue_to_patch | test(solid-query): replace deprecated 'toBeCalledTimes' with 'toHaveBeenCalledTimes' | ## 🎯 Changes
Replace the deprecated assertion alias `toBeCalledTimes` with its recommended counterpart `toHaveBeenCalledTimes` across the solid-query test suite.
The alias is flagged `@deprecated` by `@vitest/expect`'s type definitions, which point to the replacement used here:
- `toBeCalledTimes` → `toHaveBeenCalle... | 43a4ea06508b8936f3b4e9f48fb45e3a3370b563 | a7ac9132ffd00b4cdb2ab72b970b08334a841049 | [
"packages/solid-query/src/__tests__/useInfiniteQuery.test.tsx",
"packages/solid-query/src/__tests__/useQuery.test.tsx"
] | [] | diff --git a/packages/solid-query/src/__tests__/useInfiniteQuery.test.tsx b/packages/solid-query/src/__tests__/useInfiniteQuery.test.tsx
index 54c094bc2d..c0afb40bdb 100644
--- a/packages/solid-query/src/__tests__/useInfiniteQuery.test.tsx
+++ b/packages/solid-query/src/__tests__/useInfiniteQuery.test.tsx
@@ -1135,7 +1... | true | ||
TanStack/query | 10,937 | issue_to_patch | test(react-query): replace deprecated 'toBeCalledTimes' with 'toHaveBeenCalledTimes' | ## 🎯 Changes
Replace the deprecated assertion alias `toBeCalledTimes` with its recommended counterpart `toHaveBeenCalledTimes` across the react-query test suite.
The alias is flagged `@deprecated` by `@vitest/expect`'s type definitions, which point to the replacement used here:
- `toBeCalledTimes` → `toHaveBeenCalle... | 43a4ea06508b8936f3b4e9f48fb45e3a3370b563 | 6606af75acb6983674a5481c79e8119337c57282 | [
"packages/react-query/src/__tests__/useInfiniteQuery.test.tsx",
"packages/react-query/src/__tests__/useQuery.test.tsx"
] | [] | diff --git a/packages/react-query/src/__tests__/useInfiniteQuery.test.tsx b/packages/react-query/src/__tests__/useInfiniteQuery.test.tsx
index d4a16e34d8..fdcb9ad38e 100644
--- a/packages/react-query/src/__tests__/useInfiniteQuery.test.tsx
+++ b/packages/react-query/src/__tests__/useInfiniteQuery.test.tsx
@@ -977,7 +97... | true | ||
TanStack/query | 316 | issue_to_patch | Bump acorn from 6.3.0 to 6.4.1 in /examples/load-more-infinite-scroll | Bumps [acorn](https://github.com/acornjs/acorn) from 6.3.0 to 6.4.1.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/acornjs/acorn/commit/9a2e9b6678e243d66846b91179d650d28453e70c"><code>9a2e9b6</code></a> Mark version 6.4.1</li>
<li><a href="https://github.com/acornjs/acorn/commit/90a9548ea0ce... | f6178773f0bafc3327863378fc4214c38a887551 | 05dc9dba79d8fcb640d3a8ba334b88f886b308a2 | diff --git a/examples/load-more-infinite-scroll/yarn.lock b/examples/load-more-infinite-scroll/yarn.lock
index 29ba8e30a44..2190953591e 100644
--- a/examples/load-more-infinite-scroll/yarn.lock
+++ b/examples/load-more-infinite-scroll/yarn.lock
@@ -1250,9 +1250,9 @@ accepts@~1.3.5:
negotiator "0.6.2"
acorn@^6.2... | [
"examples/load-more-infinite-scroll/yarn.lock"
] | [] | true | ||
TanStack/query | 10,935 | issue_to_patch | test(vue-query): replace deprecated 'toBeCalledWith' and 'toBeCalled' with 'toHaveBeenCalledWith' and 'toHaveBeenCalled' | ## 🎯 Changes
Replace the deprecated assertion aliases `toBeCalledWith` and `toBeCalled` with their recommended counterparts `toHaveBeenCalledWith` and `toHaveBeenCalled` across the vue-query test suite.
Both aliases are flagged `@deprecated` by `@vitest/expect`'s type definitions, which point to the replacements use... | feb1efd804c1262106f72c8adc1d82a8ce9cfbb0 | babafd0df4bbff4ee065d714f25b7ee28ffc8958 | [
"packages/vue-query/src/__tests__/mutationCache.test.ts",
"packages/vue-query/src/__tests__/queryCache.test.ts",
"packages/vue-query/src/__tests__/queryClient.test.ts"
] | [] | diff --git a/packages/vue-query/src/__tests__/mutationCache.test.ts b/packages/vue-query/src/__tests__/mutationCache.test.ts
index 0ec4877a6f..cb8f20a49a 100644
--- a/packages/vue-query/src/__tests__/mutationCache.test.ts
+++ b/packages/vue-query/src/__tests__/mutationCache.test.ts
@@ -17,7 +17,7 @@ describe('MutationC... | true | ||
TanStack/query | 186 | issue_to_patch | Tidy the queryCache.clear() documentation | Remove redundant `callback` definition. | 009244b60f21a3390dbc35cf67c801b02697b09a | c6b7deca54f81609d2d41a9ca0aaba156f69c01b | diff --git a/README.md b/README.md
index 36fc9e3be0b..e2128aa23da 100644
--- a/README.md
+++ b/README.md
@@ -2312,8 +2312,6 @@ The `clear` method can be used to clear the queryCache entirely and start fresh.
```js
import { queryCache } from 'react-query'
-const callback = cache => {}
-
queryCache.clear()
```
| [
"README.md"
] | [] | true | ||
TanStack/query | 185 | issue_to_patch | Fix grammatical errors in the README | I've found some grammatical errors and typos in the README and fixed them in this PR. | 99e029994622f7ec2299579125c541b1b36b775a | b7b15423db9f83ffaf255f39f6218def40f77f1e | diff --git a/README.md b/README.md
index 0ee71e8309d..41c8398007b 100644
--- a/README.md
+++ b/README.md
@@ -63,7 +63,7 @@ Tools for managing "global state" are plentiful these days, but most of these to
React Query exports a set of hooks that address these issues. Out of the box, React Query:
-- Separates your **... | [
"README.md"
] | [] | true | ||
TanStack/query | 696 | issue_to_patch | clear is missing in QueryResult type definition
**Describe the bug**
When calling `useQuery` in a TypeScript project, `clear` is not defined as a valid key of the returned object.
**To Reproduce**
1. Visit https://codesandbox.io/s/youthful-kilby-1ktsq?file=/src/App.tsx
2. See TypeScript error: `Property 'clear' ... | fix(types): add clear to QueryResultBase | Adds type for `clear()` on `QueryResultBase`
closes #692 | 989c4cd310737ad6340fa9096fa5f0d1e43d8824 | e5042ea190a4190c6fdab55de009e8eafbf99b31 | diff --git a/types/index.d.ts b/types/index.d.ts
index 05eed236455..e0d561f0ab2 100644
--- a/types/index.d.ts
+++ b/types/index.d.ts
@@ -286,6 +286,7 @@ export interface QueryResultBase<TResult, TError = Error> {
query: object
updatedAt: number
refetch: ({ throwOnError }?: { throwOnError?: boolean }) => Promis... | [
"types/index.d.ts",
"types/test.ts"
] | [] | true | |
TanStack/query | 315 | issue_to_patch | Bump acorn from 6.3.0 to 6.4.1 in /examples/auto-refetching | Bumps [acorn](https://github.com/acornjs/acorn) from 6.3.0 to 6.4.1.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/acornjs/acorn/commit/9a2e9b6678e243d66846b91179d650d28453e70c"><code>9a2e9b6</code></a> Mark version 6.4.1</li>
<li><a href="https://github.com/acornjs/acorn/commit/90a9548ea0ce... | f6178773f0bafc3327863378fc4214c38a887551 | a5eb94c1002dc6c2ca4648a06e6a9891e6e98ccb | diff --git a/examples/auto-refetching/yarn.lock b/examples/auto-refetching/yarn.lock
index 54b12d60382..6673d47f1fe 100644
--- a/examples/auto-refetching/yarn.lock
+++ b/examples/auto-refetching/yarn.lock
@@ -1250,9 +1250,9 @@ accepts@~1.3.5:
negotiator "0.6.2"
acorn@^6.2.1:
- version "6.3.0"
- resolved "http... | [
"examples/auto-refetching/yarn.lock"
] | [] | true | ||
TanStack/query | 10,920 | issue_to_patch | test(*): move 'vi.useRealTimers' to the end of 'afterEach' so cleanup runs under fake timers | ## 🎯 Changes
Move `vi.useRealTimers()` to the **last line** of each `afterEach`/`afterAll` block, so all teardown (`queryClient.clear()`, storage resets, `*.mockClear()`, `TestBed.resetTestingModule()`, etc.) runs while fake timers are still active, and the timer regime is restored only after cleanup completes.
### ... | b552179a3b9d62793b312e21a36f14f26edde2b5 | a134fa014e64dbcea3d2fa36d971d05f9471edc8 | [
"packages/angular-query-experimental/src/__tests__/pending-tasks.test.ts",
"packages/angular-query-experimental/src/__tests__/with-devtools.test.ts",
"packages/preact-query-persist-client/src/__tests__/use-queries-with-persist.test.tsx",
"packages/preact-query/src/__tests__/QueryResetErrorBoundary.test.tsx",
... | [] | diff --git a/packages/angular-query-experimental/src/__tests__/pending-tasks.test.ts b/packages/angular-query-experimental/src/__tests__/pending-tasks.test.ts
index 0bdd109a4a7..c5a1f58d81f 100644
--- a/packages/angular-query-experimental/src/__tests__/pending-tasks.test.ts
+++ b/packages/angular-query-experimental/src... | true | ||
TanStack/query | 10,919 | issue_to_patch | test(solid-query/useIsMutating): centralize 'queryClient' setup with 'beforeEach' and rename injected/spied clients | ## 🎯 Changes
Centralize the per-test `new QueryClient()` setup into a shared `let queryClient` declared at the `describe` level and created in `beforeEach`, matching the pattern already used by `useMutation.test.tsx`. `afterEach` now calls `queryClient.clear()`.
- 3 cases now use the centralized client.
- The `shoul... | f6c654266820225334245d946d6fb45815325b6b | df15320b9612dd4b6ddf8d5fe225ba33289a91d4 | [
"packages/solid-query/src/__tests__/useIsMutating.test.tsx"
] | [] | diff --git a/packages/solid-query/src/__tests__/useIsMutating.test.tsx b/packages/solid-query/src/__tests__/useIsMutating.test.tsx
index 985ce05470..b7944511b3 100644
--- a/packages/solid-query/src/__tests__/useIsMutating.test.tsx
+++ b/packages/solid-query/src/__tests__/useIsMutating.test.tsx
@@ -12,17 +12,20 @@ impor... | true | ||
TanStack/query | 10,918 | issue_to_patch | test(solid-query/useMutationState): centralize 'queryClient' setup with 'beforeEach' | ## 🎯 Changes
Centralize the per-test `new QueryClient()` setup into a shared `let queryClient` declared at the `describe` level and created in `beforeEach`, matching the pattern already used by `useMutation.test.tsx`. `afterEach` now calls `queryClient.clear()`.
Both cases that previously created their own `new Quer... | f6c654266820225334245d946d6fb45815325b6b | 49074791b736a05ab3ff02cac7da3158e1877e7e | [
"packages/solid-query/src/__tests__/useMutationState.test.tsx"
] | [] | diff --git a/packages/solid-query/src/__tests__/useMutationState.test.tsx b/packages/solid-query/src/__tests__/useMutationState.test.tsx
index 020d24140b..f6ae20a4a1 100644
--- a/packages/solid-query/src/__tests__/useMutationState.test.tsx
+++ b/packages/solid-query/src/__tests__/useMutationState.test.tsx
@@ -10,16 +10... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.