diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/test/background_exception_notification_test.rb b/test/background_exception_notification_test.rb index abc1234..def5678 100644 --- a/test/background_exception_notification_test.rb +++ b/test/background_exception_notification_test.rb @@ -30,6 +30,10 @@ assert @mail.subject.include? "[Dummy ERROR] (ZeroD...
Add one more test for background notifications.
diff --git a/lib/conway.rb b/lib/conway.rb index abc1234..def5678 100644 --- a/lib/conway.rb +++ b/lib/conway.rb @@ -14,20 +14,20 @@ end class Grid - attr_reader :width, :heigth , :fields + attr_reader :width, :heigth, :fields def initialize(width, heigth) @width, @heigth = width, heigth - @fields = Arr...
Fix whitespace, once again ...
diff --git a/spec/controllers/ops_controller/settings/rbac_roles_spec.rb b/spec/controllers/ops_controller/settings/rbac_roles_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/ops_controller/settings/rbac_roles_spec.rb +++ b/spec/controllers/ops_controller/settings/rbac_roles_spec.rb @@ -0,0 +1,57 @@+descri...
Add specs for role editor RBAC tree.
diff --git a/lib/mikoshi/plan.rb b/lib/mikoshi/plan.rb index abc1234..def5678 100644 --- a/lib/mikoshi/plan.rb +++ b/lib/mikoshi/plan.rb @@ -5,12 +5,13 @@ module Mikoshi class Plan class Base - attr_reader :data + attr_reader :data, :client - def initialize(yaml_path: nil) + def initialize...
Add argument and attribute client
diff --git a/lib/rdf/reasoner.rb b/lib/rdf/reasoner.rb index abc1234..def5678 100644 --- a/lib/rdf/reasoner.rb +++ b/lib/rdf/reasoner.rb @@ -15,9 +15,9 @@ ## # Add entailment support for the specified regime # - # @param [:OWL, :RDFS, :SCHEMA] regime - def apply(regime) - require "rdf/reasoner/...
Allow Reasoner.apply to take multiple arguments.
diff --git a/lib/slappy/event.rb b/lib/slappy/event.rb index abc1234..def5678 100644 --- a/lib/slappy/event.rb +++ b/lib/slappy/event.rb @@ -26,7 +26,7 @@ end def ts - Time.at(@data['ts'].to_f) + Time.at((@data['ts'] || @data['event_ts']).to_f) end def reply(text, options = {})
Fix did not monitor reaction_added RTM
diff --git a/lib/tasks/test.rake b/lib/tasks/test.rake index abc1234..def5678 100644 --- a/lib/tasks/test.rake +++ b/lib/tasks/test.rake @@ -9,5 +9,5 @@ require 'coveralls/rake/task' Coveralls::RakeTask.new desc "GitLab | Run all tests on CI with simplecov" - task :test_ci => [:rubocop, :brakeman, 'jasmine:ci'...
Use teaspoon instead of jasmine:ci Signed-off-by: Dmitriy Zaporozhets <be23d75b156792e5acab51b196a2deb155d35d6a@gmail.com>
diff --git a/lib/foauth.rb b/lib/foauth.rb index abc1234..def5678 100644 --- a/lib/foauth.rb +++ b/lib/foauth.rb @@ -6,6 +6,7 @@ # # @param [String] email Your foauth.org email address. # @param [String] password Your foauth.org password. + # @yield [builder] Passes the `Faraday::Builder` instance to the block...
Document the optional block parameter
diff --git a/test/bane/behaviors/servers/timeout_in_listen_queue_test.rb b/test/bane/behaviors/servers/timeout_in_listen_queue_test.rb index abc1234..def5678 100644 --- a/test/bane/behaviors/servers/timeout_in_listen_queue_test.rb +++ b/test/bane/behaviors/servers/timeout_in_listen_queue_test.rb @@ -12,7 +12,7 @@ d...
Fix test which threw ETIMEDOUT on ruby 1.9.3p551 on Mac OS X.
diff --git a/lib/runner.rb b/lib/runner.rb index abc1234..def5678 100644 --- a/lib/runner.rb +++ b/lib/runner.rb @@ -5,6 +5,14 @@ require './lib/utils' require './lib/commentators/console' require './lib/commentators/github' + +module Policial + class ConfigLoader + def raw(filename) + File.read(filename) + ...
Fix policial confg loading function
diff --git a/lib/dimples/template.rb b/lib/dimples/template.rb index abc1234..def5678 100644 --- a/lib/dimples/template.rb +++ b/lib/dimples/template.rb @@ -1,17 +1,18 @@+# frozen_string_literal: true + module Dimples class Template include Frontable + include Renderable + + attr_accessor :path + attr...
Include Renderable, add attr_accessors and set the path
diff --git a/lib/buoys/buoy.rb b/lib/buoys/buoy.rb index abc1234..def5678 100644 --- a/lib/buoys/buoy.rb +++ b/lib/buoys/buoy.rb @@ -40,5 +40,9 @@ def pre_buoy(key, *args) @previous = Buoys::Buoy.new(context, key, args) end + + def method_missing(method, *args, &block) + context.send(method, *ar...
Add method_missing definition to Buoys::Buoy To interpret named routes method ex) root_path, in config/buoys/*.rb
diff --git a/lib/scss_lint/engine.rb b/lib/scss_lint/engine.rb index abc1234..def5678 100644 --- a/lib/scss_lint/engine.rb +++ b/lib/scss_lint/engine.rb @@ -4,11 +4,15 @@ class Engine ENGINE_OPTIONS = { cache: false, syntax: :scss } + attr_reader :contents + def initialize(scss_or_filename) if F...
Store actual string contents of SCSS files This will enable us to write linters that can access the original file in cases where line number or other such information can be inferred separately. Change-Id: I02182d1fdd19f1ce1a4c4e072c7a0655f1732889 Reviewed-on: https://gerrit.causes.com/16557 Reviewed-by: Shane da Sil...
diff --git a/db/migrate/20100814103856_create_cve_references.rb b/db/migrate/20100814103856_create_cve_references.rb index abc1234..def5678 100644 --- a/db/migrate/20100814103856_create_cve_references.rb +++ b/db/migrate/20100814103856_create_cve_references.rb @@ -2,8 +2,8 @@ def self.up create_table :cve_re...
CVEReference: Use text instead of string, to have space for long gitweb URLs
diff --git a/db/migrate/20190225092700_alter_localized_names.rb b/db/migrate/20190225092700_alter_localized_names.rb index abc1234..def5678 100644 --- a/db/migrate/20190225092700_alter_localized_names.rb +++ b/db/migrate/20190225092700_alter_localized_names.rb @@ -1,8 +1,14 @@ Sequel.migration do - change do + up do ...
Fix failing DB migration for localized_names Previous version worked correctly for migration but failed with an unsupported error on rollback. Address with explicit `up`/`down` blocks.
diff --git a/app/workers/download_manuscript_worker.rb b/app/workers/download_manuscript_worker.rb index abc1234..def5678 100644 --- a/app/workers/download_manuscript_worker.rb +++ b/app/workers/download_manuscript_worker.rb @@ -9,11 +9,9 @@ epub = EpubConverter.new manuscript.paper, User.first, true - respo...
Use RestClient instead of Typhoeus in the worker
diff --git a/lib/straight_shooter.rb b/lib/straight_shooter.rb index abc1234..def5678 100644 --- a/lib/straight_shooter.rb +++ b/lib/straight_shooter.rb @@ -12,7 +12,7 @@ def initialize(url, filename = nil) self.app = Qt::Application.new(ARGV) - self.page = Page.new(ARGV[0], ARGV[1]) + self.page = Page...
Use the method args, not the file ones.
diff --git a/lib/vmdb/initializer.rb b/lib/vmdb/initializer.rb index abc1234..def5678 100644 --- a/lib/vmdb/initializer.rb +++ b/lib/vmdb/initializer.rb @@ -19,11 +19,11 @@ end end - def self.log_db_connectable + private_class_method def self.log_db_connectable _log.info("Successfully connecte...
Make all of these methods private, called only from init.
diff --git a/releaf-core/spec/features/settings_spec.rb b/releaf-core/spec/features/settings_spec.rb index abc1234..def5678 100644 --- a/releaf-core/spec/features/settings_spec.rb +++ b/releaf-core/spec/features/settings_spec.rb @@ -2,7 +2,7 @@ feature "Settings", js: true do scenario "edit settings" do Releaf:...
Make settings feature test timezone-safe
diff --git a/lib/guillotine.rb b/lib/guillotine.rb index abc1234..def5678 100644 --- a/lib/guillotine.rb +++ b/lib/guillotine.rb @@ -7,7 +7,11 @@ excecutor = Object.const_get("Executors").const_get(command_array.shift.capitalize) response = excecutor.send(command_array.shift.downcase.to_sym, opts, *command...
Raise NameError Exceptions when not in production
diff --git a/woff.gemspec b/woff.gemspec index abc1234..def5678 100644 --- a/woff.gemspec +++ b/woff.gemspec @@ -22,8 +22,7 @@ gem.add_dependency "bindata", "~> 2.3" gem.add_dependency "brotli", "~> 0.1" - gem.add_development_dependency "rake", "~> 11.2.2" - gem.add_development_dependency "rspec", "~> 3.5.0" -...
Update Dev Dependencies to Address Deprecations
diff --git a/test/integration/assign_test.rb b/test/integration/assign_test.rb index abc1234..def5678 100644 --- a/test/integration/assign_test.rb +++ b/test/integration/assign_test.rb @@ -24,4 +24,15 @@ '{% assign foo not values %}.', 'values' => "foo,bar,baz") end + +...
Add tests for assign tag fix
diff --git a/govuk_admin_template.gemspec b/govuk_admin_template.gemspec index abc1234..def5678 100644 --- a/govuk_admin_template.gemspec +++ b/govuk_admin_template.gemspec @@ -23,6 +23,6 @@ gem.add_development_dependency "capybara", "~> 3" gem.add_development_dependency "rspec-rails", "~> 5" - gem.add_developm...
Update rubocop-govuk requirement from = 4.7.0 to = 4.8.0 Updates the requirements on [rubocop-govuk](https://github.com/alphagov/rubocop-govuk) to permit the latest version. - [Release notes](https://github.com/alphagov/rubocop-govuk/releases) - [Changelog](https://github.com/alphagov/rubocop-govuk/blob/main/CHANGELOG...
diff --git a/lib/mri_bridge.rb b/lib/mri_bridge.rb index abc1234..def5678 100644 --- a/lib/mri_bridge.rb +++ b/lib/mri_bridge.rb @@ -3,7 +3,7 @@ module Rubinius LookupTable = Hash - Tuple = Array + class Tuple < Array; end class Executable attr_accessor :primitive
Make Tuple a real class for MRI bridge.
diff --git a/app/controllers/admin/operational_fields_controller.rb b/app/controllers/admin/operational_fields_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/operational_fields_controller.rb +++ b/app/controllers/admin/operational_fields_controller.rb @@ -10,7 +10,7 @@ end def create - ...
Add strong params for operational fields
diff --git a/spec/hamlit/parser_spec.rb b/spec/hamlit/parser_spec.rb index abc1234..def5678 100644 --- a/spec/hamlit/parser_spec.rb +++ b/spec/hamlit/parser_spec.rb @@ -10,7 +10,8 @@ '%span a', [:multi, [:html, :tag, 'span', [:haml, :attrs], [:static, 'a']], - [:static, "\n"]], + ...
Fix failing spec due to newline
diff --git a/rb/spec/integration/selenium/webdriver/opera/driver_spec.rb b/rb/spec/integration/selenium/webdriver/opera/driver_spec.rb index abc1234..def5678 100644 --- a/rb/spec/integration/selenium/webdriver/opera/driver_spec.rb +++ b/rb/spec/integration/selenium/webdriver/opera/driver_spec.rb @@ -3,6 +3,9 @@ mod...
AndreasTolfTolfsen: Make sure remote server is shut down before running specs on Selenium::WebDriver::Opera git-svn-id: 4179480af2c2519a5eb5e1e9b541cbdf5cf27696@13920 07704840-8298-11de-bf8c-fd130f914ac9
diff --git a/lib/parvus/cli.rb b/lib/parvus/cli.rb index abc1234..def5678 100644 --- a/lib/parvus/cli.rb +++ b/lib/parvus/cli.rb @@ -1,4 +1,5 @@ require_relative 'shorteners/butts_so' +require_relative 'shorteners/bitly' class CommandLineParser < Thor map '--version' => :version, '-v' => :version @@ -6,9 +7,10 @@...
Add support for bitly in the CLI class
diff --git a/app/models/competitions/oregon_womens_prestige_series_modules/common.rb b/app/models/competitions/oregon_womens_prestige_series_modules/common.rb index abc1234..def5678 100644 --- a/app/models/competitions/oregon_womens_prestige_series_modules/common.rb +++ b/app/models/competitions/oregon_womens_prestige_...
Remove membership requirement for OWPS
diff --git a/Casks/mactex.rb b/Casks/mactex.rb index abc1234..def5678 100644 --- a/Casks/mactex.rb +++ b/Casks/mactex.rb @@ -6,7 +6,7 @@ url "http://mirror.ctan.org/systems/mac/mactex/mactex-#{version}.pkg" name 'MacTeX' homepage 'https://www.tug.org/mactex/' - license :unknown # todo: change license and re...
Add oss license information for MacTex License information is shown when running the installer from the pkg. `oss` is the appropriate choice here, as several different licenses are used within the package. From the license step of the installer: > TeX Live and teTeX are covered by a variety of licenses (e.g. GNU Gene...
diff --git a/config/initializers/stripe.rb b/config/initializers/stripe.rb index abc1234..def5678 100644 --- a/config/initializers/stripe.rb +++ b/config/initializers/stripe.rb @@ -1,2 +1,2 @@-Stripe.api_key = "xmLR9a78SA9MwiGrrD2Z6VQDBpe82Q0Y" -STRIPE_PUBLISHABLE_KEY = "pk_IFyTlHIcoXGg0MS2eLAn4CS3INPQx" +Stripe.api_ke...
Switch to the same default API key we use for tests in our bindings
diff --git a/lib/wright/cli.rb b/lib/wright/cli.rb index abc1234..def5678 100644 --- a/lib/wright/cli.rb +++ b/lib/wright/cli.rb @@ -48,7 +48,7 @@ @commands << e end - opts.on_tail('-v', '--version', 'Show wright version') do + opts.on_tail('--version', 'Show wright version') do ...
Remove short option for --version
diff --git a/db/migrate/20140507144143_rename_generic_site2_global.rb b/db/migrate/20140507144143_rename_generic_site2_global.rb index abc1234..def5678 100644 --- a/db/migrate/20140507144143_rename_generic_site2_global.rb +++ b/db/migrate/20140507144143_rename_generic_site2_global.rb @@ -1,9 +1,9 @@ class RenameGeneric...
Fix for generic renaming error
diff --git a/JMAttributedFormat.podspec b/JMAttributedFormat.podspec index abc1234..def5678 100644 --- a/JMAttributedFormat.podspec +++ b/JMAttributedFormat.podspec @@ -18,7 +18,7 @@ arguments, so your styled strings can be flexibly localized. DESC - s.homepage = "https://g...
Rename GitHub repository to match project name
diff --git a/db/migrate/20170209204216_create_orders.rb b/db/migrate/20170209204216_create_orders.rb index abc1234..def5678 100644 --- a/db/migrate/20170209204216_create_orders.rb +++ b/db/migrate/20170209204216_create_orders.rb @@ -1,6 +1,7 @@ class CreateOrders < ActiveRecord::Migration[5.0] def change create...
Edit migration, add :user_id to Orders table
diff --git a/Casks/brackets.rb b/Casks/brackets.rb index abc1234..def5678 100644 --- a/Casks/brackets.rb +++ b/Casks/brackets.rb @@ -1,7 +1,7 @@ class Brackets < Cask - url 'http://download.brackets.io/file.cfm?platform=OSX&build=36' + url 'http://download.brackets.io/file.cfm?platform=OSX&build=37' homepage 'http...
Update Brackets to Sprint 37
diff --git a/BFTaskCenter.podspec b/BFTaskCenter.podspec index abc1234..def5678 100644 --- a/BFTaskCenter.podspec +++ b/BFTaskCenter.podspec @@ -10,7 +10,7 @@ s.license = 'MIT' s.author = { "Superbil" => "superbil@gmail.com" } - s.source = { :git => "https://github.com/Superbil/BFTa...
Change mapping tag format at podspec
diff --git a/Library/Formula/kdelibs.rb b/Library/Formula/kdelibs.rb index abc1234..def5678 100644 --- a/Library/Formula/kdelibs.rb +++ b/Library/Formula/kdelibs.rb @@ -25,4 +25,17 @@ system "cmake .. #{std_cmake_parameters} -DCMAKE_PREFIX_PATH=#{gettext.prefix} -DBUNDLE_INSTALL_DIR=#{bin}" system "make instal...
Add KDELibs caveat so people don't expect it to fully work yet.
diff --git a/lib/cloud_conductor/converters/open_stack_converter.rb b/lib/cloud_conductor/converters/open_stack_converter.rb index abc1234..def5678 100644 --- a/lib/cloud_conductor/converters/open_stack_converter.rb +++ b/lib/cloud_conductor/converters/open_stack_converter.rb @@ -15,14 +15,29 @@ module CloudConductor ...
Add patches to OpenStackConverter to remove unimplemented properties
diff --git a/app/controllers/email_notifications_reminders_controller.rb b/app/controllers/email_notifications_reminders_controller.rb index abc1234..def5678 100644 --- a/app/controllers/email_notifications_reminders_controller.rb +++ b/app/controllers/email_notifications_reminders_controller.rb @@ -5,7 +5,8 @@ cur...
Set notifications by default when accepting
diff --git a/app/helpers/application_helper/button/provider_user_sync.rb b/app/helpers/application_helper/button/provider_user_sync.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper/button/provider_user_sync.rb +++ b/app/helpers/application_helper/button/provider_user_sync.rb @@ -2,6 +2,13 @@ need...
Disable Sync Users button if tenant mapping is not enabled If tenant mapping is not enabled, then the provider will have no tenants being refreshed into the ems. This means no groups can be created because groups require a tenant and role pair. If no groups can be created, then any new users will have their current_gr...
diff --git a/spec/converse/conversation_handler_spec.rb b/spec/converse/conversation_handler_spec.rb index abc1234..def5678 100644 --- a/spec/converse/conversation_handler_spec.rb +++ b/spec/converse/conversation_handler_spec.rb @@ -0,0 +1,19 @@+RSpec.describe Converse::ConversationHandler do + describe "#can_handle?"...
Move the conversation handler to the appropriate place
diff --git a/git_flame.gemspec b/git_flame.gemspec index abc1234..def5678 100644 --- a/git_flame.gemspec +++ b/git_flame.gemspec @@ -4,9 +4,18 @@ Gem::Specification.new do |gem| gem.authors = ["Linus Oleander"] gem.email = ["linus@oleander.nu"] - gem.description = %q{Ruby Git blame} - gem.summar...
Add dependencies and proper description to gemspec
diff --git a/Casks/gif-for-mac.rb b/Casks/gif-for-mac.rb index abc1234..def5678 100644 --- a/Casks/gif-for-mac.rb +++ b/Casks/gif-for-mac.rb @@ -0,0 +1,12 @@+cask :v1 => 'gif-for-mac' do + version :latest + sha256 :no_check + + # cloudfront.net is the official download host per the vendor homepage + url 'https://d3...
Add GIF for Mac latest
diff --git a/lib/cloudstrap/amazon/elb.rb b/lib/cloudstrap/amazon/elb.rb index abc1234..def5678 100644 --- a/lib/cloudstrap/amazon/elb.rb +++ b/lib/cloudstrap/amazon/elb.rb @@ -20,6 +20,11 @@ private + Contract Args[String] => ArrayOf[::Aws::ElasticLoadBalancing::Types::TagDescription] + def describ...
Add method to find tags
diff --git a/lib/constant-redefinition.rb b/lib/constant-redefinition.rb index abc1234..def5678 100644 --- a/lib/constant-redefinition.rb +++ b/lib/constant-redefinition.rb @@ -1,12 +1,10 @@ class Object def define_if_not_defined(const, value) mod = self.is_a?(Module) ? self : self.class + mod.const_set(cons...
Move setting of constant in define_if_not_defined up so as to not repeat code
diff --git a/features/step_definitions/contact_steps.rb b/features/step_definitions/contact_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/contact_steps.rb +++ b/features/step_definitions/contact_steps.rb @@ -1,5 +1,6 @@ Given(/^I click to edit from restroom Mission Creek Cafe$/) do - visit '/r...
Use restroom path in feature rather than hardcoding id.
diff --git a/herodotus.gemspec b/herodotus.gemspec index abc1234..def5678 100644 --- a/herodotus.gemspec +++ b/herodotus.gemspec @@ -22,5 +22,4 @@ s.add_development_dependency 'redgreen' s.add_development_dependency 'rake' s.add_development_dependency 'ruby-debug19' - s.add_development_dependency 'minitest' e...
Remove minitest dependency, just use 1.9
diff --git a/db/migrate/20150423232324_create_users.rb b/db/migrate/20150423232324_create_users.rb index abc1234..def5678 100644 --- a/db/migrate/20150423232324_create_users.rb +++ b/db/migrate/20150423232324_create_users.rb @@ -1,3 +1,5 @@+# Encoding: utf-8 +# Create Users class CreateUsers < ActiveRecord::Migration ...
Clean up user migration script
diff --git a/lib/capistrano_nrel_ext/recipes/php_apc.rb b/lib/capistrano_nrel_ext/recipes/php_apc.rb index abc1234..def5678 100644 --- a/lib/capistrano_nrel_ext/recipes/php_apc.rb +++ b/lib/capistrano_nrel_ext/recipes/php_apc.rb @@ -0,0 +1,25 @@+Capistrano::Configuration.instance(true).load do + # + # Hooks + # + a...
Add recipe for clearing PHP's APC cache on deploy.
diff --git a/test/integration/queue/list_queues_test.rb b/test/integration/queue/list_queues_test.rb index abc1234..def5678 100644 --- a/test/integration/queue/list_queues_test.rb +++ b/test/integration/queue/list_queues_test.rb @@ -24,16 +24,20 @@ after { QueueNameHelper.clean } it 'lists the available ...
Update list_queues test to expect a next_marker. This prevents failures when running against a queue service with over 5000 queues.
diff --git a/test/profile/normalize_performance_test.rb b/test/profile/normalize_performance_test.rb index abc1234..def5678 100644 --- a/test/profile/normalize_performance_test.rb +++ b/test/profile/normalize_performance_test.rb @@ -4,7 +4,7 @@ class NormalizerPerformanceTest < Test::Unit::TestCase context ".normali...
Fix performance test, should be testing normalize_url
diff --git a/lib/tasks/generate_random_sensor_data.rake b/lib/tasks/generate_random_sensor_data.rake index abc1234..def5678 100644 --- a/lib/tasks/generate_random_sensor_data.rake +++ b/lib/tasks/generate_random_sensor_data.rake @@ -0,0 +1,14 @@+namespace :generate_random_sensor_data do + task :seed, :environment do +...
Add task to seed fake readings
diff --git a/db/migrate/20190212172653_change_topic_user_id_to_bigint.rb b/db/migrate/20190212172653_change_topic_user_id_to_bigint.rb index abc1234..def5678 100644 --- a/db/migrate/20190212172653_change_topic_user_id_to_bigint.rb +++ b/db/migrate/20190212172653_change_topic_user_id_to_bigint.rb @@ -0,0 +1,9 @@+class C...
Update topic_user_id primary key to bigint
diff --git a/core/db/migrate/20171004223836_remove_icon_from_taxons.rb b/core/db/migrate/20171004223836_remove_icon_from_taxons.rb index abc1234..def5678 100644 --- a/core/db/migrate/20171004223836_remove_icon_from_taxons.rb +++ b/core/db/migrate/20171004223836_remove_icon_from_taxons.rb @@ -0,0 +1,8 @@+class RemoveIco...
Remove old icon columns from taxon
diff --git a/db/migrate/20140211203335_create_balanced_contributors.rb b/db/migrate/20140211203335_create_balanced_contributors.rb index abc1234..def5678 100644 --- a/db/migrate/20140211203335_create_balanced_contributors.rb +++ b/db/migrate/20140211203335_create_balanced_contributors.rb @@ -3,8 +3,6 @@ create_tabl...
Remove unused fields from balanced_contributors migration
diff --git a/test/fakeweb_registrations.rb b/test/fakeweb_registrations.rb index abc1234..def5678 100644 --- a/test/fakeweb_registrations.rb +++ b/test/fakeweb_registrations.rb @@ -27,3 +27,5 @@ body: { _index: "posts", _type: "post", _id: "1", _version: 118, created: false }.to_json, content_type: "application/js...
Allow connections to 127.0.0.1 to fix acceptance tests
diff --git a/rails_event_store/spec/browser_integration_spec.rb b/rails_event_store/spec/browser_integration_spec.rb index abc1234..def5678 100644 --- a/rails_event_store/spec/browser_integration_spec.rb +++ b/rails_event_store/spec/browser_integration_spec.rb @@ -19,8 +19,8 @@ response = request.get('/res/api/st...
Adjust to new paging params [d077238b]
diff --git a/lib/dapp/dimg/build/stage/ga_related_dependencies_base.rb b/lib/dapp/dimg/build/stage/ga_related_dependencies_base.rb index abc1234..def5678 100644 --- a/lib/dapp/dimg/build/stage/ga_related_dependencies_base.rb +++ b/lib/dapp/dimg/build/stage/ga_related_dependencies_base.rb @@ -8,7 +8,7 @@ end ...
Revert "Фикс stage_dependencies для пересборки стадий install,setup" This reverts commit 09d7cb4cf570609dea8dd4ab0d5691e125e672e9.
diff --git a/app/validators/reservations/custom_whitelist_validator.rb b/app/validators/reservations/custom_whitelist_validator.rb index abc1234..def5678 100644 --- a/app/validators/reservations/custom_whitelist_validator.rb +++ b/app/validators/reservations/custom_whitelist_validator.rb @@ -3,18 +3,21 @@ module Reserv...
Clean up custom whitelist validator a little
diff --git a/lib/cooperator.rb b/lib/cooperator.rb index abc1234..def5678 100644 --- a/lib/cooperator.rb +++ b/lib/cooperator.rb @@ -45,10 +45,6 @@ throw :_finish end - def success? - context.success? - end - def failure! context.failure! throw :_finish
Remove method which has already been delegated.
diff --git a/test/i_object_info_test.rb b/test/i_object_info_test.rb index abc1234..def5678 100644 --- a/test/i_object_info_test.rb +++ b/test/i_object_info_test.rb @@ -6,8 +6,8 @@ setup do gir = IRepository.default - gir.require 'Everything', nil - @info = gir.find_by_name 'Everything', 'TestObj' + gir.requi...
Make tests in IObjectInfoTest pass by changing Everything to Regress.
diff --git a/spec/factories/plugins_thermometers.rb b/spec/factories/plugins_thermometers.rb index abc1234..def5678 100644 --- a/spec/factories/plugins_thermometers.rb +++ b/spec/factories/plugins_thermometers.rb @@ -1,10 +1,9 @@ FactoryGirl.define do factory :plugins_thermometer, :class => 'Plugins::Thermometer' do...
Fix thermometer plugin factory as per Omar's master plan
diff --git a/spec/integration/queue_declare_spec.rb b/spec/integration/queue_declare_spec.rb index abc1234..def5678 100644 --- a/spec/integration/queue_declare_spec.rb +++ b/spec/integration/queue_declare_spec.rb @@ -4,12 +4,27 @@ describe "Queue" do context "with a server-generated name" do let(:connection) { ...
Use after :each so that RSpec execution thread is not blocked forever
diff --git a/lib/not_my_job.rb b/lib/not_my_job.rb index abc1234..def5678 100644 --- a/lib/not_my_job.rb +++ b/lib/not_my_job.rb @@ -13,7 +13,7 @@ end to = options.fetch(:to) { raise ArgumentError, "The :to option is required." } - with_prefix = options.fetch(:with_prefix) { true } + with_prefi...
Change the default value in fetch(:with_prefix)
diff --git a/lib/headlines/security_headers/strict_transport_security.rb b/lib/headlines/security_headers/strict_transport_security.rb index abc1234..def5678 100644 --- a/lib/headlines/security_headers/strict_transport_security.rb +++ b/lib/headlines/security_headers/strict_transport_security.rb @@ -16,7 +16,7 @@ ...
Use case insensitive scan for includeSubDomains HSTS property
diff --git a/lib/tasks/qa.rake b/lib/tasks/qa.rake index abc1234..def5678 100644 --- a/lib/tasks/qa.rake +++ b/lib/tasks/qa.rake @@ -1,4 +1,4 @@ desc 'Show some QA details about the code' task qa: ['stats', 'doc:stats'] do - sh 'rails_best_practices -x schema' + sh 'rails_best_practices -x schema --spec' end
Update railsbp to include spec files too.
diff --git a/week-4/add-it-up/my_solution.rb b/week-4/add-it-up/my_solution.rb index abc1234..def5678 100644 --- a/week-4/add-it-up/my_solution.rb +++ b/week-4/add-it-up/my_solution.rb @@ -4,30 +4,23 @@ # include it in this file. Also make sure everything that isn't code # is commented in the file. -# I worked on th...
Update 4.7.2 add it up
diff --git a/Casks/intellij-idea-ce-eap.rb b/Casks/intellij-idea-ce-eap.rb index abc1234..def5678 100644 --- a/Casks/intellij-idea-ce-eap.rb +++ b/Casks/intellij-idea-ce-eap.rb @@ -1,6 +1,6 @@ cask 'intellij-idea-ce-eap' do - version '144.2608.2' - sha256 '21d2fd409de9924d04a235bf5343033a52d84658fdf96e16d6aab377beab0...
Upgrade IntelliJ IDEA CE EAP to v144.2925.2
diff --git a/Casks/rubymine-bundled-jdk.rb b/Casks/rubymine-bundled-jdk.rb index abc1234..def5678 100644 --- a/Casks/rubymine-bundled-jdk.rb +++ b/Casks/rubymine-bundled-jdk.rb @@ -1,6 +1,6 @@ cask :v1 => 'rubymine-bundled-jdk' do - version '7.1' - sha256 '2e9fced43c8e14ffbc82a72a8f6cde1cbab50861db079162ca5ff34c668ba...
Upgrade RubyMine with bundled JDK to 7.1.2 Also add conflicts_with stanza for RubyMine without bundled JDK
diff --git a/app/controllers/admin/scoreboards_controller.rb b/app/controllers/admin/scoreboards_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/scoreboards_controller.rb +++ b/app/controllers/admin/scoreboards_controller.rb @@ -34,9 +34,9 @@ # DELETE /scoreboards/1 def destroy @...
Fix _url suffix and namespace for delete URLs
diff --git a/SHOmniAuthFacebook.podspec b/SHOmniAuthFacebook.podspec index abc1234..def5678 100644 --- a/SHOmniAuthFacebook.podspec +++ b/SHOmniAuthFacebook.podspec @@ -1,6 +1,14 @@ Pod::Spec.new do |s| - s.name = "SHOmniAuthFacebook" - s.version = "0.1.0" + name = "SHOmniAuthFacebook" + url ...
Update SHOmniAuth dependency to 0.2.0
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -1,5 +1,6 @@ class ApplicationController < ActionController::Base # Prevent CSRF attacks ...
Disable csrf for tutorial react-native app Tutorial has to send the following header: "X-Auth": "tutorial_secret" and then CSRF is ignored.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -1,29 +1,34 @@ class ApplicationController < ActionController::Base include Pundit pro...
Add callback with redirect for incomplete registrations
diff --git a/app/controllers/letsencrypt_controller.rb b/app/controllers/letsencrypt_controller.rb index abc1234..def5678 100644 --- a/app/controllers/letsencrypt_controller.rb +++ b/app/controllers/letsencrypt_controller.rb @@ -1,5 +1,5 @@ class LetsencryptController < ApplicationController def verify - render t...
Update the lets encrypt verification key.
diff --git a/config/initializers/swagger.rb b/config/initializers/swagger.rb index abc1234..def5678 100644 --- a/config/initializers/swagger.rb +++ b/config/initializers/swagger.rb @@ -5,10 +5,10 @@ } GrapeSwaggerRails.options.doc_expansion = 'list' -GrapeSwaggerRails.options.app_name = ENV['BRAND_NAME'] + ' API doc...
Fix for failing docker builds
diff --git a/app/models/product_type.rb b/app/models/product_type.rb index abc1234..def5678 100644 --- a/app/models/product_type.rb +++ b/app/models/product_type.rb @@ -1,6 +1,6 @@ class ProductType < ActiveRecord::Base acts_as_nested_set #:order => "name" - has_many :products + has_many :products, dependent: :re...
Add dependent: :restrict to has_many
diff --git a/app/routes/unsubscribes.rb b/app/routes/unsubscribes.rb index abc1234..def5678 100644 --- a/app/routes/unsubscribes.rb +++ b/app/routes/unsubscribes.rb @@ -1,6 +1,6 @@ module Citygram::Routes class Unsubscribes < Sinatra::Base - FILTER_WORDS = %w(CANCEL QUIT STOP UNSUBSCRIBE) + FILTER_WORDS = %w(C...
Add STOPALL as filter word Better to be explicit.
diff --git a/test/lib/rails_sso/failure_app_test.rb b/test/lib/rails_sso/failure_app_test.rb index abc1234..def5678 100644 --- a/test/lib/rails_sso/failure_app_test.rb +++ b/test/lib/rails_sso/failure_app_test.rb @@ -16,7 +16,7 @@ env = { 'REQUEST_URI' => 'http://test.host', 'HTTP_HOST' => 'test.host'...
[fix] Adjust test to xhr? in failure app
diff --git a/operable.gemspec b/operable.gemspec index abc1234..def5678 100644 --- a/operable.gemspec +++ b/operable.gemspec @@ -13,12 +13,12 @@ s.summary = 'Arithmetic operations on your models.' s.description = 'Perform addition, subtraction, multiplication and division on your models.' - s.add_dependency 'ac...
Allow to work with Rails RC
diff --git a/app/inputs/unique_input.rb b/app/inputs/unique_input.rb index abc1234..def5678 100644 --- a/app/inputs/unique_input.rb +++ b/app/inputs/unique_input.rb @@ -11,7 +11,7 @@ private def input_field_options - result = {} + result = input_html_options || {} result[:class] = "#{input_html_option...
Include additional passed-in fields when creating the input element.
diff --git a/app/patches/issue_patch.rb b/app/patches/issue_patch.rb index abc1234..def5678 100644 --- a/app/patches/issue_patch.rb +++ b/app/patches/issue_patch.rb @@ -9,8 +9,18 @@ next if assigned_serial_number?(cf) target_custom_value = serial_number_custom_values(cf).first - target_cust...
Fix not have a CustomValue of serial number Error
diff --git a/db/migrate/20170224133932_add_materialised_view_for_valid_taxon_concept_term_view.rb b/db/migrate/20170224133932_add_materialised_view_for_valid_taxon_concept_term_view.rb index abc1234..def5678 100644 --- a/db/migrate/20170224133932_add_materialised_view_for_valid_taxon_concept_term_view.rb +++ b/db/migra...
Add materialized view for valid_taxon_concept_term_view
diff --git a/app/helpers/page_fragments/fragments_helper.rb b/app/helpers/page_fragments/fragments_helper.rb index abc1234..def5678 100644 --- a/app/helpers/page_fragments/fragments_helper.rb +++ b/app/helpers/page_fragments/fragments_helper.rb @@ -1,7 +1,7 @@ module PageFragments::FragmentsHelper def fragments(opti...
Order page fragments when rendering
diff --git a/app/services/cap_quantity_and_store_changes.rb b/app/services/cap_quantity_and_store_changes.rb index abc1234..def5678 100644 --- a/app/services/cap_quantity_and_store_changes.rb +++ b/app/services/cap_quantity_and_store_changes.rb @@ -3,34 +3,42 @@ class CapQuantityAndStoreChanges def initialize(order)...
Split method into higher-level smaller methods
diff --git a/pg_query.gemspec b/pg_query.gemspec index abc1234..def5678 100644 --- a/pg_query.gemspec +++ b/pg_query.gemspec @@ -26,5 +26,5 @@ s.add_development_dependency 'rubocop' s.add_development_dependency 'rubocop-rspec' - s.add_runtime_dependency 'json', '~> 1.8' + s.add_runtime_dependency 'json', '>= 1...
Update JSON gem dependency for Ruby 2.4
diff --git a/test/fixtures/cookbooks/yumserver-test/recipes/default.rb b/test/fixtures/cookbooks/yumserver-test/recipes/default.rb index abc1234..def5678 100644 --- a/test/fixtures/cookbooks/yumserver-test/recipes/default.rb +++ b/test/fixtures/cookbooks/yumserver-test/recipes/default.rb @@ -10,7 +10,7 @@ end yumser...
Switch mirrored repo used for testing
diff --git a/plugins/fstab.rb b/plugins/fstab.rb index abc1234..def5678 100644 --- a/plugins/fstab.rb +++ b/plugins/fstab.rb @@ -13,13 +13,12 @@ entry_hash = Hash.new fstab_entries.each do |entry| line = entry.split - unless line.empty? - entry_hash[line[0]] = { 'mount point' => line[1], - ...
Use next to skip iteration per rubocop
diff --git a/ducksauce.gemspec b/ducksauce.gemspec index abc1234..def5678 100644 --- a/ducksauce.gemspec +++ b/ducksauce.gemspec @@ -8,6 +8,7 @@ gem.version = DuckSauce::VERSION gem.authors = ['Josh Ballanco'] gem.email = ['jballanc@gmail.com'] + gem.license = 'BSD 2-Clause' gem.de...
Set the license in the gemspec
diff --git a/spec/default/java_spec.rb b/spec/default/java_spec.rb index abc1234..def5678 100644 --- a/spec/default/java_spec.rb +++ b/spec/default/java_spec.rb @@ -6,6 +6,6 @@ end describe command('java -version') do - its(:stderr) { should match('1.8.0_25') } + its(:stderr) { should include('1.8.0_25') }...
Change Java version verification method
diff --git a/rss-dcterms.gemspec b/rss-dcterms.gemspec index abc1234..def5678 100644 --- a/rss-dcterms.gemspec +++ b/rss-dcterms.gemspec @@ -6,7 +6,7 @@ gem.email = ["KitaitiMakoto@gmail.com"] gem.description = %q{Enable standard bundled RSS library parse and make feeds including DCMI(Dublin Core Metadat...
Change homepage: Gitorious -> Rubyforge
diff --git a/spec/models/entity_spec.rb b/spec/models/entity_spec.rb index abc1234..def5678 100644 --- a/spec/models/entity_spec.rb +++ b/spec/models/entity_spec.rb @@ -20,4 +20,19 @@ require 'spec_helper' describe Entity do + before { @entity = Fabricate.build(:entity) } + subject { @entity } + + it { should val...
Add tests to completely cover Entity model
diff --git a/spec/seventeen_mon_spec.rb b/spec/seventeen_mon_spec.rb index abc1234..def5678 100644 --- a/spec/seventeen_mon_spec.rb +++ b/spec/seventeen_mon_spec.rb @@ -6,7 +6,7 @@ ipdb_1 = SM::IPDB.instance ipdb_2 = SM::IPDB.instance - ipdb_1.object_id.should == ipdb_2.object_id + expect(ipdb_...
Use the new `:expect` syntax
diff --git a/spec/array_hash_spec.rb b/spec/array_hash_spec.rb index abc1234..def5678 100644 --- a/spec/array_hash_spec.rb +++ b/spec/array_hash_spec.rb @@ -27,6 +27,6 @@ RSpec.describe 'change_value_of_key' do it 'changes the value of the key in the hash' do - expect(change_value_of_key(:favorite_food, 'sushi'...
Remove copy-paste error from test Assuming instructions and example data in lib are correct.
diff --git a/spec/gsl/matrix_spec.rb b/spec/gsl/matrix_spec.rb index abc1234..def5678 100644 --- a/spec/gsl/matrix_spec.rb +++ b/spec/gsl/matrix_spec.rb @@ -0,0 +1,95 @@+require 'spec_helper' + +# Note: test cases at this point all fit inside a uchar (0-127). +# TODO: paramaterize this better to more fully test doubles...
Add minitest spec for some matrix ops.
diff --git a/spec/locamotion_spec.rb b/spec/locamotion_spec.rb index abc1234..def5678 100644 --- a/spec/locamotion_spec.rb +++ b/spec/locamotion_spec.rb @@ -2,7 +2,6 @@ describe "Locamotion" do before do - FileUtils.rm_rf('/tmp/rm_project') FileUtils.mkdir_p('/tmp/rm_project/app') content = <<-eos ...
Clean up test folder after tests ran
diff --git a/spec/models/bug_spec.rb b/spec/models/bug_spec.rb index abc1234..def5678 100644 --- a/spec/models/bug_spec.rb +++ b/spec/models/bug_spec.rb @@ -1,6 +1,10 @@ require 'rails_helper' -describe Bug do +describe Bug, type: :model do + let(:valid_attributes) do + { title: 'My Title', description: 'My Text'...
Improve Tests for Bug User Association Validation
diff --git a/spec/status_api_spec.rb b/spec/status_api_spec.rb index abc1234..def5678 100644 --- a/spec/status_api_spec.rb +++ b/spec/status_api_spec.rb @@ -1,6 +1,43 @@ require 'spec_helper' describe Github::StatusAPI do - + describe "#api" do + before do + @expected_response = { + status_url: "ht...
Add spec for the querying the api urls.
diff --git a/test/integration/binary/serverspec/localhost/binary_spec.rb b/test/integration/binary/serverspec/localhost/binary_spec.rb index abc1234..def5678 100644 --- a/test/integration/binary/serverspec/localhost/binary_spec.rb +++ b/test/integration/binary/serverspec/localhost/binary_spec.rb @@ -3,7 +3,7 @@ require...
Test the right things in binary integration specs Suppose I just copied the source integration specs and then just didn't give a fuck. Oh well.
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -11,6 +11,7 @@ use Rack::Cors do allow do origins '*' + resource '/compile', :headers => :any, :methods => [:post] resource '/compile/*', :headers => :any, :methods => [:post] resource '/builds', :he...
Set up CORS for /compile.