diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/webpacker/webpack_runner.rb b/lib/webpacker/webpack_runner.rb index abc1234..def5678 100644 --- a/lib/webpacker/webpack_runner.rb +++ b/lib/webpacker/webpack_runner.rb @@ -28,7 +28,6 @@ if @argv.delete "--debug-webpacker" cmd = ["node", "--inspect-brk"] + cmd - @argv.delete "--d...
Remove unnecessary call to @argv.delete
diff --git a/rails_script.gemspec b/rails_script.gemspec index abc1234..def5678 100644 --- a/rails_script.gemspec +++ b/rails_script.gemspec @@ -4,7 +4,7 @@ require 'rails_script/version' Gem::Specification.new do |spec| - spec.name = 'rails_script' + spec.name = 'rails-script' spec.version ...
Use the more standard dash instead of underscore in name
diff --git a/spec/minitest/sequel_spec.rb b/spec/minitest/sequel_spec.rb index abc1234..def5678 100644 --- a/spec/minitest/sequel_spec.rb +++ b/spec/minitest/sequel_spec.rb @@ -1,7 +1,23 @@ require 'spec_helper' -class Minitest::SequelTest < Minitest::Test - def test_that_it_has_a_version_number +module Minitest::As...
Add basic Minitest assertions to tets assertions Amazingly these seems to work well!
diff --git a/spec/models/contract_spec.rb b/spec/models/contract_spec.rb index abc1234..def5678 100644 --- a/spec/models/contract_spec.rb +++ b/spec/models/contract_spec.rb @@ -3,53 +3,45 @@ describe Contract do let!(:contract) { Contract.create id: 1, can_id: '123' } - context 'description starts with no caps "w...
Use wrapping describe block to simplify tests (refactor only)
diff --git a/spec/models/spam_log_spec.rb b/spec/models/spam_log_spec.rb index abc1234..def5678 100644 --- a/spec/models/spam_log_spec.rb +++ b/spec/models/spam_log_spec.rb @@ -0,0 +1,11 @@+require 'spec_helper' + +describe SpamLog, models: true do + describe 'associations' do + it { is_expected.to belong_to(:user)...
Add model spec for SpamLog
diff --git a/reclame_aqui.gemspec b/reclame_aqui.gemspec index abc1234..def5678 100644 --- a/reclame_aqui.gemspec +++ b/reclame_aqui.gemspec @@ -13,6 +13,7 @@ spec.description = 'A gem that verify the reputation of a company on ReclameAqui.' spec.homepage = 'https://github.com/givigier/reclame_aqui' spec...
Add ruby 2.3 as required version
diff --git a/figaro.gemspec b/figaro.gemspec index abc1234..def5678 100644 --- a/figaro.gemspec +++ b/figaro.gemspec @@ -11,10 +11,10 @@ gem.homepage = "https://github.com/laserlemon/figaro" gem.license = "MIT" - gem.add_dependency "bundler", "~> 1.0" gem.add_dependency "rails", ">= 3", "< 5" gem.a...
Remove the runtime dependency on Bundler
diff --git a/services/importer/spec/acceptance/cdb_importer_context.rb b/services/importer/spec/acceptance/cdb_importer_context.rb index abc1234..def5678 100644 --- a/services/importer/spec/acceptance/cdb_importer_context.rb +++ b/services/importer/spec/acceptance/cdb_importer_context.rb @@ -7,6 +7,9 @@ @db = pg_co...
Install postgis and postgis_topology if they don't exist (in a cleaner way)
diff --git a/app/models/lot.rb b/app/models/lot.rb index abc1234..def5678 100644 --- a/app/models/lot.rb +++ b/app/models/lot.rb @@ -15,6 +15,6 @@ belongs_to :street def number_and_street - "#{self.number} #{self.street.name}" + "#{number} #{street.name}" end end
Remove redunant reference to self.
diff --git a/spec/itamae/plugin/resource/encrypted_remote_file_spec.rb b/spec/itamae/plugin/resource/encrypted_remote_file_spec.rb index abc1234..def5678 100644 --- a/spec/itamae/plugin/resource/encrypted_remote_file_spec.rb +++ b/spec/itamae/plugin/resource/encrypted_remote_file_spec.rb @@ -20,7 +20,7 @@ subject {...
Fix test failed : itamae 1.2.13 -> 1.2.14
diff --git a/lib/childprocess/jruby/process.rb b/lib/childprocess/jruby/process.rb index abc1234..def5678 100644 --- a/lib/childprocess/jruby/process.rb +++ b/lib/childprocess/jruby/process.rb @@ -30,13 +30,18 @@ private - def launch_process + def launch_process(&blk) pb = java.lang.Process...
Handle writing to stdin with JRuby.
diff --git a/lib/hanoi.rb b/lib/hanoi.rb index abc1234..def5678 100644 --- a/lib/hanoi.rb +++ b/lib/hanoi.rb @@ -7,4 +7,7 @@ [1, 2, 3] end end + + class Tower + end end
Test update now fails correctly
diff --git a/lib/frepl.rb b/lib/frepl.rb index abc1234..def5678 100644 --- a/lib/frepl.rb +++ b/lib/frepl.rb @@ -22,7 +22,7 @@ def initialize Frepl.compiler = 'gfortran' - Frepl.debug = true + Frepl.debug = false @classifier = Classifier.new @file = FortranFile.new @lines = [...
Debug mode is off by default.
diff --git a/spec/classes/mod/wsgi_spec.rb b/spec/classes/mod/wsgi_spec.rb index abc1234..def5678 100644 --- a/spec/classes/mod/wsgi_spec.rb +++ b/spec/classes/mod/wsgi_spec.rb @@ -25,5 +25,12 @@ it { should include_class("apache::params") } it { should contain_apache__mod('wsgi') } it { should contain_pa...
Add spec test for custom WSGISocketPrefix
diff --git a/db/migrate/20160531042449_remove_sub_splits.rb b/db/migrate/20160531042449_remove_sub_splits.rb index abc1234..def5678 100644 --- a/db/migrate/20160531042449_remove_sub_splits.rb +++ b/db/migrate/20160531042449_remove_sub_splits.rb @@ -1,7 +1,6 @@ class RemoveSubSplits < ActiveRecord::Migration def se...
Delete foreign key remove command from remove_sub_splits migration (allows heroku to remove the table despite its not having a foreign key)
diff --git a/spec/support/child_benefit.rb b/spec/support/child_benefit.rb index abc1234..def5678 100644 --- a/spec/support/child_benefit.rb +++ b/spec/support/child_benefit.rb @@ -1,7 +1,7 @@ RSpec::Matchers::define :contain_child_benefit_value do |text| match do |page| within ".results" do - within :xpat...
Correct matcher to search for h3 rather than h2
diff --git a/lib/docs/scrapers/phalcon.rb b/lib/docs/scrapers/phalcon.rb index abc1234..def5678 100644 --- a/lib/docs/scrapers/phalcon.rb +++ b/lib/docs/scrapers/phalcon.rb @@ -1,8 +1,6 @@ module Docs class Phalcon < UrlScraper self.type = 'phalcon' - self.release = '3.0.0' - self.base_url = 'https://docs...
Update Phalcon documentation (3.0.1, 2.0.13)
diff --git a/app/models/cocoa_pod.rb b/app/models/cocoa_pod.rb index abc1234..def5678 100644 --- a/app/models/cocoa_pod.rb +++ b/app/models/cocoa_pod.rb @@ -13,9 +13,9 @@ def serializable_hash h = super - h['pushed_at'] = h['pushed_at'].to_s - h['created_at'] = h['created_at'].to_s - h['updated_at']...
Clean serializable hash for cocoa pod.
diff --git a/app/models/lab_group.rb b/app/models/lab_group.rb index abc1234..def5678 100644 --- a/app/models/lab_group.rb +++ b/app/models/lab_group.rb @@ -2,4 +2,5 @@ has_and_belongs_to_many :registered_courses has_many :labs, through: :lab_has_group has_many :submissions, through: :lab_has_group + accepts_n...
Add nested attributes for labhasgroups
diff --git a/app/normalizers/base.rb b/app/normalizers/base.rb index abc1234..def5678 100644 --- a/app/normalizers/base.rb +++ b/app/normalizers/base.rb @@ -44,8 +44,10 @@ [] end + SEPARATOR = ' - '.freeze + def separator - ' - ' + SEPARATOR end def valid?
Replace string literal with a frozen constant To prevent new objects spawning.
diff --git a/app/tasks/fetch_feed.rb b/app/tasks/fetch_feed.rb index abc1234..def5678 100644 --- a/app/tasks/fetch_feed.rb +++ b/app/tasks/fetch_feed.rb @@ -21,10 +21,10 @@ new_entries_from(raw_feed).each do |entry| StoryRepository.add(entry, @feed) end + + FeedRepository.update_last_...
Revert "Obviously we should update last_fetched when nothing has changed" This reverts commit 25a603083cf613ace7bcb327bb4656ac113a8093. Actually we do not want this. We should only update that timestamp to what we get back from the feed.
diff --git a/bin/check_smtp.rb b/bin/check_smtp.rb index abc1234..def5678 100644 --- a/bin/check_smtp.rb +++ b/bin/check_smtp.rb @@ -11,7 +11,5 @@ ::CryptCheck::Tls::Smtp.analyze_file file, "output/#{name}.html" else ::CryptCheck::Logger.level = ENV['LOG'] || :info - ::CryptCheck::Tls::Smtp.analyze ARGV[0] + ::Cryp...
Check for MX and not directly the IP for SMTP
diff --git a/amazon-drs.gemspec b/amazon-drs.gemspec index abc1234..def5678 100644 --- a/amazon-drs.gemspec +++ b/amazon-drs.gemspec @@ -4,10 +4,10 @@ require 'amazon-drs/version' Gem::Specification.new do |spec| - spec.name = "amazon-drs" + spec.name = 'amazon-drs' spec.version = Amazon...
Use single quote in .gemspec
diff --git a/amf_socket.gemspec b/amf_socket.gemspec index abc1234..def5678 100644 --- a/amf_socket.gemspec +++ b/amf_socket.gemspec @@ -4,7 +4,7 @@ Gem::Specification.new do |gem| gem.authors = ["Chad Remesch"] gem.email = ["chad@remesch.com"] - gem.description = %q{Ruby implementation of AMF So...
Add amf socket url to gemspec
diff --git a/lib/integrity.rb b/lib/integrity.rb index abc1234..def5678 100644 --- a/lib/integrity.rb +++ b/lib/integrity.rb @@ -17,7 +17,7 @@ DataMapper.setup(:default, config[:database_uri]) end - autoload :Models, 'models' + autoload :Project, 'project' autoload :Builder, 'builder' autoload :SCM, ...
Fix autoload for Project, instead of Models
diff --git a/lib/io_actors.rb b/lib/io_actors.rb index abc1234..def5678 100644 --- a/lib/io_actors.rb +++ b/lib/io_actors.rb @@ -1,6 +1,6 @@ require "io_actors/version" -require 'concurrent' +require 'concurrent/actor' module IOActors SelectMessage = Struct.new(:actor)
Reduce the code dependency to just the actors code
diff --git a/lib/ruby-rets.rb b/lib/ruby-rets.rb index abc1234..def5678 100644 --- a/lib/ruby-rets.rb +++ b/lib/ruby-rets.rb @@ -1,3 +1,4 @@+require "rets/version" require "rets/exceptions" require "rets/client" require "rets/http"
Make sure we load rets/version.rb
diff --git a/lib/stoplight.rb b/lib/stoplight.rb index abc1234..def5678 100644 --- a/lib/stoplight.rb +++ b/lib/stoplight.rb @@ -11,33 +11,6 @@ module Stoplight VERSION = Gem::Version.new('0.0.0') - - module_function - - def data_store(data_store = nil) - @data_store = data_store if data_store - @data_stor...
Define module functions in class block
diff --git a/test/ubuntu12.rb b/test/ubuntu12.rb index abc1234..def5678 100644 --- a/test/ubuntu12.rb +++ b/test/ubuntu12.rb @@ -1,4 +1,7 @@ # Use a Linux image vagrant_box 'precise64' do - url 'http://files.vagrantup.com/precise64.box' + url 'http://files.vagrantup.com/precise64.box' + provisioner_options 'vagran...
Use vagrant mounting to install metal and metal-lxc from the host
diff --git a/Treasure.podspec b/Treasure.podspec index abc1234..def5678 100644 --- a/Treasure.podspec +++ b/Treasure.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'Treasure' - s.version = '0.1.6' + s.version = '0.1.7' s.summary = 'A small set of tools for deseriali...
Increase version number to 0.1.7
diff --git a/lib/everypolitician/popolo/collection.rb b/lib/everypolitician/popolo/collection.rb index abc1234..def5678 100644 --- a/lib/everypolitician/popolo/collection.rb +++ b/lib/everypolitician/popolo/collection.rb @@ -24,9 +24,7 @@ def where(attributes = {}) find_all do |object| - !attr...
Make method much simpler and readable
diff --git a/lib/arabic_conjugator/form.rb b/lib/arabic_conjugator/form.rb index abc1234..def5678 100644 --- a/lib/arabic_conjugator/form.rb +++ b/lib/arabic_conjugator/form.rb @@ -1,8 +1,3 @@-# encoding: utf-8 - -PAST_AFFIXES = { :I => "ت", :you_m => "ت", :you_f => "ت", :she => "ت" , :he =>'', :we => "نا", :you_pl => ...
Remove Affixes from Form class
diff --git a/lib/auto_set/active_record.rb b/lib/auto_set/active_record.rb index abc1234..def5678 100644 --- a/lib/auto_set/active_record.rb +++ b/lib/auto_set/active_record.rb @@ -1,15 +1,6 @@ module AutoSet module ActiveRecord extend ActiveSupport::Concern - - private - - def auto_set_parent_by_code(col...
Remove code that has been moved.
diff --git a/lib/droplr/errors/droplr_error.rb b/lib/droplr/errors/droplr_error.rb index abc1234..def5678 100644 --- a/lib/droplr/errors/droplr_error.rb +++ b/lib/droplr/errors/droplr_error.rb @@ -1,12 +1,13 @@ module Droplr class DroplrError < StandardError - attr_reader :message, :error_code, :http_status, :jso...
Allow for additional info in an error message. This gives us the ability to pass back a theme when receiving a password-required error.
diff --git a/core/lib/generators/refinery/form/templates/spec/requests/refinery/plural_name/plural_name_requests_spec.rb b/core/lib/generators/refinery/form/templates/spec/requests/refinery/plural_name/plural_name_requests_spec.rb index abc1234..def5678 100644 --- a/core/lib/generators/refinery/form/templates/spec/requ...
Call load_seed on every request spec - this was causing an intermittent test failure
diff --git a/lib/hookie/plugins/base_plugin.rb b/lib/hookie/plugins/base_plugin.rb index abc1234..def5678 100644 --- a/lib/hookie/plugins/base_plugin.rb +++ b/lib/hookie/plugins/base_plugin.rb @@ -5,7 +5,7 @@ @config = {} @framework.config.map do |k,v| - if k.start_with?("hooks.#{self.config_key}"...
Change config key base read into plugin
diff --git a/lib/languages/norsk/past_tense.rb b/lib/languages/norsk/past_tense.rb index abc1234..def5678 100644 --- a/lib/languages/norsk/past_tense.rb +++ b/lib/languages/norsk/past_tense.rb @@ -0,0 +1,9 @@+# encoding: UTF-8 + +class NorskPastTense < NorskTense + @keys = "past", "fortid" + + def self.specific_conju...
Add a stub past tense class. Needs conjugation rules, but will ensure we pass some of the failing tenses (for tense lists, etc.)
diff --git a/lib/modular/mst_rendering.rb b/lib/modular/mst_rendering.rb index abc1234..def5678 100644 --- a/lib/modular/mst_rendering.rb +++ b/lib/modular/mst_rendering.rb @@ -1,10 +1,12 @@ module Modular + class Template < ::Mustache + end + module MstRendering def render - path = Rails.root + "app/vie...
Rewrite some mustache-specific code to make contextual includes work
diff --git a/lib/quick_travel/resource.rb b/lib/quick_travel/resource.rb index abc1234..def5678 100644 --- a/lib/quick_travel/resource.rb +++ b/lib/quick_travel/resource.rb @@ -15,17 +15,6 @@ QuickTravel::ProductType.find(product_type_id) end - # this method is also duplicated in accommodation class. be...
Remove unused method (this is done in setter in accommodation.rb)
diff --git a/lib/rembrandt/highlighter.rb b/lib/rembrandt/highlighter.rb index abc1234..def5678 100644 --- a/lib/rembrandt/highlighter.rb +++ b/lib/rembrandt/highlighter.rb @@ -1,4 +1,4 @@-require './lib/rembrandt/engines/pygmentize' +require_relative 'engines/pygmentize' module Rembrandt class Highlighter
Fix relative path when used in other apps
diff --git a/tidy_ffi.gemspec b/tidy_ffi.gemspec index abc1234..def5678 100644 --- a/tidy_ffi.gemspec +++ b/tidy_ffi.gemspec @@ -18,5 +18,5 @@ s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } s.require_paths = ["lib"] - s.add_dependency 'ffi', "~> 1.2.0" + s.add_dependency 'ffi...
Allow wider range of FFI dependency The latest version of FFI for ruby 1.8.3 series is 1.9.6 (tests still pass using this newer FFI version).. This doesn't change anything for existing installs but will allow wider compatibility.
diff --git a/lib/upstream/tracker/init.rb b/lib/upstream/tracker/init.rb index abc1234..def5678 100644 --- a/lib/upstream/tracker/init.rb +++ b/lib/upstream/tracker/init.rb @@ -45,6 +45,7 @@ File.open(path, "w+") do |file| file.puts(html[:data]) end + html end end
Return html data and charset as hash
diff --git a/lib/podio/models/item_diff.rb b/lib/podio/models/item_diff.rb index abc1234..def5678 100644 --- a/lib/podio/models/item_diff.rb +++ b/lib/podio/models/item_diff.rb @@ -4,6 +4,7 @@ property :type, :string property :external_id, :string property :label, :string + property :config, :hash property ...
Add config to item diff model
diff --git a/spec/nio/selector_spec.rb b/spec/nio/selector_spec.rb index abc1234..def5678 100644 --- a/spec/nio/selector_spec.rb +++ b/spec/nio/selector_spec.rb @@ -8,18 +8,44 @@ monitor.should be_a NIO::Monitor end - it "selects objects for readiness" do - unready_pipe, _ = IO.pipe - ready_pipe, ready_...
Break apart specs for different types of IO objects
diff --git a/app/models/stop.rb b/app/models/stop.rb index abc1234..def5678 100644 --- a/app/models/stop.rb +++ b/app/models/stop.rb @@ -22,7 +22,7 @@ end def self.near(location) - Stop.geo_near(location).max_distance(0.00098) + Stop.geo_near(location).max_distance(0.01) end end
Adjust radius for near method
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -11,8 +11,8 @@ has_many :active_friends, -> { where(friendships: { approved: true }) }, through: :friendships, source: :friend has_many :passive_friends, -> { where(friendships:...
Rename association names to make it more clear
diff --git a/plugin.rb b/plugin.rb index abc1234..def5678 100644 --- a/plugin.rb +++ b/plugin.rb @@ -22,6 +22,7 @@ class DiscourseTranslator::TranslatorController < ::ApplicationController def translate raise PluginDisabled if !SiteSetting.translator_enabled + RateLimiter.new(current_user, "translate...
Add rate limiter for translation.
diff --git a/rails/init.rb b/rails/init.rb index abc1234..def5678 100644 --- a/rails/init.rb +++ b/rails/init.rb @@ -1,6 +1,6 @@ require File.join(File.dirname(__FILE__), *%w{ .. lib geos_extensions }) -require File.join(File.dirname(__FILE__), *%w{ .. lib active_record_extensions connection_adapters postgresql_adapt...
Use constant to pull in files.
diff --git a/spec/unit/printer_spec.rb b/spec/unit/printer_spec.rb index abc1234..def5678 100644 --- a/spec/unit/printer_spec.rb +++ b/spec/unit/printer_spec.rb @@ -11,4 +11,11 @@ cmd = TTY::Command.new(printer: :progress) expect(cmd.printer).to be_an_instance_of(TTY::Command::Printers::Progress) end + + i...
Test passing printer class name.
diff --git a/activerecord/test/cases/adapters/postgresql/case_insensitive_test.rb b/activerecord/test/cases/adapters/postgresql/case_insensitive_test.rb index abc1234..def5678 100644 --- a/activerecord/test/cases/adapters/postgresql/case_insensitive_test.rb +++ b/activerecord/test/cases/adapters/postgresql/case_insensi...
Fix `warning: ambiguous first argument` ``` test/cases/adapters/postgresql/case_insensitive_test.rb:12: warning: ambiguous first argument; put parentheses or a space even after `/' operator test/cases/adapters/postgresql/case_insensitive_test.rb:16: warning: ambiguous first argument; put parentheses or a space even af...
diff --git a/tests/hp/requests/compute/security_group_rule_tests.rb b/tests/hp/requests/compute/security_group_rule_tests.rb index abc1234..def5678 100644 --- a/tests/hp/requests/compute/security_group_rule_tests.rb +++ b/tests/hp/requests/compute/security_group_rule_tests.rb @@ -0,0 +1,54 @@+Shindo.tests('Fog::Compute...
Add tests for security group rules.
diff --git a/roles/web-backend.rb b/roles/web-backend.rb index abc1234..def5678 100644 --- a/roles/web-backend.rb +++ b/roles/web-backend.rb @@ -7,6 +7,9 @@ :worker => { :max_requests_per_child => 10000 } + }, + :apt => { + :sources => ["openstreetmap-cgimap"] }, :logstash => { :forwarde...
Add cgimap PPA repo on backends.
diff --git a/mtif.gemspec b/mtif.gemspec index abc1234..def5678 100644 --- a/mtif.gemspec +++ b/mtif.gemspec @@ -21,4 +21,5 @@ spec.add_development_dependency "bundler", "~> 1.7" spec.add_development_dependency "rake", "~> 10.0" spec.add_development_dependency "rspec" + spec.add_development_dependency "simplec...
Add coverage to guide testing
diff --git a/app/controllers/storytime/subscriptions_controller.rb b/app/controllers/storytime/subscriptions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/storytime/subscriptions_controller.rb +++ b/app/controllers/storytime/subscriptions_controller.rb @@ -5,8 +5,9 @@ before_action :set_subscrip...
Allow an usubscribed user to resubscribe
diff --git a/app/decorators/container_service_decorator.rb b/app/decorators/container_service_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/container_service_decorator.rb +++ b/app/decorators/container_service_decorator.rb @@ -5,7 +5,7 @@ def single_quad { - :fileicon => fileicon + ...
Fix missing single_quad for container services
diff --git a/features/step_definitions/authentication_steps.rb b/features/step_definitions/authentication_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/authentication_steps.rb +++ b/features/step_definitions/authentication_steps.rb @@ -1,3 +1,19 @@ Given /^I am registered$/ do @registered_us...
Add 'I am admin' & 'I am logged in as admin' steps.
diff --git a/mrblib/pi.rb b/mrblib/pi.rb index abc1234..def5678 100644 --- a/mrblib/pi.rb +++ b/mrblib/pi.rb @@ -1,36 +1,48 @@ class Pi class Pin - attr:@pin_num + attr:pin_num def initialize(num, mode ="in") @pin_num = num File.open("/sys/class/gpio/export","w"){|f| f.write("#{@pin...
Add up and close methods
diff --git a/app/policies/form_answer_attachment_policy.rb b/app/policies/form_answer_attachment_policy.rb index abc1234..def5678 100644 --- a/app/policies/form_answer_attachment_policy.rb +++ b/app/policies/form_answer_attachment_policy.rb @@ -1,15 +1,14 @@ class FormAnswerAttachmentPolicy < ApplicationPolicy - # TOD...
Clarify the form answer attachment policy
diff --git a/app/uploaders/campaign_hero_image_uploader.rb b/app/uploaders/campaign_hero_image_uploader.rb index abc1234..def5678 100644 --- a/app/uploaders/campaign_hero_image_uploader.rb +++ b/app/uploaders/campaign_hero_image_uploader.rb @@ -0,0 +1,15 @@+class CampaignHeroImageUploader < CarrierWave::Uploader::Base ...
Add uploader for campaign hero images
diff --git a/motion/test_suite_delegate.rb b/motion/test_suite_delegate.rb index abc1234..def5678 100644 --- a/motion/test_suite_delegate.rb +++ b/motion/test_suite_delegate.rb @@ -4,6 +4,7 @@ def application(application, didFinishLaunchingWithOptions:launchOptions) @window = UIWindow.alloc.initWithFrame(UIScree...
Make window visible during tests Some functional tests don't work without it
diff --git a/buildr-jaxb-xjc.gemspec b/buildr-jaxb-xjc.gemspec index abc1234..def5678 100644 --- a/buildr-jaxb-xjc.gemspec +++ b/buildr-jaxb-xjc.gemspec @@ -0,0 +1,23 @@+require File.expand_path(File.dirname(__FILE__) + '/lib/buildr/jaxb_xjc/version') + +Gem::Specification.new do |spec| + spec.name = 'buildr...
Add in a minimalistic gemspec
diff --git a/test/test_shell_command.rb b/test/test_shell_command.rb index abc1234..def5678 100644 --- a/test/test_shell_command.rb +++ b/test/test_shell_command.rb @@ -40,4 +40,17 @@ end end + context 'run!' do + it 'must raise a exception when a command fails.' do + proc { + ShellCommand.run!...
Add some tests for ShellCommand.run!(…).
diff --git a/itamae.gemspec b/itamae.gemspec index abc1234..def5678 100644 --- a/itamae.gemspec +++ b/itamae.gemspec @@ -18,13 +18,13 @@ spec.require_paths = ["lib"] spec.add_runtime_dependency "thor" - spec.add_runtime_dependency "specinfra", "2.0.0" + spec.add_runtime_dependency "specinfra", "~> 2.1.0" sp...
Use specinfra and serverspec ~> 2.1.0.
diff --git a/spec/dummy/config/initializers/mongoid.rb b/spec/dummy/config/initializers/mongoid.rb index abc1234..def5678 100644 --- a/spec/dummy/config/initializers/mongoid.rb +++ b/spec/dummy/config/initializers/mongoid.rb @@ -1,7 +1,7 @@ require 'mongoid' Mongoid.configure do |config| - name = "dummy_developme...
Change datables based on ENV
diff --git a/spec/rubocop/cop/lint/else_layout_spec.rb b/spec/rubocop/cop/lint/else_layout_spec.rb index abc1234..def5678 100644 --- a/spec/rubocop/cop/lint/else_layout_spec.rb +++ b/spec/rubocop/cop/lint/else_layout_spec.rb @@ -54,12 +54,12 @@ end it 'handles ternary ops' do - inspect_source(cop, ['x ? a : b...
Simplify a couple of inspect_source invocations in specs
diff --git a/lib/boxen/preflight/rvm.rb b/lib/boxen/preflight/rvm.rb index abc1234..def5678 100644 --- a/lib/boxen/preflight/rvm.rb +++ b/lib/boxen/preflight/rvm.rb @@ -2,8 +2,8 @@ class Boxen::Preflight::RVM < Boxen::Preflight def run - warn "You have an rvm installed in ~/.rvm.", - "The Setup uses rbenv ...
Abort if RVM is found
diff --git a/0_code_wars/time_converter.rb b/0_code_wars/time_converter.rb index abc1234..def5678 100644 --- a/0_code_wars/time_converter.rb +++ b/0_code_wars/time_converter.rb @@ -0,0 +1,5 @@+# http://www.codewars.com/kata/56b8b0ae1d36bb86b2000eaa/ +# --- iteration 1 --- +def convert(time) + time.strftime("%H:%M:%S,%...
Add code wars (7) time converter
diff --git a/tablebuilder.gemspec b/tablebuilder.gemspec index abc1234..def5678 100644 --- a/tablebuilder.gemspec +++ b/tablebuilder.gemspec @@ -11,6 +11,7 @@ s.homepage = "" s.summary = %q{A simple but flexible table builder for Rails 3} s.description = %q{Provides a table builder for your Rails views t...
Set license in gemspec to MIT
diff --git a/bin/tic_tac_toe.ru b/bin/tic_tac_toe.ru index abc1234..def5678 100644 --- a/bin/tic_tac_toe.ru +++ b/bin/tic_tac_toe.ru @@ -1,3 +1,4 @@ require 'tic_tac_toe' +use Rack::Static, :urls => ["/css", "/images"], :root => "public" run TicTacToe::RackShell.new_shell
Configure my app to serve static css and image files
diff --git a/lib/console_game_engine.rb b/lib/console_game_engine.rb index abc1234..def5678 100644 --- a/lib/console_game_engine.rb +++ b/lib/console_game_engine.rb @@ -7,6 +7,7 @@ def initialize(args) @gametype = args.fetch(:gametype, nil) @rules = args.fetch(:rules, nil) + @first_player = args.fetch(:f...
Add instance variable for firstplayer
diff --git a/refinerycms-testimonials.gemspec b/refinerycms-testimonials.gemspec index abc1234..def5678 100644 --- a/refinerycms-testimonials.gemspec +++ b/refinerycms-testimonials.gemspec @@ -3,7 +3,7 @@ Gem::Specification.new do |s| s.platform = Gem::Platform::RUBY s.name = 'refinerycms-te...
Remove String from Gemspec version
diff --git a/lib/generators/tolaria/install/templates/administrators_migration.rb b/lib/generators/tolaria/install/templates/administrators_migration.rb index abc1234..def5678 100644 --- a/lib/generators/tolaria/install/templates/administrators_migration.rb +++ b/lib/generators/tolaria/install/templates/administrators_...
Set null:false for the timestamps column to prevent Rails warning
diff --git a/konjak.gemspec b/konjak.gemspec index abc1234..def5678 100644 --- a/konjak.gemspec +++ b/konjak.gemspec @@ -18,6 +18,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] + spec.add_dependency 'nokogiri' spec.add_development_dependency "bundler", "~> ...
Add nokogiri to gem dependency
diff --git a/yubioath.gemspec b/yubioath.gemspec index abc1234..def5678 100644 --- a/yubioath.gemspec +++ b/yubioath.gemspec @@ -11,9 +11,8 @@ spec.homepage = 'https://github.com/jamesottaway/yubioath' spec.license = 'MIT' - spec.files = `git ls-files -z`.split("\x0") - spec.executables = ...
Update the gemspec to match the latest Bundler template
diff --git a/utils/wrapper.rb b/utils/wrapper.rb index abc1234..def5678 100644 --- a/utils/wrapper.rb +++ b/utils/wrapper.rb @@ -12,6 +12,7 @@ @@count = 0 def handle_valid_record(record, data_type) if ENV['RUN_TYPE'] == "draft" && @@count > MAX_DRAFT_ROWS + sleep 5 # allow some time for OS to flush buffe...
Allow early-terminating run to flush buffer before terminating. Without this, we would get a broken pipe.
diff --git a/lib/promise.rb b/lib/promise.rb index abc1234..def5678 100644 --- a/lib/promise.rb +++ b/lib/promise.rb @@ -58,10 +58,10 @@ end end - def reject(reason = nil, backtrace = nil) + def reject(reason = Error, backtrace = nil) dispatch(backtrace) do @state = :rejected - @reason = rea...
Set default reason in arglist, previously counted as ControlParameter
diff --git a/app/helpers/access_helper.rb b/app/helpers/access_helper.rb index abc1234..def5678 100644 --- a/app/helpers/access_helper.rb +++ b/app/helpers/access_helper.rb @@ -7,7 +7,7 @@ end def flash_msg - flash[:error] = "This #{current_role_name.downcase} is not allowed to #{params[:action]} this #{pa...
Fix the error message reported by Airbrake: Error Message: NoMethodError: undefined method `downcase' for nil:NilClass Where: submitted_content#edit [PROJECT_ROOT]/app/helpers/access_helper.rb, line 10
diff --git a/lib/taskmapper-basecamp.rb b/lib/taskmapper-basecamp.rb index abc1234..def5678 100644 --- a/lib/taskmapper-basecamp.rb +++ b/lib/taskmapper-basecamp.rb @@ -1,4 +1,21 @@ require File.dirname(__FILE__) + '/basecamp/basecamp.rb' + +# Monkey patch for backward compatibility issue with type cast on xml response...
Add a monkey patch to deal wth the current version of actire resource xml parsing lib
diff --git a/lib/tasks/osm_rubocop.rake b/lib/tasks/osm_rubocop.rake index abc1234..def5678 100644 --- a/lib/tasks/osm_rubocop.rake +++ b/lib/tasks/osm_rubocop.rake @@ -11,11 +11,7 @@ root = defined?(::Rails.root) ? ::Rails.root : Dir.pwd target = File.join(root, '.git', 'hooks', 'pre-commit') - # rubocop...
Remove a rubocop:disable comment that was a workaround for a bug that is now fixed
diff --git a/app/models/duckrails/mock.rb b/app/models/duckrails/mock.rb index abc1234..def5678 100644 --- a/app/models/duckrails/mock.rb +++ b/app/models/duckrails/mock.rb @@ -1,4 +1,7 @@ class Duckrails::Mock < ActiveRecord::Base + BODY_TYPE_EMBEDDED_RUBY = 'embedded_ruby' + BODY_TYPE_STATIC = 'static' + has_man...
Use constants for possible body types.
diff --git a/lib/travis/notification.rb b/lib/travis/notification.rb index abc1234..def5678 100644 --- a/lib/travis/notification.rb +++ b/lib/travis/notification.rb @@ -9,7 +9,7 @@ attr_accessor :publishers def setup(options = { instrumentation: true }) - Travis::Instrumentation.setup if options[:...
Revert "fix code accessing Travis.config.metrics" This reverts commit 35ce47154089c9ad71809a4fabad1e4e13fb6bf8.
diff --git a/lib/vagrant-list/plugin.rb b/lib/vagrant-list/plugin.rb index abc1234..def5678 100644 --- a/lib/vagrant-list/plugin.rb +++ b/lib/vagrant-list/plugin.rb @@ -23,7 +23,7 @@ control of vagrant boxes. DESC - command(:list) do + command "list" do require_relative 'command' ...
Use string for command instead of symbol
diff --git a/lib/generators/data_migration/templates/data_migration.rb b/lib/generators/data_migration/templates/data_migration.rb index abc1234..def5678 100644 --- a/lib/generators/data_migration/templates/data_migration.rb +++ b/lib/generators/data_migration/templates/data_migration.rb @@ -1,5 +1,6 @@ class <%= migra...
Comment where to put migration code in the template
diff --git a/cookbooks/travis_docker/attributes/default.rb b/cookbooks/travis_docker/attributes/default.rb index abc1234..def5678 100644 --- a/cookbooks/travis_docker/attributes/default.rb +++ b/cookbooks/travis_docker/attributes/default.rb @@ -1,4 +1,4 @@-default['travis_docker']['version'] = '1.9.1-0~trusty' +default...
Update Docker to 1.10.3 and Docker Compose to 1.6.2
diff --git a/spec/base.rb b/spec/base.rb index abc1234..def5678 100644 --- a/spec/base.rb +++ b/spec/base.rb @@ -5,7 +5,6 @@ Encoding.default_internal = Encoding.default_external = "ASCII-8BIT" if is_ruby_19? require 'rubygems' -require 'spec' begin require "ruby-debug"
Remove "require 'spec'" for rspec 2 compatability.
diff --git a/db/migrate/20120307152935_create_sentences.rb b/db/migrate/20120307152935_create_sentences.rb index abc1234..def5678 100644 --- a/db/migrate/20120307152935_create_sentences.rb +++ b/db/migrate/20120307152935_create_sentences.rb @@ -5,6 +5,8 @@ t.string :name, :null => false t.text :text, :null...
Add columns to sentence tables
diff --git a/src/app/models/cloud_account_observer.rb b/src/app/models/cloud_account_observer.rb index abc1234..def5678 100644 --- a/src/app/models/cloud_account_observer.rb +++ b/src/app/models/cloud_account_observer.rb @@ -1,7 +1,31 @@ class CloudAccountObserver < ActiveRecord::Observer def after_create(account) +...
Create bucket for images on cloud provider side The newer boxgrinder uses euca2ools instead of ec2-ami-tools to build and upload ec2 images. Ec2-ami-tools used to automatically create a amazon s3 bucket where images are uploaded, euca2ools doesn't. In future boxgrinder should take care of creation bucket but this will...
diff --git a/0_code_wars/left_and_right.rb b/0_code_wars/left_and_right.rb index abc1234..def5678 100644 --- a/0_code_wars/left_and_right.rb +++ b/0_code_wars/left_and_right.rb @@ -0,0 +1,18 @@+# http://www.codewars.com/kata/left$-and-right$/ +# --- iteration 1 --- +def left(str, i = nil) + if i.nil? + return str[0...
Add code wars (7) left and right
diff --git a/vmdb/db/migrate/20141126161823_convert_show_refresh_button_and_load_values_on_init_to_real_columns_for_dialog_fields.rb b/vmdb/db/migrate/20141126161823_convert_show_refresh_button_and_load_values_on_init_to_real_columns_for_dialog_fields.rb index abc1234..def5678 100644 --- a/vmdb/db/migrate/2014112616182...
Add say_with_time for benchmarking conversion of options to columns
diff --git a/blacklight_hierarchy.gemspec b/blacklight_hierarchy.gemspec index abc1234..def5678 100644 --- a/blacklight_hierarchy.gemspec +++ b/blacklight_hierarchy.gemspec @@ -17,6 +17,6 @@ s.test_files = Dir["test/**/*"] s.add_dependency "rails", "~> 3.2.0" - s.add_dependency "blacklight", "~> 3.2.0" + s.add...
Update dependencies to work with Blacklight ~>3.2
diff --git a/spec/views/capital_projects/_index_table.html.haml_spec.rb b/spec/views/capital_projects/_index_table.html.haml_spec.rb index abc1234..def5678 100644 --- a/spec/views/capital_projects/_index_table.html.haml_spec.rb +++ b/spec/views/capital_projects/_index_table.html.haml_spec.rb @@ -6,6 +6,7 @@ test_pr...
Update capital projects table view spec to fix broken test.
diff --git a/Casks/maciasl.rb b/Casks/maciasl.rb index abc1234..def5678 100644 --- a/Casks/maciasl.rb +++ b/Casks/maciasl.rb @@ -1,13 +1,21 @@ cask :v1 => 'maciasl' do - version '1.4' - sha256 '24c0dbaa9a13231b8c8e364ef0e6d60656718320ce69d8bb23aa5bc27e82e87d' + if MacOS.release == :lion + version '1.3' + sha25...
Improve MaciASL.app version check for Mac OS X Lion
diff --git a/spec/integration/upload_spec.rb b/spec/integration/upload_spec.rb index abc1234..def5678 100644 --- a/spec/integration/upload_spec.rb +++ b/spec/integration/upload_spec.rb @@ -14,7 +14,7 @@ attach_file('File', File.expand_path('spec/assets/chicken_rice.jpg')) click_button 'Upload image' - cur...
Use eq instead of should_be, fix expected value
diff --git a/app/controllers/named_routes_controller.rb b/app/controllers/named_routes_controller.rb index abc1234..def5678 100644 --- a/app/controllers/named_routes_controller.rb +++ b/app/controllers/named_routes_controller.rb @@ -1,10 +1,11 @@ class NamedRoutesController < ActionController::Base - caches_page :gene...
Change page caching to HTTP caching for Heroku
diff --git a/spec/will-paginate-i18n_spec.rb b/spec/will-paginate-i18n_spec.rb index abc1234..def5678 100644 --- a/spec/will-paginate-i18n_spec.rb +++ b/spec/will-paginate-i18n_spec.rb @@ -3,6 +3,6 @@ Dir.glob('locales/*.yml').each do |locale_file| describe 'a locale file' do it_behaves_like 'a valid locale fil...
Use en as the source locale (instead of en-US)
diff --git a/balanced.gemspec b/balanced.gemspec index abc1234..def5678 100644 --- a/balanced.gemspec +++ b/balanced.gemspec @@ -10,7 +10,7 @@ gem.summary = %q{https://docs.balancedpayments.com/} gem.homepage = "https://www.balancedpayments.com" - gem.add_dependency("faraday", ['>= 0.8.6', '< 0.10'])...
Reduce upper Faraday bounds to <= 0.9.0
diff --git a/gateway/sqlite_gateway.rb b/gateway/sqlite_gateway.rb index abc1234..def5678 100644 --- a/gateway/sqlite_gateway.rb +++ b/gateway/sqlite_gateway.rb @@ -26,13 +26,30 @@ to_transaction @db[:transactions][:id => id] end - def save(debit) + def save(o) + case o + when Debit + save_debit o...
Add methods to gateway to support importing transactions
diff --git a/templates/chromedriver.rb b/templates/chromedriver.rb index abc1234..def5678 100644 --- a/templates/chromedriver.rb +++ b/templates/chromedriver.rb @@ -15,3 +15,13 @@ end Capybara.javascript_driver = :headless_chrome + +RSpec.configure do |config| + config.before(:each, type: :system) do + driven_by...
Configure System Test drivers with `driven_by` According to the documentation from [`rspec-rails`][rspec-rails]: > RSpec **does not** use your `ApplicationSystemTestCase` helper. > Instead it uses the default `driven_by(:selenium)` from Rails. If you > want to override this behaviour you can call `driven_by` manually...
diff --git a/lib/ghtorrent/migrations/025_add_updated_at_projects.rb b/lib/ghtorrent/migrations/025_add_updated_at_projects.rb index abc1234..def5678 100644 --- a/lib/ghtorrent/migrations/025_add_updated_at_projects.rb +++ b/lib/ghtorrent/migrations/025_add_updated_at_projects.rb @@ -18,12 +18,12 @@ puts 'Adding ...
Change order to fix failing tests
diff --git a/spec/bug_report_templates_spec.rb b/spec/bug_report_templates_spec.rb index abc1234..def5678 100644 --- a/spec/bug_report_templates_spec.rb +++ b/spec/bug_report_templates_spec.rb @@ -1,13 +1,15 @@ require 'spec_helper' +require 'open3' RSpec.describe 'bug_report_templates' do subject do Bundler...
Fix bug report spec to not print stuff on jruby And an associated warning: the `out:` argument to `system` is unsupported there.