diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/factories/article_factory.rb b/spec/factories/article_factory.rb index abc1234..def5678 100644 --- a/spec/factories/article_factory.rb +++ b/spec/factories/article_factory.rb @@ -3,7 +3,7 @@ author factory: :user title { Faker::Lorem.sentence } slug { title.parameterize } - content { ...
Make Article factory use fake hacker-speak Way better than Lorem and will help me detect if full-text search on content works properly because these are actual English word and not fake latin.
diff --git a/spec/dummy_app/app/active_record/team.rb b/spec/dummy_app/app/active_record/team.rb index abc1234..def5678 100644 --- a/spec/dummy_app/app/active_record/team.rb +++ b/spec/dummy_app/app/active_record/team.rb @@ -5,7 +5,7 @@ attr_accessible :name, :division_id, :logo_url, :manager, :ballpark, :mascot, :fo...
Fix non-deterministic code in spec
diff --git a/spec/parser/ruby/ast_node_spec.rb b/spec/parser/ruby/ast_node_spec.rb index abc1234..def5678 100644 --- a/spec/parser/ruby/ast_node_spec.rb +++ b/spec/parser/ruby/ast_node_spec.rb @@ -20,10 +20,15 @@ describe '#pretty_print' do it "should show a list of nodes" do + obj = YARD::Parse...
Update pretty print to test docstring
diff --git a/spec/unit/multi/auto_spin_spec.rb b/spec/unit/multi/auto_spin_spec.rb index abc1234..def5678 100644 --- a/spec/unit/multi/auto_spin_spec.rb +++ b/spec/unit/multi/auto_spin_spec.rb @@ -33,6 +33,6 @@ # Ensure that top level is successful as well if all jobs run # expect(spinners.success?).to eq(tr...
Change to ensure order does not matter
diff --git a/climate_control.gemspec b/climate_control.gemspec index abc1234..def5678 100644 --- a/climate_control.gemspec +++ b/climate_control.gemspec @@ -11,6 +11,7 @@ gem.description = %q{Modify your ENV} gem.summary = %q{Modify your ENV easily with ClimateControl} gem.homepage = "https://githu...
Add license info to gemspec
diff --git a/Lokaligo.podspec b/Lokaligo.podspec index abc1234..def5678 100644 --- a/Lokaligo.podspec +++ b/Lokaligo.podspec @@ -10,7 +10,7 @@ spec.public_header_files = "LokaligoSDK.framework/**/*.h" spec.preserve_paths = "LokaligoSDK.framework" spec.summary = 'Quick and easy management of the local...
Add sha1 for the source.
diff --git a/lib/smart_answer/calculators/energy_grants_calculator.rb b/lib/smart_answer/calculators/energy_grants_calculator.rb index abc1234..def5678 100644 --- a/lib/smart_answer/calculators/energy_grants_calculator.rb +++ b/lib/smart_answer/calculators/energy_grants_calculator.rb @@ -45,7 +45,7 @@ end de...
Make measure_help? method return a boolean The `:measure_help` symbol is not used anywhere and the method is always used as if it was returning a boolean.
diff --git a/Casks/keepassx.rb b/Casks/keepassx.rb index abc1234..def5678 100644 --- a/Casks/keepassx.rb +++ b/Casks/keepassx.rb @@ -1,8 +1,8 @@ class Keepassx < Cask - url 'https://www.keepassx.org/dev/attachments/download/59/KeePassX-2.0-alpha5.dmg' + url 'https://www.keepassx.org/dev/attachments/download/72/KeePas...
Update KeePassX to latest version Сhangelog: https://www.keepassx.org/news/2014/04/433
diff --git a/Casks/owncloud.rb b/Casks/owncloud.rb index abc1234..def5678 100644 --- a/Casks/owncloud.rb +++ b/Casks/owncloud.rb @@ -4,7 +4,7 @@ url "https://download.owncloud.com/desktop/stable/ownCloud-#{version}.pkg" name 'ownCloud' - homepage 'http://owncloud.com' + homepage 'https://owncloud.com/' lice...
Fix homepage to use SSL in ownCloud Cask The HTTP URL is already getting redirected to HTTPS. Using the HTTPS URL directly makes it more secure and saves a HTTP round-trip.
diff --git a/Casks/python26.rb b/Casks/python26.rb index abc1234..def5678 100644 --- a/Casks/python26.rb +++ b/Casks/python26.rb @@ -3,7 +3,7 @@ sha256 'f3683e71af5cd96dfd838c76ef7011ca0521562fb2f0d8c30a43dffe62d57c49' url "https://www.python.org/ftp/python/#{version}/python-#{version}-macosx10.3.dmg" - homepag...
Update Python26 homepage URL to https
diff --git a/lib/alchemy/upgrader/four_point_one.rb b/lib/alchemy/upgrader/four_point_one.rb index abc1234..def5678 100644 --- a/lib/alchemy/upgrader/four_point_one.rb +++ b/lib/alchemy/upgrader/four_point_one.rb @@ -21,6 +21,19 @@ All your existing tags have been migrated to `Gutentag::Tag`s. + Remo...
Add note about translation removals to upgrader
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -41,7 +41,7 @@ end def teardown - return if !FakeFS.activated? + return unless FakeFS.activated? FakeFS.deactivate! flunk "always deactivate Fake...
Fix tiny rubocop violation in test using unless for negative condition
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -2,7 +2,8 @@ require File.expand_path("../dummy/config/environment.rb", __FILE__) require "codeclimate-test-reporter" -#CodeClimate::TestReporter.start + +CodeClimate::TestRepo...
Enable again Code Climate test reporter
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,8 +1,10 @@ ENV['RAILS_ENV'] ||= 'test' # Set the working dir to a temp location +require 'tmpdir' require 'fileutils' -ENV['WORKING_DIR'] = './tmp/working' +ENV['WORKING_DIR...
Revert "don't use tmpdir to get a temp location for blueprint testing" This reverts commit 332f5eea1e673945ab699535aa558343009da52d.
diff --git a/features/support/env.rb b/features/support/env.rb index abc1234..def5678 100644 --- a/features/support/env.rb +++ b/features/support/env.rb @@ -27,7 +27,7 @@ (ENV.keys-ignore_env).select{|x| x =~ /\A[A-Z_]*\Z/}.each do |key| c.filter_sensitive_data("<#{key}>") { ENV[key] } end - c.defaul...
Set VCR to record once
diff --git a/colocated-charters-script.rb b/colocated-charters-script.rb index abc1234..def5678 100644 --- a/colocated-charters-script.rb +++ b/colocated-charters-script.rb @@ -5,7 +5,7 @@ charter_school = v.find { |x| x[3] == "Charter"} if charter_school != nil colocated_addresses_w_charter << {k => v} - v....
Comment out line where data is added to colocated charter csv - not needed anymore since CSV has already been created
diff --git a/fail_to_ban.gemspec b/fail_to_ban.gemspec index abc1234..def5678 100644 --- a/fail_to_ban.gemspec +++ b/fail_to_ban.gemspec @@ -12,15 +12,6 @@ spec.summary = %q{Lib for handle burte force with key} spec.homepage = "https://github.com/jobteaser/cockpit" - # Prevent pushing this gem to Rub...
Remove allowed_push_host from the gemspec
diff --git a/lib/adminable/presenters/entries_presenter.rb b/lib/adminable/presenters/entries_presenter.rb index abc1234..def5678 100644 --- a/lib/adminable/presenters/entries_presenter.rb +++ b/lib/adminable/presenters/entries_presenter.rb @@ -31,9 +31,7 @@ view.link_to(entry.to_name, edit_polymorphic_path(ent...
Add tag for and_more for entries presenter
diff --git a/omnibus/config/software/ruby-windows-system-libraries.rb b/omnibus/config/software/ruby-windows-system-libraries.rb index abc1234..def5678 100644 --- a/omnibus/config/software/ruby-windows-system-libraries.rb +++ b/omnibus/config/software/ruby-windows-system-libraries.rb @@ -11,7 +11,10 @@ if windows? ...
Make sure to include libstc++-6
diff --git a/lib/friendly_id/datamapper_adapter/version.rb b/lib/friendly_id/datamapper_adapter/version.rb index abc1234..def5678 100644 --- a/lib/friendly_id/datamapper_adapter/version.rb +++ b/lib/friendly_id/datamapper_adapter/version.rb @@ -3,7 +3,7 @@ module Version MAJOR = 3 MINOR = 0 - T...
Update VERSION to match latest friendly_id release Signed-off-by: Alex Coles <60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexcolesportfolio.com>
diff --git a/lib/rbtc_arbitrage/clients/bitstamp_client.rb b/lib/rbtc_arbitrage/clients/bitstamp_client.rb index abc1234..def5678 100644 --- a/lib/rbtc_arbitrage/clients/bitstamp_client.rb +++ b/lib/rbtc_arbitrage/clients/bitstamp_client.rb @@ -6,7 +6,7 @@ def balance return @balance if @balance ...
Fix for bitstamp bitcoin client.
diff --git a/test/lib/catissue/domain/address_test.rb b/test/lib/catissue/domain/address_test.rb index abc1234..def5678 100644 --- a/test/lib/catissue/domain/address_test.rb +++ b/test/lib/catissue/domain/address_test.rb @@ -1,4 +1,4 @@-require File.join(File.dirname(__FILE__), '..', 'test_case') +require File.dirname(...
Address does not reference the owner.
diff --git a/week-4/concatenate-arrays/my_solution.rb b/week-4/concatenate-arrays/my_solution.rb index abc1234..def5678 100644 --- a/week-4/concatenate-arrays/my_solution.rb +++ b/week-4/concatenate-arrays/my_solution.rb @@ -4,6 +4,16 @@ # Your Solution Below + + + +def array_concat(array_1, array_2) + +array_2.e...
Add solution for challenge 4.6
diff --git a/TDNotificationPanel.podspec b/TDNotificationPanel.podspec index abc1234..def5678 100644 --- a/TDNotificationPanel.podspec +++ b/TDNotificationPanel.podspec @@ -4,7 +4,7 @@ s.summary = "TDNotificationPanel is a drop in class that displays a notification panel." s.homepage = "https://github.com...
Change license to not include license file
diff --git a/Titanium.podspec b/Titanium.podspec index abc1234..def5678 100644 --- a/Titanium.podspec +++ b/Titanium.podspec @@ -1,7 +1,11 @@ Pod::Spec.new do |s| s.name = "Titanium" + s.version = "0.7" + + s.license = { :type => "MIT" } + s.summary = "Image viewer library" s.d...
Set license type to “MIT”
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -3,6 +3,11 @@ to: GovukHealthcheck.rack_response( GovukHealthcheck::ActiveRecord, ) + + get "/healthcheck/live", to: proc { [200, {}, %w[OK]] } + get "/healthcheck/read...
Add RFC 141 healthcheck endpoints Once govuk-puppet has been updated, the old endpoint can be removed. See the RFC for more details.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -38,7 +38,8 @@ to: proc { [200, {}, - [ENV['GRANTZILLA_LETS_ENCRYPT_CHALLENGE_ID'] || 'The GRANTZILLA_LETS_ENCRYPT_CHALLENGE_ID environment variable is not set...
issue-289: Make rubocop happy with last change.
diff --git a/app/controllers/spree/api/v1/taxons_controller_decorator.rb b/app/controllers/spree/api/v1/taxons_controller_decorator.rb index abc1234..def5678 100644 --- a/app/controllers/spree/api/v1/taxons_controller_decorator.rb +++ b/app/controllers/spree/api/v1/taxons_controller_decorator.rb @@ -3,6 +3,9 @@ mod...
Comment controller actions for following/unfollowing
diff --git a/app/models/contact_message.rb b/app/models/contact_message.rb index abc1234..def5678 100644 --- a/app/models/contact_message.rb +++ b/app/models/contact_message.rb @@ -7,7 +7,7 @@ validates :name, presence: true, length: { maximum: 100 } validates :email, presence: true, email: true, length: { maxim...
Increase length for contact message to 2000 characters.
diff --git a/Library/Homebrew/test/dev-cmd/ruby_spec.rb b/Library/Homebrew/test/dev-cmd/ruby_spec.rb index abc1234..def5678 100644 --- a/Library/Homebrew/test/dev-cmd/ruby_spec.rb +++ b/Library/Homebrew/test/dev-cmd/ruby_spec.rb @@ -15,3 +15,17 @@ .and not_to_output.to_stderr end end + +describe "brew ruby -e...
Test for `brew ruby -e 'puts "testball".f.path'` This test aims to prevent regressions of #9362.
diff --git a/carquery.gemspec b/carquery.gemspec index abc1234..def5678 100644 --- a/carquery.gemspec +++ b/carquery.gemspec @@ -6,8 +6,8 @@ Gem::Specification.new do |spec| spec.name = "carquery" spec.version = Carquery::VERSION - spec.authors = ["Rustam Sharshenov"] - spec.email =...
Add Mason to an authors list
diff --git a/spec/class2/exercise1_spec.rb b/spec/class2/exercise1_spec.rb index abc1234..def5678 100644 --- a/spec/class2/exercise1_spec.rb +++ b/spec/class2/exercise1_spec.rb @@ -7,7 +7,7 @@ expect { exercise1 }.to output.to_stdout end - it 'display the hours in year' do + it 'display the hours in a year' ...
Fix typo with class 2 exercise 1 spec
diff --git a/spec/requests/catalog_spec.rb b/spec/requests/catalog_spec.rb index abc1234..def5678 100644 --- a/spec/requests/catalog_spec.rb +++ b/spec/requests/catalog_spec.rb @@ -16,6 +16,7 @@ expect(service.fetch('bindable')).to be_true expect(service.fetch('metadata')).to eq( { + 'provider' =...
Update test to reflect new 'provider' key setting [#59365332] Signed-off-by: Matt Royal <6463362714fdee6ae948b4a582165edffac2664e@pivotallabs.com>
diff --git a/business.gemspec b/business.gemspec index abc1234..def5678 100644 --- a/business.gemspec +++ b/business.gemspec @@ -20,7 +20,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_development_dependency "gc_ruboconfig", "~> 2.25.0" + spec.add_...
Update gc_ruboconfig requirement from ~> 2.25.0 to ~> 2.26.0 Updates the requirements on [gc_ruboconfig](https://github.com/gocardless/ruboconfig) to permit the latest version. - [Release notes](https://github.com/gocardless/ruboconfig/releases) - [Changelog](https://github.com/gocardless/gc_ruboconfig/blob/master/CHA...
diff --git a/business.gemspec b/business.gemspec index abc1234..def5678 100644 --- a/business.gemspec +++ b/business.gemspec @@ -23,5 +23,5 @@ spec.add_development_dependency "gc_ruboconfig", "~> 2.20.0" spec.add_development_dependency "rspec", "~> 3.1" spec.add_development_dependency "rspec_junit_formatter", "...
Update rubocop requirement from ~> 1.1.0 to ~> 1.2.0 Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](htt...
diff --git a/examples/parentheses.rb b/examples/parentheses.rb index abc1234..def5678 100644 --- a/examples/parentheses.rb +++ b/examples/parentheses.rb @@ -1,9 +1,21 @@ require File.expand_path(File.dirname(__FILE__) + "/../lib/grammoire") +# Repeated rules grammar = Grammoire.define do rule(:s) { produce(:s) + ...
Sort of example for an alternative way of defining productions for the same rule
diff --git a/spec/support/fake_cronitor.rb b/spec/support/fake_cronitor.rb index abc1234..def5678 100644 --- a/spec/support/fake_cronitor.rb +++ b/spec/support/fake_cronitor.rb @@ -2,7 +2,7 @@ class FakeCronitor < Sinatra::Base get '/v1/monitors/:id' do - if ['abcd', 'Test Cronitor'].include? params['id'] + ...
Update to match ID of mock existing monitor JSON
diff --git a/lib/ember/cli/resolver.rb b/lib/ember/cli/resolver.rb index abc1234..def5678 100644 --- a/lib/ember/cli/resolver.rb +++ b/lib/ember/cli/resolver.rb @@ -1,7 +1,7 @@ module Ember module CLI module Resolver - VERSION = '0.1.14' + VERSION = '0.1.15' end end end
Update Ember Resolver version to 0.1.15
diff --git a/lib/fake_email_service.rb b/lib/fake_email_service.rb index abc1234..def5678 100644 --- a/lib/fake_email_service.rb +++ b/lib/fake_email_service.rb @@ -11,9 +11,12 @@ email_address = Mail::Address.new(email) domain = email_address.domain.strip.downcase - second_level_domain = domain.split('.'...
Check third level domains for any case
diff --git a/lib/leaflet-draw-rails.rb b/lib/leaflet-draw-rails.rb index abc1234..def5678 100644 --- a/lib/leaflet-draw-rails.rb +++ b/lib/leaflet-draw-rails.rb @@ -4,6 +4,9 @@ module Draw module Rails class Engine < ::Rails::Engine + initializer 'leaflet-draw-rails.assets.precompile' do |app| + ...
Configure initializer to precompile images.
diff --git a/lib/reports_kit/engine.rb b/lib/reports_kit/engine.rb index abc1234..def5678 100644 --- a/lib/reports_kit/engine.rb +++ b/lib/reports_kit/engine.rb @@ -2,13 +2,13 @@ class Engine < ::Rails::Engine engine_name 'reports_kit' - initializer 'helper' do + initializer 'reports_kit.helpers.helper' ...
Use namespaced names for initializers
diff --git a/lib/reports_kit/helper.rb b/lib/reports_kit/helper.rb index abc1234..def5678 100644 --- a/lib/reports_kit/helper.rb +++ b/lib/reports_kit/helper.rb @@ -1,6 +1,7 @@ module ReportsKit module Helper def render_report(properties, &block) + raise ArgumentError.new('`properties` must be a Hash or St...
Raise ArgumentError if properties are blank
diff --git a/lib/scout/commands/ask.rb b/lib/scout/commands/ask.rb index abc1234..def5678 100644 --- a/lib/scout/commands/ask.rb +++ b/lib/scout/commands/ask.rb @@ -11,7 +11,7 @@ help "Ask a stupid question" def process - speak "http://LetMeGoogleThatForYou.com/?q=" + CGI.escape(args.join...
Add command name to query
diff --git a/lib/data_service/record.rb b/lib/data_service/record.rb index abc1234..def5678 100644 --- a/lib/data_service/record.rb +++ b/lib/data_service/record.rb @@ -14,7 +14,13 @@ end def parse_date(date) - DateTime.strptime(date, '%Y-%m-%d %H:%M') + if date ~= /\d+-\d+-\d+ \d{2}:\d{2}(\-|\+)\d...
Support parsing times with or without seconds Also parse the timezone now.
diff --git a/lib/facter/xcodeversion.rb b/lib/facter/xcodeversion.rb index abc1234..def5678 100644 --- a/lib/facter/xcodeversion.rb +++ b/lib/facter/xcodeversion.rb @@ -1,7 +1,7 @@ Facter.add(:xcodeversion) do confine :operatingsystem => :darwin setcode do - return "" if ! File.exists('/usr/bin/xcodebuild') + ...
Fix warning with Ruby 2.0.0: Could not retrieve fact='xcodeversion', resolution='<anonymous>': undefined method `exists' for File:Class
diff --git a/spec/features/merge_requests/pipelines_spec.rb b/spec/features/merge_requests/pipelines_spec.rb index abc1234..def5678 100644 --- a/spec/features/merge_requests/pipelines_spec.rb +++ b/spec/features/merge_requests/pipelines_spec.rb @@ -0,0 +1,48 @@+require 'spec_helper' + +feature 'Pipelines for Merge Requ...
Add a feature tests to check if a view can be rendered properly
diff --git a/Casks/kontroll.rb b/Casks/kontroll.rb index abc1234..def5678 100644 --- a/Casks/kontroll.rb +++ b/Casks/kontroll.rb @@ -2,9 +2,9 @@ version :latest sha256 :no_check - url 'http://kontroll.io/download/Kontroll.zip' + url 'https://kontroll.io/download/Kontroll.zip' name 'Kontroll' - homepage 'ht...
Fix url and homepage to use SSL in Kontroll Cask The HTTP URL is already getting redirected to HTTPS. Using the HTTPS URL directly makes it more secure and saves a HTTP round-trip.
diff --git a/lib/matross/delayed_job.rb b/lib/matross/delayed_job.rb index abc1234..def5678 100644 --- a/lib/matross/delayed_job.rb +++ b/lib/matross/delayed_job.rb @@ -5,7 +5,13 @@ desc "Writes the delayed job part of the Procfile" task :procfile, :roles => :dj do procfile_template = <<-EOF.gsub(/^\s+/, '') ...
Allow definition of DJ queues
diff --git a/lib/data_mapper/associations/parent_to_child_association.rb b/lib/data_mapper/associations/parent_to_child_association.rb index abc1234..def5678 100644 --- a/lib/data_mapper/associations/parent_to_child_association.rb +++ b/lib/data_mapper/associations/parent_to_child_association.rb @@ -0,0 +1,75 @@+requir...
Revert "Moved to one_to_many.rb as Proxy." This reverts commit 682e5c4ae2c17ae13418f010290776654d05be68.
diff --git a/lib/poise/resource_name.rb b/lib/poise/resource_name.rb index abc1234..def5678 100644 --- a/lib/poise/resource_name.rb +++ b/lib/poise/resource_name.rb @@ -22,7 +22,7 @@ module ResourceName def initialize(*args) super - @resource_name ||= Chef::Mixin::ConvertToClassName.convert_t...
Handle weird classes that have no name.
diff --git a/spec/unit/facts/rabbitmq_erlang_cookie_spec.rb b/spec/unit/facts/rabbitmq_erlang_cookie_spec.rb index abc1234..def5678 100644 --- a/spec/unit/facts/rabbitmq_erlang_cookie_spec.rb +++ b/spec/unit/facts/rabbitmq_erlang_cookie_spec.rb @@ -0,0 +1,19 @@+require 'spec_helper' + +describe 'rabbitmq_erlang_cookie'...
Add tests for this fact.
diff --git a/lib/space/model/project.rb b/lib/space/model/project.rb index abc1234..def5678 100644 --- a/lib/space/model/project.rb +++ b/lib/space/model/project.rb @@ -28,7 +28,7 @@ def number(name) if number = names.index(name) - number + 1 + number else names <<...
[PoC] Fix improper Dashboard list indexing Having two repos I'm facing improper list indexing in Dashboard. Here is how it looking https://gist.github.com/a454501c92026be915bf. Pressing key `1` that corresponds unexising repo is closing space. This fix is Proof of Concept, 'cause I didn't dive into the inner logic of...
diff --git a/lib/spinoza/calvin/node.rb b/lib/spinoza/calvin/node.rb index abc1234..def5678 100644 --- a/lib/spinoza/calvin/node.rb +++ b/lib/spinoza/calvin/node.rb @@ -1,6 +1,6 @@ require 'spinoza/system/node' require 'spinoza/calvin/sequencer' -#require 'spinoza/calvin/scheduler' +require 'spinoza/calvin/scheduler' ...
Fix initialization with :none arg.
diff --git a/lib/tasks/split_dates.rake b/lib/tasks/split_dates.rake index abc1234..def5678 100644 --- a/lib/tasks/split_dates.rake +++ b/lib/tasks/split_dates.rake @@ -10,4 +10,34 @@ task validate: :environment do Tasks::SplitDates.validate end + + desc "Backfill publishing_api_* dates using temporary_* dat...
Add rake task to backfill publishing_api_* dates This task takes all the edition timestamps that are prefixed with `temporary_` and backfills their equivalent prefixed with `publishing_api_`. This is to allow switching to the `publishing_api_*` dates and work towards the removal of the `temporary_*` ones. On my dev ...
diff --git a/lib/troo/cli/thor_fixes.rb b/lib/troo/cli/thor_fixes.rb index abc1234..def5678 100644 --- a/lib/troo/cli/thor_fixes.rb +++ b/lib/troo/cli/thor_fixes.rb @@ -2,11 +2,7 @@ module CLI class ThorFixes < Thor def self.banner(command, namespace = nil, subcommand = false) - if subcommand - ...
Fix spacing issue with subcommands.
diff --git a/html_mini.gemspec b/html_mini.gemspec index abc1234..def5678 100644 --- a/html_mini.gemspec +++ b/html_mini.gemspec @@ -7,7 +7,7 @@ s.platform = Gem::Platform::RUBY s.authors = ["Jerome Touffe-Blin"] s.email = %q{jtblin@gmail.com} - s.homepage = %q{http://github.com/jtblin/html-mini} + s.homep...
Fix typo in gem project home page url.
diff --git a/lib/sastrawi/morphology/invalid_affix_pair_specification.rb b/lib/sastrawi/morphology/invalid_affix_pair_specification.rb index abc1234..def5678 100644 --- a/lib/sastrawi/morphology/invalid_affix_pair_specification.rb +++ b/lib/sastrawi/morphology/invalid_affix_pair_specification.rb @@ -11,11 +11,13 @@ ...
Fix boolean operation for pattern matching
diff --git a/lib/ab_admin/hooks/will_paginate_no_uri.rb b/lib/ab_admin/hooks/will_paginate_no_uri.rb index abc1234..def5678 100644 --- a/lib/ab_admin/hooks/will_paginate_no_uri.rb +++ b/lib/ab_admin/hooks/will_paginate_no_uri.rb @@ -14,6 +14,6 @@ url_params[param_name.to_sym] = nil if url_params[param_name.to_sym]....
Remove trailing question mark in pagination
diff --git a/lib/amazon_athena/commands/repair_table.rb b/lib/amazon_athena/commands/repair_table.rb index abc1234..def5678 100644 --- a/lib/amazon_athena/commands/repair_table.rb +++ b/lib/amazon_athena/commands/repair_table.rb @@ -14,6 +14,8 @@ def run(connection) connection.query(statement) + + ...
REPAIR TABLE does not return output
diff --git a/config/deploy.rb b/config/deploy.rb index abc1234..def5678 100644 --- a/config/deploy.rb +++ b/config/deploy.rb @@ -24,6 +24,7 @@ task :stop do ; end task :restart, :roles => :app, :except => { :no_release => true } do run "#{try_sudo} touch #{File.join(current_path,'tmp','restart.txt')}" + ru...
Fix photos breaking on rollout
diff --git a/test/functional/groups/memberships_controller_test.rb b/test/functional/groups/memberships_controller_test.rb index abc1234..def5678 100644 --- a/test/functional/groups/memberships_controller_test.rb +++ b/test/functional/groups/memberships_controller_test.rb @@ -17,7 +17,7 @@ end def test_destroy -...
Use the committee factory to create councils.
diff --git a/app/controllers/thredded/application_controller.rb b/app/controllers/thredded/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/thredded/application_controller.rb +++ b/app/controllers/thredded/application_controller.rb @@ -11,11 +11,13 @@ private def current_ability ...
[JRO] Check for presence of messageboard_id Before searching for something with a particular param key, check that it's there.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,5 +1,7 @@ Rails.application.routes.draw do - devise_for :users, :controllers => { :omniauth_callbacks => "users/omniauth_callbacks" } + get '/users/sign_in', to: redirect('/users/auth/fac...
Change path in header for login
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,6 +1,8 @@ ActionController::Routing::Routes.draw do |map| map.root :controller => 'login' + # this route is needed for Shopify's application links, because they append the id param wi...
Add a new route to intercept redirects from Shopify like this: /orders?id=123
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -2,6 +2,6 @@ root :to => "authorizations#new" resources :authorizations, :only => :create - match 'authorize' => 'authorizations#new' + match 'authorize' => 'authorizations#new', via:...
Add via to match route, for Rails 4 compatibility.
diff --git a/app/controllers/frontend/eid_controller.rb b/app/controllers/frontend/eid_controller.rb index abc1234..def5678 100644 --- a/app/controllers/frontend/eid_controller.rb +++ b/app/controllers/frontend/eid_controller.rb @@ -8,8 +8,12 @@ end def photo - photo = session[:eid]["be:fedict:eid:idp:photo"]...
Add session check in eid/photo
diff --git a/spec/features/logins_spec.rb b/spec/features/logins_spec.rb index abc1234..def5678 100644 --- a/spec/features/logins_spec.rb +++ b/spec/features/logins_spec.rb @@ -20,11 +20,11 @@ end it do - expect(page).to have_content('logout') + expect(page).to have_content I18n.t('views.sh...
Fix spec * Deal with I18n
diff --git a/spec/features/search_spec.rb b/spec/features/search_spec.rb index abc1234..def5678 100644 --- a/spec/features/search_spec.rb +++ b/spec/features/search_spec.rb @@ -0,0 +1,11 @@+require 'rails_helper' + +feature 'Search question' do + scenario "search a keyword" do + visit root_path + find('#search_f...
Add a test for a word search.
diff --git a/app/controllers/registration_controller.rb b/app/controllers/registration_controller.rb index abc1234..def5678 100644 --- a/app/controllers/registration_controller.rb +++ b/app/controllers/registration_controller.rb @@ -2,9 +2,12 @@ class RegistrationController < BaseController include OpenFoodNetwork...
Add map helper to RegistrationController Fixes 3 errors including: Registration Terms of Service agreement if accepting Terms of Service is not required allows registration as normal Failure/Error: super ActionView::Template::Error: undefined method `using_google_maps?' for #<#<Class:0x00007fd4949c4...
diff --git a/identifier-uuid.gemspec b/identifier-uuid.gemspec index abc1234..def5678 100644 --- a/identifier-uuid.gemspec +++ b/identifier-uuid.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'identifier-uuid' - s.version = '0.1.1' + s.version = '0.1.2' s.summary = 'UU...
Package version is increased from 0.1.1 to 0.1.2
diff --git a/src/brilliant/ast/program.rb b/src/brilliant/ast/program.rb index abc1234..def5678 100644 --- a/src/brilliant/ast/program.rb +++ b/src/brilliant/ast/program.rb @@ -18,17 +18,17 @@ private def define_external_functions(main_module) - main_module.functions.add('exit', [Type::Int32], Type::Void) do ...
Correct type signatures for main, exit, and puts. Per POSIX, these should be using machine integers, not 32-bit integers.
diff --git a/lib/rails_admin/config/actions/clean_up.rb b/lib/rails_admin/config/actions/clean_up.rb index abc1234..def5678 100644 --- a/lib/rails_admin/config/actions/clean_up.rb +++ b/lib/rails_admin/config/actions/clean_up.rb @@ -3,6 +3,10 @@ module Actions class CleanUp < RailsAdmin::Config::Actions::B...
Clean up action only for accounts
diff --git a/lib/travis/api/v3/renderer/subscription.rb b/lib/travis/api/v3/renderer/subscription.rb index abc1234..def5678 100644 --- a/lib/travis/api/v3/renderer/subscription.rb +++ b/lib/travis/api/v3/renderer/subscription.rb @@ -1,6 +1,6 @@ module Travis::API::V3 class Renderer::Subscription < ModelRenderer - ...
Remove invoices from Subscription renderer
diff --git a/workflow/test/fixtures.rb b/workflow/test/fixtures.rb index abc1234..def5678 100644 --- a/workflow/test/fixtures.rb +++ b/workflow/test/fixtures.rb @@ -1,5 +1,5 @@ module Fixtures - path = File.expand_path('./test/fixtures/font-awesome-3-2-1-icons.yml') + path = File.expand_path('./test/fixtures/font-awe...
Change YAML file to load
diff --git a/db/migrate/20160916131013_create_connector_providers_configurations.rb b/db/migrate/20160916131013_create_connector_providers_configurations.rb index abc1234..def5678 100644 --- a/db/migrate/20160916131013_create_connector_providers_configurations.rb +++ b/db/migrate/20160916131013_create_connector_provide...
Change connector configuration's provider foreign key on-delete Make it restrict rather than cascade, since deleting providers for which configurations exists should be taken with care.
diff --git a/app/models/users/authenticated_sessions.rb b/app/models/users/authenticated_sessions.rb index abc1234..def5678 100644 --- a/app/models/users/authenticated_sessions.rb +++ b/app/models/users/authenticated_sessions.rb @@ -0,0 +1,40 @@+module Users + module AuthenticatedSessions + def remember + upda...
Refactor Authentication module for Users Move authentication module to app/models/users/. Borrow a finished refactor of Authentication module (it's from the development-OAuth branch)
diff --git a/config/deploy.rb b/config/deploy.rb index abc1234..def5678 100644 --- a/config/deploy.rb +++ b/config/deploy.rb @@ -1,4 +1,4 @@-lock '3.6.1' +lock '3.7.0' set :application, 'evemonk' set :repo_url, 'git@github.com:biow0lf/evemonk.git'
Update capistrano lock to 3.7.0
diff --git a/week-4/address/my_solution.rb b/week-4/address/my_solution.rb index abc1234..def5678 100644 --- a/week-4/address/my_solution.rb +++ b/week-4/address/my_solution.rb @@ -0,0 +1,11 @@+# Format an Address + +# I worked on this challenge [by myself, with: ]. + +def make_address (street, city, state, zip) +...
Add my solution to challenge 4.3.1
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -10,5 +10,6 @@ resources :languages, only: [:index, :new, :create, :show, :destroy] - get '/tags/:id', to: 'tags#show', as: "tag" + resources :tags, only: [:show, :destroy] + end
Add destory resource for tags.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,10 +1,9 @@ Rails.application.routes.draw do - resources :users scope '/:locale', :locale => /de|fr|it|en/, :format => /json|html|csv/ do + resources :words get 'export', to:...
Delete first 'resources :users' There was another one at the right place (below scope)
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,9 +1,14 @@ Rails.application.routes.draw do + + resources :sessions, only: [:new, :create, :destroy] + get '/login' => 'sessions#new', as: 'login' + post '/login' => 'sessions#create' + ...
Edit Routes For User Authentication
diff --git a/dagnabit.gemspec b/dagnabit.gemspec index abc1234..def5678 100644 --- a/dagnabit.gemspec +++ b/dagnabit.gemspec @@ -15,7 +15,7 @@ s.executables = ["dagnabit-test"] s.require_paths = ["lib"] - s.add_dependency 'activerecord', '~> 2.3.0' + s.add_dependency 'activerecord', '>= 2.3.0' [ [ 'au...
Declare compatibility with ActiveRecord 3.0. Strictly speaking, this declares compatibility with every ActiveRecord version >= 2.3.0, and I need a CI build to provide some evidence of that; however, dagnabit's specs and Cucumber scenarios pass with 2.3.10 and 3.0.3, so I'm going to make an unwarranted assumption and s...
diff --git a/lib/dsl/interpolator.rb b/lib/dsl/interpolator.rb index abc1234..def5678 100644 --- a/lib/dsl/interpolator.rb +++ b/lib/dsl/interpolator.rb @@ -1,6 +1,6 @@ class Interpolator - REGEXP = /(\$\{\s*(?:[a-zA-Z][a-zA-Z0-9]*::)*[a-zA-Z][a-zA-Z0-9]*\s*\})/ + REGEXP = /(\$\{\s*(?:[a-zA-Z][a-zA-Z0-9_]*::)*[a-zA...
Allow underscores also in interpolations
diff --git a/lib/gds_api/need_api.rb b/lib/gds_api/need_api.rb index abc1234..def5678 100644 --- a/lib/gds_api/need_api.rb +++ b/lib/gds_api/need_api.rb @@ -3,7 +3,7 @@ class GdsApi::NeedApi < GdsApi::Base def needs(options = {}) - query = "?"+options.map { |k,v| "#{k}=#{v}" }.join("&") unless options.empty? + ...
Use query_string method instead of manually mapping query parameters
diff --git a/lib/feedzirra.rb b/lib/feedzirra.rb index abc1234..def5678 100644 --- a/lib/feedzirra.rb +++ b/lib/feedzirra.rb @@ -11,12 +11,7 @@ require 'active_support/core_ext/module' require 'active_support/core_ext/kernel' require 'active_support/core_ext/object' - -if ActiveSupport::VERSION::MAJOR >= 3 - require...
Remove version check on ActiveSupport
diff --git a/lib/flexo/cli.rb b/lib/flexo/cli.rb index abc1234..def5678 100644 --- a/lib/flexo/cli.rb +++ b/lib/flexo/cli.rb @@ -40,8 +40,8 @@ template 'flexo.tt', project_dir + '.flexo', config directory 'sources', project_dir + config[:sources] - say_status '', '-' * 25 - say_status '', "Yo...
Replace ('-' * 25) with a literal.
diff --git a/lib/rubinius/toolset.rb b/lib/rubinius/toolset.rb index abc1234..def5678 100644 --- a/lib/rubinius/toolset.rb +++ b/lib/rubinius/toolset.rb @@ -16,6 +16,7 @@ def self.finish(name) ts = current::TS + ts.const_set :ToolSet, ts map[name] = ts const_set name.capitalize.to_sym, t...
Set a constant referencing the module scope.
diff --git a/app/channels/cache_channel.rb b/app/channels/cache_channel.rb index abc1234..def5678 100644 --- a/app/channels/cache_channel.rb +++ b/app/channels/cache_channel.rb @@ -10,8 +10,7 @@ page: params['page'] || 1 ).items.each do |item| FetchDeveloperWorker.perform_async( - item.login, -...
Remove reference to access token
diff --git a/lib/moho/lang.rb b/lib/moho/lang.rb index abc1234..def5678 100644 --- a/lib/moho/lang.rb +++ b/lib/moho/lang.rb @@ -1,24 +1,6 @@ module Moho module Lang class Expression < Struct.new(:value) - end - - class Int < Expression - def eval - value - end - end - - class Strin...
Put Lang::List first since it's the most important.
diff --git a/lib/tasks/groupers.rake b/lib/tasks/groupers.rake index abc1234..def5678 100644 --- a/lib/tasks/groupers.rake +++ b/lib/tasks/groupers.rake @@ -6,5 +6,10 @@ Genome::Groupers::GeneGrouper.run end end + task drugs: :environment do + Utils::Logging::without_sql do + Genome::...
Add drug grouper to rake environment
diff --git a/lib/urban/dictionary.rb b/lib/urban/dictionary.rb index abc1234..def5678 100644 --- a/lib/urban/dictionary.rb +++ b/lib/urban/dictionary.rb @@ -23,7 +23,6 @@ end private - def process(document) OpenStruct.new({ word: document.at_xpath('//td[@class="word"][1]').content.strip, @...
Remove line of code that isn't neede
diff --git a/lib/volt/cli/console.rb b/lib/volt/cli/console.rb index abc1234..def5678 100644 --- a/lib/volt/cli/console.rb +++ b/lib/volt/cli/console.rb @@ -1,19 +1,28 @@ require 'pry' class Pry - # To make the console more useful, we make it so we flush the event registry - # after each line. This makes it so ev...
Fix pry patch to allow REPL hook for flushing.
diff --git a/frontend/spec/support/shared_contexts/product_prototypes.rb b/frontend/spec/support/shared_contexts/product_prototypes.rb index abc1234..def5678 100644 --- a/frontend/spec/support/shared_contexts/product_prototypes.rb +++ b/frontend/spec/support/shared_contexts/product_prototypes.rb @@ -0,0 +1,30 @@+shared...
Add product protoypes shared context to its own file
diff --git a/lib/rubycouch.rb b/lib/rubycouch.rb index abc1234..def5678 100644 --- a/lib/rubycouch.rb +++ b/lib/rubycouch.rb @@ -6,13 +6,40 @@ require 'rubycouch/client' require 'rubycouch/definitions' require 'rubycouch/document' +require 'rubycouch/view' require 'rubycouch/database' require 'rubycouch/instance' ...
Update the demo listing to show more functionality
diff --git a/app/models/tree_field_type.rb b/app/models/tree_field_type.rb index abc1234..def5678 100644 --- a/app/models/tree_field_type.rb +++ b/app/models/tree_field_type.rb @@ -11,7 +11,7 @@ if values.is_a?(Hash) @values = values.keys else - @values = [values] + @values = values end ...
Remove casting in model - values should always be an array
diff --git a/app/controllers/admin/ideas_controller.rb b/app/controllers/admin/ideas_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/ideas_controller.rb +++ b/app/controllers/admin/ideas_controller.rb @@ -1,6 +1,7 @@ class Admin::IdeasController < Admin::AdminController before_action :set_i...
Use an Idea 'before_action' to populate associations Before rendering either of the 'GET' views, populate potential idea associations with instance variables to allow admins to set idea attributes (owners, current, state) to these values.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -3,9 +3,16 @@ # For APIs, you may want to use :null_session instead. protect_from_forge...
Fix matching of non-bare domains for domain-specifying tenants. Basically reimplmentation of set_current_tenant_by_subdomain_or_domain which also checks request.host Signed-off-by: Max Fierke <0706025b2bbcec1ed8d64822f4eccd96314938d0@maxfierke.com>
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -41,7 +41,7 @@ def set_section @section = params[:section] - @section.chomp!("_"...
Fix chomp! error when no @section
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -1,6 +1,7 @@ class ApplicationController < ActionController::Base protect_from_forger...
Add filter for facebook callback
diff --git a/lib/atlas/preset.rb b/lib/atlas/preset.rb index abc1234..def5678 100644 --- a/lib/atlas/preset.rb +++ b/lib/atlas/preset.rb @@ -9,18 +9,11 @@ attribute :id, Integer attribute :description, String attribute :ordering, Integer + attribute :title, ...
Remove unused attributes from Preset Removed create / update times, and other attributes which had a "nil" value for all the presets. Ref quintel/etsource#298