language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/ember-template-compiler/lib/plugins/assert-against-attrs.ts | @@ -55,7 +55,7 @@ export default function assertAgainstAttrs(env: EmberASTPluginEnvironment): ASTP
PathExpression(node: AST.PathExpression): AST.Node | void {
if (isAttrs(node, stack[stack.length - 1])) {
- let path = b.path(node.original.substr(6)) as AST.PathExpression;
+ let path ... | true |
Other | emberjs | ember.js | 6a9954389a4461ffc7da992fdb5eac1ffd1fa8ac.json | Avoid an 'as any' cast | packages/@ember/-internals/routing/lib/ext/controller.ts | @@ -244,8 +244,13 @@ ControllerMixin.reopen({
replaceRoute(...args: string[]) {
deprecateTransitionMethods('controller', 'replaceRoute');
// target may be either another controller or a router
- let target = get(this, 'target') as any;
- let method = target.replaceRoute || target.replaceWith;
+ le... | true |
Other | emberjs | ember.js | 6a9954389a4461ffc7da992fdb5eac1ffd1fa8ac.json | Avoid an 'as any' cast | packages/@ember/controller/index.d.ts | @@ -7,6 +7,7 @@ export default class Controller {
set<T>(key: string, value: T): void;
setProperties(props: { [key: string]: any }): void;
transitionToRoute(...args: unknown[]): unknown;
+ replaceRoute(...args: unknown[]): unknown;
_qpDelegate: unknown;
}
| true |
Other | emberjs | ember.js | 575892ba8623ca24f67ee3024070ac4f7f704abf.json | Resolve comment that no longer applies | packages/@ember/-internals/routing/lib/services/router.ts | @@ -337,9 +337,6 @@ export default class RouterService extends Service {
// *do not* account for this being `undefined`.
routeName as string,
models,
- // UNSAFE: downstream consumers treat this as `QueryParam`, which the
- // type system here *correctly* reports as incorrect, b... | false |
Other | emberjs | ember.js | 0ff7e435dc2028940ff1c9b0e7fd6129624407f2.json | Resolve failing tests | packages/@ember/-internals/routing/lib/ext/controller.ts | @@ -2,7 +2,6 @@ import { get } from '@ember/-internals/metal';
import { getOwner } from '@ember/-internals/owner';
import Controller from '@ember/controller';
import ControllerMixin from '@ember/controller/lib/controller_mixin';
-import { assert } from '@ember/debug';
import { Router } from '../..';
import { depre... | true |
Other | emberjs | ember.js | 0ff7e435dc2028940ff1c9b0e7fd6129624407f2.json | Resolve failing tests | packages/@ember/-internals/routing/tests/system/route_test.js | @@ -3,7 +3,6 @@ import { runDestroy, buildOwner, moduleFor, AbstractTestCase } from 'internal-te
import Service, { service } from '@ember/service';
import { Object as EmberObject } from '@ember/-internals/runtime';
import EmberRoute from '../../lib/system/route';
-import { defineProperty } from '../../../metal';
im... | true |
Other | emberjs | ember.js | ffcdb9fc8256da573ee8ba17eae3e6f747ded2a4.json | Fix failing lints | packages/@ember/-internals/routing/lib/system/route.ts | @@ -56,6 +56,11 @@ export type QueryParamMeta = {
};
};
+type RouteTransitionState = TransitionState<Route> & {
+ fullQueryParams?: Record<string, unknown>;
+ queryParamsFor?: Record<string, Record<string, unknown>>;
+};
+
export const ROUTE_CONNECTIONS = new WeakMap();
const RENDER = (symbol('render') as unk... | true |
Other | emberjs | ember.js | ffcdb9fc8256da573ee8ba17eae3e6f747ded2a4.json | Fix failing lints | packages/@ember/object/type-tests/computed/expand-properties.test.ts | @@ -1,5 +1,6 @@
import { expandProperties } from '@ember/object/computed';
+// eslint-disable-next-line no-console
expandProperties('{foo}.bar.{baz}', (arg: string) => console.log(arg));
// @ts-expect-error a callback is required | true |
Other | emberjs | ember.js | ffcdb9fc8256da573ee8ba17eae3e6f747ded2a4.json | Fix failing lints | packages/@ember/object/type-tests/evented/on.test.ts | @@ -4,6 +4,7 @@ import { expectTypeOf } from 'expect-type';
class Job {
logCompleted = on('completed', function () {
+ // eslint-disable-next-line no-console
console.log('Job completed!');
});
} | true |
Other | emberjs | ember.js | ffcdb9fc8256da573ee8ba17eae3e6f747ded2a4.json | Fix failing lints | packages/@ember/object/type-tests/events/index.test.ts | @@ -5,10 +5,12 @@ import { on } from '@ember/object/evented';
class Job extends EmberObject {
logStartOrUpdate = on('started', 'updated', () => {
+ // eslint-disable-next-line no-console
console.log('Job updated!');
});
logCompleted = on('completed', () => {
+ // eslint-disable-next-line no-con... | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/compat/dependent-key-compat.test.ts | @@ -5,8 +5,8 @@ expectTypeOf(dependentKeyCompat).toMatchTypeOf<PropertyDecorator>();
// Example (without irrelevant details) from https://api.emberjs.com/ember/3.18/functions/@ember%2Fobject%2Fcompat/dependentKeyCompat
class Person {
- firstName!: string;
- lastName!: string;
+ declare firstName: string;
+ decl... | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed.test.ts | @@ -1,4 +1,7 @@
import { computed } from '@ember/object';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(computed('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
declare firstName: string; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/alias.test.ts | @@ -1,4 +1,7 @@
import { alias } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(alias('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@alias('foo') alias: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/and.test.ts | @@ -1,4 +1,7 @@
import { and } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(and('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@and('foo') and: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/bool.test.ts | @@ -1,5 +1,9 @@
import { bool } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(bool('foo')).toEqualTypeOf<PropertyDecorator>();
+
class Foo {
@bool('foo') declare bool: boolean;
| true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/collect.test.ts | @@ -1,5 +1,9 @@
import { collect } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(collect('foo')).toEqualTypeOf<PropertyDecorator>();
+
class Foo {
@collect('foo') declare collect: unknown[];
@collect('foo', 'bar', 'baz') declare collect2: unknown[]; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/deprecating-alias.test.ts | @@ -1,5 +1,16 @@
import { deprecatingAlias } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(
+ deprecatingAlias('foo', {
+ id: 'test',
+ until: '4.0.0',
+ for: 'testing',
+ since: { enabled: '3.0.0' },
+ })
+).toEqualTypeOf<PropertyDecorator>();
+
class Foo... | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/empty.test.ts | @@ -1,4 +1,7 @@
import { empty } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(empty('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@empty('foo') declare empty: boolean; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/equal.test.ts | @@ -1,4 +1,7 @@
import { equal } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(equal('foo', 'bar')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@equal('foo', 'bar') declare equal: boolean; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/filter-by.test.ts | @@ -1,4 +1,7 @@
import { filterBy } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(filterBy('foo', 'key')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@filterBy('foo', 'key', 'value') | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/filter.test.ts | @@ -1,4 +1,7 @@
import { filter } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(filter('foo', (item: unknown) => Boolean(item))).toEqualTypeOf<PropertyDecorator>();
class Foo {
@filter('foo', (item: unknown) => Boolean(item)) | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/gt.test.ts | @@ -1,4 +1,7 @@
import { gt } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(gt('foo', 10)).toEqualTypeOf<PropertyDecorator>();
class Foo {
@gt('foo', 10) declare gt: boolean; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/gte.test.ts | @@ -1,4 +1,7 @@
import { gte } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(gte('foo', 10)).toEqualTypeOf<PropertyDecorator>();
class Foo {
@gte('foo', 10) declare gte: boolean; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/intersect.test.ts | @@ -1,4 +1,7 @@
import { intersect } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(intersect('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@intersect('foo') declare intersect: unknown[]; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/lt.test.ts | @@ -1,4 +1,7 @@
import { lt } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(lt('foo', 10)).toEqualTypeOf<PropertyDecorator>();
class Foo {
@lt('foo', 10) declare lt: boolean; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/lte.test.ts | @@ -1,4 +1,7 @@
import { lte } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(lte('foo', 10)).toEqualTypeOf<PropertyDecorator>();
class Foo {
@lte('foo', 10) declare lte: boolean; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/map-by.test.ts | @@ -1,4 +1,7 @@
import { mapBy } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(mapBy('foo', 'key')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@mapBy('foo', 'key') | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/map.test.ts | @@ -1,4 +1,7 @@
import { map } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(map('foo', (item: unknown) => Boolean(item))).toEqualTypeOf<PropertyDecorator>();
class Foo {
@map('foo', (item: unknown) => Boolean(item)) | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/match.test.ts | @@ -1,4 +1,7 @@
import { match } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(match('foo', /^foo$/)).toEqualTypeOf<PropertyDecorator>();
class Foo {
@match('foo', /^foo$/) declare match: boolean; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/max.test.ts | @@ -1,4 +1,7 @@
import { max } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(max('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@max('foo') max: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/min.test.ts | @@ -1,4 +1,7 @@
import { min } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(min('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@min('foo') min: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/none.test.ts | @@ -1,4 +1,7 @@
import { none } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(none('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@none('foo') none: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/not-empty.test.ts | @@ -1,4 +1,7 @@
import { notEmpty } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(notEmpty('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@notEmpty('foo') notEmpty: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/not.test.ts | @@ -1,4 +1,7 @@
import { not } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(not('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@not('foo') not: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/one-way.test.ts | @@ -1,4 +1,7 @@
import { oneWay } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(oneWay('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@oneWay('foo') oneWay: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/or.test.ts | @@ -1,4 +1,7 @@
import { or } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(or('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@or('foo') or: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/read-only.test.ts | @@ -1,4 +1,7 @@
import { readOnly } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(readOnly('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@readOnly('foo') readOnly: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/reads.test.ts | @@ -1,4 +1,7 @@
import { reads } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(reads('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@reads('foo') reads: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/set-diff.test.ts | @@ -1,4 +1,7 @@
import { setDiff } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(setDiff('foo', 'bar')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@setDiff('foo', 'bar') declare setDiff: boolean; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/sort.test.ts | @@ -1,4 +1,7 @@
import { sort } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(sort('foo', 'bar')).toEqualTypeOf<PropertyDecorator>();
class Foo {
// With sortKey | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/sum.test.ts | @@ -1,4 +1,7 @@
import { sum } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(sum('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@sum('foo') sum: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/union.test.ts | @@ -1,4 +1,7 @@
import { union } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(union('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@union('foo') declare union: unknown[]; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/uniq-by.test.ts | @@ -1,4 +1,7 @@
import { uniqBy } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(uniqBy('foo', 'bar')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@uniqBy('foo', 'key') | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/uniq.test.ts | @@ -1,4 +1,7 @@
import { uniq } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(uniq('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@uniq('foo') declare uniq: unknown[]; | true |
Other | emberjs | ember.js | 32eb0fde8d40c80438e601cb56be620ef1cf53f2.json | Improve return type of getProperties | packages/@ember/-internals/metal/lib/decorator.ts | @@ -19,7 +19,7 @@ export type ElementDescriptor = [
descriptor: DecoratorPropertyDescriptor
];
-export function isElementDescriptor(args: any[]): args is ElementDescriptor {
+export function isElementDescriptor(args: unknown[]): args is ElementDescriptor {
let [maybeTarget, maybeKey, maybeDesc] = args;
re... | true |
Other | emberjs | ember.js | 32eb0fde8d40c80438e601cb56be620ef1cf53f2.json | Improve return type of getProperties | packages/@ember/-internals/metal/lib/get_properties.ts | @@ -31,13 +31,10 @@ import { get } from './property_get';
@return {Object}
@public
*/
-function getProperties<L extends string[]>(obj: object, list: L): { [Key in L[number]]: unknown };
-function getProperties<L extends string[]>(
- obj: object,
- ...list: L
-): { [Key in L[number]]: unknown };
-function getPr... | true |
Other | emberjs | ember.js | 9354e508ee6fb0a8c2e881aab81dd4ab2e676861.json | Simplify computed types | packages/@ember/-internals/metal/lib/computed.ts | @@ -37,36 +37,30 @@ import {
PROPERTY_DID_CHANGE,
} from './property_events';
-export type ComputedPropertyGetterFunction<T> = (this: any, key: string) => T;
-export type ComputedPropertySetterFunction<T> = (
+export type ComputedPropertyGetterFunction = (this: any, key: string) => unknown;
+export type ComputedP... | true |
Other | emberjs | ember.js | 9354e508ee6fb0a8c2e881aab81dd4ab2e676861.json | Simplify computed types | packages/@ember/-internals/metal/lib/mixin.ts | @@ -68,12 +68,12 @@ function concatenatedMixinProperties(
return concats;
}
-function giveDecoratorSuper<Get, Set>(
+function giveDecoratorSuper(
key: string,
- decorator: ComputedDecorator<Get, Set>,
- property: ComputedProperty<Get, Set> | true,
+ decorator: ComputedDecorator,
+ property: ComputedPropert... | true |
Other | emberjs | ember.js | 76789a81888695ff03efa0c335d7abc7469194b8.json | Fix lint error | packages/@ember/object/type-tests/ember-object.test.ts | @@ -99,7 +99,6 @@ Person.reopen({ fullName: 6 });
// NOTE: This is marked as @internal and will not be publicly available
Person.reopenClass({ fullName: 6 });
-
class MyComponent extends EmberObject {
foo = 'bar';
| false |
Other | emberjs | ember.js | c2814c0eff10ecb0060aa726fea80595e248d4b0.json | Use internal version of alias and expandProperties | packages/@ember/object/computed.d.ts | @@ -1,6 +1,6 @@
import { DeprecationOptions } from '@ember/debug';
-export function alias(dependentKey: string): PropertyDecorator;
+export { alias, expandProperties } from '@ember/-internals/metal';
export function and(dependentKey: string, ...additionalDependentKeys: string[]): PropertyDecorator;
@@ -20,8 +20... | false |
Other | emberjs | ember.js | 4c9a7da54e6187df7abf98b3f6a75ddd63b563a4.json | Improve JS type handling | tsconfig.json | @@ -21,7 +21,9 @@
"newLine": "LF",
"noEmit": true,
- "allowJs": false,
+
+ "allowJs": true,
+ "checkJs": false,
"paths": {
"@glimmer/*": ["../node_modules/@glimmer/*"], | false |
Other | emberjs | ember.js | eeb2fe25bf4d91abbb5555787594a57066a06cdd.json | Remove extra exports | packages/@ember/-internals/runtime/index.d.ts | @@ -5,15 +5,6 @@ import Evented from './types/evented';
export const TargetActionSupport: any;
export function isArray(arr: any): boolean;
-export const ControllerMixin: any;
-
-export function deprecatingAlias(
- name: string,
- opts: {
- id: string;
- until: string;
- }
-): any;
// The public version ... | false |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/component-addon/index.js | @@ -4,9 +4,8 @@ const path = require('path');
const stringUtil = require('ember-cli-string-utils');
const getPathOption = require('ember-cli-get-component-path-option');
const normalizeEntityName = require('ember-cli-normalize-entity-name');
-const useEditionDetector = require('../edition-detector');
-module.expor... | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/component-addon/native-files/__root__/__path__/__name__.js | @@ -1 +0,0 @@
-export { default } from '<%= modulePath %>';
\ No newline at end of file | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/component-class-addon/index.js | @@ -4,9 +4,8 @@ const path = require('path');
const stringUtil = require('ember-cli-string-utils');
const getPathOption = require('ember-cli-get-component-path-option');
const normalizeEntityName = require('ember-cli-normalize-entity-name');
-const useEditionDetector = require('../edition-detector');
-module.expor... | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/component-class-addon/native-files/__root__/__path__/__name__.js | @@ -1 +0,0 @@
-export { default } from '<%= modulePath %>';
\ No newline at end of file | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/controller/files/__root__/__path__/__name__.js | @@ -1,4 +1,4 @@
import Controller from '@ember/controller';
-export default Controller.extend({
-});
+export default class <%= classifiedModuleName %>Controller extends Controller {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/controller/index.js | @@ -1,10 +1,8 @@
'use strict';
-const useEditionDetector = require('../edition-detector');
-
-module.exports = useEditionDetector({
+module.exports = {
description: 'Generates a controller.',
normalizeEntityName: function (entityName) {
return entityName.replace(/\.js$/, ''); //Prevent generation of ".js.... | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/controller/native-files/__root__/__path__/__name__.js | @@ -1,4 +0,0 @@
-import Controller from '@ember/controller';
-
-export default class <%= classifiedModuleName %>Controller extends Controller {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/route/files/__root__/__path__/__name__.js | @@ -1,11 +1,11 @@
import Route from '@ember/routing/route';
-export default Route.extend({<% if (hasDynamicSegment) {%>
+export default class <%= classifiedModuleName %>Route extends Route {<% if (hasDynamicSegment) {%>
model(params) {
/**
* This route was generated with a dynamic segment. Implement da... | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/route/index.js | @@ -5,9 +5,8 @@ const path = require('path');
const chalk = require('chalk');
const stringUtil = require('ember-cli-string-utils');
const EmberRouterGenerator = require('ember-router-generator');
-const useEditionDetector = require('../edition-detector');
-module.exports = useEditionDetector({
+module.exports = {
... | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/route/native-files/__root__/__path__/__name__.js | @@ -1,11 +0,0 @@
-import Route from '@ember/routing/route';
-
-export default class <%= classifiedModuleName %>Route extends Route {<% if (hasDynamicSegment) {%>
- model(params) {
- /**
- * This route was generated with a dynamic segment. Implement data loading
- * based on that dynamic segment here in the ... | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/route/native-files/__root__/__templatepath__/__templatename__.hbs | @@ -1,2 +0,0 @@
-<% if (addTitle) {%>{{page-title "<%= routeName %>"}}
-<%}%>{{outlet}}
\ No newline at end of file | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/service/files/__root__/__path__/__name__.js | @@ -1,4 +1,4 @@
import Service from '@ember/service';
-export default Service.extend({
-});
+export default class <%= classifiedModuleName %>Service extends Service {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/service/index.js | @@ -1,10 +1,8 @@
'use strict';
-const useEditionDetector = require('../edition-detector');
-
-module.exports = useEditionDetector({
+module.exports = {
description: 'Generates a service.',
normalizeEntityName: function (entityName) {
return entityName.replace(/\.js$/, ''); //Prevent generation of ".js.js"... | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/service/native-files/__root__/__path__/__name__.js | @@ -1,4 +0,0 @@
-import Service from '@ember/service';
-
-export default class <%= classifiedModuleName %>Service extends Service {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/blueprints/component-class-addon-test.js | @@ -4,11 +4,13 @@ const blueprintHelpers = require('ember-cli-blueprint-test-helpers/helpers');
const setupTestHooks = blueprintHelpers.setupTestHooks;
const emberNew = blueprintHelpers.emberNew;
const emberGenerateDestroy = blueprintHelpers.emberGenerateDestroy;
-
+const setupTestEnvironment = require('../helpers/s... | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/blueprints/component-class-test.js | @@ -188,23 +188,23 @@ describe('Blueprint: component-class', function () {
it('component-class foo --pod', function () {
return emberGenerateDestroy(['component-class', 'foo', '--pod'], (_file) => {
expect(_file('app/pods/components/foo/component.js')).to.equal(
- fixture('componen... | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/blueprints/controller-test.js | @@ -35,9 +35,7 @@ describe('Blueprint: controller', function () {
it('controller foo', function () {
return emberGenerateDestroy(['controller', 'foo'], (_file) => {
- expect(_file('app/controllers/foo.js')).to.equal(
- fixture('controller/native-controller.js')
- );
+ expect(... | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/blueprints/route-test.js | @@ -40,7 +40,7 @@ describe('Blueprint: route', function () {
it('route foo', function () {
return emberGenerateDestroy(['route', 'foo'], (_file) => {
- expect(_file('app/routes/foo.js')).to.equal(fixture('route/native-route.js'));
+ expect(_file('app/routes/foo.js')).to.equal(fixture('route/... | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/blueprints/service-test.js | @@ -35,7 +35,7 @@ describe('Blueprint: service', function () {
it('service foo', function () {
return emberGenerateDestroy(['service', 'foo'], (_file) => {
- expect(_file('app/services/foo.js')).to.equal(fixture('service/native-service.js'));
+ expect(_file('app/services/foo.js')).to.equal(f... | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/component-addon-dash-pod.js | @@ -1,6 +0,0 @@
-import Component from '@ember/component';
-import layout from './template';
-
-export default Component.extend({
- layout
-}); | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/component-addon-dash.js | @@ -1,6 +0,0 @@
-import Component from '@ember/component';
-import layout from '../templates/components/x-foo';
-
-export default Component.extend({
- layout
-}); | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/component-addon-nested-pod.js | @@ -1,6 +0,0 @@
-import Component from '@ember/component';
-import layout from './template';
-
-export default Component.extend({
- layout
-}); | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/component-addon-nested.js | @@ -1,6 +0,0 @@
-import Component from '@ember/component';
-import layout from '../../templates/components/foo/x-foo';
-
-export default Component.extend({
- layout
-}); | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/component-addon.js | @@ -1,6 +0,0 @@
-import Component from '@ember/component';
-import layout from '../templates/components/foo';
-
-export default Component.extend({
- layout
-}); | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/component-dash.js | @@ -1,4 +1,4 @@
-import Component from '@ember/component';
+import Component from '@glimmer/component';
-export default Component.extend({
-});
+export default class XFooComponent extends Component {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/component-nested.js | @@ -1,4 +1,4 @@
-import Component from '@ember/component';
+import Component from '@glimmer/component';
-export default Component.extend({
-});
+export default class FooXFooComponent extends Component {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/component.js | @@ -1,4 +1,4 @@
-import Component from '@ember/component';
+import Component from '@glimmer/component';
-export default Component.extend({
-});
+export default class FooComponent extends Component {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/native-component-dash.js | @@ -1,4 +0,0 @@
-import Component from '@glimmer/component';
-
-export default class XFooComponent extends Component {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/native-component-nested.js | @@ -1,4 +0,0 @@
-import Component from '@glimmer/component';
-
-export default class FooXFooComponent extends Component {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/native-component.js | @@ -1,4 +0,0 @@
-import Component from '@glimmer/component';
-
-export default class FooComponent extends Component {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/controller/controller-nested.js | @@ -1,4 +1,4 @@
import Controller from '@ember/controller';
-export default Controller.extend({
-});
+export default class FooBarController extends Controller {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/controller/controller.js | @@ -1,4 +1,4 @@
import Controller from '@ember/controller';
-export default Controller.extend({
-});
+export default class FooController extends Controller {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/controller/native-controller-nested.js | @@ -1,4 +0,0 @@
-import Controller from '@ember/controller';
-
-export default class FooBarController extends Controller {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/controller/native-controller.js | @@ -1,4 +0,0 @@
-import Controller from '@ember/controller';
-
-export default class FooController extends Controller {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/route/native-route-child.js | @@ -1,4 +0,0 @@
-import Route from '@ember/routing/route';
-
-export default class ParentChildRoute extends Route {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/route/native-route-nested.js | @@ -1,4 +0,0 @@
-import Route from '@ember/routing/route';
-
-export default class FooBarRoute extends Route {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/route/native-route-with-dynamic-segment.js | @@ -1,11 +0,0 @@
-import Route from '@ember/routing/route';
-
-export default class FooRoute extends Route {
- model(params) {
- /**
- * This route was generated with a dynamic segment. Implement data loading
- * based on that dynamic segment here in the model hook.
- */
- return params;
- }
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/route/native-route.js | @@ -1,4 +0,0 @@
-import Route from '@ember/routing/route';
-
-export default class FooRoute extends Route {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/route/route-child.js | @@ -1,4 +1,4 @@
import Route from '@ember/routing/route';
-export default Route.extend({
-});
+export default class ParentChildRoute extends Route {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/route/route-nested.js | @@ -1,4 +1,4 @@
import Route from '@ember/routing/route';
-export default Route.extend({
-});
+export default class FooBarRoute extends Route {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/route/route-with-dynamic-segment.js | @@ -1,11 +1,11 @@
import Route from '@ember/routing/route';
-export default Route.extend({
+export default class FooRoute extends Route {
model(params) {
/**
* This route was generated with a dynamic segment. Implement data loading
* based on that dynamic segment here in the model hook.
*/
... | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/route/route.js | @@ -1,4 +1,4 @@
import Route from '@ember/routing/route';
-export default Route.extend({
-});
+export default class FooRoute extends Route {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/service/native-service-nested.js | @@ -1,4 +0,0 @@
-import Service from '@ember/service';
-
-export default class FooBarService extends Service {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/service/native-service.js | @@ -1,4 +0,0 @@
-import Service from '@ember/service';
-
-export default class FooService extends Service {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/service/service-nested.js | @@ -1,4 +1,4 @@
import Service from '@ember/service';
-export default Service.extend({
-});
+export default class FooBarService extends Service {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/service/service.js | @@ -1,4 +1,4 @@
import Service from '@ember/service';
-export default Service.extend({
-});
+export default class FooService extends Service {
+} | true |
Other | emberjs | ember.js | 5ea53d595877c49aad18c8a6ca68d23b1ea226f5.json | Add v4.2.0-beta.1 to CHANGELOG
(cherry picked from commit 3b4b36d97235dddda882e014a0727fb5a41195a8) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v4.2.0-beta.1 (December 28, 2021)
+
+- [#19878](https://github.com/emberjs/ember.js/pull/19772) [BUGFIX] Allow class-based helpers to work in strict-mode.
+
### v4.1.0 (December 28, 2021)
- [#19772](https://github.com/emberjs/ember.js/pull/19772) / [#19826](https://github.c... | false |
Other | emberjs | ember.js | b50b0f8ea1ff14963d765b761048e6077c0df2d5.json | Add documentation for `setComponentManager` | packages/@ember/-internals/glimmer/lib/utils/managers.ts | @@ -6,6 +6,17 @@ import {
setComponentManager as glimmerSetComponentManager,
} from '@glimmer/manager';
+/**
+ Associate a class with a component manager (an object that is responsible for
+ coordinating the lifecycle events that occurs when invoking, rendering and
+ re-rendering a component).
+
+ @method... | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.