language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/-internals/views/lib/mixins/action_support.ts
@@ -5,8 +5,16 @@ import { inspect } from '@ember/-internals/utils'; import { Mixin, get } from '@ember/-internals/metal'; import { assert } from '@ember/debug'; -const mixinObj = { - send(actionName, ...args) { +/** + @class ActionSupport + @namespace Ember + @private +*/ +interface ActionSupport { + send(actionN...
true
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/-internals/views/lib/mixins/child_views_support.d.ts
@@ -1,10 +0,0 @@ -import { View } from '@ember/-internals/glimmer/lib/renderer'; -import Mixin from '@ember/object/mixin'; - -interface ChildViewsSupport { - readonly childViews: View[]; - appendChild(view: View): void; -} -declare const ChildViewsSupport: Mixin; - -export default ChildViewsSupport;
true
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/-internals/views/lib/mixins/child_views_support.ts
@@ -1,10 +1,15 @@ /** @module ember */ +import { View } from '@ember/-internals/glimmer/lib/renderer'; import { Mixin, nativeDescDecorator } from '@ember/-internals/metal'; import { getChildViews, addChildView } from '../system/utils'; -export default Mixin.create({ +interface ChildViewsSupport { + readonly chi...
true
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/-internals/views/lib/mixins/class_names_support.d.ts
@@ -1,9 +0,0 @@ -import Mixin from '@ember/object/mixin'; - -interface ClassNamesSupport { - classNames: string[]; - classNameBindings: string[]; -} -declare const ClassNamesSupport: Mixin; - -export default ClassNamesSupport;
true
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/-internals/views/lib/mixins/class_names_support.ts
@@ -11,7 +11,11 @@ const EMPTY_ARRAY = Object.freeze([]); @namespace Ember @private */ -export default Mixin.create({ +interface ClassNamesSupport { + classNames: string[]; + classNameBindings: string[]; +} +const ClassNamesSupport = Mixin.create({ concatenatedProperties: ['classNames', 'classNameBindings']...
true
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/-internals/views/lib/mixins/view_state_support.d.ts
@@ -1,8 +0,0 @@ -import Mixin from '@ember/object/mixin'; - -interface ViewStateSupport { - _transitionTo(state: unknown): void; -} -declare const ViewStateSupport: Mixin; - -export default ViewStateSupport;
true
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/-internals/views/lib/mixins/view_state_support.ts
@@ -2,9 +2,15 @@ @module ember */ import { Mixin } from '@ember/-internals/metal'; +import type Component from '@ember/component'; +import type states from '../views/states'; -export default Mixin.create({ - _transitionTo(state) { +interface ViewStateSupport { + /** @internal */ + _transitionTo(state: keyof typ...
true
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/-internals/views/lib/mixins/view_support.d.ts
@@ -1,19 +0,0 @@ -import Mixin from '@ember/object/mixin'; - -interface ViewSupport { - rerender(): unknown; - element: Element; - appendTo(selector: string | Element): this; - append(): this; - elementId: string | null; - willInsertElement(): void; - didInsertElement(): void; - willClearRender(): void; - will...
true
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/-internals/views/lib/mixins/view_support.ts
@@ -3,12 +3,34 @@ import { descriptorForProperty, Mixin, nativeDescDecorator } from '@ember/-inter import { assert } from '@ember/debug'; import { hasDOM } from '@ember/-internals/browser-environment'; import { matches } from '../system/utils'; +import type Component from '@ember/component'; +import { View } from '@...
true
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/-internals/views/lib/system/action_manager.ts
@@ -1,3 +1,5 @@ +import type { ActionState } from '@ember/-internals/glimmer/lib/modifiers/action'; + /** @module ember */ @@ -11,4 +13,4 @@ export default function ActionManager() {} @property registeredActions @type Object */ -ActionManager.registeredActions = {}; +ActionManager.registeredActions = {} as Re...
true
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/-internals/views/lib/system/event_dispatcher.d.ts
@@ -1,11 +0,0 @@ -import EmberObject from '@ember/object'; - -export default class EventDispatcher extends EmberObject { - finalEventNameMapping: Record<string, string>; - lazyEvents: Map<string, string>; - setupHandlerForBrowserEvent(event: string): void; - setupHandlerForEmberEvent(event: string): void; - - /** ...
true
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/-internals/views/lib/system/event_dispatcher.ts
@@ -4,6 +4,10 @@ import { get, set } from '@ember/-internals/metal'; import { Object as EmberObject } from '@ember/-internals/runtime'; import { getElementView } from '@ember/-internals/views'; import ActionManager from './action_manager'; +import { BootEnvironment } from '@ember/-internals/glimmer/lib/views/outlet'...
true
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/-internals/views/lib/views/core_view.ts
@@ -1,7 +1,7 @@ import { Renderer, View } from '@ember/-internals/glimmer/lib/renderer'; import { inject } from '@ember/-internals/metal'; import { ActionHandler, Evented, FrameworkObject } from '@ember/-internals/runtime'; -import states from './states'; +import states, { ViewState } from './states'; /** `Emb...
true
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/-internals/views/lib/views/states.ts
@@ -6,6 +6,7 @@ import Component from '@ember/component'; export interface ViewState { enter?(view: Component): void; + exit?(view: Component): void; appendChild(): void; handleEvent(view: Component, eventName: string, event: Event): boolean; rerender(view: Component): void;
true
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/application/instance.ts
@@ -12,12 +12,13 @@ import { assert } from '@ember/debug'; import { Router } from '@ember/-internals/routing'; import { EventDispatcher, ViewMixin } from '@ember/-internals/views'; import { Registry } from '@ember/-internals/container'; +import { SimpleElement } from '@simple-dom/interface'; export interface Boot...
true
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/application/lib/application.ts
@@ -27,6 +27,7 @@ import { Container, privatize as P, Registry } from '@ember/-internals/container import { setupApplicationRegistry } from '@ember/-internals/glimmer'; import { RouterService } from '@ember/-internals/routing'; import { EngineInstanceOptions } from '@ember/engine/instance'; +import { SimpleDocument,...
true
Other
emberjs
ember.js
9e82676a46db9aca32e7d130aca249f19f2bf4f5.json
Add notes about IContainer and IRegistry
packages/@ember/-internals/runtime/lib/mixins/container_proxy.ts
@@ -7,6 +7,8 @@ import { TypeOptions } from '@ember/-internals/container/lib/registry'; import { Mixin } from '@ember/-internals/metal'; import { Factory } from '@ember/-internals/owner'; +// This is defined as a separate interface so that it can be used in the definition of +// `Owner` without also including the `...
true
Other
emberjs
ember.js
9e82676a46db9aca32e7d130aca249f19f2bf4f5.json
Add notes about IContainer and IRegistry
packages/@ember/-internals/runtime/lib/mixins/registry_proxy.ts
@@ -9,6 +9,8 @@ import { Factory } from '@ember/-internals/owner'; import { AnyFn } from '@ember/-internals/utils/types'; import { assert } from '@ember/debug'; +// This is defined as a separate interface so that it can be used in the definition of +// `Owner` without also including the `__registry__` property. ex...
true
Other
emberjs
ember.js
6123eeb93b24c44aaa8b18eff6ea6e6542a44d06.json
Convert ViewStates to TS
packages/@ember/-internals/views/lib/views/states.ts
@@ -2,6 +2,15 @@ import preRender from './states/pre_render'; import hasElement from './states/has_element'; import inDOM from './states/in_dom'; import destroying from './states/destroying'; +import Component from '@ember/component'; + +export interface ViewState { + enter?(view: Component): void; + appendChild()...
true
Other
emberjs
ember.js
6123eeb93b24c44aaa8b18eff6ea6e6542a44d06.json
Convert ViewStates to TS
packages/@ember/-internals/views/lib/views/states/default.ts
@@ -1,6 +1,7 @@ import EmberError from '@ember/error'; +import type { ViewState } from '../states'; -const _default = { +const _default: ViewState = { // appendChild is only legal while rendering the buffer. appendChild() { throw new EmberError("You can't use appendChild outside of the rendering process")...
true
Other
emberjs
ember.js
6123eeb93b24c44aaa8b18eff6ea6e6542a44d06.json
Convert ViewStates to TS
packages/@ember/-internals/views/lib/views/states/destroying.ts
@@ -1,13 +1,17 @@ import EmberError from '@ember/error'; +import type { ViewState } from '../states'; import _default from './default'; -const destroying = Object.assign({}, _default, { +const destroying: ViewState = { + ..._default, + appendChild() { throw new EmberError("You can't call appendChild on a v...
true
Other
emberjs
ember.js
6123eeb93b24c44aaa8b18eff6ea6e6542a44d06.json
Convert ViewStates to TS
packages/@ember/-internals/views/lib/views/states/has_element.ts
@@ -1,18 +1,22 @@ import _default from './default'; import { join } from '@ember/runloop'; import { flaggedInstrument } from '@ember/instrumentation'; +import Component from '@ember/component'; +import type { ViewState } from '../states'; -const hasElement = Object.assign({}, _default, { - rerender(view) { - v...
true
Other
emberjs
ember.js
6123eeb93b24c44aaa8b18eff6ea6e6542a44d06.json
Convert ViewStates to TS
packages/@ember/-internals/views/lib/views/states/in_dom.ts
@@ -1,17 +1,26 @@ import { teardownMandatorySetter } from '@ember/-internals/utils'; +import type Component from '@ember/component'; +import { assert } from '@ember/debug'; import EmberError from '@ember/error'; import { DEBUG } from '@glimmer/env'; +import type { ViewState } from '../states'; import hasElement fro...
true
Other
emberjs
ember.js
6123eeb93b24c44aaa8b18eff6ea6e6542a44d06.json
Convert ViewStates to TS
packages/@ember/-internals/views/lib/views/states/pre_render.ts
@@ -1,5 +1,5 @@ import _default from './default'; -const preRender = Object.assign({}, _default); +const preRender = { ..._default }; export default Object.freeze(preRender);
true
Other
emberjs
ember.js
8c9004ece9eed44398a06489dfb561d23710b37d.json
Convert ObjectProxy to TS
packages/@ember/-internals/runtime/lib/system/object_proxy.d.ts
@@ -1,8 +0,0 @@ -import FrameworkObject from './object'; -import _ProxyMixin from '../mixins/-proxy'; - -// eslint-disable-next-line @typescript-eslint/no-empty-interface -interface ObjectProxy extends _ProxyMixin {} -declare class ObjectProxy extends FrameworkObject {} - -export default ObjectProxy;
true
Other
emberjs
ember.js
8c9004ece9eed44398a06489dfb561d23710b37d.json
Convert ObjectProxy to TS
packages/@ember/-internals/runtime/lib/system/object_proxy.ts
@@ -77,5 +77,9 @@ import _ProxyMixin from '../mixins/-proxy'; @uses Ember.ProxyMixin @public */ -export default class ObjectProxy extends FrameworkObject {} +// eslint-disable-next-line @typescript-eslint/no-empty-interface +interface ObjectProxy extends _ProxyMixin {} +class ObjectProxy extends FrameworkObject ...
true
Other
emberjs
ember.js
e0eb44fc655d2f37078b1924c54c14a619efd8b3.json
Eliminate an unnecessary cast in resolver.ts
packages/@ember/-internals/glimmer/lib/resolver.ts
@@ -103,7 +103,7 @@ function lookupComponentPair( } } -const BUILTIN_KEYWORD_HELPERS = { +const BUILTIN_KEYWORD_HELPERS: Record<string, object> = { action, mut, readonly, @@ -145,7 +145,7 @@ if (EMBER_UNIQUE_ID_HELPER) { BUILTIN_HELPERS['unique-id'] = uniqueId; } -const BUILTIN_KEYWORD_MODIFIERS = ...
false
Other
emberjs
ember.js
7987f54f1fcb91628ddf3e572e6f78ed185ef933.json
Add type utils
packages/@ember/-internals/glimmer/lib/helpers/action.ts
@@ -2,6 +2,7 @@ @module ember */ import { get } from '@ember/-internals/metal'; +import { AnyFn } from '@ember/-internals/utils/types'; import { assert } from '@ember/debug'; import { flaggedInstrument } from '@ember/instrumentation'; import { join } from '@ember/runloop'; @@ -354,7 +355,7 @@ function makeArgsPro...
true
Other
emberjs
ember.js
7987f54f1fcb91628ddf3e572e6f78ed185ef933.json
Add type utils
packages/@ember/-internals/metal/lib/events.ts
@@ -3,6 +3,7 @@ */ import { Meta, meta as metaFor, peekMeta } from '@ember/-internals/meta'; import { setListeners } from '@ember/-internals/utils'; +import { AnyFn } from '@ember/-internals/utils/types'; import { assert } from '@ember/debug'; /* @@ -203,9 +204,7 @@ export function hasListeners(obj: object, even...
true
Other
emberjs
ember.js
7987f54f1fcb91628ddf3e572e6f78ed185ef933.json
Add type utils
packages/@ember/-internals/metal/lib/mixin.ts
@@ -12,6 +12,7 @@ import { setObservers, wrap, } from '@ember/-internals/utils'; +import { AnyFn } from '@ember/-internals/utils/types'; import { assert } from '@ember/debug'; import { DEBUG } from '@glimmer/env'; import { _WeakSet } from '@glimmer/util'; @@ -763,7 +764,7 @@ function _keys(mixin: Mixin, ret =...
true
Other
emberjs
ember.js
7987f54f1fcb91628ddf3e572e6f78ed185ef933.json
Add type utils
packages/@ember/-internals/routing/lib/location/auto_location.ts
@@ -2,6 +2,7 @@ import { history, location, userAgent, window } from '@ember/-internals/browser- import { set } from '@ember/-internals/metal'; import { getOwner } from '@ember/-internals/owner'; import { Object as EmberObject } from '@ember/-internals/runtime'; +import { AnyFn, MethodNamesOf } from '@ember/-interna...
true
Other
emberjs
ember.js
7987f54f1fcb91628ddf3e572e6f78ed185ef933.json
Add type utils
packages/@ember/-internals/routing/lib/system/route.ts
@@ -21,6 +21,7 @@ import { typeOf, } from '@ember/-internals/runtime'; import { isProxy, lookupDescriptor } from '@ember/-internals/utils'; +import { AnyFn } from '@ember/-internals/utils/types'; import Controller from '@ember/controller'; import { ControllerQueryParamType } from '@ember/controller/lib/controlle...
true
Other
emberjs
ember.js
7987f54f1fcb91628ddf3e572e6f78ed185ef933.json
Add type utils
packages/@ember/-internals/routing/lib/system/router.ts
@@ -48,14 +48,7 @@ import type { Timer } from 'backburner'; import { EngineRouteInfo } from './engines'; import EngineInstance from '@ember/engine/instance'; import { QueryParams } from 'route-recognizer'; - -type AnyFn = (...args: any[]) => any; - -type MethodNamesOf<T> = { - [K in keyof T]: T[K] extends AnyFn ? K...
true
Other
emberjs
ember.js
7987f54f1fcb91628ddf3e572e6f78ed185ef933.json
Add type utils
packages/@ember/-internals/runtime/lib/mixins/array.d.ts
@@ -1,4 +1,5 @@ import { Mixin } from '@ember/-internals/metal'; +import { AnyFn } from '@ember/-internals/utils/types'; import Enumerable from './enumerable'; import MutableEnumerable from './mutable_enumerable'; @@ -55,8 +56,8 @@ interface EmberArray<T> extends Enumerable { ): V; invoke<K extends string>( ...
true
Other
emberjs
ember.js
7987f54f1fcb91628ddf3e572e6f78ed185ef933.json
Add type utils
packages/@ember/-internals/utils/types.ts
@@ -0,0 +1,7 @@ +export type AnyFn = (...args: any[]) => any; + +export type MethodNamesOf<T> = { + [K in keyof T]: T[K] extends AnyFn ? K : never; +}[keyof T]; + +export type OmitFirst<F> = F extends [any, ...infer R] ? R : [];
true
Other
emberjs
ember.js
7987f54f1fcb91628ddf3e572e6f78ed185ef933.json
Add type utils
packages/@ember/debug/index.ts
@@ -1,4 +1,5 @@ import { isChrome, isFirefox } from '@ember/-internals/browser-environment'; +import { AnyFn } from '@ember/-internals/utils/types'; import EmberError from '@ember/error'; import { DEBUG } from '@glimmer/env'; import _deprecate, { DeprecateFunc, DeprecationOptions } from './lib/deprecate'; @@ -243,7...
true
Other
emberjs
ember.js
7987f54f1fcb91628ddf3e572e6f78ed185ef933.json
Add type utils
packages/@ember/runloop/index.ts
@@ -2,6 +2,7 @@ import { assert } from '@ember/debug'; import { onErrorTarget } from '@ember/-internals/error-handling'; import { flushAsyncObservers } from '@ember/-internals/metal'; import Backburner, { DeferredActionQueues, Timer } from 'backburner'; +import { AnyFn } from '@ember/-internals/utils/types'; expo...
true
Other
emberjs
ember.js
6c259fcafa2de6fae3810a6761d04a847f5bd49a.json
Add v3.28.9 to CHANGELOG (cherry picked from commit 40c1849d2230519428c199d2a9b10bf3a3ebf9a6)
CHANGELOG.md
@@ -1,4 +1,8 @@ -# Ember Changelog +# Ember Changelo + +## v3.28.9 (April 19, 2022) + +- [#20028](https://github.com/emberjs/ember.js/pull/20028) Fix a memory leak in the Router Service class ### v4.4.0-beta.1 (March 24, 2022)
false
Other
emberjs
ember.js
97aa2436b08e7569e4f6d4e8e692e32dc1d0e909.json
Add v4.4.0-beta.1 to CHANGELOG
CHANGELOG.md
@@ -1,5 +1,13 @@ # Ember Changelog +### v4.4.0-beta.1 (March 24, 2022) + +- [#19882](https://github.com/emberjs/ember.js/pull/19882) / [#20005](https://github.com/emberjs/ember.js/pull/20005) [FEATURE] Implement the `unique-id` helper per [RFC #0659](https://github.com/emberjs/rfcs/blob/master/text/0659-unique-id-he...
false
Other
emberjs
ember.js
0e2f7e26384eea39bda21111b24b511ee8444525.json
Add v4.3.0 to CHANGELOG
CHANGELOG.md
@@ -1,12 +1,10 @@ # Ember Changelog -### v4.3.0-beta.2 (March 1, 2022) +### v4.3.0 (March 21, 2022) +- [#20025](https://github.com/emberjs/ember.js/pull/20025) [BUGFIX] Fix a memory leak in the Router Service class - [#19971](https://github.com/emberjs/ember.js/pull/19971) [BUGFIX] Don't serialize default Query P...
false
Other
emberjs
ember.js
70058439456e66d659465b481c7d282084418940.json
Resolve some issues in TS conversion
packages/@ember/-internals/glimmer/lib/helper.ts
@@ -35,14 +35,6 @@ export interface HelperInstance<T = unknown> { destroy(): void; } -export function isHelperInstance(obj: unknown): obj is HelperInstance { - if (obj !== null && typeof obj === 'object') { - let cast = obj as HelperInstance; - return typeof cast.compute === 'function' && typeof cast.destr...
true
Other
emberjs
ember.js
70058439456e66d659465b481c7d282084418940.json
Resolve some issues in TS conversion
packages/@ember/-internals/routing/lib/system/router.ts
@@ -302,6 +302,8 @@ class EmberRouter<R extends Route = Route> extends EmberObject.extend(Evented) i return path.join('.'); } + // Note that owner is actually required in this scenario, but since it is strictly + // optional in other contexts trying to make it required here confuses TS. constructor(owner...
true
Other
emberjs
ember.js
70058439456e66d659465b481c7d282084418940.json
Resolve some issues in TS conversion
packages/@ember/-internals/runtime/lib/system/namespace.ts
@@ -34,19 +34,19 @@ import EmberObject from './object'; @extends EmberObject @public */ -export default class Namespace extends EmberObject { +class Namespace extends EmberObject { static NAMESPACES = NAMESPACES; static NAMESPACES_BY_ID = NAMESPACES_BY_ID; static processAll = processAllNamespaces; st...
true
Other
emberjs
ember.js
70058439456e66d659465b481c7d282084418940.json
Resolve some issues in TS conversion
packages/@ember/-internals/views/lib/views/core_view.ts
@@ -21,11 +21,7 @@ import states from './states'; */ interface CoreView extends FrameworkObject, Evented, ActionHandler, View {} -class CoreView extends FrameworkObject.extend(Evented, ActionHandler, { - // Continue to declare `_states` here so that we have a single reference on the prototype - // instead of one ...
true
Other
emberjs
ember.js
70058439456e66d659465b481c7d282084418940.json
Resolve some issues in TS conversion
packages/@ember/application/instance.ts
@@ -101,7 +101,7 @@ class ApplicationInstance extends EngineInstance { return this; } - options = new CBootOptions(options); + options = new _BootOptions(options); this.setupRegistry(options); @@ -133,13 +133,13 @@ class ApplicationInstance extends EngineInstance { _router?: Router; ...
true
Other
emberjs
ember.js
70058439456e66d659465b481c7d282084418940.json
Resolve some issues in TS conversion
packages/@ember/engine/index.ts
@@ -15,7 +15,7 @@ import { setupEngineRegistry } from '@ember/-internals/glimmer'; import RegistryProxyMixin from '@ember/-internals/runtime/lib/mixins/registry_proxy'; import { ResolverClass } from '@ember/-internals/container/lib/registry'; -function props(obj: any) { +function props(obj: object) { let propert...
true
Other
emberjs
ember.js
9adc2739b5accb9afeec9543dce2a66dd4974b2f.json
Upgrade eslint and prettier dependencies
package.json
@@ -94,8 +94,8 @@ "@simple-dom/document": "^1.4.0", "@types/qunit": "^2.11.3", "@types/rsvp": "^4.0.4", - "@typescript-eslint/eslint-plugin": "^5.10.0", - "@typescript-eslint/parser": "^5.13.0", + "@typescript-eslint/eslint-plugin": "^5.15.0", + "@typescript-eslint/parser": "^5.15.0", "a...
true
Other
emberjs
ember.js
9adc2739b5accb9afeec9543dce2a66dd4974b2f.json
Upgrade eslint and prettier dependencies
yarn.lock
@@ -1269,16 +1269,16 @@ semver "^7.3.5" typescript-memoize "^1.0.1" -"@eslint/eslintrc@^1.0.5": - version "1.0.5" - resolved "https://registry.yarnpkg.com/@eslint/eslintrc/-/eslintrc-1.0.5.tgz#33f1b838dbf1f923bfa517e008362b78ddbbf318" - integrity sha512-BLxsnmK3KyPunz5wmCCpqy0YelEoxxGmH73Is+Z74oOTMtExcjk...
true
Other
emberjs
ember.js
ae6f8076c62a102caae6342a6910adb14590bc0e.json
Convert Object internals to TS
packages/@ember/-internals/glimmer/lib/component.ts
@@ -1,7 +1,6 @@ import { get, PROPERTY_DID_CHANGE } from '@ember/-internals/metal'; import { getOwner } from '@ember/-internals/owner'; import { TargetActionSupport } from '@ember/-internals/runtime'; -import { CoreObjectClass } from '@ember/-internals/runtime/lib/system/core_object'; import { ActionSupport, ...
true
Other
emberjs
ember.js
ae6f8076c62a102caae6342a6910adb14590bc0e.json
Convert Object internals to TS
packages/@ember/-internals/glimmer/lib/renderer.ts
@@ -293,7 +293,9 @@ export class Renderer { private _lastRevision = -1; private _destroyed = false; - private _isInteractive: boolean; + + /** @private */ + _isInteractive: boolean; readonly _runtimeResolver: ResolverImpl;
true
Other
emberjs
ember.js
ae6f8076c62a102caae6342a6910adb14590bc0e.json
Convert Object internals to TS
packages/@ember/-internals/meta/lib/meta.ts
@@ -1,3 +1,4 @@ +import { ComputedProperty } from '@ember/-internals/metal'; import { symbol, toString } from '@ember/-internals/utils'; import { assert } from '@ember/debug'; import { isDestroyed } from '@glimmer/destroyable'; @@ -330,7 +331,7 @@ export class Meta { } /** @internal */ - forEachDescriptors(...
true
Other
emberjs
ember.js
ae6f8076c62a102caae6342a6910adb14590bc0e.json
Convert Object internals to TS
packages/@ember/-internals/metal/index.ts
@@ -2,7 +2,14 @@ export { default as computed, autoComputed, isComputed, ComputedProperty } from export { getCachedValueFor } from './lib/computed_cache'; export { default as alias } from './lib/alias'; export { deprecateProperty } from './lib/deprecate_property'; -export { PROXY_CONTENT, _getPath, get, _getProp } f...
true
Other
emberjs
ember.js
ae6f8076c62a102caae6342a6910adb14590bc0e.json
Convert Object internals to TS
packages/@ember/-internals/metal/lib/is_empty.ts
@@ -1,4 +1,4 @@ -import { get, MaybeHasUnknownProperty } from './property_get'; +import { get, hasUnknownProperty } from './property_get'; /** @module @ember/utils */ @@ -39,10 +39,7 @@ export default function isEmpty(obj: unknown): boolean { return true; } - if ( - typeof (obj as MaybeHasUnknownPrope...
true
Other
emberjs
ember.js
ae6f8076c62a102caae6342a6910adb14590bc0e.json
Convert Object internals to TS
packages/@ember/-internals/metal/lib/mixin.ts
@@ -383,7 +383,11 @@ function updateObserversAndListeners(obj: object, key: string, fn: Function, add } } -export function applyMixin(obj: { [key: string]: any }, mixins: Mixin[], _hideKeys = false) { +export function applyMixin( + obj: { [key: string]: any }, + mixins: Array<Mixin | Record<string, unknown>>, +...
true
Other
emberjs
ember.js
ae6f8076c62a102caae6342a6910adb14590bc0e.json
Convert Object internals to TS
packages/@ember/-internals/metal/lib/property_get.ts
@@ -24,8 +24,16 @@ if (DEBUG) { }; } -export interface MaybeHasUnknownProperty { - unknownProperty?: (keyName: string) => any; +export interface HasUnknownProperty { + unknownProperty: (keyName: string) => any; +} + +export function hasUnknownProperty(val: unknown): val is HasUnknownProperty { + return ( + ...
true
Other
emberjs
ember.js
ae6f8076c62a102caae6342a6910adb14590bc0e.json
Convert Object internals to TS
packages/@ember/-internals/runtime/lib/mixins/evented.d.ts
@@ -13,13 +13,6 @@ interface Evented { method: string | ((this: Target, ...args: any[]) => void) ): this; on(name: string, method: ((...args: any[]) => void) | string): this; - // Allow for easier super calls - on<Target>( - name: string, - ...args: - | [Target, string | ((this: Target, ...args:...
true
Other
emberjs
ember.js
ae6f8076c62a102caae6342a6910adb14590bc0e.json
Convert Object internals to TS
packages/@ember/-internals/runtime/lib/system/core_object.d.ts
@@ -1,148 +0,0 @@ -import { Owner } from '@ember/-internals/owner'; - -/** - * Used to infer the type of ember classes of type `T`. - * - * Generally you would use `EmberClass.create()` instead of `new EmberClass()`. - * - * The single-arg constructor is required by the typescript compiler. - * The multi-arg constructo...
true
Other
emberjs
ember.js
ae6f8076c62a102caae6342a6910adb14590bc0e.json
Convert Object internals to TS
packages/@ember/-internals/runtime/lib/system/core_object.ts
@@ -3,7 +3,7 @@ */ import { getFactoryFor, setFactoryFor } from '@ember/-internals/container'; -import { getOwner } from '@ember/-internals/owner'; +import { getOwner, Owner } from '@ember/-internals/owner'; import { guidFor, makeArray, isInternalSymbol } from '@ember/-internals/utils'; import { meta } from '@emb...
true
Other
emberjs
ember.js
ae6f8076c62a102caae6342a6910adb14590bc0e.json
Convert Object internals to TS
packages/@ember/-internals/views/lib/mixins/class_names_support.d.ts
@@ -1,7 +1,6 @@ import Mixin from '@ember/object/mixin'; interface ClassNamesSupport { - concatenatedProperties: string[]; classNames: string[]; classNameBindings: string[]; }
true
Other
emberjs
ember.js
ae6f8076c62a102caae6342a6910adb14590bc0e.json
Convert Object internals to TS
packages/@ember/-internals/views/lib/mixins/view_support.d.ts
@@ -1,7 +1,6 @@ import Mixin from '@ember/object/mixin'; interface ViewSupport { - concatenatedProperties: string[]; rerender(): unknown; element: Element; appendTo(selector: string | Element): this;
true
Other
emberjs
ember.js
ae6f8076c62a102caae6342a6910adb14590bc0e.json
Convert Object internals to TS
packages/@ember/-internals/views/lib/views/core_view.ts
@@ -1,7 +1,6 @@ -import { View } from '@ember/-internals/glimmer/lib/renderer'; +import { Renderer, View } from '@ember/-internals/glimmer/lib/renderer'; import { inject } from '@ember/-internals/metal'; import { ActionHandler, Evented, FrameworkObject } from '@ember/-internals/runtime'; -import { CoreObjectClass } f...
true
Other
emberjs
ember.js
ae6f8076c62a102caae6342a6910adb14590bc0e.json
Convert Object internals to TS
packages/@ember/controller/lib/controller_mixin.d.ts
@@ -14,8 +14,6 @@ interface ControllerMixin<T> { // From routing/lib/ext/controller - concatenatedProperties: string[]; - queryParams: Array<string | Record<string, { type: 'boolean' | 'number' | 'array' | 'string' }>>; transitionToRoute(...args: RouteArgs<Route>): Transition;
true
Other
emberjs
ember.js
ae6f8076c62a102caae6342a6910adb14590bc0e.json
Convert Object internals to TS
packages/@ember/controller/type-tests/index.test.ts
@@ -23,7 +23,7 @@ expectTypeOf(controller.target).toEqualTypeOf<unknown | undefined>(); expectTypeOf(controller.model).toEqualTypeOf<Foo>(); -expectTypeOf(controller.concatenatedProperties).toEqualTypeOf<string[]>(); +expectTypeOf(controller.concatenatedProperties).toEqualTypeOf<string[] | string | undefined>(); ...
true
Other
emberjs
ember.js
ae6f8076c62a102caae6342a6910adb14590bc0e.json
Convert Object internals to TS
packages/@ember/object/type-tests/core/index.test.ts
@@ -10,18 +10,19 @@ expectTypeOf(CoreObject.create()).toEqualTypeOf<CoreObject>(); /** Newable tests */ const co1 = new CoreObject(owner); -expectTypeOf(co1.concatenatedProperties).toEqualTypeOf<string[]>(); +expectTypeOf(co1.concatenatedProperties).toEqualTypeOf<string[] | string | undefined>(); expectTypeOf(co1....
true
Other
emberjs
ember.js
a8d1dc6a7ba850c54b0c8e60503e50fed6c6ce02.json
tell eslint to ignore ts blueprint files
.eslintignore
@@ -1,4 +1,5 @@ blueprints/*/*files/**/*.js +blueprints/*/*files/**/*.ts node-tests/fixtures/**/*.js /docs/ dist/
false
Other
emberjs
ember.js
1ed27ae2527a1607264353c1aef1fb8d3295b32a.json
Add v4.3.0-beta.2 to CHANGELOG
CHANGELOG.md
@@ -1,5 +1,9 @@ # Ember Changelog +### v4.3.0-beta.2 (March 1, 2022) + +- [#19971](https://github.com/emberjs/ember.js/pull/19971) [BUGFIX] Don't serialize default Query Params on RouterService + ### v4.3.0-beta.1 (February 7, 2022) No public API changes or bugfixes.
false
Other
emberjs
ember.js
2485aba0d858a5a13a4a5718d01b3a49de45dbf7.json
Add types for runtime mixins
CHANGELOG.md
@@ -3144,7 +3144,7 @@ Clearly, `component-a` has subscribed to `some-other-component`'s `action`. Prev * CollectionView context is now its content * Various enhancements to bound helpers: adds multiple property support to bound helpers, adds bind-able options hash properties, adds {{unbound}} helper support to render...
true
Other
emberjs
ember.js
2485aba0d858a5a13a4a5718d01b3a49de45dbf7.json
Add types for runtime mixins
packages/@ember/-internals/container/lib/container.ts
@@ -308,15 +308,10 @@ function factoryFor( return manager; } -interface FactoryOptions { - instantiate?: boolean; - singleton?: boolean; -} - function isSingletonClass( container: Container, fullName: string, - { instantiate, singleton }: FactoryOptions + { instantiate, singleton }: TypeOptions ) { ...
true
Other
emberjs
ember.js
2485aba0d858a5a13a4a5718d01b3a49de45dbf7.json
Add types for runtime mixins
packages/@ember/-internals/container/lib/registry.ts
@@ -1,9 +1,9 @@ import { Factory } from '@ember/-internals/owner'; import { dictionary, intern } from '@ember/-internals/utils'; import { assert, deprecate } from '@ember/debug'; +import { set } from '@ember/object'; import { DEBUG } from '@glimmer/env'; import Container, { ContainerOptions, LazyInjection } from '...
true
Other
emberjs
ember.js
2485aba0d858a5a13a4a5718d01b3a49de45dbf7.json
Add types for runtime mixins
packages/@ember/-internals/metal/lib/property_get.ts
@@ -1,6 +1,7 @@ /** @module @ember/object */ +import ProxyMixin from '@ember/-internals/runtime/lib/mixins/-proxy'; import { isEmberArray, setProxy, symbol } from '@ember/-internals/utils'; import { assert } from '@ember/debug'; import { DEBUG } from '@glimmer/env'; @@ -159,7 +160,7 @@ _getProp({ unknownProperty(...
true
Other
emberjs
ember.js
2485aba0d858a5a13a4a5718d01b3a49de45dbf7.json
Add types for runtime mixins
packages/@ember/-internals/runtime/lib/mixins/-proxy.d.ts
@@ -0,0 +1,28 @@ +import { Mixin } from '@ember/-internals/metal'; + +export function contentFor<T>(proxy: ProxyMixin<T>): T | null; + +interface ProxyMixin<T = unknown> { + /** + The object whose properties will be forwarded. + + @property content + @type {unknown} + @default null + @public + */ + co...
true
Other
emberjs
ember.js
2485aba0d858a5a13a4a5718d01b3a49de45dbf7.json
Add types for runtime mixins
packages/@ember/-internals/runtime/lib/mixins/action_handler.d.ts
@@ -1,6 +1,9 @@ import { Mixin } from '@ember/-internals/metal'; -export default class ActionHandler extends Mixin { +interface ActionHandler { actions?: Record<string, (...args: any[]) => unknown>; send(actionName: string, ...args: unknown[]): void; } +declare const ActionHandler: Mixin; + +export default Ac...
true
Other
emberjs
ember.js
2485aba0d858a5a13a4a5718d01b3a49de45dbf7.json
Add types for runtime mixins
packages/@ember/-internals/runtime/lib/mixins/array.d.ts
@@ -1,8 +1,10 @@ import { Mixin } from '@ember/-internals/metal'; +import Enumerable from './enumerable'; +import MutableEnumerable from './mutable_enumerable'; type Value<T, K extends string> = K extends keyof T ? T[K] : unknown; -interface EmberArray<T> { +interface EmberArray<T> extends Enumerable { length:...
true
Other
emberjs
ember.js
2485aba0d858a5a13a4a5718d01b3a49de45dbf7.json
Add types for runtime mixins
packages/@ember/-internals/runtime/lib/mixins/array.js
@@ -1561,7 +1561,7 @@ const MutableArray = Mixin.create(ArrayMixin, MutableEnumerable, { ``` @method unshiftObjects - @param {Enumberable} objects the objects to add + @param {Enumerable} objects the objects to add @return {EmberArray} receiver @public */
true
Other
emberjs
ember.js
2485aba0d858a5a13a4a5718d01b3a49de45dbf7.json
Add types for runtime mixins
packages/@ember/-internals/runtime/lib/mixins/container_proxy.d.ts
@@ -3,14 +3,14 @@ import { TypeOptions } from '@ember/-internals/container/lib/registry'; import { Mixin } from '@ember/-internals/metal'; import { Factory } from '@ember/-internals/owner'; -interface ContainerProxy { +interface ContainerProxyMixin { /** @internal */ __container__: Container; ownerInject...
true
Other
emberjs
ember.js
2485aba0d858a5a13a4a5718d01b3a49de45dbf7.json
Add types for runtime mixins
packages/@ember/-internals/runtime/lib/mixins/enumerable.d.ts
@@ -0,0 +1,7 @@ +import { Mixin } from '@ember/-internals/metal'; + +// eslint-disable-next-line @typescript-eslint/no-empty-interface +interface Enumerable {} +declare const Enumerable: Mixin; + +export default Enumerable;
true
Other
emberjs
ember.js
2485aba0d858a5a13a4a5718d01b3a49de45dbf7.json
Add types for runtime mixins
packages/@ember/-internals/runtime/lib/mixins/mutable_enumerable.d.ts
@@ -0,0 +1,8 @@ +import { Mixin } from '@ember/-internals/metal'; +import Enumerable from './enumerable'; + +// eslint-disable-next-line @typescript-eslint/no-empty-interface +interface MutableEnumerable extends Enumerable {} +declare const MutableEnumerable: Mixin; + +export default MutableEnumerable;
true
Other
emberjs
ember.js
2485aba0d858a5a13a4a5718d01b3a49de45dbf7.json
Add types for runtime mixins
packages/@ember/-internals/runtime/lib/mixins/promise_proxy.d.ts
@@ -0,0 +1,24 @@ +import { Mixin } from '@ember/-internals/metal'; + +interface PromiseProxyMixin<T> { + reason: null; + + readonly isPending: boolean; + + readonly isSettled: boolean; + + isRejected: boolean; + + isFulfilled: boolean; + + promise: Promise<T>; + + then: this['promise']['then']; + + catch: this[...
true
Other
emberjs
ember.js
2485aba0d858a5a13a4a5718d01b3a49de45dbf7.json
Add types for runtime mixins
packages/@ember/-internals/runtime/lib/system/core_object.d.ts
@@ -86,6 +86,7 @@ export default class CoreObject { */ isDestroying: boolean; + // NOTE That the actual CoreObject#destroy returns `this`; /** * Destroys an object by setting the `isDestroyed` flag and removing its * metadata, which effectively destroys observers and bindings. @@ -95,7 +96,7 @@ exp...
true
Other
emberjs
ember.js
2485aba0d858a5a13a4a5718d01b3a49de45dbf7.json
Add types for runtime mixins
packages/@ember/-internals/runtime/lib/system/object_proxy.d.ts
@@ -0,0 +1,8 @@ +import FrameworkObject from './object'; +import _ProxyMixin from '../mixins/-proxy'; + +// eslint-disable-next-line @typescript-eslint/no-empty-interface +interface ObjectProxy extends _ProxyMixin {} +declare class ObjectProxy extends FrameworkObject {} + +export default ObjectProxy;
true
Other
emberjs
ember.js
2485aba0d858a5a13a4a5718d01b3a49de45dbf7.json
Add types for runtime mixins
packages/@ember/-internals/utils/lib/is_proxy.ts
@@ -1,16 +1,17 @@ +import ProxyMixin from '@ember/-internals/runtime/lib/mixins/-proxy'; import { _WeakSet as WeakSet } from '@glimmer/util'; import { isObject } from './spec'; const PROXIES = new WeakSet(); -export function isProxy(value: any | undefined | null): value is object { +export function isProxy(value...
true
Other
emberjs
ember.js
2485aba0d858a5a13a4a5718d01b3a49de45dbf7.json
Add types for runtime mixins
packages/@ember/object/type-tests/core/index.test.ts
@@ -13,15 +13,15 @@ const co1 = new CoreObject(owner); expectTypeOf(co1.concatenatedProperties).toEqualTypeOf<string[]>(); expectTypeOf(co1.isDestroyed).toEqualTypeOf<boolean>(); expectTypeOf(co1.isDestroying).toEqualTypeOf<boolean>(); -expectTypeOf(co1.destroy()).toEqualTypeOf<CoreObject>(); +expectTypeOf(co1.destr...
true
Other
emberjs
ember.js
cd40a6be39e99664c13293a87c900ccb68f38d1c.json
Convert @ember/-internals/overrides to TS
packages/@ember/-internals/overrides/index.js
@@ -1 +0,0 @@ -export let onEmberGlobalAccess;
true
Other
emberjs
ember.js
cd40a6be39e99664c13293a87c900ccb68f38d1c.json
Convert @ember/-internals/overrides to TS
packages/@ember/-internals/overrides/index.ts
@@ -0,0 +1 @@ +export let onEmberGlobalAccess: any;
true
Other
emberjs
ember.js
182a0345703e1456013b2206c414beaf7fb81caa.json
Avoid zebra classes for Component
packages/@ember/-internals/glimmer/lib/component.ts
@@ -1,6 +1,7 @@ import { get, PROPERTY_DID_CHANGE } from '@ember/-internals/metal'; -import { getOwner, Owner } from '@ember/-internals/owner'; +import { getOwner } from '@ember/-internals/owner'; import { TargetActionSupport } from '@ember/-internals/runtime'; +import { CoreObjectClass } from '@ember/-internals/runt...
true
Other
emberjs
ember.js
182a0345703e1456013b2206c414beaf7fb81caa.json
Avoid zebra classes for Component
packages/@ember/-internals/runtime/lib/mixins/action_handler.d.ts
@@ -1,3 +1,6 @@ import { Mixin } from '@ember/-internals/metal'; -export default class ActionHandler extends Mixin {} +export default class ActionHandler extends Mixin { + actions?: Record<string, (...args: unknown[]) => void>; + send(actionName: string, ...args: unknown[]): void; +}
true
Other
emberjs
ember.js
182a0345703e1456013b2206c414beaf7fb81caa.json
Avoid zebra classes for Component
packages/@ember/-internals/runtime/lib/system/core_object.d.ts
@@ -11,18 +11,39 @@ import { Owner } from '@ember/-internals/owner'; * Implementation is carefully chosen for the reasons described in * https://github.com/typed-ember/ember-typings/pull/29 */ -type EmberClassConstructor<T> = new (owner: Owner) => T; +export type EmberClassConstructor<T> = new (owner: Owner) => T...
true
Other
emberjs
ember.js
182a0345703e1456013b2206c414beaf7fb81caa.json
Avoid zebra classes for Component
packages/@ember/-internals/views/lib/views/core_view.d.ts
@@ -1,12 +0,0 @@ -import { Renderer } from '@ember/-internals/glimmer'; -import { ActionHandler } from '@ember/-internals/runtime'; -import EmberObject from '@ember/object'; -import Evented from '@ember/object/evented'; - -interface CoreView extends Evented, ActionHandler {} -declare class CoreView extends EmberObject ...
true
Other
emberjs
ember.js
182a0345703e1456013b2206c414beaf7fb81caa.json
Avoid zebra classes for Component
packages/@ember/-internals/views/lib/views/core_view.ts
@@ -1,5 +1,7 @@ +import { View } from '@ember/-internals/glimmer/lib/renderer'; import { inject } from '@ember/-internals/metal'; import { ActionHandler, Evented, FrameworkObject } from '@ember/-internals/runtime'; +import { CoreObjectClass } from '@ember/-internals/runtime/lib/system/core_object'; import states fro...
true
Other
emberjs
ember.js
182a0345703e1456013b2206c414beaf7fb81caa.json
Avoid zebra classes for Component
packages/@ember/component/type-tests/index.test.ts
@@ -1,51 +1,16 @@ import Component from '@ember/component'; import { CoreView } from '@ember/-internals/views'; import { expectTypeOf } from 'expect-type'; -import { Owner } from '@ember/-internals/owner'; import { View } from '@ember/-internals/glimmer/lib/renderer'; -import { action } from '@ember/object'; -impor...
true
Other
emberjs
ember.js
182a0345703e1456013b2206c414beaf7fb81caa.json
Avoid zebra classes for Component
packages/@ember/helper/type-tests/invoke-helper.test.ts
@@ -1,6 +1,5 @@ import Component from '@ember/-internals/glimmer/lib/component'; import { getValue } from '@ember/-internals/metal'; -import { Owner } from '@ember/-internals/owner'; import Helper from '@ember/component/helper'; import { invokeHelper } from '@ember/helper'; import { Cache } from '@glimmer/validato...
true
Other
emberjs
ember.js
2313c5c28fbb1cea4b8793c06cdc58b14ece3332.json
Add a feature flag for the unique-id helper
packages/@ember/-internals/glimmer/lib/resolver.ts
@@ -2,6 +2,7 @@ import { privatize as P } from '@ember/-internals/container'; import { TypeOptions } from '@ember/-internals/container/lib/registry'; import { ENV } from '@ember/-internals/environment'; import { Factory, Owner } from '@ember/-internals/owner'; +import { EMBER_UNIQUE_ID_HELPER } from '@ember/canary-f...
true
Other
emberjs
ember.js
2313c5c28fbb1cea4b8793c06cdc58b14ece3332.json
Add a feature flag for the unique-id helper
packages/@ember/-internals/glimmer/tests/integration/helpers/unique-id-test.js
@@ -1,144 +1,147 @@ import { RenderingTestCase, strip, moduleFor, runTask } from 'internal-test-helpers'; import { setProperties } from '@ember/-internals/metal'; - -moduleFor( - 'Helpers test: {{unique-id}}', - class extends RenderingTestCase { - ['@test it generates a unique id (string) each time']() { - ...
true
Other
emberjs
ember.js
2313c5c28fbb1cea4b8793c06cdc58b14ece3332.json
Add a feature flag for the unique-id helper
packages/@ember/canary-features/index.ts
@@ -16,6 +16,7 @@ export const DEFAULT_FEATURES = { EMBER_IMPROVED_INSTRUMENTATION: null, EMBER_ROUTING_ROUTER_SERVICE_REFRESH: true, EMBER_CACHED: true, + EMBER_UNIQUE_ID_HELPER: null, }; /** @@ -70,3 +71,4 @@ export const EMBER_ROUTING_ROUTER_SERVICE_REFRESH = featureValue( FEATURES.EMBER_ROUTING_ROU...
true
Other
emberjs
ember.js
aa8c53aa45aa7d2e7badfee1207d9dd4f4196fc2.json
Add type-tests for @ember/version
packages/@ember/version/type-tests/index.test.ts
@@ -0,0 +1,4 @@ +import { VERSION } from '@ember/version'; +import { expectTypeOf } from 'expect-type'; + +expectTypeOf(VERSION).toEqualTypeOf<string>();
false
Other
emberjs
ember.js
420a01fe1864a5e8d447ac714a3cfb9aff012a49.json
Improve @ember/utils and add type tests
packages/@ember/-internals/metal/lib/is_blank.ts
@@ -8,7 +8,6 @@ import isEmpty from './is_empty'; ```javascript import { isBlank } from '@ember/utils'; - isBlank(); // true isBlank(null); // true isBlank(undefined); // true isBlank(''); // true @@ -29,6 +28,6 @@ import isEmpty from './is_empty'; @sinc...
true
Other
emberjs
ember.js
420a01fe1864a5e8d447ac714a3cfb9aff012a49.json
Improve @ember/utils and add type tests
packages/@ember/-internals/metal/lib/is_empty.ts
@@ -1,4 +1,4 @@ -import { get } from './property_get'; +import { get, MaybeHasUnknownProperty } from './property_get'; /** @module @ember/utils */ @@ -13,7 +13,6 @@ import { get } from './property_get'; to check emptiness. ```javascript - isEmpty(); // true isEmpty(null); // ...
true
Other
emberjs
ember.js
420a01fe1864a5e8d447ac714a3cfb9aff012a49.json
Improve @ember/utils and add type tests
packages/@ember/-internals/metal/lib/is_none.ts
@@ -7,7 +7,6 @@ confusing. ```javascript - isNone(); // true isNone(null); // true isNone(undefined); // true isNone(''); // false
true
Other
emberjs
ember.js
420a01fe1864a5e8d447ac714a3cfb9aff012a49.json
Improve @ember/utils and add type tests
packages/@ember/-internals/metal/lib/is_present.ts
@@ -6,7 +6,6 @@ import isBlank from './is_blank'; A value is present if it not `isBlank`. ```javascript - isPresent(); // false isPresent(null); // false isPresent(undefined); // false isPresent(''); // false @@ -32,6 +31,6 @@ import isBlank from './is_blan...
true
Other
emberjs
ember.js
420a01fe1864a5e8d447ac714a3cfb9aff012a49.json
Improve @ember/utils and add type tests
packages/@ember/-internals/metal/lib/property_get.ts
@@ -23,7 +23,7 @@ if (DEBUG) { }; } -interface MaybeHasUnknownProperty { +export interface MaybeHasUnknownProperty { unknownProperty?: (keyName: string) => any; }
true