language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 420a01fe1864a5e8d447ac714a3cfb9aff012a49.json | Improve @ember/utils and add type tests | packages/@ember/-internals/runtime/lib/compare.ts | @@ -1,5 +1,6 @@
import { typeOf } from './type-of';
import Comparable from './mixins/comparable';
+import { assert } from '@ember/debug';
const TYPE_ORDER = {
undefined: 0,
@@ -15,6 +16,8 @@ const TYPE_ORDER = {
date: 10,
};
+type Compare = -1 | 0 | 1;
+
//
// the spaceship operator
//
@@ -32,9 +35,10 ... | true |
Other | emberjs | ember.js | 420a01fe1864a5e8d447ac714a3cfb9aff012a49.json | Improve @ember/utils and add type tests | packages/@ember/-internals/runtime/lib/copy.d.ts | @@ -1,3 +0,0 @@
-declare function copy<T>(obj: T, deep: true): T;
-declare function copy(obj: any, deep?: boolean): any;
-export default copy; | true |
Other | emberjs | ember.js | 420a01fe1864a5e8d447ac714a3cfb9aff012a49.json | Improve @ember/utils and add type tests | packages/@ember/-internals/runtime/lib/is-equal.ts | @@ -47,9 +47,9 @@
@return {Boolean}
@public
*/
-export default function isEqual(a, b) {
- if (a && typeof a.isEqual === 'function') {
- return a.isEqual(b);
+export default function isEqual(a: unknown, b: unknown): boolean {
+ if (a && typeof (a as IsEqual).isEqual === 'function') {
+ return (a as IsEqua... | true |
Other | emberjs | ember.js | 420a01fe1864a5e8d447ac714a3cfb9aff012a49.json | Improve @ember/utils and add type tests | packages/@ember/-internals/runtime/lib/mixins/action_handler.d.ts | @@ -1,3 +1,3 @@
-import Mixin from '../../types/mixin';
+import { Mixin } from '@ember/-internals/metal';
export default class ActionHandler extends Mixin {} | true |
Other | emberjs | ember.js | 420a01fe1864a5e8d447ac714a3cfb9aff012a49.json | Improve @ember/utils and add type tests | packages/@ember/-internals/runtime/lib/mixins/comparable.d.ts | @@ -0,0 +1,8 @@
+import { Mixin } from '@ember/-internals/metal';
+
+interface Comparable {
+ compare: ((a: unknown, b: unknown) => -1 | 0 | 1) | null;
+}
+declare const Comparable: Mixin;
+
+export default Comparable; | true |
Other | emberjs | ember.js | 420a01fe1864a5e8d447ac714a3cfb9aff012a49.json | Improve @ember/utils and add type tests | packages/@ember/-internals/runtime/lib/mixins/evented.d.ts | @@ -1,4 +1,4 @@
-import Mixin from '../../types/mixin';
+import { Mixin } from '@ember/-internals/metal';
/**
* This mixin allows for Ember objects to subscribe to and emit events. | true |
Other | emberjs | ember.js | 420a01fe1864a5e8d447ac714a3cfb9aff012a49.json | Improve @ember/utils and add type tests | packages/@ember/-internals/runtime/lib/type-of.ts | @@ -1,9 +1,25 @@
import CoreObject from './system/core_object';
+type TypeName =
+ | 'undefined'
+ | 'null'
+ | 'string'
+ | 'number'
+ | 'boolean'
+ | 'function'
+ | 'array'
+ | 'regexp'
+ | 'date'
+ | 'filelist'
+ | 'class'
+ | 'instance'
+ | 'error'
+ | 'object';
+
// ................................. | true |
Other | emberjs | ember.js | 420a01fe1864a5e8d447ac714a3cfb9aff012a49.json | Improve @ember/utils and add type tests | packages/@ember/-internals/runtime/types/mixin.d.ts | @@ -1,3 +0,0 @@
-import { Mixin } from '../../metal/lib/mixin';
-
-export default Mixin; | true |
Other | emberjs | ember.js | 420a01fe1864a5e8d447ac714a3cfb9aff012a49.json | Improve @ember/utils and add type tests | packages/@ember/utils/type-tests/compare.test.ts | @@ -0,0 +1,8 @@
+import { compare } from '@ember/utils';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(compare('hello', 'hello')).toEqualTypeOf<-1 | 0 | 1>(); // 0
+compare('abc', 'dfg'); // -1
+compare(2, 1); // 1
+compare('hello', 50); // 1
+compare(50, 'hello'); // -1 | true |
Other | emberjs | ember.js | 420a01fe1864a5e8d447ac714a3cfb9aff012a49.json | Improve @ember/utils and add type tests | packages/@ember/utils/type-tests/is-blank.test.ts | @@ -0,0 +1,17 @@
+import { isBlank } from '@ember/utils';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(isBlank(null)).toEqualTypeOf<boolean>(); // true
+
+isBlank(undefined); // true
+isBlank(''); // true
+isBlank([]); // true
+isBlank('\n\t'); // true
+isBlank(' '); // true
+isBlank({}); // false
+isB... | true |
Other | emberjs | ember.js | 420a01fe1864a5e8d447ac714a3cfb9aff012a49.json | Improve @ember/utils and add type tests | packages/@ember/utils/type-tests/is-empty.test.ts | @@ -0,0 +1,19 @@
+import { isEmpty } from '@ember/utils';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(isEmpty(null)).toEqualTypeOf<boolean>(); // true
+
+isEmpty(undefined); // true
+isEmpty(''); // true
+isEmpty([]); // true
+isEmpty({ size: 0 }); // true
+isEmpty({}); // false
+isEmpty('Adam Hawkins'... | true |
Other | emberjs | ember.js | 420a01fe1864a5e8d447ac714a3cfb9aff012a49.json | Improve @ember/utils and add type tests | packages/@ember/utils/type-tests/is-equal.test.ts | @@ -0,0 +1,21 @@
+import { isEqual } from '@ember/utils';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(isEqual('hello', 'hello')).toEqualTypeOf<boolean>(); // true
+
+isEqual(1, 2); // false
+
+class Person {
+ constructor(public ssn: string) {}
+
+ isEqual(other: Person) {
+ return this.ssn == oth... | true |
Other | emberjs | ember.js | 420a01fe1864a5e8d447ac714a3cfb9aff012a49.json | Improve @ember/utils and add type tests | packages/@ember/utils/type-tests/is-none.test.ts | @@ -0,0 +1,17 @@
+import { isNone } from '@ember/utils';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(isNone(null)).toEqualTypeOf<boolean>(); // true
+isNone(undefined); // true
+isNone(''); // false
+isNone([]); // false
+isNone(function () {}); // false
+
+// It functions as a type guard
+let foo: unk... | true |
Other | emberjs | ember.js | 420a01fe1864a5e8d447ac714a3cfb9aff012a49.json | Improve @ember/utils and add type tests | packages/@ember/utils/type-tests/is-present.test.ts | @@ -0,0 +1,28 @@
+import { isPresent } from '@ember/utils';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(isPresent(null)).toEqualTypeOf<boolean>(); // false
+
+isPresent(undefined); // false
+isPresent(''); // false
+isPresent(' '); // false
+isPresent('\n\t'); // false
+isPresent([]); // false
+isPres... | true |
Other | emberjs | ember.js | 420a01fe1864a5e8d447ac714a3cfb9aff012a49.json | Improve @ember/utils and add type tests | packages/@ember/utils/type-tests/type-of.test.ts | @@ -0,0 +1,44 @@
+/* eslint-disable no-new-wrappers */
+
+import { typeOf } from '@ember/utils';
+import { A } from '@ember/array';
+import EmberObject from '@ember/object';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(typeOf(null)).toEqualTypeOf<
+ | 'undefined'
+ | 'null'
+ | 'string'
+ | 'number'... | true |
Other | emberjs | ember.js | 3ea0f394fd644d579a4c0f04d97d6ce7d9dd0310.json | Add type tests for @ember/destroyable | packages/@ember/destroyable/type-tests/assert-destroyables-destroyed.test.ts | @@ -0,0 +1,6 @@
+import { assertDestroyablesDestroyed } from '@ember/destroyable';
+import { expectTypeOf } from 'expect-type';
+
+if (assertDestroyablesDestroyed) {
+ expectTypeOf(assertDestroyablesDestroyed()).toEqualTypeOf<void>();
+} | true |
Other | emberjs | ember.js | 3ea0f394fd644d579a4c0f04d97d6ce7d9dd0310.json | Add type tests for @ember/destroyable | packages/@ember/destroyable/type-tests/associate-destroyable-child.test.ts | @@ -0,0 +1,16 @@
+import { associateDestroyableChild } from '@ember/destroyable';
+import { expectTypeOf } from 'expect-type';
+
+class Foo {}
+class Bar {}
+
+let foo = new Foo();
+let bar = new Bar();
+
+expectTypeOf(associateDestroyableChild(foo, bar)).toEqualTypeOf<Bar>();
+// @ts-expect-error number is not destroy... | true |
Other | emberjs | ember.js | 3ea0f394fd644d579a4c0f04d97d6ce7d9dd0310.json | Add type tests for @ember/destroyable | packages/@ember/destroyable/type-tests/destroy.test.ts | @@ -0,0 +1,15 @@
+import { destroy, registerDestructor } from '@ember/destroyable';
+import { expectTypeOf } from 'expect-type';
+
+let obj = {};
+
+registerDestructor(obj, () => {
+ /* Will get called when destroyed */
+});
+
+expectTypeOf(destroy(obj)).toEqualTypeOf<void>();
+
+// @ts-expect-error not destroyable
+d... | true |
Other | emberjs | ember.js | 3ea0f394fd644d579a4c0f04d97d6ce7d9dd0310.json | Add type tests for @ember/destroyable | packages/@ember/destroyable/type-tests/enable-destroy-tracking.test.ts | @@ -0,0 +1,6 @@
+import { enableDestroyableTracking } from '@ember/destroyable';
+import { expectTypeOf } from 'expect-type';
+
+if (enableDestroyableTracking) {
+ expectTypeOf(enableDestroyableTracking()).toEqualTypeOf<void>();
+} | true |
Other | emberjs | ember.js | 3ea0f394fd644d579a4c0f04d97d6ce7d9dd0310.json | Add type tests for @ember/destroyable | packages/@ember/destroyable/type-tests/is-destroyed.test.ts | @@ -0,0 +1,16 @@
+import { destroy, isDestroyed } from '@ember/destroyable';
+import { expectTypeOf } from 'expect-type';
+
+let obj = {};
+
+expectTypeOf(isDestroyed(obj)).toEqualTypeOf<boolean>(); // false
+destroy(obj);
+
+// ...sometime later, after scheduled destruction
+
+expectTypeOf(isDestroyed(obj)).toEqualTyp... | true |
Other | emberjs | ember.js | 3ea0f394fd644d579a4c0f04d97d6ce7d9dd0310.json | Add type tests for @ember/destroyable | packages/@ember/destroyable/type-tests/is-destroying.test.ts | @@ -0,0 +1,19 @@
+import { destroy, isDestroying, isDestroyed } from '@ember/destroyable';
+import { expectTypeOf } from 'expect-type';
+
+let obj = {};
+
+expectTypeOf(isDestroying(obj)).toEqualTypeOf<boolean>(); // false
+
+destroy(obj);
+
+isDestroying(obj); // true
+
+// ...sometime later, after scheduled destructi... | true |
Other | emberjs | ember.js | 3ea0f394fd644d579a4c0f04d97d6ce7d9dd0310.json | Add type tests for @ember/destroyable | packages/@ember/destroyable/type-tests/register-destructor.test.ts | @@ -0,0 +1,27 @@
+import { destroy, registerDestructor } from '@ember/destroyable';
+import { expectTypeOf } from 'expect-type';
+
+class Foo {}
+let obj = new Foo();
+
+expectTypeOf(
+ registerDestructor(obj, () => {
+ /* Will get called when destroyed */
+ })
+).toEqualTypeOf<(destroyable: {}) => void>();
+
+reg... | true |
Other | emberjs | ember.js | 3ea0f394fd644d579a4c0f04d97d6ce7d9dd0310.json | Add type tests for @ember/destroyable | packages/@ember/destroyable/type-tests/unregister-destructor.test.ts | @@ -0,0 +1,30 @@
+import { registerDestructor, unregisterDestructor } from '@ember/destroyable';
+import { expectTypeOf } from 'expect-type';
+
+class Foo {
+ type: 'foo' = 'foo';
+}
+let obj = new Foo();
+
+let destructor = registerDestructor(obj, () => {
+ /* Will get called when destroyed */
+});
+
+expectTypeOf(u... | true |
Other | emberjs | ember.js | 96cc5d57439b60731ed5a191d52f61294eb64a4a.json | Add type tests for @ember/canary-features | packages/@ember/canary-features/type-tests/index.test.ts | @@ -0,0 +1,8 @@
+import { DEFAULT_FEATURES, FEATURES, isEnabled } from '@ember/canary-features';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(DEFAULT_FEATURES).toMatchTypeOf<Record<string, boolean | null>>();
+
+expectTypeOf(FEATURES).toMatchTypeOf<Record<string, boolean | null>>();
+
+expectTypeOf(isEn... | false |
Other | emberjs | ember.js | d1989091294eff20d3c7c618393dbc1e4d92de5a.json | Add type test for @ember/polyfills | packages/@ember/polyfills/type-tests/assign.test.ts | @@ -0,0 +1,14 @@
+import { assign } from '@ember/polyfills';
+import { expectTypeOf } from 'expect-type';
+
+// NOTE: Actual types could be better, but this is deprecated.
+
+let a = { first: 'Yehuda' };
+let b = { last: 'Katz' };
+let c = { company: 'Other Company' };
+let d = { company: 'Tilde Inc.' };
+expectTypeOf(... | false |
Other | emberjs | ember.js | d0371027994e0203c1072d0f258cc169830aa0b2.json | Improve BootOptions types and add more type-tests | packages/@ember/application/instance.d.ts | @@ -1,22 +1,13 @@
import EngineInstance from '@ember/engine/instance';
-export class BootOptions {
- isBrowser: boolean;
- shouldRender: boolean;
- document: Document | null;
- rootElement: string | Element | null;
- location: string | null;
-
- constructor(options?: {
- isBrowser?: boolean;
- shouldRend... | true |
Other | emberjs | ember.js | d0371027994e0203c1072d0f258cc169830aa0b2.json | Improve BootOptions types and add more type-tests | packages/@ember/application/instance.js | @@ -335,12 +335,12 @@ class BootOptions {
@default auto-detected
@private
*/
- this.isInteractive = environment.hasDOM; // This default is overridable below
+ this.isInteractive = Boolean(environment.hasDOM); // This default is overridable below
/**
@property _renderMode
@t... | true |
Other | emberjs | ember.js | d0371027994e0203c1072d0f258cc169830aa0b2.json | Improve BootOptions types and add more type-tests | packages/@ember/application/lib/application.d.ts | @@ -13,5 +13,5 @@ export default class Application extends Engine {
boot(): void;
ready(): void;
reset(): void;
- visit(url: string, options: BootOptions): Promise<ApplicationInstance>;
+ visit(url: string, options?: BootOptions): Promise<ApplicationInstance>;
} | true |
Other | emberjs | ember.js | d0371027994e0203c1072d0f258cc169830aa0b2.json | Improve BootOptions types and add more type-tests | packages/@ember/application/type-tests/index.test.ts | @@ -1,6 +1,6 @@
import { EventDispatcher } from '@ember/-internals/views';
import Application, { getOwner, setOwner } from '@ember/application';
-import ApplicationInstance, { BootOptions } from '@ember/application/instance';
+import ApplicationInstance from '@ember/application/instance';
import { Owner } from '@emb... | true |
Other | emberjs | ember.js | d0371027994e0203c1072d0f258cc169830aa0b2.json | Improve BootOptions types and add more type-tests | packages/@ember/application/type-tests/instance.test.ts | @@ -34,35 +34,25 @@ instance.hasRegistration();
expectTypeOf(instance.boot()).toEqualTypeOf<void>();
-const bootOptions = new BootOptions({
+const bootOptions: BootOptions = {
isBrowser: true,
shouldRender: false,
document: window.document,
rootElement: '#ember-application',
location: 'history',
-})... | true |
Other | emberjs | ember.js | d0371027994e0203c1072d0f258cc169830aa0b2.json | Improve BootOptions types and add more type-tests | packages/@ember/engine/type-tests/instance.test.ts | @@ -0,0 +1,38 @@
+import { Owner } from '@ember/-internals/owner';
+import EngineInstance from '@ember/engine/instance';
+import EmberObject from '@ember/object';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf<EngineInstance>().toMatchTypeOf<EmberObject>();
+expectTypeOf<EngineInstance>().toMatchTypeOf<Ow... | true |
Other | emberjs | ember.js | b97e01a685c316ab4bb80fd71ac0cefda8d1d1ea.json | Fix failing tests | packages/@ember/application/type-tests/index.test.ts | @@ -5,6 +5,8 @@ import { Owner } from '@ember/-internals/owner';
import { expectTypeOf } from 'expect-type';
+let owner = {} as Owner;
+
class App extends Application {
rootElement = '#ember-application';
customEvents = {
@@ -16,7 +18,7 @@ class App extends Application {
}
}
-const app = new App();
+c... | true |
Other | emberjs | ember.js | b97e01a685c316ab4bb80fd71ac0cefda8d1d1ea.json | Fix failing tests | packages/@ember/application/type-tests/instance.test.ts | @@ -1,11 +1,15 @@
+import { Owner } from '@ember/-internals/owner';
import Application from '@ember/application';
import ApplicationInstance, { BootOptions } from '@ember/application/instance';
import EngineInstance from '@ember/engine/instance';
import EmberObject from '@ember/object';
import { expectTypeOf } f... | true |
Other | emberjs | ember.js | b97e01a685c316ab4bb80fd71ac0cefda8d1d1ea.json | Fix failing tests | packages/@ember/engine/type-tests/index.test.ts | @@ -1,15 +1,18 @@
import { TypeOptions } from '@ember/-internals/container/lib/registry';
-import { Factory } from '@ember/-internals/owner';
+import { Factory, Owner } from '@ember/-internals/owner';
import Namespace from '@ember/application/namespace';
import Engine from '@ember/engine';
import EngineInstance fro... | true |
Other | emberjs | ember.js | d4c40f1d66cbdea276ec7db4f61a025619b12b79.json | Resolve unsafe owner methods | packages/@ember/-internals/container/lib/container.ts | @@ -1,4 +1,4 @@
-import { Factory, Owner, setOwner } from '@ember/-internals/owner';
+import { Factory, FactoryClass, Owner, setOwner } from '@ember/-internals/owner';
import { dictionary, symbol } from '@ember/-internals/utils';
import { assert } from '@ember/debug';
import { DEBUG } from '@glimmer/env';
@@ -143,7 ... | true |
Other | emberjs | ember.js | d4c40f1d66cbdea276ec7db4f61a025619b12b79.json | Resolve unsafe owner methods | packages/@ember/-internals/container/lib/registry.ts | @@ -182,7 +182,7 @@ export default class Registry implements IRegistry {
@param {Function} factory
@param {Object} options
*/
- register<T, C>(fullName: string, factory: Factory<T, C>, options: TypeOptions = {}): void {
+ register(fullName: string, factory: Factory<unknown>, options: TypeOptions = {}): vo... | true |
Other | emberjs | ember.js | d4c40f1d66cbdea276ec7db4f61a025619b12b79.json | Resolve unsafe owner methods | packages/@ember/-internals/glimmer/lib/component-managers/curly.ts | @@ -133,7 +133,7 @@ export default class CurlyComponentManager
if (layout === undefined) {
if (layoutName !== undefined) {
- let _factory = owner.lookup<TemplateFactory>(`template:${layoutName}`);
+ let _factory = owner.lookup(`template:${layoutName}`) as TemplateFactory;
assert(`La... | true |
Other | emberjs | ember.js | d4c40f1d66cbdea276ec7db4f61a025619b12b79.json | Resolve unsafe owner methods | packages/@ember/-internals/glimmer/lib/component.ts | @@ -710,8 +710,8 @@ const Component = CoreView.extend(
let owner = getOwner(this);
assert('Component is unexpectedly missing an owner', owner);
- if (owner.lookup<Environment>('-environment:main')!.isInteractive) {
- this.__dispatcher = owner.lookup<EventDispatcher>('event_dispatcher... | true |
Other | emberjs | ember.js | d4c40f1d66cbdea276ec7db4f61a025619b12b79.json | Resolve unsafe owner methods | packages/@ember/-internals/glimmer/lib/modifiers/action.ts | @@ -265,7 +265,7 @@ class ActionModifierManager implements InternalModifierManager<ActionState, obje
}
ensureEventSetup(actionState: ActionState): void {
- let dispatcher = actionState.owner.lookup<EventDispatcher>('event_dispatcher:main');
+ let dispatcher = actionState.owner.lookup('event_dispatcher:mai... | true |
Other | emberjs | ember.js | d4c40f1d66cbdea276ec7db4f61a025619b12b79.json | Resolve unsafe owner methods | packages/@ember/-internals/glimmer/lib/resolver.ts | @@ -1,7 +1,7 @@
import { privatize as P } from '@ember/-internals/container';
import { TypeOptions } from '@ember/-internals/container/lib/registry';
import { ENV } from '@ember/-internals/environment';
-import { Factory, FactoryClass, Owner } from '@ember/-internals/owner';
+import { Factory, Owner } from '@ember/-... | true |
Other | emberjs | ember.js | d4c40f1d66cbdea276ec7db4f61a025619b12b79.json | Resolve unsafe owner methods | packages/@ember/-internals/glimmer/tests/integration/application/debug-render-tree-test.ts | @@ -670,7 +670,7 @@ if (ENV._DEBUG_RENDER_TREE) {
]);
runTask(() => {
- let controller = instance!.lookup<Controller>('controller:application')!;
+ let controller = (instance!.lookup('controller:application') as Controller)!;
controller.set('message', 'World');
... | true |
Other | emberjs | ember.js | d4c40f1d66cbdea276ec7db4f61a025619b12b79.json | Resolve unsafe owner methods | packages/@ember/-internals/owner/index.ts | @@ -24,9 +24,9 @@ export interface EngineInstanceOptions {
import EngineInstance from '@ember/engine/instance';
import { TypeOptions } from '../container/lib/registry';
export interface Owner {
- lookup<T>(fullName: string, options?: TypeOptions): T | undefined;
- factoryFor<T, C>(fullName: string): Factory<T, C> ... | true |
Other | emberjs | ember.js | d4c40f1d66cbdea276ec7db4f61a025619b12b79.json | Resolve unsafe owner methods | packages/@ember/-internals/routing/lib/location/auto_location.ts | @@ -182,7 +182,7 @@ export default class AutoLocation extends EmberObject implements EmberLocation {
let owner = getOwner(this);
assert('AutoLocation is unexpectedly missing an owner', owner);
- let concrete = owner.lookup<EmberLocation>(`location:${implementation}`);
+ let concrete = owner.lookup(`lo... | true |
Other | emberjs | ember.js | d4c40f1d66cbdea276ec7db4f61a025619b12b79.json | Resolve unsafe owner methods | packages/@ember/-internals/routing/lib/system/generate_controller.ts | @@ -16,7 +16,7 @@ import { DEBUG } from '@glimmer/env';
*/
export function generateControllerFactory(owner: Owner, controllerName: string): Factory<{}> {
- let Factory = owner.factoryFor<any, any>('controller:basic')!.class;
+ let Factory = (owner.factoryFor('controller:basic') as Factory<any, any>).class;
F... | true |
Other | emberjs | ember.js | d4c40f1d66cbdea276ec7db4f61a025619b12b79.json | Resolve unsafe owner methods | packages/@ember/-internals/routing/lib/system/route.ts | @@ -278,8 +278,8 @@ class Route<T = unknown>
super(owner);
if (owner) {
- let router = owner.lookup<EmberRouter>('router:main');
- let bucketCache = owner.lookup<BucketCache>(P`-bucket-cache:main`);
+ let router = owner.lookup('router:main') as EmberRouter;
+ let bucketCache = owner.look... | true |
Other | emberjs | ember.js | d4c40f1d66cbdea276ec7db4f61a025619b12b79.json | Resolve unsafe owner methods | packages/@ember/-internals/routing/lib/system/router.ts | @@ -1,7 +1,7 @@
import { privatize as P } from '@ember/-internals/container';
import { OutletState as GlimmerOutletState, OutletView } from '@ember/-internals/glimmer';
import { computed, get, set } from '@ember/-internals/metal';
-import { FactoryClass, getOwner, Owner } from '@ember/-internals/owner';
+import { Fa... | true |
Other | emberjs | ember.js | d4c40f1d66cbdea276ec7db4f61a025619b12b79.json | Resolve unsafe owner methods | packages/@ember/-internals/views/lib/system/utils.ts | @@ -44,7 +44,7 @@ interface View {
@param {Object} owner
*/
export function getRootViews(owner: Owner): View[] {
- let registry = owner.lookup<Dict<View>>('-view-registry:main')!;
+ let registry = owner.lookup('-view-registry:main') as Dict<View>;
let rootViews: View[] = [];
@@ -120,7 +120,7 @@ const CHIL... | true |
Other | emberjs | ember.js | d4c40f1d66cbdea276ec7db4f61a025619b12b79.json | Resolve unsafe owner methods | packages/@ember/application/type-tests/instance.test.ts | @@ -19,10 +19,10 @@ expectTypeOf(
instance.register('service:store-singleton', Store, { singleton: true, instantiate: true })
).toEqualTypeOf<void>();
-expectTypeOf(instance.lookup<Store>('service:store')).toEqualTypeOf<Store | undefined>();
+expectTypeOf(instance.lookup('service:store')).toEqualTypeOf<unknown>()... | true |
Other | emberjs | ember.js | d4c40f1d66cbdea276ec7db4f61a025619b12b79.json | Resolve unsafe owner methods | packages/@ember/debug/lib/capture-render-tree.ts | @@ -20,7 +20,7 @@ import { expect } from '@glimmer/util';
@since 3.14.0
*/
export default function captureRenderTree(app: Owner): CapturedRenderNode[] {
- let renderer = expect(app.lookup<Renderer>('renderer:-dom'), `BUG: owner is missing renderer`);
+ let renderer = expect(app.lookup('renderer:-dom') as Rendere... | true |
Other | emberjs | ember.js | b1047ad3e7a4fb0f3c8a5203e8ec983f97c21f91.json | lint: Fix lint error | node-tests/blueprints/mixin-test.js | @@ -5,7 +5,6 @@ const setupTestHooks = blueprintHelpers.setupTestHooks;
const emberNew = blueprintHelpers.emberNew;
const emberGenerateDestroy = blueprintHelpers.emberGenerateDestroy;
const setupPodConfig = blueprintHelpers.setupPodConfig;
-const EOL = require('os').EOL;
const chai = require('ember-cli-blueprint-... | false |
Other | emberjs | ember.js | db7c537fb7b2e30d28287dce74856322bc45bbf0.json | Fix types for canInvoke | packages/@ember/-internals/utils/lib/invoke.ts | @@ -16,8 +16,8 @@
@return {Boolean}
@private
*/
-export function canInvoke(obj: any | null | undefined, methodName: string): obj is Function {
- return obj !== null && obj !== undefined && typeof obj[methodName] === 'function';
+export function canInvoke(obj: unknown, methodName: string): boolean {
+ return ob... | false |
Other | emberjs | ember.js | e1d249355bb29586d3ff69863c6ab5637b9d7017.json | Update router_js types | package.json | @@ -140,7 +140,7 @@
"rollup-plugin-commonjs": "^9.3.4",
"rollup-plugin-node-resolve": "^4.2.4",
"route-recognizer": "^0.3.4",
- "router_js": "^8.0.1",
+ "router_js": "^8.0.2",
"rsvp": "^4.8.5",
"serve-static": "^1.14.1",
"simple-dom": "^1.4.0", | true |
Other | emberjs | ember.js | e1d249355bb29586d3ff69863c6ab5637b9d7017.json | Update router_js types | packages/@ember/-internals/routing/lib/system/route.ts | @@ -29,7 +29,6 @@ import { DEBUG } from '@glimmer/env';
import { Template, TemplateFactory } from '@glimmer/interfaces';
import {
InternalRouteInfo,
- IModel,
ModelFor,
PARAMS_SYMBOL,
Route as IRoute,
@@ -87,7 +86,7 @@ const RENDER = (symbol('render') as unknown) as string;
@since 1.0.0
@public
*/... | true |
Other | emberjs | ember.js | e1d249355bb29586d3ff69863c6ab5637b9d7017.json | Update router_js types | yarn.lock | @@ -8612,10 +8612,10 @@ route-recognizer@^0.3.4:
resolved "https://registry.yarnpkg.com/route-recognizer/-/route-recognizer-0.3.4.tgz#39ab1ffbce1c59e6d2bdca416f0932611e4f3ca3"
integrity "sha1-Oasf+84cWebSvcpBbwkyYR5PPKM= sha512-2+MhsfPhvauN1O8KaXpXAOfR/fwe8dnUXVM+xw7yt40lJRfPVQxV6yryZm0cgRvAj5fMF/mdRZbL2ptwbs5i2g... | true |
Other | emberjs | ember.js | 2ef2be9950885f1c39248525e98b9db7c3854cf0.json | Remove code related to named outlets | packages/@ember/-internals/glimmer/lib/syntax/outlet.ts | @@ -6,7 +6,6 @@ import {
childRefFromParts,
createComputeRef,
createDebugAliasRef,
- createPrimitiveRef,
Reference,
valueForRef,
} from '@glimmer/reference';
@@ -38,32 +37,22 @@ import { OutletState } from '../utils/outlet';
Note: Your content __will not render__ if there isn't an `{{outlet}}` for i... | false |
Other | emberjs | ember.js | 1e56cc828415bd0bfcccb35f431daa12467129aa.json | Add v4.3.0-beta.1 to CHANGELOG
(cherry picked from commit 30d54b8e69d9bf5ad78e9b442c3946c47d8c78b2) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v4.3.0-beta.1 (February 7, 2022)
+
+No public API changes or bugfixes.
+
### v4.2.0 (February 7, 2022)
- [#19878](https://github.com/emberjs/ember.js/pull/19878) [BUGFIX] Allow class-based helpers to work in strict-mode. | false |
Other | emberjs | ember.js | ea486c5e693346373886dcd08496085268ad1e1d.json | Add 4.2.0 to CHANGELOG
(cherry picked from commit 693ce77994e0c826988ee0370831cd2dc3237d8b) | CHANGELOG.md | @@ -1,8 +1,8 @@
# Ember Changelog
-### v4.2.0-beta.1 (December 28, 2021)
+### v4.2.0 (February 7, 2022)
-- [#19878](https://github.com/emberjs/ember.js/pull/19772) [BUGFIX] Allow class-based helpers to work in strict-mode.
+- [#19878](https://github.com/emberjs/ember.js/pull/19878) [BUGFIX] Allow class-based helpe... | false |
Other | emberjs | ember.js | 4afbe9103a2a2fee6518ad80c91f8cf80122fc37.json | adjust failing assertions | packages/@ember/-internals/container/tests/container_test.js | @@ -608,7 +608,7 @@ moduleFor(
assert.throws(() => {
container.lookup('service:foo');
- }, /Can not call `.lookup` after the owner has been destroyed/);
+ }, /Cannot call `.lookup` after the owner has been destroyed/);
}
[`@test assert when calling factoryFor after destroy on a c... | false |
Other | emberjs | ember.js | 839eed2ab13d26cb349dc3c5e898c7c142acd65f.json | Fix typo in error messages
Cannot is one word | packages/@ember/-internals/container/lib/container.ts | @@ -145,7 +145,7 @@ export default class Container {
*/
lookup(fullName: string, options: LookupOptions): any {
if (this.isDestroyed) {
- throw new Error(`Can not call \`.lookup\` after the owner has been destroyed`);
+ throw new Error(`Cannot call \`.lookup\` after the owner has been destroyed`);... | false |
Other | emberjs | ember.js | 1320f55a753739584a64a521cc0483f8277e7f7e.json | Improve routing docs | packages/@ember/-internals/routing/lib/services/router.ts | @@ -79,8 +79,6 @@ class RouterService extends Service.extend(Evented) {
Transition the application into another route. The route may
be either a single route or route path:
- See [transitionTo](/ember/release/classes/Route/methods/transitionTo?anchor=transitionTo) for more info.
-
Calling `trans... | true |
Other | emberjs | ember.js | 1320f55a753739584a64a521cc0483f8277e7f7e.json | Improve routing docs | packages/@ember/-internals/routing/lib/system/router.ts | @@ -669,8 +669,6 @@ class EmberRouter extends EmberObject.extend(Evented) implements Evented {
Transition the application into another route. The route may
be either a single route or route path:
- See [transitionTo](/ember/release/classes/Route/methods/transitionTo?anchor=transitionTo) for more info.
-
... | true |
Other | emberjs | ember.js | 251d3eb21f07888b431dc1fb814eab7a6b55636c.json | Resolve some warnings in tests | packages/@ember/object/type-tests/computed.test.ts | @@ -22,7 +22,7 @@ class Foo {
declare badFullName: string;
// NOTE: This works, but is not recommended.
- @computed('firstName', 'lastName', function () {
+ @computed('firstName', 'lastName', function (this: Foo) {
return `${this.firstName} ${this.lastName}`;
})
declare altFullName: string; | true |
Other | emberjs | ember.js | 251d3eb21f07888b431dc1fb814eab7a6b55636c.json | Resolve some warnings in tests | packages/@ember/object/type-tests/define-property.test.ts | @@ -1,6 +1,6 @@
import { defineProperty } from '@ember/object';
-let contact = {};
+const contact = {};
// ES5 compatible mode
defineProperty(contact, 'firstName', { | true |
Other | emberjs | ember.js | 251d3eb21f07888b431dc1fb814eab7a6b55636c.json | Resolve some warnings in tests | packages/@ember/object/type-tests/ember-object.test.ts | @@ -57,7 +57,7 @@ expectTypeOf(p.toggleProperty('age')).toEqualTypeOf<boolean>();
expectTypeOf(p.cacheFor('age')).toEqualTypeOf<unknown>();
// get is not preferred for TS and only returns unknown
-let getPropertiesResult = p.getProperties('firstName', 'lastName', 'invalid');
+const getPropertiesResult = p.getProper... | true |
Other | emberjs | ember.js | 251d3eb21f07888b431dc1fb814eab7a6b55636c.json | Resolve some warnings in tests | packages/@ember/object/type-tests/evented/on.test.ts | @@ -9,7 +9,7 @@ class Job {
});
}
-let job = new Job();
+const job = new Job();
sendEvent(job, 'completed'); // Logs 'Job completed!'
| true |
Other | emberjs | ember.js | 251d3eb21f07888b431dc1fb814eab7a6b55636c.json | Resolve some warnings in tests | packages/@ember/object/type-tests/events/index.test.ts | @@ -26,9 +26,12 @@ class MyClass extends EmberObject {
super();
addListener(this, 'willDestroy', this, 'willDestroyListener');
addListener(this, 'willDestroy', this, 'willDestroyListener', true);
+
addListener(this, 'willDestroy', this, this.willDestroyListener);
+
addListener(this, 'willDestro... | true |
Other | emberjs | ember.js | 251d3eb21f07888b431dc1fb814eab7a6b55636c.json | Resolve some warnings in tests | packages/@ember/object/type-tests/get-properties.test.ts | @@ -2,7 +2,7 @@ import { getProperties } from '@ember/object';
import { expectTypeOf } from 'expect-type';
-let foo = { baz: 1 };
+const foo = { baz: 1 };
// We can't correctly infer CP types so just return unknown
expectTypeOf(getProperties(foo, 'baz', 'missing')).toEqualTypeOf<{ | true |
Other | emberjs | ember.js | 251d3eb21f07888b431dc1fb814eab7a6b55636c.json | Resolve some warnings in tests | packages/@ember/object/type-tests/get.test.ts | @@ -2,7 +2,7 @@ import { get } from '@ember/object';
import { expectTypeOf } from 'expect-type';
-let foo = { baz: 1 };
+const foo = { baz: 1 };
// We can infer basic types
expectTypeOf(get(foo, 'baz')).toEqualTypeOf<number>(); | true |
Other | emberjs | ember.js | 251d3eb21f07888b431dc1fb814eab7a6b55636c.json | Resolve some warnings in tests | packages/@ember/object/type-tests/mixin/index.test.ts | @@ -2,7 +2,7 @@ import { expectTypeOf } from 'expect-type';
import Mixin from '@ember/object/mixin';
-let newMixin = Mixin.create({
+const newMixin = Mixin.create({
foo: 'bar',
});
| true |
Other | emberjs | ember.js | 251d3eb21f07888b431dc1fb814eab7a6b55636c.json | Resolve some warnings in tests | packages/@ember/object/type-tests/observer.test.ts | @@ -2,8 +2,9 @@ import { observer } from '@ember/object';
import { expectTypeOf } from 'expect-type';
-let definition = {
+const definition = {
dependentKeys: ['value1', 'value2', 'value3'],
+
fn: () => {},
sync: true,
};
@@ -22,7 +23,7 @@ class Foo {
extraKeysObserver = observer('extraKey', definitio... | true |
Other | emberjs | ember.js | 251d3eb21f07888b431dc1fb814eab7a6b55636c.json | Resolve some warnings in tests | packages/@ember/object/type-tests/observers/index.test.ts | @@ -5,8 +5,10 @@ class MyComponent {
constructor() {
addObserver(this, 'foo', this, 'fooDidChange');
+
addObserver(this, 'foo', this, this.fooDidChange);
removeObserver(this, 'foo', this, 'fooDidChange');
+
removeObserver(this, 'foo', this, this.fooDidChange);
const lambda = () => {
... | true |
Other | emberjs | ember.js | 251d3eb21f07888b431dc1fb814eab7a6b55636c.json | Resolve some warnings in tests | packages/@ember/object/type-tests/set-properties.test.ts | @@ -2,7 +2,7 @@ import { setProperties } from '@ember/object';
import { expectTypeOf } from 'expect-type';
-let foo = { baz: 1 };
+const foo = { baz: 1 };
expectTypeOf(setProperties(foo, { baz: 2, missing: true })).toEqualTypeOf<{
baz: number; | true |
Other | emberjs | ember.js | 251d3eb21f07888b431dc1fb814eab7a6b55636c.json | Resolve some warnings in tests | packages/@ember/object/type-tests/set.test.ts | @@ -2,7 +2,7 @@ import { set } from '@ember/object';
import { expectTypeOf } from 'expect-type';
-let foo = { baz: 1 };
+const foo = { baz: 1 };
expectTypeOf(set(foo, 'baz', 2)).toEqualTypeOf<number>();
| true |
Other | emberjs | ember.js | 251d3eb21f07888b431dc1fb814eab7a6b55636c.json | Resolve some warnings in tests | packages/@ember/object/type-tests/try-set.test.ts | @@ -1,9 +1,9 @@
import { trySet } from '@ember/object';
import { expectTypeOf } from 'expect-type';
-let obj = { name: 'Zoey' };
+const obj = { name: 'Zoey' };
-let result = trySet(obj, 'contacts.twitter', '@emberjs');
+const result = trySet(obj, 'contacts.twitter', '@emberjs');
expectTypeOf(result).toEqualTypeO... | true |
Other | emberjs | ember.js | 95df93d670fd2efffc17087563862dc57d274095.json | Resolve warnings in @ember/object/computed.d.ts | packages/@ember/object/computed.d.ts | @@ -18,7 +18,7 @@ export function deprecatingAlias(
export function empty(dependentKey: string): PropertyDecorator;
-export function equal(dependentKey: string, value: any): PropertyDecorator;
+export function equal(dependentKey: string, value: unknown): PropertyDecorator;
export function filter(
dependentKe... | false |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/browser-environment/lib/has-dom.ts | @@ -1,7 +1,7 @@
// check if window exists and actually is the global
export default typeof self === 'object' &&
self !== null &&
- (self as Window['self']).Object === Object &&
+ self.Object === Object &&
typeof Window !== 'undefined' &&
self.constructor === Window &&
typeof document === 'object' && | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/glimmer/lib/component-managers/curly.ts | @@ -434,7 +434,7 @@ export default class CurlyComponentManager
if (args !== null && !validateTag(argsTag, argsRevision)) {
beginTrackFrame();
- let props = processComponentArgs(args!);
+ let props = processComponentArgs(args);
argsTag = bucket.argsTag = endTrackFrame();
bucket.ar... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/glimmer/lib/component-managers/mount.ts | @@ -154,7 +154,7 @@ class MountManager
let { controller, modelRef } = bucket;
if (modelRef !== undefined) {
- controller.set('model', valueForRef(modelRef!));
+ controller.set('model', valueForRef(modelRef));
}
}
} | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/glimmer/lib/component.ts | @@ -787,7 +787,7 @@ const Component = CoreView.extend(
_element !== null
);
- let element = _element!;
+ let element = _element;
let isSVG = element.namespaceURI === Namespace.SVG;
let { type, normalized } = normalizeProperty(element, name);
| true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/glimmer/lib/helpers/action.ts | @@ -410,7 +410,7 @@ function makeClosureAction(
if (typeofAction === 'string') {
self = target;
- fn = target.actions! && target.actions![action as string];
+ fn = (target.actions && target.actions[action as string])!;
assert(`An action named '${action}' was not found in ${target}`, Boolean(fn));... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/glimmer/lib/resolver.ts | @@ -252,7 +252,7 @@ export default class ResolverImpl implements RuntimeResolver<Owner>, CompileTime
let key: object;
if (pair.component === null) {
- key = template = pair.layout!(owner);
+ key = template = pair.layout(owner);
} else {
key = pair.component;
} | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/glimmer/lib/syntax/mount.ts | @@ -87,7 +87,7 @@ export const mountHelper = internalHelper(
assert(
`You used \`{{mount '${name}'}}\`, but the engine '${name}' can not be found.`,
- (owner as Owner).hasRegistration(`engine:${name}`)
+ owner.hasRegistration(`engine:${name}`)
);
lastName = na... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/glimmer/lib/utils/bindings.ts | @@ -116,7 +116,7 @@ export function createSimpleClassNameBindingRef(inner: Reference, path?: string)
path !== undefined
);
- return dasherizedPath || (dasherizedPath = dasherize(path!));
+ return dasherizedPath || (dasherizedPath = dasherize(path));
} else if (value || value === 0) {
... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/glimmer/lib/utils/to-bool.ts | @@ -6,7 +6,7 @@ import { consumeTag } from '@glimmer/validator';
export default function toBool(predicate: unknown): boolean {
if (isProxy(predicate)) {
- consumeTag(tagForProperty(predicate as object, 'content'));
+ consumeTag(tagForProperty(predicate, 'content'));
return Boolean(get(predicate, 'isT... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/glimmer/tests/integration/application/debug-render-tree-test.ts | @@ -28,7 +28,7 @@ interface CapturedBounds {
}
function compileTemplate(templateSource: string, options: Partial<EmberPrecompileOptions>) {
- return compile(templateSource, options) as any;
+ return compile(templateSource, options);
}
type Expected<T> = T | ((actual: T) => boolean); | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/meta/lib/meta.ts | @@ -383,7 +383,7 @@ export class Meta {
): void {
let listeners = this.writableListeners();
- let i = indexOfListener(listeners, event, target, method!);
+ let i = indexOfListener(listeners, event, target, method);
// remove if found listener was inherited
if (i !== -1 && i < this._inherited... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/metal/lib/computed.ts | @@ -344,7 +344,7 @@ export class ComputedProperty extends ComputedDescriptor {
(typeof propertyDesc.get === 'function' || typeof propertyDesc.set === 'function')
);
- let { get, set } = propertyDesc!;
+ let { get, set } = propertyDesc;
if (get !== undefined) {
this._gette... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/metal/lib/events.ts | @@ -133,7 +133,7 @@ export function sendEvent(
for (let i = actions.length - 3; i >= 0; i -= 3) {
// looping in reverse for once listeners
- let target = actions[i] as any | null;
+ let target = actions[i];
let method = actions[i + 1] as string | Function;
let once = actions[i + 2] as boolean;... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/metal/lib/mixin.ts | @@ -814,9 +814,9 @@ export function observer<T extends (...args: any[]) => any>(
dependentKeys = args as string[];
sync = !ENV._DEFAULT_ASYNC_OBSERVERS;
} else {
- func = (funcOrDef as ObserverDefinition<T>).fn;
- dependentKeys = (funcOrDef as ObserverDefinition<T>).dependentKeys;
- sync = (funcOr... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/metal/lib/namespace_search.ts | @@ -153,7 +153,7 @@ function tryIsNamespace(lookup: { [k: string]: any }, prop: string): Namespace |
let obj = lookup[prop];
return (
((obj !== null && typeof obj === 'object') || typeof obj === 'function') &&
- (obj as any).isNamespace &&
+ obj.isNamespace &&
obj
);
} catch (e... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/metal/lib/properties.ts | @@ -72,7 +72,7 @@ export function defineProperty(
}
if (isClassicDecorator(desc)) {
- defineDecorator(obj, keyName, desc!, meta);
+ defineDecorator(obj, keyName, desc, meta);
} else if (desc === null || desc === undefined) {
defineValue(obj, keyName, data, wasDescriptor, true);
} else {
@@ -91,... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/routing/lib/services/router.ts | @@ -1,4 +1,4 @@
-import { getOwner, Owner } from '@ember/-internals/owner';
+import { getOwner } from '@ember/-internals/owner';
import { Evented } from '@ember/-internals/runtime';
import { symbol } from '@ember/-internals/utils';
import { EMBER_ROUTING_ROUTER_SERVICE_REFRESH } from '@ember/canary-features';
@@ -58... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/routing/lib/services/routing.ts | @@ -2,7 +2,7 @@
@module ember
*/
-import { getOwner, Owner } from '@ember/-internals/owner';
+import { getOwner } from '@ember/-internals/owner';
import { symbol } from '@ember/-internals/utils';
import { readOnly } from '@ember/object/computed';
import Service from '@ember/service';
@@ -27,7 +27,7 @@ export def... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/routing/lib/system/dsl.ts | @@ -77,7 +77,7 @@ export default class DSLImpl implements DSL {
} else if (isCallback(_callback)) {
assert('Unexpected arguments', arguments.length === 3);
assert('Unexpected arguments', isOptions(_options));
- options = _options as RouteOptions;
+ options = _options;
callback = _cal... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/routing/lib/system/generate_controller.ts | @@ -16,7 +16,7 @@ import { DEBUG } from '@glimmer/env';
*/
export function generateControllerFactory(owner: Owner, controllerName: string): Factory<{}> {
- let Factory = owner.factoryFor<any, any>('controller:basic')!.class!;
+ let Factory = owner.factoryFor<any, any>('controller:basic')!.class;
Factory = Fa... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/routing/lib/system/route.ts | @@ -456,7 +456,7 @@ class Route extends EmberObject.extend(ActionHandler, Evented) implements IRoute
let state = transition ? transition[STATE_SYMBOL] : this._router._routerMicrolib.state;
let fullName = route.fullRouteName;
- let params = Object.assign({}, state!.params[fullName!]);
+ let params = Ob... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/routing/lib/system/router.ts | @@ -596,7 +596,7 @@ class EmberRouter extends EmberObject.extend(Evented) implements Evented {
for (let i = 0; i < routeInfos.length; i++) {
let route = routeInfos[i].route!;
- let connections = ROUTE_CONNECTIONS.get(route!);
+ let connections = ROUTE_CONNECTIONS.get(route);
let ownState:... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/utils/lib/mandatory-setter.ts | @@ -32,7 +32,6 @@ if (DEBUG) {
let MANDATORY_SETTERS: WeakMap<
object,
- // @ts-ignore
{ [key: string | symbol]: PropertyDescriptorWithMeta }
> = new WeakMap();
@@ -45,7 +44,7 @@ if (DEBUG) {
return;
}
- SEEN_TAGS!.add(tag);
+ SEEN_TAGS.add(tag);
if (Array.isArray(obj) ... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/-internals/views/lib/system/utils.ts | @@ -229,7 +229,7 @@ export const elMatches: typeof Element.prototype.matches | undefined =
export function matches(el: Element, selector: string): boolean {
assert('cannot call `matches` in fastboot mode', elMatches !== undefined);
- return elMatches!.call(el, selector);
+ return elMatches.call(el, selector);
... | true |
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/@ember/object/compat.ts | @@ -153,7 +153,7 @@ export function dependentKeyCompat(
(typeof desc.get === 'function' || typeof desc.set === 'function')
);
- return wrapGetterSetter(target, key, desc!);
+ return wrapGetterSetter(target, key, desc);
};
setClassicDecorator(decorator); | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.