language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | e996eacc3c684814b534fce469f37b4579846b62.json | Finalize CHANGELOG for 1.8.0. | CHANGELOG.md | @@ -4,8 +4,29 @@
* [BREAKING] Require Handlebars 2.0. See [blog post](http://emberjs.com/blog/2014/10/16/handlebars-update.html) for details.
-### Ember 1.8.0-beta.3 (September, 27, 2014)
-
+### Ember 1.8.0 (October, 28, 2014)
+
+* [BUGFIX] Ensure published builds do not use `define` or `require` internally.
+* [B... | false |
Other | emberjs | ember.js | 1647fdd3ccdce1502ab7e9041c77b2136beba32e.json | Ensure consistent use of Ember.create. | packages/ember-application/lib/system/application.js | @@ -794,7 +794,7 @@ var Application = Namespace.extend(DeferredMixin, {
});
Application.reopenClass({
- initializers: Object.create(null),
+ initializers: create(null),
/**
Initializer receives an object which has the following attributes: | true |
Other | emberjs | ember.js | 1647fdd3ccdce1502ab7e9041c77b2136beba32e.json | Ensure consistent use of Ember.create. | packages/ember-metal-views/tests/test_helpers.js | @@ -1,3 +1,4 @@
+import { create } from "ember-metal/platform";
import { Renderer } from "ember-metal-views";
var renderer;
@@ -6,7 +7,7 @@ function MetalRenderer () {
MetalRenderer._super.call(this);
}
MetalRenderer._super = Renderer;
-MetalRenderer.prototype = Object.create(Renderer.prototype, {
+MetalRende... | true |
Other | emberjs | ember.js | 1647fdd3ccdce1502ab7e9041c77b2136beba32e.json | Ensure consistent use of Ember.create. | packages/ember-metal/lib/dictionary.js | @@ -1,10 +1,12 @@
+import { create } from "ember-metal/platform";
+
// the delete is meant to hint at runtimes that this object should remain in
// dictionary mode. This is clearly a runtime specific hack, but currently it
// appears worthwile in some usecases. Please note, these deletes do increase
// the cost of ... | true |
Other | emberjs | ember.js | 1647fdd3ccdce1502ab7e9041c77b2136beba32e.json | Ensure consistent use of Ember.create. | packages/ember-metal/lib/map.js | @@ -34,7 +34,7 @@ function missingNew(name) {
}
function copyNull(obj) {
- var output = Object.create(null);
+ var output = create(null);
for (var prop in obj) {
// hasOwnPropery is not needed because obj is Object.create(null);
@@ -92,7 +92,7 @@ OrderedSet.prototype = {
@method clear
*/
clea... | true |
Other | emberjs | ember.js | 1647fdd3ccdce1502ab7e9041c77b2136beba32e.json | Ensure consistent use of Ember.create. | packages/ember-metal/lib/mixin.js | @@ -333,7 +333,7 @@ function connectStreamBinding(obj, key, stream) {
stream.subscribe(onNotify);
if (obj._streamBindingSubscriptions === undefined) {
- obj._streamBindingSubscriptions = Object.create(null);
+ obj._streamBindingSubscriptions = o_create(null);
}
obj._streamBindingSubscriptions[key]... | true |
Other | emberjs | ember.js | 1647fdd3ccdce1502ab7e9041c77b2136beba32e.json | Ensure consistent use of Ember.create. | packages/ember-metal/lib/streams/stream.js | @@ -1,3 +1,4 @@
+import { create } from "ember-metal/platform";
import {
getFirstKey,
getTailPath
@@ -23,7 +24,7 @@ Stream.prototype = {
var tailPath = getTailPath(path);
if (this.children === undefined) {
- this.children = Object.create(null);
+ this.children = create(null);
}
... | true |
Other | emberjs | ember.js | 1647fdd3ccdce1502ab7e9041c77b2136beba32e.json | Ensure consistent use of Ember.create. | packages/ember-routing/lib/system/router.js | @@ -19,6 +19,7 @@ import {
getActiveTargetName,
stashParamNames
} from "ember-routing/utils";
+import { create } from "ember-metal/platform";
/**
@module ember
@@ -319,7 +320,7 @@ var EmberRouter = EmberObject.extend(Evented, {
},
_getHandlerFunction: function() {
- var seen = Object.create(null);... | true |
Other | emberjs | ember.js | 1647fdd3ccdce1502ab7e9041c77b2136beba32e.json | Ensure consistent use of Ember.create. | packages/ember-runtime/tests/core/copy_test.js | @@ -1,3 +1,4 @@
+import { create } from "ember-metal/platform";
import copy from "ember-runtime/copy";
QUnit.module("Ember Copy Method");
@@ -16,7 +17,7 @@ test("Ember.copy date", function() {
});
test("Ember.copy null prototype object", function() {
- var obj = Object.create(null);
+ var obj = create(null);
... | true |
Other | emberjs | ember.js | 1647fdd3ccdce1502ab7e9041c77b2136beba32e.json | Ensure consistent use of Ember.create. | packages/ember-views/lib/system/render_buffer.js | @@ -6,6 +6,7 @@
import jQuery from "ember-views/system/jquery";
import { DOMHelper } from "morph";
import Ember from "ember-metal/core";
+import { create } from "ember-metal/platform";
// The HTML spec allows for "omitted start tags". These tags are optional
// when their intended child is the first thing in the... | true |
Other | emberjs | ember.js | 1647fdd3ccdce1502ab7e9041c77b2136beba32e.json | Ensure consistent use of Ember.create. | packages/ember-views/lib/views/view.js | @@ -3,6 +3,7 @@
// Ember.ContainerView circular dependency
// Ember.ENV
import Ember from 'ember-metal/core';
+import { create } from 'ember-metal/platform';
import Evented from "ember-runtime/mixins/evented";
import EmberObject from "ember-runtime/system/object";
@@ -1709,7 +1710,7 @@ var View = CoreView.extend... | true |
Other | emberjs | ember.js | cfe3dbf4bdbfb62d0256f3cb55efefe2ed19aa37.json | Remove DAG implementation.
As of https://github.com/emberjs/ember.js/pull/5677 the DAG is pulled in
from Bower, this file is no longer needed. | packages/ember-application/lib/system/dag.js | @@ -1,181 +0,0 @@
-import EmberError from "ember-metal/error";
-
-function visit(vertex, fn, visited, path) {
- var name = vertex.name;
- var vertices = vertex.incoming;
- var names = vertex.incomingNames;
- var len = names.length;
- var i;
-
- if (!visited) {
- visited = {};
- }
- if (!path) {
- path = [... | false |
Other | emberjs | ember.js | 1388cc09b4130ac4266de2e58ef3918b524b4d4b.json | Remove code-climate complains | Brocfile.js | @@ -2,7 +2,6 @@
var fs = require('fs');
var util = require('util');
-var path = require('path');
var pickFiles = require('broccoli-static-compiler');
var transpileES6 = require('broccoli-es6-module-transpiler');
var mergeTrees = require('broccoli-merge-trees');
@@ -52,9 +51,9 @@ var inlineTemplatePrecompiler = ... | false |
Other | emberjs | ember.js | fc68c8487b8b2068a0cb9634a3f20ee06e391049.json | Allow more configurability in production builds.
```
DISABLE_ES3=true DISABLE_JSHINT=true DISABLE_MIN=true ember serve --environment=production
```
Takes initial production build time from 70s to 21s, and rebuilds from
6s to 2s. | Brocfile.js | @@ -18,8 +18,15 @@ var es3recast = require('broccoli-es3-safe-recast');
var getVersion = require('git-repo-version');
+// To create fast production builds (without ES3 support, minification, or JSHint)
+// run the following:
+//
+// DISABLE_ES3=true DISABLE_JSHINT=true DISABLE_MIN=true ember serve --environment=pr... | false |
Other | emberjs | ember.js | 38c7307cc70fedb9c8554b140f7c187548f140a2.json | Add a test for a bug fixed on beta | packages/ember-handlebars/tests/helpers/bound_helper_test.js | @@ -44,6 +44,18 @@ QUnit.module("Handlebars bound helpers", {
}
});
+test("primitives should work correctly", function() {
+ view = EmberView.create({
+ prims: Ember.A(["string", 12]),
+
+ template: compile('{{#each view.prims}}{{#if this}}inside-if{{/if}}{{#with this}}inside-with{{/with}}{{/each}}')
+ })... | false |
Other | emberjs | ember.js | 4d5c7c2d8f6fb06ca7dff09e674c9ce1db858344.json | Remove mocha since is not used anymore | .travis.yml | @@ -16,7 +16,6 @@ after_success:
- "./bin/bower_ember_build"
script:
- npm test
- - npm run-script test-node
env:
global: | true |
Other | emberjs | ember.js | 4d5c7c2d8f6fb06ca7dff09e674c9ce1db858344.json | Remove mocha since is not used anymore | package.json | @@ -8,7 +8,6 @@
"pretest": "ember build --environment production",
"test": "bin/run-tests.js",
"start": "ember serve",
- "test-node": "mocha tests/**/*test.js",
"docs": "ember yuidoc"
},
"devDependencies": {
@@ -41,7 +40,6 @@
"express": "^4.5.0",
"glob": "~3.2.8",
"handlebars... | true |
Other | emberjs | ember.js | 09cd3335c85c9b1dd5d20f996d5771f541c55ca3.json | Change variable naming | packages/ember-metal/lib/set_properties.js | @@ -18,20 +18,20 @@ import keys from "ember-metal/keys";
```
@method setProperties
- @param self
- @param {Object} hash
- @return self
+ @param obj
+ @param {Object} properties
+ @return obj
*/
-export default function setProperties(self, hash) {
+export default function setProperties(obj, properties) {
... | false |
Other | emberjs | ember.js | 80bbf7b27ca105b4d487fce50f93c41833b6e6ee.json | Log unhandled promise rejections in testing #9376 | packages/ember-runtime/lib/ext/rsvp.js | @@ -51,6 +51,7 @@ RSVP.onerrorDefault = function (error) {
if (Test && Test.adapter) {
Test.adapter.exception(error);
+ Logger.error(error.stack);
} else {
throw error;
} | false |
Other | emberjs | ember.js | 19024da35c4eac10f25685b02cfe4d68ca515e2c.json | Add component invocation from Handlebars tests. | packages/ember-handlebars/tests/views/component_test.js | @@ -0,0 +1,88 @@
+import EmberView from "ember-views/views/view";
+import Container from 'container/container';
+import run from "ember-metal/run_loop";
+import jQuery from "ember-views/system/jquery";
+import EmberHandlebars from 'ember-handlebars-compiler';
+import ComponentLookup from 'ember-handlebars/component_loo... | false |
Other | emberjs | ember.js | e63c8186517341ecd29fbdebc41cd8b174a6a410.json | Fix Handlebars dependency. | Gemfile.lock | @@ -27,8 +27,8 @@ GIT
PATH
remote: .
specs:
- ember-source (1.9.0.alpha)
- handlebars-source (~> 1.0)
+ ember-source (1.9.0.alpha.2)
+ handlebars-source (~> 2.0)
GEM
remote: https://rubygems.org/
@@ -45,7 +45,7 @@ GEM
diff-lcs (~> 1.1)
mime-types (~> 1.15)
posix-spawn (... | true |
Other | emberjs | ember.js | e63c8186517341ecd29fbdebc41cd8b174a6a410.json | Fix Handlebars dependency. | VERSION | @@ -1 +1 @@
-1.9.0-alpha
+1.9.0-alpha.2 | true |
Other | emberjs | ember.js | e63c8186517341ecd29fbdebc41cd8b174a6a410.json | Fix Handlebars dependency. | ember-source.gemspec | @@ -13,7 +13,7 @@ Gem::Specification.new do |gem|
gem.version = Ember.rubygems_version_string
- gem.add_dependency "handlebars-source", ["~> 1.0"]
+ gem.add_dependency "handlebars-source", ["~> 2.0"]
gem.files = %w(VERSION) + Dir['dist/*.js', 'lib/ember/*.rb']
end | true |
Other | emberjs | ember.js | e63c8186517341ecd29fbdebc41cd8b174a6a410.json | Fix Handlebars dependency. | package.json | @@ -1,7 +1,7 @@
{
"name": "ember",
"license": "MIT",
- "version": "1.9.0-alpha",
+ "version": "1.9.0-alpha.2",
"scripts": {
"build": "ember build --environment production",
"postinstall": "bower install", | true |
Other | emberjs | ember.js | 171b1f390d0150893d39ecc3f64742b284daffe0.json | Add CHANGELOG entry. | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### Master
+
+* [BREAKING] Require Handlebars 2.0. See [blog post](http://emberjs.com/blog/2014/10/16/handlebars-update.html) for details.
+
### Ember 1.8.0-beta.3 (September, 27, 2014)
* [BUGFIX] Use contextualElements to properly handle omitted optional start tags. | false |
Other | emberjs | ember.js | 44a9cdaeb3a3b28cdb95b1c6c65f9051ea62db85.json | Add some tests for bind | packages/ember-handlebars/tests/helpers/bind_test.js | @@ -0,0 +1,55 @@
+import EmberView from "ember-views/views/view";
+import EmberObject from "ember-runtime/system/object";
+import run from "ember-metal/run_loop";
+
+function appendView(view) {
+ run(function() { view.appendTo('#qunit-fixture'); });
+}
+
+var view;
+
+QUnit.module("Handlebars {{#bind}} helper", {
+ t... | false |
Other | emberjs | ember.js | 21c34de2418dd94afebea05c8e2d92ea93fbed23.json | Fix some.path dependent keys on bound helpers | packages/ember-handlebars/lib/ext.js | @@ -18,7 +18,6 @@ import {
var resolveHelper, SimpleHandlebarsView;
import Stream from "ember-metal/streams/stream";
-import KeyStream from "ember-views/streams/key_stream";
import {
readArray,
readHash
@@ -419,15 +418,19 @@ function makeBoundHelper(fn) {
}
if (numParams > 0) {
- var o... | true |
Other | emberjs | ember.js | 21c34de2418dd94afebea05c8e2d92ea93fbed23.json | Fix some.path dependent keys on bound helpers | packages/ember-handlebars/tests/helpers/bound_helper_test.js | @@ -295,28 +295,38 @@ test("bound helpers should not be invoked with blocks", function() {
test("should observe dependent keys passed to registerBoundHelper", function() {
try {
- expect(2);
+ expect(3);
- var SimplyObject = EmberObject.create({
+ var simplyObject = EmberObject.create({
first... | true |
Other | emberjs | ember.js | e87d19507a4189257c16fc211341ca54d4401fbe.json | Remove custom template override
The isTop flag will be added to Handlebars itself so this override may be removed. | packages/ember-handlebars/lib/ext.js | @@ -25,7 +25,6 @@ import {
} from "ember-metal/streams/read";
var slice = [].slice;
-var originalTemplate = EmberHandlebars.template;
/**
Lookup both on root and on window. If the path starts with
@@ -436,21 +435,6 @@ function makeBoundHelper(fn) {
return helper;
}
-/**
- Overrides Handlebars.template ... | true |
Other | emberjs | ember.js | e87d19507a4189257c16fc211341ca54d4401fbe.json | Remove custom template override
The isTop flag will be added to Handlebars itself so this override may be removed. | packages/ember-handlebars/lib/main.js | @@ -5,7 +5,6 @@ import { runLoadHooks } from "ember-runtime/system/lazy_load";
import bootstrap from "ember-handlebars/loader";
import {
- template,
makeBoundHelper,
registerBoundHelper,
helperMissingHelper,
@@ -87,7 +86,6 @@ Ember Handlebars
// Ember.Handlebars.Globals
EmberHandlebars.bootstrap = boo... | true |
Other | emberjs | ember.js | b6c816ed9ca8fe9df5d83d344f1be7d0cf3eab28.json | Update precompiler for new format | lib/broccoli-ember-inline-template-precompiler.js | @@ -38,7 +38,7 @@ EmberInlineTemplatePrecompiler.prototype.processFile = function (srcDir, destDir
while (nextIndex > -1) {
var match = inputString.match(self.inlineTemplateRegExp);
- var template = "Ember.Handlebars.template(" + compiler.precompile(match[1]).toString() + ")";
+ var template = "... | true |
Other | emberjs | ember.js | b6c816ed9ca8fe9df5d83d344f1be7d0cf3eab28.json | Update precompiler for new format | packages/ember-handlebars-compiler/tests/precompile_type_test.js | @@ -6,23 +6,23 @@ var result;
QUnit.module("Ember.Handlebars.precompileType");
-test("precompile creates a function when asObject isn't defined", function(){
+test("precompile creates an object when asObject isn't defined", function(){
result = precompile(template);
- equal(typeof(result), "function");
+ equa... | true |
Other | emberjs | ember.js | 8086179d596376becc2819bf1be0c878378a6d68.json | Create Handlebars environment through proper means | packages/ember-handlebars-compiler/lib/main.js | @@ -50,7 +50,7 @@ Ember.assert("Ember Handlebars requires Handlebars version 1.0 or 1.1, " +
@class Handlebars
@namespace Ember
*/
-var EmberHandlebars = Ember.Handlebars = objectCreate(Handlebars);
+var EmberHandlebars = Ember.Handlebars = Handlebars.create();
/**
Register a bound helper or custom view he... | false |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/lib/controls.js | @@ -6,20 +6,12 @@ import Ember from "ember-metal/core"; // Ember.assert
// var emberAssert = Ember.assert;
import EmberHandlebars from "ember-handlebars-compiler";
-import { handlebarsGet } from "ember-handlebars/ext";
+
/**
@module ember
@submodule ember-handlebars-compiler
*/
-function _resolveOption(contex... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/lib/ext.js | @@ -17,109 +17,16 @@ import {
// late bound via requireModule because of circular dependencies.
var resolveHelper, SimpleHandlebarsView;
-import isEmpty from 'ember-metal/is_empty';
+import Stream from "ember-metal/streams/stream";
+import KeyStream from "ember-views/streams/key_stream";
+import {
+ readArray,
+ ... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/lib/helpers/binding.js | @@ -8,40 +8,29 @@ import Ember from "ember-metal/core"; // Ember.assert, Ember.warn, uuid
import EmberHandlebars from "ember-handlebars-compiler";
import { get } from "ember-metal/property_get";
+import { set } from "ember-metal/property_set";
import {
apply,
uuid
} from "ember-metal/utils";
import { fmt }... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/lib/helpers/collection.js | @@ -10,11 +10,14 @@ import Ember from "ember-metal/core"; // Ember.assert, Ember.deprecate
import EmberHandlebars from "ember-handlebars-compiler";
+import { IS_BINDING } from "ember-metal/mixin";
import { fmt } from "ember-runtime/system/string";
import { get } from "ember-metal/property_get";
+import SimpleStr... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/lib/helpers/debug.js | @@ -8,11 +8,6 @@ import Ember from "ember-metal/core"; // Ember.FEATURES,
import { inspect } from "ember-metal/utils";
import Logger from "ember-metal/logger";
-import {
- normalizePath,
- handlebarsGet
-} from "ember-handlebars/ext";
-
var a_slice = [].slice;
/**
@@ -30,22 +25,14 @@ var a_slice = [].slice;
... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/lib/helpers/each.js | @@ -4,7 +4,6 @@
@submodule ember-handlebars
*/
import Ember from "ember-metal/core"; // Ember.assert;, Ember.K
-var K = Ember.K;
import EmberHandlebars from "ember-handlebars-compiler";
@@ -16,9 +15,6 @@ import { Binding } from "ember-metal/binding";
import ControllerMixin from "ember-runtime/mixins/controller... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/lib/helpers/partial.js | @@ -2,7 +2,6 @@ import Ember from "ember-metal/core"; // Ember.assert
// var emberAssert = Ember.assert;
import { isNone } from 'ember-metal/is_none';
-import { handlebarsGet } from "ember-handlebars/ext";
import { bind } from "ember-handlebars/helpers/binding";
/**
@@ -61,18 +60,19 @@ import { bind } from "emb... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/lib/helpers/shared.js | @@ -1,14 +0,0 @@
-import { handlebarsGet } from "ember-handlebars/ext";
-
-export default function resolvePaths(options) {
- var ret = [];
- var contexts = options.contexts;
- var roots = options.roots;
- var data = options.data;
-
- for (var i=0, l=contexts.length; i<l; i++) {
- ret.push(handlebarsGet(roots[i]... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/lib/helpers/unbound.js | @@ -6,9 +6,6 @@
import EmberHandlebars from "ember-handlebars-compiler";
import { resolveHelper } from "ember-handlebars/helpers/binding";
-import { handlebarsGet } from "ember-handlebars/ext";
-
-var slice = [].slice;
/**
`unbound` allows you to output a property without binding. *Important:* The
@@ -30,21 +... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/lib/helpers/view.js | @@ -8,54 +8,58 @@ import Ember from "ember-metal/core"; // Ember.warn, Ember.assert
import EmberObject from "ember-runtime/system/object";
import { get } from "ember-metal/property_get";
+import keys from "ember-metal/keys";
import { IS_BINDING } from "ember-metal/mixin";
+import { readViewFactory } from "ember-vi... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/lib/main.js | @@ -5,15 +5,9 @@ import { runLoadHooks } from "ember-runtime/system/lazy_load";
import bootstrap from "ember-handlebars/loader";
import {
- normalizePath,
template,
makeBoundHelper,
registerBoundHelper,
- resolveHash,
- resolveParams,
- getEscaped,
- handlebarsGet,
- evaluateUnboundHelper,
helperM... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/lib/views/handlebars_bound_view.js | @@ -22,14 +22,11 @@ import {
} from "ember-views/views/states";
import _MetamorphView from "ember-handlebars/views/metamorph_view";
-import { handlebarsGet } from "ember-handlebars/ext";
import { uuid } from "ember-metal/utils";
-function SimpleHandlebarsView(path, pathRoot, isEscaped, templateData) {
- this.pa... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/tests/handlebars_test.js | @@ -343,22 +343,6 @@ test("child views can be inserted using the {{view}} Handlebars helper", functio
ok(view.$().text().match(/Hello world!.*Goodbye cruel world\!/), "parent view should appear before the child view");
});
-test("should accept relative paths to views", function() {
- view = EmberView.create({
- ... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/tests/helpers/bound_helper_test.js | @@ -101,7 +101,7 @@ test("bound helpers should support options", function() {
appendView();
- ok(view.$().text() === 'ababab', "helper output is correct");
+ equal(view.$().text(), 'ababab', "helper output is correct");
});
test("bound helpers should support keywords", function() {
@@ -116,7 +116,7 @@ test... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/tests/helpers/each_test.js | @@ -440,7 +440,7 @@ test("it defers all normalization of itemView names to the resolver", function()
test("it supports {{itemViewClass=}} with global (DEPRECATED)", function() {
run(function() { view.destroy(); }); // destroy existing view
view = EmberView.create({
- template: templateFor('{{each view.people ... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/tests/helpers/view_test.js | @@ -86,27 +86,6 @@ test("View lookup - App.FuView (DEPRECATED)", function() {
equal(jQuery('#fu').text(), 'bro');
});
-test("View lookup - 'App.FuView' (DEPRECATED)", function() {
- Ember.lookup = {
- App: {
- FuView: viewClass({
- elementId: "fu",
- template: Ember.Handlebars.compile("bro"... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/tests/helpers/with_test.js | @@ -121,6 +121,7 @@ test("nested {{with}} blocks shadow the outer scoped variable properly.", functi
equal(view.$().text(), "Limbo-Wrath-Treachery-Wrath-Limbo", "should be properly scoped after updating");
});
+
QUnit.module("Handlebars {{#with}} globals helper [DEPRECATED]", {
setup: function() {
Ember.... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/tests/lookup_test.js | @@ -1,133 +0,0 @@
-QUnit.module("Ember.Handlebars.resolveParams");
-
-test("Raw string parameters should be returned as Strings", function() {
- var params = Ember.Handlebars.resolveParams({}, ["foo", "bar", "baz"], { types: ["STRING", "STRING", "STRING"] });
- deepEqual(params, ["foo", "bar", "baz"]);
-});
-
-test("... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/tests/views/collection_view_test.js | @@ -350,6 +350,28 @@ test("should give its item views the property specified by itemPropertyBinding",
equal(view.$('ul li:first').text(), "yobaz", "change property of sub view");
});
+test("should unsubscribe stream bindings", function() {
+ view = EmberView.create({
+ baz: "baz",
+ content: A([EmberObject... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/tests/views/handlebars_bound_view_test.js | @@ -1,14 +1,16 @@
+import Stream from "ember-metal/streams/stream";
import { SimpleHandlebarsView } from 'ember-handlebars/views/handlebars_bound_view';
QUnit.module('SimpleHandlebarsView');
test('does not render if update is triggured by normalizedValue is the same as the previous normalizedValue', function(){
... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-handlebars/tests/views/metamorph_view_test.js | @@ -141,7 +141,7 @@ test("a metamorph view calls its childrens' willInsertElement and didInsertEleme
}
}),
- template: EmberHandlebars.compile('{{#if view.condition}}{{view "view.ViewWithCallback"}}{{/if}}'),
+ template: EmberHandlebars.compile('{{#if view.condition}}{{view view.ViewWithCallback}}{{... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-metal/lib/mixin.js | @@ -13,6 +13,8 @@ import {
import {
create as o_create
} from "ember-metal/platform";
+import { get } from "ember-metal/property_get";
+import { set, trySet } from "ember-metal/property_set";
import {
guidFor,
meta as metaFor,
@@ -31,7 +33,8 @@ import {
addObserver,
removeObserver,
addBeforeObserve... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-metal/lib/path_cache.js | @@ -4,16 +4,34 @@ var IS_GLOBAL = /^([A-Z$]|([0-9][A-Z$]))/;
var IS_GLOBAL_PATH = /^([A-Z$]|([0-9][A-Z$])).*[\.]/;
var HAS_THIS = 'this.';
-var isGlobalCache = new Cache(1000, function(key) { return IS_GLOBAL.test(key); });
-var isGlobalPathCache = new Cache(1000, function(key) { return IS_G... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-metal/lib/streams/read.js | @@ -0,0 +1,24 @@
+export function read(object) {
+ if (object && object.isStream) {
+ return object.value();
+ } else {
+ return object;
+ }
+}
+
+export function readArray(array) {
+ var length = array.length;
+ var ret = new Array(length);
+ for (var i = 0; i < length; i++) {
+ ret[i] = read(array[i]);... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-metal/lib/streams/simple.js | @@ -0,0 +1,51 @@
+import merge from "ember-metal/merge";
+import Stream from "ember-metal/streams/stream";
+import { create } from "ember-metal/platform";
+import { read } from "ember-metal/streams/read";
+
+function SimpleStream(source) {
+ this.source = source;
+
+ if (source && source.isStream) {
+ source.subsc... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-metal/lib/streams/stream.js | @@ -0,0 +1,129 @@
+import {
+ getFirstKey,
+ getTailPath
+} from "ember-metal/path_cache";
+
+var NIL = function NIL(){};
+
+function Stream(fn) {
+ this.valueFn = fn;
+ this.cache = NIL;
+ this.subscribers = undefined;
+ this.children = undefined;
+ this.destroyed = false;
+}
+
+Stream.prototype = {
+ isStream... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-metal/lib/streams/stream_binding.js | @@ -0,0 +1,74 @@
+import { create } from "ember-metal/platform";
+import merge from "ember-metal/merge";
+import run from "ember-metal/run_loop";
+import Stream from "ember-metal/streams/stream";
+
+function StreamBinding(stream) {
+ Ember.assert("StreamBinding error: tried to bind to object that is not a stream", str... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-metal/tests/streams/stream_binding_test.js | @@ -0,0 +1,121 @@
+import { get } from "ember-metal/property_get";
+import { set } from "ember-metal/property_set";
+import { mixin } from "ember-metal/mixin";
+import run from 'ember-metal/run_loop';
+import Stream from "ember-metal/streams/stream";
+import StreamBinding from "ember-metal/streams/stream_binding";
+
+v... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-routing-handlebars/lib/helpers/action.js | @@ -3,30 +3,33 @@ import { forEach } from "ember-metal/array";
import { uuid } from "ember-metal/utils";
import run from "ember-metal/run_loop";
+import { readUnwrappedModel } from "ember-views/streams/read";
import { isSimpleClick } from "ember-views/system/utils";
import ActionManager from "ember-views/system/a... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-routing-handlebars/lib/helpers/link_to.js | @@ -6,16 +6,14 @@ import { computed } from "ember-metal/computed";
import { fmt } from "ember-runtime/system/string";
import EmberObject from "ember-runtime/system/object";
+import ControllerMixin from "ember-runtime/mixins/controller";
import keys from "ember-metal/keys";
import { isSimpleClick } from "ember-vie... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-routing-handlebars/lib/helpers/outlet.js | @@ -1,4 +1,5 @@
import Ember from "ember-metal/core"; // assert
+import { set } from "ember-metal/property_set";
import ContainerView from "ember-views/views/container_view";
import { _Metamorph } from "ember-handlebars/views/metamorph_view";
import { viewHelper } from "ember-handlebars/helpers/view";
@@ -80,7 +81,... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-routing-handlebars/lib/helpers/render.js | @@ -5,7 +5,6 @@ import {
generateControllerFactory,
default as generateController
} from "ember-routing/system/generate_controller";
-import { handlebarsGet } from "ember-handlebars/ext";
import { ViewHelper } from "ember-handlebars/helpers/view";
/**
@@ -85,9 +84,9 @@ You could render it inside the `post` t... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-routing-handlebars/lib/helpers/shared.js | @@ -1,41 +0,0 @@
-import { get } from "ember-metal/property_get";
-import { map } from "ember-metal/array";
-import ControllerMixin from "ember-runtime/mixins/controller";
-import {
- resolveParams as handlebarsResolve,
- handlebarsGet
-} from "ember-handlebars/ext";
-
-export function resolveParams(context, params, ... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-routing-handlebars/lib/main.js | @@ -8,12 +8,6 @@ Ember Routing Handlebars
import Ember from "ember-metal/core";
import EmberHandlebars from "ember-handlebars";
-import Router from "ember-routing/system/router";
-
-import {
- resolvePaths,
- resolveParams
-} from "ember-routing-handlebars/helpers/shared";
import {
deprecatedLinkToHelper,
@... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-routing-handlebars/tests/helpers/action_test.js | @@ -15,7 +15,6 @@ import EmberView from "ember-views/views/view";
import EmberComponent from "ember-views/views/component";
import jQuery from "ember-views/system/jquery";
-import "ember-routing-handlebars/helpers/shared";
import {
ActionHelper,
actionHelper
@@ -99,7 +98,7 @@ test("should by default target t... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-views/lib/streams/context_stream.js | @@ -0,0 +1,44 @@
+import Ember from 'ember-metal/core';
+
+import merge from "ember-metal/merge";
+import { create } from "ember-metal/platform";
+import { isGlobal } from "ember-metal/path_cache";
+import Stream from "ember-metal/streams/stream";
+import SimpleStream from "ember-metal/streams/simple";
+
+function Cont... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-views/lib/streams/key_stream.js | @@ -0,0 +1,103 @@
+import Ember from 'ember-metal/core';
+
+import merge from "ember-metal/merge";
+import { create } from "ember-metal/platform";
+import { get } from "ember-metal/property_get";
+import { set } from "ember-metal/property_set";
+import {
+ addObserver,
+ removeObserver
+} from "ember-metal/observer";... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-views/lib/streams/read.js | @@ -0,0 +1,45 @@
+import Ember from "ember-metal/core";
+import { get } from "ember-metal/property_get";
+import { isGlobal } from "ember-metal/path_cache";
+import { fmt } from "ember-runtime/system/string";
+import { read } from "ember-metal/streams/read";
+import View from "ember-views/views/view";
+import Controlle... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-views/lib/views/collection_view.js | @@ -16,9 +16,7 @@ import {
observer,
beforeObserver
} from "ember-metal/mixin";
-import {
- handlebarsGetView
-} from "ember-handlebars/ext";
+import { readViewFactory } from "ember-views/streams/read";
import EmberArray from "ember-runtime/mixins/array";
/**
@@ -351,7 +349,7 @@ var CollectionView = Contain... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-views/lib/views/component.js | @@ -112,7 +112,6 @@ var Component = View.extend(TargetActionSupport, ComponentTemplateDeprecation, {
init: function() {
this._super();
- set(this, 'origContext', get(this, 'context'));
set(this, 'context', this);
set(this, 'controller', this);
},
@@ -160,12 +159,8 @@ var Component = View.exten... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-views/lib/views/container_view.js | @@ -385,7 +385,9 @@ merge(states.inBuffer, {
merge(states.hasElement, {
childViewsWillChange: function(view, views, start, removed) {
for (var i=start; i<start+removed; i++) {
- views[i].remove();
+ var _view = views[i];
+ _view._unsubscribeFromStreamBindings();
+ _view.remove();
}
... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-views/lib/views/view.js | @@ -12,11 +12,14 @@ import { set } from "ember-metal/property_set";
import setProperties from "ember-metal/set_properties";
import run from "ember-metal/run_loop";
import { addObserver, removeObserver } from "ember-metal/observer";
-
import { defineProperty } from "ember-metal/properties";
import { guidFor } from ... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-views/tests/views/container_view_test.js | @@ -280,11 +280,9 @@ test("if a ContainerView starts with a currentView, it is rendered as a child vi
controller: controller
});
var context = null;
- var templateData = null;
var mainView = View.create({
template: function(ctx, opts) {
context = ctx;
- templateData = opts.data;
r... | true |
Other | emberjs | ember.js | f839dcd89ad5ecc50d5403a06f507449380557b0.json | Streamify template bindings | packages/ember-views/tests/views/view/template_test.js | @@ -142,7 +142,7 @@ test("should provide a controller to the template if a controller is specified o
controller: controller1,
template: function(buffer, options) {
- optionsDataKeywordsControllerForView = options.data.keywords.controller;
+ optionsDataKeywordsControllerForView = options.data.view.... | true |
Other | emberjs | ember.js | ba1fcb82fe5cde4e40eac7a29f2623f9f38a4aaf.json | remove unused toDOM method | packages/ember-views/lib/system/render_buffer.js | @@ -64,10 +64,6 @@ ClassSet.prototype = {
this.seen[string] = true;
this.list.push(string);
- },
-
- toDOM: function() {
- return this.list.join(" ");
}
};
| false |
Other | emberjs | ember.js | 53ec667245c4a79d1e76e1d257b13ee716acb74b.json | update back burner
Diff: https://github.com/ebryn/backburner.js/compare/919861fa9f3a5504c37f05607b1b02421af04167...baef3625dd4374e3803288652cd0aab68775cc62
* [Cleanup]unify deferredActionQueue.flush and queue.flush
* [Perf] reduce cost of flushing and dramatically reduce cost of flushing empty queues. | bower.json | @@ -7,7 +7,7 @@
"qunit-phantom-runner": "jonkemp/qunit-phantomjs-runner#1.2.0"
},
"devDependencies": {
- "backburner": "https://github.com/ebryn/backburner.js.git#24ff580bef0f2d402474cc3d221da73ac82f09c9",
+ "backburner": "https://github.com/ebryn/backburner.js.git#baef3625dd4374e3803288652cd0aab68775c... | false |
Other | emberjs | ember.js | 906d5297c2ec22d6410e0b0f65d4eca47fecf098.json | Add a . to increase readability
I added a . on line 33 to separate two sentences for increase readability. | README.md | @@ -30,7 +30,7 @@ See [CONTRIBUTING.md](https://github.com/emberjs/ember.js/blob/master/CONTRIBUTI
3. Then visit <http://localhost:4200/>. This will run all tests.
-4. To test a specific package visit `http://localhost:4200/tests/index.html?package=PACKAGE_NAME` Replace
+4. To test a specific package visit `http:/... | false |
Other | emberjs | ember.js | cc04f14e2be5c790c4036251793b4ceab2093a03.json | Fix regex to match Windows line endings
Fixes #5662 | lib/broccoli-ember-inline-template-precompiler.js | @@ -15,7 +15,7 @@ function EmberInlineTemplatePrecompiler (inputTree, options) {
this.inlineTemplateRegExp = /precompileTemplate\(['"](.*)['"]\)/;
// Used for replacing the original variable declaration to satisfy JSHint.
// For example, removes `var precompileTemplate = Ember.Handlebars.compile;`.
- this.pre... | false |
Other | emberjs | ember.js | 48ecdd707e226315bb4750ff0c91a6fcb56e2637.json | Remove documentation for {{template}}
{{template}} was deprecated in favor or {[partial}} before 1.0 in
ea5456ac on 2013-07-19. | packages/ember-handlebars/lib/helpers/template.js | @@ -1,5 +1,4 @@
-import Ember from "ember-metal/core";
-// var emberDeprecate = Ember.deprecate;
+import Ember from "ember-metal/core"; // Ember.deprecate;
import EmberHandlebars from "ember-handlebars-compiler";
/**
@@ -8,43 +7,6 @@ import EmberHandlebars from "ember-handlebars-compiler";
*/
/**
- `template` ... | false |
Other | emberjs | ember.js | b7e6adb90c134593d33268b7c3a1bd15e7d627b4.json | Remove duplicate _MetamorphView | packages/ember-handlebars/lib/helpers/each.js | @@ -27,10 +27,8 @@ import {
removeBeforeObserver
} from "ember-metal/observer";
-import {
- _Metamorph,
- _MetamorphView
-} from "ember-handlebars/views/metamorph_view";
+import _MetamorphView from "ember-handlebars/views/metamorph_view";
+import { _Metamorph } from "ember-handlebars/views/metamorph_view";
v... | true |
Other | emberjs | ember.js | b7e6adb90c134593d33268b7c3a1bd15e7d627b4.json | Remove duplicate _MetamorphView | packages/ember-handlebars/lib/main.js | @@ -79,9 +79,9 @@ import {
_HandlebarsBoundView,
SimpleHandlebarsView
} from "ember-handlebars/views/handlebars_bound_view";
+import _MetamorphView from "ember-handlebars/views/metamorph_view";
import {
_SimpleMetamorphView,
- _MetamorphView,
_Metamorph
} from "ember-handlebars/views/metamorph_view";
| true |
Other | emberjs | ember.js | b7e6adb90c134593d33268b7c3a1bd15e7d627b4.json | Remove duplicate _MetamorphView | packages/ember-handlebars/lib/views/metamorph_view.js | @@ -37,7 +37,7 @@ export var _Metamorph = Mixin.create({
@uses Ember._Metamorph
@private
*/
-export var _MetamorphView = View.extend(_Metamorph);
+export default View.extend(_Metamorph);
/**
@class _SimpleMetamorphView
@@ -47,4 +47,3 @@ export var _MetamorphView = View.extend(_Metamorph);
@private
*/
... | true |
Other | emberjs | ember.js | b7e6adb90c134593d33268b7c3a1bd15e7d627b4.json | Remove duplicate _MetamorphView | packages/ember-routing-handlebars/tests/helpers/outlet_test.js | @@ -17,7 +17,7 @@ import EmberRouter from "ember-routing/system/router";
import HashLocation from "ember-routing/location/hash_location";
import EmberHandlebars from "ember-handlebars";
-import {_MetamorphView} from "ember-handlebars/views/metamorph_view";
+import _MetamorphView from "ember-handlebars/views/metamor... | true |
Other | emberjs | ember.js | f4ea6733ee3e0d8bbc9e481a660693381f0f7f34.json | Update changelog for 1.8.0-beta.2 and 1.8.0-beta.3. | CHANGELOG.md | @@ -1,5 +1,40 @@
# Ember Changelog
+### Ember 1.8.0-beta.3 (September, 27, 2014)
+
+* [BUGFIX] Use contextualElements to properly handle omitted optional start tags.
+* [BUGFIX] Ensure that `Route.prototype.activate` is not retriggered when the model for the current route changes.
+* [PERF] Fix optimization bailouts... | false |
Other | emberjs | ember.js | 99a7c9dd7dbeff4f11b4125c73f7d677d410db7f.json | Remove repeated "esnext" jshint rule | .jshintrc | @@ -41,7 +41,6 @@
"debug": false,
"devel": false,
"eqeqeq": true,
- "esnext": true,
"evil": true,
"forin": false,
"immed": false, | false |
Other | emberjs | ember.js | def2d723be222addbc2b35942f07c10a89c7d7c6.json | prefer new Map() syntax | packages/ember-metal/lib/binding.js | @@ -2,7 +2,7 @@ import Ember from "ember-metal/core"; // Ember.Logger, Ember.LOG_BINDINGS, asser
import { get } from "ember-metal/property_get";
import { trySet } from "ember-metal/property_set";
import { guidFor } from "ember-metal/utils";
-import { Map } from "ember-metal/map";
+import Map from "ember-metal/map";
... | true |
Other | emberjs | ember.js | def2d723be222addbc2b35942f07c10a89c7d7c6.json | prefer new Map() syntax | packages/ember-metal/lib/map.js | @@ -474,6 +474,7 @@ MapWithDefault.prototype.copy = function() {
}));
};
+export default Map;
export {
OrderedSet,
Map, | true |
Other | emberjs | ember.js | 00c650cc5443679ff33491be1db183c68b85429d.json | Use separate FEATURES for dev vs prod builds. | Brocfile.js | @@ -204,7 +204,22 @@ var testConfig = pickFiles('tests', {
testConfig = replace(testConfig, {
files: [ 'tests/ember_configuration.js' ],
patterns: [
- { match: /\{\{FEATURES\}\}/g, replacement: JSON.stringify(defeatureifyConfig().enabled) }
+ { match: /\{\{DEV_FEATURES\}\}/g,
+ replacement: function()... | true |
Other | emberjs | ember.js | 00c650cc5443679ff33491be1db183c68b85429d.json | Use separate FEATURES for dev vs prod builds. | tests/ember_configuration.js | @@ -5,7 +5,6 @@
testing: true
};
window.ENV = window.ENV || {};
- ENV.FEATURES = {{FEATURES}};
// Test for "hooks in ENV.EMBER_LOAD_HOOKS['hookName'] get executed"
ENV.EMBER_LOAD_HOOKS = ENV.EMBER_LOAD_HOOKS || {};
@@ -15,6 +14,8 @@
ENV.__test_hook_count__ += object;
});
+ window.ENV.FEAT... | true |
Other | emberjs | ember.js | b3f0f6ce68833ffc53a72ebc6249908b6fff199d.json | Fix argument order for handleMandatorySetter. | packages/ember-metal/lib/watch_key.js | @@ -38,7 +38,7 @@ export function watchKey(obj, keyName, meta) {
if (Ember.FEATURES.isEnabled('mandatory-setter')) {
- var handleMandatorySetter = function handleMandatorySetter(m, keyName, obj) {
+ var handleMandatorySetter = function handleMandatorySetter(m, obj, keyName) {
// this x in Y deopts, so keepi... | false |
Other | emberjs | ember.js | ca6d60018bd342387c96f0a96af57771e98eae93.json | Allow development only feature flags.
When a flag with `development-only` is found in `features.json` it will
be enabled (flags stripped) for `ember.js`, and disabled (flags
stripped) for `ember.prod.js`. | Brocfile.js | @@ -20,7 +20,13 @@ var calculateVersion = require('./lib/calculate-version');
var env = process.env.EMBER_ENV || 'development';
var disableJSHint = !!process.env.NO_JSHINT || false;
-var disableDefeatureify = !!process.env.NO_DEFEATUREIFY || env === 'development' || false;
+var disableDefeatureify;
+
+if (process.e... | true |
Other | emberjs | ember.js | ca6d60018bd342387c96f0a96af57771e98eae93.json | Allow development only feature flags.
When a flag with `development-only` is found in `features.json` it will
be enabled (flags stripped) for `ember.js`, and disabled (flags
stripped) for `ember.prod.js`. | features.json | @@ -11,7 +11,8 @@
"property-brace-expansion-improvement": true,
"ember-routing-handlebars-action-with-key-code": null,
"ember-runtime-item-controller-inline-class": null,
- "ember-metal-injected-properties": null
+ "ember-metal-injected-properties": null,
+ "mandatory-setter": "development-only"... | true |
Other | emberjs | ember.js | a72152f90f84e3793e05ca04d84f35e3782d0eb6.json | fix failing test on IE11.
turns out the internal escaping stragety can differ between browsers. We
should defer to the browsers defaults | Brocfile.js | @@ -89,7 +89,7 @@ function vendoredPackage(packageName) {
destFile: '/' + packageName + '.js'
});
- if (env !== 'development') {
+ if (true) {
sourceTree = es3recast(sourceTree);
}
@@ -599,7 +599,7 @@ var prodCompiledSource = removeFile(sourceTrees, {
// Generates prod build. defeatureify increa... | true |
Other | emberjs | ember.js | a72152f90f84e3793e05ca04d84f35e3782d0eb6.json | fix failing test on IE11.
turns out the internal escaping stragety can differ between browsers. We
should defer to the browsers defaults | packages/ember-views/tests/system/render_buffer_test.js | @@ -70,7 +70,16 @@ test("prevents XSS injection via `style`", function() {
buffer.generateElement();
var el = buffer.element();
- equal(el.getAttribute('style'), 'color:blue;" xss="true" style="color:red;');
+ var div = document.createElement('div');
+
+ // some browsers have different escaping strageties
+ ... | true |
Other | emberjs | ember.js | 9b3e1eca1f9b0e9e649adcfea15e50b8d895e29f.json | improve throughput of actionsFor by 30%-40%
hasOwnProperty is unfortunately slow so we should guard it with checks that the property is even something like what we want first. Also go back to embers roots and maintain __source__ on listeners. | packages/ember-metal/lib/events.js | @@ -52,21 +52,26 @@ function indexOf(array, target, method) {
function actionsFor(obj, eventName) {
var meta = metaFor(obj, true);
var actions;
+ var listeners = meta.listeners;
- if (!meta.listeners) { meta.listeners = {}; }
-
- if (!meta.hasOwnProperty('listeners')) {
+ if (!listeners) {
+ listeners =... | false |
Other | emberjs | ember.js | 34a0d6a561d3e18e1aef8e856064dec33740120f.json | Use svg instead of png to get better image quality | README.md | @@ -1,4 +1,4 @@
-# Ember.js [](http://travis-ci.org/emberjs/ember.js) [](https://codeclimate.com/github/emberjs/ember.js)
+# Ember.js [![Build Status](https://secure.travis... | false |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | .jshintrc | @@ -59,5 +59,6 @@
"strict": false,
"white": false,
"eqnull": true,
- "trailing": true
+ "trailing": true,
+ "unused": "vars"
} | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.