language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
emberjs
ember.js
83209e5d909152cd13649b77b4b769d84445e1bc.json
Move argument special casing to the helpers. Paves the way for Handlbars compat version of `registerHelper` and `makeBoundHelper`. Also, cleans up troubling bits of `streamifyArgs`.
packages/ember-htmlbars/lib/hooks.js
@@ -2,27 +2,15 @@ import Ember from "ember-metal/core"; import { lookupHelper } from "ember-htmlbars/system/lookup-helper"; import { sanitizeOptionsForHelper } from "ember-htmlbars/system/sanitize-for-helper"; -function streamifyArgs(view, params, hash, options, env) { - if (params.length === 3 && params[1] === "a...
true
Other
emberjs
ember.js
f07c5e9ba92592b6207eb1486d3d5d9137f94b52.json
Update htmlbars version. Allows components to have dashes in hash parameters (specifically fixes `current-when` for the `{{link-to}}` helper).
package.json
@@ -42,7 +42,7 @@ "git-repo-version": "0.0.1", "glob": "~3.2.8", "handlebars": "^2.0", - "htmlbars": "0.1.3", + "htmlbars": "0.1.4", "ncp": "~0.5.1", "rimraf": "~2.2.8", "rsvp": "~3.0.6"
false
Other
emberjs
ember.js
18e41644485785ef05b953149e28ba9db1cfa526.json
Implement action helper for HTMLBars This commit also raises an assertion for un-quoted actions. These are long deprecated, and impossible to support with the current or planned streams implementation.
packages/ember-routing-handlebars/lib/helpers/action.js
@@ -108,15 +108,11 @@ ActionHelper.registerAction = function(actionNameOrStream, options, allowedKeys) if (actionNameOrStream.isStream) { actionName = actionNameOrStream.value(); - if (typeof actionName === 'undefined' || typeof actionName === 'function') { - actionName = actionNameOrS...
true
Other
emberjs
ember.js
18e41644485785ef05b953149e28ba9db1cfa526.json
Implement action helper for HTMLBars This commit also raises an assertion for un-quoted actions. These are long deprecated, and impossible to support with the current or planned streams implementation.
packages/ember-routing-htmlbars/lib/helpers/action.js
@@ -0,0 +1,321 @@ +/** +@module ember +@submodule ember-routing-htmlbars +*/ + +import Ember from "ember-metal/core"; // Handlebars, uuid, FEATURES, assert, deprecate +import { uuid } from "ember-metal/utils"; +import run from "ember-metal/run_loop"; +import { readUnwrappedModel } from "ember-views/streams/read"; +impo...
true
Other
emberjs
ember.js
18e41644485785ef05b953149e28ba9db1cfa526.json
Implement action helper for HTMLBars This commit also raises an assertion for un-quoted actions. These are long deprecated, and impossible to support with the current or planned streams implementation.
packages/ember-routing-htmlbars/lib/main.js
@@ -15,9 +15,11 @@ import { linkToHelper, deprecatedLinkToHelper } from "ember-routing-htmlbars/helpers/link-to"; +import { actionHelper } from "ember-routing-htmlbars/helpers/action"; registerHelper('outlet', outletHelper); registerHelper('link-to', linkToHelper); registerHelper('linkTo', deprecatedLinkToH...
true
Other
emberjs
ember.js
18e41644485785ef05b953149e28ba9db1cfa526.json
Implement action helper for HTMLBars This commit also raises an assertion for un-quoted actions. These are long deprecated, and impossible to support with the current or planned streams implementation.
packages/ember-routing-htmlbars/tests/helpers/action_test.js
@@ -11,26 +11,54 @@ import EmberObjectController from "ember-runtime/controllers/object_controller"; import EmberArrayController from "ember-runtime/controllers/array_controller"; import EmberHandlebars from "ember-handlebars"; +import htmlbarsCompile from "ember-htmlbars/system/compile"; import EmberView from "em...
true
Other
emberjs
ember.js
932bab101f01d59b41706294ae3a11fe1b2f7fc0.json
Implement HTMLBars `each` helper
packages/ember-htmlbars/lib/helpers/each.js
@@ -0,0 +1,306 @@ + +/** +@module ember +@submodule ember-handlebars +*/ +import Ember from "ember-metal/core"; // Ember.assert; + + +import { fmt } from "ember-runtime/system/string"; +import { get } from "ember-metal/property_get"; +import { set } from "ember-metal/property_set"; +import CollectionView from "ember-vi...
true
Other
emberjs
ember.js
932bab101f01d59b41706294ae3a11fe1b2f7fc0.json
Implement HTMLBars `each` helper
packages/ember-htmlbars/lib/hooks.js
@@ -10,6 +10,13 @@ function streamifyArgs(view, params, hash, options, env) { stream: view.getStream(params[0]) }); options.types.splice(0, 3, 'keyword'); + } else if (params.length === 3 && params[1] === "in") { + params.splice(0, 3, { + from: params[2], + to: params[0], + stream: v...
true
Other
emberjs
ember.js
932bab101f01d59b41706294ae3a11fe1b2f7fc0.json
Implement HTMLBars `each` helper
packages/ember-htmlbars/lib/main.js
@@ -35,6 +35,7 @@ import { templateHelper } from "ember-htmlbars/helpers/template"; import { inputHelper } from "ember-htmlbars/helpers/input"; import { textareaHelper } from "ember-htmlbars/helpers/text_area"; import { collectionHelper } from "ember-htmlbars/helpers/collection"; +import { eachHelper } from "ember-h...
true
Other
emberjs
ember.js
932bab101f01d59b41706294ae3a11fe1b2f7fc0.json
Implement HTMLBars `each` helper
packages/ember-htmlbars/lib/system/lookup-helper.js
@@ -8,19 +8,19 @@ export var ISNT_HELPER_CACHE = new Cache(1000, function(key) { return key.indexOf('-') === -1; }); -export function attribute(element, params, options, env) { +export function attribute(params, hash, options, env) { var dom = env.dom; var name = params[0]; var value = params[1]; va...
true
Other
emberjs
ember.js
932bab101f01d59b41706294ae3a11fe1b2f7fc0.json
Implement HTMLBars `each` helper
packages/ember-htmlbars/tests/helpers/each_test.js
@@ -16,11 +16,19 @@ import Container from "ember-runtime/system/container"; import { get } from "ember-metal/property_get"; import { set } from "ember-metal/property_set"; +import htmlbarsCompile from "ember-htmlbars/system/compile"; +var compile; +if (Ember.FEATURES.isEnabled('ember-htmlbars')) { + compile = html...
true
Other
emberjs
ember.js
01d5f0680da11f305160e3b1d62abcf1b9249a5b.json
Implement HTMLBars `collection` helper
packages/ember-handlebars/tests/handlebars_test.js
@@ -14,8 +14,6 @@ import { A } from "ember-runtime/system/native_array"; import { computed } from "ember-metal/computed"; import { fmt } from "ember-runtime/system/string"; import { typeOf } from "ember-metal/utils"; -import ArrayProxy from "ember-runtime/system/array_proxy"; -import CollectionView from "ember-views...
true
Other
emberjs
ember.js
01d5f0680da11f305160e3b1d62abcf1b9249a5b.json
Implement HTMLBars `collection` helper
packages/ember-htmlbars/lib/helpers/collection.js
@@ -0,0 +1,267 @@ +/** +@module ember +@submodule ember-handlebars +*/ + +import Ember from "ember-metal/core"; // Ember.assert, Ember.deprecate +import EmberHandlebars from "ember-handlebars-compiler"; + +import { IS_BINDING } from "ember-metal/mixin"; +import { fmt } from "ember-runtime/system/string"; +import { get ...
true
Other
emberjs
ember.js
01d5f0680da11f305160e3b1d62abcf1b9249a5b.json
Implement HTMLBars `collection` helper
packages/ember-htmlbars/lib/main.js
@@ -34,6 +34,7 @@ import { partialHelper } from "ember-htmlbars/helpers/partial"; import { templateHelper } from "ember-htmlbars/helpers/template"; import { inputHelper } from "ember-htmlbars/helpers/input"; import { textareaHelper } from "ember-htmlbars/helpers/text_area"; +import { collectionHelper } from "ember-h...
true
Other
emberjs
ember.js
01d5f0680da11f305160e3b1d62abcf1b9249a5b.json
Implement HTMLBars `collection` helper
packages/ember-htmlbars/tests/helpers/collection_test.js
@@ -1,47 +1,158 @@ /*jshint newcap:false*/ - +import CollectionView from "ember-views/views/collection_view"; +import EmberObject from "ember-runtime/system/object"; import EmberView from "ember-views/views/view"; +import EmberHandlebars from "ember-handlebars"; +import ArrayProxy from "ember-runtime/system/array_pro...
true
Other
emberjs
ember.js
788c825b27b7c9b884a91635207742de1fcad8c1.json
Add deprecation for quoteless outlet names
packages/ember-routing-handlebars/lib/helpers/outlet.js
@@ -82,6 +82,12 @@ export function outletHelper(property, options) { property = 'main'; } + Ember.deprecate( + "Using {{outlet}} with an unquoted name is not supported. " + + "Please update to quoted usage '{{outlet \"" + property + "\"}}'.", + arguments.length === 1 || options.types[0] === 'STRING'...
true
Other
emberjs
ember.js
788c825b27b7c9b884a91635207742de1fcad8c1.json
Add deprecation for quoteless outlet names
packages/ember-routing-htmlbars/lib/helpers/outlet.js
@@ -77,8 +77,10 @@ export function outletHelper(params, hash, options, env) { var viewClass; var viewFullName; - Ember.assert("Outlet names must be a string literal, e.g. {{outlet \"header\"}}", - params.length === 0 || options.types[0] === 'string'); + Ember.assert( + "Using {{outlet}} with an unquoted...
true
Other
emberjs
ember.js
788c825b27b7c9b884a91635207742de1fcad8c1.json
Add deprecation for quoteless outlet names
packages/ember-routing-htmlbars/tests/helpers/outlet_test.js
@@ -380,3 +380,39 @@ test("should support layouts", function() { // Replace whitespace for older IE equal(trim(view.$().text()), 'HIBYE'); }); + +test("should not throw deprecations if {{outlet}} is used without a name", function() { + expectNoDeprecation(); + view = EmberView.create({ + template: compile("...
true
Other
emberjs
ember.js
f151c5b64bc2446b985777920b3ed9b1a4ff6b1c.json
Use HTMLBars from published NPM package. * Removes need to do crazy monkey patching/nesting inside HTMLBars. * Enables us to use the specific version of simple-html-tokenizer for the version of HTMLBars we are using. * Do not use `htmlbars-runtime` (ember-htmlbars is our runtime). * Use `htmlbars-test-helpers` packa...
Brocfile.js
@@ -16,7 +16,6 @@ var replace = require('broccoli-replace'); var es3recast = require('broccoli-es3-safe-recast'); var useStrictRemover = require('broccoli-use-strict-remover'); var derequire = require('broccoli-derequire'); -var htmlbarsHandlebarsInliner = require('htmlbars/build-support/handlebars-inliner'); var...
true
Other
emberjs
ember.js
f151c5b64bc2446b985777920b3ed9b1a4ff6b1c.json
Use HTMLBars from published NPM package. * Removes need to do crazy monkey patching/nesting inside HTMLBars. * Enables us to use the specific version of simple-html-tokenizer for the version of HTMLBars we are using. * Do not use `htmlbars-runtime` (ember-htmlbars is our runtime). * Use `htmlbars-test-helpers` packa...
bower.json
@@ -12,8 +12,7 @@ "router.js": "https://github.com/tildeio/router.js.git#f7b4b11543222c52d91df861544592a8c1dcea8a", "route-recognizer": "https://github.com/tildeio/route-recognizer.git#8e1058e29de741b8e05690c69da9ec402a167c69", "dag-map": "https://github.com/krisselden/dag-map.git#e307363256fe918f426e5a6...
true
Other
emberjs
ember.js
f151c5b64bc2446b985777920b3ed9b1a4ff6b1c.json
Use HTMLBars from published NPM package. * Removes need to do crazy monkey patching/nesting inside HTMLBars. * Enables us to use the specific version of simple-html-tokenizer for the version of HTMLBars we are using. * Do not use `htmlbars-runtime` (ember-htmlbars is our runtime). * Use `htmlbars-test-helpers` packa...
lib/packages.js
@@ -9,7 +9,7 @@ module.exports = { 'ember-testing': {trees: null, requirements: ['ember-application', 'ember-routing'], developmentOnly: true}, 'ember-handlebars-compiler': {trees: null, requirements: ['ember-views']}, 'ember-handlebars': {trees: null, requirements: ['ember-views', '...
true
Other
emberjs
ember.js
f151c5b64bc2446b985777920b3ed9b1a4ff6b1c.json
Use HTMLBars from published NPM package. * Removes need to do crazy monkey patching/nesting inside HTMLBars. * Enables us to use the specific version of simple-html-tokenizer for the version of HTMLBars we are using. * Do not use `htmlbars-runtime` (ember-htmlbars is our runtime). * Use `htmlbars-test-helpers` packa...
package.json
@@ -42,7 +42,7 @@ "git-repo-version": "0.0.1", "glob": "~3.2.8", "handlebars": "^2.0", - "htmlbars": "tildeio/htmlbars#e6cfd7517b279de437b93fc2f66775b37c029c5d", + "htmlbars": "0.1.3", "ncp": "~0.5.1", "rimraf": "~2.2.8", "rsvp": "~3.0.6"
true
Other
emberjs
ember.js
f151c5b64bc2446b985777920b3ed9b1a4ff6b1c.json
Use HTMLBars from published NPM package. * Removes need to do crazy monkey patching/nesting inside HTMLBars. * Enables us to use the specific version of simple-html-tokenizer for the version of HTMLBars we are using. * Do not use `htmlbars-runtime` (ember-htmlbars is our runtime). * Use `htmlbars-test-helpers` packa...
packages/ember-htmlbars/tests/hooks/text_node_test.js
@@ -2,7 +2,7 @@ import EmberView from "ember-views/views/view"; import run from "ember-metal/run_loop"; import EmberObject from "ember-runtime/system/object"; import { compile } from "htmlbars-compiler/compiler"; -import { equalInnerHTML } from "../helpers"; +import { equalInnerHTML } from "htmlbars-test-helpers"; ...
true
Other
emberjs
ember.js
f151c5b64bc2446b985777920b3ed9b1a4ff6b1c.json
Use HTMLBars from published NPM package. * Removes need to do crazy monkey patching/nesting inside HTMLBars. * Enables us to use the specific version of simple-html-tokenizer for the version of HTMLBars we are using. * Do not use `htmlbars-runtime` (ember-htmlbars is our runtime). * Use `htmlbars-test-helpers` packa...
packages/ember-htmlbars/tests/htmlbars_test.js
@@ -1,6 +1,6 @@ import { compile } from "htmlbars-compiler/compiler"; import { defaultEnv } from "ember-htmlbars"; -import { equalHTML } from "./helpers"; +import { equalHTML } from "htmlbars-test-helpers"; if (Ember.FEATURES.isEnabled('ember-htmlbars')) {
true
Other
emberjs
ember.js
549416bf59908c3844ace759478aca943bbe9496.json
Add HTMLBars component hook. Allows component lookup via: ```javascript <some-thing> Stuff here... </some-thing> ```
packages/ember-htmlbars/lib/hooks.js
@@ -1,3 +1,4 @@ +import Ember from "ember-metal/core"; import { lookupHelper } from "ember-htmlbars/system/lookup-helper"; import { sanitizeOptionsForHelper } from "ember-htmlbars/system/sanitize-for-helper"; @@ -43,6 +44,17 @@ export function content(morph, path, view, params, hash, options, env) { return helpe...
true
Other
emberjs
ember.js
549416bf59908c3844ace759478aca943bbe9496.json
Add HTMLBars component hook. Allows component lookup via: ```javascript <some-thing> Stuff here... </some-thing> ```
packages/ember-htmlbars/lib/main.js
@@ -1,5 +1,10 @@ import Ember from "ember-metal/core"; -import { content, element, subexpr } from "ember-htmlbars/hooks"; +import { + content, + element, + subexpr, + component +} from "ember-htmlbars/hooks"; import { DOMHelper } from "morph"; import template from "ember-htmlbars/system/template"; import compil...
true
Other
emberjs
ember.js
549416bf59908c3844ace759478aca943bbe9496.json
Add HTMLBars component hook. Allows component lookup via: ```javascript <some-thing> Stuff here... </some-thing> ```
packages/ember-htmlbars/tests/hooks/component_test.js
@@ -0,0 +1,59 @@ +import ComponentLookup from "ember-views/component_lookup"; +import Container from "container"; +import EmberView from "ember-views/views/view"; +import run from "ember-metal/run_loop"; +import compile from "ember-htmlbars/system/compile"; + +var view, container; + +function generateContainer() { + v...
true
Other
emberjs
ember.js
72b16349ed083fd5e40735823dbf7e5d95007166.json
Import only jQuery instead of Ember in ember-views.
packages/ember-views/lib/views/states/in_buffer.js
@@ -1,7 +1,7 @@ import _default from "ember-views/views/states/default"; import EmberError from "ember-metal/error"; -import Ember from "ember-metal/core"; // Ember.assert +import jQuery from "ember-views/system/jquery"; import { create } from "ember-metal/platform"; import merge from "ember-metal/merge"; @@ -1...
false
Other
emberjs
ember.js
7ffbd9ca809bb33bc10f358589439b6c10073042.json
Add template & compile functions for HTMLBars. This provides a central location for any customizations we need to do to the compiled templates from htmlbars-compiler. Things like `isTop` and `isMethod` being set for example. These are obviously, Ember concerns (neither thing really makes sense in HTMLBars). The node...
packages/ember-htmlbars/lib/main.js
@@ -1,5 +1,8 @@ +import Ember from "ember-metal/core"; import { content, element, subexpr } from "ember-htmlbars/hooks"; import { DOMHelper } from "morph"; +import template from "ember-htmlbars/system/template"; +import compile from "ember-htmlbars/system/compile"; import { registerHelper, @@ -42,6 +45,13 @@ re...
true
Other
emberjs
ember.js
7ffbd9ca809bb33bc10f358589439b6c10073042.json
Add template & compile functions for HTMLBars. This provides a central location for any customizations we need to do to the compiled templates from htmlbars-compiler. Things like `isTop` and `isMethod` being set for example. These are obviously, Ember concerns (neither thing really makes sense in HTMLBars). The node...
packages/ember-htmlbars/lib/system/compile.js
@@ -0,0 +1,18 @@ +import { compile } from "htmlbars-compiler/compiler"; +import template from "ember-htmlbars/system/template"; + +/** + Uses HTMLBars `compile` function to process a string into a compiled template. + + This is not present in production builds. + + @private + @method template + @param {String} tem...
true
Other
emberjs
ember.js
7ffbd9ca809bb33bc10f358589439b6c10073042.json
Add template & compile functions for HTMLBars. This provides a central location for any customizations we need to do to the compiled templates from htmlbars-compiler. Things like `isTop` and `isMethod` being set for example. These are obviously, Ember concerns (neither thing really makes sense in HTMLBars). The node...
packages/ember-htmlbars/lib/system/template.js
@@ -0,0 +1,15 @@ +/** + Augments the detault precompiled output of an HTMLBars template with + additional information needed by Ember. + + @private + @method template + @param {Function} templateSpec This is the compiled HTMLBars template spec. +*/ + +export default function(templateSpec) { + templateSpec.isTop =...
true
Other
emberjs
ember.js
7ffbd9ca809bb33bc10f358589439b6c10073042.json
Add template & compile functions for HTMLBars. This provides a central location for any customizations we need to do to the compiled templates from htmlbars-compiler. Things like `isTop` and `isMethod` being set for example. These are obviously, Ember concerns (neither thing really makes sense in HTMLBars). The node...
packages/ember-htmlbars/tests/helpers/bind_attr_test.js
@@ -15,9 +15,7 @@ import { set } from "ember-metal/property_set"; import { default as htmlbarsHelpers } from "ember-htmlbars/helpers"; -import { - compile as htmlbarsCompile -} from "htmlbars-compiler/compiler"; +import htmlbarsCompile from "ember-htmlbars/system/compile"; var compile, helpers; if (Ember.FEAT...
true
Other
emberjs
ember.js
7ffbd9ca809bb33bc10f358589439b6c10073042.json
Add template & compile functions for HTMLBars. This provides a central location for any customizations we need to do to the compiled templates from htmlbars-compiler. Things like `isTop` and `isMethod` being set for example. These are obviously, Ember concerns (neither thing really makes sense in HTMLBars). The node...
packages/ember-htmlbars/tests/helpers/bind_test.js
@@ -2,7 +2,7 @@ import EmberView from "ember-views/views/view"; import EmberObject from "ember-runtime/system/object"; import run from "ember-metal/run_loop"; import EmberHandlebars from "ember-handlebars"; -import { compile as htmlbarsCompile } from "htmlbars-compiler/compiler"; +import htmlbarsCompile from "ember-...
true
Other
emberjs
ember.js
7ffbd9ca809bb33bc10f358589439b6c10073042.json
Add template & compile functions for HTMLBars. This provides a central location for any customizations we need to do to the compiled templates from htmlbars-compiler. Things like `isTop` and `isMethod` being set for example. These are obviously, Ember concerns (neither thing really makes sense in HTMLBars). The node...
packages/ember-htmlbars/tests/helpers/debug_test.js
@@ -4,7 +4,7 @@ import run from "ember-metal/run_loop"; import EmberView from "ember-views/views/view"; import EmberHandlebars from "ember-handlebars-compiler"; import { logHelper } from "ember-handlebars/helpers/debug"; -import { compile as htmlbarsCompile } from "htmlbars-compiler/compiler"; +import htmlbarsCompil...
true
Other
emberjs
ember.js
7ffbd9ca809bb33bc10f358589439b6c10073042.json
Add template & compile functions for HTMLBars. This provides a central location for any customizations we need to do to the compiled templates from htmlbars-compiler. Things like `isTop` and `isMethod` being set for example. These are obviously, Ember concerns (neither thing really makes sense in HTMLBars). The node...
packages/ember-htmlbars/tests/helpers/if_unless_test.js
@@ -3,7 +3,7 @@ import run from "ember-metal/run_loop"; import EmberView from "ember-views/views/view"; import ObjectProxy from "ember-runtime/system/object_proxy"; import EmberHandlebars from "ember-handlebars"; -import { compile as htmlbarsCompile } from "htmlbars-compiler/compiler"; +import htmlbarsCompile from "...
true
Other
emberjs
ember.js
7ffbd9ca809bb33bc10f358589439b6c10073042.json
Add template & compile functions for HTMLBars. This provides a central location for any customizations we need to do to the compiled templates from htmlbars-compiler. Things like `isTop` and `isMethod` being set for example. These are obviously, Ember concerns (neither thing really makes sense in HTMLBars). The node...
packages/ember-htmlbars/tests/helpers/loc_test.js
@@ -1,7 +1,7 @@ import run from 'ember-metal/run_loop'; import EmberView from 'ember-views/views/view'; import EmberHandlebars from 'ember-handlebars-compiler'; -import { compile as htmlbarsCompile } from 'htmlbars-compiler/compiler'; +import htmlbarsCompile from "ember-htmlbars/system/compile"; var compile; if ...
true
Other
emberjs
ember.js
7ffbd9ca809bb33bc10f358589439b6c10073042.json
Add template & compile functions for HTMLBars. This provides a central location for any customizations we need to do to the compiled templates from htmlbars-compiler. Things like `isTop` and `isMethod` being set for example. These are obviously, Ember concerns (neither thing really makes sense in HTMLBars). The node...
packages/ember-htmlbars/tests/helpers/partial_test.js
@@ -5,7 +5,7 @@ import jQuery from "ember-views/system/jquery"; var trim = jQuery.trim; import Container from "ember-runtime/system/container"; import EmberHandlebars from "ember-handlebars-compiler"; -import { compile as htmlbarsCompile } from "htmlbars-compiler/compiler"; +import htmlbarsCompile from "ember-htmlba...
true
Other
emberjs
ember.js
7ffbd9ca809bb33bc10f358589439b6c10073042.json
Add template & compile functions for HTMLBars. This provides a central location for any customizations we need to do to the compiled templates from htmlbars-compiler. Things like `isTop` and `isMethod` being set for example. These are obviously, Ember concerns (neither thing really makes sense in HTMLBars). The node...
packages/ember-htmlbars/tests/helpers/template_test.js
@@ -6,7 +6,7 @@ var trim = jQuery.trim; import Container from "ember-runtime/system/container"; import EmberHandlebars from "ember-handlebars-compiler"; -import { compile as htmlbarsCompile } from "htmlbars-compiler/compiler"; +import htmlbarsCompile from "ember-htmlbars/system/compile"; var MyApp, lookup, view,...
true
Other
emberjs
ember.js
7ffbd9ca809bb33bc10f358589439b6c10073042.json
Add template & compile functions for HTMLBars. This provides a central location for any customizations we need to do to the compiled templates from htmlbars-compiler. Things like `isTop` and `isMethod` being set for example. These are obviously, Ember concerns (neither thing really makes sense in HTMLBars). The node...
packages/ember-htmlbars/tests/helpers/view_test.js
@@ -4,7 +4,7 @@ import Container from 'container/container'; import run from "ember-metal/run_loop"; import jQuery from "ember-views/system/jquery"; import EmberHandlebars from "ember-handlebars"; -import { compile as htmlbarsCompile } from "htmlbars-compiler/compiler"; +import htmlbarsCompile from "ember-htmlbars/s...
true
Other
emberjs
ember.js
7ffbd9ca809bb33bc10f358589439b6c10073042.json
Add template & compile functions for HTMLBars. This provides a central location for any customizations we need to do to the compiled templates from htmlbars-compiler. Things like `isTop` and `isMethod` being set for example. These are obviously, Ember concerns (neither thing really makes sense in HTMLBars). The node...
packages/ember-htmlbars/tests/helpers/with_test.js
@@ -9,7 +9,7 @@ import ObjectController from "ember-runtime/controllers/object_controller"; import Container from "ember-runtime/system/container"; // import { A } from "ember-runtime/system/native_array"; import EmberHandlebars from "ember-handlebars"; -import { compile as htmlbarsCompile } from "htmlbars-compiler/...
true
Other
emberjs
ember.js
7ffbd9ca809bb33bc10f358589439b6c10073042.json
Add template & compile functions for HTMLBars. This provides a central location for any customizations we need to do to the compiled templates from htmlbars-compiler. Things like `isTop` and `isMethod` being set for example. These are obviously, Ember concerns (neither thing really makes sense in HTMLBars). The node...
packages/ember-htmlbars/tests/helpers/yield_test.js
@@ -14,7 +14,7 @@ import { } from "ember-htmlbars/helpers"; import EmberHandlebars from "ember-handlebars"; -import { compile as htmlbarsCompile } from "htmlbars-compiler/compiler"; +import htmlbarsCompile from "ember-htmlbars/system/compile"; var compile, helper; if (Ember.FEATURES.isEnabled('ember-htmlbars'))...
true
Other
emberjs
ember.js
7ffbd9ca809bb33bc10f358589439b6c10073042.json
Add template & compile functions for HTMLBars. This provides a central location for any customizations we need to do to the compiled templates from htmlbars-compiler. Things like `isTop` and `isMethod` being set for example. These are obviously, Ember concerns (neither thing really makes sense in HTMLBars). The node...
packages/ember-htmlbars/tests/system/compile_test.js
@@ -0,0 +1,28 @@ +import compile from "ember-htmlbars/system/compile"; +import { + compile as htmlbarsCompile +} from "htmlbars-compiler/compiler"; + +if (Ember.FEATURES.isEnabled('ember-htmlbars')) { + +QUnit.module('ember-htmlbars: compile'); + +test('compiles the provided template with htmlbars', function() { + va...
true
Other
emberjs
ember.js
7ffbd9ca809bb33bc10f358589439b6c10073042.json
Add template & compile functions for HTMLBars. This provides a central location for any customizations we need to do to the compiled templates from htmlbars-compiler. Things like `isTop` and `isMethod` being set for example. These are obviously, Ember concerns (neither thing really makes sense in HTMLBars). The node...
packages/ember-htmlbars/tests/system/template_test.js
@@ -0,0 +1,23 @@ +import template from "ember-htmlbars/system/template"; + +if (Ember.FEATURES.isEnabled('ember-htmlbars')) { + +QUnit.module('ember-htmlbars: template'); + +test('sets `isTop` on the provided function', function() { + function test() { } + + template(test); + + equal(test.isTop, true, 'sets isTop on...
true
Other
emberjs
ember.js
09e137582b7dcd550c350011478aaf0152e87678.json
Remove old debugStatements.
features.json
@@ -20,15 +20,10 @@ }, "debugStatements": [ "Ember.warn", - "emberWarn", "Ember.assert", - "emberAssert", "Ember.deprecate", - "emberDeprecate", "Ember.debug", - "emberDebug", "Ember.Logger.info", - "Ember.runInDebug", - "runInDebug" + "Ember.runInDebug" ] }
true
Other
emberjs
ember.js
09e137582b7dcd550c350011478aaf0152e87678.json
Remove old debugStatements.
packages/ember-handlebars-compiler/lib/main.js
@@ -10,7 +10,7 @@ @submodule ember-handlebars-compiler */ -import Ember from "ember-metal/core"; +import Ember from "ember-metal/core"; // Ember.assert // ES6Todo: you'll need to import debugger once debugger is es6'd. if (typeof Ember.assert === 'undefined') { Ember.assert = function(){}; } @@ -25,8 +25,6 @@...
true
Other
emberjs
ember.js
09e137582b7dcd550c350011478aaf0152e87678.json
Remove old debugStatements.
packages/ember-handlebars/lib/controls.js
@@ -3,7 +3,6 @@ import TextField from "ember-handlebars/controls/text_field"; import TextArea from "ember-handlebars/controls/text_area"; import Ember from "ember-metal/core"; // Ember.assert -// var emberAssert = Ember.assert; import EmberHandlebars from "ember-handlebars-compiler";
true
Other
emberjs
ember.js
09e137582b7dcd550c350011478aaf0152e87678.json
Remove old debugStatements.
packages/ember-handlebars/lib/ext.js
@@ -1,5 +1,4 @@ import Ember from "ember-metal/core"; // Ember.FEATURES, Ember.assert, Ember.Handlebars, Ember.lookup -// var emberAssert = Ember.assert; import { fmt } from "ember-runtime/system/string";
true
Other
emberjs
ember.js
09e137582b7dcd550c350011478aaf0152e87678.json
Remove old debugStatements.
packages/ember-handlebars/lib/helpers/collection.js
@@ -4,10 +4,6 @@ */ import Ember from "ember-metal/core"; // Ember.assert, Ember.deprecate - -// var emberAssert = Ember.assert; - // emberDeprecate = Ember.deprecate; - import EmberHandlebars from "ember-handlebars-compiler"; import { IS_BINDING } from "ember-metal/mixin";
true
Other
emberjs
ember.js
09e137582b7dcd550c350011478aaf0152e87678.json
Remove old debugStatements.
packages/ember-handlebars/lib/helpers/partial.js
@@ -1,5 +1,4 @@ import Ember from "ember-metal/core"; // Ember.assert -// var emberAssert = Ember.assert; import isNone from 'ember-metal/is_none'; import { bind } from "ember-handlebars/helpers/binding";
true
Other
emberjs
ember.js
09e137582b7dcd550c350011478aaf0152e87678.json
Remove old debugStatements.
packages/ember-handlebars/lib/helpers/view.js
@@ -4,7 +4,6 @@ */ import Ember from "ember-metal/core"; // Ember.warn, Ember.assert -// var emberWarn = Ember.warn, emberAssert = Ember.assert; import EmberObject from "ember-runtime/system/object"; import { get } from "ember-metal/property_get";
true
Other
emberjs
ember.js
09e137582b7dcd550c350011478aaf0152e87678.json
Remove old debugStatements.
packages/ember-handlebars/lib/helpers/yield.js
@@ -3,8 +3,7 @@ @submodule ember-handlebars */ -import Ember from "ember-metal/core"; -// var emberAssert = Ember.assert; +import Ember from "ember-metal/core"; // Ember.assert import { get } from "ember-metal/property_get";
true
Other
emberjs
ember.js
09e137582b7dcd550c350011478aaf0152e87678.json
Remove old debugStatements.
packages/ember-htmlbars/lib/helpers/view.js
@@ -4,7 +4,6 @@ */ import Ember from "ember-metal/core"; // Ember.warn, Ember.assert -// var emberWarn = Ember.warn, emberAssert = Ember.assert; import EmberObject from "ember-runtime/system/object"; import { get } from "ember-metal/property_get";
true
Other
emberjs
ember.js
09e137582b7dcd550c350011478aaf0152e87678.json
Remove old debugStatements.
packages/ember-htmlbars/lib/helpers/yield.js
@@ -4,7 +4,6 @@ */ import Ember from "ember-metal/core"; -// var emberAssert = Ember.assert; import { get } from "ember-metal/property_get";
true
Other
emberjs
ember.js
22f33c845bd8c651aac06d7ad663d097fe1a412c.json
Fix version constraint in composer.json
config/package_manager_files/composer.json
@@ -4,7 +4,7 @@ "type": "component", "license": "MIT", "require": { - "components/jquery": ">=1.7.0 <= 2.1.0", + "components/jquery": ">=1.7.0, <= 2.1.0", "components/handlebars.js": "2.*" }, "extra": {
false
Other
emberjs
ember.js
f3245cb111a495c413e0f346e0af3fcc754a7674.json
Add {{debugger}} helper.
packages/ember-htmlbars/lib/helpers/debugger.js
@@ -0,0 +1,51 @@ +/*jshint debug:true*/ + +/** +@module ember +@submodule ember-handlebars +*/ +import Logger from "ember-metal/logger"; + +/** + Execute the `debugger` statement in the current context. + + ```handlebars + {{debugger}} + ``` + + Before invoking the `debugger` statement, there + are a few helpful ...
true
Other
emberjs
ember.js
f3245cb111a495c413e0f346e0af3fcc754a7674.json
Add {{debugger}} helper.
packages/ember-htmlbars/lib/main.js
@@ -10,6 +10,7 @@ import { viewHelper } from "ember-htmlbars/helpers/view"; import { yieldHelper } from "ember-htmlbars/helpers/yield"; import { withHelper } from "ember-htmlbars/helpers/with"; import { logHelper } from "ember-htmlbars/helpers/log"; +import { debuggerHelper } from "ember-htmlbars/helpers/debugger"; ...
true
Other
emberjs
ember.js
5abb7216a4de440e744623bf19d0ca2a391e72f7.json
Add {{log}} helper to HTMLBars.
packages/ember-htmlbars/lib/helpers/log.js
@@ -0,0 +1,33 @@ +/** +@module ember +@submodule ember-handlebars +*/ +import Logger from "ember-metal/logger"; + +/** + `log` allows you to output the value of variables in the current rendering + context. `log` also accepts primitive types such as strings or numbers. + + ```handlebars + {{log "myVariable:" myVari...
true
Other
emberjs
ember.js
5abb7216a4de440e744623bf19d0ca2a391e72f7.json
Add {{log}} helper to HTMLBars.
packages/ember-htmlbars/lib/main.js
@@ -9,6 +9,7 @@ import { bindHelper } from "ember-htmlbars/helpers/binding"; import { viewHelper } from "ember-htmlbars/helpers/view"; import { yieldHelper } from "ember-htmlbars/helpers/yield"; import { withHelper } from "ember-htmlbars/helpers/with"; +import { logHelper } from "ember-htmlbars/helpers/log"; import...
true
Other
emberjs
ember.js
5abb7216a4de440e744623bf19d0ca2a391e72f7.json
Add {{log}} helper to HTMLBars.
packages/ember-htmlbars/tests/helpers/debug_test.js
@@ -4,6 +4,14 @@ import run from "ember-metal/run_loop"; import EmberView from "ember-views/views/view"; import EmberHandlebars from "ember-handlebars-compiler"; import { logHelper } from "ember-handlebars/helpers/debug"; +import { compile as htmlbarsCompile } from "htmlbars-compiler/compiler"; + +var compile; +if (...
true
Other
emberjs
ember.js
d8b99791ab6c32d6cc864812fa88a1efddf39510.json
Fix typo in test name
packages/ember-metal/tests/computed_test.js
@@ -388,7 +388,7 @@ testBoth('circular keys should not blow up', function(get, set) { equal(get(obj, 'foo'), 'foo 3', 'cached retrieve'); }); -testBoth('redefining a property should undo old depenent keys', function(get ,set) { +testBoth('redefining a property should undo old dependent keys', function(get ,set) {...
false
Other
emberjs
ember.js
8fc24566fdc7c4a94d5b6a3991262200b98b09c4.json
Move WithView to ember-views
packages/ember-handlebars/lib/helpers/with.js
@@ -5,58 +5,10 @@ import Ember from "ember-metal/core"; // Ember.assert -import { set } from "ember-metal/property_set"; -import { apply } from "ember-metal/utils"; import { create as o_create } from "ember-metal/platform"; import isNone from 'ember-metal/is_none'; import { bind } from "ember-handlebars/helpers...
true
Other
emberjs
ember.js
8fc24566fdc7c4a94d5b6a3991262200b98b09c4.json
Move WithView to ember-views
packages/ember-htmlbars/lib/helpers/with.js
@@ -5,58 +5,10 @@ import Ember from "ember-metal/core"; // Ember.assert -import { set } from "ember-metal/property_set"; -import { apply } from "ember-metal/utils"; import { create as o_create } from "ember-metal/platform"; import isNone from 'ember-metal/is_none'; import { bind } from "ember-htmlbars/helpers/b...
true
Other
emberjs
ember.js
8fc24566fdc7c4a94d5b6a3991262200b98b09c4.json
Move WithView to ember-views
packages/ember-views/lib/views/with_view.js
@@ -0,0 +1,51 @@ + +/** +@module ember +@submodule ember-views +*/ + +import { set } from "ember-metal/property_set"; +import { apply } from "ember-metal/utils"; +import { _HandlebarsBoundView } from "ember-handlebars/views/handlebars_bound_view"; + +export default _HandlebarsBoundView.extend({ + init: function() { + ...
true
Other
emberjs
ember.js
9f32ac807b0e32f242d8960df80dadc77f65ab96.json
Restore apply as a fallback
packages/ember-metal/lib/logger.js
@@ -19,6 +19,12 @@ function consoleMethod(name) { logToConsole = method.bind(consoleObj); logToConsole.displayName = 'console.' + name; return logToConsole; + } else if (typeof method.apply === 'function') { + logToConsole = function() { + method.apply(consoleObj, arguments); + ...
false
Other
emberjs
ember.js
cbf58a8292254ec75d430986868e695b0028934c.json
Publish test index.html for easier testing from S3.
Brocfile.js
@@ -249,6 +249,45 @@ testConfig = replace(testConfig, { ] }); +var s3TestRunner = pickFiles(testConfig, { + srcDir: '/tests', + destDir: '/ember-tests', + files: ['index.html'] +}); + +s3TestRunner = replace(s3TestRunner, { + files: ['ember-tests/index.html'], + patterns: [ + { match: new RegExp('../ember...
true
Other
emberjs
ember.js
cbf58a8292254ec75d430986868e695b0028934c.json
Publish test index.html for easier testing from S3.
config/s3ProjectConfig.js
@@ -1,12 +1,13 @@ fileMap = function(revision,tag,date) { return { "ember.js": fileObject("ember", ".js", "text/javascript", revision, tag, date), - "ember-tests.js": fileObject("ember-test", ".js", "text/javascript", revision, tag, date), +...
true
Other
emberjs
ember.js
8a895e1b9559dfd846bdeb332dea12cb8279aa87.json
Use bind instead of apply in logger
packages/ember-metal/lib/logger.js
@@ -14,11 +14,9 @@ function consoleMethod(name) { var method = typeof consoleObj === 'object' ? consoleObj[name] : null; if (method) { - // Older IE doesn't support apply, but Chrome needs it - if (typeof method.apply === 'function') { - logToConsole = function() { - method.apply(consoleObj, a...
false
Other
emberjs
ember.js
880d7f3a47fb29902eae5f32258a081421a639c0.json
Serve documentation live from /docs endpont
Brocfile.js
@@ -18,6 +18,7 @@ var useStrictRemover = require('broccoli-use-strict-remover'); var derequire = require('broccoli-derequire'); var getVersion = require('git-repo-version'); +var yuidocPlugin = require('ember-cli-yuidoc'); // To create fast production builds (without ES3 support, minification, derequire, or JSHi...
true
Other
emberjs
ember.js
880d7f3a47fb29902eae5f32258a081421a639c0.json
Serve documentation live from /docs endpont
package.json
@@ -35,7 +35,7 @@ "chalk": "~0.4.0", "defeatureify": "~0.2.0", "ember-cli": "0.0.46", - "ember-cli-yuidoc": "0.1.1", + "ember-cli-yuidoc": "0.3.1", "ember-publisher": "0.0.6", "es6-module-transpiler": "~0.4.0", "express": "^4.5.0",
true
Other
emberjs
ember.js
1a14916e45c69dac52773db36ec880ba129394a7.json
Add 1.8.1 to CHANGELOG.
CHANGELOG.md
@@ -4,6 +4,15 @@ * [BREAKING] Require Handlebars 2.0. See [blog post](http://emberjs.com/blog/2014/10/16/handlebars-update.html) for details. +### Ember 1.8.1 (November, 4, 2014) + +* [BUGFIX] Make sure that `{{view}}` can accept a Ember.View instance. +* [BUGFIX] Throw an assertion if `classNameBindings` are spec...
false
Other
emberjs
ember.js
322fc0e371a6df88c1c29d80db8cb545be5315a8.json
Allow all rejection types. In `RSVP.onerrorDefault` we only handled `instanceof Error`, but we really only care about ignoring `TransitionAborted` (because that is the only acceptable rejection).
packages/ember-runtime/lib/ext/rsvp.js
@@ -42,7 +42,7 @@ RSVP.Promise.prototype.fail = function(callback, label){ }; RSVP.onerrorDefault = function (error) { - if (error instanceof Error) { + if (error && error.name !== 'TransitionAborted') { if (Ember.testing) { // ES6TODO: remove when possible if (!Test && Ember.__loader.registry[...
true
Other
emberjs
ember.js
322fc0e371a6df88c1c29d80db8cb545be5315a8.json
Allow all rejection types. In `RSVP.onerrorDefault` we only handled `instanceof Error`, but we really only care about ignoring `TransitionAborted` (because that is the only acceptable rejection).
packages/ember-runtime/tests/ext/rsvp_test.js
@@ -108,3 +108,12 @@ test("given `Ember.testing = true`, correctly informs the test suite about async equal(asyncEnded, 2); }); }); + +test('TransitionAborted errors are not re-thrown', function() { + expect(1); + var fakeTransitionAbort = { name: 'TransitionAborted' }; + + run(RSVP, 'reject', fakeTransitio...
true
Other
emberjs
ember.js
322fc0e371a6df88c1c29d80db8cb545be5315a8.json
Allow all rejection types. In `RSVP.onerrorDefault` we only handled `instanceof Error`, but we really only care about ignoring `TransitionAborted` (because that is the only acceptable rejection).
packages/ember-runtime/tests/mixins/promise_proxy_test.js
@@ -244,15 +244,20 @@ test("should have content when isFulfilled is set", function() { }); test("should have reason when isRejected is set", function() { + var error = new Error('Y U REJECT?!?'); var deferred = EmberRSVP.defer(); var proxy = ObjectPromiseProxy.create({ promise: deferred.promise });...
true
Other
emberjs
ember.js
cdfc3519d0e4be30ee6e5ef40aaa078f26f2f603.json
Fix old comments
packages/ember-runtime/tests/system/object/reopen_test.js
@@ -30,8 +30,7 @@ test('reopened properties inherited by subclasses', function() { equal(get(new SubSub(), 'bar'), 'BAR', 'Adds property'); }); -// We plan to allow this in the future -test('does not allow reopening already instantiated classes', function() { +test('allows reopening already instantiated classes',...
false
Other
emberjs
ember.js
f4f2699bf732033747eeaa16f39ec85d619b32fe.json
Fix old comments
packages/ember-routing-handlebars/tests/helpers/action_test.js
@@ -1,4 +1,4 @@ -import Ember from 'ember-metal/core'; // A, FEATURES, assert, TESTING_DEPRECATION +import Ember from 'ember-metal/core'; // A, FEATURES, assert import { set } from "ember-metal/property_set"; import run from "ember-metal/run_loop"; import EventDispatcher from "ember-views/system/event_dispatcher";
true
Other
emberjs
ember.js
f4f2699bf732033747eeaa16f39ec85d619b32fe.json
Fix old comments
packages/ember-views/tests/system/event_dispatcher_test.js
@@ -1,4 +1,4 @@ -import Ember from 'ember-metal/core'; // A, FEATURES, assert, TESTING_DEPRECATION +import Ember from 'ember-metal/core'; // A, FEATURES, assert import { get } from "ember-metal/property_get"; import run from "ember-metal/run_loop";
true
Other
emberjs
ember.js
3d4e0e3474d1a4a42988032cae68b228a1ee1452.json
Add test for errors thrown in andThen.
packages/ember-testing/tests/acceptance_test.js
@@ -262,6 +262,22 @@ test("Unhandled exceptions are logged via Ember.Test.adapter#exception", functio asyncHandled = click(".does-not-exist"); }); +test("Unhandled exceptions in `andThen` are logged via Ember.Test.adapter#exception", function () { + expect(1); + + Test.adapter = QUnitAdapter.create({ + excep...
false
Other
emberjs
ember.js
a6b9d76ee4acf0cb23107af3fb7d2edbb73e8154.json
Fix path of data.json
config/s3ProjectConfig.js
@@ -6,7 +6,7 @@ fileMap = function(revision,tag,date) { "ember-runtime.js": fileObject("ember-runtime", ".js", "text/javascript", revision, tag, date), "ember.min.js": fileObject("ember.min", ".js", "text/javascript", revision, tag, date), "ember.prod...
false
Other
emberjs
ember.js
b98b1ff7084c051fad8a2c03b504dbd6c644940e.json
Remove Ember.empty and Ember.none. These have been deprecated since before 1.0.0, and serve no purpose now.
packages/ember-handlebars/lib/helpers/partial.js
@@ -1,7 +1,7 @@ import Ember from "ember-metal/core"; // Ember.assert // var emberAssert = Ember.assert; -import { isNone } from 'ember-metal/is_none'; +import isNone from 'ember-metal/is_none'; import { bind } from "ember-handlebars/helpers/binding"; /**
true
Other
emberjs
ember.js
b98b1ff7084c051fad8a2c03b504dbd6c644940e.json
Remove Ember.empty and Ember.none. These have been deprecated since before 1.0.0, and serve no purpose now.
packages/ember-metal/lib/computed.js
@@ -1,4 +1,3 @@ -import Ember from "ember-metal/core"; import { set } from "ember-metal/property_set"; import { meta,
true
Other
emberjs
ember.js
b98b1ff7084c051fad8a2c03b504dbd6c644940e.json
Remove Ember.empty and Ember.none. These have been deprecated since before 1.0.0, and serve no purpose now.
packages/ember-metal/lib/computed_macros.js
@@ -3,7 +3,7 @@ import { get } from "ember-metal/property_get"; import { set } from "ember-metal/property_set"; import { computed } from "ember-metal/computed"; import isEmpty from 'ember-metal/is_empty'; -import { isNone } from 'ember-metal/is_none'; +import isNone from 'ember-metal/is_none'; import alias from 'em...
true
Other
emberjs
ember.js
b98b1ff7084c051fad8a2c03b504dbd6c644940e.json
Remove Ember.empty and Ember.none. These have been deprecated since before 1.0.0, and serve no purpose now.
packages/ember-metal/lib/is_empty.js
@@ -1,4 +1,3 @@ -import Ember from 'ember-metal/core'; // deprecateFunc import { get } from 'ember-metal/property_get'; import isNone from 'ember-metal/is_none'; @@ -57,10 +56,4 @@ function isEmpty(obj) { return false; } -var empty = Ember.deprecateFunc("Ember.empty is deprecated. Please use Ember.isEmpty ins...
true
Other
emberjs
ember.js
b98b1ff7084c051fad8a2c03b504dbd6c644940e.json
Remove Ember.empty and Ember.none. These have been deprecated since before 1.0.0, and serve no purpose now.
packages/ember-metal/lib/is_none.js
@@ -1,5 +1,3 @@ -import Ember from 'ember-metal/core'; // deprecateFunc - /** Returns true if the passed value is null or undefined. This avoids errors from JSLint complaining about use of ==, which can be technically @@ -23,7 +21,4 @@ function isNone(obj) { return obj === null || obj === undefined; } -exp...
true
Other
emberjs
ember.js
b98b1ff7084c051fad8a2c03b504dbd6c644940e.json
Remove Ember.empty and Ember.none. These have been deprecated since before 1.0.0, and serve no purpose now.
packages/ember-metal/lib/main.js
@@ -161,14 +161,8 @@ import { } from "ember-metal/binding"; import run from "ember-metal/run_loop"; import libraries from "ember-metal/libraries"; -import { - isNone, - none -} from 'ember-metal/is_none'; -import { - isEmpty, - empty -} from 'ember-metal/is_empty'; +import isNone from 'ember-metal/is_none'; +imp...
true
Other
emberjs
ember.js
b98b1ff7084c051fad8a2c03b504dbd6c644940e.json
Remove Ember.empty and Ember.none. These have been deprecated since before 1.0.0, and serve no purpose now.
packages/ember-routing/lib/system/route.js
@@ -7,7 +7,7 @@ import { forEach, replace }from "ember-metal/enumerable_utils"; -import { isNone } from "ember-metal/is_none"; +import isNone from "ember-metal/is_none"; import { computed } from "ember-metal/computed"; import merge from "ember-metal/merge"; import {
true
Other
emberjs
ember.js
b98b1ff7084c051fad8a2c03b504dbd6c644940e.json
Remove Ember.empty and Ember.none. These have been deprecated since before 1.0.0, and serve no purpose now.
packages/ember-runtime/lib/mixins/array.js
@@ -13,9 +13,7 @@ import { computed, cacheFor } from 'ember-metal/computed'; -import { - isNone -} from 'ember-metal/is_none'; +import isNone from 'ember-metal/is_none'; import Enumerable from 'ember-runtime/mixins/enumerable'; import { map } from 'ember-metal/enumerable_utils'; import {
true
Other
emberjs
ember.js
b98b1ff7084c051fad8a2c03b504dbd6c644940e.json
Remove Ember.empty and Ember.none. These have been deprecated since before 1.0.0, and serve no purpose now.
packages/ember-runtime/lib/mixins/observable.js
@@ -27,7 +27,7 @@ import { observersFor } from "ember-metal/observer"; import { cacheFor } from "ember-metal/computed"; -import { isNone } from "ember-metal/is_none"; +import isNone from "ember-metal/is_none"; var slice = Array.prototype.slice;
true
Other
emberjs
ember.js
b98b1ff7084c051fad8a2c03b504dbd6c644940e.json
Remove Ember.empty and Ember.none. These have been deprecated since before 1.0.0, and serve no purpose now.
packages/ember-runtime/lib/system/set.js
@@ -7,7 +7,7 @@ import Ember from "ember-metal/core"; // Ember.isNone, Ember.A import { get } from "ember-metal/property_get"; import { set } from "ember-metal/property_set"; import { guidFor } from "ember-metal/utils"; -import { isNone } from 'ember-metal/is_none'; +import isNone from 'ember-metal/is_none'; import...
true
Other
emberjs
ember.js
b98b1ff7084c051fad8a2c03b504dbd6c644940e.json
Remove Ember.empty and Ember.none. These have been deprecated since before 1.0.0, and serve no purpose now.
packages/ember-runtime/tests/core/is_empty_test.js
@@ -1,5 +1,5 @@ import Ember from "ember-metal/core"; -import {isEmpty} from 'ember-metal/is_empty'; +import isEmpty from 'ember-metal/is_empty'; import ArrayProxy from "ember-runtime/system/array_proxy"; QUnit.module("Ember.isEmpty");
true
Other
emberjs
ember.js
b98b1ff7084c051fad8a2c03b504dbd6c644940e.json
Remove Ember.empty and Ember.none. These have been deprecated since before 1.0.0, and serve no purpose now.
packages/ember-runtime/tests/legacy_1x/system/set_test.js
@@ -1,5 +1,5 @@ import Ember from "ember-metal/core"; -import { isNone } from 'ember-metal/is_none'; +import isNone from 'ember-metal/is_none'; import Set from "ember-runtime/system/set"; import EmberObject from 'ember-runtime/system/object'; import EmberArray from "ember-runtime/mixins/array";
true
Other
emberjs
ember.js
b98b1ff7084c051fad8a2c03b504dbd6c644940e.json
Remove Ember.empty and Ember.none. These have been deprecated since before 1.0.0, and serve no purpose now.
packages/ember-views/lib/system/event_dispatcher.js
@@ -6,7 +6,7 @@ import Ember from "ember-metal/core"; // Ember.assert import { get } from "ember-metal/property_get"; import { set } from "ember-metal/property_set"; -import { isNone } from 'ember-metal/is_none'; +import isNone from 'ember-metal/is_none'; import run from "ember-metal/run_loop"; import { typeOf } ...
true
Other
emberjs
ember.js
b98b1ff7084c051fad8a2c03b504dbd6c644940e.json
Remove Ember.empty and Ember.none. These have been deprecated since before 1.0.0, and serve no purpose now.
packages/ember-views/lib/views/component.js
@@ -6,7 +6,7 @@ import View from "ember-views/views/view"; import { get } from "ember-metal/property_get"; import { set } from "ember-metal/property_set"; -import { isNone } from 'ember-metal/is_none'; +import isNone from 'ember-metal/is_none'; import { computed } from "ember-metal/computed";
true
Other
emberjs
ember.js
b98b1ff7084c051fad8a2c03b504dbd6c644940e.json
Remove Ember.empty and Ember.none. These have been deprecated since before 1.0.0, and serve no purpose now.
packages/ember-views/lib/views/view.js
@@ -26,7 +26,7 @@ import { typeOf, isArray } from "ember-metal/utils"; -import { isNone } from 'ember-metal/is_none'; +import isNone from 'ember-metal/is_none'; import { Mixin } from 'ember-metal/mixin'; import { deprecateProperty } from "ember-metal/deprecate_property"; import { A as emberA } from "ember-run...
true
Other
emberjs
ember.js
6db588073bbe1997480f6740f081b8b81cafbcd0.json
Add better labels to tests, reorder
packages/ember-runtime/tests/core/compare_test.js
@@ -57,11 +57,11 @@ test('comparables should return values in the range of -1, 0, 1', function() { var zero = Comp.create({ val: 0 }); var one = Comp.create({ val: 1 }); - equal(compare('a', negOne), 1, 'Second item comparable - Should return valid range -1, 0, 1'); - equal(compare('b', zero), 0, 'Second item...
false
Other
emberjs
ember.js
ca94affbe1c3bc45583c04167a20e9328580c215.json
Fix publishing of canary builds.
config/s3ProjectConfig.js
@@ -6,7 +6,7 @@ fileMap = function(revision,tag,date) { "ember-runtime.js": fileObject("ember-runtime", ".js", "text/javascript", revision, tag, date), "ember.min.js": fileObject("ember.min", ".js", "text/javascript", revision, tag, date), "ember.prod...
false
Other
emberjs
ember.js
61ef73d2e922fa3a053aee77f3b3172c8e9aa5d2.json
Fix jQuery dependency in component.json The jQuery dependency in component.json is pointing at the wrong repository. This causes component and duo to fail when they try to install `components/ember`. Changing the dependency from `component/jquery` to `components/jquery` fixes the problem.
config/package_manager_files/component.json
@@ -7,7 +7,7 @@ "ember.js" ], "dependencies": { - "component/jquery": ">= 1.7.0 <= 2.1.0", + "components/jquery": ">= 1.7.0 <= 2.1.0", "components/handlebars.js": ">= 2.0.0 < 3.0.0" } }
false
Other
emberjs
ember.js
89da7c29a1a46c9fd31b1c68f44ad77310139d20.json
Add API to get a view's client rects
packages/ember-views/lib/main.js
@@ -11,7 +11,9 @@ Ember Views import Ember from "ember-runtime"; import jQuery from "ember-views/system/jquery"; import { - isSimpleClick + isSimpleClick, + getViewClientRects, + getViewBoundingClientRect } from "ember-views/system/utils"; import RenderBuffer from "ember-views/system/render_buffer"; import "e...
true
Other
emberjs
ember.js
89da7c29a1a46c9fd31b1c68f44ad77310139d20.json
Add API to get a view's client rects
packages/ember-views/lib/system/utils.js
@@ -9,3 +9,47 @@ export function isSimpleClick(event) { return !modifier && !secondaryClick; } + +/** + @private + @method getViewRange + @param {Ember.View} view +*/ +function getViewRange(view) { + var range = document.createRange(); + range.setStartAfter(view._morph.start); + range.setEndBefore(view._mor...
true
Other
emberjs
ember.js
89da7c29a1a46c9fd31b1c68f44ad77310139d20.json
Add API to get a view's client rects
packages/ember-views/tests/system/view_utils_test.js
@@ -0,0 +1,46 @@ +import run from "ember-metal/run_loop"; +import View from "ember-views/views/view"; + +var view; + +QUnit.module("ViewUtils", { + teardown: function() { + run(function() { + if (view) { view.destroy(); } + }); + } +}); + +test("getViewClientRects", function() { + if (!(window.Range && wi...
true
Other
emberjs
ember.js
ee17c71909d030018881877018f86138d54f5c7b.json
Remove outdated model documentation.
packages/ember-routing/lib/system/route.js
@@ -1176,7 +1176,7 @@ var Route = EmberObject.extend(ActionHandler, { }); ``` - The model for the `post` route is `App.Post.find(params.post_id)`. + The model for the `post` route is `store.find('post', params.post_id)`. By default, if your route has a dynamic segment ending in `_id`: @@ -121...
false