language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 49730043e687a1d789d90246e375b0712199a8fe.json | Add 2.7.0-beta.1 to CHANGELOG.
[ci skip] | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### 2.7.0-beta.1 (June 8, 2016)
+
+- [#13424](https://github.com/emberjs/ember.js/pull/13424) [DEPRECATE] Deprecate Ember.Binding. See [the deprecation guide](http://emberjs.com/deprecations/v2.x/#toc_ember-binding) for more details.
+- [#13599](https://github.com/emberjs/ember.js... | false |
Other | emberjs | ember.js | 7b226e94b3fa2ca2bef57ff8720acdd195a38e6a.json | Add 2.6.0 to CHANGELOG.
[ci skip]
(cherry picked from commit df81b93bb14ecbae46fbc14862941d78df036ebe) | CHANGELOG.md | @@ -1,22 +1,18 @@
# Ember Changelog
-### 2.6.0-beta.4 (May 09, 2016)
+### 2.6.0 (June 8, 2016)
+- [#13520](https://github.com/emberjs/ember.js/pull/13520) [BUGFIX] Fixes issues with `baseURL` and `rootURL` in `Ember.HistoryLocation` and ensures that `Ember.NoneLocation` properly handles `rootURL`.
+- [#13590](http... | false |
Other | emberjs | ember.js | dc4b60be5849a6dad2cc464822294a435e08e31c.json | Fix master build failures (#13606) | package.json | @@ -37,7 +37,7 @@
"express": "^4.5.0",
"finalhandler": "^0.4.0",
"github": "^0.2.3",
- "glimmer-engine": "tildeio/glimmer#525e75e",
+ "glimmer-engine": "tildeio/glimmer#bf8213",
"glob": "^5.0.13",
"htmlbars": "0.14.23",
"mocha": "^2.4.5", | false |
Other | emberjs | ember.js | 78cea046e4ca01a068ae5701cd835357584327ff.json | Add lazy evaluation tests (#13596)
In both `{{#if truthy}}...{{else}}{{some-helper}}{{/if}}` and `{{if
truthy ... (some-helper)}}`, `some-helper` should NOT be evaluated.
This is especially important when you are trying to use the `if`
helper to guard for `null`s etc.
They already works in Glimmer. The block for... | packages/ember-glimmer/tests/utils/shared-conditional-tests.js | @@ -605,6 +605,59 @@ export class TogglingHelperConditionalsTest extends TogglingConditionalsTest {
this.assertText('T1');
}
+ ['@glimmer evaluation should be lazy'](assert) {
+ let truthyEvaluated;
+ let falsyEvaluated;
+
+ let withoutEvaluatingTruthy = (callback) => {
+ truthyEvaluated = fals... | false |
Other | emberjs | ember.js | 44a299b5cc777acdaf65a2035a950186bb7a7be2.json | Remove view tests (#13579)
These tests either test a view specific feature, or already have test
coverage in the analogous controller/template feature. | packages/ember/tests/routing/basic_test.js | @@ -321,90 +321,6 @@ QUnit.test('Model passed via renderTemplate model is set as controller\'s model'
equal(jQuery('p:contains(emberjs)', '#qunit-fixture').length, 1, 'Passed model was set as controllers model');
});
-test('Renders correct view with slash notation', function() {
- setTemplate('home/page', compil... | false |
Other | emberjs | ember.js | 370d02598e3543b0062db6c56226a394827a2859.json | Remove obsolete Rakefile | Rakefile | @@ -1,159 +0,0 @@
-require 'bundler/setup'
-require './lib/ember/version'
-require 'zlib'
-require 'fileutils'
-require 'pathname'
-require 'json'
-
-### RELEASE TASKS ###
-
-namespace :release do
-
- def pretend?
- ENV['PRETEND']
- end
-
- task :gem do
- sh 'npm run-script build'
- sh 'gem build ember-sour... | false |
Other | emberjs | ember.js | 0c64d88ba1fb8afcafca38317605fe8e19cda035.json | Fix failure in master.
Due to name change that caused a PR's green status to be a lie. | packages/ember-glimmer/lib/environment.js | @@ -148,7 +148,7 @@ export default class Environment extends GlimmerEnvironment {
if (mappedKey !== key) {
path = path.map((segment) => segment === key ? mappedKey : segment);
}
- let definition = this.getComponentDefinition(path);
+ let definition = this.createCompo... | false |
Other | emberjs | ember.js | 9a72fea4854f1a12dbd81b7779afd77f99331b7e.json | fix import path | packages/ember-glimmer/tests/integration/helpers/closure-action-test.js | @@ -2,7 +2,7 @@ import run from 'ember-metal/run_loop';
import { computed } from 'ember-metal/computed';
import isEnabled from 'ember-metal/features';
import { subscribe, unsubscribe } from 'ember-metal/instrumentation';
-import { INVOKE } from 'ember-routing-htmlbars/keywords/closure-action';
+import { INVOKE } fro... | false |
Other | emberjs | ember.js | 81884e31f9a6007719a42ba71e84cf2c1cce41ef.json | Enforce child outlets to be fragments. (#13521)
Enforce child outlets to be fragments fixes crash when a outlet was filled with a element, and emitted a did-create-element after the args register had already be changed.
Remove unneeded setOutletState rerender workaround.
Add regression test for did-create-elemen... | packages/ember-glimmer/lib/syntax/outlet.js | @@ -179,7 +179,7 @@ class OutletComponentDefinition extends AbstractOutletComponentDefinition {
}
compile(builder) {
- builder.fromLayout(this.template.asLayout());
+ builder.wrapLayout(this.template.asLayout());
}
}
| true |
Other | emberjs | ember.js | 81884e31f9a6007719a42ba71e84cf2c1cce41ef.json | Enforce child outlets to be fragments. (#13521)
Enforce child outlets to be fragments fixes crash when a outlet was filled with a element, and emitted a did-create-element after the args register had already be changed.
Remove unneeded setOutletState rerender workaround.
Add regression test for did-create-elemen... | packages/ember-glimmer/lib/views/outlet.js | @@ -97,7 +97,6 @@ export default class OutletView {
setOutletState(state) {
this.outletState = state;
this._tag.dirty();
- this.rerender(); // FIXME
}
toReference() { | true |
Other | emberjs | ember.js | 81884e31f9a6007719a42ba71e84cf2c1cce41ef.json | Enforce child outlets to be fragments. (#13521)
Enforce child outlets to be fragments fixes crash when a outlet was filled with a element, and emitted a did-create-element after the args register had already be changed.
Remove unneeded setOutletState rerender workaround.
Add regression test for did-create-elemen... | packages/ember-glimmer/tests/integration/application/rendering-test.js | @@ -318,4 +318,15 @@ moduleFor('Application test: rendering', class extends ApplicationTest {
});
}
+ // Regression test, glimmer child outlets tried to assume the first element.
+ // but the if put-args clobbered the args used by did-create-element.
+ // I wish there was a way to assert that the OutletCom... | true |
Other | emberjs | ember.js | aa79ca71fe04776e1c9f4220f49bf35faf38743a.json | Introduce ENGINE_PARENT symbol.
Access to an engine's parent property should be tightly controlled.
Using a symbol allows for access only via `getEngineParent` and
`setEngineParent`. | packages/ember-application/lib/system/engine-parent.js | @@ -0,0 +1,33 @@
+/**
+@module ember
+@submodule ember-application
+*/
+
+import symbol from 'ember-metal/symbol';
+
+export const ENGINE_PARENT = symbol('ENGINE_PARENT');
+
+/**
+ `getEngineParent` retrieves an engine instance's parent instance.
+
+ @method getEngineParent
+ @param {EngineInstance} engine An engine... | true |
Other | emberjs | ember.js | aa79ca71fe04776e1c9f4220f49bf35faf38743a.json | Introduce ENGINE_PARENT symbol.
Access to an engine's parent property should be tightly controlled.
Using a symbol allows for access only via `getEngineParent` and
`setEngineParent`. | packages/ember-application/tests/system/engine_parent_test.js | @@ -0,0 +1,16 @@
+import { getEngineParent, setEngineParent, ENGINE_PARENT } from 'ember-application/system/engine-parent';
+
+QUnit.module('EngineParent', {});
+
+QUnit.test('An engine\'s parent can be set with `setEngineParent` and retrieved with `getEngineParent`', function() {
+ let engine = {};
+ let parent = {}... | true |
Other | emberjs | ember.js | c79eda2425ace1667c9b541ec6a4bcd1e8ef2fd5.json | Fix tests on master (#13511) | packages/ember-application/tests/system/engine_initializers_test.js | @@ -319,12 +319,12 @@ QUnit.test('initializers are per-engine', function() {
initialize(engine) {}
});
- throws(function() {
+ expectAssertion(function() {
FirstEngine.initializer({
name: 'abc',
initialize(engine) {}
});
- }, Error, /Assertion Failed: The initializer 'abc' has alrea... | true |
Other | emberjs | ember.js | c79eda2425ace1667c9b541ec6a4bcd1e8ef2fd5.json | Fix tests on master (#13511) | packages/ember-application/tests/system/engine_instance_initializers_test.js | @@ -341,12 +341,12 @@ QUnit.test('initializers are per-engine', function() {
initialize(engine) {}
});
- throws(function() {
+ expectAssertion(function() {
FirstEngine.instanceInitializer({
name: 'abc',
initialize(engine) {}
});
- }, Error, /Assertion Failed: The instance initialize... | true |
Other | emberjs | ember.js | c79eda2425ace1667c9b541ec6a4bcd1e8ef2fd5.json | Fix tests on master (#13511) | packages/ember-application/tests/system/initializers_test.js | @@ -358,12 +358,12 @@ QUnit.test('initializers are per-app', function() {
initialize(app) {}
});
- throws(function() {
+ expectAssertion(function() {
FirstApp.initializer({
name: 'abc',
initialize(app) {}
});
- }, Error, /Assertion Failed: The initializer 'abc' has already been regi... | true |
Other | emberjs | ember.js | c79eda2425ace1667c9b541ec6a4bcd1e8ef2fd5.json | Fix tests on master (#13511) | packages/ember-application/tests/system/instance_initializers_test.js | @@ -327,12 +327,12 @@ QUnit.test('initializers are per-app', function() {
initialize(app) {}
});
- throws(function() {
+ expectAssertion(function() {
FirstApp.instanceInitializer({
name: 'abc',
initialize(app) {}
});
- }, Error, /Assertion Failed: The instance initializer 'abc' has ... | true |
Other | emberjs | ember.js | 9471527454b30b9a892d6d40f21735365b5a2897.json | Reorganize metal to support 2WB in Glimmer
This commit restructures some of the more arcane parts of ember-metal's
observer system.
It eliminates some special casing around `length`, which isn't necessary
anymore but complicates the overall abstraction of observable
properties.
Relatedly, it also finishes implementi... | packages/ember-glimmer/lib/component.js | @@ -7,9 +7,14 @@ import AriaRoleSupport from 'ember-views/mixins/aria_role_support';
import ViewMixin from 'ember-views/mixins/view_support';
import EmberView from 'ember-views/views/view';
import symbol from 'ember-metal/symbol';
+import { get } from 'ember-metal/property_get';
+import { PROPERTY_DID_CHANGE } from ... | true |
Other | emberjs | ember.js | 9471527454b30b9a892d6d40f21735365b5a2897.json | Reorganize metal to support 2WB in Glimmer
This commit restructures some of the more arcane parts of ember-metal's
observer system.
It eliminates some special casing around `length`, which isn't necessary
anymore but complicates the overall abstraction of observable
properties.
Relatedly, it also finishes implementi... | packages/ember-glimmer/lib/syntax/curly-component.js | @@ -1,7 +1,10 @@
import { StatementSyntax, ValueReference } from 'glimmer-runtime';
import { AttributeBindingReference, RootReference, applyClassNameBinding } from '../utils/references';
-import { DIRTY_TAG } from '../component';
+import { DIRTY_TAG, IS_DISPATCHING_ATTRS } from '../component';
import { assert } from... | true |
Other | emberjs | ember.js | 9471527454b30b9a892d6d40f21735365b5a2897.json | Reorganize metal to support 2WB in Glimmer
This commit restructures some of the more arcane parts of ember-metal's
observer system.
It eliminates some special casing around `length`, which isn't necessary
anymore but complicates the overall abstraction of observable
properties.
Relatedly, it also finishes implementi... | packages/ember-glimmer/lib/utils/process-args.js | @@ -1,6 +1,7 @@
import { CONSTANT_TAG } from 'glimmer-reference';
import { assert } from 'ember-metal/debug';
import EmptyObject from 'ember-metal/empty_object';
+import { ARGS } from '../component';
export default function processArgs(args, positionalParamsDefinition) {
if (!positionalParamsDefinition || posi... | true |
Other | emberjs | ember.js | 9471527454b30b9a892d6d40f21735365b5a2897.json | Reorganize metal to support 2WB in Glimmer
This commit restructures some of the more arcane parts of ember-metal's
observer system.
It eliminates some special casing around `length`, which isn't necessary
anymore but complicates the overall abstraction of observable
properties.
Relatedly, it also finishes implementi... | packages/ember-glimmer/lib/utils/references.js | @@ -1,11 +1,15 @@
import { get } from 'ember-metal/property_get';
+import { set } from 'ember-metal/property_set';
import { tagFor } from 'ember-metal/tags';
+import symbol from 'ember-metal/symbol';
import { CURRENT_TAG, CONSTANT_TAG, VOLATILE_TAG, ConstReference, DirtyableTag, UpdatableTag, combine, isConst } from... | true |
Other | emberjs | ember.js | 9471527454b30b9a892d6d40f21735365b5a2897.json | Reorganize metal to support 2WB in Glimmer
This commit restructures some of the more arcane parts of ember-metal's
observer system.
It eliminates some special casing around `length`, which isn't necessary
anymore but complicates the overall abstraction of observable
properties.
Relatedly, it also finishes implementi... | packages/ember-glimmer/tests/integration/components/curly-components-test.js | @@ -1,4 +1,5 @@
/* globals EmberDev */
+import isEnabled from 'ember-metal/features';
import { set } from 'ember-metal/property_set';
import { observer } from 'ember-metal/mixin';
import { Component, compile } from '../../utils/helpers';
@@ -2041,7 +2042,97 @@ moduleFor('Components test: curly components', class ex... | true |
Other | emberjs | ember.js | 9471527454b30b9a892d6d40f21735365b5a2897.json | Reorganize metal to support 2WB in Glimmer
This commit restructures some of the more arcane parts of ember-metal's
observer system.
It eliminates some special casing around `length`, which isn't necessary
anymore but complicates the overall abstraction of observable
properties.
Relatedly, it also finishes implementi... | packages/ember-glimmer/tests/integration/content-test.js | @@ -190,6 +190,32 @@ class DynamicContentTest extends RenderingTest {
this.assertInvariants();
}
+ ['@test it can render a computed property with nested dependency']() {
+ let Formatter = EmberObject.extend({
+ formattedMessage: computed('messenger.message', function() {
+ return this.get('mes... | true |
Other | emberjs | ember.js | 9471527454b30b9a892d6d40f21735365b5a2897.json | Reorganize metal to support 2WB in Glimmer
This commit restructures some of the more arcane parts of ember-metal's
observer system.
It eliminates some special casing around `length`, which isn't necessary
anymore but complicates the overall abstraction of observable
properties.
Relatedly, it also finishes implementi... | packages/ember-metal/lib/chains.js | @@ -334,6 +334,8 @@ ChainNode.prototype = {
}
};
+import { makeChainNode } from './watch_path';
+
export function finishChains(obj) {
// We only create meta if we really have to
let m = peekMeta(obj);
@@ -348,7 +350,7 @@ export function finishChains(obj) {
// ensure that if we have inherited any chain... | true |
Other | emberjs | ember.js | 9471527454b30b9a892d6d40f21735365b5a2897.json | Reorganize metal to support 2WB in Glimmer
This commit restructures some of the more arcane parts of ember-metal's
observer system.
It eliminates some special casing around `length`, which isn't necessary
anymore but complicates the overall abstraction of observable
properties.
Relatedly, it also finishes implementi... | packages/ember-metal/lib/computed.js | @@ -416,10 +416,7 @@ ComputedPropertyPrototype._set = function computedPropertySet(obj, keyName, valu
return ret;
}
- let watched = meta.peekWatching(keyName);
- if (watched) {
- propertyWillChange(obj, keyName);
- }
+ propertyWillChange(obj, keyName);
if (hadCachedValue) {
cache[keyName] = u... | true |
Other | emberjs | ember.js | 9471527454b30b9a892d6d40f21735365b5a2897.json | Reorganize metal to support 2WB in Glimmer
This commit restructures some of the more arcane parts of ember-metal's
observer system.
It eliminates some special casing around `length`, which isn't necessary
anymore but complicates the overall abstraction of observable
properties.
Relatedly, it also finishes implementi... | packages/ember-metal/lib/meta.js | @@ -2,8 +2,11 @@
// Remove "use strict"; from transpiled module until
// https://bugs.webkit.org/show_bug.cgi?id=138038 is fixed
+import isEnabled from 'ember-metal/features';
import { protoMethods as listenerMethods } from 'ember-metal/meta_listeners';
import EmptyObject from 'ember-metal/empty_object';
+import ... | true |
Other | emberjs | ember.js | 9471527454b30b9a892d6d40f21735365b5a2897.json | Reorganize metal to support 2WB in Glimmer
This commit restructures some of the more arcane parts of ember-metal's
observer system.
It eliminates some special casing around `length`, which isn't necessary
anymore but complicates the overall abstraction of observable
properties.
Relatedly, it also finishes implementi... | packages/ember-metal/lib/properties.js | @@ -4,7 +4,7 @@
import { assert } from 'ember-metal/debug';
import isEnabled from 'ember-metal/features';
-import { meta as metaFor } from 'ember-metal/meta';
+import { meta as metaFor, peekMeta } from 'ember-metal/meta';
import { overrideChains } from 'ember-metal/property_events';
// .............................. | true |
Other | emberjs | ember.js | 9471527454b30b9a892d6d40f21735365b5a2897.json | Reorganize metal to support 2WB in Glimmer
This commit restructures some of the more arcane parts of ember-metal's
observer system.
It eliminates some special casing around `length`, which isn't necessary
anymore but complicates the overall abstraction of observable
properties.
Relatedly, it also finishes implementi... | packages/ember-metal/lib/property_events.js | @@ -8,6 +8,9 @@ import {
sendEvent,
accumulateListeners
} from 'ember-metal/events';
+import {
+ markObjectAsDirty
+} from './tags';
import ObserverSet from 'ember-metal/observer_set';
import symbol from 'ember-metal/symbol';
@@ -39,26 +42,24 @@ var deferred = 0;
*/
function propertyWillChange(obj, keyNam... | true |
Other | emberjs | ember.js | 9471527454b30b9a892d6d40f21735365b5a2897.json | Reorganize metal to support 2WB in Glimmer
This commit restructures some of the more arcane parts of ember-metal's
observer system.
It eliminates some special casing around `length`, which isn't necessary
anymore but complicates the overall abstraction of observable
properties.
Relatedly, it also finishes implementi... | packages/ember-metal/lib/property_set.js | @@ -2,11 +2,10 @@ import { assert } from 'ember-metal/debug';
import isEnabled from 'ember-metal/features';
import { _getPath as getPath } from 'ember-metal/property_get';
import {
- PROPERTY_DID_CHANGE,
propertyWillChange,
propertyDidChange
} from 'ember-metal/property_events';
-import { defineProperty } fr... | true |
Other | emberjs | ember.js | 9471527454b30b9a892d6d40f21735365b5a2897.json | Reorganize metal to support 2WB in Glimmer
This commit restructures some of the more arcane parts of ember-metal's
observer system.
It eliminates some special casing around `length`, which isn't necessary
anymore but complicates the overall abstraction of observable
properties.
Relatedly, it also finishes implementi... | packages/ember-metal/lib/watch_key.js | @@ -12,9 +12,6 @@ import { lookupDescriptor } from 'ember-metal/utils';
let handleMandatorySetter;
export function watchKey(obj, keyName, meta) {
- // can't watch length on Array - it is special...
- if (keyName === 'length' && Array.isArray(obj)) { return; }
-
var m = meta || metaFor(obj);
// activate wa... | true |
Other | emberjs | ember.js | 9471527454b30b9a892d6d40f21735365b5a2897.json | Reorganize metal to support 2WB in Glimmer
This commit restructures some of the more arcane parts of ember-metal's
observer system.
It eliminates some special casing around `length`, which isn't necessary
anymore but complicates the overall abstraction of observable
properties.
Relatedly, it also finishes implementi... | packages/ember-metal/lib/watch_path.js | @@ -10,14 +10,11 @@ function chainsFor(obj, meta) {
return (meta || metaFor(obj)).writableChains(makeChainNode);
}
-function makeChainNode(obj) {
+export function makeChainNode(obj) {
return new ChainNode(null, null, obj);
}
export function watchPath(obj, keyPath, meta) {
- // can't watch length on Array ... | true |
Other | emberjs | ember.js | 9471527454b30b9a892d6d40f21735365b5a2897.json | Reorganize metal to support 2WB in Glimmer
This commit restructures some of the more arcane parts of ember-metal's
observer system.
It eliminates some special casing around `length`, which isn't necessary
anymore but complicates the overall abstraction of observable
properties.
Relatedly, it also finishes implementi... | packages/ember-metal/lib/watching.js | @@ -35,9 +35,6 @@ import {
@param {String} _keyPath
*/
function watch(obj, _keyPath, m) {
- // can't watch length on Array - it is special...
- if (_keyPath === 'length' && Array.isArray(obj)) { return; }
-
if (!isPath(_keyPath)) {
watchKey(obj, _keyPath, m);
} else {
@@ -58,9 +55,6 @@ export function... | true |
Other | emberjs | ember.js | 9471527454b30b9a892d6d40f21735365b5a2897.json | Reorganize metal to support 2WB in Glimmer
This commit restructures some of the more arcane parts of ember-metal's
observer system.
It eliminates some special casing around `length`, which isn't necessary
anymore but complicates the overall abstraction of observable
properties.
Relatedly, it also finishes implementi... | packages/ember-metal/tests/watching/watch_test.js | @@ -216,8 +216,8 @@ testBoth('watching "length" property on an array', function(get, set) {
equal(get(arr, 'length'), 0, 'should have original prop');
set(arr, 'length', '10');
- equal(willCount, 0, 'should NOT have invoked willCount');
- equal(didCount, 0, 'should NOT have invoked didCount');
+ equal(willCo... | true |
Other | emberjs | ember.js | 9471527454b30b9a892d6d40f21735365b5a2897.json | Reorganize metal to support 2WB in Glimmer
This commit restructures some of the more arcane parts of ember-metal's
observer system.
It eliminates some special casing around `length`, which isn't necessary
anymore but complicates the overall abstraction of observable
properties.
Relatedly, it also finishes implementi... | packages/ember-runtime/lib/system/native_array.js | @@ -37,9 +37,7 @@ var NativeArray = Mixin.create(MutableArray, Observable, Copyable, {
// because length is a built-in property we need to know to just get the
// original property.
get(key) {
- if (key === 'length') {
- return this.length;
- } else if ('number' === typeof key) {
+ if ('number' =... | true |
Other | emberjs | ember.js | 9471527454b30b9a892d6d40f21735365b5a2897.json | Reorganize metal to support 2WB in Glimmer
This commit restructures some of the more arcane parts of ember-metal's
observer system.
It eliminates some special casing around `length`, which isn't necessary
anymore but complicates the overall abstraction of observable
properties.
Relatedly, it also finishes implementi... | packages/ember-runtime/tests/system/object/observer_test.js | @@ -208,4 +208,8 @@ testBoth('chain observer on class that has a reference to an uninitialized objec
parent.set('one.two', 'new');
equal(changed, true, 'child should have been notified of change to path');
+
+ parent.set('one', { two: 'newer' });
+
+ equal(changed, true, 'child should have been notified of ch... | true |
Other | emberjs | ember.js | bcbec4f47a10112829e3183cb562f5b9d71e5f20.json | Improve testing for uniquely named initializers.
Tests now verify that initializers can be named the same on
_different_ apps/engines, but must be uniquely named on _each_
app/engine. | packages/ember-application/tests/system/engine_initializers_test.js | @@ -310,18 +310,29 @@ QUnit.test('initializers are concatenated', function() {
});
QUnit.test('initializers are per-engine', function() {
- expect(0);
+ expect(2);
+
let FirstEngine = Engine.extend();
+
FirstEngine.initializer({
- name: 'shouldNotCollide',
+ name: 'abc',
initialize(engine) {}
... | true |
Other | emberjs | ember.js | bcbec4f47a10112829e3183cb562f5b9d71e5f20.json | Improve testing for uniquely named initializers.
Tests now verify that initializers can be named the same on
_different_ apps/engines, but must be uniquely named on _each_
app/engine. | packages/ember-application/tests/system/engine_instance_initializers_test.js | @@ -332,18 +332,29 @@ QUnit.test('initializers are concatenated', function() {
});
QUnit.test('initializers are per-engine', function() {
- expect(0);
+ expect(2);
+
let FirstEngine = Engine.extend();
+
FirstEngine.instanceInitializer({
- name: 'shouldNotCollide',
+ name: 'abc',
initialize(engine... | true |
Other | emberjs | ember.js | bcbec4f47a10112829e3183cb562f5b9d71e5f20.json | Improve testing for uniquely named initializers.
Tests now verify that initializers can be named the same on
_different_ apps/engines, but must be uniquely named on _each_
app/engine. | packages/ember-application/tests/system/initializers_test.js | @@ -349,18 +349,29 @@ QUnit.test('initializers are concatenated', function() {
});
QUnit.test('initializers are per-app', function() {
- expect(0);
- var FirstApp = Application.extend();
+ expect(2);
+
+ let FirstApp = Application.extend();
+
FirstApp.initializer({
- name: 'shouldNotCollide',
- initial... | true |
Other | emberjs | ember.js | bcbec4f47a10112829e3183cb562f5b9d71e5f20.json | Improve testing for uniquely named initializers.
Tests now verify that initializers can be named the same on
_different_ apps/engines, but must be uniquely named on _each_
app/engine. | packages/ember-application/tests/system/instance_initializers_test.js | @@ -318,18 +318,29 @@ QUnit.test('initializers are concatenated', function() {
});
QUnit.test('initializers are per-app', function() {
- expect(0);
- var FirstApp = Application.extend();
+ expect(2);
+
+ let FirstApp = Application.extend();
+
FirstApp.instanceInitializer({
- name: 'shouldNotCollide',
- ... | true |
Other | emberjs | ember.js | 591b864b428274600a2d0b4374c63cc2d74fbc2d.json | Introduce tests for EngineInstance initializers. | packages/ember-application/tests/system/engine_instance_initializers_test.js | @@ -0,0 +1,366 @@
+import run from 'ember-metal/run_loop';
+import Engine from 'ember-application/system/engine';
+import EngineInstance from 'ember-application/system/engine-instance';
+
+let MyEngine,
+ myEngine,
+ myEngineInstance;
+
+QUnit.module('Ember.Engine instance initializers', {
+ setup() {
+ },
+
+ ... | false |
Other | emberjs | ember.js | e087ae693f690e9476156ce68ec09610edcb10b7.json | Move common boot concerns to EngineInstance. | packages/ember-application/lib/system/application-instance.js | @@ -85,41 +85,19 @@ const ApplicationInstance = EngineInstance.extend({
// appended to the rootElement, in the case of apps, to the fixture harness
// in tests, or rendered to a string in the case of FastBoot.
this.register('-application-instance:main', this, { instantiate: false });
-
- this._booted ... | true |
Other | emberjs | ember.js | e087ae693f690e9476156ce68ec09610edcb10b7.json | Move common boot concerns to EngineInstance. | packages/ember-application/lib/system/engine-instance.js | @@ -8,6 +8,7 @@ import Registry from 'container/registry';
import ContainerProxy from 'ember-runtime/mixins/container_proxy';
import RegistryProxy from 'ember-runtime/mixins/registry_proxy';
import run from 'ember-metal/run_loop';
+import RSVP from 'ember-runtime/ext/rsvp';
/**
The `EngineInstance` encapsulate... | true |
Other | emberjs | ember.js | 7b925e31bd952f3c8a83cd2cd64cf622c7d26b32.json | Remove unused lookupFactory method | packages/ember-views/lib/component_lookup.js | @@ -1,56 +1,18 @@
import { assert } from 'ember-metal/debug';
import EmberObject from 'ember-runtime/system/object';
-import EmberComponent from 'ember-htmlbars/component';
-import { CONTAINS_DASH_CACHE } from 'ember-htmlbars/system/lookup-helper';
-import { getOwner } from 'container/owner';
export default EmberO... | true |
Other | emberjs | ember.js | 7b925e31bd952f3c8a83cd2cd64cf622c7d26b32.json | Remove unused lookupFactory method | packages/ember-views/lib/streams/utils.js | @@ -21,18 +21,6 @@ export function readViewFactory(object, owner) {
return viewClass;
}
-export function readComponentFactory(nameOrStream, owner) {
- var name = read(nameOrStream);
- var componentLookup = owner.lookup('component-lookup:main');
- assert(
- 'Could not find \'component-lookup:main\' on the pr... | true |
Other | emberjs | ember.js | 00e517f36eba5db96f420f758647e53d233780a0.json | Verify registry built for Ember.Application. | packages/ember-application/tests/system/application_test.js | @@ -1,6 +1,7 @@
/*globals EmberDev */
import VERSION from 'ember/version';
import { ENV, context } from 'ember-environment';
+import isEnabled from 'ember-metal/features';
import run from 'ember-metal/run_loop';
import libraries from 'ember-metal/libraries';
import Application, { _resetLegacyAddonWarnings } from ... | false |
Other | emberjs | ember.js | 32746fb694bfd70ca1f36bc6c0bdaafe78b43e36.json | Add failing test for protected attrs with no value
See https://github.com/tildeio/htmlbars/pull/455
This test demonstrates that with the current version of htmlbars bound
view attributes requiring sanitization will throw an error in node if
their value is undefined. | tests/node/component-rendering-test.js | @@ -44,6 +44,17 @@ QUnit.test("Component with dynamic value", function(assert) {
assert.ok(html.match(/<h1>Hello World<\/h1>/));
});
+QUnit.test("Ensure undefined attributes requiring protocol sanitization do not error", function(assert) {
+ var component = buildComponent('', {
+ tagName: 'link',
+ attribu... | false |
Other | emberjs | ember.js | 15e31d665ecc21786cbf0f5599562d7a4f6536be.json | Add 2.6.0-beta.4 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 60fc7dfff785d7d6a6770f57fe9447c5e59d8efd) | CHANGELOG.md | @@ -1,5 +1,12 @@
# Ember Changelog
+### 2.6.0-beta.4 (May 09, 2016)
+
+- [#13442](https://github.com/emberjs/ember.js/pull/13442) [BUGFIX] Revert `Ember.Handlebars.SafeString` deprecation.
+- [#13449](https://github.com/emberjs/ember.js/pull/13449) [BUGFIX] Ensure that `Ember.get(null, 'foo')` returns `undefined`.
+... | false |
Other | emberjs | ember.js | 714b3d73d0e0f05d1c5a47def21c568686428ba3.json | Add test for parameterless helper invocation. | packages/ember-glimmer/tests/integration/helpers/custom-helper-test.js | @@ -282,6 +282,30 @@ moduleFor('Helpers test: custom helpers', class extends RenderingTest {
this.assertText('Who overcomes by force hath overcome but half his foe');
}
+ ['@test parameterless helper is usable in subexpressions']() {
+ this.registerHelper('should-show', () => { return true; });
+
+ thi... | false |
Other | emberjs | ember.js | 34d0d2ebd14a90629f37ef6ea8d4ab3807ea4f90.json | Add 2.6.0-beta.3 to CHANGELOG.md.
[ci skip]
(cherry picked from commit e737eee8060d941ad96da1f08d49ac2b360452e7) | CHANGELOG.md | @@ -1,5 +1,13 @@
# Ember Changelog
+### 2.6.0-beta.3 (May 02, 2016)
+
+- [#13418](https://github.com/emberjs/ember.js/pull/13418) [BUGFIX] Ensure that passing `run.later` a timeout value of `NaN` does not break all future
+ timers.
+- [#13435](https://github.com/emberjs/ember.js/pull/13435) [BUGFIX] Fix positional ... | false |
Other | emberjs | ember.js | 158158364999302d1309b2135f7b46218496007f.json | Implement remaining lifecycle hooks
The original implementation of the hooks in HTMLBars does a deeper walk
than necessary (using the AlwaysDirty validator), resulting in executing
the experimental "new hooks" too often.
In particular, hooks were executed downstream from the original call to
`rerender()` even if the ... | package.json | @@ -38,7 +38,7 @@
"express": "^4.5.0",
"finalhandler": "^0.4.0",
"github": "^0.2.3",
- "glimmer-engine": "tildeio/glimmer#591a188",
+ "glimmer-engine": "tildeio/glimmer#2c22999",
"glob": "^5.0.13",
"htmlbars": "0.14.16",
"mocha": "^2.4.5", | true |
Other | emberjs | ember.js | 158158364999302d1309b2135f7b46218496007f.json | Implement remaining lifecycle hooks
The original implementation of the hooks in HTMLBars does a deeper walk
than necessary (using the AlwaysDirty validator), resulting in executing
the experimental "new hooks" too often.
In particular, hooks were executed downstream from the original call to
`rerender()` even if the ... | packages/ember-glimmer/lib/components/curly-component.js | @@ -1,5 +1,6 @@
import { StatementSyntax, ValueReference } from 'glimmer-runtime';
import { AttributeBindingReference, RootReference, applyClassNameBinding } from '../utils/references';
+import { DIRTY_TAG } from '../ember-views/component';
import EmptyObject from 'ember-metal/empty_object';
export class CurlyCom... | true |
Other | emberjs | ember.js | 158158364999302d1309b2135f7b46218496007f.json | Implement remaining lifecycle hooks
The original implementation of the hooks in HTMLBars does a deeper walk
than necessary (using the AlwaysDirty validator), resulting in executing
the experimental "new hooks" too often.
In particular, hooks were executed downstream from the original call to
`rerender()` even if the ... | packages/ember-glimmer/lib/components/outlet.js | @@ -100,6 +100,10 @@ class AbstractOutletComponentManager {
return new RootReference(state.render.controller);
}
+ getTag(state) {
+ return null;
+ }
+
getDestructor(state) {
return null;
} | true |
Other | emberjs | ember.js | 158158364999302d1309b2135f7b46218496007f.json | Implement remaining lifecycle hooks
The original implementation of the hooks in HTMLBars does a deeper walk
than necessary (using the AlwaysDirty validator), resulting in executing
the experimental "new hooks" too often.
In particular, hooks were executed downstream from the original call to
`rerender()` even if the ... | packages/ember-glimmer/lib/ember-metal-views/index.js | @@ -61,8 +61,15 @@ class Renderer {
}
remove(view) {
+ view.trigger('willDestroyElement');
view._transitionTo('destroying');
- view['_renderResult'].destroy();
+
+ let { _renderResult } = view;
+
+ if (_renderResult) {
+ _renderResult.destroy();
+ }
+
view.destroy();
}
| true |
Other | emberjs | ember.js | 158158364999302d1309b2135f7b46218496007f.json | Implement remaining lifecycle hooks
The original implementation of the hooks in HTMLBars does a deeper walk
than necessary (using the AlwaysDirty validator), resulting in executing
the experimental "new hooks" too often.
In particular, hooks were executed downstream from the original call to
`rerender()` even if the ... | packages/ember-glimmer/lib/ember-views/component.js | @@ -6,6 +6,10 @@ import InstrumentationSupport from 'ember-views/mixins/instrumentation_support';
import AriaRoleSupport from 'ember-views/mixins/aria_role_support';
import ViewMixin from 'ember-views/mixins/view_support';
import EmberView from 'ember-views/views/view';
+import symbol from 'ember-metal/symbol';
+imp... | true |
Other | emberjs | ember.js | 158158364999302d1309b2135f7b46218496007f.json | Implement remaining lifecycle hooks
The original implementation of the hooks in HTMLBars does a deeper walk
than necessary (using the AlwaysDirty validator), resulting in executing
the experimental "new hooks" too often.
In particular, hooks were executed downstream from the original call to
`rerender()` even if the ... | packages/ember-glimmer/lib/environment.js | @@ -26,8 +26,9 @@ import { default as get } from './helpers/get';
import { default as hash } from './helpers/hash';
import { default as loc } from './helpers/loc';
import { default as log } from './helpers/log';
-import { default as classHelper } from './helpers/-class';
+import { default as readonly } from './helpe... | true |
Other | emberjs | ember.js | 158158364999302d1309b2135f7b46218496007f.json | Implement remaining lifecycle hooks
The original implementation of the hooks in HTMLBars does a deeper walk
than necessary (using the AlwaysDirty validator), resulting in executing
the experimental "new hooks" too often.
In particular, hooks were executed downstream from the original call to
`rerender()` even if the ... | packages/ember-glimmer/lib/helpers/readonly.js | @@ -0,0 +1,7 @@
+import { helper } from '../helper';
+
+function readonly(args) {
+ return args[0];
+}
+
+export default helper(readonly); | true |
Other | emberjs | ember.js | 158158364999302d1309b2135f7b46218496007f.json | Implement remaining lifecycle hooks
The original implementation of the hooks in HTMLBars does a deeper walk
than necessary (using the AlwaysDirty validator), resulting in executing
the experimental "new hooks" too often.
In particular, hooks were executed downstream from the original call to
`rerender()` even if the ... | packages/ember-glimmer/tests/integration/components/life-cycle-test.js | @@ -0,0 +1,543 @@
+import { set } from 'ember-metal/property_set';
+import { Component } from '../../utils/helpers';
+import { strip } from '../../utils/abstract-test-case';
+import { moduleFor, RenderingTest } from '../../utils/test-case';
+
+class LifeCycleHooksTest extends RenderingTest {
+ constructor() {
+ sup... | true |
Other | emberjs | ember.js | 158158364999302d1309b2135f7b46218496007f.json | Implement remaining lifecycle hooks
The original implementation of the hooks in HTMLBars does a deeper walk
than necessary (using the AlwaysDirty validator), resulting in executing
the experimental "new hooks" too often.
In particular, hooks were executed downstream from the original call to
`rerender()` even if the ... | packages/ember-glimmer/tests/integration/components/will-destroy-element-hook-test.js | @@ -1,5 +1,5 @@
import { set } from 'ember-metal/property_set';
-import Component from 'ember-views/components/component';
+import { Component } from '../../utils/helpers';
import { moduleFor, RenderingTest } from '../../utils/test-case';
moduleFor('Component willDestroyElement hook', class extends RenderingTest { | true |
Other | emberjs | ember.js | 158158364999302d1309b2135f7b46218496007f.json | Implement remaining lifecycle hooks
The original implementation of the hooks in HTMLBars does a deeper walk
than necessary (using the AlwaysDirty validator), resulting in executing
the experimental "new hooks" too often.
In particular, hooks were executed downstream from the original call to
`rerender()` even if the ... | packages/ember-glimmer/tests/utils/abstract-test-case.js | @@ -98,6 +98,14 @@ export class TestCase {
this.assert = QUnit.config.current.assert;
}
+ get isHTMLBars() {
+ return packageName === 'htmlbars';
+ }
+
+ get isGlimmer() {
+ return packageName === 'glimmer';
+ }
+
teardown() {}
// The following methods require `this.element` to work
@@ -390,... | true |
Other | emberjs | ember.js | 158158364999302d1309b2135f7b46218496007f.json | Implement remaining lifecycle hooks
The original implementation of the hooks in HTMLBars does a deeper walk
than necessary (using the AlwaysDirty validator), resulting in executing
the experimental "new hooks" too often.
In particular, hooks were executed downstream from the original call to
`rerender()` even if the ... | packages/ember-glimmer/tests/utils/test-case.js | @@ -26,6 +26,11 @@ export class RenderingTest extends AbstractRenderingTest {
owner.registerOptionsForType('component', { singleton: false });
}
+ render(...args) {
+ super.render(...args);
+ this.renderer._root = this.component;
+ }
+
runTask(callback) {
super.runTask(() => {
callback(... | true |
Other | emberjs | ember.js | 158158364999302d1309b2135f7b46218496007f.json | Implement remaining lifecycle hooks
The original implementation of the hooks in HTMLBars does a deeper walk
than necessary (using the AlwaysDirty validator), resulting in executing
the experimental "new hooks" too often.
In particular, hooks were executed downstream from the original call to
`rerender()` even if the ... | packages/ember-htmlbars/tests/integration/component_lifecycle_test.js | @@ -316,7 +316,6 @@ styles.forEach(style => {
// Because the `twitter` attr is used by the all of the components,
// the lifecycle hooks are invoked for all components.
-
topAttrs = { oldAttrs: { twitter: '@tomdale' }, newAttrs: { twitter: '@hipstertomdale' } };
middleAttrs = { oldAttrs: { twitter... | true |
Other | emberjs | ember.js | 168a72ac081f9544b8463d4c04d4b98fa0265d0a.json | Implement "old" lifecycle hooks
* `willInsertElement`
* `didInsertElement` | packages/ember-glimmer/lib/components/curly-component.js | @@ -100,7 +100,7 @@ class CurlyComponentManager {
}
didCreate({ component }) {
- // component.trigger('didInsertElement');
+ component.trigger('didInsertElement');
// component.trigger('didRender');
component._transitionTo('inDOM');
} | true |
Other | emberjs | ember.js | 168a72ac081f9544b8463d4c04d4b98fa0265d0a.json | Implement "old" lifecycle hooks
* `willInsertElement`
* `didInsertElement` | packages/ember-glimmer/lib/environment.js | @@ -162,4 +162,8 @@ export default class Environment extends GlimmerEnvironment {
let keyPath = args.named.get('key').value();
return createIterable(ref, keyPath);
}
+
+ didDestroy(destroyable) {
+ destroyable.destroy();
+ }
} | true |
Other | emberjs | ember.js | 168a72ac081f9544b8463d4c04d4b98fa0265d0a.json | Implement "old" lifecycle hooks
* `willInsertElement`
* `didInsertElement` | packages/ember-glimmer/tests/integration/components/will-destroy-element-hook-test.js | @@ -3,7 +3,7 @@ import Component from 'ember-views/components/component';
import { moduleFor, RenderingTest } from '../../utils/test-case';
moduleFor('Component willDestroyElement hook', class extends RenderingTest {
- ['@htmlbars it calls willDestroyElement when removed by if'](assert) {
+ ['@test it calls willD... | true |
Other | emberjs | ember.js | 6065833fbde58fd29498846a79583503d5b2ab00.json | Fix a bug in the `(get)` helper's tag
Even if the source and path reference has not changed, the content could
still have changed, similar to how `PropertyReference` works. | package.json | @@ -38,7 +38,7 @@
"express": "^4.5.0",
"finalhandler": "^0.4.0",
"github": "^0.2.3",
- "glimmer-engine": "tildeio/glimmer#5918a481",
+ "glimmer-engine": "tildeio/glimmer#8182ab3",
"glob": "^5.0.13",
"htmlbars": "0.14.16",
"mocha": "^2.4.5", | true |
Other | emberjs | ember.js | 6065833fbde58fd29498846a79583503d5b2ab00.json | Fix a bug in the `(get)` helper's tag
Even if the source and path reference has not changed, the content could
still have changed, similar to how `PropertyReference` works. | packages/ember-glimmer/lib/helpers/get.js | @@ -1,5 +1,5 @@
import { GetHelperReference } from '../utils/references';
-import { isConst } from 'glimmer-reference';
+import { isConst, referenceFromParts } from 'glimmer-reference';
/**
@module ember
@@ -58,7 +58,8 @@ export default {
let propertyPathReference = args.positional.at(1); // bar in (get foo b... | true |
Other | emberjs | ember.js | 6065833fbde58fd29498846a79583503d5b2ab00.json | Fix a bug in the `(get)` helper's tag
Even if the source and path reference has not changed, the content could
still have changed, similar to how `PropertyReference` works. | packages/ember-glimmer/lib/utils/references.js | @@ -1,6 +1,6 @@
import { get } from 'ember-metal/property_get';
import { tagFor } from 'ember-metal/tags';
-import { CURRENT_TAG, CONSTANT_TAG, VOLATILE_TAG, ConstReference, DirtyableTag, UpdatableTag, combine, combineTagged } from 'glimmer-reference';
+import { CURRENT_TAG, CONSTANT_TAG, VOLATILE_TAG, ConstReference... | true |
Other | emberjs | ember.js | c6f70be7c456eeb7b08aab30b39e48a344f0d8e2.json | Move namespace stuff off of Ember. | packages/ember-application/lib/system/application.js | @@ -2,11 +2,13 @@
@module ember
@submodule ember-application
*/
-import Ember from 'ember-metal'; // Ember.libraries, Ember.BOOTED, Ember.testing
+import Ember from 'ember-metal'; // Ember.libraries, Ember.testing
import { ENV } from 'ember-environment';
import { assert, debug, warn, deprecate } from 'ember-metal/... | true |
Other | emberjs | ember.js | c6f70be7c456eeb7b08aab30b39e48a344f0d8e2.json | Move namespace stuff off of Ember. | packages/ember-application/tests/system/application_test.js | @@ -1,6 +1,6 @@
/*globals EmberDev */
-import Ember from 'ember-metal/core'; // Ember.libraries, Ember.BOOTED
+import Ember from 'ember-metal/core'; // Ember.libraries
import { ENV, context } from 'ember-environment';
import run from 'ember-metal/run_loop';
import Application, { _resetLegacyAddonWarnings } from '... | true |
Other | emberjs | ember.js | c6f70be7c456eeb7b08aab30b39e48a344f0d8e2.json | Move namespace stuff off of Ember. | packages/ember-metal/lib/index.js | @@ -124,6 +124,7 @@ import {
} from 'ember-metal/observer';
import {
IS_BINDING,
+ NAME_KEY,
Mixin,
aliasMethod,
_immediateObserver,
@@ -163,6 +164,7 @@ Ember._Cache = Cache;
Ember.generateGuid = generateGuid;
Ember.GUID_KEY = GUID_KEY;
+Ember.NAME_KEY = NAME_KEY;
Ember.platform ... | true |
Other | emberjs | ember.js | c6f70be7c456eeb7b08aab30b39e48a344f0d8e2.json | Move namespace stuff off of Ember. | packages/ember-metal/lib/mixin.js | @@ -6,7 +6,6 @@
@module ember
@submodule ember-metal
*/
-import Ember from 'ember-metal/core'; // warn, assert, wrap, et;
import EmberError from 'ember-metal/error';
import { debugSeal, assert, deprecate, runInDebug } from 'ember-metal/debug';
import assign from 'ember-metal/assign';
@@ -426,6 +425,8 @@ export fu... | true |
Other | emberjs | ember.js | c6f70be7c456eeb7b08aab30b39e48a344f0d8e2.json | Move namespace stuff off of Ember. | packages/ember-runtime/lib/index.js | @@ -10,7 +10,10 @@ import compare from 'ember-runtime/compare';
import copy from 'ember-runtime/copy';
import inject from 'ember-runtime/inject';
-import Namespace from 'ember-runtime/system/namespace';
+import Namespace, {
+ isSearchDisabled as isNamespaceSearchDisabled,
+ setSearchDisabled as setNamespaceSearch... | true |
Other | emberjs | ember.js | c6f70be7c456eeb7b08aab30b39e48a344f0d8e2.json | Move namespace stuff off of Ember. | packages/ember-runtime/lib/system/namespace.js | @@ -2,19 +2,31 @@
@module ember
@submodule ember-runtime
*/
-
-// Ember.BOOTED, Ember.NAME_KEY, Ember.anyUnprocessedMixins
-import Ember from 'ember-metal/core';
+import Ember from 'ember-metal/core'; // Preloaded into namespaces
import { context } from 'ember-environment';
import { get } from 'ember-metal/propert... | true |
Other | emberjs | ember.js | c6f70be7c456eeb7b08aab30b39e48a344f0d8e2.json | Move namespace stuff off of Ember. | packages/ember-runtime/tests/system/namespace/base_test.js | @@ -1,21 +1,22 @@
-import Ember from 'ember-metal/core'; // Ember.BOOTED
import { context } from 'ember-environment';
import run from 'ember-metal/run_loop';
import {get} from 'ember-metal/property_get';
import EmberObject from 'ember-runtime/system/object';
-import Namespace from 'ember-runtime/system/namespace';
... | true |
Other | emberjs | ember.js | d01caaed94290713074e0294d0ee572ebe4ca690.json | Fix an invalid input test
cc @rwjblue | packages/ember-glimmer/tests/integration/input-test.js | @@ -110,7 +110,7 @@ moduleFor('Input element tests', class extends RenderingTest {
this.setComponentValue('hello');
- this.assertValue('hola', 'DOM is used');
+ this.assertValue('hello', 'DOM is used');
}
// private helpers and assertions | false |
Other | emberjs | ember.js | 681401d55c95330109f2a9f4419808c42c525df5.json | Update input element tests for glimmer 2 | packages/ember-glimmer/tests/integration/input-test.js | @@ -0,0 +1,114 @@
+import { RenderingTest, moduleFor } from '../utils/test-case';
+import { set } from 'ember-metal/property_set';
+
+const camelizeMap = {
+ tabindex: 'tabIndex',
+ maxlength: 'maxLength'
+};
+
+moduleFor('Input element tests', class extends RenderingTest {
+
+ runAttributeTest(attributeName, values... | true |
Other | emberjs | ember.js | 681401d55c95330109f2a9f4419808c42c525df5.json | Update input element tests for glimmer 2 | packages/ember-htmlbars/tests/integration/input-test.js | @@ -0,0 +1 @@
+../../../ember-glimmer/tests/integration/input-test.js
\ No newline at end of file | true |
Other | emberjs | ember.js | 681401d55c95330109f2a9f4419808c42c525df5.json | Update input element tests for glimmer 2 | packages/ember-htmlbars/tests/integration/input_test.js | @@ -1,167 +0,0 @@
-import run from 'ember-metal/run_loop';
-import { set } from 'ember-metal/property_set';
-import View from 'ember-views/views/view';
-import { runAppend, runDestroy } from 'ember-runtime/tests/utils';
-import compile from 'ember-template-compiler/system/compile';
-import ComponentLookup from 'ember-v... | true |
Other | emberjs | ember.js | b1c3e11c42c2547dfb27c7eba0fa1aa458863499.json | Generalize the optimisation a little | packages/ember-glimmer/lib/ember-template-compiler/plugins/transform-has-block-syntax.js | @@ -25,10 +25,10 @@ export default function TransformHasBlockSyntax() {
this.syntax = null;
}
-const OLD_HAS_BLOCK = 'hasBlock';
-const NEW_HAS_BLOCK = 'has-block';
-const OLD_HAS_BLOCK_PARAMS = 'hasBlockParams';
-const NEW_HAS_BLOCK_PARAMS = 'has-block-params';
+const TRANSFORMATIONS = {
+ hasBlock: 'has-block'... | false |
Other | emberjs | ember.js | bfa224201dea93efa012e6429db505d191a5167a.json | Add 2.5.1 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 644c5a772788d4b225ef57f98b0ee958d64b7766) | CHANGELOG.md | @@ -11,6 +11,15 @@
- [#13285](https://github.com/emberjs/ember.js/pull/13285) [BUGFIX] Make `Enumerable#firstObject` read only.
- [#13289](https://github.com/emberjs/ember.js/pull/13289) [BUGFIX] Make `Enumerable#lastObject` read only.
+### 2.5.1 (April 21, 2016)
+
+- [#13310](https://github.com/emberjs/ember.js/pu... | false |
Other | emberjs | ember.js | b1c4b6f27c98ac26833a13dbd2ac51985f9905db.json | Update route-recognizer to 0.1.10.
Fixes a number of bugs:
* [tildeio/route-recognizer#46](https://github.com/tildeio/route-recognizer/pull/46) Implement a smarter route match algorithm.
Fixes a number of route priority issues, specifically one around glob
route priority matching.
* [tildeio/route-recognizer#62](... | package.json | @@ -46,7 +46,7 @@
"qunit-extras": "^1.5.0",
"qunitjs": "^1.22.0",
"rimraf": "^2.5.2",
- "route-recognizer": "0.1.5",
+ "route-recognizer": "0.1.10",
"rsvp": "~3.2.1",
"serve-static": "^1.10.0",
"simple-dom": "^0.3.0", | false |
Other | emberjs | ember.js | 1c77b908ec3f431b150db9a89e3f964a0d13e509.json | Remove extra whitespace from FEATURES.md | FEATURES.md | @@ -35,20 +35,20 @@ for a detailed explanation.
Deprecates `Route#serialize` and introduces a `serialize` option to the router DSL as a replacement (as per the [Route Serializers RFC](https://github.com/emberjs/rfcs/blob/master/text/0120-route-serializers.md)).
- * `ember-runtime-computed-uniq-by`
+* `ember-runt... | false |
Other | emberjs | ember.js | 0f71fe2374aaecb7cbaabe6050caf0c76d86d365.json | Update glimmer version, un-gate htmlSafe test | package.json | @@ -38,7 +38,7 @@
"express": "^4.5.0",
"finalhandler": "^0.4.0",
"github": "^0.2.3",
- "glimmer-engine": "tildeio/glimmer#2849de8",
+ "glimmer-engine": "tildeio/glimmer#b421a52",
"glob": "^5.0.13",
"htmlbars": "0.14.16",
"mocha": "^2.4.5", | true |
Other | emberjs | ember.js | 0f71fe2374aaecb7cbaabe6050caf0c76d86d365.json | Update glimmer version, un-gate htmlSafe test | packages/ember-glimmer/tests/integration/components/curly-components-test.js | @@ -877,7 +877,7 @@ moduleFor('Components test: curly components', class extends RenderingTest {
equalTokens(this.firstChild, expectedHtmlBold);
}
- ['@htmlbars should not escape HTML if string is a htmlSafe'](assert) {
+ ['@test should not escape HTML if string is a htmlSafe'](assert) {
let expectedHt... | true |
Other | emberjs | ember.js | e0fc791c95ffe88797f9e6755708f5b613296095.json | Fix toString to not add the property on the class
When calling `toString()` method on an Ember Object, it attaches the `toString` as a class property for the first time. This does not seem right since this should be on the prototype of the class. We could memoize the value on the class meta data.
In v2.5.0 and above,... | .jshintrc | @@ -15,6 +15,7 @@
"throws",
"deepEqual",
"ok",
+ "notOk",
"strictEqual",
"expect",
"minispade", | true |
Other | emberjs | ember.js | e0fc791c95ffe88797f9e6755708f5b613296095.json | Fix toString to not add the property on the class
When calling `toString()` method on an Ember Object, it attaches the `toString` as a class property for the first time. This does not seem right since this should be on the prototype of the class. We could memoize the value on the class meta data.
In v2.5.0 and above,... | packages/ember-runtime/lib/system/core_object.js | @@ -523,17 +523,12 @@ CoreObject.PrototypeMixin = Mixin.create({
var extension = hasToStringExtension ? ':' + this.toStringExtension() : '';
var ret = '<' + this.constructor.toString() + ':' + guidFor(this) + extension + '>';
- this.toString = makeToString(ret);
return ret;
}
});
CoreObject.P... | true |
Other | emberjs | ember.js | e0fc791c95ffe88797f9e6755708f5b613296095.json | Fix toString to not add the property on the class
When calling `toString()` method on an Ember Object, it attaches the `toString` as a class property for the first time. This does not seem right since this should be on the prototype of the class. We could memoize the value on the class meta data.
In v2.5.0 and above,... | packages/ember-runtime/tests/system/core_object_test.js | @@ -26,3 +26,14 @@ QUnit.test('works with new (> 1 arg)', function() {
equal(obj.other, undefined); // doesn't support multiple pojo' to the constructor
});
+
+QUnit.test('toString should be not be added as a property when calling toString()', function() {
+ var obj = new CoreObject({
+ firstName: 'Foo',
+ ... | true |
Other | emberjs | ember.js | 618de4fa036ab33dc760343decd355ede7b822bb.json | Update build scripts for LTS [ci skip] | bin/bower_ember_build | @@ -35,8 +35,10 @@ case $TRAVIS_BRANCH in
CHANNEL="beta" ;;
"release" )
CHANNEL="release" ;;
+ "lts-2-4" )
+ CHANNEL="lts-2-4" ;;
"release-1-13" )
- CHANNEL="release-1-13" ;;
+ CHANNEL="release-1-13" ;;
"metal-views" )
CHANNEL="metal-views" ;;
"idempotent-rerender" ) | true |
Other | emberjs | ember.js | 618de4fa036ab33dc760343decd355ede7b822bb.json | Update build scripts for LTS [ci skip] | bin/publish_to_s3.js | @@ -24,6 +24,7 @@ publisher.currentBranch = function() {
master: 'canary',
beta: 'beta',
release: 'release',
+ 'lts-2-4': 'lts-2-4',
'release-1-13': 'release-1-13'
}[this.CURRENT_BRANCH] || process.env.BUILD_TYPE;
}; | true |
Other | emberjs | ember.js | c31c50ee0472894a76e320a4e4f70fc357b3b740.json | Make Enumerable#lastObject readOnly. | packages/ember-runtime/lib/mixins/array.js | @@ -209,7 +209,7 @@ export default Mixin.create(Enumerable, {
lastObject: computed(function() {
return objectAt(this, get(this, 'length') - 1);
- }),
+ }).readOnly(),
// optimized version from Enumerable
contains(obj) { | true |
Other | emberjs | ember.js | c31c50ee0472894a76e320a4e4f70fc357b3b740.json | Make Enumerable#lastObject readOnly. | packages/ember-runtime/lib/mixins/enumerable.js | @@ -211,7 +211,7 @@ var Enumerable = Mixin.create({
pushCtx(context);
return last;
- }),
+ }).readOnly(),
/**
Returns `true` if the passed object can be found in the receiver. The | true |
Other | emberjs | ember.js | c31c50ee0472894a76e320a4e4f70fc357b3b740.json | Make Enumerable#lastObject readOnly. | packages/ember-runtime/tests/suites/enumerable/lastObject.js | @@ -1,5 +1,6 @@
import {SuiteModuleBuilder} from 'ember-runtime/tests/suites/suite';
import {get} from 'ember-metal/property_get';
+import {set} from 'ember-metal/property_set';
var suite = SuiteModuleBuilder.create();
@@ -18,4 +19,15 @@ suite.test('returns undefined if enumerable is empty', function() {
equa... | true |
Other | emberjs | ember.js | 19668677884515f3fe469dab50be8b0b03791ba3.json | routing/history_location: Add code comments | packages/ember-routing/lib/location/history_location.js | @@ -64,17 +64,20 @@ export default EmberObject.extend({
@return url {String}
*/
getURL() {
- var rootURL = get(this, 'rootURL');
var location = get(this, 'location');
var path = location.pathname;
+
+ var rootURL = get(this, 'rootURL');
var baseURL = get(this, 'baseURL');
+ // remov... | false |
Other | emberjs | ember.js | b273c005ce2a6550bc74f7adadc0ee171fc2e4a2.json | tests/blueprints: Use new testing API | node-tests/blueprints/acceptance-test-test.js | @@ -1,98 +1,85 @@
'use strict';
-var setupTestHooks = require('ember-cli-blueprint-test-helpers/lib/helpers/setup');
-var BlueprintHelpers = require('ember-cli-blueprint-test-helpers/lib/helpers/blueprint-helper');
-var generateAndDestroy = BlueprintHelpers.generateAndDestroy;
+var blueprintHelpers = require('... | true |
Other | emberjs | ember.js | b273c005ce2a6550bc74f7adadc0ee171fc2e4a2.json | tests/blueprints: Use new testing API | node-tests/blueprints/component-addon-test.js | @@ -1,23 +1,23 @@
'use strict';
-var setupTestHooks = require('ember-cli-blueprint-test-helpers/lib/helpers/setup');
-var BlueprintHelpers = require('ember-cli-blueprint-test-helpers/lib/helpers/blueprint-helper');
-var generateAndDestroy = BlueprintHelpers.generateAndDestroy;
+var blueprintHelpers = require('... | true |
Other | emberjs | ember.js | b273c005ce2a6550bc74f7adadc0ee171fc2e4a2.json | tests/blueprints: Use new testing API | node-tests/blueprints/component-test.js | @@ -1,1077 +1,823 @@
'use strict';
-var setupTestHooks = require('ember-cli-blueprint-test-helpers/lib/helpers/setup');
-var BlueprintHelpers = require('ember-cli-blueprint-test-helpers/lib/helpers/blueprint-helper');
-var generateAndDestroy = BlueprintHelpers.generateAndDestroy;
+var blueprintHelpers = requir... | true |
Other | emberjs | ember.js | b273c005ce2a6550bc74f7adadc0ee171fc2e4a2.json | tests/blueprints: Use new testing API | node-tests/blueprints/controller-test.js | @@ -1,346 +1,250 @@
'use strict';
-var setupTestHooks = require('ember-cli-blueprint-test-helpers/lib/helpers/setup');
-var BlueprintHelpers = require('ember-cli-blueprint-test-helpers/lib/helpers/blueprint-helper');
-var generateAndDestroy = BlueprintHelpers.generateAndDestroy;
+var blueprintHelpers = require... | true |
Other | emberjs | ember.js | b273c005ce2a6550bc74f7adadc0ee171fc2e4a2.json | tests/blueprints: Use new testing API | node-tests/blueprints/helper-addon-test.js | @@ -1,24 +1,23 @@
'use strict';
-var setupTestHooks = require('ember-cli-blueprint-test-helpers/lib/helpers/setup');
-var BlueprintHelpers = require('ember-cli-blueprint-test-helpers/lib/helpers/blueprint-helper');
-var generateAndDestroy = BlueprintHelpers.generateAndDestroy;
+var blueprintHelpers = require('... | true |
Other | emberjs | ember.js | b273c005ce2a6550bc74f7adadc0ee171fc2e4a2.json | tests/blueprints: Use new testing API | node-tests/blueprints/helper-test.js | @@ -1,304 +1,252 @@
'use strict';
-var setupTestHooks = require('ember-cli-blueprint-test-helpers/lib/helpers/setup');
-var BlueprintHelpers = require('ember-cli-blueprint-test-helpers/lib/helpers/blueprint-helper');
-var generateAndDestroy = BlueprintHelpers.generateAndDestroy;
+var blueprintHelpers = require... | true |
Other | emberjs | ember.js | b273c005ce2a6550bc74f7adadc0ee171fc2e4a2.json | tests/blueprints: Use new testing API | node-tests/blueprints/initializer-addon-test.js | @@ -1,24 +1,23 @@
'use strict';
-var setupTestHooks = require('ember-cli-blueprint-test-helpers/lib/helpers/setup');
-var BlueprintHelpers = require('ember-cli-blueprint-test-helpers/lib/helpers/blueprint-helper');
-var generateAndDestroy = BlueprintHelpers.generateAndDestroy;
+var blueprintHelpers = require('... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.