language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | ca443d01d22409da0c1001557e0852017654045e.json | Update Glimmer to 0.11.0.
* Threads `SymbolTable` throughout the system instead of `blockMeta`.
* Change a few argument signatures for Glimmer syntax's (moving from
options hash to positional, etc). | packages/ember-glimmer/lib/syntax/dynamic-component.js | @@ -12,59 +12,59 @@ function dynamicComponentFor(vm) {
let env = vm.env;
let args = vm.getArgs();
let nameRef = args.positional.at(0);
- let { blockMeta } = this;
+ let { symbolTable } = this;
- return new DynamicComponentReference({ nameRef, env, blockMeta });
+ return new DynamicComponentReferen... | true |
Other | emberjs | ember.js | ca443d01d22409da0c1001557e0852017654045e.json | Update Glimmer to 0.11.0.
* Threads `SymbolTable` throughout the system instead of `blockMeta`.
* Change a few argument signatures for Glimmer syntax's (moving from
options hash to positional, etc). | packages/ember-glimmer/lib/syntax/outlet.js | @@ -16,17 +16,18 @@ function outletComponentFor(vm) {
}
export class OutletSyntax extends StatementSyntax {
- constructor({ args }) {
+ constructor({ args, symbolTable }) {
super();
this.definitionArgs = args;
this.definition = outletComponentFor;
this.args = ArgsSyntax.empty();
+ this.symb... | true |
Other | emberjs | ember.js | ca443d01d22409da0c1001557e0852017654045e.json | Update Glimmer to 0.11.0.
* Threads `SymbolTable` throughout the system instead of `blockMeta`.
* Change a few argument signatures for Glimmer syntax's (moving from
options hash to positional, etc). | packages/ember-glimmer/lib/syntax/render.js | @@ -41,17 +41,18 @@ function makeComponentDefinition(vm) {
}
export class RenderSyntax extends StatementSyntax {
- constructor({ args }) {
+ constructor({ args, symbolTable }) {
super();
this.definitionArgs = args;
this.definition = makeComponentDefinition;
this.args = ArgsSyntax.fromPositiona... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-glimmer/lib/index.js | @@ -1,2 +1,2 @@
-export { default as Environment } from 'ember-glimmer/environment';
+export { default as Environment } from './environment';
export { default as template } from './template'; | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-glimmer/lib/setup-registry.js | @@ -1,15 +1,15 @@
import { privatize as P } from 'container/registry';
-import { InteractiveRenderer, InertRenderer } from 'ember-glimmer/renderer';
-import { DOMChanges, DOMTreeConstruction } from 'ember-glimmer/dom';
-import OutletView from 'ember-glimmer/views/outlet';
-import TextField from 'ember-glimmer/componen... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/alias.js | @@ -1,18 +1,18 @@
-import { assert } from 'ember-metal/debug';
-import { get } from 'ember-metal/property_get';
-import { set } from 'ember-metal/property_set';
-import EmberError from 'ember-metal/error';
+import { assert } from './debug';
+import { get } from './property_get';
+import { set } from './property_set';
+... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/binding.js | @@ -1,21 +1,21 @@
import Logger from 'ember-console';
import { context, ENV } from 'ember-environment';
-import run from 'ember-metal/run_loop';
-import { assert, deprecate } from 'ember-metal/debug';
-import { get } from 'ember-metal/property_get';
-import { trySet } from 'ember-metal/property_set';
-import { guidFo... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/cache.js | @@ -1,4 +1,4 @@
-import EmptyObject from 'ember-metal/empty_object';
+import EmptyObject from './empty_object';
export default class Cache {
constructor(limit, func, key, store) { | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/chains.js | @@ -1,7 +1,7 @@
-import { get } from 'ember-metal/property_get';
-import { meta as metaFor, peekMeta } from 'ember-metal/meta';
-import { watchKey, unwatchKey } from 'ember-metal/watch_key';
-import EmptyObject from 'ember-metal/empty_object';
+import { get } from './property_get';
+import { meta as metaFor, peekMeta }... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/computed.js | @@ -1,21 +1,21 @@
-import { assert, warn } from 'ember-metal/debug';
-import { set } from 'ember-metal/property_set';
-import { inspect } from 'ember-metal/utils';
-import { meta as metaFor, peekMeta } from 'ember-metal/meta';
-import expandProperties from 'ember-metal/expand_properties';
-import EmberError from 'ember... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/dependent_keys.js | @@ -5,7 +5,7 @@
import {
watch,
unwatch
-} from 'ember-metal/watching';
+} from './watching';
/**
@module ember | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/deprecate_property.js | @@ -3,9 +3,9 @@
@submodule ember-metal
*/
-import { deprecate } from 'ember-metal/debug';
-import { get } from 'ember-metal/property_get';
-import { set } from 'ember-metal/property_set';
+import { deprecate } from './debug';
+import { get } from './property_get';
+import { set } from './property_set';
/** | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/events.js | @@ -6,12 +6,12 @@
@module ember
@submodule ember-metal
*/
-import { assert } from 'ember-metal/debug';
-import { applyStr } from 'ember-metal/utils';
-import { meta as metaFor, peekMeta } from 'ember-metal/meta';
-import { deprecate } from 'ember-metal/debug';
+import { assert } from './debug';
+import { applyStr } ... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/expand_properties.js | @@ -1,4 +1,4 @@
-import { assert } from 'ember-metal/debug';
+import { assert } from './debug';
/**
@module ember | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/features.js | @@ -1,5 +1,5 @@
import { ENV } from 'ember-environment';
-import assign from 'ember-metal/assign';
+import assign from './assign';
import DEFAULT_FEATURES from 'ember/features';
/** | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/get_properties.js | @@ -1,4 +1,4 @@
-import { get } from 'ember-metal/property_get';
+import { get } from './property_get';
/**
To get multiple properties at once, call `Ember.getProperties` | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/index.js | @@ -7,17 +7,17 @@
import require, { has } from 'require';
import { ENV, context } from 'ember-environment';
import VERSION from 'ember/version';
-import Ember from 'ember-metal/core'; // reexports
-import { deprecate, deprecateFunc } from 'ember-metal/debug';
-import isEnabled, { FEATURES } from 'ember-metal/feature... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/injected_property.js | @@ -1,7 +1,7 @@
-import { assert } from 'ember-metal/debug';
-import { ComputedProperty } from 'ember-metal/computed';
-import { AliasedProperty } from 'ember-metal/alias';
-import { Descriptor } from 'ember-metal/properties';
+import { assert } from './debug';
+import { ComputedProperty } from './computed';
+import { ... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/instrumentation.js | @@ -1,5 +1,5 @@
import { ENV } from 'ember-environment';
-import isEnabled from 'ember-metal/features';
+import isEnabled from './features';
/**
The purpose of the Ember Instrumentation module is | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/is_blank.js | @@ -1,4 +1,4 @@
-import isEmpty from 'ember-metal/is_empty';
+import isEmpty from './is_empty';
/**
A value is blank if it is empty or a whitespace string. | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/is_empty.js | @@ -1,5 +1,5 @@
-import { get } from 'ember-metal/property_get';
-import isNone from 'ember-metal/is_none';
+import { get } from './property_get';
+import isNone from './is_none';
/**
Verifies that a value is `null` or an empty string, empty array, | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/is_present.js | @@ -1,4 +1,4 @@
-import isBlank from 'ember-metal/is_blank';
+import isBlank from './is_blank';
/**
A value is present if it not `isBlank`. | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/libraries.js | @@ -1,5 +1,5 @@
-import { warn } from 'ember-metal/debug';
-import isEnabled from 'ember-metal/features';
+import { warn } from './debug';
+import isEnabled from './features';
/**
Helper class that allows you to register your library with Ember. | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/map.js | @@ -20,8 +20,8 @@
Map is mocked out to look like an Ember object, so you can do
`Ember.Map.create()` for symmetry with other Ember classes.
*/
-import { guidFor } from 'ember-metal/utils';
-import EmptyObject from 'ember-metal/empty_object';
+import { guidFor } from './utils';
+import EmptyObject from './empty_o... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/meta.js | @@ -2,11 +2,11 @@
// Remove "use strict"; from transpiled module until
// https://bugs.webkit.org/show_bug.cgi?id=138038 is fixed
-import isEnabled from 'ember-metal/features';
-import { protoMethods as listenerMethods } from 'ember-metal/meta_listeners';
-import EmptyObject from 'ember-metal/empty_object';
-import... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/mixin.js | @@ -6,33 +6,33 @@
@module ember
@submodule ember-metal
*/
-import EmberError from 'ember-metal/error';
-import { debugSeal, assert, deprecate, runInDebug } from 'ember-metal/debug';
-import assign from 'ember-metal/assign';
+import EmberError from './error';
+import { debugSeal, assert, deprecate, runInDebug } from ... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/observer.js | @@ -1,14 +1,14 @@
import {
watch,
unwatch
-} from 'ember-metal/watching';
+} from './watching';
import {
listenersFor,
addListener,
removeListener,
suspendListeners,
suspendListener
-} from 'ember-metal/events';
+} from './events';
/**
@module ember-metal
*/ | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/observer_set.js | @@ -1,5 +1,5 @@
-import { guidFor } from 'ember-metal/utils';
-import { sendEvent } from 'ember-metal/events';
+import { guidFor } from './utils';
+import { sendEvent } from './events';
/*
this.observerSet = { | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/path_cache.js | @@ -1,4 +1,4 @@
-import Cache from 'ember-metal/cache';
+import Cache from './cache';
const IS_GLOBAL = /^[A-Z$]/;
const IS_GLOBAL_PATH = /^[A-Z$].*[\.]/; | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/properties.js | @@ -2,10 +2,10 @@
@module ember-metal
*/
-import { assert } from 'ember-metal/debug';
-import isEnabled from 'ember-metal/features';
-import { meta as metaFor, peekMeta } from 'ember-metal/meta';
-import { overrideChains } from 'ember-metal/property_events';
+import { assert } from './debug';
+import isEnabled from... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/property_events.js | @@ -1,20 +1,20 @@
import {
guidFor
-} from 'ember-metal/utils';
+} from './utils';
import {
peekMeta
-} from 'ember-metal/meta';
+} from './meta';
import {
sendEvent,
accumulateListeners
-} from 'ember-metal/events';
+} from './events';
import {
markObjectAsDirty
} from './tags';
-import ObserverSet... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/property_get.js | @@ -2,8 +2,8 @@
@module ember-metal
*/
-import { assert } from 'ember-metal/debug';
-import { isPath, hasThis } from 'ember-metal/path_cache';
+import { assert } from './debug';
+import { isPath, hasThis } from './path_cache';
const ALLOWABLE_TYPES = {
object: true, | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/property_set.js | @@ -1,23 +1,23 @@
-import { assert } from 'ember-metal/debug';
-import isEnabled from 'ember-metal/features';
-import { _getPath as getPath } from 'ember-metal/property_get';
+import { assert } from './debug';
+import isEnabled from './features';
+import { _getPath as getPath } from './property_get';
import {
prope... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/run_loop.js | @@ -1,16 +1,16 @@
-import { assert } from 'ember-metal/debug';
-import { isTesting } from 'ember-metal/testing';
+import { assert } from './debug';
+import { isTesting } from './testing';
import {
getOnerror,
setOnerror
-} from 'ember-metal/error_handler';
+} from './error_handler';
import {
GUID_KEY
-} from... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/set_properties.js | @@ -1,5 +1,5 @@
-import { changeProperties } from 'ember-metal/property_events';
-import { set } from 'ember-metal/property_set';
+import { changeProperties } from './property_events';
+import { set } from './property_set';
/**
Set a list of properties on an object. These properties are set inside | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/symbol.js | @@ -1,4 +1,4 @@
-import { GUID_KEY, intern } from 'ember-metal/utils';
+import { GUID_KEY, intern } from './utils';
export default function symbol(debugName) {
// TODO: Investigate using platform symbols, but we do not | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/transaction.js | @@ -1,6 +1,6 @@
import { meta as metaFor } from './meta';
-import { assert, runInDebug, deprecate } from 'ember-metal/debug';
-import isEnabled from 'ember-metal/features';
+import { assert, runInDebug, deprecate } from './debug';
+import isEnabled from './features';
let runInTransaction, didRender, assertNotRender... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/watch_key.js | @@ -1,13 +1,13 @@
-import isEnabled from 'ember-metal/features';
+import isEnabled from './features';
import {
meta as metaFor
-} from 'ember-metal/meta';
+} from './meta';
import {
MANDATORY_SETTER_FUNCTION,
DEFAULT_GETTER_FUNCTION,
INHERITING_GETTER_FUNCTION
-} from 'ember-metal/properties';
-import { l... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/watch_path.js | @@ -1,7 +1,7 @@
import {
meta as metaFor
-} from 'ember-metal/meta';
-import { ChainNode } from 'ember-metal/chains';
+} from './meta';
+import { ChainNode } from './chains';
// get the chains for the current object. If the current object has
// chains inherited from the proto they will be cloned and reconfigur... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/watching.js | @@ -4,22 +4,22 @@
import {
removeChainWatcher
-} from 'ember-metal/chains';
+} from './chains';
import {
watchKey,
unwatchKey
-} from 'ember-metal/watch_key';
+} from './watch_key';
import {
watchPath,
unwatchPath
-} from 'ember-metal/watch_path';
+} from './watch_path';
import {
isPath
-} from ... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/weak_map.js | @@ -1,8 +1,8 @@
-import { GUID_KEY } from 'ember-metal/utils';
+import { GUID_KEY } from './utils';
import {
peekMeta,
meta as metaFor
-} from 'ember-metal/meta';
+} from './meta';
let id = 0;
function UNDEFINED() {} | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/compare.js | @@ -1,5 +1,5 @@
-import { typeOf } from 'ember-runtime/utils';
-import Comparable from 'ember-runtime/mixins/comparable';
+import { typeOf } from './utils';
+import Comparable from './mixins/comparable';
const TYPE_ORDER = {
'undefined': 0, | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/computed/reduce_computed_macros.js | @@ -8,9 +8,9 @@ import { get } from 'ember-metal/property_get';
import EmberError from 'ember-metal/error';
import { ComputedProperty, computed } from 'ember-metal/computed';
import { addObserver, removeObserver } from 'ember-metal/observer';
-import compare from 'ember-runtime/compare';
-import { isArray } from 'em... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/controllers/controller.js | @@ -1,8 +1,8 @@
import { assert } from 'ember-metal/debug';
-import EmberObject from 'ember-runtime/system/object';
-import Mixin from 'ember-runtime/mixins/controller';
-import { createInjectionHelper } from 'ember-runtime/inject';
-import { deprecateUnderscoreActions } from 'ember-runtime/mixins/action_handler';
+im... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/copy.js | @@ -1,6 +1,6 @@
import { assert } from 'ember-metal/debug';
-import EmberObject from 'ember-runtime/system/object';
-import Copyable from 'ember-runtime/mixins/copyable';
+import EmberObject from './system/object';
+import Copyable from './mixins/copyable';
function _copy(obj, deep, seen, copies) {
let ret, loc,... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/ext/string.js | @@ -14,7 +14,7 @@ import {
underscore,
capitalize,
classify
-} from 'ember-runtime/system/string';
+} from '../system/string';
const StringPrototype = String.prototype;
| true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/index.js | @@ -5,45 +5,45 @@
// BEGIN IMPORTS
import Ember from 'ember-metal'; // reexports
-import isEqual from 'ember-runtime/is-equal';
-import compare from 'ember-runtime/compare';
-import copy from 'ember-runtime/copy';
-import inject from 'ember-runtime/inject';
+import isEqual from './is-equal';
+import compare from '.... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/mixins/-proxy.js | @@ -17,8 +17,8 @@ import {
propertyWillChange,
propertyDidChange
} from 'ember-metal/property_events';
-import { bool } from 'ember-runtime/computed/computed_macros';
-import { POST_INIT } from 'ember-runtime/system/core_object';
+import { bool } from '../computed/computed_macros';
+import { POST_INIT } from '..... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/mixins/array.js | @@ -15,7 +15,7 @@ import {
cacheFor
} from 'ember-metal/computed';
import isNone from 'ember-metal/is_none';
-import Enumerable from 'ember-runtime/mixins/enumerable';
+import Enumerable from './enumerable';
import { Mixin } from 'ember-metal/mixin';
import {
propertyWillChange,
@@ -29,7 +29,7 @@ import {
} ... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/mixins/controller.js | @@ -1,7 +1,7 @@
import { Mixin } from 'ember-metal/mixin';
import alias from 'ember-metal/alias';
-import ActionHandler from 'ember-runtime/mixins/action_handler';
-import ControllerContentModelAliasDeprecation from 'ember-runtime/mixins/controller_content_model_alias_deprecation';
+import ActionHandler from './actio... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/mixins/copyable.js | @@ -6,7 +6,7 @@
import { deprecate } from 'ember-metal/debug';
import { get } from 'ember-metal/property_get';
import { Mixin } from 'ember-metal/mixin';
-import { Freezable } from 'ember-runtime/mixins/freezable';
+import { Freezable } from './freezable';
import EmberError from 'ember-metal/error';
/** | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/mixins/enumerable.js | @@ -27,7 +27,7 @@ import {
sendEvent,
hasListeners
} from 'ember-metal/events';
-import compare from 'ember-runtime/compare';
+import compare from '../compare';
import require from 'require';
import { assert, deprecate } from 'ember-metal/debug';
| true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/mixins/mutable_array.js | @@ -4,13 +4,6 @@
*/
-// require('ember-runtime/mixins/array');
-// require('ember-runtime/mixins/mutable_enumerable');
-
-// ..........................................................
-// CONSTANTS
-//
-
const OUT_OF_RANGE_EXCEPTION = 'Index out of range';
const EMPTY = [];
@@ -21,9 +14,9 @@ const EMPTY = [];
... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/mixins/mutable_enumerable.js | @@ -1,4 +1,4 @@
-import Enumerable from 'ember-runtime/mixins/enumerable';
+import Enumerable from './enumerable';
import { Mixin } from 'ember-metal/mixin';
import {beginPropertyChanges, endPropertyChanges} from 'ember-metal/property_events';
| true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/mixins/promise_proxy.js | @@ -1,7 +1,7 @@
import { get } from 'ember-metal/property_get';
import setProperties from 'ember-metal/set_properties';
import { computed } from 'ember-metal/computed';
-import { not, or } from 'ember-runtime/computed/computed_macros';
+import { not, or } from '../computed/computed_macros';
import { Mixin } from 'e... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/application.js | @@ -1,3 +1,3 @@
-import Namespace from 'ember-runtime/system/namespace';
+import Namespace from './namespace';
export default Namespace.extend(); | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/array_proxy.js | @@ -2,7 +2,7 @@ import { assert } from 'ember-metal/debug';
import { get } from 'ember-metal/property_get';
import {
isArray
-} from 'ember-runtime/utils';
+} from '../utils';
import { computed } from 'ember-metal/computed';
import {
_beforeObserver,
@@ -13,17 +13,17 @@ import {
endPropertyChanges
} from ... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/core_object.js | @@ -33,14 +33,14 @@ import {
REQUIRED
} from 'ember-metal/mixin';
import EmberError from 'ember-metal/error';
-import ActionHandler from 'ember-runtime/mixins/action_handler';
+import ActionHandler from '../mixins/action_handler';
import { defineProperty } from 'ember-metal/properties';
import { Binding } from '... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/each_proxy.js | @@ -11,7 +11,7 @@ import {
propertyWillChange
} from 'ember-metal/property_events';
import EmptyObject from 'ember-metal/empty_object';
-import { objectAt } from 'ember-runtime/mixins/array';
+import { objectAt } from '../mixins/array';
/**
This is the object instance returned when you get the `@each` proper... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/namespace.js | @@ -15,7 +15,7 @@ import {
NAME_KEY
} from 'ember-metal/mixin';
-import EmberObject from 'ember-runtime/system/object';
+import EmberObject from './object';
let searchDisabled = false;
| true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/native_array.js | @@ -10,12 +10,12 @@ import { Mixin } from 'ember-metal/mixin';
import EmberArray, {
arrayContentDidChange,
arrayContentWillChange
-} from 'ember-runtime/mixins/array';
-import MutableArray from 'ember-runtime/mixins/mutable_array';
-import Observable from 'ember-runtime/mixins/observable';
-import Copyable from ... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/object.js | @@ -3,8 +3,8 @@
@submodule ember-runtime
*/
-import CoreObject from 'ember-runtime/system/core_object';
-import Observable from 'ember-runtime/mixins/observable';
+import CoreObject from './core_object';
+import Observable from '../mixins/observable';
/**
`Ember.Object` is the main base class for all Ember ob... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/object_proxy.js | @@ -1,5 +1,5 @@
-import EmberObject from 'ember-runtime/system/object';
-import _ProxyMixin from 'ember-runtime/mixins/-proxy';
+import EmberObject from './object';
+import _ProxyMixin from '../mixins/-proxy';
/**
`Ember.ObjectProxy` forwards all properties not defined by the proxy itself | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/service.js | @@ -1,5 +1,5 @@
-import EmberObject from 'ember-runtime/system/object';
-import { createInjectionHelper } from 'ember-runtime/inject';
+import EmberObject from './object';
+import { createInjectionHelper } from '../inject';
/** | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/string.js | @@ -6,10 +6,10 @@ import { deprecate } from 'ember-metal/debug';
import {
inspect as emberInspect
} from 'ember-metal/utils';
-import { isArray } from 'ember-runtime/utils';
+import { isArray } from '../utils';
import {
get as getString
-} from 'ember-runtime/string_registry';
+} from '../string_registry';
... | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/utils.js | @@ -1,5 +1,5 @@
-import EmberArray from 'ember-runtime/mixins/array';
-import EmberObject from 'ember-runtime/system/object';
+import EmberArray from './mixins/array';
+import EmberObject from './system/object';
// ........................................
// TYPING & ARRAY MESSAGING | true |
Other | emberjs | ember.js | 588a698c732f78b2ed7392d6240d79b9476e9a6f.json | Prevent reordering when using `seed` URL config. | tests/index.html | @@ -162,6 +162,10 @@
QUnit.config.urlConfig.push('nojshint');
QUnit.config.urlConfig.push('forceskip');
+ if (QUnit.config.seed) {
+ QUnit.config.reorder = false;
+ }
+
QUnit.begin(function() {
if (QUnit.urlParams.hideskipped) {
$('#qunit-tests... | false |
Other | emberjs | ember.js | 632ecdb07826f16cb1e7cf7a5afecc9d6ae71414.json | Fix issues with test cleanup. | packages/ember-runtime/tests/ext/rsvp_test.js | @@ -3,7 +3,13 @@ import { setOnerror, getOnerror } from 'ember-metal/error_handler';
import run from 'ember-metal/run_loop';
import RSVP from 'ember-runtime/ext/rsvp';
-QUnit.module('Ember.RSVP');
+const ORIGINAL_ONERROR = getOnerror();
+
+QUnit.module('Ember.RSVP', {
+ teardown() {
+ setOnerror(ORIGINAL_ONERRO... | true |
Other | emberjs | ember.js | 632ecdb07826f16cb1e7cf7a5afecc9d6ae71414.json | Fix issues with test cleanup. | packages/ember-runtime/tests/mixins/promise_proxy_test.js | @@ -17,6 +17,10 @@ QUnit.test('present on ember namespace', function() {
QUnit.module('Ember.PromiseProxy - ObjectProxy', {
setup() {
ObjectPromiseProxy = ObjectProxy.extend(PromiseProxyMixin);
+ },
+
+ teardown() {
+ RSVP.on('error', onerrorDefault);
}
});
| true |
Other | emberjs | ember.js | 632ecdb07826f16cb1e7cf7a5afecc9d6ae71414.json | Fix issues with test cleanup. | packages/ember-runtime/tests/system/lazy_load_test.js | @@ -1,7 +1,14 @@
import run from 'ember-metal/run_loop';
-import {onLoad, runLoadHooks} from 'ember-runtime/system/lazy_load';
+import {onLoad, runLoadHooks, _loaded } from 'ember-runtime/system/lazy_load';
-QUnit.module('Lazy Loading');
+QUnit.module('Lazy Loading', {
+ teardown() {
+ let keys = Object.keys(_lo... | true |
Other | emberjs | ember.js | 632ecdb07826f16cb1e7cf7a5afecc9d6ae71414.json | Fix issues with test cleanup. | packages/ember-testing/tests/acceptance_test.js | @@ -17,6 +17,9 @@ QUnit.module('ember-testing Acceptance', {
setup() {
jQuery('<style>#ember-testing-container { position: absolute; background: white; bottom: 0; right: 0; width: 640px; height: 384px; overflow: auto; z-index: 9999; border: 1px solid #ccc; } #ember-testing { zoom: 50%; }</style>').appendTo('hea... | true |
Other | emberjs | ember.js | 632ecdb07826f16cb1e7cf7a5afecc9d6ae71414.json | Fix issues with test cleanup. | packages/ember-testing/tests/helpers_test.js | @@ -1018,10 +1018,7 @@ QUnit.module('can override built-in helpers', {
},
teardown() {
- App.removeTestHelpers();
- jQuery('#ember-testing-container, #ember-testing').remove();
- run(App, App.destroy);
- App = null;
+ cleanup();
Test._helpers.visit = originalVisitHelper;
Test._helpers... | true |
Other | emberjs | ember.js | d21e016c51e0d1b6ce23ee36a67eac2a14e2bede.json | Add failing test for GH#13846. | packages/ember-glimmer/tests/integration/components/curly-components-test.js | @@ -2570,4 +2570,74 @@ moduleFor('Components test: curly components', class extends RenderingTest {
assertElement('foo');
}
+
+ ['@test child triggers revalidate during parent destruction (GH#13846)']() {
+ let select;
+
+ this.registerComponent('x-select', {
+ ComponentClass: Component.extend({
+... | false |
Other | emberjs | ember.js | 39875a4869d73ad34c165bbeecce0b4d4d15ab39.json | Add helpful assertion when template is missing.
Prior to this change, calling `component.appendTo()` when there was no
`template` would trigger an unhelpful error:
```
Cannot read property 'asEntryPoint' of undefined
```
After this change, it will at least point you in the direction of the
offending component:
```
... | packages/ember-glimmer/lib/renderer.js | @@ -180,6 +180,8 @@ class Renderer {
};
let { _env: env } = this;
let render = () => {
+ assert(`You cannot render \`${self.value()}\` without a template.`, template);
+
let result = template.asEntryPoint().render(self, env, {
appendTo: parentElement,
dynamicScope | false |
Other | emberjs | ember.js | 336974825be2aa061c293561e32a2d1f1a9fd531.json | Add v2.8.0-beta.3 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 30ad5145ba199e35314a8ce4afc1253ddd749c11) | CHANGELOG.md | @@ -1,5 +1,15 @@
# Ember Changelog
+### 2.8.0-beta.3 (August 15, 2016)
+
+- [#14009](https://github.com/emberjs/ember.js/pull/14009) [BUGFIX] Fix usage of `role` when used in `attributeBindings`.
+- [#14044](https://github.com/emberjs/ember.js/pull/14044) / [#14062](https://github.com/emberjs/ember.js/pull/14062) / ... | false |
Other | emberjs | ember.js | 1568459714bbe54d03b6711ea7d3501e08758300.json | Add 2.7.1 to the CHANGELOG.md.
[ci skip]
(cherry picked from commit e6a4a3b00ad1c3e978d9a3692510c90958d28add) | CHANGELOG.md | @@ -18,6 +18,12 @@
- [#13855](https://github.com/emberjs/ember.js/pull/13855) [FEATURE ember-runtime-enumerable-includes] Enable by default.
- [#13855](https://github.com/emberjs/ember.js/pull/13855) [FEATURE ember-testing-check-waiters] Enable by default.
+### 2.7.1 (August 15, 2016)
+
+- [#13920](https://github.c... | false |
Other | emberjs | ember.js | 40fe91a21e39cca4e042278628abf8813b8365f8.json | Add a (failing on Glimmer) test for #13983 | packages/ember-glimmer/tests/integration/syntax/each-test.js | @@ -653,6 +653,52 @@ class SingleEachTest extends AbstractEachTest {
this.assertText('No Thing bar');
}
+ ['@test content that are not initially present updates correctly GH#13983']() {
+ // The root cause of this bug is that Glimmer did not call `didInitializeChildren`
+ // on the inserted `TryOpcode`... | false |
Other | emberjs | ember.js | d981dadc2a58aa63dc8b74c66e06279465b76974.json | Unify another element action modify test
Unsure if we need to be testing the implementation details here, but the
difference is trivial. | packages/ember-glimmer/tests/integration/helpers/element-action-test.js | @@ -167,22 +167,19 @@ moduleFor('Helpers test: element action', class extends RenderingTest {
this.assert.deepEqual(fooArgs, ['a', 'b'], 'foo has been called with an updated value');
}
- ['@htmlbars it should output a data attribute with a guid']() {
+ ['@test it should output a marker attribute with a guid... | false |
Other | emberjs | ember.js | 2f5f485d15ea180e4f1733f8f7e06d8d29314f9e.json | Unify another test
The difference is in Glimmer, the hooks are not called when nothing has
changed. This also refactored the tests to be more readable. | packages/ember-glimmer/tests/integration/components/curly-components-test.js | @@ -1016,103 +1016,75 @@ moduleFor('Components test: curly components', class extends RenderingTest {
this.assertText('In layout - someProp: value set in instance');
}
- // Note: Hooks are not re-run for idempotent re-renders
- ['@glimmer rerendering component with attrs from parent'](assert) {
- let wil... | false |
Other | emberjs | ember.js | 93ae5ab1c7055edc455562cbab15cd7e8418612e.json | Unify another duplicated test | packages/ember-glimmer/tests/integration/components/attrs-lookup-test.js | @@ -127,66 +127,14 @@ moduleFor('Components test: attrs lookup', class extends RenderingTest {
assert.equal(instance.get('woot'), 'yes', 'component found attr after reset');
}
- // HTMLBars runs `didReceiveAttrs` on `rerender`
- ['@htmlbars getAttr() should return the same value as get()'](assert) {
- as... | false |
Other | emberjs | ember.js | cb318bc7fb2d98c8d0434502b9e917f61f50602a.json | Update testem config to use `latest` when possible.
* Use `latest` for Chrome
* Use `latest` for FireFox (was using 45) | testem.dist.json | @@ -6,11 +6,11 @@
"disable_watching": true,
"launchers": {
"SL_Chrome_Current": {
- "command": "npm run sauce:launch -- -b chrome --no-ct -u '<url>'",
+ "command": "npm run sauce:launch -- -p 'Windows 10' -b chrome -v latest --no-ct -u '<url>'",
"protocol": "tap"
},
"SL_Firefox_Cur... | false |
Other | emberjs | ember.js | 18678b75db328f66a67931f8bd8bfde55549a45e.json | Update emberjs-build to v0.14.0.
Updates to a version of emberjs-build that does not use
glimmer-template-precompiler (an obsolete package). Instead it passes
through the current glimmer version to the underlying template
compliation so that the templates shipped with Ember are for the same
version of glimmer that wil... | ember-cli-build.js | @@ -143,6 +143,7 @@ module.exports = function() {
production: getFeatures('production')
},
htmlbars: require('htmlbars'),
+ glimmer: require('glimmer-engine'),
packages: getPackages(features),
vendoredPackages: vendorPackages,
version: version | true |
Other | emberjs | ember.js | 18678b75db328f66a67931f8bd8bfde55549a45e.json | Update emberjs-build to v0.14.0.
Updates to a version of emberjs-build that does not use
glimmer-template-precompiler (an obsolete package). Instead it passes
through the current glimmer version to the underlying template
compliation so that the templates shipped with Ember are for the same
version of glimmer that wil... | package.json | @@ -33,13 +33,13 @@
"ember-cli-sauce": "^1.4.2",
"ember-cli-yuidoc": "0.8.4",
"ember-publisher": "0.0.7",
- "emberjs-build": "0.13.5",
+ "emberjs-build": "0.14.0",
"express": "^4.5.0",
"finalhandler": "^0.4.0",
"git-repo-info": "^1.1.4",
"git-repo-version": "^0.3.1",
"githu... | true |
Other | emberjs | ember.js | 3bdd7b5e68052541fda3c734d9d4c70c2cfa492b.json | Update emberjs-build to 0.13.5.
The cache invalidation issues that were being monkey patched around,
have been fixed upstream in broccoli-babel-transpiler.
These manual hacks are no longer needed. | ember-cli-build.js | @@ -60,27 +60,18 @@ function getFeatures(environment) {
function babelConfigFor(environment) {
var plugins = [];
-
var features = getFeatures(environment);
- var featureFlagPlugin = applyFeatureFlags({
+
+ plugins.push(applyFeatureFlags({
import: { module: 'ember-metal/features' },
features: featur... | true |
Other | emberjs | ember.js | 3bdd7b5e68052541fda3c734d9d4c70c2cfa492b.json | Update emberjs-build to 0.13.5.
The cache invalidation issues that were being monkey patched around,
have been fixed upstream in broccoli-babel-transpiler.
These manual hacks are no longer needed. | package.json | @@ -33,13 +33,13 @@
"ember-cli-sauce": "^1.4.2",
"ember-cli-yuidoc": "0.8.4",
"ember-publisher": "0.0.7",
- "emberjs-build": "0.13.3",
+ "emberjs-build": "0.13.5",
"express": "^4.5.0",
"finalhandler": "^0.4.0",
"git-repo-info": "^1.1.4",
"git-repo-version": "^0.3.1",
"githu... | true |
Other | emberjs | ember.js | ee050f46f6e5c94266db56292ad7a67d64af6333.json | Remove dead code | packages/ember-views/lib/system/platform.js | @@ -1,14 +0,0 @@
-import { environment } from 'ember-environment';
-
-// IE 6/7 have bugs around setting names on inputs during creation.
-// From http://msdn.microsoft.com/en-us/library/ie/ms536389(v=vs.85).aspx:
-// "To include the NAME attribute at run time on objects created with the createElement method, use the e... | false |
Other | emberjs | ember.js | 639763a81183e17cbc9ee218899c0fefab1de8b4.json | Improve coverage for `ArrayProxy` + `{{#each}}` | packages/ember-glimmer/tests/integration/syntax/each-test.js | @@ -135,14 +135,62 @@ class AbstractEachTest extends RenderingTest {
/* abstract */
makeList() {
- // this.list = ...;
+ // this.list = this.delegate = ...;
throw new Error('Not implemented: `makeList`');
}
replaceList(list) {
this.runTask(() => set(this.context, 'list', this.makeList(li... | false |
Other | emberjs | ember.js | a6f3fc4fbbe4371820f66a7c952822aa2e784e60.json | Unify Glimmer and HTMLBars `{{#each}}` tests | packages/ember-glimmer/tests/integration/syntax/each-test.js | @@ -68,59 +68,64 @@ class ArrayLike {
// The following methods are APIs used by the tests
- clear() {
- this._array.length = 0;
- propertyDidChange(this, 'length');
- }
-
objectAt(idx) {
return this._array[idx];
}
+ clear() {
+ this._array.length = 0;
+ this.arrayContentDidChange();
+... | false |
Other | emberjs | ember.js | 868e29c9840592a81f8a67e32262fe28976d762e.json | Add v2.8.0-beta.2 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 7b5186c1c952e480a2712c2f91611f5db9fc0647) | CHANGELOG.md | @@ -1,5 +1,14 @@
# Ember Changelog
+### 2.8.0-beta.2 (August 1, 2016)
+
+- [#13887](https://github.com/emberjs/ember.js/pull/13887) [BUGFIX] Add assertions for illegal component invocations.
+- [#13892](https://github.com/emberjs/ember.js/pull/13892) [CLEANUP] Remove `View#createElement` / `View#destroyElement`.
+- ... | false |
Other | emberjs | ember.js | 5d2a0ffe1a01ded944c64915d0b499fb2408999e.json | Fix version number for alpha. | ember-cli-build.js | @@ -6,9 +6,11 @@
// DISABLE_ES3=true DISABLE_JSCS=true DISABLE_JSHINT=true DISABLE_MIN=true DISABLE_DEREQUIRE=true ember serve --environment=production
var fs = require('fs');
+var path = require('path');
var EmberBuild = require('emberjs-build');
var getPackages = require('./lib/packages');
+var getGitInfo =... | true |
Other | emberjs | ember.js | 5d2a0ffe1a01ded944c64915d0b499fb2408999e.json | Fix version number for alpha. | package.json | @@ -1,7 +1,7 @@
{
"name": "ember",
"license": "MIT",
- "version": "2.9.0-canary",
+ "version": "2.9.0",
"keywords": [
"ember-addon"
],
@@ -33,9 +33,11 @@
"ember-cli-sauce": "^1.4.2",
"ember-cli-yuidoc": "0.8.4",
"ember-publisher": "0.0.7",
- "emberjs-build": "0.12.1",
+ "emberjs... | true |
Other | emberjs | ember.js | 3ce73bb00126f20edb7f5cb9ceb6f1a69ae758bb.json | Fix Glimmer builds
Both template compilers seem to need backburner, hoisting it up. | lib/packages.js | @@ -15,7 +15,7 @@ module.exports = function(features) {
trees: null,
templateCompilerOnly: true,
requirements: ['ember-metal', 'ember-environment', 'ember-console', 'ember-templates'],
- templateCompilerVendor: ['simple-html-tokenizer']
+ templateCompilerVendor: ['simple-html-tokenizer', ... | false |
Other | emberjs | ember.js | ed6ed9ebb070de6e689ac415d46496a0accb9aee.json | Add tests for nested `classNameBindings` paths | packages/ember-glimmer/tests/integration/components/class-bindings-test.js | @@ -45,6 +45,92 @@ moduleFor('ClassNameBindings integration', class extends RenderingTest {
this.assertComponentElement(this.firstChild, { tagName: 'div', attrs: { 'class': classes('ember-view foo enabled sad') }, content: 'hello' });
}
+ ['@test it can have class name bindings with nested paths']() {
+ l... | false |
Other | emberjs | ember.js | 5327eb0f699761c33341487d46334b56bbc4b57a.json | Remove `View#destroyElement` method. | packages/ember-views/lib/mixins/view_support.js | @@ -325,30 +325,6 @@ export default Mixin.create({
*/
willClearRender: K,
- /**
- Destroys any existing element along with the element for any child views
- as well. If the view does not currently have a element, then this method
- will do nothing.
-
- If you implement `willDestroyElement()` on you... | true |
Other | emberjs | ember.js | 5327eb0f699761c33341487d46334b56bbc4b57a.json | Remove `View#destroyElement` method. | packages/ember-views/lib/views/states/default.js | @@ -38,8 +38,6 @@ export default {
return true; // continue event propagation
},
- destroyElement() { },
-
destroy() { },
rerender(view) { | true |
Other | emberjs | ember.js | 5327eb0f699761c33341487d46334b56bbc4b57a.json | Remove `View#destroyElement` method. | packages/ember-views/lib/views/states/destroying.js | @@ -14,9 +14,6 @@ assign(destroying, {
},
rerender() {
throw new EmberError('You can\'t call rerender on a view being destroyed');
- },
- destroyElement() {
- throw new EmberError('You can\'t call destroyElement on a view being destroyed');
}
});
| true |
Other | emberjs | ember.js | 5327eb0f699761c33341487d46334b56bbc4b57a.json | Remove `View#destroyElement` method. | packages/ember-views/lib/views/states/has_element.js | @@ -33,10 +33,6 @@ assign(hasElement, {
view.renderer.rerender(view);
},
- destroyElement(view) {
- view.renderer.remove(view, false);
- },
-
destroy(view) {
view.renderer.remove(view, true);
}, | true |
Other | emberjs | ember.js | 5327eb0f699761c33341487d46334b56bbc4b57a.json | Remove `View#destroyElement` method. | packages/ember-views/tests/views/view/append_to_test.js | @@ -88,28 +88,6 @@ QUnit.test('raises an assert when a target does not exist in the DOM', function(
});
-QUnit.test('remove removes an element from the DOM', function() {
- willDestroyCalled = 0;
-
- view = View.create({
- willDestroyElement() {
- willDestroyCalled++;
- }
- });
-
- ok(!get(view, 'el... | true |
Other | emberjs | ember.js | 5327eb0f699761c33341487d46334b56bbc4b57a.json | Remove `View#destroyElement` method. | packages/ember-views/tests/views/view/destroy_element_test.js | @@ -1,51 +0,0 @@
-import { get } from 'ember-metal/property_get';
-import run from 'ember-metal/run_loop';
-import EmberView from 'ember-views/views/view';
-
-let view;
-
-QUnit.module('EmberView#destroyElement', {
- teardown() {
- run(() => view.destroy());
- }
-});
-
-QUnit.test('if it has no element, does nothi... | true |
Other | emberjs | ember.js | 14eb40ce1d55faa282f3da90dbdcd227fd16db88.json | Add 2.8.0-beta.1 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 1234110eeaca1ef479eb3510897b978b1b0bcc2a) | CHANGELOG.md | @@ -1,5 +1,14 @@
# Ember Changelog
+### 2.8.0-beta.1 (July 25, 2016)
+
+- [#13757](https://github.com/emberjs/ember.js/pull/13757) / [#13773](https://github.com/emberjs/ember.js/pull/13773) [CLEANUP] Remove legacy view layer features.
+- [#13819](https://github.com/emberjs/ember.js/pull/13819) [DOC] Add documentatio... | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.