language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
videojs
video.js
ca2d78fcd4cf25cf3c084f279dda306516cb267f.json
chore(sandbox): switch all urls to https (#6946)
sandbox/index.html.example
@@ -19,12 +19,12 @@ preload="auto" width="640" height="264" - poster="http://vjs.zencdn.net/v/oceans.png"> - <source src="http://vjs.zencdn.net/v/oceans.mp4" type="video/mp4"> - <source src="http://vjs.zencdn.net/v/oceans.webm" type="video/webm"> - <source src="http://vjs.zencdn.net/v/oceans....
true
Other
videojs
video.js
ca2d78fcd4cf25cf3c084f279dda306516cb267f.json
chore(sandbox): switch all urls to https (#6946)
sandbox/language.html.example
@@ -49,9 +49,9 @@ <body> <video id="vid1" class="video-js" controls preload="auto" width="640" height="264" data-setup=''> <!-- - <source src="http://video-js.zencoder.com/oceans-clip.mp4" type='video/mp4'> - <source src="http://video-js.zencoder.com/oceans-clip.webm" type='video/webm'> - <source src=...
true
Other
videojs
video.js
ca2d78fcd4cf25cf3c084f279dda306516cb267f.json
chore(sandbox): switch all urls to https (#6946)
sandbox/live.html.example
@@ -15,7 +15,7 @@ <video-js id="vid1" controls preload="auto" width="640" height="264"> <source src="https://akamai-axtest.akamaized.net/routes/lapd-v1-acceptance/www_c4/Manifest.m3u8" type="application/x-mpegURL"> - <p class="vjs-no-js">To view this video please enable JavaScript, and consider upgrading ...
true
Other
videojs
video.js
ca2d78fcd4cf25cf3c084f279dda306516cb267f.json
chore(sandbox): switch all urls to https (#6946)
sandbox/liveui.html.example
@@ -15,7 +15,7 @@ <video-js id="vid1" controls preload="auto" width="640" height="264"> <source src="https://akamai-axtest.akamaized.net/routes/lapd-v1-acceptance/www_c4/Manifest.m3u8" type="application/x-mpegURL"> - <p class="vjs-no-js">To view this video please enable JavaScript, and consider upgrading ...
true
Other
videojs
video.js
ca2d78fcd4cf25cf3c084f279dda306516cb267f.json
chore(sandbox): switch all urls to https (#6946)
sandbox/pip-disabled.html.example
@@ -20,12 +20,12 @@ preload="none" width="640" height="264" - poster="http://vjs.zencdn.net/v/oceans.png"> - <source src="http://vjs.zencdn.net/v/oceans.mp4" type="video/mp4"> - <source src="http://vjs.zencdn.net/v/oceans.webm" type="video/webm"> - <source src="http://vjs.zencdn.net/v/oceans....
true
Other
videojs
video.js
ca2d78fcd4cf25cf3c084f279dda306516cb267f.json
chore(sandbox): switch all urls to https (#6946)
sandbox/plugin.html.example
@@ -17,10 +17,10 @@ <body> <p style="background-color:#eee; border: 1px solid #777; padding: 10px; font-size: .8em; line-height: 1.5em; font-family: Verdana, sans-serif;">This page shows you how to create, register and initialize a Video.js plugin.</p> - <video id="vid1" class="video-js" controls preload="auto" ...
true
Other
videojs
video.js
ca2d78fcd4cf25cf3c084f279dda306516cb267f.json
chore(sandbox): switch all urls to https (#6946)
sandbox/responsive.html.example
@@ -108,12 +108,12 @@ class="vjs-fluid" controls preload="auto" - poster="http://vjs.zencdn.net/v/oceans.png"> - <source src="http://vjs.zencdn.net/v/oceans.mp4" type="video/mp4"> - <source src="http://vjs.zencdn.net/v/oceans.webm" type="video/webm"> - <source src="http://vjs.zencdn.net/v/oce...
true
Other
videojs
video.js
ca2d78fcd4cf25cf3c084f279dda306516cb267f.json
chore(sandbox): switch all urls to https (#6946)
sandbox/vertical-volume.html.example
@@ -19,12 +19,12 @@ preload="auto" width="640" height="264" - poster="http://vjs.zencdn.net/v/oceans.png"> - <source src="http://vjs.zencdn.net/v/oceans.mp4" type="video/mp4"> - <source src="http://vjs.zencdn.net/v/oceans.webm" type="video/webm"> - <source src="http://vjs.zencdn.net/v/oceans....
true
Other
videojs
video.js
464b971315ee49e2221aee9529ff509f7dfe14a4.json
feat(lang): add thai language translations (#6945) Also, update translations needed docs page.
docs/translations-needed.md
@@ -913,6 +913,7 @@ This default value is hardcoded as a default to the localize method in the SeekB | | Picture-in-Picture | | sv.json (missing 2) | Exit Picture-in-Picture ...
true
Other
videojs
video.js
464b971315ee49e2221aee9529ff509f7dfe14a4.json
feat(lang): add thai language translations (#6945) Also, update translations needed docs page.
lang/th.json
@@ -0,0 +1,89 @@ +{ + "Audio Player": "โปรแกรมเล่นเสียง", + "Video Player": "โปรแกรมเล่นวิดีโอ", + "Play": "เล่น", + "Pause": "หยุดชั่วคราว", + "Replay": "เล่นซ้ำ", + "Current Time": "เวลาปัจจุบัน", + "Duration": "ระยะเวลา", + "Remaining Time": "เวลาที่เหลือ", + "Stream Type": "ประเภทของสตรีม", + "LIVE": "ถ่า...
true
Other
videojs
video.js
694fe0f787f6b9b4edb06e6c87b91c50a8429237.json
fix(menu): focus correct MenuItem on keyboard open (#6914) Closes #6912 Co-authored-by: Aaron Mertzenich <aaron.mertzenich@sonicfoundry.net>
src/js/menu/menu.js
@@ -259,8 +259,7 @@ class Menu extends Component { */ focus(item = 0) { const children = this.children().slice(); - const haveTitle = children.length && children[0].className && - (/vjs-menu-title/).test(children[0].className); + const haveTitle = children.length && children[0].hasClass('vjs-menu...
false
Other
videojs
video.js
a803484a395965fc7c0aac59f9fbf18536ab858d.json
feat(tech): add a scrubbing getter. (#6920) This is helpful for source handlers and anything else that could have customer behavior for when we're scrubbing or not.
src/js/tech/html5.js
@@ -54,6 +54,8 @@ class Html5 extends Tech { this.setupSourcesetHandling_(); } + this.isScrubbing_ = false; + if (this.el_.hasChildNodes()) { const nodes = this.el_.childNodes; @@ -537,6 +539,17 @@ class Html5 extends Tech { this.isScrubbing_ = isScrubbing; } + /** + * Get wh...
true
Other
videojs
video.js
a803484a395965fc7c0aac59f9fbf18536ab858d.json
feat(tech): add a scrubbing getter. (#6920) This is helpful for source handlers and anything else that could have customer behavior for when we're scrubbing or not.
src/js/tech/tech.js
@@ -501,6 +501,15 @@ class Tech extends Component { */ setScrubbing() {} + /** + * Get whether we are scrubbing or not + * + * @abstract + * + * @see {Html5#scrubbing} + */ + scrubbing() {} + /** * Causes a manual time update to occur if {@link Tech#manualTimeUpdatesOn} was * previousl...
true
Other
videojs
video.js
f22ead10f09b89b33c996adc3cd848cfce7a635e.json
docs: Fix simple typo, intial -> initial (#6851) There is a small typo in src/js/player.js, src/js/tech/html5.js, test/unit/sourceset.test.js. Should read `initial` rather than `intial`.
src/js/player.js
@@ -1575,7 +1575,7 @@ class Player extends Component { } } - // update the source to the intial source right away + // update the source to the initial source right away // in some cases this will be empty string updateSourceCaches(eventSrc); @@ -3335,7 +3335,7 @@ class Playe...
true
Other
videojs
video.js
f22ead10f09b89b33c996adc3cd848cfce7a635e.json
docs: Fix simple typo, intial -> initial (#6851) There is a small typo in src/js/player.js, src/js/tech/html5.js, test/unit/sourceset.test.js. Should read `initial` rather than `intial`.
src/js/tech/html5.js
@@ -1475,7 +1475,7 @@ Html5.resetMediaElement = function(el) { /** * Set the value of `defaultMuted` on the media element. `defaultMuted` indicates that the current - * audio level should be silent, but will only effect the muted level on intial playback.. + * audio level should be silent, but will only ef...
true
Other
videojs
video.js
f22ead10f09b89b33c996adc3cd848cfce7a635e.json
docs: Fix simple typo, intial -> initial (#6851) There is a small typo in src/js/player.js, src/js/tech/html5.js, test/unit/sourceset.test.js. Should read `initial` rather than `intial`.
test/unit/sourceset.test.js
@@ -746,7 +746,7 @@ QUnit[qunitFn]('sourceset', function(hooks) { this.mediaEl = this.player.tech_.el(); }); - // intial sourceset should happen on player.ready + // initial sourceset should happen on player.ready this.player.one('sourceset', (e) => { validateSour...
true
Other
videojs
video.js
7192be6257cfc9340f0d1151e42bde165c2de7db.json
chore(package): Update @videojs/http-streaming to 1.13.4 (#6839) Fixes #6812
package-lock.json
@@ -1267,19 +1267,30 @@ } }, "@videojs/http-streaming": { - "version": "1.13.3", - "resolved": "https://registry.npmjs.org/@videojs/http-streaming/-/http-streaming-1.13.3.tgz", - "integrity": "sha512-rOEShTytYchSxTKR5YvQ91mDN0b3BVOGoBSVzbgMbT8pOm2FEZ1G5dWuLtUpBnvFTPb0cxnTGmISwllPq3EWYg==...
true
Other
videojs
video.js
7192be6257cfc9340f0d1151e42bde165c2de7db.json
chore(package): Update @videojs/http-streaming to 1.13.4 (#6839) Fixes #6812
package.json
@@ -82,7 +82,7 @@ }, "dependencies": { "@babel/runtime": "^7.9.2", - "@videojs/http-streaming": "1.13.3", + "@videojs/http-streaming": "1.13.4", "@videojs/xhr": "2.5.1", "global": "4.3.2", "keycode": "^2.2.0",
true
Other
videojs
video.js
c91b510ef2e5826f450eae9852fec9d5627a05ba.json
fix(tech): add abstract setScrubbing in tech.js (#6808)
src/js/tech/html5.js
@@ -524,6 +524,15 @@ class Html5 extends Tech { }); } + /** + * Set whether we are scrubbing or not. + * This is used to decide whether we should use `fastSeek` or not. + * `fastSeek` is used to provide trick play on Safari browsers. + * + * @param {boolean} isScrubbing + * - tru...
true
Other
videojs
video.js
c91b510ef2e5826f450eae9852fec9d5627a05ba.json
fix(tech): add abstract setScrubbing in tech.js (#6808)
src/js/tech/tech.js
@@ -483,6 +483,15 @@ class Tech extends Component { return createTimeRange(); } + /** + * Set whether we are scrubbing or not + * + * @abstract + * + * @see {Html5#setScrubbing} + */ + setScrubbing() {} + /** * Causes a manual time update to occur if {@link Tech#manualTimeUpdatesOn} was ...
true
Other
videojs
video.js
88850e94af287bff6322f828c50a10b78a289589.json
fix(lang): Add PiP to de (#6803)
docs/translations-needed.md
@@ -279,8 +279,7 @@ This default value is hardcoded as a default to the localize method in the SeekB | | {1} is loading. | | | Exit Picture-in-Picture ...
true
Other
videojs
video.js
88850e94af287bff6322f828c50a10b78a289589.json
fix(lang): Add PiP to de (#6803)
lang/de.json
@@ -83,6 +83,8 @@ "Volume Level": "Lautstärke", "{1} is loading.": "{1} wird geladen.", "Seek to live, currently behind live": "Zur Live-Übertragung wechseln. Aktuell wird es nicht live abgespielt.", - "Seek to live, currently playing live": "Zur Live-Übertragung wechseln. Es wird aktuell live abgespielt." - ...
true
Other
videojs
video.js
245efacb59d1cf95cd429a4324cbcb6377630a98.json
fix(tech): add abstract crossOrigin method on Tech (#6765) As part of #6588, we started using the crossOrigin method. However, it's possible that a tech doesn't support this. Notably, the Flash tech. We should instead have an abstract method on Tech that returns nothing so we don't fail on those browsers.
src/js/tech/tech.js
@@ -430,6 +430,25 @@ class Tech extends Component { */ reset() {} + /** + * Get the value of `crossOrigin` from the tech. + * + * @abstract + * + * @see {Html5#crossOrigin} + */ + crossOrigin() {} + + /** + * Set the value of `crossOrigin` on the tech. + * + * @abstract + * + * @param ...
false
Other
videojs
video.js
3d505ef0c53ee2a886f41891ab56ead6deb67257.json
feat: add debug mode (#6687) When `debug(true)` is called, it will fire a `debugon` event that plugins and components can then use to do extra logging or anything else that's helpful to for debugging. It will also set the log level to debug. When `debug(false)` is called, it will fire a `debugoff` event that plugin...
src/js/player.js
@@ -379,6 +379,9 @@ class Player extends Component { // Init state userActive_ this.userActive_ = false; + // Init debugEnabled_ + this.debugEnabled_ = false; + // if the global option object was accidentally blown away by // someone, bail early with an informative error if (!this.optio...
true
Other
videojs
video.js
3d505ef0c53ee2a886f41891ab56ead6deb67257.json
feat: add debug mode (#6687) When `debug(true)` is called, it will fire a `debugon` event that plugins and components can then use to do extra logging or anything else that's helpful to for debugging. It will also set the log level to debug. When `debug(false)` is called, it will fire a `debugoff` event that plugin...
test/unit/player.test.js
@@ -2259,6 +2259,62 @@ QUnit.test('Should accept multiple calls to currentTime after player initializat assert.equal(player.currentTime(), 800, 'The last value passed is stored as the currentTime value'); }); +QUnit.test('Should fire debugon event when debug mode is enabled', function(assert) { + const player = ...
true
Other
videojs
video.js
cad9114b2e8994fd51c2dd88a15efffbdb0b2b8a.json
fix: Use clamp correctly in progress control (#6625)
src/js/control-bar/progress-control/progress-control.js
@@ -75,7 +75,7 @@ class ProgressControl extends Component { // The default skin has a gap on either side of the `SeekBar`. This means // that it's possible to trigger this behavior outside the boundaries of // the `SeekBar`. This ensures we stay within it at all times. - seekBarPoint = clamp(0, 1, see...
false
Other
videojs
video.js
d90569fed6a64c93429c606e3f0d124d29cf1b8a.json
fix: add PiP to zh-CN.json (#6680) add "Picture-in-Picture" & "Exit Picture-in-Picture"
lang/zh-CN.json
@@ -10,6 +10,8 @@ "Progress": "进度", "Fullscreen": "全屏", "Non-Fullscreen": "退出全屏", + "Picture-in-Picture": "画中画", + "Exit Picture-in-Picture": "退出画中画", "Mute": "静音", "Unmute": "取消静音", "Playback Rate": "播放速度",
false
Other
videojs
video.js
808d818c7d8ee8467003e6958172840736b6389c.json
docs(faq): update FAQ about HLS and DASH with VHS (#6608) Fixes #6590
docs/guides/faq.md
@@ -53,8 +53,8 @@ Video.js is an extendable framework/library around the native video element. It * Offers an extendable and themable UI * Ensures accessibility for keyboard and screen reader users * Has a set of core plugins that offer support for additional video formats: - * [videojs-contrib-hls][hls] - * [vide...
false
Other
videojs
video.js
8f930c5857e10974b4578e489c63bf7fb322a236.json
docs(angular): fix demo for angular v8+. (#6581) Without the `static: true` property, an `not defined ReferenceError` will be thrown since the target is null on init.
docs/guides/angular.md
@@ -20,7 +20,7 @@ import videojs from 'video.js'; encapsulation: ViewEncapsulation.None, }) export class VjsPlayerComponent implements OnInit, OnDestroy { - @ViewChild('target') target: ElementRef; + @ViewChild('target', {static: true}) target: ElementRef; // see options: https://github.com/videojs/video.js/b...
false
Other
videojs
video.js
fce3ad23b9f0a8b596385b81bd925120382c2256.json
docs: add an example Angular integration (#6390)
docs/guides/angular.md
@@ -0,0 +1,65 @@ +# Video.js and Angular integration + +Here's a basic Angular player implementation. + +It just instantiates the Video.js player on `OnInit` and destroys it on `OnDestroy`. + +```ts +// vjs-player.component.ts +import { Component, ElementRef, Input, OnDestroy, OnInit, ViewChild, ViewEncapsulation } fro...
false
Other
videojs
video.js
47349c8e2909b477bf9117315d52a2ceee694edb.json
fix: add a threshold of 30s for the liveui to show (#6409)
src/js/live-tracker.js
@@ -5,12 +5,18 @@ import document from 'global/document'; import * as browser from './utils/browser.js'; import * as Fn from './utils/fn.js'; +const defaults = { + // Number of seconds of live window (seekableEnd - seekableStart) that + // a video needs to have before the liveui will be shown. + trackingThreshol...
true
Other
videojs
video.js
47349c8e2909b477bf9117315d52a2ceee694edb.json
fix: add a threshold of 30s for the liveui to show (#6409)
src/js/player.js
@@ -2465,12 +2465,8 @@ class Player extends Component { if (seconds === Infinity) { this.addClass('vjs-live'); - if (this.options_.liveui && this.player_.liveTracker) { - this.addClass('vjs-liveui'); - } } else { this.removeClass('vjs-live'); - this.remove...
true
Other
videojs
video.js
47349c8e2909b477bf9117315d52a2ceee694edb.json
fix: add a threshold of 30s for the liveui to show (#6409)
test/unit/live-tracker.test.js
@@ -4,12 +4,62 @@ import {createTimeRanges} from '../../src/js/utils/time-ranges.js'; import sinon from 'sinon'; QUnit.module('LiveTracker', () => { + QUnit.module('options', { + beforeEach() { + this.clock = sinon.useFakeTimers(); + }, + afterEach() { + this.player.dispose(); + this.clock....
true
Other
videojs
video.js
47349c8e2909b477bf9117315d52a2ceee694edb.json
fix: add a threshold of 30s for the liveui to show (#6409)
test/unit/seek-to-live.test.js
@@ -2,6 +2,7 @@ import TestHelpers from './test-helpers.js'; import sinon from 'sinon'; import computedStyle from '../../src/js/utils/computed-style.js'; +import { createTimeRange } from '../../src/js/utils/time-ranges.js'; QUnit.module('SeekToLive', () => { QUnit.module('live with liveui', { @@ -10,6 +11,7 @@...
true
Other
videojs
video.js
5682f14ccd61311427ee9f14558229a7132d1536.json
fix: fix a typo in en translation file (#6505)
lang/en.json
@@ -46,7 +46,7 @@ ", opens descriptions settings dialog": ", opens descriptions settings dialog", ", selected": ", selected", "captions settings": "captions settings", - "subtitles settings": "subititles settings", + "subtitles settings": "subtitles settings", "descriptions settings": "descriptions settin...
false
Other
videojs
video.js
31ac9d7a58fda2436c2dc580bd1f2571d7e5de7b.json
fix(lang): improve Persian translation (#6468)
docs/translations-needed.md
@@ -13,11 +13,12 @@ This default value is hardcoded as a default to the localize method in the SeekB ## Status of translations <!-- START langtable --> - | Language file | Missing translations | | ----------------------- | ------------------...
true
Other
videojs
video.js
31ac9d7a58fda2436c2dc580bd1f2571d7e5de7b.json
fix(lang): improve Persian translation (#6468)
lang/en.json
@@ -83,5 +83,7 @@ "Caption Settings Dialog": "Caption Settings Dialog", "Beginning of dialog window. Escape will cancel and close the window.": "Beginning of dialog window. Escape will cancel and close the window.", "End of dialog window.": "End of dialog window.", - "{1} is loading.": "{1} is loading." + "{...
true
Other
videojs
video.js
31ac9d7a58fda2436c2dc580bd1f2571d7e5de7b.json
fix(lang): improve Persian translation (#6468)
lang/fa.json
@@ -1,49 +1,51 @@ { - "Audio Player": "پخش کننده صوتی", + "Audio Player": "پخش کننده صوت", "Video Player": "پخش کننده ویدیو", "Play": "پخش", - "Pause": "مکث", - "Replay": "بازپخش", - "Current Time": "زمان کنونی", - "Duration": "مدت زمان", - "Remaining Time": "زمان باقیمانده", + "Pause": "توقف", + "Repla...
true
Other
videojs
video.js
e4e8837dede30ff759176738b8388138f6ac782f.json
fix(package): update @videojs/http-streaming to version 1.12.1 (#6467) Closes #6430
package-lock.json
@@ -942,17 +942,40 @@ } }, "@videojs/http-streaming": { - "version": "1.11.2", - "resolved": "https://registry.npmjs.org/@videojs/http-streaming/-/http-streaming-1.11.2.tgz", - "integrity": "sha512-v9Z6wEpGUFxNdnGdaqaMAjosQbkdH3HoO31mYk+cyCoeXYKZYmAfd+Lf5Cwkle+EVqqcXBGfz27aaBUeaQ0vpg==",...
true
Other
videojs
video.js
e4e8837dede30ff759176738b8388138f6ac782f.json
fix(package): update @videojs/http-streaming to version 1.12.1 (#6467) Closes #6430
package.json
@@ -81,7 +81,7 @@ }, "dependencies": { "@babel/runtime": "^7.5.5", - "@videojs/http-streaming": "1.11.2", + "@videojs/http-streaming": "1.12.1", "@videojs/xhr": "2.5.1", "global": "4.3.2", "keycode": "^2.2.0",
true
Other
videojs
video.js
7bbd0ca0c49b6553e8ced8e4dab1f2f5dba2927b.json
fix(package): update videojs-vtt.js to version 0.15.2 (#6333) Closes #6332
package-lock.json
@@ -14151,7 +14151,6 @@ "keycode": "^2.2.0", "safe-json-parse": "4.0.0", "videojs-font": "3.2.0", - "videojs-vtt.js": "^0.14.1", "xhr": "2.4.0" }, "dependencies": { @@ -14285,9 +14284,9 @@ "dev": true }, "videojs-vtt.js": { - "version": "0.1...
true
Other
videojs
video.js
7bbd0ca0c49b6553e8ced8e4dab1f2f5dba2927b.json
fix(package): update videojs-vtt.js to version 0.15.2 (#6333) Closes #6332
package.json
@@ -87,7 +87,7 @@ "keycode": "^2.2.0", "safe-json-parse": "4.0.0", "videojs-font": "3.2.0", - "videojs-vtt.js": "^0.14.1" + "videojs-vtt.js": "^0.15.2" }, "devDependencies": { "@babel/core": "^7.4.5",
true
Other
videojs
video.js
b414c60461fe45f4568aa19ae74d7055fdf6e62e.json
fix(pkg): update @videojs/http-streaming to 1.11.2 (#6323)
package-lock.json
@@ -1,6 +1,6 @@ { "name": "video.js", - "version": "7.6.4", + "version": "7.6.6", "lockfileVersion": 1, "requires": true, "dependencies": { @@ -942,15 +942,15 @@ } }, "@videojs/http-streaming": { - "version": "1.10.6", - "resolved": "https://registry.npmjs.org/@videojs/http-str...
true
Other
videojs
video.js
b414c60461fe45f4568aa19ae74d7055fdf6e62e.json
fix(pkg): update @videojs/http-streaming to 1.11.2 (#6323)
package.json
@@ -80,14 +80,14 @@ "url": "https://github.com/videojs/video.js.git" }, "dependencies": { - "@videojs/http-streaming": "1.10.6", "@babel/runtime": "^7.5.5", + "@videojs/http-streaming": "1.11.2", + "@videojs/xhr": "2.5.1", "global": "4.3.2", "keycode": "^2.2.0", "safe-json-parse"...
true
Other
videojs
video.js
a11f3fa574048b4f73aa0c6586990c1945aa928c.json
fix: detect iPadOS as IS_IPAD (#6319) iPadOS defaults to desktop mode unless Safari is opened in split screen mode. The only way to detect it is to assume that Safari with Touch enabled is iPad. This is good enough until and if a better way to detect it is made available.
src/js/utils/browser.js
@@ -9,27 +9,6 @@ const USER_AGENT = window.navigator && window.navigator.userAgent || ''; const webkitVersionMap = (/AppleWebKit\/([\d.]+)/i).exec(USER_AGENT); const appleWebkitVersion = webkitVersionMap ? parseFloat(webkitVersionMap.pop()) : null; -/** - * Whether or not this device is an iPad. - * - * @static - *...
false
Other
videojs
video.js
e37996d3c3f031683f267e70273b4cd07b1d014c.json
fix(lang): Update Norwegian translations (#6220)
docs/translations-needed.md
@@ -13,7 +13,6 @@ This default value is hardcoded as a default to the localize method in the SeekB ## Status of translations <!-- START langtable --> - | Language file | Missing translations | | ----------------------- | --------------------...
true
Other
videojs
video.js
e37996d3c3f031683f267e70273b4cd07b1d014c.json
fix(lang): Update Norwegian translations (#6220)
lang/nb.json
@@ -1,26 +1,87 @@ { + "Audio Player": "Lydspiller", + "Video Player": "Videospiller", "Play": "Spill", "Pause": "Pause", + "Replay": "Spill om igjen", "Current Time": "Aktuell tid", "Duration": "Varighet", "Remaining Time": "Gjenstående tid", "Stream Type": "Type strøm", "LIVE": "DIREKTE", + "...
true
Other
videojs
video.js
e37996d3c3f031683f267e70273b4cd07b1d014c.json
fix(lang): Update Norwegian translations (#6220)
lang/nn.json
@@ -1,26 +1,87 @@ { + "Audio Player": "Ljudspelar", + "Video Player": "Videospelar", "Play": "Spel", "Pause": "Pause", + "Replay": "Spel om att", "Current Time": "Aktuell tid", "Duration": "Varigheit", "Remaining Time": "Tid attende", "Stream Type": "Type straum", "LIVE": "DIREKTE", + "Seek to...
true
Other
videojs
video.js
de2daead6526683ba2ff441ccb4d7dfd9ccf8a98.json
chore: ignore sandbox during linting (#6208)
package.json
@@ -155,6 +155,7 @@ "ignore": [ "dist", "docs", + "sandbox", "test/dist", "test/api", "core.js"
false
Other
videojs
video.js
4134a9734bea15082bdf8bf178ee09b08b3f8ca8.json
test: run tests via rollup (#5601)
build/sandbox.js
@@ -7,12 +7,12 @@ const sh = require('shelljs'); const files = sh.find(path.join(__dirname, '..', 'sandbox', '**', '*.*')) .filter((filepath) => path.extname(filepath) === '.example'); -const changes = files.map(function(file) { - const p = path.parse(file.path); +const changes = files.map(function(filepath) { +...
true
Other
videojs
video.js
4134a9734bea15082bdf8bf178ee09b08b3f8ca8.json
test: run tests via rollup (#5601)
package-lock.json
@@ -1485,6 +1485,12 @@ "lodash": "^4.17.14" } }, + "async-array-reduce": { + "version": "0.2.1", + "resolved": "https://registry.npmjs.org/async-array-reduce/-/async-array-reduce-0.2.1.tgz", + "integrity": "sha1-yL4BCitc0A3qlsgRFgNGk9/dgtE=", + "dev": true + }, "async...
true
Other
videojs
video.js
4134a9734bea15082bdf8bf178ee09b08b3f8ca8.json
test: run tests via rollup (#5601)
package.json
@@ -96,10 +96,8 @@ "@babel/preset-env": "^7.4.5", "access-sniff": "^3.2.0", "autoprefixer": "^9.6.0", - "babelify": "^10.0.0", "bestzip": "^2.1.4", "browserify": "^16.2.3", - "browserify-istanbul": "^3.0.1", "chokidar-cli": "^1.2.2", "clean-css-cli": "^4.3.0", "cli-table": ...
true
Other
videojs
video.js
4134a9734bea15082bdf8bf178ee09b08b3f8ca8.json
test: run tests via rollup (#5601)
rollup.config.js
@@ -9,6 +9,8 @@ import ignore from 'rollup-plugin-ignore'; import alias from 'rollup-plugin-alias'; import _ from 'lodash'; import pkg from './package.json'; +import multiEntry from 'rollup-plugin-multi-entry'; +import stub from 'rollup-plugin-stub'; const compiledLicense = _.template(fs.readFileSync('./build/lic...
true
Other
videojs
video.js
4134a9734bea15082bdf8bf178ee09b08b3f8ca8.json
test: run tests via rollup (#5601)
src/js/utils/url.js
@@ -150,11 +150,19 @@ export const getFileExtension = function(path) { * @param {string} url * The url to check. * + * @param {Object} [winLoc] + * the domain to check the url against, defaults to window.location + * + * @param {string} [winLoc.protocol] + * The window locat...
true
Other
videojs
video.js
4134a9734bea15082bdf8bf178ee09b08b3f8ca8.json
test: run tests via rollup (#5601)
test/globals-shim.js
@@ -1,19 +0,0 @@ -/* eslint-env qunit */ -import 'es5-shim'; -import 'es6-shim'; -import document from 'global/document'; -import window from 'global/window'; -import sinon from 'sinon'; - -window.q = QUnit; -window.sinon = sinon; - -// There's nowhere we require completing xhr requests -// and raynos/xhr doesn't want ...
true
Other
videojs
video.js
4134a9734bea15082bdf8bf178ee09b08b3f8ca8.json
test: run tests via rollup (#5601)
test/karma.conf.js
@@ -30,34 +30,17 @@ module.exports = function(config) { }); config.files = [ + 'node_modules/es5-shim/es5-shim.js', + 'node_modules/es6-shim/es6-shim.js', + 'node_modules/sinon/pkg/sinon.js', 'dist/video-js.css', - 'test/globals-shim.js', - 'test/unit/**/*.js', + 'test/dist/bundle.js', ...
true
Other
videojs
video.js
4134a9734bea15082bdf8bf178ee09b08b3f8ca8.json
test: run tests via rollup (#5601)
test/unit/component.test.js
@@ -791,7 +791,7 @@ QUnit.test('should emit a tap event', function(assert) { assert.expect(3); // Fake touch support. Real touch support isn't needed for this test. - browser.TOUCH_ENABLED = true; + browser.stub_TOUCH_ENABLED(true); comp.emitTapEvents(); comp.on('tap', function() { @@ -839,7 +839,7 @@...
true
Other
videojs
video.js
4134a9734bea15082bdf8bf178ee09b08b3f8ca8.json
test: run tests via rollup (#5601)
test/unit/player.test.js
@@ -14,6 +14,7 @@ import sinon from 'sinon'; import window from 'global/window'; import * as middleware from '../../src/js/tech/middleware.js'; import * as Events from '../../src/js/utils/events.js'; +import pkg from '../../package.json'; QUnit.module('Player', { beforeEach() { @@ -703,13 +704,13 @@ QUnit.test...
true
Other
videojs
video.js
4134a9734bea15082bdf8bf178ee09b08b3f8ca8.json
test: run tests via rollup (#5601)
test/unit/poster.test.js
@@ -1,13 +1,11 @@ /* eslint-env qunit */ import PosterImage from '../../src/js/poster-image.js'; -import * as browser from '../../src/js/utils/browser.js'; import TestHelpers from './test-helpers.js'; import document from 'global/document'; QUnit.module('PosterImage', { beforeEach() { // Store the origin...
true
Other
videojs
video.js
4134a9734bea15082bdf8bf178ee09b08b3f8ca8.json
test: run tests via rollup (#5601)
test/unit/tech/html5.test.js
@@ -126,17 +126,17 @@ QUnit.test('blacklist playbackRate support on older verisons of Chrome on Androi const oldIsChrome = browser.IS_CHROME; const oldChromeVersion = browser.CHROME_VERSION; - browser.IS_ANDROID = true; - browser.IS_CHROME = true; - browser.CHROME_VERSION = 50; + browser.stub_IS_ANDROID(tru...
true
Other
videojs
video.js
4134a9734bea15082bdf8bf178ee09b08b3f8ca8.json
test: run tests via rollup (#5601)
test/unit/tracks/text-track-display.test.js
@@ -52,7 +52,7 @@ QUnit.test('if native text tracks are not supported, create a texttrackdisplay', textTracks: [] }; - browser.IS_FIREFOX = true; + browser.stub_IS_FIREFOX(true); const fakeTTDSpy = sinon.spy(); @@ -70,7 +70,7 @@ QUnit.test('if native text tracks are not supported, create a texttrackd...
true
Other
videojs
video.js
4134a9734bea15082bdf8bf178ee09b08b3f8ca8.json
test: run tests via rollup (#5601)
test/unit/tracks/text-track.test.js
@@ -7,14 +7,23 @@ import TextTrack from '../../../src/js/tracks/text-track.js'; import TestHelpers from '../test-helpers.js'; import sinon from 'sinon'; import log from '../../../src/js/utils/log.js'; +import XHR from '@videojs/xhr'; QUnit.module('Text Track', { beforeEach() { this.tech = new TechFaker();...
true
Other
videojs
video.js
4134a9734bea15082bdf8bf178ee09b08b3f8ca8.json
test: run tests via rollup (#5601)
test/unit/tracks/text-tracks.test.js
@@ -231,16 +231,16 @@ QUnit.test('emulated tracks are always used, except in safari', function(assert) textTracks: [] }; - browser.IS_ANY_SAFARI = false; + browser.stub_IS_ANY_SAFARI(false); assert.ok(!Html5.supportsNativeTextTracks(), 'Html5 does not support native text tracks, in non-safari'); - b...
true
Other
videojs
video.js
4134a9734bea15082bdf8bf178ee09b08b3f8ca8.json
test: run tests via rollup (#5601)
test/unit/utils/url.test.js
@@ -2,8 +2,6 @@ import document from 'global/document'; import window from 'global/window'; import * as Url from '../../../src/js/utils/url.js'; -import proxyquireify from 'proxyquireify'; -const proxyquire = proxyquireify(require); QUnit.module('url'); QUnit.test('should parse the details of a url correctly', f...
true
Other
videojs
video.js
4134a9734bea15082bdf8bf178ee09b08b3f8ca8.json
test: run tests via rollup (#5601)
test/unit/video.test.js
@@ -227,13 +227,6 @@ QUnit.test('should expose options and players properties for backward-compatibil }); QUnit.test('should expose DOM functions', function(assert) { - const origWarnLog = log.warn; - const warnLogs = []; - - log.warn = (args) => { - warnLogs.push(args); - }; - const methods = [ 'isE...
true
Other
videojs
video.js
4134a9734bea15082bdf8bf178ee09b08b3f8ca8.json
test: run tests via rollup (#5601)
test/unit/videojs-integration.test.js
@@ -18,35 +18,35 @@ QUnit.test('create a real player and dispose', function(assert) { // see https://github.com/videojs/video.js/issues/5858 old.bind = Fn.bind; - Fn.bind = function(context, fn, uid) { + Fn.stub_bind(function(context, fn, uid) { const retval = old.bind(context, fn, uid); retval.og...
true
Other
videojs
video.js
064fcafd44a0bb775c084c646d9947146693900e.json
feat: add isDisposed method to components (#6099)
docs/guides/player-workflows.md
@@ -54,6 +54,10 @@ Additionally, these actions are recursively applied to _all_ the player's child > **Note**: Do _not_ remove players via standard DOM removal methods: this will leave listeners and other objects in memory that you might not be able to clean up! +### Checking if a Player is Disposed + +At times, i...
true
Other
videojs
video.js
064fcafd44a0bb775c084c646d9947146693900e.json
feat: add isDisposed method to components (#6099)
src/js/component.js
@@ -58,6 +58,8 @@ class Component { this.player_ = player; } + this.isDisposed_ = false; + // Hold the reference to the parent component via `addChild` method this.parentComponent_ = null; @@ -124,18 +126,25 @@ class Component { */ dispose() { + // Bail out if the component has ...
true
Other
videojs
video.js
064fcafd44a0bb775c084c646d9947146693900e.json
feat: add isDisposed method to components (#6099)
test/unit/component.test.js
@@ -340,6 +340,7 @@ QUnit.test('should dispose of component and children', function(assert) { const child = comp.addChild('Component'); assert.ok(comp.children().length === 1); + assert.notOk(comp.isDisposed(), 'the component reports that it is not disposed'); // Add a listener comp.on('click', functio...
true
Other
videojs
video.js
f47939c7c5ca862ea2ddd2c28ced64b25b315cb5.json
chore(package): update http-streaming to 1.10.6 (#6205) Fixes videojs/http-streaming#312.
package-lock.json
@@ -1031,15 +1031,15 @@ } }, "@videojs/http-streaming": { - "version": "1.10.3", - "resolved": "https://registry.npmjs.org/@videojs/http-streaming/-/http-streaming-1.10.3.tgz", - "integrity": "sha512-fxXtwVrQBdhOFh6GymPAPCb4utCI01Zs5fdyZgtR6FSsaz/zGmnzfNS5GvNjBi/hZviMsbNPFaOTTFMMNLNA3A==...
true
Other
videojs
video.js
f47939c7c5ca862ea2ddd2c28ced64b25b315cb5.json
chore(package): update http-streaming to 1.10.6 (#6205) Fixes videojs/http-streaming#312.
package.json
@@ -81,7 +81,7 @@ }, "dependencies": { "@babel/runtime": "^7.4.5", - "@videojs/http-streaming": "1.10.3", + "@videojs/http-streaming": "1.10.6", "global": "4.3.2", "keycode": "^2.2.0", "safe-json-parse": "4.0.0",
true
Other
videojs
video.js
549552ed43b1d1e124eced379a03551e076ec8af.json
fix: remove deprecated tsml dependency (#6174)
package-lock.json
@@ -827,9 +827,9 @@ }, "dependencies": { "core-js": { - "version": "3.1.4", - "resolved": "https://registry.npmjs.org/core-js/-/core-js-3.1.4.tgz", - "integrity": "sha512-YNZN8lt82XIMLnLirj9MhKDFZHalwzzrL9YLt6eb0T5D0EDl4IQ90IGkua8mHbnxNrkj1d8hbdizMc0Qmg1WnQ==", + ...
true
Other
videojs
video.js
549552ed43b1d1e124eced379a03551e076ec8af.json
fix: remove deprecated tsml dependency (#6174)
package.json
@@ -85,7 +85,6 @@ "global": "4.3.2", "keycode": "^2.2.0", "safe-json-parse": "4.0.0", - "tsml": "1.0.1", "videojs-font": "3.2.0", "videojs-vtt.js": "^0.14.1", "xhr": "2.4.0"
true
Other
videojs
video.js
549552ed43b1d1e124eced379a03551e076ec8af.json
fix: remove deprecated tsml dependency (#6174)
src/js/player.js
@@ -7,7 +7,6 @@ import Component from './component.js'; import {version} from '../../package.json'; import document from 'global/document'; import window from 'global/window'; -import tsml from 'tsml'; import evented from './mixins/evented'; import {isEvented, addEventedCallback} from './mixins/evented'; import *...
true
Other
videojs
video.js
549552ed43b1d1e124eced379a03551e076ec8af.json
fix: remove deprecated tsml dependency (#6174)
src/js/tech/html5.js
@@ -5,7 +5,6 @@ import Tech from './tech.js'; import * as Dom from '../utils/dom.js'; import * as Url from '../utils/url.js'; import log from '../utils/log.js'; -import tsml from 'tsml'; import * as browser from '../utils/browser.js'; import document from 'global/document'; import window from 'global/window'; @@ ...
true
Other
videojs
video.js
549552ed43b1d1e124eced379a03551e076ec8af.json
fix: remove deprecated tsml dependency (#6174)
src/js/utils/dom.js
@@ -5,7 +5,6 @@ import document from 'global/document'; import window from 'global/window'; import log from './log.js'; -import tsml from 'tsml'; import {isObject} from './obj'; import computedStyle from './computed-style'; @@ -151,9 +150,9 @@ export function createEl(tagName = 'div', properties = {}, attributes...
true
Other
videojs
video.js
8610f9967340b9ae7fc73d41ff0e9d17a54b0604.json
perf: Use WeakMap for dom data (#6103)
src/js/component.js
@@ -7,7 +7,7 @@ import window from 'global/window'; import evented from './mixins/evented'; import stateful from './mixins/stateful'; import * as Dom from './utils/dom.js'; -import * as DomData from './utils/dom-data'; +import DomData from './utils/dom-data'; import * as Fn from './utils/fn.js'; import * as Guid f...
true
Other
videojs
video.js
8610f9967340b9ae7fc73d41ff0e9d17a54b0604.json
perf: Use WeakMap for dom data (#6103)
src/js/utils/dom-data.js
@@ -2,8 +2,6 @@ * @file dom-data.js * @module dom-data */ -import * as Guid from './guid.js'; -import window from 'global/window'; /** * Element Data Store. @@ -15,85 +13,4 @@ import window from 'global/window'; * @type {Object} * @private */ -export const elData = {}; - -/* - * Unique attribute name t...
true
Other
videojs
video.js
8610f9967340b9ae7fc73d41ff0e9d17a54b0604.json
perf: Use WeakMap for dom data (#6103)
src/js/utils/events.js
@@ -7,7 +7,7 @@ * @file events.js * @module events */ -import * as DomData from './dom-data'; +import DomData from './dom-data'; import * as Guid from './guid.js'; import log from './log.js'; import window from 'global/window'; @@ -23,7 +23,10 @@ import document from 'global/document'; * Type of event...
true
Other
videojs
video.js
8610f9967340b9ae7fc73d41ff0e9d17a54b0604.json
perf: Use WeakMap for dom data (#6103)
test/unit/component.test.js
@@ -2,7 +2,7 @@ import window from 'global/window'; import Component from '../../src/js/component.js'; import * as Dom from '../../src/js/utils/dom.js'; -import * as DomData from '../../src/js/utils/dom-data'; +import DomData from '../../src/js/utils/dom-data'; import * as Events from '../../src/js/utils/events.js'...
true
Other
videojs
video.js
8610f9967340b9ae7fc73d41ff0e9d17a54b0604.json
perf: Use WeakMap for dom data (#6103)
test/unit/menu.test.js
@@ -1,5 +1,5 @@ /* eslint-env qunit */ -import * as DomData from '../../src/js/utils/dom-data'; +import DomData from '../../src/js/utils/dom-data'; import MenuButton from '../../src/js/menu/menu-button.js'; import Menu from '../../src/js/menu/menu.js'; import CaptionSettingsMenuItem from '../../src/js/control-bar/t...
true
Other
videojs
video.js
8610f9967340b9ae7fc73d41ff0e9d17a54b0604.json
perf: Use WeakMap for dom data (#6103)
test/unit/utils/dom-data.test.js
@@ -1,63 +0,0 @@ -/* eslint-env qunit */ -import document from 'global/document'; -import * as DomData from '../../../src/js/utils/dom-data'; -import videojs from '../../../src/js/video.js'; -import window from 'global/window'; - -QUnit.module('dom-data'); - -QUnit.test('should get and remove data from an element', fun...
true
Other
videojs
video.js
8610f9967340b9ae7fc73d41ff0e9d17a54b0604.json
perf: Use WeakMap for dom data (#6103)
test/unit/videojs-integration.test.js
@@ -2,7 +2,6 @@ import videojs from '../../src/js/video.js'; import window from 'global/window'; import document from 'global/document'; -import * as DomData from '../../src/js/utils/dom-data'; import * as Fn from '../../src/js/utils/fn'; /** @@ -70,54 +69,11 @@ QUnit.test('create a real player and dispose', fun...
true
Other
videojs
video.js
1d2b20636c802428f118bcbd40143c5f5613d656.json
fix(lang): update Spanish translations (#6065)
docs/translations-needed.md
@@ -364,66 +364,7 @@ This default value is hardcoded as a default to the localize method in the SeekB | | Beginning of dialog window. Escape will cancel and close the window. | | | End of dialog window. ...
true
Other
videojs
video.js
1d2b20636c802428f118bcbd40143c5f5613d656.json
fix(lang): update Spanish translations (#6065)
lang/es.json
@@ -1,6 +1,6 @@ { - "Play": "Reproducción", - "Play Video": "Reproducción Vídeo", + "Play": "Reproducir", + "Play Video": "Reproducir Vídeo", "Pause": "Pausa", "Current Time": "Tiempo reproducido", "Duration": "Duración total", @@ -23,5 +23,65 @@ "A network error caused the media download to fail part-...
true
Other
videojs
video.js
6a93c8afacc66eec77447498ae10866398cd5815.json
perf: throttle more timers and use native bind (#6142)
src/js/control-bar/progress-control/mouse-time-display.js
@@ -27,7 +27,7 @@ class MouseTimeDisplay extends Component { */ constructor(player, options) { super(player, options); - this.update = Fn.throttle(Fn.bind(this, this.update), 25); + this.update = Fn.throttle(Fn.bind(this, this.update), Fn.UPDATE_REFRESH_INTERVAL); } /**
true
Other
videojs
video.js
6a93c8afacc66eec77447498ae10866398cd5815.json
perf: throttle more timers and use native bind (#6142)
src/js/control-bar/progress-control/play-progress-bar.js
@@ -3,6 +3,7 @@ */ import Component from '../../component.js'; import {IS_IOS, IS_ANDROID} from '../../utils/browser.js'; +import * as Fn from '../../utils/fn.js'; import './time-tooltip'; @@ -14,6 +15,20 @@ import './time-tooltip'; */ class PlayProgressBar extends Component { + /** + * Creates an inst...
true
Other
videojs
video.js
6a93c8afacc66eec77447498ae10866398cd5815.json
perf: throttle more timers and use native bind (#6142)
src/js/control-bar/progress-control/progress-control.js
@@ -3,7 +3,7 @@ */ import Component from '../../component.js'; import * as Dom from '../../utils/dom.js'; -import {throttle, bind} from '../../utils/fn.js'; +import {bind, throttle, UPDATE_REFRESH_INTERVAL} from '../../utils/fn.js'; import './seek-bar.js'; @@ -26,8 +26,8 @@ class ProgressControl extends Compon...
true
Other
videojs
video.js
6a93c8afacc66eec77447498ae10866398cd5815.json
perf: throttle more timers and use native bind (#6142)
src/js/control-bar/progress-control/time-tooltip.js
@@ -4,6 +4,7 @@ import Component from '../../component'; import * as Dom from '../../utils/dom.js'; import formatTime from '../../utils/format-time.js'; +import * as Fn from '../../utils/fn.js'; /** * Time tooltips display a time above the progress bar. @@ -12,6 +13,20 @@ import formatTime from '../../utils/for...
true
Other
videojs
video.js
6a93c8afacc66eec77447498ae10866398cd5815.json
perf: throttle more timers and use native bind (#6142)
src/js/control-bar/time-controls/time-display.js
@@ -4,7 +4,7 @@ import document from 'global/document'; import Component from '../../component.js'; import * as Dom from '../../utils/dom.js'; -import {bind, throttle} from '../../utils/fn.js'; +import {bind, throttle, UPDATE_REFRESH_INTERVAL} from '../../utils/fn.js'; import formatTime from '../../utils/format-tim...
true
Other
videojs
video.js
6a93c8afacc66eec77447498ae10866398cd5815.json
perf: throttle more timers and use native bind (#6142)
src/js/control-bar/volume-control/volume-control.js
@@ -4,7 +4,7 @@ import Component from '../../component.js'; import checkVolumeSupport from './check-volume-support'; import {isPlain} from '../../utils/obj'; -import { throttle, bind } from '../../utils/fn.js'; +import {throttle, bind, UPDATE_REFRESH_INTERVAL} from '../../utils/fn.js'; // Required children impor...
true
Other
videojs
video.js
6a93c8afacc66eec77447498ae10866398cd5815.json
perf: throttle more timers and use native bind (#6142)
src/js/slider/slider.js
@@ -59,6 +59,7 @@ class Slider extends Component { this.on('keydown', this.handleKeyDown); this.on('click', this.handleClick); + // TODO: deprecated, controlsvisible does not seem to be fired this.on(this.player_, 'controlsvisible', this.update); if (this.playerEvent) { @@ -262,10 +263,10 @@ ...
true
Other
videojs
video.js
6a93c8afacc66eec77447498ae10866398cd5815.json
perf: throttle more timers and use native bind (#6142)
src/js/utils/fn.js
@@ -5,6 +5,8 @@ import { newGUID } from './guid.js'; import window from 'global/window'; +export const UPDATE_REFRESH_INTERVAL = 30; + /** * Bind (a.k.a proxy or context). A simple method for changing the context of * a function. @@ -32,9 +34,7 @@ export const bind = function(context, fn, uid) { } // C...
true
Other
videojs
video.js
20cae21ff7222fd6b1efa6b4e48578fd405ba126.json
fix(component): use safe computedStyle in currentDimension (#6073) This will prevent a null exception when a video.js is implemented in a 'display:none' iframe on Firefox (<62). This is a fix in continuation of the PR #3664 regarding a bug in Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=548397
src/js/component.js
@@ -12,6 +12,7 @@ import * as Fn from './utils/fn.js'; import * as Guid from './utils/guid.js'; import toTitleCase from './utils/to-title-case.js'; import mergeOptions from './utils/merge-options.js'; +import computedStyle from './utils/computed-style'; /** * Base class for all UI Components. @@ -984,19 +985,15...
true
Other
videojs
video.js
20cae21ff7222fd6b1efa6b4e48578fd405ba126.json
fix(component): use safe computedStyle in currentDimension (#6073) This will prevent a null exception when a video.js is implemented in a 'display:none' iframe on Firefox (<62). This is a fix in continuation of the PR #3664 regarding a bug in Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=548397
src/js/utils/computed-style.js
@@ -26,9 +26,9 @@ function computedStyle(el, prop) { } if (typeof window.getComputedStyle === 'function') { - const cs = window.getComputedStyle(el); + const computedStyleValue = window.getComputedStyle(el); - return cs ? cs[prop] : ''; + return computedStyleValue ? computedStyleValue.getPropertyV...
true
Other
videojs
video.js
3c932c5f8e3b92ab9230b5c4d6e84b29ad82b36a.json
refactor: use the new `any` event function (#6080)
src/js/player.js
@@ -1528,20 +1528,20 @@ class Player extends Component { // if the `sourceset` `src` was an empty string // wait for a `loadstart` to update the cache to `currentSrc`. // If a sourceset happens before a `loadstart`, we reset the state - // as this function will be called again. if (!eve...
true
Other
videojs
video.js
3c932c5f8e3b92ab9230b5c4d6e84b29ad82b36a.json
refactor: use the new `any` event function (#6080)
src/js/tracks/text-track.js
@@ -93,19 +93,13 @@ const loadTrack = function(src, track) { if (track.tech_) { // to prevent use before define eslint error, we define loadHandler // as a let here - let loadHandler; - const errorHandler = () => { - log.error(`vttjs failed to load, stopping trying to pro...
true
Other
videojs
video.js
3c932c5f8e3b92ab9230b5c4d6e84b29ad82b36a.json
refactor: use the new `any` event function (#6080)
test/unit/tracks/text-track.test.js
@@ -503,7 +503,6 @@ QUnit.test('stops processing if vttjs loading errored out', function(assert) { const errorSpy = sinon.spy(); const oldVTT = window.WebVTT; const oldLogError = log.error; - const parserCreated = false; const reqs = []; window.xhr.onCreate = function(req) { @@ -529,20 +528,14 @@ QUni...
true
Other
videojs
video.js
15ff8f7242cc908717ccf730c239157bdd4ed1f9.json
revert: "fix(play-toggle): call event.stopPropagation in the click handler (#5803)" (#6128) PR #5083 introduces a fix to #5624, an issue with click events when Polymer's tap gesture is being used. However, this causes an issue where `player.on('click')` no longer triggers from the play toggle. Thus, we revert the c...
src/js/control-bar/play-toggle.js
@@ -61,7 +61,6 @@ class PlayToggle extends Button { } else { this.player_.pause(); } - event.stopPropagation(); } /**
false
Other
videojs
video.js
204ff4619a9dd055c88579af28770ea046461529.json
feat: add write method to time tooltips (#6021) This splits up the `update` method into two methods: `update` and `write`. The new write method is only responsible for updating the text content of the tooltips. This is useful if you wan't to be able to override the behavior in some way but still wanted all the behavio...
src/js/control-bar/progress-control/time-tooltip.js
@@ -82,6 +82,16 @@ class TimeTooltip extends Component { } this.el_.style.right = `-${pullTooltipBy}px`; + this.write(content); + } + + /** + * Write the time to the tooltip DOM element. + * + * @param {String} content + * The formatted time for the tooltip. + */ + write(content) { ...
false