language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | videojs | video.js | 9cec1de915ab74815dae78a3413667ace317cbab.json | docs: Redirect guides to videojs.com (#7706)
Co-authored-by: mister-ben <git@misterben.me> | docs/guides/videojs.md | @@ -1,179 +1,3 @@
# Usage examples for the functions on videojs
-## Table of Contents
-
-* [videojs()](#videojs)
-* [options](#options)
-* [getComponent()](#getcomponent)
-* [registerComponent()](#registercomponent)
-* [getTech()](#gettech)
-* [registerTech()](#registertech)
-* [extend()](#extend)
-* [mergeOptions()... | true |
Other | videojs | video.js | 9cec1de915ab74815dae78a3413667ace317cbab.json | docs: Redirect guides to videojs.com (#7706)
Co-authored-by: mister-ben <git@misterben.me> | docs/guides/vue.md | @@ -1,83 +1,3 @@
# Video.js and Vue integration
-Here's a basic Vue player implementation.
-
-It just instantiates the Video.js player on `mounted` and destroys it on `beforeDestroy`.
-
-```vue
-<template>
- <div>
- <video ref="videoPlayer" class="video-js"></video>
- </div>
-</template>
-
-<script>
-im... | true |
Other | videojs | video.js | 9cec1de915ab74815dae78a3413667ace317cbab.json | docs: Redirect guides to videojs.com (#7706)
Co-authored-by: mister-ben <git@misterben.me> | docs/guides/webpack.md | @@ -1,51 +1,3 @@
# Using Webpack with Video.js
-Video.js, and the playback technologies such as videojs-contrib-hls all work in a Webpack based build environment. Here are several configuration changes specific to Webpack that will get you up and running.
-
-## Video.js CSS:
-
-To add the CSS that the player require... | true |
Other | videojs | video.js | eeff79c5e8b56f647535d3794b1d907631482301.json | refactor: Unify audioOnly mode and audioPoster mode (#7678)
Co-authored-by: Alex Barstow <alexander.barstow@gmail.com> | src/js/control-bar/picture-in-picture-toggle.js | @@ -29,6 +29,21 @@ class PictureInPictureToggle extends Button {
this.on(player, ['enterpictureinpicture', 'leavepictureinpicture'], (e) => this.handlePictureInPictureChange(e));
this.on(player, ['disablepictureinpicturechanged', 'loadedmetadata'], (e) => this.handlePictureInPictureEnabledChange(e));
+ t... | true |
Other | videojs | video.js | eeff79c5e8b56f647535d3794b1d907631482301.json | refactor: Unify audioOnly mode and audioPoster mode (#7678)
Co-authored-by: Alex Barstow <alexander.barstow@gmail.com> | src/js/player.js | @@ -398,6 +398,9 @@ class Player extends Component {
// Init state audioOnlyMode_
this.audioOnlyMode_ = false;
+ // Init state audioPosterMode_
+ this.audioPosterMode_ = false;
+
// Init state audioOnlyCache_
this.audioOnlyCache_ = {
playerHeight: null,
@@ -583,7 +586,15 @@ class Play... | true |
Other | videojs | video.js | eeff79c5e8b56f647535d3794b1d907631482301.json | refactor: Unify audioOnly mode and audioPoster mode (#7678)
Co-authored-by: Alex Barstow <alexander.barstow@gmail.com> | test/unit/controls.test.js | @@ -283,6 +283,23 @@ QUnit.test('Picture-in-Picture control enabled property value should be correct
pictureInPictureToggle.dispose();
});
+QUnit.test('Picture-in-Picture control is hidden when the source is audio', function(assert) {
+ const player = TestHelpers.makePlayer({});
+ const pictureInPictureToggle =... | true |
Other | videojs | video.js | eeff79c5e8b56f647535d3794b1d907631482301.json | refactor: Unify audioOnly mode and audioPoster mode (#7678)
Co-authored-by: Alex Barstow <alexander.barstow@gmail.com> | test/unit/player.test.js | @@ -1573,34 +1573,77 @@ QUnit.test('should add an audio player region if an audio el is used', function(
QUnit.test('default audioPosterMode value at player creation', function(assert) {
const player = TestHelpers.makePlayer({});
+ player.trigger('ready');
assert.ok(player.audioPosterMode() === false, 'audioP... | true |
Other | videojs | video.js | a80307fe0dda11455451ad17e231f326f467a38c.json | feat: Add Basque (eu) translations (#7625) | docs/translations-needed.md | @@ -330,6 +330,7 @@ This default value is hardcoded as a default to the localize method in the SeekB
| | Exit Picture-in-Picture |
| | Picture-in-Picture ... | true |
Other | videojs | video.js | a80307fe0dda11455451ad17e231f326f467a38c.json | feat: Add Basque (eu) translations (#7625) | lang/eu.json | @@ -0,0 +1,89 @@
+{
+ "Audio Player": "Audio jogailua",
+ "Video Player": "Bideo jogailua",
+ "Play": "Hasi",
+ "Pause": "Gelditu",
+ "Replay": "Berriz hasi",
+ "Current Time": "Uneko denbora",
+ "Duration": "Iraupena",
+ "Remaining Time": "Gelditzen den denbora",
+ "Stream Type": "Jario mota",
+ "LIVE": "ZUZ... | true |
Other | videojs | video.js | 64e55f5492237b170dc3f88b27be5c307ae3a62b.json | feat: Add audioPosterMode option (#7629) | docs/guides/options.md | @@ -21,6 +21,7 @@
* [width](#width)
* [Video.js-specific Options](#videojs-specific-options)
* [aspectRatio](#aspectratio)
+ * [audioPosterMode](#audiopostermode)
* [autoSetup](#autosetup)
* [breakpoints](#breakpoints)
* [children](#children)
@@ -181,6 +182,13 @@ Puts the player in [fluid](#fluid) mode... | true |
Other | videojs | video.js | 64e55f5492237b170dc3f88b27be5c307ae3a62b.json | feat: Add audioPosterMode option (#7629) | src/css/components/_poster.scss | @@ -16,17 +16,14 @@
height: 100%;
}
-// Hide the poster after the video has started playing
-.vjs-has-started .vjs-poster {
+// Hide the poster after the video has started playing and when native controls are used
+.vjs-has-started .vjs-poster,
+.vjs-using-native-controls .vjs-poster {
display: none;
}
-// ... | true |
Other | videojs | video.js | 64e55f5492237b170dc3f88b27be5c307ae3a62b.json | feat: Add audioPosterMode option (#7629) | src/js/player.js | @@ -4293,6 +4293,37 @@ class Player extends Component {
return !!this.isAudio_;
}
+ /**
+ * Get the current audioPosterMode state or set audioPosterMode to true or false
+ *
+ * @param {boolean} [value]
+ * The value to set audioPosterMode to.
+ *
+ * @return {boolean}
+ * True ... | true |
Other | videojs | video.js | 64e55f5492237b170dc3f88b27be5c307ae3a62b.json | feat: Add audioPosterMode option (#7629) | test/unit/player.test.js | @@ -1570,6 +1570,39 @@ QUnit.test('should add an audio player region if an audio el is used', function(
player.dispose();
});
+QUnit.test('default audioPosterMode value at player creation', function(assert) {
+ const player = TestHelpers.makePlayer({});
+
+ assert.ok(player.audioPosterMode() === false, 'audioPo... | true |
Other | videojs | video.js | 950deae59b701986b3bee6ae6a55c285b8351e82.json | fix: keep focus trapping contained to modal (#6983) | src/js/component.js | @@ -14,6 +14,7 @@ import mergeOptions from './utils/merge-options.js';
import computedStyle from './utils/computed-style';
import Map from './utils/map.js';
import Set from './utils/set.js';
+import keycode from 'keycode';
/**
* Base class for all UI Components.
@@ -1161,8 +1162,10 @@ class Component {
if ... | false |
Other | videojs | video.js | 53cbfc62226255e2435cde10624bcafb54502fbb.json | docs: Add some FAQ entries (#7609)
Co-authored-by: Pat O'Neill <pgoneill@gmail.com> | docs/guides/faq.md | @@ -41,6 +41,9 @@
* [Q: Can Video.js be required in node.js?](#q-can-videojs-be-required-in-nodejs)
* [Q: Does Video.js work with webpack?](#q-does-videojs-work-with-webpack)
* [Q: Does Video.js work with react?](#q-does-videojs-work-with-react)
+* [Q: Can the big play button be centered?](#q-can-the-big-play-button... | true |
Other | videojs | video.js | 53cbfc62226255e2435cde10624bcafb54502fbb.json | docs: Add some FAQ entries (#7609)
Co-authored-by: Pat O'Neill <pgoneill@gmail.com> | docs/guides/troubleshooting.md | @@ -14,6 +14,7 @@
* [Problems with playback](#problems-with-playback)
* [Video.js Errors](#videojs-errors)
* [vdata123456 errors](#vdata123456-errors)
+* [Problems with setup options](#problems-with-setup-options)
## Problems with media formats
@@ -89,6 +90,24 @@ a component.
To fix this issue please make ... | true |
Other | videojs | video.js | 67e6ed6fd64f2a62d311721b8f786b63fb07f53b.json | feat: make negative sign on remaining time optional (#7571)
Add a new `displayNegative` option on the remaining time display to not show a negative sign in front of the time.
The default value is true to maintain current behavior.
Closes #7565 | docs/guides/options.md | @@ -7,6 +7,7 @@
* [Standard <video> Element Options](#standard-video-element-options)
* [autoplay](#autoplay)
* [More info on autoplay support and changes:](#more-info-on-autoplay-support-and-changes)
+ * [controlBar.remainingTimeDisplay.displayNegative](#controlbarremainingtimedisplaydisplaynegative)
*... | true |
Other | videojs | video.js | 67e6ed6fd64f2a62d311721b8f786b63fb07f53b.json | feat: make negative sign on remaining time optional (#7571)
Add a new `displayNegative` option on the remaining time display to not show a negative sign in front of the time.
The default value is true to maintain current behavior.
Closes #7565 | src/js/control-bar/time-controls/remaining-time-display.js | @@ -45,7 +45,9 @@ class RemainingTimeDisplay extends TimeDisplay {
createEl() {
const el = super.createEl();
- el.insertBefore(Dom.createEl('span', {}, {'aria-hidden': true}, '-'), this.contentEl_);
+ if (this.options_.displayNegative !== false) {
+ el.insertBefore(Dom.createEl('span', {}, {'aria-h... | true |
Other | videojs | video.js | 67e6ed6fd64f2a62d311721b8f786b63fb07f53b.json | feat: make negative sign on remaining time optional (#7571)
Add a new `displayNegative` option on the remaining time display to not show a negative sign in front of the time.
The default value is true to maintain current behavior.
Closes #7565 | test/unit/controls.test.js | @@ -10,6 +10,7 @@ import PictureInPictureToggle from '../../src/js/control-bar/picture-in-picture-
import FullscreenToggle from '../../src/js/control-bar/fullscreen-toggle.js';
import ControlBar from '../../src/js/control-bar/control-bar.js';
import SeekBar from '../../src/js/control-bar/progress-control/seek-bar.js... | true |
Other | videojs | video.js | d38806dacd8d451fbb30a83e599ab58659ddcd27.json | chore: fix typo in COLLABORATOR_GUIDE (#7537) | COLLABORATOR_GUIDE.md | @@ -65,7 +65,7 @@ If you are unsure about the modification and cannot take responsibility for it,
Before merging the change, it should be left open for other core committers to comment on. At least 24 hours during a weekday, and the 48 hours on a weekend. Trivial changes or bug fixes that have been reviewed by multi... | false |
Other | videojs | video.js | 6c67c3084b485ae158debba9ee4aeebde65640cf.json | fix: improve enabling liveui when switching sources (#7510)
We try and enable the liveui on canplay, however, we only do it the first time after the LiveTracker is enabled. This means that if you change sources, we may not catch that the liveui should be enabled. This is particularly important for browsers where nativ... | src/js/live-tracker.js | @@ -56,7 +56,7 @@ class LiveTracker extends Component {
this.on(this.player_, 'durationchange', (e) => this.handleDurationchange(e));
// we should try to toggle tracking on canplay as native playback engines, like Safari
// may not have the proper values for things like seekableEnd until then
- this.o... | true |
Other | videojs | video.js | 6c67c3084b485ae158debba9ee4aeebde65640cf.json | fix: improve enabling liveui when switching sources (#7510)
We try and enable the liveui on canplay, however, we only do it the first time after the LiveTracker is enabled. This means that if you change sources, we may not catch that the liveui should be enabled. This is particularly important for browsers where nativ... | test/unit/live-tracker.test.js | @@ -90,6 +90,28 @@ QUnit.module('LiveTracker', () => {
assert.equal(liveEdgeChange, 3, 'liveedgechange fired again');
});
+ QUnit.test('with canplay', function(assert) {
+ let duration = Infinity;
+
+ this.player.seekable = () => createTimeRanges(0, 30);
+ this.player.duration = () => duration;
+
+ ... | true |
Other | videojs | video.js | 8abe438b086fd8a54a66981189d3a41eaeddeaae.json | test: add tests for the click user action (#7507)
Follow up on #7495 | test/unit/player-user-actions.test.js | @@ -5,6 +5,121 @@ import sinon from 'sinon';
import TestHelpers from './test-helpers';
import FullscreenApi from '../../src/js/fullscreen-api.js';
+QUnit.module('Player: User Actions: Click', {
+
+ beforeEach() {
+ this.clock = sinon.useFakeTimers();
+ this.player = TestHelpers.makePlayer({controls: true});
... | false |
Other | videojs | video.js | ca2f5a3caeea9052bd84dda1bdd619430b7bdd1c.json | docs: fix a comment of the player's loadedmetadata event (#7506) | src/js/player.js | @@ -144,7 +144,7 @@ const TECH_EVENTS_RETRIGGER = [
* @type {EventTarget~Event}
*/
/**
- * Retrigger the `stalled` event that was triggered by the {@link Tech}.
+ * Retrigger the `loadedmetadata` event that was triggered by the {@link Tech}.
*
* @private
* @method Player#handleTechLoadedmetad... | false |
Other | videojs | video.js | 8e8b7be190d433bfc56372af4fc87b4d5669cb60.json | docs: fix typo in html-track-element.js (#7504)
vesion -> version | src/js/tracks/html-track-element.js | @@ -49,7 +49,7 @@ class HTMLTrackElement extends EventTarget {
*
* @param {string} [options.srclang='']
* A valid two character language code. An alternative, but deprioritized
- * vesion of `options.language`
+ * version of `options.language`
*
* @param {string} [options.sr... | false |
Other | videojs | video.js | b061491832236e5c0c581ed8e08bd3ca6f468474.json | fix(lang): Update Polish translation (#7499)
Missing Polish translations added. | lang/pl.json | @@ -1,13 +1,17 @@
{
+ "Audio Player": "Odtwarzacz audio",
+ "Video Player": "Odtwarzacz wideo",
"Play": "Odtwarzaj",
"Pause": "Pauza",
+ "Replay": "Odtwórz ponownie",
"Current Time": "Aktualny czas",
"Duration": "Czas trwania",
"Remaining Time": "Pozostały czas",
"Stream Type": "Typ strumienia",
... | false |
Other | videojs | video.js | e60f2cada59b15010eb63fdf5e86e57e358bda1e.json | docs(component.md): fix spelling error (#7498) | docs/guides/components.md | @@ -219,7 +219,7 @@ myComponent.on(otherComponent, 'eventName', myFunc);
otherComponent.trigger('eventName');
// logs 'myFunc called' twice
-myComponent.off(ootherComponent.el(), 'eventName', myFunc);
+myComponent.off(otherComponent.el(), 'eventName', myFunc);
myComponent.off(otherComponent, 'eventName', myFunc);
... | false |
Other | videojs | video.js | 1d91831992d4083e1ced91cbbd3e2344b0e8cec8.json | fix: remove rule on small layout (#7449) | src/css/components/_adaptive.scss | @@ -34,7 +34,7 @@
.vjs-subtitles-button,
.vjs-audio-button,
.vjs-volume-control {
- display: none !important;
+ display: none;
}
// Reset the size of the volume panel to the default so we don't see a big | false |
Other | videojs | video.js | 6c68f9554c7ac34c04789ea8b0d72aca4b6d09d9.json | fix(package): update VHS to 2.10.3 to fix seeking into a gap (#7436) | package-lock.json | @@ -1312,9 +1312,9 @@
}
},
"@videojs/http-streaming": {
- "version": "2.10.2",
- "resolved": "https://registry.npmjs.org/@videojs/http-streaming/-/http-streaming-2.10.2.tgz",
- "integrity": "sha512-JTAlAUHzj0sTsge2WBh4DWKM2I5BDFEZYOvzxmsK/ySILmI0GRyjAHx9uid68ZECQ2qbEAIRmZW5lWp0R5PeNA==",... | true |
Other | videojs | video.js | 6c68f9554c7ac34c04789ea8b0d72aca4b6d09d9.json | fix(package): update VHS to 2.10.3 to fix seeking into a gap (#7436) | package.json | @@ -84,7 +84,7 @@
},
"dependencies": {
"@babel/runtime": "^7.12.5",
- "@videojs/http-streaming": "2.10.2",
+ "@videojs/http-streaming": "2.10.3",
"@videojs/vhs-utils": "^3.0.3",
"@videojs/xhr": "2.6.0",
"aes-decrypter": "3.1.2", | true |
Other | videojs | video.js | 6d39ee24b1ee99fecc555128d3048b592258f101.json | fix: remove deprecation of getComponent feature (#7410)
Since Video.js 6, we've removed the deprecated functionality, we no longer need to have a deprecation warning. | src/js/component.js | @@ -1706,11 +1706,6 @@ class Component {
*
* @return {Component}
* The `Component` that got registered under the given name.
- *
- * @deprecated In `videojs` 6 this will not return `Component`s that were not
- * registered using {@link Component.registerComponent}. Currently we
- ... | false |
Other | videojs | video.js | 3ea078d40b1320f2d4a189430ccdb42cdf7efd1d.json | docs(plugins): fix typo in the plugins guide (#7405) | docs/guides/plugins.md | @@ -351,7 +351,7 @@ For any given plugin initialization, there are four events to be aware of:
* `beforepluginsetup`: Triggered immediately before any plugin is initialized.
* `beforepluginsetup:examplePlugin` Triggered immediately before the `examplePlugin` is initialized.
* `pluginsetup`: Triggered after any plugi... | false |
Other | videojs | video.js | 1ddcfde086b4e3604ab39db91ccd92a50c85361a.json | fix: update VHS to fix xmldom warning (#7395)
Fixes #7389 | package-lock.json | @@ -1312,28 +1312,37 @@
}
},
"@videojs/http-streaming": {
- "version": "2.10.0",
- "resolved": "https://registry.npmjs.org/@videojs/http-streaming/-/http-streaming-2.10.0.tgz",
- "integrity": "sha512-MoAp5BbexEqvCdyyazWH3thXpuOOUt82qjKB37VumXQiSZfNrIFgJRgdXOwHqsO4iEksWHSQRhJNxlTDMSP4dg==... | true |
Other | videojs | video.js | 1ddcfde086b4e3604ab39db91ccd92a50c85361a.json | fix: update VHS to fix xmldom warning (#7395)
Fixes #7389 | package.json | @@ -84,15 +84,15 @@
},
"dependencies": {
"@babel/runtime": "^7.12.5",
- "@videojs/http-streaming": "2.10.0",
+ "@videojs/http-streaming": "2.10.2",
"@videojs/vhs-utils": "^3.0.3",
"@videojs/xhr": "2.6.0",
"aes-decrypter": "3.1.2",
"global": "^4.4.0",
"keycode": "^2.2.0",
"... | true |
Other | videojs | video.js | af484eccbeabd3d847196bdc699a77179c409034.json | chore: specify bucket for CDN push (#7393) | .github/workflows/release.yml | @@ -90,4 +90,4 @@ jobs:
- name: Copy files to the CDN with the AWS CLI
run: |
- aws s3 sync node_modules/video.js/dist/ s3://${S3_KEY}/${VJS_VERSION}/ --acl ${S3_ACCESS}
+ aws s3 sync node_modules/video.js/dist/ s3://${S3_BUCKET}/${S3_KEY}/${VJS_VERSION}/ --acl ${S3_ACCESS} | false |
Other | videojs | video.js | d07a9de8203c72d2ff5d01e306954c536831cb18.json | docs(react): update react functional component tutorial (#7377) | docs/guides/react.md | @@ -12,43 +12,55 @@ import "video.js/dist/video-js.css";
export const VideoJS = ( props ) => {
const videoRef = React.useRef(null);
- const { options } = props;
+ const playerRef = React.useRef(null);
+ const { options, onReady } = props;
- // This separate functional component fixes the removal of the vide... | false |
Other | videojs | video.js | 957c6fa0097e13ec4695488f8d03bf250b9c8d89.json | chore: add a release and deploy Github Action (#7385)
The release job will do an npm publish and a github-release.
It's based on videojs/.github/github-release.yml.
The new version is published as `next` and requires to be promoted to
latest manually.
The deploy job, should do an aws s3 sync to upload the files ... | .github/workflows/release.yml | @@ -0,0 +1,93 @@
+name: release
+on:
+ push:
+ tags:
+ # match semver versions
+ - "v[0-9]+.[0-9]+.[0-9]+"
+ # match semver pre-releases
+ - "v[0-9]+.[0-9]+.[0-9]+-*"
+jobs:
+ release:
+ env:
+ NETLIFY_BASE: 'videojs-preview.netlify.app'
+ runs-on: ubuntu-latest
+ steps:
+ - name: Ch... | false |
Other | videojs | video.js | 9e82035b196f9c94108a2e55ddcc9c230939242f.json | fix(lang): fix typo in de locale for progress bar (#7380) | lang/de.json | @@ -78,7 +78,7 @@
"End of dialog window.": "Ende des Dialogfensters.",
"Audio Player": "Audio-Player",
"Video Player": "Video-Player",
- "Progress Bar": "Forschrittsbalken",
+ "Progress Bar": "Fortschrittsbalken",
"progress bar timing: currentTime={1} duration={2}": "{1} von {2}",
"Volume Level": "Laut... | false |
Other | videojs | video.js | 5c2a45bad7be73221436f4cfaa1206d2007efb34.json | feat(lang): add Romanian language and update translations doc. (#7300) | docs/translations-needed.md | @@ -329,8 +329,7 @@ This default value is hardcoded as a default to the localize method in the SeekB
| | {1} is loading. |
| | Exit Picture-in-Picture ... | true |
Other | videojs | video.js | 5c2a45bad7be73221436f4cfaa1206d2007efb34.json | feat(lang): add Romanian language and update translations doc. (#7300) | lang/ro.json | @@ -0,0 +1,89 @@
+{
+ "Audio Player": "Player audio",
+ "Video Player": "Player video",
+ "Play": "Piesă",
+ "Pause": "Pauză",
+ "Replay": "Reluare",
+ "Current Time": "Ora curentă",
+ "Duration": "Durată",
+ "Remaining Time": "Timp rămas",
+ "Stream Type": "Tip flux",
+ "LIVE": "ÎN DIRECT",
+ "Seek to live,... | true |
Other | videojs | video.js | eb8f802391392406ad9801a76934aa7a98dd1bdb.json | refactor: remove most usage of innerHTML (#7337) | src/js/button.js | @@ -6,6 +6,7 @@ import Component from './component';
import log from './utils/log.js';
import {assign} from './utils/obj';
import keycode from 'keycode';
+import {createEl} from './utils/dom.js';
/**
* Base class for all buttons.
@@ -34,7 +35,6 @@ class Button extends ClickableComponent {
tag = 'button';
... | true |
Other | videojs | video.js | eb8f802391392406ad9801a76934aa7a98dd1bdb.json | refactor: remove most usage of innerHTML (#7337) | src/js/clickable-component.js | @@ -57,7 +57,6 @@ class ClickableComponent extends Component {
*/
createEl(tag = 'div', props = {}, attributes = {}) {
props = assign({
- innerHTML: '<span aria-hidden="true" class="vjs-icon-placeholder"></span>',
className: this.buildCSSClass(),
tabIndex: 0
}, props);
@@ -73,7 +72,1... | true |
Other | videojs | video.js | eb8f802391392406ad9801a76934aa7a98dd1bdb.json | refactor: remove most usage of innerHTML (#7337) | src/js/control-bar/audio-track-controls/audio-track-menu-item.js | @@ -3,7 +3,6 @@
*/
import MenuItem from '../../menu/menu-item.js';
import Component from '../../component.js';
-import {assign} from '../../utils/obj';
/**
* An {@link AudioTrack} {@link MenuItem}
@@ -46,21 +45,21 @@ class AudioTrackMenuItem extends MenuItem {
}
createEl(type, props, attrs) {
- let ... | true |
Other | videojs | video.js | eb8f802391392406ad9801a76934aa7a98dd1bdb.json | refactor: remove most usage of innerHTML (#7337) | src/js/control-bar/live-display.js | @@ -3,6 +3,7 @@
*/
import Component from '../component';
import * as Dom from '../utils/dom.js';
+import document from 'global/document';
// TODO - Future make it click to snap to live
@@ -41,12 +42,17 @@ class LiveDisplay extends Component {
});
this.contentEl_ = Dom.createEl('div', {
- class... | true |
Other | videojs | video.js | eb8f802391392406ad9801a76934aa7a98dd1bdb.json | refactor: remove most usage of innerHTML (#7337) | src/js/control-bar/playback-rate-menu/playback-rate-menu-button.js | @@ -49,7 +49,7 @@ class PlaybackRateMenuButton extends MenuButton {
this.labelEl_ = Dom.createEl('div', {
className: 'vjs-playback-rate-value',
id: this.labelElId_,
- innerHTML: '1x'
+ textContent: '1x'
});
el.appendChild(this.labelEl_);
@@ -190,7 +190,7 @@ class PlaybackRateMen... | true |
Other | videojs | video.js | eb8f802391392406ad9801a76934aa7a98dd1bdb.json | refactor: remove most usage of innerHTML (#7337) | src/js/control-bar/seek-to-live.js | @@ -45,7 +45,7 @@ class SeekToLive extends Button {
this.textEl_ = Dom.createEl('span', {
className: 'vjs-seek-to-live-text',
- innerHTML: this.localize('LIVE')
+ textContent: this.localize('LIVE')
}, {
'aria-hidden': 'true'
}); | true |
Other | videojs | video.js | eb8f802391392406ad9801a76934aa7a98dd1bdb.json | refactor: remove most usage of innerHTML (#7337) | src/js/control-bar/spacer-controls/custom-control-spacer.js | @@ -28,14 +28,12 @@ class CustomControlSpacer extends Spacer {
* The element that was created.
*/
createEl() {
- const el = super.createEl({
- className: this.buildCSSClass()
+ return super.createEl('div', {
+ className: this.buildCSSClass(),
+ // No-flex/table-cell mode requires... | true |
Other | videojs | video.js | eb8f802391392406ad9801a76934aa7a98dd1bdb.json | refactor: remove most usage of innerHTML (#7337) | src/js/control-bar/spacer-controls/spacer.js | @@ -27,10 +27,12 @@ class Spacer extends Component {
* @return {Element}
* The element that was created.
*/
- createEl() {
- return super.createEl('div', {
- className: this.buildCSSClass()
- });
+ createEl(tag = 'div', props = {}, attributes = {}) {
+ if (!props.className) {
+ ... | true |
Other | videojs | video.js | eb8f802391392406ad9801a76934aa7a98dd1bdb.json | refactor: remove most usage of innerHTML (#7337) | src/js/control-bar/text-track-controls/subs-caps-menu-item.js | @@ -3,7 +3,7 @@
*/
import TextTrackMenuItem from './text-track-menu-item.js';
import Component from '../../component.js';
-import {assign} from '../../utils/obj';
+import {createEl} from '../../utils/dom.js';
/**
* SubsCapsMenuItem has an [cc] icon to distinguish captions from subtitles
@@ -14,21 +14,23 @@ imp... | true |
Other | videojs | video.js | eb8f802391392406ad9801a76934aa7a98dd1bdb.json | refactor: remove most usage of innerHTML (#7337) | src/js/control-bar/time-controls/time-display.js | @@ -39,9 +39,16 @@ class TimeDisplay extends Component {
createEl() {
const className = this.buildCSSClass();
const el = super.createEl('div', {
- className: `${className} vjs-time-control vjs-control`,
- innerHTML: `<span class="vjs-control-text" role="presentation">${this.localize(this.labelTex... | true |
Other | videojs | video.js | eb8f802391392406ad9801a76934aa7a98dd1bdb.json | refactor: remove most usage of innerHTML (#7337) | src/js/control-bar/time-controls/time-divider.js | @@ -18,15 +18,24 @@ class TimeDivider extends Component {
* The element that was created.
*/
createEl() {
- return super.createEl('div', {
- className: 'vjs-time-control vjs-time-divider',
- innerHTML: '<div><span>/</span></div>'
+ const el = super.createEl('div', {
+ className: ... | true |
Other | videojs | video.js | eb8f802391392406ad9801a76934aa7a98dd1bdb.json | refactor: remove most usage of innerHTML (#7337) | src/js/control-bar/volume-control/volume-level.js | @@ -17,10 +17,15 @@ class VolumeLevel extends Component {
* The element that was created.
*/
createEl() {
- return super.createEl('div', {
- className: 'vjs-volume-level',
- innerHTML: '<span class="vjs-control-text"></span>'
+ const el = super.createEl('div', {
+ className: 'vjs... | true |
Other | videojs | video.js | eb8f802391392406ad9801a76934aa7a98dd1bdb.json | refactor: remove most usage of innerHTML (#7337) | src/js/loading-spinner.js | @@ -22,7 +22,7 @@ class LoadingSpinner extends Component {
const playerType = this.localize(isAudio ? 'Audio Player' : 'Video Player');
const controlText = dom.createEl('span', {
className: 'vjs-control-text',
- innerHTML: this.localize('{1} is loading.', [playerType])
+ textContent: this.loc... | true |
Other | videojs | video.js | eb8f802391392406ad9801a76934aa7a98dd1bdb.json | refactor: remove most usage of innerHTML (#7337) | src/js/menu/menu-button.js | @@ -116,7 +116,7 @@ class MenuButton extends Component {
if (this.options_.title) {
const titleEl = Dom.createEl('li', {
className: 'vjs-menu-title',
- innerHTML: toTitleCase(this.options_.title),
+ textContent: toTitleCase(this.options_.title),
tabIndex: -1
});
| true |
Other | videojs | video.js | eb8f802391392406ad9801a76934aa7a98dd1bdb.json | refactor: remove most usage of innerHTML (#7337) | src/js/menu/menu-item.js | @@ -6,6 +6,7 @@ import Component from '../component.js';
import {assign} from '../utils/obj';
import {MenuKeys} from './menu-keys.js';
import keycode from 'keycode';
+import {createEl} from '../utils/dom.js';
/**
* The component for a menu item. `<li>`
@@ -63,11 +64,18 @@ class MenuItem extends ClickableCompone... | true |
Other | videojs | video.js | b3acf663641fca0f7a966525a72845af7ec5fab2.json | fix: remove IE8 url parsing workaround (#7334) | src/js/utils/url.js | @@ -41,38 +41,25 @@ import window from 'global/window';
* An object of url details
*/
export const parseUrl = function(url) {
+ // This entire method can be replace with URL once we are able to drop IE11
+
const props = ['protocol', 'hostname', 'port', 'pathname', 'search', 'hash', 'host'];
// a... | true |
Other | videojs | video.js | b3acf663641fca0f7a966525a72845af7ec5fab2.json | fix: remove IE8 url parsing workaround (#7334) | test/unit/utils/url.test.js | @@ -5,12 +5,9 @@ import * as Url from '../../../src/js/utils/url.js';
QUnit.module('url');
QUnit.test('should parse the details of a url correctly', function(assert) {
- assert.equal(
- Url.parseUrl('#').protocol,
- window.location.protocol,
- 'parsed relative url protocol'
- );
+ assert.equal(Url.parse... | true |
Other | videojs | video.js | 14da28dabe37681b8ea873af0fe4d7d06574f803.json | fix: remove loading spinner on ended (#7311)
If we've ended, there's no point in having the loading spinner. In
addition, there are cases where we get a waiting event immediately
before ended, and this works around that.
Fixes videojs/http-streaming#1156 | src/js/player.js | @@ -1894,6 +1894,7 @@ class Player extends Component {
*/
handleTechEnded_() {
this.addClass('vjs-ended');
+ this.removeClass('vjs-waiting');
if (this.options_.loop) {
this.currentTime(0);
this.play(); | false |
Other | videojs | video.js | c74c27d99b8d9ab4f267edb8160bd935696ecb83.json | feat: add ended getter middleware (#7287)
One thing to note is that this won't affect the play toggle from changing to the replay button on ended because it only listens to the ended event. Otherwise, this works fine. | src/js/tech/middleware.js | @@ -188,7 +188,8 @@ export const allowedGetters = {
played: 1,
paused: 1,
seekable: 1,
- volume: 1
+ volume: 1,
+ ended: 1
};
/** | false |
Other | videojs | video.js | fbcfb7b0147af454abdc22b27060316460a3137e.json | fix(lang): add some translations to es.json (#6822) | lang/es.json | @@ -83,5 +83,7 @@
"Caption Settings Dialog": "Diálogo de configuración de leyendas",
"Beginning of dialog window. Escape will cancel and close the window.": "Comienzo de la ventana de diálogo. La tecla Escape cancelará la operación y cerrará la ventana.",
"End of dialog window.": "Final de la ventana de diálog... | false |
Other | videojs | video.js | 0f707876ef9609102b49a5ed21629cb09e80f0e4.json | fix(lang): improve Hungarian translation (#7289) | docs/translations-needed.md | @@ -472,69 +472,7 @@ This default value is hardcoded as a default to the localize method in the SeekB
| | {1} is loading. |
| | Exit Picture-in-Picture ... | true |
Other | videojs | video.js | 0f707876ef9609102b49a5ed21629cb09e80f0e4.json | fix(lang): improve Hungarian translation (#7289) | lang/hu.json | @@ -22,5 +22,68 @@
"A network error caused the media download to fail part-way.": "Hálózati hiba miatt a videó részlegesen töltődött le.",
"The media could not be loaded, either because the server or network failed or because the format is not supported.": "A videó nem tölthető be hálózati vagy kiszolgálói hiba m... | true |
Other | videojs | video.js | 6259ef79e90c0a66172ac722015a3ab43a72d173.json | feat(player): Add playbackRates() method (#7228)
Adds a new playbackRates() method that takes an Array of numbers
representing the rates that are wanted to show up in the playback rates
menu. When new rates are given, a playbackrateschange event will trigger, which
will be used by the PlaybackRatesMenuButton to upd... | src/js/control-bar/playback-rate-menu/playback-rate-menu-button.js | @@ -2,7 +2,6 @@
* @file playback-rate-menu-button.js
*/
import MenuButton from '../../menu/menu-button.js';
-import Menu from '../../menu/menu.js';
import PlaybackRateMenuItem from './playback-rate-menu-item.js';
import Component from '../../component.js';
import * as Dom from '../../utils/dom.js';
@@ -33,6 +32... | true |
Other | videojs | video.js | 6259ef79e90c0a66172ac722015a3ab43a72d173.json | feat(player): Add playbackRates() method (#7228)
Adds a new playbackRates() method that takes an Array of numbers
representing the rates that are wanted to show up in the playback rates
menu. When new rates are given, a playbackrateschange event will trigger, which
will be used by the PlaybackRatesMenuButton to upd... | src/js/control-bar/playback-rate-menu/playback-rate-menu-item.js | @@ -26,7 +26,7 @@ class PlaybackRateMenuItem extends MenuItem {
// Modify options for parent MenuItem class's init.
options.label = label;
- options.selected = rate === 1;
+ options.selected = rate === player.playbackRate();
options.selectable = true;
options.multiSelectable = false;
| true |
Other | videojs | video.js | 6259ef79e90c0a66172ac722015a3ab43a72d173.json | feat(player): Add playbackRates() method (#7228)
Adds a new playbackRates() method that takes an Array of numbers
representing the rates that are wanted to show up in the playback rates
menu. When new rates are given, a playbackrateschange event will trigger, which
will be used by the PlaybackRatesMenuButton to upd... | src/js/player.js | @@ -508,6 +508,8 @@ class Player extends Component {
this.middleware_ = [];
+ this.playbackRates(options.playbackRates);
+
this.initChildren();
// Set isAudio based on whether or not an audio tag was used
@@ -2218,6 +2220,7 @@ class Player extends Component {
src: '',
source: {},
... | true |
Other | videojs | video.js | 6259ef79e90c0a66172ac722015a3ab43a72d173.json | feat(player): Add playbackRates() method (#7228)
Adds a new playbackRates() method that takes an Array of numbers
representing the rates that are wanted to show up in the playback rates
menu. When new rates are given, a playbackrateschange event will trigger, which
will be used by the PlaybackRatesMenuButton to upd... | test/unit/controls.test.js | @@ -141,13 +141,49 @@ QUnit.test('calculateDistance should use changedTouches, if available', function
slider.dispose();
});
-QUnit.test('should hide playback rate control if it\'s not supported', function(assert) {
+QUnit.test('playback rate button is hidden by default', function(assert) {
assert.expect(1);
... | true |
Other | videojs | video.js | 6259ef79e90c0a66172ac722015a3ab43a72d173.json | feat(player): Add playbackRates() method (#7228)
Adds a new playbackRates() method that takes an Array of numbers
representing the rates that are wanted to show up in the playback rates
menu. When new rates are given, a playbackrateschange event will trigger, which
will be used by the PlaybackRatesMenuButton to upd... | test/unit/player.test.js | @@ -1809,13 +1809,15 @@ QUnit.test('player#reset clears the player cache', function(assert) {
player.src(sources);
player.duration(10);
player.playbackRate(0.5);
+ player.playbackRates([1, 2, 3]);
player.volume(0.2);
assert.strictEqual(player.currentSrc(), sources[0].src, 'currentSrc is correct');
... | true |
Other | videojs | video.js | 39de502f72a1cd5eb29ca712c574eabf4f0184f0.json | feat(package): add VHS deps as Video.js deps (#7263)
Because VHS is inlined into Video.js, we should depend on what VHS
depends on.
Fixes #7091, fixes #7209, fixes #7144, fixes #7109 | package-lock.json | @@ -1078,9 +1078,9 @@
}
},
"@babel/runtime": {
- "version": "7.14.0",
- "resolved": "https://registry.npmjs.org/@babel/runtime/-/runtime-7.14.0.tgz",
- "integrity": "sha512-JELkvo/DlpNdJ7dlyw/eY7E0suy5i5GQH+Vlxaq1nsNJ+H7f4Vtv3jMeCEgRhZZQFXTjldYfQgv2qmM6M1v5wA==",
+ "version": "7.12.... | true |
Other | videojs | video.js | 39de502f72a1cd5eb29ca712c574eabf4f0184f0.json | feat(package): add VHS deps as Video.js deps (#7263)
Because VHS is inlined into Video.js, we should depend on what VHS
depends on.
Fixes #7091, fixes #7209, fixes #7144, fixes #7109 | package.json | @@ -82,11 +82,16 @@
"url": "https://github.com/videojs/video.js.git"
},
"dependencies": {
- "@babel/runtime": "^7.9.2",
+ "@babel/runtime": "^7.12.5",
"@videojs/http-streaming": "2.8.2",
+ "@videojs/vhs-utils": "^3.0.2",
"@videojs/xhr": "2.5.1",
+ "aes-decrypter": "3.1.2",
"global"... | true |
Other | videojs | video.js | 380a9b5b83a60aed93599dcd854b77990633bf38.json | docs: Fix typo in CONTRIBUTING.md (#7260) | CONTRIBUTING.md | @@ -208,7 +208,7 @@ This sets up the local webserver using connect and then watches source files, te
#### Step 1: Verify
-Whether you're adding something new, making something better, or fixing a bug, you'll first want to search the [GitHub issues](https://github.com/videojs/video.js/issues) and [plugins list](htt... | false |
Other | videojs | video.js | c70c29885a96c3b2b77fe9bd28bb30db763f0d7e.json | fix(seek-bar): remove event listener on dispose (#7258)
We were accidentally listening to `liveedgechange` when the seek-bar disposed. Instead, we should remove that event handler. | src/js/control-bar/progress-control/seek-bar.js | @@ -471,7 +471,7 @@ class SeekBar extends Slider {
this.off(this.player_, ['ended', 'durationchange', 'timeupdate'], this.update);
if (this.player_.liveTracker) {
- this.on(this.player_.liveTracker, 'liveedgechange', this.update);
+ this.off(this.player_.liveTracker, 'liveedgechange', this.update)... | false |
Other | videojs | video.js | 90ce2d7143ff5d5006cc7a9784bc52731ab551f4.json | fix(utils): add try and catch for computedStyle (#7214) | src/js/utils/computed-style.js | @@ -26,7 +26,13 @@ function computedStyle(el, prop) {
}
if (typeof window.getComputedStyle === 'function') {
- const computedStyleValue = window.getComputedStyle(el);
+ let computedStyleValue;
+
+ try {
+ computedStyleValue = window.getComputedStyle(el);
+ } catch (e) {
+ return '';
+ }... | false |
Other | videojs | video.js | a3bfeb77a64ebb306680a799e311fdcba332eb29.json | fix(package): update vtt.js to allow server-side-rendering (#7178) | package-lock.json | @@ -6837,6 +6837,14 @@
"pinkie-promise": "^2.0.0"
}
},
+ "hashish": {
+ "version": "0.0.4",
+ "resolved": "https://registry.npmjs.org/hashish/-/hashish-0.0.4.tgz",
+ "integrity": "sha1-bWC8b/r3Ebav1g5CbQd5iAFOZVQ=",
+ "requires": {
+ "traverse": ">=0.2.4"
+ }
+ ... | true |
Other | videojs | video.js | a3bfeb77a64ebb306680a799e311fdcba332eb29.json | fix(package): update vtt.js to allow server-side-rendering (#7178) | package.json | @@ -90,7 +90,7 @@
"rollup-plugin-replace": "^2.2.0",
"safe-json-parse": "4.0.0",
"videojs-font": "3.2.0",
- "videojs-vtt.js": "^0.15.2"
+ "videojs-vtt.js": "^0.15.3"
},
"devDependencies": {
"@babel/core": "^7.9.0", | true |
Other | videojs | video.js | f0d69cde56d289e7f87ef8aaa763decc5c274bed.json | fix(package): upgrade VHS to 2.7.1 (#7174) | package-lock.json | @@ -1313,9 +1313,9 @@
}
},
"@videojs/http-streaming": {
- "version": "2.7.0",
- "resolved": "https://registry.npmjs.org/@videojs/http-streaming/-/http-streaming-2.7.0.tgz",
- "integrity": "sha512-wg/5vGeBS8LhXDjKbHbpewId5aZ/gyG2dJNCeu4+Ix6AympXSTlztHuRQWTS2Gyx/fQpce1/1gfqdJne9ZIJ8Q==",
+... | true |
Other | videojs | video.js | f0d69cde56d289e7f87ef8aaa763decc5c274bed.json | fix(package): upgrade VHS to 2.7.1 (#7174) | package.json | @@ -83,7 +83,7 @@
},
"dependencies": {
"@babel/runtime": "^7.9.2",
- "@videojs/http-streaming": "2.7.0",
+ "@videojs/http-streaming": "2.7.1",
"@videojs/xhr": "2.5.1",
"global": "4.3.2",
"keycode": "^2.2.0", | true |
Other | videojs | video.js | 0d47306a520a964ed25bbb2c8733c98a7d9098c2.json | feat(package): update VHS to 2.7.0 (#7164) | package-lock.json | @@ -1313,17 +1313,17 @@
}
},
"@videojs/http-streaming": {
- "version": "2.6.4",
- "resolved": "https://registry.npmjs.org/@videojs/http-streaming/-/http-streaming-2.6.4.tgz",
- "integrity": "sha512-sFVE0MVXhawAkET8EgiUSMvDDv6u3uGidtO0BvNXG0/qKWlze/zEzhvLsyPU4HmLFRnffKeHK5RE2XpO5vHY8Q==",... | true |
Other | videojs | video.js | 0d47306a520a964ed25bbb2c8733c98a7d9098c2.json | feat(package): update VHS to 2.7.0 (#7164) | package.json | @@ -83,7 +83,7 @@
},
"dependencies": {
"@babel/runtime": "^7.9.2",
- "@videojs/http-streaming": "2.6.4",
+ "@videojs/http-streaming": "2.7.0",
"@videojs/xhr": "2.5.1",
"global": "4.3.2",
"keycode": "^2.2.0", | true |
Other | videojs | video.js | 239c9a15525c9fb2ba6a5f93471dc129616f1ad4.json | feat: enable responsive controls on fullscreen (#7098)
Co-authored-by: Ileana Padilla <ipadilla@brightcove.com> | src/css/components/_adaptive.scss | @@ -18,7 +18,7 @@
// - Volume Mute button
// - Fullscreen Button
//
-.video-js:not(.vjs-fullscreen) {
+.video-js {
&.vjs-layout-small,
&.vjs-layout-x-small,
@@ -34,7 +34,7 @@
.vjs-subtitles-button,
.vjs-audio-button,
.vjs-volume-control {
- display: none;
+ display: none !important;
... | false |
Other | videojs | video.js | 45eef66b09dbe4c4a9bae4fe8c190ee4359d0d69.json | fix: add display block to all buttons icon placeholder (#7094)
Fixes #6989 | src/css/components/_control.scss | @@ -18,6 +18,10 @@
@extend %icon-default;
}
+.vjs-button > .vjs-icon-placeholder {
+ display: block;
+}
+
// Replacement for focus outline
.video-js .vjs-control:focus:before,
.video-js .vjs-control:hover:before, | false |
Other | videojs | video.js | 6336e573f2f49353937159a98adb8263461fc3e1.json | docs: Add liveTracker options to options guide (#7097) | docs/guides/options.md | @@ -269,6 +269,22 @@ Allows the player to use the new live ui that includes:
Without this option the progress bar will be hidden and in its place will be text that indicates `LIVE` playback. There will be no progress control
and you will not be able click the text to seek to the live edge. `liveui` will default to `t... | false |
Other | videojs | video.js | 0b467041c7a90d3994dcc758f028da63033bbd71.json | chore: update rollup for upcoming vhs changes (#7075) | package-lock.json | @@ -4629,8 +4629,7 @@
"estree-walker": {
"version": "0.6.1",
"resolved": "https://registry.npmjs.org/estree-walker/-/estree-walker-0.6.1.tgz",
- "integrity": "sha512-SqmZANLWS0mnatqbSfRP5g8OXZC12Fgg1IwNtLsyHDzJizORW4khDfjPqJZsemPWBB2uqykUah5YpQ6epsqC/w==",
- "dev": true
+ "integrity": ... | true |
Other | videojs | video.js | 0b467041c7a90d3994dcc758f028da63033bbd71.json | chore: update rollup for upcoming vhs changes (#7075) | package.json | @@ -87,6 +87,7 @@
"@videojs/xhr": "2.5.1",
"global": "4.3.2",
"keycode": "^2.2.0",
+ "rollup-plugin-replace": "^2.2.0",
"safe-json-parse": "4.0.0",
"videojs-font": "3.2.0",
"videojs-vtt.js": "^0.15.2" | true |
Other | videojs | video.js | 0b467041c7a90d3994dcc758f028da63033bbd71.json | chore: update rollup for upcoming vhs changes (#7075) | rollup.config.js | @@ -12,6 +12,7 @@ import pkg from './package.json';
import multiEntry from 'rollup-plugin-multi-entry';
import stub from 'rollup-plugin-stub';
import isCI from 'is-ci';
+import replace from 'rollup-plugin-replace';
const compiledLicense = _.template(fs.readFileSync('./build/license-header.txt', 'utf8'));
const b... | true |
Other | videojs | video.js | dd0c675f0ffb236f7bce86cc7d2ebb717774430f.json | docs: fix broken blogpost urls (#7106) | docs/guides/faq.md | @@ -68,7 +68,7 @@ see the [setup guide][install-guide].
## Q: Is Video.js on bower?
Versions prior to Video.js 6 support bower, however, as of Video.js 6, bower is no
-longer officially supported. Please see <https://github.com/videojs/video.js/issues/4012>
+longer officially supported. Please see [issue #4012][iss... | true |
Other | videojs | video.js | dd0c675f0ffb236f7bce86cc7d2ebb717774430f.json | docs: fix broken blogpost urls (#7106) | docs/guides/options.md | @@ -92,7 +92,7 @@ player.autoplay('muted');
#### More info on autoplay support and changes:
-* See our blog post: <https://videojs.com/blog/autoplay-best-practices-with-video-js/>
+* See our blog post: [Autoplay Best Practices with Video.js](https://videojs.com/blog/autoplay-best-practices-with-video-js/)
### `... | true |
Other | videojs | video.js | dd0c675f0ffb236f7bce86cc7d2ebb717774430f.json | docs: fix broken blogpost urls (#7106) | docs/guides/plugins.md | @@ -374,6 +374,6 @@ These events work for both basic and advanced plugins. They are triggered on the
[spellbook]: https://github.com/videojs/spellbook
-[standards]: https://github.com/videojs/generator-videojs-plugin/blob/main/docs/standards.md
+[standards]: https://github.com/videojs/generator-videojs-plugin/blob... | true |
Other | videojs | video.js | 541f2e584b7a1fc8e3547ada32d7d9ceb586a1f6.json | fix(dom): stop findPosition at a fullscreenElement (#7074)
On iPads, if the player is inside a floating div, when fullscreen, we'll have an incorrect offset value. Instead, we should stop counting our offsets once we get to our fullscreen element (i.e. the player) because in fullscreen it's outside the regular flow, a... | src/js/utils/dom.js | @@ -4,6 +4,7 @@
*/
import document from 'global/document';
import window from 'global/window';
+import fs from '../fullscreen-api';
import log from './log.js';
import {isObject} from './obj';
import computedStyle from './computed-style';
@@ -564,12 +565,12 @@ export function findPosition(el) {
let left = 0;
... | false |
Other | videojs | video.js | 85575dbababf461463902b52a95891518b53b6b7.json | fix(evented): log an error on invalid type (#7067)
Follow up from #6982. We previously threw an error, but we've seen it
happen unexpectedly. Instead, we should log an error.
We will still throw an error if the event is undefined or null.
Here, if we have a `log` object on the current object, we should use it,
o... | src/js/mixins/evented.js | @@ -8,6 +8,7 @@ import * as Events from '../utils/events';
import * as Fn from '../utils/fn';
import * as Obj from '../utils/obj';
import EventTarget from '../event-target';
+import log from '../utils/log';
const objName = (obj) => {
if (typeof obj.name === 'function') {
@@ -444,8 +445,14 @@ const EventedMixin... | true |
Other | videojs | video.js | 85575dbababf461463902b52a95891518b53b6b7.json | fix(evented): log an error on invalid type (#7067)
Follow up from #6982. We previously threw an error, but we've seen it
happen unexpectedly. Instead, we should log an error.
We will still throw an error if the event is undefined or null.
Here, if we have a `log` object on the current object, we should use it,
o... | test/unit/mixins/evented.test.js | @@ -1,6 +1,7 @@
/* eslint-env qunit */
import sinon from 'sinon';
import evented from '../../../src/js/mixins/evented';
+import log from '../../../src/js/utils/log';
import * as Dom from '../../../src/js/utils/dom';
import * as Obj from '../../../src/js/utils/obj';
@@ -64,26 +65,46 @@ QUnit.test('evented() with ... | true |
Other | videojs | video.js | 9574bb4ad51746f4570a1acdfa7c3e84797f32ae.json | chore: netlify ci demo and docs (#7045) | .gitignore | @@ -38,3 +38,6 @@ core.es.js
# Ignore Chinese clones for now.
lang/zh-Han*.json
+
+# netlify deploy
+deploy/ | true |
Other | videojs | video.js | 9574bb4ad51746f4570a1acdfa7c3e84797f32ae.json | chore: netlify ci demo and docs (#7045) | build/generate-example.js | @@ -1,42 +0,0 @@
-const path = require('path');
-const sh = require('shelljs');
-const pkg = require('../package.json');
-
-const dest = path.join(__dirname, '..', 'docs', 'api');
-const distDest = path.join(dest, 'dist');
-const exampleDest = path.join(dest, 'test-example');
-
-const cleanupExample = function() {
- s... | true |
Other | videojs | video.js | 9574bb4ad51746f4570a1acdfa7c3e84797f32ae.json | chore: netlify ci demo and docs (#7045) | build/netlify-docs.js | @@ -1,26 +1,14 @@
const sh = require('shelljs');
const semver = require('semver');
-const generateExample = require('./generate-example.js').generateExample;
const GIT_LOG = `git log --format=%B -n 1 ${process.env.COMMIT_REF}`;
const output = sh.exec(GIT_LOG, {async: false, silent: true}).stdout;
-// if we're o... | true |
Other | videojs | video.js | 9574bb4ad51746f4570a1acdfa7c3e84797f32ae.json | chore: netlify ci demo and docs (#7045) | build/netlify.js | @@ -0,0 +1,35 @@
+const pkg = require('../package.json');
+const path = require('path');
+const sh = require('shelljs');
+
+process.env.CI = true;
+// run build steps
+sh.exec('npm run build');
+sh.exec('npm run sandbox');
+sh.exec('npm run docs:api');
+
+// copy the legacy docs over
+sh.cp('-R', 'docs/legacy-docs', 'd... | true |
Other | videojs | video.js | 9574bb4ad51746f4570a1acdfa7c3e84797f32ae.json | chore: netlify ci demo and docs (#7045) | index.html | @@ -8,6 +8,7 @@
<h2>Navigation</h2>
<ul>
<li><a href="test/debug.html">Run unit tests in browser.</a></li>
+ <li><a href="docs/api/">view api docs</a></li>
<li><a href="sandbox/index.html">Simple Demo (also seen below)</a></li>
<li><a href="sandbox/plugin.html">Plugin Demo</a></li>
<li><a h... | true |
Other | videojs | video.js | 9574bb4ad51746f4570a1acdfa7c3e84797f32ae.json | chore: netlify ci demo and docs (#7045) | package.json | @@ -70,7 +70,8 @@
"docs:lint": "remark -- './{,!(node_modules)/**/}!(CHANGELOG)*.md'",
"docs:fix": "remark --output -- './{,!(node_modules)/**/}!(CHANGELOG)*.md'",
"docs:lang": "node build/translations.js",
- "netlify": "node ./build/netlify-docs.js",
+ "netlify": "node ./build/netlify.js",
+ "n... | true |
Other | videojs | video.js | e240396f5a51ad2bc07b6bcca37a2dd25408d32b.json | docs: change master to main (#7050) | COLLABORATOR_GUIDE.md | @@ -10,9 +10,9 @@
* [Landing a PR manually](#landing-a-pr-manually)
* [Landing a PR manually with several changes](#landing-a-pr-manually-with-several-changes)
* [I just made a mistake](#i-just-made-a-mistake)
- * [I accidentally pushed a broken commit or incorrect commit to master](#i-accidentally-pu... | true |
Other | videojs | video.js | e240396f5a51ad2bc07b6bcca37a2dd25408d32b.json | docs: change master to main (#7050) | CONTRIBUTING.md | @@ -57,7 +57,7 @@ Guidelines for bug reports:
1. If your issue is with a particular video.js plugin or subproject, please open an issue against that project. See [list of some potential other projects above](#other-repositories-where-issues-could-be-filed)
1. Use the [GitHub issue search](https://github.com/videojs... | true |
Other | videojs | video.js | e240396f5a51ad2bc07b6bcca37a2dd25408d32b.json | docs: change master to main (#7050) | README.md | @@ -23,8 +23,8 @@
Thanks to the awesome folks over at [Fastly][fastly], there's a free, CDN hosted version of Video.js that anyone can use. Add these tags to your document's `<head>`:
```html
-<link href="//vjs.zencdn.net/7.8.2/video-js.min.css" rel="stylesheet">
-<script src="//vjs.zencdn.net/7.8.2/video.min.js"><... | true |
Other | videojs | video.js | e240396f5a51ad2bc07b6bcca37a2dd25408d32b.json | docs: change master to main (#7050) | build/license-header.txt | @@ -3,9 +3,9 @@
* Video.js <%= version %> <http://videojs.com/>
* <%= copyright %>
* Available under Apache License Version 2.0
- * <https://github.com/videojs/video.js/blob/master/LICENSE>
+ * <https://github.com/videojs/video.js/blob/main/LICENSE>
<% if (includesVtt) { %> *
* Includes vtt.js <https://github.... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.