language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | Homebrew | brew | 84b2276fd866342cd84c6ada8ffc13c5c209c3cf.json | Use guard clauses. | Library/Homebrew/cask/lib/hbc/cli/search.rb | @@ -41,14 +41,15 @@ def self.render_results(exact_match, partial_matches, search_term)
ohai "Exact match"
puts exact_match
end
- unless partial_matches.empty?
- if extract_regexp search_term
- ohai "Regexp matches"
- else
- ohai "Partial matc... | true |
Other | Homebrew | brew | 84b2276fd866342cd84c6ada8ffc13c5c209c3cf.json | Use guard clauses. | Library/Homebrew/cask/lib/hbc/installer.rb | @@ -28,22 +28,21 @@ def initialize(cask, command: SystemCommand, force: false, skip_cask_deps: false
def self.print_caveats(cask)
odebug "Printing caveats"
- unless cask.caveats.empty?
- output = capture_output do
- cask.caveats.each do |caveat|
- if caveat.respond_to?(:eva... | true |
Other | Homebrew | brew | 84b2276fd866342cd84c6ada8ffc13c5c209c3cf.json | Use guard clauses. | Library/Homebrew/cask/lib/hbc/utils.rb | @@ -137,13 +137,13 @@ def self.method_missing_message(method, token, section = nil)
def self.nowstamp_metadata_path(container_path)
@timenow ||= Time.now.gmtime
- if container_path.respond_to?(:join)
- precision = 3
- timestamp = @timenow.strftime("%Y%m%d%H%M%S")
- fraction = for... | true |
Other | Homebrew | brew | 84b2276fd866342cd84c6ada8ffc13c5c209c3cf.json | Use guard clauses. | Library/Homebrew/cleanup.rb | @@ -10,10 +10,9 @@ def self.cleanup
cleanup_cellar
cleanup_cache
cleanup_logs
- unless ARGV.dry_run?
- cleanup_lockfiles
- rm_ds_store
- end
+ return if ARGV.dry_run?
+ cleanup_lockfiles
+ rm_ds_store
end
def self.update_disk_cleanup_size(path_size... | true |
Other | Homebrew | brew | 84b2276fd866342cd84c6ada8ffc13c5c209c3cf.json | Use guard clauses. | Library/Homebrew/descriptions.rb | @@ -57,42 +57,41 @@ def self.ensure_cache
# If it does exist, but the Report is empty, just touch the cache file.
# Otherwise, use the report to update the cache.
def self.update_cache(report)
- if CACHE_FILE.exist?
- if report.empty?
- FileUtils.touch CACHE_FILE
- else
- renamings =... | true |
Other | Homebrew | brew | 84b2276fd866342cd84c6ada8ffc13c5c209c3cf.json | Use guard clauses. | Library/Homebrew/extend/ENV/std.rb | @@ -11,9 +11,8 @@ module Stdenv
DEFAULT_FLAGS = "-march=core2 -msse4".freeze
def self.extended(base)
- unless ORIGINAL_PATHS.include? HOMEBREW_PREFIX/"bin"
- base.prepend_path "PATH", "#{HOMEBREW_PREFIX}/bin"
- end
+ return if ORIGINAL_PATHS.include? HOMEBREW_PREFIX/"bin"
+ base.prepend_path "P... | true |
Other | Homebrew | brew | 84b2276fd866342cd84c6ada8ffc13c5c209c3cf.json | Use guard clauses. | Library/Homebrew/sandbox.rb | @@ -27,10 +27,9 @@ def self.test?
end
def self.print_sandbox_message
- unless @printed_sandbox_message
- ohai "Using the sandbox"
- @printed_sandbox_message = true
- end
+ return if @printed_sandbox_message
+ ohai "Using the sandbox"
+ @printed_sandbox_message = true
end
def ini... | true |
Other | Homebrew | brew | d2e2110e80d52e94d84989d71abe9c184d8341f5.json | cc: Add -frounding-math to list of ignored flags | Library/Homebrew/shims/super/cc | @@ -160,7 +160,7 @@ class Cmd
"-fcaller-saves", "-fthread-jumps", "-fno-reorder-blocks", "-fcse-skip-blocks",
"-frerun-cse-after-loop", "-frerun-loop-opt", "-fcse-follow-jumps",
"-fno-regmove", "-fno-for-scope", "-fno-tree-pre", "-fno-tree-dominator-opts",
- "-fuse-linker-plugin"
+ "-fuse... | false |
Other | Homebrew | brew | c7be025229dbbe86d85982a135c75b04c9ba00f2.json | CompilerSelector: fix null check, tests | Library/Homebrew/compilers.rb | @@ -122,13 +122,13 @@ def find_compiler
GNU_GCC_VERSIONS.reverse_each do |v|
name = "gcc-#{v}"
version = compiler_version(name)
- yield Compiler.new(name, version) if version
+ yield Compiler.new(name, version) unless version.null?
end
when :llvm
... | true |
Other | Homebrew | brew | c7be025229dbbe86d85982a135c75b04c9ba00f2.json | CompilerSelector: fix null check, tests | Library/Homebrew/test/test_compiler_selector.rb | @@ -15,15 +15,17 @@ class CompilerVersions
:clang_build_version
def initialize
- @gcc_4_0_build_version = nil
- @gcc_build_version = 5666
- @clang_build_version = 425
+ @gcc_4_0_build_version = Version::NULL
+ @gcc_build_version = Version.create("5666")
+ @llvm_build_version ... | true |
Other | Homebrew | brew | d8c19fd7d5f658f17f63f1136de6f80a46be0d76.json | SystemConfig: fix version reporting | Library/Homebrew/system_config.rb | @@ -143,9 +143,9 @@ def dump_verbose_config(f = $stdout)
f.puts "HOMEBREW_BOTTLE_DOMAIN: #{BottleSpecification::DEFAULT_DOMAIN}"
f.puts hardware if hardware
f.puts "Homebrew Ruby: #{describe_homebrew_ruby}"
- f.puts "GCC-4.0: build #{gcc_40}" if gcc_40
- f.puts "GCC-4.2: build #{gcc_42}" ... | false |
Other | Homebrew | brew | 4e3d23ad14b29832f14784939acc5afe2f1b28f8.json | Resource: set version to nil if version is null
Is this the right fix? This fixes version cascading from the parent. | Library/Homebrew/resource.rb | @@ -145,7 +145,10 @@ def url(val = nil, specs = {})
end
def version(val = nil)
- @version ||= detect_version(val)
+ @version ||= begin
+ version = detect_version(val)
+ version.null? ? nil : version
+ end
end
def mirror(val)
@@ -155,7 +158,7 @@ def mirror(val)
private
def dete... | false |
Other | Homebrew | brew | 20bbeb5e9c4cdd5fb5b7cc92b46325d86b543cf8.json | Return compiler versions and builds as Versions | Library/Homebrew/compilers.rb | @@ -14,7 +14,14 @@ module CompilerConstants
class CompilerFailure
attr_reader :name
- attr_rw :version
+
+ def version(val = nil)
+ if val
+ @version = Version.parse(val.to_s)
+ else
+ @version
+ end
+ end
# Allows Apple compiler `fails_with` statements to keep using `build`
# even t... | true |
Other | Homebrew | brew | 20bbeb5e9c4cdd5fb5b7cc92b46325d86b543cf8.json | Return compiler versions and builds as Versions | Library/Homebrew/development_tools.rb | @@ -44,7 +44,9 @@ def default_compiler
def gcc_40_build_version
@gcc_40_build_version ||=
if (path = locate("gcc-4.0"))
- `#{path} --version 2>/dev/null`[/build (\d{4,})/, 1].to_i
+ Version.new `#{path} --version 2>/dev/null`[/build (\d{4,})/, 1].to_i
+ else
+ Vers... | true |
Other | Homebrew | brew | 7e09379669b8288f280ddf84e2a10a9cf349d038.json | vendor: Update ruby-macho to 0.2.6.
This brings fixes for behavior expected in #1460. | Library/Homebrew/vendor/README.md | @@ -5,7 +5,7 @@ Vendored Dependencies
* [plist](https://github.com/bleything/plist), version 3.1.0
-* [ruby-macho](https://github.com/Homebrew/ruby-macho), version 0.2.5
+* [ruby-macho](https://github.com/Homebrew/ruby-macho), version 0.2.6
## Licenses:
| true |
Other | Homebrew | brew | 7e09379669b8288f280ddf84e2a10a9cf349d038.json | vendor: Update ruby-macho to 0.2.6.
This brings fixes for behavior expected in #1460. | Library/Homebrew/vendor/macho/macho.rb | @@ -13,5 +13,5 @@
# The primary namespace for ruby-macho.
module MachO
# release version
- VERSION = "0.2.5".freeze
+ VERSION = "0.2.6".freeze
end | true |
Other | Homebrew | brew | 7e09379669b8288f280ddf84e2a10a9cf349d038.json | vendor: Update ruby-macho to 0.2.6.
This brings fixes for behavior expected in #1460. | Library/Homebrew/vendor/macho/macho/fat_file.rb | @@ -34,9 +34,7 @@ def initialize(filename)
@filename = filename
@raw_data = File.open(@filename, "rb", &:read)
- @header = populate_fat_header
- @fat_archs = populate_fat_archs
- @machos = populate_machos
+ populate_fields
end
# Initializes a new FatFile instance from a b... | true |
Other | Homebrew | brew | 7e09379669b8288f280ddf84e2a10a9cf349d038.json | vendor: Update ruby-macho to 0.2.6.
This brings fixes for behavior expected in #1460. | Library/Homebrew/vendor/macho/macho/load_commands.rb | @@ -612,52 +612,14 @@ def initialize(view, cmd, cmdsize, init_address, init_module, reserved1,
# A load command containing the address of the dynamic shared library
# initialization routine and an index into the module table for the module
# that defines the routine. Corresponds to LC_ROUTINES_64.
- class Rou... | true |
Other | Homebrew | brew | c5bd5c4aa7f0595c91431407ff5bda4b1938afc3.json | bottle: improve relocatability check
Given how common it is for formulae to hard-code `etc` and `var`, check
for those paths (`/usr/local/etc` and `/usr/local/var`) when determing
relocatability. | Library/Homebrew/dev-cmd/bottle.rb | @@ -251,6 +251,8 @@ def bottle_formula(f)
relocatable = false if keg_contain?(cellar, keg, ignores)
if prefix != prefix_check
relocatable = false if keg_contain_absolute_symlink_starting_with?(prefix, keg)
+ relocatable = false if keg_contain?("#{prefix}/etc", keg, ignores)... | false |
Other | Homebrew | brew | 262eaca56e9efbb21a20be2fe83af563c9b9289e.json | diagnostic: add build error checks. | Library/Homebrew/diagnostic.rb | @@ -93,6 +93,10 @@ def fatal_development_tools_checks
%w[
].freeze
end
+
+ def build_error_checks
+ (development_tools_checks + %w[
+ ]).freeze
end
def check_for_installed_developer_tools | true |
Other | Homebrew | brew | 262eaca56e9efbb21a20be2fe83af563c9b9289e.json | diagnostic: add build error checks. | Library/Homebrew/extend/os/mac/diagnostic.rb | @@ -22,6 +22,11 @@ def fatal_development_tools_checks
check_clt_minimum_version
].freeze
end
+
+ def build_error_checks
+ (development_tools_checks + %w[
+ check_for_unsupported_macos
+ ]).freeze
end
def check_for_unsupported_macos | true |
Other | Homebrew | brew | bccd792bbffaf0c219f402d893be4c5c0d284d97.json | diagnostic: add checks for minimum Xcode/CLT versions. | Library/Homebrew/extend/os/mac/diagnostic.rb | @@ -104,6 +104,27 @@ def check_xcode_8_without_clt_on_el_capitan
EOS
end
+ def check_xcode_minimum_version
+ return unless MacOS::Xcode.installed?
+ return unless MacOS::Xcode.minimum_version?
+
+ <<-EOS.undent
+ Your Xcode (#{MacOS::Xcode.version}) is too outdated.
... | false |
Other | Homebrew | brew | 4015d0465a975aaac26d5a47395ab61e29d1702f.json | xcode: add checks for Xcode/CLT minimum versions. | Library/Homebrew/os/mac/xcode.rb | @@ -25,6 +25,17 @@ def latest_version
end
end
+ def minimum_version
+ case MacOS.version
+ when "10.12" then "8.0"
+ else "2.0"
+ end
+ end
+
+ def minimum_version?
+ version < minimum_version
+ end
+
def prerelease?
# TODO: bump t... | false |
Other | Homebrew | brew | bfa19b338518f50ec7e5c2d2ed4919fa50217dee.json | audit: Escape interpolated string in regexp
This avoids issues with names containing special characters like e.g. [
Fixes #1431 | Library/Homebrew/dev-cmd/audit.rb | @@ -741,7 +741,7 @@ def audit_text
end
bin_names.each do |name|
["system", "shell_output", "pipe_output"].each do |cmd|
- if text =~ /(def test|test do).*#{cmd}[\(\s]+['"]#{name}[\s'"]/m
+ if text =~ /(def test|test do).*#{cmd}[\(\s]+['"]#{Regexp.escape name}[\s'"]/m
problem %(... | false |
Other | Homebrew | brew | 0e15ffff627c17b6c83e7424c0f1357e99902802.json | Correct a few typos
...and update man pages where applicable | Library/Homebrew/cask/lib/hbc/utils.rb | @@ -117,7 +117,7 @@ def self.path_occupied?(path)
def self.error_message_with_suggestions
<<-EOS.undent
- Follow the instuctions here:
+ Follow the instructions here:
#{Formatter.url(PREBUG_URL)}
If this doesn’t fix the problem, please report this bug: | true |
Other | Homebrew | brew | 0e15ffff627c17b6c83e7424c0f1357e99902802.json | Correct a few typos
...and update man pages where applicable | Library/Homebrew/cmd/unpack.rb | @@ -6,7 +6,7 @@
#: If `--patch` is passed, patches for <formulae> will be applied to the
#: unpacked source.
#:
-#: If `--git` is passed, a Git repository will be initalized in the unpacked
+#: If `--git` is passed, a Git repository will be initialized in the unpacked
#: source. This is useful for cr... | true |
Other | Homebrew | brew | 0e15ffff627c17b6c83e7424c0f1357e99902802.json | Correct a few typos
...and update man pages where applicable | Library/Homebrew/dev-cmd/audit.rb | @@ -11,7 +11,7 @@
#: connection are run.
#:
#: If `--new-formula` is passed, various additional checks are run that check
-#: if a new formula is eligable for Homebrew. This should be used when creating
+#: if a new formula is eligible for Homebrew. This should be used when creating
#: new formulae a... | true |
Other | Homebrew | brew | 0e15ffff627c17b6c83e7424c0f1357e99902802.json | Correct a few typos
...and update man pages where applicable | Library/Homebrew/download_strategy.rb | @@ -20,7 +20,7 @@ def initialize(name, resource)
def fetch
end
- # Supress output
+ # Suppress output
def shutup!
@shutup = true
end | true |
Other | Homebrew | brew | 0e15ffff627c17b6c83e7424c0f1357e99902802.json | Correct a few typos
...and update man pages where applicable | Library/Homebrew/formula.rb | @@ -1599,7 +1599,7 @@ def test_fixtures(file)
HOMEBREW_LIBRARY_PATH.join("test", "fixtures", file)
end
- # This method is overriden in {Formula} subclasses to provide the installation instructions.
+ # This method is overridden in {Formula} subclasses to provide the installation instructions.
# The sourc... | true |
Other | Homebrew | brew | 0e15ffff627c17b6c83e7424c0f1357e99902802.json | Correct a few typos
...and update man pages where applicable | Library/Homebrew/migrator.rb | @@ -165,7 +165,7 @@ def migrate
rescue Interrupt
ignore_interrupts { backup_oldname }
rescue Exception => e
- onoe "Error occured while migrating."
+ onoe "Error occurred while migrating."
puts e
puts e.backtrace if ARGV.debug?
puts "Backuping..."
@@ -293,7 +293,7 @@ def ... | true |
Other | Homebrew | brew | 0e15ffff627c17b6c83e7424c0f1357e99902802.json | Correct a few typos
...and update man pages where applicable | docs/brew.1.html | @@ -374,7 +374,7 @@ <h2 id="COMMANDS">COMMANDS</h2>
<p>If <code>--patch</code> is passed, patches for <var>formulae</var> will be applied to the
unpacked source.</p>
-<p>If <code>--git</code> is passed, a Git repository will be initalized in the unpacked
+<p>If <code>--git</code> is passed, a Git repository will be... | true |
Other | Homebrew | brew | 0e15ffff627c17b6c83e7424c0f1357e99902802.json | Correct a few typos
...and update man pages where applicable | manpages/brew-cask.1 | @@ -1,7 +1,7 @@
.\" generated with Ronn/v0.7.3
.\" http://github.com/rtomayko/ronn/tree/0.7.3
.
-.TH "BREW\-CASK" "1" "October 2016" "Homebrew" "brew-cask"
+.TH "BREW\-CASK" "1" "November 2016" "Homebrew" "brew-cask"
.
.SH "NAME"
\fBbrew\-cask\fR \- a friendly binary installer for macOS | true |
Other | Homebrew | brew | 0e15ffff627c17b6c83e7424c0f1357e99902802.json | Correct a few typos
...and update man pages where applicable | manpages/brew.1 | @@ -1,7 +1,7 @@
.\" generated with Ronn/v0.7.3
.\" http://github.com/rtomayko/ronn/tree/0.7.3
.
-.TH "BREW" "1" "October 2016" "Homebrew" "brew"
+.TH "BREW" "1" "November 2016" "Homebrew" "brew"
.
.SH "NAME"
\fBbrew\fR \- The missing package manager for macOS
@@ -518,7 +518,7 @@ Unpack the source files for \fIfor... | true |
Other | Homebrew | brew | f796fe794d2827d61feb4eb7509697f2312ed7d9.json | rubocop: exclude more tap dirs from hash rockets.
This is useful for e.g. homebrew/bundle that doesn't live in just
`cmd`. | Library/.rubocop.yml | @@ -88,7 +88,10 @@ Style/GuardClause:
Style/HashSyntax:
EnforcedStyle: hash_rockets
Exclude:
+ - '**/bin/**/*'
- '**/cmd/**/*'
+ - '**/lib/**/*'
+ - '**/spec/**/*'
# disabled until it respects line length
Style/IfUnlessModifier: | false |
Other | Homebrew | brew | 72f889fef06def94083f4d0457b5729ef151bc16.json | audit: restore check that was lost in #927
This audit check ensures that certain build dependencies
are explicitly marked either as `:build` or `:run`.
It seems to have been lost in #927.
It was also adjusted in #1290. | Library/Homebrew/dev-cmd/audit.rb | @@ -415,6 +415,12 @@ def audit_deps
EOS
when *BUILD_TIME_DEPS
next if dep.build? || dep.run?
+ problem <<-EOS.undent
+ #{dep} dependency should be
+ depends_on "#{dep}" => :build
+ Or if it is indeed a runtime dependency
+ depends... | false |
Other | Homebrew | brew | 3396d479d2cc87fed0f9a74f711881ea1784e0d6.json | build: write options to file.
These can be useful for later inspection or upload by `gist-logs` if
there's a failed install and it's unclear from logs alone what options
were used. | Library/Homebrew/build.rb | @@ -132,6 +132,8 @@ def install
else
formula.prefix.mkpath
+ (formula.logs/"00.options.out").write \
+ "#{formula.full_name} #{formula.build.used_options.sort.join(" ")}".strip
formula.install
stdlibs = detect_stdlibs(ENV.compiler) | false |
Other | Homebrew | brew | 9f382bfd538cfdefd17712a19cd426ba4917175e.json | boneyard-formula-pr: add reason argument.
Used to provide a user-facing reason why this formula was boneyarded. | Library/Homebrew/dev-cmd/boneyard-formula-pr.rb | @@ -1,10 +1,12 @@
#: @hide_from_man_page
-#: * `boneyard-formula-pr` [`--dry-run`] [`--local`] <formula-name>:
+#: * `boneyard-formula-pr` [`--dry-run`] [`--local`] [`--reason=<reason>`] <formula-name> :
#: Creates a pull request to boneyard a formula.
#:
#: If `--dry-run` is passed, print what would be do... | false |
Other | Homebrew | brew | 702345ee67db78d8f2a97f68f4b4bd2803ad8538.json | docs: fix typo for brew missing | Library/Homebrew/cmd/missing.rb | @@ -3,7 +3,7 @@
#: given, check all installed brews.
#:
#: If `--hide=`<hidden> is passed, act as if none of <hidden> are installed.
-#: <hidden> should be a comma-seperated list of formulae.
+#: <hidden> should be a comma-separated list of formulae.
require "formula"
require "tab" | false |
Other | Homebrew | brew | e26750e11290f6b299fcbf8419ac051a985e0e1a.json | superenv: treat timingsafe_bcmp as weak on 10.11
Xcode 8.1 added timingsafe_bcmp to string.h and libsystem_c.tbd,
and 10.12.1 added it to libsystem_c.dylib, but it is not present in
libsystem_c.dylib on 10.11.6 (15G1108).
It may appear in libsystem_c.dylib in a later 10.11 release or it may
be marked weak on 10.11 in... | Library/Homebrew/extend/os/mac/extend/ENV/super.rb | @@ -98,7 +98,7 @@ def setup_build_environment(formula = nil)
# can't reliably figure this out with Xcode 8 on its own yet.
if MacOS.version == "10.11" && MacOS::Xcode.installed? && MacOS::Xcode.version >= "8.0"
%w[basename_r clock_getres clock_gettime clock_settime dirname_r
- getentropy mkoste... | false |
Other | Homebrew | brew | a3efe57fd62f587dd0242815cc02296560ec161a.json | docs: remove zmwangx from the list of maintainers | README.md | @@ -40,7 +40,7 @@ This is our PGP key which is valid until May 24, 2017.
## Who Are You?
Homebrew's lead maintainer is [Mike McQuaid](https://github.com/mikemcquaid).
-Homebrew's current maintainers are [Misty De Meo](https://github.com/mistydemeo), [Andrew Janke](https://github.com/apjanke), [Xu Cheng](https://git... | true |
Other | Homebrew | brew | a3efe57fd62f587dd0242815cc02296560ec161a.json | docs: remove zmwangx from the list of maintainers | docs/brew.1.html | @@ -765,7 +765,7 @@ <h2 id="AUTHORS">AUTHORS</h2>
<p>Homebrew's lead maintainer is Mike McQuaid.</p>
-<p>Homebrew's current maintainers are Misty De Meo, Andrew Janke, Xu Cheng, Tomasz Pajor, Josh Hagins, Baptiste Fontaine, Zhiming Wang, Markus Reiter, ilovezfs, Martin Afanasjew, Tom Schoonjans, Uladzislau Shablin... | true |
Other | Homebrew | brew | a3efe57fd62f587dd0242815cc02296560ec161a.json | docs: remove zmwangx from the list of maintainers | manpages/brew.1 | @@ -1034,7 +1034,7 @@ Homebrew Documentation: \fIhttps://github\.com/Homebrew/brew/blob/master/docs/\f
Homebrew\'s lead maintainer is Mike McQuaid\.
.
.P
-Homebrew\'s current maintainers are Misty De Meo, Andrew Janke, Xu Cheng, Tomasz Pajor, Josh Hagins, Baptiste Fontaine, Zhiming Wang, Markus Reiter, ilovezfs, Mar... | true |
Other | Homebrew | brew | ec83d1decb7cf7166ccf0021f998503975a845f3.json | uninstall: remove more integration tests | Library/Homebrew/test/test_uninstall.rb | @@ -23,44 +23,8 @@ def test_check_for_dependents_when_ignore_dependencies
end
class IntegrationCommandTestUninstall < IntegrationCommandTestCase
- def setup
- super
- @f1_path = setup_test_formula "testball_f1", <<-CONTENT
- def install
- FileUtils.touch prefix/touch("hello")
- end
- CONT... | false |
Other | Homebrew | brew | d0ad09708218bfbffed4857387b259bceba177c2.json | uninstall: remove duplicated method
This was moved to Keg, but looks like I forgot to get rid of it here. | Library/Homebrew/cmd/uninstall.rb | @@ -92,39 +92,6 @@ def check_for_dependents(kegs)
true
end
- # Will return some kegs, and some dependencies, if they're present.
- # For efficiency, we don't bother trying to get complete data.
- def find_some_installed_dependents(kegs)
- kegs.each do |keg|
- dependents = keg.installed_dependents -... | false |
Other | Homebrew | brew | c4c855b9fc8695664a66dd7822a483b91e3e26e3.json | ARGV: extract #values from missing | Library/Homebrew/cmd/missing.rb | @@ -18,10 +18,8 @@ def missing
ARGV.resolved_formulae
end
- hide = (ARGV.value("hide") || "").split(",")
-
ff.each do |f|
- missing = f.missing_dependencies(hide: hide)
+ missing = f.missing_dependencies(hide: ARGV.values("hide"))
next if missing.empty?
print "#{f}: " if ... | true |
Other | Homebrew | brew | c4c855b9fc8695664a66dd7822a483b91e3e26e3.json | ARGV: extract #values from missing | Library/Homebrew/extend/ARGV.rb | @@ -121,6 +121,13 @@ def value(name)
flag_with_value.strip_prefix(arg_prefix) if flag_with_value
end
+ # Returns an array of values that were given as a comma-seperated list.
+ # @see value
+ def values(name)
+ return unless val = value(name)
+ val.split(",")
+ end
+
def force?
flag? "--forc... | true |
Other | Homebrew | brew | c4c855b9fc8695664a66dd7822a483b91e3e26e3.json | ARGV: extract #values from missing | Library/Homebrew/test/test_ARGV.rb | @@ -62,4 +62,19 @@ def test_flag?
assert !@argv.flag?("--frotz")
assert !@argv.flag?("--debug")
end
+
+ def test_value
+ @argv << "--foo=" << "--bar=ab"
+ assert_equal "", @argv.value("foo")
+ assert_equal "ab", @argv.value("bar")
+ assert_nil @argv.value("baz")
+ end
+
+ def test_values
+ ... | true |
Other | Homebrew | brew | a4dc835ba06e7d1cd2a6b6b4ffacf4416b35ffea.json | uninstall: call Formula#missing_dependencies directly | Library/Homebrew/cmd/uninstall.rb | @@ -76,7 +76,7 @@ def uninstall
end
def check_for_dependents(kegs)
- return false unless result = find_some_installed_dependents(kegs)
+ return false unless result = Keg.find_some_installed_dependents(kegs)
requireds, dependents = result
@@ -108,8 +108,16 @@ def find_some_installed_dependents(keg... | true |
Other | Homebrew | brew | a4dc835ba06e7d1cd2a6b6b4ffacf4416b35ffea.json | uninstall: call Formula#missing_dependencies directly | Library/Homebrew/keg.rb | @@ -87,6 +87,41 @@ def to_s; <<-EOS.undent
mime-info pixmaps sounds postgresql
].freeze
+ # Will return some kegs, and some dependencies, if they're present.
+ # For efficiency, we don't bother trying to get complete data.
+ def self.find_some_installed_dependents(kegs)
+ # First, check in the tabs of i... | true |
Other | Homebrew | brew | a4dc835ba06e7d1cd2a6b6b4ffacf4416b35ffea.json | uninstall: call Formula#missing_dependencies directly | Library/Homebrew/test/test_uninstall.rb | @@ -31,6 +31,32 @@ def test_uninstall
assert_empty Formulary.factory(testball).installed_kegs
end
+ def test_uninstall_with_unrelated_missing_deps_in_tab
+ setup_test_formula "testball"
+ run_as_not_developer do
+ cmd("install", testball)
+ cmd("install", "testball_f2")
+ cmd("uninstall"... | true |
Other | Homebrew | brew | 422f38b945ac9f13ea5f9290b022a18c811445e4.json | missing: call Formula#missing_dependencies directly | Library/Homebrew/cmd/missing.rb | @@ -18,8 +18,13 @@ def missing
ARGV.resolved_formulae
end
- Diagnostic.missing_deps(ff, ARGV.value("hide")) do |name, missing|
- print "#{name}: " if ff.size > 1
+ hide = (ARGV.value("hide") || "").split(",")
+
+ ff.each do |f|
+ missing = f.missing_dependencies(hide: hide)
+ next ... | false |
Other | Homebrew | brew | c88b67f3a8f7e90ad974eaf82d00fd88827a1e4c.json | missing: simplify code a bit | Library/Homebrew/diagnostic.rb | @@ -8,6 +8,8 @@
module Homebrew
module Diagnostic
def self.missing_deps(ff, hide = nil)
+ hide ||= []
+
missing = {}
ff.each do |f|
missing_deps = f.recursive_dependencies do |dependent, dep|
@@ -20,12 +22,8 @@ def self.missing_deps(ff, hide = nil)
end
missing_de... | false |
Other | Homebrew | brew | 8e3e8e31c23e5ec6e204ee5462cb9d22119891ee.json | missing: add tests for not missing and hide | Library/Homebrew/test/test_missing.rb | @@ -1,11 +1,34 @@
require "helper/integration_command_test_case"
class IntegrationCommandTestMissing < IntegrationCommandTestCase
- def test_missing
+ def setup
+ super
+
setup_test_formula "foo"
setup_test_formula "bar"
+ end
+
+ def make_prefix(name)
+ (HOMEBREW_CELLAR/name/"1.0").mkpath
+ en... | false |
Other | Homebrew | brew | 888c44b238b6a5afa705ca46f6a682ac1c4bb729.json | uninstall: fix dependent order bug | Library/Homebrew/cmd/uninstall.rb | @@ -16,7 +16,7 @@ def uninstall
if !ARGV.force?
ARGV.kegs.each do |keg|
- dependents = keg.installed_dependents
+ dependents = keg.installed_dependents - ARGV.kegs
if dependents.any?
dependents_output = dependents.map { |k| "#{k.name} #{k.version}" }.join(", ")
... | true |
Other | Homebrew | brew | 888c44b238b6a5afa705ca46f6a682ac1c4bb729.json | uninstall: fix dependent order bug | Library/Homebrew/test/test_uninstall.rb | @@ -1,8 +1,43 @@
require "helper/integration_command_test_case"
class IntegrationCommandTestUninstall < IntegrationCommandTestCase
+ def setup
+ super
+ @f1_path = setup_test_formula "testball_f1", <<-CONTENT
+ def install
+ FileUtils.touch prefix/touch("hello")
+ end
+ CONTENT
+ @f2_p... | true |
Other | Homebrew | brew | 6a406763f306d88c52729343b4a65e9050f8981f.json | Open incomplete download in append mode
Open the incomplete download in append mode instead of write mode.
Opening in write mode truncates the existing file, so curl keeps
restarting downloads instead of resuming the incomplete downloads. | Library/Homebrew/cask/lib/hbc/download_strategy.rb | @@ -105,7 +105,7 @@ def fetch
else
had_incomplete_download = temporary_path.exist?
begin
- File.open(temporary_path, "w+") do |f|
+ File.open(temporary_path, "a+") do |f|
f.flock(File::LOCK_EX)
_fetch
f.flock(File::LOCK_UN) | false |
Other | Homebrew | brew | 652c5bc865ebda25ead84c5cab04a4688b4e2b9a.json | formula_installer: fix regression in #1253
Apparently `cellar :any_skip_relocation` doesn't actually mean we
can skip relocation, at least for text files. | Library/Homebrew/formula_installer.rb | @@ -762,12 +762,11 @@ def pour
end
keg = Keg.new(formula.prefix)
+ tab = Tab.for_keg(keg)
+ Tab.clear_cache
- unless formula.bottle_specification.skip_relocation?
- tab = Tab.for_keg(keg)
- Tab.clear_cache
- keg.replace_placeholders_with_locations tab.changed_files
- end
+ sk... | true |
Other | Homebrew | brew | 652c5bc865ebda25ead84c5cab04a4688b4e2b9a.json | formula_installer: fix regression in #1253
Apparently `cellar :any_skip_relocation` doesn't actually mean we
can skip relocation, at least for text files. | Library/Homebrew/keg_relocate.rb | @@ -40,7 +40,7 @@ def replace_locations_with_placeholders
replace_text_in_files(relocation)
end
- def replace_placeholders_with_locations(files)
+ def replace_placeholders_with_locations(files, skip_linkage: false)
relocation = Relocation.new(
old_prefix: PREFIX_PLACEHOLDER,
old_cellar: C... | true |
Other | Homebrew | brew | 5b64fa6fb179bee5e45e16bb4f860579d76d4210.json | metafiles: convert Metafiles class to module | Library/Homebrew/metafiles.rb | @@ -1,6 +1,6 @@
require "set"
-class Metafiles
+module Metafiles
# https://github.com/github/markup#markups
EXTENSIONS = Set.new %w[
.adoc .asc .asciidoc .creole .html .markdown .md .mdown .mediawiki .mkdn
@@ -11,12 +11,14 @@ class Metafiles
news notes notice readme todo
].freeze
- def self.lis... | false |
Other | Homebrew | brew | 9628a613cfe75669c180bf78d086f0372efce30e.json | metafiles: use Set.new instead of Array#to_set | Library/Homebrew/metafiles.rb | @@ -2,14 +2,14 @@
class Metafiles
# https://github.com/github/markup#markups
- EXTENSIONS = %w[
+ EXTENSIONS = Set.new %w[
.adoc .asc .asciidoc .creole .html .markdown .md .mdown .mediawiki .mkdn
.org .pod .rdoc .rst .rtf .textile .txt .wiki
- ].to_set.freeze
- BASENAMES = %w[
+ ].freeze
+ BASENAM... | false |
Other | Homebrew | brew | ce33f593b4259d5710cdf36da808be884ddedeef.json | metafiles: convert EXTENSIONS and BASENAMES from Array to Set | Library/Homebrew/metafiles.rb | @@ -1,13 +1,15 @@
+require "set"
+
class Metafiles
# https://github.com/github/markup#markups
EXTENSIONS = %w[
.adoc .asc .asciidoc .creole .html .markdown .md .mdown .mediawiki .mkdn
.org .pod .rdoc .rst .rtf .textile .txt .wiki
- ].freeze
+ ].to_set.freeze
BASENAMES = %w[
about authors chan... | false |
Other | Homebrew | brew | b2870c2480744aa7d202c4975e3169b05035f7ed.json | hbc/qualified_token: use regex captures instead of String#split | Library/Homebrew/cask/lib/hbc/qualified_token.rb | @@ -2,10 +2,8 @@ module Hbc
module QualifiedToken
def self.parse(arg)
return nil unless arg.is_a?(String)
- return nil unless arg.downcase =~ HOMEBREW_TAP_CASK_REGEX
- # eg caskroom/cask/google-chrome
- # per https://github.com/Homebrew/brew/blob/master/docs/brew-tap.md
- user, repo, ... | false |
Other | Homebrew | brew | 0b8af5771f590bfb5cea7bccd4bd0fc77a973113.json | Remove duplicate description of <token> | Library/Homebrew/manpages/brew-cask.1.md | @@ -89,9 +89,6 @@ names, and other aspects of this manual are still subject to change.
* `reinstall` <token> [ <token> ...]
Reinstall the given Cask.
- <token> is usually the ID of a Cask as returned by `brew cask search`,
- but see [OTHER WAYS TO SPECIFY A CASK][] for variations.
-
* `search` or `-S... | true |
Other | Homebrew | brew | 0b8af5771f590bfb5cea7bccd4bd0fc77a973113.json | Remove duplicate description of <token> | manpages/brew-cask.1 | @@ -79,9 +79,6 @@ If \fItoken\fR is given, summarize the staged files associated with the given Ca
.IP "\(bu" 4
\fBreinstall\fR \fItoken\fR [ \fItoken\fR \.\.\.] Reinstall the given Cask\.
.
-.IP
-\fItoken\fR is usually the ID of a Cask as returned by \fBbrew cask search\fR, but see \fIOTHER WAYS TO SPECIFY A CASK\f... | true |
Other | Homebrew | brew | 44f1354d63d8c95a61bb12353838c03e9abbebb6.json | hbc/qualified_token: simplify token parsing
- Stop supporting archaic "user-repo/token" syntax
- Move regex for parsing tapped Cask token to tap_constants | Library/Homebrew/cask/lib/hbc/qualified_token.rb | @@ -1,37 +1,11 @@
module Hbc
module QualifiedToken
- REPO_PREFIX = "homebrew-".freeze
-
- # per https://github.com/Homebrew/homebrew/blob/4c7bc9ec3bca729c898ee347b6135ba692ee0274/Library/Homebrew/cmd/tap.rb#L121
- USER_REGEX = /[a-z0-9_\-]+/
-
- # per https://github.com/Homebrew/homebrew/blob/4c7bc9ec3b... | true |
Other | Homebrew | brew | 44f1354d63d8c95a61bb12353838c03e9abbebb6.json | hbc/qualified_token: simplify token parsing
- Stop supporting archaic "user-repo/token" syntax
- Move regex for parsing tapped Cask token to tap_constants | Library/Homebrew/tap_constants.rb | @@ -1,5 +1,7 @@
# match taps' formulae, e.g. someuser/sometap/someformula
HOMEBREW_TAP_FORMULA_REGEX = %r{^([\w-]+)/([\w-]+)/([\w+-.@]+)$}
+# match taps' casks, e.g. someuser/sometap/somecask
+HOMEBREW_TAP_CASK_REGEX = %r{^([\w-]+)/([\w-]+)/([a-z0-9\-]+)$}
# match taps' directory paths, e.g. HOMEBREW_LIBRARY/Taps/so... | true |
Other | Homebrew | brew | 95d4a258914867ef6237709dd03971dbec765324.json | Fix linting errors | Library/Homebrew/cask/lib/hbc/cli/reinstall.rb | @@ -14,8 +14,9 @@ def self.install_casks(cask_tokens, force, skip_cask_deps, require_sha)
unless latest_installed_version.nil?
latest_installed_cask_file = installed_cask.metadata_master_container_path
- .join(latest_installed_version.joi... | false |
Other | Homebrew | brew | 32dc78835db1dff9135c3da9bc577f29469fb059.json | Add documentation for cask reinstall command | Library/Homebrew/manpages/brew-cask.1.md | @@ -86,6 +86,12 @@ names, and other aspects of this manual are still subject to change.
If <token> is given, summarize the staged files associated with the
given Cask.
+ * `reinstall` <token> [ <token> ...]
+ Reinstall the given Cask.
+
+ <token> is usually the ID of a Cask as returned by `brew cask ... | true |
Other | Homebrew | brew | 32dc78835db1dff9135c3da9bc577f29469fb059.json | Add documentation for cask reinstall command | manpages/brew-cask.1 | @@ -34,78 +34,68 @@ The tokens returned by \fBsearch\fR are suitable as arguments for most other com
.
.SH "COMMANDS"
.
-.TP
-\fBaudit\fR [ \fItoken\fR \.\.\. ]
-Check the given Casks for installability\. If no tokens are given on the command line, all Casks are audited\.
+.IP "\(bu" 4
+\fBaudit\fR [ \fItoken\fR \.\... | true |
Other | Homebrew | brew | 0b176f9cc8ee4f95271fc398b6e9a521bda9ebdb.json | Add dictionary artifact | Library/Homebrew/cask/lib/hbc/artifact.rb | @@ -2,6 +2,7 @@
require "hbc/artifact/artifact" # generic 'artifact' stanza
require "hbc/artifact/binary"
require "hbc/artifact/colorpicker"
+require "hbc/artifact/dictionary"
require "hbc/artifact/font"
require "hbc/artifact/input_method"
require "hbc/artifact/installer"
@@ -38,6 +39,7 @@ def self.artifacts
... | true |
Other | Homebrew | brew | 0b176f9cc8ee4f95271fc398b6e9a521bda9ebdb.json | Add dictionary artifact | Library/Homebrew/cask/lib/hbc/artifact/dictionary.rb | @@ -0,0 +1,8 @@
+require "hbc/artifact/moved"
+
+module Hbc
+ module Artifact
+ class Dictionary < Moved
+ end
+ end
+end | true |
Other | Homebrew | brew | 0b176f9cc8ee4f95271fc398b6e9a521bda9ebdb.json | Add dictionary artifact | Library/Homebrew/cask/lib/hbc/cli.rb | @@ -54,6 +54,7 @@ class CLI
"--colorpickerdir=" => :colorpickerdir=,
"--prefpanedir=" => :prefpanedir=,
"--qlplugindir=" => :qlplugindir=,
+ "--dictionarydir=" => :dictionarydir=,
"--fontdir=" => :fontdir=,
"--servicedir=" => ... | true |
Other | Homebrew | brew | 0b176f9cc8ee4f95271fc398b6e9a521bda9ebdb.json | Add dictionary artifact | Library/Homebrew/cask/lib/hbc/cli/internal_stanza.rb | @@ -28,6 +28,7 @@ class InternalStanza < InternalUseBase
:artifact,
:prefpane,
:qlplugin,
+ :dictionary,
:font,
:service,
:colorpicker, | true |
Other | Homebrew | brew | 0b176f9cc8ee4f95271fc398b6e9a521bda9ebdb.json | Add dictionary artifact | Library/Homebrew/cask/lib/hbc/dsl.rb | @@ -24,6 +24,7 @@ class DSL
:audio_unit_plugin,
:binary,
:colorpicker,
+ :dictionary,
:font,
:input_method,
:internet_plugin, | true |
Other | Homebrew | brew | 0b176f9cc8ee4f95271fc398b6e9a521bda9ebdb.json | Add dictionary artifact | Library/Homebrew/cask/lib/hbc/locations.rb | @@ -64,6 +64,12 @@ def qlplugindir
@qlplugindir ||= Pathname.new("~/Library/QuickLook").expand_path
end
+ attr_writer :dictionarydir
+
+ def dictionarydir
+ @dictionarydir ||= Pathname.new("~/Library/Dictionaries").expand_path
+ end
+
attr_writer :fontdir
def font... | true |
Other | Homebrew | brew | 0b176f9cc8ee4f95271fc398b6e9a521bda9ebdb.json | Add dictionary artifact | Library/Homebrew/cask/test/cask/cli/options_test.rb | @@ -57,6 +57,20 @@
Hbc.colorpickerdir.must_equal Pathname("/some/path/bar")
end
+ it "supports setting the dictionarydir" do
+ Hbc::CLI.process_options %w[help --dictionarydir=/some/path/foo]
+
+ Hbc.dictionarydir.must_equal Pathname("/some/path/foo")
+ end
+
+ it "supports setting the dictionarydir ... | true |
Other | Homebrew | brew | 0b176f9cc8ee4f95271fc398b6e9a521bda9ebdb.json | Add dictionary artifact | Library/Homebrew/manpages/brew-cask.1.md | @@ -155,6 +155,9 @@ in a future version.
* `--qlplugindir=<path>`:
Target location for QuickLook Plugins. The default value is `~/Library/QuickLook`.
+ * `--dictionarydir=<path>`:
+ Target location for Dictionaries. The default value is `~/Library/Dictionaries`.
+
* `--fontdir=<path>`:
Target loca... | true |
Other | Homebrew | brew | 0b176f9cc8ee4f95271fc398b6e9a521bda9ebdb.json | Add dictionary artifact | completions/zsh/_brew_cask | @@ -169,6 +169,7 @@ _brew_cask()
'--colorpickerdir=-:Target location for Color Pickers. The default value is ~/Library/ColorPickers.' \
'--prefpanedir=-:Target location for Preference Panes. The default value is ~/Library/PreferencePanes.' \
'--qlplugindir=-:Target location for QuickLook Plugins. The def... | true |
Other | Homebrew | brew | 0b176f9cc8ee4f95271fc398b6e9a521bda9ebdb.json | Add dictionary artifact | manpages/brew-cask.1 | @@ -162,6 +162,10 @@ Target location for Preference Panes\. The default value is \fB~/Library/Prefere
Target location for QuickLook Plugins\. The default value is \fB~/Library/QuickLook\fR\.
.
.TP
+\fB\-\-dictionarydir=<path>\fR
+Target location for Dictionaries\. The default value is \fB~/Library/Dictionaries\fR\.
... | true |
Other | Homebrew | brew | cb8af6d751d1c31bc379f96f5aeee9cc84cacf49.json | Fix failing test caused by `repo_info`. | Library/Homebrew/cask/lib/hbc/cli/info.rb | @@ -20,7 +20,7 @@ def self.info(cask)
puts "#{cask.token}: #{cask.version}"
puts Formatter.url(cask.homepage) if cask.homepage
installation_info(cask)
- puts "From: #{Formatter.url(repo_info(cask))}" if repo_info(cask)
+ puts "From: #{Formatter.url(repo_info(cask))}"
na... | true |
Other | Homebrew | brew | cb8af6d751d1c31bc379f96f5aeee9cc84cacf49.json | Fix failing test caused by `repo_info`. | Library/Homebrew/cask/test/cask/cli/info_test.rb | @@ -8,7 +8,7 @@
local-caffeine: 1.2.3
http://example.com/local-caffeine
Not installed
- From: https://github.com/caskroom/homebrew-testcasks/blob/master/Casks/local-caffeine.rb
+ From: https://github.com/caskroom/homebrew-test/blob/master/Casks/local-caffeine.rb
==> Name
Non... | true |
Other | Homebrew | brew | 827b48912ab0a2d36ca7b29d8bd5849b360c9c6c.json | Avoid empty rescue. | Library/Homebrew/cask/test/cask/cli/install_test.rb | @@ -63,16 +63,20 @@
lambda {
begin
Hbc::CLI::Install.run("googlechrome")
- rescue Hbc::CaskError; end
- }.must_output nil, /No available Cask for googlechrome\. Did you mean:\ngoogle-chrome/
+ rescue Hbc::CaskError
+ nil
+ end
+ }.must_output(nil, /No available Cask for ... | false |
Other | Homebrew | brew | 8c488de3f654af452d1cdfe5be26aca87b29af3c.json | Remove unnecessary string interpolation. | Library/Homebrew/cask/lib/hbc/cli/info.rb | @@ -53,7 +53,7 @@ def self.name_info(cask)
def self.repo_info(cask)
user, repo, token = QualifiedToken.parse(Hbc.all_tokens.detect { |t| t.split("/").last == cask.token })
remote_tap = Tap.fetch(user, repo)
- return "#{remote_tap.remote}" if remote_tap.custom_remote?
+ return remo... | false |
Other | Homebrew | brew | 15b858ccc4de1e76e8251c69b5f1a30af223d3c3.json | Use double quotes. | Library/Homebrew/cask/spec/formatter_spec.rb | @@ -5,10 +5,10 @@
describe "::columns" do
let(:input) {
[
- 'aa',
- 'bbb',
- 'ccc',
- 'dd'
+ "aa",
+ "bbb",
+ "ccc",
+ "dd",
]
}
subject { described_class.columns(input) } | false |
Other | Homebrew | brew | 783dbcc937b3f8afb79e7e8ff7cb6ff9f591746c.json | Use short-style lambdas. | Library/Homebrew/cask/test/cask/artifact/alt_target_test.rb | @@ -5,7 +5,7 @@
let(:cask) { Hbc.load("with-alt-target") }
let(:install_phase) {
- lambda { Hbc::Artifact::App.new(cask).install_phase }
+ -> { Hbc::Artifact::App.new(cask).install_phase }
}
let(:source_path) { cask.staged_path.join("Caffeine.app") } | true |
Other | Homebrew | brew | 783dbcc937b3f8afb79e7e8ff7cb6ff9f591746c.json | Use short-style lambdas. | Library/Homebrew/cask/test/cask/artifact/app_test.rb | @@ -9,13 +9,8 @@
let(:source_path) { cask.staged_path.join("Caffeine.app") }
let(:target_path) { Hbc.appdir.join("Caffeine.app") }
- let(:install_phase) {
- lambda { app.install_phase }
- }
-
- let(:uninstall_phase) {
- lambda { app.uninstall_phase }
- }
+ let(:install_phase) { -> { app.install_phase... | true |
Other | Homebrew | brew | 783dbcc937b3f8afb79e7e8ff7cb6ff9f591746c.json | Use short-style lambdas. | Library/Homebrew/cask/test/cask/artifact/generic_artifact_test.rb | @@ -4,7 +4,7 @@
let(:cask) { Hbc.load("with-generic-artifact") }
let(:install_phase) {
- lambda { Hbc::Artifact::Artifact.new(cask).install_phase }
+ -> { Hbc::Artifact::Artifact.new(cask).install_phase }
}
let(:source_path) { cask.staged_path.join("Caffeine.app") } | true |
Other | Homebrew | brew | 783dbcc937b3f8afb79e7e8ff7cb6ff9f591746c.json | Use short-style lambdas. | Library/Homebrew/cask/test/cask/artifact/suite_test.rb | @@ -3,9 +3,7 @@
describe Hbc::Artifact::Suite do
let(:cask) { Hbc.load("with-suite") }
- let(:install_phase) {
- lambda { Hbc::Artifact::Suite.new(cask).install_phase }
- }
+ let(:install_phase) { -> { Hbc::Artifact::Suite.new(cask).install_phase } }
let(:target_path) { Hbc.appdir.join("Caffeine") }
... | true |
Other | Homebrew | brew | 783dbcc937b3f8afb79e7e8ff7cb6ff9f591746c.json | Use short-style lambdas. | Library/Homebrew/cask/test/cask/artifact/two_apps_correct_test.rb | @@ -5,7 +5,7 @@
let(:cask) { Hbc.load("with-two-apps-correct") }
let(:install_phase) {
- lambda { Hbc::Artifact::App.new(cask).install_phase }
+ -> { Hbc::Artifact::App.new(cask).install_phase }
}
let(:source_path_mini) { cask.staged_path.join("Caffeine Mini.app") } | true |
Other | Homebrew | brew | ceec5a82c15cf636c8953da15ae73fbc882c5424.json | Use guard clauses. | Library/Homebrew/cask/lib/hbc/cask.rb | @@ -11,10 +11,9 @@ def initialize(token, sourcefile_path: nil, dsl: nil, &block)
@token = token
@sourcefile_path = sourcefile_path
@dsl = dsl || DSL.new(@token)
- if block_given?
- @dsl.instance_eval(&block)
- @dsl.language_eval
- end
+ return unless block_given?
+ ... | false |
Other | Homebrew | brew | 13e3272e37d18f0ad3a6273519958bcada30dbbb.json | Remove Cask’s RuboCop configuration. | Library/.rubocop.yml | @@ -1,5 +1,7 @@
AllCops:
TargetRubyVersion: 2.0
+ Exclude:
+ - '**/Casks/**/*'
Metrics/AbcSize:
Enabled: false | true |
Other | Homebrew | brew | 13e3272e37d18f0ad3a6273519958bcada30dbbb.json | Remove Cask’s RuboCop configuration. | Library/Homebrew/.rubocop.yml | @@ -6,7 +6,7 @@ AllCops:
Include:
- '**/.simplecov'
Exclude:
- - 'cask/**/*'
+ - '**/Casks/**/*'
- '**/vendor/**/*'
# so many of these in formulae but none in here | true |
Other | Homebrew | brew | 13e3272e37d18f0ad3a6273519958bcada30dbbb.json | Remove Cask’s RuboCop configuration. | Library/Homebrew/cask/.rubocop.yml | @@ -1,131 +0,0 @@
-AllCops:
- TargetRubyVersion: 2.0
- Exclude:
- - '**/.simplecov'
- - '**/Casks/**/*'
- - '**/vendor/**/*'
-
-Metrics/AbcSize:
- Enabled: false
-
-Metrics/ClassLength:
- Enabled: false
-
-Metrics/CyclomaticComplexity:
- Enabled: false
-
-Metrics/LineLength:
- Enabled: false
-
-Metrics/M... | true |
Other | Homebrew | brew | 31fb99680026fb285bc69f1641e3fbdbed09ee98.json | Remove unncessary semicolon | Library/Homebrew/cask/lib/hbc/cli/reinstall.rb | @@ -9,7 +9,7 @@ def self.install_casks(cask_tokens, force, skip_cask_deps, require_sha)
if cask.installed?
# use copy of cask for uninstallation to avoid 'No such file or directory' bug
- installed_cask = cask;
+ installed_cask = cask
latest_install... | false |
Other | Homebrew | brew | 1d8e59b31f060b6d60a98d888263d2be783637ce.json | dev-cmd/man: use SOURCE_PATH instead of HOMEBREW_LIBRARY
Don't Repeat Yourself. | Library/Homebrew/dev-cmd/man.rb | @@ -41,7 +41,7 @@ def regenerate_man_pages
convert_man_page(markup, TARGET_DOC_PATH/"brew.1.html")
convert_man_page(markup, TARGET_MAN_PATH/"brew.1")
- cask_markup = (HOMEBREW_LIBRARY/"Homebrew/manpages/brew-cask.1.md").read
+ cask_markup = (SOURCE_PATH/"brew-cask.1.md").read
convert_man_page(cas... | false |
Other | Homebrew | brew | 1f963267b6bd415ce3024bb7860d5253ad8e0132.json | Update Rubocop style.
Another look at the current Rubocop rules and how they fit with our
existing and desired future style. Almost all of these changes were
automatic. Split some rules between formulae/brew where brew doesn't
have millions of cases that need fixed. | Library/.rubocop.yml | @@ -48,6 +48,12 @@ Style/AlignHash:
Style/AlignParameters:
Enabled: false
+Style/BarePercentLiterals:
+ EnforcedStyle: percent_q
+
+Style/BlockDelimiters:
+ EnforcedStyle: line_count_based
+
Style/CaseIndentation:
IndentWhenRelativeTo: end
@@ -76,9 +82,11 @@ Style/FileName:
Style/GuardClause:
Enabled:... | true |
Other | Homebrew | brew | 1f963267b6bd415ce3024bb7860d5253ad8e0132.json | Update Rubocop style.
Another look at the current Rubocop rules and how they fit with our
existing and desired future style. Almost all of these changes were
automatic. Split some rules between formulae/brew where brew doesn't
have millions of cases that need fixed. | Library/Homebrew/.rubocop.yml | @@ -9,93 +9,31 @@ AllCops:
- 'cask/**/*'
- '**/vendor/**/*'
+# so many of these in formulae but none in here
+Lint/AmbiguousRegexpLiteral:
+ Enabled: true
+
# `formula do` uses nested method definitions
Lint/NestedMethodDefinition:
Exclude:
- 'test/**/*'
+# so many of these in formulae but none... | true |
Other | Homebrew | brew | 1f963267b6bd415ce3024bb7860d5253ad8e0132.json | Update Rubocop style.
Another look at the current Rubocop rules and how they fit with our
existing and desired future style. Almost all of these changes were
automatic. Split some rules between formulae/brew where brew doesn't
have millions of cases that need fixed. | Library/Homebrew/cmd/missing.rb | @@ -20,7 +20,7 @@ def missing
Diagnostic.missing_deps(ff) do |name, missing|
print "#{name}: " if ff.size > 1
- puts (missing * " ").to_s
+ puts missing.join(" ")
end
end
end | true |
Other | Homebrew | brew | 1f963267b6bd415ce3024bb7860d5253ad8e0132.json | Update Rubocop style.
Another look at the current Rubocop rules and how they fit with our
existing and desired future style. Almost all of these changes were
automatic. Split some rules between formulae/brew where brew doesn't
have millions of cases that need fixed. | Library/Homebrew/cmd/style.rb | @@ -49,7 +49,7 @@ def check_style_impl(files, output_type, options = {})
fix = options[:fix]
Homebrew.install_gem_setup_path! "rubocop", "0.43.0"
- args = %W[
+ args = %w[
--force-exclusion
]
args << "--auto-correct" if fix | true |
Other | Homebrew | brew | 1f963267b6bd415ce3024bb7860d5253ad8e0132.json | Update Rubocop style.
Another look at the current Rubocop rules and how they fit with our
existing and desired future style. Almost all of these changes were
automatic. Split some rules between formulae/brew where brew doesn't
have millions of cases that need fixed. | Library/Homebrew/dev-cmd/audit.rb | @@ -137,7 +137,7 @@ class FormulaAuditor
attr_reader :formula, :text, :problems
- BUILD_TIME_DEPS = %W[
+ BUILD_TIME_DEPS = %w[
autoconf
automake
boost-build
@@ -449,9 +449,8 @@ def audit_options
end
return unless @new_formula
- unless formula.deprecated_options.empty?
- prob... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.