language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | Homebrew | brew | a3bffe70bcf33e6051140b1a93c9f48714605af6.json | Use docs.brew.sh links. | Library/Homebrew/utils/analytics.rb | @@ -35,7 +35,7 @@ def report(type, metadata = {})
end
# Send analytics. Don't send or store any personally identifiable information.
- # https://github.com/Homebrew/brew/blob/master/docs/Analytics.md
+ # http://docs.brew.sh/Analytics.html
# https://developers.google.com/analyt... | true |
Other | Homebrew | brew | a3bffe70bcf33e6051140b1a93c9f48714605af6.json | Use docs.brew.sh links. | Library/Homebrew/utils/analytics.sh | @@ -107,7 +107,7 @@ report-analytics-screenview-command() {
)
# Send analytics. Don't send or store any personally identifiable information.
- # https://github.com/Homebrew/brew/blob/master/docs/Analytics.md
+ # http://docs.brew.sh/Analytics.html
# https://developers.google.com/analytics/devguides/collecti... | true |
Other | Homebrew | brew | a3bffe70bcf33e6051140b1a93c9f48714605af6.json | Use docs.brew.sh links. | README.md | @@ -18,7 +18,7 @@ cd "$(brew --repo)" && git fetch && git reset --hard origin/master && brew updat
## Troubleshooting
First, please run `brew update` and `brew doctor`.
-Second, read the [Troubleshooting Checklist](https://github.com/Homebrew/brew/blob/master/docs/Troubleshooting.md#troubleshooting).
+Second, read ... | true |
Other | Homebrew | brew | a3bffe70bcf33e6051140b1a93c9f48714605af6.json | Use docs.brew.sh links. | docs/Formula-Cookbook.md | @@ -352,7 +352,7 @@ If you have already forked Homebrew on GitHub, then you can manually push (just
git push https://github.com/myname/homebrew-core/ <what-you-called-your-branch>
```
-Now, please [open a pull request](https://github.com/Homebrew/brew/blob/master/docs/How-To-Open-a-Homebrew-Pull-Request-(and-get-it... | true |
Other | Homebrew | brew | a3bffe70bcf33e6051140b1a93c9f48714605af6.json | Use docs.brew.sh links. | docs/Tips-N'-Tricks.md | @@ -3,8 +3,7 @@
## Installing previous versions of formulae
The supported method of installing specific versions of
-some formulae is to see if there is a versions formula like e.g. `gcc@6` available. If the version you’re looking for isn’t available, consider [opening a
-pull request](https://github.com/Homebrew/b... | true |
Other | Homebrew | brew | a3bffe70bcf33e6051140b1a93c9f48714605af6.json | Use docs.brew.sh links. | docs/brew.1.html | @@ -36,7 +36,7 @@ <h2 id="COMMANDS">COMMANDS</h2>
<dl>
<dt><code>analytics</code> [<code>state</code>]</dt><dd><p>Display anonymous user behaviour analytics state.
-Read more at <a href="https://git.io/brew-analytics" data-bare-link="true">https://git.io/brew-analytics</a>.</p></dd>
+Read more at <a href="http://do... | true |
Other | Homebrew | brew | a3bffe70bcf33e6051140b1a93c9f48714605af6.json | Use docs.brew.sh links. | manpages/brew.1 | @@ -45,7 +45,7 @@ Perform a substring search of formula names for \fItext\fR\. If \fItext\fR is su
.
.TP
\fBanalytics\fR [\fBstate\fR]
-Display anonymous user behaviour analytics state\. Read more at \fIhttps://git\.io/brew\-analytics\fR\.
+Display anonymous user behaviour analytics state\. Read more at \fIhttp://do... | true |
Other | Homebrew | brew | a175a1241efbec95f442257919fffe867bdf26cf.json | license: remove copyright ending year
See https://github.com/Homebrew/brew/pull/1771#issuecomment-270143292. | LICENSE.txt | @@ -1,6 +1,6 @@
BSD 2-Clause License
-Copyright (c) 2009-2016, Homebrew contributors
+Copyright (c) 2009-present, Homebrew contributors
All rights reserved.
Redistribution and use in source and binary forms, with or without | false |
Other | Homebrew | brew | bc0aa4e64ce4eaf53476aa448b71b711feb9939e.json | Add versions documentation. | docs/Formula-Cookbook.md | @@ -9,7 +9,7 @@ A formula is a package definition written in Ruby. It can be created with `brew
| **Keg** | The installation prefix of a **Formula** | `/usr/local/Cellar/foo/0.1` |
| **opt prefix** | A symlink to the active version of a **Keg** ... | true |
Other | Homebrew | brew | bc0aa4e64ce4eaf53476aa448b71b711feb9939e.json | Add versions documentation. | docs/Tips-N'-Tricks.md | @@ -2,8 +2,8 @@
## Installing previous versions of formulae
-The preferred and supported method of installing specific versions of
-formulae is to use formula like e.g. `gcc@6`. If the version you’re looking for isn’t available, consider [opening a
+The supported method of installing specific versions of
+some for... | true |
Other | Homebrew | brew | bc0aa4e64ce4eaf53476aa448b71b711feb9939e.json | Add versions documentation. | docs/Versions.md | @@ -0,0 +1,15 @@
+# Versions
+Now that [Homebrew/versions](https://github.com/homebrew/homebrew-versions) has been deprecated [Homebrew/core](https://github.com/homebrew/homebrew-core) supports multiple versions of formulae with a new naming format.
+
+In [Homebrew/versions](https://github.com/homebrew/homebrew-version... | true |
Other | Homebrew | brew | 294781cc9efb330af98e9dfa701a2b64d41bf819.json | cask depends_on arch: remove everything but 64-bit intel | Library/Homebrew/cask/lib/hbc/dsl/depends_on.rb | @@ -13,30 +13,9 @@ class DependsOn
].freeze
VALID_ARCHES = {
- intel: { type: :intel, bits: [32, 64] },
- ppc: { type: :ppc, bits: [32, 64] },
+ intel: { type: :intel, bits: 64 },
# specific
- i386: { type: :intel, bits: 32 },
x86_64: { ty... | true |
Other | Homebrew | brew | 294781cc9efb330af98e9dfa701a2b64d41bf819.json | cask depends_on arch: remove everything but 64-bit intel | Library/Homebrew/cask/test/cask/depends_on_test.rb | @@ -79,15 +79,6 @@
Hbc::Installer.new(arch_cask).install
end
end
-
- it "raises an exception when depends_on arch is not satisfied" do
- arch_cask = Hbc.load("with-depends-on-arch-failure")
- lambda {
- shutup do
- Hbc::Installer.new(arch_cask).install
- end
- ... | true |
Other | Homebrew | brew | 294781cc9efb330af98e9dfa701a2b64d41bf819.json | cask depends_on arch: remove everything but 64-bit intel | Library/Homebrew/cask/test/support/Casks/with-depends-on-arch-failure.rb | @@ -1,12 +0,0 @@
-test_cask 'with-depends-on-arch-failure' do
- version '1.2.3'
- sha256 '67cdb8a02803ef37fdbf7e0be205863172e41a561ca446cd84f0d7ab35a99d94'
-
- url "file://#{TEST_FIXTURE_DIR}/cask/caffeine.zip"
- homepage 'http://example.com/with-depends-on-arch-failure'
-
- # guarantee mismatched hardware
- depe... | true |
Other | Homebrew | brew | 294781cc9efb330af98e9dfa701a2b64d41bf819.json | cask depends_on arch: remove everything but 64-bit intel | Library/Homebrew/cask/test/support/Casks/with-depends-on-arch.rb | @@ -6,7 +6,7 @@
homepage 'http://example.com/with-depends-on-arch'
# covers all known hardware; always succeeds
- depends_on arch: [:ppc, :intel]
+ depends_on arch: :intel
app 'Caffeine.app'
end | true |
Other | Homebrew | brew | e1d7d44e5a13d16bc7773a7afb09c1a789878f5a.json | tests: optlink fake kegs in uninstall test | Library/Homebrew/test/uninstall_test.rb | @@ -9,7 +9,10 @@ def setup
depends_on "dependency"
end
- [@dependency, @dependent].each { |f| f.installed_prefix.mkpath }
+ [@dependency, @dependent].each do |f|
+ f.installed_prefix.mkpath
+ Keg.new(f.installed_prefix).optlink
+ end
tab = Tab.empty
tab.homebrew_version = "1... | false |
Other | Homebrew | brew | e4856143a6a43a306101abcbf0f2d71d00354a18.json | keg: check installed dependencies iff optlinked | Library/Homebrew/keg.rb | @@ -385,7 +385,7 @@ def to_formula
end
def installed_dependents
- return [] if !linked? && !to_formula.keg_only?
+ return [] unless optlinked?
tap = Tab.for_keg(self).source["tap"]
Keg.all.select do |keg|
tab = Tab.for_keg(keg) | true |
Other | Homebrew | brew | e4856143a6a43a306101abcbf0f2d71d00354a18.json | keg: check installed dependencies iff optlinked | Library/Homebrew/test/keg_test.rb | @@ -467,8 +467,8 @@ def test_fallback_for_old_versions
assert_equal [[@keg], ["bar"]], Keg.find_some_installed_dependents([@keg])
end
- def test_unlinked
- @keg.unlink
+ def test_nonoptlinked
+ @keg.remove_opt_record
dependencies [{ "full_name" => "foo", "version" => "1.0" }]
assert_empty @k... | true |
Other | Homebrew | brew | 8b30abe0600df5c9d3da5b4c31ca88a71a1c3e03.json | keg: handle dependencies of moved/renamed formulae
In #1497 I switched from Keg#to_formula for comparing kegs to formulae
to comparing the name and tap in the keg's tab to the name and tap of
the formula.
However, this fails to match if the name and tap of the formula have
changed since the keg was installed, so it's... | Library/Homebrew/keg.rb | @@ -126,7 +126,18 @@ def self.find_some_installed_dependents(kegs)
end
keg_names = kegs.map(&:name)
- kegs_by_source = kegs.group_by { |k| [k.name, Tab.for_keg(k).tap] }
+ kegs_by_source = kegs.group_by do |keg|
+ begin
+ # First, attempt to resolve the keg to a formula
+ # to get u... | true |
Other | Homebrew | brew | 8b30abe0600df5c9d3da5b4c31ca88a71a1c3e03.json | keg: handle dependencies of moved/renamed formulae
In #1497 I switched from Keg#to_formula for comparing kegs to formulae
to comparing the name and tap in the keg's tab to the name and tap of
the formula.
However, this fails to match if the name and tap of the formula have
changed since the keg was installed, so it's... | Library/Homebrew/test/keg_test.rb | @@ -373,6 +373,7 @@ def test_unknown_formula
t.source["tap"] = "some/tap"
t.source["path"] = nil
end
+
dependencies [{ "full_name" => "some/tap/foo", "version" => "1.0" }]
assert_equal [@dependent], @keg.installed_dependents
assert_equal [[@keg], ["bar 1.0"]], Keg.find_some_installed_d... | true |
Other | Homebrew | brew | 49310667b4e6327d8276752a74fe480c1d7fb135.json | Revert "uninstall: remove nil requireds/dependents"
This reverts commit d7e72899e6f24dca5e02a734d5a4e64e39fc680e. | Library/Homebrew/cmd/uninstall.rb | @@ -102,8 +102,8 @@ class DependentsMessage
attr_reader :reqs, :deps
def initialize(requireds, dependents)
- @reqs = requireds.compact
- @deps = dependents.compact
+ @reqs = requireds
+ @deps = dependents
end
protected | false |
Other | Homebrew | brew | 35ae78f43d45369f86b8c56c04ccca1119fdb1d1.json | formula_versions: handle uncommitted formulae.
Otherwise an uncommitted formula can trigger an invalid `brew audit`
result.
Fixes #1731. | Library/Homebrew/formula_versions.rb | @@ -15,6 +15,7 @@ def initialize(formula, options = {})
@repository = formula.tap.path
@entry_name = @path.relative_path_from(repository).to_s
@max_depth = options[:max_depth]
+ @current_formula = formula
end
def rev_list(branch)
@@ -64,25 +65,33 @@ def version_attributes_map(attributes, branc... | false |
Other | Homebrew | brew | 01e1f7d49e91b6f02037997ffb465b37d2426b80.json | keg: fix fallback dependencies with multiple kegs
Fixes #1524. | Library/Homebrew/keg.rb | @@ -105,7 +105,13 @@ def self.find_some_installed_dependents(kegs)
#
# This happens after the initial dependency check because it's sloooow.
remaining_formulae = Formula.installed.select do |f|
- f.installed_kegs.any? { |k| Tab.for_keg(k).runtime_dependencies.nil? }
+ installed_kegs = f.install... | true |
Other | Homebrew | brew | 01e1f7d49e91b6f02037997ffb465b37d2426b80.json | keg: fix fallback dependencies with multiple kegs
Fixes #1524. | Library/Homebrew/test/keg_test.rb | @@ -382,6 +382,13 @@ def test_missing_formula_dependency
assert_equal [[@keg], ["bar"]], Keg.find_some_installed_dependents([@keg])
end
+ def test_uninstalling_dependent_and_dependency
+ dependencies nil
+ Formula["bar"].class.depends_on "foo"
+ assert_empty @keg.installed_dependents
+ assert_nil... | true |
Other | Homebrew | brew | a69997cab03988f381894b08d4b82d25014e8fed.json | tests: include homebrew version in receipt fixture | Library/Homebrew/test/support/fixtures/receipt.json | @@ -1,4 +1,5 @@
{
+ "homebrew_version": "1.1.6",
"used_options": [
"--with-foo",
"--without-bar" | false |
Other | Homebrew | brew | c31f959ec1955999d4be4446914eaab2e715058a.json | Hide `update` from `brew cask help`. | Library/Homebrew/compat/hbc/cli/update.rb | @@ -11,8 +11,12 @@ def self.run(*_ignored)
exit result.exit_status
end
+ def self.visible
+ false
+ end
+
def self.help
- Formatter.warning("deprecated: use `brew update` instead")
+ "a synonym for 'brew update'"
end
end
end | false |
Other | Homebrew | brew | 0f8cb4ba277968fb24bf438468b37466075fd18a.json | Add option to disable methods on specific date. | Library/Homebrew/test/utils_test.rb | @@ -216,7 +216,7 @@ def test_odeprecated
e = assert_raises(MethodDeprecatedError) do
odeprecated("method", "replacement",
caller: ["#{HOMEBREW_LIBRARY}/Taps/homebrew/homebrew-core/"],
- die: true)
+ disable: true)
end
assert_match "method", e.message
assert_match "repla... | true |
Other | Homebrew | brew | 0f8cb4ba277968fb24bf438468b37466075fd18a.json | Add option to disable methods on specific date. | Library/Homebrew/utils.rb | @@ -11,6 +11,7 @@
require "utils/inreplace"
require "utils/popen"
require "utils/tty"
+require "time"
def ohai(title, *sput)
title = Tty.truncate(title) if $stdout.tty? && !ARGV.verbose?
@@ -44,24 +45,32 @@ def odie(error)
exit 1
end
-def odeprecated(method, replacement = nil, options = {})
- verb = if ... | true |
Other | Homebrew | brew | 59180ec370560d461d9fa44a3e510e9f1ea68375.json | audit: improve reliability of homepage audit.
- Don't run on Yosemite where the system Curl is too old for some modern
HTTPS homepages
- Try up to 3 times in case of transient failures. | Library/Homebrew/dev-cmd/audit.rb | @@ -569,9 +569,20 @@ def audit_homepage
end
return unless @online
- status_code, = curl_output "--connect-timeout", "15", "--output", "/dev/null", "--range", "0-0",
- "--write-out", "%{http_code}", homepage
- return if status_code.start_with? "20"
+
+ # The system Curl... | false |
Other | Homebrew | brew | 6f44dc41d5316e26a3ac533019199da502f430fc.json | development_tools: remove unused method. | Library/Homebrew/development_tools.rb | @@ -119,10 +119,6 @@ def clear_version_cache
@clang_version = @clang_build_version = nil
@non_apple_gcc_version = {}
end
-
- def tar_supports_xz?
- false
- end
end
end
| true |
Other | Homebrew | brew | 6f44dc41d5316e26a3ac533019199da502f430fc.json | development_tools: remove unused method. | Library/Homebrew/extend/os/mac/development_tools.rb | @@ -76,9 +76,5 @@ def default_compiler
end
end
end
-
- def tar_supports_xz?
- false
- end
end
end | true |
Other | Homebrew | brew | 3a27d8121970dab95f2d28db81189ddf9619c0f5.json | keg: fix dependents with unavailable formulae
Because of an accidental use of `=` instead of `==`, the source formula
check would be skipped when determining if a keg depended on another one
(so only the versions would be compared).
Fixed that comparison, and updated the corresponding test.
Glad I caught that! | Library/Homebrew/keg.rb | @@ -357,7 +357,7 @@ def to_formula
end
def installed_dependents
- my_tab = Tab.for_keg(self)
+ tap = Tab.for_keg(self).source["tap"]
Keg.all.select do |keg|
tab = Tab.for_keg(keg)
next if tab.runtime_dependencies.nil? # no dependency information saved.
@@ -368,7 +368,7 @@ def installed_... | true |
Other | Homebrew | brew | 3a27d8121970dab95f2d28db81189ddf9619c0f5.json | keg: fix dependents with unavailable formulae
Because of an accidental use of `=` instead of `==`, the source formula
check would be skipped when determining if a keg depended on another one
(so only the versions would be compared).
Fixed that comparison, and updated the corresponding test.
Glad I caught that! | Library/Homebrew/test/keg_test.rb | @@ -360,9 +360,11 @@ def dependencies(deps)
# from a file path or URL.
def test_unknown_formula
Formulary.unstub(:loader_for)
- alter_tab { |t| t.source["tap"] = "some/tap" }
- dependencies [{ "full_name" => "some/tap/bar", "version" => "1.0" }]
- alter_tab { |t| t.source["path"] = nil }
+ alter_... | true |
Other | Homebrew | brew | 3ebd7df62d0b05a8a010bec74793cc4e688a2fc8.json | bump-formula-pr: fix removal of old mirrors
Previously, old mirrors are only removed if the requested spec is
stable, and if the mirror lines only have two leading spaces. This leads
to stale mirror line(s) when the formula a stable block like
stable do
url "http://example.com/v1.0.tar.gz"
mirror "htt... | Library/Homebrew/dev-cmd/bump-formula-pr.rb | @@ -156,7 +156,9 @@ def bump_formula_pr
replacement_pairs << [/^ revision \d+\n(\n( head "))?/m, "\\2"]
end
- replacement_pairs << [/(^ mirror .*\n)?/, ""] if requested_spec == :stable
+ replacement_pairs += formula_spec.mirrors.map do |mirror|
+ [/ +mirror \"#{mirror}\"\n/m, ""]
+ end
... | false |
Other | Homebrew | brew | cc09bb14c16c8e4f6b360f30074522c2ee25167b.json | brew create: add meson support
meson is quickly gaining popularity as build system, in combination with
ninja. Several Gnome projects for example are currently transitioning
from autotools to meson, mostly because it allows for Visual Studio
builds, which is impossible to accomplish with autotools.
In order to facili... | Library/Homebrew/dev-cmd/create.rb | @@ -1,4 +1,4 @@
-#: * `create` <URL> [`--autotools`|`--cmake`] [`--no-fetch`] [`--set-name` <name>] [`--set-version` <version>] [`--tap` <user>`/`<repo>]:
+#: * `create` <URL> [`--autotools`|`--cmake`|`--meson`] [`--no-fetch`] [`--set-name` <name>] [`--set-version` <version>] [`--tap` <user>`/`<repo>]:
#: Generat... | true |
Other | Homebrew | brew | cc09bb14c16c8e4f6b360f30074522c2ee25167b.json | brew create: add meson support
meson is quickly gaining popularity as build system, in combination with
ninja. Several Gnome projects for example are currently transitioning
from autotools to meson, mostly because it allows for Visual Studio
builds, which is impossible to accomplish with autotools.
In order to facili... | docs/brew.1.html | @@ -504,15 +504,16 @@ <h2 id="DEVELOPER-COMMANDS">DEVELOPER COMMANDS</h2>
url-and-sha256 style specification into a tag-and-revision style
specification, nor vice versa. It must use whichever style specification
the preexisting formula already uses.</p></dd>
-<dt><code>create</code> <var>URL</var> [<code>--autotools... | true |
Other | Homebrew | brew | cc09bb14c16c8e4f6b360f30074522c2ee25167b.json | brew create: add meson support
meson is quickly gaining popularity as build system, in combination with
ninja. Several Gnome projects for example are currently transitioning
from autotools to meson, mostly because it allows for Visual Studio
builds, which is impossible to accomplish with autotools.
In order to facili... | manpages/brew-cask.1 | @@ -1,7 +1,7 @@
.\" generated with Ronn/v0.7.3
.\" http://github.com/rtomayko/ronn/tree/0.7.3
.
-.TH "BREW\-CASK" "1" "November 2016" "Homebrew" "brew-cask"
+.TH "BREW\-CASK" "1" "December 2016" "Homebrew" "brew-cask"
.
.SH "NAME"
\fBbrew\-cask\fR \- a friendly binary installer for macOS | true |
Other | Homebrew | brew | cc09bb14c16c8e4f6b360f30074522c2ee25167b.json | brew create: add meson support
meson is quickly gaining popularity as build system, in combination with
ninja. Several Gnome projects for example are currently transitioning
from autotools to meson, mostly because it allows for Visual Studio
builds, which is impossible to accomplish with autotools.
In order to facili... | manpages/brew.1 | @@ -1,7 +1,7 @@
.\" generated with Ronn/v0.7.3
.\" http://github.com/rtomayko/ronn/tree/0.7.3
.
-.TH "BREW" "1" "November 2016" "Homebrew" "brew"
+.TH "BREW" "1" "December 2016" "Homebrew" "brew"
.
.SH "NAME"
\fBbrew\fR \- The missing package manager for macOS
@@ -695,14 +695,14 @@ If \fB\-\-message=\fR\fImessage... | true |
Other | Homebrew | brew | 41a248786f0310fa27d2df65d09b58d6ff12c241.json | audit: handle a nil revision map. | Library/Homebrew/dev-cmd/audit.rb | @@ -706,7 +706,7 @@ def audit_revision_and_version_scheme
return if formula.revision.zero?
if formula.stable
revision_map = attributes_map[:revision][:stable]
- stable_revisions = revision_map[formula.stable.version]
+ stable_revisions = revision_map[formula.stable.version] if revision_map
... | false |
Other | Homebrew | brew | d21f6954b647948b35da41ca8d02e80880ede2b6.json | update-reset: add new command.
Add new `brew update-reset` command to provide a helpful troubleshooting
fallback to fetch and reset all repositories. This could have lived in
`brew update` but it makes sense to avoid the complexity of sharing
logic between these scripts and keeping this one simpler. | Library/Homebrew/cmd/update-reset.sh | @@ -0,0 +1,43 @@
+#: @hide_from_man_page
+#: * `update-reset`:
+#: Fetches and resets Homebrew and all tap repositories using `git`(1) to
+#: their latest `origin/master`.
+
+homebrew-update-reset() {
+ local DIR
+
+ for option in "$@"
+ do
+ case "$option" in
+ -\?|-h|--help|--usage) brew he... | false |
Other | Homebrew | brew | ebb659af7da12771efe134e1f9386324423f4246.json | Add Kaby Lake to Linux hardware list
Note that no Mac hardware using a Kaby Lake processor has been released
yet, so do not add it to the equivalent list for macOS. | Library/Homebrew/extend/os/linux/hardware/cpu.rb | @@ -47,6 +47,8 @@ def family
:haswell
when 0x3d, 0x47, 0x4f, 0x56
:broadwell
+ when 0x8e
+ :kabylake
else
cpu_family_model
end | true |
Other | Homebrew | brew | ebb659af7da12771efe134e1f9386324423f4246.json | Add Kaby Lake to Linux hardware list
Note that no Mac hardware using a Kaby Lake processor has been released
yet, so do not add it to the equivalent list for macOS. | Library/Homebrew/test/hardware_test.rb | @@ -8,7 +8,7 @@ def test_hardware_cpu_type
if Hardware::CPU.intel?
def test_hardware_intel_family
- families = [:core, :core2, :penryn, :nehalem, :arrandale, :sandybridge, :ivybridge, :haswell, :broadwell, :skylake, :dunno]
+ families = [:core, :core2, :penryn, :nehalem, :arrandale, :sandybridge, :i... | true |
Other | Homebrew | brew | 3088faaf9c1bea9fdbf923a05a6aea984d32fedd.json | Fix error message when cask fails to install. | Library/Homebrew/cask/lib/hbc/installer.rb | @@ -146,14 +146,13 @@ def install_artifacts
end
rescue StandardError => e
begin
- ofail e.message
already_installed_artifacts.each do |artifact|
odebug "Reverting installation of artifact of class #{artifact}"
artifact.new(@cask, options).uninstall_phase
... | false |
Other | Homebrew | brew | ab060c9d52f4edca8551aa44315c816fe1381fd4.json | super/cc: loosen cellar formula regex.
Match HOMEBREW_TAP_FORMULA_REGEX to avoid skipping valid cellar regexes. | Library/Homebrew/shims/super/cc | @@ -31,7 +31,7 @@ class Cmd
@deps = Set.new(ENV.fetch("HOMEBREW_DEPENDENCIES") { "" }.split(","))
@formula_prefix = ENV["HOMEBREW_FORMULA_PREFIX"]
# matches opt or cellar prefix and formula name
- @keg_regex = %r[(#{Regexp.escape(opt)}|#{Regexp.escape(cellar)})/([\w\-_\+]+)]
+ @keg_regex = %r[(#{Re... | false |
Other | Homebrew | brew | 478e4f112c5482a0424c0a27c6d9d10fea3d2c07.json | formulary: call tap not formula
Fixes #1668 | Library/Homebrew/formulary.rb | @@ -211,7 +211,7 @@ def get_formula(spec, alias_path: nil)
def load_file
super
rescue MethodDeprecatedError => e
- e.issues_url = formula.tap.issues_url || formula.tap.to_s
+ e.issues_url = tap.issues_url || tap.to_s
raise
end
end | false |
Other | Homebrew | brew | f7f15673a8e8ecb6817435c7bd51c7e8077220e4.json | Fix dependency option handling.
- formula_installer: only recompute dependencies when necessary i.e.
when a bottle pour fails.
- formula_installer: re-add accidentally remove dependency options
- dependency: missing options are only those that actually exist on a
formula | Library/Homebrew/dependency.rb | @@ -43,8 +43,12 @@ def satisfied?(inherited_options)
end
def missing_options(inherited_options)
- required = options | inherited_options
- required - Tab.for_formula(to_formula).used_options
+ formula = to_formula
+ required = options
+ required |= inherited_options
+ required &= formula.optio... | true |
Other | Homebrew | brew | f7f15673a8e8ecb6817435c7bd51c7e8077220e4.json | Fix dependency option handling.
- formula_installer: only recompute dependencies when necessary i.e.
when a bottle pour fails.
- formula_installer: re-add accidentally remove dependency options
- dependency: missing options are only those that actually exist on a
formula | Library/Homebrew/formula_installer.rb | @@ -236,8 +236,7 @@ def install
@@attempted << formula
- pour_bottle = pour_bottle?(warn: true)
- if pour_bottle
+ if pour_bottle?(warn: true)
begin
pour
rescue Exception => e
@@ -251,18 +250,17 @@ def install
onoe e.message
opoo "Bottle installation failed: bu... | true |
Other | Homebrew | brew | 25242fe4e9649ecc5033510c408e6db5b6fe8bcc.json | Minimize line length | docs/FAQ.md | @@ -96,7 +96,8 @@ will use a bottled version of $FORMULA, but
`brew install $FORMULA --enable-bar` will trigger a source build.
* The `--build-from-source` option is invoked.
* The environment variable `HOMEBREW_BUILD_FROM_SOURCE` is set.
-* The machine is not running a supported version of macOS as all bottled buil... | false |
Other | Homebrew | brew | 417f27f40f112bdc228b9f2ab27fef8cea7c7d97.json | bump-formula-pr: use correct version in download
When a --version is specified, use this specified version in the name of
the downloaded file rather than the default that is parsed from the URL.
For instance,
brew bump-formula-pr --devel \
--url=http://www.zsh.org/pub/development/zsh-5.2-test-2.tar.gz \
--v... | Library/Homebrew/dev-cmd/bump-formula-pr.rb | @@ -134,6 +134,7 @@ def bump_formula_pr
rsrc = Resource.new { @url = rsrc_url }
rsrc.download_strategy = CurlDownloadStrategy
rsrc.owner = Resource.new(formula.name)
+ rsrc.version = forced_version if forced_version
rsrc_path = rsrc.fetch
if Utils.popen_read("/usr/bin/tar", "-tf"... | false |
Other | Homebrew | brew | 59f926cfd3da207d53e5ebc168fbff54a36edb6a.json | boneyard-formula-pr: checkout last branch when done
Make its behavior more consistent with that of bump-formula-pr. | Library/Homebrew/dev-cmd/boneyard-formula-pr.rb | @@ -88,6 +88,8 @@ def boneyard_formula_pr
ohai "git push $HUB_REMOTE #{branch}:#{branch}"
ohai "hub pull-request -m $'#{formula.name}: migrate to boneyard\\n\\nCreated with `brew boneyard-formula-pr`#{reason}.'"
end
+
+ ohai "git checkout -"
else
cd formula.tap.path
safe... | false |
Other | Homebrew | brew | 0fe532c242d73c73eeb2b87a15a46ec9602685df.json | boneyard-formula-pr: use ohai to print messages
Make its behavior more consistent with that of bump-formula-pr. | Library/Homebrew/dev-cmd/boneyard-formula-pr.rb | @@ -35,18 +35,18 @@ def boneyard_formula_pr
boneyard_tap = Tap.fetch("homebrew", "boneyard")
tap_migrations_path = formula.tap.path/"tap_migrations.json"
if ARGV.dry_run?
- puts "brew update"
- puts "brew tap #{boneyard_tap.name}"
- puts "cd #{formula.tap.path}"
+ ohai "brew update"
+... | false |
Other | Homebrew | brew | 006f25d8cfa5ffa9e4c531d49dcc99fe312edff6.json | Use Homebrew to detect if X11 is installed. | Library/Homebrew/cask/lib/hbc/installer.rb | @@ -179,7 +179,7 @@ def arch_dependencies
def x11_dependencies
return unless @cask.depends_on.x11
- raise CaskX11DependencyError, @cask.token if Hbc.x11_libpng.select(&:exist?).empty?
+ raise CaskX11DependencyError, @cask.token unless MacOS::X11.installed?
end
def formula_dependencie... | true |
Other | Homebrew | brew | 006f25d8cfa5ffa9e4c531d49dcc99fe312edff6.json | Use Homebrew to detect if X11 is installed. | Library/Homebrew/cask/lib/hbc/locations.rb | @@ -171,14 +171,6 @@ def tcc_db
def pre_mavericks_accessibility_dotfile
@pre_mavericks_accessibility_dotfile ||= Pathname.new("/private/var/db/.AccessibilityAPIEnabled")
end
-
- def x11_executable
- @x11_executable ||= Pathname.new("/usr/X11/bin/X")
- end
-
- def x11_libpng
... | true |
Other | Homebrew | brew | 006f25d8cfa5ffa9e4c531d49dcc99fe312edff6.json | Use Homebrew to detect if X11 is installed. | Library/Homebrew/cask/test/cask/depends_on_test.rb | @@ -93,14 +93,15 @@
describe "depends_on x11" do
it "succeeds when depends_on x11 is satisfied" do
x11_cask = Hbc.load("with-depends-on-x11")
+ MacOS::X11.stubs(:installed?).returns(true)
shutup do
Hbc::Installer.new(x11_cask).install
end
end
it "raises an exceptio... | true |
Other | Homebrew | brew | 1995f653086ec0b4ab56618105c5678331949106.json | Add a method for installing fish function files
Fish shell allows third-party software vendors to put their own function files in a directory for their software.
For brew installed Fish shell, this is /usr/local/share/fish/vendor_functions.d | Library/Homebrew/caveats.rb | @@ -19,6 +19,7 @@ def caveats
caveats << bash_completion_caveats
caveats << zsh_completion_caveats
caveats << fish_completion_caveats
+ caveats << fish_function_caveats
caveats << plist_caveats
caveats << python_caveats
caveats << app_caveats
@@ -99,6 +100,17 @@ def fish_completion_cave... | true |
Other | Homebrew | brew | 1995f653086ec0b4ab56618105c5678331949106.json | Add a method for installing fish function files
Fish shell allows third-party software vendors to put their own function files in a directory for their software.
For brew installed Fish shell, this is /usr/local/share/fish/vendor_functions.d | Library/Homebrew/formula.rb | @@ -778,6 +778,14 @@ def var
HOMEBREW_PREFIX+"var"
end
+ # The directory where the formula's fish function files should be
+ # installed.
+ # This is symlinked into `HOMEBREW_PREFIX` after installation or with
+ # `brew link` for formulae that are not keg-only.
+ def fish_function
+ share+"fish/vendor... | true |
Other | Homebrew | brew | 1995f653086ec0b4ab56618105c5678331949106.json | Add a method for installing fish function files
Fish shell allows third-party software vendors to put their own function files in a directory for their software.
For brew installed Fish shell, this is /usr/local/share/fish/vendor_functions.d | Library/Homebrew/keg.rb | @@ -303,6 +303,11 @@ def completion_installed?(shell)
dir && dir.directory? && !dir.children.empty?
end
+ def fish_functions_installed?
+ dir = path.join("share", "fish", "vendor_functions.d")
+ dir && dir.directory? && !dir.children.empty?
+ end
+
def plist_installed?
!Dir["#{path}/*.plist"].... | true |
Other | Homebrew | brew | dc8189833165ce263ce323a1c8de5dfd44597e3b.json | travis: use Xcode 8.1 on Sierra.
For code coverage from `brew test-bot`. | .travis.yml | @@ -3,7 +3,7 @@ language: ruby
matrix:
include:
- os: osx
- osx_image: xcode8.0
+ osx_image: xcode8.1
rvm: system
- os: linux
rvm: 2.0.0
@@ -13,7 +13,7 @@ before_install:
- if [ "${TRAVIS_OS_NAME}" = "osx" ]; then
HOMEBREW_REPOSITORY="$(brew --repo)";
sudo rm -rf "... | true |
Other | Homebrew | brew | dc8189833165ce263ce323a1c8de5dfd44597e3b.json | travis: use Xcode 8.1 on Sierra.
For code coverage from `brew test-bot`. | Library/Homebrew/cask/cmd/brew-cask-tests.rb | @@ -24,7 +24,11 @@ def run_tests(executable, files, args = [])
rspec = ARGV.flag?("--rspec") || !ARGV.flag?("--minitest")
minitest = ARGV.flag?("--minitest") || !ARGV.flag?("--rspec")
- ENV["HOMEBREW_TESTS_COVERAGE"] = "1" if ARGV.flag?("--coverage")
+ p [:coverage, ARGV.flag?("--coverage"), ENV["CI"], ENV["T... | true |
Other | Homebrew | brew | 3f6d31dee1ab2ef84185899caca1011cb0b54345.json | bash_test: handle race condition.
Other tests may delete Bash files (e.g. `shcmd.sh`) while tests are
ongoing so ensure this doesn't cause a test failure. | Library/Homebrew/test/bash_test.rb | @@ -2,6 +2,7 @@
class BashTests < Homebrew::TestCase
def assert_valid_bash_syntax(file)
+ return unless file.exist?
output = Utils.popen_read("/bin/bash -n #{file} 2>&1")
assert $?.success?, output
end | false |
Other | Homebrew | brew | a24a919a40f09930c5ef9f2fe811d16e83fa963a.json | install_test: add HEAD tests | Library/Homebrew/test/install_test.rb | @@ -72,6 +72,50 @@ def test_install_keg_only_outdated
cmd("install", "testball1", "--force")
end
+ def test_install_head_installed
+ initial_env = ENV.to_hash
+ %w[AUTHOR COMMITTER].each do |role|
+ ENV["GIT_#{role}_NAME"] = "brew tests"
+ ENV["GIT_#{role}_EMAIL"] = "brew-tests@localhost"
+... | false |
Other | Homebrew | brew | 52526c962b235e16da03415dd78cf911afcf8106.json | formula: add new methods
* `Formula#linked?` returns true if formula linked
* `Formula#optlinked?` returns true if formula linked to opt
formula installed to the Cellar
* `Formula#prefix_linked?` returns true if linked keg points to the prefix
passed as an argument
* `Formula#linked_version` to get linked version ... | Library/Homebrew/formula.rb | @@ -553,6 +553,28 @@ def prefix(v = pkg_version)
Pathname.new("#{HOMEBREW_CELLAR}/#{name}/#{v}")
end
+ # Is the formula linked?
+ def linked?
+ linked_keg.symlink?
+ end
+
+ # Is the formula linked to opt?
+ def optlinked?
+ opt_prefix.symlink?
+ end
+
+ # Is formula's linked keg points to the pr... | false |
Other | Homebrew | brew | bff8e8440e965365360547c585dd10c29cc2bf81.json | update.sh: Use full path to pkill
Fixes #1600. | Library/Homebrew/cmd/update.sh | @@ -417,7 +417,7 @@ EOS
safe_cd "$HOMEBREW_REPOSITORY"
# kill all of subprocess on interrupt
- trap '{ pkill -P $$; wait; exit 130; }' SIGINT
+ trap '{ /usr/bin/pkill -P $$; wait; exit 130; }' SIGINT
local update_failed_file="$HOMEBREW_REPOSITORY/.git/UPDATE_FAILED"
rm -f "$update_failed_file" | false |
Other | Homebrew | brew | 8f82e89d0b26108e32a10b5d95b67e5e21ff0df6.json | README: update license name. | README.md | @@ -45,7 +45,7 @@ Homebrew's current maintainers are [Misty De Meo](https://github.com/mistydemeo)
Former maintainers with significant contributions include [Dominyk Tiller](https://github.com/DomT4), [Brett Koonce](https://github.com/asparagui), [Jack Nagel](https://github.com/jacknagel), [Adam Vandenberg](https://gi... | false |
Other | Homebrew | brew | eb20f594a2729254fddd53b56b5d769d7e105801.json | ISSUE_TEMPLATE: point people to the right repo. | .github/ISSUE_TEMPLATE.md | @@ -5,6 +5,7 @@ If Homebrew was updated on Aug 10-11th 2016 and `brew update` always says `Alrea
- [ ] Ran `brew update` and retried your prior step?
- [ ] Ran `brew doctor`, fixed as many issues as possible and retried your prior step?
- [ ] If you're seeing permission errors tried running `sudo chown -R $(whoami) ... | false |
Other | Homebrew | brew | 726045b2f4d04a0896383975d63da0d269bc8f22.json | rubocop: exclude more files.
We never want to check these for any e.g. taps that use them. | Library/.rubocop.yml | @@ -1,7 +1,10 @@
AllCops:
TargetRubyVersion: 2.0
Exclude:
+ - '**/Rakefile'
+ - '**/.*'
- '**/Casks/**/*'
+ - '**/vendor/**/*'
Metrics/AbcSize:
Enabled: false | false |
Other | Homebrew | brew | 282c0a30b61edc46c22b0b1d50ea59d275b64a63.json | Fix macOS version comparison | Library/Homebrew/os/mac/xcode.rb | @@ -256,7 +256,7 @@ def detect_version
return MacOS::Xcode.version if MacOS::Xcode.installed? && Xcode::Version.new(MacOS::Xcode.version) < "3.0"
[MAVERICKS_PKG_ID, MAVERICKS_NEW_PKG_ID, STANDALONE_PKG_ID, FROM_XCODE_PKG_ID].find do |id|
- if Xcode::Version.new(MacOS.version) >= :mavericks.... | false |
Other | Homebrew | brew | e330047ff9881eee9cbad8828ed1ef2f16b3050e.json | diagnostic: silence a Jenkins doctor warning.
Allow our Jenkins CI testing for Homebrew/brew to live outside of
`/usr/local` without complaint (as it's not using any binary packages
anyway). | Library/Homebrew/diagnostic.rb | @@ -407,6 +407,12 @@ def check_access_cellar
def check_homebrew_prefix
return if HOMEBREW_PREFIX.to_s == "/usr/local"
+ # Allow our Jenkins CI tests to live outside of /usr/local.
+ if ENV["JENKINS_HOME"] &&
+ ENV["GIT_URL"].to_s.start_with?("https://github.com/Homebrew/brew")
... | true |
Other | Homebrew | brew | e330047ff9881eee9cbad8828ed1ef2f16b3050e.json | diagnostic: silence a Jenkins doctor warning.
Allow our Jenkins CI testing for Homebrew/brew to live outside of
`/usr/local` without complaint (as it's not using any binary packages
anyway). | Library/Homebrew/test/diagnostic_test.rb | @@ -84,6 +84,7 @@ def test_check_access_cellar
end
def test_check_homebrew_prefix
+ ENV.delete("JENKINS_HOME")
# the integration tests are run in a special prefix
assert_match "Your Homebrew's prefix is not /usr/local.",
@checks.check_homebrew_prefix | true |
Other | Homebrew | brew | d41e2ea5e8714d80948033c04165137f0d46e9ac.json | update-report: allow skipping analytics message.
This is used by the install script so it can simplify it's logic and
make the analytics messaging more prominent. | Library/Homebrew/cmd/update-report.rb | @@ -26,7 +26,7 @@ def update_report
analytics_disabled = \
Utils.popen_read("git", "config", "--local", "--get", "homebrew.analyticsdisabled").chuzzle
if analytics_message_displayed != "true" && analytics_disabled != "true" &&
- !ENV["HOMEBREW_NO_ANALYTICS"]
+ !ENV["HOMEBREW_NO_AN... | false |
Other | Homebrew | brew | 2b34e67af7a9481595dd3fd78ed39469236e9d03.json | Change my site address
I no longer maintain my former site so it's better to link to my GitHub account. | docs/Kickstarter-Supporters.md | @@ -378,7 +378,7 @@ These wonderful people supported our Kickstarter by giving us £10 or more:
* [Andrew Brown](http://pvalu.es)
* [Bethany Sumner](http://www.bethanysumner.com/)
* [Orta](http://orta.io)
-* [Michał Gołębiowski](https://mgol.eu)
+* [Michał Gołębiowski](https://github.com/mgol)
* [Adam C. Foltzer](ht... | false |
Other | Homebrew | brew | 227975110317b144988b0c5656b338292462f863.json | Fix broken link | Library/Homebrew/formula.rb | @@ -26,7 +26,7 @@
# @see SharedEnvExtension
# @see FileUtils
# @see Pathname
-# @see http://www.rubydoc.info/github/Homebrew/brew/file/docs/Formula-Cookbook.md Formula Cookbook
+# @see https://github.com/Homebrew/brew/blob/master/docs/Formula-Cookbook.md Formula Cookbook
# @see https://github.com/styleguide/ruby Ru... | false |
Other | Homebrew | brew | 0271e76f08f122b4b6dde90f7e49066696072953.json | README: add Patreon badge. | README.md | @@ -51,16 +51,8 @@ Documentation is under the [Creative Commons Attribution license](https://creati
## Donations
Homebrew is a non-profit project run entirely by unpaid volunteers. We need your funds to pay for software, hardware and hosting around continuous integration and future improvements to the project. Every ... | false |
Other | Homebrew | brew | 1980af52deb5629c9f605017c6261a94f9e2b3e7.json | audit: allow deprecated options on new @ formulae.
As these may be migrations from another tap where we want to migrate
options across correctly. | Library/Homebrew/dev-cmd/audit.rb | @@ -461,6 +461,7 @@ def audit_options
return unless @new_formula
return if formula.deprecated_options.empty?
+ return if formula.name.include?("@")
problem "New formulae should not use `deprecated_option`."
end
| false |
Other | Homebrew | brew | 00b18c3587cb445c5b1db43d43968f5cebf0d67f.json | osxfuse_requirement: add library and include paths
In the installation whose prefix is other than /usr/local,
osxfuse library and include path must explicitly be specified during build.
Although brew's pkg-config is configured to prepend appropriates paths,
the prepended paths (/usr/local) supercede the original HOMEB... | Library/Homebrew/requirements/osxfuse_requirement.rb | @@ -14,6 +14,11 @@ def self.binary_osxfuse_installed?
env do
ENV.append_path "PKG_CONFIG_PATH", HOMEBREW_LIBRARY/"Homebrew/os/mac/pkgconfig/fuse"
+
+ unless HOMEBREW_PREFIX.to_s == "/usr/local"
+ ENV.append_path "HOMEBREW_LIBRARY_PATHS", "/usr/local/lib"
+ ENV.append_path "HOMEBREW_INCLUDE_PATHS"... | false |
Other | Homebrew | brew | c1688be78035b5b0ec7ccf1dbae30c5c93c4ee58.json | version/null: add inspect method.
This makes it easier to identify null versions when inspecting them. | Library/Homebrew/version/null.rb | @@ -34,5 +34,9 @@ def to_s
""
end
alias_method :to_str, :to_s
+
+ def inspect
+ "#<Version::NULL>".freeze
+ end
end.new
end | false |
Other | Homebrew | brew | 4a9601ab82c1f8093d8d3643bed8b2532f7c4890.json | audit: check formula name against blacklisted names. | Library/Homebrew/dev-cmd/audit.rb | @@ -35,6 +35,7 @@
require "cmd/search"
require "cmd/style"
require "date"
+require "blacklist"
module Homebrew
module_function
@@ -310,6 +311,10 @@ def audit_formula_name
name = formula.name
full_name = formula.full_name
+ if blacklisted?(name)
+ problem "'#{name}' is blacklisted."
+ end... | false |
Other | Homebrew | brew | 28072021031836937a01e9fd995b03995fe49443.json | cask: use Tempfile and some style fixes | Library/Homebrew/cask/lib/hbc/artifact/pkg.rb | @@ -55,19 +55,16 @@ def run_installer(pkg_description)
args << "-verboseR" if Hbc.verbose
args << "-allowUntrusted" if pkg_install_opts :allow_untrusted
if pkg_install_opts :choices
- args << "-applyChoiceChangesXML"
- args << choices_xml
+ choices_file = choices_xm... | true |
Other | Homebrew | brew | 28072021031836937a01e9fd995b03995fe49443.json | cask: use Tempfile and some style fixes | Library/Homebrew/cask/test/cask/artifact/pkg_test.rb | @@ -40,31 +40,32 @@
end
it "passes the choice changes xml to the system installer" do
- pkg = Hbc::Artifact::Pkg.new(@cask,
- command: Hbc::FakeSystemCommand)
-
- Hbc::FakeSystemCommand.expects_command(["/usr/bin/sudo", "-E", "--", "/usr/sbin/installer", "-pkg", @... | true |
Other | Homebrew | brew | f4a3bc100b4b98a3d06222c15934abb36bf16594.json | cask: add the choices option to pkg stanza
installer command accepts -applyChoiceChangesXML option to change
customize options on the GUI installer from the commandline.
(`man installer` for more detailed information)
The introduced option `choice` enables the choice changes to be supplied
via pkg stanza without tric... | Library/Homebrew/cask/lib/hbc/artifact/pkg.rb | @@ -2,6 +2,8 @@
require "hbc/utils/hash_validator"
+require "vendor/plist/plist"
+
module Hbc
module Artifact
class Pkg < Base
@@ -16,7 +18,7 @@ def load_pkg_description(pkg_description)
@pkg_install_opts = pkg_description.shift
begin
if @pkg_install_opts.respond_to?(:keys)
- ... | true |
Other | Homebrew | brew | f4a3bc100b4b98a3d06222c15934abb36bf16594.json | cask: add the choices option to pkg stanza
installer command accepts -applyChoiceChangesXML option to change
customize options on the GUI installer from the commandline.
(`man installer` for more detailed information)
The introduced option `choice` enables the choice changes to be supplied
via pkg stanza without tric... | Library/Homebrew/cask/test/cask/artifact/pkg_test.rb | @@ -30,4 +30,41 @@
end
end
end
+
+ describe "choices" do
+ before do
+ @cask = Hbc.load("with-choices")
+ shutup do
+ TestHelper.install_without_artifacts(@cask)
+ end
+ end
+
+ it "passes the choice changes xml to the system installer" do
+ pkg = Hbc::Artifact::Pkg.n... | true |
Other | Homebrew | brew | f4a3bc100b4b98a3d06222c15934abb36bf16594.json | cask: add the choices option to pkg stanza
installer command accepts -applyChoiceChangesXML option to change
customize options on the GUI installer from the commandline.
(`man installer` for more detailed information)
The introduced option `choice` enables the choice changes to be supplied
via pkg stanza without tric... | Library/Homebrew/cask/test/support/Casks/with-choices.rb | @@ -0,0 +1,16 @@
+test_cask 'with-choices' do
+ version '1.2.3'
+ sha256 '8c62a2b791cf5f0da6066a0a4b6e85f62949cd60975da062df44adf887f4370b'
+
+ url "file://#{TEST_FIXTURE_DIR}/cask/MyFancyPkg.zip"
+ homepage 'http://example.com/fancy-pkg'
+
+ pkg 'MyFancyPkg/Fancy.pkg',
+ choices: [
+ {
+ ... | true |
Other | Homebrew | brew | e9815bf2bd2950b5450f0c3ed3bb7eadd3b4cbb3.json | install: add tests with custom requirements | Library/Homebrew/test/install_test.rb | @@ -27,4 +27,27 @@ def test_install_with_invalid_option
assert_match "testball1: this formula has no --with-fo option so it will be ignored!",
cmd("install", "testball1", "--with-fo")
end
+
+ def test_install_with_nonfatal_requirement
+ setup_test_formula "testball1", <<-EOS.undent
+ class NonFa... | false |
Other | Homebrew | brew | 39a0fec95d884ed6b6b620ff6fcb3d16fc23ff9f.json | uninstall: ignore deprecations when uninstalling.
Handle `MethodDeprecatedError` because we want people to be able to
uninstall regardless of the content of their formula. | Library/Homebrew/cmd/uninstall.rb | @@ -81,6 +81,9 @@ def handle_unsatisfied_dependents(kegs_by_rack)
all_kegs = kegs_by_rack.values.flatten(1)
check_for_dependents all_kegs
+ rescue MethodDeprecatedError
+ # Silently ignore deprecations when uninstalling.
+ nil
end
def check_for_dependents(kegs) | false |
Other | Homebrew | brew | 4278ec38e49285fe4ca4cb71878eef738154276c.json | utils/json: Replace OkJson with Ruby's core JSON.
Removes OkJson from vendor/, as Ruby has included its own JSON
parser in corelib since 1.9.x and Homebrew is now guaranteed to be
running on 2.x+. | Library/Homebrew/utils/json.rb | @@ -1,4 +1,4 @@
-require "vendor/okjson"
+require "json"
module Utils
module JSON
@@ -7,13 +7,13 @@ module JSON
Error = Class.new(StandardError)
def load(str)
- Vendor::OkJson.decode(str)
- rescue Vendor::OkJson::Error => e
+ ::JSON.load(str)
+ rescue ::JSON::ParserError => e
ra... | true |
Other | Homebrew | brew | 4278ec38e49285fe4ca4cb71878eef738154276c.json | utils/json: Replace OkJson with Ruby's core JSON.
Removes OkJson from vendor/, as Ruby has included its own JSON
parser in corelib since 1.9.x and Homebrew is now guaranteed to be
running on 2.x+. | Library/Homebrew/vendor/README.md | @@ -1,36 +1,12 @@
Vendored Dependencies
=====================
-* [okjson](https://github.com/kr/okjson), version 43
-
* [plist](https://github.com/bleything/plist), version 3.1.0
* [ruby-macho](https://github.com/Homebrew/ruby-macho), version 0.2.6
## Licenses:
-### okjson
-
-> Copyright 2011, 2012 Keith R... | true |
Other | Homebrew | brew | 4278ec38e49285fe4ca4cb71878eef738154276c.json | utils/json: Replace OkJson with Ruby's core JSON.
Removes OkJson from vendor/, as Ruby has included its own JSON
parser in corelib since 1.9.x and Homebrew is now guaranteed to be
running on 2.x+. | Library/Homebrew/vendor/okjson.rb | @@ -1,602 +0,0 @@
-# encoding: UTF-8
-#
-# Copyright 2011, 2012 Keith Rarick
-#
-# Permission is hereby granted, free of charge, to any person obtaining a copy
-# of this software and associated documentation files (the "Software"), to deal
-# in the Software without restriction, including without limitation the rights... | true |
Other | Homebrew | brew | 0a7307de6412ddc566cdcb5ab343a9bb16bb2b88.json | tests: ignore test files in test/vendor/bundle | Library/Homebrew/dev-cmd/tests.rb | @@ -46,6 +46,7 @@ def tests
files = Dir.glob("test/**/*_test.rb")
.reject { |p| !OS.mac? && p.start_with?("test/os/mac/") }
+ .reject { |p| p.start_with?("test/vendor/bundle/") }
opts = []
opts << "--serialize-stdout" if ENV["CI"] | false |
Other | Homebrew | brew | 5baf16f50e71cd8224dad58350e67fceb56942a1.json | Revert "uninstall: skip some flaky tests for now."
This reverts commit 50c964df2ebda125366a94f0e8701eaeb0d98fa7. | Library/Homebrew/test/uninstall_test.rb | @@ -34,13 +34,11 @@ def handle_unsatisfied_dependents
end
def test_check_for_testball_f2s_when_developer
- skip "Flaky test"
assert_match "Warning", handle_unsatisfied_dependents
refute_predicate Homebrew, :failed?
end
def test_check_for_dependents_when_not_developer
- skip "Flaky test"
... | false |
Other | Homebrew | brew | d7e72899e6f24dca5e02a734d5a4e64e39fc680e.json | uninstall: remove nil requireds/dependents
These shouldn’t get here in the first place so this is a bit of a hack
pending a better fix. | Library/Homebrew/cmd/uninstall.rb | @@ -99,8 +99,8 @@ class DependentsMessage
attr_reader :reqs, :deps
def initialize(requireds, dependents)
- @reqs = requireds
- @deps = dependents
+ @reqs = requireds.compact
+ @deps = dependents.compact
end
protected | false |
Other | Homebrew | brew | 50c964df2ebda125366a94f0e8701eaeb0d98fa7.json | uninstall: skip some flaky tests for now.
These will be fixed properly later but this will avoid causing
unnecessary CI failures. | Library/Homebrew/test/test_uninstall.rb | @@ -35,11 +35,13 @@ def handle_unsatisfied_dependents
end
def test_check_for_testball_f2s_when_developer
+ skip "Flaky test"
assert_match "Warning", handle_unsatisfied_dependents
refute_predicate Homebrew, :failed?
end
def test_check_for_dependents_when_not_developer
+ skip "Flaky test"
... | false |
Other | Homebrew | brew | 14099ffaf3016f126ad95c869ac5dbecf5837eee.json | utils: fix capture_stderr style | Library/Homebrew/utils.rb | @@ -377,7 +377,8 @@ def ignore_interrupts(opt = nil)
end
def capture_stderr
- old, $stderr = $stderr, StringIO.new
+ old = $stderr
+ $stderr = StringIO.new
yield
$stderr.string
ensure | false |
Other | Homebrew | brew | 3c310b2e3dd7805b04f48507c65c2c0a856c2aa2.json | Warn developers when uninstalling a dependency
Suggested in #1084.
Made the existing warning output entirely to STDERR, because
previously the first line went to STDERR and subsequent ones went
to STDOUT. | Library/Homebrew/cmd/uninstall.rb | @@ -28,10 +28,8 @@ def uninstall
ARGV.kegs.group_by(&:rack)
end
- if should_check_for_dependents?
- all_kegs = kegs_by_rack.values.flatten(1)
- return if check_for_dependents all_kegs
- end
+ handle_unsatisfied_dependents(kegs_by_rack)
+ return if Homebrew.failed?
kegs_by_rack... | true |
Other | Homebrew | brew | 3c310b2e3dd7805b04f48507c65c2c0a856c2aa2.json | Warn developers when uninstalling a dependency
Suggested in #1084.
Made the existing warning output entirely to STDERR, because
previously the first line went to STDERR and subsequent ones went
to STDOUT. | Library/Homebrew/test/test_uninstall.rb | @@ -2,20 +2,55 @@
require "cmd/uninstall"
class UninstallTests < Homebrew::TestCase
+ def setup
+ @dependency = formula("dependency") { url "f-1" }
+ @dependent = formula("dependent") do
+ url "f-1"
+ depends_on "dependency"
+ end
+
+ [@dependency, @dependent].each { |f| f.installed_prefix.mk... | true |
Other | Homebrew | brew | 3c310b2e3dd7805b04f48507c65c2c0a856c2aa2.json | Warn developers when uninstalling a dependency
Suggested in #1084.
Made the existing warning output entirely to STDERR, because
previously the first line went to STDERR and subsequent ones went
to STDOUT. | Library/Homebrew/test/test_utils.rb | @@ -174,6 +174,10 @@ def test_gzip
end
end
+ def test_capture_stderr
+ assert_equal "test\n", capture_stderr { $stderr.puts "test" }
+ end
+
def test_shell_profile
ENV["SHELL"] = "/bin/sh"
assert_equal "~/.bash_profile", Utils::Shell.shell_profile | true |
Other | Homebrew | brew | 3c310b2e3dd7805b04f48507c65c2c0a856c2aa2.json | Warn developers when uninstalling a dependency
Suggested in #1084.
Made the existing warning output entirely to STDERR, because
previously the first line went to STDERR and subsequent ones went
to STDOUT. | Library/Homebrew/utils.rb | @@ -376,6 +376,14 @@ def ignore_interrupts(opt = nil)
trap("INT", std_trap)
end
+def capture_stderr
+ old, $stderr = $stderr, StringIO.new
+ yield
+ $stderr.string
+ensure
+ $stderr = old
+end
+
def nostdout
if ARGV.verbose?
yield | true |
Other | Homebrew | brew | e9391481a8fa6037e9fe70a3050a5a2226e3954e.json | Update RuboCop to 0.45.0. | Library/.rubocop.yml | @@ -6,6 +6,9 @@ AllCops:
Metrics/AbcSize:
Enabled: false
+Metrics/BlockLength:
+ Enabled: false
+
Metrics/ClassLength:
Enabled: false
| true |
Other | Homebrew | brew | e9391481a8fa6037e9fe70a3050a5a2226e3954e.json | Update RuboCop to 0.45.0. | Library/Homebrew/.rubocop_todo.yml | @@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config --exclude-limit 100`
-# on 2016-09-28 22:26:33 +0200 using RuboCop version 0.43.0.
+# on 2016-10-24 17:14:14 +0200 using RuboCop version 0.44.1.
# The point is for the user to remove these configuration records
# one by one as the of... | true |
Other | Homebrew | brew | e9391481a8fa6037e9fe70a3050a5a2226e3954e.json | Update RuboCop to 0.45.0. | Library/Homebrew/cask/lib/hbc/cli/style.rb | @@ -23,7 +23,7 @@ def run
$CHILD_STATUS.success?
end
- RUBOCOP_CASK_VERSION = "~> 0.10.4".freeze
+ RUBOCOP_CASK_VERSION = "~> 0.10.5".freeze
def install_rubocop
Utils.capture_stderr do | true |
Other | Homebrew | brew | e9391481a8fa6037e9fe70a3050a5a2226e3954e.json | Update RuboCop to 0.45.0. | Library/Homebrew/cmd/style.rb | @@ -47,7 +47,7 @@ def check_style_json(files, options = {})
def check_style_impl(files, output_type, options = {})
fix = options[:fix]
- Homebrew.install_gem_setup_path! "rubocop", "0.43.0"
+ Homebrew.install_gem_setup_path! "rubocop", "0.45.0"
args = %w[
--force-exclusion | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.