language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | bfa97c8eb29982f42c0ae1f5021b28609289176c.json | Upgrade Glimmer and TypeScript
@glimmer/* 0.37.1 -> 0.38.1
typescript 3.0.1 -> 3.2.4 | packages/@ember/-internals/routing/lib/system/router.ts | @@ -14,7 +14,7 @@ import { cancel, once, run, scheduleOnce } from '@ember/runloop';
import { DEBUG } from '@glimmer/env';
import EmberLocation, { EmberLocation as IEmberLocation } from '../location/api';
import { calculateCacheKey, extractRouteArgs, getActiveTargetName, resemblesURL } from '../utils';
-import EmberR... | true |
Other | emberjs | ember.js | bfa97c8eb29982f42c0ae1f5021b28609289176c.json | Upgrade Glimmer and TypeScript
@glimmer/* 0.37.1 -> 0.38.1
typescript 3.0.1 -> 3.2.4 | packages/@ember/debug/index.ts | @@ -242,10 +242,10 @@ if (DEBUG) {
*/
setDebugFunction('deprecateFunc', function deprecateFunc(...args: any[]) {
if (args.length === 3) {
- let [message, options, func] = args as [string, DeprecationOptions, () => any];
- return function(this: any) {
+ let [message, options, func] = args as [s... | true |
Other | emberjs | ember.js | bfa97c8eb29982f42c0ae1f5021b28609289176c.json | Upgrade Glimmer and TypeScript
@glimmer/* 0.37.1 -> 0.38.1
typescript 3.0.1 -> 3.2.4 | packages/@ember/instrumentation/index.ts | @@ -111,6 +111,14 @@ const time = ((): (() => number) => {
return fn ? fn.bind(perf) : Date.now;
})();
+type InstrumentCallback<Binding, Result> = (this: Binding) => Result;
+
+function isCallback<Binding, Result>(
+ value: InstrumentCallback<Binding, Result> | object
+): value is InstrumentCallback<Binding, Res... | true |
Other | emberjs | ember.js | bfa97c8eb29982f42c0ae1f5021b28609289176c.json | Upgrade Glimmer and TypeScript
@glimmer/* 0.37.1 -> 0.38.1
typescript 3.0.1 -> 3.2.4 | packages/@ember/instrumentation/tests/index-test.js | @@ -149,7 +149,7 @@ moduleFor(
}
['@test raising an exception in the instrumentation attaches it to the payload'](assert) {
- assert.expect(2);
+ assert.expect(3);
let error = new Error('Instrumentation');
@@ -167,9 +167,13 @@ moduleFor(
},
});
- instrument('rende... | true |
Other | emberjs | ember.js | bfa97c8eb29982f42c0ae1f5021b28609289176c.json | Upgrade Glimmer and TypeScript
@glimmer/* 0.37.1 -> 0.38.1
typescript 3.0.1 -> 3.2.4 | yarn.lock | @@ -747,120 +747,122 @@
lodash "^4.17.11"
to-fast-properties "^2.0.0"
-"@glimmer/compiler@^0.37.1":
- version "0.37.1"
- resolved "https://registry.yarnpkg.com/@glimmer/compiler/-/compiler-0.37.1.tgz#a3d59e0b1e51341314d3f8202aa0d4b70dc55173"
- integrity sha512-bGdRb52eWZuHEGaIa1Rl0e0f4vPpQtp+gnpsaRwBMmRL... | true |
Other | emberjs | ember.js | 7255233fa5e92a8d3389a8accefd20817c132a85.json | Add v3.9.0-beta.5 to CHANGELOG
[ci skip]
(cherry picked from commit 1e2672cddfd7bc277c8073472635b1b6ab111200) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.9.0-beta.5 (March 25, 2019)
+
+- [#17733](https://github.com/emberjs/ember.js/pull/17733) [BUGFIX] Assert on use of reserved component names (`input` and `textarea`)
+
### v3.9.0-beta.4 (March 11, 2019)
- [#17710](https://github.com/emberjs/ember.js/pull/17710) [BUGFIX] ... | false |
Other | emberjs | ember.js | c3e93c7a1481c2490de3f06c44c04ac845bd3539.json | Add examples to the urlFor RouterService method | packages/@ember/-internals/routing/lib/services/router.ts | @@ -137,7 +137,60 @@ export default class RouterService extends Service {
}
/**
- Generate a URL based on the supplied route name.
+ Generate a URL based on the supplied route name and optionally a model. The
+ URL is returned as a string that can be used for any purpose.
+
+ In this example, the U... | false |
Other | emberjs | ember.js | 3a2ef238f179a65f39bbd4adfac0cb2aa4b03cb2.json | Fix mixin blueprint tests under Windows
Uncovered in https://github.com/typed-ember/ember-cli-typescript-blueprints/pull/74, tests fail under Windows due to hardcoded line ending character. | node-tests/blueprints/mixin-test.js | @@ -6,6 +6,7 @@ const emberNew = blueprintHelpers.emberNew;
const emberGenerateDestroy = blueprintHelpers.emberGenerateDestroy;
const setupPodConfig = blueprintHelpers.setupPodConfig;
const expectError = require('../helpers/expect-error');
+const EOL = require('os').EOL;
const chai = require('ember-cli-blueprint-... | false |
Other | emberjs | ember.js | 6c60eee651e27a4bda70112b1d3e9badac7fbf93.json | Remove EMBER_ENGINES_MOUNT_PARAMS feature. | packages/@ember/-internals/glimmer/lib/component-managers/mount.ts | @@ -7,7 +7,6 @@ import { Destroyable, Opaque, Option } from '@glimmer/util';
import { Owner } from '@ember/-internals/owner';
import { generateControllerFactory } from '@ember/-internals/routing';
import { OwnedTemplateMeta } from '@ember/-internals/views';
-import { EMBER_ENGINES_MOUNT_PARAMS } from '@ember/canary-... | true |
Other | emberjs | ember.js | 6c60eee651e27a4bda70112b1d3e9badac7fbf93.json | Remove EMBER_ENGINES_MOUNT_PARAMS feature. | packages/@ember/-internals/glimmer/lib/syntax/mount.ts | @@ -2,7 +2,6 @@
@module ember
*/
import { OwnedTemplateMeta } from '@ember/-internals/views';
-import { EMBER_ENGINES_MOUNT_PARAMS } from '@ember/canary-features';
import { assert } from '@ember/debug';
import { Opaque, Option } from '@glimmer/interfaces';
import { OpcodeBuilder } from '@glimmer/opcode-compiler';... | true |
Other | emberjs | ember.js | 6c60eee651e27a4bda70112b1d3e9badac7fbf93.json | Remove EMBER_ENGINES_MOUNT_PARAMS feature. | packages/@ember/-internals/glimmer/tests/integration/mount-test.js | @@ -5,31 +5,17 @@ import { compile, Component } from '../utils/helpers';
import Controller from '@ember/controller';
import { set } from '@ember/-internals/metal';
import Engine, { getEngineParent } from '@ember/engine';
-import { EMBER_ENGINES_MOUNT_PARAMS } from '@ember/canary-features';
-if (EMBER_ENGINES_MOUNT... | true |
Other | emberjs | ember.js | 6c60eee651e27a4bda70112b1d3e9badac7fbf93.json | Remove EMBER_ENGINES_MOUNT_PARAMS feature. | packages/@ember/canary-features/index.ts | @@ -15,7 +15,6 @@ import { assign } from '@ember/polyfills';
export const DEFAULT_FEATURES = {
EMBER_LIBRARIES_ISREGISTERED: null,
EMBER_IMPROVED_INSTRUMENTATION: null,
- EMBER_ENGINES_MOUNT_PARAMS: true,
EMBER_MODULE_UNIFICATION: null,
EMBER_METAL_TRACKED_PROPERTIES: null,
EMBER_GLIMMER_ANGLE_BRACKET_... | true |
Other | emberjs | ember.js | 1aa923929ab8d742ed1fac3f528704787059f662.json | Fix initializer blueprint for ember-mocha 0.14
The previous PR #17411 and its last-minute change to remove `setupTest()` introduced a very stupid error! 🤦♂️ | blueprints/initializer-test/mocha-rfc-232-files/__root__/__testType__/__path__/__name__-test.js | @@ -1,12 +1,12 @@
import { expect } from 'chai';
-import { describe, it } from 'mocha';
+import { describe, it, beforeEach, afterEach } from 'mocha';
import { setupTest } from 'ember-mocha';
import Application from '@ember/application';
import { initialize } from '<%= modulePrefix %>/initializers/<%= dasherizedModu... | true |
Other | emberjs | ember.js | 1aa923929ab8d742ed1fac3f528704787059f662.json | Fix initializer blueprint for ember-mocha 0.14
The previous PR #17411 and its last-minute change to remove `setupTest()` introduced a very stupid error! 🤦♂️ | node-tests/fixtures/initializer-test/mocha-rfc232.js | @@ -1,12 +1,12 @@
import { expect } from 'chai';
-import { describe, it } from 'mocha';
+import { describe, it, beforeEach, afterEach } from 'mocha';
import { setupTest } from 'ember-mocha';
import Application from '@ember/application';
import { initialize } from 'my-app/initializers/foo';
import { run } from '@em... | true |
Other | emberjs | ember.js | 1aa923929ab8d742ed1fac3f528704787059f662.json | Fix initializer blueprint for ember-mocha 0.14
The previous PR #17411 and its last-minute change to remove `setupTest()` introduced a very stupid error! 🤦♂️ | node-tests/fixtures/initializer-test/module-unification/mocha-rfc232.js | @@ -1,12 +1,12 @@
import { expect } from 'chai';
-import { describe, it } from 'mocha';
+import { describe, it, beforeEach, afterEach } from 'mocha';
import { setupTest } from 'ember-mocha';
import Application from '@ember/application';
import { initialize } from 'my-app/init/initializers/foo';
import { run } from... | true |
Other | emberjs | ember.js | 9b907dbf0a22be04943656dc43836f8bc495fdec.json | Add v3.9.0-beta.4 to CHANGELOG
[ci skip]
(cherry picked from commit fc75c3bd63ad10851bd7731e1d7deb7ecff8a76a) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.9.0-beta.4 (March 11, 2019)
+
+- [#17710](https://github.com/emberjs/ember.js/pull/17710) [BUGFIX] Allow accessors in mixins
+
### v3.9.0-beta.3 (March 4, 2019)
- [#17684](https://github.com/emberjs/ember.js/pull/17684) [BUGFIX] Enable maximum rerendering limit to be cus... | false |
Other | emberjs | ember.js | 82a7e36a11a9a55b8bdc0cc1603d4ce783508aed.json | remove init and add types to router | packages/@ember/-internals/routing/lib/system/router.ts | @@ -248,6 +248,11 @@ interface OutletState {
outlets: NestedOutletState;
}
+interface EngineInstance extends Owner {
+ boot(): void;
+ destroy(): void;
+}
+
export interface QueryParam {
prop: string;
urlKey: string;
@@ -280,6 +285,27 @@ class EmberRouter extends EmberObject {
rootURL!: string;
_ro... | false |
Other | emberjs | ember.js | bff547d15646b3fba3a5700b5ca16f0adfc39f2c.json | Instance-initializer blueprint: destroy instance before application
See https://github.com/emberjs/ember.js/pull/17412#discussion_r26304 | blueprints/instance-initializer-test/qunit-rfc-232-files/__root__/__testType__/__path__/__name__-test.js | @@ -15,8 +15,8 @@ module('<%= friendlyTestName %>', function(hooks) {
this.instance = this.application.buildInstance();
});
hooks.afterEach(function() {
- <% if (destroyAppExists) { %>destroyApp(this.application);<% } else { %>run(this.application, 'destroy');<% } %>
<% if (destroyAppExists) { %>dest... | true |
Other | emberjs | ember.js | bff547d15646b3fba3a5700b5ca16f0adfc39f2c.json | Instance-initializer blueprint: destroy instance before application
See https://github.com/emberjs/ember.js/pull/17412#discussion_r26304 | node-tests/fixtures/instance-initializer-test/module-unification/rfc232.js | @@ -15,8 +15,8 @@ module('Unit | Instance Initializer | foo', function(hooks) {
this.instance = this.application.buildInstance();
});
hooks.afterEach(function() {
- run(this.application, 'destroy');
run(this.instance, 'destroy');
+ run(this.application, 'destroy');
});
// Replace this with... | true |
Other | emberjs | ember.js | bff547d15646b3fba3a5700b5ca16f0adfc39f2c.json | Instance-initializer blueprint: destroy instance before application
See https://github.com/emberjs/ember.js/pull/17412#discussion_r26304 | node-tests/fixtures/instance-initializer-test/rfc232.js | @@ -15,8 +15,8 @@ module('Unit | Instance Initializer | foo', function(hooks) {
this.instance = this.application.buildInstance();
});
hooks.afterEach(function() {
- run(this.application, 'destroy');
run(this.instance, 'destroy');
+ run(this.application, 'destroy');
});
// Replace this with... | true |
Other | emberjs | ember.js | d4facc6f0e77114d45712241f76b84b7af5ace11.json | Fix blueprint helper test
It fixes the test when generating a helper in a MU `dummy` app.
It continues the work of #17658 that requires this change when #17689 was merged. | node-tests/blueprints/helper-test.js | @@ -189,7 +189,7 @@ describe('Blueprint: helper', function() {
it('helper foo/bar-baz --dummy', function() {
return emberGenerateDestroy(['helper', 'foo/bar-baz', '--dummy'], _file => {
expect(_file('tests/dummy/src/ui/components/foo/bar-baz.js')).to.equal(
- fixture('helper/helper.js')
+ ... | false |
Other | emberjs | ember.js | 514787c9b01461162ce780ff766d3c531b77d16e.json | Add v3.9.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit b93488b1857afb555b57aecf1a5b6f00a5a8c30f) | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### v3.9.0-beta.3 (March 4, 2019)
+
+- [#17684](https://github.com/emberjs/ember.js/pull/17684) [BUGFIX] Enable maximum rerendering limit to be customized.
+- [#17691](https://github.com/emberjs/ember.js/pull/17691) [BUGFIX] Ensure tagForProperty works on class constructors
+
###... | false |
Other | emberjs | ember.js | fbce6687d9db75f1b3445853097fe8e8a46755bf.json | Fix helper blueprint for module unification
Prior to this change, the classic blueprint used a different
construction for helper files. Since module unification this has
changed.
This commit updates the blueprints to generate the new construction code
for helpers when module unification is in use and still offers the... | blueprints/helper/index.js | @@ -8,6 +8,11 @@ const path = require('path');
module.exports = {
description: 'Generates a helper function.',
+ filesPath() {
+ let rootPath = isModuleUnificationProject(this.project) ? 'mu-files' : 'files';
+ return path.join(this.path, rootPath);
+ },
+
fileMapTokens() {
if (isModuleUnification... | true |
Other | emberjs | ember.js | fbce6687d9db75f1b3445853097fe8e8a46755bf.json | Fix helper blueprint for module unification
Prior to this change, the classic blueprint used a different
construction for helper files. Since module unification this has
changed.
This commit updates the blueprints to generate the new construction code
for helpers when module unification is in use and still offers the... | blueprints/helper/mu-files/__root__/__collection__/__name__.js | @@ -0,0 +1,7 @@
+import { helper as buildHelper } from '@ember/component/helper';
+
+export function <%= camelizedModuleName %>(params/*, hash*/) {
+ return params;
+}
+
+export const helper = buildHelper(<%= camelizedModuleName %>); | true |
Other | emberjs | ember.js | fbce6687d9db75f1b3445853097fe8e8a46755bf.json | Fix helper blueprint for module unification
Prior to this change, the classic blueprint used a different
construction for helper files. Since module unification this has
changed.
This commit updates the blueprints to generate the new construction code
for helpers when module unification is in use and still offers the... | node-tests/blueprints/helper-test.js | @@ -106,7 +106,7 @@ describe('Blueprint: helper', function() {
it('helper foo/bar-baz', function() {
return emberGenerateDestroy(['helper', 'foo/bar-baz'], _file => {
- expect(_file('src/ui/components/foo/bar-baz.js')).to.equal(fixture('helper/helper.js'));
+ expect(_file('src/ui/components/... | true |
Other | emberjs | ember.js | fbce6687d9db75f1b3445853097fe8e8a46755bf.json | Fix helper blueprint for module unification
Prior to this change, the classic blueprint used a different
construction for helper files. Since module unification this has
changed.
This commit updates the blueprints to generate the new construction code
for helpers when module unification is in use and still offers the... | node-tests/fixtures/helper/mu-helper.js | @@ -0,0 +1,7 @@
+import { helper as buildHelper } from '@ember/component/helper';
+
+export function fooBarBaz(params/*, hash*/) {
+ return params;
+}
+
+export const helper = buildHelper(fooBarBaz); | true |
Other | emberjs | ember.js | 7d103a937b21b5b728f73cd29b5a6272f628dce4.json | Remove `hasViews` guard.
This was originally added to ensure that we did not accidentally trigger
the auto-run assertion if we didn't have any components/views rendered.
However, as of Ember 3.4+ the autorun assertion is removed, making this
system completely useless and over complicates the remaining code.
Co-autho... | packages/@ember/-internals/glimmer/lib/renderer.ts | @@ -1,4 +1,4 @@
-import { runInTransaction, setHasViews } from '@ember/-internals/metal';
+import { runInTransaction } from '@ember/-internals/metal';
import {
fallbackViewRegistry,
getViewElement,
@@ -169,8 +169,6 @@ export function _resetRenderers() {
renderers.length = 0;
}
-setHasViews(() => renderers.... | true |
Other | emberjs | ember.js | 7d103a937b21b5b728f73cd29b5a6272f628dce4.json | Remove `hasViews` guard.
This was originally added to ensure that we did not accidentally trigger
the auto-run assertion if we didn't have any components/views rendered.
However, as of Ember 3.4+ the autorun assertion is removed, making this
system completely useless and over complicates the remaining code.
Co-autho... | packages/@ember/-internals/metal/index.ts | @@ -47,7 +47,7 @@ export { default as expandProperties } from './lib/expand_properties';
export { addObserver, removeObserver } from './lib/observer';
export { Mixin, aliasMethod, mixin, observer, applyMixin } from './lib/mixin';
export { default as inject, DEBUG_INJECTION_FUNCTIONS } from './lib/injected_property';... | true |
Other | emberjs | ember.js | 7d103a937b21b5b728f73cd29b5a6272f628dce4.json | Remove `hasViews` guard.
This was originally added to ensure that we did not accidentally trigger
the auto-run assertion if we didn't have any components/views rendered.
However, as of Ember 3.4+ the autorun assertion is removed, making this
system completely useless and over complicates the remaining code.
Co-autho... | packages/@ember/-internals/metal/lib/tags.ts | @@ -11,12 +11,6 @@ import {
UpdatableTag,
} from '@glimmer/reference';
-let hasViews: () => boolean = () => false;
-
-export function setHasViews(fn: () => boolean): void {
- hasViews = fn;
-}
-
function makeTag(): TagWrapper<DirtyableTag> {
return DirtyableTag.create();
}
@@ -95,7 +89,5 @@ export function ... | true |
Other | emberjs | ember.js | 7d103a937b21b5b728f73cd29b5a6272f628dce4.json | Remove `hasViews` guard.
This was originally added to ensure that we did not accidentally trigger
the auto-run assertion if we didn't have any components/views rendered.
However, as of Ember 3.4+ the autorun assertion is removed, making this
system completely useless and over complicates the remaining code.
Co-autho... | packages/@ember/-internals/metal/tests/accessors/set_test.js | @@ -1,13 +1,9 @@
-import { get, set, trySet, setHasViews } from '../..';
+import { get, set, trySet } from '../..';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
moduleFor(
'set',
class extends AbstractTestCase {
- teardown() {
- setHasViews(() => false);
- }
-
['@test s... | true |
Other | emberjs | ember.js | 75b5d0877f451ff790978eaa77d24989ebe1b6ad.json | Remove nonexistent link /defining-your-routes | packages/@ember/-internals/routing/lib/system/router.ts | @@ -1716,9 +1716,6 @@ EmberRouter.reopenClass({
});
```
- For more detailed documentation and examples please see
- [the guides](https://guides.emberjs.com/release/routing/defining-your-routes/).
-
@method map
@param callback
@public | false |
Other | emberjs | ember.js | 8628f37fc96ca656b4d8de18f21bcb398ad86c8b.json | Add v3.9.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit 35d15c2a8c3c4fc71de8fdbc8ba1dd9aa0280aef) | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### v3.9.0-beta.2 (February 26, 2019)
+
+- [#17618](https://github.com/emberjs/ember.js/pull/17618) [BUGFIX] Migrate autorun microtask queue to Promise.then
+- [#17649](https://github.com/emberjs/ember.js/pull/17649) [BUGFIX] Revert decorator refactors
+
### v3.9.0-beta.1 (Februa... | false |
Other | emberjs | ember.js | 4e9e931eec7b61e9c445e52d7468efcb1cd51171.json | Fix typo in docs | packages/@ember/-internals/glimmer/lib/helpers/concat.ts | @@ -30,7 +30,7 @@ const normalizeTextValue = (value: any): string => {
or for angle bracket invocation, you actually don't need concat at all.
```handlebars
- <SomeComponent @name="{{firstName lastName}}" />
+ <SomeComponent @name="{{firstName}} {{lastName}}" />
```
@public | false |
Other | emberjs | ember.js | aa0579b5dbc3e9568ebeaa034cf665e2f3c3a2ee.json | Add v3.9.0-beta.1 to CHANGELOG
[ci skip]
(cherry picked from commit 370e0d6120cbd63339eb14fa5481a7a4614f948d) | CHANGELOG.md | @@ -1,5 +1,16 @@
# Ember Changelog
+### v3.9.0-beta.1 (February 18, 2019)
+
+- [#17470](https://github.com/emberjs/ember.js/pull/17470) [DEPRECATION] Implements the Computed Property Modifier deprecation RFCs
+ * Deprecates `.property()` (see [emberjs/rfcs#0375](https://github.com/emberjs/rfcs/blob/master/text/0375... | false |
Other | emberjs | ember.js | b71a2a5aea97bed538310faacdfc60540cb6965f.json | Add v3.8.0 to CHANGELOG
[ci skip]
(cherry picked from commit 43e8cb6b62c31bfdbe6c3f937a05021251096067) | CHANGELOG.md | @@ -1,36 +1,25 @@
# Ember Changelog
-### v3.8.0-beta.5 (February 11, 2019)
-
-- [#17563](https://github.com/emberjs/ember.js/pull/17563) [BUGFIX] Transition.send/trigger call signature
-
-### v3.8.0-beta.4 (February 4, 2019)
-
-- [#17552](https://github.com/emberjs/ember.js/pull/17552) [BUGFIX] Support numbers in co... | false |
Other | emberjs | ember.js | 86b9f705c72de7ea2ad139c66f2977e82e95a898.json | Add v3.8.0-beta.5 to CHANGELOG
[ci skip]
(cherry picked from commit 39bb0d47bb8ee081a378daab0064e8033734c33d) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.8.0-beta.5 (February 11, 2019)
+
+- [#17563](https://github.com/emberjs/ember.js/pull/17563) [BUGFIX] Transition.send/trigger call signature
+
### v3.8.0-beta.4 (February 4, 2019)
- [#17552](https://github.com/emberjs/ember.js/pull/17552) [BUGFIX] Support numbers in comp... | false |
Other | emberjs | ember.js | 287afaee33d069981bc49f0f9b8bf0c05dbb419f.json | add initializer back | packages/@ember/-internals/metal/lib/tracked.ts | @@ -203,7 +203,13 @@ function descriptorForField(elementDesc: ElementDescriptor): ElementDescriptor {
get(): any {
if (CURRENT_TRACKER) CURRENT_TRACKER.add(tagForProperty(this, key));
- return getTrackedFieldValues(this)[key];
+ let values = getTrackedFieldValues(this);
+
+ if (!(... | false |
Other | emberjs | ember.js | b7c7eaf792545c2dcbc87b8ba7453d48f32f840f.json | remove cycle, switch from symbol to weakmap | packages/@ember/-internals/metal/index.ts | @@ -29,12 +29,12 @@ export {
PROPERTY_DID_CHANGE,
} from './lib/property_events';
export { defineProperty } from './lib/properties';
+export { nativeDescDecorator } from './lib/decorator';
export {
descriptorForProperty,
isComputedDecorator,
setComputedDecorator,
- nativeDescDecorator,
-} from './lib/de... | true |
Other | emberjs | ember.js | b7c7eaf792545c2dcbc87b8ba7453d48f32f840f.json | remove cycle, switch from symbol to weakmap | packages/@ember/-internals/metal/lib/alias.ts | @@ -7,10 +7,10 @@ import {
addDependentKeys,
ComputedDescriptor,
Decorator,
- descriptorForDecorator,
makeComputedDecorator,
removeDependentKeys,
} from './decorator';
+import { descriptorForDecorator } from './descriptor_map';
import { defineProperty } from './properties';
import { get } from './pro... | true |
Other | emberjs | ember.js | b7c7eaf792545c2dcbc87b8ba7453d48f32f840f.json | remove cycle, switch from symbol to weakmap | packages/@ember/-internals/metal/lib/chains.ts | @@ -1,6 +1,6 @@
import { Meta, meta as metaFor, peekMeta } from '@ember/-internals/meta';
import { getCachedValueFor } from './computed_cache';
-import { descriptorForProperty } from './decorator';
+import { descriptorForProperty } from './descriptor_map';
import { eachProxyFor } from './each_proxy';
import { get }... | true |
Other | emberjs | ember.js | b7c7eaf792545c2dcbc87b8ba7453d48f32f840f.json | remove cycle, switch from symbol to weakmap | packages/@ember/-internals/metal/lib/computed.ts | @@ -14,10 +14,10 @@ import {
addDependentKeys,
ComputedDescriptor,
Decorator,
- descriptorForDecorator,
makeComputedDecorator,
removeDependentKeys,
} from './decorator';
+import { descriptorForDecorator } from './descriptor_map';
import expandProperties from './expand_properties';
import { defineProp... | true |
Other | emberjs | ember.js | b7c7eaf792545c2dcbc87b8ba7453d48f32f840f.json | remove cycle, switch from symbol to weakmap | packages/@ember/-internals/metal/lib/decorator.ts | @@ -1,11 +1,10 @@
-import { Meta, meta as metaFor, peekMeta } from '@ember/-internals/meta';
+import { Meta, meta as metaFor } from '@ember/-internals/meta';
import { EMBER_NATIVE_DECORATOR_SUPPORT } from '@ember/canary-features';
import { assert } from '@ember/debug';
import { DEBUG } from '@glimmer/env';
+import {... | true |
Other | emberjs | ember.js | b7c7eaf792545c2dcbc87b8ba7453d48f32f840f.json | remove cycle, switch from symbol to weakmap | packages/@ember/-internals/metal/lib/descriptor_map.ts | @@ -0,0 +1,58 @@
+import { Meta, peekMeta } from '@ember/-internals/meta';
+import { assert } from '@ember/debug';
+
+const DECORATOR_DESCRIPTOR_MAP: WeakMap<
+ import('./decorator').Decorator,
+ import('./decorator').ComputedDescriptor | boolean
+> = new WeakMap();
+
+/**
+ Returns the CP descriptor assocaited with... | true |
Other | emberjs | ember.js | b7c7eaf792545c2dcbc87b8ba7453d48f32f840f.json | remove cycle, switch from symbol to weakmap | packages/@ember/-internals/metal/lib/mixin.ts | @@ -22,12 +22,12 @@ import {
ComputedPropertyGetter,
ComputedPropertySetter,
} from './computed';
+import { makeComputedDecorator } from './decorator';
import {
descriptorForDecorator,
descriptorForProperty,
isComputedDecorator,
- makeComputedDecorator,
-} from './decorator';
+} from './descriptor_map... | true |
Other | emberjs | ember.js | b7c7eaf792545c2dcbc87b8ba7453d48f32f840f.json | remove cycle, switch from symbol to weakmap | packages/@ember/-internals/metal/lib/properties.ts | @@ -5,12 +5,8 @@
import { Meta, meta as metaFor, peekMeta, UNDEFINED } from '@ember/-internals/meta';
import { assert } from '@ember/debug';
import { DEBUG } from '@glimmer/env';
-import {
- Decorator,
- descriptorForProperty,
- ElementDescriptor,
- isComputedDecorator,
-} from './decorator';
+import { Decorator... | true |
Other | emberjs | ember.js | b7c7eaf792545c2dcbc87b8ba7453d48f32f840f.json | remove cycle, switch from symbol to weakmap | packages/@ember/-internals/metal/lib/property_events.ts | @@ -2,7 +2,7 @@ import { Meta, peekMeta } from '@ember/-internals/meta';
import { symbol } from '@ember/-internals/utils';
import { DEBUG } from '@glimmer/env';
import changeEvent from './change_event';
-import { descriptorForProperty } from './decorator';
+import { descriptorForProperty } from './descriptor_map';
... | true |
Other | emberjs | ember.js | b7c7eaf792545c2dcbc87b8ba7453d48f32f840f.json | remove cycle, switch from symbol to weakmap | packages/@ember/-internals/metal/lib/property_get.ts | @@ -5,7 +5,7 @@ import { HAS_NATIVE_PROXY, symbol } from '@ember/-internals/utils';
import { EMBER_METAL_TRACKED_PROPERTIES } from '@ember/canary-features';
import { assert } from '@ember/debug';
import { DEBUG } from '@glimmer/env';
-import { descriptorForProperty } from './decorator';
+import { descriptorForProper... | true |
Other | emberjs | ember.js | b7c7eaf792545c2dcbc87b8ba7453d48f32f840f.json | remove cycle, switch from symbol to weakmap | packages/@ember/-internals/metal/lib/property_set.ts | @@ -3,7 +3,7 @@ import { HAS_NATIVE_PROXY, lookupDescriptor, toString } from '@ember/-internals/
import { assert } from '@ember/debug';
import EmberError from '@ember/error';
import { DEBUG } from '@glimmer/env';
-import { descriptorForProperty } from './decorator';
+import { descriptorForProperty } from './descript... | true |
Other | emberjs | ember.js | b7c7eaf792545c2dcbc87b8ba7453d48f32f840f.json | remove cycle, switch from symbol to weakmap | packages/@ember/-internals/metal/lib/tracked.ts | @@ -2,7 +2,8 @@ import { EMBER_NATIVE_DECORATOR_SUPPORT } from '@ember/canary-features';
import { assert } from '@ember/debug';
import { DEBUG } from '@glimmer/env';
import { combine, CONSTANT_TAG, Tag } from '@glimmer/reference';
-import { Decorator, ElementDescriptor, setComputedDecorator } from './decorator';
+im... | true |
Other | emberjs | ember.js | b7c7eaf792545c2dcbc87b8ba7453d48f32f840f.json | remove cycle, switch from symbol to weakmap | packages/@ember/-internals/metal/lib/watch_key.ts | @@ -1,7 +1,7 @@
import { Meta, meta as metaFor, peekMeta, UNDEFINED } from '@ember/-internals/meta';
import { lookupDescriptor } from '@ember/-internals/utils';
import { DEBUG } from '@glimmer/env';
-import { descriptorForProperty, isComputedDecorator } from './decorator';
+import { descriptorForProperty, isComputed... | true |
Other | emberjs | ember.js | 53b84e24220861bb45987b0dfd2461b70c909fe8.json | add action decorator | packages/@ember/object/index.js | @@ -0,0 +1,95 @@
+import { EMBER_NATIVE_DECORATOR_SUPPORT } from '@ember/canary-features';
+import { assert } from '@ember/debug';
+import { assign } from '@ember/polyfills';
+
+/**
+ Decorator that turns the target function into an Action
+ Adds an `actions` object to the target object and creates a passthrough
+ f... | true |
Other | emberjs | ember.js | 53b84e24220861bb45987b0dfd2461b70c909fe8.json | add action decorator | packages/@ember/object/tests/action_test.js | @@ -0,0 +1,234 @@
+import { EMBER_NATIVE_DECORATOR_SUPPORT } from '@ember/canary-features';
+import { Component } from '@ember/-internals/glimmer';
+import { Object as EmberObject } from '@ember/-internals/runtime';
+import { moduleFor, RenderingTestCase, strip } from 'internal-test-helpers';
+
+import { action } from ... | true |
Other | emberjs | ember.js | 53b84e24220861bb45987b0dfd2461b70c909fe8.json | add action decorator | packages/ember/index.js | @@ -28,6 +28,8 @@ import {
} from '@ember/string';
import Service, { inject as injectService } from '@ember/service';
+import { action } from '@ember/object';
+
import {
and,
bool,
@@ -433,6 +435,8 @@ Ember._ProxyMixin = _ProxyMixin;
Ember.RSVP = RSVP;
Ember.Namespace = Namespace;
+Ember._action = action... | true |
Other | emberjs | ember.js | 53b84e24220861bb45987b0dfd2461b70c909fe8.json | add action decorator | packages/ember/tests/reexports_test.js | @@ -1,5 +1,5 @@
import Ember from '../index';
-import { FEATURES } from '@ember/canary-features';
+import { FEATURES, EMBER_NATIVE_DECORATOR_SUPPORT } from '@ember/canary-features';
import { confirmExport } from 'internal-test-helpers';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
import { j... | true |
Other | emberjs | ember.js | f2dfd1393acf7abe4d00fa82acb13c918f13598c.json | use HAS_NATIVE_SYMBOL consistently | packages/@ember/-internals/glimmer/tests/integration/content-test.js | @@ -6,6 +6,7 @@ import { set, computed } from '@ember/-internals/metal';
import { getDebugFunction, setDebugFunction } from '@ember/debug';
import { readOnly } from '@ember/object/computed';
import { Object as EmberObject, ObjectProxy } from '@ember/-internals/runtime';
+import { HAS_NATIVE_SYMBOL } from '@ember/-in... | true |
Other | emberjs | ember.js | f2dfd1393acf7abe4d00fa82acb13c918f13598c.json | use HAS_NATIVE_SYMBOL consistently | packages/@ember/-internals/utils/tests/guid_for_test.js | @@ -1,4 +1,4 @@
-import { guidFor } from '..';
+import { guidFor, HAS_NATIVE_SYMBOL } from '..';
import { moduleFor, AbstractTestCase as TestCase } from 'internal-test-helpers';
function sameGuid(assert, a, b, message) {
@@ -49,7 +49,7 @@ moduleFor(
}
['@test symbols'](assert) {
- if (typeof Symbol... | true |
Other | emberjs | ember.js | b3021dcab3917a4d85e5be7ff398dffd5f814c90.json | add symbol polyfill to tests | broccoli/test-polyfills.js | @@ -0,0 +1,20 @@
+const Rollup = require('broccoli-rollup');
+const writeFile = require('broccoli-file-creator');
+const resolve = require('rollup-plugin-node-resolve');
+const commonjs = require('rollup-plugin-commonjs');
+
+module.exports = function polyfills() {
+ let polyfillEntry = writeFile('polyfill-entry.js', ... | true |
Other | emberjs | ember.js | b3021dcab3917a4d85e5be7ff398dffd5f814c90.json | add symbol polyfill to tests | ember-cli-build.js | @@ -9,6 +9,7 @@ const bootstrapModule = require('./broccoli/bootstrap-modules');
const concatBundle = require('./broccoli/concat-bundle');
const concat = require('broccoli-concat');
const testIndexHTML = require('./broccoli/test-index-html');
+const testPolyfills = require('./broccoli/test-polyfills');
const toES5 ... | true |
Other | emberjs | ember.js | b3021dcab3917a4d85e5be7ff398dffd5f814c90.json | add symbol polyfill to tests | package.json | @@ -121,6 +121,7 @@
"broccoli-typescript-compiler": "^4.0.1",
"broccoli-uglify-sourcemap": "^2.2.0",
"common-tags": "^1.8.0",
+ "core-js": "^2.6.3",
"dag-map": "^2.0.2",
"ember-cli": "^3.7.1",
"ember-cli-blueprint-test-helpers": "^0.19.2",
@@ -150,6 +151,8 @@
"prettier": "1.16.4",
... | true |
Other | emberjs | ember.js | b3021dcab3917a4d85e5be7ff398dffd5f814c90.json | add symbol polyfill to tests | tests/index.html | @@ -9,6 +9,7 @@
display: none;
}
</style>
+ <script src="../polyfill.js" nomodule></script>
<script src="../qunit/qunit.js"></script>
<script src="/testem.js"></script>
| true |
Other | emberjs | ember.js | b3021dcab3917a4d85e5be7ff398dffd5f814c90.json | add symbol polyfill to tests | yarn.lock | @@ -1995,6 +1995,11 @@ builtin-modules@^1.0.0, builtin-modules@^1.1.1:
resolved "https://registry.yarnpkg.com/builtin-modules/-/builtin-modules-1.1.1.tgz#270f076c5a72c02f5b65a47df94c5fe3a278892f"
integrity sha1-Jw8HbFpywC9bZaR9+Uxf46J4iS8=
+builtin-modules@^3.0.0:
+ version "3.0.0"
+ resolved "https://registr... | true |
Other | emberjs | ember.js | 587d91c9c9bf07ed4a7b7325bf7652848074baa8.json | Add v3.7.3 to CHANGELOG
[ci skip]
(cherry picked from commit 76dc1997b6af36905204c3244499514718ea21a6) | CHANGELOG.md | @@ -28,6 +28,11 @@
- [#17357](https://github.com/emberjs/ember.js/pull/17357) Allow notifyPropertyChange to be imported from @ember/object
- [#17413](https://github.com/emberjs/ember.js/pull/17413) Fix missing import in instance-initializer blueprint for ember-mocha
+### v3.7.3 (February 6, 2019)
+
+- [#17563](http... | false |
Other | emberjs | ember.js | 0dc1a511f4309fdfdcf109b931b1a9f29f4884b3.json | Add v3.8.0-beta.4 to CHANGELOG
[ci skip]
(cherry picked from commit 2a8319845cedd2657c7a01db619e4438879dc2eb) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.8.0-beta.4 (February 4, 2019)
+
+- [#17552](https://github.com/emberjs/ember.js/pull/17552) [BUGFIX] Support numbers in component names for Angle Brackets
+
### v3.8.0-beta.3 (January 28, 2019)
- [#17498](https://github.com/emberjs/ember.js/pull/17498) [BUGFIX] Don't rem... | false |
Other | emberjs | ember.js | 1f5438bd37af9f38d077e260a9c3cb7e5a56b09c.json | update svelte version | packages/@ember/deprecated-features/index.ts | @@ -1,5 +1,8 @@
/* eslint-disable no-implicit-coercion */
+// These versions should be the version that the deprecation was _introduced_,
+// not the version that the feature will be removed.
+
export const SEND_ACTION = !!'3.4.0';
export const EMBER_EXTEND_PROTOTYPES = !!'3.2.0-beta.5';
export const RUN_SYNC = !... | false |
Other | emberjs | ember.js | 0a2f4b4d8669d1522bc683f835b37744b7ced796.json | Add v3.8.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit 4d7a49679506889b8bf1813173de961d8273ce6e) | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### v3.8.0-beta.3 (January 28, 2019)
+
+- [#17498](https://github.com/emberjs/ember.js/pull/17498) [BUGFIX] Don't remove dep keys in `didUnwatch`
+- [#17499](https://github.com/emberjs/ember.js/pull/17499) [BUGFIX] Update to glimmer-vm 0.37.1.
+
### v3.8.0-beta.2 (January 14, 201... | false |
Other | emberjs | ember.js | 2aa22eed70030e837dbe2b500b7653653279f25f.json | Add svelte support for jQuery deprecations | packages/@ember/-internals/views/lib/mixins/view_support.js | @@ -6,68 +6,64 @@ import { hasDOM } from '@ember/-internals/browser-environment';
import { matches } from '../system/utils';
import { default as jQuery, jQueryDisabled } from '../system/jquery';
import { deprecate } from '@ember/debug';
+import { JQUERY_INTEGRATION } from '@ember/deprecated-features';
function K(... | true |
Other | emberjs | ember.js | 2aa22eed70030e837dbe2b500b7653653279f25f.json | Add svelte support for jQuery deprecations | packages/@ember/-internals/views/lib/system/event_dispatcher.js | @@ -8,6 +8,7 @@ import ActionManager from './action_manager';
import fallbackViewRegistry from '../compat/fallback-view-registry';
import addJQueryEventDeprecation from './jquery_event_deprecation';
import { contains } from './utils';
+import { JQUERY_INTEGRATION } from '@ember/deprecated-features';
/**
@module ... | true |
Other | emberjs | ember.js | 2aa22eed70030e837dbe2b500b7653653279f25f.json | Add svelte support for jQuery deprecations | packages/@ember/-internals/views/lib/system/jquery.js | @@ -1,11 +1,12 @@
import { context } from '@ember/-internals/environment';
import { hasDOM } from '@ember/-internals/browser-environment';
import { ENV } from '@ember/-internals/environment';
+import { JQUERY_INTEGRATION } from '@ember/deprecated-features';
let jQuery;
-export let jQueryDisabled = ENV._JQUERY_INT... | true |
Other | emberjs | ember.js | 2aa22eed70030e837dbe2b500b7653653279f25f.json | Add svelte support for jQuery deprecations | packages/@ember/-internals/views/lib/system/jquery_event_deprecation.js | @@ -3,9 +3,10 @@ import { deprecate } from '@ember/debug';
import { global } from '@ember/-internals/environment';
import { HAS_NATIVE_PROXY } from '@ember/-internals/utils';
import { DEBUG } from '@glimmer/env';
+import { JQUERY_INTEGRATION } from '@ember/deprecated-features';
export default function addJQueryEv... | true |
Other | emberjs | ember.js | 2aa22eed70030e837dbe2b500b7653653279f25f.json | Add svelte support for jQuery deprecations | packages/@ember/application/lib/application.js | @@ -30,6 +30,7 @@ import Engine from '@ember/engine';
import { privatize as P } from '@ember/-internals/container';
import { setupApplicationRegistry } from '@ember/-internals/glimmer';
import { RouterService } from '@ember/-internals/routing';
+import { JQUERY_INTEGRATION } from '@ember/deprecated-features';
let... | true |
Other | emberjs | ember.js | 2aa22eed70030e837dbe2b500b7653653279f25f.json | Add svelte support for jQuery deprecations | packages/@ember/deprecated-features/index.ts | @@ -9,3 +9,4 @@ export const HANDLER_INFOS = !!'3.9.0';
export const ROUTER_EVENTS = !!'3.9.0';
export const TRANSITION_STATE = !!'3.9.0';
export const COMPONENT_MANAGER_STRING_LOOKUP = !!'4.0.0';
+export const JQUERY_INTEGRATION = !!'3.9.0'; | true |
Other | emberjs | ember.js | 2aa22eed70030e837dbe2b500b7653653279f25f.json | Add svelte support for jQuery deprecations | packages/ember/index.js | @@ -125,7 +125,7 @@ import ApplicationInstance from '@ember/application/instance';
import Engine from '@ember/engine';
import EngineInstance from '@ember/engine/instance';
import { assign, merge } from '@ember/polyfills';
-import { LOGGER, EMBER_EXTEND_PROTOTYPES } from '@ember/deprecated-features';
+import { LOGGER... | true |
Other | emberjs | ember.js | 2861674ec08fe3c5342af5a084d8ae55e09a20e7.json | Remove unused svelte spike code... | broccoli/deprecated-features.js | @@ -52,51 +52,3 @@ function handleExportedDeclaration(d, map) {
}
module.exports = DEPRECATED_FEATURES;
-
-// TODO: remove this, it is primarily just for testing if svelte is working...
-function svelte(infile, outfile) {
- console.log(DEPRECATED_FEATURES); // eslint-disable-line no-console
- const babel = requir... | false |
Other | emberjs | ember.js | 3c00987af16c2e80c81895f6e18cfe10db37387f.json | Ensure Ember.$.ajax works properly.
The recent `Ember.$` deprecation accidentally introduced a regression when
using `Ember.$` as _if_ it were the global `jQuery` object. The
specific scenario that this cropped up in was an application calling
`Ember.$.ajax`. | packages/ember/index.js | @@ -561,19 +561,26 @@ Ember.VERSION = VERSION;
// ****@ember/-internals/views****
if (!views.jQueryDisabled) {
- Ember.$ = function() {
- deprecate(
- "Using Ember.$() has been deprecated, use `import jQuery from 'jquery';` instead",
- false,
- {
- id: 'ember-views.curly-components.jquery-... | true |
Other | emberjs | ember.js | 3c00987af16c2e80c81895f6e18cfe10db37387f.json | Ensure Ember.$.ajax works properly.
The recent `Ember.$` deprecation accidentally introduced a regression when
using `Ember.$` as _if_ it were the global `jQuery` object. The
specific scenario that this cropped up in was an application calling
`Ember.$.ajax`. | packages/ember/tests/reexports_test.js | @@ -2,7 +2,7 @@ import Ember from '../index';
import { FEATURES } from '@ember/canary-features';
import { confirmExport } from 'internal-test-helpers';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
-import { jQueryDisabled } from '@ember/-internals/views';
+import { jQueryDisabled, jQuery } fr... | true |
Other | emberjs | ember.js | 45b1f2e0c40a563471f9b13bdb4c0f73fcd2639c.json | Add v3.7.2 to CHANGELOG.md.
[ci skip] | CHANGELOG.md | @@ -19,6 +19,13 @@
- [#17357](https://github.com/emberjs/ember.js/pull/17357) Allow notifyPropertyChange to be imported from @ember/object
- [#17413](https://github.com/emberjs/ember.js/pull/17413) Fix missing import in instance-initializer blueprint for ember-mocha
+### v3.7.2 (January 22, 2019)
+
+* Upgrade @glim... | false |
Other | emberjs | ember.js | 900028f01704feab6c0411b0efac97db91105c26.json | Add v3.4.8 to CHANGELOG. | CHANGELOG.md | @@ -77,6 +77,13 @@
- [#16978](https://github.com/emberjs/ember.js/pull/16978) [BUGFIX] Properly teardown alias
- [#16877](https://github.com/emberjs/ember.js/pull/16877) [CLEANUP] Allow routes to be named "array" and "object"
+### v3.4.8 (January 22, 2019)
+
+* Upgrade @glimmer/* packages to 0.35.10. Fixes a few is... | false |
Other | emberjs | ember.js | 5a89657ad11d77a7b75ff3a67a06c1c33abb9ae6.json | Add v3.7.1 to CHANGELOG
[ci skip]
(cherry picked from commit dd7a1990eace1a17fcbc99333bfc7e66de768b7c) | CHANGELOG.md | @@ -18,6 +18,10 @@
- [#17357](https://github.com/emberjs/ember.js/pull/17357) Allow notifyPropertyChange to be imported from @ember/object
- [#17413](https://github.com/emberjs/ember.js/pull/17413) Fix missing import in instance-initializer blueprint for ember-mocha
+### v3.7.1 (January 21, 2019)
+
+- [#17461](http... | false |
Other | emberjs | ember.js | bb1953dab05e6f8e3f8ca8f416b8ec983e7678b7.json | Add deprecation for Ember.$()
Deprecated as per RFC386. | packages/ember/index.js | @@ -561,7 +561,18 @@ Ember.VERSION = VERSION;
// ****@ember/-internals/views****
if (!views.jQueryDisabled) {
- Ember.$ = views.jQuery;
+ Ember.$ = function() {
+ deprecate(
+ "Using Ember.$() has been deprecated, use `import jQuery from 'jquery';` instead",
+ false,
+ {
+ id: 'ember-view... | true |
Other | emberjs | ember.js | bb1953dab05e6f8e3f8ca8f416b8ec983e7678b7.json | Add deprecation for Ember.$()
Deprecated as per RFC386. | packages/ember/tests/reexports_test.js | @@ -52,6 +52,21 @@ moduleFor(
}
);
+if (!jQueryDisabled) {
+ moduleFor(
+ 'ember reexports: jQuery enabled',
+ class extends AbstractTestCase {
+ [`@test Ember.$ is exported`](assert) {
+ assert.ok(Ember.$, 'Ember.$ export exists');
+ expectDeprecation(() => {
+ let body = Ember... | true |
Other | emberjs | ember.js | c0b6b95fa000bf87a9109253099325e5f2607aeb.json | Add deprecation for this.$() in curly components
Deprecated as per RFC386. | packages/@ember/-internals/glimmer/tests/integration/components/curly-components-test.js | @@ -3612,6 +3612,8 @@ if (jQueryDisabled) {
class extends RenderingTestCase {
['@test it has a jQuery proxy to the element']() {
let instance;
+ let element1;
+ let element2;
let FooBarComponent = Component.extend({
init() {
@@ -3627,13 +3629,17 @@ if (jQueryDisa... | true |
Other | emberjs | ember.js | c0b6b95fa000bf87a9109253099325e5f2607aeb.json | Add deprecation for this.$() in curly components
Deprecated as per RFC386. | packages/@ember/-internals/glimmer/tests/integration/components/dynamic-components-test.js | @@ -835,6 +835,8 @@ if (jQueryDisabled) {
class extends RenderingTestCase {
['@test it has a jQuery proxy to the element']() {
let instance;
+ let element1;
+ let element2;
let FooBarComponent = Component.extend({
init() {
@@ -850,13 +852,17 @@ if (jQueryDisabled... | true |
Other | emberjs | ember.js | c0b6b95fa000bf87a9109253099325e5f2607aeb.json | Add deprecation for this.$() in curly components
Deprecated as per RFC386. | packages/@ember/-internals/glimmer/tests/integration/components/life-cycle-test.js | @@ -1603,7 +1603,7 @@ if (!jQueryDisabled) {
'Run loop and lifecycle hooks - jQuery only',
class extends RenderingTestCase {
['@test lifecycle hooks have proper access to this.$()'](assert) {
- assert.expect(6);
+ assert.expect(7);
let component;
let FooBarComponent = Co... | true |
Other | emberjs | ember.js | c0b6b95fa000bf87a9109253099325e5f2607aeb.json | Add deprecation for this.$() in curly components
Deprecated as per RFC386. | packages/@ember/-internals/views/lib/mixins/view_support.js | @@ -5,6 +5,7 @@ import { assert } from '@ember/debug';
import { hasDOM } from '@ember/-internals/browser-environment';
import { matches } from '../system/utils';
import { default as jQuery, jQueryDisabled } from '../system/jquery';
+import { deprecate } from '@ember/debug';
function K() {
return this;
@@ -177,... | true |
Other | emberjs | ember.js | fce8b3bf2f9a3bfb559e2ff8e094ad99fb4ec70e.json | Simplify prod tests
* container tests pass in prod build now
* omit ember-testing and @ember/debug tests from ember-tests.prod.js | CONTRIBUTING.md | @@ -280,7 +280,7 @@ Note: before using this approach, please be certain your test is really dependin
To recreate this build environment locally:
* Run `ember serve --environment=production` in a terminal (takes much much longer than a default `ember s`)
-* Browse to `localhost:4200/tests/index.html?skipPackage=cont... | true |
Other | emberjs | ember.js | fce8b3bf2f9a3bfb559e2ff8e094ad99fb4ec70e.json | Simplify prod tests
* container tests pass in prod build now
* omit ember-testing and @ember/debug tests from ember-tests.prod.js | RELEASE.md | @@ -132,9 +132,9 @@ end
1. Any feature that has been GOed gets changed to true
1. Run `ember s -prod`
1. Run tests at `http://localhost:4200/tests/index.html`
-1. Run production tests `http://localhost:4200/tests/index.html?skipPackage=container,ember-testing,@ember/debug&dist=prod&prod=true`
-1. In `.travis.yml... | true |
Other | emberjs | ember.js | fce8b3bf2f9a3bfb559e2ff8e094ad99fb4ec70e.json | Simplify prod tests
* container tests pass in prod build now
* omit ember-testing and @ember/debug tests from ember-tests.prod.js | bin/run-tests.js | @@ -74,20 +74,14 @@ function generateEachPackageTests() {
}
function generateBuiltTests() {
- // Container isn't publicly available.
- // ember-testing and @ember/debug are stripped from prod/min.
- var common = 'skipPackage=container,ember-testing,@ember/debug';
-
- testFunctions.push(() => run(common));
- te... | true |
Other | emberjs | ember.js | fce8b3bf2f9a3bfb559e2ff8e094ad99fb4ec70e.json | Simplify prod tests
* container tests pass in prod build now
* omit ember-testing and @ember/debug tests from ember-tests.prod.js | ember-cli-build.js | @@ -247,6 +247,7 @@ function buildBundles(packagesES, dependenciesES, templateCompilerDependenciesES
'*/tests/**' /* packages */,
'license.js',
],
+ exclude: ['@ember/debug/tests/**', 'ember-testing/tests/**'],
}),
bootstrapModule('empty'),
]); | true |
Other | emberjs | ember.js | 919574fecb2a9a7d649cbe4d46692af193c6b57b.json | Add v3.8.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit a2dd42ffa95182b6c925b88f6c25a6d1a90e2961) | CHANGELOG.md | @@ -1,5 +1,8 @@
# Ember Changelog
+### v3.8.0-beta.2 (January 14, 2019)
+- [#17467](https://github.com/emberjs/ember.js/pull/17467) [BUGFIX] Fix substate interactions with aborts
+
### v3.8.0-beta.1 (January 7, 2019)
- [#17143](https://github.com/emberjs/ember.js/pull/17143) / [#17375](https://github.com/emberjs... | false |
Other | emberjs | ember.js | 480248e8b757625af598b515148052bfba01d4c7.json | use Date.now instead of Number(new Date()) | packages/@ember/-internals/utils/lib/guid.ts | @@ -53,7 +53,7 @@ const NON_OBJECT_GUIDS = new Map();
@type String
@final
*/
-export const GUID_KEY = intern(`__ember${Number(new Date())}`);
+export const GUID_KEY = intern(`__ember${Date.now()}`);
/**
Generates a new guid, optionally saving the guid to the object that you | true |
Other | emberjs | ember.js | 480248e8b757625af598b515148052bfba01d4c7.json | use Date.now instead of Number(new Date()) | packages/@ember/-internals/utils/lib/symbol.ts | @@ -11,7 +11,7 @@ export default function symbol(debugName: string): string {
// TODO: Investigate using platform symbols, but we do not
// want to require non-enumerability for this API, which
// would introduce a large cost.
- let id = GUID_KEY + Math.floor(Math.random() * Number(new Date()));
+ let id = G... | true |
Other | emberjs | ember.js | 480248e8b757625af598b515148052bfba01d4c7.json | use Date.now instead of Number(new Date()) | packages/@ember/runloop/tests/later_test.js | @@ -26,7 +26,7 @@ function wait(callback, maxWaitCount = 100) {
// run loop has to flush, it would have considered
// the timer already expired.
function pauseUntil(time) {
- while (Number(new Date()) < time) {
+ while (Date.now() < time) {
/* do nothing - sleeping */
}
}
@@ -113,7 +113,7 @@ moduleFor(
... | true |
Other | emberjs | ember.js | 39c5eb74d4e12089ae6a8199749947efb44b4c1d.json | use Date.now in time function | packages/@ember/instrumentation/index.ts | @@ -105,14 +105,10 @@ function populateListeners(name: string) {
}
const time = ((): (() => number) => {
- let perf: MaybePerf = 'undefined' !== typeof window ? window.performance || {} : {};
+ let perf: MaybePerf = 'undefined' !== typeof window ? window.performance : {};
let fn = perf.now || perf.mozNow || pe... | false |
Other | emberjs | ember.js | 2648bec5bbcbae51b09376cb386aad364bd2e429.json | Add v3.8.0-beta.1 to CHANGELOG
[ci skip]
(cherry picked from commit 2ddd49bbc5e05b3c68df9b07d0df2cde06a1f2fd) | CHANGELOG.md | @@ -1,5 +1,20 @@
# Ember Changelog
+### v3.8.0-beta.1 (January 7, 2019)
+
+- [#17143](https://github.com/emberjs/ember.js/pull/17143) / [#17375](https://github.com/emberjs/ember.js/pull/17375) [FEATURE] Implement Element Modifier Manager RFC (see [emberjs/rfcs#0373](https://github.com/emberjs/rfcs/blob/master/text/0... | false |
Other | emberjs | ember.js | b025751325a93d61278c96952aaea220da1e8d88.json | Add v3.7.0 to CHANGELOG
[ci skip]
(cherry picked from commit e8261a08115432830cf9abbd8c4b1166d8fe2bbb) | CHANGELOG.md | @@ -1,23 +1,18 @@
# Ember Changelog
-### v3.7.0-beta.3 (December 24, 2018)
+### v3.7.0 (January 7, 2019)
+- [#17254](https://github.com/emberjs/ember.js/pull/17254) [BREAKING] Explicitly drop support for Node 4
+- [#17426](https://github.com/emberjs/ember.js/pull/17426) [BUGFIX] Fix 'strict mode does not allow fun... | false |
Other | emberjs | ember.js | f8364b72102429e0dc0d9ad5b1973a5dc5a87b2f.json | Fix trailing whitespace lint | packages/@ember/polyfills/lib/assign.ts | @@ -17,7 +17,6 @@ export function assign(target: object, ...sources: any[]): any;
var c = { company: 'Other Company' };
var d = { company: 'Tilde Inc.' };
assign(a, b, c, d); // a === { first: 'Yehuda', last: 'Katz', company: 'Tilde Inc.' };
-
```
@method assign | false |
Other | emberjs | ember.js | a9158275054eceed85d6d66b91dd5d01b755c7b8.json | fix issue with overidability of computed.volatile | packages/@ember/-internals/metal/lib/computed.ts | @@ -501,12 +501,11 @@ class ComputedProperty extends Descriptor implements DescriptorWithDependentKeys
/* called before property is overridden */
teardown(obj: object, keyName: string, meta?: any): void {
- if (this._volatile) {
- return;
- }
- let cache = peekCacheFor(obj);
- if (cache !== und... | true |
Other | emberjs | ember.js | a9158275054eceed85d6d66b91dd5d01b755c7b8.json | fix issue with overidability of computed.volatile | packages/@ember/-internals/metal/tests/computed_test.js | @@ -76,6 +76,16 @@ moduleFor(
assert.equal(count, 1, 'should have invoked computed property');
}
+ ['@test can override volatile computed property'](assert) {
+ let obj = {};
+
+ defineProperty(obj, 'foo', computed(function() {}).volatile());
+
+ set(obj, 'foo', 'boom');
+
+ assert.... | true |
Other | emberjs | ember.js | cbbc4c4fd014823df44fbdf2eceaec3520014beb.json | Resolve path names correctly | packages/@ember/-internals/metal/lib/property_get.ts | @@ -96,6 +96,10 @@ export function get(obj: object, keyName: string): any {
let isFunction = type === 'function';
let isObjectLike = isObject || isFunction;
+ if (isPath(keyName)) {
+ return isObjectLike ? _getPath(obj, keyName) : undefined;
+ }
+
let value: any;
if (isObjectLike) {
@@ -119,9 +123,... | false |
Other | emberjs | ember.js | 5cf65438ca86ed4a3411ce29028509e0ccd0e74c.json | Use Map() for descriptor store | packages/@ember/-internals/meta/lib/meta.ts | @@ -92,7 +92,7 @@ type Listener = RemoveAllListener | StringListener | FunctionListener;
let currentListenerVersion = 1;
export class Meta {
- _descriptors: any | undefined;
+ _descriptors: Map<string, any> | undefined;
_watching: any | undefined;
_mixins: any | undefined;
_deps: any | undefined;
@@ -256... | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.