language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
emberjs
ember.js
6c3ac7ca39a33c1c478080f1412aeb311d2019e5.json
Fix types due to `owner.lookup` type changes We explicitly added `| undefined` to the return type in the previous commit Co-authored-by: Robert Jackson <me@rwjblue.com>
packages/@ember/-internals/glimmer/lib/component-managers/curly.ts
@@ -119,27 +119,28 @@ export default class CurlyComponentManager }; } - templateFor(component: Component): OwnedTemplate { - let { layout: _layout, layoutName } = component; + protected templateFor(component: Component): OwnedTemplate { + let { layout, layoutName } = component; let owner = getOwn...
true
Other
emberjs
ember.js
6c3ac7ca39a33c1c478080f1412aeb311d2019e5.json
Fix types due to `owner.lookup` type changes We explicitly added `| undefined` to the return type in the previous commit Co-authored-by: Robert Jackson <me@rwjblue.com>
packages/@ember/-internals/routing/lib/location/auto_location.ts
@@ -99,12 +99,11 @@ export default class AutoLocation extends EmberObject implements EmberLocation { implementation = 'none'; } - let concrete = getOwner(this).lookup(`location:${implementation}`); - set(concrete, 'rootURL', rootURL); + let concrete = getOwner(this).lookup<EmberLocation>(`locatio...
true
Other
emberjs
ember.js
6c3ac7ca39a33c1c478080f1412aeb311d2019e5.json
Fix types due to `owner.lookup` type changes We explicitly added `| undefined` to the return type in the previous commit Co-authored-by: Robert Jackson <me@rwjblue.com>
packages/@ember/-internals/routing/lib/system/generate_controller.ts
@@ -1,5 +1,6 @@ import { get } from '@ember/-internals/metal'; import { Factory, Owner } from '@ember/-internals/owner'; +import Controller from '@ember/controller'; import { info } from '@ember/debug'; import { DEBUG } from '@glimmer/env'; /** @@ -39,11 +40,11 @@ export function generateControllerFactory(owner: O...
true
Other
emberjs
ember.js
6c3ac7ca39a33c1c478080f1412aeb311d2019e5.json
Fix types due to `owner.lookup` type changes We explicitly added `| undefined` to the return type in the previous commit Co-authored-by: Robert Jackson <me@rwjblue.com>
packages/@ember/-internals/routing/lib/system/route.ts
@@ -18,6 +18,7 @@ import { typeOf, } from '@ember/-internals/runtime'; import { EMBER_FRAMEWORK_OBJECT_OWNER_ARGUMENT } from '@ember/canary-features'; +import Controller from '@ember/controller'; import { assert, deprecate, info, isTesting } from '@ember/debug'; import { ROUTER_EVENTS } from '@ember/deprecated-f...
true
Other
emberjs
ember.js
6c3ac7ca39a33c1c478080f1412aeb311d2019e5.json
Fix types due to `owner.lookup` type changes We explicitly added `| undefined` to the return type in the previous commit Co-authored-by: Robert Jackson <me@rwjblue.com>
packages/@ember/-internals/routing/lib/system/router.ts
@@ -150,7 +150,7 @@ class EmberRouter extends EmberObject { let seen = Object.create(null); class PrivateRouter extends Router<Route> { - getRoute(name: string) { + getRoute(name: string): Route { let routeName = name; let routeOwner = owner; let engineInfo = router._eng...
true
Other
emberjs
ember.js
6c3ac7ca39a33c1c478080f1412aeb311d2019e5.json
Fix types due to `owner.lookup` type changes We explicitly added `| undefined` to the return type in the previous commit Co-authored-by: Robert Jackson <me@rwjblue.com>
packages/@ember/controller/index.d.ts
@@ -0,0 +1,8 @@ +export default interface Controller { + isController: true; + target?: unknown; + store?: unknown; + model?: unknown; +} + +export function inject(name?: string): Controller;
true
Other
emberjs
ember.js
de4234af72a6ce14b539baf1b5a1e1c273f8c03f.json
Add v3.12.0-beta.1 to CHANGELOG [ci skip] (cherry picked from commit e5d5133746a5495cd99f54a38fc94a27657a7ed7)
CHANGELOG.md
@@ -1,5 +1,11 @@ # Ember Changelog +# v3.12.0-beta.1 (June 27, 2019) + +- [#17406](https://github.com/emberjs/ember.js/pull/17406) [BUGFIX] Properties observed through `Ember.Observer` can be set to `undefined` +- [#18150](https://github.com/emberjs/ember.js/pull/18150) [BUGFIX] Fix a memory retention issue with str...
false
Other
emberjs
ember.js
b9a7e031df1c588453feac1f9b003c95d0ed995b.json
Add v3.11.0 to CHANGELOG [ci skip] (cherry picked from commit cc2d5ece206b1e64025cdb036b420a4c3d64724d)
CHANGELOG.md
@@ -1,29 +1,16 @@ # Ember Changelog -### v3.11.0-beta.4 (June 17, 2019) - -- [#17971](https://github.com/emberjs/ember.js/pull/17971) [BUGFIX] Ensure query param only link-to's work in error states. - -### v3.11.0-beta.3 (June 10, 2019) - -- [#18080](https://github.com/emberjs/ember.js/pull/18080) [BUGFIX] Fix `embe...
false
Other
emberjs
ember.js
68ef63c7b2307ba35034132aa36a26cabc61fd0a.json
remove usage of `get` helpers in location classes (#18123) remove usage of `get` helpers in location classes
packages/@ember/-internals/routing/lib/location/api.ts
@@ -1,4 +1,3 @@ -import { location } from '@ember/-internals/browser-environment'; import { assert } from '@ember/debug'; export interface EmberLocation { @@ -111,5 +110,4 @@ export default { }, implementations: {}, - _location: location, };
true
Other
emberjs
ember.js
68ef63c7b2307ba35034132aa36a26cabc61fd0a.json
remove usage of `get` helpers in location classes (#18123) remove usage of `get` helpers in location classes
packages/@ember/-internals/routing/lib/location/auto_location.ts
@@ -1,10 +1,9 @@ import { history, location, userAgent, window } from '@ember/-internals/browser-environment'; -import { get, set } from '@ember/-internals/metal'; +import { set } from '@ember/-internals/metal'; import { getOwner } from '@ember/-internals/owner'; import { Object as EmberObject } from '@ember/-intern...
true
Other
emberjs
ember.js
68ef63c7b2307ba35034132aa36a26cabc61fd0a.json
remove usage of `get` helpers in location classes (#18123) remove usage of `get` helpers in location classes
packages/@ember/-internals/routing/lib/location/hash_location.ts
@@ -1,7 +1,6 @@ -import { get, set } from '@ember/-internals/metal'; -import { bind } from '@ember/runloop'; - +import { set } from '@ember/-internals/metal'; import { Object as EmberObject } from '@ember/-internals/runtime'; +import { bind } from '@ember/runloop'; import { EmberLocation, UpdateCallback } from './api...
true
Other
emberjs
ember.js
68ef63c7b2307ba35034132aa36a26cabc61fd0a.json
remove usage of `get` helpers in location classes (#18123) remove usage of `get` helpers in location classes
packages/@ember/-internals/routing/lib/location/history_location.ts
@@ -1,5 +1,4 @@ -import { get, set } from '@ember/-internals/metal'; - +import { set } from '@ember/-internals/metal'; import { Object as EmberObject } from '@ember/-internals/runtime'; import { EmberLocation, UpdateCallback } from './api'; import { getHash } from './util'; @@ -68,7 +67,7 @@ export default class His...
true
Other
emberjs
ember.js
68ef63c7b2307ba35034132aa36a26cabc61fd0a.json
remove usage of `get` helpers in location classes (#18123) remove usage of `get` helpers in location classes
packages/@ember/-internals/routing/lib/location/none_location.ts
@@ -1,4 +1,4 @@ -import { get, set } from '@ember/-internals/metal'; +import { set } from '@ember/-internals/metal'; import { Object as EmberObject } from '@ember/-internals/runtime'; import { assert } from '@ember/debug'; import { EmberLocation, UpdateCallback } from './api'; @@ -26,7 +26,7 @@ export default class ...
true
Other
emberjs
ember.js
e3cf6cae68497c5006b2579522c5035d5d25d4c0.json
Add v3.11.0-beta.4 to CHANGELOG [ci skip] (cherry picked from commit 2f7f91d168f2705c4d90b339607124deaa054450)
CHANGELOG.md
@@ -1,5 +1,9 @@ # Ember Changelog +### v3.11.0-beta.4 (June 17, 2019) + +- [#17971](https://github.com/emberjs/ember.js/pull/17971) [BUGFIX] Ensure query param only link-to's work in error states. + ### v3.11.0-beta.3 (June 10, 2019) - [#18080](https://github.com/emberjs/ember.js/pull/18080) [BUGFIX] Fix `ember-...
false
Other
emberjs
ember.js
8ead9d08387c460c9d70079b5fbe8fc2bee2ef38.json
Add v3.10.2 to CHANGELOG.md. [ci skip]
CHANGELOG.md
@@ -21,6 +21,10 @@ - [#17940](https://github.com/emberjs/ember.js/pull/17940) [CLEANUP] Remove `sync` queue from @ember/runloop. - [#18026](https://github.com/emberjs/ember.js/pull/18026) Enabling featured discussed in 2019-05-03 core team meeting. +### v3.10.2 (June 17, 2019) + +- [#17971](https://github.com/ember...
false
Other
emberjs
ember.js
de467207177d67d9b2b8a23a81046b4a8cb84574.json
Update documentation for currentRoute
packages/@ember/-internals/routing/lib/services/router.ts
@@ -439,7 +439,7 @@ RouterService.reopen(Evented, { the application, '/' by default. This prefix is assumed on all routes defined on this app. - IF you change the `rootURL` in your environment configuration + If you change the `rootURL` in your environment configuration like so: ```config/...
false
Other
emberjs
ember.js
d7a2737078dbb389b5ec2356512be9680076a9fd.json
Add v3.11.0-beta.3 to CHANGELOG [ci skip] (cherry picked from commit 68c69e7819c2f8e545185ed28a772bddf3117538)
CHANGELOG.md
@@ -1,5 +1,10 @@ # Ember Changelog +### v3.11.0-beta.3 (June 10, 2019) + +- [#18080](https://github.com/emberjs/ember.js/pull/18080) [BUGFIX] Fix `ember-template-compiler` compatibility with Fastboot. +- [#18071](https://github.com/emberjs/ember.js/pull/18071) [BUGFIX] Ensure modifiers do not run in FastBoot modes. ...
false
Other
emberjs
ember.js
1664f6fcdd30667b25b9fd46058560c081adae73.json
Fix function name in documentation example Renamed `this.args.selected` to `this.args.select`
packages/@ember/-internals/glimmer/lib/helpers/fn.ts
@@ -49,7 +49,7 @@ const context = buildUntouchableThis('`fn` helper'); - When invoked as `this.args.select()` the `handleSelected` function will receive the `item` from the loop as its first and only argument. - - When invoked as `this.args.selected('foo')` the `handleSelected` function + - When invoked as ...
false
Other
emberjs
ember.js
25fd4829145e454ffaae02151f5511bf13b49cfd.json
Add v3.10.1 to CHANGELOG.md. [ci skip]
CHANGELOG.md
@@ -16,6 +16,10 @@ - [#17940](https://github.com/emberjs/ember.js/pull/17940) [CLEANUP] Remove `sync` queue from @ember/runloop. - [#18026](https://github.com/emberjs/ember.js/pull/18026) Enabling featured discussed in 2019-05-03 core team meeting. +### v3.10.1 (June 4, 2019) + +- [#18071](https://github.com/emberj...
false
Other
emberjs
ember.js
5eca0045b4ef3606923e4b124034f6063a813b6f.json
Add v3.8.2 to CHANGELOG.md. [ci skip]
CHANGELOG.md
@@ -50,6 +50,13 @@ - [#17874](https://github.com/emberjs/ember.js/pull/17874) [BUGFIX] Fix issue with `event.stopPropagation()` in component event handlers when jQuery is disabled. - [#17876](https://github.com/emberjs/ember.js/pull/17876) [BUGFIX] Fix issue with multiple `{{action}}` modifiers on the same element wh...
false
Other
emberjs
ember.js
16f9cd2905865c112e05859b6c56e68ac9cf1497.json
Add v3.11.0-beta.2 to CHANGELOG [ci skip] (cherry picked from commit 934d74fef88db9e1c0719c5225a0debf4794fe00)
CHANGELOG.md
@@ -1,5 +1,9 @@ # Ember Changelog +### v3.11.0-beta.2 (June 3, 2019) + +- [#18064](https://github.com/emberjs/ember.js/pull/18064) [BUGFIX] Fix 'hasAttribute is not a function' when jQuery is disabled + ### v3.11.0-beta.1 (May 13, 2019) - [#17842](https://github.com/emberjs/ember.js/pull/17842) / [#17901](https:...
false
Other
emberjs
ember.js
e039f3f7fda6f640eeab3e322d1587b415ebc40a.json
Fix links in documentation Documentation links were pointing at `/api/`, when the Ember documentation does not live at https://api.emberjs.com under that path. Thus all these links have been broken. And correct a few broken for other reasons.
packages/@ember/-internals/glimmer/index.ts
@@ -63,14 +63,16 @@ )}}></span> ``` - Ember's built-in helpers are described under the [Ember.Templates.helpers](/api/ember/release/classes/Ember.Templates.helpers) + Ember's built-in helpers are described under the [Ember.Templates.helpers](/ember/release/classes/Ember.Templates.helpers) namespace. Docume...
true
Other
emberjs
ember.js
e039f3f7fda6f640eeab3e322d1587b415ebc40a.json
Fix links in documentation Documentation links were pointing at `/api/`, when the Ember documentation does not live at https://api.emberjs.com under that path. Thus all these links have been broken. And correct a few broken for other reasons.
packages/@ember/-internals/glimmer/lib/component.ts
@@ -372,7 +372,7 @@ export const BOUNDS = symbol('BOUNDS'); will be removed. Both `classNames` and `classNameBindings` are concatenated properties. See - [EmberObject](/api/ember/release/classes/EmberObject) documentation for more + [EmberObject](/ember/release/classes/EmberObject) documentation for more i...
true
Other
emberjs
ember.js
e039f3f7fda6f640eeab3e322d1587b415ebc40a.json
Fix links in documentation Documentation links were pointing at `/api/`, when the Ember documentation does not live at https://api.emberjs.com under that path. Thus all these links have been broken. And correct a few broken for other reasons.
packages/@ember/-internals/glimmer/lib/components/checkbox.ts
@@ -12,7 +12,7 @@ import layout from '../templates/empty'; The internal class used to create text inputs when the `{{input}}` helper is used with `type` of `checkbox`. - See [Ember.Templates.helpers.input](/api/ember/release/classes/Ember.Templates.helpers/methods/input?anchor=input) for usage details. + See...
true
Other
emberjs
ember.js
e039f3f7fda6f640eeab3e322d1587b415ebc40a.json
Fix links in documentation Documentation links were pointing at `/api/`, when the Ember documentation does not live at https://api.emberjs.com under that path. Thus all these links have been broken. And correct a few broken for other reasons.
packages/@ember/-internals/glimmer/lib/components/input.ts
@@ -11,7 +11,7 @@ let Input: any; if (EMBER_GLIMMER_ANGLE_BRACKET_BUILT_INS) { /** - See [Ember.Templates.components.Input](/api/ember/release/classes/Ember.Templates.components/methods/Input?anchor=Input). + See [Ember.Templates.components.Input](/ember/release/classes/Ember.Templates.components/methods/In...
true
Other
emberjs
ember.js
e039f3f7fda6f640eeab3e322d1587b415ebc40a.json
Fix links in documentation Documentation links were pointing at `/api/`, when the Ember documentation does not live at https://api.emberjs.com under that path. Thus all these links have been broken. And correct a few broken for other reasons.
packages/@ember/-internals/glimmer/lib/components/link-to.ts
@@ -1165,7 +1165,7 @@ if (EMBER_GLIMMER_ANGLE_BRACKET_BUILT_INS) { {{/link-to}} ``` - See [LinkComponent](/api/ember/release/classes/LinkComponent) for a + See [LinkComponent](/ember/release/classes/LinkComponent) for a complete list of overrideable properties. Be sure to also check out inhe...
true
Other
emberjs
ember.js
e039f3f7fda6f640eeab3e322d1587b415ebc40a.json
Fix links in documentation Documentation links were pointing at `/api/`, when the Ember documentation does not live at https://api.emberjs.com under that path. Thus all these links have been broken. And correct a few broken for other reasons.
packages/@ember/-internals/glimmer/lib/components/text-field.ts
@@ -33,7 +33,7 @@ function canSetTypeOfInput(type: string): boolean { /** The internal class used to create text inputs when the `Input` component is used with `type` of `text`. - See [Ember.Templates.components.Input](/api/ember/release/classes/Ember.Templates.components/methods/Input?anchor=Input) for usage de...
true
Other
emberjs
ember.js
e039f3f7fda6f640eeab3e322d1587b415ebc40a.json
Fix links in documentation Documentation links were pointing at `/api/`, when the Ember documentation does not live at https://api.emberjs.com under that path. Thus all these links have been broken. And correct a few broken for other reasons.
packages/@ember/-internals/glimmer/lib/helpers/action.ts
@@ -87,7 +87,7 @@ import { ACTION, INVOKE, UnboundReference } from '../utils/references'; Closure actions curry both their scope and any arguments. When invoked, any additional arguments are added to the already curried list. - Actions should be invoked using the [sendAction](/api/ember/release/classes/Compone...
true
Other
emberjs
ember.js
e039f3f7fda6f640eeab3e322d1587b415ebc40a.json
Fix links in documentation Documentation links were pointing at `/api/`, when the Ember documentation does not live at https://api.emberjs.com under that path. Thus all these links have been broken. And correct a few broken for other reasons.
packages/@ember/-internals/glimmer/lib/helpers/component.ts
@@ -4,7 +4,7 @@ /** The `{{component}}` helper lets you add instances of `Component` to a - template. See [Component](/api/ember/release/classes/Component) for + template. See [Component](/ember/release/classes/Component) for additional information on how a `Component` functions. `{{component}}`'s primary...
true
Other
emberjs
ember.js
e039f3f7fda6f640eeab3e322d1587b415ebc40a.json
Fix links in documentation Documentation links were pointing at `/api/`, when the Ember documentation does not live at https://api.emberjs.com under that path. Thus all these links have been broken. And correct a few broken for other reasons.
packages/@ember/-internals/glimmer/lib/helpers/loc.ts
@@ -6,7 +6,7 @@ import { loc } from '@ember/string'; import { helper } from '../helper'; /** - Calls [loc](/api/classes/Ember.String.html#method_loc) with the + Calls [String.loc](/ember/release/classes/String/methods/loc?anchor=loc) with the provided string. This is a convenient way to localize text within a ...
true
Other
emberjs
ember.js
e039f3f7fda6f640eeab3e322d1587b415ebc40a.json
Fix links in documentation Documentation links were pointing at `/api/`, when the Ember documentation does not live at https://api.emberjs.com under that path. Thus all these links have been broken. And correct a few broken for other reasons.
packages/@ember/-internals/glimmer/lib/syntax/input.ts
@@ -29,7 +29,7 @@ if (EMBER_GLIMMER_ANGLE_BRACKET_BUILT_INS) { /** The `{{input}}` helper lets you create an HTML `<input />` component. It causes a `TextField` component to be rendered. For more info, - see the [TextField](/api/ember/release/classes/TextField) docs and + see the [TextField](/ember/...
true
Other
emberjs
ember.js
e039f3f7fda6f640eeab3e322d1587b415ebc40a.json
Fix links in documentation Documentation links were pointing at `/api/`, when the Ember documentation does not live at https://api.emberjs.com under that path. Thus all these links have been broken. And correct a few broken for other reasons.
packages/@ember/-internals/routing/lib/ext/controller.ts
@@ -136,7 +136,7 @@ ControllerMixin.reopen({ aController.transitionToRoute({ queryParams: { sort: 'date' } }); ``` - See also [replaceRoute](/api/ember/release/classes/Ember.ControllerMixin/methods/replaceRoute?anchor=replaceRoute). + See also [replaceRoute](/ember/release/classes/Ember.ControllerMixi...
true
Other
emberjs
ember.js
e039f3f7fda6f640eeab3e322d1587b415ebc40a.json
Fix links in documentation Documentation links were pointing at `/api/`, when the Ember documentation does not live at https://api.emberjs.com under that path. Thus all these links have been broken. And correct a few broken for other reasons.
packages/@ember/-internals/routing/lib/location/api.ts
@@ -27,10 +27,10 @@ export type UpdateCallback = (url: string) => void; You can pass an implementation name (`hash`, `history`, `none`, `auto`) to force a particular implementation to be used in your application. - See [HashLocation](/api/ember/release/classes/HashLocation). - See [HistoryLocation](/api/ember...
true
Other
emberjs
ember.js
e039f3f7fda6f640eeab3e322d1587b415ebc40a.json
Fix links in documentation Documentation links were pointing at `/api/`, when the Ember documentation does not live at https://api.emberjs.com under that path. Thus all these links have been broken. And correct a few broken for other reasons.
packages/@ember/-internals/routing/lib/services/router.ts
@@ -84,7 +84,7 @@ export default class RouterService extends Service { Transition the application into another route. The route may be either a single route or route path: - See [transitionTo](/api/ember/release/classes/Route/methods/transitionTo?anchor=transitionTo) for more info. + See [transiti...
true
Other
emberjs
ember.js
e039f3f7fda6f640eeab3e322d1587b415ebc40a.json
Fix links in documentation Documentation links were pointing at `/api/`, when the Ember documentation does not live at https://api.emberjs.com under that path. Thus all these links have been broken. And correct a few broken for other reasons.
packages/@ember/-internals/routing/lib/system/router.ts
@@ -497,7 +497,7 @@ class EmberRouter extends EmberObject { Transition the application into another route. The route may be either a single route or route path: - See [transitionTo](/api/ember/release/classes/Route/methods/transitionTo?anchor=transitionTo) for more info. + See [transitionTo](/ember/re...
true
Other
emberjs
ember.js
e039f3f7fda6f640eeab3e322d1587b415ebc40a.json
Fix links in documentation Documentation links were pointing at `/api/`, when the Ember documentation does not live at https://api.emberjs.com under that path. Thus all these links have been broken. And correct a few broken for other reasons.
packages/@ember/-internals/runtime/lib/ext/function.js
@@ -68,7 +68,7 @@ if (FUNCTION_PROTOTYPE_EXTENSIONS && ENV.EXTEND_PROTOTYPES.Function) { will instead clear the cache so that it is updated when the next `get` is called on the property. - See [ComputedProperty](/api/ember/release/classes/ComputedProperty), [@ember/object/computed](/api/ember/relea...
true
Other
emberjs
ember.js
e039f3f7fda6f640eeab3e322d1587b415ebc40a.json
Fix links in documentation Documentation links were pointing at `/api/`, when the Ember documentation does not live at https://api.emberjs.com under that path. Thus all these links have been broken. And correct a few broken for other reasons.
packages/@ember/string/index.ts
@@ -281,7 +281,7 @@ export function capitalize(str: string): string { if (ENV.EXTEND_PROTOTYPES.String) { Object.defineProperties(String.prototype, { /** - See [String.w](/api/ember/release/classes/String/methods/w?anchor=w). + See [String.w](/ember/release/classes/String/methods/w?anchor=w). ...
true
Other
emberjs
ember.js
d418c4f69ccb53dcb924f49c5b29fc26e637431e.json
update license to 2019
LICENSE
@@ -1,4 +1,4 @@ -Copyright (c) 2018 Yehuda Katz, Tom Dale and Ember.js contributors +Copyright (c) 2019 Yehuda Katz, Tom Dale and Ember.js contributors Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in
true
Other
emberjs
ember.js
d418c4f69ccb53dcb924f49c5b29fc26e637431e.json
update license to 2019
generators/license.js
@@ -1,6 +1,6 @@ /*! * @overview Ember - JavaScript Application Framework - * @copyright Copyright 2011-2018 Tilde Inc. and contributors + * @copyright Copyright 2011-2019 Tilde Inc. and contributors * Portions Copyright 2006-2011 Strobe Inc. * Portions Copyright 2008-2011 Apple Inc. All ri...
true
Other
emberjs
ember.js
5d3da3d783a66ffd533058ba5303d54d469776d5.json
improve tests scenarios on link-to
packages/@ember/-internals/glimmer/tests/integration/components/link-to/query-params-curly-test.js
@@ -41,6 +41,21 @@ moduleFor( }); } + ['@test populates href with fully supplied query param values, but without @route param']() { + this.addTemplate( + 'index', + `{{#link-to (query-params foo='2' bar='NAW')}}QueryParams{{/link-to}}` + ); + + return this.visit('/').then((...
false
Other
emberjs
ember.js
106bb03e87f982657edd4595652579bfeae3f06a.json
Bring release branch change to master (#18027) Bring release branch change to master Co-authored-by: Lukas Kohler <lux@lux.name>
packages/@ember/-internals/routing/lib/services/router.ts
@@ -46,7 +46,7 @@ function cleanURL(url: string, rootURL: string) { actions: { next() { - this.get('router').transitionTo('other.route'); + this.router.transitionTo('other.route'); } } });
false
Other
emberjs
ember.js
3ef8521abb10cab42587d8bf058bd3035acb7228.json
Add v3.11.0-beta.1 to CHANGELOG [ci skip] (cherry picked from commit 1bf5cec780787406b10fd201c2dddb9cdbff8d6d)
CHANGELOG.md
@@ -1,5 +1,18 @@ # Ember Changelog +### v3.11.0-beta.1 (May 13, 2019) + +- [#17842](https://github.com/emberjs/ember.js/pull/17842) / [#17901](https://github.com/emberjs/ember.js/pull/17901) [FEATURE] Implement the [Forwarding Element Modifiers with "Splattributes" RFC](https://github.com/emberjs/rfcs/blob/master/te...
false
Other
emberjs
ember.js
24e4292d0720bdad45c84b5cb30f0e7ea6d391cd.json
Add v3.10.0 to CHANGELOG [ci skip] (cherry picked from commit 358a4c7a3fb1d76b6871a54295f363294bbc4a65)
CHANGELOG.md
@@ -1,54 +1,37 @@ # Ember Changelog -### v3.10.0-beta.5 (April 29, 2019) +### v3.10.0 (May 13, 2019) +- [#17836](https://github.com/emberjs/ember.js/pull/17836) [BREAKING] Explicitly drop support for Node 6 +- [#17719](https://github.com/emberjs/ember.js/pull/17719) / [#17745](https://github.com/emberjs/ember.js/p...
false
Other
emberjs
ember.js
847877e737a328ae45e731b03dccf33bc0b58471.json
Add DISABLE_MINIFICATION environment variable. (#18005) Add DISABLE_MINIFICATION environment variable.
ember-cli-build.js
@@ -278,7 +278,7 @@ function buildBundles(packagesES, dependenciesES, templateCompilerDependenciesES return new MergeTrees( [ emberProdBundle, - emberMinBundle, + process.env.DISABLE_MINIFICATION !== '1' && emberMinBundle, emberProdTestsBundle, buildBundle('ember.debug.js', emberD...
false
Other
emberjs
ember.js
57da44f58a519f4eb7493610065ddbc17d944c13.json
Add DISABLE_MINIFICATION environment variable. This makes testing production (but not minified) builds a bit faster.
ember-cli-build.js
@@ -278,7 +278,7 @@ function buildBundles(packagesES, dependenciesES, templateCompilerDependenciesES return new MergeTrees( [ emberProdBundle, - emberMinBundle, + process.env.DISABLE_MINIFICATION !== '1' && emberMinBundle, emberProdTestsBundle, buildBundle('ember.debug.js', emberD...
false
Other
emberjs
ember.js
574dccda8ba30dc3dac8701ccce0f831690aad0a.json
fix position of @module doc for Engine
packages/@ember/engine/index.js
@@ -1,7 +1,3 @@ -/** -@module @ember/engine -*/ - export { getEngineParent, setEngineParent } from './lib/engine-parent'; import { canInvoke } from '@ember/-internals/utils'; @@ -28,6 +24,10 @@ function props(obj) { return properties; } +/** +@module @ember/engine +*/ + /** The `Engine` class contains cor...
false
Other
emberjs
ember.js
642702dd726420f3cb5a8f4622662aac4df15e1c.json
Add v3.10.0-beta.5 to CHANGELOG [ci skip] (cherry picked from commit 53f84b111eea80da33eefb7f9e87da1a563e8d02)
CHANGELOG.md
@@ -1,5 +1,10 @@ # Ember Changelog +### v3.10.0-beta.5 (April 29, 2019) + +- [#17938](https://github.com/emberjs/ember.js/pull/17938) [BUGFIX] Expose mechanism to detect if a property is a computed +- [#17974](https://github.com/emberjs/ember.js/pull/17974) [BUGFIX] Ensure inheritable observers on object proxies are...
false
Other
emberjs
ember.js
663d2098f8c50b5cb056735b0e185078243538f9.json
Add documentation for `fn`.
packages/@ember/-internals/glimmer/lib/helpers/fn.ts
@@ -7,6 +7,79 @@ import { InternalHelperReference, INVOKE } from '../utils/references'; import buildUntouchableThis from '../utils/untouchable-this'; const context = buildUntouchableThis('`fn` helper'); + +/** +@module ember +*/ + +/** + The `fn` helper allows you to ensure a function that you are passing off + t...
true
Other
emberjs
ember.js
663d2098f8c50b5cb056735b0e185078243538f9.json
Add documentation for `fn`.
packages/@ember/-internals/glimmer/lib/helpers/get.ts
@@ -40,16 +40,16 @@ import { CachedReference, referenceFromParts, UPDATE } from '../utils/references ```handlebars {{get person factName}} - <button {{action (action (mut factName)) "height"}}>Show height</button> - <button {{action (action (mut factName)) "weight"}}>Show weight</button> + <button {{action (...
true
Other
emberjs
ember.js
663d2098f8c50b5cb056735b0e185078243538f9.json
Add documentation for `fn`.
packages/@ember/-internals/glimmer/lib/helpers/mut.ts
@@ -13,7 +13,7 @@ import { INVOKE, UPDATE } from '../utils/references'; To specify that a parameter is mutable, when invoking the child `Component`: ```handlebars - <MyChild @childClickCount={{action (mut totalClicks)}} /> + <MyChild @childClickCount={{fn (mut totalClicks)}} /> ``` or @@ -37,20 +37,2...
true
Other
emberjs
ember.js
663d2098f8c50b5cb056735b0e185078243538f9.json
Add documentation for `fn`.
tests/docs/expected.js
@@ -217,6 +217,7 @@ module.exports = { 'findModel', 'findWithAssert', 'firstObject', + 'fn', 'focusIn', 'focusOut', 'followRedirects',
true
Other
emberjs
ember.js
33fdfdc02c8adf9eaace5ac223b2ed2d072984bb.json
Fix import ordering lint
packages/@ember/-internals/glimmer/lib/helpers/fn.ts
@@ -3,8 +3,8 @@ import { assert } from '@ember/debug'; import { DEBUG } from '@glimmer/env'; import { Arguments, VM } from '@glimmer/runtime'; import { ICapturedArguments } from '@glimmer/runtime/dist/types/lib/vm/arguments'; -import { InternalHelperReference } from '../utils/references'; import { Opaque } from '@g...
false
Other
emberjs
ember.js
495c93178a08c5a800ef9b254349810a560b7c1c.json
add promise polyfill
broccoli/test-polyfills.js
@@ -7,8 +7,9 @@ module.exports = function polyfills() { let polyfillEntry = writeFile( 'polyfill-entry.js', ` + require('core-js/modules/es6.promise'); require('core-js/modules/es6.symbol'); - require('regenerator-runtime/runtime') + require('regenerator-runtime/runtime'); ` )...
true
Other
emberjs
ember.js
495c93178a08c5a800ef9b254349810a560b7c1c.json
add promise polyfill
packages/@ember/-internals/glimmer/tests/integration/components/link-to/query-params-curly-test.js
@@ -1,6 +1,7 @@ import Controller from '@ember/controller'; import { RSVP } from '@ember/-internals/runtime'; import { Route } from '@ember/-internals/routing'; +import { DEBUG } from '@glimmer/env'; import { ApplicationTestCase, classes as classMatcher, @@ -59,8 +60,12 @@ moduleFor( `{{#let (query-p...
true
Other
emberjs
ember.js
495c93178a08c5a800ef9b254349810a560b7c1c.json
add promise polyfill
packages/ember/tests/routing/decoupled_basic_test.js
@@ -844,9 +844,11 @@ moduleFor( }) ); - this.handleURLRejectsWith(this, assert, '/specials/1', 'Setup error'); + let promise = this.handleURLRejectsWith(this, assert, '/specials/1', 'Setup error'); resolve(menuItem); + + return promise; } ['@test Moving from one pag...
true
Other
emberjs
ember.js
495c93178a08c5a800ef9b254349810a560b7c1c.json
add promise polyfill
packages/ember/tests/routing/query_params_test.js
@@ -312,8 +312,6 @@ moduleFor( } async ['@test error is thrown if dynamic segment and query param have same name'](assert) { - assert.expect(1); - this.router.map(function() { this.route('index', { path: '/:foo' }); });
true
Other
emberjs
ember.js
ed4fb96f14e8acc360c253e8bdad8ce72b443807.json
Add v3.10.0-beta.4 to CHANGELOG [ci skip] (cherry picked from commit 44de6b6db263c55d8a6ea5997d7b0cdb10562002)
CHANGELOG.md
@@ -1,5 +1,9 @@ # Ember Changelog +### v3.10.0-beta.4 (April 22, 2019) + +- [#17930](https://github.com/emberjs/ember.js/pull/17930) [BUGFIX] Update assertion for events in tagless component to include method names + ### v3.10.0-beta.3 (April 15, 2019) - [#17859](https://github.com/emberjs/ember.js/pull/17859) [...
false
Other
emberjs
ember.js
0f6afed29de363bfe755dd229e6ce43d7aed1051.json
add unstable args test
packages/@ember/-internals/glimmer/tests/integration/components/tracked-test.js
@@ -1,5 +1,9 @@ -import { EMBER_METAL_TRACKED_PROPERTIES } from '@ember/canary-features'; import { Object as EmberObject, A } from '@ember/-internals/runtime'; +import { + EMBER_CUSTOM_COMPONENT_ARG_PROXY, + EMBER_METAL_TRACKED_PROPERTIES, +} from '@ember/canary-features'; +import { Object as EmberObject } from '@em...
false
Other
emberjs
ember.js
e29a526b3c3a785b2830df2b55679667e9f0f24e.json
remove function export from helper blueprint
blueprints/helper/files/__root__/__collection__/__name__.js
@@ -1,7 +1,5 @@ import { helper } from '@ember/component/helper'; -export function <%= camelizedModuleName %>(params/*, hash*/) { +export default helper(function <%= camelizedModuleName %>(params/*, hash*/) { return params; -} - -export default helper(<%= camelizedModuleName %>); +});
true
Other
emberjs
ember.js
e29a526b3c3a785b2830df2b55679667e9f0f24e.json
remove function export from helper blueprint
node-tests/fixtures/helper/helper.js
@@ -1,7 +1,5 @@ import { helper } from '@ember/component/helper'; -export function fooBarBaz(params/*, hash*/) { +export default helper(function fooBarBaz(params/*, hash*/) { return params; -} - -export default helper(fooBarBaz); +});
true
Other
emberjs
ember.js
9c485789e408dffbc6f1d94b0defdaffc4e168e0.json
Add v3.10.0-beta.3 to CHANGELOG [ci skip] (cherry picked from commit 13b1d2573842f78f81fffd87e7b33ed0ce6bf81e)
CHANGELOG.md
@@ -1,5 +1,11 @@ # Ember Changelog +### v3.10.0-beta.3 (April 15, 2019) + +- [#17859](https://github.com/emberjs/ember.js/pull/17859) [BUGFIX] Fixes a regression in the legacy build +- [#17891](https://github.com/emberjs/ember.js/pull/17891) [BUGFIX] Loosen "engines" restriction for Node versions +- [#17900](https:...
false
Other
emberjs
ember.js
28ba80081c6101c5274dd6eac39ebcfafc577fce.json
Remove odd concatenation in FactoryManager#create.
packages/@ember/-internals/container/lib/container.ts
@@ -597,7 +597,7 @@ class FactoryManager<T, C> { throw new Error( `Failed to create an instance of '${ this.normalizedName - }'. Most likely an improperly defined class or` + ` an invalid module export.` + }'. Most likely an improperly defined class or an invalid module export.`...
false
Other
emberjs
ember.js
c73fa31d138fb8a628db04b877a09206d60afb7c.json
Add v3.10.0-beta.2 to CHANGELOG [ci skip] (cherry picked from commit 000e0da204ef57c864e0152872e60b5efd5267bf)
CHANGELOG.md
@@ -1,6 +1,6 @@ # Ember Changelog -### v3.10.0-beta.2 (UNRELEASED) +### v3.10.0-beta.2 (April 08, 2019) - [#17846](https://github.com/emberjs/ember.js/pull/17846) [BUGFIX] Fix issues with template-only components causing errors in subsequent updates. - [#17870](https://github.com/emberjs/ember.js/pull/17870) / [...
false
Other
emberjs
ember.js
b04e000d4be12f5ae36f36e9938e611fbe8b3992.json
Update CHANGELOG [ci skip] (cherry picked from commit e3341624dd3cecc0957511f32a0d77df12154195)
CHANGELOG.md
@@ -7,6 +7,10 @@ - [#17872](https://github.com/emberjs/ember.js/pull/17872) [BUGFIX] Fix issue where `{{link-to}}` is causing unexpected local variable shadowing assertions. - [#17874](https://github.com/emberjs/ember.js/pull/17874) [BUGFIX] Fix issue with `event.stopPropagation()` in component event handlers when jQ...
false
Other
emberjs
ember.js
7905f2131547d3e3ab6eb97e4cb96411483f3c16.json
Update CHANGELOG [ci skip] (cherry picked from commit 0c2a780fe2255adee32105aa0e3b3c56965bcf02)
CHANGELOG.md
@@ -5,6 +5,8 @@ - [#17846](https://github.com/emberjs/ember.js/pull/17846) [BUGFIX] Fix issues with template-only components causing errors in subsequent updates. - [#17870](https://github.com/emberjs/ember.js/pull/17870) / [#17871](https://github.com/emberjs/ember.js/pull/17871) [BUGFIX] Fix issue where `...attribut...
false
Other
emberjs
ember.js
7da998b3c28c4cd67c65814c0718dac52252cae0.json
update CHANGELOG [ci skip] (cherry picked from commit de969e4b93b9934875e95fefa852dd3d5cedaafd)
CHANGELOG.md
@@ -4,6 +4,7 @@ - [#17846](https://github.com/emberjs/ember.js/pull/17846) [BUGFIX] Fix issues with template-only components causing errors in subsequent updates. - [#17870](https://github.com/emberjs/ember.js/pull/17870) / [#17871](https://github.com/emberjs/ember.js/pull/17871) [BUGFIX] Fix issue where `...attrib...
false
Other
emberjs
ember.js
5f8d39c7b3a1acb5842117b24806030b981442f3.json
Update CHANGELOG [ci skip] (cherry picked from commit 8d197594e6d19f802293037b59a0c9ee376004c7)
CHANGELOG.md
@@ -3,6 +3,7 @@ ### v3.10.0-beta.2 (UNRELEASED) - [#17846](https://github.com/emberjs/ember.js/pull/17846) [BUGFIX] Fix issues with template-only components causing errors in subsequent updates. +- [#17870](https://github.com/emberjs/ember.js/pull/17870) / [#17871](https://github.com/emberjs/ember.js/pull/17871) [B...
false
Other
emberjs
ember.js
d5b9345a01f94f80953088c56d2e64058784afe9.json
Update CHANGELOG [ci skip] (cherry picked from commit 8e169048ff0b435423b4e0357a6cd78acbfceec9)
CHANGELOG.md
@@ -1,17 +1,22 @@ # Ember Changelog +### v3.10.0-beta.2 (UNRELEASED) + +- [#17846](https://github.com/emberjs/ember.js/pull/17846) [BUGFIX] Fix issues with template-only components causing errors in subsequent updates. + ### v3.10.0-beta.1 (April 02, 2019) - [#17836](https://github.com/emberjs/ember.js/pull/1783...
false
Other
emberjs
ember.js
919ede7e5eb5451f0b994ffe360dbe0a0a01f8ba.json
Add missing feature to 3.10.0-beta.1 CHANGELOG [ci skip] (cherry picked from commit 6e89ed823a43b429246940f40a4240afb47458f3)
CHANGELOG.md
@@ -6,6 +6,7 @@ - [#17719](https://github.com/emberjs/ember.js/pull/17719) / [#17745](https://github.com/emberjs/ember.js/pull/17745) [FEATURE] Support for nested components in angle bracket invocation syntax (see [emberjs/rfcs#0457](https://github.com/emberjs/rfcs/blob/master/text/0457-nested-lookups.md)). - [#1773...
false
Other
emberjs
ember.js
72ddf93acc398dc23d1298d1e05eaafd115fc44d.json
Fix some types, remove `any`s from `references.ts`
packages/@ember/-internals/glimmer/lib/component-managers/curly.ts
@@ -1,5 +1,4 @@ import { privatize as P } from '@ember/-internals/container'; -import { get } from '@ember/-internals/metal'; import { getOwner } from '@ember/-internals/owner'; import { guidFor } from '@ember/-internals/utils'; import { @@ -121,7 +120,9 @@ export default class CurlyComponentManager } templ...
true
Other
emberjs
ember.js
72ddf93acc398dc23d1298d1e05eaafd115fc44d.json
Fix some types, remove `any`s from `references.ts`
packages/@ember/-internals/glimmer/lib/component-managers/custom.ts
@@ -14,7 +14,6 @@ import { CapturedArguments, ComponentDefinition, Invocation, - PrimitiveReference, WithStaticLayout, } from '@glimmer/runtime'; import { Destroyable } from '@glimmer/util'; @@ -178,13 +177,8 @@ export default class CustomComponentManager<ComponentInstance> delegate.getContext(compo...
true
Other
emberjs
ember.js
72ddf93acc398dc23d1298d1e05eaafd115fc44d.json
Fix some types, remove `any`s from `references.ts`
packages/@ember/-internals/glimmer/lib/components/checkbox.ts
@@ -1,4 +1,4 @@ -import { get, set } from '@ember/-internals/metal'; +import { set } from '@ember/-internals/metal'; import { assert } from '@ember/debug'; import { DEBUG } from '@glimmer/env'; import EmberComponent from '../component'; @@ -121,7 +121,7 @@ const Checkbox = EmberComponent.extend({ */ didInsert...
true
Other
emberjs
ember.js
72ddf93acc398dc23d1298d1e05eaafd115fc44d.json
Fix some types, remove `any`s from `references.ts`
packages/@ember/-internals/glimmer/lib/helpers/action.ts
@@ -284,12 +284,12 @@ export default function(_vm: VM, args: Arguments): UnboundReference<Function> { let [context, action, ...restArgs] = capturedArgs.references; // TODO: Is there a better way of doing this? - let debugKey: string | undefined = (action as any)._propertyKey; + let debugKey: string | undefine...
true
Other
emberjs
ember.js
72ddf93acc398dc23d1298d1e05eaafd115fc44d.json
Fix some types, remove `any`s from `references.ts`
packages/@ember/-internals/glimmer/lib/modifiers/action.ts
@@ -205,7 +205,7 @@ export default class ActionModifierManager implements ModifierManager<ActionStat if (actionNameRef[INVOKE]) { actionName = actionNameRef; } else { - let actionLabel = actionNameRef._propertyKey; + let actionLabel = actionNameRef.propertyKey; actionName =...
true
Other
emberjs
ember.js
72ddf93acc398dc23d1298d1e05eaafd115fc44d.json
Fix some types, remove `any`s from `references.ts`
packages/@ember/-internals/glimmer/lib/utils/curly-component-state-bucket.ts
@@ -3,10 +3,12 @@ import { Revision, VersionedReference } from '@glimmer/reference'; import { CapturedNamedArguments } from '@glimmer/runtime'; import { Opaque } from '@glimmer/util'; import Environment from '../environment'; +import { Factory as TemplateFactory, OwnedTemplate } from '../template'; export interfa...
true
Other
emberjs
ember.js
72ddf93acc398dc23d1298d1e05eaafd115fc44d.json
Fix some types, remove `any`s from `references.ts`
packages/@ember/-internals/glimmer/lib/utils/references.ts
@@ -6,12 +6,14 @@ import { setCurrentTracker, tagFor, tagForProperty, + Tracker, watchKey, } from '@ember/-internals/metal'; import { isProxy, symbol } from '@ember/-internals/utils'; import { EMBER_METAL_TRACKED_PROPERTIES } from '@ember/canary-features'; +import { debugFreeze } from '@ember/debug'; i...
true
Other
emberjs
ember.js
72ddf93acc398dc23d1298d1e05eaafd115fc44d.json
Fix some types, remove `any`s from `references.ts`
packages/@ember/-internals/metal/index.ts
@@ -49,7 +49,7 @@ export { Mixin, aliasMethod, mixin, observer, applyMixin } from './lib/mixin'; export { default as inject, DEBUG_INJECTION_FUNCTIONS } from './lib/injected_property'; export { tagForProperty, tagFor, markObjectAsDirty } from './lib/tags'; export { default as runInTransaction, didRender, assertNotRe...
true
Other
emberjs
ember.js
72ddf93acc398dc23d1298d1e05eaafd115fc44d.json
Fix some types, remove `any`s from `references.ts`
packages/@ember/-internals/metal/lib/tracked.ts
@@ -18,7 +18,7 @@ let symbol = (HAS_NATIVE_SYMBOL ? Symbol : emberSymbol) as (debugKey: string) => @private */ -class Tracker { +export class Tracker { private tags = new Set<Tag>(); private last: Option<Tag> = null; @@ -243,7 +243,9 @@ export function getCurrentTracker(): Option<Tracker> { return CURR...
true
Other
emberjs
ember.js
72ddf93acc398dc23d1298d1e05eaafd115fc44d.json
Fix some types, remove `any`s from `references.ts`
packages/@ember/-internals/metal/lib/transaction.ts
@@ -90,9 +90,9 @@ if (DEBUG) { let label; if (lastRef !== undefined) { - while (lastRef && lastRef._propertyKey) { - parts.unshift(lastRef._propertyKey); - lastRef = lastRef._parentReference; + while (lastRef && lastRef.propertyKey) { + ...
true
Other
emberjs
ember.js
72ddf93acc398dc23d1298d1e05eaafd115fc44d.json
Fix some types, remove `any`s from `references.ts`
packages/@ember/-internals/routing/lib/system/dsl.ts
@@ -168,7 +168,7 @@ export default class DSLImpl implements DSL { }; } - mount(_name: string, options: Partial<MountOptions> = {}) { + mount(_name: string, options: MountOptions = {}) { let engineRouteMap = this.options.resolveRouteMap(_name); let name = _name;
true
Other
emberjs
ember.js
72ddf93acc398dc23d1298d1e05eaafd115fc44d.json
Fix some types, remove `any`s from `references.ts`
packages/@ember/-internals/utils/lib/is_proxy.ts
@@ -3,14 +3,14 @@ import { isObject } from './spec'; const PROXIES = new WeakSet(); -export function isProxy(object: any | undefined | null) { - if (isObject(object)) { - return PROXIES.has(object); +export function isProxy(value: any | undefined | null): value is object { + if (isObject(value)) { + return...
true
Other
emberjs
ember.js
72ddf93acc398dc23d1298d1e05eaafd115fc44d.json
Fix some types, remove `any`s from `references.ts`
packages/@ember/debug/index.ts
@@ -296,7 +296,13 @@ if (DEBUG) { }); setDebugFunction('debugFreeze', function debugFreeze(obj) { - Object.freeze(obj); + // re-freezing an already frozen object introduces a significant + // performance penalty on Chrome (tested through 59). + // + // See: https://bugs.chromium.org/p/v8/issues/d...
true
Other
emberjs
ember.js
665c62548359c6f16cfaf08274c1ce677feed8aa.json
fix input tests without jquery
packages/@ember/-internals/glimmer/tests/integration/components/input-angle-test.js
@@ -3,7 +3,7 @@ import { RenderingTestCase, moduleFor, runDestroy, runTask } from 'internal-test import { EMBER_GLIMMER_ANGLE_BRACKET_BUILT_INS } from '@ember/canary-features'; import { assign } from '@ember/polyfills'; import { set } from '@ember/-internals/metal'; -import { jQuery } from '@ember/-internals/views';...
true
Other
emberjs
ember.js
665c62548359c6f16cfaf08274c1ce677feed8aa.json
fix input tests without jquery
packages/@ember/-internals/glimmer/tests/integration/components/input-curly-test.js
@@ -3,7 +3,7 @@ import { RenderingTestCase, moduleFor, runDestroy, runTask } from 'internal-test import { EMBER_GLIMMER_ANGLE_BRACKET_BUILT_INS } from '@ember/canary-features'; import { assign } from '@ember/polyfills'; import { set } from '@ember/-internals/metal'; -import { jQuery } from '@ember/-internals/views';...
true
Other
emberjs
ember.js
41c4ee6bba4233ed325dd8e139b8de9dbe1ca37b.json
Add v3.10.0-beta.1 to CHANGELOG [ci skip] (cherry picked from commit 6744aa9063495217451f99a34b5dcc5f100c184b)
CHANGELOG.md
@@ -1,5 +1,20 @@ # Ember Changelog +### v3.10.0-beta.1 (April 02, 2019) + +- [#17836](https://github.com/emberjs/ember.js/pull/17836) [BREAKING] Explicitly drop support for Node 6 +- [#17719](https://github.com/emberjs/ember.js/pull/17719) / [#17745](https://github.com/emberjs/ember.js/pull/17745) [FEATURE] Support ...
false
Other
emberjs
ember.js
aede427fb866a6364caba37f88b5b8bfafdfa113.json
Add v3.8.1 to CHANGELOG [ci skip] (cherry picked from commit af18a4f23b448656793ba9a7d4ca78dd75cff34a)
CHANGELOG.md
@@ -1,5 +1,10 @@ # Ember Changelog +### v3.8.1 (April 02, 2019) + +- [#17684](https://github.com/emberjs/ember.js/pull/17684) [BUGFIX] Enable maximum rerendering limit to be customized. +- [#17823](https://github.com/emberjs/ember.js/pull/17823) Update router_js to 6.2.4 + ### v3.9.0 (April 01, 2019) - [#17470](...
false
Other
emberjs
ember.js
d059ad6b573cf3d3cd680f55abf18a17cb3933cc.json
Add v3.9.0 to CHANGELOG [ci skip] (cherry picked from commit 2b9ee1792f27d20723c9b2c534de2f050098220c)
CHANGELOG.md
@@ -1,24 +1,6 @@ # Ember Changelog -### v3.9.0-beta.5 (March 25, 2019) - -- [#17733](https://github.com/emberjs/ember.js/pull/17733) [BUGFIX] Assert on use of reserved component names (`input` and `textarea`) - -### v3.9.0-beta.4 (March 11, 2019) - -- [#17710](https://github.com/emberjs/ember.js/pull/17710) [BUGFIX]...
false
Other
emberjs
ember.js
da39c475f1f42b1544f1c95dd888db9226d05fa6.json
Remove intimate apis in the router
packages/@ember/-internals/routing/lib/system/router.ts
@@ -2,12 +2,7 @@ import { computed, get, notifyPropertyChange, set } from '@ember/-internals/meta import { getOwner, Owner } from '@ember/-internals/owner'; import { A as emberA, Evented, Object as EmberObject, typeOf } from '@ember/-internals/runtime'; import { assert, deprecate, info } from '@ember/debug'; -import...
true
Other
emberjs
ember.js
da39c475f1f42b1544f1c95dd888db9226d05fa6.json
Remove intimate apis in the router
packages/@ember/deprecated-features/index.ts
@@ -8,9 +8,7 @@ export const EMBER_EXTEND_PROTOTYPES = !!'3.2.0-beta.5'; export const RUN_SYNC = !!'3.0.0-beta.4'; export const LOGGER = !!'3.2.0-beta.1'; export const MERGE = !!'3.6.0-beta.1'; -export const HANDLER_INFOS = !!'3.9.0'; -export const ROUTER_EVENTS = !!'3.9.0'; -export const TRANSITION_STATE = !!'3.9.0...
true
Other
emberjs
ember.js
da39c475f1f42b1544f1c95dd888db9226d05fa6.json
Remove intimate apis in the router
packages/ember/tests/routing/deprecated_handler_infos_test.js
@@ -1,68 +0,0 @@ -import { moduleFor, ApplicationTestCase } from 'internal-test-helpers'; - -moduleFor( - 'Deprecated HandlerInfos', - class extends ApplicationTestCase { - constructor() { - super(...arguments); - this.router.map(function() { - this.route('parent', function() { - this.rou...
true
Other
emberjs
ember.js
da39c475f1f42b1544f1c95dd888db9226d05fa6.json
Remove intimate apis in the router
packages/ember/tests/routing/deprecated_transition_state_test.js
@@ -1,42 +0,0 @@ -import { RouterTestCase, moduleFor } from 'internal-test-helpers'; - -moduleFor( - 'Deprecated Transition State', - class extends RouterTestCase { - '@test touching transition.state is deprecated'(assert) { - assert.expect(1); - return this.visit('/').then(() => { - this.routerSe...
true
Other
emberjs
ember.js
674d30c90a537b21d2b1ef1e3de90494727d62de.json
enable feature flag
packages/@ember/canary-features/index.ts
@@ -20,7 +20,7 @@ export const DEFAULT_FEATURES = { EMBER_GLIMMER_ANGLE_BRACKET_BUILT_INS: true, EMBER_GLIMMER_ANGLE_BRACKET_NESTED_LOOKUP: true, EMBER_ROUTING_BUILD_ROUTEINFO_METADATA: true, - EMBER_NATIVE_DECORATOR_SUPPORT: null, + EMBER_NATIVE_DECORATOR_SUPPORT: true, }; /**
false
Other
emberjs
ember.js
fd360ca8181f0812a20fd718fefcfb0ddd4befe7.json
Add missing babel helper This is needed due to https://github.com/glimmerjs/glimmer-vm/blob/e672233ea70ab2614648bb194efc107f3698baad/packages/%40glimmer/runtime/lib/compiled/opcodes/component.ts This is probably unintended and a waste of bytes. We should fix it upstream and remove this helper.
packages/external-helpers/lib/external-helpers.js
@@ -111,3 +111,9 @@ export function possibleConstructorReturn(self, call) { } return assertThisInitialized(self); } + +export function objectDestructuringEmpty(obj) { + if (DEBUG && (obj === null || obj === undefined)) { + throw new TypeError('Cannot destructure undefined'); + } +}
false
Other
emberjs
ember.js
bfa97c8eb29982f42c0ae1f5021b28609289176c.json
Upgrade Glimmer and TypeScript @glimmer/* 0.37.1 -> 0.38.1 typescript 3.0.1 -> 3.2.4
package.json
@@ -91,14 +91,14 @@ "@babel/plugin-transform-shorthand-properties": "^7.2.0", "@babel/plugin-transform-spread": "^7.2.2", "@babel/plugin-transform-template-literals": "^7.2.0", - "@glimmer/compiler": "^0.37.1", + "@glimmer/compiler": "^0.38.1", "@glimmer/env": "^0.1.7", - "@glimmer/interfac...
true
Other
emberjs
ember.js
bfa97c8eb29982f42c0ae1f5021b28609289176c.json
Upgrade Glimmer and TypeScript @glimmer/* 0.37.1 -> 0.38.1 typescript 3.0.1 -> 3.2.4
packages/@ember/-internals/glimmer/lib/helpers/loc.ts
@@ -38,5 +38,5 @@ import { helper } from '../helper'; @public */ export default helper(function(params) { - return loc.apply(null, params); + return loc.apply(null, params as any /* let the other side handle errors */); });
true
Other
emberjs
ember.js
bfa97c8eb29982f42c0ae1f5021b28609289176c.json
Upgrade Glimmer and TypeScript @glimmer/* 0.37.1 -> 0.38.1 typescript 3.0.1 -> 3.2.4
packages/@ember/-internals/glimmer/lib/utils/references.ts
@@ -31,7 +31,7 @@ import { ConditionalReference as GlimmerConditionalReference, PrimitiveReference, } from '@glimmer/runtime'; -import { Option } from '@glimmer/util'; +import { Option, unreachable } from '@glimmer/util'; import { HelperFunction, HelperInstance, RECOMPUTE_TAG } from '../helper'; import emberTo...
true
Other
emberjs
ember.js
bfa97c8eb29982f42c0ae1f5021b28609289176c.json
Upgrade Glimmer and TypeScript @glimmer/* 0.37.1 -> 0.38.1 typescript 3.0.1 -> 3.2.4
packages/@ember/-internals/glimmer/lib/utils/serialization-first-node-helpers.ts
@@ -1 +1 @@ -export { isSerializationFirstNode } from '@glimmer/util'; +export { isSerializationFirstNode } from '@glimmer/runtime';
true
Other
emberjs
ember.js
bfa97c8eb29982f42c0ae1f5021b28609289176c.json
Upgrade Glimmer and TypeScript @glimmer/* 0.37.1 -> 0.38.1 typescript 3.0.1 -> 3.2.4
packages/@ember/-internals/metal/lib/transaction.ts
@@ -170,9 +170,9 @@ if (DEBUG) { let runner = new TransactionRunner(); - runInTransaction = runner.runInTransaction.bind(runner); - didRender = runner.didRender.bind(runner); - assertNotRendered = runner.assertNotRendered.bind(runner); + runInTransaction = (...args) => runner.runInTransaction(...args); + di...
true
Other
emberjs
ember.js
bfa97c8eb29982f42c0ae1f5021b28609289176c.json
Upgrade Glimmer and TypeScript @glimmer/* 0.37.1 -> 0.38.1 typescript 3.0.1 -> 3.2.4
packages/@ember/-internals/routing/lib/location/auto_location.ts
@@ -243,7 +243,7 @@ function detectImplementation(options: DetectionOptions) { if (currentPath === historyPath) { implementation = 'history'; } else if (currentPath.substr(0, 2) === '/#') { - history!.replaceState({ path: historyPath }, undefined, historyPath); + history!.replaceState({ path:...
true
Other
emberjs
ember.js
bfa97c8eb29982f42c0ae1f5021b28609289176c.json
Upgrade Glimmer and TypeScript @glimmer/* 0.37.1 -> 0.38.1 typescript 3.0.1 -> 3.2.4
packages/@ember/-internals/routing/lib/system/dsl.ts
@@ -1,58 +1,96 @@ import { Factory } from '@ember/-internals/owner'; import { assert } from '@ember/debug'; import { assign } from '@ember/polyfills'; +import { Option } from '@glimmer/interfaces'; import { MatchCallback } from 'route-recognizer'; import { EngineInfo, EngineRouteInfo } from './engines'; let uui...
true