diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/db/migrate/20171107185100_add_unique_index_on_common_id_at_subscriptions_and_sub_payments.rb b/db/migrate/20171107185100_add_unique_index_on_common_id_at_subscriptions_and_sub_payments.rb index abc1234..def5678 100644 --- a/db/migrate/20171107185100_add_unique_index_on_common_id_at_subscriptions_and_sub_pa...
Add unique index common_id on subscription / subscription_payments
diff --git a/lib/london_bike_hire_cli.rb b/lib/london_bike_hire_cli.rb index abc1234..def5678 100644 --- a/lib/london_bike_hire_cli.rb +++ b/lib/london_bike_hire_cli.rb @@ -1,19 +1,4 @@-require_relative 'london_bike_hire_cli/application' -require_relative 'london_bike_hire_cli/basic_renderer' -require_relative 'london_...
Tidy up the require statements
diff --git a/lib/pdfkit/configuration.rb b/lib/pdfkit/configuration.rb index abc1234..def5678 100644 --- a/lib/pdfkit/configuration.rb +++ b/lib/pdfkit/configuration.rb @@ -1,10 +1,10 @@ class PDFKit class Configuration - attr_accessor :meta_tag_prefix, :wkhtmltopdf, :default_options + attr_accessor :meta_tag_...
Change from always executing `which wkhtmltopdf` to only executing it if the binary file's location is not explicitly stated in config.
diff --git a/db/migrate/20170705110801_adjust_full_text_index_on_projects.rb b/db/migrate/20170705110801_adjust_full_text_index_on_projects.rb index abc1234..def5678 100644 --- a/db/migrate/20170705110801_adjust_full_text_index_on_projects.rb +++ b/db/migrate/20170705110801_adjust_full_text_index_on_projects.rb @@ -0,0...
Use public_name on project index
diff --git a/db/migrate/20170717105219_copy_confirmed_at_from_enterprises_to_spree_users.rb b/db/migrate/20170717105219_copy_confirmed_at_from_enterprises_to_spree_users.rb index abc1234..def5678 100644 --- a/db/migrate/20170717105219_copy_confirmed_at_from_enterprises_to_spree_users.rb +++ b/db/migrate/20170717105219_...
Add migration to confirm already confirmed email addresses
diff --git a/lib/nmap/uptime.rb b/lib/nmap/uptime.rb index abc1234..def5678 100644 --- a/lib/nmap/uptime.rb +++ b/lib/nmap/uptime.rb @@ -13,7 +13,7 @@ # @since 0.6.1 # def to_s - "uptime: #{@seconds} (#{@lastboot})" + "uptime: #{self.seconds} (#{self.lastboot})" end end
Use methods instead of ivars.
diff --git a/modules/nginx/spec/defines/nginx_config_vhost_default_spec.rb b/modules/nginx/spec/defines/nginx_config_vhost_default_spec.rb index abc1234..def5678 100644 --- a/modules/nginx/spec/defines/nginx_config_vhost_default_spec.rb +++ b/modules/nginx/spec/defines/nginx_config_vhost_default_spec.rb @@ -9,7 +9,7 @@...
Fix nginx default vhost spec
diff --git a/lib/express_templates/macro.rb b/lib/express_templates/macro.rb index abc1234..def5678 100644 --- a/lib/express_templates/macro.rb +++ b/lib/express_templates/macro.rb @@ -33,6 +33,7 @@ @options.merge!(child_or_option) when child_or_option.kind_of?(Symbol) @o...
Allow nils passed as an option to do nothing
diff --git a/lib/rcoli/utils.rb b/lib/rcoli/utils.rb index abc1234..def5678 100644 --- a/lib/rcoli/utils.rb +++ b/lib/rcoli/utils.rb @@ -0,0 +1,14 @@+module RCoLi + + module Properties + + def setter(name) + define_method(name) do |value| + ivar = "@#{name}" + instance_variable_set(iva...
Support for properties in DSL
diff --git a/spec/controllers/dashboards_controller_spec.rb b/spec/controllers/dashboards_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/dashboards_controller_spec.rb +++ b/spec/controllers/dashboards_controller_spec.rb @@ -0,0 +1,37 @@+describe DashboardsController do + render_views + + de...
Add spec for dashboards controller
diff --git a/dress_up.gemspec b/dress_up.gemspec index abc1234..def5678 100644 --- a/dress_up.gemspec +++ b/dress_up.gemspec @@ -7,11 +7,9 @@ s.version = DressUp::VERSION s.authors = ["Morgan Brown"] s.email = ["brown.mhg@gmail.com"] - s.homepage = "" - s.summary = %q{TODO: Write a gem su...
Add homepage and summary information
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb index abc1234..def5678 100644 --- a/app/controllers/home_controller.rb +++ b/app/controllers/home_controller.rb @@ -1,6 +1,6 @@ class HomeController < ApplicationController def index - @subscriber_count = User.count + @subscri...
Use subscription instead of user for counts
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb index abc1234..def5678 100644 --- a/app/controllers/home_controller.rb +++ b/app/controllers/home_controller.rb @@ -19,7 +19,7 @@ class HomeController < ApplicationController def index @picture = Picture.random - authorize! ...
Fix for homepage and permissions when there are no images at all.
diff --git a/config/initializers/govuk_admin_template.rb b/config/initializers/govuk_admin_template.rb index abc1234..def5678 100644 --- a/config/initializers/govuk_admin_template.rb +++ b/config/initializers/govuk_admin_template.rb @@ -1,4 +1,4 @@-GovukAdminTemplate.environment_style = ENV['RAILS_ENV'] +GovukAdminTemp...
Fix colour of environment label/favicon on staging
diff --git a/db/migrate/20150429170813_fix_email_from.rb b/db/migrate/20150429170813_fix_email_from.rb index abc1234..def5678 100644 --- a/db/migrate/20150429170813_fix_email_from.rb +++ b/db/migrate/20150429170813_fix_email_from.rb @@ -21,10 +21,11 @@ email = members[post.from_name] || Person.where_name_or...
Use help@obra.org for posts missing from email
diff --git a/db/migrate/20110316184212_questionnaire_flag_defaults.rb b/db/migrate/20110316184212_questionnaire_flag_defaults.rb index abc1234..def5678 100644 --- a/db/migrate/20110316184212_questionnaire_flag_defaults.rb +++ b/db/migrate/20110316184212_questionnaire_flag_defaults.rb @@ -0,0 +1,20 @@+class Questionnair...
Change questionnaire flags to explicit defaults
diff --git a/db/migrate/20161011074820_add_index_to_database_hosts.rb b/db/migrate/20161011074820_add_index_to_database_hosts.rb index abc1234..def5678 100644 --- a/db/migrate/20161011074820_add_index_to_database_hosts.rb +++ b/db/migrate/20161011074820_add_index_to_database_hosts.rb @@ -0,0 +1,15 @@+Sequel.migration d...
Add index to database_host (for metrics)
diff --git a/app/helpers/requests_helper.rb b/app/helpers/requests_helper.rb index abc1234..def5678 100644 --- a/app/helpers/requests_helper.rb +++ b/app/helpers/requests_helper.rb @@ -13,4 +13,17 @@ def format_http_header(word) word.gsub(/\w+|-/, &:capitalize) end + + # Determine if the response is JSON. + ...
Create helper for checking JSON responses
diff --git a/app/mailers/timeslot_mailer.rb b/app/mailers/timeslot_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/timeslot_mailer.rb +++ b/app/mailers/timeslot_mailer.rb @@ -9,4 +9,16 @@ @timeslot = timeslot mail to: @timeslot.student.email, subject: "Mentor Me Scheduling Notification" end + + d...
Add timeslot mailer methods for cancellations Add methods to timeslot mailer to issue emails to the affected student and tutor when a session is canceled by either of them.
diff --git a/app/services/import_stories.rb b/app/services/import_stories.rb index abc1234..def5678 100644 --- a/app/services/import_stories.rb +++ b/app/services/import_stories.rb @@ -14,6 +14,11 @@ Story.delete_all end + def filterByTag tags + allowedTags = ["climatewatch", "ndcsdg", "esp", "ndc"] + r...
Add filtering by tag logic to stories import
diff --git a/Casks/segger-embedded-studio-for-risc-v.rb b/Casks/segger-embedded-studio-for-risc-v.rb index abc1234..def5678 100644 --- a/Casks/segger-embedded-studio-for-risc-v.rb +++ b/Casks/segger-embedded-studio-for-risc-v.rb @@ -0,0 +1,12 @@+cask 'segger-embedded-studio-for-risc-v' do + version '3.52a' + sha256 '...
Add SEGGER Embedded Studio for RISC-V V3.52a
diff --git a/bosh-director/db/migrations/director/20140124225348_proper_pk_for_attributes.rb b/bosh-director/db/migrations/director/20140124225348_proper_pk_for_attributes.rb index abc1234..def5678 100644 --- a/bosh-director/db/migrations/director/20140124225348_proper_pk_for_attributes.rb +++ b/bosh-director/db/migrat...
Fix for mysql primary key bug Signed-off-by: Rob Day-Reynolds <904086f049d807ae99640dbdfde98536a5822f56@pivotallabs.com>
diff --git a/lib/active_record/prunable.rb b/lib/active_record/prunable.rb index abc1234..def5678 100644 --- a/lib/active_record/prunable.rb +++ b/lib/active_record/prunable.rb @@ -34,8 +34,8 @@ destroyed = prune_by_method - if destroyed.any? - logger.info "#{destroyed.size} records have bee...
Return number of removed records.
diff --git a/ZIPFoundation.podspec b/ZIPFoundation.podspec index abc1234..def5678 100644 --- a/ZIPFoundation.podspec +++ b/ZIPFoundation.podspec @@ -11,7 +11,7 @@ s.ios.deployment_target = '9.0' s.osx.deployment_target = '10.11' s.tvos.deployment_target = '9.0' - s.watchos.deployment_target = '4.0' + s.watcho...
Revert "Fixed watchOS deployment target for CocoaPods" This reverts commit 8ad242a491de1f266b54546553e9bd2d8470509b.
diff --git a/lib/chefspec/matchers/file.rb b/lib/chefspec/matchers/file.rb index abc1234..def5678 100644 --- a/lib/chefspec/matchers/file.rb +++ b/lib/chefspec/matchers/file.rb @@ -17,7 +17,7 @@ chef_run.resources.any? do |resource| resource_type(resource) == 'remote_file' && resource.pa...
Access resource attributes by method instead keys. This fixes the following error: Failure/Error: expect(chef_run).to create_remote_file_with_attributes('...') NoMethodError: undefined method `[]' for Chef::Resource::RemoteFile NOTE: We have no covering spec for this since resources are faked by hashes (whic...
diff --git a/spec/higher_level_api/integration/alternate_exchanges_spec.rb b/spec/higher_level_api/integration/alternate_exchanges_spec.rb index abc1234..def5678 100644 --- a/spec/higher_level_api/integration/alternate_exchanges_spec.rb +++ b/spec/higher_level_api/integration/alternate_exchanges_spec.rb @@ -14,8 +14,8 ...
Use march_hare in these names
diff --git a/failsafe.gemspec b/failsafe.gemspec index abc1234..def5678 100644 --- a/failsafe.gemspec +++ b/failsafe.gemspec @@ -8,7 +8,7 @@ s.platform = Gem::Platform::RUBY s.authors = ["Alex Sharp"] s.email = ["ajsharp@gmail.com"] - s.homepage = "https://github.com/ajsharp/failsafe" + s.home...
Change homepage location in gemspec
diff --git a/spec/samples/rubySyntaxParts/aggregation/multipleAggregation.rb b/spec/samples/rubySyntaxParts/aggregation/multipleAggregation.rb index abc1234..def5678 100644 --- a/spec/samples/rubySyntaxParts/aggregation/multipleAggregation.rb +++ b/spec/samples/rubySyntaxParts/aggregation/multipleAggregation.rb @@ -0,0...
Create aggregation sample for second parser Signed-off-by: Lucas Moura <143f96f992bf3dc84afaa2cc3d6d759a2b3ef261@gmail.com>
diff --git a/spec/subscriber_spec.rb b/spec/subscriber_spec.rb index abc1234..def5678 100644 --- a/spec/subscriber_spec.rb +++ b/spec/subscriber_spec.rb @@ -2,9 +2,24 @@ describe Hearst::Subscriber do - it 'auto-registers itself with Hearst' - it 'validates required parameters' - it 'stores event and exchange co...
Test subscriber hooks for registering and processing
diff --git a/sprinkle-script.gemspec b/sprinkle-script.gemspec index abc1234..def5678 100644 --- a/sprinkle-script.gemspec +++ b/sprinkle-script.gemspec @@ -18,6 +18,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] + spec.dependency "sprinkle" spec.add_develo...
Add sprinkle as a dependency
diff --git a/lib/rubocop/cop/naming/binary_operator_parameter_name.rb b/lib/rubocop/cop/naming/binary_operator_parameter_name.rb index abc1234..def5678 100644 --- a/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +++ b/lib/rubocop/cop/naming/binary_operator_parameter_name.rb @@ -18,7 +18,7 @@ 'na...
Use EXCLUDED in BinaryOperatorParameterName cop Prefer EXCLUDED to BLACKLIST in code as well as in cop config names.
diff --git a/interactive_git_branch_deleter.rb b/interactive_git_branch_deleter.rb index abc1234..def5678 100644 --- a/interactive_git_branch_deleter.rb +++ b/interactive_git_branch_deleter.rb @@ -13,7 +13,7 @@ response = gets.chomp.strip.downcase if response == 'y' - command = "git branch -d #{br...
Allow deletion of unmerged branches Calling git branch with the `-d` flag will only delete a branch if it has been fully merged with its parent (usually master). In this case, if the user explicitly chooses to delete a local branch, we want to honour this request regardless of whether the branch has been merged. This...
diff --git a/modules/govuk_ghe_vpn/spec/classes/govuk_ghe_vpn_spec.rb b/modules/govuk_ghe_vpn/spec/classes/govuk_ghe_vpn_spec.rb index abc1234..def5678 100644 --- a/modules/govuk_ghe_vpn/spec/classes/govuk_ghe_vpn_spec.rb +++ b/modules/govuk_ghe_vpn/spec/classes/govuk_ghe_vpn_spec.rb @@ -0,0 +1,9 @@+require_relative '....
Add class specs for govuk_ghe_vpn
diff --git a/lib/faker/default/computer.rb b/lib/faker/default/computer.rb index abc1234..def5678 100644 --- a/lib/faker/default/computer.rb +++ b/lib/faker/default/computer.rb @@ -32,17 +32,16 @@ ## # Produces the name of a computer os. # - # @param platform [String] optionally specify the pla...
Fix an error for `Faker::Computer.os` Follow up to #1948. This PR fixes the following error for `Faker::Computer.os`. ```console % cd path/to/faker-ruby/faker % bundle exec ruby -Itest test/test_determinism.rb Loaded suite test/test_determinism (snip) test/test_determinism.rb:13:in `test_determinism' test/test_dete...
diff --git a/lib/kosmos/packages/ferram.rb b/lib/kosmos/packages/ferram.rb index abc1234..def5678 100644 --- a/lib/kosmos/packages/ferram.rb +++ b/lib/kosmos/packages/ferram.rb @@ -4,4 +4,9 @@ homepage 'http://forum.kerbalspaceprogram.com/threads/20451-0-23-5-Ferram-Aerospace-Research-v0-13-3-4-30-14' url 'https...
Add a working package for Ferram Aerospace Research. I have installed and uninstalled this mod a few dozen times today.
diff --git a/lib/llt/review/api/helpers.rb b/lib/llt/review/api/helpers.rb index abc1234..def5678 100644 --- a/lib/llt/review/api/helpers.rb +++ b/lib/llt/review/api/helpers.rb @@ -12,7 +12,12 @@ def arethusa(rev, gold = nil, chunk = nil, word = nil) #"http://sosol.perseids.org/tools/arethusa/app/#/per...
Use the chunk param in Arethusa routes
diff --git a/lib/modules/module_weather.rb b/lib/modules/module_weather.rb index abc1234..def5678 100644 --- a/lib/modules/module_weather.rb +++ b/lib/modules/module_weather.rb @@ -20,7 +20,7 @@ private def find_weather - uri = "http://m.foreca.fi/index.php?l=100658225" + uri = "http://m.foreca.fi/old/inde...
Fix URL for Foreca service Signed-off-by: Aki Saarinen <278bc57fbbff6b7b38435aea0f9d37e3d879167e@akisaarinen.fi>
diff --git a/opal-activesupport.gemspec b/opal-activesupport.gemspec index abc1234..def5678 100644 --- a/opal-activesupport.gemspec +++ b/opal-activesupport.gemspec @@ -21,5 +21,6 @@ gem.require_paths = ['lib'] gem.add_dependency 'opal', '~> 0.4.2' + gem.add_development_dependency 'rake' gem.add_development_...
Add rake to dev deps
diff --git a/spec/dummy/config/initializers/monologue.rb b/spec/dummy/config/initializers/monologue.rb index abc1234..def5678 100644 --- a/spec/dummy/config/initializers/monologue.rb +++ b/spec/dummy/config/initializers/monologue.rb @@ -1,4 +1,4 @@ Monologue.config do |monologue| - monologue.image_upload.max_picture_s...
Change default for max picture size in dummy app
diff --git a/config/environments/development.rb b/config/environments/development.rb index abc1234..def5678 100644 --- a/config/environments/development.rb +++ b/config/environments/development.rb @@ -19,11 +19,12 @@ # Print deprecation notices to the Rails logger. config.active_support.deprecation = :log + con...
Speed up dev mode for production.
diff --git a/config/initializers/carrierwave.rb b/config/initializers/carrierwave.rb index abc1234..def5678 100644 --- a/config/initializers/carrierwave.rb +++ b/config/initializers/carrierwave.rb @@ -4,4 +4,5 @@ config.s3_access_key_id = s3[:access_key_id] config.s3_secret_access_key = s3[:secret_access_key] c...
Switch assets to S3 cnamed urls.
diff --git a/config/initializers/hoptoad.rb b/config/initializers/hoptoad.rb index abc1234..def5678 100644 --- a/config/initializers/hoptoad.rb +++ b/config/initializers/hoptoad.rb @@ -1,3 +1,3 @@ HoptoadNotifier.configure do |config| - config.api_key = '86a3b1ba9ee92b6bfc5cb1840e9ae3df' + config.api_key = ENV['HOPTO...
Use a env variable for the Hoptoad API key instead of hardcoding it
diff --git a/db/data_migrations/20190228161327_resolve_zero_percent_measures_on_cigarettes.rb b/db/data_migrations/20190228161327_resolve_zero_percent_measures_on_cigarettes.rb index abc1234..def5678 100644 --- a/db/data_migrations/20190228161327_resolve_zero_percent_measures_on_cigarettes.rb +++ b/db/data_migrations/2...
Add data migration to remove CHIEF 0% duty measures We noticed while testing another feature that CHIEF had included 0% duty measures for cigarettes again. To resolve this we've removed the 0% measures and re-enabled the existing measures that had the proper rates.
diff --git a/lib/charts/map.rb b/lib/charts/map.rb index abc1234..def5678 100644 --- a/lib/charts/map.rb +++ b/lib/charts/map.rb @@ -42,7 +42,7 @@ # Make sure chart dimensions are within Google's 440x220 limit. # def validate_dimensions - if @width > 440 or @height > 220 + if width > 440 or heig...
Remove references to instance variables (use getter methods instead).
diff --git a/lib/express_templates/compiler.rb b/lib/express_templates/compiler.rb index abc1234..def5678 100644 --- a/lib/express_templates/compiler.rb +++ b/lib/express_templates/compiler.rb @@ -1,6 +1,15 @@ module ExpressTemplates module Compiler def compile(template_or_src=nil, &block) + + if block + ...
Add helpful error message if developer makes type-o
diff --git a/lib/cowboy/fft.rb b/lib/cowboy/fft.rb index abc1234..def5678 100644 --- a/lib/cowboy/fft.rb +++ b/lib/cowboy/fft.rb @@ -1,4 +1,32 @@ module Cowboy + class Frequencies + attr_reader :dc, :unshifted, :freq + + def initialize(unshifted_array) + @unshifted = unshifted_array + @dc = unshifted_a...
Add frequencies class to do shift and include frequency buckets.
diff --git a/lib/guaranteed_queue/configure.rb b/lib/guaranteed_queue/configure.rb index abc1234..def5678 100644 --- a/lib/guaranteed_queue/configure.rb +++ b/lib/guaranteed_queue/configure.rb @@ -6,5 +6,5 @@ region: ENV['AWS_REGION'] || 'us-east-1', dead_letter_poll_interval_seconds: 30, message_failures_allow...
Allow for development rack to block queues
diff --git a/lib/frizz/sync.rb b/lib/frizz/sync.rb index abc1234..def5678 100644 --- a/lib/frizz/sync.rb +++ b/lib/frizz/sync.rb @@ -18,7 +18,7 @@ local_index.delete(local_path) else puts "#{local_path}: updated".green - remote.upload file_for(local_path), local_path + re...
Fix bug preventing deploys from replacing existing files that have changed
diff --git a/lib/redch/sos/client/templates.rb b/lib/redch/sos/client/templates.rb index abc1234..def5678 100644 --- a/lib/redch/sos/client/templates.rb +++ b/lib/redch/sos/client/templates.rb @@ -25,22 +25,21 @@ raise ArgumentError, "String or Symbol expected" end - raise ArgumentErro...
Remove useless namespace in method names
diff --git a/lib/cap_recipes/tasks/ruby19/install.rb b/lib/cap_recipes/tasks/ruby19/install.rb index abc1234..def5678 100644 --- a/lib/cap_recipes/tasks/ruby19/install.rb +++ b/lib/cap_recipes/tasks/ruby19/install.rb @@ -5,7 +5,7 @@ namespace :ruby19 do - set :ruby_ver, 'ruby-1.9.2-p180' + set :ruby_ver, 'r...
Update Ruby to the latest version for security (CVE-2013-0256) http://www.ruby-lang.org/en/news/2013/02/06/rdoc-xss-cve-2013-0256/
diff --git a/lib/chef/knife/cloudformation_export.rb b/lib/chef/knife/cloudformation_export.rb index abc1234..def5678 100644 --- a/lib/chef/knife/cloudformation_export.rb +++ b/lib/chef/knife/cloudformation_export.rb @@ -1,4 +1,3 @@-require 'pathname' require 'knife-cloudformation/cloudformation_base' require 'knife-...
Add a note about remote upload
diff --git a/app/models/concerns/recurring_ride_coordinator_scheduler.rb b/app/models/concerns/recurring_ride_coordinator_scheduler.rb index abc1234..def5678 100644 --- a/app/models/concerns/recurring_ride_coordinator_scheduler.rb +++ b/app/models/concerns/recurring_ride_coordinator_scheduler.rb @@ -4,7 +4,7 @@ exten...
Add start_date and end_date to NON_RIDE_COORDINATOR_ATTRIBUTES
diff --git a/test/test_cli.rb b/test/test_cli.rb index abc1234..def5678 100644 --- a/test/test_cli.rb +++ b/test/test_cli.rb @@ -1,4 +1,5 @@-require_relative 'helper' +$LOAD_PATH.unshift(File.dirname(__FILE__)) +require 'helper' class TestCLI < Test::Unit::TestCase context "Tracking's CLI" do
Stop using require_relative for CLI test
diff --git a/activesupport/lib/active_support/vendor.rb b/activesupport/lib/active_support/vendor.rb index abc1234..def5678 100644 --- a/activesupport/lib/active_support/vendor.rb +++ b/activesupport/lib/active_support/vendor.rb @@ -1,13 +1,16 @@+def ActiveSupport.requirable?(file) + $LOAD_PATH.any? { |p| Dir.glob("#{...
Check if the lib is in the load path and requirable before attempting to activate the gem version
diff --git a/app/controllers/posts/abouts_controller.rb b/app/controllers/posts/abouts_controller.rb index abc1234..def5678 100644 --- a/app/controllers/posts/abouts_controller.rb +++ b/app/controllers/posts/abouts_controller.rb @@ -9,7 +9,7 @@ # GET /abouts # GET /abouts.json def index - @abouts = About.onl...
Improve way SQL request are made
diff --git a/app/serializers/task_comment_serializer.rb b/app/serializers/task_comment_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/task_comment_serializer.rb +++ b/app/serializers/task_comment_serializer.rb @@ -1,5 +1,5 @@ class TaskCommentSerializer < ActiveModel::Serializer - attributes :id, :c...
QUALITY: Remove recipient_id from comment serializer
diff --git a/Casks/handbrakecli-nightly.rb b/Casks/handbrakecli-nightly.rb index abc1234..def5678 100644 --- a/Casks/handbrakecli-nightly.rb +++ b/Casks/handbrakecli-nightly.rb @@ -1,6 +1,6 @@ cask :v1 => 'handbrakecli-nightly' do - version '6559svn' - sha256 'b66feea96cb15ab7f54498235670ead24245af51e339b7218eabc5844...
Update HandbrakeCLI Nightly to v6562svn HandBrakeCLI Nightly Build 6562svn released 2014-11-27.
diff --git a/app/models/account.rb b/app/models/account.rb index abc1234..def5678 100644 --- a/app/models/account.rb +++ b/app/models/account.rb @@ -14,7 +14,7 @@ store_accessor :contact_information, :address, :country, :public_email, :telefon, :fax, :website validates :name, :users, presence: true - validates ...
Fix Validation for Account Subdomain
diff --git a/lib/onfido/api.rb b/lib/onfido/api.rb index abc1234..def5678 100644 --- a/lib/onfido/api.rb +++ b/lib/onfido/api.rb @@ -1,29 +1,10 @@-require 'onfido/address_picker' - module Onfido class API - include Requestable - include AddressPicker - - def url_for(path) - Onfido.endpoint + path - ...
Make an API wrapper around the endpoints for better calling Now you have to explicitely call a resource before calling its endpoint. It makes things clearer and will keep consistency between the endpoints as well e.g. api = Onfido::API.new api.applicant.find('applicant_id') api.address.find('postcode')
diff --git a/app/controllers/application_controller/sysprep_answer_file.rb b/app/controllers/application_controller/sysprep_answer_file.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller/sysprep_answer_file.rb +++ b/app/controllers/application_controller/sysprep_answer_file.rb @@ -1,7 +1,7 @@...
Fix rubocop warnings in ApplicationController::SysprepAnswerFile
diff --git a/magic_grid.gemspec b/magic_grid.gemspec index abc1234..def5678 100644 --- a/magic_grid.gemspec +++ b/magic_grid.gemspec @@ -15,7 +15,7 @@ # s.has_rdoc = 'yard' s.files = Dir["lib/**/*"] + ["MIT-LICENSE", "Rakefile", "README.md"] - s.test_files = Dir["{spec,test}/**/*"] - Dir["test/dummy/tmp/*", "...
Make file gemspec a little more aggressive with file filtering
diff --git a/app/models/meeting.rb b/app/models/meeting.rb index abc1234..def5678 100644 --- a/app/models/meeting.rb +++ b/app/models/meeting.rb @@ -6,7 +6,7 @@ def display_date datetime = date.to_datetime - weekday = DateTime::DAYNAMES[datetime.cwday] + weekday = DateTime::DAYNAMES[datetime.cwday == 7 ?...
Change display_date method to account for the fact that the day might be Sunday
diff --git a/Casks/font-league-gothic.rb b/Casks/font-league-gothic.rb index abc1234..def5678 100644 --- a/Casks/font-league-gothic.rb +++ b/Casks/font-league-gothic.rb @@ -4,7 +4,7 @@ url 'http://files.theleagueofmoveabletype.com/downloads/theleagueof-league-gothic-64c3ede.zip' homepage 'https://www.theleagueof...
Update League Gothic license to ofl
diff --git a/app/models/comment.rb b/app/models/comment.rb index abc1234..def5678 100644 --- a/app/models/comment.rb +++ b/app/models/comment.rb @@ -1,5 +1,7 @@ class Comment < ActiveRecord::Base + belongs_to :author, class_name: User + has_many :votes, :as => :voteable - belongs_to :author, class_name: User - ha...
Add validations and polymorphic relationship
diff --git a/weakling.gemspec b/weakling.gemspec index abc1234..def5678 100644 --- a/weakling.gemspec +++ b/weakling.gemspec @@ -9,7 +9,6 @@ s.email = ["headius@headius.com"] s.files = Dir['{lib,ext,examples,test}/**/*'] + Dir['{*.txt,*.gemspec,Rakefile}'] s.homepage = "http://github.com/headius/weakling" - s....
Remove --main rdoc thing from gemspec.
diff --git a/week-5/gps2_2.rb b/week-5/gps2_2.rb index abc1234..def5678 100644 --- a/week-5/gps2_2.rb +++ b/week-5/gps2_2.rb @@ -0,0 +1,27 @@+# Method to create a list +# input: string of items separated by spaces (example: "carrots apples cereal pizza") +# steps: + # [fill in any steps here] + # set default quantity...
Add file for GPS 2.2
diff --git a/restful_adhearsion.gemspec b/restful_adhearsion.gemspec index abc1234..def5678 100644 --- a/restful_adhearsion.gemspec +++ b/restful_adhearsion.gemspec @@ -9,6 +9,6 @@ s.files = ["lib/restful_adhearsion.rb", "LICENSE", "README.textile", "restful_adhearsion.gemspec"] s.require_paths = ["lib"] - s.a...
Fix dependency version requirements in gemspec
diff --git a/db/migrate/20150629080516_change_registry_id_from_namespace.rb b/db/migrate/20150629080516_change_registry_id_from_namespace.rb index abc1234..def5678 100644 --- a/db/migrate/20150629080516_change_registry_id_from_namespace.rb +++ b/db/migrate/20150629080516_change_registry_id_from_namespace.rb @@ -6,6 +6,...
Update the migrator to also update the activities
diff --git a/init.rb b/init.rb index abc1234..def5678 100644 --- a/init.rb +++ b/init.rb @@ -1,8 +1,7 @@-unless RAILS_ENV == 'production' - begin - require 'action_profiler' - ActionController::Base.send :include, ActionController::ActionProfiler - rescue LoadError - ActionController::Base.logger.info "`gem ...
Enable in production env also since we require an explicit around_filter now. Use the :if option on around_filter to limit profiling to a specific domain, for example.
diff --git a/init.rb b/init.rb index abc1234..def5678 100644 --- a/init.rb +++ b/init.rb @@ -3,15 +3,15 @@ Redmine::Plugin.register :redmine_dashboard do name 'Redmine Dashboard plugin' author 'Jan Graichen' - description 'Add a task dashboard to Redmine' + description 'Add a task board and a planning board to ...
Improve plugin description; Fix pathes, controller names and permissions.
diff --git a/cookbooks/lib/features/jdk_spec.rb b/cookbooks/lib/features/jdk_spec.rb index abc1234..def5678 100644 --- a/cookbooks/lib/features/jdk_spec.rb +++ b/cookbooks/lib/features/jdk_spec.rb @@ -1,4 +1,5 @@-describe 'jdk installation' do +# FIXME: remove `dev` tag ASAF +describe 'jdk installation', dev: true do ...
Tag the jdk specs `dev` since the edge images are busted
diff --git a/core/spec/screenshots/tour_spec.rb b/core/spec/screenshots/tour_spec.rb index abc1234..def5678 100644 --- a/core/spec/screenshots/tour_spec.rb +++ b/core/spec/screenshots/tour_spec.rb @@ -21,7 +21,6 @@ end it 'Interests page should be the same' do - create :user # HACK create user with id 2 (so t...
Revert "avoid using user 2" This reverts commit ff2b2e99b71191f3b5c33ac8f7bdeea11d8d3a19.
diff --git a/Casks/mamp.rb b/Casks/mamp.rb index abc1234..def5678 100644 --- a/Casks/mamp.rb +++ b/Casks/mamp.rb @@ -1,6 +1,6 @@ cask :v1 => 'mamp' do - version '3.3' - sha256 'fb50cfbf54c82f92808ae46bef50944a1c40fc607b43ad1767c78edc18d0b1d1' + version '3.4' + sha256 '4351c048f770b99bc69da6d5240e7b1cff2dbaef485dec7...
Update MAMP to version 3.4
diff --git a/db/migrate/20160914151500_add_pos_attribute_to_spree_order.rb b/db/migrate/20160914151500_add_pos_attribute_to_spree_order.rb index abc1234..def5678 100644 --- a/db/migrate/20160914151500_add_pos_attribute_to_spree_order.rb +++ b/db/migrate/20160914151500_add_pos_attribute_to_spree_order.rb @@ -1,5 +1,8 @@...
Check if the field already exists before creating it Since this fields already exists on our main host project, the migration is unable to run and it halts the whole process.
diff --git a/schema-evolution-manager.gemspec b/schema-evolution-manager.gemspec index abc1234..def5678 100644 --- a/schema-evolution-manager.gemspec +++ b/schema-evolution-manager.gemspec @@ -8,6 +8,7 @@ s.files = %w( README.md ) s.files += Dir.glob("bin/**/*") s.files += Di...
Add scripts directory, so that initial sem stuff is created
diff --git a/db/migrate/006_create_snippet_revisions.rb b/db/migrate/006_create_snippet_revisions.rb index abc1234..def5678 100644 --- a/db/migrate/006_create_snippet_revisions.rb +++ b/db/migrate/006_create_snippet_revisions.rb @@ -4,7 +4,7 @@ t.integer :snippet_id t.integer :number t.string :name ...
Use text instead of varchar(255) for snippets content, varchar(255) is too small for content
diff --git a/mongoid_auto_increment_id.gemspec b/mongoid_auto_increment_id.gemspec index abc1234..def5678 100644 --- a/mongoid_auto_increment_id.gemspec +++ b/mongoid_auto_increment_id.gemspec @@ -17,5 +17,5 @@ s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } s.require_paths = ["li...
Remove low version of Mongoid support, lock on 2.2.0
diff --git a/attributes/default.rb b/attributes/default.rb index abc1234..def5678 100644 --- a/attributes/default.rb +++ b/attributes/default.rb @@ -1,5 +1,5 @@ # installation -default.sensu.version = "0.9.13" +default.sensu.version = "0.9.13-1" default.sensu.use_unstable_repo = false default.sensu.directory = "/etc/...
Add build number to version
diff --git a/Casks/flowdock.rb b/Casks/flowdock.rb index abc1234..def5678 100644 --- a/Casks/flowdock.rb +++ b/Casks/flowdock.rb @@ -1,7 +1,7 @@ class Flowdock < Cask - url 'https://d2ph5hv9wbwvla.cloudfront.net/mac/Flowdock_v1_1_0.zip' + url 'https://flowdock-resources.s3.amazonaws.com/mac/Flowdock.zip' homepage ...
Update Flowdock to use version 'latest' & no_checksum
diff --git a/Casks/qlc-plus.rb b/Casks/qlc-plus.rb index abc1234..def5678 100644 --- a/Casks/qlc-plus.rb +++ b/Casks/qlc-plus.rb @@ -0,0 +1,10 @@+cask 'qlc-plus' do + version '4.11.1' + sha256 'd34804876fbac6fa6c1a5a4310d15cbdcf1423d460a9242b8f43453da4c964ec' + + url "http://qlcplus.org/downloads/#{version}/QLC+_#{v...
Add new cask QLC+.app v4.11.1
diff --git a/lib/rails_best_practices/reviews/not_rescue_exception_review.rb b/lib/rails_best_practices/reviews/not_rescue_exception_review.rb index abc1234..def5678 100644 --- a/lib/rails_best_practices/reviews/not_rescue_exception_review.rb +++ b/lib/rails_best_practices/reviews/not_rescue_exception_review.rb @@ -18,...
Fix grammar for "Not rescue Exception" This is not a grammatically correct sentence. The class should also probably be renamed.
diff --git a/lib/piggybak_braintree/payment_decorator.rb b/lib/piggybak_braintree/payment_decorator.rb index abc1234..def5678 100644 --- a/lib/piggybak_braintree/payment_decorator.rb +++ b/lib/piggybak_braintree/payment_decorator.rb @@ -6,8 +6,14 @@ attr_accessor :payment_method_nonce validates :payment_...
Remove validations if nonce presence
diff --git a/lib/ragnarson/stylecheck/rubocop_helpers.rb b/lib/ragnarson/stylecheck/rubocop_helpers.rb index abc1234..def5678 100644 --- a/lib/ragnarson/stylecheck/rubocop_helpers.rb +++ b/lib/ragnarson/stylecheck/rubocop_helpers.rb @@ -6,6 +6,22 @@ module RubocopHelpers class << self def config + ...
Allow to use local rubocop config by rake task. In some projects rubocop returns: ``` (Using Ruby 2.0 parser; configure using TargetRubyVersion parameter, under AllCops) ``` Different projects using different ruby versions. To fix this problem user should set TargetRubyVersion inside rubocop config. ``` inherit_gem:...
diff --git a/lib/vagrant-notify/action/check_provider.rb b/lib/vagrant-notify/action/check_provider.rb index abc1234..def5678 100644 --- a/lib/vagrant-notify/action/check_provider.rb +++ b/lib/vagrant-notify/action/check_provider.rb @@ -9,6 +9,8 @@ def call(env) env[:result] = true + # Cal...
Make sure everyone knows that CheckProvider is meant to be used along with vagrant's builtin Call action
diff --git a/app/models/organization.rb b/app/models/organization.rb index abc1234..def5678 100644 --- a/app/models/organization.rb +++ b/app/models/organization.rb @@ -17,7 +17,7 @@ # Get more information for that organisation data = octokit_client.organization(nickname) org = Organization.create( ...
Update org nickname from latest data
diff --git a/app/models/user_profile.rb b/app/models/user_profile.rb index abc1234..def5678 100644 --- a/app/models/user_profile.rb +++ b/app/models/user_profile.rb @@ -10,6 +10,8 @@ # class UserProfile < ActiveRecord::Base + attr_accessible :picture, :retained_picture, :website, :about + image_accessor :picture...
Allow users to set their picture, website and about text.
diff --git a/lib/generators/social_stream/documents/install_generator.rb b/lib/generators/social_stream/documents/install_generator.rb index abc1234..def5678 100644 --- a/lib/generators/social_stream/documents/install_generator.rb +++ b/lib/generators/social_stream/documents/install_generator.rb @@ -9,4 +9,16 @@ Ra...
Add javascripts and stylesheets to generator
diff --git a/chef/roles/vagrant.rb b/chef/roles/vagrant.rb index abc1234..def5678 100644 --- a/chef/roles/vagrant.rb +++ b/chef/roles/vagrant.rb @@ -37,4 +37,10 @@ :elasticsearch => { :allocated_memory => "512m", }, + + :torquebox => { + :backstage => { + :password => "admin", + }, + }, })
Set a default password for Backstage for local Vagrant development.
diff --git a/Silica.podspec b/Silica.podspec index abc1234..def5678 100644 --- a/Silica.podspec +++ b/Silica.podspec @@ -9,7 +9,7 @@ s.license = 'MIT' s.authors = { "Ian Ynda-Hummel" => "ianynda@gmail.com", "Steven Degutis" => "steven@cleancoders.com" } s.platform = :osx, '10.8' - s.source ...
Mark the pod as having submodules
diff --git a/spec/lib/requeue_content_spec.rb b/spec/lib/requeue_content_spec.rb index abc1234..def5678 100644 --- a/spec/lib/requeue_content_spec.rb +++ b/spec/lib/requeue_content_spec.rb @@ -19,7 +19,7 @@ expect(PublishingAPI.service(:queue_publisher)).to receive(:send_message) .exactly(1) .ti...
Make flaky test less specific This test is a bit flaky and sometimes breaks CI. Neither ContentItemFilter or ContentItem define an ordering, so it looks like this is non deterministic. I think all we really expect here is that one of the content items is returned, it doesn't matter which one.
diff --git a/app/controllers/concerns/webhook_validations.rb b/app/controllers/concerns/webhook_validations.rb index abc1234..def5678 100644 --- a/app/controllers/concerns/webhook_validations.rb +++ b/app/controllers/concerns/webhook_validations.rb @@ -6,7 +6,7 @@ if valid_incoming_webhook_address? true ...
Use :not_found instead of 404
diff --git a/app/controllers/property_elements_controller.rb b/app/controllers/property_elements_controller.rb index abc1234..def5678 100644 --- a/app/controllers/property_elements_controller.rb +++ b/app/controllers/property_elements_controller.rb @@ -7,7 +7,7 @@ @property_elements = @property.property_elements ...
Fix bug redirecting to new when property has no elements.
diff --git a/Formula/parity.rb b/Formula/parity.rb index abc1234..def5678 100644 --- a/Formula/parity.rb +++ b/Formula/parity.rb @@ -2,9 +2,9 @@ class Parity < Formula homepage "https://github.com/thoughtbot/parity" - url "https://github.com/thoughtbot/parity/releases/download/v0.9.1/parity-0.9.1-osx.tar.gz" - v...
Update Parity formula for v0.9.2 * Faster deploys, less interaction with development-machine Rake
diff --git a/robot-name/robot_name_test.rb b/robot-name/robot_name_test.rb index abc1234..def5678 100644 --- a/robot-name/robot_name_test.rb +++ b/robot-name/robot_name_test.rb @@ -4,7 +4,7 @@ class RobotTest < MiniTest::Unit::TestCase def test_has_name # rubocop:disable Lint/AmbiguousRegexpLiteral - assert_...
Remove lower-case letters from regex In the README for this problem the letters are always in upper case. And in the example solution, the `alphabet` method only returns upper case. So I didn't think the tests needed to check for lower case letters.
diff --git a/Verso.podspec b/Verso.podspec index abc1234..def5678 100644 --- a/Verso.podspec +++ b/Verso.podspec @@ -12,8 +12,7 @@ s.source = { :git => "https://github.com/eTilbudsavis/ios-verso.git", - :tag => "v" + s.version.to_s, - :submodules => true + :tag => "v" + s.v...
Remove submodules from podspec source
diff --git a/IDPDesign.podspec b/IDPDesign.podspec index abc1234..def5678 100644 --- a/IDPDesign.podspec +++ b/IDPDesign.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "IDPDesign" - s.version = "0.1.0" + s.version = "0.2.0" s.summary = "Placeholder" s.description = <<-DESC ...
Update pod version to 0.2.0
diff --git a/app/models/concerns/media_screenshot_archiver.rb b/app/models/concerns/media_screenshot_archiver.rb index abc1234..def5678 100644 --- a/app/models/concerns/media_screenshot_archiver.rb +++ b/app/models/concerns/media_screenshot_archiver.rb @@ -1,27 +1,27 @@ module MediaScreenshotArchiver extend ActiveSu...
Comment file related to screenshot archiver, that is not being used
diff --git a/Support/spec/spec_helper.rb b/Support/spec/spec_helper.rb index abc1234..def5678 100644 --- a/Support/spec/spec_helper.rb +++ b/Support/spec/spec_helper.rb @@ -5,7 +5,7 @@ module Spec::Example::ExampleMethods def set_env - root = File.expand_path(File.dirname(__FILE__) + '/../../../rspec') + roo...
Move relative location of rspec (core) directory.
diff --git a/rb/spec/unit/selenium/webdriver/remote/http/default_spec.rb b/rb/spec/unit/selenium/webdriver/remote/http/default_spec.rb index abc1234..def5678 100644 --- a/rb/spec/unit/selenium/webdriver/remote/http/default_spec.rb +++ b/rb/spec/unit/selenium/webdriver/remote/http/default_spec.rb @@ -29,6 +29,8 @@ ...
JariBakken: Update spec to check host of proxied HTTP client. git-svn-id: aa1aa1384423cb28c2b1e29129bb3a91de1d9196@10680 07704840-8298-11de-bf8c-fd130f914ac9
diff --git a/scss-lint.gemspec b/scss-lint.gemspec index abc1234..def5678 100644 --- a/scss-lint.gemspec +++ b/scss-lint.gemspec @@ -13,7 +13,7 @@ s.summary = 'SCSS lint tool' s.description = 'Opinionated tool that tells you whether or not your SCSS is "bad"' - s.files = `git ls-files -- lib`.split(...
Remove gemspec dependency on `git` Shelling out is unecessary, especially since no .rb files are gitignore'd. Using the same thing I did for `overcommit`: https://github.com/causes/overcommit/blob/master/overcommit.gemspec#L20-L22 Change-Id: I3fb732dc5e5c59cd618d34e7373084fcf9c238b3 Reviewed-on: https://gerrit.ca...