diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/src/test/entry.test.js b/src/test/entry.test.js index <HASH>..<HASH> 100644 --- a/src/test/entry.test.js +++ b/src/test/entry.test.js @@ -307,3 +307,26 @@ test('entry by duration with date', t => { t.end() }) + +test('entry duration whitespace', t => { + let e + e = new Entry(userId, '1-2pm ate 4 h...
Add tests with full entry parsing
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -80,7 +80,7 @@ setup( "Programming Language :: Python :: 3.8", ], keywords="api graphql protocol rest relay graphene", - packages=find_packages(exclude=["tests", "tests.*", "examples"]), + packages=fin...
Update excluded packages list to properly exclude examples pack… (#<I>) * examples package will not be installed with graphene
diff --git a/rxandroidble/src/main/java/com/polidea/rxandroidble/internal/RxBleLog.java b/rxandroidble/src/main/java/com/polidea/rxandroidble/internal/RxBleLog.java index <HASH>..<HASH> 100644 --- a/rxandroidble/src/main/java/com/polidea/rxandroidble/internal/RxBleLog.java +++ b/rxandroidble/src/main/java/com/polidea/r...
Fixed retention policy of RxBleLog log levels.
diff --git a/lib/pool.js b/lib/pool.js index <HASH>..<HASH> 100644 --- a/lib/pool.js +++ b/lib/pool.js @@ -22,32 +22,16 @@ class Pool { }, () => new Client(url, options)) } - stream (opts, factory, cb) { - if (cb === undefined) { - return new Promise((resolve, reject) => { - this.stream(opts, ...
refactor: pool doesn't need to create promise
diff --git a/api/server/router/volume/volume.go b/api/server/router/volume/volume.go index <HASH>..<HASH> 100644 --- a/api/server/router/volume/volume.go +++ b/api/server/router/volume/volume.go @@ -5,13 +5,13 @@ import ( "github.com/docker/docker/api/server/router/local" ) -// volumesRouter is a router to talk wi...
Modify improper comments in api/server/router/volume/volume.go
diff --git a/src/FamilySearch.js b/src/FamilySearch.js index <HASH>..<HASH> 100644 --- a/src/FamilySearch.js +++ b/src/FamilySearch.js @@ -24,7 +24,7 @@ * @param {String} options.tokenCookie Name of the cookie that the access token * will be saved in. */ - var FamilySearch = function(options){ + var Famil...
fix body processing and missing callback error
diff --git a/Classes/Domain/Repository/RedirectionRepository.php b/Classes/Domain/Repository/RedirectionRepository.php index <HASH>..<HASH> 100644 --- a/Classes/Domain/Repository/RedirectionRepository.php +++ b/Classes/Domain/Repository/RedirectionRepository.php @@ -87,6 +87,21 @@ class RedirectionRepository extends Re...
TASK: Use DQL and generator to find by target uri and host
diff --git a/config/admin/jsonadm/resource.php b/config/admin/jsonadm/resource.php index <HASH>..<HASH> 100644 --- a/config/admin/jsonadm/resource.php +++ b/config/admin/jsonadm/resource.php @@ -250,7 +250,7 @@ return [ * @param array List of user group names * @since 2017.10 */ - 'groups' => ['admin',...
Restrict locale/* resources to super admins only
diff --git a/discord/state.py b/discord/state.py index <HASH>..<HASH> 100644 --- a/discord/state.py +++ b/discord/state.py @@ -215,7 +215,7 @@ class ConnectionState: self.clear() - def clear(self) -> None: + def clear(self, *, views: bool = True) -> None: self.user: Optional[ClientUser] = No...
Don't clear views in READY
diff --git a/core/Object.php b/core/Object.php index <HASH>..<HASH> 100755 --- a/core/Object.php +++ b/core/Object.php @@ -418,9 +418,12 @@ abstract class Object { // merge with existing static vars $extensions = self::uninherited_static($class, 'extensions'); + // We use unshift rather than push so that...
BUGFIX: Ameneded r<I> so that the application order of extensions is the same as it was previously. git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@<I> <I>b<I>ca-7a2a-<I>-9d3b-<I>d<I>a<I>a9
diff --git a/src/Subjects/AbstractSubject.php b/src/Subjects/AbstractSubject.php index <HASH>..<HASH> 100644 --- a/src/Subjects/AbstractSubject.php +++ b/src/Subjects/AbstractSubject.php @@ -870,7 +870,7 @@ abstract class AbstractSubject implements SubjectInterface, FilesystemSubjectInt // log a message th...
Switch log level for message when a file has successfully been processed from info to notice to make it visible on CLI
diff --git a/src/cmdline/settings.py b/src/cmdline/settings.py index <HASH>..<HASH> 100644 --- a/src/cmdline/settings.py +++ b/src/cmdline/settings.py @@ -170,11 +170,12 @@ class SettingsParser(BaseCommand): parser.add_argument(arg, **_info) - if subcommands: + command_info = args.get('_C...
Add subcommands that do not have any additional settings
diff --git a/lib/Github/Api/Repo.php b/lib/Github/Api/Repo.php index <HASH>..<HASH> 100644 --- a/lib/Github/Api/Repo.php +++ b/lib/Github/Api/Repo.php @@ -143,6 +143,20 @@ class Repo extends AbstractApi { return $this->delete('repos/'.rawurlencode($username).'/'.rawurlencode($repository)); } + + ...
Add API request to get the readme content Adding a `readme` method to the repo api to get the readme for a repository. This is described by <URL>
diff --git a/src/components/column/Column.js b/src/components/column/Column.js index <HASH>..<HASH> 100644 --- a/src/components/column/Column.js +++ b/src/components/column/Column.js @@ -41,7 +41,8 @@ export class Column extends Component { excludeGlobalFilter: false, rowReorder: false, rowRe...
Fixed #<I> - Add exportable property to Column
diff --git a/api/src/main/java/org/ehcache/resilience/ResilienceStrategy.java b/api/src/main/java/org/ehcache/resilience/ResilienceStrategy.java index <HASH>..<HASH> 100644 --- a/api/src/main/java/org/ehcache/resilience/ResilienceStrategy.java +++ b/api/src/main/java/org/ehcache/resilience/ResilienceStrategy.java @@ -2...
#<I> : add javadoc clarifying writer/loader and resilience strategy interactions
diff --git a/nodeserver/src/client/js/corewrapper.js b/nodeserver/src/client/js/corewrapper.js index <HASH>..<HASH> 100644 --- a/nodeserver/src/client/js/corewrapper.js +++ b/nodeserver/src/client/js/corewrapper.js @@ -881,6 +881,7 @@ define(['logManager', }; ClientNode = function(node,core){ var o...
getChildrenIds was corrected Former-commit-id: db7f<I>cbfe<I>c<I>bb<I>c<I>dea<I>f<I>
diff --git a/lib/util/wrap.js b/lib/util/wrap.js index <HASH>..<HASH> 100644 --- a/lib/util/wrap.js +++ b/lib/util/wrap.js @@ -23,16 +23,16 @@ exports.wrapExport = function (wrapFunction, required, optional) { var collectOptions = true; if (length === 1 && (first instanceof Object)) { assum...
Fix if there is only one argument and the function has no required arguments Will now search through all the optional arguments.
diff --git a/src/resolvers/helpers/filter.js b/src/resolvers/helpers/filter.js index <HASH>..<HASH> 100644 --- a/src/resolvers/helpers/filter.js +++ b/src/resolvers/helpers/filter.js @@ -77,6 +77,10 @@ export const filterHelperArgs = ( ); } + if (inputComposer.getFieldNames().length === 0) { + return {}; ...
fix filterHelper, it does not return `filter` arg, if its fields are empty
diff --git a/src/UrlRoute.php b/src/UrlRoute.php index <HASH>..<HASH> 100644 --- a/src/UrlRoute.php +++ b/src/UrlRoute.php @@ -29,7 +29,7 @@ class UrlRoute extends Route { return $this->callback; } - public function dispatch(array $args) { + public function dispatch(array &$args) { $callb...
UrlRoute fix and doc comments.
diff --git a/openquake/commands/restore.py b/openquake/commands/restore.py index <HASH>..<HASH> 100644 --- a/openquake/commands/restore.py +++ b/openquake/commands/restore.py @@ -22,6 +22,7 @@ import time import os.path import zipfile import sqlite3 +import requests from openquake.baselib import sap from openquake...
Extended oq restore to download from URLs [skip CI] Former-commit-id: dcc<I>c<I>a0ff3c<I>d7d<I>e<I>b<I>f<I>f
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -21,6 +21,7 @@ setup( version=version, description='Python API for accessing the REST API of the Xero accounting tool.', long_description=long_description, + long_description_content_type='text/markdown', ...
Corrected markup content type for long description.
diff --git a/src/components/inputs/select-input/select-input.spec.js b/src/components/inputs/select-input/select-input.spec.js index <HASH>..<HASH> 100644 --- a/src/components/inputs/select-input/select-input.spec.js +++ b/src/components/inputs/select-input/select-input.spec.js @@ -116,6 +116,25 @@ describe('in single ...
chore(select-input): add test for when autoFocussed is true (#<I>) * chore(select-input): add test for when autoFocussed is true
diff --git a/test/specs/utils/Sorter.js b/test/specs/utils/Sorter.js index <HASH>..<HASH> 100644 --- a/test/specs/utils/Sorter.js +++ b/test/specs/utils/Sorter.js @@ -1,7 +1,8 @@ -var Sorter = require('undefined'); +// import Sorter from '../../../src/utils/Sorter.js' -describe('Sorter', () => { - var fixtures; +// ...
Skip sorter test (awaiting migrate to jest)
diff --git a/Framework/FileOrganiser.php b/Framework/FileOrganiser.php index <HASH>..<HASH> 100644 --- a/Framework/FileOrganiser.php +++ b/Framework/FileOrganiser.php @@ -4,7 +4,19 @@ * of the FileOrganiser to copy the required files into the webroot when * required. The files may need to be minified and compiled b...
Started re-implementing FileOrganiser for #<I>
diff --git a/lib/dml/mysqli_native_moodle_database.php b/lib/dml/mysqli_native_moodle_database.php index <HASH>..<HASH> 100644 --- a/lib/dml/mysqli_native_moodle_database.php +++ b/lib/dml/mysqli_native_moodle_database.php @@ -853,8 +853,8 @@ class mysqli_native_moodle_database extends moodle_database { re...
MDL-<I> improve emulate_bound_params() for mysqli Looping over large numbers of items with array_shift() is expensive. Reverse the array and fetch items from the top of the pile.
diff --git a/src/index.js b/src/index.js index <HASH>..<HASH> 100644 --- a/src/index.js +++ b/src/index.js @@ -161,7 +161,14 @@ class DissectHtml { babelJs(js) { try { return Babel.transform(js, { - presets: ['es2015'] + presets: [ + ['es2015', + { + modules...
babel blacklist use strict. #9
diff --git a/Minecraft/src/main/java/com/microsoft/Malmo/MissionHandlers/DiscreteMovementCommandsImplementation.java b/Minecraft/src/main/java/com/microsoft/Malmo/MissionHandlers/DiscreteMovementCommandsImplementation.java index <HASH>..<HASH> 100755 --- a/Minecraft/src/main/java/com/microsoft/Malmo/MissionHandlers/Dis...
Less stupid fix for discrete -ve movement.
diff --git a/spec/viewport_spec.rb b/spec/viewport_spec.rb index <HASH>..<HASH> 100644 --- a/spec/viewport_spec.rb +++ b/spec/viewport_spec.rb @@ -8,6 +8,6 @@ describe Remedy::Viewport do joke << "A: Purple, because ice cream has no bones!" screen = ::Remedy::Viewport.new - screen.draw joke + screen.d...
Don't actually execute draw if we're on CI, since it will break.
diff --git a/lib/test-server/client/slave-client.js b/lib/test-server/client/slave-client.js index <HASH>..<HASH> 100644 --- a/lib/test-server/client/slave-client.js +++ b/lib/test-server/client/slave-client.js @@ -251,7 +251,8 @@ var replaceConsoleFunction = function (console, name, scope) { var oldFunct...
fix #<I> On IE versions older than 9 native methods on the "console" object don't have an "apply" method The workaround is to call the generic "apply" (from "Function"'s prototype) using its own "call" method with proper arguments.
diff --git a/lib/branch_io_cli/command/report_command.rb b/lib/branch_io_cli/command/report_command.rb index <HASH>..<HASH> 100644 --- a/lib/branch_io_cli/command/report_command.rb +++ b/lib/branch_io_cli/command/report_command.rb @@ -294,16 +294,9 @@ EOF # String containing information relevant to Branch setu...
Removed some things from the Branch report
diff --git a/lib/launchy/application.rb b/lib/launchy/application.rb index <HASH>..<HASH> 100644 --- a/lib/launchy/application.rb +++ b/lib/launchy/application.rb @@ -148,14 +148,11 @@ module Launchy if my_os_family == :windows then # NOTE: the command is purposely omitted here because - # ...
Fixed a bug in launching a browser in Windows
diff --git a/lib/picker.js b/lib/picker.js index <HASH>..<HASH> 100644 --- a/lib/picker.js +++ b/lib/picker.js @@ -274,7 +274,9 @@ function PickerConstructor( ELEMENT, NAME, COMPONENT, OPTIONS ) { // * In Firefox stopPropagation() doesn’t prevent right-click events from bubbling, ...
Prevent Chrome <I> autofill from closing the picker Closes #<I> Thanks go to @Mwni for finding a solution
diff --git a/pkg/registry/service/rest_test.go b/pkg/registry/service/rest_test.go index <HASH>..<HASH> 100644 --- a/pkg/registry/service/rest_test.go +++ b/pkg/registry/service/rest_test.go @@ -569,6 +569,7 @@ func TestServiceRegistryIPAllocation(t *testing.T) { for _, ip := range testIPs { if !rest.serviceIPs.(*...
Fix the issue which TestServiceRegistryIPUpdate will randomly run failed.
diff --git a/lib/active_mocker/display_errors.rb b/lib/active_mocker/display_errors.rb index <HASH>..<HASH> 100644 --- a/lib/active_mocker/display_errors.rb +++ b/lib/active_mocker/display_errors.rb @@ -68,12 +68,3 @@ module ActiveMocker end end end - -class String - def colorize(*args) - require "colorize...
Remove hack for String#colorize that would cause the error: "NoMethodError: super: no superclass method `colorize' for #<String>"
diff --git a/go/test/endtoend/vtgate/queries/union/main_test.go b/go/test/endtoend/vtgate/queries/union/main_test.go index <HASH>..<HASH> 100644 --- a/go/test/endtoend/vtgate/queries/union/main_test.go +++ b/go/test/endtoend/vtgate/queries/union/main_test.go @@ -28,8 +28,8 @@ import ( var ( clusterInstance *cluster....
Removed build keyspace graph from union main test
diff --git a/config/configuration.js b/config/configuration.js index <HASH>..<HASH> 100644 --- a/config/configuration.js +++ b/config/configuration.js @@ -7,7 +7,7 @@ var node_env = process.env.NODE_ENV || "development"; var default_port = 8000; var default_tika_version = '1.4'; -var default_tika_path = "/etc/tika-...
Updated default tika_path
diff --git a/infrastructure.go b/infrastructure.go index <HASH>..<HASH> 100644 --- a/infrastructure.go +++ b/infrastructure.go @@ -1211,8 +1211,6 @@ func New(config *ConnConfig, ntfnHandlers *NotificationHandlers) (*Client, error start = true } } - log.Infof("Established connection to RPC server %s", - config...
Fix "Established connection" log message. Don't log "Established connection" message on new when DisableConnectOnNew is set and no connection was actually established. Do log that same message when Connect() successfully connects.
diff --git a/lib/celerity/element_locator.rb b/lib/celerity/element_locator.rb index <HASH>..<HASH> 100644 --- a/lib/celerity/element_locator.rb +++ b/lib/celerity/element_locator.rb @@ -77,13 +77,13 @@ module Celerity def find_by_id(what) case what when Regexp - elements_by_tag_names.find { |...
Fix spec failure when locating elements by id (caused by <I> API changes)
diff --git a/tests/func/experiments/test_queue.py b/tests/func/experiments/test_queue.py index <HASH>..<HASH> 100644 --- a/tests/func/experiments/test_queue.py +++ b/tests/func/experiments/test_queue.py @@ -42,6 +42,7 @@ def failed_tasks(tmp_dir, dvc, scm, test_queue, failed_exp_stage): return name_list +@pyte...
tests: mark exp queue func tests xfail (#<I>)
diff --git a/src/java/liquibase/ext/mssql/change/LoadDataChangeMSSQL.java b/src/java/liquibase/ext/mssql/change/LoadDataChangeMSSQL.java index <HASH>..<HASH> 100644 --- a/src/java/liquibase/ext/mssql/change/LoadDataChangeMSSQL.java +++ b/src/java/liquibase/ext/mssql/change/LoadDataChangeMSSQL.java @@ -10,7 +10,7 @@ imp...
bugfix: increased LoadDataChangeMSSQL priority
diff --git a/src/Ups.php b/src/Ups.php index <HASH>..<HASH> 100644 --- a/src/Ups.php +++ b/src/Ups.php @@ -139,7 +139,11 @@ abstract class Ups implements LoggerAwareInterface $accessRequest->appendChild($xml->createElement('AccessLicenseNumber', $this->accessKey)); $accessRequest->appendChild($xml->...
Fixed issue with passwords contains !
diff --git a/test/HTMLCollection.test.php b/test/HTMLCollection.test.php index <HASH>..<HASH> 100644 --- a/test/HTMLCollection.test.php +++ b/test/HTMLCollection.test.php @@ -20,4 +20,14 @@ public function testNonElementsRemoved() { $this->assertInstanceOf("\phpgt\dom\Element", $bodyChildren->item(0)); } +public f...
Add tests for HTMLDocument->forms property
diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java index <HASH>..<HASH> 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumen...
Fix query plan cache initialization (#<I>) * Fix query plan cache initialization * Update sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java Removing the cache intialization from init method.
diff --git a/vendor/seahorse/spec/seahorse/client/configuration_spec.rb b/vendor/seahorse/spec/seahorse/client/configuration_spec.rb index <HASH>..<HASH> 100644 --- a/vendor/seahorse/spec/seahorse/client/configuration_spec.rb +++ b/vendor/seahorse/spec/seahorse/client/configuration_spec.rb @@ -103,6 +103,19 @@ module S...
Added a spec for ensuring default configuration values resolve until a non-nil value is found.
diff --git a/Malmo/samples/Python_examples/tabular_q_learning.py b/Malmo/samples/Python_examples/tabular_q_learning.py index <HASH>..<HASH> 100755 --- a/Malmo/samples/Python_examples/tabular_q_learning.py +++ b/Malmo/samples/Python_examples/tabular_q_learning.py @@ -126,7 +126,9 @@ class TabQAgent: world_state...
Minor: printing any errors received is good practice.
diff --git a/spec/researches/fleschReadingSpec.js b/spec/researches/fleschReadingSpec.js index <HASH>..<HASH> 100644 --- a/spec/researches/fleschReadingSpec.js +++ b/spec/researches/fleschReadingSpec.js @@ -7,7 +7,6 @@ describe("a test to calculate the fleschReading score", function(){ var mockPaper = new Paper( "A ...
Removes todo from spec
diff --git a/openid/consumer/consumer.py b/openid/consumer/consumer.py index <HASH>..<HASH> 100644 --- a/openid/consumer/consumer.py +++ b/openid/consumer/consumer.py @@ -446,10 +446,12 @@ class GenericConsumer(object): (identity_url, delegate, server_url) = pieces - if yadis_available and xri.ident...
[project @ Handle error conditions better in complete.]
diff --git a/Repository/ResourceQueryBuilder.php b/Repository/ResourceQueryBuilder.php index <HASH>..<HASH> 100644 --- a/Repository/ResourceQueryBuilder.php +++ b/Repository/ResourceQueryBuilder.php @@ -399,10 +399,10 @@ class ResourceQueryBuilder /** * Filters nodes that are published. * - * @para...
[CoreBundle] Fixing view as for resource manager.
diff --git a/bika/lims/upgrade/to1117.py b/bika/lims/upgrade/to1117.py index <HASH>..<HASH> 100644 --- a/bika/lims/upgrade/to1117.py +++ b/bika/lims/upgrade/to1117.py @@ -9,4 +9,5 @@ def upgrade(tool): portal = aq_parent(aq_inner(tool)) setup = portal.portal_setup - setup.runImportStepFromProfile('profil...
Upgrade <I> - add run_dependencies=False Somehow re-importing the 'portlets' step, causes a beforeDelete handler to fail a HoldingReference check.
diff --git a/src/Illuminate/Support/helpers.php b/src/Illuminate/Support/helpers.php index <HASH>..<HASH> 100755 --- a/src/Illuminate/Support/helpers.php +++ b/src/Illuminate/Support/helpers.php @@ -476,18 +476,23 @@ if ( ! function_exists('env')) { $value = getenv($key); - switch (strtolower($value)) { + swit...
Fixing a few formatting things.
diff --git a/test/daemon_runner/shell_out_test.rb b/test/daemon_runner/shell_out_test.rb index <HASH>..<HASH> 100644 --- a/test/daemon_runner/shell_out_test.rb +++ b/test/daemon_runner/shell_out_test.rb @@ -94,7 +94,7 @@ class ShellOutTest < Minitest::Test assert_equal [1], shellout.valid_exit_codes end - de...
Provide better test names for wait2 tests.
diff --git a/lib/Doctrine/ORM/Persisters/ManyToManyPersister.php b/lib/Doctrine/ORM/Persisters/ManyToManyPersister.php index <HASH>..<HASH> 100644 --- a/lib/Doctrine/ORM/Persisters/ManyToManyPersister.php +++ b/lib/Doctrine/ORM/Persisters/ManyToManyPersister.php @@ -289,8 +289,9 @@ class ManyToManyPersister extends Abs...
#<I> DDC-<I> - removed unused assignment, direct return instead
diff --git a/test/test.js b/test/test.js index <HASH>..<HASH> 100644 --- a/test/test.js +++ b/test/test.js @@ -551,6 +551,22 @@ describe('S3rver Tests', function () { }); }); + + it('should list objects in a bucket filtered by a prefix 2', function (done) { + s3Client.listObjectsV2({ 'Bucket': buckets[1],...
test(listObjects): Adds test for issue #<I>
diff --git a/terms/html.py b/terms/html.py index <HASH>..<HASH> 100644 --- a/terms/html.py +++ b/terms/html.py @@ -73,8 +73,8 @@ def get_interesting_contents(parent_node, replace_regexp): if TERMS_ENABLED: - def replace_terms(html): - html = force_text(html) + def replace_terms(original_html): + ...
If nothing interesting is found, return the original HTML instead of rebuilding it.
diff --git a/storage/src/main/java/de/citec/jul/storage/registry/Registry.java b/storage/src/main/java/de/citec/jul/storage/registry/Registry.java index <HASH>..<HASH> 100644 --- a/storage/src/main/java/de/citec/jul/storage/registry/Registry.java +++ b/storage/src/main/java/de/citec/jul/storage/registry/Registry.java @...
handle wrong consistency handling in case no handler is registered.
diff --git a/escpos/config.py b/escpos/config.py index <HASH>..<HASH> 100644 --- a/escpos/config.py +++ b/escpos/config.py @@ -27,8 +27,7 @@ class Config(object): ) try: - with open(config_path) as f: - config = yaml.load(f) + config = yaml.safe_load(f) ...
Convert to safe load. Also now allows loading everyting pyyaml supports
diff --git a/cmd/daily-lifecycle-ops.go b/cmd/daily-lifecycle-ops.go index <HASH>..<HASH> 100644 --- a/cmd/daily-lifecycle-ops.go +++ b/cmd/daily-lifecycle-ops.go @@ -44,22 +44,12 @@ func startDailyLifecycle(ctx context.Context, objAPI ObjectLayer) { return case <-time.NewTimer(bgLifecycleInterval).C: // Per...
fix: cleanup lifecycle unused code (#<I>)
diff --git a/Zebra_Database.php b/Zebra_Database.php index <HASH>..<HASH> 100644 --- a/Zebra_Database.php +++ b/Zebra_Database.php @@ -633,6 +633,8 @@ class Zebra_Database 'user' => $user, 'password' => $password, 'database' => $database, + 'port' => $po...
Fixed port and socket not used even if set Thanks to Nam Trung for reporting
diff --git a/lib/minify.js b/lib/minify.js index <HASH>..<HASH> 100644 --- a/lib/minify.js +++ b/lib/minify.js @@ -30,10 +30,10 @@ function check(name, callback) { if (!name) - throw(Error('name could not be empty!')); + throw Error('name could not be empty!'); ...
chore(minify) throw() -> throw
diff --git a/tests/asm/test_risks.py b/tests/asm/test_risks.py index <HASH>..<HASH> 100644 --- a/tests/asm/test_risks.py +++ b/tests/asm/test_risks.py @@ -125,7 +125,7 @@ TEST_RISK_TYPE_JSON = { "type": "string", } TEST_RISK_TYPES_JSON = { - "constants": [TEST_RISK_TYPE_JSON], + "type": [TEST_RISK_TYPE_JSO...
fix:update language to match pipeline/discover
diff --git a/demo/http.php b/demo/http.php index <HASH>..<HASH> 100644 --- a/demo/http.php +++ b/demo/http.php @@ -6,4 +6,24 @@ if (isset($_GET['sleep'])) { sleep(10); } +if (isset($_GET['img'])) { + $fp = fopen(__DIR__ . '/../website/template/img/logo-small.png', 'rb'); + header('Content-Type: image/png'...
Add cases to manually test #<I>
diff --git a/gui/src/main/java/org/jboss/as/console/client/domain/model/impl/HostInfoStoreImpl.java b/gui/src/main/java/org/jboss/as/console/client/domain/model/impl/HostInfoStoreImpl.java index <HASH>..<HASH> 100644 --- a/gui/src/main/java/org/jboss/as/console/client/domain/model/impl/HostInfoStoreImpl.java +++ b/gui/...
don't use caching when fetching server instances
diff --git a/Core/Listener/PackageInstalledListener.php b/Core/Listener/PackageInstalledListener.php index <HASH>..<HASH> 100644 --- a/Core/Listener/PackageInstalledListener.php +++ b/Core/Listener/PackageInstalledListener.php @@ -28,13 +28,14 @@ use Symfony\Component\Process\Process; class PackageInstalledListener ...
Valorized the event listener success param, according with the operation result
diff --git a/src/zgor/ZSprite.js b/src/zgor/ZSprite.js index <HASH>..<HASH> 100644 --- a/src/zgor/ZSprite.js +++ b/src/zgor/ZSprite.js @@ -390,36 +390,6 @@ zgor.ZSprite.prototype.getElement = function() }; /** - * @override - * @public - */ -zgor.ZSprite.prototype.onAddedToStage = function() -{ - // inherited fr...
removed rudimentary event methods from zSprite
diff --git a/torrent.go b/torrent.go index <HASH>..<HASH> 100644 --- a/torrent.go +++ b/torrent.go @@ -387,6 +387,8 @@ func (t *Torrent) cacheLength() { t.length = &l } +// TODO: This shouldn't fail for storage reasons. Instead we should handle storage failure +// separately. func (t *Torrent) setInfo(info *metai...
Add TODOs around setting info bytes
diff --git a/biocommons/seqrepo/fastadir/fastadir.py b/biocommons/seqrepo/fastadir/fastadir.py index <HASH>..<HASH> 100644 --- a/biocommons/seqrepo/fastadir/fastadir.py +++ b/biocommons/seqrepo/fastadir/fastadir.py @@ -88,7 +88,7 @@ class FastaDir(BaseReader, BaseWriter): yield recd def __len__(self...
fixed KeyError in FastaDir.__len__ and added test
diff --git a/lib/config.js b/lib/config.js index <HASH>..<HASH> 100644 --- a/lib/config.js +++ b/lib/config.js @@ -64,9 +64,9 @@ function importEnvVars(collection, envPrefix) { envValue = process.env[envKey]; if ((typeof(value) == 'number') || (typeof(value) == 'string') || (typeof(value) == 'boolean') ||...
Make the config environment variable override mechanism support environment variables that contain true/on or false/off.
diff --git a/pygccxml/parser/scanner.py b/pygccxml/parser/scanner.py index <HASH>..<HASH> 100644 --- a/pygccxml/parser/scanner.py +++ b/pygccxml/parser/scanner.py @@ -218,11 +218,9 @@ class scanner_t(xml.sax.handler.ContentHandler): file_text = self.__files_text.get(file_decl) # Use lines and ...
Revert part of column change Use the start column of the comment on each line. Use the end column only on the last line.
diff --git a/session.go b/session.go index <HASH>..<HASH> 100644 --- a/session.go +++ b/session.go @@ -590,7 +590,9 @@ runLoop: default: } } - } else if !processedUndecryptablePacket { + } + // If we processed any undecryptable packets, jump to the resetting of the timers directly. + if !processedUnde...
enter the regular run loop if no undecryptable packet was processed
diff --git a/lib/plucky/criteria_hash.rb b/lib/plucky/criteria_hash.rb index <HASH>..<HASH> 100644 --- a/lib/plucky/criteria_hash.rb +++ b/lib/plucky/criteria_hash.rb @@ -72,7 +72,7 @@ module Plucky end def object_ids=(value) - raise ArgumentError unless value.respond_to?(:flatten) + raise Argumen...
Ruby <I> fix. Hashes respond to flatten so just allowing arrays which should be fine.
diff --git a/src/clusterpost-provider/executionserver.handlers.js b/src/clusterpost-provider/executionserver.handlers.js index <HASH>..<HASH> 100644 --- a/src/clusterpost-provider/executionserver.handlers.js +++ b/src/clusterpost-provider/executionserver.handlers.js @@ -14,6 +14,23 @@ module.exports = function (server,...
ENH: Add validation function logic here The package clusterpost-auth is deprecated now The token validation for the execution server is performed here
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -85,7 +85,7 @@ setup( # your project is installed. For an analysis of "install_requires" vs pip's # requirements files see: # https://packaging.python.org/en/latest/requirements.html - install_requires=['requ...
adding six to the setup see also #<I>
diff --git a/src/Administration/Resources/e2e/routes/cypress.js b/src/Administration/Resources/e2e/routes/cypress.js index <HASH>..<HASH> 100644 --- a/src/Administration/Resources/e2e/routes/cypress.js +++ b/src/Administration/Resources/e2e/routes/cypress.js @@ -4,7 +4,7 @@ const childProcess = require('child_process')...
NTR - increase maxBuffer
diff --git a/chess/uci.py b/chess/uci.py index <HASH>..<HASH> 100644 --- a/chess/uci.py +++ b/chess/uci.py @@ -901,7 +901,13 @@ class Engine(object): future.add_done_callback(async_callback) return future else: - return future.result() + # Avoid calling future.re...
Avoid calling future.result() without a timeout (#<I>)
diff --git a/head.go b/head.go index <HASH>..<HASH> 100644 --- a/head.go +++ b/head.go @@ -1364,7 +1364,6 @@ type memSeries struct { firstChunkID int nextAt int64 // Timestamp at which to cut the next chunk. - lastValue float64 sampleBuf [4]sample pendingCommit bool // Whether there are samples...
Use sampleBuf instead of maintaining lastValue. (#<I>) This cuts the size of memSize by 8B.
diff --git a/ceph_deploy/tests/unit/hosts/test_suse.py b/ceph_deploy/tests/unit/hosts/test_suse.py index <HASH>..<HASH> 100644 --- a/ceph_deploy/tests/unit/hosts/test_suse.py +++ b/ceph_deploy/tests/unit/hosts/test_suse.py @@ -19,7 +19,7 @@ class TestSuseInit(object): init_type = self.host.choose_init() ...
functionnames cant have '.' in the name
diff --git a/Trustly/Data/jsonrpcresponse.php b/Trustly/Data/jsonrpcresponse.php index <HASH>..<HASH> 100644 --- a/Trustly/Data/jsonrpcresponse.php +++ b/Trustly/Data/jsonrpcresponse.php @@ -33,15 +33,15 @@ class Trustly_Data_JSONRPCResponse extends Trustly_Data_Response { } public function getErrorCode() { - if...
Collect the error in the correct location
diff --git a/lib/functions/image.js b/lib/functions/image.js index <HASH>..<HASH> 100644 --- a/lib/functions/image.js +++ b/lib/functions/image.js @@ -62,16 +62,18 @@ Image.prototype.close = function(){ Image.prototype.type = function(){ var type - , chunk = fs.readSync(this.fd, 10, 0)[0]; + , buf = new Buf...
Refactored Image#type()
diff --git a/lib/compiler.js b/lib/compiler.js index <HASH>..<HASH> 100644 --- a/lib/compiler.js +++ b/lib/compiler.js @@ -1,6 +1,5 @@ 'use strict'; -var fs = require('fs'); var utils = require('./utils'); /**
Compiler no longer uses fs, removing require
diff --git a/Tests/Functional/FunctionalTest.php b/Tests/Functional/FunctionalTest.php index <HASH>..<HASH> 100644 --- a/Tests/Functional/FunctionalTest.php +++ b/Tests/Functional/FunctionalTest.php @@ -223,7 +223,7 @@ class FunctionalTest extends WebTestCase 'dateAsInterface' => [ ...
Add ',' in the end of array
diff --git a/tests/scripts/install_odoo.py b/tests/scripts/install_odoo.py index <HASH>..<HASH> 100755 --- a/tests/scripts/install_odoo.py +++ b/tests/scripts/install_odoo.py @@ -50,6 +50,8 @@ def install_odoo(): subprocess.check_call(["pip", "install", "pyyaml<4"]) # Odoo not compatible with werkzeug 1.0: ht...
Workaround Odoo jinja2 compatibility issue
diff --git a/lib/model/precondition.rb b/lib/model/precondition.rb index <HASH>..<HASH> 100644 --- a/lib/model/precondition.rb +++ b/lib/model/precondition.rb @@ -43,7 +43,7 @@ module SimpleXml handle_temporal elsif attr_val('@type') == DATETIMEDIFF handle_grouping_functional - elsif attr_...
Correctly handle SATISFIES clauses within subset operators
diff --git a/Kwc/Form/Component.defer.js b/Kwc/Form/Component.defer.js index <HASH>..<HASH> 100644 --- a/Kwc/Form/Component.defer.js +++ b/Kwc/Form/Component.defer.js @@ -52,6 +52,8 @@ Kwc.Form.Component = function(form) } }, this); + this.errorStyle = new Kwf.FrontendForm.errorStyles[this.config.err...
moved code for errorStyle before form fields init in frontendForm
diff --git a/drivers/virtualbox/virtualbox.go b/drivers/virtualbox/virtualbox.go index <HASH>..<HASH> 100644 --- a/drivers/virtualbox/virtualbox.go +++ b/drivers/virtualbox/virtualbox.go @@ -656,9 +656,7 @@ func getAvailableTCPPort(port int) (int, error) { port = 0 // Throw away the port hint before trying again ...
Remove stray sleep() This is just a bit of development debris.
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -70,7 +70,7 @@ http://<thumbor-server>/300x200/smart/s.glbimg.com/et/bb/f/original/2011/03/24/V install_requires=[ "tornado>=2.1.1,<2.2.0", - "pyCrypto>=2.4.1,<2.5.0", + "pyCrypto>=2.4.1",...
as ubuntu <I> comes with python-crypto <I>-2, Thumbor does not want starting
diff --git a/djangui/backend/ast/source_parser.py b/djangui/backend/ast/source_parser.py index <HASH>..<HASH> 100644 --- a/djangui/backend/ast/source_parser.py +++ b/djangui/backend/ast/source_parser.py @@ -123,9 +123,9 @@ def walk_tree(node): for key, value in d.items(): if isinstance(value, list): ...
fix for argparse being defined inside the __main__ statement
diff --git a/spec/lib/bootstrap_forms/form_builder_spec.rb b/spec/lib/bootstrap_forms/form_builder_spec.rb index <HASH>..<HASH> 100644 --- a/spec/lib/bootstrap_forms/form_builder_spec.rb +++ b/spec/lib/bootstrap_forms/form_builder_spec.rb @@ -97,7 +97,7 @@ describe 'BootstrapForms::FormBuilder' do end ...
use hashrockets for < Ruby <I>
diff --git a/src/service.js b/src/service.js index <HASH>..<HASH> 100644 --- a/src/service.js +++ b/src/service.js @@ -139,9 +139,9 @@ class Service { if (this.id === '_id') { // We can not update default mongo ids delete data[this.id]; - } else if (data[this.id] === undefined) { - // If not ...
enforcing that you shouldn't be able to change ids
diff --git a/nrrd.py b/nrrd.py index <HASH>..<HASH> 100644 --- a/nrrd.py +++ b/nrrd.py @@ -288,11 +288,12 @@ def read_header(nrrdfile): it = iter(nrrdfile) - headerSize += _validate_magic_line(it.next()) + headerSize += _validate_magic_line(next(it).decode('ascii')) header = { 'keyvaluepairs': {} ...
Python 3 compatibility - Decode header as ASCII to work with Python 3 (as is assumed in NRRD format, <URL>) - next(it) instead of it.next() Changes work for Python 2 & 3
diff --git a/code/Helpers/ConfigParser.php b/code/Helpers/ConfigParser.php index <HASH>..<HASH> 100644 --- a/code/Helpers/ConfigParser.php +++ b/code/Helpers/ConfigParser.php @@ -201,7 +201,10 @@ class ConfigParser $arguments = isset($matches[2]) ? $matches[2] : ''; foreach ($this->config->p...
BUGFIX: check for provider class exists
diff --git a/craftai/client.py b/craftai/client.py index <HASH>..<HASH> 100644 --- a/craftai/client.py +++ b/craftai/client.py @@ -32,7 +32,7 @@ class CraftAIClient(object): """ or invalid token provided.""") if (not isinstance(cfg.get("project"), six.string_types)): ...
Fix the error message when the project is badly set
diff --git a/lib/plugins/processor/index.js b/lib/plugins/processor/index.js index <HASH>..<HASH> 100644 --- a/lib/plugins/processor/index.js +++ b/lib/plugins/processor/index.js @@ -315,7 +315,8 @@ extend.processor.register(/^([^_].*)\.(\w+)/, function(file, callback){ if (renderer.indexOf(extname) === -1){ ...
Processor: Write source file with stream
diff --git a/src/test/java/org/reflections/ReflectionsTest.java b/src/test/java/org/reflections/ReflectionsTest.java index <HASH>..<HASH> 100644 --- a/src/test/java/org/reflections/ReflectionsTest.java +++ b/src/test/java/org/reflections/ReflectionsTest.java @@ -214,7 +214,7 @@ public class ReflectionsTest { @Te...
Fix inconsistency in unit tests related to testModel-reflections.xml The META-INF/reflections/testModel-reflections.xml file is created by ReflectionsCollectTest, and its presence was expected in ReflectionsTest.testResourcesScanner(). The assertion wasn't always satisfied, depending on the order of execution of tests...
diff --git a/src/FeedIo/FeedIo.php b/src/FeedIo/FeedIo.php index <HASH>..<HASH> 100644 --- a/src/FeedIo/FeedIo.php +++ b/src/FeedIo/FeedIo.php @@ -45,9 +45,8 @@ class FeedIo public function __construct(ClientInterface $client, LoggerInterface $logger) { $this->logger = $logger; - $this->reader...
getter and setter for the reader attribute
diff --git a/test/TestCases.template.js b/test/TestCases.template.js index <HASH>..<HASH> 100644 --- a/test/TestCases.template.js +++ b/test/TestCases.template.js @@ -199,7 +199,7 @@ const describeCases = config => { return; function _it(title, fn) { - exportedTests.push({ title, fn, ...
increase timeout for TestCases to <I>s
diff --git a/src/java/org/archive/wayback/http11resourcestore/Http11ResourceStore.java b/src/java/org/archive/wayback/http11resourcestore/Http11ResourceStore.java index <HASH>..<HASH> 100644 --- a/src/java/org/archive/wayback/http11resourcestore/Http11ResourceStore.java +++ b/src/java/org/archive/wayback/http11resource...
BUGFIX: IOExceptions including HTTP errors, no route to host, etc were not being handled and wrapped as ResourceNotAvailable exceptions. git-svn-id: <URL>
diff --git a/src/Core/Builder/Request/ShippingMethodRequestBuilder.php b/src/Core/Builder/Request/ShippingMethodRequestBuilder.php index <HASH>..<HASH> 100644 --- a/src/Core/Builder/Request/ShippingMethodRequestBuilder.php +++ b/src/Core/Builder/Request/ShippingMethodRequestBuilder.php @@ -98,7 +98,7 @@ class ShippingM...
WIP: add requestbuilder not added by the git add
diff --git a/pymongo/collection.py b/pymongo/collection.py index <HASH>..<HASH> 100644 --- a/pymongo/collection.py +++ b/pymongo/collection.py @@ -1007,7 +1007,8 @@ class Collection(common.BaseObject): response = self.__database.command("mapreduce", self.__name, map=...
Handle no 'result' field in M/R PYTHON-<I> For now this only happens with inline map reduce which we provide a separate method to handle.
diff --git a/pyani/pyani_graphics.py b/pyani/pyani_graphics.py index <HASH>..<HASH> 100644 --- a/pyani/pyani_graphics.py +++ b/pyani/pyani_graphics.py @@ -207,7 +207,7 @@ def heatmap_mpl(df, outfilename=None, title=None, cmap=None, width_ratios = [1, 0.15]) rowdend_axe...
Corrected row dendrogram orientation in MPL
diff --git a/machina/apps/conversation/views.py b/machina/apps/conversation/views.py index <HASH>..<HASH> 100644 --- a/machina/apps/conversation/views.py +++ b/machina/apps/conversation/views.py @@ -73,7 +73,7 @@ class TopicView(PermissionRequiredMixin, ListView): def get_queryset(self): self.topic = se...
Fixed PostEdit mixin form_valid method