diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/pubsub/google/cloud/pubsub_v1/subscriber/policy/thread.py b/pubsub/google/cloud/pubsub_v1/subscriber/policy/thread.py index <HASH>..<HASH> 100644 --- a/pubsub/google/cloud/pubsub_v1/subscriber/policy/thread.py +++ b/pubsub/google/cloud/pubsub_v1/subscriber/policy/thread.py @@ -61,7 +61,7 @@ class Policy(ba...
Use queue if provided in kwargs (#<I>) Fix for a new Queue being instantiated regardless of whether a queue is passed in or not.
diff --git a/src/main/java/org/telegram/mtproto/MTProto.java b/src/main/java/org/telegram/mtproto/MTProto.java index <HASH>..<HASH> 100644 --- a/src/main/java/org/telegram/mtproto/MTProto.java +++ b/src/main/java/org/telegram/mtproto/MTProto.java @@ -542,18 +542,20 @@ public class MTProto { return null; ...
Restored time checking with logging
diff --git a/umis/umis.py b/umis/umis.py index <HASH>..<HASH> 100644 --- a/umis/umis.py +++ b/umis/umis.py @@ -391,7 +391,7 @@ def tagcount(sam, out, genemap, output_evidence_table, positional, minevidence, buf = StringIO() for key in evidence: line = '{},{}\n'.format(key, evidence[key]) - buf...
Fix typo in handling unicode This appears to be a misplaced end parenthesis from: <I>d6ad<I>eb<I>a<I>a<I>a<I>d<I>e<I>a2
diff --git a/airflow/api_connexion/endpoints/dag_run_endpoint.py b/airflow/api_connexion/endpoints/dag_run_endpoint.py index <HASH>..<HASH> 100644 --- a/airflow/api_connexion/endpoints/dag_run_endpoint.py +++ b/airflow/api_connexion/endpoints/dag_run_endpoint.py @@ -102,7 +102,7 @@ def get_dag_run(*, dag_id: str, dag_r...
fix comments (#<I>)
diff --git a/src/CmsAdmin/Resource/web/js/form.js b/src/CmsAdmin/Resource/web/js/form.js index <HASH>..<HASH> 100644 --- a/src/CmsAdmin/Resource/web/js/form.js +++ b/src/CmsAdmin/Resource/web/js/form.js @@ -63,10 +63,11 @@ $(document).ready(function () { }); //on focus na submit - $('input[type="submit"]').on('c...
Submit.onfocus -> Form.submit
diff --git a/IPython/html/widgets/widget.py b/IPython/html/widgets/widget.py index <HASH>..<HASH> 100644 --- a/IPython/html/widgets/widget.py +++ b/IPython/html/widgets/widget.py @@ -149,12 +149,7 @@ class Widget(LoggingConfigurable): self.send_state(key=name) def _handle_displayed(self, **kwargs): ...
remove 3rd callback type from on_displayed
diff --git a/builtin/providers/digitalocean/resource_digitalocean_ssh_key.go b/builtin/providers/digitalocean/resource_digitalocean_ssh_key.go index <HASH>..<HASH> 100644 --- a/builtin/providers/digitalocean/resource_digitalocean_ssh_key.go +++ b/builtin/providers/digitalocean/resource_digitalocean_ssh_key.go @@ -74,7 ...
provider/digitalocean: Check for nil response This applies the same fix to `digitalocean_ssh_key` as #<I> applies to droplets. Fixes #<I>. The report there gives weight to my theory that this occurs when there are transport issues.
diff --git a/lib/facemock/version.rb b/lib/facemock/version.rb index <HASH>..<HASH> 100644 --- a/lib/facemock/version.rb +++ b/lib/facemock/version.rb @@ -1,3 +1,3 @@ module Facemock - VERSION = "0.0.3" + VERSION = "0.0.4" end diff --git a/spec/facemock_spec.rb b/spec/facemock_spec.rb index <HASH>..<HASH> 100644 --...
:arrow_up: Upgrade version to <I>
diff --git a/src/Component.php b/src/Component.php index <HASH>..<HASH> 100644 --- a/src/Component.php +++ b/src/Component.php @@ -5,6 +5,7 @@ namespace mito\sentry; use Closure; use mito\sentry\assets\RavenAsset; use Yii; +use yii\base\Exception; use yii\base\InvalidConfigException; use yii\helpers\ArrayHelper; ...
register component even if unable to register assets
diff --git a/lib/platformexploit.rb b/lib/platformexploit.rb index <HASH>..<HASH> 100644 --- a/lib/platformexploit.rb +++ b/lib/platformexploit.rb @@ -31,8 +31,12 @@ module Ronin super(advisory) @targets = [] - params << Param.new('target','default target index',0) - params << Param.new('custo...
* Use the add_param method for adding parameters. * Added the 'add_target' method to the Target class.
diff --git a/thefuck/system/win32.py b/thefuck/system/win32.py index <HASH>..<HASH> 100644 --- a/thefuck/system/win32.py +++ b/thefuck/system/win32.py @@ -1,5 +1,4 @@ import os -import sys import msvcrt import win_unicode_console from .. import const @@ -12,20 +11,18 @@ def init_output(): def get_key(): - c...
Fix Win<I> get_key (#<I>) PR #<I> moved the arrow and cancel key codes to `const.py`. However, the move also changed the codes from byte arrays to strings, which broke the use of `msvcrt.getch()` for Windows. The fix is to use `msvcrt.getwch()` so the key is a Unicode character, matching the Unix implementation.
diff --git a/tests/helper.py b/tests/helper.py index <HASH>..<HASH> 100644 --- a/tests/helper.py +++ b/tests/helper.py @@ -184,7 +184,7 @@ if __name__ == '__main__': print('Starting ...') import signalfd signalfd.sigprocmask(signalfd.SIG_BLOCK, [signal.SIGCHLD]) - fd = ...
Dooh! Was setting up signalfd the wrong way.
diff --git a/server.go b/server.go index <HASH>..<HASH> 100644 --- a/server.go +++ b/server.go @@ -409,7 +409,7 @@ func (srv *Server) ImagePull(name, tag, endpoint string, out io.Writer, sf *util remote := name parts := strings.Split(name, "/") if len(parts) > 2 { - remote = fmt.Sprintf("src/%s", strings.Join(pa...
Escape remote names on repo push/pull
diff --git a/generators/cleanup.js b/generators/cleanup.js index <HASH>..<HASH> 100644 --- a/generators/cleanup.js +++ b/generators/cleanup.js @@ -221,11 +221,13 @@ function cleanupOldServerFiles(generator, javaDir, testDir, mainResourceDir, tes generator.removeFile(`${testDir}web/rest/ClientForwardControllerI...
Move clean file 'JwtAuthorityExtractor' for older version than <I>
diff --git a/cmd/jujud/machine.go b/cmd/jujud/machine.go index <HASH>..<HASH> 100644 --- a/cmd/jujud/machine.go +++ b/cmd/jujud/machine.go @@ -172,9 +172,14 @@ func (a *MachineAgent) APIWorker(ensureStateWorker func()) (worker.Worker, error runner.StartWorker("logger", func() (worker.Worker, error) { return worker...
Do not start auth worker for local provider
diff --git a/src/main/java/org/sikuli/slides/processing/Relationship.java b/src/main/java/org/sikuli/slides/processing/Relationship.java index <HASH>..<HASH> 100644 --- a/src/main/java/org/sikuli/slides/processing/Relationship.java +++ b/src/main/java/org/sikuli/slides/processing/Relationship.java @@ -24,7 +24,7 @@ imp...
refactor to get any media file
diff --git a/openhtf/core/phase_executor.py b/openhtf/core/phase_executor.py index <HASH>..<HASH> 100644 --- a/openhtf/core/phase_executor.py +++ b/openhtf/core/phase_executor.py @@ -131,6 +131,7 @@ class PhaseExecutorThread(threads.KillableThread): once it is known (_phase_execution_outcome is None until then), and...
Make PhaseExecutorThread and TestExecutor daemon threads (#<I>)
diff --git a/lib/autokey/scripting/engine.py b/lib/autokey/scripting/engine.py index <HASH>..<HASH> 100644 --- a/lib/autokey/scripting/engine.py +++ b/lib/autokey/scripting/engine.py @@ -99,7 +99,8 @@ class Engine: temporary=False): """ Create a new text phrase inside the given ...
Phrases created in temporary folders are made temporary
diff --git a/components/SeoPatternHelper.php b/components/SeoPatternHelper.php index <HASH>..<HASH> 100644 --- a/components/SeoPatternHelper.php +++ b/components/SeoPatternHelper.php @@ -46,6 +46,16 @@ class SeoPatternHelper { const SEPARATOR_PATTERN_KEY = 'sep'; /** + * Global view separator parameter key name....
add feature to change separator by setting view param
diff --git a/tests/unit_tests/test_utils/test_handlers.py b/tests/unit_tests/test_utils/test_handlers.py index <HASH>..<HASH> 100644 --- a/tests/unit_tests/test_utils/test_handlers.py +++ b/tests/unit_tests/test_utils/test_handlers.py @@ -90,7 +90,8 @@ class TestHandlers(SetMeUp): c = h.Repeater( ...
fixed broken test in test_handlers.
diff --git a/bin/php/checkdbfiles.php b/bin/php/checkdbfiles.php index <HASH>..<HASH> 100755 --- a/bin/php/checkdbfiles.php +++ b/bin/php/checkdbfiles.php @@ -132,9 +132,16 @@ $versions47 = array( 'unstable' => array( array( '4.6.0', '4.7.0alpha1' ), ); $versions50 = array( 'unstable' => array( array( '4...
Fix a minor mistake in <I>a<I>cd<I>c<I>ec6fc2c0c4ba
diff --git a/tangy-form-item.js b/tangy-form-item.js index <HASH>..<HASH> 100644 --- a/tangy-form-item.js +++ b/tangy-form-item.js @@ -720,7 +720,16 @@ export class TangyFormItem extends PolymerElement { this .querySelectorAll('[name]') .forEach(input => inputs.push(input.getModProps && window.useShr...
feat(scoring-fields): Add Scoring Functionality Part of Tangerine-Community/tangy-form-editor#<I> Refs Tangerine-Community/Tangerine#<I>
diff --git a/lib/u2f/u2f.rb b/lib/u2f/u2f.rb index <HASH>..<HASH> 100644 --- a/lib/u2f/u2f.rb +++ b/lib/u2f/u2f.rb @@ -95,10 +95,14 @@ module U2F # Convert a binary public key to PEM format def self.public_key_pem(key) fail PublicKeyDecodeError unless key.length == 65 || key[0] == "\x04" - - der =...
Get rid of hard coded bytes for generating PEM from private key
diff --git a/lib/veewee/provider/core/helper/web.rb b/lib/veewee/provider/core/helper/web.rb index <HASH>..<HASH> 100644 --- a/lib/veewee/provider/core/helper/web.rb +++ b/lib/veewee/provider/core/helper/web.rb @@ -26,8 +26,8 @@ module Veewee content=displayfile.read() response.body=conten...
Leave the web thread running until we shut down, and mount it a bit more pragmatically (full paths only)
diff --git a/lxd/cluster/gateway.go b/lxd/cluster/gateway.go index <HASH>..<HASH> 100644 --- a/lxd/cluster/gateway.go +++ b/lxd/cluster/gateway.go @@ -195,15 +195,15 @@ func (g *Gateway) HandlerFuncs(heartbeatHandler HeartbeatHandler, trustedCerts f if r.Method == "PUT" { if g.shutdownCtx.Err() != nil { log...
lxd/cluster/gateway: Error message and log improvements
diff --git a/src/options/block-indent.js b/src/options/block-indent.js index <HASH>..<HASH> 100644 --- a/src/options/block-indent.js +++ b/src/options/block-indent.js @@ -45,7 +45,7 @@ let option = { var spaces = whitespaceNode.content.replace(/\n[ \t]+/gm, '\n'); if (spaces === '') { - ast.remov...
Fix ast.remove is not a function error This PR fixes an error that occurs when `"eof-newline": false,` as reported and solved here: <URL>
diff --git a/lib/browser.js b/lib/browser.js index <HASH>..<HASH> 100644 --- a/lib/browser.js +++ b/lib/browser.js @@ -25,7 +25,13 @@ function W3CWebSocket(uri, protocols) { */ return native_instance; } - +if (NativeWebSocket) { + ["CONNECTING", "OPEN", "CLOSING", "CLOSED"].forEach(function(prop) { + Object.defi...
add readyState constants to browser `w3cwebsocket` Now the exposed `w3cwebsocket` export mirrors the native WebSocket more closely. I hit this bug when moving previously native code to use this wrapper, the server-sde code was fine, but the client-side code failed because `WebSocket.OPEN` was `undefined`.
diff --git a/src/BootstrapChannelClient.js b/src/BootstrapChannelClient.js index <HASH>..<HASH> 100644 --- a/src/BootstrapChannelClient.js +++ b/src/BootstrapChannelClient.js @@ -61,7 +61,7 @@ class BootstrapChannelClient { } send(id,type,data){ - u.log(this.chord, "BSTRAP: SENDING "+type); + u.log(this.chord, ...
I cannot print a Symbol. Aww phooey!
diff --git a/statsd/statsd_test.go b/statsd/statsd_test.go index <HASH>..<HASH> 100644 --- a/statsd/statsd_test.go +++ b/statsd/statsd_test.go @@ -1,26 +1,32 @@ package statsd import ( - "io" "testing" "time" "github.com/stretchr/testify/assert" ) -type statsdWriterWrapper struct { - io.WriteCloser -} +t...
Fix race condition in the test The race only happen when also runnin the benchmark which leave enough time to the un-closed client to flush
diff --git a/src/Command/Project/ProjectCreateCommand.php b/src/Command/Project/ProjectCreateCommand.php index <HASH>..<HASH> 100644 --- a/src/Command/Project/ProjectCreateCommand.php +++ b/src/Command/Project/ProjectCreateCommand.php @@ -42,8 +42,23 @@ class ProjectCreateCommand extends CommandBase $this->for...
[project:create] add detailed help
diff --git a/src/Model/Subscription.php b/src/Model/Subscription.php index <HASH>..<HASH> 100644 --- a/src/Model/Subscription.php +++ b/src/Model/Subscription.php @@ -30,7 +30,7 @@ class Subscription extends Resource const STATUS_ACTIVE = 'active'; const STATUS_REQUESTED = 'requested'; const STATUS_PROVI...
Fix wrong case in Subscription::STATUS_FAILED constant
diff --git a/src/SteamAuth.php b/src/SteamAuth.php index <HASH>..<HASH> 100644 --- a/src/SteamAuth.php +++ b/src/SteamAuth.php @@ -217,7 +217,7 @@ class SteamAuth implements SteamAuthInterface */ public function parseSteamID() { - preg_match("#^https://steamcommunity.com/openid/id/([0-9]{17,25})#...
Make the `s` in https optional in case Valve changes their mind
diff --git a/drools-decisiontables/src/test/java/org/drools/decisiontable/UnicodeInXLSTest.java b/drools-decisiontables/src/test/java/org/drools/decisiontable/UnicodeInXLSTest.java index <HASH>..<HASH> 100644 --- a/drools-decisiontables/src/test/java/org/drools/decisiontable/UnicodeInXLSTest.java +++ b/drools-decisiont...
Added additional error information to failing test
diff --git a/src/Illuminate/Encryption/Encrypter.php b/src/Illuminate/Encryption/Encrypter.php index <HASH>..<HASH> 100755 --- a/src/Illuminate/Encryption/Encrypter.php +++ b/src/Illuminate/Encryption/Encrypter.php @@ -114,6 +114,8 @@ class Encrypter implements EncrypterContract * * @param string $value ...
Add encrypter throws docblock (#<I>)
diff --git a/lib/compiless.js b/lib/compiless.js index <HASH>..<HASH> 100644 --- a/lib/compiless.js +++ b/lib/compiless.js @@ -3,8 +3,7 @@ var Path = require('path'), fs = require('fs'), async = require('async'), _ = require('underscore'), - passError = require('passerror'), - less = require('less'...
Made the 'less' module a config option so that the caller can choose to up- or downgrade the bundled version.
diff --git a/admin/settings/appearance.php b/admin/settings/appearance.php index <HASH>..<HASH> 100644 --- a/admin/settings/appearance.php +++ b/admin/settings/appearance.php @@ -57,7 +57,7 @@ if ($hassiteconfig) { // speedup for non-admins, add all caps used on this page $htmleditors[$editor] = $editor; ...
MDL-<I> - Correction to previous change: going back to previous variable name, to prevent bugs
diff --git a/src/ContaoCommunityAlliance/UrlBuilder/UrlBuilder.php b/src/ContaoCommunityAlliance/UrlBuilder/UrlBuilder.php index <HASH>..<HASH> 100644 --- a/src/ContaoCommunityAlliance/UrlBuilder/UrlBuilder.php +++ b/src/ContaoCommunityAlliance/UrlBuilder/UrlBuilder.php @@ -86,7 +86,10 @@ class UrlBuilder $par...
Only treat path as query if it really is one
diff --git a/nfc/tag/tt1_broadcom.py b/nfc/tag/tt1_broadcom.py index <HASH>..<HASH> 100644 --- a/nfc/tag/tt1_broadcom.py +++ b/nfc/tag/tt1_broadcom.py @@ -49,7 +49,7 @@ class Topaz(tt1.Type1Tag): unless the wipe argument is set. """ - return super(Type1Tag, self).format(version, wipe) + ...
Type1Tag is imported under tt1 in tt1_broadcom
diff --git a/examples/chat/model.js b/examples/chat/model.js index <HASH>..<HASH> 100755 --- a/examples/chat/model.js +++ b/examples/chat/model.js @@ -61,8 +61,15 @@ function setup (channelHex, nick, onReady) { render(doc) } - // FIXME: Commit something to the document? + // Hack alert!!!!! hm....
Implement workaround for getting new peers into the document Waiting on a timeout is not very nice, but it mostly works.
diff --git a/lib/writeexcel/workbook.rb b/lib/writeexcel/workbook.rb index <HASH>..<HASH> 100644 --- a/lib/writeexcel/workbook.rb +++ b/lib/writeexcel/workbook.rb @@ -78,7 +78,6 @@ class Workbook < BIFFWriter @biffsize = 0 @sheet_count = 0 @chart_count = 0 - @url_forma...
* delete meaningless @url_format value set.
diff --git a/question/type/multianswer/questiontype.php b/question/type/multianswer/questiontype.php index <HASH>..<HASH> 100644 --- a/question/type/multianswer/questiontype.php +++ b/question/type/multianswer/questiontype.php @@ -141,14 +141,14 @@ class qtype_multianswer extends question_type { if ($previ...
MDL-<I> qtype multianswer refers to old name for the question_delete_questions function.
diff --git a/scriptcwl/step.py b/scriptcwl/step.py index <HASH>..<HASH> 100644 --- a/scriptcwl/step.py +++ b/scriptcwl/step.py @@ -13,14 +13,19 @@ from .reference import Reference # Helper function to make the import of cwltool.load_tool quiet @contextmanager def quiet(): + # save stdout/stderr + # Jupyter doe...
don't set sys.stdout and sys.stderr back to sys.__stdout__ and sys.__stderr__. This doesn't work in Jupyter notebooks, so save previous state to variable instead and setting back to saved state
diff --git a/app/scripts/TiledPlot.js b/app/scripts/TiledPlot.js index <HASH>..<HASH> 100644 --- a/app/scripts/TiledPlot.js +++ b/app/scripts/TiledPlot.js @@ -982,8 +982,11 @@ class TiledPlot extends React.Component { * Try to zoom in or out so that the bounds of the view correspond to the * extent of the d...
Fix strange zoomToData issue This seems to be an issue with babel rather than HiGlass
diff --git a/app/src/Bolt/Storage.php b/app/src/Bolt/Storage.php index <HASH>..<HASH> 100644 --- a/app/src/Bolt/Storage.php +++ b/app/src/Bolt/Storage.php @@ -2481,6 +2481,20 @@ class Storage array(\PDO::PARAM_INT, \PDO::PARAM_STR) )->fetchAll(); + // And the other way around.. + $...
Allow removal of relations, if relations were originally created from 'the other end'.
diff --git a/lib/Doctrine/ORM/Query/Parser.php b/lib/Doctrine/ORM/Query/Parser.php index <HASH>..<HASH> 100644 --- a/lib/Doctrine/ORM/Query/Parser.php +++ b/lib/Doctrine/ORM/Query/Parser.php @@ -425,15 +425,11 @@ class Parser /** * Checks if the given token indicates a mathematical operator. * - * ...
Fixed typo and simplified method as mentioned in an earlier comment.
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -59,17 +59,6 @@ REQUIREMENTS = [ 'google-cloud-storage', ] -GRPC_PACKAGES = [ - 'grpcio >= 1.0.0', - 'google-gax >= 0.14.1, < 0.15dev', - 'gapic-google-logging-v2 >= 0.9.0, < 0.10dev', - 'grpc-google-loggin...
Remove logging deps from setup.py. In the process removing GRPC_PACKAGES entirely.
diff --git a/packages/demos-react/.pundle.js b/packages/demos-react/.pundle.js index <HASH>..<HASH> 100644 --- a/packages/demos-react/.pundle.js +++ b/packages/demos-react/.pundle.js @@ -5,9 +5,9 @@ const mainTSConfig = require('../../tsconfig'); module.exports = { entry: ['./src/mount.tsx'], output: { - bund...
[fixed] deploy path Reviewers: O3 Material JavaScript platform reviewers, #material_motion, O2 Material Motion, featherless Reviewed By: #material_motion, O2 Material Motion, featherless Tags: #material_motion Differential Revision: <URL>
diff --git a/core/metrics-core-impl/src/main/java/org/hawkular/metrics/core/impl/transformers/BatchStatementTransformer.java b/core/metrics-core-impl/src/main/java/org/hawkular/metrics/core/impl/transformers/BatchStatementTransformer.java index <HASH>..<HASH> 100644 --- a/core/metrics-core-impl/src/main/java/org/hawkul...
HWKMETRICS-<I> Warning about batch size threshold in the logs Use more conservative value since warnings are still present on Openshift.
diff --git a/src/util.js b/src/util.js index <HASH>..<HASH> 100644 --- a/src/util.js +++ b/src/util.js @@ -190,9 +190,10 @@ util.getFileReplacement = function( src, settings, callback ) { var fileName = util.getInlineFilePath( src, settings.relativeTo ); var mimetype = mime.getType( fileName ); -...
Use callback version of readFile
diff --git a/billy/importers/bills.py b/billy/importers/bills.py index <HASH>..<HASH> 100644 --- a/billy/importers/bills.py +++ b/billy/importers/bills.py @@ -85,7 +85,7 @@ def import_bill(data, votes, categorizer): # clean up bill_ids data['bill_id'] = fix_bill_id(data['bill_id']) data['alternate_bill_i...
fix case of missing alternate_bill_ids
diff --git a/test/types/exec.rb b/test/types/exec.rb index <HASH>..<HASH> 100755 --- a/test/types/exec.rb +++ b/test/types/exec.rb @@ -524,6 +524,8 @@ class TestExec < Test::Unit::TestCase end def test_missing_checks_cause_failures + # Solaris's sh exits with 1 here instead of 127 + return if ...
Disabling a test on solaris, since apparently sh on solaris is different than everywhere else git-svn-id: <URL>
diff --git a/src/main/java/org/asteriskjava/manager/event/QueueMemberStatusEvent.java b/src/main/java/org/asteriskjava/manager/event/QueueMemberStatusEvent.java index <HASH>..<HASH> 100644 --- a/src/main/java/org/asteriskjava/manager/event/QueueMemberStatusEvent.java +++ b/src/main/java/org/asteriskjava/manager/event/Q...
WARN [Asterisk-Java ManagerConnection-0-Reader-0] (AbstractBuilder.java:<I>) - Unable to set property 'incall' to '0' on org.asteriskjava.manager.event.QueueMemberStatusEvent: no setter. Please report at <URL>
diff --git a/src/view/element-own-attached.js b/src/view/element-own-attached.js index <HASH>..<HASH> 100644 --- a/src/view/element-own-attached.js +++ b/src/view/element-own-attached.js @@ -15,7 +15,7 @@ var NodeType = require('./node-type'); var elementGetTransition = require('./element-get-transition'); var getEve...
fix: const handleError to var
diff --git a/tests/test_animalqtl.py b/tests/test_animalqtl.py index <HASH>..<HASH> 100644 --- a/tests/test_animalqtl.py +++ b/tests/test_animalqtl.py @@ -6,15 +6,15 @@ from dipper.sources.AnimalQTLdb import AnimalQTLdb from tests.test_source import SourceTestCase logging.basicConfig(level=logging.WARNING) -logger ...
conventions & use common test ids
diff --git a/salt/returners/redis_return.py b/salt/returners/redis_return.py index <HASH>..<HASH> 100644 --- a/salt/returners/redis_return.py +++ b/salt/returners/redis_return.py @@ -21,4 +21,7 @@ def returner(ret): host=__opts__['redis.host'], port=__opts__['redis.port'], db=__op...
Change the redis returner to better use data structures
diff --git a/interact.js b/interact.js index <HASH>..<HASH> 100644 --- a/interact.js +++ b/interact.js @@ -5577,6 +5577,7 @@ * interact.margin [ method ] * + * Deprecated. Use `interact(target).resizable({ margin: number });` instead. * Returns or sets the margin for autocheck resizing used ...
Mark interact.margin as deprecated Suggest providing `margin` property in the resizable method's options.
diff --git a/src/fonduer/utils/utils_visual.py b/src/fonduer/utils/utils_visual.py index <HASH>..<HASH> 100644 --- a/src/fonduer/utils/utils_visual.py +++ b/src/fonduer/utils/utils_visual.py @@ -1,9 +1,17 @@ -from collections import namedtuple +from typing import NamedTuple from fonduer.candidates.models.span_mentio...
Use NamedTuple, a typed version of namedtuple, for Bbox
diff --git a/gwpy/timeseries/statevector.py b/gwpy/timeseries/statevector.py index <HASH>..<HASH> 100644 --- a/gwpy/timeseries/statevector.py +++ b/gwpy/timeseries/statevector.py @@ -650,7 +650,7 @@ class StateVector(TimeSeriesBase): gap : `str`, optional how to handle gaps in the cache, one of ...
Fix typo: undelying -> underlying
diff --git a/tpl/template_funcs_test.go b/tpl/template_funcs_test.go index <HASH>..<HASH> 100644 --- a/tpl/template_funcs_test.go +++ b/tpl/template_funcs_test.go @@ -151,6 +151,8 @@ func TestArethmic(t *testing.T) { {float64(1), uint(2), '+', float64(3)}, {float64(1), "do", '+', false}, {uint(1), int(2), '+',...
tpl: Add two more doArithmetic test cases
diff --git a/lib/ImageCache.js b/lib/ImageCache.js index <HASH>..<HASH> 100644 --- a/lib/ImageCache.js +++ b/lib/ImageCache.js @@ -10,6 +10,7 @@ function Img (src) { this._img = new Image(); this._img.onload = this.emit.bind(this, 'load'); this._img.onerror = this.emit.bind(this, 'error'); + this._img.crossOr...
Use crossOrigin=true on images to allow getImageData/WebGL If not using crossOrigin=true, the canvas get "tainted" which throws an exception when you want to use it as a WebGL texture or if using getImageData()
diff --git a/src/Injector.php b/src/Injector.php index <HASH>..<HASH> 100644 --- a/src/Injector.php +++ b/src/Injector.php @@ -94,15 +94,13 @@ class Injector implements InjectorInterface throw new InjectorInvocationException( "Can't create $className " . " - __construct() ...
Removed exception wrapping for internal exceptions - default exception handler is unwrapping them and displaying non-detailed exception messages.
diff --git a/src/org/apache/cassandra/gms/Gossiper.java b/src/org/apache/cassandra/gms/Gossiper.java index <HASH>..<HASH> 100644 --- a/src/org/apache/cassandra/gms/Gossiper.java +++ b/src/org/apache/cassandra/gms/Gossiper.java @@ -470,7 +470,6 @@ public class Gossiper implements IFailureDetectionEventListener, IEndPoin...
fix duration calculation to avoid evicting dead endpoints instantly git-svn-id: <URL>
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -11,6 +11,7 @@ var find = require('es5-ext/array/#/find') , memoizeMethods = require('memoizee/methods-plain') , getNormalizer = partial.call(require('memoizee/normalizers/get-fixed'), 2) , ensureDocument =...
Assure repaint after view load
diff --git a/src/oauth.js b/src/oauth.js index <HASH>..<HASH> 100644 --- a/src/oauth.js +++ b/src/oauth.js @@ -190,7 +190,7 @@ async function getTokenEndpoints (wellKnown) { // set cache timeout wellKnownTimeoutId = setTimeout(() => { debug.wellKnown('cache expired') - getTokenEndpoints() + getTokenEnd...
fix: pass through wellknown url to timeout callback
diff --git a/lib/desktop/osx.rb b/lib/desktop/osx.rb index <HASH>..<HASH> 100644 --- a/lib/desktop/osx.rb +++ b/lib/desktop/osx.rb @@ -35,8 +35,7 @@ module Desktop end def update_desktop_image_permissions - system chown_command - system chmod_command + system(chown_command) && system(chmod_co...
Only run chmod if chown is successful
diff --git a/engine/env/spark/src/main/java/org/datacleaner/spark/utils/ResultFilePathUtils.java b/engine/env/spark/src/main/java/org/datacleaner/spark/utils/ResultFilePathUtils.java index <HASH>..<HASH> 100644 --- a/engine/env/spark/src/main/java/org/datacleaner/spark/utils/ResultFilePathUtils.java +++ b/engine/env/sp...
added a comment about fileSystemPrefix
diff --git a/src/renderable/container.js b/src/renderable/container.js index <HASH>..<HASH> 100644 --- a/src/renderable/container.js +++ b/src/renderable/container.js @@ -468,7 +468,7 @@ var childIndex = this.getChildIndex(child); if (childIndex > 0) { // note : we use an inve...
Fixed the moveToTop and moveToBottom functions (thanks Lamberto!)
diff --git a/django_tenants/management/commands/create_tenant.py b/django_tenants/management/commands/create_tenant.py index <HASH>..<HASH> 100644 --- a/django_tenants/management/commands/create_tenant.py +++ b/django_tenants/management/commands/create_tenant.py @@ -28,7 +28,7 @@ class Command(BaseCommand): ...
Fix domain creation bug in create_tenant management command. The 'create_tenant' management command was not handling domain creation options properly and was running into an infinite loop. This was because the store_tenant_domain() method was not returning the domain that it had newly created.
diff --git a/lib/relations/belongs_to.js b/lib/relations/belongs_to.js index <HASH>..<HASH> 100644 --- a/lib/relations/belongs_to.js +++ b/lib/relations/belongs_to.js @@ -15,8 +15,6 @@ _.str = require('underscore.string'); /** * The belongs to property for models. * - * Documentation forthcoming. - * * For examp...
Finished docs for belongs to.
diff --git a/geomdl/helpers.py b/geomdl/helpers.py index <HASH>..<HASH> 100644 --- a/geomdl/helpers.py +++ b/geomdl/helpers.py @@ -84,7 +84,7 @@ def find_span_linear(degree, knot_vector, num_ctrlpts, knot, **kwargs): :return: knot span :rtype: int """ - span = 0 # Knot span index starts from zero + ...
Fix span finding for out-of-domain evaluation
diff --git a/src/server/middleware/auth/gmeauth.js b/src/server/middleware/auth/gmeauth.js index <HASH>..<HASH> 100644 --- a/src/server/middleware/auth/gmeauth.js +++ b/src/server/middleware/auth/gmeauth.js @@ -496,7 +496,8 @@ function GMEAuth(session, gmeConfig) { var i; for (i = 0; i...
WIP gmeAuth.listUsers should add settings and data. (#<I>) should be cherry picked to <I> Former-commit-id: <I>aef<I>fcd<I>fb<I>bc<I>ab<I>d<I>a<I>a<I>
diff --git a/holoviews/element/chart.py b/holoviews/element/chart.py index <HASH>..<HASH> 100644 --- a/holoviews/element/chart.py +++ b/holoviews/element/chart.py @@ -36,6 +36,8 @@ class Chart(Columns, Element2D): lower_bounds, upper_bounds = [None]*ndims, [None]*ndims for i, slc in enumerate(index[:n...
Minor fix for Chart slicing extent setting
diff --git a/src/main/java/org/efaps/ui/wicket/models/objects/UITaskObject.java b/src/main/java/org/efaps/ui/wicket/models/objects/UITaskObject.java index <HASH>..<HASH> 100644 --- a/src/main/java/org/efaps/ui/wicket/models/objects/UITaskObject.java +++ b/src/main/java/org/efaps/ui/wicket/models/objects/UITaskObject.ja...
- webapp: field was added twice git-svn-id: <URL>
diff --git a/tests/server/blueprints/cases/test_cases_views.py b/tests/server/blueprints/cases/test_cases_views.py index <HASH>..<HASH> 100644 --- a/tests/server/blueprints/cases/test_cases_views.py +++ b/tests/server/blueprints/cases/test_cases_views.py @@ -786,7 +786,7 @@ def test_omimterms(app, test_omim_term): ...
Update tests/server/blueprints/cases/test_cases_views.py
diff --git a/lib/bot.js b/lib/bot.js index <HASH>..<HASH> 100644 --- a/lib/bot.js +++ b/lib/bot.js @@ -283,10 +283,6 @@ function OpkitBot(name, cmds, persister, params) { winston.log('info', response); return self.persister.save(self.brain[command.script], command.script); }) - .then(functio...
No longer logging persister's response
diff --git a/Classes/Command/ConfigurationCommandController.php b/Classes/Command/ConfigurationCommandController.php index <HASH>..<HASH> 100644 --- a/Classes/Command/ConfigurationCommandController.php +++ b/Classes/Command/ConfigurationCommandController.php @@ -48,8 +48,8 @@ class ConfigurationCommandController extend...
[CLEANUP] Use askConfirmation for confirmation question (#<I>)
diff --git a/c7n/version.py b/c7n/version.py index <HASH>..<HASH> 100644 --- a/c7n/version.py +++ b/c7n/version.py @@ -12,4 +12,4 @@ # See the License for the specific language governing permissions and # limitations under the License. -version = u"0.8.30.0" +version = u"0.8.31.0" diff --git a/setup.py b/setup.py i...
<I> - minor version release (#<I>)
diff --git a/spec/models/thredded/category_spec.rb b/spec/models/thredded/category_spec.rb index <HASH>..<HASH> 100644 --- a/spec/models/thredded/category_spec.rb +++ b/spec/models/thredded/category_spec.rb @@ -3,20 +3,5 @@ require 'spec_helper' module Thredded describe Category do - it 'should allow no catego...
Update specs (#<I>) * remove specification about a behaviour belonging to another model (topic) * specify only expected behaviour to avoid over specification (previously it was specified that "don't should allow no categories" ).
diff --git a/go/cmd/vtctldclient/internal/command/reparents.go b/go/cmd/vtctldclient/internal/command/reparents.go index <HASH>..<HASH> 100644 --- a/go/cmd/vtctldclient/internal/command/reparents.go +++ b/go/cmd/vtctldclient/internal/command/reparents.go @@ -150,6 +150,9 @@ func commandInitShardPrimary(cmd *cobra.Comma...
Check error response before attempting to access InitShardPrimary response
diff --git a/src/Decorator.php b/src/Decorator.php index <HASH>..<HASH> 100644 --- a/src/Decorator.php +++ b/src/Decorator.php @@ -2,13 +2,15 @@ namespace Ornament\Core; +use StdClass; + abstract class Decorator implements DecoratorInterface { protected $source; - public function __construct($source, ....
right, we need to pass references here
diff --git a/Classes/Parser/AbstractParser.php b/Classes/Parser/AbstractParser.php index <HASH>..<HASH> 100644 --- a/Classes/Parser/AbstractParser.php +++ b/Classes/Parser/AbstractParser.php @@ -307,6 +307,7 @@ abstract class AbstractParser implements ParserInterface if ($fileContent !== false) { ...
Use TYPO3-Configured Permissions (#<I>) file_put_contents uses the default php permissions. with this change the file has the configured typo3-permissions
diff --git a/js/core/List.js b/js/core/List.js index <HASH>..<HASH> 100644 --- a/js/core/List.js +++ b/js/core/List.js @@ -3,7 +3,7 @@ define(["js/core/Bindable", "underscore"], function (Bindable, _) { ctor: function (items, attributes) { this.$items = []; - this.callBase(this, attri...
fixed calling of callBase in List
diff --git a/src/Application.php b/src/Application.php index <HASH>..<HASH> 100644 --- a/src/Application.php +++ b/src/Application.php @@ -79,4 +79,11 @@ class Application extends \Symfony\Component\Console\Application { $this->getDefinition()->addOption($options); } + + public function extractNam...
Group by namespace when displaying list of commands
diff --git a/src/BaseBranchRepositoryEloquent.php b/src/BaseBranchRepositoryEloquent.php index <HASH>..<HASH> 100644 --- a/src/BaseBranchRepositoryEloquent.php +++ b/src/BaseBranchRepositoryEloquent.php @@ -2,7 +2,7 @@ namespace SedpMis\BaseRepository; -abstract class BaseBranchRepositoryEloquent extends BaseRepos...
Change base classes as non-abstract
diff --git a/hazelcast/src/main/java/com/hazelcast/map/impl/operation/MapReplicationStateHolder.java b/hazelcast/src/main/java/com/hazelcast/map/impl/operation/MapReplicationStateHolder.java index <HASH>..<HASH> 100644 --- a/hazelcast/src/main/java/com/hazelcast/map/impl/operation/MapReplicationStateHolder.java +++ b/h...
Restore Versioned interface on MapReplicationStateHolder (#<I>) Required for maintaing RU compatibility with <I>
diff --git a/lib/websocket.js b/lib/websocket.js index <HASH>..<HASH> 100644 --- a/lib/websocket.js +++ b/lib/websocket.js @@ -523,7 +523,7 @@ function initAsClient (address, protocols, options) { if (options.handshakeTimeout) { req.setTimeout( options.handshakeTimeout, - abortHandshake.bind(null, t...
[minor] Replace bound function with arrow function Do not mask potential issues, like #<I>, with bound arguments.
diff --git a/src/Base62/GmpEncoder.php b/src/Base62/GmpEncoder.php index <HASH>..<HASH> 100644 --- a/src/Base62/GmpEncoder.php +++ b/src/Base62/GmpEncoder.php @@ -31,11 +31,11 @@ class GmpEncoder public function encode($data) { if (is_integer($data)) { - $hex = dechex($data); + ...
Remove unneeded dechex() call
diff --git a/lib/SimpleSAML/Logger.php b/lib/SimpleSAML/Logger.php index <HASH>..<HASH> 100644 --- a/lib/SimpleSAML/Logger.php +++ b/lib/SimpleSAML/Logger.php @@ -16,6 +16,9 @@ interface SimpleSAML_Logger_LoggingHandler { class SimpleSAML_Logger { private static $loggingHandler = null; private static $logLevel = n...
Add support for log capturing. used in ldapstatus module.
diff --git a/addon/lint/lint.js b/addon/lint/lint.js index <HASH>..<HASH> 100644 --- a/addon/lint/lint.js +++ b/addon/lint/lint.js @@ -46,6 +46,7 @@ } var poll = setInterval(function() { if (tooltip) for (var n = node;; n = n.parentNode) { + if (n && n.nodeType == 11) n = n.root; if (n ...
[lint addon] When checking whether node is still in document, account for shadow dom Issue #<I>
diff --git a/ratecounter_test.go b/ratecounter_test.go index <HASH>..<HASH> 100644 --- a/ratecounter_test.go +++ b/ratecounter_test.go @@ -27,6 +27,19 @@ func TestRateCounter(t *testing.T) { check(0) } +func TestRateCounter_ScheduleDecrement_ReturnsImmediately(t *testing.T) { + interval := 1 * time.Second + r := N...
added test for ratecounter scheduleDecrement returning immediately
diff --git a/externs/fileapi.js b/externs/fileapi.js index <HASH>..<HASH> 100644 --- a/externs/fileapi.js +++ b/externs/fileapi.js @@ -242,13 +242,6 @@ Entry.prototype.copyTo = function(parent, newName, successCallback, errorCallback) {}; /** - * @see http://www.w3.org/TR/file-system-api/#widl-Entry-toURI - * @...
Get rid of the obsolete Entry#toURI extern. R=nicksantos DELTA=7 (0 added, 7 deleted, 0 changed) Revision created by MOE tool push_codebase. MOE_MIGRATION=<I> git-svn-id: <URL>
diff --git a/src/components/slider.js b/src/components/slider.js index <HASH>..<HASH> 100644 --- a/src/components/slider.js +++ b/src/components/slider.js @@ -89,7 +89,7 @@ AFRAME.registerComponent('gui-slider', { var clickActionFunction = window[clickActionFunctionName]; //console.log("clickA...
Modified the slider component It now notifies the user of the current position of the slider by emitting an event using clickActionFunction(data.percent)
diff --git a/locale/de.js b/locale/de.js index <HASH>..<HASH> 100644 --- a/locale/de.js +++ b/locale/de.js @@ -1,4 +1,5 @@ const messages = { + _default: (field) => `${field} ist ungültig.`, after: (field, [target]) => `${field} muss nach ${target} liegen.`, alpha_dash: (field) => `${field} darf alphanume...
added missing _default in de.js
diff --git a/lib/pay/stripe/billable.rb b/lib/pay/stripe/billable.rb index <HASH>..<HASH> 100644 --- a/lib/pay/stripe/billable.rb +++ b/lib/pay/stripe/billable.rb @@ -172,6 +172,16 @@ module Pay billable.card_token = nil end + # Syncs a customer's subscriptions from Stripe to the database + ...
RFC: add a path for syncing all of a customer's subscriptions (#<I>) * add a path for syncing all of a customer's subscriptions * scope scubscription sync to stripe_account * Update billable.rb * Update billable.rb
diff --git a/jobs/config_test.py b/jobs/config_test.py index <HASH>..<HASH> 100755 --- a/jobs/config_test.py +++ b/jobs/config_test.py @@ -441,6 +441,14 @@ class JobTest(unittest.TestCase): def test_valid_job_config_json(self): """Validate jobs/config.json.""" + # bootstrap integration test scrip...
Make sure each job has a config.json entry
diff --git a/client/src/main/java/com/paypal/selion/platform/dataprovider/AbstractExcelDataProvider.java b/client/src/main/java/com/paypal/selion/platform/dataprovider/AbstractExcelDataProvider.java index <HASH>..<HASH> 100644 --- a/client/src/main/java/com/paypal/selion/platform/dataprovider/AbstractExcelDataProvider....
Excel DataProvider Bug fix Refactored AbstractExcelDataProvider.prepareObject method to prepone the check for data from excel before checking if the field type is an interface.
diff --git a/ext/mysql2/extconf.rb b/ext/mysql2/extconf.rb index <HASH>..<HASH> 100644 --- a/ext/mysql2/extconf.rb +++ b/ext/mysql2/extconf.rb @@ -57,7 +57,7 @@ end asplode h unless have_header h end -unless RUBY_PLATFORM =~ /mswin/ +unless RUBY_PLATFORM =~ /mswin/ or RUBY_PLATFORM =~ /sparc/ $CFLAGS << ' -Wal...
fix to CFLAGS to allow compilation on SPARC with sunstudio compiler
diff --git a/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java b/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java index <HASH>..<HASH> 100644 --- a/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java +++ b/android/src/main/java/com/airbnb/android/react/maps/AirMapVie...
If we've disabled scrolling within the map, then don't capture the touch events (#<I>) * If we've disabled scrolling within the map, then don't capture the touch events. This allows the containing scrollview to perform a scrollview scroll by dragging on the map. (Previously, the map would absorb the touches, and then ...
diff --git a/shared/reducers/config.js b/shared/reducers/config.js index <HASH>..<HASH> 100644 --- a/shared/reducers/config.js +++ b/shared/reducers/config.js @@ -157,15 +157,23 @@ export default function (state: ConfigState = initialState, action: Action): Con } } case Constants.globalError: { + ...
Log global and daemon error (#<I>)
diff --git a/test/default.test.js b/test/default.test.js index <HASH>..<HASH> 100644 --- a/test/default.test.js +++ b/test/default.test.js @@ -16,6 +16,11 @@ test('should generate the expected default result', async t => { plugins: [new FaviconsWebpackPlugin({logo})] }); + stats.compilation.children + .fi...
test: check output stats for the child compiler lists no asset