language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/test/cask/artifact/installer_spec.rb
@@ -34,7 +34,7 @@ expect(command).to receive(:run!).with( executable, a_hash_including( - env: { "PATH" => PATH.new("#{HOMEBREW_PREFIX}/bin", "#{HOMEBREW_PREFIX}/sbin", ENV["PATH"]) }, + env: { "PATH" => PATH.new("#{HOMEBREW_PREFIX}/bin", "#{HOMEBREW_PREFIX}/sbin", E...
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/test/cmd/custom-external-command_spec.rb
@@ -13,7 +13,7 @@ SH FileUtils.chmod "+x", file - expect { brew cmd, "PATH" => "#{path}#{File::PATH_SEPARATOR}#{ENV["PATH"]}" } + expect { brew cmd, "PATH" => "#{path}#{File::PATH_SEPARATOR}#{ENV.fetch("PATH")}" } .to output("I am #{cmd}.\n").to_stdout .and not_to_output.to_s...
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/test/diagnostic_checks_spec.rb
@@ -20,7 +20,7 @@ FileUtils.chmod 0755, anaconda FileUtils.chmod 0755, python - ENV["PATH"] = "#{path}#{File::PATH_SEPARATOR}#{ENV["PATH"]}" + ENV["PATH"] = "#{path}#{File::PATH_SEPARATOR}#{ENV.fetch("PATH")}" expect(checks.check_for_anaconda).to match("Anaconda") end @@ -75,10 +...
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/test/spec_helper.rb
@@ -150,7 +150,7 @@ skip "Subversion is not installed." unless quiet_system svn_shim, "--version" svn_shim_path = Pathname(Utils.popen_read(svn_shim, "--homebrew=print-path").chomp.presence) - svn_paths = PATH.new(ENV["PATH"]) + svn_paths = PATH.new(ENV.fetch("PATH")) svn_paths.prepend(svn_shim_p...
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/test/support/helper/spec/shared_context/integration_test.rb
@@ -73,7 +73,7 @@ def brew(*args) env["PATH"], (HOMEBREW_LIBRARY_PATH/"test/support/helper/cmd").realpath.to_s, (HOMEBREW_PREFIX/"bin").realpath.to_s, - ENV["PATH"], + ENV.fetch("PATH"), ].compact.join(File::PATH_SEPARATOR) env.merge!(
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/test/utils_spec.rb
@@ -274,17 +274,19 @@ def esc(code) describe "#with_env" do it "sets environment variables within the block" do - expect(ENV["PATH"]).not_to eq("/bin") + expect(ENV.fetch("PATH")).not_to eq("/bin") with_env(PATH: "/bin") do - expect(ENV["PATH"]).to eq("/bin") + expect(ENV.fetch(...
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/unpack_strategy/cab.rb
@@ -23,7 +23,7 @@ def self.can_extract?(path) def extract_to_dir(unpack_dir, basename:, verbose:) system_command! "cabextract", args: ["-d", unpack_dir, "--", path], - env: { "PATH" => PATH.new(Formula["cabextract"].opt_bin, ENV["PATH"]) }, + ...
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/unpack_strategy/fossil.rb
@@ -39,7 +39,7 @@ def extract_to_dir(unpack_dir, basename:, verbose:) system_command! "fossil", args: ["open", path, *args], chdir: unpack_dir, - env: { "PATH" => PATH.new(Formula["fossil"].opt_bin, ENV["PATH"]) }, + ...
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/unpack_strategy/generic_unar.rb
@@ -32,7 +32,7 @@ def extract_to_dir(unpack_dir, basename:, verbose:) "-force-overwrite", "-quiet", "-no-directory", "-output-directory", unpack_dir, "--", path ], - env: { "PATH" => PATH.new(Formula["unar"].opt_bin, ENV["...
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/unpack_strategy/lha.rb
@@ -29,7 +29,7 @@ def dependencies def extract_to_dir(unpack_dir, basename:, verbose:) system_command! "lha", args: ["xq2w=#{unpack_dir}", path], - env: { "PATH" => PATH.new(Formula["lha"].opt_bin, ENV["PATH"]) }, + env: { "PATH" =>...
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/unpack_strategy/lzip.rb
@@ -31,7 +31,7 @@ def extract_to_dir(unpack_dir, basename:, verbose:) quiet_flags = verbose ? [] : ["-q"] system_command! "lzip", args: ["-d", *quiet_flags, unpack_dir/basename], - env: { "PATH" => PATH.new(Formula["lzip"].opt_bin, ENV["PATH"]) }, + ...
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/unpack_strategy/lzma.rb
@@ -31,7 +31,7 @@ def extract_to_dir(unpack_dir, basename:, verbose:) quiet_flags = verbose ? [] : ["-q"] system_command! "unlzma", args: [*quiet_flags, "--", unpack_dir/basename], - env: { "PATH" => PATH.new(Formula["xz"].opt_bin, ENV["PATH"]) }, + ...
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/unpack_strategy/mercurial.rb
@@ -17,7 +17,7 @@ def self.can_extract?(path) def extract_to_dir(unpack_dir, basename:, verbose:) system_command! "hg", args: ["--cwd", path, "archive", "--subrepos", "-y", "-t", "files", unpack_dir], - env: { "PATH" => PATH.new(Formula["mercurial"].opt_bin...
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/unpack_strategy/p7zip.rb
@@ -29,7 +29,7 @@ def dependencies def extract_to_dir(unpack_dir, basename:, verbose:) system_command! "7zr", args: ["x", "-y", "-bd", "-bso0", path, "-o#{unpack_dir}"], - env: { "PATH" => PATH.new(Formula["p7zip"].opt_bin, ENV["PATH"]) }, + ...
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/unpack_strategy/rar.rb
@@ -29,7 +29,7 @@ def dependencies def extract_to_dir(unpack_dir, basename:, verbose:) system_command! "unrar", args: ["x", "-inul", path, unpack_dir], - env: { "PATH" => PATH.new(Formula["unrar"].opt_bin, ENV["PATH"]) }, + env: { "...
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/unpack_strategy/xz.rb
@@ -31,7 +31,7 @@ def extract_to_dir(unpack_dir, basename:, verbose:) quiet_flags = verbose ? [] : ["-q"] system_command! "unxz", args: [*quiet_flags, "-T0", "--", unpack_dir/basename], - env: { "PATH" => PATH.new(Formula["xz"].opt_bin, ENV["PATH"]) }, + ...
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/unpack_strategy/zip.rb
@@ -37,7 +37,7 @@ def extract_to_dir(unpack_dir, basename:, verbose:) quiet_flags = verbose ? [] : ["-qq"] result = system_command! "unzip", args: [*quiet_flags, "-o", path, "-d", unpack_dir], - env: { "PATH" => PATH.ne...
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/unpack_strategy/zstd.rb
@@ -31,7 +31,7 @@ def extract_to_dir(unpack_dir, basename:, verbose:) quiet_flags = verbose ? [] : ["-q"] system_command! "unzstd", args: [*quiet_flags, "-T0", "--rm", "--", unpack_dir/basename], - env: { "PATH" => PATH.new(Formula["zstd"].opt_bin, ENV["P...
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/utils.rb
@@ -305,7 +305,7 @@ def interactive_shell(f = nil) end def with_homebrew_path(&block) - with_env(PATH: PATH.new(ENV["HOMEBREW_PATH"]), &block) + with_env(PATH: PATH.new(ORIGINAL_PATHS), &block) end def with_custom_locale(locale, &block) @@ -329,7 +329,7 @@ def quiet_system(cmd, *args) end ...
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/utils/git.rb
@@ -124,7 +124,7 @@ def setup_gpg! gnupg_bin = HOMEBREW_PREFIX/"opt/gnupg/bin" return unless gnupg_bin.directory? - ENV["PATH"] = PATH.new(ENV["PATH"]) + ENV["PATH"] = PATH.new(ENV.fetch("PATH")) .prepend(gnupg_bin) end
true
Other
Homebrew
brew
8ada737d40b46dd020de3425ef1088a53cf89fa4.json
Encapsulate ENV["SHELL"] usage
Library/Homebrew/dev-cmd/sh.rb
@@ -44,16 +44,18 @@ def sh ENV["VERBOSE"] = "1" if args.verbose? if args.cmd.present? - safe_system(ENV["SHELL"], "-c", args.cmd) + safe_system(preferred_shell, "-c", args.cmd) elsif args.named.present? - safe_system(ENV["SHELL"], args.named.first) + safe_system(preferred_shell, arg...
true
Other
Homebrew
brew
8ada737d40b46dd020de3425ef1088a53cf89fa4.json
Encapsulate ENV["SHELL"] usage
Library/Homebrew/utils.rb
@@ -291,12 +291,12 @@ def interactive_shell(f = nil) ENV["HOMEBREW_DEBUG_INSTALL"] = f.full_name end - if ENV["SHELL"].include?("zsh") && (home = Dir.home).start_with?(HOMEBREW_TEMP.resolved_path.to_s) + if Utils::Shell.preferred == :zsh && (home = Dir.home).start_with?(HOMEBREW_TEMP.resolved_path.t...
true
Other
Homebrew
brew
e78665f4f7a73bf18a26f2cb32d310de38e67898.json
Replace ENV["HOME"] with Dir.home
Library/Homebrew/cask/artifact/abstract_uninstall.rb
@@ -106,7 +106,7 @@ def uninstall_launchctl(*services, command: nil, **_) +"/Library/LaunchAgents/#{service}.plist", +"/Library/LaunchDaemons/#{service}.plist", ] - paths.each { |elt| elt.prepend(ENV["HOME"]).freeze } unless with_sudo + paths.each { |elt|...
true
Other
Homebrew
brew
e78665f4f7a73bf18a26f2cb32d310de38e67898.json
Replace ENV["HOME"] with Dir.home
Library/Homebrew/cask/artifact/relocated.rb
@@ -96,7 +96,7 @@ def add_altname_metadata(file, altname, command: nil) end def printable_target - target.to_s.sub(/^#{ENV['HOME']}(#{File::SEPARATOR}|$)/, "~/") + target.to_s.sub(/^#{Dir.home}(#{File::SEPARATOR}|$)/, "~/") end end end
true
Other
Homebrew
brew
e78665f4f7a73bf18a26f2cb32d310de38e67898.json
Replace ENV["HOME"] with Dir.home
Library/Homebrew/cask/cask.rb
@@ -241,7 +241,7 @@ def to_h def to_h_string_gsubs(string) string.to_s - .gsub(ENV["HOME"], "$HOME") + .gsub(Dir.home, "$HOME") .gsub(HOMEBREW_PREFIX, "$(brew --prefix)") end
true
Other
Homebrew
brew
e78665f4f7a73bf18a26f2cb32d310de38e67898.json
Replace ENV["HOME"] with Dir.home
Library/Homebrew/cask/config.rb
@@ -190,7 +190,7 @@ def explicit_s key = "language" value = T.cast(explicit.fetch(:languages, []), T::Array[String]).join(",") end - "#{key}: \"#{value.to_s.sub(/^#{ENV['HOME']}/, "~")}\"" + "#{key}: \"#{value.to_s.sub(/^#{Dir.home}/, "~")}\"" end.join(", ") end ...
true
Other
Homebrew
brew
e78665f4f7a73bf18a26f2cb32d310de38e67898.json
Replace ENV["HOME"] with Dir.home
Library/Homebrew/diagnostic.rb
@@ -70,7 +70,7 @@ def inject_file_list(list, string) end def user_tilde(path) - path.gsub(ENV["HOME"], "~") + path.gsub(Dir.home, "~") end sig { returns(String) } @@ -766,7 +766,7 @@ def check_for_non_prefixed_coreutils end def check_for_pydistutils_cfg_in_h...
true
Other
Homebrew
brew
e78665f4f7a73bf18a26f2cb32d310de38e67898.json
Replace ENV["HOME"] with Dir.home
Library/Homebrew/formula.rb
@@ -2433,7 +2433,7 @@ def common_stage_test_env GOCACHE: "#{HOMEBREW_CACHE}/go_cache", GOPATH: "#{HOMEBREW_CACHE}/go_mod_cache", CARGO_HOME: "#{HOMEBREW_CACHE}/cargo_cache", - CURL_HOME: ENV["CURL_HOME"] || ENV["HOME"], + CURL_HOME: ENV.fetch("CURL_HOME") { Dir.hom...
true
Other
Homebrew
brew
e78665f4f7a73bf18a26f2cb32d310de38e67898.json
Replace ENV["HOME"] with Dir.home
Library/Homebrew/formula_installer.rb
@@ -904,7 +904,7 @@ def build sandbox = Sandbox.new formula.logs.mkpath sandbox.record_log(formula.logs/"build.sandbox.log") - sandbox.allow_write_path(ENV["HOME"]) if interactive? + sandbox.allow_write_path(Dir.home) if interactive? sandbox.allow_write_temp_and_cache ...
true
Other
Homebrew
brew
e78665f4f7a73bf18a26f2cb32d310de38e67898.json
Replace ENV["HOME"] with Dir.home
Library/Homebrew/test/support/fixtures/cask/Casks/with-uninstall-script-user-relative.rb
@@ -8,9 +8,9 @@ app "MyFancyApp/MyFancyApp.app", target: "~/MyFancyApp.app" postflight do - File.write "#{ENV["HOME"]}/MyFancyApp.app/uninstall.sh", <<~SH + File.write "#{Dir.home}/MyFancyApp.app/uninstall.sh", <<~SH #!/bin/sh - /bin/rm -r "#{ENV["HOME"]}/MyFancyApp.app" + /bin/rm -r "#{D...
true
Other
Homebrew
brew
e78665f4f7a73bf18a26f2cb32d310de38e67898.json
Replace ENV["HOME"] with Dir.home
Library/Homebrew/utils.rb
@@ -291,7 +291,7 @@ def interactive_shell(f = nil) ENV["HOMEBREW_DEBUG_INSTALL"] = f.full_name end - if ENV["SHELL"].include?("zsh") && (home = ENV["HOME"])&.start_with?(HOMEBREW_TEMP.resolved_path.to_s) + if ENV["SHELL"].include?("zsh") && (home = Dir.home).start_with?(HOMEBREW_TEMP.resolved_path.t...
true
Other
Homebrew
brew
e78665f4f7a73bf18a26f2cb32d310de38e67898.json
Replace ENV["HOME"] with Dir.home
Library/Homebrew/utils/shell.rb
@@ -49,7 +49,7 @@ def export_value(key, value, shell = preferred) def profile case preferred when :bash - bash_profile = "#{ENV["HOME"]}/.bash_profile" + bash_profile = "#{Dir.home}/.bash_profile" return bash_profile if File.exist? bash_profile when :zsh return ...
true
Other
Homebrew
brew
fae972c9d708179f8fb1b91e49800f1ff2031bf9.json
brew.rb: remove 'nice' error message for missing envs
Library/Homebrew/brew.rb
@@ -11,11 +11,7 @@ std_trap = trap("INT") { exit! 130 } # no backtrace thanks # check ruby version before requiring any modules. -unless ENV["HOMEBREW_REQUIRED_RUBY_VERSION"] - raise "HOMEBREW_REQUIRED_RUBY_VERSION was not exported! Please call bin/brew directly!" -end - -REQUIRED_RUBY_X, REQUIRED_RUBY_Y, = ENV["H...
false
Other
Homebrew
brew
a2033c397e3ab0783aceac84025c9924ebed5c3f.json
Use EnvConfig methods over direct ENV access
Library/Homebrew/cmd/update-report.rb
@@ -54,19 +54,19 @@ def output_update_report ENV["HOMEBREW_LINUXBREW_CORE_MIGRATION"].blank? ohai "Re-running `brew update` for linuxbrew-core migration" - if ENV["HOMEBREW_CORE_DEFAULT_GIT_REMOTE"] != ENV["HOMEBREW_CORE_GIT_REMOTE"] + if HOMEBREW_CORE_DEFAULT_GIT_REMOTE != Homebrew::EnvConfi...
true
Other
Homebrew
brew
a2033c397e3ab0783aceac84025c9924ebed5c3f.json
Use EnvConfig methods over direct ENV access
Library/Homebrew/dev-cmd/livecheck.rb
@@ -12,7 +12,7 @@ module Homebrew module_function WATCHLIST_PATH = ( - ENV["HOMEBREW_LIVECHECK_WATCHLIST"] || + Homebrew::EnvConfig.livecheck_watchlist || "#{Dir.home}/.brew_livecheck_watchlist" ).freeze @@ -58,7 +58,7 @@ def livecheck if args.debug? && args.verbose? puts args - ...
true
Other
Homebrew
brew
8500c264191be27ccbf07b87761cecf131a724b2.json
.rubocop.yml: fix obsolete parameter usage
Library/.rubocop.yml
@@ -97,7 +97,7 @@ Naming/InclusiveLanguage: - "patches/13_fix_scope_for_show_slave_status_data.patch" # Used in formula `mytop` Naming/MethodName: - IgnoredPatterns: + AllowedPatterns: - '\A(fetch_)?HEAD\?\Z' # Both styles are used depending on context, @@ -389,7 +389,7 @@ Naming/MethodParameterNa...
false
Other
Homebrew
brew
ad5391830283973b20522b1d2616a7310727ecbc.json
Update RBI files for rubocop.
Library/Homebrew/sorbet/rbi/gems/rubocop@1.30.1.rbi
@@ -49,6 +49,8 @@ class RuboCop::CLI::Command::AutoGenerateConfig < ::RuboCop::CLI::Command::Base def line_length_enabled?(config); end def max_line_length(config); end def maybe_run_line_length_cop; end + def options_config_in_root?; end + def relative_path_to_todo_from_options_config; end def reset_conf...
true
Other
Homebrew
brew
ad5391830283973b20522b1d2616a7310727ecbc.json
Update RBI files for rubocop.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -4942,6 +4942,8 @@ module RuboCop::AST::NodePattern::Sets SET_INCLUDE_WITH_WITHOUT = ::T.let(nil, ::T.untyped) SET_SYSTEM_SHELL_OUTPUT_PIPE_OUTPUT = ::T.let(nil, ::T.untyped) SET_WITH_WITHOUT = ::T.let(nil, ::T.untyped) + SET__FETCH = ::T.let(nil, ::T.untyped) + SET_____2 = ::T.let(nil, ::T.untyped) end ...
true
Other
Homebrew
brew
502769bb85bdc63dcca144ba63e4c50f8f1eec7a.json
Update RBI files for rubocop-sorbet.
Library/Homebrew/sorbet/rbi/gems/rubocop-sorbet@0.6.10.rbi
@@ -166,6 +166,11 @@ class RuboCop::Cop::Sorbet::ForbidTUnsafe < ::RuboCop::Cop::Cop def t_unsafe?(param0 = T.unsafe(nil)); end end +class RuboCop::Cop::Sorbet::ForbidTUntyped < ::RuboCop::Cop::Cop + def on_send(node); end + def t_untyped?(param0 = T.unsafe(nil)); end +end + class RuboCop::Cop::Sorbet::ForbidU...
false
Other
Homebrew
brew
15cf890ed747babbcc32a1ac9283ea2f56e3a019.json
Fix caveats when loading from the API
Library/Homebrew/formulary.rb
@@ -203,7 +203,7 @@ def install @caveats_string = json_formula["caveats"] def caveats - @caveats_string + self.class.instance_variable_get(:@caveats_string) end end
true
Other
Homebrew
brew
15cf890ed747babbcc32a1ac9283ea2f56e3a019.json
Fix caveats when loading from the API
Library/Homebrew/test/formulary_spec.rb
@@ -241,7 +241,7 @@ def formula_json_contents(extra_items = {}) "recommended_dependencies" => ["recommended_dep"], "optional_dependencies" => ["optional_dep"], "uses_from_macos" => ["uses_from_macos_dep"], - "caveats" => "", + "ca...
true
Other
Homebrew
brew
37306fb044e7876bb513d078202ac41339d89f24.json
sorbet: Update RBI files. Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -2391,6 +2391,12 @@ module Hardware extend ::T::Private::Methods::SingletonMethodHooks end +class Hash + def deep_transform_values(&block); end + + def deep_transform_values!(&block); end +end + module Homebrew MAX_PORT = ::T.let(nil, ::T.untyped) MIN_PORT = ::T.let(nil, ::T.untyped) @@ -2400,10 +2406...
false
Other
Homebrew
brew
547d3c9e0fb3970f83925ee0aa237c0d2cfa8714.json
.rubocop.yml: enable some new cops from rubocop-rails 2.15.0
Library/.rubocop.yml
@@ -237,6 +237,10 @@ Rails/SafeNavigation: Enabled: true Rails/SafeNavigationWithBlank: Enabled: true +Rails/StripHeredoc: + Enabled: true +Rails/ToFormattedS: + Enabled: true # Don't allow cops to be disabled in casks and formulae. Style/DisableCopsWithinSourceCodeDirective:
false
Other
Homebrew
brew
0ea9f5ec808c2ee843bf0cd84e061d9aaed8df8e.json
Add tests for convert_to_string_or_symbol
Library/Homebrew/test/formulary_spec.rb
@@ -345,6 +345,16 @@ def formula_json_contents(extra_items = {}) end end + describe "::convert_to_string_or_symbol" do + it "returns the original string if it doesn't start with a colon" do + expect(described_class.convert_to_string_or_symbol("foo")).to eq "foo" + end + + it "returns a symbol i...
false
Other
Homebrew
brew
98f8a86af3b09f52a2a1e1dc924e569a2fde3bfe.json
Clarify TODO in `brew update` Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Library/Homebrew/cmd/update.sh
@@ -748,7 +748,7 @@ EOS if [[ -n "${HOMEBREW_INSTALL_FROM_API}" ]] then mkdir -p "${HOMEBREW_CACHE}/api" - # TODO: etags? +# TODO: use --header If-Modified-Since curl \ "${CURL_DISABLE_CURLRC_ARGS[@]}" \ --fail --compressed --silent --max-time 5 \
false
Other
Homebrew
brew
8c8c6964c8371988b8d7831b2c2141596b67c814.json
Add more API test coverage
Library/Homebrew/test/formulary_spec.rb
@@ -236,11 +236,11 @@ def formula_json_contents(extra_items = {}) "reason" => ":provided_by_macos", "explanation" => "", }, - "build_dependencies" => [], - "dependencies" => [], - "recommended_dependencies" => [], - ...
false
Other
Homebrew
brew
dd516e4355f6a22f21cc8cc15546162c3df57473.json
Expand `Formulary` test coverage
Library/Homebrew/test/formulary_spec.rb
@@ -26,44 +26,6 @@ def install end RUBY end - let(:formula_json_contents) do - { - formula_name => { - "desc" => "testball", - "homepage" => "https://example.com", - "license" => "MIT", - "revision" ...
false
Other
Homebrew
brew
1e536217b2cb4395f1ebe5c0ba5c8bf1db4e7926.json
Streamline loading casks from API
Library/Homebrew/cask/cask.rb
@@ -6,7 +6,6 @@ require "cask/dsl" require "cask/metadata" require "searchable" -require "api" module Cask # An instance of a cask. @@ -166,14 +165,7 @@ def outdated_versions(greedy: false, greedy_latest: false, greedy_auto_updates: # special case: tap version is not available return [] if versio...
true
Other
Homebrew
brew
1e536217b2cb4395f1ebe5c0ba5c8bf1db4e7926.json
Streamline loading casks from API
Library/Homebrew/cask/cask_loader.rb
@@ -214,7 +214,15 @@ def self.for(ref) FromTapPathLoader, FromPathLoader, ].each do |loader_class| - return loader_class.new(ref) if loader_class.can_load?(ref) + next unless loader_class.can_load?(ref) + + if loader_class == FromTapLoader && Homebrew::EnvConfig.install_fro...
true
Other
Homebrew
brew
1e536217b2cb4395f1ebe5c0ba5c8bf1db4e7926.json
Streamline loading casks from API
Library/Homebrew/cask/caskroom.rb
@@ -49,7 +49,8 @@ def self.casks(config: nil) begin if (tap_path = CaskLoader.tap_paths(token).first) CaskLoader::FromTapPathLoader.new(tap_path).load(config: config) - elsif (caskroom_path = Pathname.glob(path.join(".metadata/*/*/*/*.rb")).first) + elsif (caskroom_pat...
true
Other
Homebrew
brew
1e536217b2cb4395f1ebe5c0ba5c8bf1db4e7926.json
Streamline loading casks from API
Library/Homebrew/cli/named_args.rb
@@ -45,18 +45,16 @@ def to_formulae # the formula and prints a warning unless `only` is specified. sig { params( - only: T.nilable(Symbol), - ignore_unavailable: T.nilable(T::Boolean), - method: T.nilable(Symbol), - uniq...
true
Other
Homebrew
brew
1e536217b2cb4395f1ebe5c0ba5c8bf1db4e7926.json
Streamline loading casks from API
Library/Homebrew/cmd/install.rb
@@ -167,7 +167,7 @@ def install end begin - formulae, casks = args.named.to_formulae_and_casks(prefer_loading_from_api: true) + formulae, casks = args.named.to_formulae_and_casks .partition { |formula_or_cask| formula_or_cask.is_a?(Formula) } rescue FormulaOrCaskU...
true
Other
Homebrew
brew
1e536217b2cb4395f1ebe5c0ba5c8bf1db4e7926.json
Streamline loading casks from API
Library/Homebrew/cmd/upgrade.rb
@@ -213,15 +213,6 @@ def upgrade_outdated_formulae(formulae, args:) def upgrade_outdated_casks(casks, args:) return false if args.formula? - if Homebrew::EnvConfig.install_from_api? - casks = casks.map do |cask| - next cask if cask.tap.present? && cask.tap != "homebrew/cask" - next cask ...
true
Other
Homebrew
brew
64768f9c2a19b7b8812c19bb06ef76ead506e09e.json
Update RBI files for minitest.
Library/Homebrew/sorbet/rbi/gems/minitest@5.16.0.rbi
@@ -11,6 +11,7 @@ module Minitest def autorun; end def backtrace_filter; end def backtrace_filter=(_arg0); end + def cattr_accessor(name); end def clock_time; end def extensions; end def extensions=(_arg0); end @@ -26,6 +27,8 @@ module Minitest def reporter=(_arg0); end def ru...
true
Other
Homebrew
brew
64768f9c2a19b7b8812c19bb06ef76ead506e09e.json
Update RBI files for minitest.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -3174,35 +3174,35 @@ module Minitest::Expectations end class Minitest::Mock - def ===(*args, &b); end + def ===(*args, **kwargs, &b); end def __call(name, data); end def __respond_to?(*arg); end - def class(*args, &b); end + def class(*args, **kwargs, &b); end - def expect(name, retval, args=T...
true
Other
Homebrew
brew
43f7fa4162e19eb88016a0f16fdd011384d20c41.json
Update cached formula json file when needed
Library/Homebrew/api/formula.rb
@@ -16,6 +16,11 @@ def formula_api_path end alias generic_formula_api_path formula_api_path + sig { returns(String) } + def cached_formula_json_file + HOMEBREW_CACHE_API/"#{formula_api_path}.json" + end + sig { params(name: String).returns(Hash) } def ...
true
Other
Homebrew
brew
43f7fa4162e19eb88016a0f16fdd011384d20c41.json
Update cached formula json file when needed
Library/Homebrew/cmd/update.sh
@@ -752,7 +752,7 @@ EOS curl \ "${CURL_DISABLE_CURLRC_ARGS[@]}" \ --fail --compressed --silent --max-time 5 \ - --location --output "${HOMEBREW_CACHE}/api/formula.json" \ + --location --remote-time --output "${HOMEBREW_CACHE}/api/formula.json" \ --user-agent "${HOMEBREW_USER_AGENT_CU...
true
Other
Homebrew
brew
89483abda9199d6c6ded1dd1f1163a41d4d8c2cd.json
Remove Bottle API
Library/Homebrew/api.rb
@@ -2,7 +2,6 @@ # frozen_string_literal: true require "api/analytics" -require "api/bottle" require "api/cask" require "api/cask-source" require "api/formula"
true
Other
Homebrew
brew
89483abda9199d6c6ded1dd1f1163a41d4d8c2cd.json
Remove Bottle API
Library/Homebrew/api/bottle.rb
@@ -1,96 +0,0 @@ -# typed: false -# frozen_string_literal: true - -require "github_packages" - -module Homebrew - module API - # Helper functions for using the bottle JSON API. - # - # @api private - module Bottle - class << self - extend T::Sig - - sig { returns(String) } - def b...
true
Other
Homebrew
brew
89483abda9199d6c6ded1dd1f1163a41d4d8c2cd.json
Remove Bottle API
Library/Homebrew/diagnostic.rb
@@ -890,7 +890,7 @@ def check_deleted_formula # Formulae installed with HOMEBREW_INSTALL_FROM_API should not count as deleted formulae # but may not have a tap listed in their tab tap = Tab.for_keg(keg).tap - next if (tap.blank? || tap.core_tap?) && Homebrew::API::Bottl...
true
Other
Homebrew
brew
89483abda9199d6c6ded1dd1f1163a41d4d8c2cd.json
Remove Bottle API
Library/Homebrew/test/api/bottle_spec.rb
@@ -1,95 +0,0 @@ -# typed: false -# frozen_string_literal: true - -require "api" - -describe Homebrew::API::Bottle do - let(:bottle_json) { - <<~EOS - { - "name": "hello", - "pkg_version": "2.10", - "rebuild": 0, - "bottles": { - "arm64_big_sur": { - "url": "http...
true
Other
Homebrew
brew
e53ccbc3cde32c38e584eb1a285cc09319d81653.json
Remove unnecessary code
Library/Homebrew/cask_dependent.rb
@@ -45,8 +45,8 @@ def requirements end end - def recursive_dependencies(ignore_missing: false, &block) - Dependency.expand(self, ignore_missing: ignore_missing, &block) + def recursive_dependencies(&block) + Dependency.expand(self, &block) end def recursive_requirements(&block)
true
Other
Homebrew
brew
e53ccbc3cde32c38e584eb1a285cc09319d81653.json
Remove unnecessary code
Library/Homebrew/cmd/reinstall.rb
@@ -88,22 +88,6 @@ def reinstall_args def reinstall args = reinstall_args.parse - # We need to use the bottle API instead of just using the formula file - # from an installed keg because it will not contain bottle information. - # As a consequence, `brew reinstall` will also upgrade outdated formulae...
true
Other
Homebrew
brew
e53ccbc3cde32c38e584eb1a285cc09319d81653.json
Remove unnecessary code
Library/Homebrew/dependency.rb
@@ -46,15 +46,6 @@ def to_formula formula end - def unavailable_core_formula? - to_formula - false - rescue CoreTapFormulaUnavailableError - true - rescue - false - end - def installed? to_formula.latest_version_installed? end @@ -98,7 +89,7 @@ class << self # the list. # ...
true
Other
Homebrew
brew
e53ccbc3cde32c38e584eb1a285cc09319d81653.json
Remove unnecessary code
Library/Homebrew/exceptions.rb
@@ -234,13 +234,6 @@ def to_s end end -# Raised when a formula in a the core tap is unavailable. -class CoreTapFormulaUnavailableError < TapFormulaUnavailableError - def initialize(name) - super CoreTap.instance, name - end -end - # Raised when a formula in a specific tap does not contain a formula class. ...
true
Other
Homebrew
brew
e53ccbc3cde32c38e584eb1a285cc09319d81653.json
Remove unnecessary code
Library/Homebrew/formula_installer.rb
@@ -218,11 +218,6 @@ def prelude def verify_deps_exist begin compute_dependencies - rescue CoreTapFormulaUnavailableError => e - raise unless Homebrew::API::Bottle.available? e.name - - Homebrew::API::Bottle.fetch_bottles(e.name) - retry rescue TapFormulaUnavailableError => e ...
true
Other
Homebrew
brew
e53ccbc3cde32c38e584eb1a285cc09319d81653.json
Remove unnecessary code
Library/Homebrew/formulary.rb
@@ -447,10 +447,6 @@ def get_formula(spec, alias_path: nil, force_bottle: false, flags: [], ignore_er rescue FormulaClassUnavailableError => e raise TapFormulaClassUnavailableError.new(tap, name, e.path, e.class_name, e.class_list), "", e.backtrace rescue FormulaUnavailableError => e - if tap.core...
true
Other
Homebrew
brew
944d7eebf0bbb869616d081ffcc12112a71624e6.json
Add bottle rebuild when loading from API
Library/Homebrew/formulary.rb
@@ -435,6 +435,7 @@ def klass(flags:, ignore_errors:) if (bottles_stable = json_formula["bottle"]["stable"]).present? bottle do root_url bottles_stable["root_url"] + rebuild bottles_stable["rebuild"] bottles_stable["files"].each do |tag, bottle_spec| ...
false
Other
Homebrew
brew
6bfe7022ad0a0050c83efb43c933f244a2168287.json
Update RBI files for rubocop-rails.
Library/Homebrew/sorbet/rbi/gems/rubocop-rails@2.15.0.rbi
@@ -539,7 +539,11 @@ RuboCop::Cop::Rails::DelegateAllowBlank::MSG = T.let(T.unsafe(nil), String) RuboCop::Cop::Rails::DelegateAllowBlank::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) class RuboCop::Cop::Rails::DeprecatedActiveModelErrorsMethods < ::RuboCop::Cop::Base + include ::RuboCop::Cop::RangeHelp + extend...
false
Other
Homebrew
brew
7a95219d2b60253103f04424e743501e35fe18cb.json
remove new method and reset without TODO
Library/Homebrew/formula_cellar_checks.rb
@@ -292,8 +292,7 @@ def check_cpuid_instruction(formula) dot_brew_formula = formula.prefix/".brew/#{formula.name}.rb" return unless dot_brew_formula.exist? - require "utils/ast" - return unless Utils::AST::FormulaAST.new(dot_brew_formula.read).include_runtime_cpu_detection? + return unless dot_brew...
true
Other
Homebrew
brew
7a95219d2b60253103f04424e743501e35fe18cb.json
remove new method and reset without TODO
Library/Homebrew/utils/ast.rb
@@ -190,19 +190,6 @@ def add_stanza(name, value, type: nil) tree_rewriter.insert_after(preceding_expr, "\n#{stanza_text(name, value, indent: 2)}") end - sig { returns(T::Boolean) } - def include_runtime_cpu_detection? - install_node = children.find do |child| - (child.is_a? R...
true
Other
Homebrew
brew
7e31574c3f23fdb2c27ab5d7d552e49792d0bddb.json
avoid nil error
Library/Homebrew/utils/ast.rb
@@ -199,7 +199,7 @@ def include_runtime_cpu_detection? return false if install_node.blank? install_node.each_node.any? do |node| - node.send_type? && node.receiver.const_name == "ENV" && node.method_name == :runtime_cpu_detection + node.send_type? && node.receiver&.const_name == "E...
false
Other
Homebrew
brew
8b14738a88da598558346ec7de557401622f4ef5.json
remove safe navigation operator
Library/Homebrew/utils/ast.rb
@@ -199,7 +199,7 @@ def include_runtime_cpu_detection? return false if install_node.blank? install_node.each_node.any? do |node| - node&.receiver&.const_name == "ENV" && node&.method_name == :runtime_cpu_detection + node.send_type? && node.receiver.const_name == "ENV" && node.metho...
false
Other
Homebrew
brew
f2fe1b59a19c4a80e6c0ff14d4f81720e6d1c1b9.json
move check ENV.runtime_cpu_detection to utils/ast
Library/Homebrew/formula_cellar_checks.rb
@@ -291,8 +291,9 @@ def check_cpuid_instruction(formula) dot_brew_formula = formula.prefix/".brew/#{formula.name}.rb" return unless dot_brew_formula.exist? - # TODO: add methods to `utils/ast` to allow checking for method use - return unless dot_brew_formula.read.include? "ENV.runtime_cpu_detection" +...
true
Other
Homebrew
brew
f2fe1b59a19c4a80e6c0ff14d4f81720e6d1c1b9.json
move check ENV.runtime_cpu_detection to utils/ast
Library/Homebrew/utils/ast.rb
@@ -190,6 +190,19 @@ def add_stanza(name, value, type: nil) tree_rewriter.insert_after(preceding_expr, "\n#{stanza_text(name, value, indent: 2)}") end + sig { returns(T::Boolean) } + def include_runtime_cpu_detection? + install_node = children.find do |child| + (child.is_a? R...
true
Other
Homebrew
brew
bd54b161100591b94735c97cef1895f57d092808.json
Update RBI files for zeitwerk.
Library/Homebrew/sorbet/rbi/gems/zeitwerk@2.6.0.rbi
@@ -47,6 +47,20 @@ class Zeitwerk::GemInflector < ::Zeitwerk::Inflector def camelize(basename, abspath); end end +class Zeitwerk::GemLoader < ::Zeitwerk::Loader + def initialize(root_file, warn_on_extra_files:); end + + def setup; end + + private + + def warn_on_extra_files; end + + class << self + def _n...
false
Other
Homebrew
brew
d600b662e255291232efa10c38d973697eea2dde.json
Expand documentation comments
Library/Homebrew/livecheck/strategy/electron_builder.rb
@@ -4,8 +4,8 @@ module Homebrew module Livecheck module Strategy - # The {ElectronBuilder} strategy fetches content at a URL and parses - # it as an electron-builder appcast in YAML format. + # The {ElectronBuilder} strategy fetches content at a URL and parses it + # as an electron-builder ...
true
Other
Homebrew
brew
d600b662e255291232efa10c38d973697eea2dde.json
Expand documentation comments
Library/Homebrew/livecheck/strategy/extract_plist.rb
@@ -58,6 +58,7 @@ def self.match?(url) # {UnversionedCaskChecker} version information. # # @param items [Hash] a hash of `Item`s containing version information + # @param regex [Regexp, nil] a regex for use in a strategy block # @return [Array] sig { params...
true
Other
Homebrew
brew
d600b662e255291232efa10c38d973697eea2dde.json
Expand documentation comments
Library/Homebrew/livecheck/strategy/sparkle.rb
@@ -6,8 +6,8 @@ module Homebrew module Livecheck module Strategy - # The {Sparkle} strategy fetches content at a URL and parses - # it as a Sparkle appcast in XML format. + # The {Sparkle} strategy fetches content at a URL and parses it as a + # Sparkle appcast in XML format. # ...
true
Other
Homebrew
brew
590aabe9d7d8d383c2be013e16e5fdf83942d584.json
livecheck: update default match_data This updates these strategies to better align with the default `match_data` value in other strategies.
Library/Homebrew/livecheck/strategy/electron_builder.rb
@@ -75,7 +75,7 @@ def self.find_versions(url:, regex: nil, **_unused, &block) raise ArgumentError, "#{T.must(name).demodulize} only supports a regex when using a `strategy` block" end - match_data = { matches: {}, url: url } + match_data = { matches: {}, regex: regex, url: ur...
true
Other
Homebrew
brew
590aabe9d7d8d383c2be013e16e5fdf83942d584.json
livecheck: update default match_data This updates these strategies to better align with the default `match_data` value in other strategies.
Library/Homebrew/livecheck/strategy/extract_plist.rb
@@ -96,7 +96,7 @@ def self.find_versions(cask:, regex: nil, **_unused, &block) end raise ArgumentError, "The #{T.must(name).demodulize} strategy only supports casks." unless T.unsafe(cask) - match_data = { matches: {} } + match_data = { matches: {}, regex: regex } ...
true
Other
Homebrew
brew
590aabe9d7d8d383c2be013e16e5fdf83942d584.json
livecheck: update default match_data This updates these strategies to better align with the default `match_data` value in other strategies.
Library/Homebrew/livecheck/strategy/sparkle.rb
@@ -199,7 +199,7 @@ def self.find_versions(url:, regex: nil, **_unused, &block) raise ArgumentError, "#{T.must(name).demodulize} only supports a regex when using a `strategy` block" end - match_data = { matches: {}, url: url } + match_data = { matches: {}, regex: regex, url: ...
true
Other
Homebrew
brew
16d1679ad19b8877045389c808129ff3060db7ba.json
Update RBI files for mechanize.
Library/Homebrew/sorbet/rbi/gems/mechanize@2.8.5.rbi
@@ -689,6 +689,7 @@ class Mechanize::HTTP::Agent def webrobots; end end +Mechanize::HTTP::Agent::COOKIE_HEADERS = T.let(T.unsafe(nil), Array) Mechanize::HTTP::Agent::CREDENTIAL_HEADERS = T.let(T.unsafe(nil), Array) Mechanize::HTTP::Agent::POST_HEADERS = T.let(T.unsafe(nil), Array) Mechanize::HTTP::Agent::Robot...
false
Other
Homebrew
brew
1d5c668110b81e417382ccb78dc09e19c2863cc5.json
Remove unused parser option required_for
Library/Homebrew/cli/parser.rb
@@ -148,7 +148,7 @@ def initialize(&block) generate_banner end - def switch(*names, description: nil, replacement: nil, env: nil, required_for: nil, depends_on: nil, + def switch(*names, description: nil, replacement: nil, env: nil, depends_on: nil, method: :on, hidden: fal...
true
Other
Homebrew
brew
1d5c668110b81e417382ccb78dc09e19c2863cc5.json
Remove unused parser option required_for
Library/Homebrew/test/cli/parser_spec.rb
@@ -164,21 +164,15 @@ subject(:parser) { described_class.new do flag "--flag1=" + flag "--flag2=", depends_on: "--flag1=" flag "--flag3=" - flag "--flag2=", required_for: "--flag1=" - flag "--flag4=", depends_on: "--flag3=" conflicts...
true
Other
Homebrew
brew
2a662e8683cd16d61885702236dd343984f5d3ac.json
Update RBI files for rubocop-performance.
Library/Homebrew/sorbet/rbi/gems/rubocop-performance@1.14.2.rbi
@@ -599,6 +599,7 @@ RuboCop::Cop::Performance::RedundantStringChars::RESTRICT_ON_SEND = T.let(T.unsa class RuboCop::Cop::Performance::RegexpMatch < ::RuboCop::Cop::Base extend ::RuboCop::Cop::AutoCorrector + extend ::RuboCop::Cop::TargetRubyVersion def last_matches(param0); end def match_method?(param0 =...
false
Other
Homebrew
brew
64a7c1f8213558f9aeaaa751492297e75463f656.json
Git: Remove tags_only_debian logic The `tags_only_debian` code in livecheck's `Git` strategy was originally introduced in Homebrew/homebrew-livecheck#131 when livecheck was in a less mature state and relied more on internal special-casing like this (i.e., while we worked to add appropriate `livecheck` blocks). This lo...
Library/Homebrew/livecheck/strategy/git.rb
@@ -101,13 +101,7 @@ def self.versions_from_tags(tags, regex = nil, &block) return Strategy.handle_block_return(block_return_value) end - tags_only_debian = tags.all? { |tag| tag.start_with?("debian/") } - tags.map do |tag| - # Skip tag if it has a 'debian/' pref...
false
Other
Homebrew
brew
a4ed8f0e2d54953b5a78786ccf097240eb75f6f8.json
sorbet: Update RBI files. Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -2452,6 +2452,8 @@ module Homebrew::EnvConfig def self.bat_config_path(); end + def self.bat_theme(); end + def self.bootsnap?(); end def self.bottle_domain(); end
false
Other
Homebrew
brew
1263ad99a4d21f375d24fcc2595a952f4d1d97e6.json
Update RBI files for sorbet-static-and-runtime.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -2452,6 +2452,8 @@ module Homebrew::EnvConfig def self.bat_config_path(); end + def self.bat_theme(); end + def self.bootsnap?(); end def self.bottle_domain(); end
false
Other
Homebrew
brew
608757bc90f6c04d623b0f70b3e9ba8b804675fc.json
sorbet: Update RBI files. Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -2574,8 +2574,6 @@ module Homebrew::EnvConfig def self.update_report_all_formulae?(); end - def self.update_report_version_changed_formulae?(); end - def self.update_to_tag?(); end def self.verbose?(); end
false
Other
Homebrew
brew
04c8e02418cb083f8c2b6f9e8b5ae83a23c1bdce.json
cmd/update-report: use better wording where appropriate. From reading https://github.com/orgs/Homebrew/discussions/3328: I initially thought we should just change "Updated" to "Modified" when appropriate. After conversation with Bo98, though, I thought more and saw that we're already checking for outdated formulae her...
Library/Homebrew/cmd/update-report.rb
@@ -1,7 +1,6 @@ # typed: false # frozen_string_literal: true -require "formula_versions" require "migrator" require "formulary" require "descriptions" @@ -204,6 +203,7 @@ def output_update_report hub.dump(updated_formula_report: !args.auto_update?) unless args.quiet? hub.reporters.each(&:migrat...
true
Other
Homebrew
brew
04c8e02418cb083f8c2b6f9e8b5ae83a23c1bdce.json
cmd/update-report: use better wording where appropriate. From reading https://github.com/orgs/Homebrew/discussions/3328: I initially thought we should just change "Updated" to "Modified" when appropriate. After conversation with Bo98, though, I thought more and saw that we're already checking for outdated formulae her...
Library/Homebrew/description_cache_store.rb
@@ -48,13 +48,13 @@ def update_from_report!(report) return populate_if_empty! if database.empty? return if report.empty? - renamings = report.select_formula(:R) - alterations = report.select_formula(:A) + - report.select_formula(:M) + + renamings = report.select_formula_or_cask...
true
Other
Homebrew
brew
04c8e02418cb083f8c2b6f9e8b5ae83a23c1bdce.json
cmd/update-report: use better wording where appropriate. From reading https://github.com/orgs/Homebrew/discussions/3328: I initially thought we should just change "Updated" to "Modified" when appropriate. After conversation with Bo98, though, I thought more and saw that we're already checking for outdated formulae her...
Library/Homebrew/env_config.rb
@@ -11,15 +11,15 @@ module EnvConfig module_function ENVS = { - HOMEBREW_ADDITIONAL_GOOGLE_ANALYTICS_ID: { + HOMEBREW_ADDITIONAL_GOOGLE_ANALYTICS_ID: { description: "Additional Google Analytics tracking ID to emit user behaviour analytics to. " \ "For more ...
true
Other
Homebrew
brew
04c8e02418cb083f8c2b6f9e8b5ae83a23c1bdce.json
cmd/update-report: use better wording where appropriate. From reading https://github.com/orgs/Homebrew/discussions/3328: I initially thought we should just change "Updated" to "Modified" when appropriate. After conversation with Bo98, though, I thought more and saw that we're already checking for outdated formulae her...
Library/Homebrew/test/cmd/update-report_spec.rb
@@ -52,39 +52,39 @@ def perform_update(fixture_name = "") specify "without Formula changes" do perform_update("update_git_diff_output_without_formulae_changes") - expect(hub.select_formula(:M)).to be_empty - expect(hub.select_formula(:A)).to be_empty - expect(hub.select_formula(:D)).to be_e...
true
Other
Homebrew
brew
04c8e02418cb083f8c2b6f9e8b5ae83a23c1bdce.json
cmd/update-report: use better wording where appropriate. From reading https://github.com/orgs/Homebrew/discussions/3328: I initially thought we should just change "Updated" to "Modified" when appropriate. After conversation with Bo98, though, I thought more and saw that we're already checking for outdated formulae her...
Library/Homebrew/test/description_cache_store_spec.rb
@@ -25,7 +25,7 @@ end describe "#update_from_report!" do - let(:report) { double(select_formula: [], empty?: false) } + let(:report) { double(select_formula_or_cask: [], empty?: false) } it "reads from the report" do expect(database).to receive(:empty?).at_least(:once).and_return(false) @@ -...
true
Other
Homebrew
brew
04c8e02418cb083f8c2b6f9e8b5ae83a23c1bdce.json
cmd/update-report: use better wording where appropriate. From reading https://github.com/orgs/Homebrew/discussions/3328: I initially thought we should just change "Updated" to "Modified" when appropriate. After conversation with Bo98, though, I thought more and saw that we're already checking for outdated formulae her...
Library/Homebrew/utils.rb
@@ -248,6 +248,16 @@ def pretty_installed(f) end end + def pretty_outdated(f) + if !$stdout.tty? + f.to_s + elsif Homebrew::EnvConfig.no_emoji? + Formatter.error("#{Tty.bold}#{f} (outdated)#{Tty.reset}") + else + "#{Tty.bold}#{f} #{Formatter.warning("⚠")}#{Tty.reset}" + end + end ...
true
Other
Homebrew
brew
04c8e02418cb083f8c2b6f9e8b5ae83a23c1bdce.json
cmd/update-report: use better wording where appropriate. From reading https://github.com/orgs/Homebrew/discussions/3328: I initially thought we should just change "Updated" to "Modified" when appropriate. After conversation with Bo98, though, I thought more and saw that we're already checking for outdated formulae her...
docs/Manpage.md
@@ -2172,10 +2172,7 @@ example, run `export HOMEBREW_NO_INSECURE_REDIRECT=1` rather than just *Default:* macOS: `/private/tmp`, Linux: `/tmp`. - `HOMEBREW_UPDATE_REPORT_ALL_FORMULAE` - <br>If set, `brew update` lists updates to all software. - -- `HOMEBREW_UPDATE_REPORT_VERSION_CHANGED_FORMULAE` - <br>If set, `...
true
Other
Homebrew
brew
04c8e02418cb083f8c2b6f9e8b5ae83a23c1bdce.json
cmd/update-report: use better wording where appropriate. From reading https://github.com/orgs/Homebrew/discussions/3328: I initially thought we should just change "Updated" to "Modified" when appropriate. After conversation with Bo98, though, I thought more and saw that we're already checking for outdated formulae her...
manpages/brew.1
@@ -1,7 +1,7 @@ .\" generated with Ronn/v0.7.3 .\" http://github.com/rtomayko/ronn/tree/0.7.3 . -.TH "BREW" "1" "May 2022" "Homebrew" "brew" +.TH "BREW" "1" "June 2022" "Homebrew" "brew" . .SH "NAME" \fBbrew\fR \- The Missing Package Manager for macOS (or Linux) @@ -3186,13 +3186,7 @@ Use this path as the tempora...
true
Other
Homebrew
brew
195e4d0f89ad53d72ac0ebd4823a41fdfb8d9e2a.json
software_spec: handle nil manifests_annotations. Fixes #13372
Library/Homebrew/software_spec.rb
@@ -384,7 +384,7 @@ def github_packages_manifest_resource_tab(github_packages_manifest_resource) manifests = json["manifests"] raise ArgumentError, "Missing 'manifests' section." if manifests.blank? - manifests_annotations = manifests.map { |m| m["annotations"] } + manifests_annotations = manifests.ma...
false
Other
Homebrew
brew
24def160b6e72c4d3387246b52160387a7f11fc9.json
Update RBI files for yard.
Library/Homebrew/sorbet/rbi/gems/yard@0.9.28.rbi
@@ -202,6 +202,7 @@ module YARD def ruby18?; end def ruby19?; end def ruby2?; end + def ruby31?; end def ruby3?; end def windows?; end end @@ -2408,6 +2409,7 @@ class YARD::Parser::Ruby::ModuleNode < ::YARD::Parser::Ruby::KeywordNode end class YARD::Parser::Ruby::ParameterNode < ::YAR...
false