language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | d8f28f42043f077e1b81290d9903c4dd13dca163.json | Improve types for @ember/object
Includes:
- Object, { action } from '@ember/object'
- CoreObject from '@ember/object/core'
- Observable from '@ember/object/observable'
Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be depreca... | packages/@ember/object/index.d.ts | @@ -1 +1,3 @@
export let action: MethodDecorator;
+
+export { Object as default } from '@ember/-internals/runtime'; | true |
Other | emberjs | ember.js | d8f28f42043f077e1b81290d9903c4dd13dca163.json | Improve types for @ember/object
Includes:
- Object, { action } from '@ember/object'
- CoreObject from '@ember/object/core'
- Observable from '@ember/object/observable'
Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be depreca... | packages/@ember/object/type-tests/core.test.ts | @@ -0,0 +1,5 @@
+import { expectTypeOf } from 'expect-type';
+
+import CoreObject from '@ember/object/core';
+
+expectTypeOf(CoreObject.create()).toEqualTypeOf<CoreObject>(); | true |
Other | emberjs | ember.js | d8f28f42043f077e1b81290d9903c4dd13dca163.json | Improve types for @ember/object
Includes:
- Object, { action } from '@ember/object'
- CoreObject from '@ember/object/core'
- Observable from '@ember/object/observable'
Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be depreca... | packages/@ember/object/type-tests/index.test.ts | @@ -0,0 +1,5 @@
+import { expectTypeOf } from 'expect-type';
+
+import EmberObject from '@ember/object';
+
+expectTypeOf(EmberObject.create()).toEqualTypeOf<EmberObject>(); | true |
Other | emberjs | ember.js | d8f28f42043f077e1b81290d9903c4dd13dca163.json | Improve types for @ember/object
Includes:
- Object, { action } from '@ember/object'
- CoreObject from '@ember/object/core'
- Observable from '@ember/object/observable'
Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be depreca... | packages/@ember/object/type-tests/observable.test.ts | @@ -0,0 +1,5 @@
+import { expectTypeOf } from 'expect-type';
+
+import Observable from '@ember/object/observable';
+
+expectTypeOf<Observable['get']>().toEqualTypeOf<<K extends keyof Observable>(key: K) => unknown>(); | true |
Other | emberjs | ember.js | d8f28f42043f077e1b81290d9903c4dd13dca163.json | Improve types for @ember/object
Includes:
- Object, { action } from '@ember/object'
- CoreObject from '@ember/object/core'
- Observable from '@ember/object/observable'
Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be depreca... | packages/@ember/object/types/core.d.ts | @@ -0,0 +1 @@
+export { CoreObject as default } from '../../-internals/runtime'; | true |
Other | emberjs | ember.js | d8f28f42043f077e1b81290d9903c4dd13dca163.json | Improve types for @ember/object
Includes:
- Object, { action } from '@ember/object'
- CoreObject from '@ember/object/core'
- Observable from '@ember/object/observable'
Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be depreca... | packages/@ember/object/types/observable.d.ts | @@ -0,0 +1,2 @@
+import Observable from '@ember/-internals/runtime/types/observable';
+export default Observable; | true |
Other | emberjs | ember.js | d8f28f42043f077e1b81290d9903c4dd13dca163.json | Improve types for @ember/object
Includes:
- Object, { action } from '@ember/object'
- CoreObject from '@ember/object/core'
- Observable from '@ember/object/observable'
Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be depreca... | tests/docs/expected.js | @@ -37,7 +37,6 @@ module.exports = {
'_invoke',
'_lazyInjections',
'_logLookup',
- '_names',
'_normalizeCache',
'_onLookup',
'_options', | true |
Other | emberjs | ember.js | d8f28f42043f077e1b81290d9903c4dd13dca163.json | Improve types for @ember/object
Includes:
- Object, { action } from '@ember/object'
- CoreObject from '@ember/object/core'
- Observable from '@ember/object/observable'
Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be depreca... | tsconfig.json | @@ -24,17 +24,12 @@
"allowJs": false,
"paths": {
- "@glimmer/*": ["../node_modules/@glimmer/*"]
+ "@glimmer/*": ["../node_modules/@glimmer/*"],
+ "@ember/object/*": ["@ember/object/*", "@ember/object/types/*"]
}
},
- "include": [
- "packages/**/*.ts",
- ],
+ "include": ["packa... | true |
Other | emberjs | ember.js | d8f28f42043f077e1b81290d9903c4dd13dca163.json | Improve types for @ember/object
Includes:
- Object, { action } from '@ember/object'
- CoreObject from '@ember/object/core'
- Observable from '@ember/object/observable'
Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be depreca... | yarn.lock | @@ -5007,6 +5007,11 @@ expand-tilde@^2.0.0, expand-tilde@^2.0.2:
dependencies:
homedir-polyfill "^1.0.1"
+expect-type@^0.11.0:
+ version "0.11.0"
+ resolved "https://registry.yarnpkg.com/expect-type/-/expect-type-0.11.0.tgz#bce1a3e283f0334eedb39699b57dd27be7009cc1"
+ integrity sha512-hkObxepDKhTYloH/UZoxYT... | true |
Other | emberjs | ember.js | ac201b8e3e52226dbc74daf7be476985f9109a61.json | Release notes for v3.27.1
(cherry picked from commit 8e57edd86d2c6a0171340b316b6c436b53efb7f6)
(cherry picked from commit b3b4e5386461f912f978edd20ff231d4261d2b93) | CHANGELOG.md | @@ -4,6 +4,13 @@
- [#19472](https://github.com/emberjs/ember.js/pull/19472) [BUGFIX] Prevent transformation of block params called `attrs`
+### v3.27.1 (May 13, 2021)
+
+- [#19540](https://github.com/emberjs/ember.js/pull/19540) [BUGFIX] Ensure ember-testing is loaded lazily
+- [#19541](https://github.com/emberjs/... | false |
Other | emberjs | ember.js | f77c8b0b6c03a927012250d96f448c2ec0ce31da.json | Add v3.28.0-beta.1 to CHANGELOG
(cherry picked from commit 916e1041d8ed38f4dc8cff0a7a9b3b4013659c6c) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.28.0-beta.1 (May 3, 2021)
+
+- [#19472](https://github.com/emberjs/ember.js/pull/19472) [BUGFIX] Prevent transformation of block params called `attrs`
+
### v3.27.0 (May 3, 2021)
- [#19309](https://github.com/emberjs/ember.js/pull/19309) / [#19487](https://github.com/emb... | false |
Other | emberjs | ember.js | 3afd20cb64c334d86c657d021fdd52de1fb0c1d6.json | Add v3.27.0 to CHANGELOG
(cherry picked from commit 74ef460ecb8295183efa9f5e31eeb8ec74155a49) | CHANGELOG.md | @@ -1,30 +1,20 @@
# Ember Changelog
-### v3.27.0-beta.4 (April 21, 2021)
-
-- [#19499](https://github.com/emberjs/ember.js/pull/19499) [BUGFIX beta] [DEPRECATION] Deprecate `@foo={{helper}}`
-- [#19499](https://github.com/emberjs/ember.js/pull/19499) [BUGFIX beta] `<:else>` and `<:inverse>` should be aliases (see )
... | false |
Other | emberjs | ember.js | ba337bb40ae944c80ce8cdbda7b5b1dd9a8a8b59.json | Remove some unnecessary use of reopen in Route | packages/@ember/-internals/routing/lib/system/route.ts | @@ -97,6 +97,8 @@ export function hasDefaultSerialize(route: Route): boolean {
*/
class Route extends EmberObject implements IRoute {
+ static isRouteFactory = true;
+
routeName!: string;
fullRouteName!: string;
context: {} = {};
@@ -1876,11 +1878,199 @@ class Route extends EmberObject implements IRoute {... | false |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | package.json | @@ -96,7 +96,7 @@
"auto-dist-tag": "^1.0.0",
"aws-sdk": "^2.686.0",
"babel-template": "^6.26.0",
- "backburner.js": "^2.6.0",
+ "backburner.js": "^2.7.0",
"broccoli-babel-transpiler": "^7.8.0",
"broccoli-file-creator": "^2.1.1",
"broccoli-persistent-filter": "^2.3.1", | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/@ember/-internals/views/lib/system/jquery.d.ts | @@ -0,0 +1,2 @@
+export let jQuery: any;
+export let jQueryDisabled: boolean; | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/@ember/engine/index.d.ts | @@ -1,7 +1,9 @@
-export { default as EngineInstance } from './instance';
+import EngineInstance from './instance';
+import { EngineInstanceOptions, Factory } from '@ember/-internals/owner';
+
export function getEngineParent(instance: EngineInstance): EngineInstance | undefined;
-import { EngineInstanceOptions, Facto... | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/@ember/runloop/index.d.ts | @@ -1,21 +1,25 @@
-import { Backburner, DeferredActionQueues, Timer } from 'backburner.js';
+import Backburner, { DeferredActionQueues, Timer } from 'backburner.js';
export const _backburner: Backburner;
-export const run = Backburner.run;
-export const schedule = Backburner.schedule;
-export const later = Backbur... | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/ember-template-compiler/lib/plugins/assert-against-dynamic-helpers-modifiers.ts | @@ -7,7 +7,7 @@ import { isPath, trackLocals } from './utils';
export default function assertAgainstDynamicHelpersModifiers(
env: EmberASTPluginEnvironment
): ASTPlugin {
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
let { hasLocal, node } = trackLocals();
return { | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/ember-template-compiler/lib/plugins/assert-against-named-blocks.ts | @@ -14,7 +14,7 @@ import { EmberASTPluginEnvironment } from '../types';
@class AssertAgainstNamedBlocks
*/
export default function assertAgainstNamedBlocks(env: EmberASTPluginEnvironment): ASTPlugin {
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
return {
name: 'assert-again... | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/ember-template-compiler/lib/plugins/assert-input-helper-without-block.ts | @@ -5,7 +5,7 @@ import { EmberASTPluginEnvironment } from '../types';
import { isPath } from './utils';
export default function errorOnInputWithContent(env: EmberASTPluginEnvironment): ASTPlugin {
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
return {
name: 'assert-input-help... | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/ember-template-compiler/lib/plugins/assert-reserved-named-arguments.ts | @@ -4,7 +4,7 @@ import calculateLocationDisplay from '../system/calculate-location-display';
import { EmberASTPluginEnvironment } from '../types';
export default function assertReservedNamedArguments(env: EmberASTPluginEnvironment): ASTPlugin {
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleN... | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/ember-template-compiler/lib/plugins/assert-splattribute-expression.ts | @@ -4,7 +4,7 @@ import calculateLocationDisplay from '../system/calculate-location-display';
import { EmberASTPluginEnvironment } from '../types';
export default function assertSplattributeExpressions(env: EmberASTPluginEnvironment): ASTPlugin {
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.module... | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/ember-template-compiler/lib/plugins/deprecate-send-action.ts | @@ -18,7 +18,7 @@ const EVENTS = [
export default function deprecateSendAction(env: EmberASTPluginEnvironment): ASTPlugin {
if (SEND_ACTION) {
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
let deprecationMessage = (node: AST.Node, eventName: string, actionName: string) => ... | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/ember-template-compiler/lib/plugins/deprecate-with.ts | @@ -58,7 +58,7 @@ import { isPath } from './utils';
@class DeprecateWith
*/
export default function deprecateWith(env: EmberASTPluginEnvironment): ASTPlugin {
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
let { builders: b } = env.syntax;
return { | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/ember-template-compiler/lib/plugins/transform-attrs-into-args.ts | @@ -29,7 +29,7 @@ import { EmberASTPluginEnvironment } from '../types';
export default function transformAttrsIntoArgs(env: EmberASTPluginEnvironment): ASTPlugin {
let { builders: b } = env.syntax;
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
let stack: string[][] = [[]];
| true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/ember-template-compiler/lib/plugins/transform-has-block-syntax.ts | @@ -32,7 +32,7 @@ const TRANSFORMATIONS: { [key: string]: string } = {
export default function transformHasBlockSyntax(env: EmberASTPluginEnvironment): ASTPlugin {
let { builders: b } = env.syntax;
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
function emitDeprecationMessage(nod... | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/ember-template-compiler/lib/plugins/transform-in-element.ts | @@ -42,7 +42,7 @@ import { isPath } from './utils';
@class TransformInElement
*/
export default function transformInElement(env: EmberASTPluginEnvironment): ASTPlugin {
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
let { builders: b } = env.syntax;
return { | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/ember-template-compiler/lib/plugins/transform-link-to.ts | @@ -43,7 +43,7 @@ function transformPositionalLinkToIntoNamedArguments(
hasBlock = true
): AST.BlockStatement {
let { builders: b } = env.syntax;
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
let {
params,
hash: { pairs }, | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/ember-template-compiler/lib/plugins/transform-old-class-binding-syntax.ts | @@ -5,7 +5,7 @@ import { Builders, EmberASTPluginEnvironment } from '../types';
export default function transformOldClassBindingSyntax(env: EmberASTPluginEnvironment): ASTPlugin {
let b = env.syntax.builders;
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
return {
name: 'tra... | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/ember-template-compiler/lib/plugins/transform-resolutions.ts | @@ -65,7 +65,7 @@ const TARGETS = Object.freeze(['helper', 'modifier']);
export default function transformResolutions(env: EmberASTPluginEnvironment): ASTPlugin {
let { builders: b } = env.syntax;
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
let { hasLocal, node: tracker } = trac... | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/ember-template-compiler/lib/system/calculate-location-display.ts | @@ -1,7 +1,7 @@
import { AST } from '@glimmer/syntax';
export default function calculateLocationDisplay(
- moduleName: string,
+ moduleName: string | undefined,
loc?: AST.SourceLocation | undefined
): string {
let moduleInfo = ''; | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/ember-template-compiler/lib/system/compile-options.ts | @@ -1,7 +1,6 @@
import { EMBER_STRICT_MODE } from '@ember/canary-features';
import { assert, deprecate } from '@ember/debug';
import { assign } from '@ember/polyfills';
-import { PrecompileOptions } from '@glimmer/compiler';
import { AST, ASTPlugin, ASTPluginEnvironment, Syntax } from '@glimmer/syntax';
import { R... | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/ember-template-compiler/lib/types.d.ts | @@ -1,10 +1,14 @@
-import { ASTPlugin, ASTPluginEnvironment, builders, PrecompileOptions } from '@glimmer/syntax';
-import { StaticTemplateMeta } from '@ember/-internals/views';
+import {
+ ASTPluginBuilder,
+ ASTPluginEnvironment,
+ builders,
+ PrecompileOptions,
+} from '@glimmer/syntax';
+import { LegacyPluginCl... | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | packages/ember/index.d.ts | @@ -1,5 +1,5 @@
declare module 'ember' {
- declare const Ember: any;
+ const Ember: any;
export default Ember;
} | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | tsconfig.json | @@ -23,10 +23,6 @@
"noEmit": true,
"allowJs": false,
- // TODO: remove this once router_js types have been fixed
- // https://github.com/tildeio/router.js/issues/290
- "skipLibCheck": true,
-
"paths": {
"@glimmer/*": ["../node_modules/@glimmer/*"]
} | true |
Other | emberjs | ember.js | eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json | Resolve types from external libraries | yarn.lock | @@ -2520,10 +2520,10 @@ backbone@^1.1.2:
dependencies:
underscore ">=1.8.3"
-backburner.js@^2.6.0:
- version "2.6.0"
- resolved "https://registry.yarnpkg.com/backburner.js/-/backburner.js-2.6.0.tgz#ff3315c38026cc52eb4447ce8de80ca71dd4cff0"
- integrity "sha1-/zMVw4AmzFLrREfOjegMpx3Uz/A= sha512-mN3OPIffal2Cg... | true |
Other | emberjs | ember.js | 8e02b9dc273413dfd3dfafc44b247df8769df1c9.json | Add comment explaining 'if' guard | packages/@ember/-internals/routing/lib/system/route.ts | @@ -502,6 +502,7 @@ class Route extends EmberObject implements IRoute {
loading(transition, route) {
const controller = this.controllerFor('foo');
+ // The controller may not be instantiated when initially loading
if (controller) {
controller.currentlyLoading = true;
| false |
Other | emberjs | ember.js | 62e7b92b1e29a5af2aa821bef5c902066c37948b.json | change public to private | packages/@ember/-internals/glimmer/lib/components/-link-to.ts | @@ -637,7 +637,7 @@ const LinkComponent = EmberComponent.extend({
* link-to-external component extends the link-to component.
*
* @method assertLinkToOrigin
- * @public
+ * @private
*/
assertLinkToOrigin() {
assert( | false |
Other | emberjs | ember.js | 3a1bfa250dd5f2e2e03f3a4cadf97f5967ea36cf.json | add assertLinkToOrigin to tests/docs/expected.js | packages/@ember/-internals/glimmer/lib/components/-link-to.ts | @@ -637,6 +637,7 @@ const LinkComponent = EmberComponent.extend({
* link-to-external component extends the link-to component.
*
* @method assertLinkToOrigin
+ * @public
*/
assertLinkToOrigin() {
assert( | true |
Other | emberjs | ember.js | 3a1bfa250dd5f2e2e03f3a4cadf97f5967ea36cf.json | add assertLinkToOrigin to tests/docs/expected.js | tests/docs/expected.js | @@ -92,6 +92,7 @@ module.exports = {
'arrayContentWillChange',
'assert',
'assertDestroyablesDestroyed',
+ 'assertLinkToOrigin',
'assign',
'associateDestroyableChild',
'asyncEnd', | true |
Other | emberjs | ember.js | c30f0b4dc780da35bc16afcea83bc85f31999909.json | fix linting errors | packages/@ember/-internals/glimmer/lib/components/-link-to.ts | @@ -645,7 +645,7 @@ const LinkComponent = EmberComponent.extend({
'See https://ember-engines.com/docs/links for more info.',
!this._isEngine || this._engineMountPoint !== undefined
);
- }
+ },
_isActive(routerState: RouterState): boolean {
if (this.loading) { | false |
Other | emberjs | ember.js | 3a6a3ab2fcf666af5c4d5acf89042331c3c27328.json | Add v3.27.0-beta.2 to CHANGELOG.md. | CHANGELOG.md | @@ -1,6 +1,11 @@
# Ember Changelog
-### v3.27.0 (March 22, 2021)
+### v3.27.0-beta.2 (March 25, 2021)
+
+- [#19473](https://github.com/emberjs/ember.js/pull/19473) Update GlimmerVM to latest (fix compatibility for template import proposals)
+- [#19474](https://github.com/emberjs/ember.js/pull/19474) [FEATURE] Enable... | false |
Other | emberjs | ember.js | 3b9eee2e6e08885ab6f93b0ce81f0e6be5a870c7.json | Add 3.26.1 to CHANGELOG.md. | CHANGELOG.md | @@ -14,6 +14,10 @@
- [#19441](https://github.com/emberjs/ember.js/pull/19441) Add automated publishing of weekly alpha releases to NPM
- [#19462](https://github.com/emberjs/ember.js/pull/19462) Use `positional` and `named` as the argument names in `ember g helper` blueprint
+### v3.26.1 (March 24, 2021)
+
+- [#1947... | false |
Other | emberjs | ember.js | d3a764c35b5363c180519cf3cf0e04e1cf44f75e.json | Add v3.25.4 to CHANGELOG.md.
(cherry picked from commit ee25b41214aefe89edd75551f0c6e8125a60eb9b) | CHANGELOG.md | @@ -34,6 +34,10 @@
- [#19405](https://github.com/emberjs/ember.js/pull/19405) [BUGFIX] Avoid instantiation errors when `app/router.js` injects the router service.
- [#19436](https://github.com/emberjs/ember.js/pull/19436) [BUGFIX] Support observer keys with colons
+### v3.25.4 (March 24, 2021)
+
+- [#19473](https:/... | false |
Other | emberjs | ember.js | e503e67adcb7bc86f8876d81c0e3d9e3110422bf.json | Add v3.27.0-beta.1 to CHANGELOG
(cherry picked from commit 19ffb4993c28301f6321b347e3a887ab64e5fa44) | CHANGELOG.md | @@ -1,5 +1,19 @@
# Ember Changelog
+### v3.27.0 (March 22, 2021)
+
+- [#19382](https://github.com/emberjs/ember.js/pull/19382) / [#19430](https://github.com/emberjs/ember.js/pull/19430) [FEATURE] Remaining implementation work per [RFC #671](https://github.com/emberjs/rfcs/blob/master/text/0671-modernize-built-in-com... | false |
Other | emberjs | ember.js | d622b7c4282dcdae57d389a01e889afbd0ff93fc.json | Add v3.26.0 to CHANGELOG
(cherry picked from commit 8cebe0a3b87292434c440489edf4cae44cdd2119) | CHANGELOG.md | @@ -1,31 +1,6 @@
# Ember Changelog
-### v3.26.0-beta.5 (March 16, 2021)
-
-- [#19405](https://github.com/emberjs/ember.js/pull/19405) [BUGFIX] Avoid instantiation errors when `app/router.js` injects the router service.
-
-### v3.26.0-beta.4 (March 08, 2021)
-
-- [#19436](https://github.com/emberjs/ember.js/pull/1943... | false |
Other | emberjs | ember.js | 04f28b234bd990e56bd3a93d7bb0485719f065e4.json | Add deprecation for the Ember Global | packages/@ember/-internals/bootstrap/index.js | @@ -1,5 +1,6 @@
import require from 'require';
import { context } from '@ember/-internals/environment';
+import { deprecate } from '@ember/debug';
(function () {
let Ember;
@@ -13,6 +14,20 @@ import { context } from '@ember/-internals/environment';
Ember = require('ember').default;
}
+ ... | true |
Other | emberjs | ember.js | 04f28b234bd990e56bd3a93d7bb0485719f065e4.json | Add deprecation for the Ember Global | packages/internal-test-helpers/lib/test-cases/default-resolver-application.js | @@ -12,7 +12,7 @@ export default class DefaultResolverApplicationTestCase extends AbstractApplicat
let application;
expectDeprecation(() => {
application = this.application = Application.create(this.applicationOptions);
- }, /Using the globals resolver is deprecated/);
+ }, /(Using the globals re... | true |
Other | emberjs | ember.js | e25282f6e854a1c9e4fb318b7aa162542b964804.json | Add v3.26.0-beta.5 to CHANGELOG
(cherry picked from commit 9c0ab229425ac239cf402b277dea530e93fc54e8) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.26.0-beta.5 (March 16, 2021)
+
+- [#19405](https://github.com/emberjs/ember.js/pull/19405) [BUGFIX] Avoid instantiation errors when `app/router.js` injects the router service.
+
### v3.26.0-beta.4 (March 08, 2021)
- [#19436](https://github.com/emberjs/ember.js/pull/19436... | false |
Other | emberjs | ember.js | 75fa7e35aadf5d260e5e9a14fe28634da0fccd82.json | Add v3.26.0-beta.4 to CHANGELOG
(cherry picked from commit 4d85839ca69cace64f6185ab184fc24f3f5c02d8) | CHANGELOG.md | @@ -1,5 +1,11 @@
# Ember Changelog
+### v3.26.0-beta.4 (March 08, 2021)
+
+- [#19436](https://github.com/emberjs/ember.js/pull/19436) [BUGFIX] Support observer keys with colons
+- [#19448](https://github.com/emberjs/ember.js/pull/19448) [BUGFIX] Ensure query params are preserved through an intermediate loading state... | false |
Other | emberjs | ember.js | 891fc1bd25b9736e0d645bda01155d3023f7fab1.json | Add v3.26.0-beta.3 to CHANGELOG
(cherry picked from commit b91e6f37ee917bccf535fffd3459ee443c037dd5) | CHANGELOG.md | @@ -1,5 +1,13 @@
# Ember Changelog
+### v3.26.0-beta.3 (March 02, 2021)
+
+- [#19412](https://github.com/emberjs/ember.js/pull/19412) [BUGFIX] Updates Glimmer VM to 0.76.0, fix:
+ - `if` helper returns `null` instead of `undefined`
+ - Using `get` helper with key `length` on a string in templates
+ - Value of inp... | false |
Other | emberjs | ember.js | 56c3520b0e52e5bc7f357b5865c34a23eefd98e7.json | Add v3.24.3, v3.25.2, and v3.25.3 to CHANGELOG.md. | CHANGELOG.md | @@ -25,6 +25,23 @@
- [#19298](https://github.com/emberjs/ember.js/pull/19298) [BUGFIX] Route serialize did not extract param off proxy
- [#19326](https://github.com/emberjs/ember.js/pull/19326) [BUGFIX] Lazily setup the router in non-application tests for <LinkTo> component
+
+### v3.25.3 (March 7, 2021)
+
+- [#194... | false |
Other | emberjs | ember.js | 7dbeded1db214814040d987df8b40fc95e8badd6.json | add tests to highlight #19307 | packages/ember/tests/routing/substates_test.js | @@ -1,5 +1,7 @@
import { RSVP } from '@ember/-internals/runtime';
import { Route } from '@ember/-internals/routing';
+import Controller from '@ember/controller';
+
import { moduleFor, ApplicationTestCase, runTask } from 'internal-test-helpers';
let counter;
@@ -193,6 +195,155 @@ moduleFor(
});
}
+ ... | false |
Other | emberjs | ember.js | 0b84bc8207472f271210b0503a811c3c4b3d6dd9.json | add rendered output of each-in | packages/@ember/-internals/glimmer/lib/helpers/each-in.ts | @@ -148,7 +148,14 @@ import { internalHelper } from './internal-helper';
</ul>
```
- Outputting their name and age.
+ Outputting their name and age:
+
+ ```html
+ <ul>
+ <li>name: Shelly Sails</li>
+ <li>age: 42</li>
+ </ul>
+ ```
@method each-in
@for Ember.Templates.helpers | false |
Other | emberjs | ember.js | 7765a6758be8b8473f06d41bd02914b904485d70.json | Use symbol to create private render method | packages/@ember/-internals/glimmer/tests/integration/application/debug-render-tree-test.ts | @@ -222,12 +222,12 @@ if (ENV._DEBUG_RENDER_TREE) {
}
renderTemplate(_: Controller, { showHeader }: Model): void {
- expectDeprecation(() => this.render(), 'Usage of `render` is deprecated.');
+ expectDeprecation(() => this.render(), /Usage of `render` is deprecated... | true |
Other | emberjs | ember.js | 7765a6758be8b8473f06d41bd02914b904485d70.json | Use symbol to create private render method | packages/@ember/-internals/glimmer/tests/integration/application/rendering-test.js | @@ -470,7 +470,7 @@ moduleFor(
into: 'application',
outlet: 'nav',
});
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
})
);
@@ -617,7 +617,7 @@ moduleFor(
renderTemplate(co... | true |
Other | emberjs | ember.js | 7765a6758be8b8473f06d41bd02914b904485d70.json | Use symbol to create private render method | packages/@ember/-internals/routing/lib/system/route.ts | @@ -20,7 +20,7 @@ import {
Object as EmberObject,
typeOf,
} from '@ember/-internals/runtime';
-import { isProxy, lookupDescriptor } from '@ember/-internals/utils';
+import { isProxy, lookupDescriptor, symbol } from '@ember/-internals/utils';
import Controller from '@ember/controller';
import { assert, deprecat... | true |
Other | emberjs | ember.js | 7765a6758be8b8473f06d41bd02914b904485d70.json | Use symbol to create private render method | packages/ember/tests/routing/model_loading_test.js | @@ -216,7 +216,7 @@ moduleFor(
renderTemplate() {
expectDeprecation(
() => this.render('alternative_home'),
- 'Usage of `render` is deprecated.'
+ /Usage of `render` is deprecated/
);
},
}) | true |
Other | emberjs | ember.js | 7765a6758be8b8473f06d41bd02914b904485d70.json | Use symbol to create private render method | packages/ember/tests/routing/template_rendering_test.js | @@ -76,7 +76,7 @@ moduleFor(
'route:home',
Route.extend({
renderTemplate() {
- expectDeprecation(() => this.render('homepage'), 'Usage of `render` is deprecated.');
+ expectDeprecation(() => this.render('homepage'), /Usage of `render` is deprecated/);
},
... | true |
Other | emberjs | ember.js | 7765a6758be8b8473f06d41bd02914b904485d70.json | Use symbol to create private render method | tests/docs/expected.js | @@ -49,7 +49,6 @@ module.exports = {
'_qpChanged',
'_qpDelegate',
'_queryParamsFor',
- '_render',
'_renderMode',
'_resolveCache',
'_serializeQueryParam',
@@ -557,6 +556,7 @@ module.exports = {
'testing',
'textarea',
'then',
+ 'this[RENDER]',
'throttle',
'titl... | true |
Other | emberjs | ember.js | 51d3614d0c9eef9d2161b54f743caae9b9007a7c.json | Add deprecation for `render` method | packages/@ember/-internals/glimmer/tests/integration/application/debug-render-tree-test.ts | @@ -222,10 +222,13 @@ if (ENV._DEBUG_RENDER_TREE) {
}
renderTemplate(_: Controller, { showHeader }: Model): void {
- this.render();
+ expectDeprecation(() => this.render(), 'Usage of `render` is deprecated.');
if (showHeader) {
- this... | true |
Other | emberjs | ember.js | 51d3614d0c9eef9d2161b54f743caae9b9007a7c.json | Add deprecation for `render` method | packages/@ember/-internals/glimmer/tests/integration/application/rendering-test.js | @@ -464,11 +464,13 @@ moduleFor(
'route:application',
Route.extend({
renderTemplate() {
- this.render();
- this.render('nav', {
- into: 'application',
- outlet: 'nav',
- });
+ expectDeprecation(() => {
+ this... | true |
Other | emberjs | ember.js | 51d3614d0c9eef9d2161b54f743caae9b9007a7c.json | Add deprecation for `render` method | packages/@ember/-internals/routing/lib/system/route.ts | @@ -1485,6 +1485,29 @@ class Route extends EmberObject implements IRoute {
return route && route.currentModel;
}
+ /**
+ `_render` is used to render a template into a region of another template
+ (indicated by an `{{outlet}}`).
+
+ @method _render
+ @param {String} name the name of the template t... | true |
Other | emberjs | ember.js | 51d3614d0c9eef9d2161b54f743caae9b9007a7c.json | Add deprecation for `render` method | packages/ember/tests/routing/model_loading_test.js | @@ -214,7 +214,10 @@ moduleFor(
Route.extend({
controllerName: 'myController',
renderTemplate() {
- this.render('alternative_home');
+ expectDeprecation(
+ () => this.render('alternative_home'),
+ 'Usage of `render` is deprecated.'
+ ... | true |
Other | emberjs | ember.js | 51d3614d0c9eef9d2161b54f743caae9b9007a7c.json | Add deprecation for `render` method | packages/ember/tests/routing/template_rendering_test.js | @@ -76,7 +76,7 @@ moduleFor(
'route:home',
Route.extend({
renderTemplate() {
- this.render('homepage');
+ expectDeprecation(() => this.render('homepage'), 'Usage of `render` is deprecated.');
},
})
);
@@ -93,7 +93,7 @@ moduleFor(
'ro... | true |
Other | emberjs | ember.js | 51d3614d0c9eef9d2161b54f743caae9b9007a7c.json | Add deprecation for `render` method | tests/docs/expected.js | @@ -49,6 +49,7 @@ module.exports = {
'_qpChanged',
'_qpDelegate',
'_queryParamsFor',
+ '_render',
'_renderMode',
'_resolveCache',
'_serializeQueryParam', | true |
Other | emberjs | ember.js | b44adfee09f25d7dae36f8c831517f904798eb73.json | Update version to `3.27.0-alpha.0`. | package.json | @@ -1,6 +1,6 @@
{
"name": "ember-source",
- "version": "3.27.0",
+ "version": "3.27.0-alpha.0",
"description": "A JavaScript framework for creating ambitious web applications",
"keywords": [
"ember-addon" | false |
Other | emberjs | ember.js | 21350a5d8b9aa886390045701125d97143e682a0.json | Fix failing tests | packages/ember-testing/tests/acceptance_test.js | @@ -51,6 +51,7 @@ if (!jQueryDisabled) {
'route:posts',
Route.extend({
renderTemplate() {
+ expectDeprecation('Usage of `renderTemplate` is deprecated.');
testContext.currentRoute = 'posts';
this._super(...arguments);
... | true |
Other | emberjs | ember.js | 21350a5d8b9aa886390045701125d97143e682a0.json | Fix failing tests | packages/ember/tests/routing/template_rendering_test.js | @@ -305,7 +305,7 @@ moduleFor(
}
['@test Generated names can be customized when providing routes with dot notation'](assert) {
- assert.expect(4);
+ assert.expect(5);
this.addTemplate('index', '<div>Index</div>');
this.addTemplate('application', "<h1>Home</h1><div class='main'>{{ou... | true |
Other | emberjs | ember.js | 2676ee3b90c269a9b6606ec082dc66945317092d.json | Add renderTemplate deprecation | packages/@ember/-internals/routing/lib/system/route.ts | @@ -1507,6 +1507,17 @@ class Route extends EmberObject implements IRoute {
@public
*/
renderTemplate(_controller: any, _model: {}) {
+ if (this.renderTemplate !== Route.prototype.renderTemplate) {
+ deprecate('Usage of `renderTemplate` is deprecated.', false, {
+ id: 'route-render-template',
+... | false |
Other | emberjs | ember.js | e522fdc6192a45251d44dcb35deb8be1ab87294f.json | Add deprecation method to disconnectOutlet | packages/@ember/-internals/glimmer/tests/integration/application/debug-render-tree-test.ts | @@ -4,6 +4,8 @@ import {
moduleFor,
strip,
} from 'internal-test-helpers';
+import { ExpectDeprecationFunc } from '../../../../../../internal-test-helpers/lib/ember-dev/deprecation';
+declare let expectDeprecation: ExpectDeprecationFunc;
import { ENV } from '@ember/-internals/environment';
import { Component... | true |
Other | emberjs | ember.js | e522fdc6192a45251d44dcb35deb8be1ab87294f.json | Add deprecation method to disconnectOutlet | packages/@ember/-internals/routing/lib/system/route.ts | @@ -1705,6 +1705,15 @@ class Route extends EmberObject implements IRoute {
@public
*/
disconnectOutlet(options: string | { outlet: string; parentView?: string }) {
+ deprecate('The usage of `disconnectOutlet` is deprecated.', false, {
+ id: 'route-disconnect-outlet',
+ until: '4.0.0',
+ url... | true |
Other | emberjs | ember.js | e522fdc6192a45251d44dcb35deb8be1ab87294f.json | Add deprecation method to disconnectOutlet | packages/ember/tests/routing/template_rendering_test.js | @@ -775,10 +775,14 @@ moduleFor(
});
},
hideModal() {
- this.disconnectOutlet({
- outlet: 'modal',
- parentView: 'application',
- });
+ expectDeprecation(
+ () =>
+ this.disconne... | true |
Other | emberjs | ember.js | 3ce48a43a36083dd14615a018dd6fb53d953c669.json | Fix glimmer-component-docs.ts typo in Markdown
Was also affecting a heading anchor link. Kudos to @kaermorchen. | packages/@ember/-internals/glimmer/lib/glimmer-component-docs.ts | @@ -158,7 +158,7 @@
to `{{yield}}`. Whenever you invoke a component without passing explicitly
named blocks, the passed block is considered the `default` block.
- ### Passing parameters to named bxlocks
+ ### Passing parameters to named blocks
You can also pass parameters to named blocks:
| false |
Other | emberjs | ember.js | 4daccb827dffb1e4494219ca831ccb7613f5294c.json | unskip strict mode test | packages/@ember/-internals/glimmer/tests/integration/components/strict-mode-test.js | @@ -162,7 +162,7 @@ if (EMBER_STRICT_MODE) {
moduleFor(
'Strict Mode - built ins',
class extends RenderingTestCase {
- '@skip Can use Input'() {
+ '@test Can use Input'() {
let Foo = defineComponent({ Input }, '<Input/>');
this.registerComponent('foo', { ComponentClass: Foo })... | false |
Other | emberjs | ember.js | 3a7c034cdc81c3ed05508f64c630e2041995d2f8.json | Add v3.25.1 to CHANGELOG.
(cherry picked from commit 647279b71c15eb2de8c0ac68d078ed2c583d41dd) | CHANGELOG.md | @@ -25,6 +25,10 @@
- [#19298](https://github.com/emberjs/ember.js/pull/19298) [BUGFIX] Route serialize did not extract param off proxy
- [#19326](https://github.com/emberjs/ember.js/pull/19326) [BUGFIX] Lazily setup the router in non-application tests for <LinkTo> component
+### v3.25.1 (February 10, 2021)
+
+- [#1... | false |
Other | emberjs | ember.js | aa2594b09b8ce8e2df794aa46a1f86d03442ca43.json | Add v3.24.2 to CHANGELOG.md.
(cherry picked from commit 98745fbf3f9feb17d5fe32a8dcbb7c2c2b41bd06) | CHANGELOG.md | @@ -39,6 +39,10 @@
- [#19338](https://github.com/emberjs/ember.js/pull/19338) [BUGFIX] Add missing `deprecate` options (`for` + `since`)
- [#19342](https://github.com/emberjs/ember.js/pull/19342) [BUGFIX] Fix misleading LinkTo error message
+### v3.24.2 (February 10, 2021)
+
+- [#19326](https://github.com/emberjs/e... | false |
Other | emberjs | ember.js | 7f6cd8f743a7cc2f762a69f44455a7f169ac7bac.json | Add v3.16.0-beta.2 to CHANGELOG
(cherry picked from commit dd26c4edd3659a314cc7419899e4b6933b9df013) | CHANGELOG.md | @@ -1,5 +1,12 @@
# Ember Changelog
+### v3.26.0-beta.2 (February 15, 2021)
+
+- [#19387](https://github.com/emberjs/ember.js/pull/19387) [BUGFIX] LinkTo with incomplete model failing in rendering tests
+- [#19395](https://github.com/emberjs/ember.js/pull/19395) [BUGFIX] Only return empty href when LinkTo href genera... | false |
Other | emberjs | ember.js | 74e1b93e809eb59ed5ad3e2b1c412d170cc1ff1d.json | remove redundant comment and scenario | packages/@ember/-internals/routing/lib/services/routing.ts | @@ -54,10 +54,9 @@ export default class RoutingService extends Service {
generateURL(routeName: string, models: {}[], queryParams: {}) {
let router = this.router;
- // return early when the router microlib is not present, which is the case for <LinkTo/> in integration tests
- // also return early when t... | false |
Other | emberjs | ember.js | 6802d0d2413104f11208adc24e9847e602418145.json | add failing test
While generating link to route "dynamicWithChild.child": can't access
property "shouldSupercede", newHandlerInfo is undefined | packages/@ember/-internals/glimmer/tests/integration/components/link-to/rendering-angle-test.js | @@ -1,5 +1,11 @@
-import { moduleFor, ApplicationTestCase, RenderingTestCase, runTask } from 'internal-test-helpers';
-
+import {
+ moduleFor,
+ ApplicationTestCase,
+ RenderingTestCase,
+ RouterNonApplicationTestCase,
+ runTask,
+} from 'internal-test-helpers';
+import { Router, Route } from '@ember/-internals/ro... | false |
Other | emberjs | ember.js | 5e6b193367308ffb3ec13bde8c947149edfb5500.json | Add v3.26.0-beta.1 to CHANGELOG
(cherry picked from commit 63df7b58dceecf4d79e1a8f94e4fdd590fdf7395) | CHANGELOG.md | @@ -1,5 +1,23 @@
# Ember Changelog
+### v3.26.0-beta.1 (February 08, 2021)
+
+- [#19255](https://github.com/emberjs/ember.js/pull/19255) [DEPRECATION] Deprecate transition methods of controller and route per [RFC #674](https://github.com/emberjs/rfcs/blob/master/text/0674-deprecate-transition-methods-of-controller-a... | false |
Other | emberjs | ember.js | d58886db594226e954b8c5e4a94a5e392b72facd.json | Add v3.25.0 to CHANGELOG
(cherry picked from commit fca5ef67c756b5fbcaf96c374631b878fcdd34ec) | CHANGELOG.md | @@ -1,32 +1,19 @@
# Ember Changelog
-### v3.25.0-beta.5 (February 02, 2021)
+### v3.25.0 (February 08, 2021)
+- [#19302](https://github.com/emberjs/ember.js/pull/19302) / [#19306](https://github.com/emberjs/ember.js/pull/19306) / [#19319](https://github.com/emberjs/ember.js/pull/19319) [FEATURE] Implement the [Han... | false |
Other | emberjs | ember.js | bb607647f107a5046a19e67042bab33ba75f6e62.json | add more cases and tests | packages/@ember/-internals/metal/index.ts | @@ -59,7 +59,7 @@ export {
export { Mixin, aliasMethod, mixin, observer, applyMixin } from './lib/mixin';
export { default as inject, DEBUG_INJECTION_FUNCTIONS } from './lib/injected_property';
export { tagForProperty, tagForObject, markObjectAsDirty } from './lib/tags';
-export { tracked } from './lib/tracked';
+ex... | true |
Other | emberjs | ember.js | bb607647f107a5046a19e67042bab33ba75f6e62.json | add more cases and tests | packages/@ember/-internals/metal/lib/tracked.ts | @@ -191,16 +191,16 @@ function descriptorForField([target, key, desc]: [
return newDesc;
}
-class TrackedDescriptor {
+export class TrackedDescriptor {
constructor(private _get: () => unknown, private _set: (value: unknown) => void) {
CHAIN_PASS_THROUGH.add(this);
}
- get(obj: object) {
+ get(obj: ... | true |
Other | emberjs | ember.js | bb607647f107a5046a19e67042bab33ba75f6e62.json | add more cases and tests | packages/@ember/-internals/runtime/lib/system/core_object.js | @@ -28,6 +28,7 @@ import {
classToString,
isClassicDecorator,
DEBUG_INJECTION_FUNCTIONS,
+ TrackedDescriptor,
} from '@ember/-internals/metal';
import ActionHandler from '../mixins/action_handler';
import { assert, deprecate } from '@ember/debug';
@@ -129,7 +130,7 @@ function initialize(obj, properties) {
... | true |
Other | emberjs | ember.js | bb607647f107a5046a19e67042bab33ba75f6e62.json | add more cases and tests | packages/@ember/-internals/runtime/tests/system/object/create_test.js | @@ -1,7 +1,7 @@
import { getFactoryFor, Registry } from '@ember/-internals/container';
import { inspect } from '@ember/-internals/utils';
import { getOwner, setOwner } from '@ember/-internals/owner';
-import { computed, Mixin, observer, addObserver, alias } from '@ember/-internals/metal';
+import { computed, Mixin, ... | true |
Other | emberjs | ember.js | b06d98a118b3a49fd4ac200c37c2bc67d3a40296.json | Address some feedback | packages/@ember/-internals/extension-support/lib/data_adapter.js | @@ -234,6 +234,7 @@ export default EmberObject.extend({
@private
@property flushWatchers
@since 3.26.0
+
*/
/** | true |
Other | emberjs | ember.js | b06d98a118b3a49fd4ac200c37c2bc67d3a40296.json | Address some feedback | packages/@ember/-internals/extension-support/tests/data_adapter_test.js | @@ -15,17 +15,13 @@ const DataAdapter = EmberDataAdapter.extend({
},
init() {
this._super(...arguments);
- Object.defineProperty(this, 'containerDebugAdapter', {
- get() {
- return {
- canCatalogEntriesByType() {
- return true;
- },
- catalogEntriesByType(... | true |
Other | emberjs | ember.js | b06d98a118b3a49fd4ac200c37c2bc67d3a40296.json | Address some feedback | packages/@ember/-internals/routing/lib/ext/controller.ts | @@ -17,7 +17,7 @@ ControllerMixin.reopen({
this.namespace = owner.lookup('application:main');
this.target = owner.lookup('router:main');
}
- }
+ },
/**
Defines which query parameters the controller accepts. | true |
Other | emberjs | ember.js | b06d98a118b3a49fd4ac200c37c2bc67d3a40296.json | Address some feedback | packages/@ember/-internals/routing/lib/system/route.ts | @@ -1,3 +1,4 @@
+import { privatize as P } from '@ember/-internals/container';
import {
addObserver,
computed,
@@ -106,13 +107,12 @@ class Route extends EmberObject implements IRoute {
_names: unknown;
_router: EmberRouter | undefined;
- constructor() {
+ constructor(owner: Owner) {
super(...argum... | true |
Other | emberjs | ember.js | b06d98a118b3a49fd4ac200c37c2bc67d3a40296.json | Address some feedback | packages/@ember/-internals/routing/lib/system/router.ts | @@ -1,3 +1,4 @@
+import { privatize as P } from '@ember/-internals/container';
import { OutletState as GlimmerOutletState, OutletView } from '@ember/-internals/glimmer';
import { computed, get, notifyPropertyChange, set } from '@ember/-internals/metal';
import { BucketCache } from '@ember/-internals/routing';
@@ -14... | true |
Other | emberjs | ember.js | b06d98a118b3a49fd4ac200c37c2bc67d3a40296.json | Address some feedback | packages/@ember/-internals/runtime/lib/system/core_object.js | @@ -90,8 +90,9 @@ function initialize(obj, properties) {
let keyNames = Object.keys(properties);
for (let i = 0; i < keyNames.length; i++) {
- var keyName = keyNames[i];
- var value = properties[keyName];
+ // Hot path so 'var' to avoid closure, which may cause perf issues
+ let keyName ... | true |
Other | emberjs | ember.js | b06d98a118b3a49fd4ac200c37c2bc67d3a40296.json | Address some feedback | packages/@ember/-internals/utils/lib/inspect.ts | @@ -49,7 +49,7 @@ function inspectValue(value: any | null | undefined, depth: number, seen?: WeakS
if (value.toString === objectToString || value.toString === undefined) {
break;
}
- if (value.constructor && value.constructor.name !== 'Class') {
+ if (value.constructor && typeof value.c... | true |
Other | emberjs | ember.js | b06d98a118b3a49fd4ac200c37c2bc67d3a40296.json | Address some feedback | packages/@ember/application/lib/application.js | @@ -1172,7 +1172,7 @@ function commonSetupRegistry(registry) {
registry.register('location:history', HistoryLocation);
registry.register('location:none', NoneLocation);
- registry.register(`-bucket-cache:main`, {
+ registry.register(P`-bucket-cache:main`, {
create() {
return new BucketCache();
... | true |
Other | emberjs | ember.js | b06d98a118b3a49fd4ac200c37c2bc67d3a40296.json | Address some feedback | packages/@ember/engine/instance.js | @@ -182,7 +182,7 @@ const EngineInstance = EmberObject.extend(RegistryProxyMixin, ContainerProxyMixi
let singletons = [
'router:main',
- '-bucket-cache:main',
+ P`-bucket-cache:main`,
'-view-registry:main',
`renderer:-dom`,
'service:-document', | true |
Other | emberjs | ember.js | bd7833770f03dc3be95ec945013e3d2976d2317f.json | ES6 property syntax in Location example | packages/@ember/-internals/routing/lib/location/api.ts | @@ -58,13 +58,16 @@ export type UpdateCallback = (url: string) => void;
import HistoryLocation from '@ember/routing/history-location';
export default class MyHistory {
- implementation: 'my-custom-history',
+ implementation = 'my-custom-history';
+
constructor() {
this._history = HistoryLocati... | false |
Other | emberjs | ember.js | 002e4e86a763c6814e8035b411d41e384d76f61f.json | Add v3.25.0-beta.5 to CHANGELOG
(cherry picked from commit fc823791afc3d0e4b4508a751efe127ce46330b5) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.25.0-beta.5 (February 02, 2021)
+
+- [#19370](https://github.com/emberjs/ember.js/pull/19370) [BUGFIX] Update glimmer-vm to prevent errors for older inline precompilation
+
### v3.25.0-beta.4 (February 01, 2021)
- [#19363](https://github.com/emberjs/ember.js/pull/19363) ... | false |
Other | emberjs | ember.js | 8959f88b8678fe03660eba203af9b58220a4c053.json | Add v3.25.0-beta.4 to CHANGELOG
(cherry picked from commit 2dc1242d4ff7ba70cdcc1c4abebb4325e9bc973f) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.25.0-beta.4 (February 01, 2021)
+
+- [#19363](https://github.com/emberjs/ember.js/pull/19363) [BUGFIX] Update VM, fix component name preprocessing
+
### v3.25.0-beta.3 (January 25, 2021)
- [#19351](https://github.com/emberjs/ember.js/pull/19351) [BUGFIX] Ensure locals do... | false |
Other | emberjs | ember.js | 74e0f60d573a6981ccf5aed2f36372ff46035ad6.json | add url for with helper deprecation | packages/ember-template-compiler/lib/plugins/deprecate-with.ts | @@ -109,6 +109,7 @@ export default function deprecateWith(env: EmberASTPluginEnvironment): ASTPlugin
id: 'ember-glimmer.with-syntax',
until: '4.0.0',
for: 'ember-source',
+ url: 'https://deprecations.emberjs.com/v3.x/#toc_ember-glimmer-with-syntax',
since: {
... | false |
Other | emberjs | ember.js | 3ad915e5cf1f622e51d186b8ae910ed3b4fedca0.json | update license to 2021 | generators/license.js | @@ -1,6 +1,6 @@
/*!
* @overview Ember - JavaScript Application Framework
- * @copyright Copyright 2011-2020 Tilde Inc. and contributors
+ * @copyright Copyright 2011-2021 Tilde Inc. and contributors
* Portions Copyright 2006-2011 Strobe Inc.
* Portions Copyright 2008-2011 Apple Inc. All ri... | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.