language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 28a16f2b56584c7a786b85e393606aeb23d58802.json | fix typo in computed_macros.js
change 'provied' to 'provided' to improve API doc readability. | packages/ember-metal/lib/computed_macros.js | @@ -258,7 +258,7 @@ registerComputed('equal', function(dependentKey, value) {
});
/**
- A computed property that returns true if the provied dependent property
+ A computed property that returns true if the provided dependent property
is greater than the provided value.
Example | false |
Other | emberjs | ember.js | 85dd050c40c1458616c004dc0098123e03bd4ec4.json | Update morph and use new DOM Helper APIs | bower.json | @@ -11,6 +11,6 @@
"rsvp": "https://github.com/tildeio/rsvp.js.git#3.0.13",
"router.js": "https://github.com/tildeio/router.js.git#1562462f120156a140b9153bf36f1046f85e7812",
"route-recognizer": "https://github.com/tildeio/route-recognizer.git#8e1058e29de741b8e05690c69da9ec402a167c69",
- "htmlbars": "ht... | true |
Other | emberjs | ember.js | 85dd050c40c1458616c004dc0098123e03bd4ec4.json | Update morph and use new DOM Helper APIs | packages/ember-metal-views/lib/renderer.js | @@ -132,12 +132,7 @@ Renderer.prototype.scheduleInsert =
Renderer.prototype.appendTo =
function Renderer_appendTo(view, target) {
- // TODO use dom helper for creating this morph.
- var start = document.createTextNode('');
- var end = document.createTextNode('');
- target.appendChild(start);
- targ... | true |
Other | emberjs | ember.js | 85dd050c40c1458616c004dc0098123e03bd4ec4.json | Update morph and use new DOM Helper APIs | packages/ember-views/lib/system/render_buffer.js | @@ -231,15 +231,11 @@ _RenderBuffer.prototype = {
var el = this._element;
for (var i=0,l=childViews.length; i<l; i++) {
var childView = childViews[i];
- var morphId = '#morph-'+i;
- var ref = el.querySelector(morphId);
+ var ref = el.querySelector('#morph-'+i);
var parent = ref.pa... | true |
Other | emberjs | ember.js | 85dd050c40c1458616c004dc0098123e03bd4ec4.json | Update morph and use new DOM Helper APIs | packages/ember-views/lib/system/renderer.js | @@ -48,11 +48,7 @@ EmberRenderer.prototype.createChildViewsMorph =
view._childViewsMorph = view._morph;
} else {
element = document.createDocumentFragment();
- var start = document.createTextNode('');
- var end = document.createTextNode('');
- element.appendChild(start);
- ... | true |
Other | emberjs | ember.js | 47d00139ee7285a640930e9dbad3096ead8bd398.json | Update Morph to latest version.
Compare view:
https://github.com/tildeio/htmlbars/compare/1a4d5985824f4df23bb6e78829e442fe368937aa...7889d3f4d2a979f8e32648c92afa033f1f32b434
This includes some perf fixes by Stef to allow Morph's constructor to be
inlineable. | bower.json | @@ -11,6 +11,6 @@
"rsvp": "https://github.com/tildeio/rsvp.js.git#3.0.13",
"router.js": "https://github.com/tildeio/router.js.git#1562462f120156a140b9153bf36f1046f85e7812",
"route-recognizer": "https://github.com/tildeio/route-recognizer.git#8e1058e29de741b8e05690c69da9ec402a167c69",
- "htmlbars": "ht... | false |
Other | emberjs | ember.js | d0052ac58ea7045c1bc5b1190bd8225c42deb2c7.json | Remove dead code and polyfill for containsElement. | packages/ember-views/lib/views/states/pre_render.js | @@ -1,5 +1,3 @@
-/* global Node */
-
import _default from "ember-views/views/states/default";
import { create } from "ember-metal/platform";
import merge from "ember-metal/merge";
@@ -11,21 +9,4 @@ import jQuery from "ember-views/system/jquery";
*/
var preRender = create(_default);
-var containsElement;
-if (typ... | false |
Other | emberjs | ember.js | f9eee1f2939fe07f4fccf13571c64b965bcd5300.json | Multiline variable declarations | packages/ember-metal/lib/utils.js | @@ -357,7 +357,8 @@ export function setMeta(obj, property, value) {
*/
export function metaPath(obj, path, writable) {
Ember.deprecate("Ember.metaPath is deprecated and will be removed from future releases.");
- var _meta = meta(obj, writable), keyName, value;
+ var _meta = meta(obj, writable);
+ var keyName, v... | false |
Other | emberjs | ember.js | f3d41537475b44c5f7880dc48d6b0da53b810e0d.json | Remove publishing on failure.
All tests passing no need to publish on failure. | .travis.yml | @@ -10,8 +10,7 @@ cache:
install:
- "npm install"
- "./bin/generate_docs.js"
-after_failure:
- - "./bin/bower_ember_build"
+
after_success:
- "./bin/publish_to_s3.js"
- "./bin/bower_ember_build" | false |
Other | emberjs | ember.js | f959c8d9664ea53a8fca1ba74aa8ff575db7c2c6.json | Update more tests for ember-metal-views
* Fix test that prior rendering of a subtree doesn’t allow rerender until it is actually inserted if the root view is or will be inserted
* Fix odd test that doesn’t really make sense anymore as it is calling a private API that is going away. | packages/ember-metal-views/lib/renderer.js | @@ -18,8 +18,10 @@ function Renderer_renderTree(_view, _parentView, _insertAt) {
var total = 1;
var levelBase = _parentView ? _parentView._level+1 : 0;
- // if root view && view has a _morph assigned or _parentView._elementInserted
- var willInsert = _parentView == null ? !!_view._morph : _parentView._element... | true |
Other | emberjs | ember.js | f959c8d9664ea53a8fca1ba74aa8ff575db7c2c6.json | Update more tests for ember-metal-views
* Fix test that prior rendering of a subtree doesn’t allow rerender until it is actually inserted if the root view is or will be inserted
* Fix odd test that doesn’t really make sense anymore as it is calling a private API that is going away. | packages/ember-views/lib/system/renderer.js | @@ -5,17 +5,10 @@ import run from "ember-metal/run_loop";
import { set } from "ember-metal/property_set";
function EmberRenderer() {
- EmberRenderer.super.call(this);
+ Renderer.call(this);
}
-EmberRenderer.super = Renderer;
-EmberRenderer.prototype = Object.create(Renderer.prototype, {
- constructor: {
- va... | true |
Other | emberjs | ember.js | f959c8d9664ea53a8fca1ba74aa8ff575db7c2c6.json | Update more tests for ember-metal-views
* Fix test that prior rendering of a subtree doesn’t allow rerender until it is actually inserted if the root view is or will be inserted
* Fix odd test that doesn’t really make sense anymore as it is calling a private API that is going away. | packages/ember-views/lib/views/states/has_element.js | @@ -31,6 +31,9 @@ merge(hasElement, {
// once the view has been inserted into the DOM, rerendering is
// deferred to allow bindings to synchronize.
rerender: function(view) {
+ if (view._root._morph && !view._elementInserted) {
+ throw new EmberError("Something you did caused a view to re-render after ... | true |
Other | emberjs | ember.js | f959c8d9664ea53a8fca1ba74aa8ff575db7c2c6.json | Update more tests for ember-metal-views
* Fix test that prior rendering of a subtree doesn’t allow rerender until it is actually inserted if the root view is or will be inserted
* Fix odd test that doesn’t really make sense anymore as it is calling a private API that is going away. | packages/ember-views/tests/views/view/child_views_test.js | @@ -4,7 +4,7 @@ import run from "ember-metal/run_loop";
import EmberView from "ember-views/views/view";
-var parentView, childView, childViews;
+var parentView, childView;
QUnit.module('tests/views/view/child_views_tests.js', {
setup: function() {
@@ -25,8 +25,6 @@ QUnit.module('tests/views/view/child_views_... | true |
Other | emberjs | ember.js | eb8c4aa464c2b17216802566f74da96acd49fdcc.json | Pull htmlbars in via bower.
This allows much simpler updating to new versions, just update the sha
in `bower.json`, run `bower update htmlbars` and boom: new morph
version. | Brocfile.js | @@ -245,7 +245,7 @@ var vendoredPackages = {
'metamorph': vendoredPackage('metamorph'),
'router': vendoredEs6Package('router.js'),
'route-recognizer': vendoredEs6Package('route-recognizer'),
- 'morph': vendoredPackage('morph')
+ 'morph': morphTree('htmlbars/packages/mor... | true |
Other | emberjs | ember.js | eb8c4aa464c2b17216802566f74da96acd49fdcc.json | Pull htmlbars in via bower.
This allows much simpler updating to new versions, just update the sha
in `bower.json`, run `bower update htmlbars` and boom: new morph
version. | bower.json | @@ -10,6 +10,7 @@
"backburner": "https://github.com/ebryn/backburner.js.git#bf91c46978cced9aa130ca0793c5a72107e649db",
"rsvp": "https://github.com/tildeio/rsvp.js.git#3.0.13",
"router.js": "https://github.com/tildeio/router.js.git#1562462f120156a140b9153bf36f1046f85e7812",
- "route-recognizer": "https... | true |
Other | emberjs | ember.js | eb8c4aa464c2b17216802566f74da96acd49fdcc.json | Pull htmlbars in via bower.
This allows much simpler updating to new versions, just update the sha
in `bower.json`, run `bower update htmlbars` and boom: new morph
version. | packages/morph/lib/main.js | @@ -1,398 +0,0 @@
-define("morph",
- ["morph/morph","morph/dom-helper","exports"],
- function(__dependency1__, __dependency2__, __exports__) {
- "use strict";
- var Morph = __dependency1__["default"];
- var Morph;
- __exports__.Morph = Morph;
- var DOMHelper = __dependency2__["default"];
- var DOMHe... | true |
Other | emberjs | ember.js | dbdfa77b1adc13847034564a1578e8f6b1335002.json | Allow publishing on failure. | .travis.yml | @@ -10,7 +10,8 @@ cache:
install:
- "npm install"
- "./bin/generate_docs.js"
-
+after_failure:
+ - "./bin/bower_ember_build"
after_success:
- "./bin/publish_to_s3.js"
- "./bin/bower_ember_build" | false |
Other | emberjs | ember.js | ddda9e99d61d0960fcd1a6285f795625ac42cabe.json | Use sendEvent to fire willInsert/didInsertElement | packages/ember-metal-views/lib/main.js | @@ -7,6 +7,7 @@ import { set } from "ember-metal/property_set";
import { lookupView, setupView, teardownView, setupEventDispatcher, reset, events } from "ember-metal-views/events";
import { setupClassNames, setupClassNameBindings, setupAttributeBindings } from "ember-metal-views/attributes";
import { Placeholder } f... | false |
Other | emberjs | ember.js | 0cdbf59ab65f3d9e7235cfb6176ad5944390ea5d.json | prefer safe initializer by name storage | packages/ember-application/lib/system/application.js | @@ -37,6 +37,15 @@ import {
import EmberHandlebars from "ember-handlebars-compiler";
var ContainerDebugAdapter;
+function props(obj) {
+ var properties = [];
+
+ for (var key in obj) {
+ properties.push(key);
+ }
+
+ return properties;
+}
/**
An instance of `Ember.Application` is the starting point for... | false |
Other | emberjs | ember.js | d5bd2b9b9d1519791d0959fda997942e8ca714bc.json | prefer Object.create(null) for vertex by name map | packages/ember-application/lib/system/dag.js | @@ -37,7 +37,9 @@ function visit(vertex, fn, visited, path) {
*/
function DAG() {
this.names = [];
- this.vertices = {};
+ this.vertices = Object.create(null);
+}
+
/**
* DAG Vertex
*
@@ -61,15 +63,10 @@ function Vertex(name) {
* @param {String} name The name of the vertex to add
*/
DAG.prototype.add ... | false |
Other | emberjs | ember.js | e2cad66d95bbdbd6c50bb9d499c5bfee469f6323.json | Extract DAG Vertex to its own Constructor | packages/ember-application/lib/system/dag.js | @@ -38,6 +38,19 @@ function visit(vertex, fn, visited, path) {
function DAG() {
this.names = [];
this.vertices = {};
+/**
+ * DAG Vertex
+ *
+ * @class Vertex
+ * @constructor
+ */
+
+function Vertex(name) {
+ this.name = name;
+ this.incoming = {};
+ this.incomingNames = [];
+ this.hasOutgoing = false;
+ t... | false |
Other | emberjs | ember.js | c8d3b95f3e56ec404f9aeef79b7d81370e7a3018.json | remove duplicate Ember.keys file and imports | packages/ember-runtime/lib/keys.js | @@ -1,67 +0,0 @@
-import EnumerableUtils from 'ember-metal/enumerable_utils';
-import { create } from 'ember-metal/platform';
-
-/**
- Returns all of the keys defined on an object or hash. This is useful
- when inspecting objects for debugging. On browsers that support it, this
- uses the native `Object.keys` implem... | true |
Other | emberjs | ember.js | c8d3b95f3e56ec404f9aeef79b7d81370e7a3018.json | remove duplicate Ember.keys file and imports | packages/ember-runtime/lib/system/core_object.js | @@ -32,7 +32,7 @@ import {
import { indexOf } from "ember-metal/enumerable_utils";
import EmberError from "ember-metal/error";
import { platform } from "ember-metal/platform";
-import keys from "ember-runtime/keys";
+import keys from "ember-metal/keys";
import ActionHandler from "ember-runtime/mixins/action_handler... | true |
Other | emberjs | ember.js | c8d3b95f3e56ec404f9aeef79b7d81370e7a3018.json | remove duplicate Ember.keys file and imports | packages/ember-runtime/tests/computed/reduce_computed_test.js | @@ -8,7 +8,7 @@ import { set } from 'ember-metal/property_set';
import { meta as metaFor } from 'ember-metal/utils';
import run from 'ember-metal/run_loop';
import { observer } from 'ember-metal/mixin';
-import keys from "ember-runtime/keys";
+import keys from "ember-metal/keys";
import EmberObject from "ember-runt... | true |
Other | emberjs | ember.js | c8d3b95f3e56ec404f9aeef79b7d81370e7a3018.json | remove duplicate Ember.keys file and imports | packages/ember-runtime/tests/core/keys_test.js | @@ -1,5 +1,5 @@
import { set } from "ember-metal/property_set";
-import keys from "ember-runtime/keys";
+import keys from "ember-metal/keys";
import {
addObserver,
removeObserver | true |
Other | emberjs | ember.js | 73e5b11bba875253f80d11987aaaba4c02c91342.json | Fix incorrect usage of Ember.deprecate.
Apparently, I don't know how to Javascript. | packages/ember-routing-handlebars/lib/helpers/link_to.js | @@ -211,7 +211,7 @@ var LinkView = Ember.LinkView = EmberComponent.extend({
init: function() {
this._super.apply(this, arguments);
- Ember.deprecate('Using currentWhen with {{link-to}} is deprecated in favor of `current-when`.', this.currentWhen);
+ Ember.deprecate('Using currentWhen with {{link-to}} is... | true |
Other | emberjs | ember.js | 73e5b11bba875253f80d11987aaaba4c02c91342.json | Fix incorrect usage of Ember.deprecate.
Apparently, I don't know how to Javascript. | packages/ember/tests/helpers/link_to_test.js | @@ -279,7 +279,7 @@ test("The {{link-to}} helper supports currentWhen (DEPRECATED)", function() {
});
Ember.TEMPLATES.index = Ember.Handlebars.compile("<h3>Home</h3>{{outlet}}");
- Ember.TEMPLATES['index/about'] = Ember.Handlebars.compile("{{#link-to 'item' id='other-link' current-when='index'}}ITEM{{/link-to}... | true |
Other | emberjs | ember.js | 13c807b7e085cd91e5d40263b0ab0f299ee6a078.json | Update documentation to avoid global view access | packages/ember-handlebars-compiler/lib/main.js | @@ -93,7 +93,7 @@ var EmberHandlebars = Ember.Handlebars = objectCreate(Handlebars);
Which is functionally equivalent to:
```handlebars
- {{view App.CalendarView}}
+ {{view 'calendar'}}
```
Options in the helper will be passed to the view in exactly the same | true |
Other | emberjs | ember.js | 13c807b7e085cd91e5d40263b0ab0f299ee6a078.json | Update documentation to avoid global view access | packages/ember-handlebars/lib/controls/select.js | @@ -115,7 +115,7 @@ var SelectOptgroup = CollectionView.extend({
```
```handlebars
- {{view Ember.Select content=names}}
+ {{view "select" content=names}}
```
Would result in the following HTML:
@@ -138,10 +138,7 @@ var SelectOptgroup = CollectionView.extend({
```
```handlebars
- {{view Ember... | true |
Other | emberjs | ember.js | 13c807b7e085cd91e5d40263b0ab0f299ee6a078.json | Update documentation to avoid global view access | packages/ember-handlebars/lib/helpers/collection.js | @@ -36,52 +36,54 @@ var alias = computed.alias;
Given an empty `<body>` the following template:
```handlebars
- {{#collection contentBinding="App.items"}}
+ {{! application.hbs }}
+ {{#collection content=model}}
Hi {{view.content.name}}
{{/collection}}
```
And the following application code
... | true |
Other | emberjs | ember.js | 13c807b7e085cd91e5d40263b0ab0f299ee6a078.json | Update documentation to avoid global view access | packages/ember-handlebars/lib/helpers/each.js | @@ -260,131 +260,161 @@ GroupedEach.prototype = {
};
/**
- The `{{#each}}` helper loops over elements in a collection, rendering its
- block once for each item. It is an extension of the base Handlebars `{{#each}}`
- helper:
+ The `{{#each}}` helper loops over elements in a collection. It is an extension
+ of ... | true |
Other | emberjs | ember.js | 13c807b7e085cd91e5d40263b0ab0f299ee6a078.json | Update documentation to avoid global view access | packages/ember-handlebars/lib/helpers/view.js | @@ -335,7 +335,7 @@ export var ViewHelper = EmberObject.create({
specify a path to a custom view class.
```handlebars
- {{#view "MyApp.CustomView"}}
+ {{#view "custom"}}{{! will look up App.CustomView }}
hello.
{{/view}}
```
@@ -349,7 +349,7 @@ export var ViewHelper = EmberObject.create({
inne... | true |
Other | emberjs | ember.js | 13c807b7e085cd91e5d40263b0ab0f299ee6a078.json | Update documentation to avoid global view access | packages/ember-views/lib/views/collection_view.js | @@ -44,27 +44,32 @@ import EmberArray from "ember-runtime/mixins/array";
The view for each item in the collection will have its `content` property set
to the item.
- ## Specifying itemViewClass
+ ## Specifying `itemViewClass`
By default the view class for each item in the managed collection will be an
... | true |
Other | emberjs | ember.js | 13c807b7e085cd91e5d40263b0ab0f299ee6a078.json | Update documentation to avoid global view access | packages/ember-views/lib/views/view.js | @@ -600,8 +600,9 @@ var EMPTY_ARRAY = [];
on the descendent.
```javascript
- OuterView = Ember.View.extend({
- template: Ember.Handlebars.compile("outer {{#view InnerView}}inner{{/view}} outer"),
+ var App = Ember.Application.create();
+ App.OuterView = Ember.View.extend({
+ template: Ember.Handlebars.... | true |
Other | emberjs | ember.js | 0434d7f12f88cd1d023ad2c5bb2720bb0db41358.json | Prefer isPath over indexOf | packages/ember-metal/lib/property_get.js | @@ -62,7 +62,7 @@ var get = function get(obj, keyName) {
var value = _getPath(obj, keyName);
Ember.deprecate(
"Ember.get fetched '"+keyName+"' from the global context. This behavior will change in the future (issue #3852)",
- !value || (obj && obj !== Ember.lookup) || keyName.indexOf('.') !== -1 |... | false |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-debug/lib/main.js | @@ -93,7 +93,9 @@ Ember.deprecate = function(message, test) {
try { __fail__.fail(); } catch (e) { error = e; }
if (Ember.LOG_STACKTRACE_ON_DEPRECATION && error.stack) {
- var stack, stackStr = '';
+ var stack;
+ var stackStr = '';
+
if (error['arguments']) {
// Chrome
stack = error.... | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-extension-support/tests/container_debug_adapter_test.js | @@ -5,7 +5,8 @@ import { default as EmberController } from "ember-runtime/controllers/controller
import "ember-extension-support"; // Must be required to export Ember.ContainerDebugAdapter
import Application from "ember-application/system/application";
-var adapter, App, Model = EmberObject.extend();
+var adapter, ... | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-extension-support/tests/data_adapter_test.js | @@ -12,7 +12,8 @@ import EmberDataAdapter from "ember-extension-support/data_adapter";
import EmberApplication from "ember-application/system/application";
import DefaultResolver from "ember-application/system/resolver";
-var adapter, App, Model = EmberObject.extend();
+var adapter, App;
+var Model = EmberObject.ex... | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-handlebars/lib/ext.js | @@ -17,7 +17,8 @@ var resolveHelper,
import isEmpty from 'ember-metal/is_empty';
-var slice = [].slice, originalTemplate = EmberHandlebars.template;
+var slice = [].slice;
+var originalTemplate = EmberHandlebars.template;
/**
If a path starts with a reserved keyword, returns the root
@@ -443,7 +444,8 @@ func... | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-handlebars/lib/helpers/binding.js | @@ -125,7 +125,8 @@ function bind(property, options, preserveContext, shouldDisplay, valueNormalizer
run.once(view, 'rerender');
};
- var template, context, result = handlebarsGet(currentContext, property, options);
+ var template, context;
+ var result = handlebarsGet(currentContext, p... | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-handlebars/lib/helpers/collection.js | @@ -175,10 +175,13 @@ function collectionHelper(path, options) {
collectionClass = CollectionView;
}
- var hash = options.hash, itemHash = {}, match;
+ var hash = options.hash;
+ var itemHash = {};
+ var match;
// Extract item view class if provided else default to the standard class
- var collectio... | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-handlebars/lib/helpers/each.js | @@ -432,7 +432,8 @@ GroupedEach.prototype = {
@param [options.groupedRows] {boolean} enable normal item-by-item rendering when inside a `#group` helper
*/
function eachHelper(path, options) {
- var ctx, helperName = 'each';
+ var ctx;
+ var helperName = 'each';
if (arguments.length === 4) {
Ember.asse... | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-handlebars/lib/helpers/view.js | @@ -23,12 +23,12 @@ import {
import EmberString from "ember-runtime/system/string";
-var LOWERCASE_A_Z = /^[a-z]/,
- VIEW_PREFIX = /^view\./;
+var LOWERCASE_A_Z = /^[a-z]/;
+var VIEW_PREFIX = /^view\./;
function makeBindings(thisContext, options) {
- var hash = options.hash,
- hashType = options.hashTy... | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-handlebars/lib/loader.js | @@ -38,12 +38,12 @@ function bootstrap(ctx) {
var compile = (script.attr('type') === 'text/x-raw-handlebars') ?
jQuery.proxy(Handlebars.compile, Handlebars) :
- jQuery.proxy(EmberHandlebars.compile, EmberHandlebars),
- // Get the name of the script, used by Ember.View's t... | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-handlebars/tests/controls/select_test.js | @@ -135,8 +135,9 @@ test("can specify the property path for an option's label and value", function()
});
test("can retrieve the current selected option when multiple=false", function() {
- var yehuda = { id: 1, firstName: 'Yehuda' },
- tom = { id: 2, firstName: 'Tom' };
+ var yehuda = { id: 1, firstName: 'Ye... | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-handlebars/tests/handlebars_test.js | @@ -91,8 +91,8 @@ var appendView = function() {
run(function() { view.appendTo('#qunit-fixture'); });
};
-var originalLookup = Ember.lookup, lookup;
-var TemplateTests, container;
+var originalLookup = Ember.lookup;
+var TemplateTests, container, lookup;
/**
This module specifically tests integration with H... | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-handlebars/tests/helpers/debug_test.js | @@ -5,7 +5,8 @@ import EmberView from "ember-views/views/view";
import EmberHandlebars from "ember-handlebars-compiler";
import { logHelper } from "ember-handlebars/helpers/debug";
-var originalLookup = Ember.lookup, lookup;
+var originalLookup = Ember.lookup;
+var lookup;
var originalLog, logCalls;
var originalL... | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-handlebars/tests/helpers/each_test.js | @@ -23,7 +23,8 @@ function templateFor(template) {
return EmberHandlebars.compile(template);
}
-var originalLookup = Ember.lookup, lookup;
+var originalLookup = Ember.lookup;
+var lookup;
QUnit.module("the #each helper", {
setup: function() {
@@ -276,8 +277,8 @@ test("itemController specified in template ge... | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-handlebars/tests/helpers/partial_test.js | @@ -8,8 +8,8 @@ import EmberHandlebars from "ember-handlebars-compiler";
var compile = EmberHandlebars.compile;
-var MyApp;
-var originalLookup = Ember.lookup, lookup, TemplateTests, view, container;
+var MyApp, lookup, TemplateTests, view, container;
+var originalLookup = Ember.lookup;
QUnit.module("Support fo... | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-handlebars/tests/helpers/template_test.js | @@ -7,8 +7,8 @@ var trim = jQuery.trim;
import Container from "ember-runtime/system/container";
import EmberHandlebars from "ember-handlebars-compiler";
-var MyApp;
-var originalLookup = Ember.lookup, lookup, TemplateTests, view, container;
+var MyApp, lookup, TemplateTests, view, container;
+var originalLookup = E... | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-handlebars/tests/helpers/unbound_test.js | @@ -17,9 +17,8 @@ function appendView(view) {
run(function() { view.appendTo('#qunit-fixture'); });
}
-var view;
-var originalLookup = Ember.lookup, lookup;
-var container;
+var view, lookup, container;
+var originalLookup = Ember.lookup;
QUnit.module("Handlebars {{#unbound}} helper -- classic single-property ... | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-handlebars/tests/helpers/with_test.js | @@ -15,8 +15,8 @@ function appendView(view) {
run(function() { view.appendTo('#qunit-fixture'); });
}
-var view;
-var originalLookup = Ember.lookup, lookup;
+var view, lookup;
+var originalLookup = Ember.lookup;
QUnit.module("Handlebars {{#with}} helper", {
setup: function() { | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-handlebars/tests/helpers/yield_test.js | @@ -11,7 +11,8 @@ import { A } from "ember-runtime/system/native_array";
import Component from "ember-views/views/component";
import EmberError from "ember-metal/error";
-var originalLookup = Ember.lookup, lookup, TemplateTests, view, container;
+var originalLookup = Ember.lookup;
+var lookup, TemplateTests, view, ... | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-handlebars/tests/loader_test.js | @@ -3,7 +3,8 @@ import run from "ember-metal/run_loop";
import EmberView from "ember-views/views/view";
var trim = jQuery.trim;
-var originalLookup = Ember.lookup, lookup, Tobias, App, view;
+var originalLookup = Ember.lookup;
+var lookup, Tobias, App, view;
QUnit.module("test Ember.Handlebars.bootstrap", {
s... | true |
Other | emberjs | ember.js | 984b42329eff7eed66c36a05d0d79fc54000cba7.json | Replace multiline variable assignments.
* ember-handlebars
* ember-extension-support
* ember-debug | packages/ember-handlebars/tests/views/collection_view_test.js | @@ -28,7 +28,8 @@ function nthChild(view, nth) {
var firstChild = nthChild;
-var originalLookup = Ember.lookup, lookup, TemplateTests, view;
+var originalLookup = Ember.lookup;
+var lookup, TemplateTests, view;
QUnit.module("ember-handlebars/tests/views/collection_view_test", {
setup: function() { | true |
Other | emberjs | ember.js | 1b1477d47626373a7c35dd6338344f052bb17e0b.json | Remove some multiline var declarations.
Conflicts:
packages/ember-application/lib/ext/controller.js
packages/ember-application/tests/system/initializers_test.js
packages/ember-handlebars-compiler/tests/precompile_type_test.js | packages/container/tests/container_test.js | @@ -165,8 +165,8 @@ test("A container lookup has access to the container", function() {
});
test("Throw exception when trying to inject `type:thing` on all type(s)", function(){
- var container = new Container(),
- PostController = factory();
+ var container = new Container();
+ var PostController = factory()... | true |
Other | emberjs | ember.js | 1b1477d47626373a7c35dd6338344f052bb17e0b.json | Remove some multiline var declarations.
Conflicts:
packages/ember-application/lib/ext/controller.js
packages/ember-application/tests/system/initializers_test.js
packages/ember-handlebars-compiler/tests/precompile_type_test.js | packages/ember-application/tests/system/initializers_test.js | @@ -80,39 +80,40 @@ test("initializers can be registered in a specified order", function() {
test("initializers can have multiple dependencies", function () {
var order = [];
var a = {
- name: "a",
- before: "b",
- initialize: function(container) {
- order.push('a');
- }
- ... | true |
Other | emberjs | ember.js | 1b1477d47626373a7c35dd6338344f052bb17e0b.json | Remove some multiline var declarations.
Conflicts:
packages/ember-application/lib/ext/controller.js
packages/ember-application/tests/system/initializers_test.js
packages/ember-handlebars-compiler/tests/precompile_type_test.js | packages/ember-extension-support/lib/data_adapter.js | @@ -132,8 +132,10 @@ export default EmberObject.extend({
@return {Function} Method to call to remove all observers
*/
watchModelTypes: function(typesAdded, typesUpdated) {
- var modelTypes = this.getModelTypes(),
- self = this, typesToSend, releaseMethods = emberA();
+ var modelTypes = this.getM... | true |
Other | emberjs | ember.js | 1b1477d47626373a7c35dd6338344f052bb17e0b.json | Remove some multiline var declarations.
Conflicts:
packages/ember-application/lib/ext/controller.js
packages/ember-application/tests/system/initializers_test.js
packages/ember-handlebars-compiler/tests/precompile_type_test.js | packages/ember-extension-support/tests/data_adapter_test.js | @@ -66,15 +66,15 @@ test("Model types added with DefaultResolver", function() {
});
test("Model types added with custom container-debug-adapter", function() {
- var PostClass = Model.extend() ,
- StubContainerDebugAdapter = DefaultResolver.extend({
- canCatalogEntriesByType: function(type){
- ... | true |
Other | emberjs | ember.js | 1b1477d47626373a7c35dd6338344f052bb17e0b.json | Remove some multiline var declarations.
Conflicts:
packages/ember-application/lib/ext/controller.js
packages/ember-application/tests/system/initializers_test.js
packages/ember-handlebars-compiler/tests/precompile_type_test.js | packages/ember-handlebars-compiler/lib/main.js | @@ -206,14 +206,14 @@ EmberHandlebars.JavaScriptCompiler.prototype.appendToBuffer = function(string) {
// This can go away once the following is closed:
// https://github.com/wycats/handlebars.js/issues/634
-var DOT_LOOKUP_REGEX = /helpers\.(.*?)\)/,
- BRACKET_STRING_LOOKUP_REGEX = /helpers\['(.*?)'/,
- INVOC... | true |
Other | emberjs | ember.js | 1b1477d47626373a7c35dd6338344f052bb17e0b.json | Remove some multiline var declarations.
Conflicts:
packages/ember-application/lib/ext/controller.js
packages/ember-application/tests/system/initializers_test.js
packages/ember-handlebars-compiler/tests/precompile_type_test.js | packages/ember-handlebars-compiler/tests/block_helper_missing_test.js | @@ -1,7 +1,7 @@
import EmberHandlebars from "ember-handlebars-compiler";
-var stringify = EmberHandlebars.JavaScriptCompiler.stringifyLastBlockHelperMissingInvocation,
- s;
+var stringify = EmberHandlebars.JavaScriptCompiler.stringifyLastBlockHelperMissingInvocation;
+var s;
QUnit.module("stringifyLastBlockHel... | true |
Other | emberjs | ember.js | 1b1477d47626373a7c35dd6338344f052bb17e0b.json | Remove some multiline var declarations.
Conflicts:
packages/ember-application/lib/ext/controller.js
packages/ember-application/tests/system/initializers_test.js
packages/ember-handlebars-compiler/tests/precompile_type_test.js | packages/ember-handlebars-compiler/tests/precompile_type_test.js | @@ -1,8 +1,8 @@
import EmberHandlebars from "ember-handlebars-compiler";
-var precompile = EmberHandlebars.precompile,
- parse = EmberHandlebars.parse,
- template = 'Hello World',
- result;
+var precompile = EmberHandlebars.precompile;
+var parse = EmberHandlebars.parse;
+var template = 'Hello World';
+var re... | true |
Other | emberjs | ember.js | 1b1477d47626373a7c35dd6338344f052bb17e0b.json | Remove some multiline var declarations.
Conflicts:
packages/ember-application/lib/ext/controller.js
packages/ember-application/tests/system/initializers_test.js
packages/ember-handlebars-compiler/tests/precompile_type_test.js | packages/ember-handlebars/lib/component_lookup.js | @@ -5,9 +5,9 @@ var ComponentLookup = EmberObject.extend({
container = container || this.container;
- var fullName = 'component:' + name,
- templateFullName = 'template:components/' + name,
- templateRegistered = container && container.has(templateFullName);
+ var fullName = 'component:' + ... | true |
Other | emberjs | ember.js | 1b1477d47626373a7c35dd6338344f052bb17e0b.json | Remove some multiline var declarations.
Conflicts:
packages/ember-application/lib/ext/controller.js
packages/ember-application/tests/system/initializers_test.js
packages/ember-handlebars-compiler/tests/precompile_type_test.js | packages/ember-handlebars/lib/controls.js | @@ -199,10 +199,10 @@ function _resolveOption(context, options, key) {
export function inputHelper(options) {
Ember.assert('You can only pass attributes to the `input` helper, not arguments', arguments.length < 2);
- var hash = options.hash,
- types = options.hashTypes,
- inputType = _resolveOption(thi... | true |
Other | emberjs | ember.js | 1b1477d47626373a7c35dd6338344f052bb17e0b.json | Remove some multiline var declarations.
Conflicts:
packages/ember-application/lib/ext/controller.js
packages/ember-application/tests/system/initializers_test.js
packages/ember-handlebars-compiler/tests/precompile_type_test.js | packages/ember-handlebars/lib/controls/select.js | @@ -44,8 +44,8 @@ var SelectOption = View.extend({
},
selected: computed(function() {
- var content = get(this, 'content'),
- selection = get(this, 'parentView.selection');
+ var content = get(this, 'content');
+ var selection = get(this, 'parentView.selection');
if (get(this, 'parentView.m... | true |
Other | emberjs | ember.js | 1b1477d47626373a7c35dd6338344f052bb17e0b.json | Remove some multiline var declarations.
Conflicts:
packages/ember-application/lib/ext/controller.js
packages/ember-application/tests/system/initializers_test.js
packages/ember-handlebars-compiler/tests/precompile_type_test.js | packages/ember-handlebars/lib/controls/text_area.js | @@ -37,8 +37,8 @@ export default Component.extend(TextSupport, {
_updateElementValue: observer('value', function() {
// We do this check so cursor position doesn't get affected in IE
- var value = get(this, 'value'),
- $el = this.$();
+ var value = get(this, 'value');
+ var $el = this.$();
... | true |
Other | emberjs | ember.js | 1b1477d47626373a7c35dd6338344f052bb17e0b.json | Remove some multiline var declarations.
Conflicts:
packages/ember-application/lib/ext/controller.js
packages/ember-application/tests/system/initializers_test.js
packages/ember-handlebars-compiler/tests/precompile_type_test.js | packages/ember-handlebars/lib/controls/text_support.js | @@ -133,7 +133,7 @@ var TextSupport = Mixin.create(TargetActionSupport, {
},
/**
- Called when the text area is blurred.
+ Called when the text area is blurred.
Uses sendAction to send the `focus-out` action.
@@ -168,9 +168,9 @@ TextSupport.KEY_EVENTS = {
// sendAction semantics for TextField a... | true |
Other | emberjs | ember.js | 1b1477d47626373a7c35dd6338344f052bb17e0b.json | Remove some multiline var declarations.
Conflicts:
packages/ember-application/lib/ext/controller.js
packages/ember-application/tests/system/initializers_test.js
packages/ember-handlebars-compiler/tests/precompile_type_test.js | packages/ember-handlebars/lib/helpers/binding.js | @@ -757,8 +757,8 @@ function bindAttrHelper(options) {
// For each attribute passed, create an observer and emit the
// current value of the property as an attribute.
forEach.call(attrKeys, function(attr) {
- var path = attrs[attr],
- normalized;
+ var path = attrs[attr];
+ var normalized;
... | true |
Other | emberjs | ember.js | 1b1477d47626373a7c35dd6338344f052bb17e0b.json | Remove some multiline var declarations.
Conflicts:
packages/ember-application/lib/ext/controller.js
packages/ember-application/tests/system/initializers_test.js
packages/ember-handlebars-compiler/tests/precompile_type_test.js | packages/ember-handlebars/lib/helpers/debug.js | @@ -29,18 +29,18 @@ var a_slice = [].slice;
@param {String} property
*/
function logHelper() {
- var params = a_slice.call(arguments, 0, -1),
- options = arguments[arguments.length - 1],
- logger = Logger.log,
- values = [],
- allowPrimitives = true;
+ var params = a_slice.call(arguments, 0, ... | true |
Other | emberjs | ember.js | 1b1477d47626373a7c35dd6338344f052bb17e0b.json | Remove some multiline var declarations.
Conflicts:
packages/ember-application/lib/ext/controller.js
packages/ember-application/tests/system/initializers_test.js
packages/ember-handlebars-compiler/tests/precompile_type_test.js | packages/ember-handlebars/lib/helpers/each.js | @@ -4,7 +4,6 @@
@submodule ember-handlebars
*/
import Ember from "ember-metal/core"; // Ember.assert;, Ember.K
-// var emberAssert = Ember.assert,
var K = Ember.K;
import EmberHandlebars from "ember-handlebars-compiler";
@@ -155,8 +154,8 @@ runInDebug( function() {
});
var GroupedEach = EmberHandlebars.Group... | true |
Other | emberjs | ember.js | 4011c54de066748eca84c47c6bb5fb8548c61847.json | Add missing tests for Ember.DAG
I am not sure sure hoy to tag fixing the absence of tests. | packages/ember-application/tests/system/dag_test.js | @@ -0,0 +1,73 @@
+import DAG from "ember-application/system/dag";
+import EmberError from "ember-metal/error";
+
+QUnit.module("Ember.DAG");
+
+test("detects circular dependencies when added", function(){
+ var graph = new DAG();
+ graph.addEdges("eat omelette", 1);
+ graph.addEdges("buy eggs", 2) ;
+ graph.addEdge... | false |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/lib/array.js | @@ -89,10 +89,9 @@ var lastIndexOf = defineNativeShim(ArrayPrototype.lastIndexOf, function(obj, fro
});
var filter = defineNativeShim(ArrayPrototype.filter, function (fn, context) {
- var i,
- value,
- result = [],
- length = this.length;
+ var i, value;
+ var result = [];
+ var length = this.len... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/lib/binding.js | @@ -160,7 +160,8 @@ Binding.prototype = {
connect: function(obj) {
Ember.assert('Must pass a valid object to Ember.Binding.connect()', !!obj);
- var fromPath = this._from, toPath = this._to;
+ var fromPath = this._from;
+ var toPath = this._to;
trySet(obj, toPath, getWithGlobals(obj, fromPath));... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/lib/chains.js | @@ -4,9 +4,9 @@ import {meta} from "ember-metal/utils";
import {forEach} from "ember-metal/array";
import {watchKey, unwatchKey} from "ember-metal/watch_key";
-var metaFor = meta,
- warn = Ember.warn,
- FIRST_KEY = /^([^\.]+)/;
+var metaFor = meta;
+var warn = Ember.warn;
+var FIRST_KEY = /^([^\.]+)/;
func... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/lib/computed.js | @@ -27,8 +27,8 @@ import {
Ember.warn("The CP_DEFAULT_CACHEABLE flag has been removed and computed properties are always cached by default. Use `volatile` if you don't want caching.", Ember.ENV.CP_DEFAULT_CACHEABLE !== false);
-var metaFor = meta,
- a_slice = [].slice;
+var metaFor = meta;
+var a_slice = [].sli... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/lib/events.js | @@ -10,10 +10,12 @@ import {
} from "ember-metal/utils";
import { create } from "ember-metal/platform";
-var a_slice = [].slice,
- metaFor = meta,
- /* listener flags */
- ONCE = 1, SUSPENDED = 2;
+var a_slice = [].slice;
+var metaFor = meta;
+
+/* listener flags */
+var ONCE = 1;
+var SUSPENDED = 2;
... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/lib/expand_properties.js | @@ -6,8 +6,8 @@ import { forEach } from 'ember-metal/enumerable_utils';
@module ember-metal
*/
-var BRACE_EXPANSION = /^((?:[^\.]*\.)*)\{(.*)\}$/,
- SPLIT_REGEX = /\{|\}/;
+var BRACE_EXPANSION = /^((?:[^\.]*\.)*)\{(.*)\}$/;
+var SPLIT_REGEX = /\{|\}/;
/**
Expands `pattern`, invoking `callback` for each... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/lib/instrumentation.js | @@ -47,7 +47,8 @@ import { tryCatchFinally } from "ember-metal/utils";
@namespace Ember
@static
*/
-var subscribers = [], cache = {};
+var subscribers = [];
+var cache = {};
var populateListeners = function(name) {
var listeners = [], subscriber; | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/lib/mixin.js | @@ -36,13 +36,13 @@ import {
removeListener
} from "ember-metal/events";
-var REQUIRED,
- a_map = map,
- a_indexOf = indexOf,
- a_forEach = forEach,
- a_slice = [].slice,
- o_create = create,
- metaFor = meta;
+var REQUIRED;
+var a_map = map;
+var a_indexOf = indexOf;
+var a_forEach = forEach;
+... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/lib/observer_set.js | @@ -26,11 +26,11 @@ function ObserverSet() {
ObserverSet.prototype.add = function(sender, keyName, eventName) {
- var observerSet = this.observerSet,
- observers = this.observers,
- senderGuid = guidFor(sender),
- keySet = observerSet[senderGuid],
- index;
+ var observerSet = this.observerSet... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/lib/property_events.js | @@ -88,7 +88,8 @@ function dependentKeysWillChange(obj, depKey, meta) {
var deps;
if (meta && meta.deps && (deps = meta.deps[depKey])) {
- var seen = WILL_SEEN, top = !seen;
+ var seen = WILL_SEEN;
+ var top = !seen;
if (top) { seen = WILL_SEEN = {}; }
iterDeps(propertyWillChange, obj, deps, ... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/lib/property_get.js | @@ -67,7 +67,8 @@ var get = function get(obj, keyName) {
return value;
}
- var meta = obj['__ember_meta__'], desc = meta && meta.descs[keyName], ret;
+ var meta = obj['__ember_meta__'];
+ var desc = meta && meta.descs[keyName], ret;
if (desc === undefined && isPath(keyName)) {
return _getPath(obj... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/lib/property_set.js | @@ -41,7 +41,8 @@ var set = function set(obj, keyName, value, tolerant) {
return setPath(obj, keyName, value, tolerant);
}
- var meta = obj['__ember_meta__'], desc = meta && meta.descs[keyName],
+ var meta = obj['__ember_meta__'];
+ var desc = meta && meta.descs[keyName],
isUnknown, currentValue;
... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/lib/watch_path.js | @@ -10,7 +10,8 @@ var metaFor = meta;
// chains inherited from the proto they will be cloned and reconfigured for
// the current object.
function chainsFor(obj, meta) {
- var m = meta || metaFor(obj), ret = m.chains;
+ var m = meta || metaFor(obj);
+ var ret = m.chains;
if (!ret) {
ret = m.chains = new Ch... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/tests/binding/sync_test.js | @@ -14,7 +14,9 @@ import { defineProperty } from "ember-metal/properties";
QUnit.module("system/binding/sync_test.js");
testBoth("bindings should not sync twice in a single run loop", function(get, set) {
- var a, b, setValue, setCalled=0, getCalled=0;
+ var a, b, setValue;
+ var setCalled=0;
+ var getCalled=0;... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/tests/computed_test.js | @@ -610,7 +610,8 @@ test('adding a computed property should show up in key iteration',function() {
});
testBoth("when setting a value after it had been retrieved empty don't pass function UNDEFINED as oldValue", function(get, set) {
- var obj = {}, oldValueIsNoFunction = true;
+ var obj = {};
+ var oldValu... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/tests/enumerable_utils_test.js | @@ -3,7 +3,8 @@ import EnumerableUtils from 'ember-metal/enumerable_utils';
QUnit.module('Ember.EnumerableUtils.intersection');
test('returns an array of objects that appear in both enumerables', function() {
- var a = [1,2,3], b = [2,3,4], result;
+ var a = [1,2,3];
+ var b = [2,3,4], result;
result = Enum... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/tests/events_test.js | @@ -19,7 +19,8 @@ import {
QUnit.module('system/props/events_test');
test('listener should receive event - removing should remove', function() {
- var obj = {}, count = 0;
+ var obj = {};
+ var count = 0;
var F = function() { count++; };
addListener(obj, 'event!', F);
@@ -36,7 +37,8 @@ test('listener sho... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/tests/instrumentation_test.js | @@ -17,7 +17,8 @@ QUnit.module("Ember Instrumentation", {
test("subscribing to a simple path receives the listener", function() {
expect(12);
- var sentPayload = {}, count = 0;
+ var sentPayload = {};
+ var count = 0;
subscribe("render", {
before: function(name, timestamp, payload) {
@@ -57,7 +58,8 @... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/tests/is_blank_test.js | @@ -3,8 +3,9 @@ import isBlank from 'ember-metal/is_blank';
QUnit.module("Ember.isBlank");
test("Ember.isBlank", function() {
- var string = "string", fn = function() {},
- object = {length: 0};
+ var string = "string";
+ var fn = function() {};
+ var object = {length: 0};
equal(true, isBlank(null), ... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/tests/is_empty_test.js | @@ -3,8 +3,9 @@ import isEmpty from 'ember-metal/is_empty';
QUnit.module("Ember.isEmpty");
test("Ember.isEmpty", function() {
- var string = "string", fn = function() {},
- object = {length: 0};
+ var string = "string";
+ var fn = function() {};
+ var object = {length: 0};
equal(true, isEmpty(null), ... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/tests/is_none_test.js | @@ -3,7 +3,8 @@ import isNone from 'ember-metal/is_none';
QUnit.module("Ember.isNone");
test("Ember.isNone", function() {
- var string = "string", fn = function() {};
+ var string = "string";
+ var fn = function() {};
equal(true, isNone(null), "for null");
equal(true, isNone(undefined), "for undef... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/tests/is_present_test.js | @@ -4,8 +4,9 @@ if (Ember.FEATURES.isEnabled('ember-metal-is-present')) {
QUnit.module("Ember.isPresent");
test("Ember.isPresent", function() {
- var string = "string", fn = function() {},
- object = {length: 0};
+ var string = "string";
+ var fn = function() {};
+ var object = {length: 0};
... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/tests/mixin/computed_test.js | @@ -61,8 +61,8 @@ test('calling set on overridden computed properties', function() {
var SuperMixin, SubMixin;
var obj;
- var superGetOccurred = false,
- superSetOccurred = false;
+ var superGetOccurred = false;
+ var superSetOccurred = false;
SuperMixin = Mixin.create({
aProp: computed(functi... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/tests/observer_test.js | @@ -75,7 +75,8 @@ testBoth('observer should fire when dependent property is modified', function(ge
});
testBoth('observer should continue to fire after dependent properties are accessed', function(get, set) {
- var observerCount = 0, obj = {};
+ var observerCount = 0;
+ var obj = {};
defineProperty(obj, 'pr... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/tests/performance_test.js | @@ -20,7 +20,8 @@ QUnit.module("Computed Properties - Number of times evaluated");
test("computed properties that depend on multiple properties should run only once per run loop", function() {
var obj = {a: 'a', b: 'b', c: 'c'};
- var cpCount = 0, obsCount = 0;
+ var cpCount = 0;
+ var obsCount = 0;
defin... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/tests/platform/defineProperty_test.js | @@ -71,7 +71,10 @@ test('defining a non enumerable property', function() {
// and setters don't do anything
if (platform.hasPropertyAccessors) {
test('defining a getter/setter', function() {
- var obj = {}, getCnt = 0, setCnt = 0, v = 'FOO';
+ var obj = {};
+ var getCnt = 0;
+ var setCnt = 0;
+ var ... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/tests/run_loop/once_test.js | @@ -17,7 +17,8 @@ test('calling invokeOnce more than once invokes only once', function() {
test('should differentiate based on target', function() {
- var A = { count: 0 }, B = { count: 0 };
+ var A = { count: 0 };
+ var B = { count: 0 };
run(function() {
var F = function() { this.count++; };
run.o... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/tests/utils/guidFor_test.js | @@ -20,7 +20,8 @@ var nanGuid = function(obj) {
};
test("Object", function() {
- var a = {}, b = {};
+ var a = {};
+ var b = {};
sameGuid( a, a, "same object always yields same guid" );
diffGuid( a, b, "different objects yield different guids" );
@@ -44,7 +45,9 @@ test("Object with prototype", function()... | true |
Other | emberjs | ember.js | 951920f5655280b5dbaf4ceae7e9baf4672a7933.json | Use one variable assignment per declaration. | packages/ember-metal/tests/utils/is_array_test.js | @@ -4,13 +4,13 @@ QUnit.module("Ember Type Checking");
var global = this;
test("Ember.isArray" ,function() {
- var numarray = [1,2,3],
- number = 23,
- strarray = ["Hello", "Hi"],
- string = "Hello",
- object = {},
- length = {length: 12},
- fn ... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.