language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | Homebrew | brew | 15916338888e48e70edc4ade7f0aff94e3607e76.json | gpg_requirement: add standalone requirement
GPG 1.x has stopped receiving new features, some of which we may well want to
take advantage of sooner or later in Homebrew. Upstream has also been attempting
to work out for a while how well used it still is which suggests it may "go away"
at some point in the future.
Debi... | Library/Homebrew/requirements/gpg_requirement.rb | @@ -0,0 +1,27 @@
+require "requirement"
+
+class GPGRequirement < Requirement
+ fatal true
+ default_formula "gnupg2"
+
+ satisfy(:build_env => false) { gpg2 || gpg }
+
+ # MacGPG2/GPGTools installs GnuPG 2.0.x as a vanilla `gpg` symlink
+ # pointing to `gpg2`, as do we. Ensure we're actually using a 2.0 `gpg`.
+ ... | true |
Other | Homebrew | brew | 2b847959f098414fb12600535b5f0ab584a11e40.json | oh1: Add a truncate option | Library/Homebrew/utils.rb | @@ -88,8 +88,10 @@ def ohai(title, *sput)
puts sput
end
-def oh1(title)
- title = Tty.truncate(title) if $stdout.tty? && !ARGV.verbose?
+def oh1(title, options = {})
+ if $stdout.tty? && !ARGV.verbose? && options.fetch(:truncate, :auto) == :auto
+ title = Tty.truncate(title)
+ end
puts "#{Tty.green}==>#{... | false |
Other | Homebrew | brew | 2776f08fa095b95dafbc9af5f80188f3f063e001.json | gpg: simplify available check
which_all already runs some checks to see if the file is a file & is executable.
Our usage here inside `self.available?` is mostly a smoke test.
Closes #676.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com> | Library/Homebrew/gpg.rb | @@ -20,7 +20,7 @@ def self.gpg2
GPG_EXECUTABLE = gpg2 || gpg
def self.available?
- File.exist?(GPG_EXECUTABLE.to_s) && File.executable?(GPG_EXECUTABLE.to_s)
+ File.executable?(GPG_EXECUTABLE.to_s)
end
def self.create_test_key(path) | false |
Other | Homebrew | brew | 3005582f15237393d6dd9df5e8b6429112b2e12a.json | gpg: combine detection logic | Library/Homebrew/gpg.rb | @@ -1,32 +1,26 @@
require "utils"
class Gpg
- # Should ideally be using `GPGRequirement.new.gpg2`, etc to get path here but
- # calling that directly leads to:
- # requirement.rb:139:in `which_all': uninitialized constant Requirement::ORIGINAL_PATHS (NameError)
- # when i.e. including the gpg syntax in wget. No... | false |
Other | Homebrew | brew | 2c81083f3c9679b9c70c2d0a3e1d8f496707588a.json | test_gpg: add initial tests | Library/Homebrew/test/test_gpg.rb | @@ -0,0 +1,22 @@
+require "testing_env"
+require "gpg"
+
+class GpgTest < Homebrew::TestCase
+ def setup
+ skip "GPG Unavailable" unless Gpg.available?
+ @dir = Pathname.new(mktmpdir)
+ end
+
+ def teardown
+ @dir.rmtree
+ end
+
+ def test_create_test_key
+ Dir.chdir(@dir) do
+ with_environment("H... | false |
Other | Homebrew | brew | 91b67bd41d3a6fa04d5dd438b667d9bcb7e414e9.json | tests: add assertion to test_simple_valid_formula | Library/Homebrew/test/test_cmd_audit.rb | @@ -36,6 +36,7 @@ def test_simple_valid_formula
assert ft =~ /\burl\b/, "The formula should match 'url'"
assert_nil ft.line_number(/desc/), "The formula should not match 'desc'"
assert_equal 2, ft.line_number(/\burl\b/)
+ assert ft.include?("Valid"), "The formula should include \"Valid\""
end
... | false |
Other | Homebrew | brew | c56625f8b76f5e33ac5e086af4c9d3d79c593218.json | utils: check raise deprecation exceptions value. | Library/Homebrew/utils.rb | @@ -149,7 +149,8 @@ def odeprecated(method, replacement = nil, options = {})
#{caller_message}#{tap_message}
EOS
- if ARGV.homebrew_developer? || options[:die]
+ if ARGV.homebrew_developer? || options[:die] ||
+ Homebrew.raise_deprecation_exceptions?
raise FormulaMethodDeprecatedError, message
e... | false |
Other | Homebrew | brew | 985c672bac4dc20d369b451c484eb6553762dbcf.json | update.sh: check upstream SHA prefetch not local.
Otherwise this can prevent taps from being updated as expected. | Library/Homebrew/cmd/update.sh | @@ -383,18 +383,22 @@ EOS
[[ -d "$DIR/.git" ]] || continue
cd "$DIR" || continue
+ if [[ -n "$HOMEBREW_VERBOSE" ]]
+ then
+ echo "Checking if we need to fetch $DIR..."
+ fi
+
TAP_VAR="$(repo_var "$DIR")"
- declare PREFETCH_REVISION"$TAP_VAR"="$(read_current_revision)"
+ UPSTREAM_BRA... | false |
Other | Homebrew | brew | b7dc6ce7ee0fe580b382bec9859fa1b6129e7930.json | Update zsh-completion for --fetch-HEAD | share/zsh/site-functions/_brew | @@ -139,6 +139,7 @@ case "$words[1]" in
upgrade)
_arguments \
'(--cleanup)--cleanup[remove previously installed formula version(s)]' \
+ '(--fetch-HEAD)--fetch-HEAD[detect outdated installation by fetching the repo]' \
'1: :->forms' && return 0
if [[ "$state" == forms ]]; then | false |
Other | Homebrew | brew | 9a29a306cfd6b116a0cb696ce56bd7bc7679a8e3.json | resolve conflict in diagnostic.rb | Library/Homebrew/cmd/--env.rb | @@ -3,6 +3,7 @@
require "extend/ENV"
require "build_environment"
+require "utils/shell"
module Homebrew
def __env
@@ -11,12 +12,25 @@ def __env
ENV.setup_build_environment
ENV.universal_binary if ARGV.build_universal?
- if $stdout.tty?
+ shell_value = ARGV.value("shell")
+ has_plain = ARG... | true |
Other | Homebrew | brew | 9a29a306cfd6b116a0cb696ce56bd7bc7679a8e3.json | resolve conflict in diagnostic.rb | Library/Homebrew/diagnostic.rb | @@ -3,6 +3,7 @@
require "formula"
require "version"
require "development_tools"
+require "utils/shell"
module Homebrew
module Diagnostic
@@ -475,7 +476,7 @@ def check_user_path_1
Consider setting your PATH so that #{HOMEBREW_PREFIX}/bin
occurs before /usr/bin. Here is a ... | true |
Other | Homebrew | brew | 9a29a306cfd6b116a0cb696ce56bd7bc7679a8e3.json | resolve conflict in diagnostic.rb | Library/Homebrew/extend/os/mac/diagnostic.rb | @@ -202,7 +202,7 @@ def check_for_unsupported_curl_vars
SSL_CERT_DIR support was removed from Apple's curl.
If fetching formulae fails you should:
unset SSL_CERT_DIR
- and remove it from #{shell_profile} if present.
+ and remove it from #{Utils::Shell.shell_profile} ... | true |
Other | Homebrew | brew | 9a29a306cfd6b116a0cb696ce56bd7bc7679a8e3.json | resolve conflict in diagnostic.rb | Library/Homebrew/test/test_integration_cmds.rb | @@ -227,6 +227,26 @@ def test_env
cmd("--env"))
end
+ def test_env_bash
+ assert_match %r{export CMAKE_PREFIX_PATH="#{Regexp.quote(HOMEBREW_PREFIX.to_s)}"},
+ cmd("--env", "--shell=bash")
+ end
+
+ def test_env_fish
+ assert_match %r{set [-]gx CMAKE_PREFIX_PATH "#{Regexp.... | true |
Other | Homebrew | brew | 9a29a306cfd6b116a0cb696ce56bd7bc7679a8e3.json | resolve conflict in diagnostic.rb | Library/Homebrew/test/test_shell.rb | @@ -0,0 +1,38 @@
+require "testing_env"
+require "utils/shell"
+
+class ShellSmokeTest < Homebrew::TestCase
+ def test_path_to_shell()
+ # raw command name
+ assert_equal :bash, Utils::Shell.path_to_shell("bash")
+ # full path
+ assert_equal :bash, Utils::Shell.path_to_shell("/bin/bash")
+ # versions
+ ... | true |
Other | Homebrew | brew | 9a29a306cfd6b116a0cb696ce56bd7bc7679a8e3.json | resolve conflict in diagnostic.rb | Library/Homebrew/test/test_utils.rb | @@ -1,6 +1,7 @@
require "testing_env"
require "utils"
require "tempfile"
+require "utils/shell"
class TtyTests < Homebrew::TestCase
def test_strip_ansi
@@ -157,15 +158,15 @@ def test_gzip
def test_shell_profile
ENV["SHELL"] = "/bin/sh"
- assert_equal "~/.bash_profile", shell_profile
+ assert_eq... | true |
Other | Homebrew | brew | 9a29a306cfd6b116a0cb696ce56bd7bc7679a8e3.json | resolve conflict in diagnostic.rb | Library/Homebrew/utils/shell.rb | @@ -0,0 +1,73 @@
+module Utils
+ SHELL_PROFILE_MAP = {
+ :bash => "~/.bash_profile",
+ :csh => "~/.cshrc",
+ :fish => "~/.config/fish/config.fish",
+ :ksh => "~/.kshrc",
+ :sh => "~/.bash_profile",
+ :tcsh => "~/.tcshrc",
+ :zsh => "~/.zshrc",
+ }.freeze
+
+ module Shell
+ # take a path and h... | true |
Other | Homebrew | brew | 4eaa40ae1f432f3fd49fef628928579cb7eba600.json | Enable vendored Ruby 2.0. | Library/Homebrew/cmd/vendor-install.sh | @@ -8,6 +8,7 @@ source "$HOMEBREW_LIBRARY/Homebrew/utils/lock.sh"
VENDOR_DIR="$HOMEBREW_LIBRARY/Homebrew/vendor"
+# Built from https://github.com/Homebrew/homebrew-portable.
if [[ -n "$HOMEBREW_OSX" ]]
then
if [[ "$HOMEBREW_PROCESSOR" = "Intel" ]]
@@ -185,7 +186,10 @@ homebrew-vendor-install() {
if [[ -z... | true |
Other | Homebrew | brew | 4eaa40ae1f432f3fd49fef628928579cb7eba600.json | Enable vendored Ruby 2.0. | Library/Homebrew/manpages/brew.1.md.erb | @@ -151,6 +151,10 @@ can take several different forms:
directories. TextMate can handle this correctly in project mode, but many
editors will do strange things in this case.
+ * `HOMEBREW_FORCE_VENDOR_RUBY`:
+ If set, Homebrew will always use its vendored, relocatable Ruby 2.0 version
+ even if the s... | true |
Other | Homebrew | brew | 4eaa40ae1f432f3fd49fef628928579cb7eba600.json | Enable vendored Ruby 2.0. | Library/Homebrew/utils/ruby.sh | @@ -1,33 +1,4 @@
-original-setup-ruby-path() {
- if [[ -z "$HOMEBREW_DEVELOPER" ]]
- then
- unset HOMEBREW_RUBY_PATH
- fi
-
- if [[ -z "$HOMEBREW_RUBY_PATH" ]]
- then
- if [[ -n "$HOMEBREW_OSX" ]]
- then
- HOMEBREW_RUBY_PATH="/System/Library/Frameworks/Ruby.framework/Versions/Current/usr/bin/ruby"
- ... | true |
Other | Homebrew | brew | 4eaa40ae1f432f3fd49fef628928579cb7eba600.json | Enable vendored Ruby 2.0. | share/doc/homebrew/Common-Issues.md | @@ -38,7 +38,7 @@ invalid multibyte escape: /^\037\235/
In the past, Homebrew assumed that `/usr/bin/ruby` was Ruby 1.8. On OS X 10.9, it is now Ruby 2.0. There are various incompatibilities between the two versions, so if you upgrade to OS X 10.9 while using a sufficiently old version of Homebrew, you will encounte... | true |
Other | Homebrew | brew | 4eaa40ae1f432f3fd49fef628928579cb7eba600.json | Enable vendored Ruby 2.0. | share/doc/homebrew/brew.1.html | @@ -554,6 +554,8 @@ <h2 id="ENVIRONMENT">ENVIRONMENT</h2>
<p><em>Note:</em> <code>brew edit</code> will open all of Homebrew as discontinuous files and
directories. TextMate can handle this correctly in project mode, but many
editors will do strange things in this case.</p></dd>
+<dt><code>HOMEBREW_FORCE_VENDOR_RUBY... | true |
Other | Homebrew | brew | 4eaa40ae1f432f3fd49fef628928579cb7eba600.json | Enable vendored Ruby 2.0. | share/man/man1/brew.1 | @@ -764,6 +764,10 @@ If set, Homebrew will use this editor when editing a single formula, or several
\fINote:\fR \fBbrew edit\fR will open all of Homebrew as discontinuous files and directories\. TextMate can handle this correctly in project mode, but many editors will do strange things in this case\.
.
.TP
+\fBHOME... | true |
Other | Homebrew | brew | 06fe347de97975dc01e726f87bf07a56a6fb713e.json | os/mac/ruby_keg: improve error reporting
A failure to change a dylib ID or install name would previously cause a
rather cryptic error message, that didn't include the name of the file
that caused the failure, unless `--debug` was specified. Make sure to
output this information in all cases before re-raising the except... | Library/Homebrew/os/mac/ruby_keg.rb | @@ -5,12 +5,26 @@ def change_dylib_id(id, file)
@require_install_name_tool = true
puts "Changing dylib ID of #{file}\n from #{file.dylib_id}\n to #{id}" if ARGV.debug?
MachO::Tools.change_dylib_id(file, id)
+ rescue MachO::MachOError
+ onoe <<-EOS.undent
+ Failed changing dylib ID of #{file}... | false |
Other | Homebrew | brew | fdf55e77e10f938d1c5d8a72e015e04451be938a.json | Improve formula not found handling (#96) | Library/Homebrew/cmd/install.rb | @@ -156,6 +156,8 @@ def install
rescue FormulaUnavailableError => e
if (blacklist = blacklisted?(e.name))
ofail "#{e.message}\n#{blacklist}"
+ elsif e.name == "updog"
+ ofail "What's updog?"
else
ofail e.message
query = query_regexp(e.name) | false |
Other | Homebrew | brew | d0251c1abc3d63513c8b07647607e3a5654caedb.json | formulary: fix to_rack for fully-scoped references
Fixes the case where I have `mysql56` installed but do
`brew uninstall foo/bar/mysql56` which isn't a valid formula.
Fixes https://github.com/Homebrew/legacy-homebrew/issues/39883. | Library/Homebrew/formulary.rb | @@ -256,12 +256,15 @@ def self.from_contents(name, path, contents, spec = :stable)
end
def self.to_rack(ref)
- # First, check whether the rack with the given name exists.
+ # If using a fully-scoped reference, check if the formula can be resolved.
+ factory(ref) if ref.include? "/"
+
+ # Check wheth... | true |
Other | Homebrew | brew | d0251c1abc3d63513c8b07647607e3a5654caedb.json | formulary: fix to_rack for fully-scoped references
Fixes the case where I have `mysql56` installed but do
`brew uninstall foo/bar/mysql56` which isn't a valid formula.
Fixes https://github.com/Homebrew/legacy-homebrew/issues/39883. | Library/Homebrew/test/test_formulary.rb | @@ -111,6 +111,15 @@ def test_factory_from_rack_and_from_keg
def test_load_from_contents
assert_kind_of Formula, Formulary.from_contents(@name, @path, @path.read)
end
+
+ def test_to_rack
+ assert_equal HOMEBREW_CELLAR/@name, Formulary.to_rack(@name)
+ (HOMEBREW_CELLAR/@name).mkpath
+ assert_equal ... | true |
Other | Homebrew | brew | fdcdcf73500626994dee6bd4d3bafba3bc8974bc.json | diagnostic: remove MacGPG2 check
This hasn't been an issue for upstream stable releases for 3 years, since March
2013, and hasn't been an issue for pre-release versions for 4 years.
That release, and indeed the latest modern GPGTools releases, support 10.6 and
above so there's no reason to suspect people are actually... | Library/Homebrew/diagnostic.rb | @@ -114,25 +114,6 @@ def check_path_for_trailing_slashes
EOS
end
- # Installing MacGPG2 interferes with Homebrew in a big way
- # https://github.com/GPGTools/MacGPG2
- def check_for_macgpg2
- return if File.exist? "/usr/local/MacGPG2/share/gnupg/VERSION"
-
- suspects = %w[... | false |
Other | Homebrew | brew | 2e360112e4b84fa5fafe17c400043970578a2db7.json | analytics.*: use curl --data for readability. | Library/Homebrew/utils/analytics.rb | @@ -16,13 +16,13 @@ def report(type, metadata = {})
args = %W[
--max-time 3
--user-agent #{HOMEBREW_USER_AGENT_CURL}
- -d v=1
- -d tid=#{ENV["HOMEBREW_ANALYTICS_ID"]}
- -d cid=#{ENV["HOMEBREW_ANALYTICS_USER_UUID"]}
- -d aip=1
- -d an=#{HOMEBREW... | true |
Other | Homebrew | brew | 2e360112e4b84fa5fafe17c400043970578a2db7.json | analytics.*: use curl --data for readability. | Library/Homebrew/utils/analytics.sh | @@ -93,14 +93,14 @@ report-analytics-screenview-command() {
local args=(
--max-time 3
--user-agent "$HOMEBREW_USER_AGENT_CURL"
- -d v=1
- -d tid="$HOMEBREW_ANALYTICS_ID"
- -d cid="$HOMEBREW_ANALYTICS_USER_UUID"
- -d aip=1
- -d an="$HOMEBREW_PRODUCT"
- -d av="$HOMEBREW_VERSION"
- -d t=s... | true |
Other | Homebrew | brew | 202e5f5332a5051e37799f5a87457bca301e85b3.json | formula_installer: prevent MaximumMacOSRequirement leakage
Read the discussion in https://github.com/Homebrew/homebrew-core/pull/3703. If you
have a better idea, please file a competing PR. I'm sick to death of discussion.
Closes #662.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com> | Library/Homebrew/formula_installer.rb | @@ -308,6 +308,7 @@ def check_requirements(req_map)
req_map.each_pair do |dependent, reqs|
reqs.each do |req|
+ next if dependent.installed? && req.name == "maximummacos"
puts "#{dependent}: #{req.message}"
fatals << req if req.fatal?
end | false |
Other | Homebrew | brew | c016aedaab3a5b10207eb05d6b53199e6fcdb761.json | tests: check all our Bash code for syntax errors
Additionally include our bootstrap code in `brew.sh`, Bash utilities in
`utils.sh` and `utils/*.sh`, `superenv` shims, and the Bash completion.
Closes #654.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de> | Library/Homebrew/test/test_bash.rb | @@ -1,20 +1,34 @@
require "testing_env"
class BashTests < Homebrew::TestCase
- def assert_valid_bash_syntax(files)
- output = Utils.popen_read("/bin/bash -n #{files} 2>&1")
+ def assert_valid_bash_syntax(file)
+ output = Utils.popen_read("/bin/bash -n #{file} 2>&1")
assert $?.success?, output
end
... | false |
Other | Homebrew | brew | b75516425b2cfe746a70dd13e5538dec48688b58.json | utils/analytics.sh: fix style inconsistencies | Library/Homebrew/utils/analytics.sh | @@ -37,7 +37,7 @@ setup-analytics() {
then
if [[ -n "$HOMEBREW_LINUX" ]]
then
- HOMEBREW_ANALYTICS_USER_UUID="$(tr a-f A-F < /proc/sys/kernel/random/uuid)"
+ HOMEBREW_ANALYTICS_USER_UUID="$(tr a-f A-F </proc/sys/kernel/random/uuid)"
elif [[ -n "$HOMEBREW_OSX" ]]
then
HOMEBREW_ANA... | false |
Other | Homebrew | brew | 2a943d0ad22b27e76b8ada687902f1f9cf22d3fb.json | shims/sed: fix style inconsistencies | Library/Homebrew/shims/super/sed | @@ -1,7 +1,9 @@
#!/bin/bash
-if [[ $HOMEBREW_CCCFG == *s* ]]; then
+
+if [[ "$HOMEBREW_CCCFG" = *s* ]]
+then
# Fix issue with sed barfing on unicode characters on Mountain Lion
unset LC_ALL
- export LC_CTYPE='C'
+ export LC_CTYPE="C"
fi
exec /usr/bin/sed "$@" | false |
Other | Homebrew | brew | 85c0b594ad89e876eae6a94141a228be0f5982b4.json | shims/pod2man: fix style inconsistencies | Library/Homebrew/shims/super/pod2man | @@ -1,3 +1,8 @@
#!/bin/bash
-POD2MAN=$(/usr/bin/which pod2man5.18 || /usr/bin/which pod2man5.16 || /usr/bin/which pod2man5.12 || /usr/bin/which $HOMEBREW_PREFIX/opt/pod2man/bin/pod2man || echo /usr/bin/pod2man)
-exec $POD2MAN "$@"
+
+POD2MAN="$(/usr/bin/which pod2man5.18 ||
+ /usr/bin/which pod2man5.16 ||
+ ... | false |
Other | Homebrew | brew | 8e180a85b8dc7d5cf0f202e120f3452be61f3727.json | shims/mig: fix style inconsistencies | Library/Homebrew/shims/super/mig | @@ -1,3 +1,4 @@
#!/bin/bash
+
pwd="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-exec xcrun mig -cc $pwd/cc "$@"
+exec xcrun mig -cc "$pwd/cc" "$@" | false |
Other | Homebrew | brew | 10af1866af3a2a5966ef0bededfc42608b406b39.json | shims/make: fix style inconsistencies | Library/Homebrew/shims/super/make | @@ -1,3 +1,4 @@
#!/bin/bash
+
export HOMEBREW_CCCFG="O$HOMEBREW_CCCFG"
exec xcrun make "$@" | false |
Other | Homebrew | brew | 672dc1bae2d297d7b11a8871e837c46e687c5852.json | shims/bsdmake: fix style inconsistencies | Library/Homebrew/shims/super/bsdmake | @@ -1,3 +1,4 @@
#!/bin/bash
+
export HOMEBREW_CCCFG="O$HOMEBREW_CCCFG"
exec xcrun bsdmake "$@" | false |
Other | Homebrew | brew | faf4bc819ce8c59b21fc4f0538cdca25551ef31f.json | shims/apr-1-config: fix style inconsistencies | Library/Homebrew/shims/super/apr-1-config | @@ -1,14 +1,16 @@
#!/bin/bash
-if [[ "$HOMEBREW_CCCFG" == *a* ]]; then
+if [[ "$HOMEBREW_CCCFG" = *a* ]]
+then
case "$1" in
- --cc) echo "cc";;
- --cpp) echo "cpp";;
- --includedir) echo "$HOMEBREW_SDKROOT/usr/include/apr-1";;
- --includes) echo "-isystem$HOMEBREW_SDKROOT/usr/include/apr-1";;
- --apr-libtool... | false |
Other | Homebrew | brew | 4a7fc07430ff43b4daa3a6ba07461f680895572a.json | shims/ant: fix style inconsistencies | Library/Homebrew/shims/super/ant | @@ -1,5 +1,7 @@
#!/bin/bash
+
export HOMEBREW_CCCFG="O$HOMEBREW_CCCFG"
+
ant=/usr/bin/ant
-[ -x "$ant" ] || ant="$(${HOMEBREW_BREW_FILE} --prefix ant)/bin/ant"
+[[ -x "$ant" ]] || ant="$("$HOMEBREW_BREW_FILE" --prefix ant)/bin/ant"
exec "$ant" "$@" | false |
Other | Homebrew | brew | 3d862ef5e29e8f57649b596eeb70a57ce10bbcd2.json | cmd/vendor-install.sh: fix style inconsistencies | Library/Homebrew/cmd/vendor-install.sh | @@ -30,10 +30,10 @@ fetch() {
local temporary_path
curl_args=(
- --fail \
- --remote-time \
- --location \
- --user-agent "$HOMEBREW_USER_AGENT_CURL" \
+ --fail
+ --remote-time
+ --location
+ --user-agent "$HOMEBREW_USER_AGENT_CURL"
)
if [[ -n "$HOMEBREW_QUIET" ]]
@@ -44,7 +44,7 ... | true |
Other | Homebrew | brew | 3d862ef5e29e8f57649b596eeb70a57ce10bbcd2.json | cmd/vendor-install.sh: fix style inconsistencies | Library/Homebrew/shims/scm/git | @@ -42,7 +42,7 @@ executable() {
}
lowercase() {
- echo "$1" | tr '[:upper:]' '[:lower:]'
+ echo "$1" | tr "[:upper:]" "[:lower:]"
}
safe_exec() { | true |
Other | Homebrew | brew | 1e9328c6e16eafcb6565d8191265f0256ab2a932.json | cmd/update.sh: fix style inconsistencies | Library/Homebrew/cmd/update.sh | @@ -284,19 +284,19 @@ homebrew-update() {
for option in "$@"
do
case "$option" in
- -\?|-h|--help|--usage) brew help update; exit $? ;;
- --verbose) HOMEBREW_VERBOSE=1 ;;
- --debug) HOMEBREW_DEBUG=1;;
- --merge) HOMEBREW_MERGE=1 ;;
+ -\?|-h|--help|--usage) brew help update; ... | false |
Other | Homebrew | brew | 79c49b36389c2284f29fe8137a1c2acf87aac628.json | brew.sh: fix style inconsistencies | Library/Homebrew/brew.sh | @@ -33,7 +33,7 @@ git() {
}
# Force UTF-8 to avoid encoding issues for users with broken locale settings.
-if [[ "$(locale charmap 2> /dev/null)" != "UTF-8" ]]
+if [[ "$(locale charmap 2>/dev/null)" != "UTF-8" ]]
then
export LC_ALL="en_US.UTF-8"
fi
@@ -48,8 +48,8 @@ else
fi
case "$*" in
- --prefix) echo "... | false |
Other | Homebrew | brew | 850db4ebf473738ffba8424065d62954d3c95dd1.json | search: fix repositories with formulae and casks.
e.g. Caskroom/homebrew-cask.
Thanks to UniqMartin for the fix.
Fixes #655. | Library/Homebrew/cmd/search.rb | @@ -143,7 +143,8 @@ def search_tap(user, repo, rx)
end
end
- paths = tree["Formula"] || tree["HomebrewFormula"] || tree["Casks"] || tree["."] || []
+ paths = tree["Formula"] || tree["HomebrewFormula"] || tree["."] || []
+ paths += tree["Casks"] || []
cache[key] = paths.map { |pat... | false |
Other | Homebrew | brew | 11a1c495f7aec573e0e5e2f286036f8e6f0aa1ad.json | audit: enforce conflicts_with placement | Library/Homebrew/cmd/audit.rb | @@ -219,6 +219,7 @@ def audit_file
[/^ keg_only/, "keg_only"],
[/^ option/, "option"],
[/^ depends_on/, "depends_on"],
+ [/^ conflicts_with/, "conflicts_with"],
[/^ (go_)?resource/, "resour... | false |
Other | Homebrew | brew | 04cb161ddb29ab26314684edc214650cdb192046.json | test_formula: add outdated_versions tests | Library/Homebrew/test/test_formula.rb | @@ -134,6 +134,47 @@ def test_installed_prefix_stable_installed
f.rack.rmtree
end
+ def test_installed_prefix_outdated_stable_head_installed
+ f = formula do
+ url "foo"
+ version "1.9"
+ head "foo"
+ end
+
+ head_prefix = HOMEBREW_CELLAR/"#{f.name}/HEAD"
+ head_prefix.mkpath
+ ... | false |
Other | Homebrew | brew | 001bef0604534adeb5f85d77e00a20e8a1542b7a.json | formula: detect outdated HEAD in outdated_versions | Library/Homebrew/formula.rb | @@ -1000,7 +1000,7 @@ def migration_needed?
end
# @private
- def outdated_versions
+ def outdated_versions(options = {})
@outdated_versions ||= begin
all_versions = []
@@ -1009,16 +1009,22 @@ def outdated_versions
installed_kegs.each do |keg|
version = keg.version
all_ve... | false |
Other | Homebrew | brew | 1b88c2912b9e0fb9b03580da3707ec36e2d0c888.json | formula: add new HEAD methods
* add `latest_head_version` to return latest HEAD version installed
* add `latest_head_prefix` to return Pathname with latest HEAD version
* add `head_version_outdated?` to check if HEAD version is up-to-date | Library/Homebrew/formula.rb | @@ -413,16 +413,36 @@ def linked_keg
Pathname.new("#{HOMEBREW_LIBRARY}/LinkedKegs/#{name}")
end
- def latest_head_prefix
+ def latest_head_version
head_versions = installed_prefixes.map do |pn|
pn_pkgversion = PkgVersion.parse(pn.basename.to_s)
pn_pkgversion if pn_pkgversion.head?
en... | false |
Other | Homebrew | brew | 5ddee3502e7c8dd67b1fec4de2f72df6fd16cc94.json | download_strategy: use short hash for mercurial | Library/Homebrew/download_strategy.rb | @@ -913,7 +913,7 @@ def source_modified_time
end
def last_commit
- Utils.popen_read("hg", "parent", "--template", "{node}", "-R", cached_location.to_s)
+ Utils.popen_read("hg", "parent", "--template", "{node|short}", "-R", cached_location.to_s)
end
private | false |
Other | Homebrew | brew | 1114219384baf0948cabcce8752a4537896f7704.json | Add tests for Tab versions | Library/Homebrew/test/fixtures/receipt.json | @@ -16,6 +16,11 @@
"source": {
"path": "/usr/local/Library/Taps/hombrew/homebrew-core/Formula/foo.rb",
"tap": "homebrew/core",
- "spec": "stable"
+ "spec": "stable",
+ "versions": {
+ "stable": "2.14",
+ "devel": "2.15",
+ "head": "HEAD-0000000"
+ }
}
} | true |
Other | Homebrew | brew | 1114219384baf0948cabcce8752a4537896f7704.json | Add tests for Tab versions | Library/Homebrew/test/test_tab.rb | @@ -20,6 +20,11 @@ def setup
"tap" => "homebrew/core",
"path" => nil,
"spec" => "stable",
+ "versions" => {
+ "stable" => "0.10",
+ "devel" => "0.14",
+ "head" => "HEAD... | true |
Other | Homebrew | brew | d59f0f77a7513f85bb8f27dd81f2ee08a2ad7605.json | tests: fix fluctuations in test coverage (#647)
This basically started once our integration tests caused the overall
test time to raise above 10 minutes, causing some coverage data to be
dropped because SimpleCov believed it to be stale. | Library/Homebrew/test/.simplecov | @@ -7,6 +7,11 @@ SimpleCov.start do
coverage_dir File.expand_path("#{tests_path}/coverage")
root File.expand_path("#{tests_path}/..")
+ # We manage the result cache ourselves and the default of 10 minutes can be
+ # too low (particularly on Travis CI), causing results from some integration
+ # tests to be dr... | false |
Other | Homebrew | brew | 65203bbd1ea4513b4db3b7ed151626e1338ae70a.json | test-bot: avoid duplicate coverage reports
When running on Travis CI, both the Linux and macOS build will send a
coverage report, causing them to be merged by Coveralls. This results
in inferior coverage due to the early stage of the Linux-specific tests
and is probably not what we want. Make sure we only send a repor... | Library/Homebrew/dev-cmd/test-bot.rb | @@ -21,7 +21,8 @@
# as raw bytes instead of re-encoding in UTF-8.
# --fast: Don't install any packages, but run e.g. audit anyway.
# --keep-tmp: Keep temporary files written by main installs and tests that are run.
-# --no-pull Don't use `brew pull` when ... | false |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/cmd/audit.rb | @@ -628,7 +628,8 @@ def audit_revision
fv = FormulaVersions.new(formula, :max_depth => 10)
revision_map = fv.revision_map("origin/master")
- if (revisions = revision_map[formula.version]).any?
+ revisions = revision_map[formula.version]
+ if !revisions.empty?
problem "revision should not dec... | true |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/cmd/bottle.rb | @@ -58,10 +58,10 @@ def print_filename(string, filename)
next if Metafiles::EXTENSIONS.include? file.extname
linked_libraries = Keg.file_linked_libraries(file, string)
- result ||= linked_libraries.any?
+ result ||= !linked_libraries.empty?
if ARGV.verbose?
- print_filename(str... | true |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/cmd/info.rb | @@ -118,22 +118,22 @@ def info_formula(f)
attrs << "pinned at #{f.pinned_version}" if f.pinned?
attrs << "keg-only" if f.keg_only?
- puts "#{f.full_name}: #{specs * ", "}#{" [#{attrs * ", "}]" if attrs.any?}"
+ puts "#{f.full_name}: #{specs * ", "}#{" [#{attrs * ", "}]" unless attrs.empty?}"
puts... | true |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/cmd/install.rb | @@ -82,7 +82,7 @@ def install
begin
formulae = []
- if ARGV.casks.any?
+ unless ARGV.casks.empty?
args = []
args << "--force" if ARGV.force?
args << "--debug" if ARGV.debug? | true |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/cmd/list.rb | @@ -28,7 +28,7 @@ def list
# Unbrewed uses the PREFIX, which will exist
# Things below use the CELLAR, which doesn't until the first formula is installed.
unless HOMEBREW_CELLAR.exist?
- raise NoSuchKegError.new(ARGV.named.first) if ARGV.named.any?
+ raise NoSuchKegError.new(ARGV.named.first) u... | true |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/cmd/outdated.rb | @@ -17,13 +17,17 @@
module Homebrew
def outdated
- formulae = ARGV.resolved_formulae.any? ? ARGV.resolved_formulae : Formula.installed
+ formulae = if ARGV.resolved_formulae.empty?
+ Formula.installed
+ else
+ ARGV.resolved_formulae
+ end
if ARGV.json == "v1"
outdated = print_out... | true |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/cmd/readall.rb | @@ -22,10 +22,10 @@ def readall
end
options = { :aliases => ARGV.include?("--aliases") }
- taps = if ARGV.named.any?
- [Tap.fetch(ARGV.named.first)]
- else
+ taps = if ARGV.named.empty?
Tap
+ else
+ [Tap.fetch(ARGV.named.first)]
end
taps.each do |tap|
Homebrew.f... | true |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/cmd/search.rb | @@ -89,7 +89,7 @@ def search
arg.include?(char) && !arg.start_with?("/")
end
end
- if ARGV.any? && bad_regex
+ if !ARGV.empty? && bad_regex
ohai "Did you mean to perform a regular expression search?"
ohai "Surround your query with /slashes/ to search by regex."
... | true |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/cmd/upgrade.rb | @@ -21,16 +21,16 @@ def upgrade
if ARGV.named.empty?
outdated = Formula.installed.select(&:outdated?)
exit 0 if outdated.empty?
- elsif ARGV.named.any?
+ else
outdated = ARGV.resolved_formulae.select(&:outdated?)
(ARGV.resolved_formulae - outdated).each do |f|
versions ... | true |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/dev-cmd/bump-formula-pr.rb | @@ -25,7 +25,7 @@ def inreplace_pairs(path, replacement_pairs)
end
contents.gsub!(old, new)
end
- if contents.errors.any?
+ unless contents.errors.empty?
raise Utils::InreplaceError, path => contents.errors
end
contents | true |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/dev-cmd/test-bot.rb | @@ -342,7 +342,7 @@ def diff_formulae(start_revision, end_revision, path, filter)
@name = "#{diff_start_sha1}-#{diff_end_sha1}"
end
# Handle formulae arguments being passed on the command-line e.g. `brew test-bot wget fish`.
- elsif @formulae && @formulae.any?
+ elsif @formulae && !... | true |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/exceptions.rb | @@ -350,7 +350,7 @@ def dump
end
end
puts
- if RUBY_VERSION >= "1.8.7" && issues && issues.any?
+ if RUBY_VERSION >= "1.8.7" && issues && !issues.empty?
puts "These open issues may also help:"
puts issues.map { |i| "#{i["title"]} #{i["html_url"]}" }.join("\n")
end | true |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/formula.rb | @@ -998,7 +998,7 @@ def outdated_versions
# @private
def outdated?
- outdated_versions.any?
+ !outdated_versions.empty?
rescue Migrator::MigrationNeededError
true
end
@@ -1517,7 +1517,7 @@ def eligible_kegs_for_cleanup
installed_kegs.select { |k| pkg_version > k.version }
end
... | true |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/formula_pin.rb | @@ -31,7 +31,7 @@ def pinned?
end
def pinnable?
- @f.installed_prefixes.any?
+ !@f.installed_prefixes.empty?
end
def pinned_version | true |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/keg.rb | @@ -253,19 +253,19 @@ def completion_installed?(shell)
when :zsh then path.join("share", "zsh", "site-functions")
when :fish then path.join("share", "fish", "vendor_completions.d")
end
- dir && dir.directory? && dir.children.any?
+ dir && dir.directory? && !dir.children.empty?
... | true |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/language/python.rb | @@ -131,8 +131,8 @@ def virtualenv_create(venv_root, python = "python", formula = self)
dep_site_packages = Formula[d.name].opt_lib/"python#{xy}/site-packages"
next unless dep_site_packages.exist?
"import site; site.addsitedir('#{dep_site_packages}')\n"
- end
- if pth_cont... | true |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/software_spec.rb | @@ -77,7 +77,7 @@ def bottle_disable_reason
end
def bottle_defined?
- bottle_specification.collector.keys.any?
+ !bottle_specification.collector.keys.empty?
end
def bottled? | true |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/utils/github.rb | @@ -259,10 +259,10 @@ def print_pull_requests_matching(query)
open_or_closed_prs = issues_matching(query, :type => "pr")
open_prs = open_or_closed_prs.select { |i| i["state"] == "open" }
- if open_prs.any?
+ if !open_prs.empty?
puts "Open pull requests:"
prs = open_prs
- elsif open_or... | true |
Other | Homebrew | brew | a8566c9848122474b92fc8989eec196d5f4fb69b.json | various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)). | Library/Homebrew/utils/inreplace.rb | @@ -28,12 +28,12 @@ def inreplace(paths, before = nil, after = nil, audit_result = true)
s.gsub!(before, after, audit_result)
end
- errors[path] = s.errors if s.errors.any?
+ errors[path] = s.errors unless s.errors.empty?
Pathname(path).atomic_write(s)
end
- ... | true |
Other | Homebrew | brew | 4338f35b848ad61462fc4f73e1365e6c002201a2.json | tap: add cask methods. | Library/Homebrew/cmd/update-report.rb | @@ -193,7 +193,7 @@ def report
dst = Pathname.new paths.last
next unless dst.extname == ".rb"
- next unless paths.any? { |p| tap.formula_file?(p)}
+ next unless paths.any? { |p| tap.formula_file?(p) || tap.cask_file?(p)}
case status
when "A", "D" | true |
Other | Homebrew | brew | 4338f35b848ad61462fc4f73e1365e6c002201a2.json | tap: add cask methods. | Library/Homebrew/tap.rb | @@ -72,6 +72,7 @@ def initialize(user, repo)
def clear_cache
@remote = nil
@formula_dir = nil
+ @cask_dir = nil
@formula_files = nil
@alias_dir = nil
@alias_files = nil
@@ -304,6 +305,11 @@ def formula_dir
@formula_dir ||= [path/"Formula", path/"HomebrewFormula", path].detect(&:direc... | true |
Other | Homebrew | brew | a6033529cfdcfc6458aaa83a0bc9c4c141c60f96.json | Revert "tap: add cask methods."
This reverts commit 05daa0574732a7884bd158b2c3e14bd0709367da. | Library/Homebrew/tap.rb | @@ -72,7 +72,6 @@ def initialize(user, repo)
def clear_cache
@remote = nil
@formula_dir = nil
- @cask_dir = nil
@formula_files = nil
@alias_dir = nil
@alias_files = nil
@@ -305,11 +304,6 @@ def formula_dir
@formula_dir ||= [path/"Formula", path/"HomebrewFormula", path].detect(&:direc... | false |
Other | Homebrew | brew | 05daa0574732a7884bd158b2c3e14bd0709367da.json | tap: add cask methods.
Closes #562. | Library/Homebrew/tap.rb | @@ -72,6 +72,7 @@ def initialize(user, repo)
def clear_cache
@remote = nil
@formula_dir = nil
+ @cask_dir = nil
@formula_files = nil
@alias_dir = nil
@alias_files = nil
@@ -304,6 +305,11 @@ def formula_dir
@formula_dir ||= [path/"Formula", path/"HomebrewFormula", path].detect(&:direc... | false |
Other | Homebrew | brew | 7a00f03c92607f65336be0285584e8351ad8a73a.json | utils: tell people to report deprecations to tap.
This should hopefully avoid Homebrew/brew or Homebrew/homebrew-core
having these exceptions reported to us. | Library/Homebrew/test/test_utils.rb | @@ -223,4 +223,17 @@ def test_truncate_text_to_approximate_size
s = truncate_text_to_approximate_size(long_s, n, :front_weight => 1.0)
assert_equal(("x" * (n - glue.length)) + glue, s)
end
+
+ def test_odeprecated
+ ARGV.stubs(:homebrew_developer?).returns false
+ e = assert_raises(FormulaMethodDepr... | true |
Other | Homebrew | brew | 7a00f03c92607f65336be0285584e8351ad8a73a.json | utils: tell people to report deprecations to tap.
This should hopefully avoid Homebrew/brew or Homebrew/homebrew-core
having these exceptions reported to us. | Library/Homebrew/utils.rb | @@ -130,8 +130,13 @@ def odeprecated(method, replacement = nil, options = {})
# - Location outside of 'compat/'.
# - Location of caller of deprecated method (if all else fails).
backtrace = options.fetch(:caller, caller)
+ tap_message = nil
caller_message = backtrace.detect do |line|
- line.start_with?(... | true |
Other | Homebrew | brew | 202f793d8a46bcc186740429af26ea14093d49f8.json | cleaner: kill unnecessary perl elements
We shouldn't be packaging either `perllocal.pod` or `.packlist` files. Both
are only really useful outside of package management. They get automatically
generated whenever you install a Perl module.
Debian, Arch, MacPorts & others remove them and we should have been as well
rea... | Library/Homebrew/cleaner.rb | @@ -1,6 +1,8 @@
# Cleans a newly installed keg.
# By default:
# * removes .la files
+# * removes perllocal.pod files
+# * removes .packlist files
# * removes empty directories
# * sets permissions on executables
# * removes unresolved symlinks
@@ -89,6 +91,14 @@ def clean_dir(d)
next
elsif path.ex... | false |
Other | Homebrew | brew | 0a33cc591d258e07f2279bc0440d62e38983fd67.json | utils: provide a better location in 'odeprecated'
Try to find a formula in the backtrace to make the warning message more
helpful in identifying the culprit, as the formula is not always the
immediate caller of a deprecated method. Provide some sane fallbacks if
there's not formula in the call stack. | Library/Homebrew/utils.rb | @@ -125,9 +125,18 @@ def odeprecated(method, replacement = nil, options = {})
"There is no replacement."
end
- # Show the first location that's not in compat.
- backtrace = options[:caller] || caller
- caller_message = backtrace[1]
+ # Try to show the most relevant location in message, i.e. (if applicable... | false |
Other | Homebrew | brew | bc5b9c1e976121af04f8c80dc8794af96e0a1ae5.json | test-bot: fix non-OS X report generation. | Library/Homebrew/dev-cmd/test-bot.rb | @@ -40,6 +40,7 @@
require "rexml/cdata"
require "tap"
require "development_tools"
+require "utils/bottles"
module Homebrew
BYTES_IN_1_MEGABYTE = 1024*1024
@@ -994,7 +995,7 @@ def test_bot
tests.each do |test|
testsuite = testsuites.add_element "testsuite"
- testsuite.add_attribute "nam... | false |
Other | Homebrew | brew | 80b68add133516e5c0bebc497c07dc0ed95bb68b.json | compat: add Rubocop file. | Library/Homebrew/compat/.rubocop.yml | @@ -0,0 +1,7 @@
+inherit_from: ../../.rubocop.yml
+
+# We won't change method or predicate names because of backward compatibility.
+Style/MethodName:
+ Enabled: false
+Style/PredicateName:
+ Enabled: false | false |
Other | Homebrew | brew | 569c80323b7b28028552e21759790b83f5b305b3.json | hardware: add ARM detection from Linuxbrew. | Library/Homebrew/hardware.rb | @@ -70,6 +70,10 @@ def ppc?
type == :ppc
end
+ def arm?
+ type == :arm
+ end
+
def features
[]
end | false |
Other | Homebrew | brew | 70a1ef5bdf113c18792197f361bf18c587ae7a9f.json | testing_env: add needs_python method. | Library/Homebrew/test/testing_env.rb | @@ -97,6 +97,10 @@ def needs_compat
skip "Requires compat/ code" if ENV["HOMEBREW_NO_COMPAT"]
end
+ def needs_python
+ skip "Requires Python" unless which("python")
+ end
+
def assert_nothing_raised
yield
end | false |
Other | Homebrew | brew | c90552f66bb174e3c0c69de88ce389acbedbac8b.json | tab: use the correct default compiler. | Library/Homebrew/tab.rb | @@ -140,7 +140,7 @@ def self.empty
"source_modified_time" => 0,
"HEAD" => nil,
"stdlib" => nil,
- "compiler" => "clang",
+ "compiler" => DevelopmentTools.default_compiler,
"source" => {
"path" => nil,
"tap" => nil, | false |
Other | Homebrew | brew | 1aded31fec4a98c2521bca685166f82a8d7d66c6.json | test_utils: remove unnecessary full paths. | Library/Homebrew/test/test_utils.rb | @@ -161,21 +161,21 @@ def test_shell_profile
end
def test_popen_read
- out = Utils.popen_read("/bin/sh", "-c", "echo success").chomp
+ out = Utils.popen_read("sh", "-c", "echo success").chomp
assert_equal "success", out
assert_predicate $?, :success?
end
def test_popen_read_with_block
- ... | false |
Other | Homebrew | brew | 97b6a3069ea909d2dc6987f49f3e47eeda7054b1.json | test: add default Linux x86_64 bottle. | Library/Homebrew/test/bottles/testball_bottle-0.1.linux_x86_64.bottle.tar.gz | @@ -0,0 +1 @@
+testball_bottle-0.1.yosemite.bottle.tar.gz
\ No newline at end of file | false |
Other | Homebrew | brew | 3318967609952420980e1f87f2c6a5eac061065f.json | os: fix Rubocop warnings. | Library/Homebrew/os.rb | @@ -1,23 +1,24 @@
module OS
def self.mac?
- /darwin/i === RUBY_PLATFORM && !ENV["HOMEBREW_TEST_GENERIC_OS"]
+ return false if ENV["HOMEBREW_TEST_GENERIC_OS"]
+ RUBY_PLATFORM.to_s.downcase.include? "darwin"
end
def self.linux?
- /linux/i === RUBY_PLATFORM
+ RUBY_PLATFORM.to_s.downcase.include?... | false |
Other | Homebrew | brew | 932e145d9c44ef6c9f828422bf1daef8f10baa6f.json | test-bot: run all tests in generic mode. | Library/Homebrew/dev-cmd/test-bot.rb | @@ -665,8 +665,7 @@ def homebrew
tests_args_coverage << "--coverage" if ENV["TRAVIS"]
end
test "brew", "tests", *tests_args
- test "brew", "tests", "--generic", "--only=integration_cmds",
- *tests_args
+ test "brew", "tests", "--generic", *tests_ar... | false |
Other | Homebrew | brew | 536c42f7e6214087812413177d8bcebf3ab04f6e.json | test_version_subclasses: make OS X specific. | Library/Homebrew/test/test_os_mac_version.rb | @@ -2,7 +2,7 @@
require "version"
require "os/mac/version"
-class MacOSVersionTests < Homebrew::TestCase
+class OSMacVersionTests < Homebrew::TestCase
def setup
@v = MacOS::Version.new("10.7")
end | false |
Other | Homebrew | brew | 08f68fc4dd6afc6c118ad631889c2a35e4e8d07e.json | test_x11_requirement: make OS X specific. | Library/Homebrew/test/test_os_mac_x11_requirement.rb | @@ -0,0 +1,13 @@
+require "testing_env"
+require "requirements/x11_requirement"
+
+class OSMacX11RequirementTests < Homebrew::TestCase
+ def test_satisfied
+ MacOS::XQuartz.stubs(:version).returns("2.7.5")
+ MacOS::XQuartz.stubs(:installed?).returns(true)
+ assert_predicate X11Requirement.new, :satisfied?
+
+... | true |
Other | Homebrew | brew | 08f68fc4dd6afc6c118ad631889c2a35e4e8d07e.json | test_x11_requirement: make OS X specific. | Library/Homebrew/test/test_x11_requirement.rb | @@ -28,13 +28,4 @@ def test_x_env
ENV.expects(:x11)
x.modify_build_environment
end
-
- def test_satisfied
- MacOS::XQuartz.stubs(:version).returns("2.7.5")
- MacOS::XQuartz.stubs(:installed?).returns(true)
- assert_predicate X11Requirement.new, :satisfied?
-
- MacOS::XQuartz.stubs(:installed?)... | true |
Other | Homebrew | brew | bdc1991d7792f495a540fe775da01f408cc4c640.json | utils/github: fix broken pipe error
Closes #573. | Library/Homebrew/utils/github.rb | @@ -52,11 +52,7 @@ def api_credentials
elsif ENV["HOMEBREW_GITHUB_API_USERNAME"] && ENV["HOMEBREW_GITHUB_API_PASSWORD"]
[ENV["HOMEBREW_GITHUB_API_USERNAME"], ENV["HOMEBREW_GITHUB_API_PASSWORD"]]
else
- github_credentials = Utils.popen("git credential-osxkeychain get", "w+") do |io|
- ... | false |
Other | Homebrew | brew | 39453691ba3208dbd2e6ce1fd341d430b31dff55.json | tests: extend cmd_fail to all non-zero exit codes (#595) | Library/Homebrew/test/test_integration_cmds.rb | @@ -102,8 +102,8 @@ def cmd(*args)
def cmd_fail(*args)
output = cmd_output(*args)
status = $?.exitstatus
- $stderr.puts "\n#{output}" if status != 1
- assert_equal 1, status
+ $stderr.puts "\n#{output}" if status == 0
+ refute_equal 0, status
output
end
| false |
Other | Homebrew | brew | 2783adec4a906c8fb5c45aa1305b1460b5bc8a5b.json | Add helper class for Python virtualenvs | Library/Homebrew/language/python.rb | @@ -1,4 +1,5 @@
require "utils"
+require "language/python_virtualenv_constants"
module Language
module Python
@@ -96,5 +97,135 @@ def self.setup_install_args(prefix)
def self.package_available?(python, module_name)
quiet_system python, "-c", "import #{module_name}"
end
- end
-end
+
+ # Mixin... | true |
Other | Homebrew | brew | 2783adec4a906c8fb5c45aa1305b1460b5bc8a5b.json | Add helper class for Python virtualenvs | Library/Homebrew/language/python_virtualenv_constants.rb | @@ -0,0 +1,2 @@
+PYTHON_VIRTUALENV_URL = "https://files.pythonhosted.org/packages/5c/79/5dae7494b9f5ed061cff9a8ab8d6e1f02db352f3facf907d9eb614fb80e9/virtualenv-15.0.2.tar.gz"
+PYTHON_VIRTUALENV_SHA256 = "fab40f32d9ad298fba04a260f3073505a16d52539a84843cf8c8369d4fd17167" | true |
Other | Homebrew | brew | 157d461626007b22354a85cf463870f283f81fcb.json | README: add Contributing section.
Also, explicitly welcome new/beginner contributors and give them a suggested
starting point to contribute to Homebrew. Based on the boiler plate I tend to
send people to for GSoC, Outreachy or generally people who say "I want to try
and contribute to open-source". | README.md | @@ -16,6 +16,13 @@ Second, read the [Troubleshooting Checklist](https://github.com/Homebrew/brew/bl
**If you don't read these it will take us far longer to help you with your problem.**
+## Contributing
+We'd love you to contribute to Homebrew. First, please read our [Contribution Guide](https://github.com/Homebre... | false |
Other | Homebrew | brew | 1455aa3da6335b1eeb284e61171cff524c620fa3.json | Fix spelling of penryn (#580)
penryn was misspelled, which led to me doing a fruitless code search for where the architecture stuff is set. | share/doc/homebrew/Bottles.md | @@ -9,7 +9,7 @@ Bottles will not be used if the user requests it (see above), if the formula req
## Bottle Creation
Bottles are currently created using the [Brew Test Bot](Brew-Test-Bot.md). We will be slowly adding them to all formulae.
-By default, bottles will be built for the oldest CPU supported by the OS/arch... | false |
Other | Homebrew | brew | 265c1263494012d8e0e6cdd8b3522a664dde7aab.json | analytics.sh: use full uuidgen path on OS X.
Fixes #575. | Library/Homebrew/utils/analytics.sh | @@ -38,6 +38,9 @@ setup-analytics() {
if [[ -n "$HOMEBREW_LINUX" ]]
then
HOMEBREW_ANALYTICS_USER_UUID="$(tr a-f A-F < /proc/sys/kernel/random/uuid)"
+ elif [[ -n "$HOMEBREW_OSX" ]]
+ then
+ HOMEBREW_ANALYTICS_USER_UUID="$(/usr/bin/uuidgen)"
else
HOMEBREW_ANALYTICS_USER_UUID="$(uu... | false |
Other | Homebrew | brew | 43dafc9859e415ac85c4a082b23ceadd5813c196.json | brew.rb: Use odie instead of onoe+exit
Closes #577.
Signed-off-by: Baptiste Fontaine <b@ptistefontaine.fr> | Library/Homebrew/brew.rb | @@ -107,8 +107,7 @@ def require?(path)
safe_system(*tap_commands)
exec HOMEBREW_BREW_FILE, cmd, *ARGV
else
- onoe "Unknown command: #{cmd}"
- exit 1
+ odie "Unknown command: #{cmd}"
end
end
| false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.