language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | Homebrew | brew | ad17bbff9c59ef5d0490e6af317f7ce2d3069f69.json | cask-tests: fix loading simplecov | Library/Homebrew/cask/cmd/brew-cask-tests.rb | @@ -38,10 +38,7 @@ def run_tests(executable, files, args = [])
end
if ENV["CODECOV_TOKEN"]
- require "simplecov"
- require "codecov"
- formatter = SimpleCov::Formatter::Codecov.new
- formatter.format(SimpleCov::ResultMerger.merged_result)
+ system "bundle", "exec", "rake", "test:coverage:upload"
... | true |
Other | Homebrew | brew | 869fb0214971f3dbcccbe1915702ffc7e7d69d16.json | tests, cask-tests: serialize stdout on CI | Library/Homebrew/cask/cmd/brew-cask-tests.rb | @@ -1,7 +1,10 @@
require "English"
def run_tests(executable, files, args = [])
- system "bundle", "exec", executable, "--", *args, "--", *files
+ opts = []
+ opts << "--serialize-stdout" if ENV["CI"]
+
+ system "bundle", "exec", executable, *opts, "--", *args, "--", *files
end
repo_root = Pathname(__FILE__)... | true |
Other | Homebrew | brew | 869fb0214971f3dbcccbe1915702ffc7e7d69d16.json | tests, cask-tests: serialize stdout on CI | Library/Homebrew/dev-cmd/tests.rb | @@ -41,16 +41,24 @@ def tests
files = Dir["test/test_*.rb"]
files -= Dir["test/test_os_mac_*.rb"] unless OS.mac?
+
+ opts = []
+ opts << "--serialize-stdout" if ENV["CI"]
+
args = []
args << "--trace" if ARGV.include? "--trace"
+
if ARGV.value("only")
ENV["HOMEBRE... | true |
Other | Homebrew | brew | 0d76dfadcc11a2131917a4a677cc82bc16710b7c.json | utils: fix completions/manpages/docs linking. | Library/Homebrew/utils.rb | @@ -605,8 +605,11 @@ def link_src_dst_dirs(src_dir, dst_dir, command, link_dir: false)
src_paths = link_dir ? [src_dir] : src_dir.find
src_paths.each do |src|
next if src.directory? && !link_dir
- dst = dst_dir.parent/src.relative_path_from(src_dir.parent)
- next if dst.symlink? && src == dst.resolved_... | false |
Other | Homebrew | brew | 4e6990ed8168b74f14b51f389ae89db5abc026f6.json | list: use new exclude paths. | Library/Homebrew/cmd/list.rb | @@ -64,6 +64,8 @@ def list
UNBREWED_EXCLUDE_PATHS = %w[
.github/*
bin/brew
+ completions/zsh/_brew
+ docs/*
lib/gdk-pixbuf-2.0/*
lib/gio/*
lib/node_modules/*
@@ -73,13 +75,11 @@ def list
lib/ruby/gems/[12].*
lib/ruby/site_ruby/[12].*
lib/ruby/vendor_ruby/[12].*
+ manp... | false |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | CONTRIBUTING.md | @@ -5,7 +5,7 @@ First time contributing to Homebrew? Read our [Code of Conduct](https://github.c
* run `brew update` (twice)
* run and read `brew doctor`
-* read [the Troubleshooting Checklist](https://github.com/Homebrew/brew/blob/master/share/doc/homebrew/Troubleshooting.md#troubleshooting)
+* read [the Troublesh... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | Library/Homebrew/README.md | @@ -3,6 +3,6 @@ This is the (partially) documented public API for Homebrew.
The main class you should look at is the {Formula} class (and classes linked from there). That's the class that's used to create Homebrew formulae (i.e. package descriptions). Assume anything else you stumble upon is private.
-You may also... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | Library/Homebrew/cask/README.md | @@ -6,7 +6,7 @@ Homebrew-Cask extends [Homebrew](http://brew.sh) and brings its elegance, simpli
We do this by providing a friendly Homebrew-style CLI workflow for the administration of macOS applications distributed as binaries.
-It’s implemented as a `homebrew` [external command](https://github.com/Homebrew/brew... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | Library/Homebrew/cmd/help.rb | @@ -16,7 +16,7 @@
Developers:
brew create [URL [--no-fetch]]
brew edit [FORMULA...]
- https://github.com/Homebrew/brew/blob/master/share/doc/homebrew/Formula-Cookbook.md
+ https://github.com/Homebrew/brew/blob/master/docs/Formula-Cookbook.md
Further help:
man brew | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | Library/Homebrew/cmd/info.rb | @@ -14,7 +14,7 @@
#: information on all installed formulae.
#:
#: See the docs for examples of using the JSON:
-#: <https://github.com/Homebrew/brew/blob/master/share/doc/homebrew/Querying-Brew.md>
+#: <https://github.com/Homebrew/brew/blob/master/docs/Querying-Brew.md>
require "blacklist"
require "c... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | Library/Homebrew/cmd/tap-info.rb | @@ -13,7 +13,7 @@
#: Pass `--installed` to get information on installed taps.
#:
#: See the docs for examples of using the JSON:
-#: <https://github.com/Homebrew/brew/blob/master/share/doc/homebrew/Querying-Brew.md>
+#: <https://github.com/Homebrew/brew/blob/master/docs/Querying-Brew.md>
require "tap"... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | Library/Homebrew/dev-cmd/create.rb | @@ -154,7 +154,7 @@ def generate!
end
def template; <<-EOS.undent
- # Documentation: https://github.com/Homebrew/brew/blob/master/share/doc/homebrew/Formula-Cookbook.md
+ # Documentation: https://github.com/Homebrew/brew/blob/master/docs/Formula-Cookbook.md
# http://www.rubydoc.info/gi... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | Library/Homebrew/dev-cmd/tap-readme.rb | @@ -24,7 +24,7 @@ def tap_readme
```
## Documentation
- `brew help`, `man brew` or check [Homebrew's documentation](https://github.com/Homebrew/brew/tree/master/share/doc/homebrew#readme).
+ `brew help`, `man brew` or check [Homebrew's documentation](https://github.com/Homebrew/brew/tree/master/docs#r... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | Library/Homebrew/formula.rb | @@ -26,7 +26,7 @@
# @see SharedEnvExtension
# @see FileUtils
# @see Pathname
-# @see http://www.rubydoc.info/github/Homebrew/brew/file/share/doc/homebrew/Formula-Cookbook.md Formula Cookbook
+# @see http://www.rubydoc.info/github/Homebrew/brew/file/docs/Formula-Cookbook.md Formula Cookbook
# @see https://github.com... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | Library/Homebrew/manpages/brew.1.md.erb | @@ -62,7 +62,7 @@ scripts that reside somewhere in the `PATH`, named `brew-`<cmdname> or
to create your own commands without modifying Homebrew's internals.
Instructions for creating your own commands can be found in the docs:
-<https://github.com/Homebrew/brew/blob/master/share/doc/homebrew/External-Commands.md>
+... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | Library/Homebrew/utils/analytics.rb | @@ -35,7 +35,7 @@ def report(type, metadata = {})
end
# Send analytics. Don't send or store any personally identifiable information.
- # https://github.com/Homebrew/brew/blob/master/share/doc/homebrew/Analytics.md
+ # https://github.com/Homebrew/brew/blob/master/docs/Analytics.md
... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | Library/Homebrew/utils/analytics.sh | @@ -104,7 +104,7 @@ report-analytics-screenview-command() {
)
# Send analytics. Don't send or store any personally identifiable information.
- # https://github.com/Homebrew/brew/blob/master/share/doc/homebrew/Analytics.md
+ # https://github.com/Homebrew/brew/blob/master/docs/Analytics.md
# https://develope... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | README.md | @@ -13,12 +13,12 @@ cd "$(brew --repo)" && git fetch && git reset --hard origin/master && brew updat
3. Or use `brew search --desc <keyword>` to browse packages from the command line.
## More Documentation
-`brew help`, `man brew` or check [our documentation](https://github.com/Homebrew/brew/tree/master/share/doc/h... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | docs/Common-Issues.md | @@ -76,7 +76,7 @@ When running `brew upgrade`, you see something like this:
$ brew upgrade
Error: undefined method `include?' for nil:NilClass
Please report this bug:
- https://github.com/Homebrew/brew/blob/master/share/doc/homebrew/Troubleshooting.md
+ https://github.com/Homebrew/brew/blob/master/docs/Trouble... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | docs/External-Commands.md | @@ -81,4 +81,4 @@ These commands have been contributed by Homebrew users but are not included in t
> ```
## SEE ALSO
-Homebrew Docs: <https://github.com/Homebrew/brew/tree/master/share/doc/homebrew>
+Homebrew Docs: <https://github.com/Homebrew/brew/tree/master/docs> | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | docs/Formula-Cookbook.md | @@ -350,7 +350,7 @@ If you have already forked Homebrew on GitHub, then you can manually push (just
git push https://github.com/myname/homebrew-core/ <what-you-called-your-branch>
```
-Now, please [open a pull request](https://github.com/Homebrew/brew/blob/master/share/doc/homebrew/How-To-Open-a-Homebrew-Pull-Reque... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | docs/New-Maintainer-Checklist.md | @@ -25,8 +25,8 @@ A few requests:
- still create your branches on your fork rather than in the main repository
- if still in doubt please ask for help and we'll help you out - these are
probably worth a read:
- - https://github.com/Homebrew/brew/blob/master/share/doc/homebrew/Brew-Test-Bot-For-Core-Contributors... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | docs/Node-for-Formula-Authors.md | @@ -82,7 +82,7 @@ In your formula's `install` method, do any installation steps which need to be d
system "npm", "install", *Language::Node.local_npm_install_args
```
-This will install all of your Node modules dependencies to your local build path. You can now continue with your build steps and take care of the in... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | docs/Prose-Style-Guidelines.md | @@ -1,6 +1,6 @@
# Prose Style Guidelines
-This is a set of style and usage guidelines for Homebrew's prose documentation aimed at users, contributors, and maintainers (as opposed to executable computer code). It applies to documents like those in `share/doc/homebrew` in the `Homebrew/brew` repo, announcement emails,... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | docs/Tips-N'-Tricks.md | @@ -6,7 +6,7 @@ The preferred and supported method of installing specific versions of
formulae is to use the
[homebrew/versions](https://github.com/Homebrew/homebrew-versions)
tap. If the version you’re looking for isn’t available, consider [opening a
-pull request](https://github.com/Homebrew/brew/blob/master/shar... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | docs/brew.1.html | @@ -151,7 +151,7 @@ <h2 id="COMMANDS">COMMANDS</h2>
information on all installed formulae.</p>
<p>See the docs for examples of using the JSON:
-<a href="https://github.com/Homebrew/brew/blob/master/share/doc/homebrew/Querying-Brew.md" data-bare-link="true">https://github.com/Homebrew/brew/blob/master/share/doc/home... | true |
Other | Homebrew | brew | b85ee1cb8ffef36503f46685609442f79660737a.json | Update documentation links. | manpages/brew.1 | @@ -213,7 +213,7 @@ Print a JSON representation of \fIformulae\fR\. Currently the only accepted valu
Pass \fB\-\-all\fR to get information on all formulae, or \fB\-\-installed\fR to get information on all installed formulae\.
.
.IP
-See the docs for examples of using the JSON: \fIhttps://github\.com/Homebrew/brew/bl... | true |
Other | Homebrew | brew | 9067cc39b8d6943b585cc34c7b91994cb6a6810b.json | gitignore: rearrange repository, simplify rules. | .gitignore | @@ -33,30 +33,19 @@
# Unignore our `brew` script.
!/bin/brew
-# Ignore `share` contents (again).
-/share
-/share/doc
-/share/zsh
-/share/zsh/site-functions
-
# Unignore our documentation.
!/.github
-!/share/doc/homebrew
-!/share/man/man1/brew.1
-!/share/man/man1/brew-cask.1
-
-# Ignore `etc` contents (again)
-/et... | false |
Other | Homebrew | brew | 51ed08d733de8560048807c06eac63067f42788b.json | man: read lead, former maintainers, creator. | Library/Homebrew/dev-cmd/man.rb | @@ -51,9 +51,18 @@ def build_man_page
variables[:commands] = path_glob_commands("#{HOMEBREW_LIBRARY_PATH}/cmd/*.{rb,sh}")
variables[:developer_commands] = path_glob_commands("#{HOMEBREW_LIBRARY_PATH}/dev-cmd/*.{rb,sh}")
- variables[:maintainers] = (HOMEBREW_REPOSITORY/"README.md")
+ readme = HOMEBREW_... | true |
Other | Homebrew | brew | 51ed08d733de8560048807c06eac63067f42788b.json | man: read lead, former maintainers, creator. | Library/Homebrew/manpages/brew.1.md.erb | @@ -255,9 +255,11 @@ Homebrew Documentation: <https://github.com/Homebrew/brew/blob/master/share/doc/
## AUTHORS
+Homebrew's lead maintainer is <%= lead_maintainer %>.
+
Homebrew's current maintainers are <%= maintainers[0...-1].join(", ") %> and <%= maintainers[-1] %>.
-Former maintainers with significant cont... | true |
Other | Homebrew | brew | 51ed08d733de8560048807c06eac63067f42788b.json | man: read lead, former maintainers, creator. | share/doc/homebrew/brew.1.html | @@ -297,18 +297,14 @@ <h2 id="COMMANDS">COMMANDS</h2>
or even your <code>gem install</code> succeed. Especially handy if you run Homebrew
in an Xcode-only configuration since it adds tools like <code>make</code> to your <code>PATH</code>
which otherwise build-systems would not find.</p></dd>
-<dt><code>style</code> ... | true |
Other | Homebrew | brew | 51ed08d733de8560048807c06eac63067f42788b.json | man: read lead, former maintainers, creator. | share/man/man1/brew.1 | @@ -403,20 +403,14 @@ Search for \fItext\fR in the given package manager\'s list\.
Instantiate a Homebrew build environment\. Uses our years\-battle\-hardened Homebrew build logic to help your \fB\./configure && make && make install\fR or even your \fBgem install\fR succeed\. Especially handy if you run Homebrew in an... | true |
Other | Homebrew | brew | d6aa0aa8d35c76cc9865035e8570e9ee44600031.json | README: add lead, new maintainers. | README.md | @@ -38,7 +38,9 @@ This is our PGP key which is valid until May 24, 2017.
* Full key: https://keybase.io/homebrew/key.asc
## Who Are You?
-Homebrew's current maintainers are [Misty De Meo](https://github.com/mistydemeo), [Andrew Janke](https://github.com/apjanke), [Xu Cheng](https://github.com/xu-cheng), [Tomasz Paj... | false |
Other | Homebrew | brew | 41e25209f7486676f633ae05d7fc61e05af07b90.json | Save runtime dependencies in INSTALL_RECEIPT.json
Fixes #930 | Library/Homebrew/formula.rb | @@ -1450,6 +1450,12 @@ def recursive_requirements(&block)
Requirement.expand(self, &block)
end
+ # Returns a list of Dependency objects that are required at runtime.
+ # @private
+ def runtime_dependencies
+ recursive_dependencies.reject(&:build?)
+ end
+
# @private
def to_hash
hsh = { | true |
Other | Homebrew | brew | 41e25209f7486676f633ae05d7fc61e05af07b90.json | Save runtime dependencies in INSTALL_RECEIPT.json
Fixes #930 | Library/Homebrew/tab.rb | @@ -30,6 +30,10 @@ def self.create(formula, compiler, stdlib)
"HEAD" => HOMEBREW_REPOSITORY.git_head,
"compiler" => compiler,
"stdlib" => stdlib,
+ "runtime_dependencies" => formula.runtime_dependencies.map do |dep|
+ f = dep.to_formula
+ { "full_name" => f.full_name, "version" =... | true |
Other | Homebrew | brew | 41e25209f7486676f633ae05d7fc61e05af07b90.json | Save runtime dependencies in INSTALL_RECEIPT.json
Fixes #930 | Library/Homebrew/test/fixtures/receipt.json | @@ -14,6 +14,12 @@
"alias_path": "/usr/local/Library/Taps/homebrew/homebrew-core/Aliases/test-formula",
"stdlib": "libcxx",
"compiler": "clang",
+ "runtime_dependencies": [
+ {
+ "full_name": "foo",
+ "version": "1.0"
+ }
+ ],
"source": {
"path": "/usr/local/Library/Taps/hombrew/hom... | true |
Other | Homebrew | brew | 41e25209f7486676f633ae05d7fc61e05af07b90.json | Save runtime dependencies in INSTALL_RECEIPT.json
Fixes #930 | Library/Homebrew/test/test_formula.rb | @@ -638,6 +638,27 @@ def test_test_fixtures
f1.test_fixtures("foo")
end
+ def test_dependencies
+ stub_formula_loader formula("f1") { url "f1-1.0" }
+ stub_formula_loader formula("f2") { url "f2-1.0" }
+
+ f3 = formula("f3") do
+ url "f3-1.0"
+ depends_on "f1" => :build
+ depends_on... | true |
Other | Homebrew | brew | 41e25209f7486676f633ae05d7fc61e05af07b90.json | Save runtime dependencies in INSTALL_RECEIPT.json
Fixes #930 | Library/Homebrew/test/test_tab.rb | @@ -16,6 +16,7 @@ def setup
"HEAD" => TEST_SHA1,
"compiler" => "clang",
"stdlib" => "libcxx",
+ "runtime_dependencies" => [],
"source" => {
"tap... | true |
Other | Homebrew | brew | 15f3f2065625b05496632c1f5cf61fd150afef3c.json | Prevent Accessibility access for macOS >= 10.12
See https://github.com/caskroom/homebrew-cask/issues/24519
Feel free to suggest alternative wording and such. | Library/Homebrew/cask/lib/hbc/installer.rb | @@ -225,7 +225,12 @@ def print_caveats
def enable_accessibility_access
return unless @cask.accessibility_access
ohai "Enabling accessibility access"
- if MacOS.version <= :mountain_lion
+ if MacOS.version >= :sierra
+ opoo <<-EOS.undent
+ Access denied to accessibility DB (TCC.db) by SIP ... | false |
Other | Homebrew | brew | 4c773725c7683ec624863459ac3b4a3237a7382f.json | Use user GEM_HOME for installing gems
Save the value of GEM_HOME before unsetting it,
and resetting it when setting up a gem environment.
Fixes #944. | Library/Homebrew/brew.sh | @@ -59,6 +59,10 @@ then
odie "Cowardly refusing to continue at this prefix: $HOMEBREW_PREFIX"
fi
+# Save value to use for installing gems
+export GEM_OLD_HOME="$GEM_HOME"
+export GEM_OLD_PATH="$GEM_PATH"
+
# Users may have these set, pointing the system Ruby
# at non-system gem paths
unset GEM_HOME | true |
Other | Homebrew | brew | 4c773725c7683ec624863459ac3b4a3237a7382f.json | Use user GEM_HOME for installing gems
Save the value of GEM_HOME before unsetting it,
and resetting it when setting up a gem environment.
Fixes #944. | Library/Homebrew/utils.rb | @@ -270,17 +270,24 @@ def self.core_tap_version_string
end
def self.install_gem_setup_path!(name, version = nil, executable = name)
- require "rubygems"
+ # Respect user's preferences for where gems should be installed.
+ ENV["GEM_HOME"] = ENV["GEM_OLD_HOME"].to_s
+ ENV["GEM_HOME"] = Gem.user_dir if... | true |
Other | Homebrew | brew | 6fe70190204807a893419e5c510cb3e961e35c35.json | Make `HOMEBREW_PREFIX/Caskroom` the default. | Library/Homebrew/cask/lib/hbc.rb | @@ -49,6 +49,7 @@ def self.init
Hbc::Cache.ensure_cache_exists
Hbc::Cache.migrate_legacy_cache
+ Hbc::Caskroom.migrate_caskroom_from_repo_to_prefix
Hbc::Caskroom.ensure_caskroom_exists
end
| true |
Other | Homebrew | brew | 6fe70190204807a893419e5c510cb3e961e35c35.json | Make `HOMEBREW_PREFIX/Caskroom` the default. | Library/Homebrew/cask/lib/hbc/caskroom.rb | @@ -1,6 +1,14 @@
module Hbc::Caskroom
module_function
+ def migrate_caskroom_from_repo_to_prefix
+ repo_caskroom = Hbc.homebrew_repository.join("Caskroom")
+ if !Hbc.caskroom.exist? && repo_caskroom.directory?
+ ohai "Moving Caskroom from HOMEBREW_REPOSITORY to HOMEBREW_PREFIX"
+ FileUtils.mv rep... | true |
Other | Homebrew | brew | 6fe70190204807a893419e5c510cb3e961e35c35.json | Make `HOMEBREW_PREFIX/Caskroom` the default. | Library/Homebrew/cask/lib/hbc/cli/list.rb | @@ -79,4 +79,8 @@ def self.format_versioned(cask)
def self.help
"with no args, lists installed Casks; given installed Casks, lists staged files"
end
+
+ def self.needs_init?
+ true
+ end
end | true |
Other | Homebrew | brew | 6fe70190204807a893419e5c510cb3e961e35c35.json | Make `HOMEBREW_PREFIX/Caskroom` the default. | Library/Homebrew/cask/lib/hbc/locations.rb | @@ -9,7 +9,7 @@ def legacy_caskroom
end
def default_caskroom
- @default_caskroom ||= homebrew_repository.join("Caskroom")
+ @default_caskroom ||= homebrew_prefix.join("Caskroom")
end
def caskroom | true |
Other | Homebrew | brew | 3ffb9a2f7cda6652f75cb0c59c6d079ab1039e94.json | Fix another `brew style` from #971. | Library/Homebrew/formulary.rb | @@ -190,7 +190,7 @@ def initialize(name)
super name, Formulary.core_path(name)
end
- def get_formula(_spec, alias_path: nil)
+ def get_formula(*)
raise FormulaUnavailableError, name
end
end | false |
Other | Homebrew | brew | 13f08a2bd4ff3aec13423fa5bb62b6ef08ffa0c4.json | update-report: add missing comma. | Library/Homebrew/cmd/update-report.rb | @@ -236,7 +236,7 @@ def migrate_legacy_repository_if_necessary
end
unremovable_paths = []
- extra_remove_paths = [".git", "Library/Locks", "Library/Taps", "Caskroom"
+ extra_remove_paths = [".git", "Library/Locks", "Library/Taps", "Caskroom",
"Library/Homebrew/cask", "Librar... | false |
Other | Homebrew | brew | 8a4f26f9522522ea938e79cb9e4651968f50045f.json | test-bot: run `brew style`. | Library/Homebrew/dev-cmd/test-bot.rb | @@ -719,6 +719,7 @@ def homebrew
test "brew", "update-test", "--commit=HEAD"
end
+ test "brew", "style"
test "brew", "readall", "--syntax"
coverage_args = []
@@ -741,6 +742,9 @@ def homebrew
test "brew", "cask-tests", *coverage_args
end
elsif @... | false |
Other | Homebrew | brew | e79f62b2ead91decb3a255167d6a87020a0ad7ab.json | style: allow passing taps as arguments. | Library/Homebrew/cmd/style.rb | @@ -1,10 +1,6 @@
-#: * `style` [`--fix`] [`--display-cop-names`] [<formulae>|<files>]:
+#: * `style` [`--fix`] [`--display-cop-names`] [<files>|<taps>|<formulae>]:
#: Check formulae or files for conformance to Homebrew style guidelines.
#:
-#: <formulae> is a list of formula names.
-#:
-#: <files> is a lis... | false |
Other | Homebrew | brew | 515f7b52553b7f5f10904f2b3972260ae223c6e8.json | Unify .rubocopy.yml files. | Library/.rubocop.yml | @@ -1,134 +1,10 @@
-inherit_from: .rubocop_todo.yml
+inherit_from:
+ - .rubocop_rules.yml
+ - .rubocop_todo.yml
AllCops:
TargetRubyVersion: 2.0
Exclude:
- 'Homebrew/cask/**/*'
- 'Homebrew/vendor/**/*'
- 'Homebrew/test/vendor/**/*'
-
-# ruby style guide favorite
-Style/StringLiterals:
- Enforc... | true |
Other | Homebrew | brew | 515f7b52553b7f5f10904f2b3972260ae223c6e8.json | Unify .rubocopy.yml files. | Library/.rubocop_rules.yml | @@ -0,0 +1,141 @@
+
+# ruby style guide favorite
+Style/StringLiterals:
+ EnforcedStyle: double_quotes
+
+# consistency with above
+Style/StringLiteralsInInterpolation:
+ EnforcedStyle: double_quotes
+
+# percent-x is allowed for multiline
+Style/CommandLiteral:
+ EnforcedStyle: mixed
+
+# paths abound, easy escape
... | true |
Other | Homebrew | brew | 515f7b52553b7f5f10904f2b3972260ae223c6e8.json | Unify .rubocopy.yml files. | Library/.rubocop_todo.yml | @@ -1,6 +1,6 @@
# This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2016-09-17 15:44:31 +0100 using RuboCop version 0.42.0.
+# `rubocop --auto-gen-config --exclude-limit 30`
+# on 2016-09-18 15:15:22 +0100 using RuboCop version 0.41.2.
# The point is for the user to remove these configuration r... | true |
Other | Homebrew | brew | 515f7b52553b7f5f10904f2b3972260ae223c6e8.json | Unify .rubocopy.yml files. | Library/Homebrew/compat/.rubocop.yml | @@ -1,7 +0,0 @@
-inherit_from: ../../.rubocop.yml
-
-# We won't change method or predicate names because of backward compatibility.
-Style/MethodName:
- Enabled: false
-Style/PredicateName:
- Enabled: false | true |
Other | Homebrew | brew | 515f7b52553b7f5f10904f2b3972260ae223c6e8.json | Unify .rubocopy.yml files. | Library/Homebrew/test/.rubocop.yml | @@ -1,5 +0,0 @@
-inherit_from: ../../.rubocop.yml
-
-# `formula do` uses nested method definitions
-Lint/NestedMethodDefinition:
- Enabled: false | true |
Other | Homebrew | brew | d89a696d83cd325656e30a99cb4ba8342ffb39c9.json | Remove unused variable
This will make brew readall --syntax pass | Library/Homebrew/test/test_formula.rb | @@ -126,7 +126,6 @@ def test_installed_alias_with_core
def test_installed_alias_with_tap
tap = Tap.new("user", "repo")
name = "foo"
- full_name = "#{tap.user}/#{tap.repo}/#{name}"
path = "#{tap.path}/Formula/#{name}.rb"
f = formula(name, path) { url "foo-1.0" }
| false |
Other | Homebrew | brew | 4abd48812bb544426442749266acb13a20ce434c.json | alias tracking: add formula tests | Library/Homebrew/test/test_formula.rb | @@ -8,15 +8,154 @@ def test_formula_instantiation
name = "formula_name"
path = Formulary.core_path(name)
spec = :stable
- alias_path = CoreTap.instance.alias_dir/"formula_alias"
+
+ f = klass.new(name, path, spec)
+ assert_equal name, f.name
+ assert_equal name, f.specified_name
+ assert_e... | true |
Other | Homebrew | brew | 4abd48812bb544426442749266acb13a20ce434c.json | alias tracking: add formula tests | Library/Homebrew/test/testing_env.rb | @@ -121,5 +121,13 @@ def with_environment(partial_env)
ENV.replace old
end
end
+
+ # Use a stubbed {Formulary::FormulaLoader} to make a given formula be found
+ # when loading from {Formulary} with `ref`.
+ def stub_formula_loader(formula, ref = formula.name)
+ loader = mock
+ lo... | true |
Other | Homebrew | brew | e12c23faa87aa9c6f493dcd4aa47d1124c41a418.json | Formula#old_installed_formula?: fix some bugs
Previously, this method would:
- Include the current formula
- Include the current target of the installed alias, which by definition
is not "old"
This commit fixes both of these issues.
Only formulae that are the current target of the alias they were installed
with ar... | Library/Homebrew/formula.rb | @@ -1186,7 +1186,11 @@ def latest_formula
end
def old_installed_formulae
- alias_path ? self.class.installed_with_alias_path(alias_path) : []
+ # If this formula isn't the current target of the alias,
+ # it doesn't make sense to say that other formulae are older versions of it
+ # because we don't ... | false |
Other | Homebrew | brew | d0204207edd6a8044b8bd1f01df1b3637dab5475.json | update-report: remove cask dir after migration.
This will hang around otherwise due to e.g. running `bundle install` in
here once. | Library/Homebrew/cmd/update-report.rb | @@ -234,7 +234,7 @@ def migrate_legacy_repository_if_necessary
unremovable_paths = []
extra_remove_paths = [".git", "Library/Locks", "Library/Taps",
- "Library/Homebrew/test"]
+ "Library/Homebrew/cask", "Library/Homebrew/test"]
(repo_files + extra_remov... | false |
Other | Homebrew | brew | 7b85934f502cd6adf4696cf63cd3cd0c4449d40f.json | Update formula tests for #outdated_kegs | Library/Homebrew/test/test_formula.rb | @@ -637,55 +637,55 @@ def setup_tab_for_prefix(prefix, options = {})
tab
end
- def reset_outdated_versions
- f.instance_variable_set(:@outdated_versions, nil)
+ def reset_outdated_kegs
+ f.instance_variable_set(:@outdated_kegs, nil)
end
def test_greater_different_tap_installed
setup_tab_f... | false |
Other | Homebrew | brew | d3788c58efbae7c841faeb89a3eea539862245f7.json | brew outdated: use full name in verbose | Library/Homebrew/cmd/outdated.rb | @@ -56,9 +56,11 @@ def print_outdated(formulae)
end
outdated_versions = outdated_kegs.
- group_by(&:name).
- sort_by(&:first).
- map { |name, kegs| "#{name} (#{kegs.map(&:version) * ", "})" } * ", "
+ group_by { |keg| Formulary.from_keg(keg) }.
+ sort_by ... | false |
Other | Homebrew | brew | 2a683f2569614850f79534a8547fd96cc52c7850.json | upgrade, outdated: follow alias changes | Library/Homebrew/cmd/outdated.rb | @@ -43,15 +43,26 @@ def print_outdated(formulae)
outdated_formulae.each do |f|
if verbose
- outdated_versions = f.outdated_versions(fetch_head: fetch_head)
- current_version = if f.head? && outdated_versions.any? { |v| v.to_s == f.pkg_version.to_s }
+ outdated_kegs = f.outdated_kegs(f... | true |
Other | Homebrew | brew | 2a683f2569614850f79534a8547fd96cc52c7850.json | upgrade, outdated: follow alias changes | Library/Homebrew/cmd/upgrade.rb | @@ -37,10 +37,10 @@ def upgrade
(ARGV.resolved_formulae - outdated).each do |f|
versions = f.installed_kegs.map(&:version)
if versions.empty?
- onoe "#{f.full_name} not installed"
+ onoe "#{f.full_specified_name} not installed"
else
version = versions.max
-... | true |
Other | Homebrew | brew | 2a683f2569614850f79534a8547fd96cc52c7850.json | upgrade, outdated: follow alias changes | Library/Homebrew/extend/ARGV.rb | @@ -37,11 +37,23 @@ def resolved_formulae
f.version.update_commit(k.version.version.commit) if k.version.head?
end
end
- f
else
rack = Formulary.to_rack(name)
- Formulary.from_rack(rack, spec(nil))
+ alias_path = Formulary.factory(name).alias_path
+ ... | true |
Other | Homebrew | brew | 2a683f2569614850f79534a8547fd96cc52c7850.json | upgrade, outdated: follow alias changes | Library/Homebrew/formula.rb | @@ -60,16 +60,24 @@ class Formula
# e.g. `this-formula`
attr_reader :name
- # The name that was used to identify this {Formula}.
- # Could be the name of the {Formula}, or an alias.
- # e.g. `another-name-for-this-formula`
+ # The path to the alias that was used to identify this {Formula}.
+ # e.g. `/usr/l... | true |
Other | Homebrew | brew | 2a683f2569614850f79534a8547fd96cc52c7850.json | upgrade, outdated: follow alias changes | Library/Homebrew/formulary.rb | @@ -77,8 +77,11 @@ def initialize(name, path)
end
# Gets the formula instance.
- def get_formula(spec)
- klass.new(name, path, spec, alias_path: alias_path)
+ #
+ # `alias_path` can be overridden here in case an alias was used to refer to
+ # a formula that was loaded in another way.
+ d... | true |
Other | Homebrew | brew | 2a683f2569614850f79534a8547fd96cc52c7850.json | upgrade, outdated: follow alias changes | Library/Homebrew/test/test_formulary.rb | @@ -89,7 +89,7 @@ def test_factory_from_alias
FileUtils.ln_s @path, alias_path
result = Formulary.factory("foo")
assert_kind_of Formula, result
- assert_equal alias_path, result.alias_path
+ assert_equal alias_path.to_s, result.alias_path
ensure
alias_dir.rmtree
end | true |
Other | Homebrew | brew | ee0fb3e999197b866d727a9c63ab3dda31603639.json | update-report: handle directory not existing.
This shouldn't be possible to occur after #1013 but it makes sense to
add it anyway. | Library/Homebrew/cmd/update-report.rb | @@ -258,7 +258,7 @@ def migrate_legacy_repository_if_necessary
dst = Pathname.new("#{HOMEBREW_PREFIX}/bin/brew")
begin
FileUtils.ln_s(src.relative_path_from(dst.parent), dst)
- rescue Errno::EACCES
+ rescue Errno::EACCES, Errno::ENOENT
ofail <<-EOS.undent
Could not create symlink ... | false |
Other | Homebrew | brew | 997ccb044d21fccb1a95ef4eefad0fa892289e02.json | Relocate HOMEBREW_REPOSITORY when necessary.
Now that the default from the installer, our CI and soon all users
is `/usr/local/Homebrew` it's a lot easier to check if there's
references to it (as we cannot look for `/usr/local` as it's a too
commonly hardcoded path). | Library/Homebrew/dev-cmd/bottle.rb | @@ -177,6 +177,7 @@ def bottle_formula(f)
tar_path = Pathname.pwd/tar_filename
prefix = HOMEBREW_PREFIX.to_s
+ repository = HOMEBREW_REPOSITORY.to_s
cellar = HOMEBREW_CELLAR.to_s
ohai "Bottling #{filename}..."
@@ -193,7 +194,8 @@ def bottle_formula(f)
keg.relocate_dynamic_linkage p... | true |
Other | Homebrew | brew | 997ccb044d21fccb1a95ef4eefad0fa892289e02.json | Relocate HOMEBREW_REPOSITORY when necessary.
Now that the default from the installer, our CI and soon all users
is `/usr/local/Homebrew` it's a lot easier to check if there's
references to it (as we cannot look for `/usr/local` as it's a too
commonly hardcoded path). | Library/Homebrew/formula_installer.rb | @@ -779,7 +779,8 @@ def pour
Keg::CELLAR_PLACEHOLDER, HOMEBREW_CELLAR.to_s
end
keg.relocate_text_files Keg::PREFIX_PLACEHOLDER, HOMEBREW_PREFIX.to_s,
- Keg::CELLAR_PLACEHOLDER, HOMEBREW_CELLAR.to_s
+ Keg::CELLAR_PLACEHOLDER, HOMEBREW_CELLAR.to_s,
+ Keg::REPOSITORY_PLACEHOLDER, HOMEBREW... | true |
Other | Homebrew | brew | 997ccb044d21fccb1a95ef4eefad0fa892289e02.json | Relocate HOMEBREW_REPOSITORY when necessary.
Now that the default from the installer, our CI and soon all users
is `/usr/local/Homebrew` it's a lot easier to check if there's
references to it (as we cannot look for `/usr/local` as it's a too
commonly hardcoded path). | Library/Homebrew/keg_relocate.rb | @@ -1,6 +1,7 @@
class Keg
PREFIX_PLACEHOLDER = "@@HOMEBREW_PREFIX@@".freeze
CELLAR_PLACEHOLDER = "@@HOMEBREW_CELLAR@@".freeze
+ REPOSITORY_PLACEHOLDER = "@@HOMEBREW_REPOSITORY@@".freeze
def fix_dynamic_linkage
symlink_files.each do |file|
@@ -18,13 +19,15 @@ def relocate_dynamic_linkage(_old_prefix, _... | true |
Other | Homebrew | brew | 72d0154454a1d4fe4dd94d4a3abf94ad65d2b77b.json | update-report: migrate everyone to new repository.
Also migrate people without `HOMEBREW_DEVELOPER` set to the new
location. | Library/Homebrew/cmd/update-report.rb | @@ -175,7 +175,6 @@ def migrate_legacy_cache_if_necessary
def migrate_legacy_repository_if_necessary
return unless HOMEBREW_PREFIX.to_s == "/usr/local"
return unless HOMEBREW_REPOSITORY.to_s == "/usr/local"
- return unless ARGV.homebrew_developer?
ohai "Migrating HOMEBREW_REPOSITORY (please wait)... | false |
Other | Homebrew | brew | d70841db2bcccb089382ffb940ce8a8bc3de22d4.json | update.sh: turn origin/branch into a variable.
Rather than repeating origin multiple times. | Library/Homebrew/cmd/update.sh | @@ -215,6 +215,8 @@ merge_or_rebase() {
trap reset_on_interrupt SIGINT
+ REMOTE_REF="origin/$UPSTREAM_BRANCH"
+
if [[ -n "$(git status --untracked-files=all --porcelain 2>/dev/null)" ]]
then
if [[ -n "$HOMEBREW_VERBOSE" ]]
@@ -252,11 +254,11 @@ EOS
# Recreate and check out `#{upstream_branch}`... | false |
Other | Homebrew | brew | 58b17a0cfc34adf2213e18b1f277c52a89407e64.json | utils: convert formula name from pathname to string
`name` is passed as argument to Formulary.factory which could later be
downcased at formulary.rb:349, but Pathname doesn't have a downcase
method. Converting `name` to String as it should be fixes the problem.
Fixes #1000. | Library/Homebrew/utils.rb | @@ -627,7 +627,7 @@ def migrate_legacy_keg_symlinks_if_necessary
HOMEBREW_LINKED_KEGS.mkpath unless legacy_linked_kegs.children.empty?
legacy_linked_kegs.children.each do |link|
- name = link.basename
+ name = link.basename.to_s
src = begin
link.realpath
rescue Errno::ENOENT
@@ -648,7 +64... | false |
Other | Homebrew | brew | eb23a397013622025dc3b64dda782a9a9cdea4cf.json | utils: remove bad symlink if it already exists. | Library/Homebrew/utils.rb | @@ -637,6 +637,7 @@ def migrate_legacy_keg_symlinks_if_necessary
end
end
dst = HOMEBREW_LINKED_KEGS/name
+ dst.unlink if dst.exist?
FileUtils.ln_sf(src.relative_path_from(dst.parent), dst)
end
FileUtils.rm_rf legacy_linked_kegs | false |
Other | Homebrew | brew | 1bdbb0f462e4c3557bbcba0b203696bdcf025bb4.json | Improve rescue nesting. | Library/Homebrew/diagnostic.rb | @@ -516,10 +516,10 @@ def check_for_gettext
# Our gettext formula will be caught by check_linked_keg_only_brews
gettext = begin
- Formulary.factory("gettext")
- rescue
- nil
- end
+ Formulary.factory("gettext")
+ ... | true |
Other | Homebrew | brew | 1bdbb0f462e4c3557bbcba0b203696bdcf025bb4.json | Improve rescue nesting. | Library/Homebrew/download_strategy.rb | @@ -269,10 +269,10 @@ def chdir
case entries.length
when 0 then raise "Empty archive"
when 1 then begin
- Dir.chdir entries.first
- rescue
- nil
- end
+ Dir.chdir entries.first
+ rescue
+ nil
+ end
end
end
| true |
Other | Homebrew | brew | 1bdbb0f462e4c3557bbcba0b203696bdcf025bb4.json | Improve rescue nesting. | Library/Homebrew/global.rb | @@ -56,10 +56,10 @@ module Homebrew
ORIGINAL_PATHS = ENV["PATH"].split(File::PATH_SEPARATOR).map do |p|
begin
- Pathname.new(p).expand_path
- rescue
- nil
- ... | true |
Other | Homebrew | brew | 1bdbb0f462e4c3557bbcba0b203696bdcf025bb4.json | Improve rescue nesting. | Library/Homebrew/software_spec.rb | @@ -339,10 +339,10 @@ def checksums
os_versions = collector.keys
os_versions.map! do |osx|
begin
- MacOS::Version.from_symbol osx
- rescue
- nil
- end
+ MacOS::Version.from_symbol ... | true |
Other | Homebrew | brew | 8f1ae3b28b0a12fe4a9d905dd4c41873d1674377.json | Move LinkedKegs migration.
Move the `LinkedKegs` migration into `utils.rb` so it can also be called
from `brew.rb` on startup. | Library/Homebrew/brew.rb | @@ -87,6 +87,9 @@ def require?(path)
# `Homebrew.help` never returns, except for external/unknown commands.
end
+ # Migrate LinkedKegs/PinnedKegs if update didn't already do so
+ migrate_legacy_keg_symlinks_if_necessary
+
# Uninstall old brew-cask if it's still around; we just use the tap now.
if cmd ... | true |
Other | Homebrew | brew | 8f1ae3b28b0a12fe4a9d905dd4c41873d1674377.json | Move LinkedKegs migration.
Move the `LinkedKegs` migration into `utils.rb` so it can also be called
from `brew.rb` on startup. | Library/Homebrew/cmd/update-report.rb | @@ -7,6 +7,7 @@
require "formulary"
require "descriptions"
require "cleanup"
+require "utils"
module Homebrew
def update_preinstall_header
@@ -168,30 +169,6 @@ def migrate_legacy_cache_if_necessary
end
end
- def migrate_legacy_keg_symlinks_if_necessary
- legacy_linked_kegs = HOMEBREW_LIBRARY/"Lin... | true |
Other | Homebrew | brew | 8f1ae3b28b0a12fe4a9d905dd4c41873d1674377.json | Move LinkedKegs migration.
Move the `LinkedKegs` migration into `utils.rb` so it can also be called
from `brew.rb` on startup. | Library/Homebrew/config.rb | @@ -18,18 +18,10 @@
HOMEBREW_SHIMS_PATH = HOMEBREW_LIBRARY/"Homebrew/shims"
# Where we store symlinks to currently linked kegs
-HOMEBREW_LINKED_KEGS = if (HOMEBREW_LIBRARY/"LinkedKegs").exist?
- HOMEBREW_LIBRARY/"LinkedKegs"
-else
- HOMEBREW_PREFIX/"var/homebrew/linked"
-end
+HOMEBREW_LINKED_KEGS = HOMEBREW_PREFI... | true |
Other | Homebrew | brew | 8f1ae3b28b0a12fe4a9d905dd4c41873d1674377.json | Move LinkedKegs migration.
Move the `LinkedKegs` migration into `utils.rb` so it can also be called
from `brew.rb` on startup. | Library/Homebrew/utils.rb | @@ -620,3 +620,27 @@ def link_src_dst_dirs(src_dir, dst_dir, command, link_dir: false)
def link_path_manpages(path, command)
link_src_dst_dirs(path/"man", HOMEBREW_PREFIX/"share/man", command)
end
+
+def migrate_legacy_keg_symlinks_if_necessary
+ legacy_linked_kegs = HOMEBREW_LIBRARY/"LinkedKegs"
+ return unless... | true |
Other | Homebrew | brew | b1903c1a4a2639bf9730f1035abfe6172c3b5957.json | test-bot: generate coverage reports on Sierra.
We may have two Sierra nodes available which could speed up this
relatively slow operation. | Library/Homebrew/dev-cmd/test-bot.rb | @@ -724,7 +724,7 @@ def homebrew
coverage_args = []
if ARGV.include?("--coverage")
if ENV["JENKINS_HOME"]
- if OS.mac? && MacOS.version == :el_capitan
+ if OS.mac? && MacOS.version == :sierra
coverage_args << "--coverage"
end
else | false |
Other | Homebrew | brew | 24aa6a53caab86ec3c90d1c729a18cf65da3ba08.json | .codecov.yml: Redirect root to Library/Homebrew. | Library/Homebrew/test/.codecov.yml | @@ -1 +1,4 @@
comment: false
+coverage:
+ fixes:
+ - "::Library/Homebrew/" | false |
Other | Homebrew | brew | e3609b6fd4001523679562c33064e17d03e1534f.json | Move LinkedKegs/PinnedKegs/Locks from Library.
These don't make sense to be tied to the `HOMEBREW_REPOSITORY` but
instead should live in the `HOMEBREW_PREFIX` as they all relate to its
state. | Library/Homebrew/cmd/update-report.rb | @@ -75,6 +75,7 @@ def update_report
end
migrate_legacy_cache_if_necessary
+ migrate_legacy_keg_symlinks_if_necessary
if !updated
if !ARGV.include?("--preinstall") && !ENV["HOMEBREW_UPDATE_FAILED"]
@@ -167,6 +168,24 @@ def migrate_legacy_cache_if_necessary
end
end
+ def migrate_le... | true |
Other | Homebrew | brew | e3609b6fd4001523679562c33064e17d03e1534f.json | Move LinkedKegs/PinnedKegs/Locks from Library.
These don't make sense to be tied to the `HOMEBREW_REPOSITORY` but
instead should live in the `HOMEBREW_PREFIX` as they all relate to its
state. | Library/Homebrew/config.rb | @@ -17,8 +17,14 @@
# Where shim scripts for various build and SCM tools are stored
HOMEBREW_SHIMS_PATH = HOMEBREW_LIBRARY/"Homebrew/shims"
+# Where we store symlinks to currently linked kegs
+HOMEBREW_LINKED_KEGS = HOMEBREW_PREFIX/"var/homebrew/linked"
+
+# Wehere we store symlinks to currently version-pinned kegs
... | true |
Other | Homebrew | brew | e3609b6fd4001523679562c33064e17d03e1534f.json | Move LinkedKegs/PinnedKegs/Locks from Library.
These don't make sense to be tied to the `HOMEBREW_REPOSITORY` but
instead should live in the `HOMEBREW_PREFIX` as they all relate to its
state. | Library/Homebrew/global.rb | @@ -22,9 +22,6 @@
HOMEBREW_REPOSITORY.extend(GitRepositoryExtension)
-HOMEBREW_LINKED_KEGS = HOMEBREW_LIBRARY/"LinkedKegs"
-HOMEBREW_PINNED_KEGS = HOMEBREW_LIBRARY/"PinnedKegs"
-
RUBY_PATH = Pathname.new(RbConfig.ruby)
RUBY_BIN = RUBY_PATH.dirname
| true |
Other | Homebrew | brew | e3609b6fd4001523679562c33064e17d03e1534f.json | Move LinkedKegs/PinnedKegs/Locks from Library.
These don't make sense to be tied to the `HOMEBREW_REPOSITORY` but
instead should live in the `HOMEBREW_PREFIX` as they all relate to its
state. | Library/Homebrew/keg.rb | @@ -66,7 +66,7 @@ def to_s; <<-EOS.undent
INFOFILE_RX = %r{info/([^.].*?\.info|dir)$}
TOP_LEVEL_DIRECTORIES = %w[bin etc include lib sbin share var Frameworks]
ALL_TOP_LEVEL_DIRECTORIES = (TOP_LEVEL_DIRECTORIES + %w[lib/pkgconfig share/locale share/man opt]).freeze
- PRUNEABLE_DIRECTORIES = %w[bin etc include... | true |
Other | Homebrew | brew | e3609b6fd4001523679562c33064e17d03e1534f.json | Move LinkedKegs/PinnedKegs/Locks from Library.
These don't make sense to be tied to the `HOMEBREW_REPOSITORY` but
instead should live in the `HOMEBREW_PREFIX` as they all relate to its
state. | Library/Homebrew/test/lib/config.rb | @@ -24,6 +24,8 @@
HOMEBREW_LIBRARY = HOMEBREW_REPOSITORY+"Library"
HOMEBREW_CACHE = HOMEBREW_PREFIX.parent+"cache"
HOMEBREW_CACHE_FORMULA = HOMEBREW_PREFIX.parent+"formula_cache"
+HOMEBREW_LINKED_KEGS = HOMEBREW_PREFIX.parent+"linked"
+HOMEBREW_PINNED_KEGS = HOMEBREW_PREFIX.parent+"pinned"
HOMEBRE... | true |
Other | Homebrew | brew | e3609b6fd4001523679562c33064e17d03e1534f.json | Move LinkedKegs/PinnedKegs/Locks from Library.
These don't make sense to be tied to the `HOMEBREW_REPOSITORY` but
instead should live in the `HOMEBREW_PREFIX` as they all relate to its
state. | Library/Homebrew/test/test_integration_cmds.rb | @@ -14,6 +14,8 @@ def setup
def teardown
coretap = CoreTap.new
paths_to_delete = [
+ HOMEBREW_LINKED_KEGS,
+ HOMEBREW_PINNED_KEGS,
HOMEBREW_CELLAR.children,
HOMEBREW_CACHE.children,
HOMEBREW_LOCK_DIR.children,
@@ -22,7 +24,6 @@ def teardown
HOMEBREW_PREFIX/"bin",
... | true |
Other | Homebrew | brew | e3609b6fd4001523679562c33064e17d03e1534f.json | Move LinkedKegs/PinnedKegs/Locks from Library.
These don't make sense to be tied to the `HOMEBREW_REPOSITORY` but
instead should live in the `HOMEBREW_PREFIX` as they all relate to its
state. | Library/Homebrew/utils/lock.sh | @@ -3,7 +3,7 @@
# Noted due to the fixed FD, a shell process can only create one lock.
lock() {
local name="$1"
- local lock_dir="$HOMEBREW_LIBRARY/Locks"
+ local lock_dir="$HOMEBREW_PREFIX/var/homebrew/locks"
local lock_file="$lock_dir/$name"
[[ -d "$lock_dir" ]] || mkdir -p "$lock_dir"
# 200 is the fi... | true |
Other | Homebrew | brew | b1fba6ed54997bd0a2ce29fdd523f40fecada0c3.json | Send coverage from Jenkins, don't run OS X Travis.
OS X Travis CI is particularly error-prone, slow and unnecessary for
us when we're already running (fast) OS X builds on Jenkins so use it
just for Linux testing. | .travis.yml | @@ -2,13 +2,6 @@ language: ruby
rvm: 2.0.0
os: linux
-matrix:
- include:
- - os: osx
- env: OSX=10.11
- osx_image: xcode7.3
- rvm: system
-
before_install:
- export HOMEBREW_DEVELOPER=1
- export PATH="bin:$PATH" | true |
Other | Homebrew | brew | b1fba6ed54997bd0a2ce29fdd523f40fecada0c3.json | Send coverage from Jenkins, don't run OS X Travis.
OS X Travis CI is particularly error-prone, slow and unnecessary for
us when we're already running (fast) OS X builds on Jenkins so use it
just for Linux testing. | Library/Homebrew/cask/Gemfile | @@ -12,7 +12,7 @@ group :development do
end
group :test do
- gem "coveralls", require: false
+ gem "codecov", require: false
gem "minitest", "5.4.1"
gem "minitest-reporters"
gem "mocha", "1.1.0", require: false | true |
Other | Homebrew | brew | b1fba6ed54997bd0a2ce29fdd523f40fecada0c3.json | Send coverage from Jenkins, don't run OS X Travis.
OS X Travis CI is particularly error-prone, slow and unnecessary for
us when we're already running (fast) OS X builds on Jenkins so use it
just for Linux testing. | Library/Homebrew/cask/Gemfile.lock | @@ -5,13 +5,11 @@ GEM
ast (2.3.0)
builder (3.2.2)
byebug (9.0.5)
+ codecov (0.1.5)
+ json
+ simplecov
+ url
coderay (1.1.1)
- coveralls (0.8.15)
- json (>= 1.8, < 3)
- simplecov (~> 0.12.0)
- term-ansicolor (~> 1.3)
- thor (~> 0.19.1)
- tins (>= 1.6.0, <... | true |
Other | Homebrew | brew | b1fba6ed54997bd0a2ce29fdd523f40fecada0c3.json | Send coverage from Jenkins, don't run OS X Travis.
OS X Travis CI is particularly error-prone, slow and unnecessary for
us when we're already running (fast) OS X builds on Jenkins so use it
just for Linux testing. | Library/Homebrew/cask/README.md | @@ -8,9 +8,6 @@ We do this by providing a friendly Homebrew-style CLI workflow for the administr
It’s implemented as a `homebrew` [external command](https://github.com/Homebrew/brew/blob/master/share/doc/homebrew/External-Commands.md) called `cask`.
-[ OS X builds on Jenkins so use it
just for Linux testing. | Library/Homebrew/cask/Rakefile | @@ -23,10 +23,11 @@ namespace :test do
Rake::Task[:test].invoke
- if ENV["TRAVIS"]
- require "coveralls/rake/task"
- Coveralls::RakeTask.new
- Rake::Task['coveralls:push'].invoke
+ if ENV["CODECOV_TOKEN"]
+ require "simplecov"
+ require "codecov"
+ formatter = SimpleCov::For... | true |
Other | Homebrew | brew | b1fba6ed54997bd0a2ce29fdd523f40fecada0c3.json | Send coverage from Jenkins, don't run OS X Travis.
OS X Travis CI is particularly error-prone, slow and unnecessary for
us when we're already running (fast) OS X builds on Jenkins so use it
just for Linux testing. | Library/Homebrew/dev-cmd/test-bot.rb | @@ -59,8 +59,7 @@
#:
#: If `--no-pull` is passed, don't use `brew pull` when possible.
#:
-#: If `--coverage` is passed, generate coverage report and send it to
-#: Coveralls.
+#: If `--coverage` is passed, generate and uplaod a coverage report.
#:
#: If `--test-default-formula` is passed, use a def... | true |
Other | Homebrew | brew | b1fba6ed54997bd0a2ce29fdd523f40fecada0c3.json | Send coverage from Jenkins, don't run OS X Travis.
OS X Travis CI is particularly error-prone, slow and unnecessary for
us when we're already running (fast) OS X builds on Jenkins so use it
just for Linux testing. | Library/Homebrew/test/Gemfile | @@ -13,5 +13,5 @@ group :coverage do
:git => "https://github.com/colszowka/simplecov.git",
:branch => "master", # commit 257e26394c464c4ab388631b4eff1aa98c37d3f1
:require => false
- gem "coveralls", "0.8.14", :require => false
+ gem "codecov", require: false
end | true |
Other | Homebrew | brew | b1fba6ed54997bd0a2ce29fdd523f40fecada0c3.json | Send coverage from Jenkins, don't run OS X Travis.
OS X Travis CI is particularly error-prone, slow and unnecessary for
us when we're already running (fast) OS X builds on Jenkins so use it
just for Linux testing. | Library/Homebrew/test/Gemfile.lock | @@ -11,12 +11,10 @@ GIT
GEM
remote: https://rubygems.org/
specs:
- coveralls (0.8.14)
- json (>= 1.8, < 3)
- simplecov (~> 0.12.0)
- term-ansicolor (~> 1.3)
- thor (~> 0.19.1)
- tins (~> 1.6.0)
+ codecov (0.1.5)
+ json
+ simplecov
+ url
docile (1.1.5)
json ... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.