repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
STranslate/STranslate | 473 | issue_to_patch | feat: glm 4.5 supports turning off thinking mode | #472 | cffb7e425f3a0cde296bbfe1708f3eca331debe9 | e8b0b0861e615aeb4598cb26fdffd7215cfa8c92 | diff --git a/src/STranslate.Style/Styles/Localizations/Language.en-US.xaml b/src/STranslate.Style/Styles/Localizations/Language.en-US.xaml
index 4de71a38..3579406c 100644
--- a/src/STranslate.Style/Styles/Localizations/Language.en-US.xaml
+++ b/src/STranslate.Style/Styles/Localizations/Language.en-US.xaml
@@ -581,6 +58... | [
"src/STranslate.Style/Styles/Localizations/Language.en-US.xaml",
"src/STranslate.Style/Styles/Localizations/Language.zh-Hans-CN.xaml",
"src/STranslate.Style/Styles/Localizations/Language.zh-Hant-TW.xaml",
"src/STranslate/ViewModels/Preference/Translator/TranslatorChatglm.cs",
"src/STranslate/Views/Preferenc... | [] | true | ||
STranslate/STranslate | 471 | issue_to_patch | feat: add mtranserver | 8a6087e32290f86d0d5cee1c26a2f89996fca8a3 | d93a326a1471f9e0037e9f6ba8d4db133a0a8a1a | diff --git a/src/STranslate.Model/Enums.cs b/src/STranslate.Model/Enums.cs
index 6f1b620c..5602abce 100644
--- a/src/STranslate.Model/Enums.cs
+++ b/src/STranslate.Model/Enums.cs
@@ -210,6 +210,7 @@ public enum ServiceType
TransmartBuiltInService,
OpenRouterService,
QwenMtService,
+ MTranServerService... | [
"src/STranslate.Model/Enums.cs",
"src/STranslate.Style/Resources/mtranserver.png",
"src/STranslate.Style/Resources/transmart.png",
"src/STranslate.Style/STranslate.Style.csproj",
"src/STranslate.Style/Styles/IconStyle.xaml",
"src/STranslate/Helper/ConfigHelper.cs",
"src/STranslate/ViewModels/InputViewMo... | [] | true | |||
STranslate/STranslate | 468 | issue_to_patch | feat: add qwen-mt | 4eed23c8bd71611e3b8d451cc534eb25caa77906 | 74d84c1a7fdfab18ec4d458a7470ea9ece6b2eb0 | diff --git a/Directory.Build.props b/Directory.Build.props
index 64537a18..b5a56b58 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -4,5 +4,6 @@
<ImplicitUsings>enable</ImplicitUsings>
<EnableWindowsTargeting>true</EnableWindowsTargeting>
<RepositoryUrl>https://github.com/ZGGSONG/STranslat... | [
"Directory.Build.props",
"src/STranslate.Host/Cargo.lock",
"src/STranslate.Host/Cargo.toml",
"src/STranslate.Host/src/main.rs",
"src/STranslate.Model/Constant.cs",
"src/STranslate.Model/Enums.cs",
"src/STranslate.Model/Term.cs",
"src/STranslate.Style/AssemblyInfo.cs",
"src/STranslate.Style/Controls/... | [] | true | |||
STranslate/STranslate | 462 | issue_to_patch | feat: Optimized start-up procedure | #455 | 52e8242803909fc8d4553df82d5bef57e4e5e3ef | fe575077f7d39766c621f988b5b13018c411486d | diff --git a/src/STranslate.Updater/Cargo.lock b/src/STranslate.Host/Cargo.lock
similarity index 54%
rename from src/STranslate.Updater/Cargo.lock
rename to src/STranslate.Host/Cargo.lock
index f0783f3b..916cdc23 100644
--- a/src/STranslate.Updater/Cargo.lock
+++ b/src/STranslate.Host/Cargo.lock
@@ -20,14 +20,82 @@ dep... | [
"src/STranslate.Host/Cargo.lock",
"src/STranslate.Host/Cargo.toml",
"src/STranslate.Host/src/main.rs",
"src/STranslate.Model/ConfigModel.cs",
"src/STranslate.Model/Constant.cs",
"src/STranslate.Model/Enums.cs",
"src/STranslate.Style/Styles/Localizations/Language.en-US.xaml",
"src/STranslate.Style/Styl... | [] | true | ||
STranslate/STranslate | 460 | issue_to_patch | feat: Add title and hint word configuration endpoints. | #418 | 31eb5968224489bab5939931a833e9e6e2adbb41 | 48b14e68fd35442d4dc1fab8e5765d9951c8e390 | diff --git a/src/STranslate.Model/ConfigModel.cs b/src/STranslate.Model/ConfigModel.cs
index c8621a12..de00f58a 100644
--- a/src/STranslate.Model/ConfigModel.cs
+++ b/src/STranslate.Model/ConfigModel.cs
@@ -459,6 +459,16 @@ public class ConfigModel
/// </summary>
public int HttpTimeout { get; set; } = 10;
+... | [
"src/STranslate.Model/ConfigModel.cs",
"src/STranslate.Style/Styles/Localizations/Language.en-US.xaml",
"src/STranslate.Style/Styles/Localizations/Language.zh-Hans-CN.xaml",
"src/STranslate.Style/Styles/Localizations/Language.zh-Hant-TW.xaml",
"src/STranslate/Helper/ConfigHelper.cs",
"src/STranslate/ViewM... | [] | true | ||
STranslate/STranslate | 459 | issue_to_patch | feat: adapt maimemo | #458 | 36be54053d7e7414704bc7e2c64189bfaa6af20f | 1817315d0f221b6da9da1fb30f8537f3bb77c2af | diff --git a/src/STranslate.Model/Enums.cs b/src/STranslate.Model/Enums.cs
index 70b6025c..1edcf50f 100644
--- a/src/STranslate.Model/Enums.cs
+++ b/src/STranslate.Model/Enums.cs
@@ -225,6 +225,11 @@ public enum VocabularyBookType
/// 欧陆词典
/// </summary>
EuDictVocabularyBook,
+
+ /// <summary>
+ ... | [
"src/STranslate.Model/Enums.cs",
"src/STranslate.Style/Resources/maimemo.png",
"src/STranslate.Style/STranslate.Style.csproj",
"src/STranslate.Style/Styles/IconStyle.xaml",
"src/STranslate.Style/Styles/Localizations/Language.en-US.xaml",
"src/STranslate.Style/Styles/Localizations/Language.zh-Hans-CN.xaml"... | [] | true | ||
STranslate/STranslate | 457 | issue_to_patch | feat: adapting openrouter | #450 | 773c99df3957d32736d989b99e19efe9aed3b460 | 65c367cdca7497942409ff2c5683cf5ea007b7ea | diff --git a/src/STranslate.Model/Enums.cs b/src/STranslate.Model/Enums.cs
index 1cf5d4f6..70b6025c 100644
--- a/src/STranslate.Model/Enums.cs
+++ b/src/STranslate.Model/Enums.cs
@@ -208,6 +208,7 @@ public enum ServiceType
YandexBuiltInService,
DeerAPIService,
TransmartBuiltInService,
+ OpenRouterServ... | [
"src/STranslate.Model/Enums.cs",
"src/STranslate.Style/Resources/openrouter.png",
"src/STranslate.Style/STranslate.Style.csproj",
"src/STranslate.Style/Styles/IconStyle.xaml",
"src/STranslate.Style/Styles/Localizations/Language.en-US.xaml",
"src/STranslate.Style/Styles/Localizations/Language.zh-Hans-CN.xa... | [] | true | ||
STranslate/STranslate | 443 | issue_to_patch | feat: 修复保存服务配置页面保存撤销等问题 | 5e19a7a016915906ab5835db70810e74d80a3e85 | c91ec91580ddef4afbe846f9d1445dbc59703449 | diff --git a/src/STranslate/ViewModels/Preference/OCRScvViewModel.cs b/src/STranslate/ViewModels/Preference/OCRScvViewModel.cs
index 68106866..5283a040 100644
--- a/src/STranslate/ViewModels/Preference/OCRScvViewModel.cs
+++ b/src/STranslate/ViewModels/Preference/OCRScvViewModel.cs
@@ -231,7 +231,7 @@ private void Dele... | [
"src/STranslate/ViewModels/Preference/OCRScvViewModel.cs",
"src/STranslate/ViewModels/Preference/ReplaceViewModel.cs",
"src/STranslate/ViewModels/Preference/TTSViewModel.cs",
"src/STranslate/ViewModels/Preference/TranslatorViewModel.cs",
"src/STranslate/ViewModels/Preference/VocabularyBookViewModel.cs",
"... | [] | true | |||
STranslate/STranslate | 428 | issue_to_patch | fix: the initial launch of the program did not use the set timeout time | c5ac8b26177e11798b85f936f83031386668e3a0 | 13a318a707e356edd62abe3914fae96de36324d4 | diff --git a/src/STranslate/Helper/ConfigHelper.cs b/src/STranslate/Helper/ConfigHelper.cs
index fa074e30..111b9cd2 100644
--- a/src/STranslate/Helper/ConfigHelper.cs
+++ b/src/STranslate/Helper/ConfigHelper.cs
@@ -137,6 +137,9 @@ public void InitialOperate()
//初始化隐藏输入界面
ShowLangViewOnShowRetOperate(C... | [
"src/STranslate/Helper/ConfigHelper.cs"
] | [] | true | |||
STranslate/STranslate | 408 | issue_to_patch | update-casing-CleanOcr.bat | The build fails in linux because Linux is case-sensitive and Windows is not | 0ec3ced8599009fb243776db776afd937d996b49 | 6815a72266b3ed4dc54892b8c4410dd86bd5df9e | diff --git a/src/STranslate/STranslate.csproj b/src/STranslate/STranslate.csproj
index 1792be68..6f4538e4 100644
--- a/src/STranslate/STranslate.csproj
+++ b/src/STranslate/STranslate.csproj
@@ -42,7 +42,7 @@
<Content Include="z_uninstall.bat">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</Co... | [
"src/STranslate/STranslate.csproj"
] | [] | true | ||
STranslate/STranslate | 304 | issue_to_patch | feat: installer builder from MicaSetup | #80
使用MicaSetup打包成exe安装包 (MicaSetup >= 2.3.5)
https://github.com/lemutec/MicaSetup/releases
安装MicaSetup后运行`installer.ps1`片刻后输出`STranslateSetup_v1.3.0.107_win64.exe`
| 2d46af558a7b32423e2dbbda86be823f6b532edc | f2dcc5986ad63c6a44e4927235029c7a9ddc96fe | diff --git a/.gitignore b/.gitignore
index f9705ab7..100c59d8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,6 +3,7 @@ bin/
obj/
*.user
.idea/
+.dist/
packages/
diff --git a/img/favicon.png b/img/favicon.png
new file mode 100644
index 00000000..f19070d3
Binary files /dev/null and b/img/favicon.png differ
diff -... | [
".gitignore",
"img/favicon.png",
"img/setup.png",
"img/uninst.png",
"installer.ps1",
"micasetup.json"
] | [] | true | ||
STranslate/STranslate | 289 | issue_to_patch | feat: Add a switch to clipboard insertion results | Metaphysics Solution to #131 | 5fc1ffddd9cee0bce7f69558655e51b5f947da4a | 34a4fe8b4a6c3f233a4643cd05d2dc3ed89786ca | diff --git a/src/STranslate.Model/ConfigModel.cs b/src/STranslate.Model/ConfigModel.cs
index 67f182db..38bada7a 100644
--- a/src/STranslate.Model/ConfigModel.cs
+++ b/src/STranslate.Model/ConfigModel.cs
@@ -441,6 +441,11 @@ public class ConfigModel
/// </summary>
public LangEnum TargetLangIfSourceNotZh { get;... | [
"src/STranslate.Model/ConfigModel.cs",
"src/STranslate/Helper/ConfigHelper.cs",
"src/STranslate/Helper/InputSimulatorHelper.cs",
"src/STranslate/ViewModels/Preference/CommonViewModel.cs",
"src/STranslate/Views/Preference/CommonPage.xaml"
] | [] | true | ||
STranslate/STranslate | 266 | issue_to_patch | fix: #265 在 rider 或者其他软件编辑框中划词会缺少 | #265 在 rider 或者其他软件编辑框中划词会缺少 | de6dd50768a5fc29c8a431b0a7ac1442a75c4820 | fffdf46ce1b119e08b547853ddf5a2b3ffdff056 | diff --git a/src/STranslate.Util/ClipboardUtil.cs b/src/STranslate.Util/ClipboardUtil.cs
index ca46b52a..0167f99e 100644
--- a/src/STranslate.Util/ClipboardUtil.cs
+++ b/src/STranslate.Util/ClipboardUtil.cs
@@ -7,6 +7,30 @@ namespace STranslate.Util;
public static class ClipboardUtil
{
+ # region Const
+ priv... | [
"src/STranslate.Util/ClipboardUtil.cs"
] | [] | true | ||
STranslate/STranslate | 220 | issue_to_patch | implement the feature mentioned in #217 | * As a newcomer to C#, I've implemented this text-to-speech feature.
* Referenced the existing shortcut key logic for implementation.
* Functionality: Select text, press shortcut key, text is read aloud.
* Local testing confirms correct operation.
* Please don't hesitate to reach out on GitHub if any issues arise. | 09a3225f08a54f9153ee55f8f824380b8028a4d5 | 8acd5e62efdadebae281d3e4a987a7add902c7df | diff --git a/Backup/STranslate.sln b/Backup/STranslate.sln
new file mode 100644
index 00000000..84d34fe4
--- /dev/null
+++ b/Backup/STranslate.sln
@@ -0,0 +1,91 @@
+
+Microsoft Visual Studio Solution File, Format Version 12.00
+# Visual Studio Version 17
+VisualStudioVersion = 17.7.34024.191
+MinimumVisualStudioVersio... | [
"Backup/STranslate.sln",
"UpgradeLog.htm",
"src/STranslate.Model/Constant.cs",
"src/STranslate.Model/Enums.cs",
"src/STranslate.Model/Hotkeys.cs",
"src/STranslate/Helper/ConfigHelper.cs",
"src/STranslate/Helper/HotkeyHelper.cs",
"src/STranslate/ViewModels/MainViewModel.cs",
"src/STranslate/ViewModel... | [] | true | ||
STranslate/STranslate | 218 | issue_to_patch | 增加启动时不显示通知的开关 | 在 `常规设置-显示配置` 中增加 `启动时不显示通知` 开关，控制启动时是否显示系统通知 | 6f418dd526bd87ede2a7795c78f9f28a5406c9c4 | dc97599e66c79866a6ae316df266c6becd3cf9e0 | diff --git a/src/STranslate.Model/ConfigModel.cs b/src/STranslate.Model/ConfigModel.cs
index 7b394451..e4d44928 100644
--- a/src/STranslate.Model/ConfigModel.cs
+++ b/src/STranslate.Model/ConfigModel.cs
@@ -153,6 +153,11 @@ public class ConfigModel
/// </summary>
public bool IsHideOnStart { get; set; }
+ ... | [
"src/STranslate.Model/ConfigModel.cs",
"src/STranslate/Helper/ConfigHelper.cs",
"src/STranslate/ViewModels/Preference/CommonViewModel.cs",
"src/STranslate/Views/MainView.xaml.cs",
"src/STranslate/Views/Preference/CommonPage.xaml"
] | [] | true | ||
STranslate/STranslate | 119 | issue_to_patch | update: full size icon | https://github.com/ZGGSONG/STranslate/issues/118 | d557f17751e0c2c3317ef97e7dd98af70f75735a | e79b599a94d3baf1672c28582403f12929c0a0ab | diff --git a/src/STranslate.Style/Resources/favicon.ico b/src/STranslate.Style/Resources/favicon.ico
index 37cd4bbc..74fe8085 100644
Binary files a/src/STranslate.Style/Resources/favicon.ico and b/src/STranslate.Style/Resources/favicon.ico differ
| [
"src/STranslate.Style/Resources/favicon.ico"
] | [] | true | ||
STranslate/STranslate | 5 | issue_to_patch | docs:add README_EN.md | e9d75e8c4fbb1158c53e963d8f31fd9dea3d1ee1 | 73869f31e69de6534095ff6812959ca603025444 | diff --git a/README.md b/README.md
index 48f7128f..32d88fe8 100644
--- a/README.md
+++ b/README.md
@@ -19,7 +19,10 @@
</p>
<h1 align="center">STranslate</h1>
-<p align="center">WPF 开发的一款<strong>即开即用</strong>、<strong>即用即走</strong>的翻译工具</p>
+<p align="center">WPF 开发的一款<strong>即开即用</strong>、<strong>即用即走</strong>的翻译工具
... | [
"README.md",
"README_EN.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 94 | issue_to_patch | Correct language of README.md | Correct sentence for proper English grammar.
| 3bc191f8d310b4ae65fcb0b6a82d4953dba5e590 | 6de975f85bbfc4ce31a5f3464d900d97bdee7b13 | diff --git a/README.md b/README.md
index ac4044e..cdf33c8 100644
--- a/README.md
+++ b/README.md
@@ -5,7 +5,7 @@ Online book about how to write a computer operating system in C/C++ from scratch
**Caution**: This repository is a remake of my old course. It was written several years ago [as one of my first projects wh... | [
"README.md"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 102 | issue_to_patch | Fixed some wording. | Changed the phrasing of some sentences/paragraphs, removed/added some words.
| d14cd7368136687e94ad0e1b9d49c383d6bc864b | 11f048e711510105c33e6f75f80ac9c264e629ae | diff --git a/Chapter-3/README.md b/Chapter-3/README.md
index d659d4c..07ae526 100644
--- a/Chapter-3/README.md
+++ b/Chapter-3/README.md
@@ -8,11 +8,11 @@ The BIOS boot sequence is: RAM detection -> Hardware detection/Initialization ->
The most important step for us is the "Boot sequence", where the BIOS is done wit... | [
"Chapter-3/README.md",
"Chapter-4/README.md"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 101 | issue_to_patch | Fixed some typos | d14cd7368136687e94ad0e1b9d49c383d6bc864b | 6a9e13014873e2ffe996388630061146c6c0c441 | diff --git a/src/kernel/arch/x86/architecture.h b/src/kernel/arch/x86/architecture.h
index ba7928b..49cd9b8 100644
--- a/src/kernel/arch/x86/architecture.h
+++ b/src/kernel/arch/x86/architecture.h
@@ -23,16 +23,16 @@ class Architecture
void setParam(u32 ret,u32 ret1,u32 ret2, u32 ret3,u32 ret4); /* set the syscall ... | [
"src/kernel/arch/x86/architecture.h"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 90 | issue_to_patch | Reworded a paragraph that included a typo | Corrected typo 'Vargrantfile' -> 'Vagrantfile' and reworded paragraph.
| 7a2ea63e2a4ad80f6af3e7676e23394ad681608a | 04bd0d26dea3ec8a9b0f1f6ce0c05cccdd7afaf3 | diff --git a/Chapter-2/README.md b/Chapter-2/README.md
index e993001..9902b37 100644
--- a/Chapter-2/README.md
+++ b/Chapter-2/README.md
@@ -37,7 +37,7 @@ You can now access your box by using ssh to connect to the virtual box using:
vagrant ssh
```
-Put any file into the same directory of Vargrantfile, it will be a... | [
"Chapter-2/README.md"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 87 | issue_to_patch | Fix gitbook link. | 6a68ae0c8bdc401962c7cc0f9b481dd93125c15d | a8840b5541d392e2b334e1971f8de2b17b9f116a | diff --git a/README.md b/README.md
index b71f574..ac4044e 100644
--- a/README.md
+++ b/README.md
@@ -5,7 +5,7 @@ Online book about how to write a computer operating system in C/C++ from scratch
**Caution**: This repository is a remake of my old course. It was written several years ago [as one of my first projects wh... | [
"README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 85 | issue_to_patch | fixed odd phrasing | 2d8c36ef33d17d3a415cf17b011b10e2e236647a | 510970971e686354c0d615540657af61e269d3af | diff --git a/Chapter-1/README.md b/Chapter-1/README.md
index 76658ad..df41755 100644
--- a/Chapter-1/README.md
+++ b/Chapter-1/README.md
@@ -32,4 +32,4 @@ The OS will be built for the x86 architecture, running on 32 bits, and compatibl
* Userland :
* API Posix
* LibC
- * "Can" run a shell or some executab... | [
"Chapter-1/README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 84 | issue_to_patch | Update README.md | cylinder to sector mistake corrected
| 4fb7c7906df49df472d3c55230b76114d31b32f5 | 9b6d3c8a9d4dd2d071dc6032e1a4e5c94abf5c73 | diff --git a/Chapter-3/README.md b/Chapter-3/README.md
index 7f5f4a2..d659d4c 100644
--- a/Chapter-3/README.md
+++ b/Chapter-3/README.md
@@ -112,10 +112,10 @@ fdisk ./c.img
# Choose partition number
> 1
-# Choose first cylinder (1-4, default 1)
+# Choose first sector (1-4, default 1)
> 1
-# Choose last cylinder,... | [
"Chapter-3/README.md"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 79 | issue_to_patch | Changing "defien" to "define" | A small typo correction
| 278a50128c6642c2e7e6008a6c41ab280a0501c3 | a051d0104df5ef5c5ea5b0bde5d5d34c185eb0a9 | diff --git a/src/kernel/config.h b/src/kernel/config.h
index 590f202..a767e59 100644
--- a/src/kernel/config.h
+++ b/src/kernel/config.h
@@ -12,7 +12,7 @@
#ifdef __x86__
#define KERNEL_PROCESSOR_IDENTIFIER "x86"
#else
-#defien KERNEL_PROCESSOR_IDENTIFIER "(null)"
+#define KERNEL_PROCESSOR_IDENTIFIER "(null)"
#endif... | [
"src/kernel/config.h"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 76 | issue_to_patch | Explains /vagrant more detailed | I needed to google around to understand the usage of /vagrant and where it is when I first read this. So I think it's a good idea to explain it a little bit more in detail.
| b5d314d640743c27251c15e18493ce4eca7a365c | a124d7db6903f0e6d41e51c9c780ee8488db9fa9 | diff --git a/Chapter-2/README.md b/Chapter-2/README.md
index 0334a89..bea5c6a 100644
--- a/Chapter-2/README.md
+++ b/Chapter-2/README.md
@@ -37,7 +37,7 @@ You can now access your box by using ssh to connect to the virtual box using:
vagrant ssh
```
-The code will be available in the */vagrant* directory:
+Put any f... | [
"Chapter-2/README.md"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 69 | issue_to_patch | modtify May not run correctly place | The emergence of the following result according to the book's step operation make run
vagrant@lucid32:/vagrant$ make run
Running Dev Operating System.
cd ./sdk && sudo ./diskimage.sh
sudo: ./diskimage.sh: command not found
make: **\* [run] Error 1
so I add bash in the front of ./diskimage.sh Because when creating disk... | b9c333903610460e912bc8dc88b6d93b6b35bf28 | c213d3abff31cb8f0aafbd1a54d8efde58158bd1 | diff --git a/src/Makefile b/src/Makefile
index b550907..a2f9073 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -21,7 +21,7 @@ build:
run:
@echo "Running Dev Operating System."
- cd ./sdk && sudo ./diskimage.sh
+ cd ./sdk && sudo bash ./diskimage.sh
cd ./sdk && ./qemu.sh
clean:
| [
"src/Makefile"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 52 | issue_to_patch | Fixed typo about boot signature and sectors 511 and 512 | Statement "signature bytes `0x55` and `0xAA` at _sectors_ 511 and 512 respectively." isn't correct. There should be "offsets" instead of "sectors", because signature belongs only to first (mbr) sector, not to 511th and 512th sectors.
| 04bc828faa4a3cd39439f908159d1e85664f51f7 | dc8c81c08fb51311249b25d5139e294178e539d5 | diff --git a/Chapter-3/README.md b/Chapter-3/README.md
index ab0f00d..94fbb58 100644
--- a/Chapter-3/README.md
+++ b/Chapter-3/README.md
@@ -8,7 +8,7 @@ The BIOS boot sequence is: RAM detection -> Hardware detection/Initialization ->
The most important step for us is the "Boot sequence", where the BIOS is done with ... | [
"Chapter-3/README.md"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 10 | issue_to_patch | typo | 54b3ceee543656ac785d417e36dea54c4bba0fab | 2ac1315e4ab71689fd22f227c5bcb76bc137e87e | diff --git a/Chapter-3/README.md b/Chapter-3/README.md
index 8f01830..7423a9d 100644
--- a/Chapter-3/README.md
+++ b/Chapter-3/README.md
@@ -29,7 +29,7 @@ To make it simple, GRUB is the first thing booted by the machine (a boot-loader)
#### How to use GRUB?
-GRUB use the Multiboot specification, the executable bin... | [
"Chapter-3/README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 51 | issue_to_patch | Typo
Mis-calculation of the number of cytes for the loop-device partition in Chapter 3. PR coming. | Update Chapter 3 README | Fixed a mis-calculation typo for the number of bytes required in the fdisk command (loop-device partition). Fixes #50.
| 04bc828faa4a3cd39439f908159d1e85664f51f7 | 8fd38fecb066c827249b412b447c5060ad567891 | diff --git a/Chapter-3/README.md b/Chapter-3/README.md
index ab0f00d..51b153f 100644
--- a/Chapter-3/README.md
+++ b/Chapter-3/README.md
@@ -130,7 +130,7 @@ fdisk ./c.img
We need now to attach the created partition to the loop-device (which allows a file to be access like a block device) using losetup. The offset of... | [
"Chapter-3/README.md"
] | [] | true | |
SamyPesse/How-to-Make-a-Computer-Operating-System | 20 | issue_to_patch | Grammar changes | e3806a3c57e6b327c21d25772b2a663b59c1ac73 | f26d612cf7a34ebb73f799ab085f62ed1e5379a9 | diff --git a/Chapter-2/README.md b/Chapter-2/README.md
index e87022b..8bfa430 100644
--- a/Chapter-2/README.md
+++ b/Chapter-2/README.md
@@ -6,7 +6,7 @@ The first step is to setup a good and viable development environment. Using Vagr
> Vagrant is free and open-source software for creating and configuring virtual dev... | [
"Chapter-2/README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 35 | issue_to_patch | Typo: access -> accessed | b539cf4db79808afad4bcbd57d87864d46fe1936 | e5ef8d141b84fdaa067441bfdb52da64dfc1c7f1 | diff --git a/Chapter-5/README.md b/Chapter-5/README.md
index 8917970..c41ef57 100644
--- a/Chapter-5/README.md
+++ b/Chapter-5/README.md
@@ -4,7 +4,7 @@ Now that we know how to compile our C++ kernel and boot the binary using GRUB, w
#### Printing to the screen console
-We are going to use VGA default mode (03h) t... | [
"Chapter-5/README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 22 | issue_to_patch | Spelling fixes. | 66fc492be62e404a71c418c7eb8d22793dd99900 | 94b12b757acec322bf2c32fdb2554560e79edc88 | diff --git a/Chapter-1/README.md b/Chapter-1/README.md
index 5e34e50..76658ad 100644
--- a/Chapter-1/README.md
+++ b/Chapter-1/README.md
@@ -32,4 +32,4 @@ The OS will be built for the x86 architecture, running on 32 bits, and compatibl
* Userland :
* API Posix
* LibC
- * "Can" run a shell or some excutabl... | [
"Chapter-1/README.md",
"Chapter-3/README.md",
"Chapter-5/README.md",
"Chapter-6/README.md",
"Chapter-7/README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 21 | issue_to_patch | Typo: byte -> bit | b3e09f8a166e4f8d4a66260d8b5600b6fc55e8f2 | 8aa0ffc3d3287d691d7cafed483c75ab4a1cc465 | diff --git a/Chapter-4/README.md b/Chapter-4/README.md
index bb220f1..12b8fab 100644
--- a/Chapter-4/README.md
+++ b/Chapter-4/README.md
@@ -30,7 +30,7 @@ These functions are defined in [string.cc](https://github.com/SamyPesse/How-to-M
#### C types
-During the next step, we are going to use different types in our ... | [
"Chapter-4/README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 32 | issue_to_patch | Some changes in Chapter 3 | Thanks for your work with this repo. It's fascinating.
I made some small modifications to the text in Chapter 3.
| df25c7fabeea6f7884777f53afb89d6ddad0ad1b | 60f21171333c8e369eac7070fa823ba9ce6767f8 | diff --git a/Chapter-3/README.md b/Chapter-3/README.md
index 6b071e2..18bd2dd 100644
--- a/Chapter-3/README.md
+++ b/Chapter-3/README.md
@@ -2,13 +2,13 @@
#### How the boot works?
-When an x86-based computer is turned on, it begins a complex path to get to the stage where control is transferred to our kernel's "ma... | [
"Chapter-3/README.md"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 19 | issue_to_patch | grammar changes for README.md | e3806a3c57e6b327c21d25772b2a663b59c1ac73 | 733d36dc1396de0a7fb258167681650ec14edbf0 | diff --git a/Chapter-1/README.md b/Chapter-1/README.md
index aa62191..5e34e50 100644
--- a/Chapter-1/README.md
+++ b/Chapter-1/README.md
@@ -1,18 +1,18 @@
-## Chapter 1: Introduction about the x86 architecture and about our OS
+## Chapter 1: Introduction to the x86 architecture and about our OS
### What is the x86 a... | [
"Chapter-1/README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 37 | issue_to_patch | Explain putc() special characters | 7cd6dd0b1958b4381f7a9f28aa4833e7b21c5739 | 026c3bdfb432e3180092821d3ec2fdb5624b1a1b | diff --git a/Chapter-5/README.md b/Chapter-5/README.md
index c41ef57..8a697ed 100644
--- a/Chapter-5/README.md
+++ b/Chapter-5/README.md
@@ -20,17 +20,21 @@ void Io::putc(char c){
kattr = 0x07;
unsigned char *video;
video = (unsigned char *) (real_screen+ 2 * x + 160 * y);
- if (c == 10) {
+ // newline
+ if (c... | [
"Chapter-5/README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 45 | issue_to_patch | Added detail on the BIOS boot process | In Chapter 3 I've added some further detail surrounding the transfer of
control from BIOS to the bootsector code.
| 05b5913123839990909aac8d8399b38f04027a6a | b002b7ef109270e3167818d7e5351525f821b688 | diff --git a/Chapter-3/README.md b/Chapter-3/README.md
index 6e809b9..c6aa1da 100644
--- a/Chapter-3/README.md
+++ b/Chapter-3/README.md
@@ -2,17 +2,17 @@
#### How the boot works?
-When an x86-based computer is turned on, it begins a complex path to get to the stage where control is transferred to our kernel's "ma... | [
"Chapter-3/README.md"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 30 | issue_to_patch | Spelling fixes. | Spelling fixes in Chapter 2.
| df25c7fabeea6f7884777f53afb89d6ddad0ad1b | cb746d048a8a1f0397da8511c77d4c2fd559a11c | diff --git a/Chapter-2/README.md b/Chapter-2/README.md
index 211db06..11c45ef 100644
--- a/Chapter-2/README.md
+++ b/Chapter-2/README.md
@@ -59,7 +59,7 @@ Test our operating system with qemu:
make run
```
-The documentation for quemu is available at [QUEMU Emulator Documentation](http://wiki.qemu.org/download/qemu-... | [
"Chapter-2/README.md"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 41 | issue_to_patch | Added next/previous links to all chapters | You can view the links [here](https://github.com/bbaugher/How-to-Make-a-Computer-Operating-System).
| a56a6a8b67e98bc626b41c912117b1b6699554a0 | e24b375eb0a4cf8a1b9af70312ebb091cfa63201 | diff --git a/Chapter-1/README.md b/Chapter-1/README.md
index 76658ad..e7e9e28 100644
--- a/Chapter-1/README.md
+++ b/Chapter-1/README.md
@@ -33,3 +33,5 @@ The OS will be built for the x86 architecture, running on 32 bits, and compatibl
* API Posix
* LibC
* "Can" run a shell or some executables like Lua, ... | [
"Chapter-1/README.md",
"Chapter-2/README.md",
"Chapter-3/README.md",
"Chapter-4/README.md",
"Chapter-5/README.md",
"Chapter-6/README.md",
"Chapter-7/README.md"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 36 | issue_to_patch | Typo: base->lucid32 | the box name 'base' is different from 'lucid32' in Vagrantfile, which causes download box twice, one time for 'vagrant add box' another time for 'vagrant up'
| b539cf4db79808afad4bcbd57d87864d46fe1936 | 226cd9c90d2124b7fe5724d6d279e90ebe276328 | diff --git a/Chapter-2/README.md b/Chapter-2/README.md
index 11c45ef..5a58292 100644
--- a/Chapter-2/README.md
+++ b/Chapter-2/README.md
@@ -20,7 +20,7 @@ Vagrant needs Virtualbox to work, Download and install for your system at https:
Once Vagrant and Virtualbox are installed, you need to download the ubuntu lucid32 ... | [
"Chapter-2/README.md"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 13 | issue_to_patch | Typo fix | Typical useless PR :-)
| 6730970b70710d5b10c1da4122a0e66c08dc5069 | d490811d62c285a58ed4b5a504c5eea12dc887bc | diff --git a/Chapter-3/README.md b/Chapter-3/README.md
index 7423a9d..aab2353 100644
--- a/Chapter-3/README.md
+++ b/Chapter-3/README.md
@@ -128,7 +128,7 @@ fdisk ./c.img
> w
```
-We need now to atach the created partition to loop-device (which allow a file to be access like a block device) using losetup. The offse... | [
"Chapter-3/README.md"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 31 | issue_to_patch | README.md: Correcting punctuation | df25c7fabeea6f7884777f53afb89d6ddad0ad1b | b635293ef5970587d6315335da9d42c60fb6f6be | diff --git a/README.md b/README.md
index 91998d0..e633126 100644
--- a/README.md
+++ b/README.md
@@ -13,7 +13,7 @@ You can follow me on Twitter [@SamyPesse](https://twitter.com/SamyPesse) or supp
### What kind of OS are we building?
-The goal is to build a very simple UNIX-based operating system in C++, not just a... | [
"README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 55 | issue_to_patch | Update README.md | correct typo
| b7070c0ecd7b173cef7b1c6498ca82e0ab7dd397 | 1c027ce965f4a81c57897e584dda22b1b59316c6 | diff --git a/Chapter-3/README.md b/Chapter-3/README.md
index 7ad591d..6318ef2 100644
--- a/Chapter-3/README.md
+++ b/Chapter-3/README.md
@@ -72,7 +72,7 @@ You can use the command ```mbchk kernel.elf``` to validate your kernel.elf file
#### Create a disk image for our kernel and grub
-The script [diskimage.sh](http... | [
"Chapter-3/README.md"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 54 | issue_to_patch | Fix typo in chapter 5 | 3c28feee17031f4126b413ce411ff9095b361d74 | e5791f4e409f99a887920c12cfeb49bbae2cbb51 | diff --git a/Chapter-5/README.md b/Chapter-5/README.md
index 8a697ed..b25adae 100644
--- a/Chapter-5/README.md
+++ b/Chapter-5/README.md
@@ -159,7 +159,7 @@ A large number of instructions are available in Assembly but there is not equiva
In C, we can include Assembly using the directive "asm()", gcc use gas to compi... | [
"Chapter-5/README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 57 | issue_to_patch | Correct grammar and spelling | Only for Chapter 7
| c6a7b518726301c42d18f393f6462bea50943ffb | d7d0916475f49e956ab39382fd535b4cb484e076 | diff --git a/Chapter-7/README.md b/Chapter-7/README.md
index 0a4c3ab..faf8ccb 100644
--- a/Chapter-7/README.md
+++ b/Chapter-7/README.md
@@ -10,15 +10,15 @@ There are 3 types of interrupts:
#### The keyboard example:
-When the user pressed a key on the keyboard, the keyboard controller will signal an interrupt to ... | [
"Chapter-7/README.md"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 56 | issue_to_patch | Magic Bytes Explanation | Proposing a little more explanation of the signature (magic bytes) of MBR, and its representation's purpose in binary. It will help reader understand more that why values 0x55 and 0xAA are used for checking validity of boot loader.
| 3adb7e05df69ec9146afff184eec72091d7e1035 | 14c549ff987e5ae6d841dc47e1c57892cc28600c | diff --git a/Chapter-3/README.md b/Chapter-3/README.md
index 6318ef2..837249d 100644
--- a/Chapter-3/README.md
+++ b/Chapter-3/README.md
@@ -8,7 +8,7 @@ The BIOS boot sequence is: RAM detection -> Hardware detection/Initialization ->
The most important step for us is the "Boot sequence", where the BIOS is done with ... | [
"Chapter-3/README.md"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 18 | issue_to_patch | Various spelling and grammar changes | 8b0d74358e86b35379680f3e8afb1fe4bf3e64b2 | 99624590d9ea30e3a31ba4f37b2f19ddfa299454 | diff --git a/Chapter-1/README.md b/Chapter-1/README.md
index dabc697..aa62191 100644
--- a/Chapter-1/README.md
+++ b/Chapter-1/README.md
@@ -10,14 +10,14 @@ In this course we are not going to design an operating system for x86-64 archite
### Our Operating System
-The goal is to build a very simple UNIX-based opera... | [
"Chapter-1/README.md",
"Chapter-3/README.md",
"Chapter-4/README.md",
"Chapter-5/README.md",
"Chapter-6/README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 49 | issue_to_patch | Chapter 8: Fix typo. | 3e7b6e6fe27b6648a5cca82c25457202abe7c6d7 | f829113a5e591a05cf1d11c4dea45fe9388b3098 | diff --git a/Chapter-8/README.md b/Chapter-8/README.md
index 6a4c356..eb88d7e 100644
--- a/Chapter-8/README.md
+++ b/Chapter-8/README.md
@@ -12,7 +12,7 @@ Paging will allow our kernel to:
* to have a unique memory space for each process
* to allow and unallow memory space in a dynamic way
-In a paged system, each p... | [
"Chapter-8/README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 40 | issue_to_patch | Chapter-6/README.md: minor typo | 487ed1caf7f0d19caa7d6ac88165a8722cfc5c2d | 08a20dd182e3717c75dbbfc06f1c6aaa4fb06848 | diff --git a/Chapter-6/README.md b/Chapter-6/README.md
index f1c93a0..ae4a8e1 100644
--- a/Chapter-6/README.md
+++ b/Chapter-6/README.md
@@ -4,7 +4,7 @@ Thanks to GRUB, your kernel is no longer in real-mode, but already in [protected
#### What is the GDT?
-The [GDT](http://en.wikipedia.org/wiki/Global_Descriptor_T... | [
"Chapter-6/README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 4 | issue_to_patch | typos | 500be2b6dea636cc1fab69570727e7fd05a26069 | 316a2e8d29cb33c2621b03bde254cc17c807b125 | diff --git a/Chapter-1/README.md b/Chapter-1/README.md
index a0c9d11..dabc697 100644
--- a/Chapter-1/README.md
+++ b/Chapter-1/README.md
@@ -4,7 +4,7 @@
> The term x86 denotes a family of backward compatible instruction set architectures based on the Intel 8086 CPU.
-The x86 arhictacture is most common instruction... | [
"Chapter-1/README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 27 | issue_to_patch | Install zip by default,in order to run `make build`. | c56072b8939562efa29887cbefe843271987636a | 89158cbf94cf5a05cfeec085a52e3c41b51b2531 | diff --git a/src/Vagrantfile b/src/Vagrantfile
index 3da3057..046ab4c 100644
--- a/src/Vagrantfile
+++ b/src/Vagrantfile
@@ -95,7 +95,7 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
$script = %Q{
sudo apt-get update
- sudo apt-get install nasm make build-essential grub qemu -y
+ sudo apt-get... | [
"src/Vagrantfile"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 17 | issue_to_patch | fix typo - floopy => floppy | f08bc5bd030e8ceafa901f6571f0518dfb3a20c1 | 431b1a942a75822f23db67d218222f079603054e | diff --git a/Chapter-3/README.md b/Chapter-3/README.md
index 49a8d06..aba6177 100644
--- a/Chapter-3/README.md
+++ b/Chapter-3/README.md
@@ -8,7 +8,7 @@ The BIOS boot sequence is: RAM detection -> Hardware detection/Initialization ->
The step important for us is the "Boot sequence", when the BIOS is done with its in... | [
"Chapter-3/README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 15 | issue_to_patch | Various typo fixes | 6730970b70710d5b10c1da4122a0e66c08dc5069 | 9e340f83cc58ad03a2a0f9f54fa33fd8e1f42923 | diff --git a/Chapter-4/README.md b/Chapter-4/README.md
index a0c2029..0ebaade 100644
--- a/Chapter-4/README.md
+++ b/Chapter-4/README.md
@@ -8,11 +8,11 @@ The compiler will assume that all the C++ runtime support is available by defaul
Our basic C++ runtime can be found in the [cxx.cc](https://github.com/SamyPesse/H... | [
"Chapter-4/README.md",
"README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 9 | issue_to_patch | Fixed typo | fee8d8360d26df12afde78efc8339190c1334ac0 | 664c0fe005e44dbc748e25e12e8e7b3eeccd17a2 | diff --git a/Chapter-4/README.md b/Chapter-4/README.md
index 45a1e39..a0c2029 100644
--- a/Chapter-4/README.md
+++ b/Chapter-4/README.md
@@ -6,7 +6,7 @@ A kernel can be programmed in C++, it is very similar to making a kernel in C, e
The compiler will assume that all the C++ runtime support is available by default, ... | [
"Chapter-4/README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 7 | issue_to_patch | Fixes for a couple spelling mistakes in the READMEs | 4faaba9a28383ec2754d24944473ea3368b7663a | ba21f4cd6a59181fd1a8d2548ff3e28043a1281d | diff --git a/Chapter-2/README.md b/Chapter-2/README.md
index 6634eb4..6186186 100644
--- a/Chapter-2/README.md
+++ b/Chapter-2/README.md
@@ -25,7 +25,7 @@ Once Vagrant and Virtualbox are installed, you need to download the ubuntu lucid
vagrant box add base http://files.vagrantup.com/lucid32.box
```
-Once the lucid3... | [
"Chapter-2/README.md",
"Chapter-5/README.md"
] | [] | true | |||
SamyPesse/How-to-Make-a-Computer-Operating-System | 6 | issue_to_patch | Fixing verb tense | Changed 'valid' to 'validate'
| 282684ec8ce993c7b808600d4da357d106e60c0e | e14d57d9352486d1886120ba1fcfc3cbf2cac84d | diff --git a/Chapter-3/README.md b/Chapter-3/README.md
index 593c33a..8f01830 100644
--- a/Chapter-3/README.md
+++ b/Chapter-3/README.md
@@ -68,7 +68,7 @@ struct multiboot_info {
};
```
-You can use the command ```mbchk kernel.elf``` to valid your kernel.elf file with the multiboot standard. You also use the comman... | [
"Chapter-3/README.md"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 5 | issue_to_patch | Fixed misspelling of load | Replaced 'laod' with 'load'
| 1ed020858a0792e7022dfba68edd88e027f1fa52 | 8556ba031536bbc1cfb560aafac75b1ea7156fcc | diff --git a/Chapter-3/README.md b/Chapter-3/README.md
index f9e4d0a..593c33a 100644
--- a/Chapter-3/README.md
+++ b/Chapter-3/README.md
@@ -25,7 +25,7 @@ To make it simple, GRUB is the first thing booted by the machine (a boot-loader)
* GRUB is very simple to use
* Make it very simple to load 32bits kernels without ... | [
"Chapter-3/README.md"
] | [] | true | ||
SamyPesse/How-to-Make-a-Computer-Operating-System | 1 | issue_to_patch | Fix a few capitalizations, and grammars. | 8a9755b1664d72d473735a06ed39b3baf06fee34 | 263cd377a5bdb0ceb1393afa300cc9539fba6025 | diff --git a/README.md b/README.md
index 1ea0966..342df5a 100644
--- a/README.md
+++ b/README.md
@@ -1,13 +1,13 @@
How to Make a Computer Operating System
=======================================
-**Caution**: This repository is a remake of my old course. It was written several years ago [as one of my first projects... | [
"README.md"
] | [] | true | |||
SaturnFramework/Saturn | 386 | issue_to_patch | Use char-based override instead of string in EndsWith | Tiny code clean-up.
Fix for CA1865-1867: https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1865-ca1867 | 4bf73d17979b126db68d15ecd7d991a9620bbd94 | 4d027ea3d1711c7e2b106daa519eb6487b88f641 | diff --git a/src/Saturn/Controller.fs b/src/Saturn/Controller.fs
index c3322cd..d941714 100644
--- a/src/Saturn/Controller.fs
+++ b/src/Saturn/Controller.fs
@@ -230,7 +230,7 @@ module Controller =
x.FormattedRouteFunc state (PrintfFormat<_,_,_,_,'Key * string> (route + "/%s")) (fst >> actionHandler)
... | [
"src/Saturn/Controller.fs",
"src/Saturn/ControllerEndpoint.fs"
] | [] | true | ||
SaturnFramework/Saturn | 381 | issue_to_patch | acceptJson throws MissingMethodException
On .NET8 and having upgraded Saturn to 0.16.1 and Giraffe to 6.3.0 I get:
> System.MissingMethodException: Method not found: 'System.Threading.Tasks.Task`1<Microsoft.FSharp.Core.FSharpOption`1<Microsoft.AspNetCore.Http.HttpContext>> Giraffe.Core.mustAccept(Microsoft.FSharp.Col... | bump Giraffe dependency to 6.4 | This PR fixes #380
Tested by referencing my local build of Saturn instead of the nuget package. | 8511856ba3121aad62902ccc9571b7976146198f | faeb3933c8724faae816353e705766715f0e0c77 | diff --git a/paket.lock b/paket.lock
index 31398fb..f7b88ee 100644
--- a/paket.lock
+++ b/paket.lock
@@ -38,13 +38,12 @@ NUGET
FSharp.Core (>= 4.3.4)
Microsoft.IO.RecyclableMemoryStream (>= 1.2.2)
FSharp.Core (6.0.3)
- Giraffe (6.0)
- FSharp.Core (>= 6.0.1)
- Giraffe.ViewEngine (>= 1.3)
... | [
"paket.lock"
] | [] | true | |
SaturnFramework/Saturn | 378 | issue_to_patch | Reduced some dictionary double-lookups | Very minor performance optimisation. | dc62a7ec1dd2b51bbb12415bae2106392ce90018 | 0452bc653e6692aa534ff3043b523db06ab11b59 | diff --git a/src/Saturn/Common.fs b/src/Saturn/Common.fs
index e6894d71..a29b4228 100644
--- a/src/Saturn/Common.fs
+++ b/src/Saturn/Common.fs
@@ -37,9 +37,9 @@ module Common =
let private getSavedSubPath (ctx : HttpContext) =
let inline strOption (str : string) =
if String.IsNullOrEmpty str then None el... | [
"src/Saturn/Common.fs",
"src/Saturn/Controller.fs",
"src/Saturn/ControllerEndpoint.fs"
] | [] | true | ||
SaturnFramework/Saturn | 370 | issue_to_patch | Spell check sample application | Minor spelling error fix in code comments
Issue listed here #371 | d5a64d61210a4a165cfe696285877362ca3394c0 | 192a76557930e9639403f875095e5c04f21f5f15 | diff --git a/sample/EndpointRoutingSample/Program.fs b/sample/EndpointRoutingSample/Program.fs
index ca4fab69..430c83ab 100644
--- a/sample/EndpointRoutingSample/Program.fs
+++ b/sample/EndpointRoutingSample/Program.fs
@@ -93,7 +93,7 @@ let topRouter = router {
get "/a" otherHelloWorld2
})
- // or ca... | [
"sample/EndpointRoutingSample/Program.fs"
] | [] | true | ||
SaturnFramework/Saturn | 368 | issue_to_patch | Replace `master` branch references by `main` branch | ## Description:
With this PR I'm basically replacing the references to the `master` branch in this repository by references to the `main` branch. | d15a317548447cfb31ba57424f6bd7acd5c9fc3d | b3a16889d5230bdd7f38300aa0516bc2d709fcf3 | diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index e8d9c4e3..d87cd656 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -29,7 +29,7 @@ Guidelines for bug reports:
reported.
2. **Check if the issue has been fixed** — try to reproduce it using the
- `master` branch in the repository.
+ `main` branc... | [
"CONTRIBUTING.md",
"README.md"
] | [] | true | ||
SaturnFramework/Saturn | 367 | issue_to_patch | Fix RouterEndpoint.fs typo | ## Description:
This small PR is intended to fix a typo in the `RouterEndpoint.fs` file, related to the RouterState.
* `Forawrds` -> `Forwards` | f22bca07d785e11272481057076f1e69a2cd9456 | 312135850cc303d66e5da057cb96aceb157e9230 | diff --git a/src/Saturn/RouterEndpoint.fs b/src/Saturn/RouterEndpoint.fs
index 04d8cef1..d59dbced 100644
--- a/src/Saturn/RouterEndpoint.fs
+++ b/src/Saturn/RouterEndpoint.fs
@@ -23,8 +23,7 @@ module Router =
type RouterState =
{ Routes: Dictionary<string * RouteType, HttpHandler list>
RoutesF: Dictionar... | [
"src/Saturn/RouterEndpoint.fs"
] | [] | true | ||
SaturnFramework/Saturn | 365 | issue_to_patch | api docs (authorization): rephrase comment and fix typo | 638b2cf699aa77f01b8318516b29a1c55bd20907 | cae0549dde4c965baba47c93ff8d44e76a8df374 | diff --git a/src/Saturn.Extensions.Authorization/OAuth.fs b/src/Saturn.Extensions.Authorization/OAuth.fs
index e3860d1b..75f6918c 100644
--- a/src/Saturn.Extensions.Authorization/OAuth.fs
+++ b/src/Saturn.Extensions.Authorization/OAuth.fs
@@ -17,7 +17,7 @@ let private addCookie state (c : AuthenticationBuilder) = if no... | [
"src/Saturn.Extensions.Authorization/OAuth.fs",
"src/Saturn/Authentication.fs"
] | [] | true | |||
SaturnFramework/Saturn | 364 | issue_to_patch | Replaced GiraffeViewEngine with Giraffe.ViewEngine | dc999a97ba1f89cd8fb152b9a39752af214f6b78 | a41fccceedecf003e7dbfd5d40dba484be86f029 | diff --git a/docs/content/explanations/routing.fsx b/docs/content/explanations/routing.fsx
index f90b1357..3333212a 100644
--- a/docs/content/explanations/routing.fsx
+++ b/docs/content/explanations/routing.fsx
@@ -14,11 +14,11 @@ menu_order: 5
#r "Microsoft.AspNetCore.Http.Abstractions.dll"
module Index =
- open ... | [
"docs/content/explanations/routing.fsx",
"docs/content/explanations/view.md",
"docs/content/tutorials/adding-pages.md"
] | [] | true | |||
SaturnFramework/Saturn | 360 | issue_to_patch | Added unit test for deletef request | # Description
With this PR I'm adding more test scenarios for the router feature. The endpoint that was added to cover the following HTTP verbs:
* DELETEF
Let me know if you guys have any suggestions. | 5fb39fcd3995b0026edacaf769f496ebe0f958fe | 5d5ef1338e90b02a75034a3900d665ae281d6e2c | [
"tests/Saturn.UnitTests/RouterTests.fs"
] | [] | diff --git a/tests/Saturn.UnitTests/RouterTests.fs b/tests/Saturn.UnitTests/RouterTests.fs
index 7b1e0cef..8c0da3ac 100644
--- a/tests/Saturn.UnitTests/RouterTests.fs
+++ b/tests/Saturn.UnitTests/RouterTests.fs
@@ -13,6 +13,7 @@ let testRouter = router {
post "/post/2" (text "2")
put "/user/123" (text "User updat... | true | ||
SaturnFramework/Saturn | 361 | issue_to_patch | Update GitHub Actions | ## Description:
With this PR I'm:
* Updating the version of both the `checkout` and `setup-dotnet` actions used.
* Pin the environment version to avoid problems popping up in the future due to some release (avoiding `latest` tags whenever possible).
* Add a workaround for the MacOS `dotnet tool restore`, which ... | 5fb39fcd3995b0026edacaf769f496ebe0f958fe | a1c4a18a05c05f08c78c465fe8704c1e078a46b5 | diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml
index ae1df1a2..f3283845 100644
--- a/.github/workflows/benchmark.yml
+++ b/.github/workflows/benchmark.yml
@@ -7,17 +7,23 @@ jobs:
strategy:
matrix:
- os: [macos-latest]
+ os: [macos-12]
dotnet: [6.0.200... | [
".github/workflows/benchmark.yml",
".github/workflows/build.yml",
".github/workflows/docs.yml",
".github/workflows/publish.yml"
] | [] | true | ||
SaturnFramework/Saturn | 315 | issue_to_patch | Add test instructions to the README.md and fix the test instructions in the CONTRIBUTING.md | I have noticed that the project lacks instructions about how to run the automated tests inside it. So I decided to contribute by providing a new section to the README.md where I teach people how to run those tests and how to run a specific test in cases where folks want to.
Also, I have fixed the CONTRIBUTING.md fil... | 936a88c5b829bdc9f3a4b52acb6670a560943131 | f3dfbcf734a8ff575b8473a9d8523391f67607b4 | diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 2c765470..e8d9c4e3 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -124,7 +124,7 @@ in order to craft an excellent pull request:
5. Make sure all the tests are still passing.
```bash
- fake build
+ dotnet fake build -t Test
```
6. Push your to... | [
"CONTRIBUTING.md",
"README.md"
] | [
{
"comment": "does the command `dotnet fake build -t Test` work here instead? This is the command used in the [CI build script](https://github.com/SaturnFramework/Saturn/blob/master/.github/workflows/build.yml#L23) and would help ensure these two results are as similar as possible.\r\n\r\nSimilarly, the instruc... | true | ||
SaturnFramework/Saturn | 354 | issue_to_patch | Enhance the "Explanation" section of the documentation | ## Description:
With this PR I'm enhancing the pages of the "Explanation" section of the documentation.
The scope of changes is relatively small. Most of the time I'm simply adding "," or ".", or breaking paragraphs to make it easier to read. On other pages, I merely added references to some documentation that wi... | a02f3ded324a4b5582e26eb2722613a6d4d8ec13 | 8f1ce808754bcd68870d81aaf9405ac35004cf64 | diff --git a/docs/content/explanations/controller.fsx b/docs/content/explanations/controller.fsx
index 1aa22863..9ada847f 100644
--- a/docs/content/explanations/controller.fsx
+++ b/docs/content/explanations/controller.fsx
@@ -16,7 +16,9 @@ menu_order: 7
(**
# Controller
-In Saturn, a **controller** is a list of ro... | [
"docs/content/explanations/controller.fsx",
"docs/content/explanations/directory-structure.md",
"docs/content/explanations/endpoint-routing.md",
"docs/content/explanations/overview.md",
"docs/content/explanations/pipeline.fsx",
"docs/content/explanations/routing.fsx",
"docs/content/explanations/scaffold... | [] | true | ||
SaturnFramework/Saturn | 355 | issue_to_patch | Add more test scenarios for the `router` feature | ## Description:
With this PR I'm adding more test scenarios for the `router` feature. The endpoints added cover the following HTTP verbs:
* PUT
* DELETE
I'm also adding some GET endpoints to test the `getf` method.
Let me know if there is something you'd like to change before getting this PR merged. | 51056dcbc277c2f073571da34e7d83cd7a3334d7 | 2b6c4eabecdc766982a67c2e531353914a4f4337 | [
"tests/Saturn.UnitTests/RouterTests.fs"
] | [] | diff --git a/tests/Saturn.UnitTests/RouterTests.fs b/tests/Saturn.UnitTests/RouterTests.fs
index f159a5cc..7b1e0cef 100644
--- a/tests/Saturn.UnitTests/RouterTests.fs
+++ b/tests/Saturn.UnitTests/RouterTests.fs
@@ -7,8 +7,12 @@ open Giraffe
let testRouter = router {
get "/1" (text "HelloWorld")
get "/post/1" (te... | true | ||
SaturnFramework/Saturn | 356 | issue_to_patch | [Cosmetic] Update indentation | ## Description:
With this PR, I'm sending a cosmetic update, only fixing the `updateAction` function indentation. Previously it was ahead of the other functions.
Let me know if you'd like me to change something before merging this PR. | 51056dcbc277c2f073571da34e7d83cd7a3334d7 | 6091f128bc5c4f69606c4f272c691b4fca68e7b5 | [
"tests/Saturn.UnitTests/ControllerTests.fs"
] | [] | diff --git a/tests/Saturn.UnitTests/ControllerTests.fs b/tests/Saturn.UnitTests/ControllerTests.fs
index 43563fbc..d742efe1 100644
--- a/tests/Saturn.UnitTests/ControllerTests.fs
+++ b/tests/Saturn.UnitTests/ControllerTests.fs
@@ -14,10 +14,10 @@ let createAction id ctx =
|> Controller.text ctx
let updateAction i... | true | ||
SaturnFramework/Saturn | 353 | issue_to_patch | SimpleTests - Fix typo | ## Description:
With this PR I'm fixing a typo in the module name for the `SimpleTests.fs` file, along with other minor fixes in this file.
* Rename module: `SimpleTets` -> `SimpleTests`
* Remove empty line
* Change the `mkLinks` function to avoid receiving unused parameter
* Fix indentation for the router | c967f9ff5680db965360896fece3486a20ee0879 | e84ec693a7d49921a1305c3e1e205cdcee8738dc | [
"tests/Saturn.UnitTests/SimpleTests.fs"
] | [] | diff --git a/tests/Saturn.UnitTests/SimpleTests.fs b/tests/Saturn.UnitTests/SimpleTests.fs
index 41a388c7..159058aa 100644
--- a/tests/Saturn.UnitTests/SimpleTests.fs
+++ b/tests/Saturn.UnitTests/SimpleTests.fs
@@ -1,4 +1,4 @@
-module SimpleTets
+module SimpleTests
open Expecto
open Saturn
@@ -12,20 +12,19 @@ let s... | true | ||
SaturnFramework/Saturn | 352 | issue_to_patch | Update `how-to-start` guide | ## Description:
With this PR, I'm:
* Updating the `how-to-start` guide due to the major .NET update of the project ([issue link](https://github.com/SaturnFramework/Saturn/issues/321)).
* Update the command used to start the sample application in watch mode. It was required to change due to the lack of [FAKE](ht... | c967f9ff5680db965360896fece3486a20ee0879 | 7b4dfe241280437971e7d5ca567d7915d878b645 | diff --git a/docs/content/tutorials/how-to-start.md b/docs/content/tutorials/how-to-start.md
index 781edd86..fee8c53d 100644
--- a/docs/content/tutorials/how-to-start.md
+++ b/docs/content/tutorials/how-to-start.md
@@ -8,7 +8,7 @@ menu_order: 1
Requirements:
-* `dotnet` SDK 3.1 [https://dotnet.microsoft.com/downlo... | [
"docs/content/tutorials/how-to-start.md"
] | [] | true | ||
SaturnFramework/Saturn | 344 | issue_to_patch | Release stable 0.16.0 | 2ad1d02965a071115e677eb02e0d6ad02f9e659e | d3e5e31263e16cc8313b529e282381b71f242010 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index c66a63a9..dafc72a8 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,25 +3,25 @@
"isRoot": true,
"tools": {
"fake-cli": {
- "version": "5.20.4-alpha.1642",
+ "version": "5.22.0",
"commands": [... | [
".config/dotnet-tools.json",
"CHANGELOG.md",
"benchmark/GiraffeBench/paket.references",
"benchmark/SaturnBench/paket.references",
"benchmark/SaturnEndpointBench/paket.references",
"paket.dependencies",
"paket.lock",
"paket.references",
"sample/ChannelsSample/paket.references",
"sample/Controller.S... | [] | diff --git a/tests/Saturn.UnitTests/paket.references b/tests/Saturn.UnitTests/paket.references
index 7ed458b4..da9f9110 100644
--- a/tests/Saturn.UnitTests/paket.references
+++ b/tests/Saturn.UnitTests/paket.references
@@ -1,6 +1,5 @@
Expecto
NSubstitute
BenchmarkDotNet
-FSharp.Core
Giraffe
-Microsoft.AspNetCore.Te... | true | ||
SaturnFramework/Saturn | 322 | issue_to_patch | Update to .NET6 | 01eb4f021161ac8b432ff2cc5e9d384b38fba5f8 | 51c81a951e314ebe8da4f71fc68ae76f9696fb70 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 843e19e8..c66a63a9 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -8,17 +8,23 @@
"fake"
]
},
+ "fornax": {
+ "version": "0.13.1",
+ "commands": [
+ "fornax"
+ ]
+ },
... | [
".config/dotnet-tools.json",
".github/workflows/benchmark.yml",
".github/workflows/build.yml",
".github/workflows/docs.yml",
".github/workflows/publish.yml",
".paket/Paket.Restore.targets",
".paket/paket.targets",
".vscode/launch.json",
"Build.fs",
"Build.fsproj",
"CHANGELOG.md",
"Helpers.fs",... | [
{
"comment": "I think you need to pass CLI args to this function instead of the `[]` parameter here. This allows fake to record the arguments and pass them to targets.\r\n\r\nThis will come into play with my next comment.",
"path": "Helpers.fs",
"hunk": "@@ -0,0 +1,114 @@\n+module Helpers\n+\n+open Fake... | diff --git a/tests/Saturn.UnitTests/ControllerTests.fs b/tests/Saturn.UnitTests/ControllerTests.fs
index d852123d..43563fbc 100644
--- a/tests/Saturn.UnitTests/ControllerTests.fs
+++ b/tests/Saturn.UnitTests/ControllerTests.fs
@@ -2,7 +2,6 @@ module ControllerTests
open Expecto
open Saturn
-open FSharp.Control.Task... | true | ||
SaturnFramework/Saturn | 343 | issue_to_patch | Modernize creating GitHub releases | f81844b49495a1550518070d8e3195115b05c2d2 | 3282f16821958b25352d97845ece8f4948af31a2 | diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index a927e308..ad229b1d 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -31,29 +31,13 @@ jobs:
env:
nuget-key: ${{ secrets.NUGET_KEY }}
- - name: Get Changelog Entry
- id: changelog_re... | [
".github/workflows/publish.yml"
] | [] | true | |||
SaturnFramework/Saturn | 342 | issue_to_patch | Update Build.fs | Fix typo in name of the build param (it should be the same as what's defined in the Action - https://github.com/SaturnFramework/Saturn/blob/master/.github/workflows/publish.yml#L32) | 6627b66aa60584c32793aab372711da0c511d579 | 6e8bf8af21b2aad9801832ac7beb47744cc9ac83 | diff --git a/Build.fs b/Build.fs
index e2796549..70ecb7aa 100644
--- a/Build.fs
+++ b/Build.fs
@@ -155,7 +155,7 @@ let init args =
let key =
//Environment.environVarOrFail "nugetKey"
- match getBuildParam "nugetkey" with
+ match getBuildParam "nuget-key" with
|... | [
"Build.fs"
] | [] | true | ||
SaturnFramework/Saturn | 341 | issue_to_patch | fix build script and set indent_size to 4 | 5250efa372f0039c87743bfa637eab04d2fc3b77 | 150ba4992a22ee11befaac2e04da15d2ea835757 | diff --git a/.editorconfig b/.editorconfig
index 22861b3a..8a4fce65 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -3,7 +3,7 @@ root = true
[*]
indent_style = space
-indent_size = 2
+indent_size = 4
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
diff --git a/Build.fs b/Build.fs
index fb6a474... | [
".editorconfig",
"Build.fs"
] | [] | true | |||
SaturnFramework/Saturn | 335 | issue_to_patch | [Security] Workflow publish.yml is using vulnerable action mindsers/changelog-reader-action
The workflow publish.yml is referencing action mindsers/changelog-reader-action using references v1.1.0. However this reference is missing the commit [a5d0f1d4f77ba7a2f2dc539df311d137861fa8b8](https://github.com/mindsers/change... | Update gitpod and actions infra | Fixes #332, #331, #330, #329 | cdaa6df4e575b623acf885d085a660470ea0fab8 | 552d893dd5e573fa5dc133803733a42aa2ca4449 | diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml
index c8ee1f3b..7f50b777 100644
--- a/.github/workflows/benchmark.yml
+++ b/.github/workflows/benchmark.yml
@@ -12,7 +12,8 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- - uses: actions/checkout@v1
+ - name: Checkout
+ us... | [
".github/workflows/benchmark.yml",
".github/workflows/build.yml",
".github/workflows/docs.yml",
".github/workflows/publish.yml",
".gitpod.yml"
] | [] | true | |
SaturnFramework/Saturn | 320 | issue_to_patch | Add NO_CONTENT reponse helper | 5d6ed9f84885bd70bf5dbb5a2eea1de6b01d0d58 | 0ba1d9a7ce16df2da51a2385470c00444c267976 | diff --git a/src/Saturn/ControllerHelpers.fs b/src/Saturn/ControllerHelpers.fs
index b6dfbc67..509b6515 100644
--- a/src/Saturn/ControllerHelpers.fs
+++ b/src/Saturn/ControllerHelpers.fs
@@ -192,6 +192,9 @@ module ControllerHelpers =
let ok (ctx: HttpContext) res =
Successful.OK res Common.halt ctx
+ l... | [
"src/Saturn/ControllerHelpers.fs"
] | [] | true | |||
SaturnFramework/Saturn | 310 | issue_to_patch | Could Saturn require only FSharp.Core 5.0.0 rather than 5.0.1?
As per #308, this can be confusing when starting from scratch, | lower fsharp.core dependency to 5.x so users can float | Should fix #309 by lowering the version pinned in paket.dependencies. | 977961ed7a030fed51984b357d4c11522fb841df | a100f44773683c246063dc8e32da7650482e5649 | diff --git a/paket.dependencies b/paket.dependencies
index 51634b4a..6f756b1c 100644
--- a/paket.dependencies
+++ b/paket.dependencies
@@ -20,7 +20,9 @@ nuget protobuf-net.Grpc.AspNetCore
nuget protobuf-net.Grpc.HttpClient
nuget System.ServiceModel.Primitives
nuget FSharp.Control.Websockets >= 0.2
-nuget FSharp.Core... | [
"paket.dependencies",
"paket.lock"
] | [] | true | |
SaturnFramework/Saturn | 291 | issue_to_patch | Log prematurely closed WebSocket connections as info, not as error | This is a common thing to happen and is unavoidable, so this should not be logged as an error IMO. | 18944b3b4923eef67369ed67959cf2f88e8c474d | 98472e7ac45836c4bd8f1b7a037b39720cbb879a | diff --git a/src/Saturn/Channels.fs b/src/Saturn/Channels.fs
index fc2632c2..dd42b6f0 100644
--- a/src/Saturn/Channels.fs
+++ b/src/Saturn/Channels.fs
@@ -9,6 +9,7 @@ open System
open System.Collections.Concurrent
open System.Collections.Generic
open System.Net.WebSockets
+open System.Runtime.ExceptionServices
open... | [
"src/Saturn/Channels.fs"
] | [] | true | ||
SaturnFramework/Saturn | 298 | issue_to_patch | allow newer versions of dotnet5 to make project build in the devconta… | …iner | 9595a578c94f14174edf3e5cd30e351dc048a41e | 13c6b568330f9a6a4386c24ed6b94cd6672b6494 | diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
index 697f86e7..41a66afc 100644
--- a/.devcontainer/devcontainer.json
+++ b/.devcontainer/devcontainer.json
@@ -1,6 +1,6 @@
// See https://aka.ms/vscode-remote/devcontainer.json for format details.
{
- "name": "F# (.NET Core Latest)",
+ "n... | [
".devcontainer/devcontainer.json",
"global.json"
] | [] | true | ||
SaturnFramework/Saturn | 296 | issue_to_patch | add use_response_caching to application CE (#295) | 9595a578c94f14174edf3e5cd30e351dc048a41e | 897896d53834f0a9ec99e9c63d665136974fa36a | diff --git a/src/Saturn/Application.fs b/src/Saturn/Application.fs
index def3ff17..6e733b7b 100644
--- a/src/Saturn/Application.fs
+++ b/src/Saturn/Application.fs
@@ -327,6 +327,33 @@ module Application =
ServicesConfig = service::state.ServicesConfig
AppConfigs = middleware::state.AppConfigs
... | [
"src/Saturn/Application.fs"
] | [] | true | |||
SaturnFramework/Saturn | 292 | issue_to_patch | Fixed doc comment on Logger | b06fe74eff2c215084e582e8de19d59160c6afa1 | 00db8756b4db0b23012cd326f6401fd171b3786d | diff --git a/src/Saturn.AzureFunctions/AzureFunctions.fs b/src/Saturn.AzureFunctions/AzureFunctions.fs
index febe52d0..ae8b99e2 100644
--- a/src/Saturn.AzureFunctions/AzureFunctions.fs
+++ b/src/Saturn.AzureFunctions/AzureFunctions.fs
@@ -92,7 +92,7 @@ module AzureFunctions =
member __.NotFoundHandler(state : Func... | [
"src/Saturn.AzureFunctions/AzureFunctions.fs"
] | [] | true | |||
SaturnFramework/Saturn | 290 | issue_to_patch | typo fix: s/shortucts/shortcuts/ | Typo fix in left navigation of Saturn documentation.
Also fix typo in function name.
| 18944b3b4923eef67369ed67959cf2f88e8c474d | 48b2f160203b7f167d209aa4860683de9fcc840e | diff --git a/docs/generators/partials/menu.fsx b/docs/generators/partials/menu.fsx
index 7c1e935d..a72e6d91 100644
--- a/docs/generators/partials/menu.fsx
+++ b/docs/generators/partials/menu.fsx
@@ -97,9 +97,9 @@ let menu (ctx : SiteContents) (page: string) =
]
]
- let renderShortucuts =
+ let renderS... | [
"docs/generators/partials/menu.fsx"
] | [] | true | ||
SaturnFramework/Saturn | 287 | issue_to_patch | Preserve stack trace by default in controller (#280) | This should preserve the stack trace when exceptions are thrown while using controllers that have no dedicated error handler.
This solves a part of #280 | 62e84152a264407992025b3660f48a17732e310e | 9ad1daddda0b0701b7faf5ae708e85c3fec0517f | diff --git a/src/Saturn/Controller.fs b/src/Saturn/Controller.fs
index c42a8d8e..093d81e8 100644
--- a/src/Saturn/Controller.fs
+++ b/src/Saturn/Controller.fs
@@ -48,7 +48,7 @@ module Controller =
DeleteAll: (HttpContext -> Task<'DeleteAllOutput>) option
NotFoundHandler: HttpHandler option
- ErrorHandler... | [
"src/Saturn/Controller.fs"
] | [] | true | ||
SaturnFramework/Saturn | 289 | issue_to_patch | When using channels, exceptions are not propagated properly
I encountered this issue when using channels in Saturn via add_channel in application CE.
Take the following code:
```FSharp
open System
open Microsoft.AspNetCore.Http
open Microsoft.Extensions.Logging
open Saturn
open Giraffe
open Saturn.Channe... | Fixes exception propagation when using channels | Should fix #288
This is very urgent for our project. Is there a timeframe for the next release? | 62e84152a264407992025b3660f48a17732e310e | aae215066bf71dc460da6230e0fe69bce293a831 | diff --git a/src/Saturn/Channels.fs b/src/Saturn/Channels.fs
index a3feed73..fc2632c2 100644
--- a/src/Saturn/Channels.fs
+++ b/src/Saturn/Channels.fs
@@ -146,7 +146,7 @@ module Channels =
do! ctx.Response.WriteAsync msg
| false ->
ctx.Response.St... | [
"src/Saturn/Channels.fs"
] | [] | true | |
SaturnFramework/Saturn | 252 | issue_to_patch | Endpoint routing and Giraffe 5.0 | Interesting bits at the moment are in `EndpointRouter.fs`
- [x] Implement Router based on Endpoint Routing
- [x] Implement Controller based on Endpoint Routing
- [x] Add a new way of plugging the router in `application` CE
- [x] Add back all code depending on ViewEngine when it's published again
- [x] Handle `ap... | 6c0b3027d0a612486d2f46a2c20dea148d778cbd | ad2e20cc28624bb373f6b2ecf8ce7d8c436940d2 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index c0d973b2..47bf0b32 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,20 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Ve... | [
"CHANGELOG.md",
"Saturn.sln",
"benchmark/SaturnEndpointBench/Program.fs",
"benchmark/SaturnEndpointBench/SaturnEndpointBench.fsproj",
"benchmark/SaturnEndpointBench/paket.references",
"benchmark/test.sh",
"docs/content/explanations/endpoint-routing.md",
"paket.dependencies",
"paket.lock",
"sample/... | [] | diff --git a/tests/Saturn.UnitTests/ControllerTests.fs b/tests/Saturn.UnitTests/ControllerTests.fs
index c73df367..66095505 100644
--- a/tests/Saturn.UnitTests/ControllerTests.fs
+++ b/tests/Saturn.UnitTests/ControllerTests.fs
@@ -2,9 +2,7 @@ module ControllerTests
open Expecto
open Saturn
-open Giraffe.GiraffeView... | true | |
SaturnFramework/Saturn | 285 | issue_to_patch | Rework DI system | This builds on #276 to provide bit better (IMHO) API surface for DI operations. | 82d15e722718006b1eda8e25058001e3bb703edc | d4af3ea41241f9665557c370655447222bdbc9b4 | diff --git a/src/Saturn/Application.fs b/src/Saturn/Application.fs
index 57628bd9..cd907497 100644
--- a/src/Saturn/Application.fs
+++ b/src/Saturn/Application.fs
@@ -230,10 +230,6 @@ module Application =
member __.Router(state, handler) =
{state with Router = Some handler}
-
- member x.Router(state, h... | [
"src/Saturn/Application.fs",
"src/Saturn/Channels.fs",
"src/Saturn/Controller.fs",
"src/Saturn/ControllerEndpoint.fs",
"src/Saturn/Pipelines.fs",
"src/Saturn/Router.fs",
"src/Saturn/RouterEndpoint.fs",
"tests/Saturn.UnitTests/ControllerTests.fs",
"tests/Saturn.UnitTests/EndpointControllerTests.fs"
] | [] | diff --git a/tests/Saturn.UnitTests/ControllerTests.fs b/tests/Saturn.UnitTests/ControllerTests.fs
index 66095505..86a87287 100644
--- a/tests/Saturn.UnitTests/ControllerTests.fs
+++ b/tests/Saturn.UnitTests/ControllerTests.fs
@@ -283,26 +283,29 @@ let implicitConversionTest =
]
-//---------------------------D... | true | |
SaturnFramework/Saturn | 286 | issue_to_patch | Update to net5.0 and Girafe 5.0 RC 6 | 36f7fdbc5927c1550dd92baec615d3dea90b8553 | 50a9c1c06feb5765a0601b6cd2cb7e20941464ec | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 4bdd1bf4..843e19e8 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,13 +3,13 @@
"isRoot": true,
"tools": {
"fake-cli": {
- "version": "5.19.0",
+ "version": "5.20.4-alpha.1642",
"commands": [... | [
".config/dotnet-tools.json",
".devcontainer/Dockerfile",
".github/workflows/benchmark.yml",
".github/workflows/build.yml",
".github/workflows/docs.yml",
".github/workflows/publish.yml",
".gitignore",
".gitpod.yml",
".vscode/launch.json",
".vscode/tasks.json",
"README.md",
"benchmark/GiraffeBen... | [] | diff --git a/tests/Saturn.UnitTests/BenchmarkTests.fs b/tests/Saturn.UnitTests/BenchmarkTests.fs
index 7e9c6ad3..8bd4c565 100644
--- a/tests/Saturn.UnitTests/BenchmarkTests.fs
+++ b/tests/Saturn.UnitTests/BenchmarkTests.fs
@@ -66,7 +66,7 @@ type Requesters() =
-[<Tests>]
+// [<Tests>]
let tests =
testList "pe... | true | ||
SaturnFramework/Saturn | 276 | issue_to_patch | Initial implementation of automatic dependency injection | I was going to collect feedback on this matter in #275, but the implementation turned out to be straight-forward enough that I decided to submit an implementation as a basis for discussion around the issue.
Basically, for every CE builder method that accepts a function or the result of another CE, a new method of th... | 73855f08d9c50e5d94097c5ab12c786947c424fb | 025b7cdde2c1ecd5e8b6e0ad437264c1c36bacf4 | diff --git a/src/Saturn/Application.fs b/src/Saturn/Application.fs
index 89886148..57628bd9 100644
--- a/src/Saturn/Application.fs
+++ b/src/Saturn/Application.fs
@@ -74,7 +74,7 @@ module Application =
CookiesAlreadyAdded: bool
NoRouter: bool
NoWebhost: bool
- Channels: (string * IChannel) list
+ C... | [
"src/Saturn/Application.fs",
"src/Saturn/Channels.fs",
"src/Saturn/Controller.fs",
"src/Saturn/DependencyInjectionHelper.fs",
"src/Saturn/Pipelines.fs",
"src/Saturn/Router.fs",
"src/Saturn/Saturn.fsproj"
] | [] | true | ||
SaturnFramework/Saturn | 278 | issue_to_patch | Turbolinks extension, (optionally) include query string parameters in 'Turbolinks-Location' header?
I haven't used the ruby-on-rails implementation, so I don't know how this is implemented in that version. But the current Saturn implementation sets 'Turbolinks-Location' to `ctx.Request.Path.Value`, the virtual path. W... | Include querystring in Turbolinks-location. | This fixes #262.
It's a somewhat breaking change, but like we discussed in the issue we can see this as a bug-fix.
I didn't see any docs/tests/samples that needed to be changed because of this, but let me know if there is anything that I should update. | 2dab59248954948c099e9f6a34fef73a650ca326 | 97f6e7ef30352bcc078a58878ee426bc965f5c25 | diff --git a/src/Saturn.Extensions.Turbolinks/Turbolinks.fs b/src/Saturn.Extensions.Turbolinks/Turbolinks.fs
index 62e7f397..f91f04f5 100644
--- a/src/Saturn.Extensions.Turbolinks/Turbolinks.fs
+++ b/src/Saturn.Extensions.Turbolinks/Turbolinks.fs
@@ -33,7 +33,7 @@ module TurbolinksHelpers =
let internal handleTurb... | [
"src/Saturn.Extensions.Turbolinks/Turbolinks.fs"
] | [] | true | |
SaturnFramework/Saturn | 274 | issue_to_patch | fix issue #270: application/json not compressed in response | Add the additionalMime list to ResponseCompressionDefaults.MimeTypes.
(appearently the passed options do not contain the defaults) | 1a038267c5fbbec7dc78268ecd201f784e97a30c | a63b86dbdc8b89c49850647f5c14db33d8e27353 | diff --git a/src/Saturn/Application.fs b/src/Saturn/Application.fs
index 2e7af9e3..cc71b858 100644
--- a/src/Saturn/Application.fs
+++ b/src/Saturn/Application.fs
@@ -284,7 +284,7 @@ module Application =
"application/x-javascript";
"text/javascript";
|]
- o.... | [
"src/Saturn/Application.fs"
] | [] | true | ||
SaturnFramework/Saturn | 268 | issue_to_patch | Fix putSecureBrowserHeaders header typo | Looks like this header was incorrect as evidenced by the doc lines being the correct header. This should be `x-frame-options` according to [this](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Frame-Options) | 4b11a4685e5e27f1df6d6195c1d3e965adfb0ec1 | 568c2d0a37bd3636a8f37e87d0346ea993bf6353 | diff --git a/src/Saturn/Pipelines.fs b/src/Saturn/Pipelines.fs
index 8c625217..d1924b4a 100644
--- a/src/Saturn/Pipelines.fs
+++ b/src/Saturn/Pipelines.fs
@@ -177,7 +177,7 @@ module PipelineHelpers =
/// * x-download-options - set to noopen to instruct the browser not to open a download directly in the browser, to ... | [
"src/Saturn/Pipelines.fs"
] | [] | true | ||
SaturnFramework/Saturn | 267 | issue_to_patch | Fix typo getConfiguration | Fix typo getConfiguration - #266 | 7c6f3b07b56e2264a0a932c031dd40ed970dd393 | 63dbe2a6d1c47fbc42afea16b165d7ec08b2e947 | diff --git a/src/Saturn/Application.fs b/src/Saturn/Application.fs
index e9bfdcc8..2e7af9e3 100644
--- a/src/Saturn/Application.fs
+++ b/src/Saturn/Application.fs
@@ -643,4 +643,4 @@ module Application =
///Helpers for getting configuration
module Config =
- let getConfinguration (services: #IServiceCollecti... | [
"src/Saturn/Application.fs"
] | [] | true | ||
SaturnFramework/Saturn | 257 | issue_to_patch | Saturn 0.14 | 9cd02f0060eb3f51c0baaca32988097cb4e35d77 | ad7d40594aa7c8bfa0c05a7262faecad22097512 | diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
index cbb6aa64..267bf669 100644
--- a/.devcontainer/Dockerfile
+++ b/.devcontainer/Dockerfile
@@ -3,7 +3,7 @@
# Licensed under the MIT License. See https://go.microsoft.com/fwlink/?linkid=2090316 for license information.
#-------------------------------... | [
".devcontainer/Dockerfile",
".github/workflows/benchmark.yml",
".github/workflows/build.yml",
".github/workflows/docs.yml",
".github/workflows/publish.yml",
".paket/Paket.Restore.targets",
"CHANGELOG.md",
"Saturn.sln",
"benchmark/GiraffeBench/GiraffeBench.fsproj",
"benchmark/GiraffeBench/Program.f... | [] | diff --git a/tests/Saturn.UnitTests/paket.references b/tests/Saturn.UnitTests/paket.references
index a4415740..2c6a08de 100644
--- a/tests/Saturn.UnitTests/paket.references
+++ b/tests/Saturn.UnitTests/paket.references
@@ -1,7 +1,5 @@
Expecto
NSubstitute
BenchmarkDotNet
-
-group netcoreapp3.1
- FSharp.Core
- Giraf... | true | ||
SaturnFramework/Saturn | 259 | issue_to_patch | Update to latest template and use CDN for landing | 8347b05f6f4c29fb20fe20a4d1dc9f359001252c | 5265966e077fb1190a4390244926100de3482fef | diff --git a/.paket/Paket.Restore.targets b/.paket/Paket.Restore.targets
index 8cb5986c..0ec28162 100644
--- a/.paket/Paket.Restore.targets
+++ b/.paket/Paket.Restore.targets
@@ -27,10 +27,16 @@
<PaketBootStrapperExePath Condition=" '$(PaketBootStrapperExePath)' == '' AND Exists('$(PaketRootPath)paket.bootstrapper... | [
".paket/Paket.Restore.targets",
"docs/config.fsx",
"docs/content/explanations/controller.fsx",
"docs/content/explanations/directory-structure.md",
"docs/content/explanations/pipeline.fsx",
"docs/content/explanations/routing.fsx",
"docs/content/explanations/scaffolding.md",
"docs/content/tutorials/addi... | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.