url stringlengths 58 61 | number int64 1 8.23k | title stringlengths 1 290 | body stringlengths 0 228k ⌀ | state stringclasses 2
values | created_at timestamp[s]date 2020-04-14 10:18:02 2026-05-30 09:38:59 | comments_url stringlengths 67 70 | pull_request dict | is_pull_request bool 2
classes | text stringlengths 2 228k | comments listlengths 0 30 |
|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/huggingface/datasets/issues/19 | 19 | Replace tf.constant for TF | Replace simple tf.constant type of Tensor to tf.ragged.constant which allows to have examples of different size in a tf.data.Dataset.
Now the training works with TF. Here the same example than for the PT in collab:
```python
import tensorflow as tf
import nlp
from transformers import BertTokenizerFast, TFBertF... | closed | 2020-04-24T15:32:06 | https://api.github.com/repos/huggingface/datasets/issues/19/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/19",
"html_url": "https://github.com/huggingface/datasets/pull/19",
"diff_url": "https://github.com/huggingface/datasets/pull/19.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/19.patch",
"merged_at": "2020-04-25T21:18:45"
} | true | Replace tf.constant for TF
Replace simple tf.constant type of Tensor to tf.ragged.constant which allows to have examples of different size in a tf.data.Dataset.
Now the training works with TF. Here the same example than for the PT in collab:
```python
import tensorflow as tf
import nlp
from transformers import... | [
"Awesome!"
] |
https://api.github.com/repos/huggingface/datasets/issues/18 | 18 | Updating caching mechanism - Allow dependency in dataset processing scripts - Fix style and quality in the repo | This PR has a lot of content (might be hard to review, sorry, in particular because I fixed the style in the repo at the same time).
# Style & quality:
You can now install the style and quality tools with `pip install -e .[quality]`. This will install black, the compatible version of sort and flake8.
You can then ... | closed | 2020-04-24T07:39:48 | https://api.github.com/repos/huggingface/datasets/issues/18/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/18",
"html_url": "https://github.com/huggingface/datasets/pull/18",
"diff_url": "https://github.com/huggingface/datasets/pull/18.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/18.patch",
"merged_at": "2020-04-28T16:06:28"
} | true | Updating caching mechanism - Allow dependency in dataset processing scripts - Fix style and quality in the repo
This PR has a lot of content (might be hard to review, sorry, in particular because I fixed the style in the repo at the same time).
# Style & quality:
You can now install the style and quality tools with... | [
"LGTM"
] |
https://api.github.com/repos/huggingface/datasets/issues/17 | 17 | Add Pandas as format type | As detailed in the title ^^ | closed | 2020-04-23T18:20:14 | https://api.github.com/repos/huggingface/datasets/issues/17/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/17",
"html_url": "https://github.com/huggingface/datasets/pull/17",
"diff_url": "https://github.com/huggingface/datasets/pull/17.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/17.patch",
"merged_at": "2020-04-27T18:07:48"
} | true | Add Pandas as format type
As detailed in the title ^^ | [] |
https://api.github.com/repos/huggingface/datasets/issues/16 | 16 | create our own DownloadManager | I tried to create our own - and way simpler - download manager, by replacing all the complicated stuff with our own `cached_path` solution.
With this implementation, I tried `dataset = nlp.load('squad')` and it seems to work fine.
For the implementation, what I did exactly:
- I copied the old download manager
- I... | closed | 2020-04-23T16:08:07 | https://api.github.com/repos/huggingface/datasets/issues/16/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/16",
"html_url": "https://github.com/huggingface/datasets/pull/16",
"diff_url": "https://github.com/huggingface/datasets/pull/16.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/16.patch",
"merged_at": "2020-04-25T21:25:10"
} | true | create our own DownloadManager
I tried to create our own - and way simpler - download manager, by replacing all the complicated stuff with our own `cached_path` solution.
With this implementation, I tried `dataset = nlp.load('squad')` and it seems to work fine.
For the implementation, what I did exactly:
- I copie... | [
"Looks great to me! ",
"The new download manager is ready. I removed the old folder and I fixed a few remaining dependencies.\r\nI tested it on squad and a few others from the dataset folder and it works fine.\r\n\r\nThe only impact of these changes is that it breaks the `download_and_prepare` script that was use... |
https://api.github.com/repos/huggingface/datasets/issues/15 | 15 | [Tests] General Test Design for all dataset scripts | The general idea is similar to how testing is done in `transformers`. There is one general `test_dataset_common.py` file which has a `DatasetTesterMixin` class. This class implements all of the logic that can be used in a generic way for all dataset classes. The idea is to keep each individual dataset test file as mini... | closed | 2020-04-22T16:46:01 | https://api.github.com/repos/huggingface/datasets/issues/15/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/15",
"html_url": "https://github.com/huggingface/datasets/pull/15",
"diff_url": "https://github.com/huggingface/datasets/pull/15.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/15.patch",
"merged_at": "2020-04-27T14:48:02"
} | true | [Tests] General Test Design for all dataset scripts
The general idea is similar to how testing is done in `transformers`. There is one general `test_dataset_common.py` file which has a `DatasetTesterMixin` class. This class implements all of the logic that can be used in a generic way for all dataset classes. The idea ... | [
"> I think I'm fine with this.\r\n> \r\n> The alternative would be to host a small subset of the dataset on the S3 together with the testing script. But I think having all (test file creation + actual tests) in one file is actually quite convenient.\r\n> \r\n> Good for me!\r\n> \r\n> One question though, will we ha... |
https://api.github.com/repos/huggingface/datasets/issues/14 | 14 | [Download] Only create dir if not already exist | This was quite annoying to find out :D.
Some datasets have save in the same directory. So we should only create a new directory if it doesn't already exist. | closed | 2020-04-22T13:32:51 | https://api.github.com/repos/huggingface/datasets/issues/14/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/14",
"html_url": "https://github.com/huggingface/datasets/pull/14",
"diff_url": "https://github.com/huggingface/datasets/pull/14.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/14.patch",
"merged_at": "2020-04-23T08:27:33"
} | true | [Download] Only create dir if not already exist
This was quite annoying to find out :D.
Some datasets have save in the same directory. So we should only create a new directory if it doesn't already exist. | [] |
https://api.github.com/repos/huggingface/datasets/issues/13 | 13 | [Make style] | Added Makefile and applied make style to all.
make style runs the following code:
```
style:
black --line-length 119 --target-version py35 src
isort --recursive src
```
It's the same code that is run in `transformers`. | closed | 2020-04-22T08:10:06 | https://api.github.com/repos/huggingface/datasets/issues/13/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/13",
"html_url": "https://github.com/huggingface/datasets/pull/13",
"diff_url": "https://github.com/huggingface/datasets/pull/13.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/13.patch",
"merged_at": "2020-04-23T13:02:22"
} | true | [Make style]
Added Makefile and applied make style to all.
make style runs the following code:
```
style:
black --line-length 119 --target-version py35 src
isort --recursive src
```
It's the same code that is run in `transformers`. | [
"I think this can be quickly reproduced. \r\nI use `black, version 19.10b0`. \r\n\r\nWhen running: \r\n`black nlp/src/arrow_reader.py` \r\nit gives me: \r\n\r\n```\r\nerror: cannot format /home/patrick/hugging_face/nlp/src/nlp/arrow_reader.py: cannot use --safe with this file; failed to parse source file. AST erro... |
https://api.github.com/repos/huggingface/datasets/issues/12 | 12 | [Map Function] add assert statement if map function does not return dict or None | IMO, if a function is provided that is not a print statement (-> returns variable of type `None`) or a function that updates the datasets (-> returns variable of type `dict`), then a `TypeError` should be raised.
Not sure whether you had cases in mind where the user should do something else @thomwolf , but I think ... | closed | 2020-04-22T07:21:24 | https://api.github.com/repos/huggingface/datasets/issues/12/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/12",
"html_url": "https://github.com/huggingface/datasets/pull/12",
"diff_url": "https://github.com/huggingface/datasets/pull/12.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/12.patch",
"merged_at": "2020-04-24T06:29:03"
} | true | [Map Function] add assert statement if map function does not return dict or None
IMO, if a function is provided that is not a print statement (-> returns variable of type `None`) or a function that updates the datasets (-> returns variable of type `dict`), then a `TypeError` should be raised.
Not sure whether you h... | [
"Also added to an assert statement that if a dict is returned by function, all values of `dicts` are `lists`",
"Wait to merge until `make style` is set in place.",
"Updated the assert statements. Played around with multiple cases and it should be good now IMO. "
] |
https://api.github.com/repos/huggingface/datasets/issues/11 | 11 | [Convert TFDS to HFDS] Extend script to also allow just converting a single file | Adds another argument to be able to convert only a single file | closed | 2020-04-21T11:25:33 | https://api.github.com/repos/huggingface/datasets/issues/11/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/11",
"html_url": "https://github.com/huggingface/datasets/pull/11",
"diff_url": "https://github.com/huggingface/datasets/pull/11.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/11.patch",
"merged_at": "2020-04-21T20:47:00"
} | true | [Convert TFDS to HFDS] Extend script to also allow just converting a single file
Adds another argument to be able to convert only a single file | [] |
https://api.github.com/repos/huggingface/datasets/issues/10 | 10 | Name json file "squad.json" instead of "squad.py.json" | closed | 2020-04-21T11:04:28 | https://api.github.com/repos/huggingface/datasets/issues/10/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/10",
"html_url": "https://github.com/huggingface/datasets/pull/10",
"diff_url": "https://github.com/huggingface/datasets/pull/10.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/10.patch",
"merged_at": "2020-04-21T20:48:06"
} | true | Name json file "squad.json" instead of "squad.py.json"
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/9 | 9 | [Clean up] Datasets | Clean up `nlp/datasets` folder.
As I understood, eventually the `nlp/datasets` shall not exist anymore at all.
The folder `nlp/datasets/nlp` is kept for the moment, but won't be needed in the future, since it will live on S3 (actually it already does) at: `https://s3.console.aws.amazon.com/s3/buckets/datasets.h... | closed | 2020-04-21T10:39:56 | https://api.github.com/repos/huggingface/datasets/issues/9/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/9",
"html_url": "https://github.com/huggingface/datasets/pull/9",
"diff_url": "https://github.com/huggingface/datasets/pull/9.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/9.patch",
"merged_at": "2020-04-21T20:49:58"
} | true | [Clean up] Datasets
Clean up `nlp/datasets` folder.
As I understood, eventually the `nlp/datasets` shall not exist anymore at all.
The folder `nlp/datasets/nlp` is kept for the moment, but won't be needed in the future, since it will live on S3 (actually it already does) at: `https://s3.console.aws.amazon.com/s... | [
"Yes!"
] |
https://api.github.com/repos/huggingface/datasets/issues/8 | 8 | Fix issue 6: error when the citation is missing in the DatasetInfo | closed | 2020-04-17T08:04:26 | https://api.github.com/repos/huggingface/datasets/issues/8/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/8",
"html_url": "https://github.com/huggingface/datasets/pull/8",
"diff_url": "https://github.com/huggingface/datasets/pull/8.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/8.patch",
"merged_at": "2020-04-20T13:24:12"
} | true | Fix issue 6: error when the citation is missing in the DatasetInfo
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/7 | 7 | Fix issue 5: allow empty datasets | closed | 2020-04-17T07:59:56 | https://api.github.com/repos/huggingface/datasets/issues/7/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/7",
"html_url": "https://github.com/huggingface/datasets/pull/7",
"diff_url": "https://github.com/huggingface/datasets/pull/7.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/7.patch",
"merged_at": "2020-04-20T13:23:47"
} | true | Fix issue 5: allow empty datasets
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/6 | 6 | Error when citation is not given in the DatasetInfo | The following error is raised when the `citation` parameter is missing when we instantiate a `DatasetInfo`:
```
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/jplu/dev/jplu/datasets/src/nlp/info.py", line 338, in __repr__
citation_pprint = _indent('"""{}"""'.format(self.... | closed | 2020-04-15T14:14:54 | https://api.github.com/repos/huggingface/datasets/issues/6/comments | null | false | Error when citation is not given in the DatasetInfo
The following error is raised when the `citation` parameter is missing when we instantiate a `DatasetInfo`:
```
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/jplu/dev/jplu/datasets/src/nlp/info.py", line 338, in __repr__
... | [
"Yes looks good to me.\r\nNote that we may refactor quite strongly the `info.py` to make it a lot simpler (it's very complicated for basically a dictionary of info I think)",
"No, problem ^^ It might just be a temporary fix :)",
"Fixed."
] |
https://api.github.com/repos/huggingface/datasets/issues/5 | 5 | ValueError when a split is empty | When a split is empty either TEST, VALIDATION or TRAIN I get the following error:
```
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/jplu/dev/jplu/datasets/src/nlp/load.py", line 295, in load
ds = dbuilder.as_dataset(**as_dataset_kwargs)
File "/home/jplu/dev/jplu/data... | closed | 2020-04-15T13:25:13 | https://api.github.com/repos/huggingface/datasets/issues/5/comments | null | false | ValueError when a split is empty
When a split is empty either TEST, VALIDATION or TRAIN I get the following error:
```
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/jplu/dev/jplu/datasets/src/nlp/load.py", line 295, in load
ds = dbuilder.as_dataset(**as_dataset_kwargs)
... | [
"To fix this I propose to modify only the file `arrow_reader.py` with few updates. First update, the following method:\r\n```python\r\ndef _make_file_instructions_from_absolutes(\r\n name,\r\n name2len,\r\n absolute_instructions,\r\n):\r\n \"\"\"Returns the files instructions from the absolu... |
https://api.github.com/repos/huggingface/datasets/issues/4 | 4 | [Feature] Keep the list of labels of a dataset as metadata | It would be useful to keep the list of the labels of a dataset as metadata. Either directly in the `DatasetInfo` or in the Arrow metadata. | closed | 2020-04-15T10:17:10 | https://api.github.com/repos/huggingface/datasets/issues/4/comments | null | false | [Feature] Keep the list of labels of a dataset as metadata
It would be useful to keep the list of the labels of a dataset as metadata. Either directly in the `DatasetInfo` or in the Arrow metadata. | [
"Yes! I see mostly two options for this:\r\n- a `Feature` approach like currently (but we might deprecate features)\r\n- wrapping in a smart way the Dictionary arrays of Arrow: https://arrow.apache.org/docs/python/data.html?highlight=dictionary%20encode#dictionary-arrays",
"I would have a preference for the secon... |
https://api.github.com/repos/huggingface/datasets/issues/3 | 3 | [Feature] More dataset outputs | Add the following dataset outputs:
- Spark
- Pandas | closed | 2020-04-15T10:08:14 | https://api.github.com/repos/huggingface/datasets/issues/3/comments | null | false | [Feature] More dataset outputs
Add the following dataset outputs:
- Spark
- Pandas | [
"Yes!\r\n- pandas will be a one-liner in `arrow_dataset`: https://arrow.apache.org/docs/python/generated/pyarrow.Table.html#pyarrow.Table.to_pandas\r\n- for Spark I have no idea. let's investigate that at some point",
"For Spark it looks to be pretty straightforward as well https://spark.apache.org/docs/latest/sq... |
https://api.github.com/repos/huggingface/datasets/issues/2 | 2 | Issue to read a local dataset | Hello,
As proposed by @thomwolf, I open an issue to explain what I'm trying to do without success. What I want to do is to create and load a local dataset, the script I have done is the following:
```python
import os
import csv
import nlp
class BbcConfig(nlp.BuilderConfig):
def __init__(self, **kwarg... | closed | 2020-04-14T18:18:51 | https://api.github.com/repos/huggingface/datasets/issues/2/comments | null | false | Issue to read a local dataset
Hello,
As proposed by @thomwolf, I open an issue to explain what I'm trying to do without success. What I want to do is to create and load a local dataset, the script I have done is the following:
```python
import os
import csv
import nlp
class BbcConfig(nlp.BuilderConfig):
... | [
"My first bug report ❤️\r\nLooking into this right now!",
"Ok, there are some news, most good than bad :laughing: \r\n\r\nThe dataset script now became:\r\n```python\r\nimport csv\r\n\r\nimport nlp\r\n\r\n\r\nclass Bbc(nlp.GeneratorBasedBuilder):\r\n VERSION = nlp.Version(\"1.0.0\")\r\n\r\n def __init__(sel... |
https://api.github.com/repos/huggingface/datasets/issues/1 | 1 | changing nlp.bool to nlp.bool_ | closed | 2020-04-14T10:18:02 | https://api.github.com/repos/huggingface/datasets/issues/1/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/1",
"html_url": "https://github.com/huggingface/datasets/pull/1",
"diff_url": "https://github.com/huggingface/datasets/pull/1.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/1.patch",
"merged_at": "2020-04-14T12:01:40"
} | true | changing nlp.bool to nlp.bool_
| [] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.