id int64 0 10.2k | text_id stringlengths 17 67 | repo_owner stringclasses 232
values | repo_name stringclasses 295
values | issue_url stringlengths 39 89 | pull_url stringlengths 37 87 | comment_url stringlengths 37 94 | links_count int64 1 2 | link_keyword stringclasses 12
values | issue_title stringlengths 7 197 | issue_body stringlengths 45 21.3k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | diff_url stringlengths 120 170 | diff stringlengths 478 132k | changed_files stringlengths 47 2.6k | changed_files_exts stringclasses 22
values | changed_files_count int64 1 22 | java_changed_files_count int64 1 22 | kt_changed_files_count int64 0 0 | py_changed_files_count int64 0 0 | code_changed_files_count int64 1 22 | repo_symbols_count int64 32.6k 242M | repo_tokens_count int64 6.59k 49.2M | repo_lines_count int64 992 6.2M | repo_files_without_tests_count int64 12 28.1k | changed_symbols_count int64 0 36.1k | changed_tokens_count int64 0 6.5k | changed_lines_count int64 0 561 | changed_files_without_tests_count int64 1 17 | issue_symbols_count int64 45 21.3k | issue_words_count int64 2 1.39k | issue_tokens_count int64 13 4.47k | issue_lines_count int64 1 325 | issue_links_count int64 0 19 | issue_code_blocks_count int64 0 31 | pull_create_at timestamp[s] | repo_stars int64 10 44.3k | repo_language stringclasses 8
values | repo_languages stringclasses 296
values | repo_license stringclasses 2
values |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
9,883 | clickhouse/clickhouse-java/1070/1069 | clickhouse | clickhouse-java | https://github.com/ClickHouse/clickhouse-java/issues/1069 | https://github.com/ClickHouse/clickhouse-java/pull/1070 | https://github.com/ClickHouse/clickhouse-java/pull/1070 | 1 | fixes | BasicAuthentication Support | Is basic authentication supported in the most recent version of the clickhouse JDBC drivers? (`clickhouse-jdbc-0.3.2-patch11` is my version).
I found an older PR saying that everyone got switched over https://github.com/ClickHouse/clickhouse-jdbc/issues/522, but looks like it may not be true in the most revent versi... | 4077e59b845f7d8f95a221dbedea233dbc04b8c8 | 12b95acc6af2a0bc8770a1b68a4855b822233d70 | https://github.com/clickhouse/clickhouse-java/compare/4077e59b845f7d8f95a221dbedea233dbc04b8c8...12b95acc6af2a0bc8770a1b68a4855b822233d70 | diff --git a/clickhouse-client/src/test/java/com/clickhouse/client/BaseIntegrationTest.java b/clickhouse-client/src/test/java/com/clickhouse/client/BaseIntegrationTest.java
index 578825d3..7a4e8fd4 100644
--- a/clickhouse-client/src/test/java/com/clickhouse/client/BaseIntegrationTest.java
+++ b/clickhouse-client/src/te... | ['clickhouse-http-client/src/main/java/com/clickhouse/client/http/ClickHouseHttpConnection.java', 'clickhouse-http-client/src/main/java/com/clickhouse/client/http/HttpUrlConnectionImpl.java', 'clickhouse-http-client/src/test/java/com/clickhouse/client/http/ClickHouseHttpClientTest.java', 'clickhouse-http-client/src/mai... | {'.java': 9} | 9 | 9 | 0 | 0 | 9 | 2,583,913 | 538,949 | 76,365 | 333 | 11,700 | 2,194 | 195 | 6 | 913 | 109 | 220 | 7 | 2 | 0 | 1970-01-01T00:27:42 | 1,272 | Java | {'Java': 3989428, 'Shell': 397} | Apache License 2.0 |
9,888 | clickhouse/clickhouse-java/940/920 | clickhouse | clickhouse-java | https://github.com/ClickHouse/clickhouse-java/issues/920 | https://github.com/ClickHouse/clickhouse-java/pull/940 | https://github.com/ClickHouse/clickhouse-java/pull/940 | 1 | closes | Multiple values insert prepared statement | [QUESTION] about multiple values in prepared statement.
Probably, after this [COMMIT](https://github.com/ClickHouse/clickhouse-jdbc/commit/09cd66e564966d76d72f996754dbf8311bf1b49d)
between **patch5** and **patch6** and later versions.
I can't anymore use multiple values in prepared statement, like
`PreparedState... | 44a1986ba59705fd1254af9705c315d5853e91c8 | 7db110ff8cf708c59121adcbb8a7684fd74f87ec | https://github.com/clickhouse/clickhouse-java/compare/44a1986ba59705fd1254af9705c315d5853e91c8...7db110ff8cf708c59121adcbb8a7684fd74f87ec | diff --git a/clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/internal/ClickHouseConnectionImpl.java b/clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/internal/ClickHouseConnectionImpl.java
index ebef724b..3df1afb6 100644
--- a/clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/internal/ClickHouseConnectionImpl.java
... | ['clickhouse-jdbc/src/test/java/com/clickhouse/jdbc/ClickHousePreparedStatementTest.java', 'clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/internal/ClickHouseConnectionImpl.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 2,375,543 | 497,493 | 71,031 | 324 | 1,201 | 216 | 19 | 1 | 1,111 | 108 | 289 | 17 | 2 | 0 | 1970-01-01T00:27:33 | 1,272 | Java | {'Java': 3989428, 'Shell': 397} | Apache License 2.0 |
9,889 | clickhouse/clickhouse-java/901/889 | clickhouse | clickhouse-java | https://github.com/ClickHouse/clickhouse-java/issues/889 | https://github.com/ClickHouse/clickhouse-java/pull/901 | https://github.com/ClickHouse/clickhouse-java/pull/901 | 1 | closes | ClickHouseColumn bug when parsing a tuple type | Hi.
There is a bug or unexpected behavior in ClickHouseColumn when parsing a tuple type:
`ClickHouseColumn.parse("col_name Tuple(s String, i Int64)")` is throwing the following exception:
```
java.lang.IllegalArgumentException: Unknown data type: s String
```
My use case retrieves the types with a `DESCRIBE... | b76a2eefb97802eefe02f7cae83c591d285610d3 | 2c7bf7773bfc09dd3708c63623c90d14fd97084f | https://github.com/clickhouse/clickhouse-java/compare/b76a2eefb97802eefe02f7cae83c591d285610d3...2c7bf7773bfc09dd3708c63623c90d14fd97084f | diff --git a/clickhouse-client/src/main/java/com/clickhouse/client/ClickHouseColumn.java b/clickhouse-client/src/main/java/com/clickhouse/client/ClickHouseColumn.java
index 34011606..aac9dc41 100644
--- a/clickhouse-client/src/main/java/com/clickhouse/client/ClickHouseColumn.java
+++ b/clickhouse-client/src/main/java/c... | ['clickhouse-client/src/main/java/com/clickhouse/client/ClickHouseDataType.java', 'clickhouse-client/src/main/java/com/clickhouse/client/ClickHouseColumn.java', 'clickhouse-client/src/test/java/com/clickhouse/client/ClickHouseColumnTest.java'] | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 2,244,194 | 470,925 | 67,358 | 308 | 2,249 | 415 | 34 | 2 | 380 | 49 | 83 | 10 | 0 | 1 | 1970-01-01T00:27:30 | 1,272 | Java | {'Java': 3989428, 'Shell': 397} | Apache License 2.0 |
9,890 | clickhouse/clickhouse-java/658/657 | clickhouse | clickhouse-java | https://github.com/ClickHouse/clickhouse-java/issues/657 | https://github.com/ClickHouse/clickhouse-java/pull/658 | https://github.com/ClickHouse/clickhouse-java/pull/658 | 1 | fixes | Incorrect value returned from getAutoCommit | Since transactions are implicitly enabled for new connections (they are not supported at all), the `getAutoCommit` should return true. | 339453f5173dd7a064051d31876c81baad38decd | 5ca9485fe76bce8e5e8cb4effcaa74b4ffc5a089 | https://github.com/clickhouse/clickhouse-java/compare/339453f5173dd7a064051d31876c81baad38decd...5ca9485fe76bce8e5e8cb4effcaa74b4ffc5a089 | diff --git a/clickhouse-jdbc/src/main/java/ru/yandex/clickhouse/ClickHouseConnectionImpl.java b/clickhouse-jdbc/src/main/java/ru/yandex/clickhouse/ClickHouseConnectionImpl.java
index 6ec960ca..0b498c6a 100644
--- a/clickhouse-jdbc/src/main/java/ru/yandex/clickhouse/ClickHouseConnectionImpl.java
+++ b/clickhouse-jdbc/sr... | ['clickhouse-jdbc/src/main/java/ru/yandex/clickhouse/ClickHouseConnectionImpl.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 586,216 | 121,413 | 17,745 | 101 | 44 | 8 | 2 | 1 | 134 | 19 | 26 | 1 | 0 | 0 | 1970-01-01T00:27:00 | 1,272 | Java | {'Java': 3989428, 'Shell': 397} | Apache License 2.0 |
9,891 | clickhouse/clickhouse-java/540/462 | clickhouse | clickhouse-java | https://github.com/ClickHouse/clickhouse-java/issues/462 | https://github.com/ClickHouse/clickhouse-java/pull/540 | https://github.com/ClickHouse/clickhouse-java/pull/540 | 1 | fix | NoHttpResponseException while intensive inserts | Hi!
I catch an error using sendStream in RowBinary format intensive queries(1M rows in batch every 3 second) One batch inserts in ~10-15 seconds.
Clickhouse machine cpu usage is about 25%.
It appears after 5 minutes of job start.
I tried to catch problematic batch and insert in separately. Everything was fine.
... | 8e68aa489d21fcb4a0f4d48c05028f804f048169 | f90acb005c077b4b82dbb6d6d92d64930cef4d4d | https://github.com/clickhouse/clickhouse-java/compare/8e68aa489d21fcb4a0f4d48c05028f804f048169...f90acb005c077b4b82dbb6d6d92d64930cef4d4d | diff --git a/src/main/java/ru/yandex/clickhouse/settings/ClickHouseConnectionSettings.java b/src/main/java/ru/yandex/clickhouse/settings/ClickHouseConnectionSettings.java
index 202574fe..6928a340 100644
--- a/src/main/java/ru/yandex/clickhouse/settings/ClickHouseConnectionSettings.java
+++ b/src/main/java/ru/yandex/cli... | ['src/test/java/ru/yandex/clickhouse/util/ClickHouseHttpClientBuilderTest.java', 'src/main/java/ru/yandex/clickhouse/util/ClickHouseHttpClientBuilder.java', 'src/main/java/ru/yandex/clickhouse/settings/ClickHouseConnectionSettings.java', 'src/main/java/ru/yandex/clickhouse/settings/ClickHouseProperties.java'] | {'.java': 4} | 4 | 4 | 0 | 0 | 4 | 437,607 | 90,987 | 13,597 | 69 | 3,050 | 557 | 63 | 3 | 9,958 | 698 | 2,975 | 131 | 1 | 5 | 1970-01-01T00:26:50 | 1,272 | Java | {'Java': 3989428, 'Shell': 397} | Apache License 2.0 |
9,882 | clickhouse/clickhouse-java/1082/1072 | clickhouse | clickhouse-java | https://github.com/ClickHouse/clickhouse-java/issues/1072 | https://github.com/ClickHouse/clickhouse-java/pull/1082 | https://github.com/ClickHouse/clickhouse-java/pull/1082 | 1 | fixes | File data insert using CSVWithNames is failing since v0.3.2-patch10 | We are using ClickHouse JDBC driver to import CSV files that include a header line with column names. Here is the JRuby code that we use https://github.com/rsim/mondrian-olap/blob/master/spec/rake_tasks.rb#L377-L380
```ruby
conn.jdbc_connection.createStatement.write.
query("INSERT INTO #{table_name}(#{columns_stri... | 94a5e7c2921047bfe907fbdf6aea2feaed3c2417 | fe4e199876c89df9d99bf08e0ef9f9c50d2814b8 | https://github.com/clickhouse/clickhouse-java/compare/94a5e7c2921047bfe907fbdf6aea2feaed3c2417...fe4e199876c89df9d99bf08e0ef9f9c50d2814b8 | diff --git a/clickhouse-cli-client/src/main/java/com/clickhouse/client/cli/ClickHouseCommandLine.java b/clickhouse-cli-client/src/main/java/com/clickhouse/client/cli/ClickHouseCommandLine.java
index 5565b2aa..c4835963 100644
--- a/clickhouse-cli-client/src/main/java/com/clickhouse/client/cli/ClickHouseCommandLine.java
... | ['clickhouse-cli-client/src/main/java/com/clickhouse/client/cli/ClickHouseCommandLine.java', 'clickhouse-client/src/main/java/com/clickhouse/client/ClickHouseRequest.java', 'clickhouse-client/src/test/java/com/clickhouse/client/ClientIntegrationTest.java'] | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 2,642,550 | 550,548 | 78,098 | 354 | 295 | 59 | 6 | 2 | 2,073 | 149 | 528 | 27 | 2 | 2 | 1970-01-01T00:27:42 | 1,272 | Java | {'Java': 3989428, 'Shell': 397} | Apache License 2.0 |
9,886 | clickhouse/clickhouse-java/981/977 | clickhouse | clickhouse-java | https://github.com/ClickHouse/clickhouse-java/issues/977 | https://github.com/ClickHouse/clickhouse-java/pull/981 | https://github.com/ClickHouse/clickhouse-java/pull/981 | 1 | fix | Question about emptyBatchError | Currently, I use Flink JDBC + CK Driver to write data to clickhouse in real time, and there is a high probability of encountering the following errors , So maybe we can support writing empty batch ?
```
Caused by: java.lang.RuntimeException: Writing records to JDBC failed.
at org.apache.flink.connector.jdbc.intern... | e59bd468c1e1b049d84a0a8183758740735e8e9a | 844b2b8013b3af7f51e2fa66f8335b50f47cc157 | https://github.com/clickhouse/clickhouse-java/compare/e59bd468c1e1b049d84a0a8183758740735e8e9a...844b2b8013b3af7f51e2fa66f8335b50f47cc157 | diff --git a/clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/SqlExceptionUtils.java b/clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/SqlExceptionUtils.java
index da5b824b..25b3ffe3 100644
--- a/clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/SqlExceptionUtils.java
+++ b/clickhouse-jdbc/src/main/java/com/clickhou... | ['clickhouse-jdbc/src/test/java/com/clickhouse/jdbc/ClickHouseStatementTest.java', 'clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/internal/SqlBasedPreparedStatement.java', 'clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/internal/ClickHouseConnectionImpl.java', 'clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/S... | {'.java': 8} | 8 | 8 | 0 | 0 | 8 | 2,480,744 | 518,734 | 73,778 | 328 | 815 | 143 | 16 | 6 | 4,890 | 164 | 976 | 51 | 0 | 1 | 1970-01-01T00:27:36 | 1,272 | Java | {'Java': 3989428, 'Shell': 397} | Apache License 2.0 |
9,884 | clickhouse/clickhouse-java/1019/947 | clickhouse | clickhouse-java | https://github.com/ClickHouse/clickhouse-java/issues/947 | https://github.com/ClickHouse/clickhouse-java/pull/1019 | https://github.com/ClickHouse/clickhouse-java/pull/1019 | 1 | closes | Incorrect update count (0.3.2-patch9) | Hi!
In `com.clickhouse.jdbc.internal.ClickHouseStatementImpl#updateResult`:
```
...
// FIXME apparently this is not always true
if (currentUpdateCount <= 0L) {
currentUpdateCount = 1L;
}
...
```
Yes, this isn’t always true :)
**Examples:**
```
Statement statement = connection.createStatement... | cdaf8f3f6cfd7c7227df00284a71f58b9399838a | 5f6d8b7ab6c0bd23db36ef807975b8f52c2f9abf | https://github.com/clickhouse/clickhouse-java/compare/cdaf8f3f6cfd7c7227df00284a71f58b9399838a...5f6d8b7ab6c0bd23db36ef807975b8f52c2f9abf | diff --git a/clickhouse-client/src/main/java/com/clickhouse/client/ClickHouseResponseSummary.java b/clickhouse-client/src/main/java/com/clickhouse/client/ClickHouseResponseSummary.java
index c75c9b8a..33bc639b 100644
--- a/clickhouse-client/src/main/java/com/clickhouse/client/ClickHouseResponseSummary.java
+++ b/clickh... | ['clickhouse-client/src/main/java/com/clickhouse/client/ClickHouseResponseSummary.java', 'clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/internal/ClickHouseStatementImpl.java', 'clickhouse-jdbc/src/test/java/com/clickhouse/jdbc/ClickHousePreparedStatementTest.java', 'clickhouse-jdbc/src/test/java/com/clickhouse/jdbc... | {'.java': 4} | 4 | 4 | 0 | 0 | 4 | 2,556,449 | 533,465 | 75,659 | 332 | 3,580 | 753 | 84 | 2 | 641 | 76 | 165 | 30 | 0 | 2 | 1970-01-01T00:27:39 | 1,272 | Java | {'Java': 3989428, 'Shell': 397} | Apache License 2.0 |
9,885 | clickhouse/clickhouse-java/982/979 | clickhouse | clickhouse-java | https://github.com/ClickHouse/clickhouse-java/issues/979 | https://github.com/ClickHouse/clickhouse-java/pull/982 | https://github.com/ClickHouse/clickhouse-java/pull/982 | 1 | fix | ResultSet getObject with class return null values filled as it was not null | When selecting values from table with getObject(index, Class)
simple types (like float/int/boolean) return 0/false as result (when null is expected).
```
CREATE TABLE db.tbl
(
id int not null,
double_col double,
float_col float,
varchar_col varchar(36),
boolean_col boolean,
int_col int,
... | 2f2f2eae501e59453aa0b8a77581cbe99f3949d3 | 70612d802499ed8d64a989932beb21853c62e73d | https://github.com/clickhouse/clickhouse-java/compare/2f2f2eae501e59453aa0b8a77581cbe99f3949d3...70612d802499ed8d64a989932beb21853c62e73d | diff --git a/clickhouse-client/src/main/java/com/clickhouse/client/ClickHouseValue.java b/clickhouse-client/src/main/java/com/clickhouse/client/ClickHouseValue.java
index e13bceb1..b55fc5df 100644
--- a/clickhouse-client/src/main/java/com/clickhouse/client/ClickHouseValue.java
+++ b/clickhouse-client/src/main/java/com/... | ['clickhouse-client/src/main/java/com/clickhouse/client/data/ClickHouseBitmapValue.java', 'clickhouse-client/src/main/java/com/clickhouse/client/data/ClickHouseNestedValue.java', 'clickhouse-client/src/main/java/com/clickhouse/client/data/array/ClickHouseLongArrayValue.java', 'clickhouse-client/src/main/java/com/clickh... | {'.java': 16} | 16 | 16 | 0 | 0 | 16 | 2,480,675 | 518,723 | 73,776 | 328 | 1,595 | 339 | 84 | 15 | 722 | 96 | 197 | 24 | 0 | 1 | 1970-01-01T00:27:36 | 1,272 | Java | {'Java': 3989428, 'Shell': 397} | Apache License 2.0 |
8,930 | gradle/gradle-profiler/457/456 | gradle | gradle-profiler | https://github.com/gradle/gradle-profiler/issues/456 | https://github.com/gradle/gradle-profiler/pull/457 | https://github.com/gradle/gradle-profiler/issues/456#issuecomment-1289037751 | 2 | fixes | Using `--profile yourkit` in Windows build failed with java.lang.NullPointerException | ### Environment
gradle-profiler version: 0.19.0
YourKit version: 2022.9
**Crash log**
```
java.lang.NullPointerException
at org.gradle.profiler.yourkit.YourKitJvmArgsCalculator.calculateJvmArgs(YourKitJvmArgsCalculator.java:33)
at org.gradle.profiler.GradleScenarioInvoker.run(GradleScenarioInvo... | 5f376813f3042714121b41985e52a57dc9665e54 | bb4a3b0b8412c80bb2ed7dea4acb4654e31d28d1 | https://github.com/gradle/gradle-profiler/compare/5f376813f3042714121b41985e52a57dc9665e54...bb4a3b0b8412c80bb2ed7dea4acb4654e31d28d1 | diff --git a/src/main/java/org/gradle/profiler/yourkit/YourKit.java b/src/main/java/org/gradle/profiler/yourkit/YourKit.java
index d1f5cf55..e6cb56d6 100644
--- a/src/main/java/org/gradle/profiler/yourkit/YourKit.java
+++ b/src/main/java/org/gradle/profiler/yourkit/YourKit.java
@@ -38,7 +38,7 @@ public static File find... | ['src/main/java/org/gradle/profiler/yourkit/YourKit.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 563,537 | 111,022 | 14,982 | 237 | 180 | 48 | 2 | 1 | 977 | 61 | 260 | 26 | 1 | 1 | 1970-01-01T00:27:46 | 1,265 | Java | {'Java': 569946, 'Groovy': 279034, 'Perl': 35996, 'Kotlin': 28566, 'HTML': 16578, 'JavaScript': 9668, 'XSLT': 1566} | Apache License 2.0 |
1,086 | google/conscrypt/920/902 | google | conscrypt | https://github.com/google/conscrypt/issues/902 | https://github.com/google/conscrypt/pull/920 | https://github.com/google/conscrypt/pull/920 | 1 | fixes | isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards | I would like to report a minor bug in Conscrypt's KeyFactorySpi.engineGetKeySpec implementations. This bug appears to impact both [OpenSSLRSAKeyFactory](https://github.com/google/conscrypt/blob/6e29d195147e73f824ae3a7576f791eb4bb165df/common/src/main/java/org/conscrypt/OpenSSLRSAKeyFactory.java#L77-L181) and [OpenSSLEC... | ae487934dcc1ec3d3c37a6084b07632f7ef76d38 | 46ed27fda6350590b148a77037e2000e6f6ba1f7 | https://github.com/google/conscrypt/compare/ae487934dcc1ec3d3c37a6084b07632f7ef76d38...46ed27fda6350590b148a77037e2000e6f6ba1f7 | diff --git a/common/src/main/java/org/conscrypt/OpenSSLECKeyFactory.java b/common/src/main/java/org/conscrypt/OpenSSLECKeyFactory.java
index 596e8711..b10e3391 100644
--- a/common/src/main/java/org/conscrypt/OpenSSLECKeyFactory.java
+++ b/common/src/main/java/org/conscrypt/OpenSSLECKeyFactory.java
@@ -87,12 +87,12 @@ p... | ['common/src/main/java/org/conscrypt/OpenSSLRSAKeyFactory.java', 'common/src/main/java/org/conscrypt/OpenSSLECKeyFactory.java', 'common/src/test/java/org/conscrypt/java/security/KeyFactoryTestRSA.java', 'common/src/test/java/org/conscrypt/java/security/KeyFactoryTestEC.java'] | {'.java': 4} | 4 | 4 | 0 | 0 | 4 | 1,780,545 | 390,735 | 48,160 | 250 | 2,630 | 537 | 30 | 2 | 3,566 | 343 | 769 | 54 | 3 | 1 | 1970-01-01T00:26:44 | 1,164 | Java | {'Java': 3533745, 'C++': 526129, 'C': 7529, 'Python': 6764, 'Shell': 5171, 'Dockerfile': 3414, 'CMake': 1784, 'PowerShell': 1675, 'Batchfile': 1140, 'HTML': 756} | Apache License 2.0 |
1,087 | google/conscrypt/843/840 | google | conscrypt | https://github.com/google/conscrypt/issues/840 | https://github.com/google/conscrypt/pull/843 | https://github.com/google/conscrypt/pull/843 | 1 | fixes | SSLEngine.beginHandshake() should throw SSLException after it was closed | During testing conscrypt in the netty testsuite we encountered that Conscrypt does not correct implement SSLEngine.beginHandshake().
See https://github.com/netty/netty/pull/10211/files#diff-08da41869dfc1d842df441440b1c605bR2084
If you call `beginHandshake()` after the engine was closed it must throw an `SSLExcept... | 78433b95e34e7455a2dcd6aedfbf5708f34c1650 | 2f7404fa4ca6de8683dbeb75f732cd4ad7235395 | https://github.com/google/conscrypt/compare/78433b95e34e7455a2dcd6aedfbf5708f34c1650...2f7404fa4ca6de8683dbeb75f732cd4ad7235395 | diff --git a/common/src/main/java/org/conscrypt/ConscryptEngine.java b/common/src/main/java/org/conscrypt/ConscryptEngine.java
index f1eedcc7..8df11b5b 100644
--- a/common/src/main/java/org/conscrypt/ConscryptEngine.java
+++ b/common/src/main/java/org/conscrypt/ConscryptEngine.java
@@ -413,7 +413,7 @@ final class Consc... | ['common/src/main/java/org/conscrypt/ConscryptEngine.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,750,377 | 384,313 | 47,402 | 245 | 167 | 25 | 2 | 1 | 479 | 42 | 127 | 8 | 2 | 0 | 1970-01-01T00:26:28 | 1,164 | Java | {'Java': 3533745, 'C++': 526129, 'C': 7529, 'Python': 6764, 'Shell': 5171, 'Dockerfile': 3414, 'CMake': 1784, 'PowerShell': 1675, 'Batchfile': 1140, 'HTML': 756} | Apache License 2.0 |
1,089 | google/conscrypt/785/781 | google | conscrypt | https://github.com/google/conscrypt/issues/781 | https://github.com/google/conscrypt/pull/785 | https://github.com/google/conscrypt/pull/785 | 1 | fixes | NullPointerException in getAlpnSelectedProtocol | We’ve got the exact same crash as #379 but this time we’re calling `getAlpnSelectedProtocol()` instead of `getProtocol()`. I presume the same fix will work: cache more session state when the connection is closed.
```
FATAL EXCEPTION: MockWebServer
Process: com.xxx.xxx.xxx, PID: 5607
java.lang.AssertionError: java... | d2aa6104ac4a9c92a36213bce65f144efdcd1a1b | d28d0a8d85a0461baa1cb29aec8dd813384f2ee1 | https://github.com/google/conscrypt/compare/d2aa6104ac4a9c92a36213bce65f144efdcd1a1b...d28d0a8d85a0461baa1cb29aec8dd813384f2ee1 | diff --git a/common/src/main/java/org/conscrypt/ActiveSession.java b/common/src/main/java/org/conscrypt/ActiveSession.java
index 4726499a..b00a3fa5 100644
--- a/common/src/main/java/org/conscrypt/ActiveSession.java
+++ b/common/src/main/java/org/conscrypt/ActiveSession.java
@@ -37,6 +37,7 @@ final class ActiveSession i... | ['common/src/main/java/org/conscrypt/ActiveSession.java', 'common/src/main/java/org/conscrypt/SessionSnapshot.java', 'common/src/main/java/org/conscrypt/ConscryptFileDescriptorSocket.java', 'openjdk/src/test/java/org/conscrypt/ConscryptSocketTest.java', 'openjdk/src/test/java/org/conscrypt/ConscryptEngineTest.java', 'c... | {'.java': 9} | 9 | 9 | 0 | 0 | 9 | 1,746,819 | 383,662 | 47,311 | 245 | 3,562 | 589 | 65 | 7 | 1,558 | 87 | 357 | 26 | 0 | 1 | 1970-01-01T00:26:13 | 1,164 | Java | {'Java': 3533745, 'C++': 526129, 'C': 7529, 'Python': 6764, 'Shell': 5171, 'Dockerfile': 3414, 'CMake': 1784, 'PowerShell': 1675, 'Batchfile': 1140, 'HTML': 756} | Apache License 2.0 |
1,090 | google/conscrypt/784/783 | google | conscrypt | https://github.com/google/conscrypt/issues/783 | https://github.com/google/conscrypt/pull/784 | https://github.com/google/conscrypt/pull/784 | 1 | fixes | Possible java.util.ConcurrentModificationException when notifying handshake listeners | The listeners should be iterated that allows modification of the underlying list (such as using `toArray`). The listener implementation might remove the listener using `removeHandshakeCompletedListener` when notified.
```
Caused by: java.util.ConcurrentModificationException
at java.base/java.util.ArrayList$Itr.... | d2aa6104ac4a9c92a36213bce65f144efdcd1a1b | 8ba5432c469d73062bd7e56f355729415e7a22ba | https://github.com/google/conscrypt/compare/d2aa6104ac4a9c92a36213bce65f144efdcd1a1b...8ba5432c469d73062bd7e56f355729415e7a22ba | diff --git a/common/src/main/java/org/conscrypt/AbstractConscryptSocket.java b/common/src/main/java/org/conscrypt/AbstractConscryptSocket.java
index 7d67285b..1fe7a238 100644
--- a/common/src/main/java/org/conscrypt/AbstractConscryptSocket.java
+++ b/common/src/main/java/org/conscrypt/AbstractConscryptSocket.java
@@ -5... | ['common/src/main/java/org/conscrypt/AbstractConscryptSocket.java', 'common/src/test/java/org/conscrypt/javax/net/ssl/SSLSocketVersionCompatibilityTest.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,746,819 | 383,662 | 47,311 | 245 | 326 | 61 | 5 | 1 | 978 | 53 | 230 | 15 | 0 | 1 | 1970-01-01T00:26:13 | 1,164 | Java | {'Java': 3533745, 'C++': 526129, 'C': 7529, 'Python': 6764, 'Shell': 5171, 'Dockerfile': 3414, 'CMake': 1784, 'PowerShell': 1675, 'Batchfile': 1140, 'HTML': 756} | Apache License 2.0 |
1,088 | google/conscrypt/809/801 | google | conscrypt | https://github.com/google/conscrypt/issues/801 | https://github.com/google/conscrypt/pull/809 | https://github.com/google/conscrypt/pull/809 | 1 | fixes | resource stream leak on android | see log below from conscrypt 2.2.1 (2.3.0 is not yet available for android?)
(tested on android 4.4)
E/StrictMode: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.
java.lang.Throwable: Explicit termination method 'end' not c... | dec987186b9d716dd8814e7d22a61796c416e08c | 64d4b3cbc43ca52b6b5784d3093637f7ada9bdde | https://github.com/google/conscrypt/compare/dec987186b9d716dd8814e7d22a61796c416e08c...64d4b3cbc43ca52b6b5784d3093637f7ada9bdde | diff --git a/common/src/main/java/org/conscrypt/Conscrypt.java b/common/src/main/java/org/conscrypt/Conscrypt.java
index c562a69b..42440fdd 100644
--- a/common/src/main/java/org/conscrypt/Conscrypt.java
+++ b/common/src/main/java/org/conscrypt/Conscrypt.java
@@ -34,6 +34,7 @@ import javax.net.ssl.SSLSocket;
import jav... | ['common/src/main/java/org/conscrypt/Conscrypt.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,748,656 | 384,000 | 47,366 | 245 | 311 | 59 | 6 | 1 | 932 | 62 | 217 | 15 | 0 | 0 | 1970-01-01T00:26:21 | 1,164 | Java | {'Java': 3533745, 'C++': 526129, 'C': 7529, 'Python': 6764, 'Shell': 5171, 'Dockerfile': 3414, 'CMake': 1784, 'PowerShell': 1675, 'Batchfile': 1140, 'HTML': 756} | Apache License 2.0 |
9,341 | dtstack/taier/657/655 | dtstack | taier | https://github.com/DTStack/Taier/issues/655 | https://github.com/DTStack/Taier/pull/657 | https://github.com/DTStack/Taier/pull/657 | 1 | fix | 资源组件HiveServer连接测试失败 | 报错信息：
{"componentTypeCode":0,"errorMsg":"com.dtstack.taier.pluginapi.exception.PluginDefineException: get conn exception:com.dtstack.taier.pluginapi.exception.PluginDefineException: get conn exception:com.dtstack.taier.pluginapi.exception.PluginDefineException: java.lang.NullPointerException\\r\\ncom.dtstack.taier.pl... | 6f5f2e15ae6a25583d6ddc19fc0147147f8081cb | c125025e67ad7bc0a2414634671adfb3ec3e4b9c | https://github.com/dtstack/taier/compare/6f5f2e15ae6a25583d6ddc19fc0147147f8081cb...c125025e67ad7bc0a2414634671adfb3ec3e4b9c | diff --git a/taier-data-develop/src/main/java/com/dtstack/taier/develop/service/console/ConsoleComponentService.java b/taier-data-develop/src/main/java/com/dtstack/taier/develop/service/console/ConsoleComponentService.java
index 2847d19f..c1e9fbc8 100644
--- a/taier-data-develop/src/main/java/com/dtstack/taier/develop/... | ['taier-data-develop/src/main/java/com/dtstack/taier/develop/service/console/ConsoleComponentService.java', 'taier-data-develop/src/main/java/com/dtstack/taier/develop/service/console/ConsoleService.java', 'taier-scheduler/src/main/java/com/dtstack/taier/scheduler/service/ComponentService.java'] | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 6,139,810 | 1,336,390 | 184,706 | 1,386 | 1,552 | 315 | 17 | 3 | 3,499 | 133 | 823 | 40 | 0 | 0 | 1970-01-01T00:27:39 | 1,159 | Java | {'Java': 9989416, 'TypeScript': 2279705, 'CSS': 713033, 'PLpgSQL': 515685, 'Scala': 85975, 'SCSS': 76346, 'JavaScript': 37746, 'Shell': 5499, 'Dockerfile': 1573, 'Mustache': 241} | Apache License 2.0 |
228 | mekanism/mekanism/4868/4852 | mekanism | mekanism | https://github.com/mekanism/Mekanism/issues/4852 | https://github.com/mekanism/Mekanism/pull/4868 | https://github.com/mekanism/Mekanism/pull/4868 | 1 | fixes | [1.12] Electrolytic Separator + Energy Upgrades = Hydrogen Power | #### Issue description:
The Electrolytic Separator accepts Energy Upgrades. In the past, this only increased the energy capacity. The Electrolytic Separator was the only machine to not receive a boost in efficiency in order to prevent an infinite energy loop using Hydrogen Gas.
The Electrolytic Separator currentl... | f09f8d28384592b7f16318b0ec04ad6c4faf218b | b8a83fb9ef6c0ac3499fd6f798556cd85c52aebe | https://github.com/mekanism/mekanism/compare/f09f8d28384592b7f16318b0ec04ad6c4faf218b...b8a83fb9ef6c0ac3499fd6f798556cd85c52aebe | diff --git a/src/main/java/mekanism/common/tile/TileEntityElectrolyticSeparator.java b/src/main/java/mekanism/common/tile/TileEntityElectrolyticSeparator.java
index 15fe5ff389..26df3dd624 100644
--- a/src/main/java/mekanism/common/tile/TileEntityElectrolyticSeparator.java
+++ b/src/main/java/mekanism/common/tile/TileEn... | ['src/main/java/mekanism/common/tile/TileEntityElectrolyticSeparator.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 4,185,091 | 1,116,250 | 145,081 | 928 | 411 | 103 | 17 | 1 | 866 | 136 | 214 | 15 | 0 | 0 | 1970-01-01T00:25:13 | 1,137 | Java | {'Java': 10634221, 'ZenScript': 66932, 'Groovy': 7193, 'Perl': 4725, 'GLSL': 4576, 'JavaScript': 1156, 'Python': 511} | MIT License |
237 | mekanism/mekanism/4544/3613 | mekanism | mekanism | https://github.com/mekanism/Mekanism/issues/3613 | https://github.com/mekanism/Mekanism/pull/4544 | https://github.com/mekanism/Mekanism/pull/4544 | 1 | fixes | [1.10.2] Cardboard box deletes Advanced Solar Generator when boxing the base of it. | The box and the Advanced Solar Generator just straight up disappear, never to be seen again.
| b3f1a9fee43e6aec5689664f268fa6dbeebb50b0 | 6ba975b84f792322472582edf21bcf9d65394f5a | https://github.com/mekanism/mekanism/compare/b3f1a9fee43e6aec5689664f268fa6dbeebb50b0...6ba975b84f792322472582edf21bcf9d65394f5a | diff --git a/src/main/java/mekanism/common/Mekanism.java b/src/main/java/mekanism/common/Mekanism.java
index a2860b183e..4033bc2254 100644
--- a/src/main/java/mekanism/common/Mekanism.java
+++ b/src/main/java/mekanism/common/Mekanism.java
@@ -1426,11 +1426,21 @@ public class Mekanism
public void onBlacklistUpdate(Box... | ['src/main/java/mekanism/generators/common/MekanismGenerators.java', 'src/main/java/mekanism/common/Mekanism.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 4,691,959 | 1,234,542 | 161,646 | 1,283 | 800 | 230 | 19 | 2 | 93 | 16 | 18 | 2 | 0 | 0 | 1970-01-01T00:25:00 | 1,137 | Java | {'Java': 10634221, 'ZenScript': 66932, 'Groovy': 7193, 'Perl': 4725, 'GLSL': 4576, 'JavaScript': 1156, 'Python': 511} | MIT License |
236 | mekanism/mekanism/4549/3534 | mekanism | mekanism | https://github.com/mekanism/Mekanism/issues/3534 | https://github.com/mekanism/Mekanism/pull/4549 | https://github.com/mekanism/Mekanism/pull/4549 | 1 | fixes | [Issue] Tesselating block model | Hi,
Random client crash when i'm in my base, it seems to begin to happen since i've built a boiler.
Crash log : http://pastebin.com/qQqD8yf6
| b3f1a9fee43e6aec5689664f268fa6dbeebb50b0 | 4614c6775059b2533b7427b26a8d9e079f38805c | https://github.com/mekanism/mekanism/compare/b3f1a9fee43e6aec5689664f268fa6dbeebb50b0...4614c6775059b2533b7427b26a8d9e079f38805c | diff --git a/src/main/java/mekanism/common/block/BlockBasic.java b/src/main/java/mekanism/common/block/BlockBasic.java
index 6be823ca10..f420ff9d59 100644
--- a/src/main/java/mekanism/common/block/BlockBasic.java
+++ b/src/main/java/mekanism/common/block/BlockBasic.java
@@ -158,8 +158,8 @@ public abstract class BlockBa... | ['src/main/java/mekanism/generators/common/GeneratorsItems.java', 'src/main/java/mekanism/common/block/BlockMachine.java', 'src/main/java/mekanism/generators/common/block/BlockReactor.java', 'src/main/java/mekanism/common/block/BlockGlowPanel.java', 'src/main/java/mekanism/common/block/BlockGasTank.java', 'src/main/jav... | {'.java': 11} | 11 | 11 | 0 | 0 | 11 | 4,691,959 | 1,234,542 | 161,646 | 1,283 | 3,905 | 1,021 | 69 | 11 | 143 | 24 | 43 | 6 | 1 | 0 | 1970-01-01T00:25:00 | 1,137 | Java | {'Java': 10634221, 'ZenScript': 66932, 'Groovy': 7193, 'Perl': 4725, 'GLSL': 4576, 'JavaScript': 1156, 'Python': 511} | MIT License |
235 | mekanism/mekanism/4550/4484 | mekanism | mekanism | https://github.com/mekanism/Mekanism/issues/4484 | https://github.com/mekanism/Mekanism/pull/4550 | https://github.com/mekanism/Mekanism/pull/4550 | 1 | fixes | [1.11.2] Server Crash | #### Issue description:
Hello! A few days ago, our official pack server started crashing whenever someone is near a Mekanism machine (tested with a Metallurgic Infuser and Enrichment Chamber). At first we thought that it was all due to Mekanism, but today we figured out that it doesn't happen when the crafting recipe... | 7b1e965509307591e82df93cb364118650288cf1 | 4a7b457bfc7bb1703b9d220fdeeffee3b7504972 | https://github.com/mekanism/mekanism/compare/7b1e965509307591e82df93cb364118650288cf1...4a7b457bfc7bb1703b9d220fdeeffee3b7504972 | diff --git a/src/main/java/mekanism/common/content/transporter/TransporterManager.java b/src/main/java/mekanism/common/content/transporter/TransporterManager.java
index ca9cd31ed6..9609b648b4 100644
--- a/src/main/java/mekanism/common/content/transporter/TransporterManager.java
+++ b/src/main/java/mekanism/common/conte... | ['src/main/java/mekanism/common/frequency/Frequency.java', 'src/main/java/mekanism/common/entity/EntityRobit.java', 'src/main/java/mekanism/common/tile/TileEntitySecurityDesk.java', 'src/main/java/mekanism/common/content/transporter/TransporterManager.java', 'src/main/java/mekanism/common/tile/component/TileComponentSe... | {'.java': 7} | 7 | 7 | 0 | 0 | 7 | 4,695,748 | 1,235,555 | 161,733 | 1,283 | 2,160 | 484 | 45 | 7 | 889 | 147 | 236 | 11 | 1 | 0 | 1970-01-01T00:25:00 | 1,137 | Java | {'Java': 10634221, 'ZenScript': 66932, 'Groovy': 7193, 'Perl': 4725, 'GLSL': 4576, 'JavaScript': 1156, 'Python': 511} | MIT License |
234 | mekanism/mekanism/4551/4539 | mekanism | mekanism | https://github.com/mekanism/Mekanism/issues/4539 | https://github.com/mekanism/Mekanism/pull/4551 | https://github.com/mekanism/Mekanism/pull/4551 | 1 | fixes | [1.11.2] Placing water in a machine with a forestry tin can or capsule causes a ticking tile entity | Using a forestry tin can or capsule instead of a bucket in Mekanism machines causes ticking block crash.
1. Place electrolytic separator
2. Put water can in water slot
3. Crash
Mekanism 307
Forge 13.20.1.2386
Minecraft 1.11.2
Log:
https://paste.ee/p/oxUq9 | b3f1a9fee43e6aec5689664f268fa6dbeebb50b0 | 9106ac94a747bf5c59884e470ede5e19cc2a6e24 | https://github.com/mekanism/mekanism/compare/b3f1a9fee43e6aec5689664f268fa6dbeebb50b0...9106ac94a747bf5c59884e470ede5e19cc2a6e24 | diff --git a/src/main/java/mekanism/common/util/FluidContainerUtils.java b/src/main/java/mekanism/common/util/FluidContainerUtils.java
index 330829f5f9..37602c11c2 100644
--- a/src/main/java/mekanism/common/util/FluidContainerUtils.java
+++ b/src/main/java/mekanism/common/util/FluidContainerUtils.java
@@ -13,8 +13,10 @... | ['src/main/java/mekanism/common/util/FluidContainerUtils.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 4,691,959 | 1,234,542 | 161,646 | 1,283 | 1,237 | 280 | 24 | 1 | 269 | 39 | 80 | 12 | 1 | 0 | 1970-01-01T00:25:00 | 1,137 | Java | {'Java': 10634221, 'ZenScript': 66932, 'Groovy': 7193, 'Perl': 4725, 'GLSL': 4576, 'JavaScript': 1156, 'Python': 511} | MIT License |
233 | mekanism/mekanism/4552/4539 | mekanism | mekanism | https://github.com/mekanism/Mekanism/issues/4539 | https://github.com/mekanism/Mekanism/pull/4552 | https://github.com/mekanism/Mekanism/pull/4552 | 1 | fixes | [1.11.2] Placing water in a machine with a forestry tin can or capsule causes a ticking tile entity | Using a forestry tin can or capsule instead of a bucket in Mekanism machines causes ticking block crash.
1. Place electrolytic separator
2. Put water can in water slot
3. Crash
Mekanism 307
Forge 13.20.1.2386
Minecraft 1.11.2
Log:
https://paste.ee/p/oxUq9 | 46367a445ed8fc21871f15384f9a0ef0a68133c7 | 3815945d1efc4db3a3da7928cc868e1e4d5949a7 | https://github.com/mekanism/mekanism/compare/46367a445ed8fc21871f15384f9a0ef0a68133c7...3815945d1efc4db3a3da7928cc868e1e4d5949a7 | diff --git a/src/main/java/mekanism/common/util/FluidContainerUtils.java b/src/main/java/mekanism/common/util/FluidContainerUtils.java
index 330829f5f9..7fa9616a04 100644
--- a/src/main/java/mekanism/common/util/FluidContainerUtils.java
+++ b/src/main/java/mekanism/common/util/FluidContainerUtils.java
@@ -27,40 +27,46 ... | ['src/main/java/mekanism/common/util/FluidContainerUtils.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 4,369,978 | 1,164,709 | 152,470 | 1,050 | 2,400 | 560 | 53 | 1 | 269 | 39 | 80 | 12 | 1 | 0 | 1970-01-01T00:25:00 | 1,137 | Java | {'Java': 10634221, 'ZenScript': 66932, 'Groovy': 7193, 'Perl': 4725, 'GLSL': 4576, 'JavaScript': 1156, 'Python': 511} | MIT License |
229 | mekanism/mekanism/4752/4694 | mekanism | mekanism | https://github.com/mekanism/Mekanism/issues/4694 | https://github.com/mekanism/Mekanism/pull/4752 | https://github.com/mekanism/Mekanism/pull/4752 | 1 | fixes | [1.11.2] Logistical Sorter item filtering issue | #### Issue description:
Using the logistical sorter to sort the drops from a mob farm and I've run into an issue when trying to send items like bows ect which are damaged to a different location it will only filter the exact bow that was used to create the filter because it's using the metadata from that item.
With ... | 9c7164c0db3877538a6c525700b64d4353d20da5 | 6103bc2b119293dd5f15f95a2a3233538aaafff6 | https://github.com/mekanism/mekanism/compare/9c7164c0db3877538a6c525700b64d4353d20da5...6103bc2b119293dd5f15f95a2a3233538aaafff6 | diff --git a/src/main/java/mekanism/common/content/transporter/Finder.java b/src/main/java/mekanism/common/content/transporter/Finder.java
index 0d268be899..64c42a809d 100644
--- a/src/main/java/mekanism/common/content/transporter/Finder.java
+++ b/src/main/java/mekanism/common/content/transporter/Finder.java
@@ -87,7 ... | ['src/main/java/mekanism/common/content/transporter/Finder.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 4,100,917 | 1,095,234 | 142,504 | 907 | 177 | 37 | 2 | 1 | 1,558 | 265 | 347 | 17 | 1 | 0 | 1970-01-01T00:25:07 | 1,137 | Java | {'Java': 10634221, 'ZenScript': 66932, 'Groovy': 7193, 'Perl': 4725, 'GLSL': 4576, 'JavaScript': 1156, 'Python': 511} | MIT License |
232 | mekanism/mekanism/4562/4560 | mekanism | mekanism | https://github.com/mekanism/Mekanism/issues/4560 | https://github.com/mekanism/Mekanism/pull/4562 | https://github.com/mekanism/Mekanism/pull/4562 | 1 | fixes | [1.11.2] Energy side configuration doesn't respect block orientation | #### Issue description:
Regardless of which way a block is oriented the side configuration for energy always treats the faces as follows:
- Front is North
- Back is South
- Left is West
- Right is East
- Bottom is Down
- Top is Up
Also tested with items but this seems to be functioning as expected.
#### St... | 77e46985ac243728b3210edcac2592852149d628 | 90cf4cea0849e9937b703789449933c62f87400b | https://github.com/mekanism/mekanism/compare/77e46985ac243728b3210edcac2592852149d628...90cf4cea0849e9937b703789449933c62f87400b | diff --git a/src/main/java/mekanism/common/tile/TileEntityFactory.java b/src/main/java/mekanism/common/tile/TileEntityFactory.java
index 21c55246dd..5df3f9693f 100644
--- a/src/main/java/mekanism/common/tile/TileEntityFactory.java
+++ b/src/main/java/mekanism/common/tile/TileEntityFactory.java
@@ -394,6 +394,12 @@ publ... | ['src/main/java/mekanism/common/tile/TileEntityFactory.java', 'src/main/java/mekanism/common/tile/component/TileComponentConfig.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 4,388,554 | 1,169,528 | 153,214 | 1,052 | 675 | 172 | 16 | 2 | 750 | 127 | 181 | 22 | 0 | 0 | 1970-01-01T00:25:00 | 1,137 | Java | {'Java': 10634221, 'ZenScript': 66932, 'Groovy': 7193, 'Perl': 4725, 'GLSL': 4576, 'JavaScript': 1156, 'Python': 511} | MIT License |
231 | mekanism/mekanism/4567/4560 | mekanism | mekanism | https://github.com/mekanism/Mekanism/issues/4560 | https://github.com/mekanism/Mekanism/pull/4567 | https://github.com/mekanism/Mekanism/pull/4567 | 1 | fixes | [1.11.2] Energy side configuration doesn't respect block orientation | #### Issue description:
Regardless of which way a block is oriented the side configuration for energy always treats the faces as follows:
- Front is North
- Back is South
- Left is West
- Right is East
- Bottom is Down
- Top is Up
Also tested with items but this seems to be functioning as expected.
#### St... | 2a535733c1b5a5c38361acf5f3b267ea78efb165 | 341e11da7009aa077ff3c2240c504ec586d0a0fd | https://github.com/mekanism/mekanism/compare/2a535733c1b5a5c38361acf5f3b267ea78efb165...341e11da7009aa077ff3c2240c504ec586d0a0fd | diff --git a/src/main/java/mekanism/common/tile/TileEntityDigitalMiner.java b/src/main/java/mekanism/common/tile/TileEntityDigitalMiner.java
index 7d56ed0a0d..602769200c 100644
--- a/src/main/java/mekanism/common/tile/TileEntityDigitalMiner.java
+++ b/src/main/java/mekanism/common/tile/TileEntityDigitalMiner.java
@@ -1... | ['src/main/java/mekanism/common/tile/TileEntityFluidicPlenisher.java', 'src/main/java/mekanism/common/tile/TileEntityDigitalMiner.java', 'src/main/java/mekanism/common/tile/TileEntityElectricPump.java'] | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 4,389,887 | 1,169,828 | 153,244 | 1,052 | 410 | 98 | 19 | 3 | 750 | 127 | 181 | 22 | 0 | 0 | 1970-01-01T00:25:01 | 1,137 | Java | {'Java': 10634221, 'ZenScript': 66932, 'Groovy': 7193, 'Perl': 4725, 'GLSL': 4576, 'JavaScript': 1156, 'Python': 511} | MIT License |
230 | mekanism/mekanism/4575/4573 | mekanism | mekanism | https://github.com/mekanism/Mekanism/issues/4573 | https://github.com/mekanism/Mekanism/pull/4575 | https://github.com/mekanism/Mekanism/pull/4575 | 1 | closes | [1.10.2] Rotary Condensentrator Bucket issue | #### Issue description:
So when placing a bucket in the Rotary Condensentrator seems to not empty it but in fact gives you infinite liquid see the video below
#### Steps to reproduce:
https://www.youtube.com/watch?v=ZF6JDSpxur4
#### Version (make sure you are on the latest version before reporting):
**Forge:*... | cf436ab42392749265a5cc986ce26379eb5b0687 | 8d98a98dd8b88302cf9058fe6809311eca6c1b4c | https://github.com/mekanism/mekanism/compare/cf436ab42392749265a5cc986ce26379eb5b0687...8d98a98dd8b88302cf9058fe6809311eca6c1b4c | diff --git a/src/main/java/mekanism/common/util/FluidContainerUtils.java b/src/main/java/mekanism/common/util/FluidContainerUtils.java
index 35ac06d7b6..bb010342d8 100644
--- a/src/main/java/mekanism/common/util/FluidContainerUtils.java
+++ b/src/main/java/mekanism/common/util/FluidContainerUtils.java
@@ -123,8 +123,7 ... | ['src/main/java/mekanism/common/util/FluidContainerUtils.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 4,882,339 | 1,280,704 | 166,896 | 1,306 | 1,459 | 394 | 56 | 1 | 473 | 57 | 119 | 10 | 2 | 0 | 1970-01-01T00:25:01 | 1,137 | Java | {'Java': 10634221, 'ZenScript': 66932, 'Groovy': 7193, 'Perl': 4725, 'GLSL': 4576, 'JavaScript': 1156, 'Python': 511} | MIT License |
239 | mekanism/mekanism/4426/4425 | mekanism | mekanism | https://github.com/mekanism/Mekanism/issues/4425 | https://github.com/mekanism/Mekanism/pull/4426 | https://github.com/mekanism/Mekanism/pull/4426 | 1 | fixes | Thermal Evaporation Plant causes massive lag while entering world | It is caused by instancing many display lists during recalculation of water model inside the plant.
Reproduction: Add one level to fully built and filled plant | 16b6860f94d6c82ac9a40951b920bd478da2485e | b6d77c595d39bcca24795dbff1d3f1408bdb3d1e | https://github.com/mekanism/mekanism/compare/16b6860f94d6c82ac9a40951b920bd478da2485e...b6d77c595d39bcca24795dbff1d3f1408bdb3d1e | diff --git a/src/main/java/mekanism/client/render/RenderResizableCuboid.java b/src/main/java/mekanism/client/render/RenderResizableCuboid.java
index db994b3325..b750223eca 100644
--- a/src/main/java/mekanism/client/render/RenderResizableCuboid.java
+++ b/src/main/java/mekanism/client/render/RenderResizableCuboid.java
@... | ['src/main/java/mekanism/client/render/tileentity/RenderThermalEvaporationController.java', 'src/main/java/mekanism/client/render/RenderResizableCuboid.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 4,692,558 | 1,234,831 | 161,686 | 1,285 | 6,360 | 1,744 | 176 | 2 | 162 | 26 | 32 | 3 | 0 | 0 | 1970-01-01T00:24:56 | 1,137 | Java | {'Java': 10634221, 'ZenScript': 66932, 'Groovy': 7193, 'Perl': 4725, 'GLSL': 4576, 'JavaScript': 1156, 'Python': 511} | MIT License |
262 | slimeknights/tinkersconstruct/1584/1561 | slimeknights | tinkersconstruct | https://github.com/SlimeKnights/TinkersConstruct/issues/1561 | https://github.com/SlimeKnights/TinkersConstruct/pull/1584 | https://github.com/SlimeKnights/TinkersConstruct/pull/1584 | 1 | fixes | Drying rack mirrors items horizontally if placed while facing north or west | http://i.imgur.com/6i51sRL.png
Signs in the picture label which direction the player is facing.
Also possibly worth noting: as evident in the pictures, they're not properly centered on the rack.
This has been a problem as long as I can remember, frankly I'm surprised I can't find anything mentioning it.
| 9f0349c66b264e858d23665aebd4fdc99108dcaa | dfed1dd9f44505522d464622b204bb45aec4d0f6 | https://github.com/slimeknights/tinkersconstruct/compare/9f0349c66b264e858d23665aebd4fdc99108dcaa...dfed1dd9f44505522d464622b204bb45aec4d0f6 | diff --git a/src/main/java/tconstruct/armor/modelblock/DryingRackSpecialRender.java b/src/main/java/tconstruct/armor/modelblock/DryingRackSpecialRender.java
index 23f46f3de..ee94797ba 100644
--- a/src/main/java/tconstruct/armor/modelblock/DryingRackSpecialRender.java
+++ b/src/main/java/tconstruct/armor/modelblock/Dryi... | ['src/main/java/tconstruct/armor/modelblock/DryingRackSpecialRender.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 2,803,930 | 682,154 | 78,537 | 600 | 549 | 187 | 16 | 1 | 307 | 48 | 70 | 7 | 1 | 0 | 1970-01-01T00:23:50 | 1,133 | Java | {'Java': 5527226, 'ZenScript': 28851} | MIT License |
3,338 | stripe/stripe-android/57/55 | stripe | stripe-android | https://github.com/stripe/stripe-android/issues/55 | https://github.com/stripe/stripe-android/pull/57 | https://github.com/stripe/stripe-android/pull/57 | 2 | fixes | Duplicate card number prefix | Just wondering if there was a mistake on this line
https://github.com/stripe/stripe-android/blob/master/stripe/src/main/java/com/stripe/android/model/Card.java#L19
or why is it that you are including `37` as a `Diners Club` prefix if according to your source page https://en.wikipedia.org/wiki/Bank_card_number#Issuer_i... | f3366f28b0842f398984d6858d21a732ba0e7193 | 1d90219e20bf60db6c26ccf4455a0b0a5fffc410 | https://github.com/stripe/stripe-android/compare/f3366f28b0842f398984d6858d21a732ba0e7193...1d90219e20bf60db6c26ccf4455a0b0a5fffc410 | diff --git a/stripe/src/main/java/com/stripe/android/model/Card.java b/stripe/src/main/java/com/stripe/android/model/Card.java
index 8bd357522e..395aa01d83 100644
--- a/stripe/src/main/java/com/stripe/android/model/Card.java
+++ b/stripe/src/main/java/com/stripe/android/model/Card.java
@@ -16,7 +16,7 @@ public class Ca... | ['stripe/src/main/java/com/stripe/android/model/Card.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 60,816 | 12,635 | 1,735 | 16 | 257 | 91 | 2 | 1 | 375 | 36 | 90 | 4 | 2 | 0 | 1970-01-01T00:24:13 | 1,115 | Kotlin | {'Kotlin': 9267111, 'Java': 69683, 'Shell': 18879, 'Python': 13927, 'Ruby': 7073} | MIT License |
94 | tony19/logback-android/221/213 | tony19 | logback-android | https://github.com/tony19/logback-android/issues/213 | https://github.com/tony19/logback-android/pull/221 | https://github.com/tony19/logback-android/pull/221 | 1 | fixes | Daily rollover uses UTC instead of local time | ## Description
I configured daily rollover with TimeBasedRollingPolicy, according to example in [wiki](https://github.com/tony19/logback-android/wiki/Appender-Notes#configuration-in-code). It generally works, but rollover happens at UTC midnight, not local midnight. This may be confusing.
I know it's possible to sp... | 8386981b046084492df784bca739db2598db3107 | e40e9fa4c1518038e066f4a246a4f6a539bfaed0 | https://github.com/tony19/logback-android/compare/8386981b046084492df784bca739db2598db3107...e40e9fa4c1518038e066f4a246a4f6a539bfaed0 | diff --git a/logback-android/src/main/java/ch/qos/logback/core/rolling/helper/RollingCalendar.java b/logback-android/src/main/java/ch/qos/logback/core/rolling/helper/RollingCalendar.java
index 2d461e535..d94336e94 100644
--- a/logback-android/src/main/java/ch/qos/logback/core/rolling/helper/RollingCalendar.java
+++ b/l... | ['logback-android/src/main/java/ch/qos/logback/core/rolling/helper/RollingCalendar.java', 'logback-android/src/test/java/ch/qos/logback/core/rolling/helper/RollingCalendarTest.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,282,267 | 294,498 | 42,373 | 422 | 153 | 34 | 4 | 1 | 845 | 109 | 216 | 19 | 2 | 0 | 1970-01-01T00:26:40 | 1,110 | Java | {'Java': 2511833, 'TypeScript': 19668, 'Shell': 8371, 'HTML': 6656, 'Roff': 482} | Apache License 2.0 |
498 | appium/java-client/313/311 | appium | java-client | https://github.com/appium/java-client/issues/311 | https://github.com/appium/java-client/pull/313 | https://github.com/appium/java-client/pull/313#issuecomment-180294535 | 1 | resolve | Update page object features. Server node 1.5.x | These things should be done:
- mark _name_ parameter _Decrecated_ as _By.name_ selector is not supported by native app automation
- _By.id_ selector should be used by default (native content) when not any selector strategy defined.
- _org.openqa.selenium.InvalidSelectorException_ should be handled.
| 138e2e8071c9346aeda51f995d506066b3b6ba41 | c823138cf5f6605f834bfb33f5a1b5b11227b8f5 | https://github.com/appium/java-client/compare/138e2e8071c9346aeda51f995d506066b3b6ba41...c823138cf5f6605f834bfb33f5a1b5b11227b8f5 | diff --git a/src/main/java/io/appium/java_client/pagefactory/AndroidFindBy.java b/src/main/java/io/appium/java_client/pagefactory/AndroidFindBy.java
index 1dd3e485..5569fe83 100644
--- a/src/main/java/io/appium/java_client/pagefactory/AndroidFindBy.java
+++ b/src/main/java/io/appium/java_client/pagefactory/AndroidFindB... | ['src/main/java/io/appium/java_client/pagefactory/AndroidFindBy.java', 'src/test/java/io/appium/java_client/pagefactory_tests/iOSPageObjectTest.java', 'src/test/java/io/appium/java_client/pagefactory_tests/SelendroidModeTest.java', 'src/main/java/io/appium/java_client/pagefactory/ThrowableUtil.java', 'src/main/java/io/... | {'.java': 5} | 5 | 5 | 0 | 0 | 5 | 354,320 | 76,767 | 10,144 | 108 | 851 | 180 | 19 | 3 | 301 | 41 | 66 | 5 | 0 | 0 | 1970-01-01T00:24:14 | 1,098 | Java | {'Java': 1674245, 'HTML': 80758} | Apache License 2.0 |
500 | appium/java-client/769/764 | appium | java-client | https://github.com/appium/java-client/issues/764 | https://github.com/appium/java-client/pull/769 | https://github.com/appium/java-client/pull/769 | 1 | fix | Client asking to many times for session | ## Description
I'm seeing the java client asking for getSession too many times, probably like 5,6 times between commands, making the test to run slower. This make a big difference when running on a testing cloud since this calls are adding ~4 seconds between commands in the test.
## Environment
This is a proble... | 5dab23d599ac04bd4550c0b2cda68e110551d7c4 | d10f5d1df3482ce8049cca115444aa0a2b191633 | https://github.com/appium/java-client/compare/5dab23d599ac04bd4550c0b2cda68e110551d7c4...d10f5d1df3482ce8049cca115444aa0a2b191633 | diff --git a/src/main/java/io/appium/java_client/DefaultGenericMobileDriver.java b/src/main/java/io/appium/java_client/DefaultGenericMobileDriver.java
index 23e188b2..6376a265 100644
--- a/src/main/java/io/appium/java_client/DefaultGenericMobileDriver.java
+++ b/src/main/java/io/appium/java_client/DefaultGenericMobileD... | ['src/main/java/io/appium/java_client/internal/ElementMap.java', 'src/main/java/io/appium/java_client/internal/JsonToMobileElementConverter.java', 'src/main/java/io/appium/java_client/pagefactory/utils/WebDriverUnpackUtility.java', 'src/main/java/io/appium/java_client/pagefactory/AppiumElementLocator.java', 'src/main/j... | {'.java': 8} | 8 | 8 | 0 | 0 | 8 | 634,995 | 133,291 | 17,502 | 193 | 9,025 | 1,634 | 161 | 8 | 6,075 | 597 | 1,976 | 100 | 0 | 1 | 1970-01-01T00:25:10 | 1,098 | Java | {'Java': 1674245, 'HTML': 80758} | Apache License 2.0 |
501 | appium/java-client/733/732 | appium | java-client | https://github.com/appium/java-client/issues/732 | https://github.com/appium/java-client/pull/733 | https://github.com/appium/java-client/pull/733 | 1 | fix | Appium 1.7.0 crashes Java client 5.0.3 when testing iOS | ## Description
When attempting to use java-client 5.0.3 to test an iOS device with Appium 1.7.0, the java-client crashes with java.lang.NullPointerException: null value in entry: browserName=null
## Environment
* java client build version or git revision if you use some shapshot: 5.0.3
* Appium server version... | 9e3946cfd22905841f9a1cb7d4a3750960e41106 | 89b22dddd55ab708d0ac923ad508b73bb1d1e5b6 | https://github.com/appium/java-client/compare/9e3946cfd22905841f9a1cb7d4a3750960e41106...89b22dddd55ab708d0ac923ad508b73bb1d1e5b6 | diff --git a/src/main/java/io/appium/java_client/AppiumDriver.java b/src/main/java/io/appium/java_client/AppiumDriver.java
index be4900a2..dc7df872 100644
--- a/src/main/java/io/appium/java_client/AppiumDriver.java
+++ b/src/main/java/io/appium/java_client/AppiumDriver.java
@@ -17,9 +17,8 @@
package io.appium.java_cli... | ['src/main/java/io/appium/java_client/AppiumDriver.java', 'src/main/java/io/appium/java_client/HasSessionDetails.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 618,032 | 129,727 | 16,954 | 185 | 3,684 | 663 | 72 | 2 | 2,876 | 310 | 998 | 40 | 2 | 1 | 1970-01-01T00:25:06 | 1,098 | Java | {'Java': 1674245, 'HTML': 80758} | Apache License 2.0 |
512 | appium/java-client/314/294 | appium | java-client | https://github.com/appium/java-client/issues/294 | https://github.com/appium/java-client/pull/314 | https://github.com/appium/java-client/pull/314 | 1 | fix | Not able to build project locally | @TikhomirovSergey i was unable to build the project locally. I cloned the java_client and ran the the command
```
mvn clean install -Dmaven.test.skip=true
```
Please check the gist for errors.
https://gist.github.com/saikrishna321/03f85f7bfce8d2199f7d
More Info:
```
Apache Maven 3.3.3 (7994120775791599e205a5524e... | 138e2e8071c9346aeda51f995d506066b3b6ba41 | 53d4edee8763339bb6550f765057c28b6f3a5661 | https://github.com/appium/java-client/compare/138e2e8071c9346aeda51f995d506066b3b6ba41...53d4edee8763339bb6550f765057c28b6f3a5661 | diff --git a/src/main/java/io/appium/java_client/AppiumDriver.java b/src/main/java/io/appium/java_client/AppiumDriver.java
index 3b5c6b62..aad34a91 100644
--- a/src/main/java/io/appium/java_client/AppiumDriver.java
+++ b/src/main/java/io/appium/java_client/AppiumDriver.java
@@ -42,14 +42,13 @@ import static io.appium.j... | ['src/main/java/io/appium/java_client/android/StartsActivity.java', 'src/main/java/io/appium/java_client/pagefactory/bys/builder/AppiumByBuilder.java', 'src/main/java/io/appium/java_client/service/local/flags/AndroidServerFlag.java', 'src/main/java/io/appium/java_client/service/local/flags/IOSServerFlag.java', 'src/mai... | {'.java': 15} | 15 | 15 | 0 | 0 | 15 | 354,320 | 76,767 | 10,144 | 108 | 17,215 | 4,139 | 359 | 15 | 667 | 69 | 246 | 22 | 1 | 2 | 1970-01-01T00:24:14 | 1,098 | Java | {'Java': 1674245, 'HTML': 80758} | Apache License 2.0 |
503 | appium/java-client/705/704 | appium | java-client | https://github.com/appium/java-client/issues/704 | https://github.com/appium/java-client/pull/705 | https://github.com/appium/java-client/pull/705 | 1 | fix | 5.0.0: Brokes iOS tests | ## Description
Move from 5.0.0-BETA9 -> 5.0.0 cause iOS tests fail to find any element
## Environment
* java client build version or git revision if you use some shapshot: 5.0.0
* Appium server version or git revision if you use some shapshot: 1.6.6-beta.4
* Desktop OS/version used to run Appium if necessary... | 8f914fb2467e21368603bf76d98e97ed37e4fde3 | 4d87d9396d569fbf01c2e142e111b1091c06f63d | https://github.com/appium/java-client/compare/8f914fb2467e21368603bf76d98e97ed37e4fde3...4d87d9396d569fbf01c2e142e111b1091c06f63d | diff --git a/src/main/java/io/appium/java_client/DefaultGenericMobileDriver.java b/src/main/java/io/appium/java_client/DefaultGenericMobileDriver.java
index e3a27cb9..23e188b2 100644
--- a/src/main/java/io/appium/java_client/DefaultGenericMobileDriver.java
+++ b/src/main/java/io/appium/java_client/DefaultGenericMobileD... | ['src/main/java/io/appium/java_client/DefaultGenericMobileDriver.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 615,108 | 129,111 | 16,885 | 184 | 153 | 32 | 6 | 1 | 4,937 | 423 | 1,823 | 68 | 1 | 1 | 1970-01-01T00:25:03 | 1,098 | Java | {'Java': 1674245, 'HTML': 80758} | Apache License 2.0 |
506 | appium/java-client/582/574 | appium | java-client | https://github.com/appium/java-client/issues/574 | https://github.com/appium/java-client/pull/582 | https://github.com/appium/java-client/pull/582 | 1 | fix | wait.until(ExpectedConditions.visibilityOf(elementName)) related issue | ## Description
I've below code
`WebDriverWait wait = new WebDriverWait(AppiumController.instance.driver, timeout);
wait.until(ExpectedConditions.visibilityOf(elementName));`
Here I pass timeout value but observed that instead of waiting for timeout value, it waits for default time mentioned in
`PageFac... | df7168b4c39fb0ea914150b89fb1a34d552468b5 | 615ef51b07a5a0fc471a278b7602146f83047706 | https://github.com/appium/java-client/compare/df7168b4c39fb0ea914150b89fb1a34d552468b5...615ef51b07a5a0fc471a278b7602146f83047706 | diff --git a/src/main/java/io/appium/java_client/pagefactory/AppiumElementLocator.java b/src/main/java/io/appium/java_client/pagefactory/AppiumElementLocator.java
index 1f1c9c0f..6ce4e3b1 100644
--- a/src/main/java/io/appium/java_client/pagefactory/AppiumElementLocator.java
+++ b/src/main/java/io/appium/java_client/pag... | ['src/main/java/io/appium/java_client/pagefactory/WidgetInterceptor.java', 'src/main/java/io/appium/java_client/pagefactory/ElementInterceptor.java', 'src/main/java/io/appium/java_client/pagefactory/ElementListInterceptor.java', 'src/main/java/io/appium/java_client/pagefactory/AppiumElementLocator.java', 'src/main/java... | {'.java': 6} | 6 | 6 | 0 | 0 | 6 | 569,817 | 119,764 | 15,561 | 167 | 1,206 | 199 | 26 | 6 | 1,400 | 186 | 341 | 38 | 1 | 0 | 1970-01-01T00:24:47 | 1,098 | Java | {'Java': 1674245, 'HTML': 80758} | Apache License 2.0 |
507 | appium/java-client/568/567 | appium | java-client | https://github.com/appium/java-client/issues/567 | https://github.com/appium/java-client/pull/568 | https://github.com/appium/java-client/pull/568 | 1 | fix | 5.0.0-BETA2: ClassCastException: WebElement -> IOSElement | ## Description
Failed to cast WebElement into IOSElement. Worked with 5.0.0-BETA1.
## Environment
* java client build version or git revision if you use some shapshot: 5.0.0-BETA2
* Appium server version or git revision if you use some shapshot: 1.6.4-beta
* Mobile platform/version under test: iOS
* Real devi... | 1d3e9705527435c48005f0a50a60b1371e03bbd1 | b3351034ac0eb7b814ecfcacb1b097b8fd547a55 | https://github.com/appium/java-client/compare/1d3e9705527435c48005f0a50a60b1371e03bbd1...b3351034ac0eb7b814ecfcacb1b097b8fd547a55 | diff --git a/src/main/java/io/appium/java_client/AppiumDriver.java b/src/main/java/io/appium/java_client/AppiumDriver.java
index a3adf2e9..fa9696cf 100644
--- a/src/main/java/io/appium/java_client/AppiumDriver.java
+++ b/src/main/java/io/appium/java_client/AppiumDriver.java
@@ -76,7 +76,6 @@ public class AppiumDriver<T... | ['src/main/java/io/appium/java_client/internal/ElementMap.java', 'src/main/java/io/appium/java_client/internal/JsonToMobileElementConverter.java', 'src/main/java/io/appium/java_client/pagefactory/AppiumFieldDecorator.java', 'src/main/java/io/appium/java_client/AppiumDriver.java', 'src/test/java/io/appium/java_client/ap... | {'.java': 7} | 7 | 7 | 0 | 0 | 7 | 570,684 | 119,915 | 15,588 | 167 | 3,923 | 686 | 81 | 5 | 674 | 74 | 168 | 17 | 0 | 0 | 1970-01-01T00:24:46 | 1,098 | Java | {'Java': 1674245, 'HTML': 80758} | Apache License 2.0 |
508 | appium/java-client/468/467 | appium | java-client | https://github.com/appium/java-client/issues/467 | https://github.com/appium/java-client/pull/468 | https://github.com/appium/java-client/pull/468 | 1 | fixes | page object pattern, field with "@WithTimeout" would change the global implicit wait time | ## Description
page object pattern, field with "@WithTimeout" would change the global implicit wait time
## Environment
Always exists. see code analysis below
## Details
in method [AppiumElementLocatorFactory#createLocator](https://github.com/appium/java-client/blob/master/src/main/java/io/appium/java_client/pagefa... | ef779eb9a72926fe0349f18e5fea3146d2995d5a | 31ce398dc771455f42b4673973db150e6940ef7a | https://github.com/appium/java-client/compare/ef779eb9a72926fe0349f18e5fea3146d2995d5a...31ce398dc771455f42b4673973db150e6940ef7a | diff --git a/src/main/java/io/appium/java_client/pagefactory/AppiumElementLocator.java b/src/main/java/io/appium/java_client/pagefactory/AppiumElementLocator.java
index 5ccfdb09..eb11f441 100644
--- a/src/main/java/io/appium/java_client/pagefactory/AppiumElementLocator.java
+++ b/src/main/java/io/appium/java_client/pag... | ['src/main/java/io/appium/java_client/pagefactory/AppiumElementLocatorFactory.java', 'src/main/java/io/appium/java_client/pagefactory/AppiumElementLocator.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 516,520 | 108,730 | 14,151 | 136 | 935 | 164 | 11 | 2 | 1,361 | 161 | 283 | 20 | 2 | 0 | 1970-01-01T00:24:33 | 1,098 | Java | {'Java': 1674245, 'HTML': 80758} | Apache License 2.0 |
509 | appium/java-client/451/450 | appium | java-client | https://github.com/appium/java-client/issues/450 | https://github.com/appium/java-client/pull/451 | https://github.com/appium/java-client/pull/451 | 2 | fix | java -client4.1 "EventFiringWebDriverFactory.getEventFiringWebDriver"capabilities turn to null | ## Description
use java-client 4.1 found :+1:
capabilities.setCapability(MobileCapabilityType.BROWSER_NAME, browser_Name);
capabilities.setCapability(MobileCapabilityType.PLATFORM_NAME, platform_Name);
capabilities.setCapability(MobileCapabilityType.DEVICE_NAME,device_Name);
... | bd19d78b0696aec602e4685b314e818af9b2dddb | a3065c24c338e7ecf266da9f155e60a32f1048ac | https://github.com/appium/java-client/compare/bd19d78b0696aec602e4685b314e818af9b2dddb...a3065c24c338e7ecf266da9f155e60a32f1048ac | diff --git a/src/main/java/io/appium/java_client/events/DefaultAspect.java b/src/main/java/io/appium/java_client/events/DefaultAspect.java
index 3bec135a..652c17a8 100644
--- a/src/main/java/io/appium/java_client/events/DefaultAspect.java
+++ b/src/main/java/io/appium/java_client/events/DefaultAspect.java
@@ -156,7 +15... | ['src/main/java/io/appium/java_client/events/DefaultListener.java', 'src/test/java/io/appium/java_client/events/EmptyWebDriver.java', 'src/test/java/io/appium/java_client/events/DefaultEventListenerTest.java', 'src/main/java/io/appium/java_client/events/DefaultAspect.java'] | {'.java': 4} | 4 | 4 | 0 | 0 | 4 | 505,422 | 106,832 | 13,934 | 140 | 266 | 48 | 4 | 2 | 855 | 59 | 189 | 25 | 0 | 1 | 1970-01-01T00:24:30 | 1,098 | Java | {'Java': 1674245, 'HTML': 80758} | Apache License 2.0 |
511 | appium/java-client/317/311 | appium | java-client | https://github.com/appium/java-client/issues/311 | https://github.com/appium/java-client/pull/317 | https://github.com/appium/java-client/pull/317 | 1 | fix | Update page object features. Server node 1.5.x | These things should be done:
- mark _name_ parameter _Decrecated_ as _By.name_ selector is not supported by native app automation
- _By.id_ selector should be used by default (native content) when not any selector strategy defined.
- _org.openqa.selenium.InvalidSelectorException_ should be handled.
| 8f88f67ff6a8c63b5d37d93864600e63455f6889 | 5ed8b9e5ac3b4eda1ee20788cba31c0899220dea | https://github.com/appium/java-client/compare/8f88f67ff6a8c63b5d37d93864600e63455f6889...5ed8b9e5ac3b4eda1ee20788cba31c0899220dea | diff --git a/src/main/java/io/appium/java_client/pagefactory/AndroidFindBy.java b/src/main/java/io/appium/java_client/pagefactory/AndroidFindBy.java
index 1dd3e485..5569fe83 100644
--- a/src/main/java/io/appium/java_client/pagefactory/AndroidFindBy.java
+++ b/src/main/java/io/appium/java_client/pagefactory/AndroidFindB... | ['src/main/java/io/appium/java_client/pagefactory/AndroidFindBy.java', 'src/main/java/io/appium/java_client/pagefactory/bys/builder/AppiumByBuilder.java', 'src/test/java/io/appium/java_client/pagefactory_tests/iOSPageObjectTest.java', 'src/test/java/io/appium/java_client/pagefactory_tests/SelendroidModeTest.java', 'src... | {'.java': 8} | 8 | 8 | 0 | 0 | 8 | 353,902 | 76,522 | 10,060 | 108 | 3,034 | 629 | 68 | 5 | 301 | 41 | 66 | 5 | 0 | 0 | 1970-01-01T00:24:15 | 1,098 | Java | {'Java': 1674245, 'HTML': 80758} | Apache License 2.0 |
393 | javers/javers/541/455 | javers | javers | https://github.com/javers/javers/issues/455 | https://github.com/javers/javers/pull/541 | https://github.com/javers/javers/pull/541 | 1 | fix | MySQL error: Specified key was too long; max key length is 767 bytes | Hi, I'm initializing repository this way:
```
JaversSqlRepository sqlRepository = SqlRepositoryBuilder.sqlRepository()
.withConnectionProvider(connectionProvider)
.withDialect(DialectName.MYSQL)
.build();
Javers javers = JaversBuilder.javers().registerJaversRepository(sqlRepository).build();
```
however I ge... | 174c15278998eb1ba17809c40c2199eb7f411da4 | 36fae3ed1f9822be9eba4afc2c0ee7490fff6684 | https://github.com/javers/javers/compare/174c15278998eb1ba17809c40c2199eb7f411da4...36fae3ed1f9822be9eba4afc2c0ee7490fff6684 | diff --git a/javers-persistence-sql/src/main/java/org/javers/repository/sql/schema/FixedSchemaFactory.java b/javers-persistence-sql/src/main/java/org/javers/repository/sql/schema/FixedSchemaFactory.java
index 7aac9530..f3d77fc0 100644
--- a/javers-persistence-sql/src/main/java/org/javers/repository/sql/schema/FixedSche... | ['javers-persistence-sql/src/main/java/org/javers/repository/sql/schema/FixedSchemaFactory.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 730,352 | 149,959 | 22,779 | 378 | 339 | 74 | 4 | 1 | 12,711 | 552 | 2,835 | 179 | 2 | 3 | 1970-01-01T00:24:54 | 1,096 | Java | {'Java': 1158177, 'Groovy': 842390, 'Shell': 608} | Apache License 2.0 |
392 | javers/javers/598/597 | javers | javers | https://github.com/javers/javers/issues/597 | https://github.com/javers/javers/pull/598 | https://github.com/javers/javers/pull/598 | 1 | fix | Again: MySQL error: Specified key was too long; max key length is 767 bytes | #455 is back in 3.6.0 (or earlier?) affecting mysql <= 4.6..
mysql <= 4.6 has a max key length of 767 bytes (whereas >= 4.7 has a limit of 3072 bytes)
```
Caused by: org.polyjdbc.core.exception.SchemaManagerException: [DDL_ERROR] Failed to run DDL:
CREATE INDEX jv_commit_property_property_name_property_value_i... | 89e68859667afc5908d4eb5fb514ff9c3eb3a7bd | 0b923c46d61e01b192d2ead3a6d20bddaef2bad6 | https://github.com/javers/javers/compare/89e68859667afc5908d4eb5fb514ff9c3eb3a7bd...0b923c46d61e01b192d2ead3a6d20bddaef2bad6 | diff --git a/javers-persistence-sql/src/main/java/org/javers/repository/sql/schema/FixedSchemaFactory.java b/javers-persistence-sql/src/main/java/org/javers/repository/sql/schema/FixedSchemaFactory.java
index f3d77fc0..354ab67b 100644
--- a/javers-persistence-sql/src/main/java/org/javers/repository/sql/schema/FixedSche... | ['javers-persistence-sql/src/main/java/org/javers/repository/sql/schema/FixedSchemaFactory.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 762,023 | 157,199 | 23,620 | 382 | 556 | 123 | 7 | 1 | 2,461 | 222 | 570 | 44 | 1 | 2 | 1970-01-01T00:25:10 | 1,096 | Java | {'Java': 1158177, 'Groovy': 842390, 'Shell': 608} | Apache License 2.0 |
389 | javers/javers/696/692 | javers | javers | https://github.com/javers/javers/issues/692 | https://github.com/javers/javers/pull/696 | https://github.com/javers/javers/pull/696 | 1 | fixes | JaVers dependency on Google Guava | As documented I just ran the below code to view the diff. It seems that Google Guava is required as a runtime dependency for the below code to work.
```java
Javers javers = JaversBuilder.javers().build();
Person tommyOld = new Person("tommy", "Tommy Smart");
Person tommyNew = new Person("tommy", "Tommy C. Smart")... | ecaa45ed4965f6c243c05ffa85248e2ab9209f77 | 9cdedbe0c836af2af84d7b58fe85961d9ff76339 | https://github.com/javers/javers/compare/ecaa45ed4965f6c243c05ffa85248e2ab9209f77...9cdedbe0c836af2af84d7b58fe85961d9ff76339 | diff --git a/javers-core/src/main/java/org/javers/common/collections/Primitives.java b/javers-core/src/main/java/org/javers/common/collections/Primitives.java
index eee8a3c4..c9ff294d 100644
--- a/javers-core/src/main/java/org/javers/common/collections/Primitives.java
+++ b/javers-core/src/main/java/org/javers/common/c... | ['javers-core/src/main/java/org/javers/common/collections/Primitives.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 833,230 | 172,127 | 25,728 | 402 | 204 | 32 | 4 | 1 | 1,700 | 153 | 423 | 33 | 1 | 2 | 1970-01-01T00:25:33 | 1,096 | Java | {'Java': 1158177, 'Groovy': 842390, 'Shell': 608} | Apache License 2.0 |
387 | javers/javers/1222/1183 | javers | javers | https://github.com/javers/javers/issues/1183 | https://github.com/javers/javers/pull/1222 | https://github.com/javers/javers/pull/1222 | 1 | fixes | Possible issue with skip value check | While reading the code, I found this snippet on`master`:
https://github.com/javers/javers/blob/f49b0aea4c371b90ada54144843e3e1eae81fe65/javers-core/src/main/java/org/javers/repository/api/QueryParamsBuilder.java#L111
```
public QueryParamsBuilder skip(int skip) {
Validate.argumentCheck(limit >= 0, "Skip is ... | c92044c41f3bfb8ee30879a73f880f470b26ef06 | 3e504dd5494f339fd497d354f9b5eed8f403e89b | https://github.com/javers/javers/compare/c92044c41f3bfb8ee30879a73f880f470b26ef06...3e504dd5494f339fd497d354f9b5eed8f403e89b | diff --git a/javers-core/src/main/java/org/javers/repository/api/QueryParamsBuilder.java b/javers-core/src/main/java/org/javers/repository/api/QueryParamsBuilder.java
index 24122e34..a46ad839 100644
--- a/javers-core/src/main/java/org/javers/repository/api/QueryParamsBuilder.java
+++ b/javers-core/src/main/java/org/jav... | ['javers-core/src/main/java/org/javers/repository/api/QueryParamsBuilder.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,049,140 | 215,043 | 31,806 | 452 | 164 | 36 | 2 | 1 | 514 | 46 | 135 | 11 | 1 | 1 | 1970-01-01T00:27:44 | 1,096 | Java | {'Java': 1158177, 'Groovy': 842390, 'Shell': 608} | Apache License 2.0 |
388 | javers/javers/1189/1188 | javers | javers | https://github.com/javers/javers/issues/1188 | https://github.com/javers/javers/pull/1189 | https://github.com/javers/javers/pull/1189 | 1 | fixes | ClassNotFoundException when using javers-persistence-sql and gson 2.9.0 | **Clear description of my expectations versus reality**
I'm using javers with javers-persistence-sql and expected that updating gson from 2.8.9 to 2.9.0 wouldn't do any harm.
But using gson 2.9.0 will result in
```
Exception in thread "main" java.lang.NoClassDefFoundError: com/google/gson/internal/LinkedHashTreeMa... | f49b0aea4c371b90ada54144843e3e1eae81fe65 | 34d11f594b57ff4c0d266d9e4bd2532d030ec4c8 | https://github.com/javers/javers/compare/f49b0aea4c371b90ada54144843e3e1eae81fe65...34d11f594b57ff4c0d266d9e4bd2532d030ec4c8 | diff --git a/javers-persistence-sql/src/main/java/org/javers/repository/sql/schema/FixedSchemaFactory.java b/javers-persistence-sql/src/main/java/org/javers/repository/sql/schema/FixedSchemaFactory.java
index ea6c93b1..7d5a99a0 100644
--- a/javers-persistence-sql/src/main/java/org/javers/repository/sql/schema/FixedSche... | ['javers-persistence-sql/src/main/java/org/javers/repository/sql/schema/FixedSchemaFactory.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,045,742 | 214,343 | 31,715 | 452 | 198 | 40 | 4 | 1 | 1,476 | 98 | 355 | 29 | 2 | 1 | 1970-01-01T00:27:25 | 1,096 | Java | {'Java': 1158177, 'Groovy': 842390, 'Shell': 608} | Apache License 2.0 |
390 | javers/javers/693/692 | javers | javers | https://github.com/javers/javers/issues/692 | https://github.com/javers/javers/pull/693 | https://github.com/javers/javers/pull/693 | 1 | fixes | JaVers dependency on Google Guava | As documented I just ran the below code to view the diff. It seems that Google Guava is required as a runtime dependency for the below code to work.
```java
Javers javers = JaversBuilder.javers().build();
Person tommyOld = new Person("tommy", "Tommy Smart");
Person tommyNew = new Person("tommy", "Tommy C. Smart")... | 432bd6d2de60e62e075d78a04ee274279abcfc88 | c129c04808f5144d8021eaa1ff804ae6584d268d | https://github.com/javers/javers/compare/432bd6d2de60e62e075d78a04ee274279abcfc88...c129c04808f5144d8021eaa1ff804ae6584d268d | diff --git a/javers-core/src/main/java/org/javers/core/Changes.java b/javers-core/src/main/java/org/javers/core/Changes.java
index 2496ae6c..8cf726a8 100644
--- a/javers-core/src/main/java/org/javers/core/Changes.java
+++ b/javers-core/src/main/java/org/javers/core/Changes.java
@@ -1,6 +1,5 @@
package org.javers.core;... | ['javers-spring-jpa/src/test/java/org/javers/hibernate/integration/config/HibernateConfig.java', 'javers-spring-jpa/src/test/java/org/javers/spring/example/JaversSpringJpaApplicationConfig.java', 'javers-core/src/main/java/org/javers/core/Changes.java', 'javers-spring/src/test/java/org/javers/spring/example/JaversSprin... | {'.java': 4} | 4 | 4 | 0 | 0 | 4 | 826,405 | 170,826 | 25,563 | 402 | 126 | 31 | 4 | 1 | 1,700 | 153 | 423 | 33 | 1 | 2 | 1970-01-01T00:25:33 | 1,096 | Java | {'Java': 1158177, 'Groovy': 842390, 'Shell': 608} | Apache License 2.0 |
829 | netflix/hollow/341/339 | netflix | hollow | https://github.com/Netflix/hollow/issues/339 | https://github.com/Netflix/hollow/pull/341 | https://github.com/Netflix/hollow/pull/341 | 1 | fixes | Ergonomic HollowObjectDelegateCachedImpls refer to object ordinal | Looks like the problem is here:
https://github.com/Netflix/hollow/blob/f0126b04575a897b3e7ceefa07baa0f354b79683/hollow/src/main/java/com/netflix/hollow/api/codegen/delegate/HollowObjectDelegateCachedImplGenerator.java#L131
For a `String` field I get:
```
this.nameOrdinal = typeAPI.getNameOrdinal(ordinal... | 7590c8442a4df35bcc620e2360f8ad896a3d3285 | d807d5254c07ad294392c88b7bd13e65c1e14ac9 | https://github.com/netflix/hollow/compare/7590c8442a4df35bcc620e2360f8ad896a3d3285...d807d5254c07ad294392c88b7bd13e65c1e14ac9 | diff --git a/hollow/src/main/java/com/netflix/hollow/api/codegen/delegate/HollowObjectDelegateCachedImplGenerator.java b/hollow/src/main/java/com/netflix/hollow/api/codegen/delegate/HollowObjectDelegateCachedImplGenerator.java
index 1692f5910..d1631fe27 100644
--- a/hollow/src/main/java/com/netflix/hollow/api/codegen/d... | ['hollow/src/main/java/com/netflix/hollow/api/codegen/delegate/HollowObjectDelegateCachedImplGenerator.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 2,658,735 | 549,230 | 68,670 | 537 | 629 | 144 | 2 | 1 | 748 | 72 | 182 | 12 | 1 | 1 | 1970-01-01T00:25:42 | 1,094 | Java | {'Java': 4858508, 'CSS': 4299, 'JavaScript': 1703, 'Shell': 1383, 'Makefile': 1217, 'C++': 798, 'Pawn': 701} | Apache License 2.0 |
828 | netflix/hollow/417/416 | netflix | hollow | https://github.com/Netflix/hollow/issues/416 | https://github.com/Netflix/hollow/pull/417 | https://github.com/Netflix/hollow/pull/417 | 1 | fixes | PrimaryKeyIndex doesn't index large changes efficiently | It's intended for `PrimaryKeyIndex` to do a full re-index when more than 10% of the previous ordinals have been removed (record removed or modified).
A [bug in the code (HollowPrimaryKeyIndex.java#L582)](https://github.com/Netflix/hollow/blob/240417b373d1b6aeead886152603201cbbd01fc2/hollow/src/main/java/com/netflix/... | 240417b373d1b6aeead886152603201cbbd01fc2 | 3850981a86ecf947d2e24286ba95d7988dcb0cc0 | https://github.com/netflix/hollow/compare/240417b373d1b6aeead886152603201cbbd01fc2...3850981a86ecf947d2e24286ba95d7988dcb0cc0 | diff --git a/hollow/src/main/java/com/netflix/hollow/core/index/HollowPrimaryKeyIndex.java b/hollow/src/main/java/com/netflix/hollow/core/index/HollowPrimaryKeyIndex.java
index e6dc2cc7d..525fe3d1a 100644
--- a/hollow/src/main/java/com/netflix/hollow/core/index/HollowPrimaryKeyIndex.java
+++ b/hollow/src/main/java/com/... | ['hollow/src/main/java/com/netflix/hollow/core/index/HollowPrimaryKeyIndex.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 2,963,462 | 615,591 | 75,235 | 576 | 224 | 45 | 2 | 1 | 767 | 69 | 184 | 9 | 1 | 1 | 1970-01-01T00:25:55 | 1,094 | Java | {'Java': 4858508, 'CSS': 4299, 'JavaScript': 1703, 'Shell': 1383, 'Makefile': 1217, 'C++': 798, 'Pawn': 701} | Apache License 2.0 |
830 | netflix/hollow/177/176 | netflix | hollow | https://github.com/Netflix/hollow/issues/176 | https://github.com/Netflix/hollow/pull/177 | https://github.com/Netflix/hollow/pull/177 | 1 | fixes | Compilation of generated files fails if data model object has `Byte` | If you try and generate an API for object that contains a Byte, the generated files to do not compile. Any generated files that to try reference the type (eg <APIName>HashIndex.java) conflict between my.generated.package.Byte and java.lang.Byte, since we import my.generated.*.
A couple ways to fix this:
* have simi... | 11cb87e9703810c3d9912b91dbadb4aa5c5a2c31 | 1951a8089654b865f2f96b9d7b0958b50c3023c8 | https://github.com/netflix/hollow/compare/11cb87e9703810c3d9912b91dbadb4aa5c5a2c31...1951a8089654b865f2f96b9d7b0958b50c3023c8 | diff --git a/hollow/src/main/java/com/netflix/hollow/api/codegen/HollowAPIFactoryJavaGenerator.java b/hollow/src/main/java/com/netflix/hollow/api/codegen/HollowAPIFactoryJavaGenerator.java
index ee0b3a4f7..59739c0bd 100644
--- a/hollow/src/main/java/com/netflix/hollow/api/codegen/HollowAPIFactoryJavaGenerator.java
+++ ... | ['hollow/src/main/java/com/netflix/hollow/api/codegen/indexes/HollowHashIndexGenerator.java', 'hollow/src/main/java/com/netflix/hollow/api/codegen/objects/HollowMapJavaGenerator.java', 'hollow/src/main/java/com/netflix/hollow/api/codegen/HollowConsumerJavaFileGenerator.java', 'hollow/src/main/java/com/netflix/hollow/ap... | {'.java': 14} | 14 | 14 | 0 | 0 | 14 | 2,517,651 | 520,759 | 65,419 | 514 | 6,085 | 1,094 | 127 | 14 | 535 | 82 | 118 | 5 | 0 | 0 | 1970-01-01T00:25:19 | 1,094 | Java | {'Java': 4858508, 'CSS': 4299, 'JavaScript': 1703, 'Shell': 1383, 'Makefile': 1217, 'C++': 798, 'Pawn': 701} | Apache License 2.0 |
1,262 | vert-x3/vertx-web/1731/1730 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1730 | https://github.com/vert-x3/vertx-web/pull/1731 | https://github.com/vert-x3/vertx-web/pull/1731 | 1 | fix | Template engine not working for parametrized paths like "/:project/" | ### Version
4.0.0.Beta3
### Context
I am trying to use a template for this routing:
```
router
.route()
.path("/:project/")
.produces("text/html")
.handler(routingContext -> {
@Nullable String projectName = routingCont... | 635bcb56673965244680f00dc65ae69a862426eb | 065f3a8d0cc0f4042ff9f5e2772210f5f1c69d28 | https://github.com/vert-x3/vertx-web/compare/635bcb56673965244680f00dc65ae69a862426eb...065f3a8d0cc0f4042ff9f5e2772210f5f1c69d28 | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/impl/Utils.java b/vertx-web/src/main/java/io/vertx/ext/web/impl/Utils.java
index 4e8c1ec6e..2425fe96b 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/impl/Utils.java
+++ b/vertx-web/src/main/java/io/vertx/ext/web/impl/Utils.java
@@ -55,6 +55,19 @@ public class... | ['vertx-web/src/test/java/io/vertx/ext/web/templ/TemplateTest.java', 'vertx-web/src/main/java/io/vertx/ext/web/impl/Utils.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,671,865 | 369,986 | 51,775 | 404 | 299 | 72 | 13 | 1 | 1,170 | 111 | 244 | 41 | 1 | 1 | 1970-01-01T00:26:41 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,263 | vert-x3/vertx-web/1729/1472 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1472 | https://github.com/vert-x3/vertx-web/pull/1729 | https://github.com/vert-x3/vertx-web/pull/1729 | 1 | fixes | SubRouter Mount acting as Exact Path | ### 3.8.4
* vert.x web:
### Context
The handlers mounted on sub-router are ignored when the mount point is `"/"`.
`router.mountSubRouter("/", subRouter);`
Note that, we can't have empty string as mount point.
It was functional until v3.8.1. With v3.8.4 it behaves as exactMatch and ending with slash.
B... | c729ef5b0afad23568758fec09b58f9514b99fc8 | acd45048af85bbdf08f2db1163e9d81b442a1cc3 | https://github.com/vert-x3/vertx-web/compare/c729ef5b0afad23568758fec09b58f9514b99fc8...acd45048af85bbdf08f2db1163e9d81b442a1cc3 | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextWrapper.java b/vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextWrapper.java
index 9d8360619..19d777bae 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextWrapper.java
+++ b/vertx-web/src/main/java/io/vertx/ext/web... | ['vertx-web/src/test/java/io/vertx/ext/web/SubRouterTest.java', 'vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextWrapper.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,671,876 | 369,992 | 51,774 | 404 | 537 | 124 | 9 | 1 | 1,781 | 265 | 468 | 48 | 4 | 0 | 1970-01-01T00:26:41 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,264 | vert-x3/vertx-web/1724/1720 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1720 | https://github.com/vert-x3/vertx-web/pull/1724 | https://github.com/vert-x3/vertx-web/pull/1724 | 1 | fix | SockJSHandlerTest intermittent failures in CI | ### Questions
There is an intermittent failures about `SockJSHandlerTest` in CI
### Version
`master` branch
### Context
### Exceptions found
```java
Starting test: SockJSHandlerTest#testCombineBinaryContinuationFramesRawWebSocket
Unhandled exception
java.lang.IllegalStateException: assert or fail... | 8e6e4681df8d1262ae5a00dc6607752055ad9133 | 714d9280cf78ac0a788d5a640b2caff1aa151a9b | https://github.com/vert-x3/vertx-web/compare/8e6e4681df8d1262ae5a00dc6607752055ad9133...714d9280cf78ac0a788d5a640b2caff1aa151a9b | diff --git a/vertx-template-engines/vertx-web-templ-pebble/src/main/java/io/vertx/ext/web/templ/pebble/PebbleTemplateEngine.java b/vertx-template-engines/vertx-web-templ-pebble/src/main/java/io/vertx/ext/web/templ/pebble/PebbleTemplateEngine.java
index db07598b9..7c3e7e86c 100644
--- a/vertx-template-engines/vertx-web-... | ['vertx-web/src/test/java/io/vertx/ext/web/WebTestBase.java', 'vertx-web/src/main/java/io/vertx/ext/web/handler/sockjs/impl/SockJSSession.java', 'vertx-template-engines/vertx-web-templ-pebble/src/main/java/io/vertx/ext/web/templ/pebble/PebbleTemplateEngine.java'] | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 1,669,283 | 369,360 | 51,681 | 404 | 569 | 120 | 14 | 2 | 3,325 | 115 | 661 | 56 | 1 | 1 | 1970-01-01T00:26:41 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,266 | vert-x3/vertx-web/1686/1685 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1685 | https://github.com/vert-x3/vertx-web/pull/1686 | https://github.com/vert-x3/vertx-web/pull/1686 | 1 | fixes | StatusCode still remains -1 when catching a runtime exception | ### Questions
The status code in failure handler remains -1 when catching a runtime exception
### Version
3.9.2, 4.0.0beta1
### Do you have a reproducer?
try this example:
```java
Route route1 = router.get("/somepath/path1/");
route1.handler(ctx -> {
// Let's say this throws a RuntimeException
t... | f56655459e50661c8d13367193b2bf27b823702e | 10c0ebcd54c4b448d8c5bcd27a9b9c8a1f7ca6a6 | https://github.com/vert-x3/vertx-web/compare/f56655459e50661c8d13367193b2bf27b823702e...10c0ebcd54c4b448d8c5bcd27a9b9c8a1f7ca6a6 | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/ErrorHandlerImpl.java b/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/ErrorHandlerImpl.java
index 948941020..2c35e033a 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/ErrorHandlerImpl.java
+++ b/vertx-web/src/main/java/io/vert... | ['vertx-web/src/test/java/io/vertx/ext/web/RouterTest.java', 'vertx-web/src/test/java/io/vertx/ext/web/SubRouterTest.java', 'vertx-web/src/main/java/io/vertx/ext/web/handler/impl/ErrorHandlerImpl.java', 'vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextImpl.java'] | {'.java': 4} | 4 | 4 | 0 | 0 | 4 | 1,648,974 | 364,858 | 51,080 | 404 | 2,837 | 557 | 62 | 2 | 870 | 98 | 193 | 30 | 0 | 1 | 1970-01-01T00:26:38 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,246 | vert-x3/vertx-web/2066/2065 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/2065 | https://github.com/vert-x3/vertx-web/pull/2066 | https://github.com/vert-x3/vertx-web/pull/2066 | 1 | fixes | SecuritySchemeImpl returns null on bind call | ### Version
4.1.5
### Context
When calling `RouterBuilder.securityScheme(String).bind(..)` the returned Future always return null due to a `.mapEmpty()` call.
| 5b34cadd4a24b197ca2ac625393b8cf29f25f677 | f24d31766fda9b17c418b6403289212109d22941 | https://github.com/vert-x3/vertx-web/compare/5b34cadd4a24b197ca2ac625393b8cf29f25f677...f24d31766fda9b17c418b6403289212109d22941 | diff --git a/vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/impl/SecuritySchemeImpl.java b/vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/impl/SecuritySchemeImpl.java
index 2c8043fff..7df9cf046 100644
--- a/vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/impl/SecuritySchemeImpl.java
+++ b/v... | ['vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/impl/SecuritySchemeImpl.java', 'vertx-web-openapi/src/test/java/io/vertx/ext/web/openapi/RouterBuilderSecurityHandlerTest.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,913,261 | 424,136 | 59,339 | 474 | 55 | 11 | 2 | 1 | 170 | 19 | 40 | 8 | 0 | 0 | 1970-01-01T00:27:13 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,268 | vert-x3/vertx-web/1492/1490 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1490 | https://github.com/vert-x3/vertx-web/pull/1492 | https://github.com/vert-x3/vertx-web/pull/1492 | 2 | fixes | FormLoginHandlerImpl should return status 401 on failed authentication | ### Version
* vert.x core: 3.8.4
* vert.x web: 3.8.4
### Context
I was using the FormLoginHandler to perform simple form-based login. The default implementation sets the status code to 403 ("Forbidden") which to me indicates that the user is not **allowed** to login. I think 401 ("Unauthorized") is more appro... | 70b4403c3b3a970167ebb101868ce2166ebf12d1 | 357a8678ed88283b1b3112a91ebb691e51ed23be | https://github.com/vert-x3/vertx-web/compare/70b4403c3b3a970167ebb101868ce2166ebf12d1...357a8678ed88283b1b3112a91ebb691e51ed23be | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/FormLoginHandlerImpl.java b/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/FormLoginHandlerImpl.java
index 0fe34f8d6..71ed6f810 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/FormLoginHandlerImpl.java
+++ b/vertx-web/src/main/... | ['vertx-web/src/test/java/io/vertx/ext/web/handler/RedirectAuthHandlerTest.java', 'vertx-web/src/main/java/io/vertx/ext/web/handler/impl/FormLoginHandlerImpl.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,270,844 | 283,807 | 40,228 | 298 | 316 | 67 | 6 | 1 | 976 | 104 | 252 | 23 | 3 | 0 | 1970-01-01T00:26:16 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,261 | vert-x3/vertx-web/1765/1742 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1742 | https://github.com/vert-x3/vertx-web/pull/1765 | https://github.com/vert-x3/vertx-web/pull/1765 | 1 | fixes | ResponsePredicateResult::response returns null when requiresBody is false | ### Version
`3.9.3`
### Context
I have a very simple `ErrorConverter` whose `ResponsePredicateResult` is returning `null` for `response()` when `requiresBody()` is set to `false`. It works fine (valid `HttpResponse` instance) if `requiresBody()` is set to `true`.
I would expect to be able to assess all resp... | 5e61e19dc35d74543b93bc7a19eb56802ac7d855 | d4260ec69ed3228dee793a0da19d243a37a57c69 | https://github.com/vert-x3/vertx-web/compare/5e61e19dc35d74543b93bc7a19eb56802ac7d855...d4260ec69ed3228dee793a0da19d243a37a57c69 | diff --git a/vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/predicate/PredicateInterceptor.java b/vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/predicate/PredicateInterceptor.java
index a4f5afe5e..8273ea14b 100644
--- a/vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/predicate/Pre... | ['vertx-web-client/src/test/java/io/vertx/ext/web/client/WebClientTest.java', 'vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/predicate/PredicateInterceptor.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,691,104 | 374,258 | 52,377 | 411 | 323 | 55 | 3 | 1 | 6,845 | 318 | 1,494 | 106 | 1 | 4 | 1970-01-01T00:26:44 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,253 | vert-x3/vertx-web/1978/1380 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1380 | https://github.com/vert-x3/vertx-web/pull/1978 | https://github.com/vert-x3/vertx-web/pull/1978 | 1 | fix | Race condition when using an event bus bridge hook (events handler), between socket closed event and other events | ### Version
* vert.x core: 3.7.1 (should apply to 3.8.1, master)
* vert.x web: 3.7.1 (should apply to 3.8.1, master)
### Context
We started to see that some messages were not delivered to the same event bus (bridge) address. After multiple re-connections, a client can't listen anymore to some particular addre... | 7a8c6550ee5f4fdd9755ebfabb326765a6e52f3a | e321e222b2086086b8901941f79acc3a90341af2 | https://github.com/vert-x3/vertx-web/compare/7a8c6550ee5f4fdd9755ebfabb326765a6e52f3a...e321e222b2086086b8901941f79acc3a90341af2 | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/handler/sockjs/impl/EventBusBridgeImpl.java b/vertx-web/src/main/java/io/vertx/ext/web/handler/sockjs/impl/EventBusBridgeImpl.java
index 346b45b8e..51a98c417 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/handler/sockjs/impl/EventBusBridgeImpl.java
+++ b/vert... | ['vertx-web/src/main/java/io/vertx/ext/web/handler/sockjs/impl/EventBusBridgeImpl.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,757,323 | 389,173 | 54,407 | 434 | 2,238 | 476 | 47 | 1 | 1,881 | 276 | 416 | 33 | 1 | 0 | 1970-01-01T00:27:03 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,254 | vert-x3/vertx-web/1947/1890 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1890 | https://github.com/vert-x3/vertx-web/pull/1947 | https://github.com/vert-x3/vertx-web/pull/1947 | 1 | fixes | SessionHandler doesn't set SameSite cookie attribute when destroying the session and expiring the session cookie | ### Questions
When the session cookie needs to be removed on session logout, the SameSite attribute is not set.
### Version
3.9.2
### Context
If SameSite.None is set on the cookie while setting it for the duration of the session, It should also be present when the user sends a logout and the expiration ... | a4eb3dbe0f2dc167f1242c03282b14e37aeb13be | 48c3ede6747d7a65cb00478a57478b44125e59a0 | https://github.com/vert-x3/vertx-web/compare/a4eb3dbe0f2dc167f1242c03282b14e37aeb13be...48c3ede6747d7a65cb00478a57478b44125e59a0 | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/SessionHandlerImpl.java b/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/SessionHandlerImpl.java
index 367e27de1..c9934625c 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/SessionHandlerImpl.java
+++ b/vertx-web/src/main/java/i... | ['vertx-web/src/test/java/io/vertx/ext/web/handler/SessionHandlerTestBase.java', 'vertx-web/src/main/java/io/vertx/ext/web/handler/impl/SessionHandlerImpl.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,749,425 | 387,236 | 54,129 | 428 | 833 | 175 | 19 | 1 | 1,663 | 208 | 326 | 43 | 0 | 1 | 1970-01-01T00:27:00 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,255 | vert-x3/vertx-web/1945/1933 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1933 | https://github.com/vert-x3/vertx-web/pull/1945 | https://github.com/vert-x3/vertx-web/pull/1945 | 1 | fix | CORS handling fails with "Origin: null" header | ### Version
Which version(s) did you encounter this bug ?
4.0.3
### Context
When issuing an HTTP request with the `Origin: null` header, the CorsHandler generates an HTTP 500 error (`CORS Rejected - Invalid origin`), even though it should allow the request to continue its normal processing.
This happens ... | f8e7bb17b6365b1f86f84fae0090102a48674205 | dce68f718a20d7c985a2175219c19c1507414f11 | https://github.com/vert-x3/vertx-web/compare/f8e7bb17b6365b1f86f84fae0090102a48674205...dce68f718a20d7c985a2175219c19c1507414f11 | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/impl/Origin.java b/vertx-web/src/main/java/io/vertx/ext/web/impl/Origin.java
index f2aec90b5..5feada3f7 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/impl/Origin.java
+++ b/vertx-web/src/main/java/io/vertx/ext/web/impl/Origin.java
@@ -34,6 +34,7 @@ public fi... | ['vertx-web/src/test/java/io/vertx/ext/web/handler/CORSHandlerTest.java', 'vertx-web/src/test/java/io/vertx/ext/web/impl/OriginTest.java', 'vertx-web/src/main/java/io/vertx/ext/web/impl/Origin.java'] | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 1,748,628 | 387,026 | 54,084 | 428 | 841 | 210 | 45 | 1 | 8,731 | 404 | 1,718 | 85 | 10 | 2 | 1970-01-01T00:27:00 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,234 | vert-x3/vertx-web/2397/2315 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/2315 | https://github.com/vert-x3/vertx-web/pull/2397 | https://github.com/vert-x3/vertx-web/pull/2397 | 1 | fixes | TenantHandler doesn't respect the order aware sub handler | See: https://github.com/eclipse-vertx/vert.x/issues/4536
A possible use case is to implement SSO on the same endpoint, for this the IdP info is extracted from a param, however, OAuth2Handler implements `OrderListener` and depends on this information to properly mount the callback.
On a Multi tenant environment, t... | eae0a59cd95a68f1df51ac887b8f9631d26435ca | d8f87ecca44446944a090d74e7c7a555ee2009dc | https://github.com/vert-x3/vertx-web/compare/eae0a59cd95a68f1df51ac887b8f9631d26435ca...d8f87ecca44446944a090d74e7c7a555ee2009dc | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/MultiTenantHandlerImpl.java b/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/MultiTenantHandlerImpl.java
index ccf8e8f22..d8d75c14a 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/MultiTenantHandlerImpl.java
+++ b/vertx-web/src... | ['vertx-web/src/main/java/io/vertx/ext/web/handler/impl/MultiTenantHandlerImpl.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 2,020,426 | 448,267 | 62,389 | 504 | 434 | 88 | 12 | 1 | 399 | 59 | 89 | 5 | 1 | 0 | 1970-01-01T00:27:59 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,256 | vert-x3/vertx-web/1925/1919 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1919 | https://github.com/vert-x3/vertx-web/pull/1925 | https://github.com/vert-x3/vertx-web/pull/1925 | 1 | fix | Server eats exception and simply responds 500 | ### Description
Server log doesn't contain any info about NPE error. I think it happens for other errors too.
### Version
4.0.3
### Code sample
```
final HttpServer server = vertx
.createHttpServer(
new HttpServerOptions()
.setLogActivity(true)
);
... | 123b750b7995a20302bbeff92527344454f4894e | 1e0a374065cbdb3af9c43e953bf8833f3c226c8f | https://github.com/vert-x3/vertx-web/compare/123b750b7995a20302bbeff92527344454f4894e...1e0a374065cbdb3af9c43e953bf8833f3c226c8f | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextImplBase.java b/vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextImplBase.java
index c7e87fce0..4432edcb6 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextImplBase.java
+++ b/vertx-web/src/main/java/io/vertx/ext/... | ['vertx-web/src/test/java/io/vertx/ext/web/handler/BodyHandlerTest.java', 'vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextImplBase.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,746,216 | 386,399 | 53,997 | 427 | 153 | 33 | 5 | 1 | 5,157 | 521 | 1,950 | 83 | 0 | 2 | 1970-01-01T00:26:58 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,260 | vert-x3/vertx-web/1779/1778 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1778 | https://github.com/vert-x3/vertx-web/pull/1779 | https://github.com/vert-x3/vertx-web/pull/1779 | 1 | fixes | HTTP server file upload cleanup fail to delete | The HTTP server file upload cleanup mechanism implemented in `BodyHandler` can fail to delete uploaded files because it does not ensure that the file upload is finished before deleting the file. Fixing this in vertx-web would bring lot of complexity and instead this has been implemented in vertx-core HTTP server file u... | 7d91fc4471655c3d57bb0ef7210079cf8b483145 | 68dd64008a5312e67950bc7429a32a35b92f90ab | https://github.com/vert-x3/vertx-web/compare/7d91fc4471655c3d57bb0ef7210079cf8b483145...68dd64008a5312e67950bc7429a32a35b92f90ab | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/FileUpload.java b/vertx-web/src/main/java/io/vertx/ext/web/FileUpload.java
index bc812f747..a95a2cb30 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/FileUpload.java
+++ b/vertx-web/src/main/java/io/vertx/ext/web/FileUpload.java
@@ -62,5 +62,11 @@ public inter... | ['vertx-web/src/main/java/io/vertx/ext/web/FileUpload.java', 'vertx-web/src/main/java/io/vertx/ext/web/impl/FileUploadImpl.java', 'vertx-web/src/main/java/io/vertx/ext/web/handler/impl/BodyHandlerImpl.java'] | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 1,698,077 | 375,725 | 52,586 | 412 | 2,487 | 469 | 59 | 3 | 383 | 60 | 70 | 2 | 0 | 0 | 1970-01-01T00:26:45 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,259 | vert-x3/vertx-web/1815/1814 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1814 | https://github.com/vert-x3/vertx-web/pull/1815 | https://github.com/vert-x3/vertx-web/pull/1815 | 1 | fixes | NPE when userAgentEnabled is set to false | ### Version
4.0.0 (and in previous betas)
### Context
I have a SecretsClient that is based on VaultConfigStore and like that code uses SlimVaultClient to access secrets in Vault. It only uses loginWithAppRole for creating/renewing the client token.
The configuration passed thru to the SlimVaultClient includ... | b00221acf6a4809e87241e984a357bc5b20467b9 | dfee825ee22a2610978565ce5f8be5fa6897dff3 | https://github.com/vert-x3/vertx-web/compare/b00221acf6a4809e87241e984a357bc5b20467b9...dfee825ee22a2610978565ce5f8be5fa6897dff3 | diff --git a/vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/HttpRequestImpl.java b/vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/HttpRequestImpl.java
index b83629198..a2c760d77 100644
--- a/vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/HttpRequestImpl.java
+++ b/vertx-web-client... | ['vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/HttpRequestImpl.java', 'vertx-web-client/src/test/java/io/vertx/ext/web/client/WebClientTest.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,706,875 | 377,581 | 52,829 | 416 | 262 | 49 | 4 | 1 | 3,569 | 309 | 753 | 92 | 0 | 3 | 1970-01-01T00:26:47 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,258 | vert-x3/vertx-web/1834/1825 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1825 | https://github.com/vert-x3/vertx-web/pull/1834 | https://github.com/vert-x3/vertx-web/pull/1834 | 1 | fix | RoutingContext.isFresh() returns false for IF-NONE-MATCH single value Header | Hi,
while trying to use e-tag header for HTTP caching - I noticed the following behavior.
### Version
4.0.0
### Context
Given a simple HTTP server sample using `ctx.isFresh()` method:
```java
package io.vertx.reproducer;
import io.vertx.core.AbstractVerticle;
import io.vertx.core.Promise;
import... | 2c0d3e6b84bc4c30dc3a384e6e9309d3b95f324b | 105040967214ab96d66ce29af48af4bf2ec2b4e2 | https://github.com/vert-x3/vertx-web/compare/2c0d3e6b84bc4c30dc3a384e6e9309d3b95f324b...105040967214ab96d66ce29af48af4bf2ec2b4e2 | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/impl/Utils.java b/vertx-web/src/main/java/io/vertx/ext/web/impl/Utils.java
index 2425fe96b..572f02319 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/impl/Utils.java
+++ b/vertx-web/src/main/java/io/vertx/ext/web/impl/Utils.java
@@ -161,7 +161,8 @@ public clas... | ['vertx-web/src/test/java/io/vertx/ext/web/RouterTest.java', 'vertx-web/src/main/java/io/vertx/ext/web/impl/Utils.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,707,426 | 377,707 | 52,854 | 416 | 479 | 126 | 11 | 1 | 2,743 | 307 | 724 | 95 | 5 | 3 | 1970-01-01T00:26:49 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,236 | vert-x3/vertx-web/2300/2293 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/2293 | https://github.com/vert-x3/vertx-web/pull/2300 | https://github.com/vert-x3/vertx-web/pull/2300 | 1 | fixes | "405 Method Not Allowed" response not adding allow header | As per this document, https://vertx.io/docs/vertx-web/java/#_route_match_failures Vert.x-Web will signal a 405 error If a route matches the path but doesn’t match the HTTP Method, but as per Mozilla document https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/405 response should contain `allow` header. Is there an... | 1231eab65a061c9e6f9497049b86d3a3a21394e1 | 8bcd7b50bd1a8bde897341df205121b4414e9287 | https://github.com/vert-x3/vertx-web/compare/1231eab65a061c9e6f9497049b86d3a3a21394e1...8bcd7b50bd1a8bde897341df205121b4414e9287 | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextImpl.java b/vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextImpl.java
index c6959902b..07da73ab5 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextImpl.java
+++ b/vertx-web/src/main/java/io/vertx/ext/web/impl/Rou... | ['vertx-web/src/test/java/io/vertx/ext/web/RouterTest.java', 'vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextImplBase.java', 'vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextImpl.java'] | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 1,970,042 | 437,391 | 61,089 | 482 | 616 | 132 | 11 | 2 | 419 | 52 | 104 | 5 | 2 | 0 | 1970-01-01T00:27:47 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,230 | vert-x3/vertx-web/2347/2319 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/2319 | https://github.com/vert-x3/vertx-web/pull/2347 | https://github.com/vert-x3/vertx-web/issues/2319#issuecomment-1406925163 | 2 | resolve | CORS headers not set on response for .* origin | ### Version
VertX 4.3.6
### Context
On a HTTP-Request without `Origin` i would expect the CORS-Handler to set `Vary:Origin` and this was the case with 3.4.5.
I'm not 100% sure about the CORS spec itself but considering that the Requests could be cached and looking at -> https://fetch.spec.whatwg.org/#cors-pr... | 79faa1baaa4e5292f945a56c30bfad60c3af6fb6 | 26919f07ea3510cde0c08b51255531a22e4c939b | https://github.com/vert-x3/vertx-web/compare/79faa1baaa4e5292f945a56c30bfad60c3af6fb6...26919f07ea3510cde0c08b51255531a22e4c939b | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/CorsHandlerImpl.java b/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/CorsHandlerImpl.java
index 4df0ebfd5..1b938687d 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/CorsHandlerImpl.java
+++ b/vertx-web/src/main/java/io/vertx/e... | ['vertx-web/src/test/java/io/vertx/ext/web/handler/CORSHandlerTest.java', 'vertx-web/src/main/java/io/vertx/ext/web/handler/impl/CorsHandlerImpl.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,985,499 | 440,889 | 61,525 | 488 | 219 | 50 | 3 | 1 | 772 | 90 | 198 | 23 | 1 | 0 | 1970-01-01T00:27:54 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,267 | vert-x3/vertx-web/1639/1619 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1619 | https://github.com/vert-x3/vertx-web/pull/1639 | https://github.com/vert-x3/vertx-web/pull/1639 | 1 | fixes | ApolloWS handler does not support messages sent in multiple frames | GraphQL Subscriptions websocket uses a handler instead of textMessageHandler resulting in lost messages since handler will be called for all binary / text / continuation frames.
In our case we should add a textMessageHandler since we want to concatenate messages when a continuation frame is received
https://githu... | 129fedc24157d84dadefde44cfd186274f3fddb9 | 4eb7f7321e71f77c135311f171cd6727386eb72e | https://github.com/vert-x3/vertx-web/compare/129fedc24157d84dadefde44cfd186274f3fddb9...4eb7f7321e71f77c135311f171cd6727386eb72e | diff --git a/vertx-web-graphql/src/main/java/io/vertx/ext/web/handler/graphql/impl/ApolloWSConnectionHandler.java b/vertx-web-graphql/src/main/java/io/vertx/ext/web/handler/graphql/impl/ApolloWSConnectionHandler.java
index abdd7e4ed..7394d8f96 100644
--- a/vertx-web-graphql/src/main/java/io/vertx/ext/web/handler/graphq... | ['vertx-web-graphql/src/test/java/io/vertx/ext/web/handler/graphql/ApolloWSHandlerTest.java', 'vertx-web-graphql/src/main/java/io/vertx/ext/web/handler/graphql/impl/ApolloWSConnectionHandler.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,611,540 | 355,944 | 49,888 | 402 | 2,846 | 568 | 88 | 1 | 494 | 47 | 119 | 5 | 1 | 0 | 1970-01-01T00:26:32 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,232 | vert-x3/vertx-web/2406/1935 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1935 | https://github.com/vert-x3/vertx-web/pull/2406 | https://github.com/vert-x3/vertx-web/pull/2406 | 1 | fix | Log (LoggerHandlerImpl) swallows/loses log if client closes connection. | As discussed from: https://github.com/eclipse-vertx/vert.x/issues/3902
Version
3.9.x
Context
Log is not logged
Do you have a reproducer?
No.
Steps to reproduce
This is coming from conversation here: https://groups.google.com/g/vertx/c/CZaPXYk2MA0
Add LoggerHandlerImpl to your route as early as possib... | 01794a9f52c06fb496916f3095a0174d8b57f352 | f2e96ec91594a83c019c40d9a2c6ae45301b3f10 | https://github.com/vert-x3/vertx-web/compare/01794a9f52c06fb496916f3095a0174d8b57f352...f2e96ec91594a83c019c40d9a2c6ae45301b3f10 | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/LoggerHandlerImpl.java b/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/LoggerHandlerImpl.java
index 5a5c8ca2e..a521f1500 100755
--- a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/LoggerHandlerImpl.java
+++ b/vertx-web/src/main/java/io/v... | ['vertx-web/src/main/java/io/vertx/ext/web/handler/impl/LoggerHandlerImpl.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,751,923 | 391,757 | 55,275 | 443 | 574 | 109 | 9 | 1 | 605 | 78 | 146 | 17 | 2 | 0 | 1970-01-01T00:28:00 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,252 | vert-x3/vertx-web/1984/1983 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1983 | https://github.com/vert-x3/vertx-web/pull/1984 | https://github.com/vert-x3/vertx-web/pull/1984 | 1 | fixes | Pause/Resume missing in AuthorizationHandlerImpl? IllegalStateException: Request has already been read | ### Version
4.1.0
### Context
When using async operations in implementations of `AuthorizationProvider.getAuthorizations` then a `BodyHandler` added after an `AuthorizationHandler` that uses that `AuthorizationProvider` (created with `AuthorizationHandler.create`) causes that requests with body may fail due to... | 97917b0ad77ee80bfd6d65ca2f87b57ff3ad2d6a | bc9a0366a6d09477b5d701d58029bc73dd622cd2 | https://github.com/vert-x3/vertx-web/compare/97917b0ad77ee80bfd6d65ca2f87b57ff3ad2d6a...bc9a0366a6d09477b5d701d58029bc73dd622cd2 | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/AuthorizationHandlerImpl.java b/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/AuthorizationHandlerImpl.java
index bdb61f542..d735cf00a 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/AuthorizationHandlerImpl.java
+++ b/vertx-w... | ['vertx-web/src/main/java/io/vertx/ext/web/handler/impl/AuthorizationHandlerImpl.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,757,869 | 389,260 | 54,421 | 434 | 1,268 | 221 | 24 | 1 | 1,909 | 107 | 452 | 25 | 1 | 1 | 1970-01-01T00:27:04 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,248 | vert-x3/vertx-web/2035/1817 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1817 | https://github.com/vert-x3/vertx-web/pull/2035 | https://github.com/vert-x3/vertx-web/pull/2035 | 1 | resolves | Enable loading OpenAPI YAML from classpath | #### Feature Description
I'd like to load an OpenAPI YAML for router creation from a file that's bundled in a JAR. However, when using `getResource` to determine the URI to the bundled file, an exception is thrown:
```
io.vertx.ext.web.openapi.RouterBuilderException: Cannot load the spec in path file:/path/to/ap... | faff38257bcf4c9608a645ca151ae8fe56d6f920 | 51e13bbef6d7a52d7eb6019a87818163ced80ed1 | https://github.com/vert-x3/vertx-web/compare/faff38257bcf4c9608a645ca151ae8fe56d6f920...51e13bbef6d7a52d7eb6019a87818163ced80ed1 | diff --git a/vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/impl/OpenAPIHolderImpl.java b/vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/impl/OpenAPIHolderImpl.java
index c092f22bb..66cb0ebe1 100755
--- a/vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/impl/OpenAPIHolderImpl.java
+++ b/vert... | ['vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/impl/OpenAPIHolderImpl.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,772,442 | 392,555 | 54,835 | 436 | 22 | 5 | 1 | 1 | 947 | 128 | 217 | 14 | 1 | 1 | 1970-01-01T00:27:10 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,249 | vert-x3/vertx-web/2031/2030 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/2030 | https://github.com/vert-x3/vertx-web/pull/2031 | https://github.com/vert-x3/vertx-web/pull/2031 | 1 | fixes | HTTP/2, BodyHandler together with AuthorizationHandler - IllegalStateException Request has already been read | ### Version
vertx-web 4.1.0 - 4.2.0.Beta.1 (since this [commit](https://github.com/vert-x3/vertx-web/commit/bc9a0366a6d09477b5d701d58029bc73dd622cd2))
### Context
* BodyHandler together with a `AuthorizationHandler.create(RoleBasedAuthorization.create("operator"))` and Http 2 requests.
### Do you have a rep... | 342982409d38e2defff1587c99c2ddcfd5c1aec3 | 24b2c593bfdc491e24a18d5a68f7785c5f6a0f31 | https://github.com/vert-x3/vertx-web/compare/342982409d38e2defff1587c99c2ddcfd5c1aec3...24b2c593bfdc491e24a18d5a68f7785c5f6a0f31 | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/AuthorizationHandlerImpl.java b/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/AuthorizationHandlerImpl.java
index d735cf00a..28e51519e 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/AuthorizationHandlerImpl.java
+++ b/vertx-w... | ['vertx-web/src/main/java/io/vertx/ext/web/handler/impl/AuthorizationHandlerImpl.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,771,962 | 392,449 | 54,825 | 436 | 1,551 | 280 | 26 | 1 | 408 | 33 | 129 | 16 | 2 | 0 | 1970-01-01T00:27:10 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,245 | vert-x3/vertx-web/2124/2123 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/2123 | https://github.com/vert-x3/vertx-web/pull/2124 | https://github.com/vert-x3/vertx-web/pull/2124 | 1 | fix | SessionHandler doesn't callback the handler of method flush in some cases | ### Questions
SessionHandler doesn't callback the handler of method flush in some cases, leaving some user defined actions uncomplished in the handler.
### Version
vertx-web 3.9.12
### Context
Hi, we are developing website with Vert.x framework. When we tested the session feature based on the Vert.x `Ses... | 91a1b2ade0d5af86aeb38231a919a5013a33ad99 | 92fd0ac40396c9fdeff54e3c47801d22987ca5cf | https://github.com/vert-x3/vertx-web/compare/91a1b2ade0d5af86aeb38231a919a5013a33ad99...92fd0ac40396c9fdeff54e3c47801d22987ca5cf | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/SessionHandlerImpl.java b/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/SessionHandlerImpl.java
index 40d6efbdc..e07b7ac85 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/SessionHandlerImpl.java
+++ b/vertx-web/src/main/java/i... | ['vertx-web/src/main/java/io/vertx/ext/web/handler/impl/SessionHandlerImpl.java', 'vertx-web/src/test/java/io/vertx/ext/web/sstore/LocalSessionHandlerTest.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,906,750 | 423,047 | 59,207 | 462 | 158 | 33 | 2 | 1 | 3,532 | 446 | 735 | 73 | 1 | 1 | 1970-01-01T00:27:24 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,244 | vert-x3/vertx-web/2140/2136 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/2136 | https://github.com/vert-x3/vertx-web/pull/2140 | https://github.com/vert-x3/vertx-web/pull/2140 | 1 | fix | Subrouter fails if mounted on another subrouter on path with path params | ### Version
4.2.4 and 4.3.0-SNAPSHOT
### Context
If subrouter is NOT mounted on root router (but instead on another subrouter) and its path contains parameters, then routing fails with 404 and well-known HTML output "Resource not found".
### Do you have a reproducer?
By modifying [SubRouterTest#testSimpl... | 8d1c667a6848ed71753d4dd7d314cb8492fb09a2 | 0a998d8f269f8c12ec4980af8d1409b340f41b17 | https://github.com/vert-x3/vertx-web/compare/8d1c667a6848ed71753d4dd7d314cb8492fb09a2...0a998d8f269f8c12ec4980af8d1409b340f41b17 | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/impl/RouterImpl.java b/vertx-web/src/main/java/io/vertx/ext/web/impl/RouterImpl.java
index efae8cccd..63db497d3 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/impl/RouterImpl.java
+++ b/vertx-web/src/main/java/io/vertx/ext/web/impl/RouterImpl.java
@@ -346,12 ... | ['vertx-web/src/test/java/io/vertx/ext/web/SubRouterTest.java', 'vertx-web/src/main/java/io/vertx/ext/web/impl/RouterImpl.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,907,442 | 423,206 | 59,226 | 462 | 403 | 89 | 6 | 1 | 2,138 | 191 | 555 | 67 | 2 | 2 | 1970-01-01T00:27:26 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,243 | vert-x3/vertx-web/2159/2139 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/2139 | https://github.com/vert-x3/vertx-web/pull/2159 | https://github.com/vert-x3/vertx-web/pull/2159 | 1 | fix | ConcurrentLRUCache shouldn't be named concurrent or LRU? | Hey!
I happened to notice `io.vertx.ext.web.impl.ConcurrentLRUCache` class in this project. Is this still being maintained and/or used somewhere? I couldn't find any references to this class in the codebase except in the tests here, or any discussions related to this.
I was about to start using this for a simple ... | 8ed704182b18d459bd82c8bf2dc389d1a4edd8d5 | a6894b3407554f43db8fc07c579441e133d65ca8 | https://github.com/vert-x3/vertx-web/compare/8ed704182b18d459bd82c8bf2dc389d1a4edd8d5...a6894b3407554f43db8fc07c579441e133d65ca8 | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/impl/ConcurrentLRUCache.java b/vertx-web/src/main/java/io/vertx/ext/web/impl/ConcurrentLRUCache.java
deleted file mode 100644
index e4b91f050..000000000
--- a/vertx-web/src/main/java/io/vertx/ext/web/impl/ConcurrentLRUCache.java
+++ /dev/null
@@ -1,163 +0,0 @@
-/*
-... | ['vertx-web/src/test/java/io/vertx/ext/web/ConcurrentLRUCacheTest.java', 'vertx-web/src/main/java/io/vertx/ext/web/impl/ConcurrentLRUCache.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,930,111 | 428,865 | 59,963 | 466 | 3,834 | 925 | 163 | 1 | 1,065 | 172 | 221 | 11 | 0 | 0 | 1970-01-01T00:27:28 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,242 | vert-x3/vertx-web/2176/2169 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/2169 | https://github.com/vert-x3/vertx-web/pull/2176 | https://github.com/vert-x3/vertx-web/pull/2176 | 1 | fixes | fileUploads are un-ordered | ### Questions
`fileUploads` are stored in an `HashSet`, thus we lose the order they were sent from.
### Version
4.3.0-SNAPSHOT
### Context
I have a route which handle file uploads and it needs to retrieves the file names in the order they were sent.
### Do you have a reproducer?
The `HashSet` is cr... | 4e2a4aca621884107ab1b0651acc76361ddb0b75 | c1f6e93ee0ddec39f3edb92d715b20d09db6af4e | https://github.com/vert-x3/vertx-web/compare/4e2a4aca621884107ab1b0651acc76361ddb0b75...c1f6e93ee0ddec39f3edb92d715b20d09db6af4e | diff --git a/vertx-web-api-contract/src/main/java/io/vertx/ext/web/api/contract/openapi3/impl/OpenAPI3RequestValidationHandlerImpl.java b/vertx-web-api-contract/src/main/java/io/vertx/ext/web/api/contract/openapi3/impl/OpenAPI3RequestValidationHandlerImpl.java
index d8428e232..5992cc391 100644
--- a/vertx-web-api-contr... | ['vertx-web-validation/src/main/java/io/vertx/ext/web/validation/RequestPredicate.java', 'vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextDecorator.java', 'vertx-web-api-contract/src/main/java/io/vertx/ext/web/api/validation/impl/BaseValidationHandler.java', 'vertx-web/src/main/java/io/vertx/ext/web/Routing... | {'.java': 10} | 10 | 10 | 0 | 0 | 10 | 1,960,389 | 435,305 | 60,784 | 481 | 1,879 | 441 | 41 | 9 | 548 | 63 | 153 | 20 | 1 | 0 | 1970-01-01T00:27:32 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,241 | vert-x3/vertx-web/2186/2185 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/2185 | https://github.com/vert-x3/vertx-web/pull/2186 | https://github.com/vert-x3/vertx-web/pull/2186 | 1 | fixes | Subrouter fails if mounted on another subrouter on path with path params | ### Version
4.3.0 and 4.3.1-SNAPSHOT
### Context
Follow up on #2136 which still fails in some cases.
### Do you have a reproducer?
Add this to [SubRouterTest](https://github.com/vert-x3/vertx-web/blob/master/vertx-web/src/test/java/io/vertx/ext/web/SubRouterTest.java):
```
@Test // FAILS!
public... | f3e7c6e32632702bae3557c3da86fe8d35e23c5b | ab2318af9ac0cab9129a35fa4b38c5e58affe286 | https://github.com/vert-x3/vertx-web/compare/f3e7c6e32632702bae3557c3da86fe8d35e23c5b...ab2318af9ac0cab9129a35fa4b38c5e58affe286 | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/impl/RouteState.java b/vertx-web/src/main/java/io/vertx/ext/web/impl/RouteState.java
index b9833c6a3..7d54c0c76 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/impl/RouteState.java
+++ b/vertx-web/src/main/java/io/vertx/ext/web/impl/RouteState.java
@@ -1024,7 ... | ['vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextDecorator.java', 'vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextImplBase.java', 'vertx-web/src/test/java/io/vertx/ext/web/SubRouterTest.java', 'vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextImpl.java', 'vertx-web/src/main/java/io/... | {'.java': 7} | 7 | 7 | 0 | 0 | 7 | 1,965,720 | 436,450 | 60,969 | 482 | 2,332 | 517 | 68 | 6 | 2,445 | 203 | 613 | 77 | 2 | 2 | 1970-01-01T00:27:33 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,270 | vert-x3/vertx-web/1432/1429 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1429 | https://github.com/vert-x3/vertx-web/pull/1432 | https://github.com/vert-x3/vertx-web/pull/1432 | 1 | fixes | StaticHandlerImpl uses a shared DateFormat across threads causing issues with date parsing in header values | Continuing on this curious issue in Quarkus https://github.com/quarkusio/quarkus/issues/4627, apart from the fix done yesterday here https://github.com/vert-x3/vertx-web/issues/1423, it would be really odd that Firefox (that too the latest version) would send incorrect values for a header like `If-Modified-Since`. The ... | 32f6a489e9e53431a7051a6151977940150cb931 | 7eae93b1dce3d6c916e85b8372b1eece8a3a9e7e | https://github.com/vert-x3/vertx-web/compare/32f6a489e9e53431a7051a6151977940150cb931...7eae93b1dce3d6c916e85b8372b1eece8a3a9e7e | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/LoggerHandlerImpl.java b/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/LoggerHandlerImpl.java
index a76a6513e..282e8e99a 100755
--- a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/LoggerHandlerImpl.java
+++ b/vertx-web/src/main/java/io/v... | ['vertx-web/src/main/java/io/vertx/ext/web/handler/impl/StaticHandlerImpl.java', 'vertx-web/src/main/java/io/vertx/ext/web/impl/Utils.java', 'vertx-web/src/test/java/io/vertx/ext/web/handler/SessionHandlerTestBase.java', 'vertx-web/src/test/java/io/vertx/ext/web/handler/CookieHandlerTest.java', 'vertx-web/src/main/java... | {'.java': 6} | 6 | 6 | 0 | 0 | 6 | 1,211,345 | 271,625 | 38,526 | 292 | 2,339 | 482 | 49 | 3 | 1,389 | 194 | 298 | 9 | 3 | 1 | 1970-01-01T00:26:11 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,250 | vert-x3/vertx-web/1998/1996 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1996 | https://github.com/vert-x3/vertx-web/pull/1998 | https://github.com/vert-x3/vertx-web/pull/1998 | 1 | fixes | Hosted OpenAPI document relative `$ref` values replaced with absolute file paths | ### Version
4.1.0
### Context
When hosting an OpenAPI document using `io.vertx.ext.web.openapi.RouterBuilder` with `io.vertx.ext.web.openapi.RouterBuilderOptions#setContractEndpoint`, the hosted document has absolute paths in `$ref` attribute values. It appears the relative references (i.e. to `#/components/..... | bb945a87766b61f2c5e62690305406a811cd9e55 | d427e10d3a696ace43360000ed8b2c1cdfee6777 | https://github.com/vert-x3/vertx-web/compare/bb945a87766b61f2c5e62690305406a811cd9e55...d427e10d3a696ace43360000ed8b2c1cdfee6777 | diff --git a/vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/impl/OpenAPIHolderImpl.java b/vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/impl/OpenAPIHolderImpl.java
index f227a422c..c092f22bb 100755
--- a/vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/impl/OpenAPIHolderImpl.java
+++ b/vert... | ['vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/impl/OpenAPIHolderImpl.java', 'vertx-web-openapi/src/test/java/io/vertx/ext/web/openapi/impl/OpenAPIHolderTest.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,763,022 | 390,341 | 54,569 | 436 | 70 | 17 | 2 | 1 | 653 | 85 | 142 | 16 | 0 | 0 | 1970-01-01T00:27:06 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,273 | vert-x3/vertx-web/986/943 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/943 | https://github.com/vert-x3/vertx-web/pull/986 | https://github.com/vert-x3/vertx-web/pull/986 | 1 | fixes | ParsableHeaderValue::parameter does not call ensureHeaderProcessed | `ParsableHeaderValue::parameter` does not call `ensureHeaderProcessed`. Because of this, the function will return `null` even though there is a parameter.
Same goes for `parameters`
Workaround is to call `value` first | b1af8b3be4081a4a956853c5aa8c8a15685be6d2 | 9a3e485bf68656793363d36e7aaaf52bbe1d1fa4 | https://github.com/vert-x3/vertx-web/compare/b1af8b3be4081a4a956853c5aa8c8a15685be6d2...9a3e485bf68656793363d36e7aaaf52bbe1d1fa4 | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/impl/ParsableHeaderValue.java b/vertx-web/src/main/java/io/vertx/ext/web/impl/ParsableHeaderValue.java
index 596d7071e..b46cdfd77 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/impl/ParsableHeaderValue.java
+++ b/vertx-web/src/main/java/io/vertx/ext/web/impl/... | ['vertx-web/src/main/java/io/vertx/ext/web/impl/ParsableHeaderValue.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 926,962 | 209,607 | 29,639 | 223 | 59 | 10 | 2 | 1 | 223 | 29 | 50 | 5 | 0 | 0 | 1970-01-01T00:25:32 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,240 | vert-x3/vertx-web/2187/2182 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/2182 | https://github.com/vert-x3/vertx-web/pull/2187 | https://github.com/vert-x3/vertx-web/pull/2187 | 1 | fixes | Upgrading to 4.3.0 fails at the router Creation | I just upgraded to 4.3.0 from 4.2.7 and now the router creation fails with Cannot add [SECURITY_POLICY] handler to route with [BODY] handler at index 0.
java.lang.IllegalStateException: Cannot add [SECURITY_POLICY] handler to route with [BODY] handler at index 0
at io.vertx.ext.web.impl.RouteState.addContextHandle... | 553c190b657a928af84fb5ffba0c6d3bfa70feba | 101f13f33b847ad8c70e47fbd889546c420103df | https://github.com/vert-x3/vertx-web/compare/553c190b657a928af84fb5ffba0c6d3bfa70feba...101f13f33b847ad8c70e47fbd889546c420103df | diff --git a/vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/RouterBuilder.java b/vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/RouterBuilder.java
index fc1395d2a..ffadb3128 100644
--- a/vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/RouterBuilder.java
+++ b/vertx-web-openapi/src/main/java... | ['vertx-web-openapi/src/test/java/io/vertx/ext/web/openapi/RouterBuilderIntegrationTest.java', 'vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/RouterBuilder.java', 'vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/impl/OpenAPI3RouterBuilderImpl.java'] | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 1,966,252 | 436,577 | 61,001 | 482 | 1,762 | 365 | 39 | 2 | 1,371 | 141 | 371 | 24 | 2 | 0 | 1970-01-01T00:27:33 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,271 | vert-x3/vertx-web/1245/983 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/983 | https://github.com/vert-x3/vertx-web/pull/1245 | https://github.com/vert-x3/vertx-web/pull/1245 | 1 | fixes | */* produces does not limit AcceptableContentType based on Accept header | ### Version
* vert.x core: 3.6.0-SNAPSHOT
* vert.x web: 3.6.0-SNAPSHOT
### Context
When a route can produce `*/*` and the client specifies a specific content type via the Accept header, AcceptableContentType returns `*/*` instead of the client specified content type. To figure out what the client is requestin... | 9147d85ad6b300f6b75cd56907f594043797003c | d152aaf0aa21a99bc456adc733f992d759c8b483 | https://github.com/vert-x3/vertx-web/compare/9147d85ad6b300f6b75cd56907f594043797003c...d152aaf0aa21a99bc456adc733f992d759c8b483 | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/ParsedHeaderValues.java b/vertx-web/src/main/java/io/vertx/ext/web/ParsedHeaderValues.java
index 54e1a1777..b54d8171b 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/ParsedHeaderValues.java
+++ b/vertx-web/src/main/java/io/vertx/ext/web/ParsedHeaderValues.java... | ['vertx-web/src/main/java/io/vertx/ext/web/ParsedHeaderValues.java', 'vertx-web/src/test/java/io/vertx/ext/web/RouterTest.java', 'vertx-web/src/main/java/io/vertx/ext/web/impl/ParsableHeaderValuesContainer.java'] | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 1,117,662 | 250,532 | 35,342 | 278 | 1,114 | 243 | 27 | 2 | 1,285 | 134 | 286 | 40 | 0 | 2 | 1970-01-01T00:25:55 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,233 | vert-x3/vertx-web/2399/2388 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/2388 | https://github.com/vert-x3/vertx-web/pull/2399 | https://github.com/vert-x3/vertx-web/pull/2399 | 1 | fix | ParsableMIMEValue - component() and subComponent() do not ensure the header is parsed | ### Version
4.3.7
### Context
The `io.vertx.ext.web.impl.ParsableMIMEValue.component()` and `io.vertx.ext.web.impl.ParsableMIMEValue.subComponent()` methods do not call the `ensureHeaderProcessed()` method. As a result, these methods may return `null`.
A workaround exists: first call any other method that t... | 6ab7e72204338712bc1303bce252a9982721917b | ec366d0056ea438e1aac497a4e66e128678ddf6f | https://github.com/vert-x3/vertx-web/compare/6ab7e72204338712bc1303bce252a9982721917b...ec366d0056ea438e1aac497a4e66e128678ddf6f | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/impl/ParsableMIMEValue.java b/vertx-web/src/main/java/io/vertx/ext/web/impl/ParsableMIMEValue.java
index 01d24ed2f..dda7d80c9 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/impl/ParsableMIMEValue.java
+++ b/vertx-web/src/main/java/io/vertx/ext/web/impl/Parsab... | ['vertx-web/src/main/java/io/vertx/ext/web/impl/ParsableMIMEValue.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 2,020,811 | 448,355 | 62,401 | 504 | 59 | 10 | 2 | 1 | 539 | 53 | 129 | 12 | 0 | 0 | 1970-01-01T00:27:59 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,247 | vert-x3/vertx-web/2064/2063 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/2063 | https://github.com/vert-x3/vertx-web/pull/2064 | https://github.com/vert-x3/vertx-web/pull/2064 | 1 | fixes | AuthorizationHandlerImpl: hanging requests - ctx.fail() is never called at denied request with all authorizations already cached in session | ### Version
4.1.1
### Context
When `AuthorizationHandlerImpl` handles a denied request for a user with an active session where all authorizations are already fetched from all providers (at a previous request of the same user session) then `ctx.fail(...)` is never called, which causes the request to hang.
##... | ca67bd5de22f27d4389310c2fde293f9df161a94 | fad10340e34ffce9cdf34841f81301255ad0251c | https://github.com/vert-x3/vertx-web/compare/ca67bd5de22f27d4389310c2fde293f9df161a94...fad10340e34ffce9cdf34841f81301255ad0251c | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/AuthorizationHandlerImpl.java b/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/AuthorizationHandlerImpl.java
index 10d4a1b04..e794cea21 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/AuthorizationHandlerImpl.java
+++ b/vertx-w... | ['vertx-web/src/main/java/io/vertx/ext/web/handler/impl/AuthorizationHandlerImpl.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,913,013 | 424,082 | 59,336 | 474 | 855 | 181 | 19 | 1 | 524 | 77 | 110 | 16 | 0 | 0 | 1970-01-01T00:27:13 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,231 | vert-x3/vertx-web/2413/2219 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/2219 | https://github.com/vert-x3/vertx-web/pull/2413 | https://github.com/vert-x3/vertx-web/pull/2413 | 1 | fix | OAuth2AuthHandler.withScope returns new instance rather than updating current instance | ### Version
4.3.1
### Context
I upgraded from 4.0.0. There were a few changes I needed to make, which went fine. But when testing OAuth with Webex, I got a message saying I was passing an invalid scope. I checked the URL, and no scope was being passed although I called `withScope()`
Investigating further, I... | 62c838ebe99883d38606e9eef3dcbec3025ae9db | 70efdb09de560528968a88750c47e0f1ef914b6a | https://github.com/vert-x3/vertx-web/compare/62c838ebe99883d38606e9eef3dcbec3025ae9db...70efdb09de560528968a88750c47e0f1ef914b6a | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/handler/JWTAuthHandler.java b/vertx-web/src/main/java/io/vertx/ext/web/handler/JWTAuthHandler.java
index 9af0816ac..70cc1172c 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/handler/JWTAuthHandler.java
+++ b/vertx-web/src/main/java/io/vertx/ext/web/handler/JWT... | ['vertx-web/src/test/java/io/vertx/ext/web/handler/JWTAuthHandlerTest.java', 'vertx-web/src/main/java/io/vertx/ext/web/handler/impl/ScopedAuthentication.java', 'vertx-web/src/main/java/io/vertx/ext/web/handler/impl/OAuth2AuthHandlerImpl.java', 'vertx-web/src/main/java/io/vertx/ext/web/handler/OAuth2AuthHandler.java', '... | {'.java': 7} | 7 | 7 | 0 | 0 | 7 | 1,755,892 | 392,675 | 55,397 | 443 | 8,764 | 1,916 | 155 | 5 | 1,838 | 279 | 458 | 23 | 2 | 0 | 1970-01-01T00:28:00 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,272 | vert-x3/vertx-web/1046/1044 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1044 | https://github.com/vert-x3/vertx-web/pull/1046 | https://github.com/vert-x3/vertx-web/pull/1046 | 1 | fixes | OAuth handler should not redirect the callback route | when the oauth handle is set to protect everything e.g.: `router.route().handler(...` it always covers the `callback` handler and this will enter an infinite loop of redirects to the oauth provider and back. This needs to be whitelisted. | 19cfcfa8c421a207c430a8f3f3e301b0b2ffcb62 | 0140c6910f3c5c599eee1827d57b921fbfe687ba | https://github.com/vert-x3/vertx-web/compare/19cfcfa8c421a207c430a8f3f3e301b0b2ffcb62...0140c6910f3c5c599eee1827d57b921fbfe687ba | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/OAuth2AuthHandlerImpl.java b/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/OAuth2AuthHandlerImpl.java
index 414f08356..fb18a2b86 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/OAuth2AuthHandlerImpl.java
+++ b/vertx-web/src/ma... | ['vertx-web/src/test/java/io/vertx/ext/web/handler/OAuth2AuthHandlerTest.java', 'vertx-web/src/main/java/io/vertx/ext/web/handler/impl/OAuth2AuthHandlerImpl.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 989,166 | 222,491 | 31,395 | 246 | 1,426 | 274 | 22 | 1 | 237 | 37 | 51 | 1 | 0 | 0 | 1970-01-01T00:25:41 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,237 | vert-x3/vertx-web/2287/2282 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/2282 | https://github.com/vert-x3/vertx-web/pull/2287 | https://github.com/vert-x3/vertx-web/pull/2287 | 1 | fixes | BodyHandler Requires TRANSFER-ENCODING to react | ### Version
4.3.4
### Context
https://netty.io/news/2022/09/08/4-1-81-Final.html
> Connection related headers in HTTP/2 frames are now rejected, in compliance with the specification
It is no longer allowed to set TRANSFER-ENCODING chunked on HTTP2 connections but we are currently doing this to allow Bo... | 9736694b3b65a3fda3afbb82d98aa601f13822a8 | bca6a416ee852b4c50f3203e6278efa13735cf55 | https://github.com/vert-x3/vertx-web/compare/9736694b3b65a3fda3afbb82d98aa601f13822a8...bca6a416ee852b4c50f3203e6278efa13735cf55 | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/BodyHandlerImpl.java b/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/BodyHandlerImpl.java
index 0269e9cca..2e674a2ef 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/BodyHandlerImpl.java
+++ b/vertx-web/src/main/java/io/vertx/e... | ['vertx-web/src/main/java/io/vertx/ext/web/handler/impl/BodyHandlerImpl.java', 'vertx-web/src/main/java/io/vertx/ext/web/handler/impl/OAuth2AuthHandlerImpl.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,970,649 | 437,522 | 61,100 | 482 | 487 | 110 | 7 | 2 | 597 | 59 | 158 | 21 | 3 | 0 | 1970-01-01T00:27:46 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,239 | vert-x3/vertx-web/2213/2196 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/2196 | https://github.com/vert-x3/vertx-web/pull/2213 | https://github.com/vert-x3/vertx-web/pull/2213 | 1 | fixes | SSL not set for secure Request | ### Questions
I'm currently encountering a strange bug. I'm not entirely sure whether its me, or whether something odd is happening in the vertx Code.
I'm adding a secure cookie to a WebClientSession and then try to request a page from a server.
However, the cookie is not added to the request, since the request do... | c6aeabfae673afe2097ab799129b3dc21632d065 | 0375b9b78dc5cb496e64e26e403481551292f661 | https://github.com/vert-x3/vertx-web/compare/c6aeabfae673afe2097ab799129b3dc21632d065...0375b9b78dc5cb496e64e26e403481551292f661 | diff --git a/vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/HttpRequestImpl.java b/vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/HttpRequestImpl.java
index 34313458b..da9290138 100644
--- a/vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/HttpRequestImpl.java
+++ b/vertx-web-client... | ['vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/HttpRequestImpl.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,970,063 | 437,405 | 61,125 | 482 | 276 | 63 | 5 | 1 | 1,518 | 256 | 362 | 33 | 1 | 1 | 1970-01-01T00:27:35 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,257 | vert-x3/vertx-web/1852/1830 | vert-x3 | vertx-web | https://github.com/vert-x3/vertx-web/issues/1830 | https://github.com/vert-x3/vertx-web/pull/1852 | https://github.com/vert-x3/vertx-web/pull/1852 | 1 | fixes | SockJS websocket connections initially fail when combined with clustered infinispan-backed sessions | ### Version
4.0.0.Beta3 - 4.0.0
Version 3.X.Y, 4.0.0.Beta1 and 4.0.0.Beta2 are not effected.
### Context
Since vert.x stack version 4.0.0.Beta3 SockJS websocket connections are not established
for load-balanced verticles until the same verticle processes the initial sockjs "/info" request and the websocket... | 6c50bbde8119e6f3d104f47e2a1472b95e962706 | 5c0dc3722174379c4bf594b8add03e0436d52ce1 | https://github.com/vert-x3/vertx-web/compare/6c50bbde8119e6f3d104f47e2a1472b95e962706...5c0dc3722174379c4bf594b8add03e0436d52ce1 | diff --git a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/AuthenticationHandlerImpl.java b/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/AuthenticationHandlerImpl.java
index f3be81d40..f42f2013b 100644
--- a/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/AuthenticationHandlerImpl.java
+++ b/vert... | ['vertx-web/src/test/java/io/vertx/ext/web/sstore/ClusteredSessionHandlerTest.java', 'vertx-web/src/main/java/io/vertx/ext/web/handler/impl/SessionHandlerImpl.java', 'vertx-web/src/main/java/io/vertx/ext/web/handler/impl/AuthenticationHandlerImpl.java'] | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 1,711,255 | 378,609 | 52,958 | 417 | 2,311 | 447 | 53 | 2 | 1,023 | 116 | 287 | 29 | 2 | 0 | 1970-01-01T00:26:51 | 1,049 | Java | {'Java': 2911199, 'Python': 985896, 'HTML': 11069, 'JavaScript': 8466, 'Shell': 1414, 'Handlebars': 693, 'FreeMarker': 557, 'Batchfile': 249, 'Pug': 191, 'CSS': 113, 'Fluent': 27} | Apache License 2.0 |
1,342 | spring-cloud/spring-cloud-openfeign/202/189 | spring-cloud | spring-cloud-openfeign | https://github.com/spring-cloud/spring-cloud-openfeign/issues/189 | https://github.com/spring-cloud/spring-cloud-openfeign/pull/202 | https://github.com/spring-cloud/spring-cloud-openfeign/pull/202 | 1 | closes | Properly handle Pageable.unpaged() in PageableSpringEncoder | Version `2.1.1.RELEASE` introduced support for Spring's `Pageable` (#26). However the associated Encoder (`PageableSpringEncoder`) crashes when faced with `Pageable.unpaged()`, since the latter throws an `UnsupportedOperationException` on `Pageable.getPageNumber(int)`. This will lead to the very unspecific error:
`f... | eda905684de1007c7a65b378487b264b07b3da06 | ead4c47fcb42dc36106c2ceaf573fcfb97e2e28e | https://github.com/spring-cloud/spring-cloud-openfeign/compare/eda905684de1007c7a65b378487b264b07b3da06...ead4c47fcb42dc36106c2ceaf573fcfb97e2e28e | diff --git a/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/support/PageableSpringEncoder.java b/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/support/PageableSpringEncoder.java
index ddf631bb..4461f36b 100644
--- a/spring-cloud-openfeign-core/src/main/java... | ['spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/PageableEncoderTests.java', 'spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/support/PageableSpringEncoder.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 181,316 | 38,885 | 5,790 | 49 | 307 | 62 | 8 | 1 | 567 | 69 | 129 | 7 | 0 | 0 | 1970-01-01T00:26:04 | 1,041 | Java | {'Java': 869956, 'CSS': 34264, 'Ruby': 481} | Apache License 2.0 |
1,341 | spring-cloud/spring-cloud-openfeign/843/842 | spring-cloud | spring-cloud-openfeign | https://github.com/spring-cloud/spring-cloud-openfeign/issues/842 | https://github.com/spring-cloud/spring-cloud-openfeign/pull/843 | https://github.com/spring-cloud/spring-cloud-openfeign/pull/843#issuecomment-1453933064 | 1 | fixes | SpringQueryMap is ignored when used with Pageable | `@SpringQueryMap` is ignored when method includes `Pageable`
`Page<Dto> list(@SpringQueryMap Pojo pojo, Pageable pageable)`
this has been introduced in version 3.1.6 by https://github.com/spring-cloud/spring-cloud-openfeign/issues/753
`paramIndex` is set always to Pageable causing `PageableSpringQueryMapEncode... | 471c5c5cb11cf6d24dc49f0d4d94f003fc5b6c89 | 5bc28fa1dd47be69c1269b6bf013e42bc6b27ff2 | https://github.com/spring-cloud/spring-cloud-openfeign/compare/471c5c5cb11cf6d24dc49f0d4d94f003fc5b6c89...5bc28fa1dd47be69c1269b6bf013e42bc6b27ff2 | diff --git a/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/support/SpringMvcContract.java b/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/support/SpringMvcContract.java
index 430bb44c..746cec5c 100644
--- a/spring-cloud-openfeign-core/src/main/java/org/spr... | ['spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/support/SpringMvcContract.java', 'spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/SpringMvcContractTests.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 315,256 | 67,084 | 9,243 | 83 | 1,143 | 253 | 27 | 1 | 352 | 33 | 93 | 8 | 1 | 0 | 1970-01-01T00:27:57 | 1,041 | Java | {'Java': 869956, 'CSS': 34264, 'Ruby': 481} | Apache License 2.0 |
659 | spring-cloud/spring-cloud-dataflow/1236/1235 | spring-cloud | spring-cloud-dataflow | https://github.com/spring-cloud/spring-cloud-dataflow/issues/1235 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/1236 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/1236 | 1 | fixes | Providing long deployment property values hangs | Trying to set a property and if the value is too long it seems to hang - saw this from both shell and UI
```
dataflow:>stream deploy --name ticktock --properties "app.log.foo=FOOOOOOOOOOOBaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaar"
```
doesn't complete in a reasonable time. | e80994edc2f36881ac9e12941a46e82e26e41c39 | ff2de24b4a61193237143284979fa7298b8cf696 | https://github.com/spring-cloud/spring-cloud-dataflow/compare/e80994edc2f36881ac9e12941a46e82e26e41c39...ff2de24b4a61193237143284979fa7298b8cf696 | diff --git a/spring-cloud-dataflow-rest-resource/src/main/java/org/springframework/cloud/dataflow/rest/util/DeploymentPropertiesUtils.java b/spring-cloud-dataflow-rest-resource/src/main/java/org/springframework/cloud/dataflow/rest/util/DeploymentPropertiesUtils.java
index 5ecc255e4..1494b4c2f 100644
--- a/spring-cloud-... | ['spring-cloud-dataflow-rest-resource/src/main/java/org/springframework/cloud/dataflow/rest/util/DeploymentPropertiesUtils.java', 'spring-cloud-dataflow-rest-resource/src/test/java/org/springframework/cloud/dataflow/rest/job/support/DeploymentPropertiesUtilsTests.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,041,670 | 222,165 | 30,555 | 327 | 2,979 | 771 | 59 | 1 | 287 | 38 | 69 | 7 | 0 | 1 | 1970-01-01T00:24:49 | 1,007 | Java | {'Java': 6711491, 'Shell': 131470, 'TypeScript': 51513, 'Starlark': 14704, 'Dockerfile': 1362, 'Mustache': 1297, 'XSLT': 863, 'Ruby': 846, 'Python': 477, 'JavaScript': 310, 'Vim Snippet': 190} | Apache License 2.0 |
648 | spring-cloud/spring-cloud-dataflow/2358/2353 | spring-cloud | spring-cloud-dataflow | https://github.com/spring-cloud/spring-cloud-dataflow/issues/2353 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/2358 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/2358 | 1 | resolves | Streams definitions search is broken | _From @oodamien on August 3, 2018 20:52_
https://github.com/spring-cloud/spring-cloud-dataflow/commit/4cb9d85ff2d78d239df3b1b8541514e4780f4a84#diff-1b8ed5096382d31ece0a8397f1eb4cf2R135
The search parameter has changed.
_Copied from original issue: spring-cloud/spring-cloud-dataflow-ui#875_ | 042f28df7d5caf291bfb1831215f36398a7719b3 | 3010f9607f1d728fe4cfa3886dd25105fa26b84a | https://github.com/spring-cloud/spring-cloud-dataflow/compare/042f28df7d5caf291bfb1831215f36398a7719b3...3010f9607f1d728fe4cfa3886dd25105fa26b84a | diff --git a/spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/StreamDefinitionController.java b/spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/StreamDefinitionController.java
index 576c92897..bf2e1296f 100644
--- a... | ['spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/service/impl/AbstractStreamService.java', 'spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/StreamDefinitionController.java', 'spring-cloud-dataflow-server-core/src/main/java/o... | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 1,442,279 | 307,734 | 41,542 | 410 | 1,241 | 260 | 16 | 3 | 295 | 18 | 109 | 7 | 1 | 0 | 1970-01-01T00:25:33 | 1,007 | Java | {'Java': 6711491, 'Shell': 131470, 'TypeScript': 51513, 'Starlark': 14704, 'Dockerfile': 1362, 'Mustache': 1297, 'XSLT': 863, 'Ruby': 846, 'Python': 477, 'JavaScript': 310, 'Vim Snippet': 190} | Apache License 2.0 |
664 | spring-cloud/spring-cloud-dataflow/562/560 | spring-cloud | spring-cloud-dataflow | https://github.com/spring-cloud/spring-cloud-dataflow/issues/560 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/562 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/562 | 1 | fixes | module info doesn't work for Docker apps | If I do `module info sink:log` I get the following exception -
```
dataflow:>module list
╔══════╤═════════╤════╤════╗
║source│processor│sink│task║
╠══════╪═════════╪════╪════╣
║time │ │log │ ║
╚══════╧═════════╧════╧════╝
dataflow:>module info sink:log
Command failed org.springframework.cloud.dataflow.res... | d20999bbf76b7d82b86b2d332e305e8b12e24b94 | 746f5ec294f0338908cd572816117af6afae46b9 | https://github.com/spring-cloud/spring-cloud-dataflow/compare/d20999bbf76b7d82b86b2d332e305e8b12e24b94...746f5ec294f0338908cd572816117af6afae46b9 | diff --git a/spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/ModuleController.java b/spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/ModuleController.java
index fb8524b49..94da34645 100644
--- a/spring-cloud-datafl... | ['spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/ModuleController.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 670,638 | 142,603 | 20,007 | 206 | 531 | 105 | 11 | 1 | 2,351 | 102 | 521 | 37 | 0 | 1 | 1970-01-01T00:24:21 | 1,007 | Java | {'Java': 6711491, 'Shell': 131470, 'TypeScript': 51513, 'Starlark': 14704, 'Dockerfile': 1362, 'Mustache': 1297, 'XSLT': 863, 'Ruby': 846, 'Python': 477, 'JavaScript': 310, 'Vim Snippet': 190} | Apache License 2.0 |
658 | spring-cloud/spring-cloud-dataflow/1349/1241 | spring-cloud | spring-cloud-dataflow | https://github.com/spring-cloud/spring-cloud-dataflow/issues/1241 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/1349 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/1349 | 1 | resolves | Step Execution Count incorrect when same job is executed multiple times | When executing a batch job (with same job name) multiple times the step execution count for for all instances are the same. i.e. if a job has 3 steps, the step execution count for the first run will be 3. The next time its run the step count for the current run and previous run will be 6.
Steps to reproduce. Exec... | 15a17aec39efb159698cdf12eba1956feb536d81 | f98b8a2e9d3860605686ce3a18e728779f8e582a | https://github.com/spring-cloud/spring-cloud-dataflow/compare/15a17aec39efb159698cdf12eba1956feb536d81...f98b8a2e9d3860605686ce3a18e728779f8e582a | diff --git a/spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/service/impl/DefaultTaskJobService.java b/spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/service/impl/DefaultTaskJobService.java
index 9644bd213..91c521b15 100644
--- a/sprin... | ['spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/service/impl/DefaultTaskJobService.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,100,289 | 234,991 | 32,267 | 339 | 690 | 156 | 14 | 1 | 416 | 80 | 102 | 3 | 0 | 0 | 1970-01-01T00:24:52 | 1,007 | Java | {'Java': 6711491, 'Shell': 131470, 'TypeScript': 51513, 'Starlark': 14704, 'Dockerfile': 1362, 'Mustache': 1297, 'XSLT': 863, 'Ruby': 846, 'Python': 477, 'JavaScript': 310, 'Vim Snippet': 190} | Apache License 2.0 |
663 | spring-cloud/spring-cloud-dataflow/564/563 | spring-cloud | spring-cloud-dataflow | https://github.com/spring-cloud/spring-cloud-dataflow/issues/563 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/564 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/564 | 1 | resolves | NPE when module info doesn't exist | For the command `module info type:name` and if the app doesn't exist, then NPE is thrown.
```
dataflow:>module info processor:test
Command failed java.lang.NullPointerException
java.lang.NullPointerException
at org.springframework.cloud.dataflow.shell.command.ModuleCommands.info(ModuleCommands.java:101)
at sun... | 746f5ec294f0338908cd572816117af6afae46b9 | 119f173daba7f3bd176e4a77d5069745b416ec35 | https://github.com/spring-cloud/spring-cloud-dataflow/compare/746f5ec294f0338908cd572816117af6afae46b9...119f173daba7f3bd176e4a77d5069745b416ec35 | diff --git a/spring-cloud-dataflow-shell/src/main/java/org/springframework/cloud/dataflow/shell/command/ModuleCommands.java b/spring-cloud-dataflow-shell/src/main/java/org/springframework/cloud/dataflow/shell/command/ModuleCommands.java
index 3f507c9d3..868f7282d 100644
--- a/spring-cloud-dataflow-shell/src/main/java/o... | ['spring-cloud-dataflow-shell/src/test/java/org/springframework/cloud/dataflow/shell/command/ModuleCommandsTests.java', 'spring-cloud-dataflow-shell/src/main/java/org/springframework/cloud/dataflow/shell/command/ModuleCommands.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 670,777 | 142,638 | 20,010 | 206 | 2,491 | 528 | 55 | 1 | 1,198 | 50 | 245 | 20 | 0 | 1 | 1970-01-01T00:24:21 | 1,007 | Java | {'Java': 6711491, 'Shell': 131470, 'TypeScript': 51513, 'Starlark': 14704, 'Dockerfile': 1362, 'Mustache': 1297, 'XSLT': 863, 'Ruby': 846, 'Python': 477, 'JavaScript': 310, 'Vim Snippet': 190} | Apache License 2.0 |
662 | spring-cloud/spring-cloud-dataflow/1067/923 | spring-cloud | spring-cloud-dataflow | https://github.com/spring-cloud/spring-cloud-dataflow/issues/923 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/1067 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/1067 | 1 | fixes | Stream parser permits unbalanced quotes | You can create tasks such as:
```
`timestamp --format="asddd`
``` | 60bb7939d53231a3d18a94b40c9dca4d3dad4aae | 9dd230c3006585320b0b78ab19a59770ae68f011 | https://github.com/spring-cloud/spring-cloud-dataflow/compare/60bb7939d53231a3d18a94b40c9dca4d3dad4aae...9dd230c3006585320b0b78ab19a59770ae68f011 | diff --git a/spring-cloud-dataflow-core/src/main/java/org/springframework/cloud/dataflow/core/dsl/Tokenizer.java b/spring-cloud-dataflow-core/src/main/java/org/springframework/cloud/dataflow/core/dsl/Tokenizer.java
index 524a33da2..b3c9b1581 100644
--- a/spring-cloud-dataflow-core/src/main/java/org/springframework/clou... | ['spring-cloud-dataflow-core/src/test/java/org/springframework/cloud/dataflow/core/dsl/TaskParserTests.java', 'spring-cloud-dataflow-core/src/test/java/org/springframework/cloud/dataflow/core/dsl/StreamParserTests.java', 'spring-cloud-dataflow-core/src/main/java/org/springframework/cloud/dataflow/core/dsl/Tokenizer.jav... | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 846,280 | 177,655 | 24,594 | 284 | 524 | 144 | 9 | 1 | 67 | 10 | 19 | 5 | 0 | 1 | 1970-01-01T00:24:41 | 1,007 | Java | {'Java': 6711491, 'Shell': 131470, 'TypeScript': 51513, 'Starlark': 14704, 'Dockerfile': 1362, 'Mustache': 1297, 'XSLT': 863, 'Ruby': 846, 'Python': 477, 'JavaScript': 310, 'Vim Snippet': 190} | Apache License 2.0 |
661 | spring-cloud/spring-cloud-dataflow/1118/1070 | spring-cloud | spring-cloud-dataflow | https://github.com/spring-cloud/spring-cloud-dataflow/issues/1070 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/1118 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/1118 | 1 | resolves | REST: Retrieving non-existing app details should return a 404 | The issue is in class `AppRegistryController#DetailedAppRegistrationResource`
When executing a **GET** `/apps/{type}/{name}` a `200` HTTP Status is returned.
But it should produce a `404`.
We need to ensure that when making this minor **breaking change** that the shell and web UI are working. | 1131305790f5cea7d6d6ace57e171c2a6997f595 | 56472c0d1da7632e0acba9584a53bdf4e9eea048 | https://github.com/spring-cloud/spring-cloud-dataflow/compare/1131305790f5cea7d6d6ace57e171c2a6997f595...56472c0d1da7632e0acba9584a53bdf4e9eea048 | diff --git a/spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/AppRegistryController.java b/spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/AppRegistryController.java
index 092e4e259..51dd91e31 100644
--- a/spring-cl... | ['spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/AppRegistryController.java', 'spring-cloud-dataflow-shell-core/src/main/java/org/springframework/cloud/dataflow/shell/command/AppRegistryCommands.java', 'spring-cloud-dataflow-server-core/src/test/java/org/springframe... | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 856,660 | 179,835 | 24,861 | 286 | 2,959 | 602 | 63 | 2 | 302 | 42 | 69 | 7 | 0 | 0 | 1970-01-01T00:24:44 | 1,007 | Java | {'Java': 6711491, 'Shell': 131470, 'TypeScript': 51513, 'Starlark': 14704, 'Dockerfile': 1362, 'Mustache': 1297, 'XSLT': 863, 'Ruby': 846, 'Python': 477, 'JavaScript': 310, 'Vim Snippet': 190} | Apache License 2.0 |
643 | spring-cloud/spring-cloud-dataflow/3549/3546 | spring-cloud | spring-cloud-dataflow | https://github.com/spring-cloud/spring-cloud-dataflow/issues/3546 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/3549 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/3549 | 1 | resolves | SCDF fails to start with Scheduling disabled | As a user, when deploying SCDF to CF without Scheduling (i.e., `SPRING_CLOUD_DATAFLOW_FEATURES_SCHEDULES_ENABLED=false`), I get the following error on `master` and on `2.3 M2`.
```
2019-10-07T21:36:17.35-0700 [APP/PROC/WEB/0] OUT ***************************
2019-10-07T21:36:17.35-0700 [APP/PROC/WEB/0] OUT APPLI... | e466301ea38e0ab8ac8cba564214769fd97b9807 | 7431604333d48d74f26ab8219308b02dd99c8e88 | https://github.com/spring-cloud/spring-cloud-dataflow/compare/e466301ea38e0ab8ac8cba564214769fd97b9807...7431604333d48d74f26ab8219308b02dd99c8e88 | diff --git a/spring-cloud-dataflow-classic-docs/src/test/java/org/springframework/cloud/dataflow/server/rest/documentation/BaseDocumentation.java b/spring-cloud-dataflow-classic-docs/src/test/java/org/springframework/cloud/dataflow/server/rest/documentation/BaseDocumentation.java
index 13752c791..e2f7dd354 100644
--- a... | ['spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/service/impl/DefaultTaskDeleteService.java', 'spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/config/features/TaskConfiguration.java', 'spring-cloud-dataflow-server-core/src/test/java/or... | {'.java': 5} | 5 | 5 | 0 | 0 | 5 | 1,971,577 | 425,151 | 56,411 | 533 | 2,050 | 434 | 67 | 2 | 906 | 85 | 281 | 11 | 0 | 1 | 1970-01-01T00:26:11 | 1,007 | Java | {'Java': 6711491, 'Shell': 131470, 'TypeScript': 51513, 'Starlark': 14704, 'Dockerfile': 1362, 'Mustache': 1297, 'XSLT': 863, 'Ruby': 846, 'Python': 477, 'JavaScript': 310, 'Vim Snippet': 190} | Apache License 2.0 |
644 | spring-cloud/spring-cloud-dataflow/3274/3264 | spring-cloud | spring-cloud-dataflow | https://github.com/spring-cloud/spring-cloud-dataflow/issues/3264 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/3274 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/3274 | 1 | resolves | NPE when registering the app without the app resolution schema | As a user, I copied the following app registration command from the [Microsite](https://dataflow.spring.io/docs/recipes/polyglot/processor/), but it failed with an NPE.
register:
```
app register --type processor --name python-processor --uri springcloud/polyglot-python-processor:0.1
```
error:
```
2019-06-0... | ba7570c9443f58ca5784a5f4960841d6ed98a9d6 | 64bb806f267a325f7e513b710d4a608489171816 | https://github.com/spring-cloud/spring-cloud-dataflow/compare/ba7570c9443f58ca5784a5f4960841d6ed98a9d6...64bb806f267a325f7e513b710d4a608489171816 | diff --git a/spring-cloud-dataflow-registry/src/main/java/org/springframework/cloud/dataflow/registry/support/AppResourceCommon.java b/spring-cloud-dataflow-registry/src/main/java/org/springframework/cloud/dataflow/registry/support/AppResourceCommon.java
index 4c5cc44ea..85a42e2ff 100644
--- a/spring-cloud-dataflow-reg... | ['spring-cloud-dataflow-registry/src/test/java/org/springframework/cloud/dataflow/registry/support/AppResourceCommonTests.java', 'spring-cloud-dataflow-registry/src/main/java/org/springframework/cloud/dataflow/registry/support/AppResourceCommon.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,807,312 | 390,577 | 52,140 | 503 | 370 | 82 | 7 | 1 | 1,265 | 77 | 213 | 18 | 1 | 2 | 1970-01-01T00:25:59 | 1,007 | Java | {'Java': 6711491, 'Shell': 131470, 'TypeScript': 51513, 'Starlark': 14704, 'Dockerfile': 1362, 'Mustache': 1297, 'XSLT': 863, 'Ruby': 846, 'Python': 477, 'JavaScript': 310, 'Vim Snippet': 190} | Apache License 2.0 |
646 | spring-cloud/spring-cloud-dataflow/2509/2508 | spring-cloud | spring-cloud-dataflow | https://github.com/spring-cloud/spring-cloud-dataflow/issues/2508 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/2509 | https://github.com/spring-cloud/spring-cloud-dataflow/pull/2509 | 1 | resolves | app info cmd throws exception for `app info <type:name>` | Description:
```
dataflow:>app info source:http
Command failed java.lang.IllegalArgumentException: The options [<type>:<name>] and [--name && --type] are mutually exclusive and one of these should be specified to uniquely identify the application
```
Release versions:
Latest master, 1.7.0.RC1
| 26ebafe6c0c44d059c79b582aa2805b4cb71f864 | 6fab2419dcc3bed5e470dd8e92444278d0288345 | https://github.com/spring-cloud/spring-cloud-dataflow/compare/26ebafe6c0c44d059c79b582aa2805b4cb71f864...6fab2419dcc3bed5e470dd8e92444278d0288345 | diff --git a/spring-cloud-dataflow-shell-core/src/main/java/org/springframework/cloud/dataflow/shell/command/classic/ClassicAppRegistryCommands.java b/spring-cloud-dataflow-shell-core/src/main/java/org/springframework/cloud/dataflow/shell/command/classic/ClassicAppRegistryCommands.java
index 72c867037..0b3cf45be 100644... | ['spring-cloud-dataflow-shell-core/src/main/java/org/springframework/cloud/dataflow/shell/command/classic/ClassicAppRegistryCommands.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,555,448 | 331,474 | 44,779 | 445 | 297 | 76 | 5 | 1 | 306 | 36 | 69 | 10 | 0 | 1 | 1970-01-01T00:25:39 | 1,007 | Java | {'Java': 6711491, 'Shell': 131470, 'TypeScript': 51513, 'Starlark': 14704, 'Dockerfile': 1362, 'Mustache': 1297, 'XSLT': 863, 'Ruby': 846, 'Python': 477, 'JavaScript': 310, 'Vim Snippet': 190} | Apache License 2.0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.