id int64 0 10.2k | text_id stringlengths 17 67 | repo_owner stringclasses 232
values | repo_name stringclasses 295
values | issue_url stringlengths 39 89 | pull_url stringlengths 37 87 | comment_url stringlengths 37 94 | links_count int64 1 2 | link_keyword stringclasses 12
values | issue_title stringlengths 7 197 | issue_body stringlengths 45 21.3k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | diff_url stringlengths 120 170 | diff stringlengths 478 132k | changed_files stringlengths 47 2.6k | changed_files_exts stringclasses 22
values | changed_files_count int64 1 22 | java_changed_files_count int64 1 22 | kt_changed_files_count int64 0 0 | py_changed_files_count int64 0 0 | code_changed_files_count int64 1 22 | repo_symbols_count int64 32.6k 242M | repo_tokens_count int64 6.59k 49.2M | repo_lines_count int64 992 6.2M | repo_files_without_tests_count int64 12 28.1k | changed_symbols_count int64 0 36.1k | changed_tokens_count int64 0 6.5k | changed_lines_count int64 0 561 | changed_files_without_tests_count int64 1 17 | issue_symbols_count int64 45 21.3k | issue_words_count int64 2 1.39k | issue_tokens_count int64 13 4.47k | issue_lines_count int64 1 325 | issue_links_count int64 0 19 | issue_code_blocks_count int64 0 31 | pull_create_at timestamp[s] | repo_stars int64 10 44.3k | repo_language stringclasses 8
values | repo_languages stringclasses 296
values | repo_license stringclasses 2
values |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1,401 | grpc/grpc-java/1404/875 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/875 | https://github.com/grpc/grpc-java/pull/1404 | https://github.com/grpc/grpc-java/pull/1404 | 1 | fixes | InProcessTransport doesn't call onReady | The in-process transport supports flow control and supports `isReady()`, but it never calls `onReady()`. It seems to be just an oversight/bug. Since the in-process transport connects immediately, `onReady()` should probably be called on the client immediately in `newStream()`.
Locking will be a little interesting sinc... | 5b9726ea7dade0952d64796178dc0bdfd134d16d | 86f2c9f2243a8aa34e5d9de78dcae11da80edff6 | https://github.com/grpc/grpc-java/compare/5b9726ea7dade0952d64796178dc0bdfd134d16d...86f2c9f2243a8aa34e5d9de78dcae11da80edff6 | diff --git a/core/src/main/java/io/grpc/inprocess/InProcessTransport.java b/core/src/main/java/io/grpc/inprocess/InProcessTransport.java
index 3498173d6..f9ecf01ac 100644
--- a/core/src/main/java/io/grpc/inprocess/InProcessTransport.java
+++ b/core/src/main/java/io/grpc/inprocess/InProcessTransport.java
@@ -231,14 +231... | ['core/src/main/java/io/grpc/inprocess/InProcessTransport.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 2,433,670 | 526,713 | 68,915 | 299 | 1,575 | 289 | 44 | 1 | 643 | 90 | 141 | 4 | 0 | 0 | 1970-01-01T00:24:15 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,400 | grpc/grpc-java/1490/1476 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/1476 | https://github.com/grpc/grpc-java/pull/1490 | https://github.com/grpc/grpc-java/pull/1490 | 1 | resolves | TransportSet should reset current index on transportReady | If we successfully make a connection to an address, then that should mean the address is good. If it later is disconnected due to GOAWAY or transient failure we should start at the top of the list instead of trying less-desirable IPs.
This can cause errors, but any errors can already be gotten other ways, so it should... | 86bad4ffea5faf4d65cb943456bdf3d0d51d0766 | 643bb2c6b53d5a4516f13af856d98a85b334f0dc | https://github.com/grpc/grpc-java/compare/86bad4ffea5faf4d65cb943456bdf3d0d51d0766...643bb2c6b53d5a4516f13af856d98a85b334f0dc | diff --git a/core/src/main/java/io/grpc/internal/TransportSet.java b/core/src/main/java/io/grpc/internal/TransportSet.java
index 0fa578476..d3f884e38 100644
--- a/core/src/main/java/io/grpc/internal/TransportSet.java
+++ b/core/src/main/java/io/grpc/internal/TransportSet.java
@@ -77,12 +77,11 @@ final class TransportSe... | ['core/src/test/java/io/grpc/internal/TransportSetTest.java', 'core/src/test/java/io/grpc/internal/ManagedChannelImplTransportManagerTest.java', 'core/src/main/java/io/grpc/internal/TransportSet.java'] | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 2,484,255 | 536,922 | 70,259 | 303 | 1,510 | 333 | 33 | 1 | 351 | 63 | 74 | 4 | 0 | 0 | 1970-01-01T00:24:16 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,399 | grpc/grpc-java/1602/1546 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/1546 | https://github.com/grpc/grpc-java/pull/1602 | https://github.com/grpc/grpc-java/pull/1602 | 1 | resolves | If DNS resolution fails, the Channel is permanently failed | We should probably update DnsNameResolver to continue retrying the DNS query until shutdown, at maybe a fixed rate of 1 minute or such. Overall, it's not a superb solution, but it fixes a lot of the problem and is expedient to implement.
| 575df76a8fa9a5c15213e49c3abb3de021239ace | 2d15af53c7a9129b53c6ac6ac510d38f23276117 | https://github.com/grpc/grpc-java/compare/575df76a8fa9a5c15213e49c3abb3de021239ace...2d15af53c7a9129b53c6ac6ac510d38f23276117 | diff --git a/core/src/main/java/io/grpc/DnsNameResolver.java b/core/src/main/java/io/grpc/DnsNameResolver.java
index ce787ebbe..ae5fa0457 100644
--- a/core/src/main/java/io/grpc/DnsNameResolver.java
+++ b/core/src/main/java/io/grpc/DnsNameResolver.java
@@ -31,16 +31,21 @@
package io.grpc;
+import com.google.common... | ['core/src/main/java/io/grpc/DnsNameResolverFactory.java', 'core/src/main/java/io/grpc/internal/GrpcUtil.java', 'core/src/main/java/io/grpc/DnsNameResolver.java', 'core/src/test/java/io/grpc/DnsNameResolverTest.java', 'core/src/test/java/io/grpc/internal/FakeClock.java'] | {'.java': 5} | 5 | 5 | 0 | 0 | 5 | 3,146,686 | 672,419 | 87,585 | 284 | 4,932 | 950 | 122 | 3 | 238 | 42 | 54 | 2 | 0 | 0 | 1970-01-01T00:24:19 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,392 | grpc/grpc-java/2258/2246 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/2246 | https://github.com/grpc/grpc-java/pull/2258 | https://github.com/grpc/grpc-java/pull/2258 | 1 | resolves | Deadlock with TransportSet | Hello,
I was testing Grpc with RoundRobinLB and a custom NameResolver when this deadlock happened:
> Found one Java-level deadlock:
>
> "grpc-timer-0":
> waiting to lock monitor 0x00007fa1b00062c8 (object 0x00000007397d7f88, a java.lang.Object),
> which is held by "main"
> "main":
> waiting to lock monitor 0x0... | 8b745d9114fe11b0b9c65b67006a8ad0b7a11325 | 3d4ae360746c7f95b42a685d1254e69d0f0061f4 | https://github.com/grpc/grpc-java/compare/8b745d9114fe11b0b9c65b67006a8ad0b7a11325...3d4ae360746c7f95b42a685d1254e69d0f0061f4 | diff --git a/core/src/main/java/io/grpc/internal/TransportSet.java b/core/src/main/java/io/grpc/internal/TransportSet.java
index 025b83276..d89a8ac49 100644
--- a/core/src/main/java/io/grpc/internal/TransportSet.java
+++ b/core/src/main/java/io/grpc/internal/TransportSet.java
@@ -249,9 +249,14 @@ final class TransportS... | ['core/src/main/java/io/grpc/internal/TransportSet.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,796,050 | 808,722 | 105,188 | 333 | 499 | 98 | 7 | 1 | 2,336 | 167 | 631 | 42 | 0 | 0 | 1970-01-01T00:24:33 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,397 | grpc/grpc-java/1896/1883 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/1883 | https://github.com/grpc/grpc-java/pull/1896 | https://github.com/grpc/grpc-java/pull/1896 | 1 | resolves | java.lang.IllegalArgumentException when try to use ipv6 | I guess this is caused by the scopeId:
```
java.lang.IllegalArgumentException: cannot find a NameResolver for directaddress:////0:0:0:0:0:0:0:0%0:10005 (Malformed escape pair at index 33: directaddress:////0:0:0:0:0:0:0:0%0:10005)
at io.grpc.internal.ManagedChannelImpl.getNameResolver(ManagedChannelImpl.java:238)
at i... | d25b65bb53258fc033e58cbaab4013a329ff45ce | 631a9d5fac0257416d3f74e53c9729989b8cd8b2 | https://github.com/grpc/grpc-java/compare/d25b65bb53258fc033e58cbaab4013a329ff45ce...631a9d5fac0257416d3f74e53c9729989b8cd8b2 | diff --git a/core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java b/core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java
index d14b09f1c..4cb74e9b9 100644
--- a/core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java
+++ b/core/src/main/java/io/grpc/interna... | ['core/src/main/java/io/grpc/internal/ManagedChannelImpl.java', 'core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java', 'core/src/test/java/io/grpc/internal/ManagedChannelImplGetNameResolverTest.java'] | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 3,501,533 | 745,601 | 97,876 | 311 | 961 | 207 | 21 | 2 | 493 | 30 | 137 | 9 | 0 | 1 | 1970-01-01T00:24:24 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,396 | grpc/grpc-java/1979/1652 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/1652 | https://github.com/grpc/grpc-java/pull/1979 | https://github.com/grpc/grpc-java/pull/1979 | 1 | fixes | Exceptions thrown in StreamObserver.onNext() may be swallowed | For unary calls it appears the exception is basically guaranteed to be swallowed.
See #1638 for some discussion. Basically we try to fail the call with a Status, but if the call already completed successfully (which is especially likely for unary calls) the exception is thrown away.
| 6c59770a5bd54857290dfb0496fe0b81fc79bd57 | 46f418da9408bc6e9d5172ea3a7c467b30c6b358 | https://github.com/grpc/grpc-java/compare/6c59770a5bd54857290dfb0496fe0b81fc79bd57...46f418da9408bc6e9d5172ea3a7c467b30c6b358 | diff --git a/core/src/main/java/io/grpc/internal/ClientCallImpl.java b/core/src/main/java/io/grpc/internal/ClientCallImpl.java
index 366d0f7b3..baa117507 100644
--- a/core/src/main/java/io/grpc/internal/ClientCallImpl.java
+++ b/core/src/main/java/io/grpc/internal/ClientCallImpl.java
@@ -414,8 +414,10 @@ final class Cl... | ['core/src/main/java/io/grpc/internal/ClientCallImpl.java', 'core/src/test/java/io/grpc/internal/ClientCallImplTest.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 3,591,771 | 764,473 | 100,173 | 326 | 1,734 | 309 | 44 | 1 | 284 | 47 | 55 | 3 | 0 | 0 | 1970-01-01T00:24:26 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,395 | grpc/grpc-java/2025/1947 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/1947 | https://github.com/grpc/grpc-java/pull/2025 | https://github.com/grpc/grpc-java/pull/2025 | 1 | fixes | ServerCallImpl's use of metadata in sendHeaders is thread-unsafe | `ServerCallImpl` uses metadata to determine compression settings in [sendHeaders](https://github.com/grpc/grpc-java/blob/a2076f4/core/src/main/java/io/grpc/internal/ServerCallImpl.java#L111). However, that `Metadata` has already been passed to the application which is free to modify it. The `acceptEncodings` should jus... | 0d6a9de54c3ef7800b76405ecd9ff581c90f6c7a | 0e47be12878fe1dfb0504ed43ec8f363fe9eb1ce | https://github.com/grpc/grpc-java/compare/0d6a9de54c3ef7800b76405ecd9ff581c90f6c7a...0e47be12878fe1dfb0504ed43ec8f363fe9eb1ce | diff --git a/core/src/main/java/io/grpc/internal/ServerCallImpl.java b/core/src/main/java/io/grpc/internal/ServerCallImpl.java
index 6e0707b32..d2a4e9029 100644
--- a/core/src/main/java/io/grpc/internal/ServerCallImpl.java
+++ b/core/src/main/java/io/grpc/internal/ServerCallImpl.java
@@ -62,7 +62,7 @@ final class Serve... | ['core/src/main/java/io/grpc/internal/ServerCallImpl.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,656,371 | 777,801 | 101,644 | 330 | 680 | 131 | 12 | 1 | 374 | 38 | 83 | 2 | 1 | 0 | 1970-01-01T00:24:28 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,394 | grpc/grpc-java/2064/2036 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/2036 | https://github.com/grpc/grpc-java/pull/2064 | https://github.com/grpc/grpc-java/pull/2064 | 1 | fixes | Metadata trailers are not passed to Status*Exception when using ClientCalls.blockingUnaryCall. | Trying to write a sample for #1295, but when calling unary rpc method on blocking stub, the trailers are not passed during `ClientCalls.getUnchecked` which is called from [ClientCalls.blockingUnaryCall](https://github.com/grpc/grpc-java/blob/master/stub/src/main/java/io/grpc/stub/ClientCalls.java#L141).
Is this by des... | 30c2b0eda023e05e431d7bc2cb977c958dab958e | 26065c742d21bc10361aacce3c4e38e83bab579f | https://github.com/grpc/grpc-java/compare/30c2b0eda023e05e431d7bc2cb977c958dab958e...26065c742d21bc10361aacce3c4e38e83bab579f | diff --git a/stub/src/main/java/io/grpc/stub/ClientCalls.java b/stub/src/main/java/io/grpc/stub/ClientCalls.java
index 529649763..b3cb880ac 100644
--- a/stub/src/main/java/io/grpc/stub/ClientCalls.java
+++ b/stub/src/main/java/io/grpc/stub/ClientCalls.java
@@ -31,6 +31,8 @@
package io.grpc.stub;
+import static com... | ['stub/src/main/java/io/grpc/stub/ClientCalls.java', 'stub/src/test/java/io/grpc/stub/ClientCallsTest.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 3,465,530 | 735,797 | 95,719 | 310 | 1,371 | 266 | 28 | 1 | 656 | 46 | 184 | 6 | 3 | 0 | 1970-01-01T00:24:28 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,393 | grpc/grpc-java/2154/2152 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/2152 | https://github.com/grpc/grpc-java/pull/2154 | https://github.com/grpc/grpc-java/pull/2154 | 1 | resolves | Deadlock found in TransportSet | When running benchmarks where the client started up faster than the server, The first few calls failed as unavailable. Our internal deadlock detector seems to think there is a deadlock around here:
```
Deadlock(s) found:
"grpc-client-net-1-32" daemon prio=5 Id=175 BLOCKED on java.lang.Object@7eeb2e6b owned by "grpc-c... | 3879c6a8fa4b0ec25f211019ec26b0acee8976cb | 7a33fae8e8cd4d36c4986b0644f13c8d8d2f2d6f | https://github.com/grpc/grpc-java/compare/3879c6a8fa4b0ec25f211019ec26b0acee8976cb...7a33fae8e8cd4d36c4986b0644f13c8d8d2f2d6f | diff --git a/core/src/main/java/io/grpc/internal/TransportSet.java b/core/src/main/java/io/grpc/internal/TransportSet.java
index dc04c9497..025b83276 100644
--- a/core/src/main/java/io/grpc/internal/TransportSet.java
+++ b/core/src/main/java/io/grpc/internal/TransportSet.java
@@ -227,8 +227,10 @@ final class TransportS... | ['core/src/main/java/io/grpc/internal/TransportSet.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,723,185 | 792,487 | 103,198 | 322 | 885 | 177 | 17 | 1 | 4,355 | 103 | 938 | 56 | 0 | 1 | 1970-01-01T00:24:30 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,406 | grpc/grpc-java/1260/1251 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/1251 | https://github.com/grpc/grpc-java/pull/1260 | https://github.com/grpc/grpc-java/pull/1260 | 1 | fixes | Netty Server does not observe channelInactive | If the TCP connection goes down, gRPC isn't noticing because nothing is observing the `channelInactive()` notification on the channel pipeline. I confirmed that `channelInactive()` is called, but saw that an outstanding streaming RPC was not cancelled.
This likely applies to both client-side and server-side; I only ve... | 8d0b5b0c4d40c5ee4dba7e74851c9eecc3bb400e | 96f9cefda41bbbf1462bfe607864d451bc716219 | https://github.com/grpc/grpc-java/compare/8d0b5b0c4d40c5ee4dba7e74851c9eecc3bb400e...96f9cefda41bbbf1462bfe607864d451bc716219 | diff --git a/netty/src/main/java/io/grpc/netty/NettyServerHandler.java b/netty/src/main/java/io/grpc/netty/NettyServerHandler.java
index e7d6ea2dd..06b5a3fb9 100644
--- a/netty/src/main/java/io/grpc/netty/NettyServerHandler.java
+++ b/netty/src/main/java/io/grpc/netty/NettyServerHandler.java
@@ -261,18 +261,21 @@ class... | ['netty/src/test/java/io/grpc/netty/NettyServerHandlerTest.java', 'netty/src/main/java/io/grpc/netty/NettyServerHandler.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 2,139,256 | 461,888 | 60,556 | 276 | 946 | 191 | 25 | 1 | 353 | 51 | 68 | 4 | 0 | 0 | 1970-01-01T00:24:09 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,405 | grpc/grpc-java/1262/1251 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/1251 | https://github.com/grpc/grpc-java/pull/1262 | https://github.com/grpc/grpc-java/pull/1262 | 1 | fixes | Netty Server does not observe channelInactive | If the TCP connection goes down, gRPC isn't noticing because nothing is observing the `channelInactive()` notification on the channel pipeline. I confirmed that `channelInactive()` is called, but saw that an outstanding streaming RPC was not cancelled.
This likely applies to both client-side and server-side; I only ve... | 999f408ff29b61d2bdd5cd723f614c70320adf16 | 3e0f44fb8c73e51927eb5e077fd69c8571f693ad | https://github.com/grpc/grpc-java/compare/999f408ff29b61d2bdd5cd723f614c70320adf16...3e0f44fb8c73e51927eb5e077fd69c8571f693ad | diff --git a/netty/src/main/java/io/grpc/netty/NettyServerHandler.java b/netty/src/main/java/io/grpc/netty/NettyServerHandler.java
index 94f287629..7e53e731a 100644
--- a/netty/src/main/java/io/grpc/netty/NettyServerHandler.java
+++ b/netty/src/main/java/io/grpc/netty/NettyServerHandler.java
@@ -224,15 +224,18 @@ class... | ['netty/src/test/java/io/grpc/netty/NettyServerHandlerTest.java', 'netty/src/main/java/io/grpc/netty/NettyServerHandler.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,856,798 | 390,397 | 53,465 | 239 | 750 | 153 | 21 | 1 | 353 | 51 | 68 | 4 | 0 | 0 | 1970-01-01T00:24:09 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,416 | grpc/grpc-java/364/359 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/359 | https://github.com/grpc/grpc-java/pull/364 | https://github.com/grpc/grpc-java/pull/364 | 1 | resolves | Http2ClientStream overwrites error message | [Http2ClientStream.transportHeadersReceived()](https://github.com/grpc/grpc-java/blob/d0aad72441f2f110910003599bb923db6f671f02/core/src/main/java/io/grpc/transport/Http2ClientStream.java#L102) is calling withDescription instead of augmentDescription. This hinders debugging what went wrong.
@yang-g, since he is interes... | 41940f7ff7025ba703bf7d77f90fd376f825f75b | 2b33598ec4b377a7cae8d55e8c020c1171d119a2 | https://github.com/grpc/grpc-java/compare/41940f7ff7025ba703bf7d77f90fd376f825f75b...2b33598ec4b377a7cae8d55e8c020c1171d119a2 | diff --git a/core/src/main/java/io/grpc/transport/Http2ClientStream.java b/core/src/main/java/io/grpc/transport/Http2ClientStream.java
index badc7c0f2..85577cc8f 100644
--- a/core/src/main/java/io/grpc/transport/Http2ClientStream.java
+++ b/core/src/main/java/io/grpc/transport/Http2ClientStream.java
@@ -99,7 +99,7 @@ p... | ['core/src/main/java/io/grpc/transport/Http2ClientStream.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 748,500 | 156,719 | 20,878 | 125 | 168 | 32 | 2 | 1 | 350 | 23 | 87 | 4 | 1 | 0 | 1970-01-01T00:23:50 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,407 | grpc/grpc-java/1112/1111 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/1111 | https://github.com/grpc/grpc-java/pull/1112 | https://github.com/grpc/grpc-java/pull/1112 | 1 | fixes | transportShutdown() should be called before calling transportTerminated(). | With the changes of TransportSet, transportShutdown() must be called before calling transportTerminated().
```
10-06 15:32:45.917 5126 5126 E AndroidRuntime: FATAL EXCEPTION: OkHttpClientTransport
10-06 15:32:45.917 5126 5126 E AndroidRuntime: Process: com.google.android.apps.fireball, PID: 5126
10-06 15:32:45.917... | 6474938fe7e9c9355a5fa1004f4cae39ad069797 | 72a0a38182bc7b1f32868cfc8c1fc3e2667a5f04 | https://github.com/grpc/grpc-java/compare/6474938fe7e9c9355a5fa1004f4cae39ad069797...72a0a38182bc7b1f32868cfc8c1fc3e2667a5f04 | diff --git a/core/src/main/java/io/grpc/internal/ClientTransport.java b/core/src/main/java/io/grpc/internal/ClientTransport.java
index 8f287973c..c2c88e47b 100644
--- a/core/src/main/java/io/grpc/internal/ClientTransport.java
+++ b/core/src/main/java/io/grpc/internal/ClientTransport.java
@@ -114,6 +114,8 @@ public inte... | ['core/src/main/java/io/grpc/internal/ClientTransport.java', 'okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java', 'okhttp/src/test/java/io/grpc/okhttp/OkHttpClientTransportTest.java'] | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 1,873,238 | 393,629 | 53,916 | 241 | 3,020 | 657 | 52 | 2 | 1,418 | 109 | 427 | 15 | 0 | 1 | 1970-01-01T00:24:04 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,414 | grpc/grpc-java/692/687 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/687 | https://github.com/grpc/grpc-java/pull/692 | https://github.com/grpc/grpc-java/pull/692 | 1 | fixes | Fix UNKNOWN status without description | https://github.com/grpc/grpc-java/blob/d2b1b37ed7ba0087fd8a2920549118191ce22f95/core/src/main/java/io/grpc/ChannelImpl.java#L311
https://github.com/grpc/grpc-java/blob/3e26b993ce90901b32faa1b8b855abfdc2153bc6/netty/src/main/java/io/grpc/transport/netty/NettyClientHandler.java#L212
We should basically always provide a ... | 384a80593d42cf3a4045e21b6a61fa601a81bbb1 | 248f575a59ec39be9e30f0b21984bea07dc8e775 | https://github.com/grpc/grpc-java/compare/384a80593d42cf3a4045e21b6a61fa601a81bbb1...248f575a59ec39be9e30f0b21984bea07dc8e775 | diff --git a/core/src/main/java/io/grpc/ChannelImpl.java b/core/src/main/java/io/grpc/ChannelImpl.java
index 4e4acebb7..c50950d1a 100644
--- a/core/src/main/java/io/grpc/ChannelImpl.java
+++ b/core/src/main/java/io/grpc/ChannelImpl.java
@@ -308,7 +308,7 @@ public final class ChannelImpl extends Channel {
act... | ['core/src/main/java/io/grpc/ChannelImpl.java', 'netty/src/main/java/io/grpc/transport/netty/NettyClientHandler.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,690,743 | 355,500 | 49,039 | 211 | 685 | 140 | 11 | 2 | 493 | 36 | 140 | 5 | 2 | 0 | 1970-01-01T00:23:58 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,408 | grpc/grpc-java/1027/694 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/694 | https://github.com/grpc/grpc-java/pull/1027 | https://github.com/grpc/grpc-java/pull/1027 | 1 | fixes | Double-closure of call during interop tests | I find it in the stderr of the test report of Netty, Netty local channel, and OkHttp. I see it printed out to my console once, so I think that may be from the InProcess test.
This exception very likely means we have a bug and are double-closing.
```
java.lang.IllegalStateException: call already closed
at com.goog... | efa774b846ac493886509cd51f71db4554e92993 | 47ad6f81bfee08aefec15f6b42bef9e0d2c66863 | https://github.com/grpc/grpc-java/compare/efa774b846ac493886509cd51f71db4554e92993...47ad6f81bfee08aefec15f6b42bef9e0d2c66863 | diff --git a/interop-testing/src/main/java/io/grpc/testing/integration/TestServiceImpl.java b/interop-testing/src/main/java/io/grpc/testing/integration/TestServiceImpl.java
index b3de8b624..d73aee095 100644
--- a/interop-testing/src/main/java/io/grpc/testing/integration/TestServiceImpl.java
+++ b/interop-testing/src/ma... | ['interop-testing/src/main/java/io/grpc/testing/integration/TestServiceImpl.java', 'stub/src/main/java/io/grpc/stub/ServerCalls.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,869,737 | 392,608 | 53,814 | 241 | 1,510 | 291 | 39 | 2 | 1,594 | 84 | 347 | 23 | 0 | 1 | 1970-01-01T00:24:02 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,420 | grpc/grpc-java/247/246 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/246 | https://github.com/grpc/grpc-java/pull/247 | https://github.com/grpc/grpc-java/pull/247 | 1 | resolves | ClientAuthInterceptor synchronizes on wrong object | The "this" in synchronized (this), is not the correct object to synchronize on:
https://github.com/grpc/grpc-java/blob/master/auth/src/main/java/io/grpc/auth/ClientAuthInterceptor.java#L77
It should be ClientAuthInterceptor.this instead. As the code stands, there is no synchronization between threads so you can see Nu... | e515c772cd81cc4ee1b6f24c1c36afbaac1c2ebb | b48b4db3fb3577ed21da8f05e3c0428a991e3eed | https://github.com/grpc/grpc-java/compare/e515c772cd81cc4ee1b6f24c1c36afbaac1c2ebb...b48b4db3fb3577ed21da8f05e3c0428a991e3eed | diff --git a/auth/src/main/java/io/grpc/auth/ClientAuthInterceptor.java b/auth/src/main/java/io/grpc/auth/ClientAuthInterceptor.java
index 17c3aaec5..3351aa715 100644
--- a/auth/src/main/java/io/grpc/auth/ClientAuthInterceptor.java
+++ b/auth/src/main/java/io/grpc/auth/ClientAuthInterceptor.java
@@ -74,7 +74,8 @@ publi... | ['auth/src/main/java/io/grpc/auth/ClientAuthInterceptor.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 681,110 | 142,103 | 18,955 | 109 | 241 | 42 | 8 | 1 | 379 | 41 | 78 | 5 | 1 | 0 | 1970-01-01T00:23:47 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,419 | grpc/grpc-java/249/239 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/239 | https://github.com/grpc/grpc-java/pull/249 | https://github.com/grpc/grpc-java/pull/249 | 1 | resolves | Lacking preconditions for start() in ChannelImpl.CallImpl | For instance, calling request() before start() has been called results in a NullPointerException.
| 191dcd38ac8a5bb3e6ce4238d673200d6ff6f097 | 966e1200986c007666a7a4a74bbcb9c0a28742e9 | https://github.com/grpc/grpc-java/compare/191dcd38ac8a5bb3e6ce4238d673200d6ff6f097...966e1200986c007666a7a4a74bbcb9c0a28742e9 | diff --git a/core/src/main/java/io/grpc/ChannelImpl.java b/core/src/main/java/io/grpc/ChannelImpl.java
index 033de038a..8baf9824f 100644
--- a/core/src/main/java/io/grpc/ChannelImpl.java
+++ b/core/src/main/java/io/grpc/ChannelImpl.java
@@ -265,6 +265,7 @@ public final class ChannelImpl implements Channel {
@Ove... | ['core/src/main/java/io/grpc/ChannelImpl.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 681,132 | 142,129 | 18,944 | 109 | 63 | 12 | 1 | 1 | 98 | 13 | 17 | 2 | 0 | 0 | 1970-01-01T00:23:47 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,418 | grpc/grpc-java/250/238 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/238 | https://github.com/grpc/grpc-java/pull/250 | https://github.com/grpc/grpc-java/pull/250 | 1 | resolves | Race in Server handler initialization | When initializing an incoming client connection, [we call startAsync()](https://github.com/grpc/grpc-java/blob/master/netty/src/main/java/io/grpc/transport/netty/NettyServer.java#L84) on the transport, which [registers the handler](https://github.com/grpc/grpc-java/blob/master/netty/src/main/java/io/grpc/transport/nett... | 966e1200986c007666a7a4a74bbcb9c0a28742e9 | 9bd31daee673adfd3877bb2a6e1635e665231e9e | https://github.com/grpc/grpc-java/compare/966e1200986c007666a7a4a74bbcb9c0a28742e9...9bd31daee673adfd3877bb2a6e1635e665231e9e | diff --git a/netty/src/main/java/io/grpc/transport/netty/NettyServer.java b/netty/src/main/java/io/grpc/transport/netty/NettyServer.java
index a96dce64b..c2c252789 100644
--- a/netty/src/main/java/io/grpc/transport/netty/NettyServer.java
+++ b/netty/src/main/java/io/grpc/transport/netty/NettyServer.java
@@ -81,7 +81,10... | ['netty/src/main/java/io/grpc/transport/netty/NettyServer.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 681,195 | 142,141 | 18,945 | 109 | 324 | 61 | 5 | 1 | 946 | 99 | 221 | 12 | 2 | 1 | 1970-01-01T00:23:47 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,417 | grpc/grpc-java/345/330 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/330 | https://github.com/grpc/grpc-java/pull/345 | https://github.com/grpc/grpc-java/pull/345 | 1 | fixes | OkHttpClientTransport.onGoAway() races with startPendingStreams() | onGoAway has two phases: do things necessary under lock and final cleanup. In the first phase it collects the streams to terminate in the second and sets goAway.
startPendingStreams() does not observe goAway and also creates new streams that should be failed due to the goAway. From an initial look, it seems it would b... | 986d221eaa70139206e035821e9951f822e01893 | 8a5d927a9a8d61431f7ed7fab97abaff03d23d2c | https://github.com/grpc/grpc-java/compare/986d221eaa70139206e035821e9951f822e01893...8a5d927a9a8d61431f7ed7fab97abaff03d23d2c | diff --git a/okhttp/src/main/java/io/grpc/transport/okhttp/OkHttpClientTransport.java b/okhttp/src/main/java/io/grpc/transport/okhttp/OkHttpClientTransport.java
index 0e37a3884..04fd3612e 100644
--- a/okhttp/src/main/java/io/grpc/transport/okhttp/OkHttpClientTransport.java
+++ b/okhttp/src/main/java/io/grpc/transport/o... | ['okhttp/src/main/java/io/grpc/transport/okhttp/OkHttpClientTransport.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 732,947 | 153,475 | 20,388 | 123 | 798 | 156 | 24 | 1 | 573 | 92 | 122 | 4 | 0 | 0 | 1970-01-01T00:23:50 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,415 | grpc/grpc-java/667/583 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/583 | https://github.com/grpc/grpc-java/pull/667 | https://github.com/grpc/grpc-java/pull/667 | 1 | fixes | OkHttp's cancellation is not properly synchronized | [`OkHttpClientStream.sendCancel()` calls `finishStream()`](https://github.com/grpc/grpc-java/blob/master/okhttp/src/main/java/io/grpc/transport/okhttp/OkHttpClientStream.java#L213) from an application thread. But `finishStream()` [calls transportReportStatus() without any lock held](https://github.com/grpc/grpc-java/bl... | 1ac64bd09ddcec60829d5291c4db4147aeb2328a | 750f6265e21ffb83a0ee46d2120af92b30785b30 | https://github.com/grpc/grpc-java/compare/1ac64bd09ddcec60829d5291c4db4147aeb2328a...750f6265e21ffb83a0ee46d2120af92b30785b30 | diff --git a/okhttp/src/main/java/io/grpc/transport/okhttp/AsyncFrameWriter.java b/okhttp/src/main/java/io/grpc/transport/okhttp/AsyncFrameWriter.java
index bbc6e79ca..8615e489b 100644
--- a/okhttp/src/main/java/io/grpc/transport/okhttp/AsyncFrameWriter.java
+++ b/okhttp/src/main/java/io/grpc/transport/okhttp/AsyncFram... | ['okhttp/src/main/java/io/grpc/transport/okhttp/OutboundFlowController.java', 'okhttp/src/main/java/io/grpc/transport/okhttp/AsyncFrameWriter.java', 'okhttp/src/main/java/io/grpc/transport/okhttp/OkHttpClientStream.java', 'okhttp/src/main/java/io/grpc/transport/okhttp/OkHttpClientTransport.java', 'okhttp/src/test/java/... | {'.java': 5} | 5 | 5 | 0 | 0 | 5 | 1,687,079 | 354,616 | 48,934 | 211 | 12,204 | 2,434 | 285 | 4 | 1,069 | 98 | 247 | 4 | 3 | 0 | 1970-01-01T00:23:57 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,413 | grpc/grpc-java/787/786 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/786 | https://github.com/grpc/grpc-java/pull/787 | https://github.com/grpc/grpc-java/pull/787 | 1 | fixes | okhttp: pending stream is broken due to stream id check. | `OkHttpClientTransport.mayHaveCreatedStream()` checks the stream id less than the `nextStreamId`, but the `nextStreamId` is not increased yet when the pending stream is being started.
And `OkHttpClientTransport.mayHaveCreatedStream()` is wrong when the stream id greater than Integer.MAX_VALUE - 2.
| b42122b035da900d10f4b9e41017ef98ef62880a | ddea7435c9952e4ee8ecaf8f52bda6733a7bc824 | https://github.com/grpc/grpc-java/compare/b42122b035da900d10f4b9e41017ef98ef62880a...ddea7435c9952e4ee8ecaf8f52bda6733a7bc824 | diff --git a/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java b/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
index f121f6a30..8c8ef855b 100644
--- a/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
+++ b/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
@@ -272... | ['okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java', 'okhttp/src/main/java/io/grpc/okhttp/OutboundFlowController.java', 'okhttp/src/test/java/io/grpc/okhttp/OkHttpClientTransportTest.java'] | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 1,706,074 | 358,903 | 49,497 | 218 | 313 | 71 | 6 | 2 | 300 | 36 | 67 | 4 | 0 | 0 | 1970-01-01T00:23:59 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,412 | grpc/grpc-java/889/887 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/887 | https://github.com/grpc/grpc-java/pull/889 | https://github.com/grpc/grpc-java/pull/889 | 1 | fixes | OkHttp: race between sendCancel and sendFrame. | If sendCancel is called (by timeout for example) before the stream is started, a following sendFrame will cause a NPE:
```
java.lang.NullPointerException
at io.grpc.okhttp.OkHttpClientStream.sendFrame(OkHttpClientStream.java:197)
at io.grpc.internal.AbstractClientStream.internalSendFrame(AbstractClientStream.j... | 080190c753a484559b5aace35561626c73d5fe8b | a3f2f6249e5fd7d809b780f8e160796c469dc045 | https://github.com/grpc/grpc-java/compare/080190c753a484559b5aace35561626c73d5fe8b...a3f2f6249e5fd7d809b780f8e160796c469dc045 | diff --git a/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientStream.java b/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientStream.java
index ffa4b316b..9a299b595 100644
--- a/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientStream.java
+++ b/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientStream.java
@@ -190,11 +190,14 ... | ['okhttp/src/main/java/io/grpc/okhttp/OkHttpClientStream.java', 'okhttp/src/test/java/io/grpc/okhttp/OkHttpClientTransportTest.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,783,012 | 374,873 | 51,546 | 226 | 169 | 43 | 5 | 1 | 1,659 | 60 | 362 | 24 | 0 | 1 | 1970-01-01T00:24:00 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,411 | grpc/grpc-java/948/926 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/926 | https://github.com/grpc/grpc-java/pull/948 | https://github.com/grpc/grpc-java/pull/948 | 1 | resolves | NettyServer prematurely releases worker event loop | 777e928 causes flaky server shutdown, as the individual transports out-live the server.
| d42559c6afa666ed7d96a1c324fe09f0d0f8f7ed | 2a3ae36bd3730058d00564bca7e7502f84d099df | https://github.com/grpc/grpc-java/compare/d42559c6afa666ed7d96a1c324fe09f0d0f8f7ed...2a3ae36bd3730058d00564bca7e7502f84d099df | diff --git a/netty/src/main/java/io/grpc/netty/NettyServer.java b/netty/src/main/java/io/grpc/netty/NettyServer.java
index bd083e49e..f1ba4df27 100644
--- a/netty/src/main/java/io/grpc/netty/NettyServer.java
+++ b/netty/src/main/java/io/grpc/netty/NettyServer.java
@@ -48,6 +48,8 @@ import io.netty.channel.EventLoopGrou... | ['netty/src/main/java/io/grpc/netty/NettyServer.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,823,182 | 382,647 | 52,583 | 233 | 1,581 | 302 | 39 | 1 | 88 | 12 | 18 | 2 | 0 | 0 | 1970-01-01T00:24:01 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,410 | grpc/grpc-java/1018/1017 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/1017 | https://github.com/grpc/grpc-java/pull/1018 | https://github.com/grpc/grpc-java/pull/1018 | 1 | fixes | The run-test-server.sh exits immediately | After changing to using daemon threads by default, this script stopped working. We need to update the server to keep alive until cancelled (e.g. ctrl+c).
| abe5b8e5516042d8a5265f8502bfc10a13ac5639 | 49bb24c25f0225af92ab55086f3004d5838118da | https://github.com/grpc/grpc-java/compare/abe5b8e5516042d8a5265f8502bfc10a13ac5639...49bb24c25f0225af92ab55086f3004d5838118da | diff --git a/interop-testing/src/main/java/io/grpc/testing/integration/TestServiceServer.java b/interop-testing/src/main/java/io/grpc/testing/integration/TestServiceServer.java
index 07ebefec6..f994c2cd5 100644
--- a/interop-testing/src/main/java/io/grpc/testing/integration/TestServiceServer.java
+++ b/interop-testing/... | ['interop-testing/src/main/java/io/grpc/testing/integration/TestServiceServer.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,869,166 | 392,451 | 53,808 | 241 | 276 | 55 | 10 | 1 | 155 | 25 | 33 | 2 | 0 | 0 | 1970-01-01T00:24:02 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
1,409 | grpc/grpc-java/1023/999 | grpc | grpc-java | https://github.com/grpc/grpc-java/issues/999 | https://github.com/grpc/grpc-java/pull/1023 | https://github.com/grpc/grpc-java/pull/1023 | 1 | fixes | Possible race condition ServerImpl between start() and shutdown() | I believe it may be possible if start and stop are called concurrently that the shared executor may not get released. I'm not sure if this is an actual problem, but it does go against the @ ThreadSafe annotation.
| 45c75f2c96456cb7c1cd675c85a1c36ffdc51a9a | 4b27e542e08abe5bccd48ebdc5c4d242fd12f662 | https://github.com/grpc/grpc-java/compare/45c75f2c96456cb7c1cd675c85a1c36ffdc51a9a...4b27e542e08abe5bccd48ebdc5c4d242fd12f662 | diff --git a/core/src/main/java/io/grpc/internal/ServerImpl.java b/core/src/main/java/io/grpc/internal/ServerImpl.java
index 80523832f..e45a6cecb 100644
--- a/core/src/main/java/io/grpc/internal/ServerImpl.java
+++ b/core/src/main/java/io/grpc/internal/ServerImpl.java
@@ -31,6 +31,7 @@
package io.grpc.internal;
+i... | ['core/src/main/java/io/grpc/internal/ServerImpl.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,869,290 | 392,501 | 53,802 | 241 | 250 | 48 | 6 | 1 | 214 | 39 | 45 | 2 | 0 | 0 | 1970-01-01T00:24:02 | 10,705 | Java | {'Java': 11734252, 'Shell': 64137, 'C++': 50003, 'Starlark': 45373, 'Batchfile': 6230, 'Dockerfile': 3878, 'Python': 1961} | Apache License 2.0 |
36 | jhy/jsoup/292/290 | jhy | jsoup | https://github.com/jhy/jsoup/issues/290 | https://github.com/jhy/jsoup/pull/292 | https://github.com/jhy/jsoup/pull/292 | 1 | fixes | Element.clone() causes StackOverflowError when the element has excessively stacked children | This is similar to the issue I previously opened and was subsequently fixed in 1.7.2.
Excessively stacked elements contained in a parent element, such as a couple hundred `<i>` tags wrapped around some text, cause `Element.clone()` to throw a `StackOverflowError` in `Node.doClone()`
Consider this page: http://m.game... | 834d3142304e0927dc659791da6a4521f271d7fd | 586c85420990eab5e0f07c324fc26fcdae3af05c | https://github.com/jhy/jsoup/compare/834d3142304e0927dc659791da6a4521f271d7fd...586c85420990eab5e0f07c324fc26fcdae3af05c | diff --git a/src/main/java/org/jsoup/nodes/Node.java b/src/main/java/org/jsoup/nodes/Node.java
index f3411a75..41a13fbf 100644
--- a/src/main/java/org/jsoup/nodes/Node.java
+++ b/src/main/java/org/jsoup/nodes/Node.java
@@ -10,6 +10,7 @@ import java.net.MalformedURLException;
import java.net.URL;
import java.util.Arra... | ['src/main/java/org/jsoup/nodes/Node.java', 'src/test/java/org/jsoup/nodes/DocumentTest.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 489,133 | 100,159 | 14,028 | 53 | 1,028 | 206 | 27 | 1 | 2,932 | 123 | 1,398 | 16 | 1 | 1 | 1970-01-01T00:22:40 | 10,266 | Java | {'Java': 1474668, 'HTML': 316865} | MIT License |
1,437 | netflix/conductor/1973/1960 | netflix | conductor | https://github.com/Netflix/conductor/issues/1960 | https://github.com/Netflix/conductor/pull/1973 | https://github.com/Netflix/conductor/pull/1973 | 1 | fixes | Mismatched parameter naming for IsolationGroup | In IsolatedTaskQueueProducer
```
@VisibleForTesting
void addTaskQueues() {
Set<TaskDef> isolationTaskDefs = getIsolationExecutionNameSpaces();
logger.debug("Retrieved queues {}", isolationTaskDefs);
Set<String> taskTypes = SystemTaskWorkerCoordinator.taskNameWorkflowTaskMapping.keySet();
for (TaskDef... | 69d996d58657229712ecffaaca780831efda0a54 | 7a19487a7a0f778e116f29fe5a93170d26ba9a0c | https://github.com/netflix/conductor/compare/69d996d58657229712ecffaaca780831efda0a54...7a19487a7a0f778e116f29fe5a93170d26ba9a0c | diff --git a/core/src/main/java/com/netflix/conductor/core/execution/tasks/IsolatedTaskQueueProducer.java b/core/src/main/java/com/netflix/conductor/core/execution/tasks/IsolatedTaskQueueProducer.java
index ce4477c5c..46dab7916 100644
--- a/core/src/main/java/com/netflix/conductor/core/execution/tasks/IsolatedTaskQueue... | ['core/src/main/java/com/netflix/conductor/core/execution/tasks/IsolatedTaskQueueProducer.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 2,194,648 | 452,740 | 58,618 | 376 | 173 | 36 | 2 | 1 | 1,579 | 149 | 356 | 44 | 0 | 3 | 1970-01-01T00:26:45 | 9,943 | Java | {'Java': 3462518, 'Groovy': 850012, 'JavaScript': 390784, 'Go': 45821, 'Python': 27631, 'TypeScript': 8934, 'Dockerfile': 4469, 'SCSS': 4366, 'HTML': 2524, 'Shell': 2374, 'PLpgSQL': 1962, 'CSS': 1347, 'Makefile': 253} | Apache License 2.0 |
1,438 | netflix/conductor/943/856 | netflix | conductor | https://github.com/Netflix/conductor/issues/856 | https://github.com/Netflix/conductor/pull/943 | https://github.com/Netflix/conductor/pull/943 | 1 | fix | NullPointerException when starting up (using dynomite) | Using conductor version 2.1.0 (downloaded from https://bintray.com/netflixoss/maven/conductor/2.1.0)
Configuration is as follows (all IPs replaced with 1.2.3.4, they are unique in actual config)
I have validated the dynomite cluster is functioning properly using redis-cli
```
db=dynomite
workflow.dynomite.cl... | aa036d49bb225e4bdc4c951a6cd0cb71d0753123 | 6669e5265fb5c29a574d1e0f18941a2521f1f49c | https://github.com/netflix/conductor/compare/aa036d49bb225e4bdc4c951a6cd0cb71d0753123...6669e5265fb5c29a574d1e0f18941a2521f1f49c | diff --git a/redis-persistence/src/main/java/com/netflix/conductor/jedis/TokenMapSupplierProvider.java b/redis-persistence/src/main/java/com/netflix/conductor/jedis/TokenMapSupplierProvider.java
index 627fed072..92a7ef207 100644
--- a/redis-persistence/src/main/java/com/netflix/conductor/jedis/TokenMapSupplierProvider.... | ['redis-persistence/src/main/java/com/netflix/conductor/jedis/TokenMapSupplierProvider.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,457,915 | 304,798 | 41,258 | 265 | 1,973 | 395 | 44 | 1 | 5,181 | 172 | 1,241 | 82 | 2 | 2 | 1970-01-01T00:25:47 | 9,943 | Java | {'Java': 3462518, 'Groovy': 850012, 'JavaScript': 390784, 'Go': 45821, 'Python': 27631, 'TypeScript': 8934, 'Dockerfile': 4469, 'SCSS': 4366, 'HTML': 2524, 'Shell': 2374, 'PLpgSQL': 1962, 'CSS': 1347, 'Makefile': 253} | Apache License 2.0 |
1,436 | netflix/conductor/3495/3494 | netflix | conductor | https://github.com/Netflix/conductor/issues/3494 | https://github.com/Netflix/conductor/pull/3495 | https://github.com/Netflix/conductor/pull/3495 | 1 | fixes | Complete WAIT task inside for loop by TaskRef | See discussion https://github.com/Netflix/conductor/discussions/2873
Seems like it was partially fixed https://github.com/Netflix/conductor/pull/2883 for eventhandler actions, but did not get fixed for default WAIT task handlers.
| 719677de34ff323fc30578ad13436865e18ccbac | a72599fbd673408d62701fa376373f5154c7d948 | https://github.com/netflix/conductor/compare/719677de34ff323fc30578ad13436865e18ccbac...a72599fbd673408d62701fa376373f5154c7d948 | diff --git a/core/src/main/java/com/netflix/conductor/core/events/queue/DefaultEventQueueProcessor.java b/core/src/main/java/com/netflix/conductor/core/events/queue/DefaultEventQueueProcessor.java
index 78abf836b..f1c508803 100644
--- a/core/src/main/java/com/netflix/conductor/core/events/queue/DefaultEventQueueProcess... | ['core/src/main/java/com/netflix/conductor/core/events/queue/DefaultEventQueueProcessor.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 2,261,284 | 443,640 | 60,343 | 356 | 593 | 42 | 6 | 1 | 233 | 23 | 52 | 3 | 2 | 0 | 1970-01-01T00:27:56 | 9,943 | Java | {'Java': 3462518, 'Groovy': 850012, 'JavaScript': 390784, 'Go': 45821, 'Python': 27631, 'TypeScript': 8934, 'Dockerfile': 4469, 'SCSS': 4366, 'HTML': 2524, 'Shell': 2374, 'PLpgSQL': 1962, 'CSS': 1347, 'Makefile': 253} | Apache License 2.0 |
44 | tootallnate/java-websocket/570/564 | tootallnate | java-websocket | https://github.com/TooTallNate/Java-WebSocket/issues/564 | https://github.com/TooTallNate/Java-WebSocket/pull/570 | https://github.com/TooTallNate/Java-WebSocket/pull/570 | 2 | fix | Continuous binary getting swallowed? | My WS JS hosted in Chrome seems to be sending the following frames:
BINARY, isFin = false
CONTINUOUS, isFin = true
Java-WebSocket seems to drop the CONTINUOUS frame on the floor and the application never gets it:
```java
// org/java_websocket/drafts/Draft_6455.java:542
} else if( frame.isFin() ) {
if( curre... | f33422e9951369ffd948d473c026ef0e6da6b8e4 | 32c1ce01c9064d68c8adcfa3b1b577d30bed8cb2 | https://github.com/tootallnate/java-websocket/compare/f33422e9951369ffd948d473c026ef0e6da6b8e4...32c1ce01c9064d68c8adcfa3b1b577d30bed8cb2 | diff --git a/src/main/java/org/java_websocket/WebSocketImpl.java b/src/main/java/org/java_websocket/WebSocketImpl.java
index 74aca19..f794591 100644
--- a/src/main/java/org/java_websocket/WebSocketImpl.java
+++ b/src/main/java/org/java_websocket/WebSocketImpl.java
@@ -605,7 +605,7 @@ public class WebSocketImpl implemen... | ['src/main/java/org/java_websocket/WebSocketListener.java', 'src/main/java/org/java_websocket/WebSocketImpl.java', 'src/main/java/org/java_websocket/drafts/Draft_6455.java', 'src/main/java/org/java_websocket/server/WebSocketServer.java', 'src/test/java/org/java_websocket/example/AutobahnServerTest.java'] | {'.java': 5} | 5 | 5 | 0 | 0 | 5 | 404,340 | 97,292 | 11,329 | 64 | 6,409 | 1,398 | 104 | 4 | 1,252 | 157 | 291 | 25 | 0 | 1 | 1970-01-01T00:25:07 | 9,888 | Java | {'Java': 920046, 'HTML': 673666, 'Gherkin': 1433} | MIT License |
45 | tootallnate/java-websocket/470/465 | tootallnate | java-websocket | https://github.com/TooTallNate/Java-WebSocket/issues/465 | https://github.com/TooTallNate/Java-WebSocket/pull/470 | https://github.com/TooTallNate/Java-WebSocket/pull/470 | 1 | fix | Bad rsv 4 on android | Hello, our team using this library for connecting websocket server on Android platform,
sometimes, there are 'bad rsv 4' errors occurred. Seems same problem with #430.
```
04-27 14:26:09.960 I/System.out( 1564): D/WebsocketChannel: 000000 48 54 54 50 2f 31 2e 31 20 31 30 31 20 53 77 69 74 63 HTTP/1.1 101 Switc
... | b983c881b2dfb9f4c607f4b8b8201666e3491a12 | 2daee16dacbf1e0a9186f260310400a03c10803d | https://github.com/tootallnate/java-websocket/compare/b983c881b2dfb9f4c607f4b8b8201666e3491a12...2daee16dacbf1e0a9186f260310400a03c10803d | diff --git a/src/main/java/org/java_websocket/WebSocketImpl.java b/src/main/java/org/java_websocket/WebSocketImpl.java
index f3c3142..560651d 100644
--- a/src/main/java/org/java_websocket/WebSocketImpl.java
+++ b/src/main/java/org/java_websocket/WebSocketImpl.java
@@ -151,7 +151,9 @@ public class WebSocketImpl implemen... | ['src/main/java/org/java_websocket/WebSocketImpl.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 286,679 | 70,843 | 8,405 | 50 | 117 | 30 | 4 | 1 | 854 | 118 | 234 | 12 | 0 | 1 | 1970-01-01T00:24:53 | 9,888 | Java | {'Java': 920046, 'HTML': 673666, 'Gherkin': 1433} | MIT License |
47 | tootallnate/java-websocket/276/171 | tootallnate | java-websocket | https://github.com/TooTallNate/Java-WebSocket/issues/171 | https://github.com/TooTallNate/Java-WebSocket/pull/276 | https://github.com/TooTallNate/Java-WebSocket/pull/276 | 2 | fix | Endless loop in client upon close() when using wss | First, thanks so much for creating the library, it's really useful. I am using this via gottox/socket-io (client) and have run into this nasty problem of an endless loop in SSLSocketChannel2.java when closing a connection (maybe after the other side closed first). A couple of these failures is all it takes to pin the C... | 05d2e2ed045d955947d944d7111ce3e6758843b6 | ea7e061369477bfdf5a0c32bad920c91f8af61fb | https://github.com/tootallnate/java-websocket/compare/05d2e2ed045d955947d944d7111ce3e6758843b6...ea7e061369477bfdf5a0c32bad920c91f8af61fb | diff --git a/src/main/java/org/java_websocket/SSLSocketChannel2.java b/src/main/java/org/java_websocket/SSLSocketChannel2.java
index ba8d8f8..e540612 100644
--- a/src/main/java/org/java_websocket/SSLSocketChannel2.java
+++ b/src/main/java/org/java_websocket/SSLSocketChannel2.java
@@ -5,6 +5,13 @@
*/
package org.java... | ['src/main/java/org/java_websocket/SSLSocketChannel2.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 262,194 | 64,649 | 7,706 | 50 | 793 | 181 | 20 | 1 | 856 | 126 | 198 | 18 | 0 | 1 | 1970-01-01T00:23:30 | 9,888 | Java | {'Java': 920046, 'HTML': 673666, 'Gherkin': 1433} | MIT License |
37 | tootallnate/java-websocket/567/390 | tootallnate | java-websocket | https://github.com/TooTallNate/Java-WebSocket/issues/390 | https://github.com/TooTallNate/Java-WebSocket/pull/567 | https://github.com/TooTallNate/Java-WebSocket/issues/390#issuecomment-335473419 | 1 | fixes | Websocket server returning 401; can't handle on client side | I have a websocket server that returns 401 on the http handshake
I can't figure out how to get that information on the websocket client
Two things I can't figure out:
1. Where can I get the http status code returned form the server (401 in this case)
onClose is called but with irrelevant code (-1) which I saw in yo... | 37b4610cd6c5b5f717b8c4ca196947019a0ed8b1 | f1eeff4c3b677a503d04d260475b9725445a82d6 | https://github.com/tootallnate/java-websocket/compare/37b4610cd6c5b5f717b8c4ca196947019a0ed8b1...f1eeff4c3b677a503d04d260475b9725445a82d6 | diff --git a/src/main/java/org/java_websocket/WebSocketImpl.java b/src/main/java/org/java_websocket/WebSocketImpl.java
index 74aca19..7cc3330 100644
--- a/src/main/java/org/java_websocket/WebSocketImpl.java
+++ b/src/main/java/org/java_websocket/WebSocketImpl.java
@@ -447,11 +447,11 @@ public class WebSocketImpl implem... | ['src/main/java/org/java_websocket/WebSocketImpl.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 407,737 | 98,043 | 11,419 | 65 | 265 | 68 | 4 | 1 | 1,212 | 226 | 269 | 15 | 0 | 0 | 1970-01-01T00:25:07 | 9,888 | Java | {'Java': 920046, 'HTML': 673666, 'Gherkin': 1433} | MIT License |
38 | tootallnate/java-websocket/1232/1230 | tootallnate | java-websocket | https://github.com/TooTallNate/Java-WebSocket/issues/1230 | https://github.com/TooTallNate/Java-WebSocket/pull/1232 | https://github.com/TooTallNate/Java-WebSocket/pull/1232 | 1 | fixes | CONTINUOUS should be decoded depending on the first frame | **Describe the bug**
Due to changes with #1165 a return was introduced to handle not decode messages where no RSV1 is set.
This is however the case for a frame with opcode CONTINUOUS.
It is a valid framing and should therefore work
**To Reproduce**
Steps to reproduce the behavior:
1. Run autobahn testsuite
... | 2c9b09127fbbc6d73438097a961a1337dd0d8a65 | 8f1f8e4462b8939f4f1706681d934658c6794bc4 | https://github.com/tootallnate/java-websocket/compare/2c9b09127fbbc6d73438097a961a1337dd0d8a65...8f1f8e4462b8939f4f1706681d934658c6794bc4 | diff --git a/src/main/java/org/java_websocket/drafts/Draft_6455.java b/src/main/java/org/java_websocket/drafts/Draft_6455.java
index 68feb61..eb48799 100644
--- a/src/main/java/org/java_websocket/drafts/Draft_6455.java
+++ b/src/main/java/org/java_websocket/drafts/Draft_6455.java
@@ -115,13 +115,23 @@ public class Draf... | ['src/main/java/org/java_websocket/drafts/Draft_6455.java', 'src/main/java/org/java_websocket/extensions/permessage_deflate/PerMessageDeflateExtension.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 486,793 | 115,202 | 14,097 | 97 | 2,802 | 587 | 64 | 2 | 371 | 58 | 83 | 13 | 0 | 0 | 1970-01-01T00:27:28 | 9,888 | Java | {'Java': 920046, 'HTML': 673666, 'Gherkin': 1433} | MIT License |
39 | tootallnate/java-websocket/1133/1132 | tootallnate | java-websocket | https://github.com/TooTallNate/Java-WebSocket/issues/1132 | https://github.com/TooTallNate/Java-WebSocket/pull/1133 | https://github.com/TooTallNate/Java-WebSocket/pull/1133 | 2 | fixes | Draft_6455 flagged by Veracode CWE-331 replace Random with SecureRandom | Our veracode scan flagged usage of `Random` in Draft_6455.java as a vulnerability.
https://cwe.mitre.org/data/definitions/331.html
According to Websocket Protocol:
For example, each masking could be drawn from a cryptographically strong random number generator. If the same key is used or a decipherable pattern... | 32d5656ffd0aa4ba6caba830ac0205c7bf2609e3 | feec867c81d1a426815717b489147894a19826e5 | https://github.com/tootallnate/java-websocket/compare/32d5656ffd0aa4ba6caba830ac0205c7bf2609e3...feec867c81d1a426815717b489147894a19826e5 | diff --git a/src/main/java/org/java_websocket/drafts/Draft_6455.java b/src/main/java/org/java_websocket/drafts/Draft_6455.java
index 06c964d..68feb61 100644
--- a/src/main/java/org/java_websocket/drafts/Draft_6455.java
+++ b/src/main/java/org/java_websocket/drafts/Draft_6455.java
@@ -29,6 +29,7 @@ import java.math.BigI... | ['src/main/java/org/java_websocket/drafts/Draft_6455.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 484,669 | 114,730 | 14,035 | 97 | 185 | 36 | 4 | 1 | 1,029 | 155 | 217 | 20 | 1 | 0 | 1970-01-01T00:26:56 | 9,888 | Java | {'Java': 920046, 'HTML': 673666, 'Gherkin': 1433} | MIT License |
40 | tootallnate/java-websocket/1014/1011 | tootallnate | java-websocket | https://github.com/TooTallNate/Java-WebSocket/issues/1011 | https://github.com/TooTallNate/Java-WebSocket/pull/1014 | https://github.com/TooTallNate/Java-WebSocket/pull/1014 | 1 | fixes | Crash on Android due to missing method `setEndpointIdentificationAlgorithm` on 1.5.0. | Websocket library 1.5.0
The same code was not crashing on 1.4.1
This is the entire stack trace. I got it through Crashlytics so I cannot describe steps that led to it.
```
Fatal Exception: java.lang.NoSuchMethodError: No virtual method setEndpointIdentificationAlgorithm(Ljava/lang/String;)V in class Ljavax/net/... | c207fb8a7c28e7c49bf42e8da7e7866e7db60043 | 877ad764e5d01166d754e611a4139e816cc04d0d | https://github.com/tootallnate/java-websocket/compare/c207fb8a7c28e7c49bf42e8da7e7866e7db60043...877ad764e5d01166d754e611a4139e816cc04d0d | diff --git a/src/main/java/org/java_websocket/client/WebSocketClient.java b/src/main/java/org/java_websocket/client/WebSocketClient.java
index 0bbcfe5..4d735de 100644
--- a/src/main/java/org/java_websocket/client/WebSocketClient.java
+++ b/src/main/java/org/java_websocket/client/WebSocketClient.java
@@ -472,8 +472,6 @@... | ['src/test/java/org/java_websocket/issues/Issue997Test.java', 'src/main/java/org/java_websocket/client/WebSocketClient.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 469,383 | 112,447 | 13,300 | 96 | 529 | 110 | 6 | 1 | 648 | 66 | 164 | 15 | 0 | 1 | 1970-01-01T00:26:29 | 9,888 | Java | {'Java': 920046, 'HTML': 673666, 'Gherkin': 1433} | MIT License |
41 | tootallnate/java-websocket/901/905 | tootallnate | java-websocket | https://github.com/TooTallNate/Java-WebSocket/issues/905 | https://github.com/TooTallNate/Java-WebSocket/pull/901 | https://github.com/TooTallNate/Java-WebSocket/pull/901 | 1 | fixes | IOException wrapped in InternalError not handled properly | **Describe the bug**
The call to `socket.connect(...)` at `WebSocketClient:436` can throw a `java.lang.InternalError` that is currently not handled in the enclosing try/catch as it extends `java.lang.Error` and not `java.lang.Exception`
This `InternalError` wraps a `java.lang.IOException` that contains useful infor... | c9e75337940cd041e935191e3dbec0005a622c64 | f73cca0f3faf1bc5d72ba44d0ee42a1b6dabe28e | https://github.com/tootallnate/java-websocket/compare/c9e75337940cd041e935191e3dbec0005a622c64...f73cca0f3faf1bc5d72ba44d0ee42a1b6dabe28e | diff --git a/src/main/java/org/java_websocket/client/WebSocketClient.java b/src/main/java/org/java_websocket/client/WebSocketClient.java
index f5cd9b1..7a93a0a 100644
--- a/src/main/java/org/java_websocket/client/WebSocketClient.java
+++ b/src/main/java/org/java_websocket/client/WebSocketClient.java
@@ -28,6 +28,7 @@ p... | ['src/main/java/org/java_websocket/client/WebSocketClient.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 443,103 | 106,639 | 12,595 | 90 | 461 | 106 | 10 | 1 | 2,649 | 216 | 598 | 53 | 0 | 1 | 1970-01-01T00:26:00 | 9,888 | Java | {'Java': 920046, 'HTML': 673666, 'Gherkin': 1433} | MIT License |
42 | tootallnate/java-websocket/683/685 | tootallnate | java-websocket | https://github.com/TooTallNate/Java-WebSocket/issues/685 | https://github.com/TooTallNate/Java-WebSocket/pull/683 | https://github.com/TooTallNate/Java-WebSocket/pull/683 | 1 | fixes | Exclude default port from wss host | <!--- Provide a general summary of the issue in the Title above -->
I'm working with a server balanced by a proxy that redirect my request to the targeted server depends on the URL I requested.
One of these servers has a secure Websocket (I mean wss) and it works on the default port (443).
In your client (class ... | c08be4e43f2414d34ecd5b2fa9985f9e4ff48263 | 8a9df49a0e9fb7bedc0a08e10bed0862a28b9440 | https://github.com/tootallnate/java-websocket/compare/c08be4e43f2414d34ecd5b2fa9985f9e4ff48263...8a9df49a0e9fb7bedc0a08e10bed0862a28b9440 | diff --git a/src/main/java/org/java_websocket/client/WebSocketClient.java b/src/main/java/org/java_websocket/client/WebSocketClient.java
index da30d5b..00e40fd 100644
--- a/src/main/java/org/java_websocket/client/WebSocketClient.java
+++ b/src/main/java/org/java_websocket/client/WebSocketClient.java
@@ -434,7 +434,10 @... | ['src/main/java/org/java_websocket/client/WebSocketClient.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 432,537 | 104,289 | 12,202 | 80 | 227 | 59 | 5 | 1 | 1,002 | 171 | 237 | 14 | 0 | 1 | 1970-01-01T00:25:21 | 9,888 | Java | {'Java': 920046, 'HTML': 673666, 'Gherkin': 1433} | MIT License |
46 | tootallnate/java-websocket/329/259 | tootallnate | java-websocket | https://github.com/TooTallNate/Java-WebSocket/issues/259 | https://github.com/TooTallNate/Java-WebSocket/pull/329 | https://github.com/TooTallNate/Java-WebSocket/pull/329 | 2 | fixes | WebSocketServer freezes in stop() method | Hello,
first I would like to thank you for creating a great and useful library.
I'am using it in Android application to communicate with website.
When I try to stop the server, the application sometimes stops responding.
The main thread is indefinitely waiting in "WebSocketServer.stop()" method in "selectorThread.jo... | ac45d846806ad662de48c206896d1248acbb53ff | e4c248a69f0cb36f87e5b3d3100bd2b46e027289 | https://github.com/tootallnate/java-websocket/compare/ac45d846806ad662de48c206896d1248acbb53ff...e4c248a69f0cb36f87e5b3d3100bd2b46e027289 | diff --git a/src/main/java/org/java_websocket/server/WebSocketServer.java b/src/main/java/org/java_websocket/server/WebSocketServer.java
index 5fc6a39..12cea2f 100644
--- a/src/main/java/org/java_websocket/server/WebSocketServer.java
+++ b/src/main/java/org/java_websocket/server/WebSocketServer.java
@@ -216,16 +216,10 ... | ['src/main/java/org/java_websocket/server/WebSocketServer.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 262,584 | 64,741 | 7,715 | 50 | 636 | 147 | 14 | 1 | 595 | 90 | 124 | 15 | 0 | 0 | 1970-01-01T00:23:58 | 9,888 | Java | {'Java': 920046, 'HTML': 673666, 'Gherkin': 1433} | MIT License |
544 | square/moshi/500/277 | square | moshi | https://github.com/square/moshi/issues/277 | https://github.com/square/moshi/pull/500 | https://github.com/square/moshi/pull/500 | 1 | closes | Error where map key doesn’t encode as a string is incoherent | When a map key doesn’t have a natural string encoding we crash with a difficult exception. [For example](https://bitbucket.org/robeden/moshi-test), when writing a `Map<Matcher,String> identifiers` we crash like so:
```
Exception in thread "main" java.lang.IllegalStateException: Nesting problem.
at com.squa... | 1c68437f3c62a0092fab16afab84c19f5127a35c | 44e6fbd067404dc8b56fe75648aaf0f3d812670d | https://github.com/square/moshi/compare/1c68437f3c62a0092fab16afab84c19f5127a35c...44e6fbd067404dc8b56fe75648aaf0f3d812670d | diff --git a/moshi/src/main/java/com/squareup/moshi/JsonUtf8Writer.java b/moshi/src/main/java/com/squareup/moshi/JsonUtf8Writer.java
index 4fa074d..5cedfe1 100644
--- a/moshi/src/main/java/com/squareup/moshi/JsonUtf8Writer.java
+++ b/moshi/src/main/java/com/squareup/moshi/JsonUtf8Writer.java
@@ -77,6 +77,10 @@ final cl... | ['moshi/src/test/java/com/squareup/moshi/PromoteNameToValueTest.java', 'moshi/src/test/java/com/squareup/moshi/MapJsonAdapterTest.java', 'moshi/src/main/java/com/squareup/moshi/JsonUtf8Writer.java', 'moshi/src/main/java/com/squareup/moshi/JsonValueWriter.java'] | {'.java': 4} | 4 | 4 | 0 | 0 | 4 | 291,888 | 67,004 | 8,571 | 53 | 1,408 | 315 | 36 | 2 | 1,199 | 107 | 286 | 28 | 1 | 2 | 1970-01-01T00:25:23 | 9,081 | Kotlin | {'Kotlin': 638860, 'Java': 422224, 'Shell': 785} | Apache License 2.0 |
545 | square/moshi/493/128 | square | moshi | https://github.com/square/moshi/issues/128 | https://github.com/square/moshi/pull/493 | https://github.com/square/moshi/pull/493 | 1 | closes | Android: failing to find adapter for a 'GenericArrayTypeImpl' type | We have an adapter in place to process `byte[]` as a base64 / base32 string. Everything works fine when a class has a `byte[]` field, but parsing json fails on Android when we have a field of type `Map<String, byte[]>`. The code below works in the standard JVM but fails on Android.
``` java
class Base32Adapter exten... | 2cc878da8158741c31492240c172c36eb4824bb9 | fa1f10dc77b764022acdb6a1bcc54049a3f7214f | https://github.com/square/moshi/compare/2cc878da8158741c31492240c172c36eb4824bb9...fa1f10dc77b764022acdb6a1bcc54049a3f7214f | diff --git a/moshi/src/main/java/com/squareup/moshi/internal/Util.java b/moshi/src/main/java/com/squareup/moshi/internal/Util.java
index 0744728..e16980a 100644
--- a/moshi/src/main/java/com/squareup/moshi/internal/Util.java
+++ b/moshi/src/main/java/com/squareup/moshi/internal/Util.java
@@ -45,7 +45,7 @@ public final ... | ['moshi/src/main/java/com/squareup/moshi/internal/Util.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 287,403 | 65,997 | 8,453 | 52 | 84 | 14 | 2 | 1 | 2,527 | 194 | 634 | 51 | 0 | 2 | 1970-01-01T00:25:23 | 9,081 | Kotlin | {'Kotlin': 638860, 'Java': 422224, 'Shell': 785} | Apache License 2.0 |
546 | square/moshi/80/79 | square | moshi | https://github.com/square/moshi/issues/79 | https://github.com/square/moshi/pull/80 | https://github.com/square/moshi/pull/80 | 1 | fixes | Parsing fails on NULL field values | This JSON
{
"id":"2",
"name":"glpi",
"firstname":null
}
fails: Expected a value but was NULL at path $.firstname
class ObjectJsonAdapter in file StandardJsonAdapters.java
has switch (reader.peek()) {}
there are BEGIN_ARRAY, BEGIN_OBJECT, STRING, NUMBER, BOOLEAN
and noooooo NULL value among... | 2a05fe4d692d4daf6621ffa6a5721c33b6d81619 | 80953219bda3eeac4da5a7ee7ac6ad9497ea8e38 | https://github.com/square/moshi/compare/2a05fe4d692d4daf6621ffa6a5721c33b6d81619...80953219bda3eeac4da5a7ee7ac6ad9497ea8e38 | diff --git a/moshi/src/main/java/com/squareup/moshi/StandardJsonAdapters.java b/moshi/src/main/java/com/squareup/moshi/StandardJsonAdapters.java
index 9283680..7e9c763 100644
--- a/moshi/src/main/java/com/squareup/moshi/StandardJsonAdapters.java
+++ b/moshi/src/main/java/com/squareup/moshi/StandardJsonAdapters.java
@@ ... | ['moshi/src/main/java/com/squareup/moshi/StandardJsonAdapters.java', 'moshi/src/test/java/com/squareup/moshi/ObjectAdapterTest.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 183,633 | 42,772 | 5,462 | 27 | 58 | 10 | 3 | 1 | 332 | 40 | 85 | 14 | 0 | 0 | 1970-01-01T00:24:02 | 9,081 | Kotlin | {'Kotlin': 638860, 'Java': 422224, 'Shell': 785} | Apache License 2.0 |
3,549 | square/okio/124/105 | square | okio | https://github.com/square/okio/issues/105 | https://github.com/square/okio/pull/124 | https://github.com/square/okio/pull/124 | 1 | closes | BufferedSink.write(Source, long) hides bugs | It calls `source.read(buffer, byteCount)` which might not read `byteCount` bytes and also might return -1 (which is ignored).
Our API should make it hard to write buggy code, and this one tripped me up forcing use of the inverse API which correctly reported read count.
| 9f2c6e38cd0ffc25d1df7337d71bafcd63504f3c | 828384545b72ddc005d35b33c2ebd674548c77df | https://github.com/square/okio/compare/9f2c6e38cd0ffc25d1df7337d71bafcd63504f3c...828384545b72ddc005d35b33c2ebd674548c77df | diff --git a/okio/src/main/java/okio/Buffer.java b/okio/src/main/java/okio/Buffer.java
index 92097b9e..44cfbf29 100644
--- a/okio/src/main/java/okio/Buffer.java
+++ b/okio/src/main/java/okio/Buffer.java
@@ -826,8 +826,10 @@ public final class Buffer implements BufferedSource, BufferedSink, Cloneable {
}
@Overri... | ['okio/src/main/java/okio/RealBufferedSink.java', 'okio/src/main/java/okio/Buffer.java', 'okio/src/test/java/okio/BufferedSinkTest.java'] | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 157,834 | 38,438 | 4,856 | 23 | 495 | 127 | 14 | 2 | 271 | 45 | 60 | 4 | 0 | 0 | 1970-01-01T00:23:45 | 8,448 | Kotlin | {'Kotlin': 1473930, 'Java': 43685, 'Shell': 1180} | Apache License 2.0 |
3,548 | square/okio/130/129 | square | okio | https://github.com/square/okio/issues/129 | https://github.com/square/okio/pull/130 | https://github.com/square/okio/pull/130 | 1 | closes | DeflaterSink, InflaterSource may leave behind an empty tail | Both of these allocate a segment if necessary, but may end up not writing to that segment. We should write tests that exercise this situation and make sure we don't have a 0-byte segment still in a Buffer.
| d07412cc7cb917f852442d3d8ea056e374bad402 | 2526e7650dd965122e2a4a76d0f3c757d8e70353 | https://github.com/square/okio/compare/d07412cc7cb917f852442d3d8ea056e374bad402...2526e7650dd965122e2a4a76d0f3c757d8e70353 | diff --git a/okio/src/main/java/okio/DeflaterSink.java b/okio/src/main/java/okio/DeflaterSink.java
index 3b23655c..a5bca15d 100644
--- a/okio/src/main/java/okio/DeflaterSink.java
+++ b/okio/src/main/java/okio/DeflaterSink.java
@@ -99,7 +99,12 @@ public final class DeflaterSink implements Sink {
buffer.size += ... | ['okio/src/main/java/okio/InflaterSource.java', 'okio/src/test/java/okio/InflaterSourceTest.java', 'okio/src/main/java/okio/DeflaterSink.java', 'okio/src/main/java/okio/Okio.java', 'okio/src/test/java/okio/DeflaterSinkTest.java'] | {'.java': 5} | 5 | 5 | 0 | 0 | 5 | 169,474 | 41,356 | 5,167 | 24 | 598 | 138 | 14 | 3 | 206 | 38 | 44 | 2 | 0 | 0 | 1970-01-01T00:23:46 | 8,448 | Kotlin | {'Kotlin': 1473930, 'Java': 43685, 'Shell': 1180} | Apache License 2.0 |
70 | dropwizard/dropwizard/2271/2268 | dropwizard | dropwizard | https://github.com/dropwizard/dropwizard/issues/2268 | https://github.com/dropwizard/dropwizard/pull/2271 | https://github.com/dropwizard/dropwizard/pull/2271 | 1 | resolves | ProxyServlet does not set Content-Length correctly for gzipped content | I have a Dropwizard application that uses a Jetty ProxyServlet to forward HTTP traffic. This works great when the HTTP traffic is not gzipped. When the HTTP traffic is gzipped, the proxy forwards a bad HTTP request.
The problem appears to be that when Dropwizard receives a gzipped HTTP request, the BiDiGzipHandler p... | b8f6c8f576ddfe1b4b62377da7beb3ec8be31f6c | 6d86f8afde0a0a2480a1d7744960dd2f26103c74 | https://github.com/dropwizard/dropwizard/compare/b8f6c8f576ddfe1b4b62377da7beb3ec8be31f6c...6d86f8afde0a0a2480a1d7744960dd2f26103c74 | diff --git a/dropwizard-jetty/src/main/java/io/dropwizard/jetty/BiDiGzipHandler.java b/dropwizard-jetty/src/main/java/io/dropwizard/jetty/BiDiGzipHandler.java
index 375f42539..cdcca89c1 100644
--- a/dropwizard-jetty/src/main/java/io/dropwizard/jetty/BiDiGzipHandler.java
+++ b/dropwizard-jetty/src/main/java/io/dropwizar... | ['dropwizard-jetty/src/test/java/io/dropwizard/jetty/BiDiGzipHandlerTest.java', 'dropwizard-jetty/src/main/java/io/dropwizard/jetty/BiDiGzipHandler.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,112,021 | 221,697 | 33,050 | 447 | 2,599 | 438 | 43 | 1 | 3,185 | 298 | 862 | 94 | 3 | 7 | 1970-01-01T00:25:18 | 8,421 | Java | {'Java': 2800516, 'Shell': 6214, 'FreeMarker': 992, 'Mustache': 569, 'HTML': 111} | Apache License 2.0 |
68 | dropwizard/dropwizard/5037/4943 | dropwizard | dropwizard | https://github.com/dropwizard/dropwizard/issues/4943 | https://github.com/dropwizard/dropwizard/pull/5037 | https://github.com/dropwizard/dropwizard/pull/5037 | 1 | closes | fix dropwizard-health log message | HealthCheckScheduler log message doesn't log the _value_ of the Counter object, but logs the object instead.
> DEBUG [2022-03-09 20:47:59,008] io.dropwizard.health.HealthCheckScheduler [thread=health-check-example-app-1]: Scheduled check: check=ScheduledHealthCheck{name='example-app-db', critical=true, healthCheck... | d0a2fa78d630abca82f3c202700045a215cdec26 | 8100f17382a836f111d70bf6c5ba285f8989e755 | https://github.com/dropwizard/dropwizard/compare/d0a2fa78d630abca82f3c202700045a215cdec26...8100f17382a836f111d70bf6c5ba285f8989e755 | diff --git a/dropwizard-health/src/main/java/io/dropwizard/health/ScheduledHealthCheck.java b/dropwizard-health/src/main/java/io/dropwizard/health/ScheduledHealthCheck.java
index 349c6001d..ecec175c2 100644
--- a/dropwizard-health/src/main/java/io/dropwizard/health/ScheduledHealthCheck.java
+++ b/dropwizard-health/src/... | ['dropwizard-health/src/main/java/io/dropwizard/health/ScheduledHealthCheck.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,282,196 | 258,084 | 38,033 | 472 | 520 | 94 | 8 | 1 | 740 | 39 | 200 | 6 | 0 | 0 | 1970-01-01T00:27:28 | 8,421 | Java | {'Java': 2800516, 'Shell': 6214, 'FreeMarker': 992, 'Mustache': 569, 'HTML': 111} | Apache License 2.0 |
69 | dropwizard/dropwizard/2643/2523 | dropwizard | dropwizard | https://github.com/dropwizard/dropwizard/issues/2523 | https://github.com/dropwizard/dropwizard/pull/2643 | https://github.com/dropwizard/dropwizard/pull/2643 | 1 | closes | DropwizardTestSupport should clean system properties (config overrides) on service startup failure | We had a few test classes using both `DropwizardAppRule` and `DropwizardClientRule` (`DropwizardClientRule` around `DropwizardAppRule`). The service started by the `DropwizardAppRule` would fail on startup because of some environment problem. The _config override_ properties would stick around for the following tests c... | 1a34237e2e5119eced9c50f396fcd46644380a27 | 24650677e14264ae819c17e1f7a917684ce29446 | https://github.com/dropwizard/dropwizard/compare/1a34237e2e5119eced9c50f396fcd46644380a27...24650677e14264ae819c17e1f7a917684ce29446 | diff --git a/dropwizard-e2e/src/test/java/com/example/badlog/BadLogTest.java b/dropwizard-e2e/src/test/java/com/example/badlog/BadLogTest.java
index 03dd9abf9..147ce4337 100644
--- a/dropwizard-e2e/src/test/java/com/example/badlog/BadLogTest.java
+++ b/dropwizard-e2e/src/test/java/com/example/badlog/BadLogTest.java
@@ ... | ['dropwizard-testing/src/main/java/io/dropwizard/testing/DropwizardTestSupport.java', 'dropwizard-e2e/src/test/java/com/example/badlog/BadLogTest.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 1,180,292 | 236,711 | 35,173 | 471 | 369 | 69 | 11 | 1 | 2,814 | 236 | 498 | 71 | 0 | 1 | 1970-01-01T00:25:49 | 8,421 | Java | {'Java': 2800516, 'Shell': 6214, 'FreeMarker': 992, 'Mustache': 569, 'HTML': 111} | Apache License 2.0 |
8,247 | trinodb/trino/17804/17803 | trinodb | trino | https://github.com/trinodb/trino/issues/17803 | https://github.com/trinodb/trino/pull/17804 | https://github.com/trinodb/trino/pull/17804 | 1 | fixes | Correctness issue with double slash location on Glue & S3 in Hive connector | The file is generated correctly under the table location, but it returns an empty result. Delta and Iceberg connectors are fine as far as I confirmed.
```sql
create table test_slash (c1 int) with (external_location = 's3://bucket/foo//bar');
insert into test_slash values (1);
table test_slash;
c1
----
(0 rows)... | eaf893a74737d877aeb4e6cd267a8018203a632d | 8cb4bd1b5e81541b96c5faeb725126a698789144 | https://github.com/trinodb/trino/compare/eaf893a74737d877aeb4e6cd267a8018203a632d...8cb4bd1b5e81541b96c5faeb725126a698789144 | diff --git a/plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/metastore/glue/TestDeltaLakeConcurrentModificationGlueMetastore.java b/plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/metastore/glue/TestDeltaLakeConcurrentModificationGlueMetastore.java
index f4aaad4880..de99991545 100644
---... | ['plugin/trino-hive/src/test/java/io/trino/plugin/hive/metastore/TestSemiTransactionalHiveMetastore.java', 'plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java', 'plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHiveLocal.java', 'plugin/trino-delta-lake/src/test/java/io/trino/plugin/d... | {'.java': 17} | 17 | 17 | 0 | 0 | 17 | 38,138,403 | 7,631,131 | 995,195 | 6,473 | 17,841 | 3,222 | 218 | 9 | 325 | 48 | 82 | 9 | 0 | 1 | 1970-01-01T00:28:06 | 8,254 | Java | {'Java': 71658946, 'JavaScript': 233768, 'ANTLR': 56491, 'Shell': 49457, 'HTML': 30842, 'CSS': 13515, 'Scala': 10145, 'Python': 7379, 'Smarty': 1938, 'Dockerfile': 1723, 'Groovy': 1702, 'PLSQL': 85} | Apache License 2.0 |
8,249 | trinodb/trino/6186/6170 | trinodb | trino | https://github.com/trinodb/trino/issues/6170 | https://github.com/trinodb/trino/pull/6186 | https://github.com/trinodb/trino/pull/6186 | 1 | fixes | Iceberg catalog: connecting to Google Cloud Storage produced error | The [documentation](https://prestosql.io/docs/current/connector/iceberg.html) says that **Iceberg supports the same metastore configuration properties as the Hive connector.** However, when I provide the catalog `iceberg.properties` with
`connector.name=iceberg`
`hive.metastore.uri=thrift://hive-metastore:9083`
`h... | ad4f8d542c7195fd8da91300a9d48f36e45632a3 | 7c6a9437ac9070e4ff0ccb0f1c94544c4a4c68cb | https://github.com/trinodb/trino/compare/ad4f8d542c7195fd8da91300a9d48f36e45632a3...7c6a9437ac9070e4ff0ccb0f1c94544c4a4c68cb | diff --git a/presto-iceberg/src/main/java/io/prestosql/plugin/iceberg/InternalIcebergConnectorFactory.java b/presto-iceberg/src/main/java/io/prestosql/plugin/iceberg/InternalIcebergConnectorFactory.java
index 8e01a261a6..2b2187d918 100644
--- a/presto-iceberg/src/main/java/io/prestosql/plugin/iceberg/InternalIcebergCon... | ['presto-iceberg/src/main/java/io/prestosql/plugin/iceberg/InternalIcebergConnectorFactory.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 26,082,340 | 5,240,335 | 697,768 | 4,758 | 193 | 45 | 4 | 1 | 2,365 | 128 | 558 | 43 | 1 | 1 | 1970-01-01T00:26:46 | 8,254 | Java | {'Java': 71658946, 'JavaScript': 233768, 'ANTLR': 56491, 'Shell': 49457, 'HTML': 30842, 'CSS': 13515, 'Scala': 10145, 'Python': 7379, 'Smarty': 1938, 'Dockerfile': 1723, 'Groovy': 1702, 'PLSQL': 85} | Apache License 2.0 |
8,248 | trinodb/trino/7212/7208 | trinodb | trino | https://github.com/trinodb/trino/issues/7208 | https://github.com/trinodb/trino/pull/7212 | https://github.com/trinodb/trino/pull/7212 | 1 | fixes | Unnecessary wrapping of TrinoException due to LazyConnection usage in CachingJdbcClient | https://github.com/trinodb/trino/pull/7069 introduced `LazyConnection` that opens a connection on first usage, not when it's acquired in the code path.
This changed how exceptions are handled in the `CachingJdbcClient`. Prior to that change when executing i.e. `show tables from mysql.default;` client would get:
`... | 6395ff0ae44b86a27af7eac31c1397a20a32aa26 | 8ffe51d219c978abb83b034405234d36775695a8 | https://github.com/trinodb/trino/compare/6395ff0ae44b86a27af7eac31c1397a20a32aa26...8ffe51d219c978abb83b034405234d36775695a8 | diff --git a/plugin/trino-mysql/src/main/java/io/trino/plugin/mysql/MySqlClient.java b/plugin/trino-mysql/src/main/java/io/trino/plugin/mysql/MySqlClient.java
index 99a6bbd54f..16f8f41f9b 100644
--- a/plugin/trino-mysql/src/main/java/io/trino/plugin/mysql/MySqlClient.java
+++ b/plugin/trino-mysql/src/main/java/io/trino... | ['plugin/trino-mysql/src/main/java/io/trino/plugin/mysql/MySqlClient.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 27,058,170 | 5,384,152 | 727,585 | 4,924 | 97 | 18 | 2 | 1 | 862 | 94 | 201 | 14 | 1 | 2 | 1970-01-01T00:26:55 | 8,254 | Java | {'Java': 71658946, 'JavaScript': 233768, 'ANTLR': 56491, 'Shell': 49457, 'HTML': 30842, 'CSS': 13515, 'Scala': 10145, 'Python': 7379, 'Smarty': 1938, 'Dockerfile': 1723, 'Groovy': 1702, 'PLSQL': 85} | Apache License 2.0 |
9,503 | thundernest/k-9/6591/6581 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/6581 | https://github.com/thundernest/k-9/pull/6591 | https://github.com/thundernest/k-9/pull/6591 | 1 | fixes | Opening message and hitting archive doesn't mark the email as read. | ### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.400
### Where did you get the app from?
F-Droid
### Android version
13 / OneUI 5.0
### Device model
Samsung ... | 14c5c07e3676f3dede03577d1e399c46fae5319c | 78d6e233629e6cfc598f349d2837c168c0909b1d | https://github.com/thundernest/k-9/compare/14c5c07e3676f3dede03577d1e399c46fae5319c...78d6e233629e6cfc598f349d2837c168c0909b1d | diff --git a/app/core/src/main/java/com/fsck/k9/controller/MessagingController.java b/app/core/src/main/java/com/fsck/k9/controller/MessagingController.java
index dfa2cc252..0d1f491f3 100644
--- a/app/core/src/main/java/com/fsck/k9/controller/MessagingController.java
+++ b/app/core/src/main/java/com/fsck/k9/controller/... | ['app/core/src/main/java/com/fsck/k9/controller/MessagingController.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 2,181,715 | 437,634 | 59,663 | 329 | 4,204 | 838 | 87 | 1 | 1,141 | 195 | 256 | 39 | 0 | 0 | 1970-01-01T00:27:53 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,533 | thundernest/k-9/6255/6243 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/6243 | https://github.com/thundernest/k-9/pull/6255 | https://github.com/thundernest/k-9/pull/6255 | 1 | fixes | SecurityException on image shared to K-9 not caught | ### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.301
### Where did you get the app from?
F-Droid
### Android version
12
### Device model
Pixel 4a
### Steps ... | 9cf73c99d09332a461ecb3830db86bca044bdf2e | fd396b183debe084a5cbdfba260bec1f6640bdbf | https://github.com/thundernest/k-9/compare/9cf73c99d09332a461ecb3830db86bca044bdf2e...fd396b183debe084a5cbdfba260bec1f6640bdbf | diff --git a/app/ui/legacy/src/main/java/com/fsck/k9/activity/loader/AttachmentContentLoader.java b/app/ui/legacy/src/main/java/com/fsck/k9/activity/loader/AttachmentContentLoader.java
index 6a420c812..19ceff5b6 100644
--- a/app/ui/legacy/src/main/java/com/fsck/k9/activity/loader/AttachmentContentLoader.java
+++ b/app/... | ['app/ui/legacy/src/main/java/com/fsck/k9/activity/loader/AttachmentInfoLoader.java', 'app/ui/legacy/src/main/java/com/fsck/k9/activity/loader/AttachmentContentLoader.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 2,061,027 | 411,985 | 57,788 | 345 | 4,492 | 787 | 106 | 2 | 5,350 | 445 | 1,622 | 74 | 1 | 1 | 1970-01-01T00:27:41 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,564 | thundernest/k-9/5650/5592 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/5592 | https://github.com/thundernest/k-9/pull/5650 | https://github.com/thundernest/k-9/pull/5650 | 1 | fixes | Sender name is not displayed | Please search to check for an existing issue (including closed issues, for which the fix may not have yet been released) before opening a new issue: https://github.com/k9mail/k-9/issues?q=is%3Aissue
If you are unsure whether or not you have found a bug please post to the support forum instead: https://forum.k9mail.a... | c92baae802f6f87b300aeb00cb88a1a8a1c7fad4 | 9156e8f699f6ab8c47bd23fffc989f53068521e0 | https://github.com/thundernest/k-9/compare/c92baae802f6f87b300aeb00cb88a1a8a1c7fad4...9156e8f699f6ab8c47bd23fffc989f53068521e0 | diff --git a/app/core/src/main/java/com/fsck/k9/helper/MessageHelper.java b/app/core/src/main/java/com/fsck/k9/helper/MessageHelper.java
index 5595d47f8..cb9e865da 100644
--- a/app/core/src/main/java/com/fsck/k9/helper/MessageHelper.java
+++ b/app/core/src/main/java/com/fsck/k9/helper/MessageHelper.java
@@ -1,6 +1,8 @@... | ['app/core/src/test/java/com/fsck/k9/helper/MessageHelperTest.java', 'app/core/src/main/java/com/fsck/k9/helper/MessageHelper.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 2,324,966 | 462,034 | 65,311 | 373 | 257 | 48 | 5 | 1 | 1,297 | 183 | 310 | 31 | 3 | 0 | 1970-01-01T00:27:10 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,490 | thundernest/k-9/6001/5999 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/5999 | https://github.com/thundernest/k-9/pull/6001 | https://github.com/thundernest/k-9/issues/5999#issuecomment-1087826808 | 2 | fixes | K-9 fails to import settings and then crashes | ### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
5.914 (git 0e78b8aae6bda14aca094298813b50759b50e8cb)
### Where did you get the app from?
Built from sou... | 0e78b8aae6bda14aca094298813b50759b50e8cb | 6721a1566322b80918a880a9cbeb87921d05f03f | https://github.com/thundernest/k-9/compare/0e78b8aae6bda14aca094298813b50759b50e8cb...6721a1566322b80918a880a9cbeb87921d05f03f | diff --git a/app/core/src/main/java/com/fsck/k9/preferences/SettingsImporter.java b/app/core/src/main/java/com/fsck/k9/preferences/SettingsImporter.java
index 1b28729f3..661ab013c 100644
--- a/app/core/src/main/java/com/fsck/k9/preferences/SettingsImporter.java
+++ b/app/core/src/main/java/com/fsck/k9/preferences/Setti... | ['app/core/src/main/java/com/fsck/k9/preferences/SettingsImporter.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 2,225,814 | 442,868 | 62,240 | 358 | 226 | 33 | 2 | 1 | 4,074 | 248 | 901 | 70 | 0 | 1 | 1970-01-01T00:27:29 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,611 | thundernest/k-9/4636/4620 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/4620 | https://github.com/thundernest/k-9/pull/4636 | https://github.com/thundernest/k-9/pull/4636 | 1 | fixes | Crash when saving attachment because no Activity found for CREATE_DOCUMENT Intent | * I have set up an account with pgp (most messages like the one from logcat are only encrypted, not signed)
* The message text is not shown but a file to show or save is presented
* pressing save crashes
* open only suggests openkeychain
* Version is 5.707 from f-droid
* thunderbird opens the mail inline
```
<<< lo... | 68213ac717feb90a112202f40c6119bb0d807222 | e46c5bd966f72b389eaed88f87b8e93125ddf3ee | https://github.com/thundernest/k-9/compare/68213ac717feb90a112202f40c6119bb0d807222...e46c5bd966f72b389eaed88f87b8e93125ddf3ee | diff --git a/app/ui/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.java b/app/ui/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.java
index a8d2c0165..e4e55485c 100644
--- a/app/ui/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.java
+++ b/app/ui/src/main/java/com/fsck/k9/ui/mess... | ['app/ui/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,016,992 | 594,615 | 83,878 | 465 | 379 | 57 | 7 | 1 | 8,689 | 650 | 2,745 | 173 | 0 | 1 | 1970-01-01T00:26:25 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,489 | thundernest/k-9/4474/4472 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/4472 | https://github.com/thundernest/k-9/pull/4474 | https://github.com/thundernest/k-9/issues/4472#issuecomment-578148550 | 2 | fixes | Contact pictures not shown | ### Expected behavior
If a mail comes in from a contact with a picture in address book and the option "show contact picture" is set, the **picture from the address book should be displayed**.
### Actual behavior
Only a generic first-letter-of-name picture is displayed in the mail. If you click on it, the correct c... | 28dadaf4683ebfeab0916369d5771642115df56e | 5b436adaeeb6c75cabcb0dd39015a4cdde6729a8 | https://github.com/thundernest/k-9/compare/28dadaf4683ebfeab0916369d5771642115df56e...5b436adaeeb6c75cabcb0dd39015a4cdde6729a8 | diff --git a/app/core/src/main/java/com/fsck/k9/helper/Contacts.java b/app/core/src/main/java/com/fsck/k9/helper/Contacts.java
index e9de1f814..94698809f 100644
--- a/app/core/src/main/java/com/fsck/k9/helper/Contacts.java
+++ b/app/core/src/main/java/com/fsck/k9/helper/Contacts.java
@@ -6,7 +6,6 @@ import android.cont... | ['app/core/src/main/java/com/fsck/k9/helper/Contacts.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,094,671 | 609,924 | 86,111 | 477 | 372 | 54 | 6 | 1 | 795 | 133 | 184 | 19 | 0 | 0 | 1970-01-01T00:26:19 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,631 | thundernest/k-9/3756/3652 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/3652 | https://github.com/thundernest/k-9/pull/3756 | https://github.com/thundernest/k-9/pull/3756 | 1 | fixes | Crash on open certain messages | Certain spam messages, not detected by German email provider GMX (false negative), causing k-9 to crash.
### Expected behavior
On tapping a message from folder list, the message should appear in detailed view.
### Actual behavior
On tapping a message from folder list, k-9 crashes
### Steps to reproduce
1. T... | 0455157eb7e4c21e971f19ca39e8dcd29d440b13 | 4e6d642ddd8121f35bb596377f88d7fd6dd5afd6 | https://github.com/thundernest/k-9/compare/0455157eb7e4c21e971f19ca39e8dcd29d440b13...4e6d642ddd8121f35bb596377f88d7fd6dd5afd6 | diff --git a/mail/common/src/main/java/com/fsck/k9/mail/Address.java b/mail/common/src/main/java/com/fsck/k9/mail/Address.java
index 88c773913..7fd63782b 100644
--- a/mail/common/src/main/java/com/fsck/k9/mail/Address.java
+++ b/mail/common/src/main/java/com/fsck/k9/mail/Address.java
@@ -1,6 +1,7 @@
package com.fsck... | ['mail/common/src/test/java/com/fsck/k9/mail/AddressTest.java', 'mail/common/src/main/java/com/fsck/k9/mail/Address.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 3,539,843 | 696,597 | 97,904 | 512 | 653 | 111 | 14 | 1 | 898 | 122 | 237 | 27 | 1 | 0 | 1970-01-01T00:25:43 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,488 | thundernest/k-9/4419/3266 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/3266 | https://github.com/thundernest/k-9/pull/4419 | https://github.com/thundernest/k-9/pull/4419#issuecomment-570258591 | 1 | fixes | crash: reply to encrypted mail |
### Expected behavior
open new mail screen.
### Actual behavior
K9 displays new mail screen and crashes.
03-16 12:15:32.187 E/AndroidRuntime(31412): java.lang.NullPointerException: Attempt to invoke interface method 'com.fsck.k9.mail.Body com.fsck.k9.mail.Part.getBody()' on a null object reference
This see... | 0aac541c273f0d3b7e88cf06e7c6331fdaad1ae6 | d937113b6b3ae91b213e2621c4a5623d8e27f008 | https://github.com/thundernest/k-9/compare/0aac541c273f0d3b7e88cf06e7c6331fdaad1ae6...d937113b6b3ae91b213e2621c4a5623d8e27f008 | diff --git a/app/core/src/main/java/com/fsck/k9/mailstore/MessageViewInfo.java b/app/core/src/main/java/com/fsck/k9/mailstore/MessageViewInfo.java
index 64ba2ca7c..35795fff2 100644
--- a/app/core/src/main/java/com/fsck/k9/mailstore/MessageViewInfo.java
+++ b/app/core/src/main/java/com/fsck/k9/mailstore/MessageViewInfo.... | ['app/core/src/main/java/com/fsck/k9/mailstore/MessageViewInfo.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,127,952 | 616,646 | 87,029 | 475 | 727 | 158 | 14 | 1 | 627 | 79 | 159 | 23 | 0 | 0 | 1970-01-01T00:26:17 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,487 | thundernest/k-9/2206/1932 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/1932 | https://github.com/thundernest/k-9/pull/2206 | https://github.com/thundernest/k-9/pull/2206#issuecomment-280692550 | 1 | fix | Error Decrypting Email | ### Expected behavior
Expected decrypted email to show in cleartext
### Actual behavior
Error Eecrypting Email message shown with icon from OpenKeyChain
### Steps to reproduce
Send encrypted email to an account handled by K-9
Open email in k-9
Answer password request for decryption Key
See error message
... | 19b7d4491d5a925a4f53f6d155619e674f16c5cc | 955d994bcea275bf793b67df964bb0062b4424db | https://github.com/thundernest/k-9/compare/19b7d4491d5a925a4f53f6d155619e674f16c5cc...955d994bcea275bf793b67df964bb0062b4424db | diff --git a/k9mail/src/main/java/com/fsck/k9/activity/MessageLoaderHelper.java b/k9mail/src/main/java/com/fsck/k9/activity/MessageLoaderHelper.java
index d29b79181..b6d1d9346 100644
--- a/k9mail/src/main/java/com/fsck/k9/activity/MessageLoaderHelper.java
+++ b/k9mail/src/main/java/com/fsck/k9/activity/MessageLoaderHel... | ['k9mail/src/main/java/com/fsck/k9/helper/RetainFragment.java', 'k9mail/src/main/java/com/fsck/k9/activity/MessageLoaderHelper.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 3,474,872 | 689,617 | 95,086 | 439 | 1,455 | 280 | 21 | 2 | 941 | 125 | 232 | 30 | 1 | 0 | 1970-01-01T00:24:46 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,547 | thundernest/k-9/5931/5930 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/5930 | https://github.com/thundernest/k-9/pull/5931 | https://github.com/thundernest/k-9/pull/5931 | 1 | fixes | Notification isn't removed when message is marked as read or deleted locally | ### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
5.911
### Where did you get the app from?
_No response_
### Android version
doesn't matter
### Device model
_N... | 504062a5338f8e14b72556861fad0f52fd84f5e3 | e1c43beee1421409fc32e00b07e61cd7cb8644e2 | https://github.com/thundernest/k-9/compare/504062a5338f8e14b72556861fad0f52fd84f5e3...e1c43beee1421409fc32e00b07e61cd7cb8644e2 | diff --git a/app/core/src/main/java/com/fsck/k9/controller/MessagingController.java b/app/core/src/main/java/com/fsck/k9/controller/MessagingController.java
index ff1cb2fa4..12cd1439a 100644
--- a/app/core/src/main/java/com/fsck/k9/controller/MessagingController.java
+++ b/app/core/src/main/java/com/fsck/k9/controller/... | ['app/core/src/main/java/com/fsck/k9/controller/MessagingController.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 2,232,542 | 444,140 | 62,418 | 358 | 602 | 106 | 13 | 1 | 764 | 134 | 173 | 40 | 0 | 0 | 1970-01-01T00:27:25 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,550 | thundernest/k-9/5881/5879 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/5879 | https://github.com/thundernest/k-9/pull/5881 | https://github.com/thundernest/k-9/pull/5881 | 1 | fixes | Can't connect to POP3 server (IONOS, GMX, maybe others) | ### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
5.806
### Where did you get the app from?
Google Play
### Android version
8.0
### Device model
Shift 5me
### ... | de15580e400b8101a10d824fbc6e8a111373880d | 251a221b3b3fd86b11b5f58f2a4fe197c45bf36e | https://github.com/thundernest/k-9/compare/de15580e400b8101a10d824fbc6e8a111373880d...251a221b3b3fd86b11b5f58f2a4fe197c45bf36e | diff --git a/mail/protocols/pop3/src/main/java/com/fsck/k9/mail/store/pop3/Pop3Connection.java b/mail/protocols/pop3/src/main/java/com/fsck/k9/mail/store/pop3/Pop3Connection.java
index 666d40065..2a0d004e2 100644
--- a/mail/protocols/pop3/src/main/java/com/fsck/k9/mail/store/pop3/Pop3Connection.java
+++ b/mail/protocol... | ['mail/protocols/pop3/src/main/java/com/fsck/k9/mail/store/pop3/Pop3Connection.java', 'mail/protocols/pop3/src/test/java/com/fsck/k9/mail/store/pop3/Pop3StoreTest.java', 'mail/protocols/pop3/src/test/java/com/fsck/k9/mail/store/pop3/Pop3ConnectionTest.java'] | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 2,274,800 | 452,593 | 63,876 | 364 | 1,547 | 251 | 37 | 1 | 1,109 | 187 | 250 | 40 | 0 | 0 | 1970-01-01T00:27:23 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,552 | thundernest/k-9/5864/5800 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/5800 | https://github.com/thundernest/k-9/pull/5864 | https://github.com/thundernest/k-9/pull/5864 | 1 | fix | Username isn't trimmed | **Describe the bug**
When adding a new email account, the specified username is not trimmed. Thus when C&P'ing a username that happens to contain a space (at the end), the authentication will fail and it is very hard to figure out that the training space is the issue, since it is not rendered (as a visible character)
... | 722e6b923fcdb511a72234cb4d06a92759059c9c | 1ffc7ba02cfbba0b97c122433bc2d5b97c496bd2 | https://github.com/thundernest/k-9/compare/722e6b923fcdb511a72234cb4d06a92759059c9c...1ffc7ba02cfbba0b97c122433bc2d5b97c496bd2 | diff --git a/app/ui/legacy/src/main/java/com/fsck/k9/activity/setup/AccountSetupIncoming.java b/app/ui/legacy/src/main/java/com/fsck/k9/activity/setup/AccountSetupIncoming.java
index b5cba2113..c3f27bcf5 100644
--- a/app/ui/legacy/src/main/java/com/fsck/k9/activity/setup/AccountSetupIncoming.java
+++ b/app/ui/legacy/sr... | ['app/ui/legacy/src/main/java/com/fsck/k9/activity/setup/AccountSetupOutgoing.java', 'app/ui/legacy/src/main/java/com/fsck/k9/activity/setup/AccountSetupIncoming.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 2,274,710 | 452,555 | 63,881 | 365 | 1,564 | 262 | 28 | 2 | 673 | 107 | 145 | 12 | 0 | 0 | 1970-01-01T00:27:22 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,553 | thundernest/k-9/5854/5851 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/5851 | https://github.com/thundernest/k-9/pull/5854 | https://github.com/thundernest/k-9/pull/5854 | 1 | fixes | Outbox Refreshes Once Mail Sends But Leaves Numbers With Empty Outbox | Please search to check for an existing issue (including closed issues, for which the fix may not have yet been released) before opening a new issue: https://github.com/k9mail/k-9/issues?q=is%3Aissue
If you are unsure whether or not you have found a bug please post to the support forum instead: https://forum.k9mail.a... | b05c0ea5c4f0f953ef1e4844b91a94192cec2aa4 | d68b3269941f14fb1076364ff465248420f7dfc5 | https://github.com/thundernest/k-9/compare/b05c0ea5c4f0f953ef1e4844b91a94192cec2aa4...d68b3269941f14fb1076364ff465248420f7dfc5 | diff --git a/app/core/src/main/java/com/fsck/k9/controller/MessagingController.java b/app/core/src/main/java/com/fsck/k9/controller/MessagingController.java
index 3e1a70258..ba4ca011e 100644
--- a/app/core/src/main/java/com/fsck/k9/controller/MessagingController.java
+++ b/app/core/src/main/java/com/fsck/k9/controller/... | ['app/core/src/main/java/com/fsck/k9/controller/MessagingController.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 2,274,409 | 452,511 | 63,875 | 365 | 154 | 28 | 4 | 1 | 1,175 | 180 | 280 | 38 | 2 | 0 | 1970-01-01T00:27:21 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,613 | thundernest/k-9/4540/4498 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/4498 | https://github.com/thundernest/k-9/pull/4540 | https://github.com/thundernest/k-9/pull/4540 | 1 | fixes | youtube loads in the message window | ### Expected behavior
When opening a message from a subscribed youtube channel and after pressing the video thumbnail or link, a popup should appear asking you which application to use to open the video link.
### Actual behavior
The video loads in the message window.
### Steps to reproduce
1. Open the message ... | 5dce1101edb40076423fa04c44e23b1a12958b40 | ce7b59addfa59e414db1cf6d9810a673df0aaa46 | https://github.com/thundernest/k-9/compare/5dce1101edb40076423fa04c44e23b1a12958b40...ce7b59addfa59e414db1cf6d9810a673df0aaa46 | diff --git a/app/ui/src/main/java/com/fsck/k9/view/K9WebViewClient.java b/app/ui/src/main/java/com/fsck/k9/view/K9WebViewClient.java
index 8fdc85179..29ef07e44 100644
--- a/app/ui/src/main/java/com/fsck/k9/view/K9WebViewClient.java
+++ b/app/ui/src/main/java/com/fsck/k9/view/K9WebViewClient.java
@@ -10,6 +10,7 @@ impor... | ['app/ui/src/main/java/com/fsck/k9/view/K9WebViewClient.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,065,884 | 603,974 | 85,212 | 472 | 465 | 90 | 14 | 1 | 620 | 91 | 144 | 19 | 1 | 0 | 1970-01-01T00:26:21 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,615 | thundernest/k-9/4506/4498 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/4498 | https://github.com/thundernest/k-9/pull/4506 | https://github.com/thundernest/k-9/pull/4506 | 1 | fixes | youtube loads in the message window | ### Expected behavior
When opening a message from a subscribed youtube channel and after pressing the video thumbnail or link, a popup should appear asking you which application to use to open the video link.
### Actual behavior
The video loads in the message window.
### Steps to reproduce
1. Open the message ... | 79c06745fb27af807d894092d5001506aaaddf53 | 67e2029d56e2c2d13200d149196f6cdc04a4e71a | https://github.com/thundernest/k-9/compare/79c06745fb27af807d894092d5001506aaaddf53...67e2029d56e2c2d13200d149196f6cdc04a4e71a | diff --git a/app/ui/src/main/java/com/fsck/k9/view/K9WebViewClient.java b/app/ui/src/main/java/com/fsck/k9/view/K9WebViewClient.java
index aac73ba73..8fdc85179 100644
--- a/app/ui/src/main/java/com/fsck/k9/view/K9WebViewClient.java
+++ b/app/ui/src/main/java/com/fsck/k9/view/K9WebViewClient.java
@@ -16,9 +16,11 @@ impo... | ['app/ui/src/main/java/com/fsck/k9/view/K9WebViewClient.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,066,654 | 604,188 | 85,247 | 473 | 396 | 75 | 8 | 1 | 620 | 91 | 144 | 19 | 1 | 0 | 1970-01-01T00:26:20 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,520 | thundernest/k-9/6372/3937 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/3937 | https://github.com/thundernest/k-9/pull/6372 | https://github.com/thundernest/k-9/pull/6372 | 1 | fixes | Message inadvertently sent twice | When sending emails through K-9 on a Xiaomi Mi Mix2, occasionally the same email is sent twice. This happens both on Wi-Fi and mobile data connections. It is unclear what triggers the issue, but it appears specific to K-9 running on a Xiaomi Mi Mix2, so either the application or the phone, or the combination of the two... | e94a42f63f1f2b4858a5e749f39720fa92220d69 | 738ba9c112126c745cf0bd408427899db9d28d41 | https://github.com/thundernest/k-9/compare/e94a42f63f1f2b4858a5e749f39720fa92220d69...738ba9c112126c745cf0bd408427899db9d28d41 | diff --git a/app/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java b/app/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java
index 81b55765a..925edd1ed 100644
--- a/app/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java
+++ b/app/ui/legacy/src/main/java/com/fsck/k9/activity/Mes... | ['app/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 1,987,713 | 397,255 | 55,512 | 333 | 276 | 48 | 10 | 1 | 1,771 | 272 | 442 | 37 | 2 | 0 | 1970-01-01T00:27:45 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,629 | thundernest/k-9/3864/3862 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/3862 | https://github.com/thundernest/k-9/pull/3864 | https://github.com/thundernest/k-9/pull/3864 | 1 | fixes | Fix ImapStore.listFolders() when SPECIAL-USE extension is present | `LIST (SPECIAL-USE) …` only lists special folders, not special folders and regular folders.
We probably want to switch back to using a regular LSUB/LIST, then querying the special folders and adding them to our list afterwards. That way we'll get to use a special folder, even if it wasn't included in the result list... | 6a64d5e380d60ee6de6be8e22f5f016af407c015 | e4d7482bef618c76e9e52cf86aa636dfa29feb4e | https://github.com/thundernest/k-9/compare/6a64d5e380d60ee6de6be8e22f5f016af407c015...e4d7482bef618c76e9e52cf86aa636dfa29feb4e | diff --git a/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapConnection.java b/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapConnection.java
index 0758cf6ce..dde67c72f 100644
--- a/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapConnection.java
+++ b/mail/protocol... | ['mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/ImapConnectionTest.java', 'mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapConnection.java', 'mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapStore.java', 'mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/Im... | {'.java': 4} | 4 | 4 | 0 | 0 | 4 | 3,430,452 | 674,824 | 95,177 | 504 | 1,027 | 206 | 21 | 2 | 457 | 78 | 100 | 3 | 0 | 0 | 1970-01-01T00:25:46 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,627 | thundernest/k-9/4161/4160 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/4160 | https://github.com/thundernest/k-9/pull/4161 | https://github.com/thundernest/k-9/pull/4161 | 1 | fixes | The application still has some bugs | Hello. I noticed some crashes in logs. The corresponding commit version of code is e85e91c, and application version is 5.6.
## 1.com.fsck.k9.activity.LauncherShortcuts
The exception trace is:
*FATAL EXCEPTION: main
android.util.SuperNotCalledException: Activity {com.fsck.k9/com.fsck.k9.activity.LauncherShortcuts}... | 168e0908464f5fe8306d99119864438d66d1da8e | 4886f2f8fc943b2507bec8d6b9fb6affc25c163c | https://github.com/thundernest/k-9/compare/168e0908464f5fe8306d99119864438d66d1da8e...4886f2f8fc943b2507bec8d6b9fb6affc25c163c | diff --git a/app/ui/src/main/java/com/fsck/k9/activity/LauncherShortcuts.java b/app/ui/src/main/java/com/fsck/k9/activity/LauncherShortcuts.java
index 1e26574b7..990d24793 100644
--- a/app/ui/src/main/java/com/fsck/k9/activity/LauncherShortcuts.java
+++ b/app/ui/src/main/java/com/fsck/k9/activity/LauncherShortcuts.java... | ['app/ui/src/main/java/com/fsck/k9/activity/LauncherShortcuts.java', 'app/ui/src/main/java/com/fsck/k9/activity/MessageList.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 3,323,824 | 653,728 | 92,315 | 494 | 2,224 | 375 | 39 | 2 | 5,133 | 320 | 1,168 | 67 | 0 | 0 | 1970-01-01T00:26:05 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,626 | thundernest/k-9/4218/4121 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/4121 | https://github.com/thundernest/k-9/pull/4218 | https://github.com/thundernest/k-9/pull/4218 | 1 | closes | Openpgp enable crash | ### Actual behavior
K9 crashes when enabling openpgp support without having a provider installed.
### Steps to reproduce
Click the following:
1. Settings
2. Account
3. End-to-end encryption
4. Enable
5. Install
### Environment
K-9 Mail version: master
Android version:9.0
```
07-23 15:58:10.701 2... | 4f85dc2220a378036238d7c5fe1edf2580cb3381 | b981cd0efd8d4c8faff13085226c9863ead8e15b | https://github.com/thundernest/k-9/compare/4f85dc2220a378036238d7c5fe1edf2580cb3381...b981cd0efd8d4c8faff13085226c9863ead8e15b | diff --git a/app/ui/src/main/java/com/fsck/k9/ui/settings/account/OpenPgpAppSelectDialog.java b/app/ui/src/main/java/com/fsck/k9/ui/settings/account/OpenPgpAppSelectDialog.java
index d94bc56b8..376f8b0fb 100644
--- a/app/ui/src/main/java/com/fsck/k9/ui/settings/account/OpenPgpAppSelectDialog.java
+++ b/app/ui/src/main/... | ['app/ui/src/main/java/com/fsck/k9/ui/settings/account/OpenPgpAppSelectDialog.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,324,156 | 653,699 | 92,300 | 494 | 113 | 16 | 2 | 1 | 2,797 | 245 | 877 | 38 | 0 | 1 | 1970-01-01T00:26:10 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,624 | thundernest/k-9/4255/4250 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/4250 | https://github.com/thundernest/k-9/pull/4255 | https://github.com/thundernest/k-9/pull/4255 | 1 | fixes | Cannot connect to server (Invalid CAPABILITY response received) | ### Expected behavior
Fetch mail
### Actual behavior
Cannot connect to server (Invalid CAPABILITY response received)
### Steps to reproduce
Capabilities returned from the IMAP server
```
a capability
* CAPABILITY IMAP4rev1 STARTTLS AUTH=PLAIN AUTH=LOGIN ID APPENDLIMIT
a OK CAPABILITY completed
```
### ... | f62615bb577b0ee76cbfcbcca49dcd837d4225bd | b241201e88e27ee5361130dfffe4ca613ae0c98a | https://github.com/thundernest/k-9/compare/f62615bb577b0ee76cbfcbcca49dcd837d4225bd...b241201e88e27ee5361130dfffe4ca613ae0c98a | diff --git a/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapConnection.java b/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapConnection.java
index dde67c72f..3b866a0c4 100644
--- a/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapConnection.java
+++ b/mail/protocol... | ['mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/ImapConnectionTest.java', 'mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapConnection.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 3,235,879 | 638,269 | 90,039 | 491 | 1,756 | 321 | 32 | 1 | 533 | 66 | 133 | 23 | 1 | 1 | 1970-01-01T00:26:13 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,623 | thundernest/k-9/4271/4248 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/4248 | https://github.com/thundernest/k-9/pull/4271 | https://github.com/thundernest/k-9/pull/4271 | 1 | fixes | master branch crashes on start when trying to add an IMAP account | ### Expected behavior
k9 should allow to create an IMAP account without crashing
### Actual behavior
After entering the details for the incoming server, the screen for outgoing server settings appears shortly, but then k9 crashes with following errors:
```
E/AndroidRuntime: FATAL EXCEPTION: MessagingController... | b396c801143583e1eb4b41b5080f662e71db1362 | d4def08551f5efaaf9ce7bbe98f3f696fa24af46 | https://github.com/thundernest/k-9/compare/b396c801143583e1eb4b41b5080f662e71db1362...d4def08551f5efaaf9ce7bbe98f3f696fa24af46 | diff --git a/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapStore.java b/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapStore.java
index e15b62709..b723fa9ce 100644
--- a/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapStore.java
+++ b/mail/protocols/imap/src/main... | ['mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapStore.java', 'mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/ImapStoreTest.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 3,224,126 | 635,536 | 89,700 | 488 | 592 | 113 | 9 | 1 | 2,368 | 205 | 574 | 43 | 0 | 1 | 1970-01-01T00:26:14 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,616 | thundernest/k-9/4447/4436 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/4436 | https://github.com/thundernest/k-9/pull/4447 | https://github.com/thundernest/k-9/pull/4447 | 2 | fixes | Non-existent folder in PendingMoveOrCopy | Note: maybe related or duplicated with #4420 , but opening a new issue since I'm not sure.
Hello,
Thanks for working and offering k-9 mail, it's very useful piece of software.
I use the F-Droid version and recently upgraded from 5.600 to 5.700 (and then the next ones. Currently I'm using 5.703).
I use K-9 in te... | 6ad0d66d43b99bc1bbe25b382f26877bc5f08f32 | a939eca6d55b6375e9f12c8bc07a2602415b4e79 | https://github.com/thundernest/k-9/compare/6ad0d66d43b99bc1bbe25b382f26877bc5f08f32...a939eca6d55b6375e9f12c8bc07a2602415b4e79 | diff --git a/app/core/src/main/java/com/fsck/k9/controller/MessagingController.java b/app/core/src/main/java/com/fsck/k9/controller/MessagingController.java
index b21b0c00d..d15b60eb5 100644
--- a/app/core/src/main/java/com/fsck/k9/controller/MessagingController.java
+++ b/app/core/src/main/java/com/fsck/k9/controller/... | ['app/core/src/main/java/com/fsck/k9/controller/MessagingController.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,116,381 | 614,189 | 86,751 | 477 | 261 | 48 | 3 | 1 | 1,652 | 273 | 394 | 23 | 1 | 0 | 1970-01-01T00:26:18 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,505 | thundernest/k-9/6586/6582 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/6582 | https://github.com/thundernest/k-9/pull/6586 | https://github.com/thundernest/k-9/pull/6586 | 1 | fixes | "Delete spam messages immediately without moving them to the trash folder" doesn't delete Email in Spam Folder | ### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.501
### Where did you get the app from?
Other
### Android version
13
### Device model
Pixel 5
### Steps to ... | e797da026efc9c5799d7df6ebae55c49d9233be9 | 3a04190aa223a4292e0c4af4815b0aca5cfc7c41 | https://github.com/thundernest/k-9/compare/e797da026efc9c5799d7df6ebae55c49d9233be9...3a04190aa223a4292e0c4af4815b0aca5cfc7c41 | diff --git a/app/core/src/main/java/com/fsck/k9/controller/MessagingController.java b/app/core/src/main/java/com/fsck/k9/controller/MessagingController.java
index 16944e743..dfa2cc252 100644
--- a/app/core/src/main/java/com/fsck/k9/controller/MessagingController.java
+++ b/app/core/src/main/java/com/fsck/k9/controller/... | ['app/core/src/main/java/com/fsck/k9/controller/MessagingController.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 2,181,712 | 437,631 | 59,661 | 329 | 702 | 150 | 10 | 1 | 924 | 164 | 214 | 46 | 0 | 0 | 1970-01-01T00:27:53 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,671 | thundernest/k-9/1013/871 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/871 | https://github.com/thundernest/k-9/pull/1013 | https://github.com/thundernest/k-9/pull/1013 | 1 | fixes | Crash during reading of an email | I receive an email which crashes the app.
After some research, I found that mBody for the file Version_texte.txt is null (LocalBodyPart with minetype "text/plain") and OpenPgpUtils.parseMessage crashes with a null value.
I also tried a new email with this file but mBody is not null.
So I think the issue is located in t... | ac131a2919040f5ef34b7d30cdb815f0a31b83aa | 15571b597665aeddddf65db2337ff7b4210c7844 | https://github.com/thundernest/k-9/compare/ac131a2919040f5ef34b7d30cdb815f0a31b83aa...15571b597665aeddddf65db2337ff7b4210c7844 | diff --git a/k9mail/src/main/java/com/fsck/k9/crypto/MessageDecryptVerifier.java b/k9mail/src/main/java/com/fsck/k9/crypto/MessageDecryptVerifier.java
index e11e86a32..761dc2e39 100644
--- a/k9mail/src/main/java/com/fsck/k9/crypto/MessageDecryptVerifier.java
+++ b/k9mail/src/main/java/com/fsck/k9/crypto/MessageDecryptV... | ['k9mail/src/main/java/com/fsck/k9/crypto/MessageDecryptVerifier.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,238,666 | 642,061 | 88,696 | 328 | 131 | 18 | 5 | 1 | 431 | 65 | 105 | 7 | 1 | 0 | 1970-01-01T00:24:12 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,670 | thundernest/k-9/1017/899 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/899 | https://github.com/thundernest/k-9/pull/1017 | https://github.com/thundernest/k-9/pull/1017 | 1 | fixes | backslash in username does not work for IMAP login | I need to access an exchange server via IMAP. My username has the form username@domain\\special_mailbox .
Authentication with just username for the personal mailbox works fine but not for the special mailbox with the backslash syntax above.
I tried two backslashes since I suspected some java string escaping problem, bu... | ac131a2919040f5ef34b7d30cdb815f0a31b83aa | 0366633ff83086f3c7620a618ae7b3b5cc6ade1a | https://github.com/thundernest/k-9/compare/ac131a2919040f5ef34b7d30cdb815f0a31b83aa...0366633ff83086f3c7620a618ae7b3b5cc6ade1a | diff --git a/k9mail-library/src/main/java/com/fsck/k9/mail/store/imap/ImapConnection.java b/k9mail-library/src/main/java/com/fsck/k9/mail/store/imap/ImapConnection.java
index a81408755..ada1a1f53 100644
--- a/k9mail-library/src/main/java/com/fsck/k9/mail/store/imap/ImapConnection.java
+++ b/k9mail-library/src/main/java... | ['k9mail-library/src/main/java/com/fsck/k9/mail/store/imap/ImapConnection.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,238,666 | 642,061 | 88,696 | 328 | 326 | 58 | 10 | 1 | 347 | 55 | 68 | 4 | 0 | 0 | 1970-01-01T00:24:12 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,669 | thundernest/k-9/1126/1110 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/1110 | https://github.com/thundernest/k-9/pull/1126 | https://github.com/thundernest/k-9/pull/1126 | 1 | fixes | Notification stays after reading e-mail | ### Expected behaviour
Notification disappears after reading an e-mail.
### Actual behaviour
The notification stays after reading the e-mail, when the e-mail was received by refreshing the inbox out of the inbox.
### Steps to reproduce
1. Go to the inbox, where you expect to get an e-mail in.
2. Refresh the inbox, so... | e27205873d661d5a192d2838e210605fafdf620f | 41a32bd3472a25a392037bc9cb71730395cd3e9f | https://github.com/thundernest/k-9/compare/e27205873d661d5a192d2838e210605fafdf620f...41a32bd3472a25a392037bc9cb71730395cd3e9f | diff --git a/k9mail/src/main/java/com/fsck/k9/controller/MessagingController.java b/k9mail/src/main/java/com/fsck/k9/controller/MessagingController.java
index 8f51a5222..efc039033 100644
--- a/k9mail/src/main/java/com/fsck/k9/controller/MessagingController.java
+++ b/k9mail/src/main/java/com/fsck/k9/controller/Messagin... | ['k9mail/src/main/java/com/fsck/k9/controller/MessagingController.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,407,629 | 676,626 | 93,646 | 377 | 99 | 14 | 1 | 1 | 641 | 109 | 166 | 20 | 0 | 0 | 1970-01-01T00:24:16 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,494 | thundernest/k-9/6972/6816 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/6816 | https://github.com/thundernest/k-9/pull/6972 | https://github.com/thundernest/k-9/pull/6972 | 1 | fixes | Inconsistent recipient names when composing a message | ### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.400
### Where did you get the app from?
F-Droid
### Android version
13
### Device model
_... | 4bc2afa9ad88c319f9d237872f3038633efb9554 | ff79ee70fc2cd49a3c7dc8630b85908d5fc782e5 | https://github.com/thundernest/k-9/compare/4bc2afa9ad88c319f9d237872f3038633efb9554...ff79ee70fc2cd49a3c7dc8630b85908d5fc782e5 | diff --git a/app/ui/legacy/src/main/java/com/fsck/k9/activity/compose/RecipientLoader.java b/app/ui/legacy/src/main/java/com/fsck/k9/activity/compose/RecipientLoader.java
index e5fd41de2..e3931375f 100644
--- a/app/ui/legacy/src/main/java/com/fsck/k9/activity/compose/RecipientLoader.java
+++ b/app/ui/legacy/src/main/ja... | ['app/ui/legacy/src/main/java/com/fsck/k9/activity/compose/RecipientLoader.java', 'app/ui/legacy/src/test/java/com/fsck/k9/activity/compose/RecipientLoaderTest.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 2,002,696 | 401,935 | 54,851 | 301 | 1,076 | 214 | 14 | 1 | 1,020 | 165 | 235 | 40 | 0 | 0 | 1970-01-01T00:28:06 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,668 | thundernest/k-9/1133/811 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/811 | https://github.com/thundernest/k-9/pull/1133 | https://github.com/thundernest/k-9/pull/1133 | 1 | fixes | ClassCastException on IMAP sync | On a fresh install of k9Mail on a new phone, one of my IMAP accounts stops suddenly with the below error. It worked like a charm for a few days prior to that. I've another IMAP account on the same server which still works and isn't affected.
K9-Mail version: 5.006
Device make: motorola
Device model: MotoG3
Android ver... | 916e83d4d9cfa9767c3912fb720d3a981b79d4a1 | 14054ec977f94d42c8648acd6d05ef295ce598a8 | https://github.com/thundernest/k-9/compare/916e83d4d9cfa9767c3912fb720d3a981b79d4a1...14054ec977f94d42c8648acd6d05ef295ce598a8 | diff --git a/k9mail-library/src/main/java/com/fsck/k9/mail/store/imap/ImapResponseParser.java b/k9mail-library/src/main/java/com/fsck/k9/mail/store/imap/ImapResponseParser.java
index 7b70d41f4..b508bad7e 100644
--- a/k9mail-library/src/main/java/com/fsck/k9/mail/store/imap/ImapResponseParser.java
+++ b/k9mail-library/s... | ['k9mail-library/src/main/java/com/fsck/k9/mail/store/imap/ImapResponseParser.java', 'k9mail-library/src/test/java/com/fsck/k9/mail/store/imap/ImapResponseParserTest.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 3,404,894 | 677,863 | 94,218 | 395 | 787 | 154 | 18 | 1 | 1,934 | 100 | 527 | 26 | 0 | 0 | 1970-01-01T00:24:16 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,656 | thundernest/k-9/1883/1874 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/1874 | https://github.com/thundernest/k-9/pull/1883 | https://github.com/thundernest/k-9/pull/1883 | 1 | fixes | Crash: NPE in Address.hashCode() | Via Play Developer Console
App version: 5.200
```
java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.String.hashCode()' on a null object reference
at com.fsck.k9.mail.Address.hashCode(Address.java:176)
at java.util.Collections.secondaryHash(Collections.java:3405)
at java.util.Lin... | b2ed230b322277f6e366fc3f1510043ccba45836 | 40e5f038044f208b345842bf726e009aea86c87e | https://github.com/thundernest/k-9/compare/b2ed230b322277f6e366fc3f1510043ccba45836...40e5f038044f208b345842bf726e009aea86c87e | diff --git a/k9mail-library/src/main/java/com/fsck/k9/mail/Address.java b/k9mail-library/src/main/java/com/fsck/k9/mail/Address.java
index dfb778a4a..5b6b3885c 100644
--- a/k9mail-library/src/main/java/com/fsck/k9/mail/Address.java
+++ b/k9mail-library/src/main/java/com/fsck/k9/mail/Address.java
@@ -173,7 +173,10 @@ pu... | ['k9mail-library/src/test/java/com/fsck/k9/mail/AddressTest.java', 'k9mail-library/src/main/java/com/fsck/k9/mail/Address.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 3,440,332 | 682,537 | 94,166 | 420 | 149 | 33 | 5 | 1 | 1,843 | 67 | 412 | 28 | 0 | 1 | 1970-01-01T00:24:42 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,610 | thundernest/k-9/4671/4435 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/4435 | https://github.com/thundernest/k-9/pull/4671 | https://github.com/thundernest/k-9/pull/4671 | 1 | fixes | Do not save unmodified new message as draft | ### Expected behavior
After having pressing the compose new message button, the compose view opens. If you close/background the app at this point, without changing/inputting anything at all, K-9 should not have saved the message as a draft.
### Actual behavior
The empty new message is saved as a draft.
### St... | 3459ab526748a6e3ee17813603903c2cd91b792e | fc49fb9d67f469c14b508237d8315508179a692c | https://github.com/thundernest/k-9/compare/3459ab526748a6e3ee17813603903c2cd91b792e...fc49fb9d67f469c14b508237d8315508179a692c | diff --git a/app/ui/src/main/java/com/fsck/k9/activity/MessageCompose.java b/app/ui/src/main/java/com/fsck/k9/activity/MessageCompose.java
index ef8be534c..d078a3a5c 100644
--- a/app/ui/src/main/java/com/fsck/k9/activity/MessageCompose.java
+++ b/app/ui/src/main/java/com/fsck/k9/activity/MessageCompose.java
@@ -120,8 +... | ['app/ui/src/test/java/com/fsck/k9/activity/compose/RecipientPresenterTest.java', 'app/ui/src/main/java/com/fsck/k9/activity/compose/RecipientPresenter.java', 'app/ui/src/main/java/com/fsck/k9/activity/MessageCompose.java', 'app/ui/src/main/java/com/fsck/k9/activity/compose/RecipientMvpView.java'] | {'.java': 4} | 4 | 4 | 0 | 0 | 4 | 2,853,108 | 562,316 | 79,533 | 422 | 3,386 | 638 | 78 | 3 | 1,737 | 304 | 379 | 24 | 0 | 0 | 1970-01-01T00:26:27 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,658 | thundernest/k-9/1689/1609 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/1609 | https://github.com/thundernest/k-9/pull/1689 | https://github.com/thundernest/k-9/pull/1689 | 1 | fixes | Quoted-printable encoding inserts unnecessary line breaks | K-9 Mail created a message that contained unnecessary line breaks in the encoded message body.
(v5.111)
```
[...]
Content-Type: text/plain;
charset=utf-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
[...]
-----BEGIN PGP SIGNATURE-----
iQI0BAEBCgAeFxx... | fc79b290d03bad5a20347c8bc12c467ad6700dcf | ce249bf07ef7c8a83dac6b17681de238b45e77ba | https://github.com/thundernest/k-9/compare/fc79b290d03bad5a20347c8bc12c467ad6700dcf...ce249bf07ef7c8a83dac6b17681de238b45e77ba | diff --git a/k9mail/src/main/java/com/fsck/k9/message/PgpMessageBuilder.java b/k9mail/src/main/java/com/fsck/k9/message/PgpMessageBuilder.java
index b0c5d10b9..11638b6e0 100644
--- a/k9mail/src/main/java/com/fsck/k9/message/PgpMessageBuilder.java
+++ b/k9mail/src/main/java/com/fsck/k9/message/PgpMessageBuilder.java
@@ ... | ['k9mail/src/main/java/com/fsck/k9/message/PgpMessageBuilder.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,539,371 | 707,429 | 97,689 | 433 | 343 | 68 | 4 | 1 | 1,135 | 63 | 671 | 43 | 0 | 1 | 1970-01-01T00:24:35 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,659 | thundernest/k-9/1687/1666 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/1666 | https://github.com/thundernest/k-9/pull/1687 | https://github.com/thundernest/k-9/pull/1687 | 1 | fix | Switching from dark to light theme (or vise versa) inside message doesn't work | ### Expected behavior
When `fixed message theme` option is disabled, switching the theme when viewing a message should switch the theme immediately.
### Actual behavior
After switching the theme inside the message, the message view reloads but the theme stays the same. I need to leave the message and open it again to... | c7b5a506360089630aac685aa050ff2924501db1 | 22e8f4cedb71dbd85b40bdf5ceb665ec549d9262 | https://github.com/thundernest/k-9/compare/c7b5a506360089630aac685aa050ff2924501db1...22e8f4cedb71dbd85b40bdf5ceb665ec549d9262 | diff --git a/k9mail/src/main/java/com/fsck/k9/activity/MessageLoaderHelper.java b/k9mail/src/main/java/com/fsck/k9/activity/MessageLoaderHelper.java
index c6be46a1d..d29b79181 100644
--- a/k9mail/src/main/java/com/fsck/k9/activity/MessageLoaderHelper.java
+++ b/k9mail/src/main/java/com/fsck/k9/activity/MessageLoaderHel... | ['k9mail/src/main/java/com/fsck/k9/activity/MessageLoaderHelper.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,537,988 | 707,124 | 97,651 | 433 | 40 | 7 | 2 | 1 | 597 | 100 | 144 | 15 | 0 | 0 | 1970-01-01T00:24:35 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,660 | thundernest/k-9/1678/1625 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/1625 | https://github.com/thundernest/k-9/pull/1678 | https://github.com/thundernest/k-9/pull/1678 | 1 | fixes | Wrong order for multipart/alternative children | We create `multipart/alternative` parts with a `text/html` part as first child and `text/plain` as second child. This isn't what other clients do. And it seems to confuse Thunderbird which then only displays the `text/plain` part.
Affected version: 5.111
| dbb6cc4d887058a1318ce872fbc29e0e00eb7043 | 0cd52bc26b1c1f34d569d7370216b81b9369bbb4 | https://github.com/thundernest/k-9/compare/dbb6cc4d887058a1318ce872fbc29e0e00eb7043...0cd52bc26b1c1f34d569d7370216b81b9369bbb4 | diff --git a/k9mail/src/main/java/com/fsck/k9/message/MessageBuilder.java b/k9mail/src/main/java/com/fsck/k9/message/MessageBuilder.java
index 775513aed..3c365fcd1 100644
--- a/k9mail/src/main/java/com/fsck/k9/message/MessageBuilder.java
+++ b/k9mail/src/main/java/com/fsck/k9/message/MessageBuilder.java
@@ -152,10 +152... | ['k9mail/src/test/java/com/fsck/k9/message/MessageBuilderTest.java', 'k9mail/src/main/java/com/fsck/k9/message/MessageBuilder.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 3,536,841 | 706,845 | 97,622 | 433 | 422 | 86 | 5 | 1 | 256 | 38 | 61 | 4 | 0 | 0 | 1970-01-01T00:24:35 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,661 | thundernest/k-9/1608/1607 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/1607 | https://github.com/thundernest/k-9/pull/1608 | https://github.com/thundernest/k-9/pull/1608 | 1 | fixes | Composer crashes when an invalid mail address is about to be shown in recipient selector | ### Steps to reproduce
1. create a contact with a name and an invalid mail address, e. g. "(none)"
2. click '+' to compose new message
3. type first letters of the contact name until it should be shown
### Logcat
```
09-09 22:12:26.740 10531 10531 E AndroidRuntime: FATAL EXCEPTION: main
09-09 22:12:26.740 10531 10531 ... | 82f5fc6b30947894054c099d0c841e9d0cc80794 | 192ce7e7700f34f75d92e2c7f40f9a281087dd20 | https://github.com/thundernest/k-9/compare/82f5fc6b30947894054c099d0c841e9d0cc80794...192ce7e7700f34f75d92e2c7f40f9a281087dd20 | diff --git a/k9mail/src/main/java/com/fsck/k9/activity/compose/RecipientLoader.java b/k9mail/src/main/java/com/fsck/k9/activity/compose/RecipientLoader.java
index bd359924f..60df445fd 100644
--- a/k9mail/src/main/java/com/fsck/k9/activity/compose/RecipientLoader.java
+++ b/k9mail/src/main/java/com/fsck/k9/activity/comp... | ['k9mail/src/main/java/com/fsck/k9/view/RecipientSelectView.java', 'k9mail/src/main/java/com/fsck/k9/activity/compose/RecipientLoader.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 3,526,875 | 702,474 | 97,599 | 433 | 698 | 122 | 14 | 2 | 3,805 | 291 | 1,156 | 44 | 0 | 1 | 1970-01-01T00:24:33 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,662 | thundernest/k-9/1584/1582 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/1582 | https://github.com/thundernest/k-9/pull/1584 | https://github.com/thundernest/k-9/pull/1584 | 1 | fixes | Crash while moving message | Reported via Google Play:
```
java.lang.RuntimeException: Failure delivering result ResultInfo{who=android:fragment:1, request=1, result=-1, data=Intent { (has extras) }} to activity {com.fsck.k9/com.fsck.k9.activity.MessageList}: java.lang.IllegalStateException: got an activity result that wasn't meant for us. this i... | 4e7f93c3e3657921293d4615c49f5f5f54d9b985 | 5a1776890e26c73fe267ca857f6596996e1dc76d | https://github.com/thundernest/k-9/compare/4e7f93c3e3657921293d4615c49f5f5f54d9b985...5a1776890e26c73fe267ca857f6596996e1dc76d | diff --git a/k9mail/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.java b/k9mail/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.java
index 0616ccaa4..996b222c2 100644
--- a/k9mail/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.java
+++ b/k9mail/src/main/java/com/fsck/k9/ui/mess... | ['k9mail/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,526,740 | 702,446 | 97,598 | 433 | 1,511 | 264 | 29 | 1 | 1,969 | 149 | 453 | 30 | 0 | 1 | 1970-01-01T00:24:32 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,663 | thundernest/k-9/1537/819 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/819 | https://github.com/thundernest/k-9/pull/1537 | https://github.com/thundernest/k-9/pull/1537 | 1 | fix | forward a mail with attachment failed | ### Actual behaviour
there's two cases:
1.get a mail with inline images
2.get a mail with attachment
Two mail has been down fully in my k9 client.
When forward,both toast:"Some attachments cannot be forwarded because they have not been downloaded.".
If ignore this error to forward,the inline images or attachment ... | 81468ac2b34d2b670ea74e2186424fcd06d3c513 | d276bbda3ea65284487d92caa3577db0dd5ae1e6 | https://github.com/thundernest/k-9/compare/81468ac2b34d2b670ea74e2186424fcd06d3c513...d276bbda3ea65284487d92caa3577db0dd5ae1e6 | diff --git a/k9mail/src/main/java/com/fsck/k9/activity/MessageCompose.java b/k9mail/src/main/java/com/fsck/k9/activity/MessageCompose.java
index 563d9cc96..c40ce1622 100644
--- a/k9mail/src/main/java/com/fsck/k9/activity/MessageCompose.java
+++ b/k9mail/src/main/java/com/fsck/k9/activity/MessageCompose.java
@@ -1276,7 ... | ['k9mail/src/main/java/com/fsck/k9/ui/messageview/AttachmentController.java', 'k9mail/src/main/java/com/fsck/k9/activity/compose/AttachmentPresenter.java', 'k9mail/src/main/java/com/fsck/k9/activity/MessageCompose.java', 'k9mail/src/test/java/com/fsck/k9/mailstore/AttachmentResolverTest.java', 'k9mail/src/main/java/com... | {'.java': 7} | 7 | 7 | 0 | 0 | 7 | 3,529,396 | 703,410 | 97,677 | 430 | 4,835 | 935 | 109 | 5 | 867 | 135 | 200 | 29 | 0 | 0 | 1970-01-01T00:24:30 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,664 | thundernest/k-9/1536/1495 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/1495 | https://github.com/thundernest/k-9/pull/1536 | https://github.com/thundernest/k-9/pull/1536 | 1 | fixes | "To" field does not convert typed email addresses to tokens on send | ### Expected behavior
Autocomplete address field "To" should convert typed email addresses to tokens when clicking send
### Actual behavior
It does not, shows "Recipient field contains incomplete input!"
### Steps to reproduce
1. compose mail
2. write body subject and in the last step write email address into "To" fi... | 81468ac2b34d2b670ea74e2186424fcd06d3c513 | b3f2974962df4789331578f1afdeef3baef5f311 | https://github.com/thundernest/k-9/compare/81468ac2b34d2b670ea74e2186424fcd06d3c513...b3f2974962df4789331578f1afdeef3baef5f311 | diff --git a/k9mail/src/main/java/com/fsck/k9/activity/compose/RecipientMvpView.java b/k9mail/src/main/java/com/fsck/k9/activity/compose/RecipientMvpView.java
index a8889a388..cb04bb62e 100644
--- a/k9mail/src/main/java/com/fsck/k9/activity/compose/RecipientMvpView.java
+++ b/k9mail/src/main/java/com/fsck/k9/activity/c... | ['k9mail/src/main/java/com/fsck/k9/activity/compose/RecipientPresenter.java', 'k9mail/src/main/java/com/fsck/k9/view/RecipientSelectView.java', 'k9mail/src/main/java/com/fsck/k9/activity/compose/RecipientMvpView.java'] | {'.java': 3} | 3 | 3 | 0 | 0 | 3 | 3,529,396 | 703,410 | 97,677 | 430 | 1,049 | 198 | 34 | 3 | 502 | 77 | 118 | 18 | 0 | 0 | 1970-01-01T00:24:30 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,665 | thundernest/k-9/1262/1250 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/1250 | https://github.com/thundernest/k-9/pull/1262 | https://github.com/thundernest/k-9/pull/1262 | 1 | fixes | Reply flag is not set anymore when replying to a mail | ### Expected behaviour
Reply flag is set when replying to a mail.
### Actual behaviour
When replying to a mail I do not see a reply flag for the original mail I replied to. When checking the account with a different client (web/Thunderbird) I do not see a flag, too. So it is no frontend bug, the flag is not set anymo... | f794cc1f896a9755c535370c8527c49be88ed2f1 | 7f724e9e04a4df93362712ac894ef757025981f3 | https://github.com/thundernest/k-9/compare/f794cc1f896a9755c535370c8527c49be88ed2f1...7f724e9e04a4df93362712ac894ef757025981f3 | diff --git a/k9mail/src/main/java/com/fsck/k9/activity/MessageCompose.java b/k9mail/src/main/java/com/fsck/k9/activity/MessageCompose.java
index cd7cde46f..5072c6e5f 100644
--- a/k9mail/src/main/java/com/fsck/k9/activity/MessageCompose.java
+++ b/k9mail/src/main/java/com/fsck/k9/activity/MessageCompose.java
@@ -2454,18... | ['k9mail/src/main/java/com/fsck/k9/activity/MessageCompose.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,421,870 | 682,236 | 94,810 | 409 | 1,979 | 328 | 40 | 1 | 498 | 87 | 133 | 18 | 0 | 0 | 1970-01-01T00:24:19 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,666 | thundernest/k-9/1247/1227 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/1227 | https://github.com/thundernest/k-9/pull/1247 | https://github.com/thundernest/k-9/pull/1247 | 1 | fixes | Crash on screen rotate with OpenPGP handled message | ### Expected behaviour
Message should be re-rendered in landscape.
### Actual behaviour
Application crashes with following exception.
```
03-29 08:40:55.041 12045-12045/com.fsck.k9.debug E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.fsck.k9.de... | 74c6e764338d312dab49bb6e5499ee82d2c86c83 | fd89879f384c0d3e55d9ab98f9401ea98247c225 | https://github.com/thundernest/k-9/compare/74c6e764338d312dab49bb6e5499ee82d2c86c83...fd89879f384c0d3e55d9ab98f9401ea98247c225 | diff --git a/k9mail/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.java b/k9mail/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.java
index fccf71fd9..bd535fa89 100644
--- a/k9mail/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.java
+++ b/k9mail/src/main/java/com/fsck/k9/ui/mess... | ['k9mail/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,420,444 | 681,947 | 94,777 | 409 | 71 | 14 | 1 | 1 | 3,543 | 117 | 548 | 45 | 0 | 1 | 1970-01-01T00:24:19 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,667 | thundernest/k-9/1233/615 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/615 | https://github.com/thundernest/k-9/pull/1233 | https://github.com/thundernest/k-9/pull/1233 | 1 | fixes | Account listed multiple times | I have three email accounts, which were before listed like this:
```
AccountA
AccountB
AccountC
```
After long-pressing the last account and choosing "Move up", I got two copies of the account that I tried to move, like this:
```
AccountA
AccountC
AccountB
AccountC
```
This state persisted after restarting the app ... | e738e4b28dd92bc74efed0d239c355c8a34447f2 | 9284243fb47ca5eca19fdc65bde20d395bebdfdf | https://github.com/thundernest/k-9/compare/e738e4b28dd92bc74efed0d239c355c8a34447f2...9284243fb47ca5eca19fdc65bde20d395bebdfdf | diff --git a/k9mail/src/main/java/com/fsck/k9/Preferences.java b/k9mail/src/main/java/com/fsck/k9/Preferences.java
index 05b839c5f..dcfc6bba8 100644
--- a/k9mail/src/main/java/com/fsck/k9/Preferences.java
+++ b/k9mail/src/main/java/com/fsck/k9/Preferences.java
@@ -61,7 +61,9 @@ public class Preferences {
}
... | ['k9mail/src/main/java/com/fsck/k9/Preferences.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,421,580 | 682,184 | 94,805 | 409 | 168 | 29 | 4 | 1 | 666 | 114 | 170 | 23 | 0 | 2 | 1970-01-01T00:24:19 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,657 | thundernest/k-9/1704/1699 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/1699 | https://github.com/thundernest/k-9/pull/1704 | https://github.com/thundernest/k-9/pull/1704 | 1 | fixes | NPE in k9 and empty list when querying messages from 3rd party application (Gadgetbridge) | ### Expected behavior
We should get a list of messages
### Actual behavior
We get an empty list and k9 logs a NPE
`
java.lang.NullPointerException: Attempt to invoke virtual method 'com.fsck.k9.Account com.fsck.k9.mailstore.LocalMessage.getAccount()' on a null object re... | 54bf6f7bd548a0c7502a9149f942cfad63494e57 | dae6be34dfa2c21472ce007c3b6815e1e3693e9f | https://github.com/thundernest/k-9/compare/54bf6f7bd548a0c7502a9149f942cfad63494e57...dae6be34dfa2c21472ce007c3b6815e1e3693e9f | diff --git a/k9mail/src/main/java/com/fsck/k9/provider/MessageProvider.java b/k9mail/src/main/java/com/fsck/k9/provider/MessageProvider.java
index 760dc0660..20e2e3e3c 100644
--- a/k9mail/src/main/java/com/fsck/k9/provider/MessageProvider.java
+++ b/k9mail/src/main/java/com/fsck/k9/provider/MessageProvider.java
@@ -935... | ['k9mail/src/main/java/com/fsck/k9/provider/MessageProvider.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,539,944 | 707,545 | 97,696 | 433 | 157 | 21 | 2 | 1 | 2,420 | 102 | 430 | 39 | 0 | 0 | 1970-01-01T00:24:36 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,644 | thundernest/k-9/2777/2776 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/2776 | https://github.com/thundernest/k-9/pull/2777 | https://github.com/thundernest/k-9/pull/2777 | 1 | fixes | S/MIME signed emails in sent folder misleadingly shown as PGP encrypted mails | ### Expected behavior
I am using S/MIME to sign e-mails on my computer. When I open sent mails in k9 mail app on my smartphone the mail body is shown correctly, I can read the sent message, because it is just signed. I also see the attachment (signature file" smime.p7s") there.
### Actual behavior
Since last... | e266547bfc6db2f7af1dc84a07e954e20636adec | ac628a265daa6583bbe0c425163db5697a9b527e | https://github.com/thundernest/k-9/compare/e266547bfc6db2f7af1dc84a07e954e20636adec...ac628a265daa6583bbe0c425163db5697a9b527e | diff --git a/k9mail/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java b/k9mail/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java
index 974811957..cd8bd7034 100644
--- a/k9mail/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java
+++ b/k9mail/src/main/java/com/fsck/k... | ['k9mail/src/main/java/com/fsck/k9/mailstore/MessageViewInfoExtractor.java', 'k9mail/src/main/java/com/fsck/k9/mailstore/MessageViewInfo.java', 'k9mail/src/main/java/com/fsck/k9/ui/crypto/MessageCryptoAnnotations.java', 'k9mail/src/main/java/com/fsck/k9/ui/crypto/MessageCryptoSplitter.java', 'k9mail/src/main/java/com/f... | {'.java': 7} | 7 | 7 | 0 | 0 | 7 | 3,587,196 | 705,508 | 98,663 | 483 | 9,508 | 1,743 | 177 | 5 | 1,017 | 172 | 253 | 20 | 0 | 0 | 1970-01-01T00:25:05 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,581 | thundernest/k-9/5189/5187 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/5187 | https://github.com/thundernest/k-9/pull/5189 | https://github.com/thundernest/k-9/pull/5189 | 1 | fixes | Crash when editing outgoing server settings | **Describe the bug**
Ever since the [5.728](https://github.com/k9mail/k-9/releases/tag/5.728) update (with the long awaited [Add support for client certificate and password authentication](https://github.com/k9mail/k-9/issues/793#event-4298863970)) change, K-9 crashes when trying to send email over a (TLS-enabled) SMT... | 51e25a0bddb140d1f8ad9c3afbd03c70967ea488 | 3002964f0ae796b97a2b3418cb5e1635016cd21f | https://github.com/thundernest/k-9/compare/51e25a0bddb140d1f8ad9c3afbd03c70967ea488...3002964f0ae796b97a2b3418cb5e1635016cd21f | diff --git a/app/ui/legacy/src/main/java/com/fsck/k9/activity/setup/AccountSetupOutgoing.java b/app/ui/legacy/src/main/java/com/fsck/k9/activity/setup/AccountSetupOutgoing.java
index 443c4f9f8..e1c021243 100644
--- a/app/ui/legacy/src/main/java/com/fsck/k9/activity/setup/AccountSetupOutgoing.java
+++ b/app/ui/legacy/sr... | ['app/ui/legacy/src/main/java/com/fsck/k9/activity/setup/AccountSetupOutgoing.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 2,539,062 | 502,020 | 70,866 | 403 | 180 | 36 | 5 | 1 | 5,966 | 633 | 1,883 | 76 | 3 | 2 | 1970-01-01T00:26:54 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,652 | thundernest/k-9/1955/1915 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/1915 | https://github.com/thundernest/k-9/pull/1955 | https://github.com/thundernest/k-9/pull/1955 | 1 | fixes | message subject no longer shown on message view | ### Expected behavior
the message subject should be shown in the message view
### Actual behavior
the message view no longer shows the message subject
### Steps to reproduce
1. open a message
2. try to read the message subject in the message view
### Environment
K-9 Mail version: 5.201
Android version:... | a56f12f1bef60cee0f94be879ed2b7a0b27e65c6 | 10a252e6b99cc089fbdc6e0ee2dc3d00ec6bd24a | https://github.com/thundernest/k-9/compare/a56f12f1bef60cee0f94be879ed2b7a0b27e65c6...10a252e6b99cc089fbdc6e0ee2dc3d00ec6bd24a | diff --git a/k9mail/src/main/java/com/fsck/k9/activity/MessageList.java b/k9mail/src/main/java/com/fsck/k9/activity/MessageList.java
index c0a6098a6..65cf011b4 100644
--- a/k9mail/src/main/java/com/fsck/k9/activity/MessageList.java
+++ b/k9mail/src/main/java/com/fsck/k9/activity/MessageList.java
@@ -1435,6 +1435,8 @@ p... | ['k9mail/src/main/java/com/fsck/k9/activity/MessageList.java', 'k9mail/src/main/java/com/fsck/k9/view/MessageTitleView.java'] | {'.java': 2} | 2 | 2 | 0 | 0 | 2 | 3,453,031 | 685,304 | 94,469 | 422 | 273 | 48 | 8 | 2 | 380 | 59 | 95 | 17 | 0 | 0 | 1970-01-01T00:24:43 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,595 | thundernest/k-9/4994/3767 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/3767 | https://github.com/thundernest/k-9/pull/4994 | https://github.com/thundernest/k-9/pull/4994 | 1 | closes | There is an archive entry in the context entry of the mail in the archive | Please search to check for an existing issue (including closed issues, for which the fix may not have yet been released) before opening a new issue: https://github.com/k9mail/k-9/issues?q=is%3Aissue
### Expected behavior
When I move my mail to the archive, the item to keep in spite of the archive is registered in t... | 8685da31d44ba2d5623c2f05531af728e53699a2 | 617dd1641ec6cfff9e48e41122f873a0a6f0a3cc | https://github.com/thundernest/k-9/compare/8685da31d44ba2d5623c2f05531af728e53699a2...617dd1641ec6cfff9e48e41122f873a0a6f0a3cc | diff --git a/app/ui/legacy/src/main/java/com/fsck/k9/fragment/MessageListFragment.java b/app/ui/legacy/src/main/java/com/fsck/k9/fragment/MessageListFragment.java
index 54affea70..f480bab24 100644
--- a/app/ui/legacy/src/main/java/com/fsck/k9/fragment/MessageListFragment.java
+++ b/app/ui/legacy/src/main/java/com/fsck/... | ['app/ui/legacy/src/main/java/com/fsck/k9/fragment/MessageListFragment.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 2,734,879 | 539,277 | 76,391 | 416 | 634 | 118 | 10 | 1 | 620 | 94 | 151 | 18 | 1 | 0 | 1970-01-01T00:26:42 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,653 | thundernest/k-9/1954/1938 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/1938 | https://github.com/thundernest/k-9/pull/1954 | https://github.com/thundernest/k-9/pull/1954 | 1 | fixes | BCC not working as expected | ### Expected behavior
I wrote the mail with BBC on my Android 6.0.1.
So other people from CC shouldn't know that there are e-mail on BBC
### Actual behavior
All were able to read that there was bbc
### Steps to reproduce
1. Write mail with BBC
2. See their smiling faces when they discovers that boss e-mail i... | b516af2af0e9d1161c3eea8b31a2d55c28d96e98 | 4323ca3419a149b7a1693d16a9abae4a77db87b9 | https://github.com/thundernest/k-9/compare/b516af2af0e9d1161c3eea8b31a2d55c28d96e98...4323ca3419a149b7a1693d16a9abae4a77db87b9 | diff --git a/k9mail/src/main/java/com/fsck/k9/mailstore/LocalMessage.java b/k9mail/src/main/java/com/fsck/k9/mailstore/LocalMessage.java
index 8b1ce0ee7..c739a88a4 100644
--- a/k9mail/src/main/java/com/fsck/k9/mailstore/LocalMessage.java
+++ b/k9mail/src/main/java/com/fsck/k9/mailstore/LocalMessage.java
@@ -2,6 +2,8 @@... | ['k9mail/src/main/java/com/fsck/k9/mailstore/LocalMessage.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,453,516 | 685,396 | 94,488 | 422 | 1,741 | 354 | 56 | 1 | 474 | 79 | 126 | 18 | 0 | 0 | 1970-01-01T00:24:43 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,635 | thundernest/k-9/3219/632 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/632 | https://github.com/thundernest/k-9/pull/3219 | https://github.com/thundernest/k-9/pull/3219 | 1 | fixes | Case sensitivity problem in account>folders settings | I have an IMAP account with two directories, one named "Spam", and other named "spam".
In K9Mail I go to Account Preferences, Folders, Spam folder, and try to choose the lower case "spam".
After that, marking a message as spam, K9Mail will still move it to the "Spam" folder, instead of "spam".
I suppose the problem ... | ddc048b56b647c35e066b4255c0982ae80e065f3 | 95b046bbf6057dcff124be4dfcc0b6281f8e0aa5 | https://github.com/thundernest/k-9/compare/ddc048b56b647c35e066b4255c0982ae80e065f3...95b046bbf6057dcff124be4dfcc0b6281f8e0aa5 | diff --git a/k9mail-library/src/main/java/com/fsck/k9/mail/store/imap/ImapFolder.java b/k9mail-library/src/main/java/com/fsck/k9/mail/store/imap/ImapFolder.java
index 14cec2a31..f80e58c05 100644
--- a/k9mail-library/src/main/java/com/fsck/k9/mail/store/imap/ImapFolder.java
+++ b/k9mail-library/src/main/java/com/fsck/k9... | ['k9mail-library/src/main/java/com/fsck/k9/mail/store/pop3/Pop3Store.java', 'k9mail/src/main/java/com/fsck/k9/activity/ActivityListener.java', 'k9mail-library/src/main/java/com/fsck/k9/mail/store/imap/ImapFolder.java', 'k9mail/src/main/java/com/fsck/k9/activity/ChooseFolder.java', 'k9mail/src/main/java/com/fsck/k9/noti... | {'.java': 15} | 15 | 15 | 0 | 0 | 15 | 3,644,613 | 714,329 | 99,963 | 501 | 4,712 | 945 | 73 | 13 | 341 | 59 | 85 | 8 | 0 | 0 | 1970-01-01T00:25:19 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,634 | thundernest/k-9/3292/3289 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/3289 | https://github.com/thundernest/k-9/pull/3292 | https://github.com/thundernest/k-9/pull/3292 | 1 | fixes | selecting key from openkeychain fails | k-9 does not accept the cryptographic key from openkeychain.
The key has been created newly by openkeychain using plain defaults from the
wizzard, except for uploading to the internet being off (as these are tests
yet only).
Steps in detail:
In k-9, after selecting the key from the list, the app takes a shor... | 5e1291344bf061a5ff0d5609ba28ef25746f4f88 | 44d1a1a454621f968689e90bcb274e7cf901e102 | https://github.com/thundernest/k-9/compare/5e1291344bf061a5ff0d5609ba28ef25746f4f88...44d1a1a454621f968689e90bcb274e7cf901e102 | diff --git a/plugins/openpgp-api-lib/openpgp-api/src/main/java/org/openintents/openpgp/util/OpenPgpKeyPreference.java b/plugins/openpgp-api-lib/openpgp-api/src/main/java/org/openintents/openpgp/util/OpenPgpKeyPreference.java
index 15eb44693..dd4b5373d 100644
--- a/plugins/openpgp-api-lib/openpgp-api/src/main/java/org/o... | ['plugins/openpgp-api-lib/openpgp-api/src/main/java/org/openintents/openpgp/util/OpenPgpKeyPreference.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 3,641,038 | 712,930 | 99,690 | 493 | 529 | 95 | 17 | 1 | 724 | 122 | 188 | 20 | 0 | 0 | 1970-01-01T00:25:22 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,589 | thundernest/k-9/5078/5077 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/5077 | https://github.com/thundernest/k-9/pull/5078 | https://github.com/thundernest/k-9/pull/5078 | 1 | fixes | Crash due to Parcelable problem | Crash when restoring AccountSetupBasics instance state
Steps to reproduce the behavior:
1. In developer options: enable don't keep activities" to easily reproduce the bug
2. Go to AccountSetupBasics activity
3. Click home button to quit the app
4. Use recent app to go back to K9
5. The app crash
**Environmen... | f03f962156df460dda4c86ec62b0c409cce31a3e | 1f65982263a2de884b97c6c9eb84110198289e6c | https://github.com/thundernest/k-9/compare/f03f962156df460dda4c86ec62b0c409cce31a3e...1f65982263a2de884b97c6c9eb84110198289e6c | diff --git a/app/ui/legacy/src/main/java/com/fsck/k9/view/FoldableLinearLayout.java b/app/ui/legacy/src/main/java/com/fsck/k9/view/FoldableLinearLayout.java
index 997167a64..5d0e84ae8 100644
--- a/app/ui/legacy/src/main/java/com/fsck/k9/view/FoldableLinearLayout.java
+++ b/app/ui/legacy/src/main/java/com/fsck/k9/view/F... | ['app/ui/legacy/src/main/java/com/fsck/k9/view/FoldableLinearLayout.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 2,576,377 | 509,280 | 71,963 | 412 | 247 | 46 | 4 | 1 | 1,804 | 126 | 418 | 35 | 0 | 0 | 1970-01-01T00:26:48 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
9,588 | thundernest/k-9/5079/5063 | thundernest | k-9 | https://github.com/thundernest/k-9/issues/5063 | https://github.com/thundernest/k-9/pull/5079 | https://github.com/thundernest/k-9/pull/5079 | 1 | fixes | Read messages keep changing status back to unread | > Sounds like the "mark as read" commands either fail or are stuck in the local command queue and never sent to the server.
Having the same problem with k9 5.724 and an IMAP account. Accidently I tried to move mails to a mail folder which is a directory on the server and can therefore not store any mails. This move ... | 938a2654646ea40f17e760a22e5d2f01a62b962f | 7ae88bb61d417fc6141a5be07bd017b4f3cbe93a | https://github.com/thundernest/k-9/compare/938a2654646ea40f17e760a22e5d2f01a62b962f...7ae88bb61d417fc6141a5be07bd017b4f3cbe93a | diff --git a/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/FolderNotFoundException.java b/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/FolderNotFoundException.java
index 871b321a5..3b15551d7 100644
--- a/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/FolderNotFoundExcepti... | ['mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/FolderNotFoundException.java'] | {'.java': 1} | 1 | 1 | 0 | 0 | 1 | 2,575,629 | 509,141 | 71,938 | 412 | 115 | 28 | 2 | 1 | 682 | 99 | 167 | 9 | 2 | 0 | 1970-01-01T00:26:48 | 8,156 | Kotlin | {'Kotlin': 4058553, 'Java': 2375292, 'Shell': 7553, 'AIDL': 1946} | Apache License 2.0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.