File size: 7,479 Bytes
d99646e | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 | from sqlalchemy import create_engine
from sqlalchemy.orm import sessionmaker
from sqlalchemy.pool import StaticPool
from fastapi import HTTPException
from app import dependencies
from app.core.database import Base
from app.core.security import decode_access_token, verify_password
from app.models.department import Department
from app.models.user import User
from app.schemas.auth import LoginRequest, SignupRequest
from app.services.auth_service import (
authenticate_user,
build_token_response,
create_user,
)
def _make_session():
engine = create_engine(
"sqlite+pysqlite:///:memory:",
connect_args={"check_same_thread": False},
poolclass=StaticPool,
)
TestingSessionLocal = sessionmaker(autocommit=False, autoflush=False, bind=engine)
Base.metadata.create_all(bind=engine)
return engine, TestingSessionLocal()
def test_signup_creates_user_with_hashed_password():
engine, db = _make_session()
try:
user = create_user(
db,
SignupRequest(
email="student@example.com",
password="password123",
full_name="Student User",
department_name="Student",
),
)
assert user.id is not None
assert user.email == "student@example.com"
assert user.full_name == "Student User"
assert user.role == "STUDENT"
assert user.department_id is None
assert user.hashed_password != "password123"
assert verify_password("password123", user.hashed_password)
finally:
db.close()
Base.metadata.drop_all(bind=engine)
def test_signup_student_sets_student_role_without_department():
engine, db = _make_session()
try:
user = create_user(
db,
SignupRequest(
email="student2@example.com",
password="password123",
full_name="Student User",
department_name="Student",
),
)
assert user.role == "STUDENT"
assert user.department_id is None
finally:
db.close()
Base.metadata.drop_all(bind=engine)
def test_login_returns_access_token():
engine, db = _make_session()
try:
created_user = create_user(
db,
SignupRequest(
email="teacher@example.com",
password="password123",
full_name="Teacher User",
department_name="Student",
),
)
user = authenticate_user(
db,
LoginRequest(email="teacher@example.com", password="password123"),
)
token_response = build_token_response(user)
claims = decode_access_token(token_response.access_token)
assert user.id == created_user.id
assert token_response.token_type == "bearer"
assert claims["sub"] == str(created_user.id)
finally:
db.close()
Base.metadata.drop_all(bind=engine)
def test_signup_rejects_duplicate_email():
engine, db = _make_session()
try:
create_user(
db,
SignupRequest(
email="duplicate@example.com",
password="password123",
department_name="Student",
),
)
try:
create_user(
db,
SignupRequest(
email="duplicate@example.com",
password="password123",
department_name="Student",
),
)
raise AssertionError("Expected duplicate email to fail")
except ValueError as exc:
assert "already registered" in str(exc)
finally:
db.close()
Base.metadata.drop_all(bind=engine)
def test_signup_staff_sets_staff_role_and_department_id():
engine, db = _make_session()
try:
department = Department(
name="Examination Department",
code="EXAM",
description="Handles examinations",
keywords="exam, timetable, seating",
)
db.add(department)
db.commit()
db.refresh(department)
user = create_user(
db,
SignupRequest(
email="staff@example.com",
password="password123",
full_name="Exam Staff",
department_name="Examination Department",
),
)
assert user.role == "Examination Department"
assert user.department_id == department.id
finally:
db.close()
Base.metadata.drop_all(bind=engine)
def test_signup_response_includes_department_name_for_staff():
engine, db = _make_session()
try:
department = Department(
name="Finance Department",
code="FIN",
description="Handles finance",
keywords="finance, budget, fees",
)
db.add(department)
db.commit()
db.refresh(department)
user = create_user(
db,
SignupRequest(
email="finance.staff@example.com",
password="password123",
full_name="Finance Staff",
department_name="Finance Department",
),
)
token_response = build_token_response(user)
assert token_response.user.department_name == "Finance Department"
finally:
db.close()
Base.metadata.drop_all(bind=engine)
def test_signup_defaults_new_users_to_non_admin():
engine, db = _make_session()
try:
user = create_user(
db,
SignupRequest(
email="normal.user@example.com",
password="password123",
full_name="Normal User",
department_name="Student",
),
)
assert user.is_admin is False
finally:
db.close()
Base.metadata.drop_all(bind=engine)
def test_get_current_admin_user_returns_admin_user():
engine, db = _make_session()
try:
admin_user = User(
email="admin@example.com",
full_name="Admin User",
hashed_password="hashed",
role="ADMIN",
is_admin=True,
department_id=None,
)
db.add(admin_user)
db.commit()
db.refresh(admin_user)
current_admin = dependencies.get_current_admin_user(current_user=admin_user)
assert current_admin.id == admin_user.id
assert current_admin.is_admin is True
finally:
db.close()
Base.metadata.drop_all(bind=engine)
def test_get_current_admin_user_rejects_non_admin_user():
engine, db = _make_session()
try:
normal_user = User(
email="user@example.com",
full_name="Normal User",
hashed_password="hashed",
role="STUDENT",
is_admin=False,
department_id=None,
)
db.add(normal_user)
db.commit()
db.refresh(normal_user)
try:
dependencies.get_current_admin_user(current_user=normal_user)
raise AssertionError("Expected admin check to fail")
except HTTPException as exc:
assert exc.status_code == 403
assert "Admin access required" in str(exc.detail)
finally:
db.close()
Base.metadata.drop_all(bind=engine)
|