Spaces:
Running
Running
File size: 9,558 Bytes
a9fbc84 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 | import { beforeEach, describe, expect, it, vi } from "vitest";
const mockArgon2Verify = vi.fn();
const mockConsumeRateLimitPoint = vi.fn();
vi.mock("hash-wasm", () => ({
argon2Verify: (...args: unknown[]) => mockArgon2Verify(...args),
}));
vi.mock("./verifyTokenAndRateLimit", () => ({
consumeRateLimitPoint: (...args: unknown[]) =>
mockConsumeRateLimitPoint(...args),
}));
beforeEach(() => {
vi.clearAllMocks();
// Within budget by default; the rate-limited case opts out.
mockConsumeRateLimitPoint.mockResolvedValue(true);
});
function makeMockRequest(
url: string,
method: string,
body?: string,
): {
url: string | undefined;
method: string;
headers: Record<string, string>;
on: ReturnType<typeof vi.fn>;
endCallbacks: Array<() => void>;
} {
const endCallbacks: Array<() => void> = [];
const on = vi.fn((event: string, cb: (chunk: string) => void) => {
if (event === "data" && body) {
cb(body);
}
if (event === "end") {
endCallbacks.push(cb as () => void);
}
});
return { url, method, headers: {}, on, endCallbacks };
}
function makeMockResponse() {
const setHeader = vi.fn();
const end = vi.fn();
const statusCode = 200;
return { setHeader, end, statusCode };
}
/** Builds a well-formed argon2id hash string with the client's fixed parameters. */
function makeValidAccessKeyHash(suffix: string): string {
const salt = Buffer.from(`${suffix}salt`).toString("base64url");
const digest = Buffer.from(`${suffix}digest`).toString("base64url");
return `$argon2id$v=19$m=512,t=16,p=1$${salt}$${digest}`;
}
describe("validateAccessKeyServerHook", () => {
it("should skip non-matching URLs", async () => {
const { validateAccessKeyServerHook } = await import(
"./validateAccessKeyServerHook"
);
const use = vi.fn();
validateAccessKeyServerHook({
middlewares: { use },
} as never);
const handler = use.mock.calls[0][0] as (
req: { url: string; method: string },
res: unknown,
next: () => void,
) => void;
const next = vi.fn();
handler({ url: "/other", method: "POST" }, {}, next);
expect(next).toHaveBeenCalled();
});
it("should skip non-POST methods", async () => {
const { validateAccessKeyServerHook } = await import(
"./validateAccessKeyServerHook"
);
const use = vi.fn();
validateAccessKeyServerHook({
middlewares: { use },
} as never);
const handler = use.mock.calls[0][0] as (
req: { url: string; method: string },
res: unknown,
next: () => void,
) => void;
const next = vi.fn();
handler({ url: "/api/validate-access-key", method: "GET" }, {}, next);
expect(next).toHaveBeenCalled();
});
it("should return valid: true for a matching access key", async () => {
process.env.ACCESS_KEYS = "test-key";
mockArgon2Verify.mockResolvedValue(true);
const { validateAccessKeyServerHook } = await import(
"./validateAccessKeyServerHook"
);
const use = vi.fn();
validateAccessKeyServerHook({
middlewares: { use },
} as never);
const handler = use.mock.calls[0][0] as (
req: {
url: string;
method: string;
on: (event: string, cb: (chunk: string) => void) => void;
},
res: {
setHeader: ReturnType<typeof vi.fn>;
end: ReturnType<typeof vi.fn>;
},
next: () => void,
) => void;
const res = makeMockResponse();
const req = makeMockRequest(
"/api/validate-access-key",
"POST",
JSON.stringify({ accessKeyHash: makeValidAccessKeyHash("valid") }),
);
await new Promise<void>((resolve) => {
void handler(req as never, res as never, () => {});
// The handler consumes a rate-limit point (async) before it registers its
// end listener, so trigger it on a later macrotask.
setImmediate(() => {
for (const cb of req.endCallbacks) {
cb();
}
setTimeout(resolve, 50);
});
});
expect(res.end).toHaveBeenCalledWith(JSON.stringify({ valid: true }));
// The request was within budget, so the limiter let it through.
expect(mockConsumeRateLimitPoint).toHaveBeenCalledTimes(1);
});
it("responds 429 and skips the argon2 loop when the limiter refuses", async () => {
process.env.ACCESS_KEYS = "test-key";
mockConsumeRateLimitPoint.mockResolvedValue(false);
const { validateAccessKeyServerHook } = await import(
"./validateAccessKeyServerHook"
);
const use = vi.fn();
validateAccessKeyServerHook({
middlewares: { use },
} as never);
const handler = use.mock.calls[0][0] as (
req: {
url: string;
method: string;
on: (event: string, cb: (chunk: string) => void) => void;
},
res: {
setHeader: ReturnType<typeof vi.fn>;
end: ReturnType<typeof vi.fn>;
statusCode: number;
},
next: () => void,
) => void;
const res = makeMockResponse();
const req = makeMockRequest(
"/api/validate-access-key",
"POST",
JSON.stringify({ accessKeyHash: makeValidAccessKeyHash("valid") }),
);
await new Promise<void>((resolve) => {
handler(req as never, res as never, () => {});
setTimeout(resolve, 50);
});
expect(res.statusCode).toBe(429);
expect(res.end).toHaveBeenCalledWith(
JSON.stringify({ error: "Too many requests." }),
);
// The limiter refused before the argon2 loop ran, so no key was verified.
expect(mockArgon2Verify).not.toHaveBeenCalled();
});
it("should return valid: false when no access keys match", async () => {
process.env.ACCESS_KEYS = "test-key";
mockArgon2Verify.mockResolvedValue(false);
const { validateAccessKeyServerHook } = await import(
"./validateAccessKeyServerHook"
);
const use = vi.fn();
validateAccessKeyServerHook({
middlewares: { use },
} as never);
const handler = use.mock.calls[0][0] as (
req: {
url: string;
method: string;
on: (event: string, cb: (chunk: string) => void) => void;
},
res: {
setHeader: ReturnType<typeof vi.fn>;
end: ReturnType<typeof vi.fn>;
},
next: () => void,
) => void;
const res = makeMockResponse();
const req = makeMockRequest(
"/api/validate-access-key",
"POST",
JSON.stringify({ accessKeyHash: makeValidAccessKeyHash("wrong") }),
);
await new Promise<void>((resolve) => {
void handler(req as never, res as never, () => {});
setImmediate(() => {
for (const cb of req.endCallbacks) {
cb();
}
setTimeout(resolve, 50);
});
});
expect(res.end).toHaveBeenCalledWith(JSON.stringify({ valid: false }));
});
it("refuses a hash whose parameter block differs from the client's before argon2Verify runs", async () => {
process.env.ACCESS_KEYS = "test-key";
const { validateAccessKeyServerHook } = await import(
"./validateAccessKeyServerHook"
);
const use = vi.fn();
validateAccessKeyServerHook({
middlewares: { use },
} as never);
const handler = use.mock.calls[0][0] as (
req: {
url: string;
method: string;
on: (event: string, cb: (chunk: string) => void) => void;
},
res: {
setHeader: ReturnType<typeof vi.fn>;
end: ReturnType<typeof vi.fn>;
statusCode: number;
},
next: () => void,
) => void;
const res = makeMockResponse();
// A hash with inflated parameters: m=4194304 would force a multi-gigabyte
// allocation if argon2Verify ever saw it.
const malicious =
"$argon2id$v=19$m=4194304,t=1000,p=1$xJaao6+z/VEA4+CU/+LAKg$JCE6vg7EHYLNv+EfNk1R6oJsEoDOsv2zNAXzQrrvI0E";
const req = makeMockRequest(
"/api/validate-access-key",
"POST",
JSON.stringify({ accessKeyHash: malicious }),
);
await new Promise<void>((resolve) => {
void handler(req as never, res as never, () => {});
setImmediate(() => {
for (const cb of req.endCallbacks) {
cb();
}
setTimeout(resolve, 50);
});
});
expect(res.end).toHaveBeenCalledWith(JSON.stringify({ valid: false }));
expect(mockArgon2Verify).not.toHaveBeenCalled();
});
it("should return 400 for invalid JSON body", async () => {
process.env.ACCESS_KEYS = "test-key";
const { validateAccessKeyServerHook } = await import(
"./validateAccessKeyServerHook"
);
const use = vi.fn();
validateAccessKeyServerHook({
middlewares: { use },
} as never);
const handler = use.mock.calls[0][0] as (
req: {
url: string;
method: string;
on: (event: string, cb: (chunk: string) => void) => void;
},
res: {
setHeader: ReturnType<typeof vi.fn>;
end: ReturnType<typeof vi.fn>;
statusCode: { value: number };
},
next: () => void,
) => void;
const res = makeMockResponse();
const req = makeMockRequest("/api/validate-access-key", "POST", "not-json");
await new Promise<void>((resolve) => {
void handler(req as never, res as never, () => {});
setImmediate(() => {
for (const cb of req.endCallbacks) {
cb();
}
setTimeout(resolve, 50);
});
});
expect(res.statusCode).toBe(400);
expect(res.end).toHaveBeenCalledWith(
JSON.stringify({ valid: false, error: "Invalid request" }),
);
});
});
|