verify.py v0.3: pre-fix missing tests count as failing (upstream semantics), record all cmd lists

scripts/verify.py

@@ -1,9 +1,10 @@
-"""PatchBench row verification + context expansion harness (v0.2).
+"""PatchBench row verification + context expansion harness (v0.3).
 
 For each candidate row:
   1. clone the repo at base_commit
   2. apply test_patch -> run rebuild_cmds -> run test_cmds (twice) -> parse per-test results
-     verify: every FAIL_TO_PASS test FAILS in both pre-fix runs
+     verify: every FAIL_TO_PASS test FAILS pre-fix in both runs (a test that does not
+     exist because its package fails to build counts as failing -- upstream semantics)
   3. apply gold_patch -> rebuild -> run test_cmds (twice) -> parse
      verify: every FAIL_TO_PASS PASSES and every PASS_TO_PASS still PASSES in both runs
   4. slice a 500-1500 line context window around the buggy files
@@ -11,7 +12,8 @@ For each candidate row:
 
 Native (non-Docker) reproduction of the upstream env: toolchain dirs are prepended
 to PATH per language, and the upstream /testbed convention is rewritten to the
-local checkout path.
+local checkout path. Toolchain image must satisfy the repos' go.mod/tool requirements
+(use golang:1.25+ for Go rows).
 
 Usage (inside a job with the right language toolchain image):
   python verify.py --lang go --file pilot/candidates/go.jsonl --limit 6
@@ -24,7 +26,6 @@ CMD_TIMEOUT_S = 2100
 GIT_TIMEOUT_S = 900
 MAX_CONTEXT_LINES = 1500
 
-# toolchain dirs that login-shell /etc/profile resets away, or that images install off-PATH
 LANG_PATH_PREPEND = {
     "go": ["/usr/local/go/bin"],
     "rust": ["/usr/local/cargo/bin", "/usr/local/rustup/bin"],
@@ -99,12 +100,15 @@ def run_tests(row, repo_dir):
     return parser(out), out[-3000:]
 
 
-def grade(tests, want, expect):
+def grade(tests, want, expect, allow_missing=False):
+    """allow_missing=True for pre-fix 'fail' checks: a test that never ran (build
+    failure in its package) is not passing, which is what upstream means by fail."""
     missing, wrong = [], []
     for t in want:
         s = tests.get(t)
         if s is None:
-            missing.append(t)
+            if not allow_missing:
+                missing.append(t)
         elif s != expect:
             wrong.append((t, s))
     return (not missing and not wrong), {"missing": len(missing), "wrong": wrong[:10],
@@ -178,13 +182,12 @@ def verify_row(row, lang):
             rec["error"] = f"checkout failed: {out[-500:]}"
             return rec
 
-    # native env fixes: toolchain PATH + /testbed convention
     os.environ["PATH"] = ":".join(LANG_PATH_PREPEND.get(lang, [])) + ":" + os.environ["PATH"]
     def tb(cmds):
         return [c.replace(TESTBED, repo_dir) for c in (cmds or [])]
     row = {**row, "test_cmds": tb(row["test_cmds"]), "rebuild_cmds": tb(row.get("rebuild_cmds")),
            "print_cmds": tb(row.get("print_cmds"))}
-    rec["test_cmds"] = row["test_cmds"]
+    rec["test_cmds"], rec["rebuild_cmds"], rec["print_cmds"] = row["test_cmds"], row["rebuild_cmds"], row["print_cmds"]
     rec["timing"]["setup"] = round(time.time() - t0, 1)
 
     # ---- PRE-FIX (twice) ----
@@ -199,8 +202,8 @@ def verify_row(row, lang):
         tests, tail = run_tests(row, repo_dir)
         pre_runs.append((tests, tail))
         rec["timing"][f"pre_test_{i}"] = round(time.time() - s, 1)
-    pre_detail = grade(pre_runs[0][0], row["fail_to_pass"], "fail")[1]
-    f2p_ok_pre = all(grade(t, row["fail_to_pass"], "fail")[0] for t, _ in pre_runs)
+    pre_detail = grade(pre_runs[0][0], row["fail_to_pass"], "fail", allow_missing=True)[1]
+    f2p_ok_pre = all(grade(t, row["fail_to_pass"], "fail", allow_missing=True)[0] for t, _ in pre_runs)
     rec["f2p_pre_ok"], rec["pre_detail"] = f2p_ok_pre, pre_detail
 
     # ---- POST-FIX (twice) ----