verify.py v0.5: P2P restricted to tests that pass pre-fix in this env (p2p_env_dropped recorded)

scripts/verify.py

@@ -1,4 +1,4 @@
-"""PatchBench row verification + context expansion harness (v0.4).
+"""PatchBench row verification + context expansion harness (v0.5).
 
 For each candidate row:
   1. clone the repo at base_commit
@@ -10,12 +10,16 @@ For each candidate row:
   4. slice a 500-1500 line context window around the buggy files
   5. write a result record; verified rows additionally carry the full patchbench schema
 
+P2P scoping: PASS_TO_PASS is evaluated over tests that PASS in BOTH pre-fix runs in
+this environment. Tests upstream lists in P2P that fail pre-fix here (e.g. tests
+needing docker/k8s) are recorded in p2p_env_dropped and excluded from grading --
+they are not evaluable natively, not regressions.
+
 Native (non-Docker) reproduction of the upstream env:
   - toolchain dirs are prepended to PATH per language
   - the upstream /testbed convention is rewritten to the local checkout path
   - after test_cmds, the harness cats reports/* (rows redirect `go test -json >
-    reports/<lang>-test-results.json` and upstream's harness reads that report
-    itself; the row's print_cmds list is often empty)
+    reports/<lang>-test-results.json`; the row's print_cmds list is often empty)
 
 Usage (inside a job with the right language toolchain image):
   python verify.py --lang go --file pilot/candidates/go.jsonl --limit 6
@@ -210,6 +214,12 @@ def verify_row(row, lang):
     f2p_ok_pre = all(grade(t, row["fail_to_pass"], "fail", allow_missing=True)[0] for t, _ in pre_runs)
     rec["f2p_pre_ok"], rec["pre_detail"] = f2p_ok_pre, pre_detail
 
+    # P2P scoped to this environment: keep only tests that pass in BOTH pre-fix runs
+    p2p_scoped = [t for t in row["pass_to_pass"]
+                  if pre_runs[0][0].get(t) == "pass" and pre_runs[1][0].get(t) == "pass"]
+    rec["p2p_env_dropped"] = [t for t in row["pass_to_pass"] if t not in set(p2p_scoped)]
+    rec["p2p_scoped_count"] = len(p2p_scoped)
+
     # ---- POST-FIX (twice) ----
     clean_state(repo_dir)
     err = apply_patch(row["test_patch"], repo_dir)
@@ -227,7 +237,7 @@ def verify_row(row, lang):
         post_runs.append((tests, tail))
         rec["timing"][f"post_test_{i}"] = round(time.time() - s, 1)
     f2p_ok_post = all(grade(t, row["fail_to_pass"], "pass")[0] for t, _ in post_runs)
-    p2p_ok_post = all(grade(t, row["pass_to_pass"], "pass")[0] for t, _ in post_runs)
+    p2p_ok_post = all(grade(t, p2p_scoped, "pass")[0] for t, _ in post_runs)
     rec["f2p_post_ok"], rec["p2p_post_ok"] = f2p_ok_post, p2p_ok_post
     rec["post_detail"] = grade(post_runs[0][0], row["fail_to_pass"], "pass")[1]