instance_id stringlengths 17 41 | org stringclasses 19
values | repo stringclasses 19
values | number int64 29 21.7k | state stringclasses 1
value | title stringlengths 9 118 | body stringlengths 10 5.5k | base unknown | resolved_issues unknown | lang stringclasses 4
values | problem_statement stringlengths 51 34.5k | hints stringlengths 1 65.8k ⌀ | pull_url stringlengths 40 64 | issue_urls unknown | test_command stringlengths 66 10.4k ⌀ | fix_patch stringlengths 365 784k | test_patch stringlengths 382 698k | n2p_tests unknown | f2p_tests unknown | p2p_tests unknown | s2p_tests unknown |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
commons-app__apps-android-commons-6324 | commons-app | apps-android-commons | 6,324 | closed | Fix infinite loading circular progress bar after nominating for deletion | **Description (required)**
Fixes #5531
What changes did you make and why?
Parneet fixed the issue in his PR #5610 by making changes in the `MediaDetailFragment.java` file. However, that file was migrated to `Kotlin` and caused merge conflicts. So, I pull from his branch, copy the changes to the migrated file an... | {
"label": "commons-app:main",
"ref": "main",
"sha": "5d7f42d127600f205773214bb877472f259ff552"
} | [
{
"number": 5531,
"title": "[Bug]: Circular Progress bar keeps on moving even though nomination for deletion is successful",
"body": "### Summary\n\nWhen the user clicks on 'Nominate for Deletion,' the circular progress bar keeps moving even though the nomination for deletion is successful. This doesn't... | kotlin | [Bug]: Circular Progress bar keeps on moving even though nomination for deletion is successful
### Summary
When the user clicks on 'Nominate for Deletion,' the circular progress bar keeps moving even though the nomination for deletion is successful. This doesn't provide any visible status and makes the user think that... | please assign #5531 @nicolas-raoul
Can I work on this @kanahia1 ?
Sure @neeldoshii, You can take it ! | https://github.com/commons-app/apps-android-commons/pull/6324 | [
"https://github.com/commons-app/apps-android-commons/issues/5531"
] | ./gradlew :app:testBetaDebugUnitTest --tests "fr.free.nrw.commons.delete.ReasonBuilderTest" | diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index 9c53155a77..2e391a24fd 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -347,6 +347,7 @@ dependencies {
// Kotlin + coroutines
implementation(libs.androidx.work.runtime.ktx)
implementation(libs.androidx.work.runtime)
+ imple... | diff --git a/app/src/test/kotlin/fr/free/nrw/commons/delete/ReasonBuilderTest.kt b/app/src/test/kotlin/fr/free/nrw/commons/delete/ReasonBuilderTest.kt
index e89a02dece..bd67475ee3 100644
--- a/app/src/test/kotlin/fr/free/nrw/commons/delete/ReasonBuilderTest.kt
+++ b/app/src/test/kotlin/fr/free/nrw/commons/delete/Reason... | {
"fr.free.nrw.commons.delete.ReasonBuilderTest.getReason": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
}
} | {
"fr.free.nrw.commons.delete.ReasonBuilderTest.forceLoginWhenAccountIsNull": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {} | {} |
element-hq__element-x-android-2374 | element-hq | element-x-android | 2,374 | closed | Typing notification rendering | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [x] Feature
- [ ] Bugfix
- [ ] Technical
- [ ] Other :
## Content
<!-- Describe shortly what has been changed -->
Render typing no... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "3a834393d118d1e3bf8030077ea95ca9c477def4"
} | [
{
"number": 2242,
"title": "[Task] Render typing notification",
"body": "Please see and discuss the details in the meta issue."
}
] | kotlin | [Task] Render typing notification
Please see and discuss the details in the meta issue.
| null | https://github.com/element-hq/element-x-android/pull/2374 | [
"https://github.com/element-hq/element-x-android/issues/2242"
] | ./gradlew :features:messages:impl:testDebugUnitTest --tests "io.element.android.features.messages.impl.typing.TypingNotificationPresenterTest" --tests "io.element.android.features.messages.impl.timeline.TimelineViewTest" --tests "io.element.android.features.messages.impl.MessagesPresenterTest" | diff --git a/changelog.d/2242.feature b/changelog.d/2242.feature
new file mode 100644
index 00000000000..947661653f0
--- /dev/null
+++ b/changelog.d/2242.feature
@@ -0,0 +1,1 @@
+Rendering typing notification
diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesPresenter... | diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesPresenterTest.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesPresenterTest.kt
index fe7e07e6f90..44dc96d8045 100644
--- a/features/messages/impl/src/test/kotlin/io/element... | {
"io.element.android.libraries.push.impl.notifications.NotificationRendererTest.given a simple notification is added when rendering then show the simple notification and update summary": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.textcomposer.impl.mentions.Mention... | {} | {
"io.element.android.libraries.mediapickers.PickerTypeTest.CameraVideo - assert types": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.mediapickers.PickerTypeTest.ImageAndVideo - assert types": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.elem... | {} |
element-hq__element-x-android-2437 | element-hq | element-x-android | 2,437 | closed | Show blocked users list | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [x] Feature
- [ ] Bugfix
- [ ] Technical
- [ ] Other :
## Content
- Add blocked users list item in the settings screen.
- Allow to... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "5939c6415889b96af327055ab74c939c07fd9370"
} | [
{
"number": 2418,
"title": "[Task] Show blocked users",
"body": "From element-x-ios created by [stefanceriu](https://github.com/stefanceriu): element-hq/element-x-ios#2486 \n\nPlease see and discuss the details in the meta issue."
}
] | kotlin | [Task] Show blocked users
From element-x-ios created by [stefanceriu](https://github.com/stefanceriu): element-hq/element-x-ios#2486
Please see and discuss the details in the meta issue.
| null | https://github.com/element-hq/element-x-android/pull/2437 | [
"https://github.com/element-hq/element-x-android/issues/2418"
] | ./gradlew :features:preferences:impl:testDebugUnitTest --tests "io.element.android.features.preferences.impl.blockedusers.BlockedUsersPresenterTests" :libraries:designsystem:testDebugUnitTest --tests "io.element.android.libraries.designsystem.component.async.AsyncIndicatorTests" | diff --git a/appnav/src/main/kotlin/io/element/android/appnav/loggedin/LoggedInView.kt b/appnav/src/main/kotlin/io/element/android/appnav/loggedin/LoggedInView.kt
index be9550d9906..74c71d387ca 100644
--- a/appnav/src/main/kotlin/io/element/android/appnav/loggedin/LoggedInView.kt
+++ b/appnav/src/main/kotlin/io/element... | diff --git a/features/preferences/impl/src/test/kotlin/io/element/android/features/preferences/impl/blockedusers/BlockedUsersPresenterTests.kt b/features/preferences/impl/src/test/kotlin/io/element/android/features/preferences/impl/blockedusers/BlockedUsersPresenterTests.kt
new file mode 100644
index 00000000000..3bcd7... | {
"io.element.android.libraries.push.impl.notifications.NotificationRendererTest.given a simple notification is added when rendering then show the simple notification and update summary": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.textcomposer.impl.mentions.Mention... | {} | {
"io.element.android.libraries.mediapickers.PickerTypeTest.CameraVideo - assert types": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.mediapickers.PickerTypeTest.ImageAndVideo - assert types": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.elem... | {} |
element-hq__element-x-android-2588 | element-hq | element-x-android | 2,588 | closed | Remove Welcome screen from the FTUE | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [ ] Bugfix
- [ ] Technical
- [x] Other : UI flow changes
## Content
- Remove `WelcomeScreen` from the FTUE flow.
#... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "62435d674730503773b1ed438627a47e2eb996a1"
} | [
{
"number": 2584,
"title": "[Task] FTUE - Remove the welcome screen",
"body": "Please see and discuss the details in the meta issue."
}
] | kotlin | [Task] FTUE - Remove the welcome screen
Please see and discuss the details in the meta issue.
| null | https://github.com/element-hq/element-x-android/pull/2588 | [
"https://github.com/element-hq/element-x-android/issues/2584"
] | ./gradlew :features:ftue:impl:testDebugUnitTest --tests "io.element.android.features.ftue.impl.DefaultFtueStateTests" | diff --git a/changelog.d/2584.misc b/changelog.d/2584.misc
new file mode 100644
index 00000000000..de85b9d90fa
--- /dev/null
+++ b/changelog.d/2584.misc
@@ -0,0 +1,1 @@
+Remove Welcome screen from the FTUE.
diff --git a/features/ftue/impl/src/main/kotlin/io/element/android/features/ftue/impl/FtueFlowNode.kt b/features/... | diff --git a/.maestro/tests/account/login.yaml b/.maestro/tests/account/login.yaml
index 397cc61f5c8..dcb5cd32234 100644
--- a/.maestro/tests/account/login.yaml
+++ b/.maestro/tests/account/login.yaml
@@ -23,8 +23,6 @@ appId: ${MAESTRO_APP_ID}
- inputText: ${MAESTRO_PASSWORD}
- pressKey: Enter
- tapOn: "Continue"
--... | {
"io.element.android.features.ftue.impl.DefaultFtueStateTests.traverse flow": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.ftue.impl.DefaultFtueStateTests.if version is older than 13 we don't display the notification opt in screen": {
"run": "PASS",
"test": "... | {} | {} | {} |
element-hq__element-x-android-2594 | element-hq | element-x-android | 2,594 | closed | Move session verification to FTUE flow, make it mandatory | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [x] Feature
- [ ] Bugfix
- [ ] Technical
- [ ] Other :
## Content
- Moves the session verification flow to be the first step of the... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "05f6770d356d8256e7ee7f9c0f96b05dc8c94138"
} | [
{
"number": 2580,
"title": "[Task] FTUE - Move session verification to the login flow",
"body": "Please see and discuss the details in the meta issue."
}
] | kotlin | [Task] FTUE - Move session verification to the login flow
Please see and discuss the details in the meta issue.
| null | https://github.com/element-hq/element-x-android/pull/2594 | [
"https://github.com/element-hq/element-x-android/issues/2580"
] | ./gradlew :features:preferences:impl:testDebugUnitTest --tests "io.element.android.features.preferences.impl.root.PreferencesRootPresenterTest" :features:messages:impl:testDebugUnitTest --tests "io.element.android.features.messages.impl.timeline.TimelinePresenterTest" --tests "io.element.android.features.messages.impl.... | diff --git a/appnav/src/main/kotlin/io/element/android/appnav/LoggedInEventProcessor.kt b/appnav/src/main/kotlin/io/element/android/appnav/LoggedInEventProcessor.kt
index b59c1cebdf7..22300b77142 100644
--- a/appnav/src/main/kotlin/io/element/android/appnav/LoggedInEventProcessor.kt
+++ b/appnav/src/main/kotlin/io/elem... | diff --git a/.maestro/tests/account/login.yaml b/.maestro/tests/account/login.yaml
index dcb5cd32234..69833a985ed 100644
--- a/.maestro/tests/account/login.yaml
+++ b/.maestro/tests/account/login.yaml
@@ -23,7 +23,8 @@ appId: ${MAESTRO_APP_ID}
- inputText: ${MAESTRO_PASSWORD}
- pressKey: Enter
- tapOn: "Continue"
+-... | {
"io.element.android.features.ftue.impl.DefaultFtueServiceTests.if a check for a step is true, start from the next one": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.messages.impl.MessagesPresenterTest.present - handle action reply to an image media message": {
"... | {} | {
"io.element.android.features.preferences.impl.root.PreferencesRootPresenterTest.present - initial state": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
}
} | {} |
element-hq__element-x-android-2653 | element-hq | element-x-android | 2,653 | closed | Copy permalink | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [ ] Bugfix
- [ ] Technical
- [ ] Other :
## Content
<!-- Describe shortly what has been changed -->
Add action on me... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "05f6770d356d8256e7ee7f9c0f96b05dc8c94138"
} | [
{
"number": 2650,
"title": "[Task] Copy permalink for Event",
"body": "Please see and discuss the details in the meta issue."
}
] | kotlin | [Task] Copy permalink for Event
Please see and discuss the details in the meta issue.
| null | https://github.com/element-hq/element-x-android/pull/2653 | [
"https://github.com/element-hq/element-x-android/issues/2650"
] | ./gradlew :features:messages:impl:testDebugUnitTest --tests "io.element.android.features.messages.impl.actionlist.ActionListPresenterTest" --tests "io.element.android.features.messages.impl.MessagesPresenterTest" | diff --git a/changelog.d/2650.feature b/changelog.d/2650.feature
new file mode 100644
index 00000000000..4287d42ac79
--- /dev/null
+++ b/changelog.d/2650.feature
@@ -0,0 +1,1 @@
+Add action to copy permalink
diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesPresenter.... | diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesPresenterTest.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesPresenterTest.kt
index 6cceb6b5b54..bce97f4a6ee 100644
--- a/features/messages/impl/src/test/kotlin/io/element... | {
"io.element.android.features.messages.impl.actionlist.ActionListPresenterTest.present - compute for message from others redacted": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.messages.impl.MessagesPresenterTest.present - handle action reply to an image media messag... | {} | {} | {} |
element-hq__element-x-android-3298 | element-hq | element-x-android | 3,298 | closed | Feature: identity reset | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
- Moves OIDC related code to their own modules: `libraries/oidc`.
- Improves the custom chrome tab implementation and fixes issues with the fallback... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "45775d71fd29354749ae64651a312c32ebbd10e1"
} | [
{
"number": 3268,
"title": "[Story] Crypto identity reset",
"body": "See details in the parent ticket"
}
] | kotlin | [Story] Crypto identity reset
See details in the parent ticket
| null | https://github.com/element-hq/element-x-android/pull/3298 | [
"https://github.com/element-hq/element-x-android/issues/3268"
] | ./gradlew :features:securebackup:impl:testDebugUnitTest --tests "io.element.android.features.securebackup.impl.reset.root.ResetIdentityRootViewTest" --tests "io.element.android.features.securebackup.impl.reset.password.ResetIdentityPasswordViewTest" --tests "io.element.android.features.securebackup.impl.reset.root.Rese... | diff --git a/appnav/build.gradle.kts b/appnav/build.gradle.kts
index 53680fd44ea..887f48e203b 100644
--- a/appnav/build.gradle.kts
+++ b/appnav/build.gradle.kts
@@ -42,6 +42,7 @@ dependencies {
implementation(projects.libraries.architecture)
implementation(projects.libraries.deeplink)
implementation(proj... | diff --git a/appnav/src/test/kotlin/io/element/android/appnav/intent/IntentResolverTest.kt b/appnav/src/test/kotlin/io/element/android/appnav/intent/IntentResolverTest.kt
index aa0fe9cbf12..8134c091f61 100644
--- a/appnav/src/test/kotlin/io/element/android/appnav/intent/IntentResolverTest.kt
+++ b/appnav/src/test/kotli... | {
"io.element.android.features.securebackup.impl.reset.root.ResetIdentityRootPresenterTest.present - DismissDialog event hides the confirmation dialog": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.oidc.impl.webview.OidcPresenterTest.present - go back with failure": ... | {} | {} | {} |
element-hq__element-x-android-3633 | element-hq | element-x-android | 3,633 | closed | QrCode intro screen: add subtitle and fix button wording #3632 | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Add subtitle and fix button wording.
## Motivation and context
<!-- Provide link to the corres... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "47dcdef6aad573dd12612c1815841d127b79c0e6"
} | [
{
"number": 3632,
"title": "[Task] Show a hint that QR code login is only available when the account provider supports.",
"body": "Please see and discuss the details in the meta issue.\r\n"
}
] | kotlin | [Task] Show a hint that QR code login is only available when the account provider supports.
Please see and discuss the details in the meta issue.
| null | https://github.com/element-hq/element-x-android/pull/3633 | [
"https://github.com/element-hq/element-x-android/issues/3632"
] | ./gradlew :features:login:impl:testDebugUnitTest --tests "io.element.android.features.login.impl.screens.qrcode.intro.QrCodeIntroViewTest" | diff --git a/features/login/impl/src/main/kotlin/io/element/android/features/login/impl/screens/qrcode/intro/QrCodeIntroView.kt b/features/login/impl/src/main/kotlin/io/element/android/features/login/impl/screens/qrcode/intro/QrCodeIntroView.kt
index a128884e408..0a2892d661a 100644
--- a/features/login/impl/src/main/ko... | diff --git a/features/login/impl/src/test/kotlin/io/element/android/features/login/impl/screens/qrcode/intro/QrCodeIntroViewTest.kt b/features/login/impl/src/test/kotlin/io/element/android/features/login/impl/screens/qrcode/intro/QrCodeIntroViewTest.kt
index 11762d502bc..2655624c0e8 100644
--- a/features/login/impl/src... | {
"io.element.android.features.login.impl.screens.qrcode.intro.QrCodeIntroViewTest.on back button clicked - calls the expected callback": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.login.impl.screens.qrcode.intro.QrCodeIntroViewTest.when can continue - calls the exp... | {
"io.element.android.features.login.impl.screens.qrcode.intro.QrCodeIntroViewTest.on back pressed - calls the expected callback": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {} | {} |
element-hq__element-x-android-3918 | element-hq | element-x-android | 3,918 | closed | Remove AttachmentsState and use the MessagesNavigator | Remove AttachmentsState and use the MessagesNavigator.
Close #3910
Let the Node use the factories so that we have cleaner Presenter constructors. | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "e8af711777c97d75a8e2de9c07f38f0c388b08fb"
} | [
{
"number": 3910,
"title": "Remove `AttachmentsState` and use the `MessagesNavigator`",
"body": "To do once https://github.com/element-hq/element-x-android/pull/3902 has been merged."
}
] | kotlin | Remove `AttachmentsState` and use the `MessagesNavigator`
To do once https://github.com/element-hq/element-x-android/pull/3902 has been merged.
| null | https://github.com/element-hq/element-x-android/pull/3918 | [
"https://github.com/element-hq/element-x-android/issues/3910"
] | ./gradlew :features:messages:impl:testDebugUnitTest --tests "io.element.android.features.messages.impl.timeline.TimelinePresenterTest" --tests "io.element.android.features.messages.impl.messagecomposer.MessageComposerPresenterTest" --tests "io.element.android.features.messages.impl.MessagesViewTest" --tests "io.element... | diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesNavigator.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesNavigator.kt
index 3eba997eea9..470d9da9c42 100644
--- a/features/messages/impl/src/main/kotlin/io/element/android... | diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/FakeMessagesNavigator.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/FakeMessagesNavigator.kt
index fa5e412f27b..5dcc4e74966 100644
--- a/features/messages/impl/src/test/kotlin/io/element... | {
"io.element.android.features.messages.impl.MessagesPresenterTest.present - handle action reply to an image media message": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.messages.impl.timeline.TimelinePresenterTest.present - on scroll finished send read receipt if an ... | {} | {} | {} |
element-hq__element-x-android-4161 | element-hq | element-x-android | 4,161 | closed | Media navigation with swipe gesture | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Add ability to swipe between media (images and videos) and files (files, audio and voice message) wh... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "e4768a88507d8ea940a8629eebc082327bd451da"
} | [
{
"number": 4174,
"title": "[Task] Attachment viewer: navigation by swiping left and right",
"body": "Please see and discuss the details in the meta issue.\n\n(Note: this is actually #1484)"
}
] | kotlin | [Task] Attachment viewer: navigation by swiping left and right
Please see and discuss the details in the meta issue.
(Note: this is actually #1484)
| null | https://github.com/element-hq/element-x-android/pull/4161 | [
"https://github.com/element-hq/element-x-android/issues/4174"
] | ./gradlew :libraries:mediaviewer:impl:testDebugUnitTest --tests "io.element.android.libraries.mediaviewer.impl.gallery.TimelineMediaGalleryDataSourceTest" --tests "io.element.android.libraries.mediaviewer.impl.gallery.SingleMediaGalleryDataSourceTest" --tests "io.element.android.libraries.mediaviewer.impl.viewer.MediaV... | diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesFlowNode.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesFlowNode.kt
index 61f6426978d..f9d9bbf27f0 100644
--- a/features/messages/impl/src/main/kotlin/io/element/android/f... | diff --git a/libraries/matrix/impl/src/test/kotlin/io/element/android/libraries/matrix/impl/fixtures/fakes/FakeRustTimeline.kt b/libraries/matrix/impl/src/test/kotlin/io/element/android/libraries/matrix/impl/fixtures/fakes/FakeRustTimeline.kt
index e269a30b1b1..042d4c98a19 100644
--- a/libraries/matrix/impl/src/test/ko... | {
"io.element.android.libraries.mediaviewer.impl.gallery.MediaGalleryPresenterTest.present - delete bottom sheet": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.mediaviewer.impl.viewer.MediaViewerViewTest.clicking on image hides the overlay": {
"run": "PASS",
... | {
"io.element.android.libraries.matrix.impl.timeline.RustTimelineTest.ensure that the timeline emits new loading item when pagination does not bring new events": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {
"io.element.android.tests.konsist.KonsistClassNameTest.Class implementing interface should have name not end with 'Impl' but start with 'Default'": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.tests.konsist.KonsistClassNameTest.Classes extending 'Node' should have 'Node' suf... | {} |
streetcomplete__StreetComplete-4657 | streetcomplete | StreetComplete | 4,657 | closed | Cycleway overlay | - refactored cycleway, street parking and sidewalk parsers to be be consistent and properly handle all edge cases when tagging only one side (fixes #4634). A side-effect of this is that the app will always merge same `*:left` and `*:right` values to `*:both` as was requested several times somewhere in this issue tracke... | {
"label": "streetcomplete:master",
"ref": "master",
"sha": "b75c8ae4f833173cee72a4f2b8279ef5577b6dbd"
} | [
{
"number": 4634,
"title": "Crash when adding a parking lane",
"body": "The crash only happens with a specific way, but is deterministic.\r\n\r\n**How to Reproduce**\r\n* Select this way in the parking lane overlay: https://www.openstreetmap.org/way/4014978\r\n* Then select the south side and add “paral... | kotlin | Crash when adding a parking lane
The crash only happens with a specific way, but is deterministic.
**How to Reproduce**
* Select this way in the parking lane overlay: https://www.openstreetmap.org/way/4014978
* Then select the south side and add “parallel on street side” (screenshot below). Leave the north side as... | null | https://github.com/streetcomplete/StreetComplete/pull/4657 | [
"https://github.com/streetcomplete/StreetComplete/issues/4634"
] | ./gradlew :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.osm.cycleway_separate.SeparateCyclewayCreatorKtTest" --tests "de.westnordost.streetcomplete.osm.street_parking.StreetParkingKtTest" --tests "de.westnordost.streetcomplete.osm.cycleway.CyclewayCreatorKtTest" --tests "de.westnordost.streetcomplete.os... | diff --git a/app/src/main/assets/country_metadata/AQ.yml b/app/src/main/assets/country_metadata/AQ.yml
new file mode 100644
index 00000000000..cc4a63ba104
--- /dev/null
+++ b/app/src/main/assets/country_metadata/AQ.yml
@@ -0,0 +1,2 @@
+# Do not edit. Data is from res/country/metadata and https://github.com/streetcomple... | diff --git a/app/src/androidTest/java/de/westnordost/streetcomplete/data/osm/osmquests/TestQuestType.kt b/app/src/androidTest/java/de/westnordost/streetcomplete/data/osm/osmquests/TestQuestType.kt
index 176fed3129c..7b97c648cbe 100644
--- a/app/src/androidTest/java/de/westnordost/streetcomplete/data/osm/osmquests/TestQ... | {
"de.westnordost.streetcomplete.osm.cycleway.CyclewayCreatorKtTest.apply separate cycleway answer": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"de.westnordost.streetcomplete.quests.cycleway.AddCyclewayTest.applicable to road with cycleway that is far away enough": {
"run": "PASS",
"tes... | {} | {} | {} |
thunderbird__thunderbird-android-5859 | thunderbird | thunderbird-android | 5,859 | closed | Be more selective when removing notifications | - When opening a message for viewing, only the notification for that particular message is removed.
- When displaying the Unified Inbox, notifications for messages in the Unified Inbox are removed.
- When displaying the "new messages" list, notifications for all messages in that account are removed.
- When displayin... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "88e823d6859697b85a076d1e3743a094c3d0a7ca"
} | [
{
"number": 1664,
"title": "Notifications removed",
"body": "### Expected behavior\n\nIf there are multiple notifications for mails, the user expands the multiline 'compressed' notification and clicks on one of the mails, this mail should be opened in K-9 and should be removed from the notifications. Th... | kotlin | Notifications removed
### Expected behavior
If there are multiple notifications for mails, the user expands the multiline 'compressed' notification and clicks on one of the mails, this mail should be opened in K-9 and should be removed from the notifications. The other mails should stay in the notifications.
### Actua... | Possibly this is an enhancement. There is a difference of opinion as to whether notifications should clear:
- On opening the app
- On viewing the unified inbox / inbox for that account
- On viewing the message itself
We may need a setting for this.
Yes, I am totally with you. I also think a setting would be very help... | https://github.com/thunderbird/thunderbird-android/pull/5859 | [
"https://github.com/thunderbird/thunderbird-android/issues/1664"
] | ./gradlew :app:core:testDebugUnitTest --tests "com.fsck.k9.notification.NotificationDataStoreTest" --tests "com.fsck.k9.notification.NewMailNotificationManagerTest" | diff --git a/app/core/src/main/java/com/fsck/k9/controller/MessagingController.java b/app/core/src/main/java/com/fsck/k9/controller/MessagingController.java
index ba4ca011e00..341a4bf038e 100644
--- a/app/core/src/main/java/com/fsck/k9/controller/MessagingController.java
+++ b/app/core/src/main/java/com/fsck/k9/control... | diff --git a/app/core/src/test/java/com/fsck/k9/notification/NewMailNotificationManagerTest.kt b/app/core/src/test/java/com/fsck/k9/notification/NewMailNotificationManagerTest.kt
index 7393229c32f..873dd7cb5f7 100644
--- a/app/core/src/test/java/com/fsck/k9/notification/NewMailNotificationManagerTest.kt
+++ b/app/core/... | {
"com.fsck.k9.notification.NewMailNotificationManagerTest.remove notification when additional notifications are available": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.notification.NewMailNotificationManagerTest.restore notifications with one inactive persisted notification": {
... | {} | {} | {} |
thunderbird__thunderbird-android-7008 | thunderbird | thunderbird-android | 7,008 | closed | Fetch `List-Post` header when downloading partial message | `ReplyToParser` currently checks the `List-Post` header to figure out which email address to use as recipient when replying. With this change we make sure the `List-Post` header is always available, i.e. we explicitly fetch it when downloading a partial message.
Fixes #6414 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "f72bd24fbd0b88dbf4d32e4a31de9f90f4ed297e"
} | [
{
"number": 6414,
"title": "Problematic behavior with mailing lists",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App version\n\n6.305\n\n### W... | kotlin | Problematic behavior with mailing lists
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.305
### Where did you get the app from?
Other
### Android version
Andr... | Hello @SvSky
I have been trying to reproduce the issue you described ((in Samsung A32, Android 13)), but I am having difficulty doing so. I was wondering if you could provide me with more information on the scenario you experienced in order to help us resolve the issue. you say the same word in expected behavior and ... | https://github.com/thunderbird/thunderbird-android/pull/7008 | [
"https://github.com/thunderbird/thunderbird-android/issues/6414"
] | ./gradlew :mail:protocols:imap:test --tests "com.fsck.k9.mail.store.imap.RealImapFolderTest" | diff --git a/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt b/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt
index 6746d890520..26ff4103d48 100644
--- a/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt
+++ b/mail/protocols/... | diff --git a/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapFolderTest.kt b/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapFolderTest.kt
index 27225051ea0..c87615f2c8d 100644
--- a/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapFolderTest.kt
+++ b/mai... | {
"com.fsck.k9.mail.store.imap.RealImapFolderTest.fetch_withBodyFetchProfileAndNoMaximumDownloadSize_shouldIssueRespectiveCommand": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.store.imap.RealImapFolderTest.getMessagesFromUids": {
"run": "PASS",
"test": "NONE",
"fix"... | {
"com.fsck.k9.mail.store.imap.RealImapFolderTest.open_readWrite_shouldOpenFolder": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"com.fsck.k9.mail.store.imap.RealImapFolderTest.getUidFromMessageId_withMessageIdHeader_shouldIssueUidSearchCommand": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.mail.store.imap.RealImapFolderTest.open_withMessagingException_shouldThrowMessagingException": {
"run": "PASS",
... | {} |
thunderbird__thunderbird-android-8136 | thunderbird | thunderbird-android | 8,136 | closed | Add drawer account view | Add new drawer `AccountView`.
Resolves #8120
| {
"label": "thunderbird:main",
"ref": "main",
"sha": "a58a0520826fd3ba16f27cd6aea575167df9e800"
} | [
{
"number": 8120,
"title": "Add account top view",
"body": "Implement the account top view highlighted in this design:\n\n\n\n"
}
] | kotlin | Add account top view
Implement the account top view highlighted in this design:
| null | https://github.com/thunderbird/thunderbird-android/pull/8136 | [
"https://github.com/thunderbird/thunderbird-android/issues/8120"
] | ./gradlew :feature:navigation:drawer:testDebugUnitTest --tests "app.k9mail.feature.navigation.drawer.ui.DrawerViewModelTest" | diff --git a/core/ui/compose/theme2/common/src/main/kotlin/app/k9mail/core/ui/compose/theme2/SelectThemeColorScheme.kt b/core/ui/compose/theme2/common/src/main/kotlin/app/k9mail/core/ui/compose/theme2/SelectThemeColorScheme.kt
index ee9b3519cba..d1f44da6d8a 100644
--- a/core/ui/compose/theme2/common/src/main/kotlin/app... | diff --git a/feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigation/drawer/ui/account/FakeData.kt b/feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigation/drawer/ui/account/FakeData.kt
new file mode 100644
index 00000000000..3bcbd017480
--- /dev/null
+++ b/feature/navigation/drawer/s... | {
"app.k9mail.feature.navigation.drawer.ui.DrawerViewModelTest.should collect display accounts when created and select first as current": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.feature.navigation.drawer.ui.DrawerViewModelTest.should set current account to null when no accounts a... | {} | {} | {} |
thunderbird__thunderbird-android-8155 | thunderbird | thunderbird-android | 8,155 | closed | Add drawer unified folder support | Added the unified folder support for the drawer. The default selection has not been implemented as it requires state information from the MessageList properly propagated: #8142
Depends on #8151
... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "0bde0aecc707f0e78b549356fbb4200056a94206"
} | [
{
"number": 8121,
"title": "Add the unified folder list section",
"body": "Implement the unified folders highlighted in this design:\n\n\n\n"
}
] | kotlin | Add the unified folder list section
Implement the unified folders highlighted in this design:
| null | https://github.com/thunderbird/thunderbird-android/pull/8155 | [
"https://github.com/thunderbird/thunderbird-android/issues/8121"
] | ./gradlew :feature:navigation:drawer:testDebugUnitTest --tests "app.k9mail.feature.navigation.drawer.domain.usecase.GetDrawerConfigTest" --tests "app.k9mail.feature.navigation.drawer.ui.DrawerStateTest" --tests "app.k9mail.feature.navigation.drawer.ui.DrawerViewModelTest" --tests "app.k9mail.feature.navigation.drawer.u... | diff --git a/core/ui/compose/designsystem/src/main/kotlin/app/k9mail/core/ui/compose/designsystem/atom/icon/Icons.kt b/core/ui/compose/designsystem/src/main/kotlin/app/k9mail/core/ui/compose/designsystem/atom/icon/Icons.kt
index 592c561be6a..5e4a5861902 100644
--- a/core/ui/compose/designsystem/src/main/kotlin/app/k9ma... | diff --git a/feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigation/drawer/ui/FakeData.kt b/feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigation/drawer/ui/FakeData.kt
index cb847e0c1ea..7ab5cde18f6 100644
--- a/feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigatio... | {
"app.k9mail.feature.widget.unread.UnreadWidgetDataProviderTest.nonExistentAccount_shouldReturnNull": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.feature.navigation.drawer.ui.DrawerViewKtTest.pull refresh should listen to view model state": {
"run": "PASS",
"test": "NONE",
... | {} | {} | {} |
thunderbird__thunderbird-android-8329 | thunderbird | thunderbird-android | 8,329 | closed | Add funding UI - part 5 | This finishes adding the main UI parts. Integration with the actual billing manager will be in a separate pull-request. Given the time constraints, it doesn't include fake data to render the contribution items.
... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "3289bcdfb158c1eddf8d9457fc6dafbbb86bb956"
} | [
{
"number": 8163,
"title": "Implement subscription ui flow",
"body": "Design:\r\n\r\n\r\n"
}
] | kotlin | Implement subscription ui flow
Design:
| Will this also be enabled for first time installs like the desktop version of Thunderbird does? And will it pop up regularly or will it just be there?
We haven't worked out the cadence yet, but the first time install might be a bit too early. Folks need to have a chance to use the app before they make this decision. On... | https://github.com/thunderbird/thunderbird-android/pull/8329 | [
"https://github.com/thunderbird/thunderbird-android/issues/8163"
] | ./gradlew :feature:funding:googleplay:testDebugUnitTest --tests "app.k9mail.feature.funding.googleplay.ui.contribution.ContributionScreenKtTest" --tests "app.k9mail.feature.funding.googleplay.ui.contribution.ContributionViewModelTest" | diff --git a/core/ui/compose/designsystem/src/main/kotlin/app/k9mail/core/ui/compose/designsystem/organism/TopAppBar.kt b/core/ui/compose/designsystem/src/main/kotlin/app/k9mail/core/ui/compose/designsystem/organism/TopAppBar.kt
index ae78238d63b..3d39d176cea 100644
--- a/core/ui/compose/designsystem/src/main/kotlin/ap... | diff --git a/feature/funding/googleplay/src/debug/kotlin/app/k9mail/feature/funding/googleplay/ui/contribution/FakeContributionViewModel.kt b/feature/funding/googleplay/src/debug/kotlin/app/k9mail/feature/funding/googleplay/ui/contribution/FakeContributionViewModel.kt
new file mode 100644
index 00000000000..62da2560890... | {
"app.k9mail.feature.funding.googleplay.ui.contribution.ContributionViewModelTest.should change selected contribution and selected type when on time contribution selected": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.feature.funding.googleplay.ui.contribution.ContributionScreenKtTes... | {} | {} | {} |
thunderbird__thunderbird-android-9634 | thunderbird | thunderbird-android | 9,634 | closed | fix(logs): debug logs ignored when user enable it | Fixes #9561.
- Fixes the "Enable debug logging" preference not logging any useful data outside debuggable builds
- Refactor:
- Move `CompositeLogSinkManager` to `:core:logging:api`
- Replaced hardcoded string qualifier `syncDebug` with the `LogSync.Qualifier.SyncDebug` enum qualifier for improved discoverabil... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "b71249d539bf54a7913f2072204e967a528a529a"
} | [
{
"number": 9561,
"title": "Debug logging does not include IMAP/POP3 commands in beta versions",
"body": "### Checklist\n\n- [x] I have used the search function to see if someone else has already submitted the same bug report.\n- [x] I will describe the problem with as much detail as possible.\n\n### Ap... | kotlin | Debug logging does not include IMAP/POP3 commands in beta versions
### Checklist
- [x] I have used the search function to see if someone else has already submitted the same bug report.
- [x] I will describe the problem with as much detail as possible.
### App
Thunderbird for Android
### App version
12.0b4
### Whe... | null | https://github.com/thunderbird/thunderbird-android/pull/9634 | [
"https://github.com/thunderbird/thunderbird-android/issues/9561"
] | ./gradlew :core:logging:impl-composite:testDebugUnitTest --tests "net.thunderbird.core.logging.composite.DefaultCompositeLogSinkTest" | diff --git a/app-common/src/main/kotlin/net/thunderbird/app/common/core/AppCommonCoreModule.kt b/app-common/src/main/kotlin/net/thunderbird/app/common/core/AppCommonCoreModule.kt
index 92e1c60d6b3..c9d1d85c7d9 100644
--- a/app-common/src/main/kotlin/net/thunderbird/app/common/core/AppCommonCoreModule.kt
+++ b/app-commo... | diff --git a/core/logging/impl-composite/src/commonTest/kotlin/net/thunderbird/core/logging/composite/DefaultCompositeLogSinkTest.kt b/core/logging/impl-composite/src/commonTest/kotlin/net/thunderbird/core/logging/composite/DefaultCompositeLogSinkTest.kt
index ec3fed6ff8d..7b2f8aae487 100644
--- a/core/logging/impl-com... | {
"net.thunderbird.core.logging.composite.DefaultCompositeLogSinkTest.log should log to all sinks": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"net.thunderbird.core.logging.composite.DefaultCompositeLogSinkTest.log should not log if level is below threshold": {
"run": "PASS",
"test": "N... | {} | {} | {} |
wordpress-mobile__WordPress-Android-18967 | wordpress-mobile | WordPress-Android | 18,967 | closed | [Jetpack Social] Hide Jetpack Social container if PostStatus is PRIVATE | Fixes #18927
To test:
You should not be able to reproduce the bug anymore. Steps to reproduce can be found in https://github.com/wordpress-mobile/WordPress-Android/issues/18927
## Regression Notes
1. Potential unintended areas of impact
Jetpack Social containers should continue to work as expected.
2. What ... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "cfb329ae952a18c517e71c9f66efb257da1fe136"
} | [
{
"number": 18927,
"title": "Jetpack Social section is visible on private posts",
"body": "Refs pctCYC-W4-p2#comment-989\n\n### Expected behavior\nThe Jetpack Social section should be hidden from the pre-publishing sheet and post settings when the post is set to private.\n\n### Actual behavior\nThe Jetp... | kotlin | Jetpack Social section is visible on private posts
Refs pctCYC-W4-p2#comment-989
### Expected behavior
The Jetpack Social section should be hidden from the pre-publishing sheet and post settings when the post is set to private.
### Actual behavior
The Jetpack Social section is shown for private posts, but the post is... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/18967 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/18927"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.posts.EditorJetpackSocialViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostSettingsFragment.java b/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostSettingsFragment.java
index fcc44f840f07..17a68c9c050c 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostSettingsFragment.java
+++ ... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/posts/EditorJetpackSocialViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/posts/EditorJetpackSocialViewModelTest.kt
index 68e92a6e3a22..1e05b7d4f486 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/posts/EditorJetpackSocialVie... | {
"org.wordpress.android.ui.posts.EditorJetpackSocialViewModelTest.Should show jetpack social container if FF is enabled": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.posts.EditorJetpackSocialViewModelTest.Should track SHARING_CONNECTION_TOGGLED when connection item is ... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19091 | wordpress-mobile | WordPress-Android | 19,091 | closed | Dashboard Personalization: Post cards more menu tracking | Closes #18945 & #18946
This PR adds track events for the more menu actions of the Scheduled and Draft post cards. This PR also removes post card footer action tracking events.
**Merge Instructions**
- Ensure #19075, #19089, and #19090 have been merged
- Ensure the parent branch is set to `feature/dashboard-pers... | {
"label": "wordpress-mobile:feature/dashboard-personalization",
"ref": "feature/dashboard-personalization",
"sha": "498bb68e1ee31f8e9c3e4b5425b382858b0b0d43"
} | [
{
"number": 18945,
"title": "Dashboard Personalization: Add more menu to Draft Posts card",
"body": "Draft Posts card\r\n\r\n\r\n```[tasklist]\r\n### Tasks\r\n- [x] Add more menu with options **View all drafts** and **Hide this**\r\n- [x] Implement action for Hide This -> Turn the draft posts preference... | kotlin | Dashboard Personalization: Add more menu to Draft Posts card
Draft Posts card
```[tasklist]
### Tasks
- [x] Add more menu with options **View all drafts** and **Hide this**
- [x] Implement action for Hide This -> Turn the draft posts preference to hide
- [x] Implement action for View All Drafts -> navigate to ... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/19091 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/18945"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.mysite.cards.dashboard.posts.PostsCardViewModelSliceTest" --tests "org.wordpress.android.ui.mysite.cards.dashboard.CardsTrackerTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/dashboard/CardsTracker.kt b/WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/dashboard/CardsTracker.kt
index 4516b1ae3f27..6fa114b0d9c0 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/dashboard/CardsTracke... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/dashboard/CardsTrackerTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/dashboard/CardsTrackerTest.kt
index e6522f993f3f..cd7987188d0e 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/dashboard/Car... | {
"org.wordpress.android.ui.mysite.cards.dashboard.posts.PostsCardViewModelSliceTest.given drafts post card, when more menu item hide this is accessed, then hide card is tracked": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.mysite.cards.dashboard.CardsTrackerTest.when a... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19115 | wordpress-mobile | WordPress-Android | 19,115 | closed | Fixes: My site dashboard menu items tracking | Fixes #19114
## Description
This PR implements the tracking on clicking menu items in MySiteDashboard
## To test:
1. Login to the app
2. Go to Menu
3. Tap on menu item posts|stats
4. Verify that the tracking is present
5. 🔵 Tracked: my_site_menu_item_tapped, Properties: {"type":"posts|stats"}
5. Tap on any other ite... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "db8a917509f4ca9163b5e6c4b5afce89cee33678"
} | [
{
"number": 19114,
"title": "Missing tracking of Menu items in MySiteDashboard",
"body": "### Expected behavior\r\nOn clicking menu items in MySiteDashboard the following event should be triggered for all the items \r\n- 🔵 Tracked: my_site_menu_item_tapped, Properties: {\"type\":\"MENU_ITEM_LABEL\"}\r... | kotlin | Missing tracking of Menu items in MySiteDashboard
### Expected behavior
On clicking menu items in MySiteDashboard the following event should be triggered for all the items
- 🔵 Tracked: my_site_menu_item_tapped, Properties: {"type":"MENU_ITEM_LABEL"}
### Actual behavior
The tracking is present only for Posts an... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/19115 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19114"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.mysite.MySiteViewModelTest" --tests "org.wordpress.android.ui.mysite.items.SiteItemsTrackerTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteViewModel.kt b/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteViewModel.kt
index 00af915c6a45..75d903da827c 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteViewModel.kt
+++ b/WordPress/src/main/java/org/... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/mysite/MySiteViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/mysite/MySiteViewModelTest.kt
index 55323820a635..9b529e23026a 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/mysite/MySiteViewModelTest.kt
+++ b/WordPress/src/te... | {
"org.wordpress.android.ui.mysite.MySiteViewModelTest.given remove undo snackbar, when undo is clicked, then it updates setting and refresh prompts": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.mysite.MySiteViewModelTest.given post card, when footer link is clicked, th... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19175 | wordpress-mobile | WordPress-Android | 19,175 | closed | Dashboard Personalization: Personalize card navigation, tracking and unit testing | Closes #18937
This PR adds the following for the personalize card
- Navigation event for onclick
- Tracking for card shown and tapped
- Add unit tests
**To test:**
- Install the app and login
- Navigate to Me > Debug Settings > enable `dashboard_personalization` and restart the app
- Navigate to the My Sit... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "6eab5e2e728ef475a16e98a45840f407218c77e0"
} | [
{
"number": 18937,
"title": "Dashboard Personalization: Create Personalize Your Home Tab Card",
"body": "Create the **Personalize Home Tab** card \r\n\r\n\r\n\r\n\r\n```[tasklist]\n### Tasks... | kotlin | Dashboard Personalization: Create Personalize Your Home Tab Card
Create the **Personalize Home Tab** card
```[tasklist]
### Tasks
- [x] Guard with `dashboard_personalization` feature flag
- [x] Cr... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/19175 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/18937"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.mysite.cards.personalize.PersonalizeCardViewModelSliceTest" --tests "org.wordpress.android.ui.mysite.cards.personalize.PersonalizeCardBuilderTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/ActivityNavigator.kt b/WordPress/src/main/java/org/wordpress/android/ui/ActivityNavigator.kt
index 16406fd9a874..d6aa4ad91098 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/ActivityNavigator.kt
+++ b/WordPress/src/main/java/org/wordpress/andro... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/personalize/PersonalizeCardBuilderTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/personalize/PersonalizeCardBuilderTest.kt
new file mode 100644
index 000000000000..1c24cd8b2cbe
--- /dev/null
+++ b/WordPress/src/test/java... | {
"org.wordpress.android.ui.mysite.cards.personalize.PersonalizeCardViewModelSliceTest.given personalize card, when card item is clicked, then open personalize event is raised": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.mysite.cards.personalize.PersonalizeCardViewMode... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19253 | wordpress-mobile | WordPress-Android | 19,253 | closed | Plans in site creation: Remove site domains feature flag | Fixes #19252
Removing the site domains feature flag as it a stable feature
<img width=320 src="https://github.com/wordpress-mobile/WordPress-Android/assets/990349/7d89184a-c3ea-4a94-9be5-542632c4e8bc" />
To test:
- Launch JP app
- `Go` to Debug settings (Me -> Debug settings)
- `Verify` `site_domains_r... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "274107bedb8009dad7dba7cef334f761790896c5"
} | [
{
"number": 19252,
"title": "Plans in Site Creation: Remove SITE_DOMAINS Feature Flag",
"body": "There's an old site domains feature flag done almost two years ago that needs to be removed"
}
] | kotlin | Plans in Site Creation: Remove SITE_DOMAINS Feature Flag
There's an old site domains feature flag done almost two years ago that needs to be removed
|
<!--
1 failure: Please add a type...
0 warning:
DangerID: danger-id-Peril;
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>
Please add a type label to this ... | https://github.com/wordpress-mobile/WordPress-Android/pull/19253 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19252"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.mysite.items.listitem.SiteListItemBuilderTest" --tests "org.wordpress.android.ui.domains.DomainSuggestionsViewModelTest" | diff --git a/WordPress/build.gradle b/WordPress/build.gradle
index a2656512789b..a5e47e4cf5f1 100644
--- a/WordPress/build.gradle
+++ b/WordPress/build.gradle
@@ -108,7 +108,6 @@ android {
buildConfigField "boolean", "MANAGE_CATEGORIES", "false"
buildConfigField "boolean", "GLOBAL_STYLE_SUPPORT", "tru... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/domains/DomainSuggestionsViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/domains/DomainSuggestionsViewModelTest.kt
index fea1061fe04e..d968c4ac9dfd 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/domains/DomainSuggestionsVie... | {
"org.wordpress.android.ui.domains.DomainSuggestionsViewModelTest.intro is visible at start": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.domains.DomainSuggestionsViewModelTest.site on blogger plan is requesting only dot blog domain suggestions": {
"run": "PASS",
... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19262 | wordpress-mobile | WordPress-Android | 19,262 | closed | Plans in site creation: Remove domain purchasing feature flag | Fixes #19230
This PR removes domain purchasing in site creation feature flag, and replaces it with plans in site creation feature flag.
To test:
Test 1
- `Launch` JP app
- `Go` to Me-> Debug settings
- `Switch` to `Features in Development` tab
- `Verify` there's no `SiteCreationDomainPurchasing` featu... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "d7a5a3231954294ade35f515ed07a7b962bed792"
} | [
{
"number": 19230,
"title": "Plans in Site Creation: Remove DOMAIN_PURCHASING feature flag",
"body": "There is a local only feature flag for domain purchasing in the site creation feature. Since we bind domain purchasing feature into \"Plans in Site Creation\" project, we should remove [SiteCreationDoma... | kotlin | Plans in Site Creation: Remove DOMAIN_PURCHASING feature flag
There is a local only feature flag for domain purchasing in the site creation feature. Since we bind domain purchasing feature into "Plans in Site Creation" project, we should remove [SiteCreationDomainPurchasing](https://github.com/wordpress-mobile/WordPres... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/19262 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19230"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.sitecreation.domains.SiteCreationDomainsViewModelTest" | diff --git a/WordPress/build.gradle b/WordPress/build.gradle
index 0036a3717d78..23921af71fd4 100644
--- a/WordPress/build.gradle
+++ b/WordPress/build.gradle
@@ -158,7 +158,6 @@ android {
buildConfigField "boolean", "ENABLE_MY_SITE_DASHBOARD_TABS", "true"
buildConfigField "boolean", "ENABLE_QRCODE_AU... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/sitecreation/domains/SiteCreationDomainsViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/sitecreation/domains/SiteCreationDomainsViewModelTest.kt
index 6d43f782cbab..e761a7ee74b3 100644
--- a/WordPress/src/test/java/org/wordpress/android/u... | {
"org.wordpress.android.ui.sitecreation.domains.SiteCreationDomainsViewModelTest.verify cost of sale domain results from api is 'OnSale'": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.sitecreation.domains.SiteCreationDomainsViewModelTest.verify only 1st domain result fr... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19303 | wordpress-mobile | WordPress-Android | 19,303 | closed | Plans in Site Creation: Create functionality to add domain with a plan to a cart | Fixes #19265
- [x] Merge https://github.com/wordpress-mobile/WordPress-FluxC-Android/pull/2864
- [x] Update FluxC reference to `trunk`
This makes the project compatible with the FluxC change. `CreateShoppingCartPayload` was deprecated in the FluxC PR, and this PR changes it with `CreateShoppingCartWithDomainAnd... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "a5e5a941d9c8f3846a9c4622fef89820126d94a4"
} | [
{
"number": 19265,
"title": "Plans in Site Creation: Create functionality to add domain with a plan to a cart",
"body": "Create functionality to add domain together with a plan via `me/shopping-cart/siteID` endpoint.\r\n\r\nWe can pass a plan and a domain objects to a `products` parameter in this format... | kotlin | Plans in Site Creation: Create functionality to add domain with a plan to a cart
Create functionality to add domain together with a plan via `me/shopping-cart/siteID` endpoint.
We can pass a plan and a domain objects to a `products` parameter in this format:
```
products: [
{
product_id: 1003
},... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/19303 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19265"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.domains.DomainRegistrationDetailsViewModelTest" --tests "org.wordpress.android.ui.sitecreation.progress.SiteCreationProgressViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/domains/DomainRegistrationDetailsViewModel.kt b/WordPress/src/main/java/org/wordpress/android/ui/domains/DomainRegistrationDetailsViewModel.kt
index 98d36051a627..bf5d598e19ea 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/domains/DomainRegist... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/domains/DomainRegistrationDetailsViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/domains/DomainRegistrationDetailsViewModelTest.kt
index 6bbe25cc3b7a..8d71993756e9 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/domains/Doma... | {
"org.wordpress.android.ui.domains.DomainRegistrationDetailsViewModelTest.onSameCountrySelected": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.sitecreation.progress.SiteCreationProgressViewModelTest.on service success for paid domain creates cart": {
"run": "PASS",
... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19469 | wordpress-mobile | WordPress-Android | 19,469 | closed | Fixes: In eligible cards shown in Personalization Screen | ## Fixes
#19467
## Description
This PR fixes the scenario in which the in eligible feature cards were shown in the personalization screen This PR adds a check before adding the visibility options for a feature card in personalization screen.
Note: the shortcuts personalization already was checking whether a f... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "88afc7687e1739482bf07d66fe6566b8007284a0"
} | [
{
"number": 19467,
"title": "Dashboard Cards Personalization shows in eligible cards ",
"body": "### Expected behavior\r\nFor a site or user not having the capability of a feature, the card personalization for that card should not be shown \r\n\r\n### Actual behavior\r\nThe ability to hide/show a card o... | kotlin | Dashboard Cards Personalization shows in eligible cards
### Expected behavior
For a site or user not having the capability of a feature, the card personalization for that card should not be shown
### Actual behavior
The ability to hide/show a card of a feature that isn't available for the user is shown in the da... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/19469 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19467"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.mysite.personalization.DashboardCardPersonalizationViewModelSliceTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/mysite/personalization/DashboardCardPersonalizationViewModelSlice.kt b/WordPress/src/main/java/org/wordpress/android/ui/mysite/personalization/DashboardCardPersonalizationViewModelSlice.kt
index 62149c0368bd..8d25b5d32a73 100644
--- a/WordPress/src/main/java... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/mysite/personalization/DashboardCardPersonalizationViewModelSliceTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/mysite/personalization/DashboardCardPersonalizationViewModelSliceTest.kt
index c6074d3d76fa..6e2530ccf16c 100644
--- a/WordPress/src/t... | {
"org.wordpress.android.ui.mysite.personalization.DashboardCardPersonalizationViewModelSliceTest.when draft posts card state is toggled, then pref is updated": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.mysite.personalization.DashboardCardPersonalizationViewModelSlice... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19510 | wordpress-mobile | WordPress-Android | 19,510 | closed | Attach Purchase Domain screen to Domain Search flow | Fixes #19502
The PR adds the Purchase Domain screen to the existing flow.
Note: I also converted `PurchaseDomainViewModel` to assisted injection-friendly implementation for passing domain id to the viewmodel's parameters, which makes the class easily testable. I wasn't sure if we needed the entire `ProposedDomai... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "d36116b1a261a2a376777148d0b7672cbd6fb153"
} | [
{
"number": 19502,
"title": "🤖 Link up the purchase domain screen to the flow",
"body": "Link up the implemented \"Purchase Domain\" screen UI https://github.com/wordpress-mobile/WordPress-Android/pull/19332 to the flow"
}
] | kotlin | 🤖 Link up the purchase domain screen to the flow
Link up the implemented "Purchase Domain" screen UI https://github.com/wordpress-mobile/WordPress-Android/pull/19332 to the flow
| null | https://github.com/wordpress-mobile/WordPress-Android/pull/19510 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19502"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.domains.management.purchasedomain.PurchaseDomainViewModelTest" --tests "org.wordpress.android.ui.domains.management.newdomainsearch.domainsfetcher.NewDomainsSearchRepositoryTest" --tests "org.wordpress.android.ui.domains.management... | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/ActivityNavigator.kt b/WordPress/src/main/java/org/wordpress/android/ui/ActivityNavigator.kt
index 9ae93dd4e3b6..c6e3cc7aea9e 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/ActivityNavigator.kt
+++ b/WordPress/src/main/java/org/wordpress/andro... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/domains/management/newdomainsearch/NewDomainSearchViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/domains/management/newdomainsearch/NewDomainSearchViewModelTest.kt
index 123966533a6d..6298a2ee56d5 100644
--- a/WordPress/src/test/java/org... | {
"org.wordpress.android.ui.domains.management.newdomainsearch.NewDomainSearchViewModelTest.WHEN back button pressed THEN send GoBack action event": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.domains.management.newdomainsearch.NewDomainSearchViewModelTest.WHEN a domain... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19524 | wordpress-mobile | WordPress-Android | 19,524 | closed | Fix Null Pointer Exception on getSelectedSite | Fixes #19520
Sentry [JETPACK-ANDROID-E2J](https://a8c.sentry.io/issues/4592008344/?referrer=github_integration)
This PR prevents a crash when siteRepository.getSelectedSite returns a null. If there is no site, we can continue.
Note: I could not reproduce this crash, so this a preventative measure
**To test:**
... | {
"label": "wordpress-mobile:release/23.6",
"ref": "release/23.6",
"sha": "e265e8d9e6027ba36f26773486c46f652dfcc0fc"
} | [
{
"number": 19520,
"title": "NullPointerException",
"body": "Sentry Issue: [JETPACK-ANDROID-E2J](https://a8c.sentry.io/issues/4592008344/?referrer=github_integration)\n\n```\nNullPointerException: None\n at org.wordpress.android.ui.mysite.menu.MenuViewModel.start(MenuViewModel.kt:89)\n at org.word... | kotlin | NullPointerException
Sentry Issue: [JETPACK-ANDROID-E2J](https://a8c.sentry.io/issues/4592008344/?referrer=github_integration)
```
NullPointerException: None
at org.wordpress.android.ui.mysite.menu.MenuViewModel.start(MenuViewModel.kt:89)
at org.wordpress.android.ui.mysite.menu.MenuActivity$onCreate$1$1$2.invo... | From logs, I can say the crash is related to https://github.com/wordpress-mobile/WordPress-Android/pull/19244 | https://github.com/wordpress-mobile/WordPress-Android/pull/19524 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19520"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.mysite.menu.MenuViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/mysite/menu/MenuActivity.kt b/WordPress/src/main/java/org/wordpress/android/ui/mysite/menu/MenuActivity.kt
index 00b4f5e1a0d0..cf26a9e7c87c 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/mysite/menu/MenuActivity.kt
+++ b/WordPress/src/main/jav... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/mysite/menu/MenuViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/mysite/menu/MenuViewModelTest.kt
index 7889c673f1b3..8a0f8f58fdb1 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/mysite/menu/MenuViewModelTest.kt
+++ b/WordPre... | {
"org.wordpress.android.ui.mysite.menu.MenuViewModelTest.given vm start, when jetpack capabilities includes scan, then scan menu item is visible": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.mysite.menu.MenuViewModelTest.when vm, when init, then uiState should contain ... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20074 | wordpress-mobile | WordPress-Android | 20,074 | closed | Stats Traffic: Today card | Fixes #19950
-----
<img width=320 src="https://github.com/wordpress-mobile/WordPress-Android/assets/990349/243c2c9b-37a6-4875-a478-6c79037fe957" />
## To Test:
Test 1:
- Enable `stats_traffic_tab` feature flag (Me -> Debug settings - Remote Features)
- Go to Stats
- `Verify` only Traffic tab, and Insigh... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "e0e84ab29aea3d6907639543761f6dab40152aae"
} | [
{
"number": 19950,
"title": "Stats Traffic: By day card (Today card)",
"body": "Refer to #19973, to reuse the card in this when date picker strip is ready \n\nParent: https://github.com/wordpress-mobile/jetpack-issue-repo/issues/1\n
Refer to #19973, to reuse the card in this when date picker strip is ready
Parent: https://github.com/wordpress-mobile/jetpack-issue-repo/issues/1
| null | https://github.com/wordpress-mobile/WordPress-Android/pull/20074 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19950"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.stats.refresh.lists.sections.granular.usecases.OverviewUseCaseTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/lists/sections/granular/usecases/OverviewUseCase.kt b/WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/lists/sections/granular/usecases/OverviewUseCase.kt
index 46d2a1ce3a39..ef7b192d6ba7 100644
--- a/WordPress/src/main/java/org/w... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/stats/refresh/lists/sections/granular/usecases/OverviewUseCaseTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/stats/refresh/lists/sections/granular/usecases/OverviewUseCaseTest.kt
index 3757b6c82b41..d0206175cee8 100644
--- a/WordPress/src/test/ja... | {
"org.wordpress.android.ui.stats.refresh.lists.sections.granular.usecases.OverviewUseCaseTest.maps domain model to UI model": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.stats.refresh.lists.sections.granular.usecases.OverviewUseCaseTest.does not track incorrect data wh... | {} | {} | {} |
NMF-earth__nmf-app-424 | NMF-earth | nmf-app | 424 | closed | chore: upgrade to Expo SDK 55 |
<!-- Thanks for submitting a pull request! We appreciate a lot your help. Please provide some information so that others can review your pull request. The two last fields below are optional but appreciated. -->
✅ I have read the [contributing file](https://github.com/NMF-earth/nmf-app/blob/main/contributing.md)
... | {
"label": "NMF-earth:main",
"ref": "main",
"sha": "47d489a3da2e23930c3462a692e4fa5500b80336"
} | [
{
"number": 420,
"title": "Update to Expo SDK 55",
"body": "#### Summary\nExpo SDK 55 is available in Bete https://expo.dev/changelog/sdk-55-beta\nand soon will have stable release. Till then we will have this logged.\n\n\n"
}
] | typescript | Update to Expo SDK 55
#### Summary
Expo SDK 55 is available in Bete https://expo.dev/changelog/sdk-55-beta
and soon will have stable release. Till then we will have this logged.
|
@PierreBresson before we do this it will be nice to have a build pushed to sentry with current stable master so that when we do a release of SDK 55 we can compare the gains vs SDK 54
may need some setup as per https://docs.sentry.io/platforms/react-native/size-analysis/
Sounds like a good plan. New build is being rev... | https://github.com/NMF-earth/nmf-app/pull/424 | [
"https://github.com/NMF-earth/nmf-app/issues/420"
] | NODE_OPTIONS='--experimental-vm-modules --max-old-space-size=4096' npx --no-install jest app/components/NoEmission/__tests__/NoEmissions.test.tsx --passWithNoTests 2>&1 | diff --git a/app.config.js b/app.config.js
index 6dedbe7b..c119b43b 100644
--- a/app.config.js
+++ b/app.config.js
@@ -17,9 +17,14 @@ module.exports = () => {
"microphonePermission": "Allow $(PRODUCT_NAME) to access your microphone",
"recordAudioAndroid": true
}
- ]
+ ],
+ ... | diff --git a/app/components/NoEmission/__tests__/__snapshots__/NoEmissions.test.tsx.snap b/app/components/NoEmission/__tests__/__snapshots__/NoEmissions.test.tsx.snap
index d472c46a..298220ba 100644
--- a/app/components/NoEmission/__tests__/__snapshots__/NoEmissions.test.tsx.snap
+++ b/app/components/NoEmission/__tests... | {} | {
"renders correctly NoEmission": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"app/components/NoEmission/__tests__/NoEmissions.test.tsx": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {} | {} |
NMF-earth__nmf-app-412 | NMF-earth | nmf-app | 412 | closed | feat: Center the switch component within the ListItemSwitch by applying a new style. |
<!-- Thanks for submitting a pull request! We appreciate a lot your help. Please provide some information so that others can review your pull request. The two last fields below are optional but appreciated. -->
✅ I have read the [contributing file](https://github.com/NMF-earth/nmf-app/blob/main/contributing.md)
... | {
"label": "NMF-earth:main",
"ref": "main",
"sha": "d495e2bdf83b6c168e6f39c2d6a672e3dfcc02ee"
} | [
{
"number": 406,
"title": "Bug: aligment issue switch",
"body": "**Describe the bug**\n\nFix alignment issue, see screenshot below. It should be center vertically and the trailing edge of the switch should have same margin as the chevron.\n\n<img width=\"314\" height=\"192\" alt=\"Image\" src=\"https://... | typescript | Bug: aligment issue switch
**Describe the bug**
Fix alignment issue, see screenshot below. It should be center vertically and the trailing edge of the switch should have same margin as the chevron.
<img width="314" height="192" alt="Image" src="https://github.com/user-attachments/assets/cda14948-4e7b-4f51-b0c9-68feb4... | null | https://github.com/NMF-earth/nmf-app/pull/412 | [
"https://github.com/NMF-earth/nmf-app/issues/406"
] | NODE_OPTIONS='--experimental-vm-modules --max-old-space-size=4096' npx --no-install jest app/components/ListItemSwitch/__tests__/ListItemSwitch.test.tsx --passWithNoTests 2>&1 | diff --git a/app/components/ListItemSwitch/ListItemSwitch.styles.ts b/app/components/ListItemSwitch/ListItemSwitch.styles.ts
index b412184b..f237406d 100644
--- a/app/components/ListItemSwitch/ListItemSwitch.styles.ts
+++ b/app/components/ListItemSwitch/ListItemSwitch.styles.ts
@@ -12,6 +12,9 @@ export default StyleShe... | diff --git a/app/components/ListItemSwitch/__tests__/__snapshots__/ListItemSwitch.test.tsx.snap b/app/components/ListItemSwitch/__tests__/__snapshots__/ListItemSwitch.test.tsx.snap
index b1e08408..031fcd86 100644
--- a/app/components/ListItemSwitch/__tests__/__snapshots__/ListItemSwitch.test.tsx.snap
+++ b/app/componen... | {} | {
"render": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"app/components/ListItemSwitch/__tests__/ListItemSwitch.test.tsx": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"ListItem renders correctly with topLine": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
... | {} | {} |
NMF-earth__nmf-app-403 | NMF-earth | nmf-app | 403 | closed | Remove all usages of suppressHighlighting and make Ionicons have opacity on touch | <!-- Thanks for submitting a pull request! We appreciate a lot your help. Please provide some information so that others can review your pull request. The two last fields below are optional but appreciated. -->
✅ I have read the [contributing file](https://github.com/NMF-earth/nmf-app/blob/main/contributing.md)
#... | {
"label": "NMF-earth:main",
"ref": "main",
"sha": "8752a29cc7b46df11d6c4dbc3b24fceb0d3f962a"
} | [
{
"number": 392,
"title": "Ionicons buttons opacity",
"body": "#### Summary\r\nFind alternative to `suppressHighlighting={true}` for `Ionicons`, see this [commit](https://github.com/NMF-earth/nmf-app/commit/2e8b6f224993e29cbb0c4af1112b5155caa5d4ff). The icon opacity should change like back button instea... | typescript | Ionicons buttons opacity
#### Summary
Find alternative to `suppressHighlighting={true}` for `Ionicons`, see this [commit](https://github.com/NMF-earth/nmf-app/commit/2e8b6f224993e29cbb0c4af1112b5155caa5d4ff). The icon opacity should change like back button instead
| null | https://github.com/NMF-earth/nmf-app/pull/403 | [
"https://github.com/NMF-earth/nmf-app/issues/392"
] | NODE_OPTIONS='--experimental-vm-modules --max-old-space-size=4096' npx --no-install jest app/components/Accordion/__tests__/Accordion.test.tsx app/components/Button/__tests__/Button.test.tsx app/components/EmissionListItem/__tests__/EmissionListItem.test.tsx app/components/InfoButton/__tests__/InfoButton.test.tsx app/c... | diff --git a/app/components/Accordion/Accordion.tsx b/app/components/Accordion/Accordion.tsx
index 6a3941e7..97732ec5 100644
--- a/app/components/Accordion/Accordion.tsx
+++ b/app/components/Accordion/Accordion.tsx
@@ -1,5 +1,5 @@
import React, { FC, ReactNode, Children, cloneElement, useState, ReactElement } from "re... | diff --git a/app/components/Accordion/__tests__/__snapshots__/Accordion.test.tsx.snap b/app/components/Accordion/__tests__/__snapshots__/Accordion.test.tsx.snap
index a62741a1..0b4c3b59 100644
--- a/app/components/Accordion/__tests__/__snapshots__/Accordion.test.tsx.snap
+++ b/app/components/Accordion/__tests__/__snaps... | {} | {
"app/components/Button/__tests__/Button.test.tsx": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"app/components/SelectableListItem/__tests__/SelectableListItem.test.tsx": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"app/components/TextButton/__tests__/TextButton.test.tsx":... | {} | {} |
NMF-earth__nmf-app-402 | NMF-earth | nmf-app | 402 | closed | refactor: move FaqScreen ScrollView padding to contentContainerStyle |
<!-- Thanks for submitting a pull request! We appreciate a lot your help. Please provide some information so that others can review your pull request. The two last fields below are optional but appreciated. -->
✅ I have read the [contributing file](https://github.com/NMF-earth/nmf-app/blob/main/contributing.md)
... | {
"label": "NMF-earth:main",
"ref": "main",
"sha": "1518b11db4564f4151708c8caf71c1e0ca3463c1"
} | [
{
"number": 399,
"title": "Bug: Bottom Tabs Overlap FAQ Content",
"body": "**Describe the bug**\n In the FAQ screen under the Settings tab, the content of an expanded Accordion overlaps with the bottom tab navigator. The last item of the list becomes partially hidden, reducing readability and hurting t... | typescript | Bug: Bottom Tabs Overlap FAQ Content
**Describe the bug**
In the FAQ screen under the Settings tab, the content of an expanded Accordion overlaps with the bottom tab navigator. The last item of the list becomes partially hidden, reducing readability and hurting the user experience. There should be a margin or padding... | I’d like to take this issue and work on a fix. Planning to address it by adding bottom padding or adjusting contentInset to ensure the last Accordion item doesn’t overlap with the bottom tab.
@muhammadkamran8586 thanks for reporting this bug. You can open a pr, I will have a look ;)
Hey @PierreBresson I am happy to hel... | https://github.com/NMF-earth/nmf-app/pull/402 | [
"https://github.com/NMF-earth/nmf-app/issues/399"
] | NODE_OPTIONS='--experimental-vm-modules --max-old-space-size=4096' npx --no-install jest app/screens/Faq/__tests__/FaqScreen.test.tsx --passWithNoTests 2>&1 | diff --git a/app/screens/Faq/FaqScreen.styles.ts b/app/screens/Faq/FaqScreen.styles.ts
index bcfeccf0..dc706a1a 100644
--- a/app/screens/Faq/FaqScreen.styles.ts
+++ b/app/screens/Faq/FaqScreen.styles.ts
@@ -5,6 +5,8 @@ import { Colors } from "style";
const styles = StyleSheet.create({
container: {
backgroundCo... | diff --git a/app/screens/Faq/__tests__/__snapshots__/FaqScreen.test.tsx.snap b/app/screens/Faq/__tests__/__snapshots__/FaqScreen.test.tsx.snap
index e4334a01..846cb9ad 100644
--- a/app/screens/Faq/__tests__/__snapshots__/FaqScreen.test.tsx.snap
+++ b/app/screens/Faq/__tests__/__snapshots__/FaqScreen.test.tsx.snap
@@ -2... | {} | {
"FaqScreen renders correctly": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"app/screens/Faq/__tests__/FaqScreen.test.tsx": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {} | {} |
NMF-earth__nmf-app-401 | NMF-earth | nmf-app | 401 | closed | Update Social Links on SettingsScreen + Fix Failing Lint and tests | Fixes #400
✅ I have read the [contributing file](https://github.com/NMF-earth/nmf-app/blob/main/contributing.md)
## Summary
This PR updates the application to be compatible with Expo 52, refactors deprecated APIs, and improves the Social Media component.
**Motivation:**
- **Expo 52 Compatibility:** The `e... | {
"label": "NMF-earth:main",
"ref": "main",
"sha": "b0414f6c6bf3706d8a2060c7fd680204ff75f44c"
} | [
{
"number": 400,
"title": "Non-working links",
"body": "The two links on the end of the settings pages are not available. \n\n**To Reproduce**\nSteps to reproduce the behavior:\n1. Go to 'settings'\n2. Scroll down to the end of the page\n3. Click on 'mastodon.social icon and medium.com'\n4. See error\n\... | typescript | Non-working links
The two links on the end of the settings pages are not available.
**To Reproduce**
Steps to reproduce the behavior:
1. Go to 'settings'
2. Scroll down to the end of the page
3. Click on 'mastodon.social icon and medium.com'
4. See error
**Expected behaviour**
Links should take us to a useful page.
... | I'd like to know if there are any other links you would want to add instead of these. Also the about page is very simple, i would like to redesign it.
Hey,
The 2 available links atm are github and nmf website, I've close down social media. Feel free to submit a redesign :)
@PierreBresson did you take down http://nmf.ea... | https://github.com/NMF-earth/nmf-app/pull/401 | [
"https://github.com/NMF-earth/nmf-app/issues/400"
] | NODE_OPTIONS='--experimental-vm-modules --max-old-space-size=4096' npx --no-install jest app/components/OpenFoodFacts/__tests__/OpenFoodFacts.test.tsx app/components/SocialMedia/__tests__/SocialMedia.test.tsx app/components/StickersImage/__tests__/StickersImage.test.tsx app/screens/MonthlyBudget/__tests__/MonthlyBudget... | diff --git a/app/components/SocialMedia/SocialMedia.styles.ts b/app/components/SocialMedia/SocialMedia.styles.ts
index ebb319e7..6835b392 100644
--- a/app/components/SocialMedia/SocialMedia.styles.ts
+++ b/app/components/SocialMedia/SocialMedia.styles.ts
@@ -9,8 +9,9 @@ export default StyleSheet.create({
box: {
... | diff --git a/app/components/OpenFoodFacts/__tests__/__snapshots__/OpenFoodFacts.test.tsx.snap b/app/components/OpenFoodFacts/__tests__/__snapshots__/OpenFoodFacts.test.tsx.snap
index 5bc53025..11fd5648 100644
--- a/app/components/OpenFoodFacts/__tests__/__snapshots__/OpenFoodFacts.test.tsx.snap
+++ b/app/components/Ope... | {} | {
"app/components/SocialMedia/__tests__/SocialMedia.test.tsx": {
"run": "FAIL",
"test": "FAIL",
"fix": "PASS"
}
} | {
"app/screens/Settings/__tests__/SettingsScreen.test.tsx": {
"run": "FAIL",
"test": "PASS",
"fix": "PASS"
},
"app/components/StickersImage/__tests__/StickersImage.test.tsx": {
"run": "FAIL",
"test": "PASS",
"fix": "PASS"
},
"app/screens/MonthlyBudget/__tests__/MonthlyBudgetScreen.test... | {} |
NMF-earth__nmf-app-342 | NMF-earth | nmf-app | 342 | closed | (#339) Present PermissionsRequest in Notification screen | ✅ I have read the [contributing file](https://github.com/NMF-earth/nmf-app/blob/main/contributing.md)
## Summary
Closes #339
## Changelog
- Update snapshots
- Check for permissions on useEffect in Notifications screen
- Use PermissionsRequest component to require permissions in Notifications screen
- Ad... | {
"label": "NMF-earth:main",
"ref": "main",
"sha": "bd4f7cc9a17936c44a2b67f78a2b8952645cb427"
} | [
{
"number": 339,
"title": "Present PermissionsRequest in Notification screen",
"body": "#### Summary\r\nShow `PermissionsRequest` component in Notification screen instead of opening settings with Linking.\r\n\r\n_NB: First to submit a valid PR, first to merge. Except if you already have merged some good... | typescript | Present PermissionsRequest in Notification screen
#### Summary
Show `PermissionsRequest` component in Notification screen instead of opening settings with Linking.
_NB: First to submit a valid PR, first to merge. Except if you already have merged some good code in this repo, I won’t assign any issue due to spam and... | As far as I'm concerned you can't show the permission pop up twice to a user once they've rejected.
I also agree that just sending users to settings might not be a good UX, rather showing a popup saying :
`you've rejected before if you want you can go to settings and give permission manually` (sth like that) & then t... | https://github.com/NMF-earth/nmf-app/pull/342 | [
"https://github.com/NMF-earth/nmf-app/issues/339"
] | NODE_OPTIONS='--experimental-vm-modules --max-old-space-size=4096' npx --no-install jest app/components/PermissionsRequest/__tests__/PermissionsRequest.test.tsx app/screens/Notifications/__tests__/NotificationsScreen.tests.tsx --passWithNoTests 2>&1 | diff --git a/app/components/PermissionsRequest/translations/en.json b/app/components/PermissionsRequest/translations/en.json
index ae6002d8..5210dddb 100644
--- a/app/components/PermissionsRequest/translations/en.json
+++ b/app/components/PermissionsRequest/translations/en.json
@@ -2,6 +2,6 @@
"PERMISSIONS_REQUEST_C... | diff --git a/app/components/PermissionsRequest/__tests__/__snapshots__/PermissionsRequest.test.tsx.snap b/app/components/PermissionsRequest/__tests__/__snapshots__/PermissionsRequest.test.tsx.snap
index 25b50ab3..bdbde928 100644
--- a/app/components/PermissionsRequest/__tests__/__snapshots__/PermissionsRequest.test.tsx... | {} | {
"app/screens/Notifications/__tests__/NotificationsScreen.tests.tsx": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"app/components/PermissionsRequest/__tests__/PermissionsRequest.test.tsx": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {} | {} |
NMF-earth__nmf-app-337 | NMF-earth | nmf-app | 337 | closed | Store review | ✅ I have read the [contributing file](https://github.com/NMF-earth/nmf-app/blob/main/contributing.md)
## Summary
Closes #309
## Changelog
- Adds `expo-store-review`;
- Adds `timesStarted` variable, and its corresponding action and selector, in userPreferences redux slice;
- Checks if the user has started ... | {
"label": "NMF-earth:main",
"ref": "main",
"sha": "c7977bef0fe4a6eb124a618d04f4d8b1b7362230"
} | [
{
"number": 309,
"title": "Store Review",
"body": "#### Summary\r\nAfter 4 starts of the app, if the user has accepted terms of use, ask him to rate the app thanks to expo [store-review api](https://docs.expo.dev/versions/v38.0.0/sdk/storereview/). See more [here](https://expo.canny.io/feature-requests/... | typescript | Store Review
#### Summary
After 4 starts of the app, if the user has accepted terms of use, ask him to rate the app thanks to expo [store-review api](https://docs.expo.dev/versions/v38.0.0/sdk/storereview/). See more [here](https://expo.canny.io/feature-requests/p/android-in-app-review)
_NB: First to submit a valid... | Hello @PierreBresson! I started working on this and I have a question. Do you think that a new redux slice is needed to store the number of times the user has opened the app? Or could we just set a variable on the `userPreferences` slice?
@EmersonPinheiro Thanks for having a look :)
Yes, you can simply set a variable... | https://github.com/NMF-earth/nmf-app/pull/337 | [
"https://github.com/NMF-earth/nmf-app/issues/309"
] | NODE_OPTIONS='--experimental-vm-modules --max-old-space-size=4096' npx --no-install jest app/components/StoreReviewChecker/__tests__/StoreReviewChecker.test.tsx app/ducks/userPreferences/__tests__/userPreferences.actions.test.ts app/ducks/userPreferences/__tests__/userPreferences.reducer.test.ts app/ducks/userPreferenc... | diff --git a/App.tsx b/App.tsx
index 1d2707de..e63d7f86 100644
--- a/App.tsx
+++ b/App.tsx
@@ -13,6 +13,7 @@ import { Provider } from "react-redux";
import { enableScreens } from "react-native-screens";
import { LocalizationContext } from "utils";
+import StoreReviewChecker from "components/StoreReviewChecker";
... | diff --git a/app/components/StoreReviewChecker/__tests__/StoreReviewChecker.test.tsx b/app/components/StoreReviewChecker/__tests__/StoreReviewChecker.test.tsx
new file mode 100644
index 00000000..b292a2ce
--- /dev/null
+++ b/app/components/StoreReviewChecker/__tests__/StoreReviewChecker.test.tsx
@@ -0,0 +1,18 @@
+impor... | {} | {
"app/ducks/userPreferences/__tests__/userPreferences.actions.test.ts": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"app/ducks/userPreferences/__tests__/userPreferences.selectors.test.ts": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"app/ducks/userPreferences/__tests__/use... | {} | {} |
NMF-earth__nmf-app-333 | NMF-earth | nmf-app | 333 | closed | Add ClickableTag | <!-- Thanks for submitting a pull request! We appreciate a lot your help. Please provide some information so that others can review your pull request. The two last fields below are optional but appreciated. -->
✅ I have read the [contributing file](https://github.com/NMF-earth/nmf-app/blob/main/contributing.md)
#... | {
"label": "NMF-earth:main",
"ref": "main",
"sha": "76d3c553a36d33c039b388bb98427e85ebd80458"
} | [
{
"number": 324,
"title": "ClickableTag component",
"body": "#### Summary\r\nCreate ClickableTag component with 2 props, `text` and `isSelected`\r\n\r\n#### To Do List \r\n\r\n- [ ] Code\r\n- [ ] Snapshots Tests + OnPress Test\r\n\r\n_NB: First to submit a valid PR, first to merge. Except if you already... | typescript | ClickableTag component
#### Summary
Create ClickableTag component with 2 props, `text` and `isSelected`
#### To Do List
- [ ] Code
- [ ] Snapshots Tests + OnPress Test
_NB: First to submit a valid PR, first to merge. Except if you already have merged some good code in this repo, I won’t assign any issue due... | null | https://github.com/NMF-earth/nmf-app/pull/333 | [
"https://github.com/NMF-earth/nmf-app/issues/324"
] | NODE_OPTIONS='--experimental-vm-modules --max-old-space-size=4096' npx --no-install jest app/components/ClickableTag/__tests__/ClickableTag.test.tsx --passWithNoTests 2>&1 | diff --git a/app/components/ClickableTag/ClickableTag.styles.ts b/app/components/ClickableTag/ClickableTag.styles.ts
new file mode 100644
index 00000000..c9a37298
--- /dev/null
+++ b/app/components/ClickableTag/ClickableTag.styles.ts
@@ -0,0 +1,21 @@
+import { StyleSheet } from "react-native";
+
+import { Colors } from... | diff --git a/app/components/ClickableTag/__tests__/ClickableTag.test.tsx b/app/components/ClickableTag/__tests__/ClickableTag.test.tsx
new file mode 100644
index 00000000..d1191003
--- /dev/null
+++ b/app/components/ClickableTag/__tests__/ClickableTag.test.tsx
@@ -0,0 +1,26 @@
+import React from "react";
+import { crea... | {
"should render correctly": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"given onPress should be called": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
}
} | {
"app/components/ClickableTag/__tests__/ClickableTag.test.tsx": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {} | {} |
NMF-earth__nmf-app-253 | NMF-earth | nmf-app | 253 | closed | Updated @expo-vector-icons | <!-- Thanks for submitting a pull request! We appreciate a lot your help. Please provide some information so that others can review your pull request. The two last fields below are optional but appreciated. -->
✅ I have read the [contributing file](https://github.com/NMF-earth/nmf-app/blob/main/contributing.md)
#... | {
"label": "NMF-earth:main",
"ref": "main",
"sha": "c4f531d8c87423494011fe9b07dfffb19e1a02bb"
} | [
{
"number": 252,
"title": "Not compatible @expo/vector-icons version",
"body": "**Describe the bug**\r\nWhen you try to run the app, the following warning will appear in console:\r\n\r\nThe app... | typescript | Not compatible @expo/vector-icons version
**Describe the bug**
When you try to run the app, the following warning will appear in console:
The app works fine and there's no another problem besides that warn... | null | https://github.com/NMF-earth/nmf-app/pull/253 | [
"https://github.com/NMF-earth/nmf-app/issues/252"
] | NODE_OPTIONS='--experimental-vm-modules --max-old-space-size=4096' npx --no-install jest app/components/ListItem/__tests__/ListItem.test.tsx app/components/SocialMedia/__tests__/SocialMedia.test.tsx app/screens/Act/__tests__/ActScreen.test.tsx app/screens/Budget/components/ProgressChart/__tests__/ProgressChart.test.tsx... | diff --git a/app/components/ListItem/ListItem.tsx b/app/components/ListItem/ListItem.tsx
index 318b7371..e81eb2bb 100644
--- a/app/components/ListItem/ListItem.tsx
+++ b/app/components/ListItem/ListItem.tsx
@@ -20,7 +20,7 @@ const ListItem = ({ title, onPress }: Props) => {
</Text.Secondary>
<Ionicons
... | diff --git a/app/components/ListItem/__tests__/__snapshots__/ListItem.test.tsx.snap b/app/components/ListItem/__tests__/__snapshots__/ListItem.test.tsx.snap
index 9d4ffda9..9e718427 100644
--- a/app/components/ListItem/__tests__/__snapshots__/ListItem.test.tsx.snap
+++ b/app/components/ListItem/__tests__/__snapshots__/... | {} | {
"app/components/SocialMedia/__tests__/SocialMedia.test.tsx": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"app/screens/Settings/components/SettingsRow/__tests__/SettingsRow.test.tsx": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"app/components/ListItem/__tests__/ListItem.t... | {} | {} |
NMF-earth__nmf-app-246 | NMF-earth | nmf-app | 246 | closed | Fix 239 little bug in a guide script | <!-- Thanks for submitting a pull request! We appreciate a lot your help. Please provide some information so that others can review your pull request. The two last fields below are optional but appreciated. -->
✅ I have read the [contributing file](https://github.com/NMF-earth/nmf-app/blob/main/contributing.md)
#... | {
"label": "NMF-earth:main",
"ref": "main",
"sha": "8b83bbd75f0bcb0ac4078fa25cfc193bee3bfce6"
} | [
{
"number": 239,
"title": "Fix little bug in a guide script",
"body": "**Describe the bug**\r\n\r\nRemove \"personal\" path (`/Users/pierrebresson/Documents/Git/nmf-app/assets//markdown/`) in snapshot file (like it was before). See `key` in this hot [fix](https://github.com/NMF-earth/nmf-app/commit/a32d... | typescript | Fix little bug in a guide script
**Describe the bug**
Remove "personal" path (`/Users/pierrebresson/Documents/Git/nmf-app/assets//markdown/`) in snapshot file (like it was before). See `key` in this hot [fix](https://github.com/NMF-earth/nmf-app/commit/a32dc9adc900803964ec7964d299d04a6a9a87f1)
This is a side effe... | null | https://github.com/NMF-earth/nmf-app/pull/246 | [
"https://github.com/NMF-earth/nmf-app/issues/239"
] | NODE_OPTIONS='--experimental-vm-modules --max-old-space-size=4096' npx --no-install jest app/screens/Act/__tests__/ActScreen.test.tsx --passWithNoTests 2>&1 | diff --git a/assets/guides/guides.json b/assets/guides/guides.json
index 04b37525..4b56c0d3 100644
--- a/assets/guides/guides.json
+++ b/assets/guides/guides.json
@@ -1,1 +1,1 @@
-[{"title":"Clean your cloud data","category":"digital","body":"<h1>Clean your cloud data</h1>\n<p>When your data is saved on the cloud, it m... | diff --git a/app/screens/Act/__tests__/__snapshots__/ActScreen.test.tsx.snap b/app/screens/Act/__tests__/__snapshots__/ActScreen.test.tsx.snap
index 03326e83..e10f0945 100644
--- a/app/screens/Act/__tests__/__snapshots__/ActScreen.test.tsx.snap
+++ b/app/screens/Act/__tests__/__snapshots__/ActScreen.test.tsx.snap
@@ -1... | {} | {
"ActScreen renders correctly": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"app/screens/Act/__tests__/ActScreen.test.tsx": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {} | {} |
NMF-earth__nmf-app-241 | NMF-earth | nmf-app | 241 | closed | Fix imports | <!-- Thanks for submitting a pull request! We appreciate a lot your help. Please provide some information so that others can review your pull request. The two last fields below are optional but appreciated. -->
✅ I have read the [contributing file](https://github.com/NMF-earth/nmf-app/blob/master/contributing.md)
... | {
"label": "NMF-earth:master",
"ref": "master",
"sha": "303c2fd8f80c08792a8bef73ec7bae1cb80f8d1b"
} | [
{
"number": 177,
"title": "Custom Path Aliases Part 2",
"body": "Following #167 \r\n\r\nReplace the following direct path of `ducks, interface, components, utils, navigation, style`\r\n\r\nSo the following : \r\n\r\n``` \r\nimport { emissions } from \"../../../ducks\";\r\nimport { Emission } from \"../.... | typescript | Custom Path Aliases Part 2
Following #167
Replace the following direct path of `ducks, interface, components, utils, navigation, style`
So the following :
```
import { emissions } from "../../../ducks";
import { Emission } from "../../../interfaces";
import { calculation, ui } from "../../../utils";
imp... | WIP in: https://github.com/NMF-earth/nmf-app/pull/188
Resolved 😁 | https://github.com/NMF-earth/nmf-app/pull/241 | [
"https://github.com/NMF-earth/nmf-app/issues/177"
] | NODE_OPTIONS='--experimental-vm-modules --max-old-space-size=4096' npx --no-install jest app/ducks/emissions/__tests__/emissions.actions.test.ts app/ducks/emissions/__tests__/emissions.reducer.test.ts app/ducks/emissions/__tests__/emissions.selectors.test.ts app/screens/AddEmission/__tests__/AddEmissionScreen.test.tsx ... | diff --git a/.eslintrc.js b/.eslintrc.js
index 05c4335f..83f8ac6c 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -57,7 +57,7 @@ module.exports = {
"internal",
["parent", "sibling", "index"],
],
- "newlines-between": "always-and-inside-groups",
+ "newline... | diff --git a/app/ducks/emissions/__tests__/emissions.actions.test.ts b/app/ducks/emissions/__tests__/emissions.actions.test.ts
index 869392f1..878f293a 100644
--- a/app/ducks/emissions/__tests__/emissions.actions.test.ts
+++ b/app/ducks/emissions/__tests__/emissions.actions.test.ts
@@ -1,7 +1,8 @@
import { TransportEn... | {} | {
"app/screens/AddEmission/__tests__/AddEmissionScreen.test.tsx": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"app/ducks/emissions/__tests__/emissions.reducer.test.ts": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"app/screens/Budget/ducks/__tests__/BudgetScreen.selectors.te... | {
"app/screens/Emissions/components/EmissionsListItem/__tests__/EmissionListItem.test.tsx": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
}
} | {} |
NMF-earth__nmf-app-212 | NMF-earth | nmf-app | 212 | closed | 144 emission info | Resolves #144
Pulled the Emission Info button into the shared components so that it could be reused for existing emissions and added it to EmissionItem.
Also added a test for coverage :) | {
"label": "NMF-earth:master",
"ref": "master",
"sha": "6e58734b2c451651b5884c05a0da46d65413d5c8"
} | [
{
"number": 144,
"title": "Emission info",
"body": "Add a button on EmissionItemScreen opening a new modal screen. This new modal screen should show some text from a markdown file, in the same way as sustainable guide is working.\r\n\r\n<img width=\"323\" alt=\"Screenshot 2020-06-25 at 09 03 08\" src=\"... | typescript | Emission info
Add a button on EmissionItemScreen opening a new modal screen. This new modal screen should show some text from a markdown file, in the same way as sustainable guide is working.
<img width="323" alt="Screenshot 2020-06-25 at 09 03 08" src="https://user-images.githubusercontent.com/8709134/85672332-1119... | What kind of markdown we have here. Are we using anything?
@akkikumar72 Same markdown mechanism as act tab / sustainable guide.
Looks like it same as https://github.com/NMF-earth/nmf-app/issues/154.
If yes, I can have a look
> Looks like it same as #154.
> If yes, I can have a look
Exact, same as #154 | https://github.com/NMF-earth/nmf-app/pull/212 | [
"https://github.com/NMF-earth/nmf-app/issues/144"
] | NODE_OPTIONS='--experimental-vm-modules --max-old-space-size=4096' npx --no-install jest app/components/InfoButton/__tests__/EmissionInfoButton.test.tsx app/screens/InfoModal/__test__/InfoModalScreen.test.tsx app/screens/Methodology/__test__/MethodologyScreen.test.tsx --passWithNoTests 2>&1 | diff --git a/app/screens/AddEmission/components/InfoButton/InfoButton.styles.ts b/app/components/InfoButton/InfoButton.styles.ts
similarity index 82%
rename from app/screens/AddEmission/components/InfoButton/InfoButton.styles.ts
rename to app/components/InfoButton/InfoButton.styles.ts
index fe6092fe..7bc804ec 100644
--... | diff --git a/app/components/InfoButton/__tests__/EmissionInfoButton.test.tsx b/app/components/InfoButton/__tests__/EmissionInfoButton.test.tsx
new file mode 100644
index 00000000..54b8333b
--- /dev/null
+++ b/app/components/InfoButton/__tests__/EmissionInfoButton.test.tsx
@@ -0,0 +1,9 @@
+import React from "react";
+im... | {} | {
"app/components/InfoButton/__tests__/EmissionInfoButton.test.tsx": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"app/screens/InfoModal/__test__/InfoModalScreen.test.tsx": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {} | {} |
artsy__eigen-4378 | artsy | eigen | 4,378 | closed | Add watched lots to Inbox 'bids' tab | The type of this PR is: **feature**
<!-- Bugfix/Feature/Enhancement/Documentation -->
<!-- If applicable, write the Jira ticket number in square brackets e.g. `[CX-434]`
The Jira integration will turn it into a clickable link for you. -->
### Description
This PR resolves [PURCHASE-2206]. It is based o... | {
"label": "artsy:master",
"ref": "master",
"sha": "11421d622c6f4e14e92b64fb0b18b98d994c0f73"
} | [
{
"number": 4344,
"title": "WIP - Watched Lots",
"body": "The type of this PR is: **TYPE**\r\n\r\n<!-- Bugfix/Feature/Enhancement/Documentation -->\r\n\r\n<!-- If applicable, write the Jira ticket number in square brackets e.g. `[CX-434]`\r\n The Jira integration will turn it into a clickable link f... | typescript | WIP - Watched Lots
The type of this PR is: **TYPE**
<!-- Bugfix/Feature/Enhancement/Documentation -->
<!-- If applicable, write the Jira ticket number in square brackets e.g. `[CX-434]`
The Jira integration will turn it into a clickable link for you. -->
This PR resolves [CX-]
### Description
<!-- ... | null | https://github.com/artsy/eigen/pull/4378 | [
"https://github.com/artsy/eigen/issues/4344"
] | NODE_OPTIONS='--experimental-vm-modules --max-old-space-size=4096' npx --no-install jest src/lib/Scenes/MyBids/__tests__/ActiveLotStanding-tests.tsx src/lib/Scenes/MyBids/__tests__/ClosedLotStanding-tests.tsx src/lib/Scenes/MyBids/__tests__/MyBids-tests.tsx --passWithNoTests 2>&1 | diff --git a/src/__generated__/ActiveLot_lotStanding.graphql.ts b/src/__generated__/ActiveLotStanding_lotStanding.graphql.ts
similarity index 90%
rename from src/__generated__/ActiveLot_lotStanding.graphql.ts
rename to src/__generated__/ActiveLotStanding_lotStanding.graphql.ts
index a43cd8adaab..5ada26e1fcd 100644
--- ... | diff --git a/src/__generated__/InboxTestsQuery.graphql.ts b/src/__generated__/InboxTestsQuery.graphql.ts
index f0b4fcb2a1b..681d1ea4182 100644
--- a/src/__generated__/InboxTestsQuery.graphql.ts
+++ b/src/__generated__/InboxTestsQuery.graphql.ts
@@ -1,7 +1,7 @@
/* tslint:disable */
/* eslint-disable */
// @ts-nocheck... | {} | {
"src/lib/Scenes/MyBids/__tests__/MyBids-tests.tsx": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"src/lib/Scenes/MyBids/__tests__/ActiveLotStanding-tests.tsx": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"src/lib/Scenes/MyBids/__tests__/ClosedLotStanding-tests.tsx": {
... | {} | {} |
PalisadoesFoundation__talawa-2481 | PalisadoesFoundation | talawa | 2,481 | closed | Fixed Error in Event Creation & Update with latest recurrence changes | **What kind of change does this PR introduce?**
bugfix, feature, refactoring
**Issue Number:**
Fixes #2468
**Did you add tests for your changes?**
Yes
**Snapshots/Videos:**
https://github.com/PalisadoesFoundation/talawa/assets/109027247/7f3718c6-00f2-4bc8-8d23-da7abf868110
**Summary**
- Rem... | {
"label": "PalisadoesFoundation:develop",
"ref": "develop",
"sha": "24f4aa77060693190ace0ac74dc5387c7107993d"
} | [
{
"number": 2468,
"title": "Error in Event Creation & Fetch due to Faulty mutation",
"body": "**Describe the bug**\r\nUser is unable to create event due to faulty and old implementation of `createEvent` mutation. The support for recurrance field was removed from API in https://github.com/PalisadoesFound... | dart | Error in Event Creation & Fetch due to Faulty mutation
**Describe the bug**
User is unable to create event due to faulty and old implementation of `createEvent` mutation. The support for recurrance field was removed from API in https://github.com/PalisadoesFoundation/talawa-api/issues/2107 and there are issuein recurr... | Would like to work on this issue | https://github.com/PalisadoesFoundation/talawa/pull/2481 | [
"https://github.com/PalisadoesFoundation/talawa/issues/2468"
] | null | diff --git a/lang/de.json b/lang/de.json
index 679e807a59..d1e9798204 100644
--- a/lang/de.json
+++ b/lang/de.json
@@ -70,6 +70,8 @@
"Add Event": "Ereignis hinzufügen",
"Add": "Anzeige",
"Add Image": "Bild hinzufügen",
+ "Select Start Date": "Startdatum auswählen",
+ "Select End Date": "Enddatum auswählen",
... | diff --git a/test/helpers/test_helpers.mocks.dart b/test/helpers/test_helpers.mocks.dart
index 17c038dc22..017b54648e 100644
--- a/test/helpers/test_helpers.mocks.dart
+++ b/test/helpers/test_helpers.mocks.dart
@@ -978,6 +978,51 @@ class MockGraphQLClient extends _i2.Mock implements _i3.GraphQLClient {
///
/// See th... | {} | {
"/home/talawa/test/model_tests/chat/chat_user_test.dart: Test chat_user model Test model to json": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"/home/talawa/test/model_tests/chat/chat_list_tile_data_model_test.dart: Test ChatListTileDataModel Test ChatListTileDataModel.fromJson": {
"run": ... | {
"/home/talawa/test/model_tests/chat/chat_list_tile_data_model_test.dart: Test ChatListTileDataModel Test constructor": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/talawa/test/model_tests/chat/chat_user_test.dart: Test chat_user model Test json to model": {
"run": "PASS",
"test":... | {} |
PalisadoesFoundation__talawa-2477 | PalisadoesFoundation | talawa | 2,477 | closed | Bug-Fix SignUp | **What kind of change does this PR introduce?**
Bug-Fix
<!-- E.g. a bugfix, feature, refactoring, etc… -->
**Issue Number:**
Fixes #2454
**Did you add tests for your changes?**
Yes, I have made changed in the unit tests to make sure workflow doesn't fail.
**Snapshots/Videos:**
SignUp is working fine now
... | {
"label": "PalisadoesFoundation:develop",
"ref": "develop",
"sha": "21db262aea3450e12725ddeee5db16632a222d55"
} | [
{
"number": 2454,
"title": "Bug Report: SignUp (Mobile)",
"body": "**Describe the bug**\r\n\r\nThe Talawa App is not able to run locally because of certain GrapphQL errors on the client side \r\n\r\n\r\n
**Describe the bug**
The Talawa App is not able to run locally because of certain GrapphQL errors on the client side
On server Talawa-API `userRegistrationRequired` is n... | I would like to work on this issue
@ArinNigam Before working on this, please verify this issue is happening in the develop march. Please close this if it is not needed.
The error is being caused by `userRegistrationRequired`. The server issue has been closed. Apparently the fields are present in `develop` branch and ... | https://github.com/PalisadoesFoundation/talawa/pull/2477 | [
"https://github.com/PalisadoesFoundation/talawa/issues/2454"
] | null | diff --git a/lib/utils/queries.dart b/lib/utils/queries.dart
index 256aa26516..60234d4228 100644
--- a/lib/utils/queries.dart
+++ b/lib/utils/queries.dart
@@ -10,6 +10,7 @@ class Queries {
/// * `lastName`: user's data.
/// * `email`: user's data.
/// * `password`: user's data.
+ /// * `selectedOrganization`:... | diff --git a/test/utils_tests/queries_test.dart b/test/utils_tests/queries_test.dart
index 6fffa67398..cdb43da4da 100644
--- a/test/utils_tests/queries_test.dart
+++ b/test/utils_tests/queries_test.dart
@@ -10,8 +10,13 @@ void main() {
var mutation = false;
expect(mutation, false);
- final fnData =... | {
"/home/talawa/test/utils_tests/queries_test.dart: Tests for queries.dart Check if updateLanguage works correctly": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/talawa/test/utils_tests/queries_test.dart: Tests for queries.dart Check if logout works correctly": {
"run": "PASS",
"te... | {} | {} | {} |
PalisadoesFoundation__talawa-2469 | PalisadoesFoundation | talawa | 2,469 | closed | Fixed registerForEvent mutation & update tests | **What kind of change does this PR introduce?**
bugfix
**Issue Number:**
Fixes #2467
**Did you add tests for your changes?**
Yes
**Snapshots/Videos:**
https://github.com/PalisadoesFoundation/talawa/assets/109027247/3261ed92-cf07-4223-bc8a-bb7f017a5de6
**Summary**
- Modified `registerForEve... | {
"label": "PalisadoesFoundation:develop",
"ref": "develop",
"sha": "897a0b19e50e70c1a13ff352159bb430fb7c0524"
} | [
{
"number": 2467,
"title": "Error in Event Registration due Faulty mutation",
"body": "**Describe the bug**\r\nThe `registerForEvent` mutation being used for register functionality was updated in Talawa API in https://github.com/PalisadoesFoundation/talawa-api/issues/1644 . Before update `registerForEve... | dart | Error in Event Registration due Faulty mutation
**Describe the bug**
The `registerForEvent` mutation being used for register functionality was updated in Talawa API in https://github.com/PalisadoesFoundation/talawa-api/issues/1644 . Before update `registerForEvent` returned `Event` object, after update it returns `Eve... | Would like to work on this issue | https://github.com/PalisadoesFoundation/talawa/pull/2469 | [
"https://github.com/PalisadoesFoundation/talawa/issues/2467"
] | null | diff --git a/lib/services/event_service.dart b/lib/services/event_service.dart
index eff3153edd..6b3146ec89 100644
--- a/lib/services/event_service.dart
+++ b/lib/services/event_service.dart
@@ -80,7 +80,6 @@ class EventService {
final List eventsJson =
(result as QueryResult).data!["eventsByOrganizatio... | diff --git a/test/service_tests/event_service_test.dart b/test/service_tests/event_service_test.dart
index 5546bfa246..76c461bbde 100644
--- a/test/service_tests/event_service_test.dart
+++ b/test/service_tests/event_service_test.dart
@@ -1,5 +1,3 @@
-// ignore_for_file: talawa_api_doc
-
import 'package:flutter_test/f... | {} | {
"/home/talawa/test/utils/event_queries_test.dart: Tests for event_queries.dart Check if registerForEvent works correctly": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"/home/talawa/test/utils/event_queries_test.dart: Tests for event_queries.dart Check if attendeesByEvent works correctly": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/talawa/test/utils/event_queries_test.dart: Tests for event_queries.dart Check if addEvent works correctly": {
"run":... | {} |
PalisadoesFoundation__talawa-2466 | PalisadoesFoundation | talawa | 2,466 | closed | Fix issues in loading Attendees | **What kind of change does this PR introduce?**
bugfix, refactoring
**Issue Number:**
Fixes #2463
**Did you add tests for your changes?**
Yes
**Snapshots/Videos:**
https://github.com/PalisadoesFoundation/talawa/assets/109027247/d23e9acd-0198-40d1-8c01-3ad2753eb760
**Summary**
In API reg... | {
"label": "PalisadoesFoundation:develop",
"ref": "develop",
"sha": "62c72227603b96f47185e73e47e68c5ab2cf9e24"
} | [
{
"number": 2463,
"title": "Event Attendees Not loading due faulty query",
"body": "**Describe the bug**\r\nIn the Event Page, the attendees for that specific events don't load, due to usage of `registrantsByEvent` query whose support was removed from API instead `getEventAttendeesByEventId` query resol... | dart | Event Attendees Not loading due faulty query
**Describe the bug**
In the Event Page, the attendees for that specific events don't load, due to usage of `registrantsByEvent` query whose support was removed from API instead `getEventAttendeesByEventId` query resolvers should be used which was added in https://github.com... | I would like to work on this issue | https://github.com/PalisadoesFoundation/talawa/pull/2466 | [
"https://github.com/PalisadoesFoundation/talawa/issues/2463"
] | null | diff --git a/lib/demo_server_data/events_demo_data.dart b/lib/demo_server_data/events_demo_data.dart
index 5578599915..9d22b4ef95 100644
--- a/lib/demo_server_data/events_demo_data.dart
+++ b/lib/demo_server_data/events_demo_data.dart
@@ -1,14 +1,29 @@
-// ignore_for_file: talawa_api_doc
-// ignore_for_file: talawa_goo... | diff --git a/test/helpers/test_helpers.dart b/test/helpers/test_helpers.dart
index ee66b2ffb4..dfdae1de6c 100644
--- a/test/helpers/test_helpers.dart
+++ b/test/helpers/test_helpers.dart
@@ -1,8 +1,4 @@
-// ignore_for_file: talawa_api_doc
-// ignore_for_file: talawa_good_doc_comments
-
import 'dart:async';
-
import '... | {
"/home/talawa/test/utils/event_queries_test.dart: Tests for event_queries.dart Check if updateEvent works correctly": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/talawa/test/utils/event_queries_test.dart: Tests for event_queries.dart Check if attendeesByEvent works correctly": {
"ru... | {} | {} | {} |
PalisadoesFoundation__talawa-2462 | PalisadoesFoundation | talawa | 2,462 | closed | Updated implementation of fetchOrgEvents | **What kind of change does this PR introduce?**
bugfix
**Issue Number:**
Fixes #2461
**Did you add tests for your changes?**
Yes (Updated existing tests)
**Snapshots/Videos:**
https://github.com/PalisadoesFoundation/talawa/assets/109027247/55c5d69e-c2fa-413f-a6d2-4c95ab273109
**Summary**
... | {
"label": "PalisadoesFoundation:develop",
"ref": "develop",
"sha": "676c1f81e723c8c2ab9f411ba2b23de7e4726654"
} | [
{
"number": 2461,
"title": "Events not rendering due older implementation of fetchOrgEvents query",
"body": "**Describe the bug**\r\n\r\nfetchOrgEvents query being used in app is still on older implementation which requires recurrance field. The reccurance field support was removed from Talawa API in ht... | dart | Events not rendering due older implementation of fetchOrgEvents query
**Describe the bug**
fetchOrgEvents query being used in app is still on older implementation which requires recurrance field. The reccurance field support was removed from Talawa API in https://github.com/PalisadoesFoundation/talawa-api/issues/210... | I would like to work on this issue | https://github.com/PalisadoesFoundation/talawa/pull/2462 | [
"https://github.com/PalisadoesFoundation/talawa/issues/2461"
] | null | diff --git a/lib/utils/event_queries.dart b/lib/utils/event_queries.dart
index d3f5ec5cb8..65bbe3d441 100644
--- a/lib/utils/event_queries.dart
+++ b/lib/utils/event_queries.dart
@@ -25,7 +25,6 @@ class EventQueries {
isPublic
isRegisterable
recurring
- recurrance
st... | diff --git a/test/utils/event_queries_test.dart b/test/utils/event_queries_test.dart
index cc0d370031..811ff80d3f 100644
--- a/test/utils/event_queries_test.dart
+++ b/test/utils/event_queries_test.dart
@@ -17,7 +17,6 @@ void main() {
isPublic
isRegisterable
recurring
- recurra... | {} | {
"Tests for event_queries.dart Check if fetchOrgEvents works correctly": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"Tests for event_queries.dart Check if registerForEvent works correctly": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"Tests for event_queries.dart Check if registrantsByEvents works correctly": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"Tests for event_queries.dart Che... | {} |
PalisadoesFoundation__talawa-2412 | PalisadoesFoundation | talawa | 2,412 | closed | Integrated create recurrence event API. | <!--
This section can be deleted after reading.
We employ the following branching strategy to simplify the development process and to ensure that only stable code is pushed to the `master` branch:
- `develop`: For unstable code: New features and bug fixes.
- `master`: Where the stable production ready code lies... | {
"label": "PalisadoesFoundation:develop",
"ref": "develop",
"sha": "8fb384f2b3d850e116b36439832306fd4c0ac556"
} | [
{
"number": 2341,
"title": "Mobile - Add support to recurring events.",
"body": "**Is your feature request related to a problem? Please describe.**\r\nImplement `recurring events` functionality into Talawa mobile. \r\n\r\n**Describe the solution you'd like**\r\n- The event creation screen(s) should have... | dart | Mobile - Add support to recurring events.
**Is your feature request related to a problem? Please describe.**
Implement `recurring events` functionality into Talawa mobile.
**Describe the solution you'd like**
- The event creation screen(s) should have functionality to create recurring events.
1. weeks
... | @palisadoes please have a look at this issue and do let me know if any follow ups and if I missedout on any thing.
@Azad99-9
You are requested to hold off for some time as there is currently a discussion underway regarding whether we should follow a denormalized approach or another one.
Once it is confirmed, there ... | https://github.com/PalisadoesFoundation/talawa/pull/2412 | [
"https://github.com/PalisadoesFoundation/talawa/issues/2341"
] | null | diff --git a/lib/constants/recurrence_values.dart b/lib/constants/recurrence_values.dart
new file mode 100644
index 0000000000..c6393aa06c
--- /dev/null
+++ b/lib/constants/recurrence_values.dart
@@ -0,0 +1,53 @@
+/// Class containing constants for recurrence options.
+class Recurrance {
+ /// Constant representing an... | diff --git a/test/helpers/setup_hive.mocks.dart b/test/helpers/setup_hive.mocks.dart
index dc67dfd0a5..8b4dfda4a8 100644
--- a/test/helpers/setup_hive.mocks.dart
+++ b/test/helpers/setup_hive.mocks.dart
@@ -1,5 +1,5 @@
-// Mocks generated by Mockito 5.4.3 from annotations
-// in talawa/test/utils/encryptor_test.dart.
+... | {} | {
"/home/talawa/test/utils/event_queries_test.dart: Tests for event_queries.dart Check if addEvent works correctly": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"/home/talawa/test/utils/event_queries_test.dart: Tests for event_queries.dart Check if registrantsByEvents works correctly": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/talawa/test/utils/event_queries_test.dart: Tests for event_queries.dart Check if updateEvent works correctly": {
... | {} |
PalisadoesFoundation__talawa-2350 | PalisadoesFoundation | talawa | 2,350 | closed | Post comments were invisible in Individual Post Page with Image | **What kind of change does this PR introduce?**
BugFix: Comments were not visible for posts with images.
**Issue Number:**
Fixes #2333
**Did you add tests for your changes?**
Yes
**Snapshots/Videos:**
https://github.com/PalisadoesFoundation/talawa/assets/93479496/2eb8603d-b3dc-48d2-9226-3d1af27... | {
"label": "PalisadoesFoundation:develop",
"ref": "develop",
"sha": "f314e5c2b6c1712ea8335e6f6a0f079a8a5c42f6"
} | [
{
"number": 2333,
"title": "Bug: Post comments are invisible in Individual Post Page.",
"body": "**Describe the bug**\r\n`Post comments` in `individual post page` are empty and `invisible` despite the `existence` of comments.\r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\n\r\n1. Login an... | dart | Bug: Post comments are invisible in Individual Post Page.
**Describe the bug**
`Post comments` in `individual post page` are empty and `invisible` despite the `existence` of comments.
**To Reproduce**
Steps to reproduce the behavior:
1. Login and Join an organisation.
2. Create a post in case of empty posts.
... | @noman2002 @Cioppolo14
Can you please assign this to me
I have found the cause of bug and will try to create a PR to fix this till tomorrow. | https://github.com/PalisadoesFoundation/talawa/pull/2350 | [
"https://github.com/PalisadoesFoundation/talawa/issues/2333"
] | null | diff --git a/lib/services/comment_service.dart b/lib/services/comment_service.dart
index 7b25338eb9..b118b6c003 100644
--- a/lib/services/comment_service.dart
+++ b/lib/services/comment_service.dart
@@ -4,7 +4,6 @@ import 'package:talawa/locator.dart';
import 'package:talawa/services/database_mutation_functions.dart';... | diff --git a/test/service_tests/comment_service_test.dart b/test/service_tests/comment_service_test.dart
index 71233621d7..4a8af56952 100644
--- a/test/service_tests/comment_service_test.dart
+++ b/test/service_tests/comment_service_test.dart
@@ -6,7 +6,6 @@ import 'package:talawa/locator.dart';
import 'package:talawa... | {} | {
"/home/talawa/test/utils/post_queries_test.dart: Tests for post_queries.dart Check if getPostById works correctly": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"/home/talawa/test/utils/comment_queries_test.dart: Tests for comment_queries.dart Check if getPostsComments works correctly": {
"... | {
"/home/talawa/test/utils/post_queries_test.dart: Tests for post_queries.dart Check if removeLike works correctly": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/talawa/test/utils/post_queries_test.dart: Tests for post_queries.dart Check if removePost works correctly": {
"run": "PASS",... | {} |
PalisadoesFoundation__talawa-2322 | PalisadoesFoundation | talawa | 2,322 | closed | converted private orgs to userRegistrationRequired orgs | <!--
This section can be deleted after reading.
We employ the following branching strategy to simplify the development process and to ensure that only stable code is pushed to the `master` branch:
- `develop`: For unstable code: New features and bug fixes.
- `master`: Where the stable production ready code lies... | {
"label": "PalisadoesFoundation:develop",
"ref": "develop",
"sha": "dce8ce0ddba752f6ac7df5ad273cf0b60f4aa7bd"
} | [
{
"number": 2287,
"title": "Mobile - Remove Support for Private Organizations",
"body": "**Is your feature request related to a problem? Please describe.**\r\nWe need to reduce and simplify some of the Talawa features. \r\n\r\nThe concept of private organizations is unlikely given that most organization... | dart | Mobile - Remove Support for Private Organizations
**Is your feature request related to a problem? Please describe.**
We need to reduce and simplify some of the Talawa features.
The concept of private organizations is unlikely given that most organizations using Talawa will be non-profits where transparency will be... | @noman2002 @Cioppolo14 @Kevoniat can any one of you please assign this issue to me. I would like to work on this.
Can I work on this issue?
@AVtheking If the issue has already been assigned, please don't ask to be assigned. We want everyone to get a chance.
@palisadoes a small clarification, the `membership request` fe... | https://github.com/PalisadoesFoundation/talawa/pull/2322 | [
"https://github.com/PalisadoesFoundation/talawa/issues/2287"
] | null | diff --git a/lib/models/organization/org_info.dart b/lib/models/organization/org_info.dart
index 1ab789ad52..28b790924c 100644
--- a/lib/models/organization/org_info.dart
+++ b/lib/models/organization/org_info.dart
@@ -14,7 +14,7 @@ class OrgInfo {
this.description,
this.id,
this.image,
- this.isPubli... | diff --git a/test/helpers/test_helpers.dart b/test/helpers/test_helpers.dart
index 71ebf67576..9de98325bc 100644
--- a/test/helpers/test_helpers.dart
+++ b/test/helpers/test_helpers.dart
@@ -111,7 +111,7 @@ final fakeOrgInfo = OrgInfo(
firstName: "ravidi",
lastName: "shaikh",
),
- isPublic: false,
+ user... | {
"/home/talawa/test/model_tests/user/user_info_test.dart: Tests for UserInfo.dart Check if print method works": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/talawa/test/model_tests/user/user_info_test.dart: Tests for UserInfo.dart Check if UserInfo.fromJson works with fromOrg": {
"run... | {} | {} | {} |
PalisadoesFoundation__talawa-2308 | PalisadoesFoundation | talawa | 2,308 | closed | fixed fetch events bug | <!--
This section can be deleted after reading.
We employ the following branching strategy to simplify the development process and to ensure that only stable code is pushed to the `master` branch:
- `develop`: For unstable code: New features and bug fixes.
- `master`: Where the stable production ready code lies... | {
"label": "PalisadoesFoundation:develop",
"ref": "develop",
"sha": "6d95344d7c4ecc07faa83683ded189cf547d2e3b"
} | [
{
"number": 2307,
"title": "Explore Events page is failing to fetch Events.",
"body": "**Describe the bug**\r\n**Explore Events page not working properly.**\r\nThe `Explore Events page` fails to retrieve events from the server, consistently displaying an `empty list message` on the screen despite the` e... | dart | Explore Events page is failing to fetch Events.
**Describe the bug**
**Explore Events page not working properly.**
The `Explore Events page` fails to retrieve events from the server, consistently displaying an `empty list message` on the screen despite the` existence of events` in the database.
**To Reproduce**
S... | @noman2002 @Cioppolo14 @Kevoniat please assign me this issue, I would like to work on this.
https://github.com/PalisadoesFoundation/talawa/issues/2195
This issue already exists and someone is working on it, the reason why events are not getting fetched because of same problem why you cannot create an event which is ... | https://github.com/PalisadoesFoundation/talawa/pull/2308 | [
"https://github.com/PalisadoesFoundation/talawa/issues/2307"
] | null | diff --git a/lib/utils/event_queries.dart b/lib/utils/event_queries.dart
index 23b06458b5..14c9e82e52 100644
--- a/lib/utils/event_queries.dart
+++ b/lib/utils/event_queries.dart
@@ -1,9 +1,15 @@
-// ignore_for_file: talawa_api_doc
-// ignore_for_file: talawa_good_doc_comments
-
///This class creates queries related t... | diff --git a/test/utils/event_queries_test.dart b/test/utils/event_queries_test.dart
index a3d03a86f4..cb9fe23fe9 100644
--- a/test/utils/event_queries_test.dart
+++ b/test/utils/event_queries_test.dart
@@ -1,6 +1,3 @@
-// ignore_for_file: talawa_api_doc
-// ignore_for_file: talawa_good_doc_comments
-
import 'package:... | {} | {
"Tests for event_queries.dart Check if fetchOrgEvents works correctly": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"Tests for event_queries.dart Check if registerForEvent works correctly": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"Tests for event_queries.dart Check if registrantsByEvents works correctly": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"Tests for event_queries.dart Che... | {} |
PalisadoesFoundation__talawa-2230 | PalisadoesFoundation | talawa | 2,230 | closed | Navigation Services Test Written | <!--
This section can be deleted after reading.
We employ the following branching strategy to simplify the development process and to ensure that only stable code is pushed to the `master` branch:
- `develop`: For unstable code: New features and bug fixes.
- `master`: Where the stable production ready code lies... | {
"label": "PalisadoesFoundation:develop",
"ref": "develop",
"sha": "82039eeb22fad52c3a48f4fd9a3af3594c78c992"
} | [
{
"number": 2158,
"title": "Write tests for service navigation_service.dart",
"body": "The Talawa code base needs to be 100% reliable. This means we need to have 100% unittest code coverage.\r\n\r\nWe will need unittests done for all methods, classes and functions found in this file.\r\n\r\nAny widgets ... | dart | Write tests for service navigation_service.dart
The Talawa code base needs to be 100% reliable. This means we need to have 100% unittest code coverage.
We will need unittests done for all methods, classes and functions found in this file.
Any widgets referenced in this file must also have unittests done
```
... | This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.
@palisadoes @noman2002
Can you assign this issue to me
@Manik2708 Assigned to you, please consider adding a profile picture. ... | https://github.com/PalisadoesFoundation/talawa/pull/2230 | [
"https://github.com/PalisadoesFoundation/talawa/issues/2158"
] | null | diff --git a/lib/services/navigation_service.dart b/lib/services/navigation_service.dart
index cc177b8d0a..508da99bd9 100644
--- a/lib/services/navigation_service.dart
+++ b/lib/services/navigation_service.dart
@@ -131,6 +131,7 @@ class NavigationService {
errorMessage: errorMessage,
),
bac... | diff --git a/test/service_tests/navigation_service_test.dart b/test/service_tests/navigation_service_test.dart
new file mode 100644
index 0000000000..13a90a35dd
--- /dev/null
+++ b/test/service_tests/navigation_service_test.dart
@@ -0,0 +1,563 @@
+import 'package:flutter/material.dart';
+import 'package:flutter_localiz... | {} | {
"Navigation Services Tests showTalawaErrorSnackBar() test with default duration": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"Navigation Services Tests showTalawaErrorSnackBar() test with custom duration": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {
"Navigation Services Tests pushScreen() test with arguments": {
"run": "NONE",
"test": "PASS",
"fix": "PASS"
},
"Navigation Services Tests removeAllAndPush() test with arguments": {
"run": "NONE",
"test": "PASS",
"fix": "PASS"
},
"Navigation Services Tests pop() method test": {
"... | {} |
PalisadoesFoundation__talawa-2220 | PalisadoesFoundation | talawa | 2,220 | closed | Tests for encryptor.dart written | <!--
This section can be deleted after reading.
We employ the following branching strategy to simplify the development process and to ensure that only stable code is pushed to the `master` branch:
- `develop`: For unstable code: New features and bug fixes.
- `master`: Where the stable production ready code lies... | {
"label": "PalisadoesFoundation:develop",
"ref": "develop",
"sha": "405f49da5360280343582c1c76514e70a1adc1f2"
} | [
{
"number": 2149,
"title": "Write tests for lib/utils/encryptor.dart",
"body": "The Talawa code base needs to be 100% reliable. This means we need to have 100% unittest code coverage. No functionality must be removed to achieve this goal.\r\n\r\nWe will need unittests done for all methods, classes and f... | dart | Write tests for lib/utils/encryptor.dart
The Talawa code base needs to be 100% reliable. This means we need to have 100% unittest code coverage. No functionality must be removed to achieve this goal.
We will need unittests done for all methods, classes and functions found in this file.
Any widgets referenced in t... | @Ayush0Chaudhary @noman2002 I would like to work on this issue.. can you please assign it to me?
Solve other issues first
@Ayush0Chaudhary @noman2002 Can you assign this issue to me?
There is a problem lying in the `generateRSAKeyPair()` function, the parameters passed in ` final random = SecureRandom('Fortuna')
... | https://github.com/PalisadoesFoundation/talawa/pull/2220 | [
"https://github.com/PalisadoesFoundation/talawa/issues/2149"
] | null | diff --git a/lib/main.dart b/lib/main.dart
index 19350a4cc3..7ec3b18905 100644
--- a/lib/main.dart
+++ b/lib/main.dart
@@ -15,6 +15,7 @@ import 'package:talawa/constants/custom_theme.dart';
import 'package:talawa/constants/quick_actions.dart';
import 'package:talawa/firebase_options.dart';
import 'package:talawa/loc... | diff --git a/test/helpers/setup_hive.dart b/test/helpers/setup_hive.dart
index cb9b87fbc5..55cc63be57 100644
--- a/test/helpers/setup_hive.dart
+++ b/test/helpers/setup_hive.dart
@@ -2,9 +2,22 @@
// ignore_for_file: talawa_good_doc_comments
import 'package:hive/hive.dart';
+import 'package:mockito/annotations.dart'... | {
"When shouldEncrypt is false For loadPairKey()": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"When shouldEncrypt is false encryptString method should return the same string": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"When shouldEncrypt is false For checking whether the... | {} | {} | {} |
PalisadoesFoundation__talawa-2216 | PalisadoesFoundation | talawa | 2,216 | closed | Fixing bug to join or switch to any joined org | **What kind of change does this PR introduce?**
Fix the bug to switch or join new org.
**Issue Number:**
Fixes #2199
**Did you add tests for your changes?**
No
**Have you read the [contributing guide](https://github.com/PalisadoesFoundation/talawa/blob/master/CONTRIBUTING.md)?**
Yes
| {
"label": "PalisadoesFoundation:develop",
"ref": "develop",
"sha": "63a420c20c55ae0cb99d79cbc0217ddfcb78fb63"
} | [
{
"number": 2199,
"title": "Switching organizations fails when organization exists",
"body": "**Describe the bug**\r\n- Please work with @Ayush0Chaudhary for comments, advice and review of your PR.\r\n- Switching organizations fails even when the organization exists\r\n- A `No organization found! Please... | dart | Switching organizations fails when organization exists
**Describe the bug**
- Please work with @Ayush0Chaudhary for comments, advice and review of your PR.
- Switching organizations fails even when the organization exists
- A `No organization found! Please contact your admin` message is seen
**To Reproduce**
Ste... | I would like to work on this issue. Can you please assign it to me?
I would like to work on this @noman2002 @palisadoes | https://github.com/PalisadoesFoundation/talawa/pull/2216 | [
"https://github.com/PalisadoesFoundation/talawa/issues/2199"
] | null | diff --git a/lib/models/organization/org_info.dart b/lib/models/organization/org_info.dart
index a72873f562..1ab789ad52 100644
--- a/lib/models/organization/org_info.dart
+++ b/lib/models/organization/org_info.dart
@@ -66,15 +66,25 @@ class OrgInfo {
///
/// **returns**:
/// * `List<OrgInfo>`: returning the Or... | diff --git a/test/model_tests/organization/org_info_test.dart b/test/model_tests/organization/org_info_test.dart
index 7e1ad7c1e1..fb96537579 100644
--- a/test/model_tests/organization/org_info_test.dart
+++ b/test/model_tests/organization/org_info_test.dart
@@ -106,5 +106,70 @@ void main() {
expect(result.adm... | {} | {
"Test OrgInfo model Test fromJsonToList with nested structures": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {
"Test OrgInfo model Test fromJson function with memberRequest false": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"Test OrgInfo model Test fromJson function with memberRequest true": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"Test OrgInfo model Test fromJsonToList": {
... | {} |
zulip__zulip-flutter-1952 | zulip | zulip-flutter | 1,952 | closed | compose: Fix bug where topic input not filled on quote-and-reply | Fixes #1469. | {
"label": "zulip:main",
"ref": "main",
"sha": "f5602fe60ebedce733e0a794e1377258dc97b2f0"
} | [
{
"number": 1469,
"title": "compose: On recent servers, quote-and-reply doesn't fill empty topic input",
"body": "To reproduce:\n\n1. Connect to CZO or another realm with feature level 334+\n2. Enter a channel narrow\n3. Long-press a message; tap \"Quote and reply\"\n4. See the content input update with... | dart | compose: On recent servers, quote-and-reply doesn't fill empty topic input
To reproduce:
1. Connect to CZO or another realm with feature level 334+
2. Enter a channel narrow
3. Long-press a message; tap "Quote and reply"
4. See the content input update with the quoted message
Expected: the topic input is automaticall... | null | https://github.com/zulip/zulip-flutter/pull/1952 | [
"https://github.com/zulip/zulip-flutter/issues/1469"
] | flutter test test/widgets/action_sheet_test.dart --reporter expanded 2>&1 | diff --git a/lib/widgets/action_sheet.dart b/lib/widgets/action_sheet.dart
index 30bbf433f5..c56e41d5c2 100644
--- a/lib/widgets/action_sheet.dart
+++ b/lib/widgets/action_sheet.dart
@@ -1409,7 +1409,7 @@ class QuoteAndReplyButton extends MessageActionSheetMenuItemButton {
composeBoxController!;
if (
c... | diff --git a/test/model/autocomplete_checks.dart b/test/model/autocomplete_checks.dart
index cb08378e77..65e3aaf755 100644
--- a/test/model/autocomplete_checks.dart
+++ b/test/model/autocomplete_checks.dart
@@ -10,6 +10,7 @@ extension ComposeContentControllerChecks on Subject<ComposeContentController> {
extension Co... | {} | {
"message action sheet QuoteAndReplyButton in channel narrow with empty topic": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {
"message action sheet StarButton star success": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"channel action sheet ChannelFeedButton from app bar on topic list: visible": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"channel action sheet UnsubscribeButton channel subscribed... | {} |
zulip__zulip-flutter-1915 | zulip | zulip-flutter | 1,915 | closed | all_channels: Replace three dot menu with long press gesture and add on tap to feed | Fixes #1914
<details>
<summary>Before and After still </summary>
### Page View
| Before | After |
| --- | --- |
|<img width="360" height="1200" alt="Screenshot_1761912198" src="https://github.com/user-attachments/assets/3f03cc3c-0322-4a53-b140-e7de74c565a2" /> | <img width="360" height="1200" alt="Screenshot_... | {
"label": "zulip:main",
"ref": "main",
"sha": "3781b308124cf43f04a1c0dd0dc86f15e558f967"
} | [
{
"number": 1914,
"title": "Make \"All channels\" view more similar to \"Channels\"",
"body": "\nWe should make the UI of the \"All channels\" view match the \"Channels\" view better:\n\n- Click on the row should navigate to the channel.\n- Long press should open the channel menu.\n- Remove the `...` bu... | dart | Make "All channels" view more similar to "Channels"
We should make the UI of the "All channels" view match the "Channels" view better:
- Click on the row should navigate to the channel.
- Long press should open the channel menu.
- Remove the `...` buttons, as users can follow the regular pattern of opening the menu w... | null | https://github.com/zulip/zulip-flutter/pull/1915 | [
"https://github.com/zulip/zulip-flutter/issues/1914"
] | flutter test test/widgets/all_channels_test.dart --reporter expanded 2>&1 | diff --git a/lib/widgets/all_channels.dart b/lib/widgets/all_channels.dart
index 3aaf0d8baf..7d662bcc2d 100644
--- a/lib/widgets/all_channels.dart
+++ b/lib/widgets/all_channels.dart
@@ -5,11 +5,13 @@ import '../api/route/channels.dart';
import '../generated/l10n/zulip_localizations.dart';
import '../log.dart';
impo... | diff --git a/test/widgets/all_channels_test.dart b/test/widgets/all_channels_test.dart
index b47546be40..f6e1092781 100644
--- a/test/widgets/all_channels_test.dart
+++ b/test/widgets/all_channels_test.dart
@@ -12,6 +12,7 @@ import 'package:zulip/widgets/app_bar.dart';
import 'package:zulip/widgets/button.dart';
impo... | {} | {
"navigate to channel feed on tap": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"sorting/appearance": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"open channel action sheet on long press": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {
"navigate to page from empty subscription list": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"use toggle switch to subscribe/unsubscribe": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"navigate to page": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"em... | {} |
zulip__zulip-flutter-1911 | zulip | zulip-flutter | 1,911 | closed | settings: Make page scrollable | | Before | After (Screenshot) |
| ------- | ------------------ |
|  |  |
| ![column_d](https://github.com/user-attachments/assets/d... | {
"label": "zulip:main",
"ref": "main",
"sha": "50bbf93941d184c79c680fbe65c2dc0d38d06441"
} | [
{
"number": 1904,
"title": "Settings page should scroll",
"body": "The settings page should be scrollable if the content doesn't all fit on the screen.\n\nCurrently there are only a few settings, so for most users this doesn't happen. But it can happen if the user has a very small screen (https://github... | dart | Settings page should scroll
The settings page should be scrollable if the content doesn't all fit on the screen.
Currently there are only a few settings, so for most users this doesn't happen. But it can happen if the user has a very small screen (https://github.com/zulip/zulip-flutter/issues/1898#issuecomment-3386032... | null | https://github.com/zulip/zulip-flutter/pull/1911 | [
"https://github.com/zulip/zulip-flutter/issues/1904"
] | flutter test test/widgets/settings_test.dart --reporter expanded 2>&1 | diff --git a/lib/widgets/settings.dart b/lib/widgets/settings.dart
index 5995cdcbfe..bad16c336b 100644
--- a/lib/widgets/settings.dart
+++ b/lib/widgets/settings.dart
@@ -20,7 +20,7 @@ class SettingsPage extends StatelessWidget {
return Scaffold(
appBar: ZulipAppBar(
title: Text(zulipLocalizations.... | diff --git a/test/widgets/settings_test.dart b/test/widgets/settings_test.dart
index e889fa0d3d..a56b93d7d9 100644
--- a/test/widgets/settings_test.dart
+++ b/test/widgets/settings_test.dart
@@ -64,6 +64,21 @@ void main() {
hasCheckedState: true, isChecked: expectedIsChecked);
}
+ testWidgets('SettingsPa... | {} | {
"SettingsPage is scrollable when taller than a screenful": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {
"BrowserPreference use our per-platform default browser preference (variant: TargetPlatform.android)": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"ThemeSetting smoke": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"ThemeSetting follow system setting when themeSetting is nu... | {} |
zulip__zulip-flutter-1909 | zulip | zulip-flutter | 1,909 | closed | Open uploaded files using authed temporary URLs | Fixes #1732.
| {
"label": "zulip:main",
"ref": "main",
"sha": "5599f64bf22288788e05c142054a165b2602b97a"
} | [
{
"number": 1732,
"title": "Open uploaded files without logging in again",
"body": "Currently if you're looking at a Zulip message that contains an uploaded file (other than an image or video, which we handle directly in the message feed) — for example a PDF — and you click the link to try to open the f... | dart | Open uploaded files without logging in again
Currently if you're looking at a Zulip message that contains an uploaded file (other than an image or video, which we handle directly in the message feed) — for example a PDF — and you click the link to try to open the file, you get a Zulip login page.
This ultimately works... | Describing this with different words to help with finding it in search (after #1834; thanks @varkor): you might say you're trying to open or download a file that's been shared in a Zulip message.
| https://github.com/zulip/zulip-flutter/pull/1909 | [
"https://github.com/zulip/zulip-flutter/issues/1732"
] | flutter test test/model/internal_link_test.dart test/widgets/actions_test.dart test/widgets/content_test.dart --reporter expanded 2>&1 | diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
index 9048fa98de..1f52ac32ba 100644
--- a/assets/l10n/app_en.arb
+++ b/assets/l10n/app_en.arb
@@ -329,6 +329,10 @@
"@errorCouldNotFetchMessageSource": {
"description": "Error message when the source of a message could not be fetched."
},
+ "errorC... | diff --git a/test/model/internal_link_test.dart b/test/model/internal_link_test.dart
index 74345f9811..c256286b6a 100644
--- a/test/model/internal_link_test.dart
+++ b/test/model/internal_link_test.dart
@@ -586,6 +586,34 @@ void main() {
});
});
});
+
+ group('parseInternalLink uploads', () {
+ for (... | {
"/home/zulip-flutter/test/widgets/content_test.dart: GlobalTime TwentyFourHourTimeMode.twentyFourHour": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/content_test.dart: strong (bold) in spoiler header (platform requests bold)": {
"run": "PASS",
"test": "... | {} | {} | {} |
zulip__zulip-flutter-1890 | zulip | zulip-flutter | 1,890 | closed | Confirm before unsubscribing (always, if from action sheet; only sometimes, if from "All channels") | Stacked atop #1887.
-----
Fixes #1827.
Fixes #1878.
| {
"label": "zulip:main",
"ref": "main",
"sha": "aaff63f2ef79ab53a4b7909ee11b0987fb9e3152"
} | [
{
"number": 1878,
"title": "Add warning when unsubscribing from private channel using toggle",
"body": "When unsubscribing from a private channel using the unsubscribe option in the three dot menu, the app shows a confirmation dialog with a warning that you might not be able to rejoin.\n\nHowever, when ... | dart | Add warning when unsubscribing from private channel using toggle
When unsubscribing from a private channel using the unsubscribe option in the three dot menu, the app shows a confirmation dialog with a warning that you might not be able to rejoin.
However, when unsubscribing using the toggle switch next to the channel... | Screenshot to clarify what I'm talking about:
<img src="https://github.com/user-attachments/assets/b1268a28-cda1-41d9-a411-b639b053c737" alt="Screenshot" width="350">
Warning here when we'd warn from the other UI makes sense to me.
Can I try this??
/attempt
@chrisbobbe can I work on this???
a snack bar like the one... | https://github.com/zulip/zulip-flutter/pull/1890 | [
"https://github.com/zulip/zulip-flutter/issues/1878",
"https://github.com/zulip/zulip-flutter/issues/1827"
] | flutter test test/widgets/action_sheet_test.dart test/widgets/all_channels_test.dart --reporter expanded 2>&1 | diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
index 2570578b6f..05598dab42 100644
--- a/assets/l10n/app_en.arb
+++ b/assets/l10n/app_en.arb
@@ -140,7 +140,7 @@
"@unsubscribeConfirmationDialogTitle": {
"description": "Title for a confirmation dialog for unsubscribing from a channel.",
"placeh... | diff --git a/test/widgets/action_sheet_test.dart b/test/widgets/action_sheet_test.dart
index e03e102cf5..22a4b06d8e 100644
--- a/test/widgets/action_sheet_test.dart
+++ b/test/widgets/action_sheet_test.dart
@@ -573,9 +573,15 @@ void main() {
connection.prepare(json: {});
await tapButton(tester);
- ... | {
"/home/zulip-flutter/test/widgets/all_channels_test.dart: Toggle \"off\" to unsubscribe, public channel": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/all_channels_test.dart: navigate to page from empty subscription list": {
"run": "NONE",
"test": "NONE... | {
"/home/zulip-flutter/test/widgets/all_channels_test.dart: Toggle \"off\" to unsubscribe, but without resubscribe permission": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/action_sheet_test.dart: channel action sheet UnsubscribeButton smoke, public channel": {
... | {
"/home/zulip-flutter/test/widgets/action_sheet_test.dart: message action sheet ReactionButtons tada adding success; useLegacy: false": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/action_sheet_test.dart: channel action sheet SubscribeButton channel subscribed":... | {} |
zulip__zulip-flutter-1887 | zulip | zulip-flutter | 1,887 | closed | action_sheet: Check can_subscribe_group for "Subscribe" confirmation dialog | Fixes #1786.
(Also fill in some test coverage for the change in cf83c9ec6 / #1822.) | {
"label": "zulip:main",
"ref": "main",
"sha": "38a2c63fd3bc5ac7bce88445c3d3e198c6f35a7b"
} | [
{
"number": 1786,
"title": "Check group-based permission to subscribe to a channel, as needed",
"body": "We should check the relevant permission:\n\n- ~~before deciding to show a \"Subscribe\" button in the channel action sheet (#1224)~~ (this was done in #1822)\n- to give a specific warning \"you won'... | dart | Check group-based permission to subscribe to a channel, as needed
We should check the relevant permission:
- ~~before deciding to show a "Subscribe" button in the channel action sheet (#1224)~~ (this was done in #1822)
- to give a specific warning "you won't have permission to resubscribe" in the confirmation dialog ... | null | https://github.com/zulip/zulip-flutter/pull/1887 | [
"https://github.com/zulip/zulip-flutter/issues/1786"
] | flutter test test/widgets/action_sheet_test.dart --reporter expanded 2>&1 | diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
index 73bcb373b0..89160f5bad 100644
--- a/assets/l10n/app_en.arb
+++ b/assets/l10n/app_en.arb
@@ -143,9 +143,9 @@
"channelName": {"type": "String", "example": "mobile"}
}
},
- "unsubscribeConfirmationDialogMessageMaybeCannotResubscribe": "Once... | diff --git a/test/model/test_store.dart b/test/model/test_store.dart
index e706f3139f..faf62412e4 100644
--- a/test/model/test_store.dart
+++ b/test/model/test_store.dart
@@ -319,6 +319,19 @@ extension PerAccountStoreTestExtension on PerAccountStore {
await handleEvent(ChannelCreateEvent(id: 1, streams: streams));... | {} | {
"channel action sheet UnsubscribeButton smoke, private channel": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"message action sheet StarButton star success": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"channel action sheet ChannelFeedButton from app bar on topic list: visible": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"channel action sheet UnsubscribeButton channel subscribed... | {} |
zulip__zulip-flutter-1879 | zulip | zulip-flutter | 1,879 | closed | home: Add icons label on main navigation bar. | **Key Changes:** (Screenshots Outdated)
| Dark Theme | Light Theme |
|---------|---------|
|  |  |
I have kept the he... | {
"label": "zulip:main",
"ref": "main",
"sha": "49d6226eca4641d6253534c3b20bd0a8ba36977f"
} | [
{
"number": 1857,
"title": "Label icons on main nav bar",
"body": "In the bottom nav bar on the home screens of the app, we want to show a text label along with the icon for each button.\n\nThis should also resolve the lack of such labels for screen readers, which was one of the points noted at https://... | dart | Label icons on main nav bar
In the bottom nav bar on the home screens of the app, we want to show a text label along with the icon for each button.
This should also resolve the lack of such labels for screen readers, which was one of the points noted at https://github.com/zulip/zulip-flutter/issues/535#issuecomment-29... |
@MritunjayTiwari14, would you check whether your #1879 resolves this issue, and if so then mark it as doing so?
Yes @gnprice , it can also fix it. In most app i checked out like Google and Whatsapp using TalkBack On. I noticed that both of them uses `<navbar_item_name> Tab` as a convention to announce the different b... | https://github.com/zulip/zulip-flutter/pull/1879 | [
"https://github.com/zulip/zulip-flutter/issues/1857",
"https://github.com/zulip/zulip-flutter/issues/1960"
] | flutter test test/widgets/home_test.dart test/widgets/recent_dm_conversations_test.dart --reporter expanded 2>&1 | diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
index 45c7e6ca94..38b49c2edd 100644
--- a/assets/l10n/app_en.arb
+++ b/assets/l10n/app_en.arb
@@ -1261,6 +1261,10 @@
"@wildcardMentionTopicDescription": {
"description": "Description for \"@topic\" wildcard-mention autocomplete options when writing a ... | diff --git a/test/widgets/home_test.dart b/test/widgets/home_test.dart
index 1ee0a0ae8e..239449c990 100644
--- a/test/widgets/home_test.dart
+++ b/test/widgets/home_test.dart
@@ -1,3 +1,5 @@
+import 'dart:ui';
+
import 'package:checks/checks.dart';
import 'package:flutter/material.dart';
import 'package:flutter_chec... | {
"/home/zulip-flutter/test/widgets/recent_dm_conversations_test.dart: RecentDmConversationsItem content/appearance 1:1 has right title/avatar muted user": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/recent_dm_conversations_test.dart: RecentDmConversationsItem c... | {} | {
"/home/zulip-flutter/test/widgets/home_test.dart: _LoadingPlaceholderPage after finishing loading, choose the loaded account": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/recent_dm_conversations_test.dart: RecentDmConversationsItem content/appearance group no ... | {} |
zulip__zulip-flutter-1877 | zulip | zulip-flutter | 1,877 | closed | Show channel/topic at top of channel/topic action sheet | Fixes #1533.
-----
<details>
<summary>Outdated screenshots; working on new ones…</summary>
| Channel | Topic |
| --- | --- |
| <img width="559" height="1062" alt="image" src="https://github.com/user-attachments/assets/d406808b-b358-4c6b-a707-05eefad13dcd" /> | <img width="559" height="1062" alt="image" src=... | {
"label": "zulip:main",
"ref": "main",
"sha": "cc2b97ec11ad8395eceb69e54abfe3f7aa16956c"
} | [
{
"number": 1533,
"title": "Show channel/topic at top of channel/topic action sheet",
"body": "When the user opens the channel action sheet or topic action sheet (e.g. by long-pressing on the channel or topic name somewhere), the resulting bottom sheet should show at the top the name of the channel, or ... | dart | Show channel/topic at top of channel/topic action sheet
When the user opens the channel action sheet or topic action sheet (e.g. by long-pressing on the channel or topic name somewhere), the resulting bottom sheet should show at the top the name of the channel, or the channel and topic, respectively.
### References
* ... | null | https://github.com/zulip/zulip-flutter/pull/1877 | [
"https://github.com/zulip/zulip-flutter/issues/1533"
] | flutter test test/widgets/action_sheet_test.dart --reporter expanded 2>&1 | diff --git a/lib/widgets/action_sheet.dart b/lib/widgets/action_sheet.dart
index 59be92482f..30bbf433f5 100644
--- a/lib/widgets/action_sheet.dart
+++ b/lib/widgets/action_sheet.dart
@@ -35,11 +35,20 @@ import 'text.dart';
import 'theme.dart';
import 'topic_list.dart';
+/// Show an action sheet with scrollable menu... | diff --git a/test/api/model/model_checks.dart b/test/api/model/model_checks.dart
index a7db054b55..5cb6df7c24 100644
--- a/test/api/model/model_checks.dart
+++ b/test/api/model/model_checks.dart
@@ -54,6 +54,9 @@ extension SavedSnippetChecks on Subject<SavedSnippet> {
extension ZulipStreamChecks on Subject<ZulipStre... | {} | {
"channel action sheet showChannelActionSheet header public channel": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"channel action sheet showChannelActionSheet header web-public channel": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"topic action sheet showTopicActionSheet h... | {
"message action sheet StarButton star success": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"channel action sheet ChannelFeedButton from app bar on topic list: visible": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"channel action sheet UnsubscribeButton channel subscribed... | {} |
zulip__zulip-flutter-1869 | zulip | zulip-flutter | 1,869 | closed | Rely on Zulip Server 6 APIs | Fixes #1837.
This isn't our most urgent issue, but I was looking for some low-hanging fruit I could clear during yesterday's heat wave when it was really hot and uncomfortable at home. :) | {
"label": "zulip:main",
"ref": "main",
"sha": "912f243b8ff45536b8e65112536e623e667627bb"
} | [
{
"number": 1837,
"title": "Rely on Zulip Server 6 APIs",
"body": "Since #1521, the app refuses to connect to servers older than Zulip Server 7. That means we can simplify away all the spots in our codebase where we have logic to accommodate older versions of the Zulip server.\n\nThe previous issue #268... | dart | Rely on Zulip Server 6 APIs
Since #1521, the app refuses to connect to servers older than Zulip Server 7. That means we can simplify away all the spots in our codebase where we have logic to accommodate older versions of the Zulip server.
The previous issue #268 was for removing the code for supporting Zulip Server 4,... | null | https://github.com/zulip/zulip-flutter/pull/1869 | [
"https://github.com/zulip/zulip-flutter/issues/1837"
] | flutter test test/model/channel_test.dart test/model/message_list_test.dart test/model/unreads_test.dart test/widgets/action_sheet_test.dart --reporter expanded 2>&1 | diff --git a/lib/api/core.dart b/lib/api/core.dart
index b4d05b5b34..7ac3f1f852 100644
--- a/lib/api/core.dart
+++ b/lib/api/core.dart
@@ -14,7 +14,7 @@ import 'exception.dart';
///
/// When updating this, also update [kMinSupportedZulipFeatureLevel]
/// and the README.
-// TODO(#992) address all TODO(server-6) and ... | diff --git a/test/example_data.dart b/test/example_data.dart
index 9bc82b9d6d..a26b94ff13 100644
--- a/test/example_data.dart
+++ b/test/example_data.dart
@@ -821,14 +821,13 @@ GetMessagesResult nearGetMessagesResult({
/// A GetMessagesResult the server might return when we request older messages.
GetMessagesResult o... | {
"/home/zulip-flutter/test/model/channel_test.dart: selfCanSendMessage, legacy \"member\" user can't post in channel with \"administrators\" policy": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/channel_test.dart: selfCanSendMessage, legacy \"moderator\" user can ... | {} | {
"/home/zulip-flutter/test/model/channel_test.dart: topic visibility events remove, as last in stream": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/action_sheet_test.dart: channel action sheet SubscribeButton channel subscribed": {
"run": "PASS",
"test"... | {} |
zulip__zulip-flutter-1863 | zulip | zulip-flutter | 1,863 | closed | channel: Implement modern group-based permission check for can-send-message | Fixes #1862. | {
"label": "zulip:main",
"ref": "main",
"sha": "690a0e5a3f9a81f1f2aafe2eb032e471ab681fcb"
} | [
{
"number": 1862,
"title": "Update can-send-message check to use modern group-based permission when available",
"body": "We have a permission check that controls which channels appear in the share-to-Zulip page, and also whether we offer a compose box in channels.\n\nWe should update it to use the moder... | dart | Update can-send-message check to use modern group-based permission when available
We have a permission check that controls which channels appear in the share-to-Zulip page, and also whether we offer a compose box in channels.
We should update it to use the modern `can_send_message_group` permission when that's availab... | null | https://github.com/zulip/zulip-flutter/pull/1863 | [
"https://github.com/zulip/zulip-flutter/issues/1862"
] | flutter test test/model/channel_test.dart --reporter expanded 2>&1 | diff --git a/lib/api/model/events.dart b/lib/api/model/events.dart
index 94bf662e30..5d86935186 100644
--- a/lib/api/model/events.dart
+++ b/lib/api/model/events.dart
@@ -680,6 +680,7 @@ class ChannelUpdateEvent extends ChannelEvent {
case ChannelPropertyName.canAddSubscribersGroup:
case ChannelPropertyNa... | diff --git a/test/example_data.dart b/test/example_data.dart
index 9a9eb1099e..9bc82b9d6d 100644
--- a/test/example_data.dart
+++ b/test/example_data.dart
@@ -461,9 +461,16 @@ ZulipStream stream({
GroupSettingValue? canAddSubscribersGroup,
GroupSettingValue? canDeleteAnyMessageGroup,
GroupSettingValue? canDele... | {
"selfCanSendMessage, legacy \"moderator\" user can post in channel with \"any\" policy": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"topic visibility willChangeIfTopicVisible/InStream stream not muted, policy none -> followed, no change": {
"run": "PASS",
"test": "NONE",
"fix": "P... | {} | {} | {} |
zulip__zulip-flutter-1853 | zulip | zulip-flutter | 1,853 | closed | initial_snapshot: Centralize group-permission defaults; fix admin permission for legacy servers | Fixes #1850.
Also does the refactor Greg suggested here: https://github.com/zulip/zulip-flutter/pull/1842#discussion_r2331337006 | {
"label": "zulip:main",
"ref": "main",
"sha": "da1d968f31813f206a5c980487c691ef2617b963"
} | [
{
"number": 1850,
"title": "Make `role:administrators` the default for `realm_can_delete_any_message_group`",
"body": "Server 10 added the `realm_can_delete_any_message_group` permission. For servers before that, we're meant to use `role:administrators` when deciding whether to show the \"delete message... | dart | Make `role:administrators` the default for `realm_can_delete_any_message_group`
Server 10 added the `realm_can_delete_any_message_group` permission. For servers before that, we're meant to use `role:administrators` when deciding whether to show the "delete message" button, but (with #1842, not yet merged) we'll actuall... | null | https://github.com/zulip/zulip-flutter/pull/1853 | [
"https://github.com/zulip/zulip-flutter/issues/1850"
] | flutter test test/model/message_test.dart test/model/realm_test.dart test/model/user_test.dart --reporter expanded 2>&1 | diff --git a/lib/api/model/initial_snapshot.dart b/lib/api/model/initial_snapshot.dart
index a8e99dde28..9250f75fa2 100644
--- a/lib/api/model/initial_snapshot.dart
+++ b/lib/api/model/initial_snapshot.dart
@@ -424,248 +424,3 @@ class UnreadHuddleSnapshot {
Map<String, dynamic> toJson() => _$UnreadHuddleSnapshotTo... | diff --git a/test/model/message_test.dart b/test/model/message_test.dart
index 7dbf28a47d..4eccf75112 100644
--- a/test/model/message_test.dart
+++ b/test/model/message_test.dart
@@ -868,7 +868,7 @@ void main() {
group('selfCanDeleteMessage', () {
/// Call the method, with setup from [params].
Future<bool>... | {
"/home/zulip-flutter/test/model/realm_test.dart: selfHasPermissionForGroupSetting guest -> no permission, despite group": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/realm_test.dart: customProfileFields update clobbers old list": {
"run": "PASS",
"test":... | {
"/home/zulip-flutter/test/model/message_test.dart: selfCanDeleteMessage legacy behavior pre-281 self-user is admin": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {
"/home/zulip-flutter/test/model/message_test.dart: handleMessageEvent from empty": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/message_test.dart: selfCanDeleteMessage legacy behavior pre-291 allowed (strict policy, high role)": {
"run": "NONE",
"test": "... | {} |
zulip__zulip-flutter-1840 | zulip | zulip-flutter | 1,840 | closed | msglist: Suppress bottom inset in top sliver, too | Fixes #1523.
Chris reported the issue, debugged, and wrote the core of the fix. I added the test, found that the left and right insets reappeared, debugged why, and added removeLeft and removeRight to fix those.
Co-authored-by: Chris Bobbe <cbobbe@zulip.com>
| {
"label": "zulip:main",
"ref": "main",
"sha": "b49ebf1d5a724004aa28ae52d72e70834e3f4c6d"
} | [
{
"number": 1523,
"title": "content/msglist: Horizontal scrollbar in code block sometimes has wrong vertical position (again)",
"body": "In a message-list page without a compose box, the scroll bar in a code block is misaligned, if it's in a message in the top sliver:\n\n| Bottom sliver (aligned correct... | dart | content/msglist: Horizontal scrollbar in code block sometimes has wrong vertical position (again)
In a message-list page without a compose box, the scroll bar in a code block is misaligned, if it's in a message in the top sliver:
| Bottom sliver (aligned correctly) | Top sliver (bug) |
| --- | --- |
| <img width="559"... | This seems to fix it; @gnprice, would you check this and send a PR, updating the regression test so it exercises the top-sliver case?
```diff
diff --git lib/widgets/message_list.dart lib/widgets/message_list.dart
index dcd063a62..071231412 100644
--- lib/widgets/message_list.dart
+++ lib/widgets/message_list.dart
@@ -... | https://github.com/zulip/zulip-flutter/pull/1840 | [
"https://github.com/zulip/zulip-flutter/issues/1523"
] | flutter test test/widgets/message_list_test.dart --reporter expanded 2>&1 | diff --git a/lib/widgets/message_list.dart b/lib/widgets/message_list.dart
index 6316655705..77e2e8cb24 100644
--- a/lib/widgets/message_list.dart
+++ b/lib/widgets/message_list.dart
@@ -1069,7 +1069,7 @@ class _MessageListState extends State<MessageList> with PerAccountStoreAwareStat
// The top sliver has its c... | diff --git a/test/widgets/message_list_test.dart b/test/widgets/message_list_test.dart
index 1755994cfd..acdde3fd2c 100644
--- a/test/widgets/message_list_test.dart
+++ b/test/widgets/message_list_test.dart
@@ -405,7 +405,31 @@ void main() {
});
group('presents message content appropriately', () {
- testWidg... | {} | {
"presents message content appropriately content not asked to consume insets (including bottom), even without compose box, in top sliver": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {
"app bar show topic visibility policy for topic narrows": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"fetch initial batch of messages topic permalink with message move": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"MessageListPage MessageListPageState.narrow": {
"run... | {} |
zulip__zulip-flutter-1822 | zulip | zulip-flutter | 1,822 | closed | Group-based permissions | Fixes #1687.
Fixes #814.
Stacked atop #1814.
This adds all the generic infrastructure needed for implementing any given group-based permission. The last commit (or pair of commits) then adds the permission "has content access (to a channel)" (which we'll want for #188), to demonstrate end-to-end how to add indiv... | {
"label": "zulip:main",
"ref": "main",
"sha": "e86e2352b89802536c6d9ec67e4c28ea27efdd74"
} | [
{
"number": 814,
"title": "Implement group-based permission checks",
"body": "In the Zulip API, we've recently introduced a new group-based permission system, where a realm's admins can define arbitrary user groups to use for permissions. This is more flexible than the old roles-based system, which has ... | dart | Implement group-based permission checks
In the Zulip API, we've recently introduced a new group-based permission system, where a realm's admins can define arbitrary user groups to use for permissions. This is more flexible than the old roles-based system, which has a fixed handful of roles like "admin", "moderator", or... | > - Implement some particular setting that uses the system, so we can demonstrate end-to-end that the implementation works.
The edit-topic permission is another candidate for this, used for
- #1159.
| https://github.com/zulip/zulip-flutter/pull/1822 | [
"https://github.com/zulip/zulip-flutter/issues/814",
"https://github.com/zulip/zulip-flutter/issues/1687"
] | flutter test test/model/realm_test.dart test/model/user_group_test.dart --reporter expanded 2>&1 | diff --git a/lib/api/model/events.dart b/lib/api/model/events.dart
index e472f151b7..2f0f846d49 100644
--- a/lib/api/model/events.dart
+++ b/lib/api/model/events.dart
@@ -34,7 +34,10 @@ sealed class Event {
switch (json['op'] as String) {
case 'add': return UserGroupAddEvent.fromJson(json);
... | diff --git a/test/example_data.dart b/test/example_data.dart
index 3e4da34b96..84d1abf6aa 100644
--- a/test/example_data.dart
+++ b/test/example_data.dart
@@ -198,6 +198,8 @@ int _lastUserGroupId = 100;
UserGroup userGroup({
int? id,
+ Iterable<int>? members,
+ Iterable<int>? directSubgroupIds,
String? name,... | {
"/home/zulip-flutter/test/model/realm_test.dart: processTopicLikeServer": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/user_group_test.dart: UserGroupUpdateEvent": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/r... | {} | {} | {} |
zulip__zulip-flutter-1820 | zulip | zulip-flutter | 1,820 | closed | content: Fix bugs where `TextSpan` styles clobber each other with `InlineContent.style` attributes | Fixes #806.
Fixes #1812.
Fixes #1817.
Fixes #1818.
There are other issues with inline-span styles:
- #1813
- #1819
- (possibly more)
but I think those all involve `WidgetSpan`s in `InlineContent`'s span tree and can be addressed separately.
| Before | After |
| --- | --- |
| <img width="559" height="10... | {
"label": "zulip:main",
"ref": "main",
"sha": "d9ab0757c0133e474cbf8f8a6ee16b338f74b0d7"
} | [
{
"number": 1817,
"title": "content: Bold text in strikethrough should have strikethrough line, but doesn't",
"body": null
},
{
"number": 806,
"title": "content: Inline code links should be rendered with the link color",
"body": "We should fix inline code's color when it is a part of a l... | dart | content: Bold text in strikethrough should have strikethrough line, but doesn't
content: Inline code links should be rendered with the link color
We should fix inline code's color when it is a part of a link.
| web (expected) | flutter |
| - | - |
| ![Screenshot from 2024-07-11 21-33-29](https://github.com/user-a... | https://github.com/zulip/zulip-flutter/pull/1820 | [
"https://github.com/zulip/zulip-flutter/issues/1817",
"https://github.com/zulip/zulip-flutter/issues/806",
"https://github.com/zulip/zulip-flutter/issues/1812",
"https://github.com/zulip/zulip-flutter/issues/1818"
] | flutter test test/model/content_test.dart test/widgets/content_test.dart --reporter expanded 2>&1 | diff --git a/lib/widgets/content.dart b/lib/widgets/content.dart
index 5851222a1c..3626d55ae4 100644
--- a/lib/widgets/content.dart
+++ b/lib/widgets/content.dart
@@ -1127,8 +1127,7 @@ class _InlineContentBuilder {
case UnicodeEmojiNode():
return TextSpan(text: node.emojiUnicode, recognizer: _recogniz... | diff --git a/test/model/content_test.dart b/test/model/content_test.dart
index 9cabfbb3b8..84e3baed42 100644
--- a/test/model/content_test.dart
+++ b/test/model/content_test.dart
@@ -85,6 +85,13 @@ class ContentExample {
'<p><strong>bold</strong></p>',
const StrongNode(nodes: [TextNode('bold')]));
+ static... | {} | {
"/home/zulip-flutter/test/widgets/content_test.dart: UnicodeEmoji has strike-through line in strike-through": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/content_test.dart: inline code is link-colored in link span": {
"run": "NONE",
"test": "FAIL",
... | {
"/home/zulip-flutter/test/widgets/content_test.dart: MessageImage, MessageImageList image with invalid src URL": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/content_test.dart: strong (bold) in different kind of span in table column header": {
"run": "PASS"... | {} | |
zulip__zulip-flutter-1806 | zulip | zulip-flutter | 1,806 | closed | Match insensitively to diacritics (autocomplete and new-DMs) | Fixes #237.
Fixes #1067. | {
"label": "zulip:main",
"ref": "main",
"sha": "e12673a24dfc3ffc4b37f251b62b9075bca41efa"
} | [
{
"number": 237,
"title": "autocomplete: In @-mention results, match insensitively to diacritics",
"body": "If there's a user with `Étienne` in their name, we should still include it in the results for the query `etienne`.\r\n\r\nThe matching is already case-insensitive, but it should be insensitive to ... | dart | autocomplete: In @-mention results, match insensitively to diacritics
If there's a user with `Étienne` in their name, we should still include it in the results for the query `etienne`.
The matching is already case-insensitive, but it should be insensitive to diacritics too.
For emoji autocomplete, match insensitivel... | (In principle this should also apply to user-group mentions, not just user mentions. User-group mention autocomplete hasn't been implemented yet: #233.)
Can we use something like [diacritic](https://github.com/agilord/diacritic)?
BTW I'm new here (and new to open source in general) so what is the policy when it comes ... | https://github.com/zulip/zulip-flutter/pull/1806 | [
"https://github.com/zulip/zulip-flutter/issues/237",
"https://github.com/zulip/zulip-flutter/issues/1067"
] | flutter test test/model/autocomplete_test.dart test/model/emoji_test.dart test/widgets/new_dm_sheet_test.dart --reporter expanded 2>&1 | diff --git a/lib/model/autocomplete.dart b/lib/model/autocomplete.dart
index 0b17f50b27..cf5c6b86e0 100644
--- a/lib/model/autocomplete.dart
+++ b/lib/model/autocomplete.dart
@@ -2,6 +2,7 @@ import 'dart:math';
import 'package:flutter/foundation.dart';
import 'package:flutter/services.dart';
+import 'package:unorm_... | diff --git a/test/model/autocomplete_test.dart b/test/model/autocomplete_test.dart
index 20f8adb6be..a560512553 100644
--- a/test/model/autocomplete_test.dart
+++ b/test/model/autocomplete_test.dart
@@ -27,9 +27,6 @@ import 'autocomplete_checks.dart';
typedef MarkedTextParse = ({int? expectedSyntaxStart, TextEditingVa... | {
"/home/zulip-flutter/test/model/autocomplete_test.dart: ComposeContentController.autocompleteIntent in \"—~@_abc^\", query \"abc\"": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/autocomplete_test.dart: ComposeContentController.autocompleteIntent no query in \":<^... | {
"/home/zulip-flutter/test/widgets/new_dm_sheet_test.dart: user filtering muted users excluded": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/new_dm_sheet_test.dart: user filtering search is case- and diacritics-insensitive": {
"run": "NONE",
"test": "FA... | {
"/home/zulip-flutter/test/widgets/new_dm_sheet_test.dart: navigation to DM Narrow navigates to 1:1 DM": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/new_dm_sheet_test.dart: navigation to DM Narrow navigates to group DM": {
"run": "PASS",
"test": "PASS",... | {} |
zulip__zulip-flutter-1797 | zulip | zulip-flutter | 1,797 | closed | startup: Add beta-complete dialog | Fixes #1603.
cc @alya
-----
<img width="559" height="1062" alt="image" src="https://github.com/user-attachments/assets/babf606f-f20f-44bf-8a48-b73334b41c36" />
<img width="340" height="755" alt="image" src="https://github.com/user-attachments/assets/8c36182e-9101-42d9-8fc7-30f5d9b82219" />
| {
"label": "zulip:beta-prelaunch",
"ref": "beta-prelaunch",
"sha": "888952bb73c1b999f37b2a9d36016935a78901dd"
} | [
{
"number": 1603,
"title": "Update to old beta channel saying app has moved",
"body": "Now that the app [has launched](https://blog.zulip.com/2025/06/17/flutter-mobile-app-launched/), we're publishing future releases to the main Zulip app's listings in the Play Store and App Store, and no longer to the ... | dart | Update to old beta channel saying app has moved
Now that the app [has launched](https://blog.zulip.com/2025/06/17/flutter-mobile-app-launched/), we're publishing future releases to the main Zulip app's listings in the Play Store and App Store, and no longer to the listings (in the Play Store and TestFlight) that were f... | > * When should the dialog appear? Options include just once; or on every startup of the app; or some more-complicated description in between.
I vote "on every startup of the app". It's easiest to implement, and I think the goal is to be assertive but stop short of a rug-pull where we just disable all the app's featur... | https://github.com/zulip/zulip-flutter/pull/1797 | [
"https://github.com/zulip/zulip-flutter/issues/1603"
] | flutter test test/notifications/open_test.dart test/widgets/app_test.dart test/widgets/home_test.dart test/widgets/login_test.dart --reporter expanded 2>&1 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 6ae781c17d..3adbb17987 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -22,8 +22,14 @@ jobs:
# so that Flutter knows its version and sees the constraint in our
# pubspec is satisfied. It's uncommon for flutter/... | diff --git a/test/notifications/open_test.dart b/test/notifications/open_test.dart
index a2c14ca20a..2e2eddc0b2 100644
--- a/test/notifications/open_test.dart
+++ b/test/notifications/open_test.dart
@@ -13,6 +13,7 @@ import 'package:zulip/model/narrow.dart';
import 'package:zulip/notifications/open.dart';
import 'pac... | {
"/home/zulip-flutter/test/notifications/open_test.dart: NotificationOpenService stream message (variant: TargetPlatform.android)": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/home_test.dart: logging out after fully loaded": {
"run": "PASS",
"test": "NO... | {} | {} | {} |
zulip__zulip-flutter-1794 | zulip | zulip-flutter | 1,794 | closed | action_sheet: Add 'Channel feed' button to channel action sheet | Fixes #1705.
## Screenshots
### From channel feed (no button)
<img width="559" height="1062" alt="image" src="https://github.com/user-attachments/assets/afb32f2a-1864-40ee-bb72-5768a655a84d" />
### Not from channel feed (button)
<img width="559" height="1062" alt="image" src="https://github.com/user-atta... | {
"label": "zulip:main",
"ref": "main",
"sha": "edeb05df0614c4fc7d8868b2c9f4ee819dae2419"
} | [
{
"number": 1705,
"title": "Add channel feed button to bottom sheet",
"body": "To improve navigation, we should add a \"Channel feed\" link to the bottom sheet for channels.\n\nCZO: [#mobile > channel feed link in bottom sheet?](https://chat.zulip.org/#narrow/channel/48-mobile/topic/channel.20feed.20lin... | dart | Add channel feed button to bottom sheet
To improve navigation, we should add a "Channel feed" link to the bottom sheet for channels.
CZO: [#mobile > channel feed link in bottom sheet?](https://chat.zulip.org/#narrow/channel/48-mobile/topic/channel.20feed.20link.20in.20bottom.20sheet.3F/with/2219497)
| It should probably be omitted if you're already on the channel's channel feed.
On web, we also omit it when just clicking on the channel name would take you to the channel feed. Might be fine to include the link on mobile, though, at least while the menu is short like it currently is. | https://github.com/zulip/zulip-flutter/pull/1794 | [
"https://github.com/zulip/zulip-flutter/issues/1705"
] | flutter test test/widgets/action_sheet_test.dart --reporter expanded 2>&1 | diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
index 56d906e233..776a866d3b 100644
--- a/assets/l10n/app_en.arb
+++ b/assets/l10n/app_en.arb
@@ -116,6 +116,10 @@
"@actionSheetOptionListOfTopics": {
"description": "Label for navigating to a channel's topic-list page."
},
+ "actionSheetOptionCha... | diff --git a/test/widgets/action_sheet_test.dart b/test/widgets/action_sheet_test.dart
index 83574786a7..8f4d614220 100644
--- a/test/widgets/action_sheet_test.dart
+++ b/test/widgets/action_sheet_test.dart
@@ -34,6 +34,7 @@ import 'package:zulip/widgets/message_list.dart';
import 'package:share_plus_platform_interfac... | {} | {
"channel action sheet ChannelFeedButton from app bar on topic list: visible": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"channel action sheet ChannelFeedButton from recipient header in combined feed: visible": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"channel action ... | {
"message action sheet StarButton star success": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"channel action sheet UnsubscribeButton channel subscribed": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"topic action sheet UserTopicUpdateButton check expected buttons isChannelM... | {} |
zulip__zulip-flutter-1793 | zulip | zulip-flutter | 1,793 | closed | Show last-active time on profile page | Fixes #1647.
There are probably ways the logic here can be improved. But we can do that in tandem with the relative times on the lightbox (#45), once we have ready access to CLDR data via FFI.
~~Draft because I want to write some tests before merging; my manual testing hasn't reached all the different cases in t... | {
"label": "zulip:main",
"ref": "main",
"sha": "c6fcbf6e24c64736095704497c8fd7d5638a81fb"
} | [
{
"number": 1647,
"title": "profile: Show when the user was last active",
"body": "On a user's profile, we should show the time they were last known to be active, e.g., \"5 hours ago\". For how to format the time, see #45."
}
] | dart | profile: Show when the user was last active
On a user's profile, we should show the time they were last known to be active, e.g., "5 hours ago". For how to format the time, see #45.
| Hi team 👋,
I'd love to work on this issue! I have experience with Flutter and handling datetime formatting. I can implement a user-friendly "last active" display using libraries like `timeago` or `intl` to show values such as:
Example implementaion code using `timeago`:-
```
import 'package:timeago/timeago.dart' as ... | https://github.com/zulip/zulip-flutter/pull/1793 | [
"https://github.com/zulip/zulip-flutter/issues/1647"
] | flutter test test/widgets/profile_test.dart --reporter expanded 2>&1 | diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
index 66ef1ee004..dedffe9b47 100644
--- a/assets/l10n/app_en.arb
+++ b/assets/l10n/app_en.arb
@@ -874,6 +874,50 @@
"@yesterday": {
"description": "Term to use to reference the previous day."
},
+ "userActiveNow": "Active now",
+ "@userActiveNow":... | diff --git a/test/widgets/profile_test.dart b/test/widgets/profile_test.dart
index a7b74356ab..c79e3fb5b9 100644
--- a/test/widgets/profile_test.dart
+++ b/test/widgets/profile_test.dart
@@ -1,6 +1,7 @@
import 'dart:io';
import 'package:checks/checks.dart';
+import 'package:clock/clock.dart';
import 'package:flutt... | {
"invisible mode smoke, turn on (variant: tapRow)": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"invisible mode request has an error (variant: tapRow)": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"invisible mode spam-tapping (variant: dragToggleThumb)": {
"run": "PASS... | {} | {} | {} |
zulip__zulip-flutter-1777 | zulip | zulip-flutter | 1,777 | closed | For uploads, use verbatim URL string from server | Fixes #1709.
## Commit messages
#### 314c83c09 api [nfc]: Rename field UploadFileResult.url from "uri"
Like elsewhere in our codebase, use the standard term "URL":
https://github.com/zulip/zulip-mobile/blob/main/docs/style.md#url-not-uri
#### c7f336c1e compose [nfc]: Take a URL string at inlineLink, ... | {
"label": "zulip:main",
"ref": "main",
"sha": "f9ea6c97390c7b07b6d1b9a36a1bad9991da19f8"
} | [
{
"number": 1709,
"title": "Uploaded file's URL gets percent-encoded, breaking permissions",
"body": "If someone sends a message with an uploaded file whose filename contains non-ASCII characters, we end up percent-encoding those characters in the URL in the message's link to the file.\n\nThe resulting ... | dart | Uploaded file's URL gets percent-encoded, breaking permissions
If someone sends a message with an uploaded file whose filename contains non-ASCII characters, we end up percent-encoding those characters in the URL in the message's link to the file.
The resulting behavior is that the file is visible to the person who or... | null | https://github.com/zulip/zulip-flutter/pull/1777 | [
"https://github.com/zulip/zulip-flutter/issues/1709"
] | flutter test test/api/route/messages_test.dart test/model/compose_test.dart test/widgets/compose_box_test.dart --reporter expanded 2>&1 | diff --git a/lib/api/route/messages.dart b/lib/api/route/messages.dart
index 05364951cd..44053bcc4a 100644
--- a/lib/api/route/messages.dart
+++ b/lib/api/route/messages.dart
@@ -315,10 +315,11 @@ Future<UploadFileResult> uploadFile(
@JsonSerializable(fieldRename: FieldRename.snake)
class UploadFileResult {
- fina... | diff --git a/test/api/route/messages_test.dart b/test/api/route/messages_test.dart
index f00bf4428f..a862b512b6 100644
--- a/test/api/route/messages_test.dart
+++ b/test/api/route/messages_test.dart
@@ -567,7 +567,7 @@ void main() {
required String? contentType,
}) async {
connection.prepare(json:
- ... | {
"/home/zulip-flutter/test/widgets/compose_box_test.dart: length validation content code points not counted unnecessarily": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/compose_test.dart: wrapWithBacktickFence whitespace around info string": {
"run": "PASS",
... | {} | {} | {} |
zulip__zulip-flutter-1775 | zulip | zulip-flutter | 1,775 | closed | autocomplete: Support user-group mentions; match users by email; rank results by match quality | Fixes #236.
Fixes #233.
Screenshots coming soon.
<img width="559" height="1062" alt="image" src="https://github.com/user-attachments/assets/594e5f84-fd8e-4800-816c-fd9ad49183ae" />
<img width="559" height="1062" alt="image" src="https://github.com/user-attachments/assets/62a7dbf5-3fb4-47ff-9598-f94a4446edb5" ... | {
"label": "zulip:main",
"ref": "main",
"sha": "58181da915402e7a959895b0831d632e9ad2a075"
} | [
{
"number": 233,
"title": "autocomplete: Support user-group @-mentions",
"body": "With #207 being merged, we now have an @-mention autocomplete UI for user mentions! 🎉\n\nWe should extend it to support autocompleting user-_group_ mentions, like `@*mobile*`.\n\n### Related issues\n\n- Prerequisite: #662... | dart | autocomplete: Support user-group @-mentions
With #207 being merged, we now have an @-mention autocomplete UI for user mentions! 🎉
We should extend it to support autocompleting user-_group_ mentions, like `@*mobile*`.
### Related issues
- Prerequisite: #662
autocomplete: Filter user-autocomplete results according to... | When implementing this, we should be sure to exclude deactivated groups from the results.
Until recently, such groups weren't included in the data the server gave us in the first place. Now they are:
* https://chat.zulip.org/#narrow/stream/378-api-design/topic/deactivated.20groups.20in.20.60GET.60.20endpoints/near/... | https://github.com/zulip/zulip-flutter/pull/1775 | [
"https://github.com/zulip/zulip-flutter/issues/233",
"https://github.com/zulip/zulip-flutter/issues/236"
] | flutter test test/model/autocomplete_test.dart test/model/compose_test.dart --reporter expanded 2>&1 | diff --git a/lib/model/autocomplete.dart b/lib/model/autocomplete.dart
index fe344189de..0b17f50b27 100644
--- a/lib/model/autocomplete.dart
+++ b/lib/model/autocomplete.dart
@@ -8,11 +8,11 @@ import '../api/model/model.dart';
import '../api/route/channels.dart';
import '../generated/l10n/zulip_localizations.dart';
... | diff --git a/test/model/autocomplete_checks.dart b/test/model/autocomplete_checks.dart
index ec8acbe500..cb08378e77 100644
--- a/test/model/autocomplete_checks.dart
+++ b/test/model/autocomplete_checks.dart
@@ -1,6 +1,7 @@
import 'package:checks/checks.dart';
import 'package:zulip/api/model/model.dart';
import 'pack... | {
"/home/zulip-flutter/test/model/autocomplete_test.dart: ComposeContentController.autocompleteIntent in \"—~@_abc^\", query \"abc\"": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/autocomplete_test.dart: MentionAutocompleteView sorting results compareByBotStatus bo... | {} | {} | {} |
zulip__zulip-flutter-1744 | zulip | zulip-flutter | 1,744 | closed | new-dm: Exclude deactivated users | Fixes #1743.
| {
"label": "zulip:main",
"ref": "main",
"sha": "0ce94c45f1951275734953ee795651241ec99fc3"
} | [
{
"number": 1743,
"title": "Exclude deactivated users in new-DM screen",
"body": "In the \"New DM\" screen, if you type a query that matches some deactivated users, they'll appear in the list.\n\nIf you then select them and go to the message list, the actual compose box is absent, replaced with an error... | dart | Exclude deactivated users in new-DM screen
In the "New DM" screen, if you type a query that matches some deactivated users, they'll appear in the list.
If you then select them and go to the message list, the actual compose box is absent, replaced with an error banner — because you can't actually send a DM to a deactiv... | null | https://github.com/zulip/zulip-flutter/pull/1744 | [
"https://github.com/zulip/zulip-flutter/issues/1743"
] | flutter test test/widgets/new_dm_sheet_test.dart --reporter expanded 2>&1 | diff --git a/lib/model/user.dart b/lib/model/user.dart
index aa4666c359..7d195e3197 100644
--- a/lib/model/user.dart
+++ b/lib/model/user.dart
@@ -35,7 +35,10 @@ mixin UserStore on PerAccountStoreBase, RealmStore {
/// Consider using [userDisplayName].
User? getUser(int userId);
- /// All known users in the re... | diff --git a/test/widgets/new_dm_sheet_test.dart b/test/widgets/new_dm_sheet_test.dart
index ae77e9643f..a95d42dc1a 100644
--- a/test/widgets/new_dm_sheet_test.dart
+++ b/test/widgets/new_dm_sheet_test.dart
@@ -116,24 +116,19 @@ void main() {
});
group('user filtering', () {
- final mutedUser = eg.user(fullN... | {} | {
"user filtering deactivated users excluded": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {
"user filtering shows empty state when no users match": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"user filtering search is case-insensitive": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"navigation to DM Narrow navigates to self DM": {
"run": "PASS",
"test": "P... | {} |
zulip__zulip-flutter-1730 | zulip | zulip-flutter | 1,730 | closed | Follow user's time format setting (12 or 24 hour) | Fixes #1015.
cc @alya for screenshots below. | {
"label": "zulip:main",
"ref": "main",
"sha": "3addf690bf1f4cb9f58484219cd6a28d2dd82c9d"
} | [
{
"number": 1015,
"title": "ui: Follow `user_settings.twenty_four_hour_time`",
"body": "When we show timestamps, for example on messages in the message list, we should format them according to the user's setting:\n\n- `user_settings.twenty_four_hour_time` true: \"13:52\"\n- `user_settings.twenty_four_ho... | dart | ui: Follow `user_settings.twenty_four_hour_time`
When we show timestamps, for example on messages in the message list, we should format them according to the user's setting:
- `user_settings.twenty_four_hour_time` true: "13:52"
- `user_settings.twenty_four_hour_time` false: "1:52 PM"
This is something we did in the z... | I would like to work on this issue if it has not been assigned to anyone else.
Please see the Zulip project's guide to claiming an issue: https://zulip.readthedocs.io/en/latest/contributing/contributing.html#in-other-zulip-repositories
In particular:
> In your comment, describe what part of the code you’re modify... | https://github.com/zulip/zulip-flutter/pull/1730 | [
"https://github.com/zulip/zulip-flutter/issues/1015"
] | flutter test test/api/route/settings_test.dart test/model/store_test.dart test/widgets/content_test.dart test/widgets/lightbox_test.dart test/widgets/message_list_test.dart --reporter expanded 2>&1 | diff --git a/lib/api/model/events.dart b/lib/api/model/events.dart
index bb3d7245e0..6070616387 100644
--- a/lib/api/model/events.dart
+++ b/lib/api/model/events.dart
@@ -175,6 +175,7 @@ class UserSettingsUpdateEvent extends Event {
final value = json['value'];
switch (UserSettingName.fromRawString(json['prop... | diff --git a/test/api/route/settings_test.dart b/test/api/route/settings_test.dart
index d2808ece02..8b31caa646 100644
--- a/test/api/route/settings_test.dart
+++ b/test/api/route/settings_test.dart
@@ -17,8 +17,8 @@ void main() {
for (final name in UserSettingName.values) {
switch (name) {
c... | {
"/home/zulip-flutter/test/model/store_test.dart: UpdateMachine.poll handles events": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/store_test.dart: UpdateMachine.registerNotificationToken on iOS, use provided app ID from packageInfo": {
"run": "PASS",
"tes... | {} | {} | {} |
zulip__zulip-flutter-1720 | zulip | zulip-flutter | 1,720 | closed | Render KaTeX by default | Fixes #46. (By enabling the TeX support whose substance was added over a number of preceding PRs.)
Here's a version of the commit I've included in each release recently, atop (previous versions of) #1559, to enable our KaTeX support. Now that #1559 and its preceding PRs (#1698, and others before that) are merged to ... | {
"label": "zulip:main",
"ref": "main",
"sha": "fe186b29a624fb4c348416504cf7101f57d9350e"
} | [
{
"number": 46,
"title": "TeX in the message list",
"body": "Zulip's Markdown flavor supports TeX for mathematical notation, using [KaTeX](https://katex.org/). This will be one of the more complex message-content features for us to support.\r\n\r\nThe way this works for web and for the existing RN-based... | dart | TeX in the message list
Zulip's Markdown flavor supports TeX for mathematical notation, using [KaTeX](https://katex.org/). This will be one of the more complex message-content features for us to support.
The way this works for web and for the existing RN-based mobile client is:
* KaTeX consists of some JavaScript c... | We got a request for this as beta feedback in the Google Play Console:
> Looks like there's no Latex support yet. This makes it a non-starter for our purposes unfortunately. Are there plans to bring that in soon?
And again today:
> Math doesn't work, glitches with links. I'll try again another time (love Zulip ge... | https://github.com/zulip/zulip-flutter/pull/1720 | [
"https://github.com/zulip/zulip-flutter/issues/46"
] | flutter test test/model/content_test.dart test/widgets/content_test.dart --reporter expanded 2>&1 | diff --git a/lib/model/settings.dart b/lib/model/settings.dart
index e8a309ac29..4e71224444 100644
--- a/lib/model/settings.dart
+++ b/lib/model/settings.dart
@@ -178,7 +178,7 @@ enum BoolGlobalSetting {
upgradeWelcomeDialogShown(GlobalSettingType.internal, false),
/// An experimental flag to toggle rendering K... | diff --git a/test/model/content_test.dart b/test/model/content_test.dart
index e4dd622b19..88bd11c66c 100644
--- a/test/model/content_test.dart
+++ b/test/model/content_test.dart
@@ -512,7 +512,7 @@ class ContentExample {
static final mathInline = ContentExample.inline(
'inline math',
r"$$ \lambda $$",
- ... | {} | {
"/home/zulip-flutter/test/widgets/content_test.dart: inline math smoke: inline math": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/content_test.dart: MathBlock smoke: math block": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"/home/zulip-flutter/test/widgets/content_test.dart: MessageImage, MessageImageList image with invalid src URL": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/content_test.dart: strong (bold) in different kind of span in table column header": {
"run": "PASS"... | {} |
zulip__zulip-flutter-1688 | zulip | zulip-flutter | 1,688 | closed | Add user groups to store and API binding | Fixes #662, toward #233 user-group @-mentions.
| {
"label": "zulip:main",
"ref": "main",
"sha": "37af86db63216f3693bc8ee649ef97aa6dd20b6e"
} | [
{
"number": 662,
"title": "Store user groups",
"body": "We should store the list of user groups in the realm, with their metadata ~~and their memberships~~, and keep the data up to date.\n\n(Memberships will be a separate issue: #1687.)\n\nThis data originates as `realm_user_groups` in the initial snaps... | dart | Store user groups
We should store the list of user groups in the realm, with their metadata ~~and their memberships~~, and keep the data up to date.
(Memberships will be a separate issue: #1687.)
This data originates as `realm_user_groups` in the initial snapshot at https://zulip.com/api/register-queue#response , and... | We're likely about to add a [client capability](https://zulip.com/api/register-queue#parameter-client_capabilities) on the server related to user groups, with a name like `allow_deactivated`:
https://chat.zulip.org/#narrow/stream/378-api-design/topic/deactivated.20groups.20in.20.60GET.60.20endpoints/near/1940349
So... | https://github.com/zulip/zulip-flutter/pull/1688 | [
"https://github.com/zulip/zulip-flutter/issues/662"
] | flutter test test/model/user_group_test.dart --reporter expanded 2>&1 | diff --git a/lib/api/model/events.dart b/lib/api/model/events.dart
index 6fd21e5c9a..b3f3844366 100644
--- a/lib/api/model/events.dart
+++ b/lib/api/model/events.dart
@@ -30,6 +30,14 @@ sealed class Event {
default: return UnexpectedEvent.fromJson(json);
}
case 'custom_profile_fields': return... | diff --git a/test/api/model/model_checks.dart b/test/api/model/model_checks.dart
index 262395d955..36b6396c97 100644
--- a/test/api/model/model_checks.dart
+++ b/test/api/model/model_checks.dart
@@ -2,6 +2,14 @@ import 'package:checks/checks.dart';
import 'package:zulip/api/model/model.dart';
import 'package:zulip/ap... | {
"activeGroups, allGroups": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"initialize": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"various fields make it through": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"getGroup": {
"run": "NONE",
"test"... | {} | {} | {} |
zulip__zulip-flutter-1686 | zulip | zulip-flutter | 1,686 | closed | store: Pass `dont_block` in first poll attempt after a failure | Fixes #979.
Discussion:
https://github.com/zulip/zulip-flutter/issues/979#issuecomment-2993296322
------
Tested manually, with and without this change:
1. Log out from CZO (too active; events coming in frequently); connect to a not-very-active org
2. Make an artificial network error in the `getEvents`... | {
"label": "zulip:main",
"ref": "main",
"sha": "4b75025cfa95222cee7df9084c4b8963d810ac4c"
} | [
{
"number": 979,
"title": "Loading indicator slow to go away when returning to app, though in fact up to date",
"body": "We added a loading indicator in #852 that appears when even queue polling fails with any error.\r\n\r\nHowever, it seems that the loading indicator can stay on even the event queue is... | dart | Loading indicator slow to go away when returning to app, though in fact up to date
We added a loading indicator in #852 that appears when even queue polling fails with any error.
However, it seems that the loading indicator can stay on even the event queue is doing fine, and does not go away until you get a new even... | Thanks for the report!
I don't think I've seen this symptom myself yet. It sounds reminiscent of this other event-queue-related symptom I saw once back in July:
* #809
but I haven't seen that one since then either.
I think this won't be actionable until we hear more reports of it happening, so I'll push it ou... | https://github.com/zulip/zulip-flutter/pull/1686 | [
"https://github.com/zulip/zulip-flutter/issues/979"
] | flutter test test/model/store_test.dart test/widgets/app_bar_test.dart --reporter expanded 2>&1 | diff --git a/lib/model/store.dart b/lib/model/store.dart
index 13a999aa37..9973cbc33e 100644
--- a/lib/model/store.dart
+++ b/lib/model/store.dart
@@ -582,12 +582,12 @@ class PerAccountStore extends PerAccountStoreBase with
_updateMachine = value;
}
- bool get isLoading => _isLoading;
- bool _isLoading = fa... | diff --git a/test/model/store_checks.dart b/test/model/store_checks.dart
index 93e24dffdd..c157ac2190 100644
--- a/test/model/store_checks.dart
+++ b/test/model/store_checks.dart
@@ -45,7 +45,7 @@ extension GlobalStoreChecks on Subject<GlobalStore> {
extension PerAccountStoreChecks on Subject<PerAccountStore> {
S... | {
"/home/zulip-flutter/test/model/store_test.dart: GlobalStore.perAccount account is logged out during transient-error backoff": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/app_bar_test.dart: buildTitle's willCenterTitle agrees with Material AppBar android": {
... | {} | {} | {} |
zulip__zulip-flutter-1650 | zulip | zulip-flutter | 1,650 | closed | msglist: Friendlier placeholder text when narrow has no messages (simple version) | Splitting this out from #1640, so it can be merged soon.
Fixes #1555.
For now, the text simply says "There are no messages here." We'll add per-narrow logic later, but this is an improvement over the current appearance which just says "No earlier messages." (Earlier than what?) | {
"label": "zulip:main",
"ref": "main",
"sha": "b509c24a87c1096d85f716f60ab3a1741644a676"
} | [
{
"number": 1555,
"title": "msglist: Friendlier placeholder text when narrow has no messages",
"body": "When a message list has no messages, we currently just show \"No earlier messages\". Screenshots for the narrows currently supported in the message-list page:\n\n| Combined feed | Channel | Topic | DM... | dart | msglist: Friendlier placeholder text when narrow has no messages
When a message list has no messages, we currently just show "No earlier messages". Screenshots for the narrows currently supported in the message-list page:
| Combined feed | Channel | Topic | DM (1:1) | DM (self) | DM (group) | Starred messages | Mentio... | "There are no messages here." is the default placeholder on web, which seems more clear ("earlier than what?").
But if it's comparably easy to do specific messages depending on the view, I would just copy whatever we have on web. If we don't like some of them, we can discuss that and change the web one too, but it mi... | https://github.com/zulip/zulip-flutter/pull/1650 | [
"https://github.com/zulip/zulip-flutter/issues/1555"
] | flutter test test/widgets/message_list_test.dart --reporter expanded 2>&1 | diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
index d7fd14303b..9b6c5f6532 100644
--- a/assets/l10n/app_en.arb
+++ b/assets/l10n/app_en.arb
@@ -530,6 +530,10 @@
"others": {"type": "String", "example": "Alice, Bob"}
}
},
+ "emptyMessageList": "There are no messages here.",
+ "@emptyMessag... | diff --git a/test/widgets/message_list_test.dart b/test/widgets/message_list_test.dart
index f1961fc809..dbcdf5ff1d 100644
--- a/test/widgets/message_list_test.dart
+++ b/test/widgets/message_list_test.dart
@@ -129,6 +129,9 @@ void main() {
return findScrollView(tester).controller;
}
+ final contentInputFind... | {
"app bar show topic visibility policy for topic narrows": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"fetch initial batch of messages topic permalink with message move": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"MessageListPage MessageListPageState.narrow": {
"run... | {} | {} | {} |
zulip__zulip-flutter-1625 | zulip | zulip-flutter | 1,625 | closed | msglist: Use icon for topic-list button in app bar | Our initial implementation of https://github.com/zulip/zulip-flutter/issues/1158, in https://github.com/zulip/zulip-flutter/pull/1500, uses the word "TOPICS" for the app-bar action/button leading to the topic-list page, following the design in Figma.
We want to change it to use a "list" icon instead. This is in orde... | {
"label": "zulip:main",
"ref": "main",
"sha": "79e0ca0834eda73840872535f0a950abcc9a4fba"
} | [
{
"number": 1532,
"title": "Use icon for topic-list button in app bar",
"body": "Our initial implementation of #1158, in #1500, uses the word \"TOPICS\" for the app-bar action/button leading to the topic-list page, following the design in Figma.\n\nWe want to change it to use a \"list\" icon instead. Th... | dart | Use icon for topic-list button in app bar
Our initial implementation of #1158, in #1500, uses the word "TOPICS" for the app-bar action/button leading to the topic-list page, following the design in Figma.
We want to change it to use a "list" icon instead. This is in order to let it occupy less space, especially in lan... | Do we know which specific icon we want?
Current "TOPICS" button:
<img width="818" alt="Image" src="https://github.com/user-attachments/assets/6c404d0d-c6bf-4be8-ab30-d1e9f2c2405a" />
Could be replaced with, e.g.:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=8996-27909&m=dev
<img width="... | https://github.com/zulip/zulip-flutter/pull/1625 | [
"https://github.com/zulip/zulip-flutter/issues/1532"
] | flutter test test/widgets/message_list_test.dart test/widgets/topic_list_test.dart --reporter expanded 2>&1 | diff --git a/assets/l10n/app_de.arb b/assets/l10n/app_de.arb
index aa89465183..819b687ea4 100644
--- a/assets/l10n/app_de.arb
+++ b/assets/l10n/app_de.arb
@@ -427,9 +427,9 @@
}
}
},
- "topicsButtonLabel": "THEMEN",
- "@topicsButtonLabel": {
- "description": "Label for message list button leading to ... | diff --git a/test/widgets/message_list_test.dart b/test/widgets/message_list_test.dart
index 70d204a101..d068e12ed5 100644
--- a/test/widgets/message_list_test.dart
+++ b/test/widgets/message_list_test.dart
@@ -288,7 +288,7 @@ void main() {
connection.prepare(json: GetStreamTopicsResult(topics: [
eg.get... | {
"/home/zulip-flutter/test/widgets/topic_list_test.dart: handle empty topics": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/topic_list_test.dart: unreads with and without unread mentions": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/... | {
"/home/zulip-flutter/test/widgets/message_list_test.dart: app bar has topic-list action for topic narrows": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/message_list_test.dart: app bar has topic-list action for channel narrows": {
"run": "PASS",
"test":... | {
"/home/zulip-flutter/test/widgets/message_list_test.dart: MessageListPage ancestorOf finds page state from message": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/topic_list_test.dart: app bar navigate to channel feed": {
"run": "PASS",
"test": "PASS",
... | {} |
zulip__zulip-flutter-1624 | zulip | zulip-flutter | 1,624 | closed | Show message content, sender, and timestamp in message action sheet | Fixes #217.
We've had some complaints about not being able to see the timestamps of messages in a run of messages from the same sender, e.g.:
[#mobile > Sent time not visible @ 💬](https://chat.zulip.org/#narrow/channel/48-mobile/topic/Sent.20time.20not.20visible/near/2201862)
> There is a "message sent" time sh... | {
"label": "zulip:main",
"ref": "main",
"sha": "9cc34cd7ef36684831632840139df178c7cc13b8"
} | [
{
"number": 217,
"title": "Show message text in bottom sheet",
"body": "In the redesigned message bottom sheet #90 from @terpimost, the top of the message sheet shows the message you're acting on.\r\n\r\nWe've left that part out of the scope of #90; this is a follow-up issue for adding it. See Figma des... | dart | Show message text in bottom sheet
In the redesigned message bottom sheet #90 from @terpimost, the top of the message sheet shows the message you're acting on.
We've left that part out of the scope of #90; this is a follow-up issue for adding it. See Figma design:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/... | Another option is to take a screenshot of the rendered message on which user has clicked and show top part of that, cutting out the rest:
<img width="764" alt="image" src="https://github.com/zulip/zulip-flutter/assets/1903309/a7874ea3-35f6-4463-8e05-7ad65bbb79b2">
It might be ok to copy that with a background:
<img ... | https://github.com/zulip/zulip-flutter/pull/1624 | [
"https://github.com/zulip/zulip-flutter/issues/217"
] | flutter test test/widgets/action_sheet_test.dart --reporter expanded 2>&1 | diff --git a/lib/model/content.dart b/lib/model/content.dart
index 79f3181963..e80247325f 100644
--- a/lib/model/content.dart
+++ b/lib/model/content.dart
@@ -1927,3 +1927,9 @@ class _ZulipContentParser {
ZulipContent parseContent(String html) {
return _ZulipContentParser().parse(html);
}
+
+ZulipMessageContent pa... | diff --git a/test/widgets/action_sheet_test.dart b/test/widgets/action_sheet_test.dart
index b2a3ed1de0..177aa43503 100644
--- a/test/widgets/action_sheet_test.dart
+++ b/test/widgets/action_sheet_test.dart
@@ -38,6 +38,7 @@ import '../api/fake_api.dart';
import '../example_data.dart' as eg;
import '../flutter_checks... | {} | {
"message action sheet header muted sender also shown": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"message action sheet header poll is rendered": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"message action sheet header message sender and content shown": {
"run": "NON... | {
"message action sheet StarButton star success": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"topic action sheet UserTopicUpdateButton check expected buttons isChannelMuted: (not subscribed), UserTopicVisibilityPolicy.none": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"cha... | {} |
zulip__zulip-flutter-1590 | zulip | zulip-flutter | 1,590 | closed | Welcome dialog on upgrade from legacy app | Fixes #1580.
Stacked atop #1588.
I believe this works correctly. Some tests would be nice to write, but are less critical than for #1070 / #1588.
### Screenshots
| dark | light |
| --- | --- |
|  | ... | {
"label": "zulip:main",
"ref": "main",
"sha": "6dc5a80d740d3ccd5ed3dc49c37b6da8c25b9977"
} | [
{
"number": 1580,
"title": "Show a welcome dialog on upgrading from legacy app",
"body": "When this app launches for the first time in an install that previously held the legacy app (following the launch, cf #715), we should show a brief dialog box to acknowledge the obvious that the app will look quite... | dart | Show a welcome dialog on upgrading from legacy app
When this app launches for the first time in an install that previously held the legacy app (following the launch, cf #715), we should show a brief dialog box to acknowledge the obvious that the app will look quite different, and to offer more information.
Here's text... | #1285 blocks doing links in prose, if it's translated. (In fact I'm not sure offhand how to make a link in _un_-translated text, except in the context of Zulip message content, and we don't have #488 yet.)
We can give the dialog an extra action button though. (For the implementation, maybe `showSuggestedActionDialog` ... | https://github.com/zulip/zulip-flutter/pull/1590 | [
"https://github.com/zulip/zulip-flutter/issues/1580"
] | flutter test test/model/database_test.dart test/widgets/dialog_test.dart --reporter expanded 2>&1 | diff --git a/lib/model/database.dart b/lib/model/database.dart
index 2811ae27d2..ca84fc949c 100644
--- a/lib/model/database.dart
+++ b/lib/model/database.dart
@@ -31,6 +31,9 @@ class GlobalSettings extends Table {
Column<String> get markReadOnScroll => textEnum<MarkReadOnScrollSetting>()
.nullable()();
+ Col... | diff --git a/test/model/database_test.dart b/test/model/database_test.dart
index e6e2b729be..e89bd569db 100644
--- a/test/model/database_test.dart
+++ b/test/model/database_test.dart
@@ -326,6 +326,8 @@ void main() {
check(globalSettings.browserPreference).isNull();
await after.close();
});
+
+ //... | {
"/home/zulip-flutter/test/model/database_test.dart: migrations (tearDownAll)": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
}
} | {
"/home/zulip-flutter/test/model/database_test.dart: migrations migrate without data from v6 to latest (v9)": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/database_test.dart: migrations migrate without data from v4 to latest (v9)": {
"run": "NONE",
"test":... | {
"/home/zulip-flutter/test/model/database_test.dart: migrations migrate without data from v3 to v4": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/database_test.dart: migrations upgrade to v2, with data": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
... | {} |
zulip__zulip-flutter-1574 | zulip | zulip-flutter | 1,574 | closed | Implement mark-as-read-on-scroll, v1 | (edited)
Fixes #81. 🎉
Still to do, but can be soon-after-launch:
- #1583
- #685 | {
"label": "zulip:main",
"ref": "main",
"sha": "a0241e0155ce0d253207cb2778a72b6f7de50c7d"
} | [
{
"number": 81,
"title": "Mark messages as read on scroll, configurably",
"body": "This Zulip feature: https://zulip.com/help/marking-messages-as-read#configure-whether-messages-are-automatically-marked-as-read\r\n\r\nThat means:\r\n* When scrolling through messages that are unread, by default mark them... | dart | Mark messages as read on scroll, configurably
This Zulip feature: https://zulip.com/help/marking-messages-as-read#configure-whether-messages-are-automatically-marked-as-read
That means:
* When scrolling through messages that are unread, by default mark them as read with a request to the server.
* Control that beha... | > Specifically, eagerly fade out the unread-message markers in the message list.
We might go further and eagerly update the model itself.
* The zulip-mobile RN app doesn't do this; the consequence is that it looks kind of glitchy as the "N unreads" banner at the top of the message list doesn't update or disappear i... | https://github.com/zulip/zulip-flutter/pull/1574 | [
"https://github.com/zulip/zulip-flutter/issues/81"
] | flutter test test/model/settings_test.dart test/widgets/action_sheet_test.dart test/widgets/autocomplete_test.dart test/widgets/compose_box_test.dart test/widgets/emoji_reaction_test.dart test/widgets/lightbox_test.dart test/widgets/message_list_test.dart --reporter expanded 2>&1 | diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
index e20d220aba..e03f421761 100644
--- a/assets/l10n/app_en.arb
+++ b/assets/l10n/app_en.arb
@@ -971,6 +971,30 @@
"@initialAnchorSettingNewestAlways": {
"description": "Label for a value of setting controlling initial anchor of message list."
},
... | diff --git a/test/model/schemas/drift_schema_v8.json b/test/model/schemas/drift_schema_v8.json
new file mode 100644
index 0000000000..62f8ca43d0
--- /dev/null
+++ b/test/model/schemas/drift_schema_v8.json
@@ -0,0 +1,1 @@
+{"_meta":{"description":"This file contains a serialized version of schema entities for drift.","v... | {
"/home/zulip-flutter/test/widgets/compose_box_test.dart: length validation content code points not counted unnecessarily": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/compose_box_test.dart: error banner in DMs with deactivated users 1:1 DMs active user becomes... | {} | {
"/home/zulip-flutter/test/model/settings_test.dart: getUrlLaunchMode globalSettings.browserPreference is external; follow the user preference (iOS)": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/settings_test.dart: getUrlLaunchMode globalSettings.browserPreferenc... | {} |
zulip__zulip-flutter-1566 | zulip | zulip-flutter | 1,566 | closed | anchors 10/n: Open /near/ links at message | Fixes #82.
This is the next round after #1515 — and completes #82, as well as bringing us close to #80. (These changes were previously sent as part of #1517.)
This branch is a draft only because of a lack of tests. The changes it does have are ready for review.
This doesn't implement the other aspect of the be... | {
"label": "zulip:main",
"ref": "main",
"sha": "211b545f35ab85301e1be68d8f352d69afd69e4b"
} | [
{
"number": 82,
"title": "Open a message list in the middle of history, when requested",
"body": "When the user takes an action that should navigate to a particular \"anchor\" message (like through #73 internal links, #76 deep links, or a notification), we should take them straight to that message, rath... | dart | Open a message list in the middle of history, when requested
When the user takes an action that should navigate to a particular "anchor" message (like through #73 internal links, #76 deep links, or a notification), we should take them straight to that message, rather than to the latest message or first unread message i... | Started working on this.
https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/Control.20scroll.20position.20on.20new.20and.20newly-fetched.20messages
https://github.com/user-attachments/assets/a379256e-3208-48b5-960c-7740a06fe497
https://github.com/user-attachments/assets/9feec67c-380e-4e92-9631-37a58ec8... | https://github.com/zulip/zulip-flutter/pull/1566 | [
"https://github.com/zulip/zulip-flutter/issues/82"
] | flutter test test/model/internal_link_test.dart test/model/message_list_test.dart test/widgets/content_test.dart test/widgets/message_list_test.dart --reporter expanded 2>&1 | diff --git a/lib/model/internal_link.dart b/lib/model/internal_link.dart
index 749f60698c..a552f1679f 100644
--- a/lib/model/internal_link.dart
+++ b/lib/model/internal_link.dart
@@ -109,22 +109,43 @@ Uri narrowLink(PerAccountStore store, Narrow narrow, {int? nearMessageId}) {
return result;
}
-/// A [Narrow] fro... | diff --git a/test/model/internal_link_test.dart b/test/model/internal_link_test.dart
index 611cc3ece0..824def8cc2 100644
--- a/test/model/internal_link_test.dart
+++ b/test/model/internal_link_test.dart
@@ -160,7 +160,14 @@ void main() {
test(urlString, () async {
final store = await setupStore(real... | {
"/home/zulip-flutter/test/model/internal_link_test.dart: parseInternalLink /#narrow/is/<...> returns corresponding narrow /#narrow/is/followed": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/internal_link_test.dart: parseInternalLink is-internal rejects triple sla... | {} | {
"/home/zulip-flutter/test/model/message_list_test.dart: fetchInitial recent senders track all the messages": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/message_list_test.dart: app bar has topic-list action for channel narrows": {
"run": "PASS",
"test"... | {} |
zulip__zulip-flutter-1517 | zulip | zulip-flutter | 1,517 | closed | anchors n/n: Open at first unread | Fixes #80.
This is stacked atop #1566.
This is marked as a draft only because of a lack of tests. The functionality is fully implemented, and otherwise ready for review.
---
This implementation has one key difference from the legacy app and from the original plan for #80:
When fetching at first unread, i... | {
"label": "zulip:main",
"ref": "main",
"sha": "211b545f35ab85301e1be68d8f352d69afd69e4b"
} | [
{
"number": 80,
"title": "Open message list at first unread, rather than latest message",
"body": "When navigating to a message list, our default behavior (if there isn't a specific message we're asked to go to) should be to show the first unread message, if any, and the messages around it.\r\n\r\nThis ... | dart | Open message list at first unread, rather than latest message
When navigating to a message list, our default behavior (if there isn't a specific message we're asked to go to) should be to show the first unread message, if any, and the messages around it.
This means
* fetching around the `first_unread` anchor (https... |
Started working on this.
https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/Control.20scroll.20position.20on.20new.20and.20newly-fetched.20messages
https://github.com/user-attachments/assets/a379256e-3208-48b5-960c-7740a06fe497
https://github.com/user-attachments/assets/9feec67c-380e-4e92-9631-37a58ec... | https://github.com/zulip/zulip-flutter/pull/1517 | [
"https://github.com/zulip/zulip-flutter/issues/80",
"https://github.com/zulip/zulip-flutter/issues/82"
] | flutter test test/model/internal_link_test.dart test/model/message_list_test.dart test/model/settings_test.dart test/widgets/content_test.dart test/widgets/message_list_test.dart test/widgets/settings_test.dart --reporter expanded 2>&1 | diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
index fb62815eef..1f070feb19 100644
--- a/assets/l10n/app_en.arb
+++ b/assets/l10n/app_en.arb
@@ -951,6 +951,26 @@
"@pollWidgetOptionsMissing": {
"description": "Text to display for a poll when it has no options"
},
+ "initialAnchorSettingTitle": ... | diff --git a/test/model/internal_link_test.dart b/test/model/internal_link_test.dart
index 611cc3ece0..824def8cc2 100644
--- a/test/model/internal_link_test.dart
+++ b/test/model/internal_link_test.dart
@@ -160,7 +160,14 @@ void main() {
test(urlString, () async {
final store = await setupStore(real... | {
"/home/zulip-flutter/test/model/internal_link_test.dart: parseInternalLink /#narrow/is/<...> returns corresponding narrow /#narrow/is/followed": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/internal_link_test.dart: parseInternalLink is-internal rejects triple sla... | {
"/home/zulip-flutter/test/widgets/message_list_test.dart: fetch initial batch of messages topic permalink with message move": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/message_list_test.dart: fetch initial batch of messages topic permalink without message mo... | {
"/home/zulip-flutter/test/model/message_list_test.dart: fetchInitial recent senders track all the messages": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/content_test.dart: strong (bold) in different kind of span in table column header": {
"run": "NONE",
... | {} |
zulip__zulip-flutter-1507 | zulip | zulip-flutter | 1,507 | closed | anchors 8/n: Let new messages accumulate in bottom sliver | Fixes #83. (As the "90% solution"; see https://github.com/zulip/zulip-flutter/issues/83#issuecomment-2917864412.)
This is the next round after #1468.
After this PR, not only does the last message from the initial fetch go into the bottom sliver, but it remains there even while new messages arrive as events, and t... | {
"label": "zulip:main",
"ref": "main",
"sha": "77ab9300a83045d6336946d73d55b3792c046413"
} | [
{
"number": 83,
"title": "Control scroll position on new and newly-fetched messages",
"body": "Currently if you're looking at the message list and then a new message comes in, you'll see the messages on the screen jump. This is exactly the right thing (*) if you're scrolled to the bottom — the new messa... | dart | Control scroll position on new and newly-fetched messages
Currently if you're looking at the message list and then a new message comes in, you'll see the messages on the screen jump. This is exactly the right thing (*) if you're scrolled to the bottom — the new message appears at the bottom, and the existing messages a... | This 90% solution:
> A good 90% solution here would be to build the message list out of two list slivers facing back to back, rather than one list sliver facing upward.
will happen as part of #82. So this issue tracks going further than that. | https://github.com/zulip/zulip-flutter/pull/1507 | [
"https://github.com/zulip/zulip-flutter/issues/83"
] | flutter test test/model/message_list_test.dart test/widgets/message_list_test.dart --reporter expanded 2>&1 | diff --git a/lib/model/message_list.dart b/lib/model/message_list.dart
index 2f8777d3ed..f2a45b78aa 100644
--- a/lib/model/message_list.dart
+++ b/lib/model/message_list.dart
@@ -70,11 +70,26 @@ mixin _MessageSequence {
/// A sequence number for invalidating stale fetches.
int generation = 0;
- /// The message... | diff --git a/test/model/message_list_test.dart b/test/model/message_list_test.dart
index bb85556ae9..ac41d771ec 100644
--- a/test/model/message_list_test.dart
+++ b/test/model/message_list_test.dart
@@ -1,6 +1,8 @@
import 'dart:convert';
import 'package:checks/checks.dart';
+import 'package:collection/collection.da... | {
"/home/zulip-flutter/test/model/message_list_test.dart: UserTopicEvent unmute a topic -> refetch from scratch": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/message_list_test.dart: fetchInitial recent senders track all the messages": {
"run": "PASS",
"tes... | {} | {
"/home/zulip-flutter/test/widgets/message_list_test.dart: MessageListPage ancestorOf finds page state from message": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/message_list_test.dart: MessageListPage composeBoxState null when no compose box": {
"run": "PA... | {} |
zulip__zulip-flutter-1453 | zulip | zulip-flutter | 1,453 | closed | local echo (7/7): Support simplified version of local echo | Fixes #1441.
Stacked atop #1472.
(This branch can be used to preview the full implementation)
<details>
<summary> screenshots </summary>
| message sent | got message event |
| - | - |
|  | ![sendin... | {
"label": "zulip:main",
"ref": "main",
"sha": "3ef9de648cf88c8c21fd8e7fff87d96b75126bd0"
} | [
{
"number": 1441,
"title": "Simplified local echo, with retry",
"body": "### Background\n\nThis is a new proposed spec for handling the same user need as the following previous issue:\n* #720 \n\nThe point is to better handle the case where you type out a message and hit send, and it fails because you d... | dart | Simplified local echo, with retry
### Background
This is a new proposed spec for handling the same user need as the following previous issue:
* #720
The point is to better handle the case where you type out a message and hit send, and it fails because you don't have working network at that moment. The current behavi... | null | https://github.com/zulip/zulip-flutter/pull/1453 | [
"https://github.com/zulip/zulip-flutter/issues/1441"
] | flutter test test/widgets/compose_box_test.dart test/widgets/message_list_test.dart --reporter expanded 2>&1 | diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
index 1f070feb19..0d3f273d16 100644
--- a/assets/l10n/app_en.arb
+++ b/assets/l10n/app_en.arb
@@ -385,9 +385,9 @@
"@discardDraftForEditConfirmationDialogMessage": {
"description": "Message for a confirmation dialog for discarding message text that was... | diff --git a/test/widgets/compose_box_test.dart b/test/widgets/compose_box_test.dart
index c25b00793e..70f0913316 100644
--- a/test/widgets/compose_box_test.dart
+++ b/test/widgets/compose_box_test.dart
@@ -1530,6 +1530,165 @@ void main() {
}
}
+ group('restoreMessageNotSent', () {
+ final channel = eg.st... | {
"/home/zulip-flutter/test/widgets/compose_box_test.dart: auto focus ChannelNarrow, empty fetch": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/message_list_test.dart: MessageListPage composeBoxState finds compose box": {
"run": "PASS",
"test": "NONE",
... | {} | {
"/home/zulip-flutter/test/widgets/compose_box_test.dart: length validation content code points not counted unnecessarily": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/message_list_test.dart: MessageListPage ancestorOf finds page state from message": {
"run... | {} |
zulip__zulip-flutter-1451 | zulip | zulip-flutter | 1,451 | closed | notif: Use live value for app ID on registering APNs token | Fixes #407
Changes made:
- Replaced the hardcoded app bundle ID with `packageInfo.packageName`.
- Added a new test that sets a specific appId via packageInfo and confirms it’s used in a notification request.
The first change caused the "token initially unknown" test in `store_test.dart` to fail due to the adde... | {
"label": "zulip:main",
"ref": "main",
"sha": "5c812e703cff0aa7b689b2095e0b10574e97313e"
} | [
{
"number": 407,
"title": "notif: Use live value for app ID on registering APNs token",
"body": "In my draft for #321 I have a TODO like this:\r\n```dart\r\n case TargetPlatform.iOS:\r\n const appBundleId = 'com.zulip.flutter'; // TODO find actual value live\r\n await registerApnsToke... | dart | notif: Use live value for app ID on registering APNs token
In my draft for #321 I have a TODO like this:
```dart
case TargetPlatform.iOS:
const appBundleId = 'com.zulip.flutter'; // TODO find actual value live
await registerApnsToken(connection, token: token, appid: appBundleId);
```
This ... | My approach to solve the issue:
1. Update ZulipBinding to provide package info: Add a method in ZulipBinding to return the package name. This method will wrap the call to PackageInfo.fromPlatform() and make it test-friendly.
2. Override the method in TestZulipBinding: In the TestZulipBinding, override getAppBundleId ... | https://github.com/zulip/zulip-flutter/pull/1451 | [
"https://github.com/zulip/zulip-flutter/issues/407"
] | flutter test test/api/core_test.dart test/model/store_test.dart --reporter expanded 2>&1 | diff --git a/lib/model/binding.dart b/lib/model/binding.dart
index 94435631ac..198e0ae119 100644
--- a/lib/model/binding.dart
+++ b/lib/model/binding.dart
@@ -310,10 +310,12 @@ class LinuxDeviceInfo implements BaseDeviceInfo {
class PackageInfo {
final String version;
final String buildNumber;
+ final String pa... | diff --git a/test/api/core_test.dart b/test/api/core_test.dart
index 297dcfc441..e2c6e72ecb 100644
--- a/test/api/core_test.dart
+++ b/test/api/core_test.dart
@@ -460,7 +460,7 @@ void main() {
});
}
- const packageInfo = PackageInfo(version: '0.0.1', buildNumber: '1');
+ final packageInfo = eg.packa... | {
"/home/zulip-flutter/test/model/store_test.dart: UpdateMachine.poll handles events": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/store_test.dart: UpdateMachine.registerNotificationToken on iOS, use provided app ID from packageInfo": {
"run": "NONE",
"tes... | {} | {} | {} |
zulip__zulip-flutter-1428 | zulip | zulip-flutter | 1,428 | closed | Fix DB downgrades to match creating from scratch | Fixes #1427.
Prerequisite for #1421.
## Selected commit messages
#### f64450168 db test: Fix migration tests to use intended source versions
The `fromVersion` reference inside this test body, for each of the
test cases, was referring to the same one, mutable `fromVersion`
variable. So by the time any of ... | {
"label": "zulip:main",
"ref": "main",
"sha": "47f3e6aa52265bd0dadd1b82d11c62dba9d9286f"
} | [
{
"number": 1427,
"title": "Schema downgrades fail (from future schema versions)",
"body": "In #1416, we should have adjusted `AppDatabase._dropAndCreateAll` to reflect the change that PR made to the `onCreate` in `migration`, making it insert the GlobalSettings row.\r\n\r\n(Originally noticed this at h... | dart | Schema downgrades fail (from future schema versions)
In #1416, we should have adjusted `AppDatabase._dropAndCreateAll` to reflect the change that PR made to the `onCreate` in `migration`, making it insert the GlobalSettings row.
(Originally noticed this at https://github.com/zulip/zulip-flutter/issues/1421#issuecomm... | null | https://github.com/zulip/zulip-flutter/pull/1428 | [
"https://github.com/zulip/zulip-flutter/issues/1427"
] | flutter test test/model/database_test.dart --reporter expanded 2>&1 | diff --git a/lib/model/database.dart b/lib/model/database.dart
index 6393294438..ed6cba5f74 100644
--- a/lib/model/database.dart
+++ b/lib/model/database.dart
@@ -68,65 +68,44 @@ class UriConverter extends TypeConverter<Uri, String> {
@override Uri fromSql(String fromDb) => Uri.parse(fromDb);
}
-// TODO(drift): g... | diff --git a/test/model/database_test.dart b/test/model/database_test.dart
index c6245bc5cc..3d7e8f170d 100644
--- a/test/model/database_test.dart
+++ b/test/model/database_test.dart
@@ -127,7 +127,8 @@ void main() {
});
test('downgrading', () async {
- final schema = await verifier.schemaAt(2);
+ ... | {
"migrations migrate without data from v1 to v2": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"migrations downgrading": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"migrations upgrade to v5: with existing GlobalSettings row, do nothing": {
"run": "PASS",
"test": "N... | {} | {} | {} |
zulip__zulip-flutter-1400 | zulip | zulip-flutter | 1,400 | closed | Support setting browser preference | Fixes #1228.
This is taken from #1167, addressing the reviews there. | {
"label": "zulip:main",
"ref": "main",
"sha": "4409c1c39459e64c5a90c445845cc8687613a3da"
} | [
{
"number": 1228,
"title": "Offer \"Open links with in-app browser\" setting",
"body": "Like we do in the legacy apps.\r\n\r\nAn instance of:\r\n- #97"
}
] | dart | Offer "Open links with in-app browser" setting
Like we do in the legacy apps.
An instance of:
- #97
| null | https://github.com/zulip/zulip-flutter/pull/1400 | [
"https://github.com/zulip/zulip-flutter/issues/1228"
] | flutter test test/model/database_test.dart test/model/settings_test.dart test/widgets/content_test.dart test/widgets/profile_test.dart test/widgets/settings_test.dart --reporter expanded 2>&1 | diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
index 7f37a00dad..1973f5fab7 100644
--- a/assets/l10n/app_en.arb
+++ b/assets/l10n/app_en.arb
@@ -811,6 +811,10 @@
"@themeSettingSystem": {
"description": "Label for system theme setting."
},
+ "openLinksWithInAppBrowser": "Open links with in-app ... | diff --git a/test/example_data.dart b/test/example_data.dart
index 03cabbda97..955f5dacfb 100644
--- a/test/example_data.dart
+++ b/test/example_data.dart
@@ -880,9 +880,11 @@ ChannelUpdateEvent channelUpdateEvent(
GlobalSettingsData globalSettings({
ThemeSetting? themeSetting,
+ BrowserPreference? browserPrefer... | {
"/home/zulip-flutter/test/model/settings_test.dart: getUrlLaunchMode globalSettings.browserPreference is null; use our per-platform defaults for HTTP links (Android)": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/content_test.dart: strong (bold) in spoiler head... | {} | {} | {} |
zulip__zulip-flutter-1379 | zulip | zulip-flutter | 1,379 | closed | notif ios: Handle opening of conversation on tap; take 2 | Fixes #1147.
2nd attempt, first attempt was #1261. This one uses pigeon to move most of the notification payload handling to dart side (and doesn't use/rely on `zulip://notification` URL). | {
"label": "zulip:main",
"ref": "main",
"sha": "11f05dc3747f6383473fbafec20ebe575b9fc94e"
} | [
{
"number": 1147,
"title": "ios notifs: Support tapping a notification to open the conversation",
"body": "Like #123, but for iOS.\r\n\r\nWhen you tap a new-message notification, we should open the message's conversation."
}
] | dart | ios notifs: Support tapping a notification to open the conversation
Like #123, but for iOS.
When you tap a new-message notification, we should open the message's conversation.
| Beta feedback requesting this: https://chat.zulip.org/#narrow/channel/48-mobile/topic/beta.20feedback.3A.20.28ios.29.20notifications.20should.20open.20conversation/near/2067876 | https://github.com/zulip/zulip-flutter/pull/1379 | [
"https://github.com/zulip/zulip-flutter/issues/1147"
] | flutter test test/model/store_test.dart test/notifications/display_test.dart test/notifications/open_test.dart test/widgets/store_test.dart --reporter expanded 2>&1 | diff --git a/android/app/src/main/kotlin/com/zulip/flutter/Notifications.g.kt b/android/app/src/main/kotlin/com/zulip/flutter/AndroidNotifications.g.kt
similarity index 94%
rename from android/app/src/main/kotlin/com/zulip/flutter/Notifications.g.kt
rename to android/app/src/main/kotlin/com/zulip/flutter/AndroidNotific... | diff --git a/test/model/binding.dart b/test/model/binding.dart
index 2c70b68826..839242c1ce 100644
--- a/test/model/binding.dart
+++ b/test/model/binding.dart
@@ -8,6 +8,7 @@ import 'package:flutter/services.dart';
import 'package:test/fake.dart';
import 'package:url_launcher/url_launcher.dart' as url_launcher;
impo... | {
"/home/zulip-flutter/test/model/store_test.dart: UpdateMachine.poll handles events": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/store_test.dart: UpdateMachine.registerNotificationToken on iOS, use provided app ID from packageInfo": {
"run": "NONE",
"tes... | {} | {} | {} |
zulip__zulip-flutter-1340 | zulip | zulip-flutter | 1,340 | closed | store: Ensure sole ownership of MessageListView | Fixes #1358.
PerAccountStore shouldn't be an owner of the MessageListView elements.
Its relationship to MessageListView is similar to that of AutocompleteViewManager to MentionAutocompleteView (#645).
With two owners, the MessageListView can be disposed twice:
1. before the frame is rendered, `removeAccount... | {
"label": "zulip:main",
"ref": "main",
"sha": "1e8397be156ab603a89c2b024a12d4e2028e1acc"
} | [
{
"number": 1358,
"title": "MessageListView could be disposed twice",
"body": "This is the issue thread for the bug fixed by:\n* #1340 \n\nSee also chat thread:\nhttps://chat.zulip.org/#narrow/channel/243-mobile-team/topic/MessageListView.20lifecycle/near/2083074\n\nI believe this was a crash bug — the ... | dart | MessageListView could be disposed twice
This is the issue thread for the bug fixed by:
* #1340
See also chat thread:
https://chat.zulip.org/#narrow/channel/243-mobile-team/topic/MessageListView.20lifecycle/near/2083074
I believe this was a crash bug — the stack trace in #1340 was while the Flutter framework is updat... | null | https://github.com/zulip/zulip-flutter/pull/1340 | [
"https://github.com/zulip/zulip-flutter/issues/1358"
] | flutter test test/model/actions_test.dart test/model/message_test.dart test/model/store_test.dart test/widgets/actions_test.dart test/widgets/home_test.dart test/widgets/message_list_test.dart test/widgets/store_test.dart --reporter expanded 2>&1 | diff --git a/lib/model/actions.dart b/lib/model/actions.dart
new file mode 100644
index 0000000000..a88eea0777
--- /dev/null
+++ b/lib/model/actions.dart
@@ -0,0 +1,36 @@
+import 'dart:async';
+
+import '../notifications/receive.dart';
+import 'store.dart';
+
+// TODO: Make this a part of GlobalStore
+Future<void> logO... | diff --git a/test/model/actions_test.dart b/test/model/actions_test.dart
new file mode 100644
index 0000000000..e24bb3223c
--- /dev/null
+++ b/test/model/actions_test.dart
@@ -0,0 +1,188 @@
+import 'package:checks/checks.dart';
+import 'package:flutter/foundation.dart';
+import 'package:flutter_test/flutter_test.dart';... | {
"/home/zulip-flutter/test/model/store_test.dart: UpdateMachine.poll handles events": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/store_test.dart: UpdateMachine.poll reloads immediately on expired queue": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"... | {} | {
"/home/zulip-flutter/test/model/message_test.dart: handleMessageEvent from empty": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/message_test.dart: handleUpdateMessageEvent rendering-only update does not change timestamp": {
"run": "PASS",
"test": "PASS",
... | {} |
zulip__zulip-flutter-1312 | zulip | zulip-flutter | 1,312 | closed | anchors 2/n: Fix three sticky-header bugs | Fixes #1309.
Fixes #725. (which is the same underlying bug)
In addition to that live bug in the app (involving scrollOffsetCorrection, which we previously weren't handling), the last two commits in this branch fix a couple of bugs in the `sticky_header` library that were latent bugs in the app — they can only trigg... | {
"label": "zulip:main",
"ref": "main",
"sha": "c66a9053eed5ce60a010ceefea98f92e6f09c43f"
} | [
{
"number": 1309,
"title": "Gap in message list",
"body": "There's a symptom I've seen happen just a couple of times, and just now while working on the sticky-header code (for #82) I realized what's causing it and how to fix it.\n\nRepro recipe:\n* Scroll up in history, a screenful or two past some mess... | dart | Gap in message list
There's a symptom I've seen happen just a couple of times, and just now while working on the sticky-header code (for #82) I realized what's causing it and how to fix it.
Repro recipe:
* Scroll up in history, a screenful or two past some message that you sent and can still edit.
* From a different c... |
Moving this to the post-launch milestone because it's only ever happened the one time as far as I know, and it's been a couple of months since then.
If we see it another time or two, or hear a user report of it, we can bump it back up in priority. | https://github.com/zulip/zulip-flutter/pull/1312 | [
"https://github.com/zulip/zulip-flutter/issues/1309",
"https://github.com/zulip/zulip-flutter/issues/725"
] | flutter test test/widgets/sticky_header_test.dart --reporter expanded 2>&1 | diff --git a/lib/example/sticky_header.dart b/lib/example/sticky_header.dart
new file mode 100644
index 0000000000..3fa2185c1a
--- /dev/null
+++ b/lib/example/sticky_header.dart
@@ -0,0 +1,428 @@
+/// Example app for exercising the sticky_header library.
+///
+/// This is useful when developing changes to [StickyHeader... | diff --git a/test/widgets/sticky_header_test.dart b/test/widgets/sticky_header_test.dart
index fc363c71e8..c283652ae1 100644
--- a/test/widgets/sticky_header_test.dart
+++ b/test/widgets/sticky_header_test.dart
@@ -103,6 +103,116 @@ void main() {
}
}
}
+
+ testWidgets('sticky headers: propagate scrollOf... | {} | {
"sticky headers: propagate scrollOffsetCorrection properly": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"sliver only part of viewport, header at end": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {
"sticky headers: RTL scroll forward, header at end, GrowthDirection.forward, headers bounded": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"sticky headers: RTL scroll forward, header at end, GrowthDirection.reverse, headers overflow": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
... | {} |
zulip__zulip-flutter-1311 | zulip | zulip-flutter | 1,311 | closed | Handle moved messages for unreads | Fixes #901. (**edit**, after splitting that issue.)
Work toward #901
I prioritized updating unreads data for moved messages because it is more visible after supporting the resolve/unresolve topic actions. Updating recent senders data will be a follow-up to this. | {
"label": "zulip:main",
"ref": "main",
"sha": "b0307378c4b513d3fe320259be34ab61df49dfa6"
} | [
{
"number": 901,
"title": "Handle moved messages in unreads data",
"body": "With #787 we implemented most of #150, handling moved messages. But as that PR description said:\n> Fixes most of https://github.com/zulip/zulip-flutter/issues/150. (After this lands we should do a quick scan to identify anythin... | dart | Handle moved messages in unreads data
With #787 we implemented most of #150, handling moved messages. But as that PR description said:
> Fixes most of https://github.com/zulip/zulip-flutter/issues/150. (After this lands we should do a quick scan to identify anything else that needs updating on message moves — there are... | The key user-facing scenario where this comes up, which I happened to see again earlier today:
* You're reading messages in Combined feed.
* A topic gets resolved, containing some unread messages.
* The messages are still unread, and shown with the blue unread marker at left. If you tap the recipient header to navig... | https://github.com/zulip/zulip-flutter/pull/1311 | [
"https://github.com/zulip/zulip-flutter/issues/901"
] | flutter test test/api/model/events_test.dart test/model/message_list_test.dart test/model/unreads_test.dart --reporter expanded 2>&1 | diff --git a/lib/api/model/events.dart b/lib/api/model/events.dart
index 9faa3d367e..985f5b5803 100644
--- a/lib/api/model/events.dart
+++ b/lib/api/model/events.dart
@@ -718,16 +718,8 @@ class UpdateMessageEvent extends Event {
// final String? streamName; // ignore
- @JsonKey(name: 'stream_id')
- final int? ... | diff --git a/test/api/model/events_checks.dart b/test/api/model/events_checks.dart
index c1fa0a117f..12d74479de 100644
--- a/test/api/model/events_checks.dart
+++ b/test/api/model/events_checks.dart
@@ -48,11 +48,7 @@ extension UpdateMessageEventChecks on Subject<UpdateMessageEvent> {
Subject<List<int>> get messageI... | {
"/home/zulip-flutter/test/model/message_list_test.dart: messagesMoved in topic narrow moved from narrow: should remove moved messages (channel, topic) -> (channel, new topic)": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/message_list_test.dart: UserTopicEvent un... | {} | {} | {} |
zulip__zulip-flutter-1266 | zulip | zulip-flutter | 1,266 | closed | Distinguish a TopicName type from plain String | Toward #1250.
Fixes #1205.
This PR introduces a new type `TopicName` as a Dart "extension type":
https://dart.dev/language/extension-types
At runtime it's just a String — so there's no performance cost to it — but the type-checker tracks the distinction.
This lets us readily find all the spots in the code that... | {
"label": "zulip:main",
"ref": "main",
"sha": "35d83f2192b3b6ae41b89d9ed2367e738e9ff12c"
} | [
{
"number": 1205,
"title": "android: Notification grouping should treat topics case-insensitively",
"body": "We use Android's \"inbox style\" notifications (this was #128 / PR #718) to group notifications by conversation.\r\n\r\nFor channel messages, this means grouping messages by topic. Topics in Zuli... | dart | android: Notification grouping should treat topics case-insensitively
We use Android's "inbox style" notifications (this was #128 / PR #718) to group notifications by conversation.
For channel messages, this means grouping messages by topic. Topics in Zulip are meant to be case-insensitive, so we should ignore case ... | > See our notification-display code for getting a message's "conversation key". It just takes the topic literally without normalizing it by case:
(I assume the server isn't normalizing it for us.)
Generally, the server always tries to preserve case when passing data around, since you often do want to display with th... | https://github.com/zulip/zulip-flutter/pull/1266 | [
"https://github.com/zulip/zulip-flutter/issues/1205"
] | flutter test test/api/model/events_test.dart test/api/model/initial_snapshot_test.dart test/api/model/model_test.dart test/api/notifications_test.dart test/api/route/channels_test.dart test/api/route/messages_test.dart test/api/route/typing_test.dart test/model/autocomplete_test.dart test/model/channel_test.dart test/m... | diff --git a/lib/api/model/events.dart b/lib/api/model/events.dart
index 837aab120f..f543144ce1 100644
--- a/lib/api/model/events.dart
+++ b/lib/api/model/events.dart
@@ -645,7 +645,7 @@ class UserTopicEvent extends Event {
String get type => 'user_topic';
final int streamId;
- final String topicName;
+ final... | diff --git a/test/api/model/events_checks.dart b/test/api/model/events_checks.dart
index f95c6b4362..c1fa0a117f 100644
--- a/test/api/model/events_checks.dart
+++ b/test/api/model/events_checks.dart
@@ -51,8 +51,8 @@ extension UpdateMessageEventChecks on Subject<UpdateMessageEvent> {
Subject<int?> get origStreamId =... | {
"/home/zulip-flutter/test/api/model/events_test.dart: user_settings: all known settings have event handling": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/api/model/model_test.dart: MessageEditState topic resolved in edit history Topic was resolved but it also moved in... | {} | {} | {} |
zulip__zulip-flutter-1239 | zulip | zulip-flutter | 1,239 | closed | compose: Enforce max topic/content length by code points, following API | Fixes #1238.
Done by computing `String.runes` (the number of Unicode code points) unless we know that the result can't exceed the threshold number of code points. In particular, we don't compute it unless `String.length` (the number of UTF-16 code units) exceeds the threshold number of code points. | {
"label": "zulip:main",
"ref": "main",
"sha": "70343d4c3baa709d87c3ba381923a50cfccb1106"
} | [
{
"number": 1238,
"title": "compose: Enforce max topic/content length by Unicode code points, not UTF-16 code units",
"body": "We have this comment where we decide if the content input is too long:\r\n\r\n```dart\r\n // normalized.length is the number of UTF-16 code units, while the server\r\n ... | dart | compose: Enforce max topic/content length by Unicode code points, not UTF-16 code units
We have this comment where we decide if the content input is too long:
```dart
// normalized.length is the number of UTF-16 code units, while the server
// API expresses the max in Unicode code points. So this compa... | null | https://github.com/zulip/zulip-flutter/pull/1239 | [
"https://github.com/zulip/zulip-flutter/issues/1238"
] | flutter test test/widgets/app_test.dart test/widgets/compose_box_test.dart --reporter expanded 2>&1 | diff --git a/lib/api/route/messages.dart b/lib/api/route/messages.dart
index 3374741c51..be6728c790 100644
--- a/lib/api/route/messages.dart
+++ b/lib/api/route/messages.dart
@@ -156,7 +156,7 @@ class GetMessagesResult {
}
// https://zulip.com/api/send-message#parameter-topic
-const int kMaxTopicLength = 60;
+const... | diff --git a/test/widgets/app_test.dart b/test/widgets/app_test.dart
index 8c992533ee..af386bfdf1 100644
--- a/test/widgets/app_test.dart
+++ b/test/widgets/app_test.dart
@@ -280,14 +280,14 @@ void main() {
check(ZulipApp.ready).value.isFalse();
await tester.pump();
check(findSnackBarByText(message... | {
"/home/zulip-flutter/test/widgets/compose_box_test.dart: length validation content code points not counted unnecessarily": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/compose_box_test.dart: ComposeBox typing notices smoke DmNarrow": {
"run": "PASS",
"t... | {} | {
"/home/zulip-flutter/test/widgets/app_test.dart: scaffoldMessenger reportErrorToUserBriefly(null) does not dismiss dialog": {
"run": "NONE",
"test": "PASS",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/app_test.dart: scaffoldMessenger scaffoldMessenger becomes non-null after startup": {
"r... | {} |
zulip__zulip-flutter-1112 | zulip | zulip-flutter | 1,112 | closed | Rank emoji results in autocomplete | Fixes #1068.
As is, this PR applies to the results of autocomplete in the compose box (when you type a colon `:`). In combination with #1103 adding an emoji picker, it applies to the results in the emoji picker too, because that PR reuses the same autocomplete machinery.
This mimics the ranking in the web client ... | {
"label": "zulip:main",
"ref": "main",
"sha": "be4196efbe16a9af330510a9709a7038e039a21e"
} | [
{
"number": 1068,
"title": "Rank emoji autocomplete results",
"body": "For the initial implementation of #670, there won't be a useful ordering to the results. This means a user might have to type a longer, more specific query to find their desired emoji than they might with good ranking.\r\n\r\nThis is... | dart | Rank emoji autocomplete results
For the initial implementation of #670, there won't be a useful ordering to the results. This means a user might have to type a longer, more specific query to find their desired emoji than they might with good ranking.
This issue is for ranking the results. The ranking should match wh... | null | https://github.com/zulip/zulip-flutter/pull/1112 | [
"https://github.com/zulip/zulip-flutter/issues/1068"
] | flutter test test/model/algorithms_test.dart test/model/emoji_test.dart --reporter expanded 2>&1 | diff --git a/lib/model/algorithms.dart b/lib/model/algorithms.dart
index 7c03a88d80..93bcb188ee 100644
--- a/lib/model/algorithms.dart
+++ b/lib/model/algorithms.dart
@@ -116,3 +116,67 @@ QueueList<int> setUnion(Iterable<int> xs, Iterable<int> ys) {
}
return result;
}
+
+/// Sort the items by bucket, stably,
+//... | diff --git a/test/model/algorithms_test.dart b/test/model/algorithms_test.dart
index b6def6393e..4dc3772105 100644
--- a/test/model/algorithms_test.dart
+++ b/test/model/algorithms_test.dart
@@ -1,5 +1,7 @@
+import 'dart:math';
import 'package:checks/checks.dart';
+import 'package:collection/collection.dart';
impor... | {
"/home/zulip-flutter/test/model/algorithms_test.dart: setUnion comparison is numeric, not lexicographic": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/algorithms_test.dart: setUnion nonempty, empty": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},... | {} | {} | {} |
zulip__zulip-flutter-1106 | zulip | zulip-flutter | 1,106 | closed | Make topic headers case-insensitive | Topics in Zulip are case-insensitive. This change makes the message list's topic headers match that behavior, so messages whose topics differ only in case (like "missing string" and "Missing string") share a single header. This brings the behavior in line with Zulip web.
### What is the change?
The change modifi... | {
"label": "zulip:main",
"ref": "main",
"sha": "6070a7f1950e15846e081a7f0abb686b8974164b"
} | [
{
"number": 739,
"title": "Extra recipient header when topic changes case",
"body": "If you visit the thread `#translation > Missing string` on chat.zulip.org, around this message (the first one in today's thread):\r\nhttps://chat.zulip.org/#narrow/stream/58-translation/topic/Missing.20string/near/18283... | dart | Extra recipient header when topic changes case
If you visit the thread `#translation > Missing string` on chat.zulip.org, around this message (the first one in today's thread):
https://chat.zulip.org/#narrow/stream/58-translation/topic/Missing.20string/near/1828362
you'll find it gets its own recipient header, even... | We had a second report of the issue today, with a screenshot:
https://chat.zulip.org/#narrow/stream/48-mobile/topic/Case.20sensitivity.20in.20topics/near/1954248
| https://github.com/zulip/zulip-flutter/pull/1106 | [
"https://github.com/zulip/zulip-flutter/issues/739"
] | flutter test test/model/message_list_test.dart --reporter expanded 2>&1 | diff --git a/lib/model/message_list.dart b/lib/model/message_list.dart
index 440d12f2b8..ecfb16c2b9 100644
--- a/lib/model/message_list.dart
+++ b/lib/model/message_list.dart
@@ -352,7 +352,7 @@ mixin _MessageSequence {
bool haveSameRecipient(Message prevMessage, Message message) {
if (prevMessage is StreamMessage ... | diff --git a/test/model/message_list_test.dart b/test/model/message_list_test.dart
index e7b6cd7834..e92b2489b3 100644
--- a/test/model/message_list_test.dart
+++ b/test/model/message_list_test.dart
@@ -1803,6 +1803,26 @@ void main() {
}
}
});
+
+ group('topics compared case-insensitively', () {... | {} | {
"haveSameRecipient topics compared case-insensitively different case, same diacritics": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"haveSameRecipient topics compared case-insensitively different case": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {
"messagesMoved in topic narrow moved into narrow: should refetch messages (old channel, old topic) -> (channel, topic)": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"messagesMoved fetch races fetchOlder #1, _reset, move fetch finishes, fetchOlder #2, fetchOlder #1 finishes, fetchOlder #2 finis... | {} |
zulip__zulip-flutter-1017 | zulip | zulip-flutter | 1,017 | closed | dialog: Use Cupertino-flavored alert dialogs on iOS | This pull request closes #996.<br>
In `dialog.dart`:<br>
Switched `alertDialog(` to `alertDialog.adaptive(`, as per #996.<br>
Defined new private widget `_adaptiveAction` which displays a `CupertinoDialogAction` for IOS and a `TextButton` otherwise. `_adaptiveAction(` is used in place of `TextButton(` when stat... | {
"label": "zulip:main",
"ref": "main",
"sha": "98b94bd2a0685606272882e089441000f8680952"
} | [
{
"number": 996,
"title": "dialog: Use Cupertino-flavored alert dialogs on iOS",
"body": "We should experiment with the [`AlertDialog.adaptive`](https://api.flutter.dev/flutter/material/AlertDialog/AlertDialog.adaptive.html) constructor, instead of [`AlertDialog`](https://api.flutter.dev/flutter/materia... | dart | dialog: Use Cupertino-flavored alert dialogs on iOS
We should experiment with the [`AlertDialog.adaptive`](https://api.flutter.dev/flutter/material/AlertDialog/AlertDialog.adaptive.html) constructor, instead of [`AlertDialog`](https://api.flutter.dev/flutter/material/AlertDialog/AlertDialog.html), which forces a Materi... | Hi I'm keen to get involved with this project and this issue looks like a good place to start, can I have a go at it?
@u7088495 Please take a look at the Zulip project's guide to getting involved with the code:
https://zulip.readthedocs.io/en/latest/contributing/contributing.html#your-first-codebase-contribution
http... | https://github.com/zulip/zulip-flutter/pull/1017 | [
"https://github.com/zulip/zulip-flutter/issues/996"
] | flutter test test/widgets/action_sheet_test.dart test/widgets/app_test.dart test/widgets/compose_box_test.dart test/widgets/dialog_test.dart --reporter expanded 2>&1 | diff --git a/lib/widgets/dialog.dart b/lib/widgets/dialog.dart
index e635071cc9..61a6462592 100644
--- a/lib/widgets/dialog.dart
+++ b/lib/widgets/dialog.dart
@@ -1,3 +1,5 @@
+import 'package:flutter/cupertino.dart';
+import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import '../gener... | diff --git a/test/widgets/action_sheet_test.dart b/test/widgets/action_sheet_test.dart
index d65ac20507..f673ebc0d8 100644
--- a/test/widgets/action_sheet_test.dart
+++ b/test/widgets/action_sheet_test.dart
@@ -335,7 +335,7 @@ void main() {
await tester.tap(findButtonForLabel('Mark channel as read'));
... | {
"/home/zulip-flutter/test/widgets/action_sheet_test.dart: channel action sheet showChannelActionSheet show from app bar in topic narrow": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/action_sheet_test.dart: message action sheet UnrevealMutedMessageButton visibl... | {} | {
"/home/zulip-flutter/test/widgets/compose_box_test.dart: length validation content code points not counted unnecessarily": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/zulip-flutter/test/widgets/action_sheet_test.dart: message action sheet ReactionButtons tada adding success; useLegacy: ... | {} |
zulip__zulip-flutter-833 | zulip | zulip-flutter | 833 | closed | lightbox: Display thumbnail with original image sizing | https://github.com/user-attachments/assets/0a007765-0879-4124-9f1b-2cf597518dac
(Initial image opens are older messages missing `data-original-dimensions` attribute)
Fixes #830 | {
"label": "zulip:main",
"ref": "main",
"sha": "c17dd0efd19291e0fa84cac87bbd0c6462835a6c"
} | [
{
"number": 830,
"title": "Show thumbnail at main image's size in lightbox",
"body": "With #820 (implementing #799), when you open an image in the lightbox we immediately show the thumbnail (which we'll typically already have loaded, from when you saw the preview in the message list) while we're loading... | dart | Show thumbnail at main image's size in lightbox
With #820 (implementing #799), when you open an image in the lightbox we immediately show the thumbnail (which we'll typically already have loaded, from when you saw the preview in the message list) while we're loading the full image.
One wrinkle is that for some image... | null | https://github.com/zulip/zulip-flutter/pull/833 | [
"https://github.com/zulip/zulip-flutter/issues/830"
] | flutter test test/model/content_test.dart test/widgets/lightbox_test.dart --reporter expanded 2>&1 | diff --git a/lib/model/content.dart b/lib/model/content.dart
index cf2ebd28b5..e9ee7875ef 100644
--- a/lib/model/content.dart
+++ b/lib/model/content.dart
@@ -356,6 +356,8 @@ class ImageNode extends BlockContentNode {
required this.srcUrl,
required this.thumbnailUrl,
required this.loading,
+ required ... | diff --git a/test/model/content_test.dart b/test/model/content_test.dart
index 60a5698c99..0846273795 100644
--- a/test/model/content_test.dart
+++ b/test/model/content_test.dart
@@ -263,7 +263,8 @@ class ContentExample {
]),
ImageNodeList([
ImageNode(srcUrl: 'https://chat.zulip.org/user_av... | {
"/home/zulip-flutter/test/model/content_test.dart: parse image as immediate child in implicit paragraph": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/content_test.dart: parse impossible content after image cluster in implicit paragraph": {
"run": "PASS",
... | {} | {} | {} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.