{"sample_id":"cross_issue_0003","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"[Epic] Horizontally scalable request layer (e.g. `pgwired`)?","query_context":"At the moment, all communication from clients goes through `environmentd`, which maintains the catalog, performs optimization, sends requests to `clusterd`, and passes results back to the client. Both data and control are multiplexed on the same connection.\n\nThe result of this multiplexing is\n* increased effort for `environmentd` to provide data to clients,\n* inability to restart independently of client connections, and\n* risk of exhausting resources within `environmentd`.\n\nEdit: Renamed the new component to `pgwired` based on feedback.\n\n## Goals\n\nSplit the control and data plane into separate entities. This could be achieved using the following approach:\n* Introduce an `pgwired` that accepts client connections, forwards requests to `environmentd`, and collects results from `environmentd` or `computed` directly.\n* `environmentd` maintains its current responsibility but does not transfer data from `computed` to clients because that data is exchanged directly.\n* `computed` hands the result of inserts directly to `persist` instead of passing data through `environmentd`\n* `pgwired` needs to be stateless to avoid conflicts with `environmentd`'s state.\n* The rollout needs to happen in a backwards-compatible fashion.\n\n## Non-goals\n\n* Move more processing, such as optimization, out of `environmentd`.\n\n## Tasks\n\n* Design the structure of `pgwired`\n * Derive a minimal protocol that allows `pgwired` to discover which services it needs to talk to.\n* Implement the protocol between `pgwired` and `computed`, while preserving the existing communication channel.\n\n## Alternatives\n\n* Use Persist to move data between components of the system.","known_context_document_ids":["gh_issue_1358985263"],"reference_answer":"from @ georgewfraser (thanks!), lightly edited and shared with permission:\n\nYou can get most of Fivetran's commands if you set up postgres as a source (henceforth, \"upstreamdb\") and set up a new postgres database as a destination (henceforth, \"downstreamdb\"). Instrument downstreamdb with statement level logging and do the following operations:\n\nCreate a few tables in upstreamdb, add some data, and connect it to fivetran. Fivetran should do an initial load of all the data (into fivetran's internal representation).\n\n* Sync a table to downstreamdb.\n * On the first sync Fivetran should copy straight into the table (this is DWH dependent, so lets see what happens).\n* Run some inserts in upstreamdb, then sync again.\n * You should see Fivetran create a separate staging table and then move the data from there.\n* Run some updates in upstreamdb and then sync again. \n * Be sure to update multiple columns, and try a few variations.\n * You'll see us do some funky update queries that do a \"patch\" operation. They're long but they follow a simple template.\n* Sync some DELETES.\n * You'll see some slightly different update queries.\n* Add a column.\n * We'll add the column in the destination.\n* Change the type of a column.\n * We'll migrate the data in-place in the destination.\n* Click resync in the Fivetran UI.\n * We'll do a \"mass update\" where we flag any rows that didn't get resynced as deleted.\n* All of these queries will be slightly different in \"history mode\" vs \"live mode\" (ed: i don't know what this means, perhaps it is obvious from Fivetran UI). \n * History mode isn't widely available yet though, and it's probably best to just start with live mode.","answer_document_id":"gh_comment_755764601","silver_evidence_path":["gh_comment_1242851542","gh_issue_778157642","gh_comment_755764601"],"evidence_issue_ids":[1358985263,778157642],"source_repo_name":"MaterializeInc/materialize","source_issue_id":1358985263,"source_issue_number":14568,"source_issue_url":"https://github.com/MaterializeInc/materialize/issues/14568","target_repo_name":"MaterializeInc/materialize","target_issue_id":778157642,"target_issue_number":5188,"target_issue_url":"https://github.com/MaterializeInc/materialize/issues/5188","reference_anchor_document_id":"gh_comment_1242851542","reference_answer_author":"rjnn","reference_answer_author_association":"MEMBER","quality_score":94.15,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0769,"anchor_target_overlap":0.2692,"target_answer_overlap":0.25},"issue_created_at":"2022-09-01T14:56:50+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_1358985263","fragment_type":"issue_description","sequence":0,"text":"[Epic] Horizontally scalable request layer (e.g. `pgwired`)\nAt the moment, all communication from clients goes through `environmentd`, which maintains the catalog, performs optimization, sends requests to `clusterd`, and passes results back to the client. Both data and control are multiplexed on the same connection.\n\nThe result of this multiplexing is\n* increased effort for `environmentd` to provide data to clients,\n* inability to restart independently of client connections, and\n* risk of exhausting resources within `environmentd`.\n\nEdit: Renamed the new component to `pgwired` based on feedback.\n\n## Goals\n\nSplit the control and data plane into separate entities. This could be achieved using the following approach:\n* Introduce an `pgwired` that accepts client connections, forwards requests to `environmentd`, and collects results from `environmentd` or `computed` directly.\n* `environmentd` maintains its current responsibility but does not transfer data from `computed` to clients because that data is exchanged directly.\n* `computed` hands the result of inserts directly to `persist` instead of passing data through `environmentd`\n* `pgwired` needs to be stateless to avoid conflicts with `environmentd`'s state.\n* The rollout needs to happen in a backwards-compatible fashion.\n\n## Non-goals\n\n* Move more processing, such as optimization, out of `environmentd`.\n\n## Tasks\n\n* Design the structure of `pgwired`\n * Derive a minimal protocol that allows `pgwired` to discover which services it needs to talk to.\n* Implement the protocol between `pgwired` and `computed`, while preserving the existing communication channel.\n\n## Alternatives\n\n* Use Persist to move data between components of the system.","author_login":"antiguru","author_association":"MEMBER","created_at":"2022-09-01T14:56:50+08:00","repo_name":"MaterializeInc/materialize","issue_id":1358985263,"issue_number":14568,"issue_url":"https://github.com/MaterializeInc/materialize/issues/14568","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1234712771","fragment_type":"issue_comment","sequence":1,"text":"@mjibson has wanted this for a while! One nit: I wouldn't call the new proposed binary `adapterd`, since most of the \"adapter\" layer will still live in `environmentd`. @mjibson has proposed `pgwired`, which I like! Though if these handle HTTP connections too... I'm sure there's an even better name we could come up with.\n\nA few things to consider:\n\n * How do we automatically scale `pgwired`? This is the core problem that we need to solve to make this approach worthwhile, IMO. If there's one `pgwired` handling all client connections, we're strictly worse off than before, as far as I can tell, because we've got an extra network boundary that's not in service of scalability or fault tolerance.\n * Our cloud infrastructure layer is not yet equipped to handle multiple `pgwired`s. With multiple `pgwired`s, we'll need a load balancer. (Right now we're able to provision environments pretty quickly because we get away with _not_ provisioning a load balancer.)\n * The current versioning and deployment scheme involves force-upgrading all binaries to the same version. That's going to frustrate the goal of restarting `pgwired` less frequently than `environmentd`. We'd need more granular versioning, so that `pgwired` is only restarted when the `environmentd`—`pgwired` protocol evolves.\n\n----\n \n\nProbably s/`storaged`/`persist` here?","author_login":"benesch","author_association":"MEMBER","created_at":"2022-09-01T19:51:17+08:00","repo_name":"MaterializeInc/materialize","issue_id":1358985263,"issue_number":14568,"issue_url":"https://github.com/MaterializeInc/materialize/issues/14568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1242851542","fragment_type":"issue_comment","sequence":2,"text":"From Slack: @frankmcsherry notes that a good litmus test for `pgwired` is whether it allows us to efficiently support Fivetran ingest. The gist is that Fivetran ingest would require handling many large `COPY FROM`, `INSERT`, and `SELECT` statements. See URL for details.","author_login":"benesch","author_association":"MEMBER","created_at":"2022-09-11T02:25:55+08:00","repo_name":"MaterializeInc/materialize","issue_id":1358985263,"issue_number":14568,"issue_url":"https://github.com/MaterializeInc/materialize/issues/14568","linked_issue_ids":[778157642],"is_known_query_context":false},{"document_id":"gh_issue_778157642","fragment_type":"issue_description","sequence":0,"text":"Scope fivetran ingest support\nFivetran has a \"Generic Postgres\" sink. We should set up a generic postgres with statement logging turned on, to see all the introspection statements that Fivetran uses, as well as the kinds of inserts and updates that it performs. Perhaps the best test would be to set up chbench via mysql -> fivetran -> generic postgres, run some updates through it, and instrument the logs. As we already have the first half of that ready to go in the benchmarking suite, and its nontrivial in the things it does.\n\nThis would be similar to the work that @JLDLaughlin did for scoping out Metabase support. We should do this sooner rather than later, because if there are transactional updates/inserts/etc then those would be good to know early so that @mjibson can scope out that support, in addition to the `pg_catalog` SQL level work that needs to be done.\n\nAssigning to SQL team for triage to see if I've missed anything.","author_login":"rjnn","author_association":"CONTRIBUTOR","created_at":"2021-01-04T15:03:44+08:00","repo_name":"MaterializeInc/materialize","issue_id":778157642,"issue_number":5188,"issue_url":"https://github.com/MaterializeInc/materialize/issues/5188","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_755764601","fragment_type":"issue_comment","sequence":1,"text":"from @ georgewfraser (thanks!), lightly edited and shared with permission:\n\nYou can get most of Fivetran's commands if you set up postgres as a source (henceforth, \"upstreamdb\") and set up a new postgres database as a destination (henceforth, \"downstreamdb\"). Instrument downstreamdb with statement level logging and do the following operations:\n\nCreate a few tables in upstreamdb, add some data, and connect it to fivetran. Fivetran should do an initial load of all the data (into fivetran's internal representation).\n\n* Sync a table to downstreamdb.\n * On the first sync Fivetran should copy straight into the table (this is DWH dependent, so lets see what happens).\n* Run some inserts in upstreamdb, then sync again.\n * You should see Fivetran create a separate staging table and then move the data from there.\n* Run some updates in upstreamdb and then sync again. \n * Be sure to update multiple columns, and try a few variations.\n * You'll see us do some funky update queries that do a \"patch\" operation. They're long but they follow a simple template.\n* Sync some DELETES.\n * You'll see some slightly different update queries.\n* Add a column.\n * We'll add the column in the destination.\n* Change the type of a column.\n * We'll migrate the data in-place in the destination.\n* Click resync in the Fivetran UI.\n * We'll do a \"mass update\" where we flag any rows that didn't get resynced as deleted.\n* All of these queries will be slightly different in \"history mode\" vs \"live mode\" (ed: i don't know what this means, perhaps it is obvious from Fivetran UI). \n * History mode isn't widely available yet though, and it's probably best to just start with live mode.","author_login":"rjnn","author_association":"MEMBER","created_at":"2021-01-06T22:50:36+08:00","repo_name":"MaterializeInc/materialize","issue_id":778157642,"issue_number":5188,"issue_url":"https://github.com/MaterializeInc/materialize/issues/5188","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_758830743","fragment_type":"issue_comment","sequence":2,"text":"Ok, I've set up a GitHub -> Generic PostgreSQL connector to try this out. Nothing particularly interesting happening yet\n\n2021-01-12 11:35:51.076 EST [3663493] postgres@fivetran LOG: execute : SET extra_float_digits = 3\n2021-01-12 11:35:51.094 EST [3663493] postgres@fivetran LOG: execute : SET application_name = 'fivetran'\n2021-01-12 11:35:51.112 EST [3663493] postgres@fivetran LOG: execute : SELECT 1\n2021-01-12 11:35:51.471 EST [3663494] postgres@fivetran LOG: execute : SET extra_float_digits = 3\n2021-01-12 11:35:51.488 EST [3663494] postgres@fivetran LOG: execute : SET application_name = 'fivetran'\n2021-01-12 11:35:51.506 EST [3663494] postgres@fivetran LOG: execute : SET ssl_renegotiation_limit = 0\n2021-01-12 11:35:51.657 EST [3663495] postgres@fivetran LOG: execute : SET extra_float_digits = 3\n2021-01-12 11:35:51.676 EST [3663495] postgres@fivetran LOG: execute : SET application_name = 'fivetran'\n2021-01-12 11:35:51.700 EST [3663495] postgres@fivetran LOG: execute : SELECT 1\n2021-01-12 11:35:51.874 EST [3663496] postgres@fivetran LOG: execute : SET extra_float_digits = 3\n2021-01-12 11:35:51.892 EST [3663496] postgres@fivetran LOG: execute : SET application_name = 'fivetran'\n2021-01-12 11:35:51.910 EST [3663496] postgres@fivetran LOG: execute : SELECT 1\n2021-01-12 11:35:52.041 EST [3663497] postgres@fivetran LOG: execute : SET extra_float_digits = 3\n2021-01-12 11:35:52.280 EST [3663497] postgres@fivetran LOG: execute : SET application_name = 'fivetran'\n2021-01-12 11:35:52.299 EST [3663497] postgres@fivetran LOG: execute : SET ssl_renegotiation_limit = 0\n2021-01-12 11:35:52.671 EST [3663498] postgres@fivetran LOG: execute : SET extra_float_digits = 3\n2021-01-12 11:35:52.911 EST [3663498] postgres@fivetran LOG: execute : SET application_name = 'fivetran'\n2021-01-12 11:35:53.166 EST [3663498] postgres@fivetran LOG: execute : /*Fivetran*/CREATE SCHEMA fivetran_testing_schema_e2fdda3da7874877a1e98315e8acf782\n2021-01-12 11:35:53.188 EST [3663498] postgres@fivetran LOG: execute : /*Fivetran*/CREATE TABLE fivetran_testing_schema_e2fdda3da7874877a1e98315e8acf782.fivetran_testing_table (id int)\n2021-01-12 11:35:53.207 EST [3663498] postgres@fivetran LOG: execute : /*Fivetran*/CREATE TEMPORARY TABLE fivetran_testing_table_temporary (id int)\n2021-01-12 11:35:53.226 EST [3663498] postgres@fivetran LOG: execute : /*Fivetran*/DROP SCHEMA IF EXISTS fivetran_testing_schema_e2fdda3da7874877a1e98315e8acf782 CASCADE\n2021-01-12 11:36:16.149 EST [3663736] postgres@fivetran LOG: execute : SET extra_float_digits = 3\n2021-01-12 11:36:16.394 EST [3663736] postgres@fivetran LOG: execute : SET application_name = 'fivetran'\n2021-01-12 11:36:16.414 EST [3663736] postgres@fivetran LOG: execute : SELECT 1\n2021-01-12 11:36:16.993 EST [3663737] postgres@fivetran LOG: execute : SET extra_float_digits = 3\n2021-01-12 11:36:17.011 EST [3663737] postgres@fivetran LOG: execute : SET application_name = 'fivetran'\n2021-01-12 11:36:17.030 EST [3663737] postgres@fivetran LOG: execute : SET ssl_renegotiation_limit = 0\n2021-01-12 11:36:17.179 EST [3663753] postgres@fivetran LOG: execute : SET extra_float_digits = 3\n2021-01-12 11:36:17.196 EST [3663753] postgres@fivetran LOG: execute : SET application_name = 'fivetran'\n2021-01-12 11:36:17.221 EST [3663753] postgres@fivetran LOG: execute : /*Fivetran*/SELECT version()\n\nBut fivetran is still loading data from GitHub, it seems. I guess the initial sync is buffered by Fivetran and then dumped into the destination in one shot.\n\nOne learning so far has been that our \"modern\" TLS requirements are too modern for Fivetran.","author_login":"benesch","author_association":"MEMBER","created_at":"2021-01-12T17:52:36+08:00","repo_name":"MaterializeInc/materialize","issue_id":778157642,"issue_number":5188,"issue_url":"https://github.com/MaterializeInc/materialize/issues/5188","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_759262331","fragment_type":"issue_comment","sequence":3,"text":"Here's the full dump: URL \n\nA quick glance suggests we're missing:\n\n * `COPY FROM ... (FORMAT CSV)`\n * `INSERT ... SELECT`\n * `DELETE ... USING`\n * `CREATE TEMPORARY TABLE`\n\nThat's all to build upsert semantics on top of PostgreSQL though. If Fivetran is willing to meet us in the middle, there are probably some simpler solutions to be had that supporting the above four types of queries.","author_login":"benesch","author_association":"MEMBER","created_at":"2021-01-13T07:30:21+08:00","repo_name":"MaterializeInc/materialize","issue_id":778157642,"issue_number":5188,"issue_url":"https://github.com/MaterializeInc/materialize/issues/5188","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1242851616","fragment_type":"issue_comment","sequence":4,"text":"Noting that performance of Fivetran ingest will be bottlenecked on `environmentd` until we tackle #14568.","author_login":"benesch","author_association":"MEMBER","created_at":"2022-09-11T02:26:30+08:00","repo_name":"MaterializeInc/materialize","issue_id":778157642,"issue_number":5188,"issue_url":"https://github.com/MaterializeInc/materialize/issues/5188","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0020","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"External hostname is not updated if an ingress is added *after* relating a charm to Prometheus?","query_context":"### Bug Description\n\nSee title. If you first relate to Prometheus and then to Traefik, it all works as expected. The other way around, no cigar.\n\n### To Reproduce\n\n-\n\n### Environment\n\n-\n\n### Relevant log output\n\nshell\n-\n\n### Additional context\n\nWe could have used the ingress established/revoked events, but these are unfortunately fired prematurely","known_context_document_ids":["gh_issue_1381005452"],"reference_answer":"So basically, what I think would make sense here:\n\nAn optional argument, per consumer, to turn path-prefix-stripping on and off. It should take whatever path prefix it is using for that route and add it to the middleware's list of path's to strip. As an example:\n\n- Jon is instantiating the traefik consumer in his `zinc-k8s` charm.\n- Jon is, either implicitly or explicitly, setting the `strip_path_prefix` argument to `True`.\n- Traefik adds a route, with the path prefix `/jons-cool-model-zinc-k8s`, resulting in the full routable URL ` URL \n- Traefik also adds a strip path prefix middleware for `/jons-cool-model-zinc-k8s`.\n- The workload app will no longer have to know that it is being reverse proxied and will continue to work, as long as all of the links it renders are relative.","answer_document_id":"gh_comment_1265451573","silver_evidence_path":["gh_comment_1277474331","gh_issue_1207565669","gh_comment_1265451573"],"evidence_issue_ids":[1381005452,1207565669],"source_repo_name":"canonical/prometheus-k8s-operator","source_issue_id":1381005452,"source_issue_number":368,"source_issue_url":"https://github.com/canonical/prometheus-k8s-operator/issues/368","target_repo_name":"canonical/traefik-k8s-operator","target_issue_id":1207565669,"target_issue_number":45,"target_issue_url":"https://github.com/canonical/traefik-k8s-operator/issues/45","reference_anchor_document_id":"gh_comment_1277474331","reference_answer_author":"simskij","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1351,"anchor_target_overlap":0.2273,"target_answer_overlap":0.1321},"issue_created_at":"2022-09-21T14:13:02+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_1381005452","fragment_type":"issue_description","sequence":0,"text":"External hostname is not updated if an ingress is added *after* relating a charm to Prometheus\n### Bug Description\n\nSee title. If you first relate to Prometheus and then to Traefik, it all works as expected. The other way around, no cigar.\n\n### To Reproduce\n\n-\n\n### Environment\n\n-\n\n### Relevant log output\n\nshell\n-\n\n### Additional context\n\nWe could have used the ingress established/revoked events, but these are unfortunately fired prematurely","author_login":"simskij","author_association":"MEMBER","created_at":"2022-09-21T14:13:02+08:00","repo_name":"canonical/prometheus-k8s-operator","issue_id":1381005452,"issue_number":368,"issue_url":"https://github.com/canonical/prometheus-k8s-operator/issues/368","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1277160997","fragment_type":"issue_comment","sequence":1,"text":"## Reproduction\nAfter relating a charm to traefik, its metrics endpoint is not updated and prometheus reports `health: down` because it is no longer reachable via the local ip.\n\n1. am, prom, trfk deployed and all in active/idle.\n1. juju relate am:self-metrics-endpoint prom\n - curl 10.1.13.182:9090/api/v1/targets | jq '.data.activeTargets'\n - \"scrapeUrl\": \" URL \n - \"globalUrl\": \" URL \n - \"health\": \"up\",\n1. juju relate am trfk\n - curl 10.1.13.182:9090/api/v1/targets | jq '.data.activeTargets'\n - \"scrapeUrl\": \" URL \n - \"globalUrl\": \" URL \n - \"health\": \"down\",\n1. juju run-action trfk/0 show-proxied-endpoints --wait\n - proxied-endpoints: '{\"am\": {\"url\": \" URL \n\n- update-status didn't help because the lib doesn't automatically observe it for sidecars, and alertmanager didn't pass custom refresh events.\n\n## Proposal 1\nUsers of MetricsEndpointProvider must be instructed to always set custom refresh events\n\nself.metrics = MetricsEndpointProvider(\n # ...\n refresh_event=[ # needed for ingress\n self.ingress.on.ready_for_unit,\n self.ingress.on.revoked_for_unit,\n self.on.update_status,\n ]\n\n## Proposal 2\nMetricsEndpointProvider should always observe update-status by default.\n\n## Proposal 3\nMetricsEndpointProvider should update relation data every re-init.\nI.e. the contructor MetricsEndpointProvider should call `self._set_scrape_job_spec` every instantiation, instead of registring it as an observer.\n\nIdeas? @dstathis @Abuelodelanada @rbarry82","author_login":"sed-i","author_association":"CONTRIBUTOR","created_at":"2022-10-13T07:33:43+08:00","repo_name":"canonical/prometheus-k8s-operator","issue_id":1381005452,"issue_number":368,"issue_url":"https://github.com/canonical/prometheus-k8s-operator/issues/368","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1277474331","fragment_type":"issue_comment","sequence":2,"text":"I think proposal #3 is preferable by far. It's idempotent, users don't have to do anything at all, it doesn't depend on `update-status-interval` or calling other events, and it can easily be removed from the library constructor when `stripPrefix` middleware lands in traefik, which makes this problem more or less disappear entirely (at least from an in-model/cluster perspective, as well as any external targets which have routable endpoints and don't need a path specified by any reverse proxy).","author_login":"rbarry82","author_association":"CONTRIBUTOR","created_at":"2022-10-13T11:39:48+08:00","repo_name":"canonical/prometheus-k8s-operator","issue_id":1381005452,"issue_number":368,"issue_url":"https://github.com/canonical/prometheus-k8s-operator/issues/368","linked_issue_ids":[1207565669],"is_known_query_context":false},{"document_id":"gh_comment_1277574501","fragment_type":"issue_comment","sequence":3,"text":"Tested manually and the combination of:\n- URL and\n- URL (with the modified prom lib)\n\nsolves the issue.\n\nWith which charm did you experience this @simskij ? You may need to update charm code:\n- fetch-lib for prometheus_scrape\n- pass `external_url` to MetricsEndpointProvider\n- use correct port number for the job `port = urlparse(self._external_url).port or 80`","author_login":"sed-i","author_association":"CONTRIBUTOR","created_at":"2022-10-13T13:02:56+08:00","repo_name":"canonical/prometheus-k8s-operator","issue_id":1381005452,"issue_number":368,"issue_url":"https://github.com/canonical/prometheus-k8s-operator/issues/368","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1278154336","fragment_type":"issue_comment","sequence":4,"text":"If it's a loki datasource issue then perhaps it's not related to prometheus_scrape?\n\nMaybe we need to manually call `update_source` in loki?\nBTW, `update_source` seems very different from `refresh_event`.\n@dstathis @rbarry82","author_login":"sed-i","author_association":"CONTRIBUTOR","created_at":"2022-10-13T20:38:50+08:00","repo_name":"canonical/prometheus-k8s-operator","issue_id":1381005452,"issue_number":368,"issue_url":"https://github.com/canonical/prometheus-k8s-operator/issues/368","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1278200367","fragment_type":"issue_comment","sequence":5,"text":"`update_source` is just a superset of `_set_unit_details` which also allows passing additional fields, and was added explicitly for consumers to say \"I have an ingress now, so update out-of-band in case `GrafanaSourceProvider._source_url` from the constructor is out of date\".\n\nSince Loki already uses the property in the constructor, `update_source` would be called when an ingress is added, yes, which allows setting/updating the Grafana relation data immediately after `ingress_ready` rather than waiting for some other event to re-trigger the constructor. We could do the same thing in `grafana_source` as is done here, but it would make sense from Loki's codebase to add it just after `update_endpoint(...)`, since the semantics are the same. The Prometheus libraries have just obsessively avoiding having any public API at all which could be used for this purpose.","author_login":"rbarry82","author_association":"CONTRIBUTOR","created_at":"2022-10-13T21:31:15+08:00","repo_name":"canonical/prometheus-k8s-operator","issue_id":1381005452,"issue_number":368,"issue_url":"https://github.com/canonical/prometheus-k8s-operator/issues/368","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1280618872","fragment_type":"issue_comment","sequence":6,"text":"My bad, I saw it in Prometheus too, but it seems to have been resolved now.","author_login":"simskij","author_association":"MEMBER","created_at":"2022-10-17T10:11:59+08:00","repo_name":"canonical/prometheus-k8s-operator","issue_id":1381005452,"issue_number":368,"issue_url":"https://github.com/canonical/prometheus-k8s-operator/issues/368","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1207565669","fragment_type":"issue_description","sequence":0,"text":"Allow stripping of path prefix when forwarding to backend\n### Bug Description\n\nWhen configured to use path based routing, the traefik operator will send requests to the backend on the same path that came into the frontend. This requires the backend service being able to reconfigure itself based upon the path prefix that is chosen from by the traefik operator. This is generally possible, however not all backends will be able to necessarily reconfigure the root path without sticking a proxy in the way to rewrite the URL. Instead, the traefik operator should allow for the requires side of the relation to indicate that the path prefix should be stripped or left intact.\n\nThis is fairly simply to do, and requires that a middleware option be injected/included into the yaml configuration for the service (relevant documentation). In fact, this should maybe be the default option since backend services may not be aware that they need to handle a forwarded HTTP request to the original path determined by the traefik operator.\n\n### To Reproduce\n\nI think it's fairly self-explanatory, but ...\n\n1. juju deploy --channel beta traefik\n2. juju deploy \n3. juju add-relation traefik \n4. curl URL provided on the relation\n5. Observe the traefik logs do not include the X-Forwarded-Prefix headers, which is used then the path prefix is stripped:\n\n2022-04-18T23:04:38.084Z [traefik] time=\"2022-04-18T23:04:38Z\" level=debug msg=\"vulcand/oxy/roundrobin/rr: Forwarding this request to URL\" Request=\"{\\\"Method\\\":\\\"GET\\\",\\\"URL\\\":{\\\"Scheme\\\":\\\"\\\",\\\"Opaque\\\":\\\"\\\",\\\"User\\\":null,\\\"Host\\\":\\\"\\\",\\\"Path\\\":\\\"/openstack-nova/v2.1/os-hypervisors/detail\\\",\\\"RawPath\\\":\\\"\\\",\\\"ForceQuery\\\":false,\\\"RawQuery\\\":\\\"\\\",\\\"Fragment\\\":\\\"\\\",\\\"RawFragment\\\":\\\"\\\"},\\\"Proto\\\":\\\"HTTP/1.1\\\",\\\"ProtoMajor\\\":1,\\\"ProtoMinor\\\":1,\\\"Header\\\":{\\\"Accept\\\":[\\\"application/json\\\"],\\\"Accept-Encoding\\\":[\\\"gzip, deflate\\\"],\\\"Connection\\\":[\\\"keep-alive\\\"],\\\"User-Agent\\\":[\\\"python-novaclient\\\"],\\\"X-Auth-Token\\\":[\\\"gAAAAABiXe6FWsObpnFYyAUq26ZavlDHi5bvGG1I0PFWmL6OkKdHe1HmSsmqIIaYfvQnEOsrtplRVtpOLeQPT8uEobez5VLp5uWu8lxPlncTYTFYIelnuQFUo2H5mFrWgCfqGoIbwByT9QtLCOgcfJnn35QhUT2hbjVU-BRaJgc7flM1XuqzJ9Q\\\"],\\\"X-Forwarded-Host\\\":[\\\"192.168.8.2\\\"],\\\"X-Forwarded-Port\\\":[\\\"80\\\"],\\\"X-Forwarded-Proto\\\":[\\\"http\\\"],\\\"X-Forwarded-Server\\\":[\\\"traefik-0\\\"],\\\"X-Openstack-Nova-Api-Version\\\":[\\\"2.1\\\"],\\\"X-Real-Ip\\\":[\\\"10.1.38.1\\\"]},\\\"ContentLength\\\":0,\\\"TransferEncoding\\\":null,\\\"Host\\\":\\\"192.168.8.2\\\",\\\"Form\\\":null,\\\"PostForm\\\":null,\\\"MultipartForm\\\":null,\\\"Trailer\\\":null,\\\"RemoteAddr\\\":\\\"10.1.38.1:3050\\\",\\\"RequestURI\\\":\\\"/openstack-nova/v2.1/os-hypervisors/detail\\\",\\\"TLS\\\":null}\" ForwardURL=\" URL \n2022-04-18T23:04:40.984Z [traefik] time=\"2022-04-18T23:04:40Z\" level=debug msg=\"vulcand/oxy/roundrobin/rr: completed ServeHttp on request\" Request=\"{\\\"Method\\\":\\\"GET\\\",\\\"URL\\\":{\\\"Scheme\\\":\\\"\\\",\\\"Opaque\\\":\\\"\\\",\\\"User\\\":null,\\\"Host\\\":\\\"\\\",\\\"Path\\\":\\\"/openstack-nova/v2.1/os-hypervisors/detail\\\",\\\"RawPath\\\":\\\"\\\",\\\"ForceQuery\\\":false,\\\"RawQuery\\\":\\\"\\\",\\\"Fragment\\\":\\\"\\\",\\\"RawFragment\\\":\\\"\\\"},\\\"Proto\\\":\\\"HTTP/1.1\\\",\\\"ProtoMajor\\\":1,\\\"ProtoMinor\\\":1,\\\"Header\\\":{\\\"Accept\\\":[\\\"application/json\\\"],\\\"Accept-Encoding\\\":[\\\"gzip, deflate\\\"],\\\"Connection\\\":[\\\"keep-alive\\\"],\\\"User-Agent\\\":[\\\"python-novaclient\\\"],\\\"X-Auth-Token\\\":[\\\"gAAAAABiXe6FWsObpnFYyAUq26ZavlDHi5bvGG1I0PFWmL6OkKdHe1HmSsmqIIaYfvQnEOsrtplRVtpOLeQPT8uEobez5VLp5uWu8lxPlncTYTFYIelnuQFUo2H5mFrWgCfqGoIbwByT9QtLCOgcfJnn35QhUT2hbjVU-BRaJgc7flM1XuqzJ9Q\\\"],\\\"X-Forwarded-Host\\\":[\\\"192.168.8.2\\\"],\\\"X-Forwarded-Port\\\":[\\\"80\\\"],\\\"X-Forwarded-Proto\\\":[\\\"http\\\"],\\\"X-Forwarded-Server\\\":[\\\"traefik-0\\\"],\\\"X-Openstack-Nova-Api-Version\\\":[\\\"2.1\\\"],\\\"X-Real-Ip\\\":[\\\"10.1.38.1\\\"]},\\\"ContentLength\\\":0,\\\"TransferEncoding\\\":null,\\\"Host\\\":\\\"192.168.8.2\\\",\\\"Form\\\":null,\\\"PostForm\\\":null,\\\"MultipartForm\\\":null,\\\"Trailer\\\":null,\\\"RemoteAddr\\\":\\\"10.1.38.1:3050\\\",\\\"RequestURI\\\":\\\"/openstack-nova/v2.1/os-hypervisors/detail\\\",\\\"TLS\\\":null}\"\n\nReconfiguring the yaml to include the necessary stripPrefix middleware, results in the proper request and the backend knowing how to service the path without reconfiguring the backend application:\n\n2022-04-18T23:09:01.542Z [traefik] time=\"2022-04-18T23:09:01Z\" level=debug msg=\"vulcand/oxy/roundrobin/rr: Forwarding this request to URL\" Request=\"{\\\"Method\\\":\\\"GET\\\",\\\"URL\\\":{\\\"Scheme\\\":\\\"\\\",\\\"Opaque\\\":\\\"\\\",\\\"User\\\":null,\\\"Host\\\":\\\"\\\",\\\"Path\\\":\\\"/v2.1/os-hypervisors/detail\\\",\\\"RawPath\\\":\\\"\\\",\\\"ForceQuery\\\":false,\\\"RawQuery\\\":\\\"\\\",\\\"Fragment\\\":\\\"\\\",\\\"RawFragment\\\":\\\"\\\"},\\\"Proto\\\":\\\"HTTP/1.1\\\",\\\"ProtoMajor\\\":1,\\\"ProtoMinor\\\":1,\\\"Header\\\":{\\\"Accept\\\":[\\\"application/json\\\"],\\\"Accept-Encoding\\\":[\\\"gzip, deflate\\\"],\\\"Connection\\\":[\\\"keep-alive\\\"],\\\"User-Agent\\\":[\\\"python-novaclient\\\"],\\\"X-Auth-Token\\\":[\\\"gAAAAABiXe-Nan9s3Mo6BygUvoiauekQFcnWbMBOHGU5aD5XInjpc6zlVCT2MeA6e0ucbTlWFUnXNlTHpo0OkHd3IfHrpwBtNr1-pwGotTi_5Sx0xW_DPPz1MdmC_rXZnOOYvNyVa3quCQar18pyOktTP42QJxP-cM6unim9omPvj3iE1MKIyDE\\\"],\\\"X-Forwarded-Host\\\":[\\\"192.168.8.2\\\"],\\\"X-Forwarded-Port\\\":[\\\"80\\\"],\\\"X-Forwarded-Prefix\\\":[\\\"/openstack-nova\\\"],\\\"X-Forwarded-Proto\\\":[\\\"http\\\"],\\\"X-Forwarded-Server\\\":[\\\"traefik-0\\\"],\\\"X-Openstack-Nova-Api-Version\\\":[\\\"2.1\\\"],\\\"X-Real-Ip\\\":[\\\"10.1.38.1\\\"]},\\\"ContentLength\\\":0,\\\"TransferEncoding\\\":null,\\\"Host\\\":\\\"192.168.8.2\\\",\\\"Form\\\":null,\\\"PostForm\\\":null,\\\"MultipartForm\\\":null,\\\"Trailer\\\":null,\\\"RemoteAddr\\\":\\\"10.1.38.1:7822\\\",\\\"RequestURI\\\":\\\"/v2.1/os-hypervisors/detail\\\",\\\"TLS\\\":null}\" ForwardURL=\" URL \n2022-04-18T23:09:05.230Z [traefik] time=\"2022-04-18T23:09:05Z\" level=debug msg=\"vulcand/oxy/roundrobin/rr: completed ServeHttp on request\" Request=\"{\\\"Method\\\":\\\"GET\\\",\\\"URL\\\":{\\\"Scheme\\\":\\\"\\\",\\\"Opaque\\\":\\\"\\\",\\\"User\\\":null,\\\"Host\\\":\\\"\\\",\\\"Path\\\":\\\"/v2.1/os-hypervisors/detail\\\",\\\"RawPath\\\":\\\"\\\",\\\"ForceQuery\\\":false,\\\"RawQuery\\\":\\\"\\\",\\\"Fragment\\\":\\\"\\\",\\\"RawFragment\\\":\\\"\\\"},\\\"Proto\\\":\\\"HTTP/1.1\\\",\\\"ProtoMajor\\\":1,\\\"ProtoMinor\\\":1,\\\"Header\\\":{\\\"Accept\\\":[\\\"application/json\\\"],\\\"Accept-Encoding\\\":[\\\"gzip, deflate\\\"],\\\"Connection\\\":[\\\"keep-alive\\\"],\\\"User-Agent\\\":[\\\"python-novaclient\\\"],\\\"X-Auth-Token\\\":[\\\"gAAAAABiXe-Nan9s3Mo6BygUvoiauekQFcnWbMBOHGU5aD5XInjpc6zlVCT2MeA6e0ucbTlWFUnXNlTHpo0OkHd3IfHrpwBtNr1-pwGotTi_5Sx0xW_DPPz1MdmC_rXZnOOYvNyVa3quCQar18pyOktTP42QJxP-cM6unim9omPvj3iE1MKIyDE\\\"],\\\"X-Forwarded-Host\\\":[\\\"192.168.8.2\\\"],\\\"X-Forwarded-Port\\\":[\\\"80\\\"],\\\"X-Forwarded-Prefix\\\":[\\\"/openstack-nova\\\"],\\\"X-Forwarded-Proto\\\":[\\\"http\\\"],\\\"X-Forwarded-Server\\\":[\\\"traefik-0\\\"],\\\"X-Openstack-Nova-Api-Version\\\":[\\\"2.1\\\"],\\\"X-Real-Ip\\\":[\\\"10.1.38.1\\\"]},\\\"ContentLength\\\":0,\\\"TransferEncoding\\\":null,\\\"Host\\\":\\\"192.168.8.2\\\",\\\"Form\\\":null,\\\"PostForm\\\":null,\\\"MultipartForm\\\":null,\\\"Trailer\\\":null,\\\"RemoteAddr\\\":\\\"10.1.38.1:7822\\\",\\\"RequestURI\\\":\\\"/v2.1/os-hypervisors/detail\\\",\\\"TLS\\\":null}\"\n\n### Environment\n\nmicrok8s: v1.23.5\njuju: 2.9.28\ntraefik: beta (rev 22)\n\n### Relevant log output\n\nshell\nRelevant logs are included in the output from the reproducer. This is a design change request.\n\n### Additional context\n\nI believe something along the lines of the following would suffice for the per-app ingress scenario:\n\nAdded to the `_generate_per_app_config` method after the config dict has been created:\n\npython\n if request.strip_prefix and self._routing_mode == _RoutingMode.path:\n traefik_middleware_name = f\"juju-{prefix}-stripprefix\"\n config['http']['routers'][traefik_router_name]['middlewares'] = [traefik_middleware_name]\n config['http']['middlewares'] = {\n traefik_middleware_name: {\n 'stripPrefix': {\n 'prefixes': [f\"/{prefix}\"],\n }\n }\n }","author_login":"wolsen","author_association":"NONE","created_at":"2022-04-18T23:53:19+08:00","repo_name":"canonical/traefik-k8s-operator","issue_id":1207565669,"issue_number":45,"issue_url":"https://github.com/canonical/traefik-k8s-operator/issues/45","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1102045556","fragment_type":"issue_comment","sequence":1,"text":"Imo this is a use-case for URL If Juju had anything like relation config, we could avoid a middleman configuration charm, but alas :-)","author_login":"mmanciop","author_association":"COLLABORATOR","created_at":"2022-04-19T05:02:43+08:00","repo_name":"canonical/traefik-k8s-operator","issue_id":1207565669,"issue_number":45,"issue_url":"https://github.com/canonical/traefik-k8s-operator/issues/45","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1179401841","fragment_type":"issue_comment","sequence":2,"text":"Revisiting this, I believe that the default behavior is incorrect in the Traefik charm. The current default when in path_routing mode requires that the backend's webroot be updated in order to service the request proxied through or a 404 will be served. In fact, no configuration changes should be *required* in order for the proxied requests to succeed. If it is Traefik that adds the path-prefix for routing purposes, then it should strip the path-prefix by default before sending this off to the backend. In other words, the backend service should not have to care about how the ingress service proxies the request.\n\nTo be clear, the url that is currently passed to the backend should continue to be the public endpoint that is exposed by Traefik. Services that need to know should be able to opt-in and that, I believe, would be a good use case for traefik-route. I believe things should just work by default for the general use case.","author_login":"wolsen","author_association":"NONE","created_at":"2022-07-08T22:17:02+08:00","repo_name":"canonical/traefik-k8s-operator","issue_id":1207565669,"issue_number":45,"issue_url":"https://github.com/canonical/traefik-k8s-operator/issues/45","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1179494682","fragment_type":"issue_comment","sequence":3,"text":"I agree - I think using the StripPrefix middleware in the default path-based routing mode would make sense.","author_login":"jnsgruk","author_association":"MEMBER","created_at":"2022-07-09T07:16:27+08:00","repo_name":"canonical/traefik-k8s-operator","issue_id":1207565669,"issue_number":45,"issue_url":"https://github.com/canonical/traefik-k8s-operator/issues/45","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1255122649","fragment_type":"issue_comment","sequence":4,"text":"I think traefik can reload it's config more gracefully than that?","author_login":"jnsgruk","author_association":"MEMBER","created_at":"2022-09-22T14:37:35+08:00","repo_name":"canonical/traefik-k8s-operator","issue_id":1207565669,"issue_number":45,"issue_url":"https://github.com/canonical/traefik-k8s-operator/issues/45","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1255183037","fragment_type":"issue_comment","sequence":5,"text":"It can, via a `watch` parameter. The reload is reasonably graceful, and doesn't need to be churned (unlike nginx).\n\nThis PR is pretty old, but could be resurrected easily enough and pretty much completes this.","author_login":"rbarry82","author_association":"NONE","created_at":"2022-09-22T15:21:20+08:00","repo_name":"canonical/traefik-k8s-operator","issue_id":1207565669,"issue_number":45,"issue_url":"https://github.com/canonical/traefik-k8s-operator/issues/45","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1265451573","fragment_type":"issue_comment","sequence":6,"text":"So basically, what I think would make sense here:\n\nAn optional argument, per consumer, to turn path-prefix-stripping on and off. It should take whatever path prefix it is using for that route and add it to the middleware's list of path's to strip. As an example:\n\n- Jon is instantiating the traefik consumer in his `zinc-k8s` charm.\n- Jon is, either implicitly or explicitly, setting the `strip_path_prefix` argument to `True`.\n- Traefik adds a route, with the path prefix `/jons-cool-model-zinc-k8s`, resulting in the full routable URL ` URL \n- Traefik also adds a strip path prefix middleware for `/jons-cool-model-zinc-k8s`.\n- The workload app will no longer have to know that it is being reverse proxied and will continue to work, as long as all of the links it renders are relative.","author_login":"simskij","author_association":"MEMBER","created_at":"2022-10-03T13:35:41+08:00","repo_name":"canonical/traefik-k8s-operator","issue_id":1207565669,"issue_number":45,"issue_url":"https://github.com/canonical/traefik-k8s-operator/issues/45","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1267169155","fragment_type":"issue_comment","sequence":7,"text":"In case charms other than 'yourself' are using your address should the 'this address has had its prefix stripped' also be published back to the consumers from the traefik side?\n\ni.e. should traefik publish something like:\n\n-urls:\n unit-0: \n - url: foo.com\n - prefix-is-stripped: false\n unit-1: \n - url: foo.com\n - prefix-is-stripped: true\n\nI guess it's not a use case that different units of the same app have different settings when it comes to prefix-strip, right?\n\nMy new nightmare:\n\npython\nself.ipu=IPUProvider(self, strip_prefix = bool(int(self.unit.name[-1]) % 2))\n\nBecause if not, then this is a non-issue: other applications can't see the addresses traefik is publishing to you.\nIf yes, then other units might get confused as to how to reach their peers. Or maybe I'm overcomplicating it. Is there a scenario in which this is a problem?","author_login":"PietroPasotti","author_association":"COLLABORATOR","created_at":"2022-10-04T15:18:06+08:00","repo_name":"canonical/traefik-k8s-operator","issue_id":1207565669,"issue_number":45,"issue_url":"https://github.com/canonical/traefik-k8s-operator/issues/45","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1267287577","fragment_type":"issue_comment","sequence":8,"text":"My presumption would be that the charm requesting it be stripped (via a constructor) would \"know\", and it would be flagged either via a config value or just globally, depending on the charm, so different units with different configs wouldn't be a supported configuration.\n\nIn general, the use case here is that a lot of \"modern\" applications using, say, `net/http` from Go just set up a handler at whatever the path is.\n\nRight now, if an IPU relation is established and the `PathPrefix` is _not_ stripped, it comes into `foo-2` as `/bar-model-foo-2/request`, and the handler says \"I don't know about that path, here's a 404\" unless each application is also configured with some parameter (depending on the application) specifying what the webroot should be.\n\nSetting _that_ root, though, also means that in-cluster or in-namespace traffic which isn't going through the ingress at all (or even checking some readiness API endpoint on `localhost`) must also have the root appended, and it's a snarl.\n\nThis sort-of leads to the entire \"ingress isn't ready yet\" case, but also means that `foo/0` which is related to IPU and has a metrics endpoint at `/metrics` must immediately reconfigure itself, restart the entire application (probably), update Prometheus with a new path with the IPU prefix prepended, and so on. That kind of cascade effect applies to any application whatsoever conducting HTTP traffic, even traffic which never leads the cluster, and is a potential cascading event storm as long as leaving the prefix is the default.","author_login":"rbarry82","author_association":"NONE","created_at":"2022-10-04T16:51:49+08:00","repo_name":"canonical/traefik-k8s-operator","issue_id":1207565669,"issue_number":45,"issue_url":"https://github.com/canonical/traefik-k8s-operator/issues/45","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0027","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"[Question] longhorn-conversion-webhook container not starting error, failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: eaccess /usr/local/sbin/longhorn-manager: permission denied: unknown?","query_context":"**Question:**\n\nI am open this as Question, because this is my first Longhorn storage installation on Kubernetes cluster (Multi Master HA setup), Feels like issue with some container permission while accessing /usr/local/sbin/longhorn-manager while provisioning container.\nafter applying the longhorn.yaml version v1.3.2, non of pods are getting started throwing error \"CrashLoopBackOff\" for longhorn-manager and convention-webhook pods. Looking at Kubernetes pod logs, in longhorn-conventional-webhook container its showing with the message: \" unable to start container process: eaccess /usr/local/sbin/longhorn-manager: permission denied: unknown\"\n\nWhat more can I look at to diagnose this issue? Is my volume configured incorrectly somehow? Did I miss a setup step somewhere?\n\nEnvironment Setup\nLonghorn version: v1.3.2\nKubernetes version: v1.24.0\nNode config\nOS type and version: Rhel 8\nCPU per node: 4\nMemory per node: 8gb & 16gb\nDisk type: XFS\nNetwork bandwidth and latency between the nodes: I don't have numbers, but they are all running on the same physical server\nUnderlying Infrastructure (e.g VMWare/KVM, Baremetal): KVM\n\n**Additional context**\nMy basic setup is that I have multiple K8s nodes running inside KVM virtual machines provisioned with libvirt. The K8S nodes are running rhel8. I have ensured that nfs-common and open-iscsi are both installed. Everything is running the latest version give or take a week. Each K8S VM has a 300gb XFS volume mounted at /var/lib/longhorn.","known_context_document_ids":["gh_issue_1749022121"],"reference_answer":"You can manually hide the private information, or you can send the support bundle to longhorn-support-bundle@suse.com which is only accessible by Longhorn members.","answer_document_id":"gh_comment_2176532828","silver_evidence_path":["gh_comment_2176162185","gh_issue_2359706899","gh_comment_2176532828"],"evidence_issue_ids":[1749022121,2359706899],"source_repo_name":"longhorn/longhorn","source_issue_id":1749022121,"source_issue_number":6090,"source_issue_url":"https://github.com/longhorn/longhorn/issues/6090","target_repo_name":"longhorn/longhorn","target_issue_id":2359706899,"target_issue_number":8780,"target_issue_url":"https://github.com/longhorn/longhorn/issues/8780","reference_anchor_document_id":"gh_comment_2176162185","reference_answer_author":"derekbit","reference_answer_author_association":"MEMBER","quality_score":94.85,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.375,"anchor_target_overlap":0.375,"target_answer_overlap":0.0769},"issue_created_at":"2023-06-09T03:02:29+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_1749022121","fragment_type":"issue_description","sequence":0,"text":"[Question] longhorn-conversion-webhook container not starting error, failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: eaccess /usr/local/sbin/longhorn-manager: permission denied: unknown\n**Question:**\n\nI am open this as Question, because this is my first Longhorn storage installation on Kubernetes cluster (Multi Master HA setup), Feels like issue with some container permission while accessing /usr/local/sbin/longhorn-manager while provisioning container.\nafter applying the longhorn.yaml version v1.3.2, non of pods are getting started throwing error \"CrashLoopBackOff\" for longhorn-manager and convention-webhook pods. Looking at Kubernetes pod logs, in longhorn-conventional-webhook container its showing with the message: \" unable to start container process: eaccess /usr/local/sbin/longhorn-manager: permission denied: unknown\"\n\nWhat more can I look at to diagnose this issue? Is my volume configured incorrectly somehow? Did I miss a setup step somewhere?\n\nEnvironment Setup\nLonghorn version: v1.3.2\nKubernetes version: v1.24.0\nNode config\nOS type and version: Rhel 8\nCPU per node: 4\nMemory per node: 8gb & 16gb\nDisk type: XFS\nNetwork bandwidth and latency between the nodes: I don't have numbers, but they are all running on the same physical server\nUnderlying Infrastructure (e.g VMWare/KVM, Baremetal): KVM\n\n**Additional context**\nMy basic setup is that I have multiple K8s nodes running inside KVM virtual machines provisioned with libvirt. The K8S nodes are running rhel8. I have ensured that nfs-common and open-iscsi are both installed. Everything is running the latest version give or take a week. Each K8S VM has a 300gb XFS volume mounted at /var/lib/longhorn.","author_login":"atul-devopswarriors","author_association":"NONE","created_at":"2023-06-09T03:02:29+08:00","repo_name":"longhorn/longhorn","issue_id":1749022121,"issue_number":6090,"issue_url":"https://github.com/longhorn/longhorn/issues/6090","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1583889025","fragment_type":"issue_comment","sequence":1,"text":"@atul-devopswarriors \nCould you please update the ticket with the below format and provide more information? Thank you.\n\n## Describe the bug (🐛 if you encounter this issue)\n\nA clear and concise description of what the bug is.\n\n## To Reproduce\n\nSteps to reproduce the behavior:\n1. Go to '...'\n2. Click on '....'\n3. Perform '....'\n4. See error\n\n## Expected behavior\n\nA clear and concise description of what you expected to happen.\n\n## Log or Support bundle\n\nIf applicable, add the Longhorn managers' log or support bundle when the issue happens. \nYou can generate a Support Bundle using the link at the footer of the Longhorn UI.\n\n## Environment\n\n - Longhorn version:\n - Installation method (e.g. Rancher Catalog App/Helm/Kubectl):\n - Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version:\n - Number of management node in the cluster:\n - Number of worker node in the cluster:\n - Node config\n - OS type and version:\n - CPU per node:\n - Memory per node:\n - Disk type(e.g. SSD/NVMe):\n - Network bandwidth between the nodes:\n - Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal):\n - Number of Longhorn volumes in the cluster:\n\n## Additional context\n\nAdd any other context about the problem here.","author_login":"derekbit","author_association":"MEMBER","created_at":"2023-06-09T03:04:54+08:00","repo_name":"longhorn/longhorn","issue_id":1749022121,"issue_number":6090,"issue_url":"https://github.com/longhorn/longhorn/issues/6090","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1588629118","fragment_type":"issue_comment","sequence":2,"text":"Do you have the logs from other pods (longhorn-manager, longhorn-driver-deployer, longhorn-ui). Do they share the same crashing error message above?","author_login":"PhanLe1010","author_association":"CONTRIBUTOR","created_at":"2023-06-13T06:31:24+08:00","repo_name":"longhorn/longhorn","issue_id":1749022121,"issue_number":6090,"issue_url":"https://github.com/longhorn/longhorn/issues/6090","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1590212381","fragment_type":"issue_comment","sequence":3,"text":"I am thinking if this error is related to Longhorn PSP not being enabled causing the problem in your cluster. \nBy default, in Longhorn v1.3.2 we don't ship Longhorn PSP. If your cluster requires this to work, you will need to deploy it. \n\nCould you provide the output of `kubectl get psp` ?","author_login":"PhanLe1010","author_association":"CONTRIBUTOR","created_at":"2023-06-13T23:46:33+08:00","repo_name":"longhorn/longhorn","issue_id":1749022121,"issue_number":6090,"issue_url":"https://github.com/longhorn/longhorn/issues/6090","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1590306254","fragment_type":"issue_comment","sequence":4,"text":"Could also provide some audit logs to see if there is any issue with SELinux?\n\nausearch -m AVC -ts recent","author_login":"PhanLe1010","author_association":"CONTRIBUTOR","created_at":"2023-06-14T01:35:31+08:00","repo_name":"longhorn/longhorn","issue_id":1749022121,"issue_number":6090,"issue_url":"https://github.com/longhorn/longhorn/issues/6090","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1591104180","fragment_type":"issue_comment","sequence":5,"text":"I am not able to fetch the long of any longhorn pod because non of pods are active or running state, However i can share describe logs.","author_login":"atul-devopswarriors","author_association":"NONE","created_at":"2023-06-14T12:32:03+08:00","repo_name":"longhorn/longhorn","issue_id":1749022121,"issue_number":6090,"issue_url":"https://github.com/longhorn/longhorn/issues/6090","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1591133201","fragment_type":"issue_comment","sequence":6,"text":"Please check the below output from above command\n\n` ausearch -m AVC -ts recent\n \n`","author_login":"atul-devopswarriors","author_association":"NONE","created_at":"2023-06-14T12:49:34+08:00","repo_name":"longhorn/longhorn","issue_id":1749022121,"issue_number":6090,"issue_url":"https://github.com/longhorn/longhorn/issues/6090","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1591802397","fragment_type":"issue_comment","sequence":7,"text":"$ kubectl get psp\nWarning: policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+\nNAME PRIV CAPS SELINUX RUNASUSER FSGROUP SUPGROUP READONLYROOTFS VOLUMES\nlonghorn-psp true SYS_ADMIN RunAsAny RunAsAny RunAsAny RunAsAny false configMap,downwardAPI,emptyDir,secret,projected,hostPath","author_login":"atul-devopswarriors","author_association":"NONE","created_at":"2023-06-14T18:43:23+08:00","repo_name":"longhorn/longhorn","issue_id":1749022121,"issue_number":6090,"issue_url":"https://github.com/longhorn/longhorn/issues/6090","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1592077085","fragment_type":"issue_comment","sequence":8,"text":"Thanks @atul-devopswarriors !\n\nThe PSP looks good.\n\nFor audit logs, did you run `ausearch -m AVC -ts recent` on the node `t1-prm-wrk1` yet?","author_login":"PhanLe1010","author_association":"CONTRIBUTOR","created_at":"2023-06-14T22:31:03+08:00","repo_name":"longhorn/longhorn","issue_id":1749022121,"issue_number":6090,"issue_url":"https://github.com/longhorn/longhorn/issues/6090","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2176162185","fragment_type":"issue_comment","sequence":9,"text":"Related to: URL \nIt's maybe because /var/ is mounted with noexec options.","author_login":"lenglet-k","author_association":"NONE","created_at":"2024-06-18T13:52:26+08:00","repo_name":"longhorn/longhorn","issue_id":1749022121,"issue_number":6090,"issue_url":"https://github.com/longhorn/longhorn/issues/6090","linked_issue_ids":[2359706899],"is_known_query_context":false},{"document_id":"gh_issue_2359706899","fragment_type":"issue_description","sequence":0,"text":"[BUG] longhorn-manager /usr/local/sbin/ volume and noexec configuration\n## Describe the bug\n\nWe want to use longhorn on CIS Benchmark Linux servers. In the CIS rules, the /var/ volume must have the noexec option enabled, this volume is propagated by containerd when a container mounts a volume, this is the case of longhorn-manager here.\n\nIn my case, longhorn-manager gets the permission denied error because the noexec option is propagated to the container automatically. \n\nimage\n\nMy question is: why did you create a volume in longhorn-manager on /usr/local/sbin? is it useful?\n## To Reproduce\n\n1. Create a mountpoint with noexec options on /var. \n2. Install Kubernetes and install containerd on /var/lib/containerd\n3. Deploy longhorn.\n4. See crashloopback state\n\n## Expected behavior\n\nHave the possibility to run longhorn-manager on hardening system from scratch and without error","author_login":"lenglet-k","author_association":"NONE","created_at":"2024-06-18T12:08:23+08:00","repo_name":"longhorn/longhorn","issue_id":2359706899,"issue_number":8780,"issue_url":"https://github.com/longhorn/longhorn/issues/8780","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2176495073","fragment_type":"issue_comment","sequence":1,"text":"`launch-manager`, `longhorn-manager` and `nsmounter` are put in `/usr/local/sbin`. Some utilities such as `engine-binaries` are in `/var/lib/longhorn`.\nI'm not familiar with CIS benchmark Linux. Can you provide a support bundle for checking what the error is? Thank you.\n\nBTW, @innobead `/var/lib/longhorn` is hard-coded path. Do you think we should make it configurable in the future?","author_login":"derekbit","author_association":"MEMBER","created_at":"2024-06-18T16:18:21+08:00","repo_name":"longhorn/longhorn","issue_id":2359706899,"issue_number":8780,"issue_url":"https://github.com/longhorn/longhorn/issues/8780","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2176522232","fragment_type":"issue_comment","sequence":2,"text":"There is a possibilty to hide private information with a support bundle ? In state, i can't send you this file with sensitive information.","author_login":"lenglet-k","author_association":"NONE","created_at":"2024-06-18T16:33:23+08:00","repo_name":"longhorn/longhorn","issue_id":2359706899,"issue_number":8780,"issue_url":"https://github.com/longhorn/longhorn/issues/8780","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2176532828","fragment_type":"issue_comment","sequence":3,"text":"You can manually hide the private information, or you can send the support bundle to longhorn-support-bundle@suse.com which is only accessible by Longhorn members.","author_login":"derekbit","author_association":"MEMBER","created_at":"2024-06-18T16:39:13+08:00","repo_name":"longhorn/longhorn","issue_id":2359706899,"issue_number":8780,"issue_url":"https://github.com/longhorn/longhorn/issues/8780","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2178062594","fragment_type":"issue_comment","sequence":4,"text":"@derekbit I have just sent this file by mail. WIth anonymous data","author_login":"lenglet-k","author_association":"NONE","created_at":"2024-06-19T08:21:57+08:00","repo_name":"longhorn/longhorn","issue_id":2359706899,"issue_number":8780,"issue_url":"https://github.com/longhorn/longhorn/issues/8780","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2195965989","fragment_type":"issue_comment","sequence":5,"text":"Verified **pass** on longhorn master(longhorn-manager `77ac26`, longhorn-engine `004f20`, longhorn-instance-manager `4dd756`)\n\nFrom daily regression, did not observe new outstanding issue.","author_login":"chriscchien","author_association":"CONTRIBUTOR","created_at":"2024-06-28T01:57:11+08:00","repo_name":"longhorn/longhorn","issue_id":2359706899,"issue_number":8780,"issue_url":"https://github.com/longhorn/longhorn/issues/8780","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0036","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"error message using this step?","query_context":"Hi,\nI set this first step in our workflow:\n\n - name: Cancel Previous Runs\n uses: styfle/cancel-workflow-action@0.11.0\n\nI did 2 pushes (first, and second) one after another to check how it works.\nI see this message in the logs:\n`Error while canceling workflow_id 5888667: Resource not accessible by integration`\n\nWhy did it happen?","known_context_document_ids":["gh_issue_1528923107"],"reference_answer":"Makes sense, as long as we can provide examples for each of the `Advanced:` use cases in the readme.\n\nWould you like to submit a PR?","answer_document_id":"gh_comment_1316300915","silver_evidence_path":["gh_comment_1379695924","gh_issue_1448551601","gh_comment_1316300915"],"evidence_issue_ids":[1528923107,1448551601],"source_repo_name":"styfle/cancel-workflow-action","source_issue_id":1528923107,"source_issue_number":200,"source_issue_url":"https://github.com/styfle/cancel-workflow-action/issues/200","target_repo_name":"styfle/cancel-workflow-action","target_issue_id":1448551601,"target_issue_number":191,"target_issue_url":"https://github.com/styfle/cancel-workflow-action/issues/191","reference_anchor_document_id":"gh_comment_1379695924","reference_answer_author":"styfle","reference_answer_author_association":"OWNER","quality_score":82.09,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1034,"anchor_target_overlap":0.087,"target_answer_overlap":0.0},"issue_created_at":"2023-01-11T12:08:12+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_1528923107","fragment_type":"issue_description","sequence":0,"text":"error message using this step\nHi,\nI set this first step in our workflow:\n\n - name: Cancel Previous Runs\n uses: styfle/cancel-workflow-action@0.11.0\n\nI did 2 pushes (first, and second) one after another to check how it works.\nI see this message in the logs:\n`Error while canceling workflow_id 5888667: Resource not accessible by integration`\n\nWhy did it happen?","author_login":"shirady","author_association":"NONE","created_at":"2023-01-11T12:08:12+08:00","repo_name":"styfle/cancel-workflow-action","issue_id":1528923107,"issue_number":200,"issue_url":"https://github.com/styfle/cancel-workflow-action/issues/200","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1379695924","fragment_type":"issue_comment","sequence":1,"text":"Also seeing this issue as of 10 minutes ago. I investigated that it was properly receiving the `github.token` parameter as well.\n\nOn that note, I'm taking this opportunity to finally migrate to the new concurrency system as it meets my needs, related to #191.\n\n@styfle thank you for this repo! It has been in every workflow I've set up in GitHub Actions. It worked wonderfully. 🙂","author_login":"bdrelling","author_association":"NONE","created_at":"2023-01-12T01:30:29+08:00","repo_name":"styfle/cancel-workflow-action","issue_id":1528923107,"issue_number":200,"issue_url":"https://github.com/styfle/cancel-workflow-action/issues/200","linked_issue_ids":[1448551601],"is_known_query_context":false},{"document_id":"gh_comment_1380924840","fragment_type":"issue_comment","sequence":2,"text":"Following up - \n\nDefinitely want to thank @styfle for this awesome action too -- I moved to `concurrency` by adding something like this to the top level of my action instead of using `cancel-workflow-action`.\n\nconcurrency:\n group: ${{ github.workflow }}-${{ github.ref }}\n cancel-in-progress: true","author_login":"johnmberger","author_association":"NONE","created_at":"2023-01-12T19:49:43+08:00","repo_name":"styfle/cancel-workflow-action","issue_id":1528923107,"issue_number":200,"issue_url":"https://github.com/styfle/cancel-workflow-action/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1381453075","fragment_type":"issue_comment","sequence":3,"text":"@johnmberger @bdrelling @styfle \nWould you please explain what concurrency is? and what happened to this repo that you recommended on the other one?\nI thought about implementing this step in all our workflows, so I want to understand...\nThnaks","author_login":"shirady","author_association":"NONE","created_at":"2023-01-13T08:07:30+08:00","repo_name":"styfle/cancel-workflow-action","issue_id":1528923107,"issue_number":200,"issue_url":"https://github.com/styfle/cancel-workflow-action/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1382049861","fragment_type":"issue_comment","sequence":4,"text":"@shirady , this action's purpose was to make sure you were able to cancel an outdated workflow if you pushed changes to the same branch. Github now has this exact functionality baked into Github Actions, and it's called concurrency. \n\nBasically, instead of using this action, you can add the `concurrency` key to you Github Action files to control if they'll get cancelled when you push new code. The other advantage of using concurrency is that you can customize \"concurrency groups\" to determine what gets cancelled and when.\n\nCheck out this release announcement blog post or Github's documentation or search Stack Overflow for more examples.","author_login":"johnmberger","author_association":"NONE","created_at":"2023-01-13T15:56:50+08:00","repo_name":"styfle/cancel-workflow-action","issue_id":1528923107,"issue_number":200,"issue_url":"https://github.com/styfle/cancel-workflow-action/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1448551601","fragment_type":"issue_description","sequence":0,"text":"Archive this repo\nI would suggest to add this action and/or add notice about the native `concurrency` functionality\n URL \n\n---\n\n@Fdawgs suggested the native functionality in URL","author_login":"MichaelDeBoey","author_association":"CONTRIBUTOR","created_at":"2022-11-14T18:35:45+08:00","repo_name":"styfle/cancel-workflow-action","issue_id":1448551601,"issue_number":191,"issue_url":"https://github.com/styfle/cancel-workflow-action/issues/191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1316300915","fragment_type":"issue_comment","sequence":1,"text":"Makes sense, as long as we can provide examples for each of the `Advanced:` use cases in the readme.\n\nWould you like to submit a PR?","author_login":"styfle","author_association":"OWNER","created_at":"2022-11-16T04:10:03+08:00","repo_name":"styfle/cancel-workflow-action","issue_id":1448551601,"issue_number":191,"issue_url":"https://github.com/styfle/cancel-workflow-action/issues/191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1318792185","fragment_type":"issue_comment","sequence":2,"text":"I currently don't have the bandwidth to create a PR & figure out the advanced use cases, but may @Fdawgs has some time?","author_login":"MichaelDeBoey","author_association":"CONTRIBUTOR","created_at":"2022-11-17T15:20:21+08:00","repo_name":"styfle/cancel-workflow-action","issue_id":1448551601,"issue_number":191,"issue_url":"https://github.com/styfle/cancel-workflow-action/issues/191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1368174049","fragment_type":"issue_comment","sequence":3,"text":"Just want to thank you @styfle for creating this GitHub Actions which helped us a lot in the past! ❤️","author_login":"Hongbo-Miao","author_association":"NONE","created_at":"2022-12-31T06:41:51+08:00","repo_name":"styfle/cancel-workflow-action","issue_id":1448551601,"issue_number":191,"issue_url":"https://github.com/styfle/cancel-workflow-action/issues/191","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0042","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"[image_picker] image_picker: ^1.0.7 image revert issue in IOS?","query_context":"### Steps to reproduce\n\n1. get the image from library/gallery or capture it from camera(only front camera)\n2. select and show it\n3. all images are inverted like a mirror in IOS devices only are inverted\n\n### Expected results\n\nThe image must be the same as placed in the gallery or captured by camera using the front camera.\n\n### Actual results\n\nImages are inverted in IOS when choosing from library/gallery using ImagePicker().pickImage(ImageSource.gallery) or captured by camera using ImagePicker().pickImage(ImageSource.camera).\n\n### Code sample\n\nImagePicker().pickImage(source:text == StringConstants.loadFromLibrary ? ImageSource.gallery : ImageSource.camera).then((value) async {\nif (value != null) {\nList imageBytes = File(value.path).readAsBytesSync();\nString _base64Image = base64Encode(imageBytes);\n}\n}).onError((err, stackTrace) {\ndebugPrint(err.toString());\n});\n\n### Screenshots or Video\n\n \n Screenshots / Video demonstration \n\n[Upload media here]\n\n \n\n### Logs\n\n Logs \n\nconsole\n[Paste your logs here]\n\n \n\n### Flutter Doctor output\n\nFlutter (Channel stable, 3.16.7, on Microsoft Windows [Version 10.0.19044.3086], locale en-US)\n• Flutter version 3.16.7 on channel stable at D:\\dev\\projects\\flutter\n• Upstream repository URL \n• Framework revision URL (3 months ago), 2024-01-11 15:19:26 -0600\n• Engine revision 4a585b7929\n• Dart version 3.2.4\n• DevTools version 2.28.5\n\nNote: the bug is only generating in case of front camera images that are placed in gallery or captured from camera.","known_context_document_ids":["gh_issue_2242954070"],"reference_answer":"When taking selfie in native camera at on Android devices, they are correcting the mirror effect, this is a useful feature to be baked into the `camera` package instead of modifing the image using `Transform` widget\nThanks for the issue!","answer_document_id":"gh_comment_789551119","silver_evidence_path":["gh_comment_2063059413","gh_issue_407865675","gh_comment_789551119"],"evidence_issue_ids":[2242954070,407865675],"source_repo_name":"flutter/flutter","source_issue_id":2242954070,"source_issue_number":146751,"source_issue_url":"https://github.com/flutter/flutter/issues/146751","target_repo_name":"flutter/flutter","target_issue_id":407865675,"target_issue_number":27650,"target_issue_url":"https://github.com/flutter/flutter/issues/27650","reference_anchor_document_id":"gh_comment_2063059413","reference_answer_author":"TahaTesser","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2105,"anchor_target_overlap":0.1579,"target_answer_overlap":0.2667},"issue_created_at":"2024-04-15T07:46:19+08:00","valid_comment_count":72,"fragments":[{"document_id":"gh_issue_2242954070","fragment_type":"issue_description","sequence":0,"text":"[image_picker] image_picker: ^1.0.7 image revert issue in IOS\n### Steps to reproduce\n\n1. get the image from library/gallery or capture it from camera(only front camera)\n2. select and show it\n3. all images are inverted like a mirror in IOS devices only are inverted\n\n### Expected results\n\nThe image must be the same as placed in the gallery or captured by camera using the front camera.\n\n### Actual results\n\nImages are inverted in IOS when choosing from library/gallery using ImagePicker().pickImage(ImageSource.gallery) or captured by camera using ImagePicker().pickImage(ImageSource.camera).\n\n### Code sample\n\nImagePicker().pickImage(source:text == StringConstants.loadFromLibrary ? ImageSource.gallery : ImageSource.camera).then((value) async {\nif (value != null) {\nList imageBytes = File(value.path).readAsBytesSync();\nString _base64Image = base64Encode(imageBytes);\n}\n}).onError((err, stackTrace) {\ndebugPrint(err.toString());\n});\n\n### Screenshots or Video\n\n \n Screenshots / Video demonstration \n\n[Upload media here]\n\n \n\n### Logs\n\n Logs \n\nconsole\n[Paste your logs here]\n\n \n\n### Flutter Doctor output\n\nFlutter (Channel stable, 3.16.7, on Microsoft Windows [Version 10.0.19044.3086], locale en-US)\n• Flutter version 3.16.7 on channel stable at D:\\dev\\projects\\flutter\n• Upstream repository URL \n• Framework revision URL (3 months ago), 2024-01-11 15:19:26 -0600\n• Engine revision 4a585b7929\n• Dart version 3.2.4\n• DevTools version 2.28.5\n\nNote: the bug is only generating in case of front camera images that are placed in gallery or captured from camera.","author_login":"ItsArsalanAziz","author_association":"NONE","created_at":"2024-04-15T07:46:19+08:00","repo_name":"flutter/flutter","issue_id":2242954070,"issue_number":146751,"issue_url":"https://github.com/flutter/flutter/issues/146751","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2056635389","fragment_type":"issue_comment","sequence":1,"text":"@ItsArsalanAziz \nIs there any difference between this issue and the other one you reported ?\nCan you provide screenshots of the current behavior ?\nCheck this similar issue which was fixed and see if it helps in your case or not.","author_login":"darshankawar","author_association":"MEMBER","created_at":"2024-04-15T11:46:54+08:00","repo_name":"flutter/flutter","issue_id":2242954070,"issue_number":146751,"issue_url":"https://github.com/flutter/flutter/issues/146751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2056690194","fragment_type":"issue_comment","sequence":2,"text":"@darshankawar \n\nYes these both issues are totally different from each other, I have added images here for that issue.\n\nThe issue you mentioned, not worked in my case. I have tried all the solutions posted there.\n\nBelow you can see the behavior for this issue that when I pick from the list, the image have the bottle on RHS but when it appears on screen using Image Widget, the bottle shifted to LHS.","author_login":"ItsArsalanAziz","author_association":"NONE","created_at":"2024-04-15T12:12:10+08:00","repo_name":"flutter/flutter","issue_id":2242954070,"issue_number":146751,"issue_url":"https://github.com/flutter/flutter/issues/146751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2058283576","fragment_type":"issue_comment","sequence":3,"text":"Thanks for the update @ItsArsalanAziz \nI tried with image_picker plugin example running on iOS physical device OS 15.3.1 with which I didn't see the reported behavior.\n\n<img width=\"342\" alt=\"Screenshot 2024-04-16 at 11 22 31 AM\" src=\" URL \n\nCan you try the same at your end using plugin example and check if using it, you still get reported behavior or not ?\nIf not, please provide us runnable complete but minimal reproducible code sample (ex: main.dart) that we can directly use to verify the issue further. Also, provide iOS device you are using which shows the issue.","author_login":"darshankawar","author_association":"MEMBER","created_at":"2024-04-16T05:54:15+08:00","repo_name":"flutter/flutter","issue_id":2242954070,"issue_number":146751,"issue_url":"https://github.com/flutter/flutter/issues/146751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2059057571","fragment_type":"issue_comment","sequence":4,"text":"import 'dart:io';\nimport 'package:flutter/material.dart';\nimport 'package:image_picker/image_picker.dart';\n\nvoid main() {\n runApp(const MyApp());\n}\n\nclass MyApp extends StatelessWidget {\n const MyApp({super.key});\n\n @override\n Widget build(BuildContext context) {\n return const MaterialApp(\n title: \"Test\",\n home: MainApp(),\n );\n }\n}\n\nclass MainApp extends StatelessWidget {\n const MainApp({super.key});\n\n _pickImage(BuildContext context, src) {\n ImagePicker().pickImage(source: src).then((value) async {\n if (value != null) {\n showDialog(\n context: context,\n builder: (context) {\n return Center(\n child: Image.file(\n File(value.path),\n height: 300.0,\n width: 300.0,\n fit: BoxFit.cover,\n ),\n );\n },\n );\n }\n }).onError((err, stackTrace) {\n debugPrint(err.toString());\n });\n }\n\n @override\n Widget build(BuildContext context) {\n return Scaffold(\n body: Center(\n child: Column(\n mainAxisAlignment: MainAxisAlignment.center,\n children: [\n GestureDetector(\n onTap: () => _pickImage(context, ImageSource.gallery),\n behavior: HitTestBehavior.opaque,\n child: const Text(\n 'Pick from Gallery',\n textAlign: TextAlign.center,\n style: TextStyle(\n fontFamily: 'Roboto',\n color: Colors.blue,\n fontSize: 16,\n ),\n ),\n ),\n const SizedBox(height: 30),\n GestureDetector(\n onTap: () => _pickImage(context, ImageSource.camera),\n behavior: HitTestBehavior.opaque,\n child: const Text(\n 'Capture from Camera',\n textAlign: TextAlign.center,\n style: TextStyle(\n fontFamily: 'Roboto',\n color: Colors.blue,\n fontSize: 16,\n ),\n ),\n ),\n ],\n ),\n ),\n );\n }\n}\n\nAbove is the simplest code, by running it with the below image you can see the rotation issue. Kindly check it on latest IOS device and use only the front camera, as I have already , mentioned that this issue occurs on front camera. For your kind information, I am using iPhone 13 pro max and this issue is also occurs in other latest IOS devices too.","author_login":"ItsArsalanAziz","author_association":"NONE","created_at":"2024-04-16T13:10:36+08:00","repo_name":"flutter/flutter","issue_id":2242954070,"issue_number":146751,"issue_url":"https://github.com/flutter/flutter/issues/146751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2060461141","fragment_type":"issue_comment","sequence":5,"text":"Thanks for the update. Although I don't have iPhone 13 pro max, I tried the code sample on iPhone 6s with which using camera and gallery, both times, the images was shown as expected using front camera.\n\n<img width=\"339\" alt=\"Screenshot 2024-04-17 at 11 47 52 AM\" src=\" URL \n<img width=\"341\" alt=\"Screenshot 2024-04-17 at 11 47 58 AM\" src=\" URL \n\nI tried on latest stable version.","author_login":"darshankawar","author_association":"MEMBER","created_at":"2024-04-17T06:18:39+08:00","repo_name":"flutter/flutter","issue_id":2242954070,"issue_number":146751,"issue_url":"https://github.com/flutter/flutter/issues/146751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2060700718","fragment_type":"issue_comment","sequence":6,"text":"URL \n\nYou can see clearly that I have used the official image_picker example in 13 pro max and used only front camera to reproduce it. I have iPhone 7 plus and 13 pro max, and in both this issue occurs. Kindly capture image from only front camera in this example app.","author_login":"ItsArsalanAziz","author_association":"NONE","created_at":"2024-04-17T08:30:53+08:00","repo_name":"flutter/flutter","issue_id":2242954070,"issue_number":146751,"issue_url":"https://github.com/flutter/flutter/issues/146751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2063059413","fragment_type":"issue_comment","sequence":7,"text":"I used front camera while using your example app with which I didn't get the reported behavior on iphone I tried. \nI am wondering since this is occuring using camera which is being used underlying in image_picker package, whether you are hitting this URL","author_login":"darshankawar","author_association":"MEMBER","created_at":"2024-04-18T05:58:56+08:00","repo_name":"flutter/flutter","issue_id":2242954070,"issue_number":146751,"issue_url":"https://github.com/flutter/flutter/issues/146751","linked_issue_ids":[407865675],"is_known_query_context":false},{"document_id":"gh_comment_2066418890","fragment_type":"issue_comment","sequence":8,"text":"@darshankawar this issue persists across every iOS device I've. I've tested on the following devices: iPhone 7 Plus, iPhone 12 Mini, iPhone 13, and iPhone 13 Pro Max\n\nTo get the reported behavior in iPhone 6s, as you said it works fine on 6s, I've arranged it and checked using the example app from image_picker, where this issue also occurs. In the below video, you can see the behavior clearly, and in the end of the video, you can see the device info too.\n\n URL","author_login":"ItsArsalanAziz","author_association":"NONE","created_at":"2024-04-19T11:57:14+08:00","repo_name":"flutter/flutter","issue_id":2242954070,"issue_number":146751,"issue_url":"https://github.com/flutter/flutter/issues/146751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2068522800","fragment_type":"issue_comment","sequence":9,"text":"I tried on iPhone 13 pro max simulator running iOS 15.3 version but wasn't able to replicate.\n\n URL \n\nAlso, as previously stated, tried on iphone 6s device on which as well, I wasn't able to replicate the reported behavior.\n\nBased on the report, it seems to be device + OS specific, so labeling it for team's input / tracking.","author_login":"darshankawar","author_association":"MEMBER","created_at":"2024-04-22T05:31:43+08:00","repo_name":"flutter/flutter","issue_id":2242954070,"issue_number":146751,"issue_url":"https://github.com/flutter/flutter/issues/146751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2075889397","fragment_type":"issue_comment","sequence":10,"text":"@ItsArsalanAziz, please take a moment to read out see our code of conduct, which requires kind and actively welcoming behavior. Your last comment was neither.","author_login":"jmagman","author_association":"MEMBER","created_at":"2024-04-24T21:35:59+08:00","repo_name":"flutter/flutter","issue_id":2242954070,"issue_number":146751,"issue_url":"https://github.com/flutter/flutter/issues/146751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2076404832","fragment_type":"issue_comment","sequence":11,"text":"@jmagman apologies for the kind of behavior but look into the matter as I clearly mentioned the issue that is not device-specific but platform-specific. I have checked in more than 6 different IOS physical devices and it generates in every device. @darshankawar marked it as a device-specific issue which is hard to understand.","author_login":"ItsArsalanAziz","author_association":"NONE","created_at":"2024-04-25T05:34:55+08:00","repo_name":"flutter/flutter","issue_id":2242954070,"issue_number":146751,"issue_url":"https://github.com/flutter/flutter/issues/146751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2076471542","fragment_type":"issue_comment","sequence":12,"text":"@ItsArsalanAziz \nYou are correct. It doesn't seem to be device specific so I will remove that label. I was finally able to replicate this on iPhone 6s device with front camera as shown below:\n\n URL \n\nI compared it with native iOS camera with which same behavior occurs using front camera:\n\n URL \n\nIn both videos, you can observe that when we open front camera, the cupboard is to the right, when we take picture, in preview you'll see it on left which is same behavior in native iOS and Flutter.\n\nThis indicates it is how native iOS front camera works that you can check on the range of devices you mentioned and compare with Flutter's image_picker or camera.","author_login":"darshankawar","author_association":"MEMBER","created_at":"2024-04-25T06:36:35+08:00","repo_name":"flutter/flutter","issue_id":2242954070,"issue_number":146751,"issue_url":"https://github.com/flutter/flutter/issues/146751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2076502349","fragment_type":"issue_comment","sequence":13,"text":"@darshankawar thank you, will there be any fix for this in Flutter's image_picker in upcoming release?","author_login":"ItsArsalanAziz","author_association":"NONE","created_at":"2024-04-25T06:59:13+08:00","repo_name":"flutter/flutter","issue_id":2242954070,"issue_number":146751,"issue_url":"https://github.com/flutter/flutter/issues/146751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2077132553","fragment_type":"issue_comment","sequence":14,"text":"The current behavior is in sync with native iOS, so I am not sure if the fix is in scope for the plugin to be made.\nSince image_picker under the hood uses camera, I suggest you to follow-up in URL which is similar as your request.\nClosing for now. If you disagree, write in comments and I'll reopen it.","author_login":"darshankawar","author_association":"MEMBER","created_at":"2024-04-25T13:03:59+08:00","repo_name":"flutter/flutter","issue_id":2242954070,"issue_number":146751,"issue_url":"https://github.com/flutter/flutter/issues/146751","linked_issue_ids":[407865675],"is_known_query_context":false},{"document_id":"gh_comment_2077335565","fragment_type":"issue_comment","sequence":15,"text":"This isn't actually a duplicate of #27650, since `camera` and `image_picker` have fundamentally different code. `camera` is a wrapper around the low-level OS camera APIs, and does not involve any system UI. There's a lot more opportunity to customize behaviors at that level.\n\n`image_picker` is a wrapper around a very high-level system-provide UI control. The only things the plugin can change about the resulting UI are those that the OS specifically provides (which is basically this). I don't see any way to control the behavior of the camera UI in that configuration, which means that the functionality requested here cannot be implemented in this plugin.\n\nGiven that, removing the duplicate label, but leaving the issue closed. Clients who need to customize the capture experience would need to build their own UI around `camera` or a similar plugin, rather than using `image_picker`.","author_login":"stuartmorgan","author_association":"CONTRIBUTOR","created_at":"2024-04-25T14:24:47+08:00","repo_name":"flutter/flutter","issue_id":2242954070,"issue_number":146751,"issue_url":"https://github.com/flutter/flutter/issues/146751","linked_issue_ids":[407865675],"is_known_query_context":false},{"document_id":"gh_comment_2078203742","fragment_type":"issue_comment","sequence":16,"text":"What @stuartmorgan said.\n\nWhen taking a picture with the front camera, iOS automatically mirrors it. This is built into Apple's `UIImagePickerController` API. The preview of the image (the view where it says \"Retake\" and \"Use Photo\" is also part of `UIImagePickerController`). You may also notice that when you use the native iOS camera app, this behavior also occurs. In conclusion, this is not an issue with `image_picker` or Flutter but the expected behavior.","author_login":"jmagman","author_association":"MEMBER","created_at":"2024-04-25T21:27:13+08:00","repo_name":"flutter/flutter","issue_id":2242954070,"issue_number":146751,"issue_url":"https://github.com/flutter/flutter/issues/146751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2078673194","fragment_type":"issue_comment","sequence":17,"text":"@jmagman this might be the default behavior you are right, but it works fine in other platforms. As in my case, this behavior is a glitch which is the reason why I opened this issue.","author_login":"ItsArsalanAziz","author_association":"NONE","created_at":"2024-04-26T05:43:57+08:00","repo_name":"flutter/flutter","issue_id":2242954070,"issue_number":146751,"issue_url":"https://github.com/flutter/flutter/issues/146751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_407865675","fragment_type":"issue_description","sequence":0,"text":"Mirror Effect in Front Camera Flutter\nI am currently using the camera pluggin on flutter. Is there a way to remove the mirror effect from the front camera (selfie camera) when you take a picture? If there is none, can it be added ?","author_login":"ueabu","author_association":"NONE","created_at":"2019-02-07T19:41:22+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_461714706","fragment_type":"issue_comment","sequence":1,"text":"@ueabu \nPlease try the latest camera plugin.\nIf this remains to be an issue, can you file a PR?","author_login":"kangwang1988","author_association":"MEMBER","created_at":"2019-02-08T07:28:16+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_475877608","fragment_type":"issue_comment","sequence":2,"text":"I'm using latest camera plugin as at 2019/03/23 (camera 0.4.2), my app is as simple as preview the camera for 3 seconds (using the front camera), take a picture, and show the picture taken for 10 seconds. However, the picture taken and the preview is mirrored. Can I have some work around? say, can I preview the camera in mirror? (I can't find any widget for this), or, can I save the image in mirror? (I am unable to find any plugin to do this as well)","author_login":"lhcdims","author_association":"NONE","created_at":"2019-03-23T15:12:35+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_532405492","fragment_type":"issue_comment","sequence":3,"text":"Using camera-0.5.4, and this issue still occurs. Image captured is mirrored and then saved to directory.","author_login":"PoojaB26","author_association":"NONE","created_at":"2019-09-17T21:16:20+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_540942845","fragment_type":"issue_comment","sequence":4,"text":"I am experiencing the same mirror effect. When using front camera the plugin always mirrors the image. Please fix this. Thank you!","author_login":"festapp86","author_association":"NONE","created_at":"2019-10-11T07:09:31+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_543209242","fragment_type":"issue_comment","sequence":5,"text":"The same for me. A video recorded by the front camera is mirrored in a file, but looking good in the CaeraPreview.\n\nflutter doctor\nDoctor summary (to see all details, run flutter doctor -v):\n[✓] Flutter (Channel stable, v1.9.1+hotfix.4, on Mac OS X 10.15 19A602, locale\n ru-UA)\n[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)\n[✓] Xcode - develop for iOS and macOS (Xcode 11.0)\n[✓] Android Studio (version 3.5)\n[✓] Connected device (1 available)\n\n• No issues found!","author_login":"troy379","author_association":"NONE","created_at":"2019-10-17T14:45:25+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_572534416","fragment_type":"issue_comment","sequence":6,"text":"You can use ffmpeg to flip an image:\n\n1) Setup URL \n2) use following ffmpeg code to flip an image: \n`\"-y -i inputPath -filter:v \\\"hflip\\\" outputPath\"`\nwhere -y parameter allows overwriting inputPath\n2) example code that only flips image when using front camera:\n\n`// take our first picture\n _cameraController.takePicture(_tempDir.path + \"/tempfaver/firstPic.png\")\n\n // when we're done taking our picture\n .then((void _void) async {\n //\n // try to flip picture in case of selfie-mode\n if (_availableCameras[_selectedCameraIndex].lensDirection ==\n CameraLensDirection.front) {\n\n // show waiting spinner while mirroring picture\n setState(() {\n _isProcessing = true;\n });\n\n // mirror selfie picture\n await _ffmpeg.execute(\"-y -i \" +\n _tempDir.path +\n \"/tempfaver/firstPic.png \" +\n \"-filter:v \\\"hflip\\\" \" +\n _tempDir.path +\n \"/tempfaver/firstPic.png\");\n\n _isProcessing = false;\n\n print(\"flipping done\");\n } else {\n print(\"no flipping necessary\");\n }\n });`","author_login":"gisinator","author_association":"NONE","created_at":"2020-01-09T12:11:15+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_591028017","fragment_type":"issue_comment","sequence":7,"text":"Alternative solution is to mirror the preview instead:\n``\nfinal mirror = selectedCameraIndex == 1 ? math.pi : 0;\nTransform(Alignment.center,\n child: CameraPreview(controller),\n transform: Matrix4.rotationY(mirror)\n)``","author_login":"justAsascha","author_association":"NONE","created_at":"2020-02-25T19:31:53+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_592519100","fragment_type":"issue_comment","sequence":8,"text":"I solved this problem by modifying the code of the plugin myself\n\nClasses/CameraPlugin.m\n\nfind the code:\n\n bool success = [UIImageJPEGRepresentation(image, 1.0) writeToFile:_path atomically:YES];\n\ninsert after this\n\n UIImage *image = [UIImage imageWithCGImage:[UIImage imageWithData:data].CGImage\n scale:1.0\n orientation:[self getImageRotation]];\n\n// insert this code\nimage = [UIImage imageWithCGImage:image.CGImage scale:image.scale orientation:UIImageOrientationLeftMirrored]; \n\n // TODO(sigurdm): Consider writing file asynchronously.\n bool success = [UIImageJPEGRepresentation(image, 1.0) writeToFile:_path atomically:YES];","author_login":"peasfarmer","author_association":"NONE","created_at":"2020-02-28T13:45:21+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_592538765","fragment_type":"issue_comment","sequence":9,"text":"@peasfarmer awesome! Is it only working for iOS or both platforms?","author_login":"justAsascha","author_association":"NONE","created_at":"2020-02-28T14:32:46+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_612129766","fragment_type":"issue_comment","sequence":10,"text":"Sure here it is:\n`\nimport 'dart:async';\nimport 'package:camera/camera.dart';\nimport 'package:flutter/material.dart';\n\nimport 'dart:math' as math;\n\nclass CameraPage extends StatefulWidget {\n static String routeName = \"camera\";\n\n @override\n _CameraPageState createState() {\n return _CameraPageState();\n }\n}\n\nclass _CameraPageState extends State {\n CameraController controller;\n List cameras;\n // 0 = front | 1 = back\n int selectedCameraIndex;\n\n @override\n void deactivate() {\n super.deactivate();\n controller.dispose();\n }\n\n @override\n void initState() {\n super.initState();\n // Get the listonNewCameraSelected of available cameras.\n // Then set the first camera as selected.\n availableCameras().then((availableCameras) {\n cameras = availableCameras;\n if (cameras.length > 0) {\n setState(() {\n // select front camera as default\n selectedCameraIndex = 1;\n });\n\n _onCameraSwitched(cameras[selectedCameraIndex]).then((void v) {});\n }\n }).catchError((err) {\n print('Error: $err.code\\nError Message: $err.message');\n });\n }\n\n @override\n Widget build(BuildContext context) {\n if (controller == null || !controller.value.isInitialized) {\n return Container(\n color: Colors.black,\n width: MediaQuery.of(context).size.width,\n height: MediaQuery.of(context).size.height);\n }\n\n // mirror camera preview only for front camera\n final double mirror = selectedCameraIndex == 1 ? math.pi : 0;\n\n return Transform(\n alignment: Alignment.center,\n child: CameraPreview(controller),\n transform: Matrix4.rotationY(mirror),\n );\n }\n\n Future _onCameraSwitched(CameraDescription cameraDescription) async {\n if (controller != null) {\n await controller.dispose();\n }\n\n controller = CameraController(cameraDescription, ResolutionPreset.high,\n enableAudio: false);\n\n // If the controller is updated then update the UI.\n controller.addListener(() {\n if (mounted) {\n setState(() {});\n }\n\n if (controller.value.hasError) {\n // Fluttertoast.showToast(\n // msg: 'Camera error ${controller.value.errorDescription}',\n // toastLength: Toast.LENGTH_SHORT,\n // gravity: ToastGravity.CENTER,\n // timeInSecForIos: 1,\n // backgroundColor: Colors.red,\n // textColor: Colors.white);\n }\n });\n\n try {\n await controller.initialize();\n } on CameraException catch (e) {\n // _showCameraException(e);\n }\n\n if (mounted) {\n setState(() {});\n }\n }\n}\n`","author_login":"justAsascha","author_association":"NONE","created_at":"2020-04-10T17:19:27+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_789551119","fragment_type":"issue_comment","sequence":11,"text":"When taking selfie in native camera at on Android devices, they are correcting the mirror effect, this is a useful feature to be baked into the `camera` package instead of modifing the image using `Transform` widget\nThanks for the issue!","author_login":"TahaTesser","author_association":"MEMBER","created_at":"2021-03-03T08:56:39+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_798111295","fragment_type":"issue_comment","sequence":12,"text":"@TahaTesser do you have any timeline as to when this can be fixed in the plugin code? We are about to go live.","author_login":"aytunch","author_association":"NONE","created_at":"2021-03-13T10:25:49+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_812334183","fragment_type":"issue_comment","sequence":13,"text":"Do we have a solution for video recording? Similar to that suggested by @peasfarmer for picture?","author_login":"AbhishekDoshi26","author_association":"NONE","created_at":"2021-04-02T05:50:27+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_843754601","fragment_type":"issue_comment","sequence":14,"text":"In the android library source code, I had modified a bit on the solution suggested by @peasfarmer in order to fix the mirroring on front camera\n\n \n\n// Listen for picture being taken\n pictureImageReader.setOnImageAvailableListener(\n reader -> {\n try (Image image = reader.acquireLatestImage()) {\n ByteBuffer buffer = image.getPlanes()[0].getBuffer();\n\n//Add this line.\n if (isFrontFacing) {\n byte[] buf2 = new byte[buffer.remaining()];\n buffer.get(buf2);\n Bitmap bitmap = BitmapFactory.decodeByteArray(buf2, 0, buf2.length);\n Matrix m = new Matrix();\n m.preScale(1, -1);\n m.postRotate(270);\n Bitmap dst = Bitmap.createBitmap(bitmap, 0, 0, bitmap.getWidth(), bitmap.getHeight(), m, true);\n dst.setDensity(DisplayMetrics.DENSITY_DEFAULT);\n ByteArrayOutputStream stream = new ByteArrayOutputStream();\n dst.compress(Bitmap.CompressFormat.JPEG, 100, stream);\n buffer = ByteBuffer.wrap(stream.toByteArray());\n }\n\n writeToFile(buffer, file);\n pictureCaptureRequest.finish(file.getAbsolutePath());\n } catch (IOException e) {\n pictureCaptureRequest.error(\"IOError\", \"Failed saving image\", null);\n }\n },\n null);","author_login":"abebrumal","author_association":"NONE","created_at":"2021-05-19T05:21:11+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_843755891","fragment_type":"issue_comment","sequence":15,"text":"In the android library source code, I had modified a bit on the solution suggested by @peasfarmer in order to fix the mirroring.\n\n \n\n// Listen for picture being taken\n pictureImageReader.setOnImageAvailableListener(\n reader -> {\n try (Image image = reader.acquireLatestImage()) {\n ByteBuffer buffer = image.getPlanes()[0].getBuffer();\n\n//Add this line.\n if (isFrontFacing) {\n byte[] buf2 = new byte[buffer.remaining()];\n buffer.get(buf2);\n Bitmap bitmap = BitmapFactory.decodeByteArray(buf2, 0, buf2.length);\n Matrix m = new Matrix();\n m.preScale(1, -1);\n m.postRotate(270);\n Bitmap dst = Bitmap.createBitmap(bitmap, 0, 0, bitmap.getWidth(), bitmap.getHeight(), m, true);\n dst.setDensity(DisplayMetrics.DENSITY_DEFAULT);\n ByteArrayOutputStream stream = new ByteArrayOutputStream();\n dst.compress(Bitmap.CompressFormat.JPEG, 100, stream);\n buffer = ByteBuffer.wrap(stream.toByteArray());\n }\n\n writeToFile(buffer, file);\n pictureCaptureRequest.finish(file.getAbsolutePath());\n } catch (IOException e) {\n pictureCaptureRequest.error(\"IOError\", \"Failed saving image\", null);\n }\n },\n null);","author_login":"abebrumal","author_association":"NONE","created_at":"2021-05-19T05:24:35+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_851182358","fragment_type":"issue_comment","sequence":16,"text":"@peasfarmer your answer is good solves the issue but the image is rotated 90 degrees in some devices","author_login":"BhavyKoshti9spl","author_association":"NONE","created_at":"2021-05-31T05:18:24+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_897200456","fragment_type":"issue_comment","sequence":17,"text":"Guys... i think i fixed it... i wasted 2 days of my life googling\n\nCredits goes to: URL \n\nSolution:\n\ndart\n XFile xfile = await _cameraController.takePicture();\n\n List imageBytes = await xfile.readAsBytes();\n\n img.Image? originalImage = img.decodeImage(imageBytes);\n img.Image fixedImage = img.flipVertical(originalImage!);\n\n File file = File(xfile.path);\n\n File fixedFile = await file.writeAsBytes(\n img.encodeJpg(fixedImage),\n flush: true,\n );\n\nEssentially we have to extract the image bytes we took into a temporary file variable, flip it and then write back those bytes into the original image we took, resulting in anti-mirrored file","author_login":"milanobrenovic","author_association":"NONE","created_at":"2021-08-11T22:21:45+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1002116163","fragment_type":"issue_comment","sequence":18,"text":"Hello, i understand this way for images. \nIs there a similar way to do ir from video files?","author_login":"XcelsiorGithub","author_association":"NONE","created_at":"2021-12-28T13:52:54+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1058214794","fragment_type":"issue_comment","sequence":19,"text":"Hey any updates on this?\nI'm experiencing this issue both on iOS and Android.","author_login":"naamapps","author_association":"NONE","created_at":"2022-03-03T16:13:11+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1173214045","fragment_type":"issue_comment","sequence":20,"text":"Thank you so much! It's working perfectly as I expected... 🚀","author_login":"msi-shamim","author_association":"NONE","created_at":"2022-07-04T00:45:42+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1186389368","fragment_type":"issue_comment","sequence":21,"text":"From you current Camera description, the one the user is using to take the picture/video.\n\n//Properties you need in your controller class\n\nfinal cameras = List ([]);\nint camIndex = 0;\n\nThen just check after taking the picture, like this:\n\n if (cameras.value[camIndex].lensDirection == CameraLensDirection.front) {\n originalImg = img.flipHorizontal(originalImg);\n }","author_login":"reiko-dev","author_association":"NONE","created_at":"2022-07-17T03:48:22+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1190438738","fragment_type":"issue_comment","sequence":22,"text":"Is there a solution for videos? **also why does this issue keep getting closed even when it is unresolved! Just because people are not commenting, it does not mean the issue has magically stopped being an issue!","author_login":"vlad-ed-git","author_association":"NONE","created_at":"2022-07-20T15:35:45+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1231235940","fragment_type":"issue_comment","sequence":23,"text":"I re-wrote a dependency library based on the Camera package to solve the front-facing camera flip problem, you can see:\n URL \n URL","author_login":"q384264619","author_association":"NONE","created_at":"2022-08-30T07:04:12+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1231241490","fragment_type":"issue_comment","sequence":24,"text":"I re-wrote a dependency library based on the Camera package to solve the front-facing camera flip problem, you can see:\n URL","author_login":"q384264619","author_association":"NONE","created_at":"2022-08-30T07:10:16+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1335427583","fragment_type":"issue_comment","sequence":25,"text":"A video recorded by the front camera is mirrored in a file, but looking good in the CameraPreview. Do we have a solution for video recording?","author_login":"Fudal","author_association":"NONE","created_at":"2022-12-02T15:33:04+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1420436804","fragment_type":"issue_comment","sequence":26,"text":"iOS recorded video of the front camera is not mirrored as the default camera app in the iphone. This results to incorrect video output and very difficult to correct with postprocessing libraries of the video. This should be just a flag set in the SWIFT code. Can anybody help. I am able to test","author_login":"bogdannedelcu","author_association":"NONE","created_at":"2023-02-07T09:12:51+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1429490715","fragment_type":"issue_comment","sequence":27,"text":"import 'package:ffmpeg_kit_flutter/ffmpeg_kit.dart';\n\n...\n\nawait FFmpegKit.execute(\"-y -i \" +\n videoFile.path +\n\n \" -filter:v \\\"hflip\\\" -pix_fmt yuv420p -vcodec hevc_videotoolbox -b:v 1200k -tag:v hvc1 -c:a eac3 -b:a 64k \" +\n applicationTemporaryDirectoryPath + '/video_roeid_mirror.mp4'\n );\n\ntune the -b:v parameters for video quality\n\nInside XCode you should add this:\n\nimage\n\nimage","author_login":"bogdannedelcu","author_association":"NONE","created_at":"2023-02-14T10:28:22+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1459928289","fragment_type":"issue_comment","sequence":28,"text":"When using Flutter SDK>3.x\n \n\nfinal XFile xfile = await controller!.takePicture();\n debugPrint(\"camera id is ${controller!.cameraId}\");\n Uint8List imageBytes = (await rawImage?.readAsBytes()) as Uint8List;\n\n img.Image? originalImage = img.decodeImage(imageBytes);\n img.Image fixedImage = img.flipHorizontal(originalImage!);\n\n File file = File(xfile.path);\n File fixedFile = await file.writeAsBytes(\n img.encodeJpg(fixedImage),\n flush: true,\n );","author_login":"goddev99","author_association":"NONE","created_at":"2023-03-08T10:09:38+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1485166152","fragment_type":"issue_comment","sequence":29,"text":"CamerAwesome now has a simple setting `mirrorFrontCamera` that let you decide wether you want the output to be mirrored or not.\n\nExample usage:\n\ndart\nCameraAwesomeBuilder.awesome(\n saveConfig: SaveConfig.photoAndVideo(\n photoPathBuilder: () => path(CaptureMode.photo),\n videoPathBuilder: () => path(CaptureMode.video),\n initialCaptureMode: CaptureMode.photo,\n ),\n onMediaTap: (mediaCapture) {\n OpenFile.open(mediaCapture.filePath);\n },\n mirrorFrontCamera: true, // Set it to true for mirroring, false otherwise\n)\n\nFeel free to share feedback!","author_login":"apalala-dev","author_association":"NONE","created_at":"2023-03-27T14:04:46+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1688031909","fragment_type":"issue_comment","sequence":30,"text":"Still persists.. But I found a solution using the image package:\n\ndart\nimport 'package:image/image.dart' as img;\n\n late CameraController _controller;\n late bool _isRearCameraSelected;\n late bool confirm;\n late bool isFlash;\n late XFile image;\n late img.Image flippedImage;\n\n Future initCamera(CameraDescription cameraDescription) async {\n _controller = CameraController(\n cameraDescription,\n ResolutionPreset.high,\n enableAudio: false,\n );\n try {\n await _controller.initialize();\n\n if (!mounted) return;\n\n setState(() {});\n } on CameraException catch (e) {\n debugPrint(\"camera error $e\");\n }\n }\n\n @override\n void initState() {\n super.initState();\n _isRearCameraSelected = true;\n confirm = false;\n isFlash = false;\n initCamera(widget.camera[0])\n .whenComplete(() => _controller.setFlashMode(FlashMode.off));\n }\n\n @override\n void dispose() {\n _controller.dispose();\n super.dispose();\n } Future initCamera(CameraDescription cameraDescription) async {\n _controller = CameraController(\n cameraDescription,\n ResolutionPreset.high,\n enableAudio: false,\n );\n try {\n await _controller.initialize();\n\n if (!mounted) return;\n\n setState(() {});\n } on CameraException catch (e) {\n debugPrint(\"camera error $e\");\n }\n }\n\n @override\n void initState() {\n super.initState();\n _isRearCameraSelected = true;\n confirm = false;\n isFlash = false;\n initCamera(widget.camera[0])\n .whenComplete(() => _controller.setFlashMode(FlashMode.off));\n }\n\n @override\n void dispose() {\n _controller.dispose();\n super.dispose();\n }\n\n// This is the OnTap function of an InkWell widget\n () async {\n try {\n// we take the picture using the camera package\n image = await _controller.takePicture();\n if (!_isRearCameraSelected) {\n flippedImage =\n img.decodeJpg(await image.readAsBytes())!; // we fill in the image in memory for manipulation\n flippedImage = img.flipHorizontal(flippedImage); // we flip it\n await img.encodeJpgFile(\n image.path, flippedImage); // and finally override the original image with the corrected one\n } \n // display the confirm\n setState(() {\n confirm = !confirm;\n });\n } catch (e) {\n developer.log(e.toString(),\n name: \"exception in takePicture\");\n }\n }","author_login":"DroidZed","author_association":"NONE","created_at":"2023-08-22T11:47:39+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1688177250","fragment_type":"issue_comment","sequence":31,"text":"I found a workaround involving a third party library: `package:image`\n\ndart\nimport 'package:image/image.dart' as img; // import the library\n\n// Then in your *Stateful* widget:\n\n late CameraController _controller;\n late bool _isRearCameraSelected; // have some variable to handle the state of switching between cameras...\n late XFile image; // the image file, managed by the controller\n late img.Image flippedImage; // the flipped image, gonna use this as a temp variable\n...\n\n// This is our version of initializing the camera with settings, feel free to modify as needed:\n Future initCamera(CameraDescription cameraDescription) async {\n _controller = CameraController(\n cameraDescription,\n ResolutionPreset.high,\n enableAudio: false,\n );\n try {\n await _controller.initialize();\n\n if (!mounted) return;\n\n setState(() {});\n } on CameraException catch (e) {\n debugPrint(\"camera error $e\");\n }\n }\n\n @override\n void initState() {\n super.initState();\n _isRearCameraSelected = true;\n confirm = false;\n isFlash = false;\n initCamera(widget.camera[0])\n .whenComplete(() => _controller.setFlashMode(FlashMode.off));\n }\n\n @override\n void dispose() {\n _controller.dispose();\n super.dispose();\n }\n\n...\n\n// Down into the function callback for when you click on a button to switch cameras:\n () async {\n try {\n image = await _controller.takePicture();\n if (!_isRearCameraSelected) {\n flippedImage =\n img.decodeJpg(await image.readAsBytes())!;\n flippedImage = img.flipHorizontal(flippedImage);\n await img.encodeJpgFile(\n image.path, flippedImage);\n }\n // display the confirm\n setState(() {\n confirm = !confirm;\n });\n } catch (e) {\n developer.log(e.toString(),\n name: \"exception in takePicture\");\n }\n }","author_login":"DroidZed","author_association":"NONE","created_at":"2023-08-22T13:20:39+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1746542815","fragment_type":"issue_comment","sequence":32,"text":"Still an issue for us. \nwe don't want to use a 3rd party plugin for this, and flipping videos with ffmpeg is a hudge performance problem. \n\nCan we have a flag to prevent mirroring ? or to get the non mirrored video after record... ? \nlike iOS does in photo app when recording a video with front camera.","author_login":"jeyremy","author_association":"NONE","created_at":"2023-10-04T10:00:18+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1752065156","fragment_type":"issue_comment","sequence":33,"text":"While using Transform or other post processing might work, with the release of `camera: 0.10.4`, the plugin allows for the camera to be flipped mid video recording. This means that simple flipping of the video post capture will no longer be correct as both parts of the video, those of the front and the back lens would be flipped.\n\nIf there are any native APIs that allow for the recording to be saved as previewed, then the camera plugin should probably expose them. Otherwise, recordings with multiple cameras will more or less always be incorrect if the user of the plugin will want to show exactly what was previewed to the user and save the video as such.","author_login":"jellynoone","author_association":"CONTRIBUTOR","created_at":"2023-10-08T15:29:17+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1794534907","fragment_type":"issue_comment","sequence":34,"text":"This issue should be closed after adding the mirror attribute (true, false) to the camera plugin itself","author_login":"Mamasodikov","author_association":"NONE","created_at":"2023-11-06T10:41:46+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1865716622","fragment_type":"issue_comment","sequence":35,"text":"Working fine in iOS but in Android it's still saving mirrored video/image. Any idea when it will be resolve?","author_login":"ahmad-whizpool","author_association":"NONE","created_at":"2023-12-21T07:14:42+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1865722174","fragment_type":"issue_comment","sequence":36,"text":"Please add setMirror method and update target sdk to 33 currently it 28","author_login":"ahmad-whizpool","author_association":"NONE","created_at":"2023-12-21T07:16:54+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1897866654","fragment_type":"issue_comment","sequence":37,"text":"If you're only looking for solving mirror image issue try below snippet when user takes picture from front camera, however there is still issue of video mirroring though 🙃\n\nthis issue needs to be fixed ASAP\n\nimport 'dart:io';\nimport 'dart:typed_data';\nimport 'package:image/image.dart' as img;\n\n /// Flips and overrides provided image.\n static String flipImage(String path) {\n // Read the image from file.\n final inputImageFile = File(path);\n final bytes = inputImageFile.readAsBytesSync();\n var image = img.decodeImage(Uint8List.fromList(bytes))!;\n\n // Flip the image.\n image = img.flip(image, direction: img.FlipDirection.horizontal);\n\n // Save the flipped image.\n File(path).writeAsBytesSync(Uint8List.fromList(img.encodeJpg(image)));\n 'Flipped image saved to: $path'.logD;\n return path;\n }","author_login":"wdcs-dimilkalathiya","author_association":"NONE","created_at":"2024-01-18T06:13:10+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1945212773","fragment_type":"issue_comment","sequence":38,"text":"Is there any solution looking to come from this at all? By all appearances, the package camerawesome has managed to turn front camera mirroring into a toggle-able feature. Just curious if there's any similar solutions in the works for the main camera plugin. Recording any video (or image) content with text or other similar content is not really doable right now. At least not without doing video processing after the fact","author_login":"ChristopherCfly","author_association":"NONE","created_at":"2024-02-15T01:19:54+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1950289998","fragment_type":"issue_comment","sequence":39,"text":"I can't imagine a person in this world who likes to take a selfie without mirror mode on the camera. However, this package does not allow you to do that, even though this feature was requested in 2019. I understand that Flutter is a huge project and requires prioritizing. But, my question is: Should it be a priority to run Flutter even on a washing machine, when you still can't take a proper selfie on an iPhone? 🤷🏼‍♂️","author_login":"siddharthadevops","author_association":"NONE","created_at":"2024-02-17T19:31:15+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1951969871","fragment_type":"issue_comment","sequence":40,"text":"@siddharthadevops Hi, it's not about taking a photo not in selfie mode, it's about taking a video, as camera plugin serve both of this... \nTaking a video in mirror mode is not the problem, but saving it in mirror mode it is, if you have something in background like a car, a brand name, it's all reversed... what would be great is to choose it, like in iOS / Swift","author_login":"jeyremy","author_association":"NONE","created_at":"2024-02-19T08:51:25+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1974809104","fragment_type":"issue_comment","sequence":41,"text":"@jeyremy Hi, what I was trying to emphasize is that issues like this should be prioritized in the platform roadmap. Flutter should provide full support for enabling and disabling mirroring through this package and also image_picker, which depends on it. For both image and video, at the time the content is captured and, of course, at the time it is saved. Post-processing of content, especially video, is not an option.","author_login":"siddharthadevops","author_association":"NONE","created_at":"2024-03-02T14:23:52+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2077339753","fragment_type":"issue_comment","sequence":42,"text":"`image_picker` does not depend on the `camera` package; the camera UI that is available through `image_picker` is provided entirely by the OS.","author_login":"stuartmorgan","author_association":"CONTRIBUTOR","created_at":"2024-04-25T14:26:43+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2103420183","fragment_type":"issue_comment","sequence":43,"text":"if it just about UI\n\ndart\nTransform.flip(\n flipX: true,\n child: Image.file(\n File(selfieImagePath!),\n ),\n )","author_login":"yeasin50","author_association":"CONTRIBUTOR","created_at":"2024-05-09T21:06:17+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2137178438","fragment_type":"issue_comment","sequence":44,"text":"This function failed on Samsung devices. It rotated image instead of flipping.\n\nThis worked perfectly for me: URL","author_login":"Mamasodikov","author_association":"NONE","created_at":"2024-05-29T11:24:56+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2137994309","fragment_type":"issue_comment","sequence":45,"text":"My problem is that I use image picker package for the user to take an image from any of the cameras, front or rear, and I only want to mirror if the image was taken with the front camera. When the plugin returns an image I can't tell which camera it was taken with, so I can't apply any transformations.","author_login":"siddharthadevops","author_association":"NONE","created_at":"2024-05-29T18:11:44+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2138004451","fragment_type":"issue_comment","sequence":46,"text":"If user takes image from image picker there is no problem with mirror effect","author_login":"Mamasodikov","author_association":"NONE","created_at":"2024-05-29T18:17:47+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2138878809","fragment_type":"issue_comment","sequence":47,"text":"Maybe I'm missing something. I think it is a problem because of what I explained before. Because I can't determine the origin of the photo, front or rear camera, I don't know whether to apply the mirror effect or not.\nThis only happens on iOS, on Android pictures taken with the front camera have the mirror effect applied.","author_login":"siddharthadevops","author_association":"NONE","created_at":"2024-05-30T07:40:47+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2138994191","fragment_type":"issue_comment","sequence":48,"text":"If you get a captured JPEG, you may (in some cases) determine the source camera by examining the EXIF headers of this file. EXIF headers can provide rather detailed description of the camera that was used. E.g. Camera maker, Camera model…One indicator that can help is the Focal length. Here, this is 3.5-4mm for the \"main\" camera, and 2mm for the secondary lens. \nScreenshot 2024-05-30 at 13 23 37","author_login":"Mamasodikov","author_association":"NONE","created_at":"2024-05-30T08:24:34+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2161474053","fragment_type":"issue_comment","sequence":49,"text":"Now, that the default android camera implementation is camerax is there a change this issue is revisted?\n\nThe problem with workarounds (other than using a another package) is that when using the mid-recording camera switching feature, you can no longer post process the video.\nThis seems like a major blocker for applications that try to create a camera experience that mimics the social media camera behaviour (record and double tap to change the camera used and save the video as previewed).\n\n@stuartmorgan you originally assigned a p3 on this issue back in 2021. Have priorities shifted since then?","author_login":"jellynoone","author_association":"CONTRIBUTOR","created_at":"2024-06-11T19:34:23+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2455173986","fragment_type":"issue_comment","sequence":50,"text":"Do we have a release plan for a fix? As of today I still experience this issue. It would be great to let the developer choose to flip or not.\nUpdating the UI or editing the file afterwards is not a valid solution as the Camera will show a preview of the flipped photo for confirmation, leading to incoherent user experience.\nIf you know how to alter the confirmation preview with the current version of the package, please let me know.","author_login":"AdrKacz","author_association":"NONE","created_at":"2024-11-04T16:33:12+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2457170974","fragment_type":"issue_comment","sequence":51,"text":"I do have a workaround. Not a fix, but a temporary solution to deal with this. \n\nif you open the camera package itself, inside the .pub-cache folder, and find the camera_avfoundation-{version}\ngo to the ios folder then camera_avfoundation/Sources/FLTCam.m\n\nInside the file, find the line with \n\nswift\nconnection.videoMirrored = Yes;\n\nChange it to No and save it.\n\nWhen you build using this dependency in future, your output video will be recorded without mirroring. Unfortunately your preview also becomes unmirrored, but I find its easier to apply a conditional horizontal flip with a transform widget to correct thiis.\n\nI feel like the ideal solution in future would be to have the package be able to pass and update this property through the CameraController, then auto-apply corrections to the preview. Also keep in mind, any time replacing the dependency. ie with a new version, this property will have to be updated again.","author_login":"ChristopherLinnett","author_association":"NONE","created_at":"2024-11-05T13:21:27+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2684805297","fragment_type":"issue_comment","sequence":52,"text":"to handle mirroring camera in UI Widget, you can wrap the CameraPreview using Transform.flip, \n\n` Transform.flip(\n flipX: true,\n child: CameraPreview(_cameraController),\n ),`\n\nand for flip the image file you can use this function method\n\n`import 'package:image/image.dart' as img;\nimport 'dart:io';\n\nFuture fixImage(File file) async {\n final bytes = await file.readAsBytes();\n img.Image? image = img.decodeImage(bytes);\n\n if (image != null) {\n img.Image fixedImage = img.flipHorizontal(image);\n return File(file.path)..writeAsBytesSync(img.encodeJpg(fixedImage));\n }\n return file;\n}`","author_login":"programmermager","author_association":"NONE","created_at":"2025-02-26T12:21:22+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2746903113","fragment_type":"issue_comment","sequence":53,"text":"It should be possible to expose the control by combining the Android CameraX support from URL and URL for Darwin. Not sure about other platforms.","author_login":"AlexV525","author_association":"MEMBER","created_at":"2025-03-24T05:09:33+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[407865675],"is_known_query_context":false},{"document_id":"gh_comment_2779557824","fragment_type":"issue_comment","sequence":54,"text":"How can this be 6 years and not solved yet? Of course Transform.flip and img.flipHorizontal works, but then the user has to experience a delay because of that flip call, that should not be necessary.","author_login":"underfilho","author_association":"NONE","created_at":"2025-04-04T19:16:51+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3117653939","fragment_type":"issue_comment","sequence":55,"text":"@aniruddh-p41 \nIf you look up, I put a workaround in. Basically go to the package itself. Disable the mirroring there, then in your app. You need to check for this case specifically to put a flip on the preview when this case is hit. \n\nIts not perfect, but I'm not about to launch a PR to flutter itself either. \nFor me I found a simple way of handling this thats a bit more automated. \n\nI added a snippet to my Github Actions workflow I use for deploying my iOS app. It runs just before the build process. For me this is enough so that I don't have to worry about it. \n\nyaml\n - name: Patch camera_avfoundation FLTCam.m to disable videoMirrored\n run: |\n set -e\n FILE=$(find $HOME/.pub-cache/hosted/pub.dev/ -type f -path \"*/camera_avfoundation-*/ios/camera_avfoundation/Sources/camera_avfoundation_objc/FLTCam.m\" | head -n 1)\n if [ -z \"$FILE\" ]; then\n echo \"FLTCam.m not found!\"\n exit 1\n fi\n echo \"Patching $FILE\"\n sed -i.bak 's/connection.videoMirrored = YES;/connection.videoMirrored = NO;/' \"$FILE\"","author_login":"ChristopherLinnett","author_association":"NONE","created_at":"2025-07-25T12:44:01+08:00","repo_name":"flutter/flutter","issue_id":407865675,"issue_number":27650,"issue_url":"https://github.com/flutter/flutter/issues/27650","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0045","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"residual and capacity do not have the value returned by the API?","query_context":"### Mark\n\nPeugeot\n\n### Model\n\ne208\n\n### Year\n\n2020\n\n### Engine\n\nElectric\n\n### Remote service\n\nE-remote control\n\n### HomeAssistant version\n\nlast\n\n### Integration version\n\nlast\n\n### What happened?\n\nHi, I think there is a problem with the display of battery capacity and remaining values.\nthe percentage does not correspond to the displayed values either\n\nAPI log : \n'preconditioning': {'airConditioning': {'createdAt': '2025-08-19T06:47:53Z', 'updatedAt': '2025-08-19T06:47:53Z', 'status': 'Disabled'}}, 'energies': [{'createdAt': '2025-08-10T02:12:28Z', 'type': 'Electric', 'subType': 'ElectricEnergy', 'level': 41.0, 'autonomy': 160, 'extension': {'electric': {'battery': {'load': {'createdAt': '2025-08-10T02:12:28Z', **'capacity': 46176, 'residual': 18688}},** 'charging': {'plugged': False, 'status': 'Disconnected', 'chargingRate': 0, 'chargingMode': 'No', 'nextDelayedTime': 'PT22H5M', 'schedule': []}}}}], 'preconditionning': {'airConditioning': {'createdAt': '2025-08-19T06:47:53Z', 'updatedAt': '2025-08-19T06:47:53Z', 'status': 'Disabled'}}, 'energy': [{'createdAt': '2025-08-10T02:12:28Z', 'updatedAt': '2025-08-19T06:47:53Z', 'type': 'Electric', 'level': 41.0, 'autonomy': 160, 'charging': {'plugged': False, 'status': 'Disconnected', 'chargingRate': 0, 'chargingMode': 'No', 'nextDelayedTime': 'PT22H5M'}}]}\n\nintegration value in yellow :\n\n \n\n \n\n### Log output\n\nshell","known_context_document_ids":["gh_issue_3333286707"],"reference_answer":"Unfortunally stellantis dont provide the specific type of hybrid.\nThe only way is to remove capacity and residual for all hybrids on next release.","answer_document_id":"gh_comment_3012288415","silver_evidence_path":["gh_comment_3207555401","gh_issue_3171387380","gh_comment_3012288415"],"evidence_issue_ids":[3333286707,3171387380],"source_repo_name":"andreadegiovine/homeassistant-stellantis-vehicles","source_issue_id":3333286707,"source_issue_number":264,"source_issue_url":"https://github.com/andreadegiovine/homeassistant-stellantis-vehicles/issues/264","target_repo_name":"andreadegiovine/homeassistant-stellantis-vehicles","target_issue_id":3171387380,"target_issue_number":208,"target_issue_url":"https://github.com/andreadegiovine/homeassistant-stellantis-vehicles/issues/208","reference_anchor_document_id":"gh_comment_3207555401","reference_answer_author":"andreadegiovine","reference_answer_author_association":"OWNER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1818,"anchor_target_overlap":0.1818,"target_answer_overlap":0.3125},"issue_created_at":"2025-08-19T07:42:58+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_3333286707","fragment_type":"issue_description","sequence":0,"text":"residual and capacity do not have the value returned by the API\n### Mark\n\nPeugeot\n\n### Model\n\ne208\n\n### Year\n\n2020\n\n### Engine\n\nElectric\n\n### Remote service\n\nE-remote control\n\n### HomeAssistant version\n\nlast\n\n### Integration version\n\nlast\n\n### What happened?\n\nHi, I think there is a problem with the display of battery capacity and remaining values.\nthe percentage does not correspond to the displayed values either\n\nAPI log : \n'preconditioning': {'airConditioning': {'createdAt': '2025-08-19T06:47:53Z', 'updatedAt': '2025-08-19T06:47:53Z', 'status': 'Disabled'}}, 'energies': [{'createdAt': '2025-08-10T02:12:28Z', 'type': 'Electric', 'subType': 'ElectricEnergy', 'level': 41.0, 'autonomy': 160, 'extension': {'electric': {'battery': {'load': {'createdAt': '2025-08-10T02:12:28Z', **'capacity': 46176, 'residual': 18688}},** 'charging': {'plugged': False, 'status': 'Disconnected', 'chargingRate': 0, 'chargingMode': 'No', 'nextDelayedTime': 'PT22H5M', 'schedule': []}}}}], 'preconditionning': {'airConditioning': {'createdAt': '2025-08-19T06:47:53Z', 'updatedAt': '2025-08-19T06:47:53Z', 'status': 'Disabled'}}, 'energy': [{'createdAt': '2025-08-10T02:12:28Z', 'updatedAt': '2025-08-19T06:47:53Z', 'type': 'Electric', 'level': 41.0, 'autonomy': 160, 'charging': {'plugged': False, 'status': 'Disconnected', 'chargingRate': 0, 'chargingMode': 'No', 'nextDelayedTime': 'PT22H5M'}}]}\n\nintegration value in yellow :\n\n \n\n \n\n### Log output\n\nshell","author_login":"ben33880","author_association":"CONTRIBUTOR","created_at":"2025-08-19T07:42:58+08:00","repo_name":"andreadegiovine/homeassistant-stellantis-vehicles","issue_id":3333286707,"issue_number":264,"issue_url":"https://github.com/andreadegiovine/homeassistant-stellantis-vehicles/issues/264","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_3207527929","fragment_type":"issue_comment","sequence":1,"text":"@andreadegiovine \n\nThank you for the clarification.\n\nIn my case, the API reports a capacity of 52.8 kWh and a remaining capacity of 40.05 kWh:\n`\nenergies': [{'createdAt': '2025-06-30T17:54:08Z', 'type': 'Electric', 'subType': 'ElectricEnergy', 'level': 81.0, 'autonomy': 320, 'extension': {'electric': {'battery': {'load': {'createdAt': '2025-06-30T17:54:08Z', 'capacity': 52800, 'residual': 40050}}\n`\n\nMy vehicle has a range of 320 km with a remaining capacity of 40.05 kWh and a range of 416 km when fully charged.\n\nLet's do the math:\n40,05 kWh / 320 km * 100 km = 12,515625 kWh/100km\n52,8 kWh / 416 km * 100 km = 12,6923076923 kWh/100km\n(After a trip, the vehicle reports a consumption of approximately 11–14 kWh/100 km.(depending on driving style))\n\nSo, for me, the values reported by the API are perfectly plausible, and there's no need to add an additional 10 kWh.\n\nSimilar figures were also published on the website:\n\n(Its new 156 hp electric engine, combined with an improved energy density battery of 54 kWh, offers a range in the WLTP cycle of 420 km.)","author_login":"MoellerDi","author_association":"CONTRIBUTOR","created_at":"2025-08-20T18:08:59+08:00","repo_name":"andreadegiovine/homeassistant-stellantis-vehicles","issue_id":3333286707,"issue_number":264,"issue_url":"https://github.com/andreadegiovine/homeassistant-stellantis-vehicles/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3207555401","fragment_type":"issue_comment","sequence":2,"text":"I'm not sure how the percentage is calculated... but even 42 kWh would be close enough to the reported 40.05 kWh. It's closer to the truth than the integration, which currently comes in at 50.05 kWh :-)\n\nbtw, It seems there is at least another issues #208 about Capacity/Residual values....","author_login":"MoellerDi","author_association":"CONTRIBUTOR","created_at":"2025-08-20T18:19:12+08:00","repo_name":"andreadegiovine/homeassistant-stellantis-vehicles","issue_id":3333286707,"issue_number":264,"issue_url":"https://github.com/andreadegiovine/homeassistant-stellantis-vehicles/issues/264","linked_issue_ids":[3171387380],"is_known_query_context":false},{"document_id":"gh_comment_3207695064","fragment_type":"issue_comment","sequence":3,"text":"e208 2020\nSOH 90.4% -> given by Peugeot, this value is unknown with the integration\nSOC 41%\nCapacity 46,176kWh\nResidual 18,688kWh\nBuffer (from gbt) dont know","author_login":"ben33880","author_association":"NONE","created_at":"2025-08-20T19:06:29+08:00","repo_name":"andreadegiovine/homeassistant-stellantis-vehicles","issue_id":3333286707,"issue_number":264,"issue_url":"https://github.com/andreadegiovine/homeassistant-stellantis-vehicles/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3207715251","fragment_type":"issue_comment","sequence":4,"text":"ok, as per the following website:\n\nYour Mokka-e2022 has a nominal capacity of 50.0 kWh and useable capacity of 46.3 kWh\n URL \n\nMy eC4 2024 has a nominal capacity of 54.0 kWh and useable capacity of 50.8 kWh -> again match the values from the API\n URL","author_login":"MoellerDi","author_association":"CONTRIBUTOR","created_at":"2025-08-20T19:11:45+08:00","repo_name":"andreadegiovine/homeassistant-stellantis-vehicles","issue_id":3333286707,"issue_number":264,"issue_url":"https://github.com/andreadegiovine/homeassistant-stellantis-vehicles/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3207753034","fragment_type":"issue_comment","sequence":5,"text":"SOH 90.4% -> given by Peugeot, this value is unknown with the integration \nSOC 41% \nCapacity 46,176kWh \nResidual 18,688kWh \nBuffer (from gbt) dont know\n\nis this matching your vehicle? _(Nominal Capacity | 51.0 kWh, Useable Capacity | 48.1 kWh)_\n URL","author_login":"MoellerDi","author_association":"CONTRIBUTOR","created_at":"2025-08-20T19:21:59+08:00","repo_name":"andreadegiovine/homeassistant-stellantis-vehicles","issue_id":3333286707,"issue_number":264,"issue_url":"https://github.com/andreadegiovine/homeassistant-stellantis-vehicles/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3207785039","fragment_type":"issue_comment","sequence":6,"text":"my car : URL \nsame capacity as your mokka 50 kWh nominal and 46,3 kWh usable\n\nthe nearest calculation for me :\n50 * SOH * SOC = residual\n50*90.4%*41% = 18,53 kWh\n\nfor ur mokka : \n50*92%*68% = 31,28 kWh => api give bad information !!!!","author_login":"ben33880","author_association":"NONE","created_at":"2025-08-20T19:27:00+08:00","repo_name":"andreadegiovine/homeassistant-stellantis-vehicles","issue_id":3333286707,"issue_number":264,"issue_url":"https://github.com/andreadegiovine/homeassistant-stellantis-vehicles/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_3171387380","fragment_type":"issue_description","sequence":0,"text":"Mild Hybrid Battery Capacity/Residual value\n### Mark\n\nPeugeot\n\n### Model\n\n5008\n\n### Year\n\n2025\n\n### Engine\n\nHybrid\n\n### Remote service\n\nE-remote control\n\n### HomeAssistant version\n\n2025.6.2\n\n### Integration version\n\n2025.6.6\n\n### What happened?\n\nHi,\n\nI have a mild-hybrid Peugeot 5008. These has very small battery capacity.\nThe integration always add +10 kwh to the value given by Stellantis server, which is wrong.\n\nI corrected the error in base.py using the following code. If you find it correct, you could implement it in your fork.\n\n if key in [\"battery_capacity\", \"battery_residual\"]:\n if int(value) 1000:\n value = (float(value) / 1000) + 10\n else:\n value = (float(value) / 1000) \n\nFor now, i simply checked if the given capacity is <1000Wh. This is the case of all Stellantis mild hybrids (none-rechargeable), but needs to be confirmed.\n\n### Log output\n\nshell","author_login":"adonix31","author_association":"NONE","created_at":"2025-06-24T10:25:07+08:00","repo_name":"andreadegiovine/homeassistant-stellantis-vehicles","issue_id":3171387380,"issue_number":208,"issue_url":"https://github.com/andreadegiovine/homeassistant-stellantis-vehicles/issues/208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3001180147","fragment_type":"issue_comment","sequence":1,"text":"For PlugInHybrid (308) battery_residual and battery_capacity have value \"Unknown\"\n\nIs there any sense to provide this information for mild hybrid when this battery is that small and you don't have any impact on its level?","author_login":"Jordan87","author_association":"CONTRIBUTOR","created_at":"2025-06-24T16:44:26+08:00","repo_name":"andreadegiovine/homeassistant-stellantis-vehicles","issue_id":3171387380,"issue_number":208,"issue_url":"https://github.com/andreadegiovine/homeassistant-stellantis-vehicles/issues/208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3012288415","fragment_type":"issue_comment","sequence":2,"text":"Unfortunally stellantis dont provide the specific type of hybrid.\nThe only way is to remove capacity and residual for all hybrids on next release.","author_login":"andreadegiovine","author_association":"OWNER","created_at":"2025-06-27T09:08:04+08:00","repo_name":"andreadegiovine/homeassistant-stellantis-vehicles","issue_id":3171387380,"issue_number":208,"issue_url":"https://github.com/andreadegiovine/homeassistant-stellantis-vehicles/issues/208","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0048","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Receive from dashboard?","query_context":"As a fast-follow for send, we need to design a way to handle \"Send\" & \"Receive\" as global action.\nThis issue is about the Receive part that is delivered separately.\n\nAC:\n- User is able to trigger receive from homepage \n- User is able to choose or create new account for receiving \n\nDesigns: URL","known_context_document_ids":["gh_issue_2770798238"],"reference_answer":"Missing Cardano Send feature is something that has to be handled here. And even if we unblock the ADA send and implemented, it will probably be available only on 2.8.7 FW and not older (since the ADA send flow has been changed in that version). URL","answer_document_id":"gh_comment_2603965598","silver_evidence_path":["gh_comment_2603958190","gh_issue_2801051938","gh_comment_2603965598"],"evidence_issue_ids":[2770798238,2801051938],"source_repo_name":"trezor/trezor-suite","source_issue_id":2770798238,"source_issue_number":16204,"source_issue_url":"https://github.com/trezor/trezor-suite/issues/16204","target_repo_name":"trezor/trezor-suite","target_issue_id":2801051938,"target_issue_number":16484,"target_issue_url":"https://github.com/trezor/trezor-suite/issues/16484","reference_anchor_document_id":"gh_comment_2603958190","reference_answer_author":"matejkriz","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.625,"anchor_target_overlap":0.5,"target_answer_overlap":0.15},"issue_created_at":"2025-01-06T14:37:29+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_2770798238","fragment_type":"issue_description","sequence":0,"text":"Receive from dashboard\nAs a fast-follow for send, we need to design a way to handle \"Send\" & \"Receive\" as global action.\nThis issue is about the Receive part that is delivered separately.\n\nAC:\n- User is able to trigger receive from homepage \n- User is able to choose or create new account for receiving \n\nDesigns: URL","author_login":"shenkys","author_association":"NONE","created_at":"2025-01-06T14:37:29+08:00","repo_name":"trezor/trezor-suite","issue_id":2770798238,"issue_number":16204,"issue_url":"https://github.com/trezor/trezor-suite/issues/16204","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2580768014","fragment_type":"issue_comment","sequence":1,"text":"Receive tab has been removed and global Receive button on dashboard added in this PR URL but it's not finished. \n\n- Send button is missing\n- Receive flow missing + button\n- Missing ADA Send is not handled!!!","author_login":"matejkriz","author_association":"MEMBER","created_at":"2025-01-09T16:37:50+08:00","repo_name":"trezor/trezor-suite","issue_id":2770798238,"issue_number":16204,"issue_url":"https://github.com/trezor/trezor-suite/issues/16204","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2603958190","fragment_type":"issue_comment","sequence":2,"text":"The issue has been split to Receive (this one, original) and new Send URL","author_login":"matejkriz","author_association":"MEMBER","created_at":"2025-01-21T08:29:42+08:00","repo_name":"trezor/trezor-suite","issue_id":2770798238,"issue_number":16204,"issue_url":"https://github.com/trezor/trezor-suite/issues/16204","linked_issue_ids":[2801051938],"is_known_query_context":false},{"document_id":"gh_issue_2801051938","fragment_type":"issue_description","sequence":0,"text":"Send from dashboard\nAs a fast-follow for send, we need to design a way to handle \"Send\" & \"Receive\" as global action.\nThis issue is just for Send, receive was done in URL \n\nAC:\n- User is able to trigger send from homepage\n- User is able to choose acount for sending\n- User sees only accounts with positive balances for Send\n\nDesigns: URL \n\nFollowup issue for analytics: URL","author_login":"matejkriz","author_association":"MEMBER","created_at":"2025-01-21T08:28:38+08:00","repo_name":"trezor/trezor-suite","issue_id":2801051938,"issue_number":16484,"issue_url":"https://github.com/trezor/trezor-suite/issues/16484","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2603965598","fragment_type":"issue_comment","sequence":1,"text":"Missing Cardano Send feature is something that has to be handled here. And even if we unblock the ADA send and implemented, it will probably be available only on 2.8.7 FW and not older (since the ADA send flow has been changed in that version). URL","author_login":"matejkriz","author_association":"MEMBER","created_at":"2025-01-21T08:32:11+08:00","repo_name":"trezor/trezor-suite","issue_id":2801051938,"issue_number":16484,"issue_url":"https://github.com/trezor/trezor-suite/issues/16484","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2668321630","fragment_type":"issue_comment","sequence":2,"text":"I might found a bug in this - when trying to send ERC20 token from the dashboard, it opens ETH send form instead for me.","author_login":"matejkriz","author_association":"MEMBER","created_at":"2025-02-19T11:10:18+08:00","repo_name":"trezor/trezor-suite","issue_id":2801051938,"issue_number":16484,"issue_url":"https://github.com/trezor/trezor-suite/issues/16484","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2683266665","fragment_type":"issue_comment","sequence":3,"text":"**QA NOK**\nThere is a global \"Send\" button in portfolio tracker URL","author_login":"STew790","author_association":"CONTRIBUTOR","created_at":"2025-02-25T20:52:47+08:00","repo_name":"trezor/trezor-suite","issue_id":2801051938,"issue_number":16484,"issue_url":"https://github.com/trezor/trezor-suite/issues/16484","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2711461300","fragment_type":"issue_comment","sequence":4,"text":"**QA OK**\nIssue was addressed, Global send works for all coins correctly. It is available only after discovery is finished.\n\n**Info**\n25.3.1 URL","author_login":"STew790","author_association":"CONTRIBUTOR","created_at":"2025-03-10T18:23:49+08:00","repo_name":"trezor/trezor-suite","issue_id":2801051938,"issue_number":16484,"issue_url":"https://github.com/trezor/trezor-suite/issues/16484","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0063","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"None or multiple MFA types potentially break login flow?","query_context":"This needs investigation to replicate, but there is a possiblity that if:\n\nA user has no MFA setup on their amazon account, they will be prompted to set it up after a successful login. Which breaks the flow.\n\nA user has multiple forms of MFA setup on their amazon account, they might be presented with a different version of the MFA form. Which breaks the login flow.","known_context_document_ids":["gh_issue_2769061212"],"reference_answer":"@mmstano when you say you cleared cookies and history - I meant the ones the server application (the add-on) stores, not your browsers. Perhaps a misunderstanding there because I said cookies, because that's what I called one of the files it generates haha. Probably a poor choice of words on my part.\n\nI'm not sure if Home Assistant will remove an add-ons persisted data when the add-on is removed tbf. But worth checking just incase. It might keep the data around so it's all still there should you decide to activate the add-on again.\n\nBut yea, the server add-on tells HA to store some files it needs for future reference. One of them is a config.json file and the other is a cookies.json file. The former stores server settings, the latter stores your authenticated browser session with amazon.\n\nProbably a red herring, but something to check out in the mean time until I get chance to try and replicate this.\n\nThose errors look chromium related, and not our errors, just output logs from chromium itself. That \"not authenticated\" error is likely referring to something else.\n\nI will try and replicate later, but I don't have windows I'm afraid 😅 .\n\nIf I really can't replicate it, the nuclear option would be to get together on discord or something and do a screenshare, fiddle with some code and see if we can discover what the hell is going on.","answer_document_id":"gh_comment_2587420635","silver_evidence_path":["gh_comment_2585955674","gh_issue_2769203934","gh_comment_2587420635"],"evidence_issue_ids":[2769061212,2769203934],"source_repo_name":"madmachinations/home-assistant-alexa-shopping-list","source_issue_id":2769061212,"source_issue_number":37,"source_issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/37","target_repo_name":"madmachinations/home-assistant-alexa-shopping-list","target_issue_id":2769203934,"target_issue_number":39,"target_issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/39","reference_anchor_document_id":"gh_comment_2585955674","reference_answer_author":"madmachinations","reference_answer_author_association":"OWNER","quality_score":82.86,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0357,"anchor_target_overlap":0.2667,"target_answer_overlap":0.1625},"issue_created_at":"2025-01-05T00:55:20+08:00","valid_comment_count":20,"fragments":[{"document_id":"gh_issue_2769061212","fragment_type":"issue_description","sequence":0,"text":"None or multiple MFA types potentially break login flow\nThis needs investigation to replicate, but there is a possiblity that if:\n\nA user has no MFA setup on their amazon account, they will be prompted to set it up after a successful login. Which breaks the flow.\n\nA user has multiple forms of MFA setup on their amazon account, they might be presented with a different version of the MFA form. Which breaks the login flow.","author_login":"madmachinations","author_association":"OWNER","created_at":"2025-01-05T00:55:20+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769061212,"issue_number":37,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/37","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2571479479","fragment_type":"issue_comment","sequence":1,"text":"I don't know if this is really my issue, just sharing the error I'm getting from trying to use the Home Assistant Add-On for the server. **I use an authenticator app for my MFA**. I completely started from scratch. I can connect to the US server and put in the username and password, but it won't prompt me for the MFA code, as that is where this error happens. I've signed out of Amazon.com on all of my devices and cleared my browser history/cache before attempting, as well. I was hoping to get this all setup without the need for running the server in docker desktop. \n\n`Traceback (most recent call last):\n File \"C:\\Users\\hajdu\\AppData\\Roaming\\Python\\Python311\\site-packages\\websockets\\legacy\\protocol.py\", line 1289, in close_connection\n await self.transfer_data_task\n File \"C:\\Users\\hajdu\\AppData\\Roaming\\Python\\Python311\\site-packages\\websockets\\legacy\\protocol.py\", line 955, in transfer_data\n message = await self.read_message()\n ^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"C:\\Users\\hajdu\\AppData\\Roaming\\Python\\Python311\\site-packages\\websockets\\legacy\\protocol.py\", line 1025, in read_message\n frame = await self.read_data_frame(max_size=self.max_size)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"C:\\Users\\hajdu\\AppData\\Roaming\\Python\\Python311\\site-packages\\websockets\\legacy\\protocol.py\", line 1100, in read_data_frame\n frame = await self.read_frame(max_size)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"C:\\Users\\hajdu\\AppData\\Roaming\\Python\\Python311\\site-packages\\websockets\\legacy\\protocol.py\", line 1157, in read_frame\n frame = await Frame.read(\n ^^^^^^^^^^^^^^^^^\n File \"C:\\Users\\hajdu\\AppData\\Roaming\\Python\\Python311\\site-packages\\websockets\\legacy\\framing.py\", line 68, in read\n data = await reader(2)\n ^^^^^^^^^^^^^^^\n File \"C:\\Users\\hajdu\\AppData\\Local\\Programs\\Python\\Python311\\Lib\\asyncio\\streams.py\", line 733, in readexactly\n await self._wait_for_data('readexactly')\n File \"C:\\Users\\hajdu\\AppData\\Local\\Programs\\Python\\Python311\\Lib\\asyncio\\streams.py\", line 526, in _wait_for_data\n await self._waiter\nasyncio.exceptions.CancelledError\n\nThe above exception was the direct cause of the following exception:\n\nTraceback (most recent call last):\n File \"D:\\Downloads\\HomeAssistant\\home-assistant-alexa-shopping-list-main\\client\\client.py\", line 288, in \n asyncio.run(client.run_console())\n File \"C:\\Users\\hajdu\\AppData\\Local\\Programs\\Python\\Python311\\Lib\\asyncio\\runners.py\", line 190, in run\n return runner.run(main)\n ^^^^^^^^^^^^^^^^\n File \"C:\\Users\\hajdu\\AppData\\Local\\Programs\\Python\\Python311\\Lib\\asyncio\\runners.py\", line 118, in run\n return self._loop.run_until_complete(task)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"C:\\Users\\hajdu\\AppData\\Local\\Programs\\Python\\Python311\\Lib\\asyncio\\base_events.py\", line 653, in run_until_complete\n return future.result()\n ^^^^^^^^^^^^^^^\n File \"D:\\Downloads\\HomeAssistant\\home-assistant-alexa-shopping-list-main\\client\\client.py\", line 259, in run_console\n await self._check_server()\n File \"D:\\Downloads\\HomeAssistant\\home-assistant-alexa-shopping-list-main\\client\\client.py\", line 84, in _check_server\n await self._setup_server_authentication()\n File \"D:\\Downloads\\HomeAssistant\\home-assistant-alexa-shopping-list-main\\client\\client.py\", line 131, in _setup_server_authentication\n response = await self._send_command(\"login\", email=email, password=password)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"D:\\Downloads\\HomeAssistant\\home-assistant-alexa-shopping-list-main\\client\\client.py\", line 39, in _send_command\n response = await websocket.recv()\n ^^^^^^^^^^^^^^^^^^^^^^\n File \"C:\\Users\\hajdu\\AppData\\Roaming\\Python\\Python311\\site-packages\\websockets\\legacy\\protocol.py\", line 564, in recv\n await self.ensure_open()\n File \"C:\\Users\\hajdu\\AppData\\Roaming\\Python\\Python311\\site-packages\\websockets\\legacy\\protocol.py\", line 940, in ensure_open\n raise self.connection_closed_exc()\nwebsockets.exceptions.ConnectionClosedError: sent 1011 (internal error) keepalive ping timeout; no close frame received`","author_login":"mmstano","author_association":"NONE","created_at":"2025-01-05T02:48:48+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769061212,"issue_number":37,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2571481173","fragment_type":"issue_comment","sequence":2,"text":"I would have preferred doing this using Linux Terminal, but my Linux laptop died on me (it was a dinosaur). I have wsl on this Windows PC, but the websocket in the requirements.txt won't install with the pip3 command because wsl in Windows in limited to websocket version 9.","author_login":"mmstano","author_association":"NONE","created_at":"2025-01-05T02:59:45+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769061212,"issue_number":37,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2571516298","fragment_type":"issue_comment","sequence":3,"text":"@mmstano I am getting the same error with the client on macOS. I'm running the server as an add-on in HA, which is running in a proxmox linux VM. The error happens shortly after I enter username and password.\n\nI already have MFA set up on my amazon account.","author_login":"nathan815","author_association":"NONE","created_at":"2025-01-05T06:12:53+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769061212,"issue_number":37,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2585955674","fragment_type":"issue_comment","sequence":4,"text":"This fix should now be deployed in the latest version which uses the new authenticator to get everything logged in.\n\nPlease clear out your existing installation, delete all containers and old client versions. And go through the documentation on the wiki for installing the new version:\n\n URL \n\nI will close this issue, if you have problems with the authenticator please post about them in #39","author_login":"madmachinations","author_association":"OWNER","created_at":"2025-01-12T23:06:18+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769061212,"issue_number":37,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/37","linked_issue_ids":[2769203934],"is_known_query_context":false},{"document_id":"gh_issue_2769203934","fragment_type":"issue_description","sequence":0,"text":"Create authenticator selenium app\nOkay so I believe the best way to solve all new and future problems with regards to getting everything setup, is to change the way the server gets authenticated.\n\nThe plan is to add a new applet called the authenticator. So there will be the server, the client, the component and the authenticator.\n\nLike the client, the authenticator runs on your laptop/desktop whatever.\n\nBut instead it will use selenium to create an instance of the chromium browser matching the version used by the server.\n\nThe user will be prompted to login to amazon, and perform whatever steps are necessary to authenticate.\n\nThey then return to the terminal and press enter to continue.\n\nAt which point all the files which make up the user's session are extracted from the browser and sent to the server for it to store and use when it needs to use the amazon website.\n\nThis approach would mean everyone can see what they're doing, they can jump through whatever weird hoops are required for their particular instance. All we're really interested in is the valid session details anyway","author_login":"madmachinations","author_association":"OWNER","created_at":"2025-01-05T10:12:41+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769203934,"issue_number":39,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/39","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2585957938","fragment_type":"issue_comment","sequence":1,"text":"This should now be deployed in the latest version which uses the new authenticator to get everything logged in.\n\nPlease clear out your existing installation, delete all containers and old client versions. And go through the documentation on the wiki for installing the new version:\n\n URL \n\nI will close this issue, if you have problems with the authenticator please post about them in URL","author_login":"madmachinations","author_association":"OWNER","created_at":"2025-01-12T23:13:14+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769203934,"issue_number":39,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/39","linked_issue_ids":[2769203934],"is_known_query_context":false},{"document_id":"gh_comment_2587339065","fragment_type":"issue_comment","sequence":2,"text":"I have the same issue. \ni'm loggin in with user and pass and an otp code. \nThe errors on the terminal starts when opened chromium.","author_login":"guizard-hub","author_association":"NONE","created_at":"2025-01-13T15:00:02+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769203934,"issue_number":39,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/39","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2587391856","fragment_type":"issue_comment","sequence":3,"text":"Yessir, I have attempted twice now with the same error. I've completely started from scratch both times which involved - \n\n1. uninstalling custom component AND add-on, then restarting Home Assistant\n2. deleting history/cookies from Chrome, Chromium, and Edge browsers\n3. deleting python data from client in my AppData folder\n4. restart my computer\n\nI use an authenticator app for MFA (bitwarden), Windows 10 PC\n\nThe errors happen right when Chromium opens and asks if I successfully logged into Amazon as shown below - \n\nAre you logged in to your Amazon account? (y/N): [7680:11932:0113/100043.511:ERROR:gles2_cmd_decoder_passthrough.cc(1082)] [GroupMarkerNotSet(crbug.com/242999)!:A0602A0094170000]Automatic fallback to software WebGL has been deprecated. Please use the --enable-unsafe-swiftshader flag to opt in to lower security guarantees for trusted content.\n[11572:8808:0113/100044.552:ERROR:registration_request.cc(291)] Registration response error message: DEPRECATED_ENDPOINT\n[11572:8808:0113/100044.654:ERROR:mcs_client.cc(700)] Error code: 401 Error message: Authentication Failed: wrong_secret\n[11572:8808:0113/100044.654:ERROR:mcs_client.cc(702)] Failed to log in to GCM, resetting connection.\n[11572:3304:0113/100045.093:ERROR:fm_registration_token_uploader.cc(186)] Client is missing for kUser scope\n[11572:3304:0113/100045.221:ERROR:fm_registration_token_uploader.cc(186)] Client is missing for kUser scope\n[7680:11932:0113/100055.434:ERROR:gles2_cmd_decoder_passthrough.cc(1082)] [GroupMarkerNotSet(crbug.com/242999)!:A0902A0094170000]Automatic fallback to software WebGL has been deprecated. Please use the --enable-unsafe-swiftshader flag to opt in to lower security guarantees for trusted content.\n[7680:11932:0113/100103.093:ERROR:gles2_cmd_decoder_passthrough.cc(1082)] [GroupMarkerNotSet(crbug.com/242999)!:A0902A0094170000]Automatic fallback to software WebGL has been deprecated. Please use the --enable-unsafe-swiftshader flag to opt in to lower security guarantees for trusted content.\n[11572:8808:0113/100111.521:ERROR:registration_request.cc(291)] Registration response error message: DEPRECATED_ENDPOINT\n[7680:11932:0113/100123.299:ERROR:gles2_cmd_decoder_passthrough.cc(1082)] [GroupMarkerNotSet(crbug.com/242999)!:A0602A0094170000]Automatic fallback to software WebGL has been deprecated. Please use the --enable-unsafe-swiftshader flag to opt in to lower security guarantees for trusted content.\n[7680:11932:0113/100157.326:ERROR:gles2_cmd_decoder_passthrough.cc(1082)] [GroupMarkerNotSet(crbug.com/242999)!:A0602A0094170000]Automatic fallback to software WebGL has been deprecated. Please use the --enable-unsafe-swiftshader flag to opt in to lower security guarantees for trusted content.\n[11572:8808:0113/100159.619:ERROR:registration_request.cc(291)] Registration response error message: DEPRECATED_ENDPOINT\n[7680:11932:0113/100201.473:ERROR:gles2_cmd_decoder_passthrough.cc(1082)] [GroupMarkerNotSet(crbug.com/242999)!:A0902A0094170000]Automatic fallback to software WebGL has been deprecated. Please use the --enable-unsafe-swiftshader flag to opt in to lower security guarantees for trusted content.","author_login":"mmstano","author_association":"NONE","created_at":"2025-01-13T15:16:47+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769203934,"issue_number":39,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/39","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2587420635","fragment_type":"issue_comment","sequence":4,"text":"@mmstano when you say you cleared cookies and history - I meant the ones the server application (the add-on) stores, not your browsers. Perhaps a misunderstanding there because I said cookies, because that's what I called one of the files it generates haha. Probably a poor choice of words on my part.\n\nI'm not sure if Home Assistant will remove an add-ons persisted data when the add-on is removed tbf. But worth checking just incase. It might keep the data around so it's all still there should you decide to activate the add-on again.\n\nBut yea, the server add-on tells HA to store some files it needs for future reference. One of them is a config.json file and the other is a cookies.json file. The former stores server settings, the latter stores your authenticated browser session with amazon.\n\nProbably a red herring, but something to check out in the mean time until I get chance to try and replicate this.\n\nThose errors look chromium related, and not our errors, just output logs from chromium itself. That \"not authenticated\" error is likely referring to something else.\n\nI will try and replicate later, but I don't have windows I'm afraid 😅 .\n\nIf I really can't replicate it, the nuclear option would be to get together on discord or something and do a screenshare, fiddle with some code and see if we can discover what the hell is going on.","author_login":"madmachinations","author_association":"OWNER","created_at":"2025-01-13T15:24:41+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769203934,"issue_number":39,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/39","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2587463171","fragment_type":"issue_comment","sequence":5,"text":"I'll triple check, but I've checked my Home Assistant addon_configs folder and the .storage folder for any residual data that may be leftovers from previous sessions and I didn't see anything.","author_login":"mmstano","author_association":"NONE","created_at":"2025-01-13T15:39:40+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769203934,"issue_number":39,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/39","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2587466803","fragment_type":"issue_comment","sequence":6,"text":"@mmstano sweet, I assume it would be lurking somewhere around there. You'd know better than I would, I don't have HA OS to test either haha 🤣","author_login":"madmachinations","author_association":"OWNER","created_at":"2025-01-13T15:41:01+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769203934,"issue_number":39,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/39","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2587479867","fragment_type":"issue_comment","sequence":7,"text":"Hmmmm, could be something windows specific perhaps.\n\n@guizard-hub @mmstano no pressure or expectation, but if you have the ability in the mean time - you could try running the client on the WSL or a Linux VM instead of on windows directly, and see if it still pisses on your chips.","author_login":"madmachinations","author_association":"OWNER","created_at":"2025-01-13T15:45:11+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769203934,"issue_number":39,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/39","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2587493227","fragment_type":"issue_comment","sequence":8,"text":"I've got some things to do, but I'll try using WSL later tonight. The last time I tried WSL, the websocket uses an older version than what is required for client.py, but I'll run apt-get update and we shall see if that changed.","author_login":"mmstano","author_association":"NONE","created_at":"2025-01-13T15:49:53+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769203934,"issue_number":39,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/39","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2587493704","fragment_type":"issue_comment","sequence":9,"text":"Throwing in my data point. Windows 11. HAOS add on. Amazon.com (US). Was able to successfully list out my Alexa shopping list in the client.","author_login":"saberstop","author_association":"NONE","created_at":"2025-01-13T15:50:05+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769203934,"issue_number":39,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/39","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2587505714","fragment_type":"issue_comment","sequence":10,"text":"Ahhhhh amazing! Thanks @saberstop that's much appreciated. Glad it's working for someone in the US haha!","author_login":"madmachinations","author_association":"OWNER","created_at":"2025-01-13T15:54:43+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769203934,"issue_number":39,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/39","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2588054403","fragment_type":"issue_comment","sequence":11,"text":"Can confirm the problem is something related to Win11. \nWith osx completed the process to server config.\nNow I have some problem with the custom components. But the server successfully retrieved the list","author_login":"guizard-hub","author_association":"NONE","created_at":"2025-01-13T19:48:36+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769203934,"issue_number":39,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/39","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2588131330","fragment_type":"issue_comment","sequence":12,"text":"Nice! Thank you @guizard-hub , that's really handy to know. If you get stuck with the custom component then feel free to give me a shout in another issue","author_login":"madmachinations","author_association":"OWNER","created_at":"2025-01-13T20:29:36+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769203934,"issue_number":39,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/39","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2595850804","fragment_type":"issue_comment","sequence":13,"text":"Just another data point, HAOS on an old mac mini - all fine in terms of authentication and sync (list returned in client) using a MacBook Pro for the client. Only issue is getting it show in the list on the dashboard.","author_login":"nickiles","author_association":"NONE","created_at":"2025-01-16T14:17:57+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769203934,"issue_number":39,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/39","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2596667324","fragment_type":"issue_comment","sequence":14,"text":"Awesome thanks @nickiles , if you have the custom component installed it should be able to connect to the same address as the client does.","author_login":"madmachinations","author_association":"OWNER","created_at":"2025-01-16T19:29:24+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769203934,"issue_number":39,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/39","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2596870968","fragment_type":"issue_comment","sequence":15,"text":"Custom component issue resolved- had missed the need to add the HA Shopping List first. Resolution was to delete the hub and then recreate it. \n\nBrilliant to have it working at last- coffee on its way!","author_login":"nickiles","author_association":"NONE","created_at":"2025-01-16T20:55:20+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769203934,"issue_number":39,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/39","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2612153918","fragment_type":"issue_comment","sequence":16,"text":"Thanks I'll see if I can add a step for Linux where it changes those file perms.\n\nDid you have to flag anything as executable also? Or just marking them as 755?","author_login":"madmachinations","author_association":"OWNER","created_at":"2025-01-24T10:12:20+08:00","repo_name":"madmachinations/home-assistant-alexa-shopping-list","issue_id":2769203934,"issue_number":39,"issue_url":"https://github.com/madmachinations/home-assistant-alexa-shopping-list/issues/39","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0066","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Canonical URL not added with default configuration?","query_context":"With a new install of the Metatag 1.22.5 and default settings...\n\nUnder \"Advanced Tags\" for \"Global\" and \"Content\", the following token is set for \"Canonical URL\":\n\n`[current-page:url:absolute]`\n\nSince a token is is provided for the canonical url field by default, I would expect to see\n\n` `\n\nIn the head of all pages. However, no rel canonical tag is inserted.\n\nNote that if \"Always output canonical, shortlink, and generator meta tags\" is enabled in Metatag master settings, a canonical tag _is_ inserted.\n\nReproducible with Backdrop 1.24.1 and Metatag 1.22.5.\n\nPerhaps I am misunderstanding expected behavior?","known_context_document_ids":["gh_issue_1631050458"],"reference_answer":"I checked metatag's handling of `#attached` and it looks like it already works correctly. There was a separate issue with Canonical not working #109, but with that issue fixed I have confirmed that the HTTP `Link` header already works properly. The `X-Generator` header is another example of a metatag that exists both in HTML and in the HTTP header. I added test coverage for both in a PR at URL \n\nSo in summary to fix this issue, I think we need to do both of these things:\n\n1. Merge URL to make `schema_metatag` act like other metatags.\n2. Merge URL which includes @dgbruns's fix and test coverage.","answer_document_id":"gh_comment_1773517917","silver_evidence_path":["gh_comment_1749924386","gh_issue_1929309320","gh_comment_1773517917"],"evidence_issue_ids":[1631050458,1929309320],"source_repo_name":"backdrop-contrib/metatag","source_issue_id":1631050458,"source_issue_number":109,"source_issue_url":"https://github.com/backdrop-contrib/metatag/issues/109","target_repo_name":"backdrop-contrib/metatag","target_issue_id":1929309320,"target_issue_number":110,"target_issue_url":"https://github.com/backdrop-contrib/metatag/issues/110","reference_anchor_document_id":"gh_comment_1749924386","reference_answer_author":"quicksketch","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3077,"anchor_target_overlap":0.5385,"target_answer_overlap":0.3182},"issue_created_at":"2023-03-19T17:54:24+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_1631050458","fragment_type":"issue_description","sequence":0,"text":"Canonical URL not added with default configuration\nWith a new install of the Metatag 1.22.5 and default settings...\n\nUnder \"Advanced Tags\" for \"Global\" and \"Content\", the following token is set for \"Canonical URL\":\n\n`[current-page:url:absolute]`\n\nSince a token is is provided for the canonical url field by default, I would expect to see\n\n` `\n\nIn the head of all pages. However, no rel canonical tag is inserted.\n\nNote that if \"Always output canonical, shortlink, and generator meta tags\" is enabled in Metatag master settings, a canonical tag _is_ inserted.\n\nReproducible with Backdrop 1.24.1 and Metatag 1.22.5.\n\nPerhaps I am misunderstanding expected behavior?","author_login":"dgbruns","author_association":"NONE","created_at":"2023-03-19T17:54:24+08:00","repo_name":"backdrop-contrib/metatag","issue_id":1631050458,"issue_number":109,"issue_url":"https://github.com/backdrop-contrib/metatag/issues/109","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1749871948","fragment_type":"issue_comment","sequence":1,"text":"I have seen this same problem, BUT, the problem is not exactly that the canonical URL is not added to the `head`. Actually is NOT supposed to be added to the head, but rather to the **response headers** of the page. \n\nThe Canonical URL metatag uses the `#attached` method `backdrop_add_http_header` (notice this is NOT `backdrop_add_html_head`). \n\nStill, this is a problem. If you inspect the Response Header with the browser dev tools you'll see that the canonical URL is not included:\n\n<img width=\"1344\" alt=\"Screen Shot 2023-10-05 at 7 33 06 PM\" src=\" URL \n \nThe main issue is the way Backdrop's metatag module processes the metatag info. Unlike the D7 version, Backdrop's version bypasses the normal way of adding tags to the head (or in this case, adding info to the header) by hard-coding `backdrop_add_html_head()` in `metatag_preprocess_page()`.\n\nThis is not right. But rather than making tons of changes, there is a way to avoid this problem. I'll will submit this in a separate issue.","author_login":"argiepiano","author_association":"NONE","created_at":"2023-10-06T01:38:58+08:00","repo_name":"backdrop-contrib/metatag","issue_id":1631050458,"issue_number":109,"issue_url":"https://github.com/backdrop-contrib/metatag/issues/109","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1749924386","fragment_type":"issue_comment","sequence":2,"text":"I have provided an issue and PR that fixes this. After patching, the header \"link\" with the canonical URL is sent to the browser. See #110 and #111","author_login":"argiepiano","author_association":"NONE","created_at":"2023-10-06T03:09:47+08:00","repo_name":"backdrop-contrib/metatag","issue_id":1631050458,"issue_number":109,"issue_url":"https://github.com/backdrop-contrib/metatag/issues/109","linked_issue_ids":[1929309320],"is_known_query_context":false},{"document_id":"gh_comment_1773085437","fragment_type":"issue_comment","sequence":3,"text":"Although this can be done with the HTTP `Link` header (per Google documentation), I don't think that's the intention of the current code, which intends to an HTML element.\n\nIt looks to me like the problem here is a mismatch between `metatag_html_head_alter()` (where the canonical tag is removed) and `metatag_preprocess_page()` (where metatag adds its own tags). The current code is striping out both the canonical tag added by core, and the canonical tag added by metatag, resulting in no canonical tag at all. If the \"Always output canonical, shortlink, and generator meta tags\" option is disabled, you actually end up with _two_ canonical tags right now.\n\nIn `metatag_html_head_alter()` we have this code:\n\n // Do not remove meta tags provided by Metatag.\n if (strpos($key, 'metatag_') === 0) {\n continue;\n }\n\nBut in `metatag_preprocess_page()` no keys are prefixed with `metatag_`. I'll file a PR to fix this specific issue.","author_login":"quicksketch","author_association":"MEMBER","created_at":"2023-10-20T17:00:20+08:00","repo_name":"backdrop-contrib/metatag","issue_id":1631050458,"issue_number":109,"issue_url":"https://github.com/backdrop-contrib/metatag/issues/109","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1773099786","fragment_type":"issue_comment","sequence":4,"text":"Fixed in URL I'm going to follow-up with test coverage in URL","author_login":"quicksketch","author_association":"MEMBER","created_at":"2023-10-20T17:10:30+08:00","repo_name":"backdrop-contrib/metatag","issue_id":1631050458,"issue_number":109,"issue_url":"https://github.com/backdrop-contrib/metatag/issues/109","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1929309320","fragment_type":"issue_description","sequence":0,"text":"Process '#attached' key in metatag data before adding tags to the head\nBackdrop's version of metatag is different from D7's version in one important way: B's version **directly** adds the head tags in `metatag_preprocess_page()`. This creates serious problems for metatag data that make use of the `#attached` key.\n\nOne example of that is the data provided by \"Canonical URL\" metatag in class `BackdropLinkMetaTag`. The data returned by `getElement` in this class looks a bit like this:\n\nphp\n$element['#attached'] = array(\n 'backdrop_add_http_header' => array(\n 0 => array(\n 'Link', \n ' ;' . backdrop_http_header_attributes(array('rel' => $element['#attributes']['rel'])), \n TRUE\n ),\n )\n);\n\nThis data fails to have any effect when it's run without any preprocessing through `backdrop_add_html_head($data, $tag);` in `metatag_preprocess_page()`. The result of doing it this way (i.e. ADDING the data to the head BEFORE running the `#attached` function) is that, in this case, the Canonical URL `Link` header is never sent to the browser, as reported in #109.\n\nThere are TONS of other metatags, provided by a module I'm porting called `schema_metatag`, that make use of the `[#attached]` key. Because of the current approach taken by Backdrop (i.e. using a \"shortcut\" and adding the tags directly in `metatag_preprocess_page()`, instead of doing it the way D7 does it), those tags fail to be added, and in fact crash the rest of the tags added later, because they result in malformed ` ` tags being added.\n\nThere is a solution that avoids completely rewriting `metatag_preprocess_page()`. The solution is to check if the metatag data contains `[#attached]` as the top-most element. If it does, instead of directly adding the \"raw\" data, you call `backdrop_render()` for that data. Backdrop is smart enough to call the attached function with the arguments provided in the data, AND adds the tag to the head without the need of manually using `backdrop_add_html_head()`.\n\nThis solution solves not only the Canonical URL problem, but also all the `schema_metatag` malfunctioning tags.\n\nI'll provide the PR later tonight. It's a one-liner.","author_login":"argiepiano","author_association":"CONTRIBUTOR","created_at":"2023-10-06T01:50:32+08:00","repo_name":"backdrop-contrib/metatag","issue_id":1929309320,"issue_number":110,"issue_url":"https://github.com/backdrop-contrib/metatag/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1749923632","fragment_type":"issue_comment","sequence":1,"text":"PR ready for review. This is a site that uses Canonical URL metatag. Unlike other basic metatags, Canonical URL is supposed to be sent to the browser in the headers. Before the patch, inspecting the headers, Link is not included:\n\n<img width=\"1344\" alt=\"Screen Shot 2023-10-05 at 7 33 06 PM\" src=\" URL \n\nAfter the patch:\n\n<img width=\"1407\" alt=\"Screen Shot 2023-10-05 at 9 07 19 PM\" src=\" URL \n\nI've tested the patch with some of the tags provided by `schema_metatag`, and they work as expected.","author_login":"argiepiano","author_association":"NONE","created_at":"2023-10-06T03:08:27+08:00","repo_name":"backdrop-contrib/metatag","issue_id":1929309320,"issue_number":110,"issue_url":"https://github.com/backdrop-contrib/metatag/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1763423445","fragment_type":"issue_comment","sequence":2,"text":"I've been testing a patched version of Metatag (#110) with Metatag schema, with the 'article' schema type.\n\nIn general, it's working well and I see schema tags in json-ld format appear in the of pages configured to use the article schema type. However, while testing yesterday, I ran into a new error:\n\n`Warning: strtolower() expects parameter 1 to be string, array given in strtolower() (line 2237 of /var/www/html/web/modules/contrib/metatag/metatag.module). `\n\nThis happens because the $attr_value delivered to strtolower can be an array for things like the 'organization' and 'ImageObject' that are part of the 'article' spec. I'm not sure why I didn't see this before, but I noticed after clearing caches, the error doesn't always appear right away. If I hack the code to check for a string:\n\n if (is_string($attr_value)) {\n $attr_value = strtolower($attr_value); // Account for G in generator.\n }\n\nThe error goes away.\n\nLet me know if you need more details or if I should open a separate issue.","author_login":"dgbruns","author_association":"NONE","created_at":"2023-10-15T15:25:04+08:00","repo_name":"backdrop-contrib/metatag","issue_id":1929309320,"issue_number":110,"issue_url":"https://github.com/backdrop-contrib/metatag/issues/110","linked_issue_ids":[1929309320],"is_known_query_context":false},{"document_id":"gh_comment_1766880004","fragment_type":"issue_comment","sequence":3,"text":"@argiepiano Thanks for the PR! I'll be taking a look at this shortly. Can either you or @dgbruns provide some steps to reproduce the problem?","author_login":"quicksketch","author_association":"MEMBER","created_at":"2023-10-17T17:42:24+08:00","repo_name":"backdrop-contrib/metatag","issue_id":1929309320,"issue_number":110,"issue_url":"https://github.com/backdrop-contrib/metatag/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1767072736","fragment_type":"issue_comment","sequence":4,"text":"@quicksketch - just sent over some info and json config. The gist is that I am testing the 'Article' type only at the 'Content' level in Metag with the patched version of Metatag that uses backdrop_render.\n\nIt seems that the error above happens when pieces of the json-ld array (the sub-arrays for persons and organizations) hit strtolower.","author_login":"dgbruns","author_association":"NONE","created_at":"2023-10-17T19:55:48+08:00","repo_name":"backdrop-contrib/metatag","issue_id":1929309320,"issue_number":110,"issue_url":"https://github.com/backdrop-contrib/metatag/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1772034196","fragment_type":"issue_comment","sequence":5,"text":"Thanks @argiepiano and @dgbruns. I've reproduced the problem with the `schema_metatag` module.\n\n@dgbruns I think your little fix is also totally okay.\n\nI'd like to have automated test coverage for the variety of situations we're putting forward, but it seems like the Metatag module tests need some work. I'll put up a combined PR that includes URL plus @dgbruns's fix, and if possible, some test coverage.","author_login":"quicksketch","author_association":"MEMBER","created_at":"2023-10-20T03:49:46+08:00","repo_name":"backdrop-contrib/metatag","issue_id":1929309320,"issue_number":110,"issue_url":"https://github.com/backdrop-contrib/metatag/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1773471502","fragment_type":"issue_comment","sequence":6,"text":"@argiepiano I see your point about needing to support `#attached` in `BackdropLinkMetaTag` and possibly other places to add HTTP headers, but I'm also looking at `schema_metatag` and it looks as though the pull request here is not required for that module to function properly? I filed a PR at URL that makes `schema_metatag` return the element directly, without using `#attached` at all. And while I think it's still important we figure this out for other tags, I think `schema_metatag` might be better off if it uses the simplified syntax.","author_login":"quicksketch","author_association":"MEMBER","created_at":"2023-10-20T22:32:36+08:00","repo_name":"backdrop-contrib/metatag","issue_id":1929309320,"issue_number":110,"issue_url":"https://github.com/backdrop-contrib/metatag/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1773517917","fragment_type":"issue_comment","sequence":7,"text":"I checked metatag's handling of `#attached` and it looks like it already works correctly. There was a separate issue with Canonical not working #109, but with that issue fixed I have confirmed that the HTTP `Link` header already works properly. The `X-Generator` header is another example of a metatag that exists both in HTML and in the HTTP header. I added test coverage for both in a PR at URL \n\nSo in summary to fix this issue, I think we need to do both of these things:\n\n1. Merge URL to make `schema_metatag` act like other metatags.\n2. Merge URL which includes @dgbruns's fix and test coverage.","author_login":"quicksketch","author_association":"MEMBER","created_at":"2023-10-20T23:24:43+08:00","repo_name":"backdrop-contrib/metatag","issue_id":1929309320,"issue_number":110,"issue_url":"https://github.com/backdrop-contrib/metatag/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1774175467","fragment_type":"issue_comment","sequence":8,"text":"Perfect, and I see you merged URL I've merged URL as well and I'll make a new release shortly.","author_login":"quicksketch","author_association":"MEMBER","created_at":"2023-10-22T19:13:03+08:00","repo_name":"backdrop-contrib/metatag","issue_id":1929309320,"issue_number":110,"issue_url":"https://github.com/backdrop-contrib/metatag/issues/110","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0068","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"SchemaOf returns undefined-able type for a required array?","query_context":"I need to verify that my schema match array of strings, so I use [`yup.SchemaOf `]( URL but when I try to validate using this schema or InferType from it, it returns me `string[] | undefined`. I can't understand where this `undefined` comes from:\n\njs\nconst schema: yup.SchemaOf = yup.array().of(yup.string().required()).required();\ntype MyType = yup.InferType ;\n\nExpected result: `type MyType = string[]`\nActual result: `type MyType = string[] | undefined`\n\nI provided this simplified example, but this happens not only with array of strings, but with any arrays, including arrays in object attributes.\n\nNote: if I don't use SchemaOf annotation, it works as expected:\n\njs\nconst schema = yup.array().of(yup.string().required()).required();\ntype MyType = yup.InferType ; // type MyType = string[]\n\n(but that way I can't guarantee that validation schema produce objects that match types defined in my application)\n\nYup version: 0.32.11\nNodeJS version: 16.15.0\nTypeScript version: 4.6.4\n\nIt became pretty annoying so I appreciate any feedback. Thank you!","known_context_document_ids":["gh_issue_1486753151"],"reference_answer":"Yes, strict nulls is a required typescript setting for types to work, as mentioned in the docs","answer_document_id":"gh_comment_1704320561","silver_evidence_path":["gh_comment_1419298740","gh_issue_916934899","gh_comment_1704320561"],"evidence_issue_ids":[1486753151,916934899],"source_repo_name":"jquense/yup","source_issue_id":1486753151,"source_issue_number":1853,"source_issue_url":"https://github.com/jquense/yup/issues/1853","target_repo_name":"jquense/yup","target_issue_id":916934899,"target_issue_number":1389,"target_issue_url":"https://github.com/jquense/yup/issues/1389","reference_anchor_document_id":"gh_comment_1419298740","reference_answer_author":"jquense","reference_answer_author_association":"OWNER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.3846,"anchor_target_overlap":0.1538,"target_answer_overlap":0.2222},"issue_created_at":"2022-12-09T13:20:38+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_1486753151","fragment_type":"issue_description","sequence":0,"text":"SchemaOf returns undefined-able type for a required array\nI need to verify that my schema match array of strings, so I use [`yup.SchemaOf `]( URL but when I try to validate using this schema or InferType from it, it returns me `string[] | undefined`. I can't understand where this `undefined` comes from:\n\njs\nconst schema: yup.SchemaOf = yup.array().of(yup.string().required()).required();\ntype MyType = yup.InferType ;\n\nExpected result: `type MyType = string[]`\nActual result: `type MyType = string[] | undefined`\n\nI provided this simplified example, but this happens not only with array of strings, but with any arrays, including arrays in object attributes.\n\nNote: if I don't use SchemaOf annotation, it works as expected:\n\njs\nconst schema = yup.array().of(yup.string().required()).required();\ntype MyType = yup.InferType ; // type MyType = string[]\n\n(but that way I can't guarantee that validation schema produce objects that match types defined in my application)\n\nYup version: 0.32.11\nNodeJS version: 16.15.0\nTypeScript version: 4.6.4\n\nIt became pretty annoying so I appreciate any feedback. Thank you!","author_login":"fomin-alexander","author_association":"NONE","created_at":"2022-12-09T13:20:38+08:00","repo_name":"jquense/yup","issue_id":1486753151,"issue_number":1853,"issue_url":"https://github.com/jquense/yup/issues/1853","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1419298740","fragment_type":"issue_comment","sequence":1,"text":"This is also here: URL \n\nI'm not sure why this isn't being fixed. Validating that arrays are defined seems like a pretty basic validation rule.","author_login":"nrutman","author_association":"NONE","created_at":"2023-02-06T15:46:34+08:00","repo_name":"jquense/yup","issue_id":1486753151,"issue_number":1853,"issue_url":"https://github.com/jquense/yup/issues/1853","linked_issue_ids":[916934899],"is_known_query_context":false},{"document_id":"gh_comment_1703357641","fragment_type":"issue_comment","sequence":2,"text":"this will still fail if strict is set to false in the tsconfig.json... example on the left is without strict mode enabled\nimage\n\nTook me a second to figure that out. You may end up introducing new TS errors when changing the config, though.\n\nalso posted here: #1389","author_login":"shelbyneal","author_association":"NONE","created_at":"2023-09-01T21:56:29+08:00","repo_name":"jquense/yup","issue_id":1486753151,"issue_number":1853,"issue_url":"https://github.com/jquense/yup/issues/1853","linked_issue_ids":[916934899],"is_known_query_context":false},{"document_id":"gh_issue_916934899","fragment_type":"issue_description","sequence":0,"text":"Validation of required/defaulted array results in array | undefined type\n**Describe the bug**\nWhen validating a required array or an array with a default value, the resulting type is `arraytype[] | undefined`, as if it wasn't required.\n\n**To Reproduce**\nExample to reproduce:\n\ntypescript\nimport * as yup from 'yup';\n\n// Define a required array of required numbers\nexport const schema: yup.SchemaOf = yup.array().of(yup.number().required()).required();\n\nasync function test() {\n // Type 'number[] | undefined' is not assignable to type 'number[]'.\n // Type 'undefined' is not assignable to type 'number[]'.\n const x: number[] = await schema.validate([]);\n}\n\nSame result when using `.default([])`.\n\n**Expected behavior**\nA required array should have type `arraytype[]` without undefined.\n\n**Platform (please complete the following information):**\n - Yup 0.32.9\n - Typescript 4.2.3","author_login":"plaa","author_association":"NONE","created_at":"2021-06-10T05:57:28+08:00","repo_name":"jquense/yup","issue_id":916934899,"issue_number":1389,"issue_url":"https://github.com/jquense/yup/issues/1389","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_861507901","fragment_type":"issue_comment","sequence":1,"text":"Hello, I tried to run it using : \n- Yup 0.32.8\n- Typescript 4.2.3\nAnd it worked, no `| undefined` added to the expected type.\n\nMinimal runnable example here : URL \n\nIt seems to have broken between the 0.32.8 and the 0.32.9, but I have no idea of the modification that could have caused this type bug.","author_login":"joxcat","author_association":"NONE","created_at":"2021-06-15T13:40:42+08:00","repo_name":"jquense/yup","issue_id":916934899,"issue_number":1389,"issue_url":"https://github.com/jquense/yup/issues/1389","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1069037829","fragment_type":"issue_comment","sequence":2,"text":"This one worked for my `string | undefined` problem:\n`members: yup.array().of(yup.string().required(errorMessage)).defined()`","author_login":"maciekdzialo","author_association":"NONE","created_at":"2022-03-16T11:44:43+08:00","repo_name":"jquense/yup","issue_id":916934899,"issue_number":1389,"issue_url":"https://github.com/jquense/yup/issues/1389","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1703081678","fragment_type":"issue_comment","sequence":3,"text":"this will still fail if strict is set to false in the tsconfig.json","author_login":"shelbyneal","author_association":"NONE","created_at":"2023-09-01T17:15:33+08:00","repo_name":"jquense/yup","issue_id":916934899,"issue_number":1389,"issue_url":"https://github.com/jquense/yup/issues/1389","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1704320561","fragment_type":"issue_comment","sequence":4,"text":"Yes, strict nulls is a required typescript setting for types to work, as mentioned in the docs","author_login":"jquense","author_association":"OWNER","created_at":"2023-09-03T14:28:38+08:00","repo_name":"jquense/yup","issue_id":916934899,"issue_number":1389,"issue_url":"https://github.com/jquense/yup/issues/1389","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0073","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"[google_maps_flutter] Google maps overlay?","query_context":"I would like to display an image in overlay at given lat-log positions on Google map using Flutter. I am using flutter package google_maps_flutter: ^2.2.1, at present the package does not provide to implement the feature .","known_context_document_ids":["gh_issue_1400904897"],"reference_answer":"@UDAYBIDKAR did some great work on this in URL but unfortunately isn't available to finish the work. If anyone would like to build on their great contribution and take it to the finish line, that would be great — there's just some review comments to address (see the PR for details).","answer_document_id":"gh_comment_1149260271","silver_evidence_path":["gh_comment_1272788855","gh_issue_398605825","gh_comment_1149260271"],"evidence_issue_ids":[1400904897,398605825],"source_repo_name":"flutter/flutter","source_issue_id":1400904897,"source_issue_number":113093,"source_issue_url":"https://github.com/flutter/flutter/issues/113093","target_repo_name":"flutter/flutter","target_issue_id":398605825,"target_issue_number":26479,"target_issue_url":"https://github.com/flutter/flutter/issues/26479","reference_anchor_document_id":"gh_comment_1272788855","reference_answer_author":"Hixie","reference_answer_author_association":"MEMBER","quality_score":79.76,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.2857,"target_answer_overlap":0.0952},"issue_created_at":"2022-10-07T09:43:24+08:00","valid_comment_count":17,"fragments":[{"document_id":"gh_issue_1400904897","fragment_type":"issue_description","sequence":0,"text":"[google_maps_flutter] Google maps overlay\nI would like to display an image in overlay at given lat-log positions on Google map using Flutter. I am using flutter package google_maps_flutter: ^2.2.1, at present the package does not provide to implement the feature .","author_login":"tuandq2711","author_association":"NONE","created_at":"2022-10-07T09:43:24+08:00","repo_name":"flutter/flutter","issue_id":1400904897,"issue_number":113093,"issue_url":"https://github.com/flutter/flutter/issues/113093","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1271544447","fragment_type":"issue_comment","sequence":1,"text":"@tuandq2711 \nCan you elaborate on the use case you are trying to achieve and current limitation you are facing ?","author_login":"darshankawar","author_association":"MEMBER","created_at":"2022-10-07T12:44:41+08:00","repo_name":"flutter/flutter","issue_id":1400904897,"issue_number":113093,"issue_url":"https://github.com/flutter/flutter/issues/113093","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1271636522","fragment_type":"issue_comment","sequence":2,"text":"@darshankawar \nCurrently on android or ios there is a Ground Overlays section to be able to draw images on the map. But on google_maps_flutter I don't see any to use. I can't add that part by myself so I hope you guys can help me add it.","author_login":"tuandq2711","author_association":"NONE","created_at":"2022-10-07T14:00:57+08:00","repo_name":"flutter/flutter","issue_id":1400904897,"issue_number":113093,"issue_url":"https://github.com/flutter/flutter/issues/113093","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1272788855","fragment_type":"issue_comment","sequence":3,"text":"Closing this as duplicate of URL Please follow-up in it for further updates.","author_login":"darshankawar","author_association":"MEMBER","created_at":"2022-10-10T05:01:43+08:00","repo_name":"flutter/flutter","issue_id":1400904897,"issue_number":113093,"issue_url":"https://github.com/flutter/flutter/issues/113093","linked_issue_ids":[398605825],"is_known_query_context":false},{"document_id":"gh_issue_398605825","fragment_type":"issue_description","sequence":0,"text":"[google_maps_flutter] Support for Ground Overlay\nHi, I'm developing an app where the main functionality is a Map with a Custom Ground Overlay. I've achieve that with the Ionic Framework but I want to make a Flutter version and I notice that the Ground Overlay Class or functionality is not present in the library at the moment. \n\nThis is what I need:\n\nAndroid:\n URL \n\niOS:\n URL \n\nThis is a main functionality for my app, so I need this to launch a production Flutter version of my app. Please, take a look at it.\n\nThanks!","author_login":"francovp","author_association":"NONE","created_at":"2019-01-13T00:24:54+08:00","repo_name":"flutter/flutter","issue_id":398605825,"issue_number":26479,"issue_url":"https://github.com/flutter/flutter/issues/26479","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_662855351","fragment_type":"issue_comment","sequence":1,"text":"Are there any plans to release an update on this? Is there any workaround?","author_login":"poqueque","author_association":"NONE","created_at":"2020-07-23T07:17:20+08:00","repo_name":"flutter/flutter","issue_id":398605825,"issue_number":26479,"issue_url":"https://github.com/flutter/flutter/issues/26479","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_665818270","fragment_type":"issue_comment","sequence":2,"text":"year and a half and still no progress, not even a comment :(","author_login":"palicka","author_association":"NONE","created_at":"2020-07-29T18:10:12+08:00","repo_name":"flutter/flutter","issue_id":398605825,"issue_number":26479,"issue_url":"https://github.com/flutter/flutter/issues/26479","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_674544186","fragment_type":"issue_comment","sequence":3,"text":"I know it's not solution, but I discovered another map package which supports ground overlays and many other things:\nflutter_map\nI didn't need google specific functionality for map, so I replaced them.\n\nMaybe it will help someone....","author_login":"palicka","author_association":"NONE","created_at":"2020-08-16T15:59:23+08:00","repo_name":"flutter/flutter","issue_id":398605825,"issue_number":26479,"issue_url":"https://github.com/flutter/flutter/issues/26479","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_675132530","fragment_type":"issue_comment","sequence":4,"text":"Hi there!\n\nI needed GroundOverlay in my project and implemented support for **Android**. \nYou are welcome to continue working on my forked repo to add iOS support \n\n URL \n\nIf you want to use GroundOverlay for Flutter Android now,\nyou can use the following dependency from the repository instead of the one from pub repo\n\ngoogle_maps_flutter:\n__git:\n____url: git@github.com:bytestreme/plugins_git.git\n____path: packages/google_maps_flutter/google_maps_flutter/","author_login":"bytestreme","author_association":"NONE","created_at":"2020-08-17T21:49:29+08:00","repo_name":"flutter/flutter","issue_id":398605825,"issue_number":26479,"issue_url":"https://github.com/flutter/flutter/issues/26479","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_693916875","fragment_type":"issue_comment","sequence":5,"text":"Is there any update in groundoverlay feature in flutter please....","author_login":"anooptj97","author_association":"NONE","created_at":"2020-09-17T05:46:38+08:00","repo_name":"flutter/flutter","issue_id":398605825,"issue_number":26479,"issue_url":"https://github.com/flutter/flutter/issues/26479","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_721407320","fragment_type":"issue_comment","sequence":6,"text":"Plus one to this request. I would like to overlay a builds interior on the map.","author_login":"jasonJamEther","author_association":"NONE","created_at":"2020-11-03T22:28:52+08:00","repo_name":"flutter/flutter","issue_id":398605825,"issue_number":26479,"issue_url":"https://github.com/flutter/flutter/issues/26479","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1149260271","fragment_type":"issue_comment","sequence":7,"text":"@UDAYBIDKAR did some great work on this in URL but unfortunately isn't available to finish the work. If anyone would like to build on their great contribution and take it to the finish line, that would be great — there's just some review comments to address (see the PR for details).","author_login":"Hixie","author_association":"MEMBER","created_at":"2022-06-07T23:13:17+08:00","repo_name":"flutter/flutter","issue_id":398605825,"issue_number":26479,"issue_url":"https://github.com/flutter/flutter/issues/26479","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1324785867","fragment_type":"issue_comment","sequence":8,"text":"+1 for this, @bytestreme great work on Android, but I (and others I believe) really need it on iOS as well. An official release would be great","author_login":"Mathorga","author_association":"NONE","created_at":"2022-11-23T09:44:25+08:00","repo_name":"flutter/flutter","issue_id":398605825,"issue_number":26479,"issue_url":"https://github.com/flutter/flutter/issues/26479","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1421585945","fragment_type":"issue_comment","sequence":9,"text":"It has been **4 years** waiting for this feature. We don't even have an estimate on when this will be addressed.","author_login":"poqueque","author_association":"NONE","created_at":"2023-02-07T22:59:38+08:00","repo_name":"flutter/flutter","issue_id":398605825,"issue_number":26479,"issue_url":"https://github.com/flutter/flutter/issues/26479","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1499123240","fragment_type":"issue_comment","sequence":10,"text":"I have followed this feature request since the first issues and later PRs. After waiting for a while, I started using this fork from originally rejected PR #3420, It has been a while since I have been using it in production without any major issues. However, it would be great to have it on the official channel.\n\nThis is how you can give it a try installing in your pubspec.yaml:\n\n google_maps_flutter:\n git:\n url: URL \n path: packages/google_maps_flutter/google_maps_flutter/","author_login":"joaquinperaza","author_association":"NONE","created_at":"2023-04-06T14:07:55+08:00","repo_name":"flutter/flutter","issue_id":398605825,"issue_number":26479,"issue_url":"https://github.com/flutter/flutter/issues/26479","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1499137195","fragment_type":"issue_comment","sequence":11,"text":"I used it for showing geotiffs of irregular shapes with RGB data or single-band with transparency computed locally on the flutter side. Here are some examples. Unfortunately I can’t share the class geotiff handling the png encoding since I am not the owner.\n\n<img width=\"1070\" alt=\"image\" src=\" URL","author_login":"joaquinperaza","author_association":"NONE","created_at":"2023-04-06T14:16:18+08:00","repo_name":"flutter/flutter","issue_id":398605825,"issue_number":26479,"issue_url":"https://github.com/flutter/flutter/issues/26479","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1553314158","fragment_type":"issue_comment","sequence":12,"text":"@stuartmorgan have you some expectation about a date to implement this feature?","author_login":"mauricioluz","author_association":"NONE","created_at":"2023-05-18T16:30:20+08:00","repo_name":"flutter/flutter","issue_id":398605825,"issue_number":26479,"issue_url":"https://github.com/flutter/flutter/issues/26479","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1699841567","fragment_type":"issue_comment","sequence":13,"text":"Any updates on this? Such functionality would be of major use for a great number of app ideas. I can understand that there is currently no bijection between the functionalities of the native ground overlays for Android and iOS, for example the fact that the iOS implementation has no constructor allowing the specification of a target location and a width. However, this is not something that basic math can't get around.\n\nSome existing forks of the `plugins` library are of good quality in Android. However, iOS is still rather flaky and unsuitable for production code when attempting more powerful functionality.\n\nThanks again for all the hard work.","author_login":"czadmedia","author_association":"NONE","created_at":"2023-08-30T21:05:02+08:00","repo_name":"flutter/flutter","issue_id":398605825,"issue_number":26479,"issue_url":"https://github.com/flutter/flutter/issues/26479","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2031466218","fragment_type":"issue_comment","sequence":14,"text":"Is there something new on this issue? It would be really good if this is implemented in next releases.","author_login":"ZahidTekbas","author_association":"NONE","created_at":"2024-04-02T09:08:03+08:00","repo_name":"flutter/flutter","issue_id":398605825,"issue_number":26479,"issue_url":"https://github.com/flutter/flutter/issues/26479","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0074","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"left right assertion failures on intel/nvidia hybrid gpu laptop.","query_context":"Hi! I tried running wl-screenrec on my hardware but I consistently get the following errors on both my NVIDIA card and my integrated intel gpu:\n\nbash\n❯ ./wl-screenrec --dri-device /dev/dri/renderD129 -v\nUsing output eDP-1\n[file @ 0x564a68e9ce00] Setting default whitelist 'file,crypto,data'\n[AVHWDeviceContext @ 0x564a68e9d340] libva: VA-API version 1.18.0\n[AVHWDeviceContext @ 0x564a68e9d340] libva: Trying to open /usr/lib/dri/iHD_drv_video.so\n[AVHWDeviceContext @ 0x564a68e9d340] libva: va_openDriver() returns -1\n[AVHWDeviceContext @ 0x564a68e9d340] libva: Trying to open /usr/lib/dri/i965_drv_video.so\n[AVHWDeviceContext @ 0x564a68e9d340] libva: va_openDriver() returns -1\n[AVHWDeviceContext @ 0x564a68e9d340] Failed to initialise VAAPI connection: -1 (unknown libva error).\nthread 'main' panicked at 'assertion failed: `(left == right)`\n left: `-5`,\n right: `0`', src/avhw.rs:34:13\nnote: run with `RUST_BACKTRACE=1` environment variable to display a backtrace\n[AVIOContext @ 0x564a68e9d180] Statistics: 0 bytes written, 0 seeks, 0 writeouts\n\nIf anyone can provide some context as to why this is occurring, I'd love to dig in deeper and provide more information.","known_context_document_ids":["gh_issue_1784075121"],"reference_answer":"Fixed the timing issues, which includes mp4 timing, so it should work without jank. \n\nI'm going to close this issue, if you still see the frame corruption issues open a new issue. Thanks for all the help guys!","answer_document_id":"gh_comment_1383295409","silver_evidence_path":["gh_comment_1618898421","gh_issue_1533767150","gh_comment_1383295409"],"evidence_issue_ids":[1784075121,1533767150],"source_repo_name":"russelltg/wl-screenrec","source_issue_id":1784075121,"source_issue_number":13,"source_issue_url":"https://github.com/russelltg/wl-screenrec/issues/13","target_repo_name":"russelltg/wl-screenrec","target_issue_id":1533767150,"target_issue_number":1,"target_issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","reference_anchor_document_id":"gh_comment_1618898421","reference_answer_author":"russelltg","reference_answer_author_association":"OWNER","quality_score":90.95,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.358,"anchor_target_overlap":0.0993,"target_answer_overlap":0.0},"issue_created_at":"2023-07-01T16:41:29+08:00","valid_comment_count":27,"fragments":[{"document_id":"gh_issue_1784075121","fragment_type":"issue_description","sequence":0,"text":"left right assertion failures on intel/nvidia hybrid gpu laptop.\nHi! I tried running wl-screenrec on my hardware but I consistently get the following errors on both my NVIDIA card and my integrated intel gpu:\n\nbash\n❯ ./wl-screenrec --dri-device /dev/dri/renderD129 -v\nUsing output eDP-1\n[file @ 0x564a68e9ce00] Setting default whitelist 'file,crypto,data'\n[AVHWDeviceContext @ 0x564a68e9d340] libva: VA-API version 1.18.0\n[AVHWDeviceContext @ 0x564a68e9d340] libva: Trying to open /usr/lib/dri/iHD_drv_video.so\n[AVHWDeviceContext @ 0x564a68e9d340] libva: va_openDriver() returns -1\n[AVHWDeviceContext @ 0x564a68e9d340] libva: Trying to open /usr/lib/dri/i965_drv_video.so\n[AVHWDeviceContext @ 0x564a68e9d340] libva: va_openDriver() returns -1\n[AVHWDeviceContext @ 0x564a68e9d340] Failed to initialise VAAPI connection: -1 (unknown libva error).\nthread 'main' panicked at 'assertion failed: `(left == right)`\n left: `-5`,\n right: `0`', src/avhw.rs:34:13\nnote: run with `RUST_BACKTRACE=1` environment variable to display a backtrace\n[AVIOContext @ 0x564a68e9d180] Statistics: 0 bytes written, 0 seeks, 0 writeouts\n\nIf anyone can provide some context as to why this is occurring, I'd love to dig in deeper and provide more information.","author_login":"Shinyzenith","author_association":"NONE","created_at":"2023-07-01T16:41:29+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1784075121,"issue_number":13,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/13","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1616079029","fragment_type":"issue_comment","sequence":1,"text":"The previous logs were from ArchLinux. I tried the same on NixOS on my Intel Iris Xe card laptop and I get the exact same error.","author_login":"Shinyzenith","author_association":"NONE","created_at":"2023-07-01T20:04:03+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1784075121,"issue_number":13,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/13","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1618866037","fragment_type":"issue_comment","sequence":2,"text":"Which GPU is renderD129? Could you post outputs of `ls -lah /dev/dri/by-path`, `lspci`, as well as `vainfo`? Also, does wf-recorder work in vaapi mode (`wf-recorder -c h264_vaapi -d /dev/dri/renderD129`)?\n\nYou cannot use vaapi on integrated nvidia graphics (or, I thought so, I had a hard time finding a reference that proved or disproved this), so I highly suggest you use the intel gpu for encode.","author_login":"russelltg","author_association":"OWNER","created_at":"2023-07-03T16:40:52+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1784075121,"issue_number":13,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/13","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1618898421","fragment_type":"issue_comment","sequence":3,"text":"I do not have that machine with me right now so I will provide the above details for the intel Iris Xe card I have. I'll report back with the logs from the hybrid machine when I have it available again.\n\nbash\n~\n❯ ls -lah /dev/dri/by-path\nPermissions Size User Date Modified Name\nlrwxrwxrwx@ 8 root 3 Jul 20:57  pci-0000:00:02.0-card -> ../card0\nlrwxrwxrwx 13 root 3 Jul 20:05  pci-0000:00:02.0-render -> ../renderD128\n\nbash\n[nix-shell:~]$ lspci\n00:00.0 Host bridge: Intel Corporation 11th Gen Core Processor Host Bridge/DRAM Registers (rev 01)\n00:02.0 VGA compatible controller: Intel Corporation TigerLake-LP GT2 [Iris Xe Graphics] (rev 01)\n00:04.0 Signal processing controller: Intel Corporation TigerLake-LP Dynamic Tuning Processor Participant (rev 01)\n00:06.0 PCI bridge: Intel Corporation 11th Gen Core Processor PCIe Controller (rev 01)\n00:0d.0 USB controller: Intel Corporation Tiger Lake-LP Thunderbolt 4 USB Controller (rev 01)\n00:12.0 Serial controller: Intel Corporation Tiger Lake-LP Integrated Sensor Hub (rev 20)\n00:14.0 USB controller: Intel Corporation Tiger Lake-LP USB 3.2 Gen 2x1 xHCI Host Controller (rev 20)\n00:14.2 RAM memory: Intel Corporation Tiger Lake-LP Shared SRAM (rev 20)\n00:14.3 Network controller: Intel Corporation Wi-Fi 6 AX201 (rev 20)\n00:15.0 Serial bus controller: Intel Corporation Tiger Lake-LP Serial IO I2C Controller #0 (rev 20)\n00:15.1 Serial bus controller: Intel Corporation Tiger Lake-LP Serial IO I2C Controller #1 (rev 20)\n00:16.0 Communication controller: Intel Corporation Tiger Lake-LP Management Engine Interface (rev 20)\n00:1c.0 PCI bridge: Intel Corporation Device a0be (rev 20)\n00:1f.0 ISA bridge: Intel Corporation Tiger Lake-LP LPC Controller (rev 20)\n00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)\n00:1f.4 SMBus: Intel Corporation Tiger Lake-LP SMBus Controller (rev 20)\n00:1f.5 Serial bus controller: Intel Corporation Tiger Lake-LP SPI Controller (rev 20)\n01:00.0 Non-Volatile memory controller: Micron Technology Inc Device 5404 (rev 03)\n02:00.0 SD Host controller: O2 Micro, Inc. SD/MMC Card Reader Controller (rev 01)\n\nbash\n[nix-shell:~]$ vainfo\nTrying display: wayland\nlibva info: VA-API version 1.18.0\nlibva info: Trying to open /run/opengl-driver/lib/dri/iHD_drv_video.so\nlibva info: Trying to open /usr/lib/dri/iHD_drv_video.so\nlibva info: Trying to open /usr/lib32/dri/iHD_drv_video.so\nlibva info: Trying to open /usr/lib/x86_64-linux-gnu/dri/iHD_drv_video.so\nlibva info: Trying to open /usr/lib/i386-linux-gnu/dri/iHD_drv_video.so\nlibva info: va_openDriver() returns -1\nlibva info: Trying to open /run/opengl-driver/lib/dri/i965_drv_video.so\nlibva info: Trying to open /usr/lib/dri/i965_drv_video.so\nlibva info: Trying to open /usr/lib32/dri/i965_drv_video.so\nlibva info: Trying to open /usr/lib/x86_64-linux-gnu/dri/i965_drv_video.so\nlibva info: Trying to open /usr/lib/i386-linux-gnu/dri/i965_drv_video.so\nlibva info: va_openDriver() returns -1\nvaInitialize failed with error code -1 (unknown libva error),exit\n\nbash\n[nix-shell:~]$ wf-recorder -c h264_vaapi -d /dev/dri/renderD128\nselected region 0,0 0x0\n[AVHWDeviceContext @ 0x7f4524005800] Failed to initialise VAAPI connection: -1 (unknown libva error).\nFailed to create hw encoding device /dev/dri/renderD128:","author_login":"Shinyzenith","author_association":"NONE","created_at":"2023-07-03T17:07:01+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1784075121,"issue_number":13,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/13","linked_issue_ids":[1533767150],"is_known_query_context":false},{"document_id":"gh_comment_1618901715","fragment_type":"issue_comment","sequence":4,"text":"Yeah, so you do not have a functional libva installation--I suggest you follow your distributions documentation on vaapi.","author_login":"russelltg","author_association":"OWNER","created_at":"2023-07-03T17:09:24+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1784075121,"issue_number":13,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/13","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1618902509","fragment_type":"issue_comment","sequence":5,"text":"Oh I didn't consider that. Thanks for taking a look. I'll try to setup vaapi, use wf-recorder to check if it's working and then try wl-screenrec again.","author_login":"Shinyzenith","author_association":"NONE","created_at":"2023-07-03T17:10:15+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1784075121,"issue_number":13,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/13","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1618921743","fragment_type":"issue_comment","sequence":6,"text":"I have setup vaapi and wl-screenrec works now. Thanks. However the colors look \"washed out\" and the overall quality is a little blurry which is odd. I see there's an issue about this in the repo so I will take a look at that.\nThanks for your help.","author_login":"Shinyzenith","author_association":"NONE","created_at":"2023-07-03T17:30:10+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1784075121,"issue_number":13,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/13","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1618956724","fragment_type":"issue_comment","sequence":7,"text":"Do they look overall worse than wf-recorder? Keep in mind the default bitrate is rather low, as this is what I like (I prefer small file sizes over high quality), but feel free to increase it with the `--bitrate` parameter","author_login":"russelltg","author_association":"OWNER","created_at":"2023-07-03T18:03:22+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1784075121,"issue_number":13,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/13","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1618977181","fragment_type":"issue_comment","sequence":8,"text":"I'll try that! The colors are actually significantly better than wf recorder but the blurriness remains","author_login":"Shinyzenith","author_association":"NONE","created_at":"2023-07-03T18:22:18+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1784075121,"issue_number":13,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/13","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1533767150","fragment_type":"issue_description","sequence":0,"text":"AMD GPU support\nHey i get this error when i try to use it with amd igpu\n\n🄸 ganymede ~> RUST_BACKTRACE=full wl-screenrec\nUsing output eDP-1\nXlib: extension \"DRI2\" missing on display \":0\".\namdgpu_device_initialize: amdgpu_query_info(ACCEL_WORKING) failed (-13)\namdgpu: amdgpu_device_initialize failed.\n[AVHWDeviceContext @ 0x55d28a6560c0] libva: /usr/lib/dri/radeonsi_drv_video.so init failed\n[AVHWDeviceContext @ 0x55d28a6560c0] Failed to initialise VAAPI connection: 2 (resource allocation failed).\nthread 'main' panicked at 'assertion failed: `(left == right)`\n left: `-5`,\n right: `0`', src/main.rs:767:13\nstack backtrace:\n 0: 0x55d2898cee70 - std::backtrace_rs::backtrace::libunwind::trace::h1d00f3fcf4cb5ac4\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5\n 1: 0x55d2898cee70 - std::backtrace_rs::backtrace::trace_unsynchronized::h920a6ff332484ee2\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5\n 2: 0x55d2898cee70 - std::sys_common::backtrace::_print_fmt::hd7323920c925af6d\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/sys_common/backtrace.rs:65:5\n 3: 0x55d2898cee70 - ::fmt::h3155a8c966b4beb5\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/sys_common/backtrace.rs:44:22\n 4: 0x55d2898eb94e - core::fmt::write::h062c617411b691df\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/fmt/mod.rs:1209:17\n 5: 0x55d2898cc935 - std::io::Write::write_fmt::hb61fdf1275c61e1c\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/io/mod.rs:1682:15\n 6: 0x55d2898cec35 - std::sys_common::backtrace::_print::hd1b4d9664ab500e0\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/sys_common/backtrace.rs:47:5\n 7: 0x55d2898cec35 - std::sys_common::backtrace::print::hca896ae22beb06cb\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/sys_common/backtrace.rs:34:9\n 8: 0x55d2898d04ef - std::panicking::default_hook::{{closure}}::h0b5eeed5cf36ab5f\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:267:22\n 9: 0x55d2898d022a - std::panicking::default_hook::h8932b573145a321b\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:286:9\n 10: 0x55d2898d0be8 - std::panicking::rust_panic_with_hook::h4b1447a24e3e94f8\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:688:13\n 11: 0x55d2898d0987 - std::panicking::begin_panic_handler::{{closure}}::h8701da9995a3820c\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:579:13\n 12: 0x55d2898cf31c - std::sys_common::backtrace::__rust_end_short_backtrace::hb696c5ed02a01598\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/sys_common/backtrace.rs:137:18\n 13: 0x55d2898d06a2 - rust_begin_unwind\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:575:5\n 14: 0x55d28982cc53 - core::panicking::panic_fmt::h8aa706a976963c88\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/panicking.rs:65:14\n 15: 0x55d2898eabeb - core::panicking::assert_failed_inner::h3c3fae67130f6d6f\n 16: 0x55d28982a24b - core::panicking::assert_failed::hb8d58c1ba4efd32a\n 17: 0x55d28983fe06 - wl_screenrec::State::start_if_output_probe_complete::hdfdb73a7e409d7d4\n 18: 0x55d28983e058 - >::event::h60a3a4608687ec1f\n 19: 0x55d289846952 - wayland_client::event_queue::queue_callback::h8d386cc6546cff38\n 20: 0x55d28984784a - wayland_client::event_queue::EventQueue ::dispatch_pending::h0b0717127d7c09df\n 21: 0x55d289847d87 - wayland_client::event_queue::EventQueue ::blocking_dispatch::he196364748bcac03\n 22: 0x55d28984160e - wl_screenrec::main::h8ddb69fd9753ba1f\n 23: 0x55d289830763 - std::sys_common::backtrace::__rust_begin_short_backtrace::h69401c9006f76632\n 24: 0x55d2898369b9 - std::rt::lang_start::{{closure}}::h11dce253789bb3c0\n 25: 0x55d2898c8b9b - core::ops::function::impls:: for &F>::call_once::h8cbb48ae40ddb046\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/ops/function.rs:286:13\n 26: 0x55d2898c8b9b - std::panicking::try::do_call::h92db802eb38b49b7\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:483:40\n 27: 0x55d2898c8b9b - std::panicking::try::ha8949d2082cf3644\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:447:19\n 28: 0x55d2898c8b9b - std::panic::catch_unwind::h5e34c1f8a5992ed9\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panic.rs:137:14\n 29: 0x55d2898c8b9b - std::rt::lang_start_internal::{{closure}}::hea52a0bb3f8ff16a\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/rt.rs:148:48\n 30: 0x55d2898c8b9b - std::panicking::try::do_call::h5bc358faf3d68a8b\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:483:40\n 31: 0x55d2898c8b9b - std::panicking::try::h675304212928379d\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:447:19\n 32: 0x55d2898c8b9b - std::panic::catch_unwind::h7ce3ad349ed5c844\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panic.rs:137:14\n 33: 0x55d2898c8b9b - std::rt::lang_start_internal::hcd7e45acd25ab5ab\n at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/rt.rs:148:20\n 34: 0x55d289843ed5 - main\n 35: 0x7f35c843c290 - \n 36: 0x7f35c843c34a - __libc_start_main\n 37: 0x55d28982cf95 - _start\n at /build/glibc/src/glibc/csu/../sysdeps/x86_64/start.S:115\n 38: 0x0 -","author_login":"p00f","author_association":"NONE","created_at":"2023-01-15T11:17:33+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383123215","fragment_type":"issue_comment","sequence":1,"text":"output of vainfo:\n\n🄸 ganymede ~ [101]> vainfo\nTrying display: wayland\nvainfo: VA-API version: 1.17 (libva 2.17.1)\nvainfo: Driver version: Mesa Gallium driver 22.3.3 for AMD Radeon Graphics (renoir, LLVM 14.0.6, DRM 3.49, 6.1.5-arch2-1)\nvainfo: Supported profile and entrypoints\n VAProfileMPEG2Simple : VAEntrypointVLD\n VAProfileMPEG2Main : VAEntrypointVLD\n VAProfileVC1Simple : VAEntrypointVLD\n VAProfileVC1Main : VAEntrypointVLD\n VAProfileVC1Advanced : VAEntrypointVLD\n VAProfileH264ConstrainedBaseline: VAEntrypointVLD\n VAProfileH264ConstrainedBaseline: VAEntrypointEncSlice\n VAProfileH264Main : VAEntrypointVLD\n VAProfileH264Main : VAEntrypointEncSlice\n VAProfileH264High : VAEntrypointVLD\n VAProfileH264High : VAEntrypointEncSlice\n VAProfileHEVCMain : VAEntrypointVLD\n VAProfileHEVCMain : VAEntrypointEncSlice\n VAProfileHEVCMain10 : VAEntrypointVLD\n VAProfileHEVCMain10 : VAEntrypointEncSlice\n VAProfileJPEGBaseline : VAEntrypointVLD\n VAProfileVP9Profile0 : VAEntrypointVLD\n VAProfileVP9Profile2 : VAEntrypointVLD\n VAProfileNone : VAEntrypointVideoProc","author_login":"p00f","author_association":"NONE","created_at":"2023-01-15T11:17:58+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383200250","fragment_type":"issue_comment","sequence":2,"text":"I have similar error, after running `wl-screenrec`:\n\nUsing output eDP-1\namdgpu_device_initialize: amdgpu_query_info(ACCEL_WORKING) failed (-13)\namdgpu: amdgpu_device_initialize failed.\n[AVHWDeviceContext @ 0x5590fb0ac040] libva: /usr/lib/dri/radeonsi_drv_video.so init failed\n[AVHWDeviceContext @ 0x5590fb0ac040] Failed to initialise VAAPI connection: 2 (resource allocation failed).\nthread 'main' panicked at 'assertion failed: `(left == right)`\n left: `-5`,\n right: `0`', src/main.rs:767:13\nnote: run with `RUST_BACKTRACE=1` environment variable to display a backtrace\n\nOS: Arch Linux x86_64\nWindow Manager: Sway Wayland only mode\nHost: 82B1 Lenovo Legion 5 15ARH05H\nCPU: AMD Ryzen 7 4800H with Radeon Graphics (16) @ 2.900GHz\nGPU: AMD ATI 06:00.0 Renoir\nGPU: NVIDIA GeForce GTX 1660 Ti Mobile\n\nI have installed\nlibva\nlibva-mesa-driver\nlibva-vdpau-driver\nvulkan-radeon\nmesa-vdpau","author_login":"roland-rollo","author_association":"NONE","created_at":"2023-01-15T16:59:25+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383208248","fragment_type":"issue_comment","sequence":3,"text":"Thanks for the reports. Could I get the output of\n\nstrace wl-screenrec\n\nand the output of \n\nstrace vainfo --display drm --device /dev/dri/card0\n\nAlso, if /dev/dri/card0 isn't you amd gpu, set `--dri-device=/dev/dri/cardx` of `wl-screenrec`","author_login":"russelltg","author_association":"OWNER","created_at":"2023-01-15T17:35:35+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383214015","fragment_type":"issue_comment","sequence":4,"text":"Okay, I think I know what's going on. Can I see\n\nvainfo --display drm --device /dev/dri/renderD128","author_login":"russelltg","author_association":"OWNER","created_at":"2023-01-15T18:03:06+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383214127","fragment_type":"issue_comment","sequence":5,"text":"`strace wl-screenrec`: URL \n`strace vainfo --display drm --device /dev/dri/card0`: URL","author_login":"p00f","author_association":"NONE","created_at":"2023-01-15T18:03:33+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383214198","fragment_type":"issue_comment","sequence":6,"text":"🄸 ganymede ~> vainfo --display drm --device /dev/dri/renderD128\nTrying display: drm\nvainfo: VA-API version: 1.17 (libva 2.17.1)\nvainfo: Driver version: Mesa Gallium driver 22.3.3 for AMD Radeon Graphics (renoir, LLVM 14.0.6, DRM 3.49, 6.1.5-arch2-1)\nvainfo: Supported profile and entrypoints\n VAProfileMPEG2Simple : VAEntrypointVLD\n VAProfileMPEG2Main : VAEntrypointVLD\n VAProfileVC1Simple : VAEntrypointVLD\n VAProfileVC1Main : VAEntrypointVLD\n VAProfileVC1Advanced : VAEntrypointVLD\n VAProfileH264ConstrainedBaseline: VAEntrypointVLD\n VAProfileH264ConstrainedBaseline: VAEntrypointEncSlice\n VAProfileH264Main : VAEntrypointVLD\n VAProfileH264Main : VAEntrypointEncSlice\n VAProfileH264High : VAEntrypointVLD\n VAProfileH264High : VAEntrypointEncSlice\n VAProfileHEVCMain : VAEntrypointVLD\n VAProfileHEVCMain : VAEntrypointEncSlice\n VAProfileHEVCMain10 : VAEntrypointVLD\n VAProfileHEVCMain10 : VAEntrypointEncSlice\n VAProfileJPEGBaseline : VAEntrypointVLD\n VAProfileVP9Profile0 : VAEntrypointVLD\n VAProfileVP9Profile2 : VAEntrypointVLD\n VAProfileNone : VAEntrypointVideoProc","author_login":"p00f","author_association":"NONE","created_at":"2023-01-15T18:03:56+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383215908","fragment_type":"issue_comment","sequence":7,"text":"Okay, I anticipate that `wl-screenrec --dri-device /dev/dri/renderD128` might work?\n\nIf so, I can make it use that device by default","author_login":"russelltg","author_association":"OWNER","created_at":"2023-01-15T18:11:28+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383216154","fragment_type":"issue_comment","sequence":8,"text":"nope,\n\n🄸 ganymede ~> wl-screenrec --dri-device /dev/dri/renderD128\nUsing output eDP-1\n[h264_vaapi @ 0x5620833caa40] No usable encoding entrypoint found for profile VAProfileH264High (7).\nthread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ffmpeg::Error(38: Function not implemented)', src/main.rs:684:39\nnote: run with `RUST_BACKTRACE=1` environment variable to display a backtrace","author_login":"p00f","author_association":"NONE","created_at":"2023-01-15T18:12:45+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383217564","fragment_type":"issue_comment","sequence":9,"text":"vainfo --display drm --device /dev/dri/renderD128\n\nTrying display: drm\nvainfo: VA-API version: 1.17 (libva 2.17.1)\nvainfo: Driver version: Mesa Gallium driver 22.3.3 for AMD Radeon Graphics (renoir, LLVM 15.0.7, DRM 3.49, 6.1.5-arch2-1)\nvainfo: Supported profile and entrypoints\n VAProfileMPEG2Simple : VAEntrypointVLD\n VAProfileMPEG2Main : VAEntrypointVLD\n VAProfileVC1Simple : VAEntrypointVLD\n VAProfileVC1Main : VAEntrypointVLD\n VAProfileVC1Advanced : VAEntrypointVLD\n VAProfileH264ConstrainedBaseline: VAEntrypointVLD\n VAProfileH264ConstrainedBaseline: VAEntrypointEncSlice\n VAProfileH264Main : VAEntrypointVLD\n VAProfileH264Main : VAEntrypointEncSlice\n VAProfileH264High : VAEntrypointVLD\n VAProfileH264High : VAEntrypointEncSlice\n VAProfileHEVCMain : VAEntrypointVLD\n VAProfileHEVCMain : VAEntrypointEncSlice\n VAProfileHEVCMain10 : VAEntrypointVLD\n VAProfileHEVCMain10 : VAEntrypointEncSlice\n VAProfileJPEGBaseline : VAEntrypointVLD\n VAProfileVP9Profile0 : VAEntrypointVLD\n VAProfileVP9Profile2 : VAEntrypointVLD\n VAProfileNone : VAEntrypointVideoProc\n\nwl-screenrec --dri-device /dev/dri/renderD128\n\nUsing output eDP-1\n[h264_vaapi @ 0x5647a3015980] No usable encoding entrypoint found for profile VAProfileH264High (7).\nthread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ffmpeg::Error(38: Function not implemented)', src/main.rs:684:39\nnote: run with `RUST_BACKTRACE=1` environment variable to display a backtrace","author_login":"roland-rollo","author_association":"NONE","created_at":"2023-01-15T18:19:08+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383240142","fragment_type":"issue_comment","sequence":10,"text":"Does `ffmpeg -vaapi_device /dev/dri/renderD128 -f lavfi -i rgbtestsrc=duration=5:size=1280x720:rate=30 -vf hwupload,crop=100:100:200:200,scale_vaapi=format=nv12:w=100:h=100 -c:v h264_vaapi testout.mp4` work?","author_login":"russelltg","author_association":"OWNER","created_at":"2023-01-15T20:09:57+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383244916","fragment_type":"issue_comment","sequence":11,"text":"`ffmpeg -vaapi_device /dev/dri/renderD128 -f lavfi -i rgbtestsrc=duration=5:size=1280x720:rate=30 -vf hwupload,crop=100:100:200:200,scale_vaapi=format=nv12:w=100:h=100 -c:v h264_vaapi testout.mp4`\n\nffmpeg version n5.1.2 Copyright (c) 2000-2022 the FFmpeg developers\n built with gcc 12.2.0 (GCC)\n configuration: --prefix=/usr --disable-debug --disable-static --disable-stripping --enable-amf --enable-avisynth --enable-cuda-llvm --enable-lto --enable-fontconfig --enable-gmp --enable-gnutls --enable-gpl --enable-ladspa --enable-libaom --enable-libass --enable-libbluray --enable-libbs2b --enable-libdav1d --enable-libdrm --enable-libfreetype --enable-libfribidi --enable-libgsm --enable-libiec61883 --enable-libjack --enable-libmfx --enable-libmodplug --enable-libmp3lame --enable-libopencore_amrnb --enable-libopencore_amrwb --enable-libopenjpeg --enable-libopus --enable-libpulse --enable-librav1e --enable-librsvg --enable-libsoxr --enable-libspeex --enable-libsrt --enable-libssh --enable-libsvtav1 --enable-libtheora --enable-libv4l2 --enable-libvidstab --enable-libvmaf --enable-libvorbis --enable-libvpx --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxcb --enable-libxml2 --enable-libxvid --enable-libzimg --enable-nvdec --enable-nvenc --enable-opencl --enable-opengl --enable-shared --enable-version3 --enable-vulkan\n libavutil 57. 28.100 / 57. 28.100\n libavcodec 59. 37.100 / 59. 37.100\n libavformat 59. 27.100 / 59. 27.100\n libavdevice 59. 7.100 / 59. 7.100\n libavfilter 8. 44.100 / 8. 44.100\n libswscale 6. 7.100 / 6. 7.100\n libswresample 4. 7.100 / 4. 7.100\n libpostproc 56. 6.100 / 56. 6.100\nInput #0, lavfi, from 'rgbtestsrc=duration=5:size=1280x720:rate=30':\n Duration: N/A, start: 0.000000, bitrate: N/A\n Stream #0:0: Video: rawvideo (RGBA / 0x41424752), rgba, 1280x720 [SAR 1:1 DAR 16:9], 30 tbr, 30 tbn\nStream mapping:\n Stream #0:0 -> #0:0 (rawvideo (native) -> h264 (h264_vaapi))\nPress [q] to stop, [?] for help\n[h264_vaapi @ 0x556510bae6c0] No quality level set; using default (20).\n[h264_vaapi @ 0x556510bae6c0] Driver does not support some wanted packed headers (wanted 0xd, found 0).\n[h264_vaapi @ 0x556510bae6c0] Driver does not support packed sequence headers, but a global header is requested.\n[h264_vaapi @ 0x556510bae6c0] No global header will be written: this may result in a stream which is not usable for some purposes (e.g. not muxable to some containers).\nOutput #0, mp4, to 'testout.mp4':\n Metadata:\n encoder : Lavf59.27.100\n Stream #0:0: Video: h264 (High) (avc1 / 0x31637661), vaapi(progressive), 100x100 [SAR 16:9 DAR 16:9], q=2-31, 30 fps, 15360 tbn\n Metadata:\n encoder : Lavc59.37.100 h264_vaapi\nframe= 150 fps=0.0 q=-0.0 Lsize= 5kB time=00:00:04.96 bitrate= 8.9kbits/s speed=14.3x\nvideo:4kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 36.048229%\n\n URL","author_login":"roland-rollo","author_association":"NONE","created_at":"2023-01-15T20:33:18+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383245112","fragment_type":"issue_comment","sequence":12,"text":"wl-screenrec --low-power=off\n\nUsing output eDP-1\n[h264_vaapi @ 0x5618377f29c0] Driver does not support some wanted packed headers (wanted 0xd, found 0).\n[h264_vaapi @ 0x5618377f29c0] Driver does not support packed sequence headers, but a global header is requested.\n[h264_vaapi @ 0x5618377f29c0] No global header will be written: this may result in a stream which is not usable for some purposes (e.g. not muxable to some containers).\n3 fps\n[avi @ 0x561837595680] Application provided invalid, non monotonically increasing dts to muxer in stream 0: 292 >= 292\nthread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ffmpeg::Error(22: Invalid argument)', src/main.rs:757:55\nnote: run with `RUST_BACKTRACE=1` environment variable to display a backtrace\n\nAnd then I tried second time and it worked\n[roland@blackrainbow ~]$ wl-screenrec --low-power=off\n\nUsing output eDP-1\n[h264_vaapi @ 0x560869f3f580] Driver does not support some wanted packed headers (wanted 0xd, found 0).\n[h264_vaapi @ 0x560869f3f580] Driver does not support packed sequence headers, but a global header is requested.\n[h264_vaapi @ 0x560869f3f580] No global header will be written: this may result in a stream which is not usable for some purposes (e.g. not muxable to some containers).\n3 fps\n56 fps\n10 fps\n16 fps\n46 fps\n38 fps\n80 fps\n45 fps\n2 fps\n10 fps\n10 fps\n2 fps\n2 fps\n3 fps\n5 fps\n9 fps","author_login":"roland-rollo","author_association":"NONE","created_at":"2023-01-15T20:34:03+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383245474","fragment_type":"issue_comment","sequence":13,"text":"Awesome. I've seen that non monotonically increasing error before as well, I'm not entirely sure why it happens. I think I should probably just discard frames that end up having a higher PTS, but I'm not sure why wlroots is not giving increasing timestamps.","author_login":"russelltg","author_association":"OWNER","created_at":"2023-01-15T20:35:23+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383245530","fragment_type":"issue_comment","sequence":14,"text":"There's still a bug with --low-power=auto (the default), and I think I have an idea","author_login":"russelltg","author_association":"OWNER","created_at":"2023-01-15T20:35:42+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383255371","fragment_type":"issue_comment","sequence":15,"text":"Okay, latest should be able to auto-detect the low_power setting properly, as well as discarding non-monotonic frames","author_login":"russelltg","author_association":"OWNER","created_at":"2023-01-15T21:17:55+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383260147","fragment_type":"issue_comment","sequence":16,"text":"Interesting. Does the shell matter in the quality of the recording? bash vs fish\n URL","author_login":"roland-rollo","author_association":"NONE","created_at":"2023-01-15T21:41:31+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383261707","fragment_type":"issue_comment","sequence":17,"text":"I can't imagine why it would. I get an error opening that URL....","author_login":"russelltg","author_association":"OWNER","created_at":"2023-01-15T21:50:04+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383282528","fragment_type":"issue_comment","sequence":18,"text":"I'm pretty sure that it's a side effect of the non monotonic DTS thing--you probably missed an IDR. I'll see if I can figure it out. Certainly not a function of your shell","author_login":"russelltg","author_association":"OWNER","created_at":"2023-01-15T23:22:15+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383295409","fragment_type":"issue_comment","sequence":19,"text":"Fixed the timing issues, which includes mp4 timing, so it should work without jank. \n\nI'm going to close this issue, if you still see the frame corruption issues open a new issue. Thanks for all the help guys!","author_login":"russelltg","author_association":"OWNER","created_at":"2023-01-16T00:12:37+08:00","repo_name":"russelltg/wl-screenrec","issue_id":1533767150,"issue_number":1,"issue_url":"https://github.com/russelltg/wl-screenrec/issues/1","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0077","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"🚀 Feature: publish: :push action?","query_context":"### 🔖 Feature description\n\nadd publish:\\ :push to the list of built-in action\n\n### 🎤 Context\n\nAs a user who adding API (or any other component) to my service catalogue - I want to have the option to do this via UI.\nCreating a new git repository for each new entity seems wasteful, so I want to have a single repository for all configs. \nCreating yaml files manually and registering them via a direct link is tiring.\nI want to push a new yaml file directly to the branch and be able to register entity in catalog immediately after creation.\n\ntemplate example:\n\n steps:\n - id: fetch-base\n name: Fetch Base\n action: fetch:template\n input:\n url: ./content\n values:\n name: ${{ parameters.name }}\n\n - id: publish\n name: Publish\n action: publish:github:push\n input:\n branch: master\n targetPath: some/path\n repoUrl: ${{ parameters.repoUrl }}\n\n - id: register\n name: Register\n action: catalog:register\n input:\n repoContentsUrl: ${{ steps['publish'].output.repoContentsUrl }}\n catalogInfoPath: 'some/path/catalog-info.yaml'\n\n### ✌️ Possible Implementation\n\n_No response_\n\n### 👀 Have you spent some time to check if this feature request has been raised before?\n\n- [X] I checked and didn't find similar issue\n\n### 🏢 Have you read the Code of Conduct?\n\n- [X] I have read the Code of Conduct\n\n### Are you willing to submit PR?\n\nNone","known_context_document_ids":["gh_issue_1568395314"],"reference_answer":"That's right.\n \n\nYep, spread them out to where they belong, and leave their management up to their respective owners.\n \n\nI am again a bit confused by the wording \"catalog repo\". :) There should be no catalog repo. You should have catalog-info files spread out all across your version control system, and the catalog (the catalog SERVICE, running in your infrastructure) holds a list of URLs pointing to those files. It updates its internal state all the time, in the background, based on the contents of those files.\n\nIf an end user changes a catalog-info file in their own repo, that's already registered in the catalog backend, there's no more action to take. You don't re-register. A short while later, the updated info will just automatically be reflected in the catalog.","answer_document_id":"gh_comment_1700502364","silver_evidence_path":["gh_comment_1420485882","gh_issue_1568411360","gh_comment_1700502364"],"evidence_issue_ids":[1568395314,1568411360],"source_repo_name":"backstage/backstage","source_issue_id":1568395314,"source_issue_number":16153,"source_issue_url":"https://github.com/backstage/backstage/issues/16153","target_repo_name":"backstage/backstage","target_issue_id":1568411360,"target_issue_number":16155,"target_issue_url":"https://github.com/backstage/backstage/issues/16155","reference_anchor_document_id":"gh_comment_1420485882","reference_answer_author":"freben","reference_answer_author_association":"MEMBER","quality_score":95.31,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.3333,"target_answer_overlap":0.0862},"issue_created_at":"2023-02-02T16:50:23+08:00","valid_comment_count":20,"fragments":[{"document_id":"gh_issue_1568395314","fragment_type":"issue_description","sequence":0,"text":"🚀 Feature: publish: :push action\n### 🔖 Feature description\n\nadd publish:\\ :push to the list of built-in action\n\n### 🎤 Context\n\nAs a user who adding API (or any other component) to my service catalogue - I want to have the option to do this via UI.\nCreating a new git repository for each new entity seems wasteful, so I want to have a single repository for all configs. \nCreating yaml files manually and registering them via a direct link is tiring.\nI want to push a new yaml file directly to the branch and be able to register entity in catalog immediately after creation.\n\ntemplate example:\n\n steps:\n - id: fetch-base\n name: Fetch Base\n action: fetch:template\n input:\n url: ./content\n values:\n name: ${{ parameters.name }}\n\n - id: publish\n name: Publish\n action: publish:github:push\n input:\n branch: master\n targetPath: some/path\n repoUrl: ${{ parameters.repoUrl }}\n\n - id: register\n name: Register\n action: catalog:register\n input:\n repoContentsUrl: ${{ steps['publish'].output.repoContentsUrl }}\n catalogInfoPath: 'some/path/catalog-info.yaml'\n\n### ✌️ Possible Implementation\n\n_No response_\n\n### 👀 Have you spent some time to check if this feature request has been raised before?\n\n- [X] I checked and didn't find similar issue\n\n### 🏢 Have you read the Code of Conduct?\n\n- [X] I have read the Code of Conduct\n\n### Are you willing to submit PR?\n\nNone","author_login":"yesmanmx","author_association":"NONE","created_at":"2023-02-02T16:50:23+08:00","repo_name":"backstage/backstage","issue_id":1568395314,"issue_number":16153,"issue_url":"https://github.com/backstage/backstage/issues/16153","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1419030898","fragment_type":"issue_comment","sequence":1,"text":"I would recommend looking into the `publish:github:pull-request` action instead, which would allow you create pull requests for each entity definition.\n\nIf you go to your backstage instance, `/create/actions` you should be able to see the options that you can pass into the action in the template definition.","author_login":"benjdlambert","author_association":"MEMBER","created_at":"2023-02-06T12:50:47+08:00","repo_name":"backstage/backstage","issue_id":1568395314,"issue_number":16153,"issue_url":"https://github.com/backstage/backstage/issues/16153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1420467893","fragment_type":"issue_comment","sequence":2,"text":"Thank you for the answer, but the main idea here is not to leave backstage UI during updates. Do not interact with other services like github to merge PR","author_login":"yesmanmx","author_association":"NONE","created_at":"2023-02-07T09:35:50+08:00","repo_name":"backstage/backstage","issue_id":1568395314,"issue_number":16153,"issue_url":"https://github.com/backstage/backstage/issues/16153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1420485882","fragment_type":"issue_comment","sequence":3,"text":"My point about this is described in a bit more detail at: URL","author_login":"yesmanmx","author_association":"NONE","created_at":"2023-02-07T09:49:43+08:00","repo_name":"backstage/backstage","issue_id":1568395314,"issue_number":16153,"issue_url":"https://github.com/backstage/backstage/issues/16153","linked_issue_ids":[1568411360],"is_known_query_context":false},{"document_id":"gh_comment_1426757963","fragment_type":"issue_comment","sequence":4,"text":"I'm wondering if this use case is better served by directly communication with the GitHub APIs from the client, rather than using the scaffolder? Bit in line with how the `catalog-import` client creates PRs.","author_login":"Rugvip","author_association":"MEMBER","created_at":"2023-02-11T12:41:42+08:00","repo_name":"backstage/backstage","issue_id":1568395314,"issue_number":16153,"issue_url":"https://github.com/backstage/backstage/issues/16153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2027294337","fragment_type":"issue_comment","sequence":5,"text":"I have the same problem. Do we have an update on publishing to a GitHub Folder? ... without having to create a new repo or manually merge a pull request?","author_login":"cgallisa","author_association":"NONE","created_at":"2024-03-29T14:06:05+08:00","repo_name":"backstage/backstage","issue_id":1568395314,"issue_number":16153,"issue_url":"https://github.com/backstage/backstage/issues/16153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1568411360","fragment_type":"issue_description","sequence":0,"text":"🚀 Feature: Possibility to update entities via UI\n### 🔖 Feature description\n\nAs a user, I want to be able to update entities' data via backstage UI\n\n### 🎤 Context\n\nWhen working with backstage, to add a link or relation or update some fields of entity - you need to manually update yaml file.\nEditing entities via UI will make work with a backstage much more user-friendly. You will not need to edit data in the database (git repo in this case) directly.\n\n### ✌️ Possible Implementation\n\nBackstage already have \"view yaml\" for the entity feature. \nFew forms can be implemented to update common fields like description or links. On form submission - new yaml will override existing in the git repo and in backstage's database.\n\n### 👀 Have you spent some time to check if this feature request has been raised before?\n\n- [X] I checked and didn't find similar issue\n\n### 🏢 Have you read the Code of Conduct?\n\n- [X] I have read the Code of Conduct\n\n### Are you willing to submit PR?\n\nNone","author_login":"yesmanmx","author_association":"NONE","created_at":"2023-02-02T16:59:29+08:00","repo_name":"backstage/backstage","issue_id":1568411360,"issue_number":16155,"issue_url":"https://github.com/backstage/backstage/issues/16155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1419774731","fragment_type":"issue_comment","sequence":1,"text":"Hi!\n\nThis can be done in a couple different ways. For data in a version control system, ultimately the end result has to either be a push, or a pull request. That involves making requests using the relevant client library, eg octokit for the case of github. We have the helpers to get the auth set up for that so that it happens on behalf of the actual user performing the action, so that's good. You could make a web interface either for targeted actions as you mention, or in the form of a full YAML editor that helps you do validation and get the indentation right and all of that jazz.\n\nSeparate to this, there's an entire track to explore of having direct editor support, as in, building vscode / intellij plugins and thinking about leveraging schemas and/or querying the catalog for automatic validation as you type, and stuff like that.\n\nPing @taras here for info - these are topics that may be of interest to him, and to the Adoption SIG work that's underway.","author_login":"freben","author_association":"MEMBER","created_at":"2023-02-06T21:22:48+08:00","repo_name":"backstage/backstage","issue_id":1568411360,"issue_number":16155,"issue_url":"https://github.com/backstage/backstage/issues/16155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1420480584","fragment_type":"issue_comment","sequence":2,"text":"Thank you for the answer.\nI understand, that I can do it on my own, but I want it to be a part of backstage and available out of the box.\n\nAlso, if backstage will support some database as a source of truth backend (not git), it will be very helpful for decoupling from code, easy migrations, and consistency checks. \nE.g.: specify postgres as the source backend for storing entities. Add action in templates for entity creation. Implement CRUD API and interfaces for entity management directly in the backstage app. Implement entity provider to sync with the core database.\n\nDisclaimer: I still understand, that all this is possible to do on my own, but I won't be able to support it on my own :)","author_login":"yesmanmx","author_association":"NONE","created_at":"2023-02-07T09:45:36+08:00","repo_name":"backstage/backstage","issue_id":1568411360,"issue_number":16155,"issue_url":"https://github.com/backstage/backstage/issues/16155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1420483725","fragment_type":"issue_comment","sequence":3,"text":"about\n \n\nIt is nice to have this, but still, this requires some third-party tool to work with backstage. And my point is that backstage should be self-sufficient and user friendly","author_login":"yesmanmx","author_association":"NONE","created_at":"2023-02-07T09:48:02+08:00","repo_name":"backstage/backstage","issue_id":1568411360,"issue_number":16155,"issue_url":"https://github.com/backstage/backstage/issues/16155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1426001608","fragment_type":"issue_comment","sequence":4,"text":"Hi!\n\nWe've built something like this internally for our Bitbucket repos:\n- a Yaml Editor that is filled with the catalog-info.yaml content from the repo (using monaco-yaml: URL \n- an endpoint within Backstage that outputs a dynamic JSON Schema based on the whole Backstage catalog data for the different entity types - therefor offering then some predefined Enums and autocomplete functionality to e.g. easier define the correct component name in the dependencies as well as to have some validation like the inbuilt Backstage restrictions e.g. metadata.name must have a certain format\n- a save functionality that creates a pull request with the changes\n\nI was thinking about open sourcing it, but there would be needed to do some generalization, since we have some specific scenarios just for us in there right now and it's all put together in one plugin. Might be considering to split the above mentioned functionalites up a bit into seperate plugins and have an \"Editor\" plugin, that can offers some extendable functionality so other plugins could integrate their own saving logic. There is probably quite a lot to consider to have it generalized.\n\nHere is a screenshot to easier grasp what we've done:\nimage","author_login":"belech","author_association":"NONE","created_at":"2023-02-10T15:49:48+08:00","repo_name":"backstage/backstage","issue_id":1568411360,"issue_number":16155,"issue_url":"https://github.com/backstage/backstage/issues/16155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1427792937","fragment_type":"issue_comment","sequence":5,"text":"Thank you for the answer\nIt looks handy, but still not enough for backstage to be an independent tool for all team (not only developers)\nThanks for the link, I will try it. But if you decide to implement CUD UI for entities - I would like to use it.\n\nBTW, backstage is really cool and powerful tool, but a bit complex sometimes","author_login":"yesmanmx","author_association":"NONE","created_at":"2023-02-13T11:34:50+08:00","repo_name":"backstage/backstage","issue_id":1568411360,"issue_number":16155,"issue_url":"https://github.com/backstage/backstage/issues/16155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1513824368","fragment_type":"issue_comment","sequence":6,"text":"@belech I really appreciate your implementation details! I just found out about monaco-yaml from your suggestion and it looks awesome! We've been trying to build a custom template to download + merge yaml files together but it's not quite working out for us with multi yaml files.","author_login":"aaronnickovich","author_association":"CONTRIBUTOR","created_at":"2023-04-18T21:38:37+08:00","repo_name":"backstage/backstage","issue_id":1568411360,"issue_number":16155,"issue_url":"https://github.com/backstage/backstage/issues/16155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1605288354","fragment_type":"issue_comment","sequence":7,"text":"@belech Awesome stuff. Any chance you open source your solution.","author_login":"dweber019","author_association":"CONTRIBUTOR","created_at":"2023-06-24T06:37:46+08:00","repo_name":"backstage/backstage","issue_id":1568411360,"issue_number":16155,"issue_url":"https://github.com/backstage/backstage/issues/16155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1696022752","fragment_type":"issue_comment","sequence":8,"text":"My company is also interested in this, i see this as one basic feature. And i really hope this will be implemented..","author_login":"enryson","author_association":"NONE","created_at":"2023-08-28T16:50:46+08:00","repo_name":"backstage/backstage","issue_id":1568411360,"issue_number":16155,"issue_url":"https://github.com/backstage/backstage/issues/16155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1697716049","fragment_type":"issue_comment","sequence":9,"text":"I'd be interested in hearing about end-to-end workflow descriptions. Those of you who expressed interest, how would you envision that this worked from start to finish?\n\nSay you are an org with a couple hundred or thousand repos and teams. You want to start adopting Backstage. What would you like the journey to be like, for your end users to start getting things into the catalog and get all of the right metadata into place, from that blank slate? How would permissions and the lifecycle of things work?","author_login":"freben","author_association":"MEMBER","created_at":"2023-08-29T15:49:40+08:00","repo_name":"backstage/backstage","issue_id":1568411360,"issue_number":16155,"issue_url":"https://github.com/backstage/backstage/issues/16155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1698084581","fragment_type":"issue_comment","sequence":10,"text":"On the company that i work now, we divided the implementation on stages...\n\n- 1 Stage (we are on this stage right now BTW):\nTechdocs + Software Catalog + Users + Groups\nWe took 2 teams and they are in-charge to catalog and adding they own entities on a catalog repository.\n\n- 2 Stage:\nExpand from 2 teams to a tribe.\n\n- 3 Stage:\nExpand to all our 6 tribes.\n\n- 4 Stage:\nImplementing software templates, CI-CD, centralize all the solicitations of services on backstage.\n\nFor now. Stage 1 we encounter some issues.\nTh adoption is running really slow, the dev's must clone the backstage service as well the catalog, running both on the machine and fixing entity errors... THEN creating a branch, making a pull request, and other team testing and validating if the PR is ok.\nIn the future all this entities must have some changes, updates etc.. and this process is slow and not that user intuitive even for the dev's.\n\nWill be really nice to have a interface to help with..\n\nI imagine working something like this..\n1 - Developer logging on backstage.\n2 - He have a button to CREATE a entities (user, system, api etc..) OR he can select a existing one and just editing that.\n3 - The interface will be very similar to CREATE or UPDATE a entities.\nwill be nice if this will be a complete interface, with selects for choosing TEAMS, APIS from other entities, like form interface, maybe using the entities APIS to bring existing data of the database, like: \"i'm creating a new API, this api has a part on a System, or consumes other api, is own by the the team\" something like this..\n4 - the dev click on save, then backstage makes sure that the entity is all ok.\n5 - The dev save the changes directly on the YAML file and the database,( or only the database)\n\nOR maybe like this..\n\n1 - Developer logging on backstage.\n2 - He have a button to CREATE a entities (user, system, api etc..) OR he can select a existing one and just editing that.\n3 - Brings him to a online text editor, so he can make the changes, with help of ta intelisense, auto-complete, with all the tools need to facilitate this step.. if the user are Creating a new entities maybe given the option to use a template..\n4 - the dev click on save, then backstage makes sure that the entity is all ok.\n5 - The dev save the changes directly on the YAML file and the database,( or only the database)\n\nOn both cases i saw the permissions like this..\nDevs/TechLeads can edit and create entities of their own SQUAD.\nPrincipalEngineer can edit and create entities of multiple SQUADS from his tribe\nCoordenators can edit and create entities of ALL tribes..\n\nBTW all teams can SEE all the entities from other teams..\n\nThis is how i saw on the company that i work... maybe this will not be 100% to other people on this thread..\n\n(i'm not native to English language so, forgive-me if i wrote something not 100% clear.. )","author_login":"enryson","author_association":"NONE","created_at":"2023-08-29T20:29:57+08:00","repo_name":"backstage/backstage","issue_id":1568411360,"issue_number":16155,"issue_url":"https://github.com/backstage/backstage/issues/16155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1699963584","fragment_type":"issue_comment","sequence":11,"text":"@belech I was inspired by your reference material and built a clone for myself to help learn React. That monaco-yaml library seems to force me into the low-level javascript event listeners and it felt very difficult to use React other than a way to import a component. Did you experience the same?\n\nI dont know if I just lack some React experience, but for the life of me, l just couldnt get Jest to instrument the monaco-yaml editor.\n\nWhat was really interesting about this effort was that I didnt realize monaco is the VSCode engine and that IDEs use language-server-protocols (LSP). So the monaco-yaml shims the YAML LSP built by Red Hat and so I built a rudimentary VSCode web editor for backstage files. Anyways, really cool experience!\n\n@freben, I kind of like this plugin because I can reuse a full json schemastore which works beyond just backstage files. However, if I try to contribute this feature back, do you have any ideas where should it be located? I just threw mine on the left nav bar, but I'm wondering if it should be an optional drop-down where people typically select the github ingestion tool","author_login":"aaronnickovich","author_association":"CONTRIBUTOR","created_at":"2023-08-30T23:01:22+08:00","repo_name":"backstage/backstage","issue_id":1568411360,"issue_number":16155,"issue_url":"https://github.com/backstage/backstage/issues/16155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1700502364","fragment_type":"issue_comment","sequence":12,"text":"That's right.\n \n\nYep, spread them out to where they belong, and leave their management up to their respective owners.\n \n\nI am again a bit confused by the wording \"catalog repo\". :) There should be no catalog repo. You should have catalog-info files spread out all across your version control system, and the catalog (the catalog SERVICE, running in your infrastructure) holds a list of URLs pointing to those files. It updates its internal state all the time, in the background, based on the contents of those files.\n\nIf an end user changes a catalog-info file in their own repo, that's already registered in the catalog backend, there's no more action to take. You don't re-register. A short while later, the updated info will just automatically be reflected in the catalog.","author_login":"freben","author_association":"MEMBER","created_at":"2023-08-31T07:22:26+08:00","repo_name":"backstage/backstage","issue_id":1568411360,"issue_number":16155,"issue_url":"https://github.com/backstage/backstage/issues/16155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1776055922","fragment_type":"issue_comment","sequence":13,"text":"I'm thinking abbot another suggestion..\nWhen we use templates we can put the properties of the entity..\nthen we put the steps on the template.. to create new repo or push a file etc...\n\nI wonder if is a great idea to use the templates as a structure to edit a entity..\nthe way i saw this, the editing page will be similar to the create template..\nthe editing fields will be the same fields as the create.\n(if for some reason the editing has more fields, or some fields are different, this can be solved with dedicated template YAML, OR as a new parameters on the existing template. like \"editing_parameters: \" and \"editing_steps:\")\n\nI know that backstage has a route to return a entity data, so the entity fields that are store on the database are display on this editing page. the UI can be customizable by using the \"editing_parameters:\" on the template..\n\nAfter the user make the changes the entity can be validate and... if everything is right.. this will RUN the \"editing_steps:\"\n\nFor me this make sense, most of the tools to make this backstage have, like: route to validate a entity, steps to push files to a repo, and the UI..\n\nOn my take this is \"basically\" re-create the create page but using different parameters and steps or even a different template.yaml, the KIND and TYPE on the entity will be the key to determine what \"editing template\" to use...\nAnd the steps will be customizable to.. almost the same as the normal template.\n\nthis make sense? \n(English isn't my main language, so feel free to ask something)","author_login":"enryson","author_association":"NONE","created_at":"2023-10-23T21:32:34+08:00","repo_name":"backstage/backstage","issue_id":1568411360,"issue_number":16155,"issue_url":"https://github.com/backstage/backstage/issues/16155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1810681901","fragment_type":"issue_comment","sequence":14,"text":"This is something very useful for me because I'm importing some resource from external sources like rabbit exchanges and queues but these resources doesn't have any additional information like tags or customized field. In this case all my resources goes to same owner, for example. That would be great if we had a tool to edit these components after the importing.","author_login":"brunoscota","author_association":"NONE","created_at":"2023-11-14T16:51:44+08:00","repo_name":"backstage/backstage","issue_id":1568411360,"issue_number":16155,"issue_url":"https://github.com/backstage/backstage/issues/16155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2113384898","fragment_type":"issue_comment","sequence":15,"text":"I have created a plugin which goes into this direction but I'm still testing it internal so consider it alpha.\n URL","author_login":"dweber019","author_association":"CONTRIBUTOR","created_at":"2024-05-15T20:19:12+08:00","repo_name":"backstage/backstage","issue_id":1568411360,"issue_number":16155,"issue_url":"https://github.com/backstage/backstage/issues/16155","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0084","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Correção de Estilização na Página de Horóscopo?","query_context":"Descrição: Esta tarefa foca na construção e implementação do conteúdo da tela do horoscopo do site, utilizando o design já estabelecido como referência. \n\nfigma: URL \ndocumento: heavenly.pdf","known_context_document_ids":["gh_issue_2433955804"],"reference_answer":"Correção de estilo concluída e integrada à branch develop. \nfeature da tarefa: Feature/correcao estilo","answer_document_id":"gh_comment_2263587636","silver_evidence_path":["gh_comment_2263562908","gh_issue_2438482435","gh_comment_2263587636"],"evidence_issue_ids":[2433955804,2438482435],"source_repo_name":"victo-dev-qriarlabs/heavenly","source_issue_id":2433955804,"source_issue_number":27,"source_issue_url":"https://github.com/victo-dev-qriarlabs/heavenly/issues/27","target_repo_name":"victo-dev-qriarlabs/heavenly","target_issue_id":2438482435,"target_issue_number":32,"target_issue_url":"https://github.com/victo-dev-qriarlabs/heavenly/issues/32","reference_anchor_document_id":"gh_comment_2263562908","reference_answer_author":"ProBeta12","reference_answer_author_association":"COLLABORATOR","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.3333,"anchor_target_overlap":0.5,"target_answer_overlap":0.2222},"issue_created_at":"2024-07-28T14:20:42+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_2433955804","fragment_type":"issue_description","sequence":0,"text":"Correção de Estilização na Página de Horóscopo\nDescrição: Esta tarefa foca na construção e implementação do conteúdo da tela do horoscopo do site, utilizando o design já estabelecido como referência. \n\nfigma: URL \ndocumento: heavenly.pdf","author_login":"LayaneBentes","author_association":"COLLABORATOR","created_at":"2024-07-28T14:20:42+08:00","repo_name":"victo-dev-qriarlabs/heavenly","issue_id":2433955804,"issue_number":27,"issue_url":"https://github.com/victo-dev-qriarlabs/heavenly/issues/27","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2258977320","fragment_type":"issue_comment","sequence":1,"text":"@JosielSantos16 Além de criar uma nova página para redirecionamento individual de cada horóscopo de signo a partir da página principal de horóscopo, é necessário corrigir os espaçamentos entre os componentes e ajustar as fontes.","author_login":"ProBeta12","author_association":"COLLABORATOR","created_at":"2024-07-30T18:40:19+08:00","repo_name":"victo-dev-qriarlabs/heavenly","issue_id":2433955804,"issue_number":27,"issue_url":"https://github.com/victo-dev-qriarlabs/heavenly/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2259038816","fragment_type":"issue_comment","sequence":2,"text":"Fiz a implementação dessa tela e das outra e subi os commits, estou esperando a revisao","author_login":"JosielSantos16","author_association":"COLLABORATOR","created_at":"2024-07-30T19:16:20+08:00","repo_name":"victo-dev-qriarlabs/heavenly","issue_id":2433955804,"issue_number":27,"issue_url":"https://github.com/victo-dev-qriarlabs/heavenly/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2263562908","fragment_type":"issue_comment","sequence":3,"text":"@JosielSantos16 a revisão dessa tarefa esta na tarefa de integração #32","author_login":"ProBeta12","author_association":"COLLABORATOR","created_at":"2024-08-01T17:13:46+08:00","repo_name":"victo-dev-qriarlabs/heavenly","issue_id":2433955804,"issue_number":27,"issue_url":"https://github.com/victo-dev-qriarlabs/heavenly/issues/27","linked_issue_ids":[2438482435],"is_known_query_context":false},{"document_id":"gh_issue_2438482435","fragment_type":"issue_description","sequence":0,"text":"Correção de Estilização\nDescrição: Esta tarefa envolve a revisão e ajuste dos estilos das páginas existentes para corrigir erros de estilização, melhorar o layout e garantir uma apresentação visual consistente. As subtarefas incluem:\n\n1. Correção de Espaçamentos:\n\n - Ajustar o espaçamento entre e ao redor dos componentes para garantir uma distribuição equilibrada e evitar que os elementos fiquem muito próximos das bordas ou entre si.\n\n1. Ajuste de Estilos:\n\n - Modificar propriedades de CSS, como cores, fontes, tamanhos de texto e margens, para corrigir problemas visuais e garantir uma aparência uniforme em todas as páginas.\n\n1. Verificação de Responsividade:\n\n - Garantir que as páginas estejam visualmente corretas e funcionais em diferentes tamanhos de tela, incluindo dispositivos móveis e desktops.\n\n1. Correção de Outros Erros Visuais:\n\n - Identificar e resolver quaisquer problemas visuais adicionais que possam surgir nas telas de horóscopo, constelação e dúvidas comuns.\n\nsegue as subtarefas:\n\n- [ ] #27 \n- [ ] #28 \n- [ ] #29","author_login":"ProBeta12","author_association":"COLLABORATOR","created_at":"2024-07-30T18:58:18+08:00","repo_name":"victo-dev-qriarlabs/heavenly","issue_id":2438482435,"issue_number":32,"issue_url":"https://github.com/victo-dev-qriarlabs/heavenly/issues/32","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2263558209","fragment_type":"issue_comment","sequence":1,"text":"@JosielSantos16 Revisei os o código puxando para meu ambiente dev, esta muito bom as correções. Um ponto de atenção seria colocar mais detalhes de onde foi corrigido na tarefa, tipo imagens mostrando a correção e o erro de estilização referentes a cada pagina corrigida.","author_login":"ProBeta12","author_association":"COLLABORATOR","created_at":"2024-08-01T17:11:57+08:00","repo_name":"victo-dev-qriarlabs/heavenly","issue_id":2438482435,"issue_number":32,"issue_url":"https://github.com/victo-dev-qriarlabs/heavenly/issues/32","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2263587636","fragment_type":"issue_comment","sequence":2,"text":"Correção de estilo concluída e integrada à branch develop. \nfeature da tarefa: Feature/correcao estilo","author_login":"ProBeta12","author_association":"COLLABORATOR","created_at":"2024-08-01T17:27:01+08:00","repo_name":"victo-dev-qriarlabs/heavenly","issue_id":2438482435,"issue_number":32,"issue_url":"https://github.com/victo-dev-qriarlabs/heavenly/issues/32","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0095","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Tighten the definition of \"column\"?","query_context":"The source map spec doesn't describe the units for columns -- just that they are zero-based. It turns out that Gecko uses UTF-16 code points, and that seems to be a common, but not universal, choice. It would improve the spec if it were explicit about the units.","known_context_document_ids":["gh_issue_255951179"],"reference_answer":"I left a comment now on the tc39 proposal. I hope for now that Firefox reverts this behavior but the issue is known from our side. Since not all Firefox versions agree on the offset it's unfortunately a pretty frustrating situation right now that we do not want to try to make too many guesses about.","answer_document_id":"gh_comment_1134703895","silver_evidence_path":["gh_comment_1499111388","gh_issue_1094187909","gh_comment_1134703895"],"evidence_issue_ids":[255951179,1094187909],"source_repo_name":"tc39/source-map-rfc","source_issue_id":255951179,"source_issue_number":5,"source_issue_url":"https://github.com/tc39/source-map-rfc/issues/5","target_repo_name":"getsentry/rust-sourcemap","target_issue_id":1094187909,"target_issue_number":37,"target_issue_url":"https://github.com/getsentry/rust-sourcemap/issues/37","reference_anchor_document_id":"gh_comment_1499111388","reference_answer_author":"mitsuhiko","reference_answer_author_association":"MEMBER","quality_score":86.33,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":false,"anchor_query_overlap":0.0417,"anchor_target_overlap":0.1667,"target_answer_overlap":0.1724},"issue_created_at":"2017-09-07T14:12:08+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_255951179","fragment_type":"issue_description","sequence":0,"text":"Tighten the definition of \"column\"\nThe source map spec doesn't describe the units for columns -- just that they are zero-based. It turns out that Gecko uses UTF-16 code points, and that seems to be a common, but not universal, choice. It would improve the spec if it were explicit about the units.","author_login":"tromey","author_association":"NONE","created_at":"2017-09-07T14:12:08+08:00","repo_name":"tc39/source-map-rfc","issue_id":255951179,"issue_number":5,"issue_url":"https://github.com/tc39/source-map-rfc/issues/5","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1499111388","fragment_type":"issue_comment","sequence":1,"text":"I would like to revisit this. Firefox today is the only engine that does not use UTF-16 codepoints and apparently switched at one point at random. I would propose to once and for all specify this to mean UTF-16 as this matches what _most_ tools today assume.\n\n* URL \n* URL","author_login":"mitsuhiko","author_association":"NONE","created_at":"2023-04-06T14:00:24+08:00","repo_name":"tc39/source-map-rfc","issue_id":255951179,"issue_number":5,"issue_url":"https://github.com/tc39/source-map-rfc/issues/5","linked_issue_ids":[1094187909],"is_known_query_context":false},{"document_id":"gh_comment_1538000188","fragment_type":"issue_comment","sequence":2,"text":"So here are some of my findings. Take this file:\n\nhtml\n \n \n Column Test \n \nfunction fail() {\n throw new Error();\n}\n\nfunction logColumn(c, e) {\n const lines = e.stack.split(/\\r?\\n/g);\n if (lines[0] === 'Error') {\n lines.shift();\n }\n console.log(c, parseInt(lines[1].match(/:\\d+:(\\d+)/)[1]));\n}\n\ntry {\n /* xxxxx */fail();\n} catch (e) {\n logColumn(\"x\", e);\n}\ntry {\n /* ☃️☃️☃️☃️☃️ */fail();\n} catch (e) {\n logColumn(\"☃️\", e);\n}\ntry {\n /* 🔥🔥🔥🔥🔥 */fail();\n} catch (e) {\n logColumn(\"🔥\", e);\n}\ntry {\n /* 👩‍👩‍👧👩‍👩‍👧👩‍👩‍👧👩‍👩‍👧👩‍👩‍👧 */fail()();\n} catch (e) {\n logColumn(\"👩‍👩‍👧\", e);\n}\n \n\nThe calculated offsets of the `throw` keyword are the following (utf-8 offset, utf-16 offset, unicode character offset):\n\n/* xxxxx */: 14/14/14\n/* ☃️☃️☃️☃️☃️ */: 39/19/19\n/* 🔥🔥🔥🔥🔥 */: 29/19/14\n/* 👩‍👩‍👧👩‍👩‍👧👩‍👩‍👧👩‍👩‍👧👩‍👩‍👧 */: 99/49/34\n\nWhat browsers report:\n\n**Safari:**\n* x – 18\n* ☃️ – 23\n* 🔥 – 23\n* 👩‍👩‍👧 – 53\n\n**Firefox:**\n* x 14\n* ☃️ 19\n* 🔥 14\n* 👩‍👩‍👧 34\n\n**Chrome:**\n* x 14\n* ☃️ 19\n* 🔥 19\n* 👩‍👩‍👧 49\n\n**Edge:**\n* x 14\n* ☃️ 19\n* 🔥 19\n* 👩‍👩‍👧 49\n\n**Node:**\n\n* x 14\n* ☃️ 19\n* 🔥 19\n* 👩‍👩‍👧 49","author_login":"mitsuhiko","author_association":"CONTRIBUTOR","created_at":"2023-05-08T08:54:08+08:00","repo_name":"tc39/source-map-rfc","issue_id":255951179,"issue_number":5,"issue_url":"https://github.com/tc39/source-map-rfc/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1538453323","fragment_type":"issue_comment","sequence":3,"text":"Really nice data and +1 for the set of test cases! Since Chrome/Edge/Node/Deno are all V8 under the hood, their consistent behavior is expected. I'm pretty sure the JS engines populate this property without involvement (by default) from embedding runtimes/browsers. It's really:\n\n* V8 (UTF-16)\n* JavaScriptCore (UTF-16 + \"what's a call site\" 4)\n* Spidermonkey (UTF-32)\n\nSo no two engines actually agree in this case, although V8 and JavaScriptCore disagree on something not related to column offset calculations.\n\nBtw, I'm not sure if it's still maintained but eshost-cli could be a nice way of running these test cases across runtimes: URL If nothing else, the page with Supported Hosts is a nice potential checklist.","author_login":"jkrems","author_association":"MEMBER","created_at":"2023-05-08T14:25:37+08:00","repo_name":"tc39/source-map-rfc","issue_id":255951179,"issue_number":5,"issue_url":"https://github.com/tc39/source-map-rfc/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1539968730","fragment_type":"issue_comment","sequence":4,"text":"Given that this is mostly determined by browsers I will skip evaluating what the generators currently output. From my experience at processing a lot of source maps at Sentry, the general consensus is pretty strong for it to be counted in UTF-16 offsets.","author_login":"mitsuhiko","author_association":"CONTRIBUTOR","created_at":"2023-05-09T11:05:35+08:00","repo_name":"tc39/source-map-rfc","issue_id":255951179,"issue_number":5,"issue_url":"https://github.com/tc39/source-map-rfc/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1540033706","fragment_type":"issue_comment","sequence":5,"text":"If someone is available to volunteer, it'd be great to see this analysis of generators. The goal is to get in the habit of testing sourcemap generators anyway, so we can file bugs against them and get everyone aligned. Also this is something of an edge case, so I wouldn't be shocked to see someone who we should already file a bug against (as soon as we agree on the definition)--so this testing should be directly useful for that.","author_login":"littledan","author_association":"CONTRIBUTOR","created_at":"2023-05-09T12:32:33+08:00","repo_name":"tc39/source-map-rfc","issue_id":255951179,"issue_number":5,"issue_url":"https://github.com/tc39/source-map-rfc/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1556856110","fragment_type":"issue_comment","sequence":6,"text":"I tried but I have not found a place in the browsers where columns are displayed for CSS source maps, thus I was unable to determine based on observation in the browser how columns are handled. However libsass produces UTF-16 columns:\n\n**foo.scss**\n\ncss\nbody {\n /*🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥*/background:/*🔥*/red;\n /*🔥🔥🔥*/color:/*🔥*/blue;\n}\n\n**foo.css**\n\ncss\nbody{background:red;color:blue}/*# sourceMappingURL=foo.css.map */\n\n**foo.css.map**\n\njson\n{\"version\":3,\"sourceRoot\":\"\",\"sources\":[\"foo.scss\"],\"names\":[],\"mappings\":\"AAAA,KAC8B,eAClB\",\"file\":\"foo.css\"}%\n\nDecoded:\n\n 0:0 -> foo.scss:0:0\n 0:5 -> foo.scss:1:30\n 0:20 -> foo.scss:2:12\n\nIf you look at the tokens referenced:\n\n1:30 -> background:/*🔥*/red;\n2:12 -> color:/*🔥*/blue;","author_login":"mitsuhiko","author_association":"CONTRIBUTOR","created_at":"2023-05-22T09:16:05+08:00","repo_name":"tc39/source-map-rfc","issue_id":255951179,"issue_number":5,"issue_url":"https://github.com/tc39/source-map-rfc/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1563665887","fragment_type":"issue_comment","sequence":7,"text":"It's possible you could do it in Firefox by having CSS that uses non-base-plane characters and then provokes a warning later on the same line. Then, look at the warning in the console. IIRC (it's been a while) the devtools will apply source maps in this case.","author_login":"tromey","author_association":"NONE","created_at":"2023-05-26T00:37:02+08:00","repo_name":"tc39/source-map-rfc","issue_id":255951179,"issue_number":5,"issue_url":"https://github.com/tc39/source-map-rfc/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1564188531","fragment_type":"issue_comment","sequence":8,"text":"To drive this discussion forward, here is my proposal of what should be added to the spec:","author_login":"mitsuhiko","author_association":"CONTRIBUTOR","created_at":"2023-05-26T10:38:42+08:00","repo_name":"tc39/source-map-rfc","issue_id":255951179,"issue_number":5,"issue_url":"https://github.com/tc39/source-map-rfc/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1651515429","fragment_type":"issue_comment","sequence":9,"text":"Yes. I consider this closed. We can follow up on other formats if the need arises.","author_login":"mitsuhiko","author_association":"CONTRIBUTOR","created_at":"2023-07-26T10:32:51+08:00","repo_name":"tc39/source-map-rfc","issue_id":255951179,"issue_number":5,"issue_url":"https://github.com/tc39/source-map-rfc/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1652075709","fragment_type":"issue_comment","sequence":10,"text":"I think we were still waiting to hear back from some folks about WASM? I'm happy to close this an open a separate ticket for that since the above PR has been merged.","author_login":"jkup","author_association":"NONE","created_at":"2023-07-26T15:42:50+08:00","repo_name":"tc39/source-map-rfc","issue_id":255951179,"issue_number":5,"issue_url":"https://github.com/tc39/source-map-rfc/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1652213701","fragment_type":"issue_comment","sequence":11,"text":"The PR for the wasm columns definition: tc39/source-map-spec#14","author_login":"JSMonk","author_association":"NONE","created_at":"2023-07-26T17:20:06+08:00","repo_name":"tc39/source-map-rfc","issue_id":255951179,"issue_number":5,"issue_url":"https://github.com/tc39/source-map-rfc/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1094187909","fragment_type":"issue_description","sequence":0,"text":"Sourcemap locations may be resolved incorrectly in Firefox\nPlease consider this issue an FYI for other Sentry users as much as anything else, since I think the fix will happen in Firefox.\n\nWe recently ran into a problem where JavaScript crash reports from Firefox were resolved to the wrong location in the original code. The issue turned out to be that Firefox expresses column numbers in stack traces differently than other browsers. Chrome and Safari report the column number in UTF-16 code units, whereas Firefox reports them in Unicode code points. From what I can tell, this package assumes UTF-16 code units. If a minified source bundle contains many characters (eg. emojis) that require multiple UTF-16 characters to encode, this can result in incorrectly resolved source locations when processing crash reports in Firefox.\n\nI filed an issue at URL and URL to try to find an upstream resolution.","author_login":"robertknight","author_association":"NONE","created_at":"2022-01-05T10:12:36+08:00","repo_name":"getsentry/rust-sourcemap","issue_id":1094187909,"issue_number":37,"issue_url":"https://github.com/getsentry/rust-sourcemap/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1134703895","fragment_type":"issue_comment","sequence":1,"text":"I left a comment now on the tc39 proposal. I hope for now that Firefox reverts this behavior but the issue is known from our side. Since not all Firefox versions agree on the offset it's unfortunately a pretty frustrating situation right now that we do not want to try to make too many guesses about.","author_login":"mitsuhiko","author_association":"MEMBER","created_at":"2022-05-23T13:49:01+08:00","repo_name":"getsentry/rust-sourcemap","issue_id":1094187909,"issue_number":37,"issue_url":"https://github.com/getsentry/rust-sourcemap/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2531312315","fragment_type":"issue_comment","sequence":2,"text":"Seems like this is already fixed, feel free to reopen if that is not the case.","author_login":"tobias-wilfert","author_association":"MEMBER","created_at":"2024-12-10T11:32:13+08:00","repo_name":"getsentry/rust-sourcemap","issue_id":1094187909,"issue_number":37,"issue_url":"https://github.com/getsentry/rust-sourcemap/issues/37","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0096","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Create a preprocessing step to use defaults, validate input data, and calculate flow partitions?","query_context":"### Description\n\nAs in the Tulipa-OBZ-CaseStudy, we start with the bare minimum input data and then move on to the tables we need to create the model. Having these steps inside Tulipa will help improve the users' experience and avoid data that generates incorrect constraints (e.g., the flow partitions must be inferred from the asset partitions).\n\n### Sub issues\n\n- [ ] Create the minimum input data (mandatory) files/tables an user must provide\n- [ ] Create a validation function to check #461 \n- [x] #1129\n- [ ] #1052","known_context_document_ids":["gh_issue_2909350286"],"reference_answer":"Here's a version of the 1st one, the user workflow. It includes functions that don't exist, and I haven't followed the current situation of the workflow, but it should be enough to evaluate the solution.\nTulipa User Workflow-2.pdf","answer_document_id":"gh_comment_2734444189","silver_evidence_path":["gh_comment_2740565600","gh_issue_2086214232","gh_comment_2734444189"],"evidence_issue_ids":[2909350286,2086214232],"source_repo_name":"TulipaEnergy/TulipaEnergyModel.jl","source_issue_id":2909350286,"source_issue_number":1081,"source_issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/1081","target_repo_name":"TulipaEnergy/TulipaEnergyModel.jl","target_issue_id":2086214232,"target_issue_number":415,"target_issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","reference_anchor_document_id":"gh_comment_2740565600","reference_answer_author":"abelsiqueira","reference_answer_author_association":"MEMBER","quality_score":93.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0625,"anchor_target_overlap":0.25,"target_answer_overlap":0.1667},"issue_created_at":"2025-03-11T06:53:31+08:00","valid_comment_count":23,"fragments":[{"document_id":"gh_issue_2909350286","fragment_type":"issue_description","sequence":0,"text":"Create a preprocessing step to use defaults, validate input data, and calculate flow partitions\n### Description\n\nAs in the Tulipa-OBZ-CaseStudy, we start with the bare minimum input data and then move on to the tables we need to create the model. Having these steps inside Tulipa will help improve the users' experience and avoid data that generates incorrect constraints (e.g., the flow partitions must be inferred from the asset partitions).\n\n### Sub issues\n\n- [ ] Create the minimum input data (mandatory) files/tables an user must provide\n- [ ] Create a validation function to check #461 \n- [x] #1129\n- [ ] #1052","author_login":"datejada","author_association":"NONE","created_at":"2025-03-11T06:53:31+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2909350286,"issue_number":1081,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/1081","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2712880127","fragment_type":"issue_comment","sequence":1,"text":"@abelsiqueira This is the issue we commented on in yesterday's meeting. Please add/change according to what you also consider needed here. There are new functions in TulipaIO that can be used for the preprocessing step.\n\n@clizbe I think this will be nice to have before TLC starts, but if not, we can still work with the model as it is. Please also add/change as you consider in this issue.","author_login":"datejada","author_association":"MEMBER","created_at":"2025-03-11T06:57:59+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2909350286,"issue_number":1081,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/1081","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2714664853","fragment_type":"issue_comment","sequence":2,"text":"Hi @datejada, I'm not sure about the other bullet points. But I will work on creating the data validation #461 skeleton. Perhaps the flow partition inference can be part of that, but that could be a separate step as well. Please tag me when you define how the inference will work and I'll try to see where it fits","author_login":"abelsiqueira","author_association":"MEMBER","created_at":"2025-03-11T15:00:40+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2909350286,"issue_number":1081,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/1081","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2715589457","fragment_type":"issue_comment","sequence":3,"text":"I'll try to pick up the flow partitions since it sounds fun and I know there's already a version in OBZ. ;)","author_login":"clizbe","author_association":"MEMBER","created_at":"2025-03-11T20:07:30+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2909350286,"issue_number":1081,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/1081","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2730126864","fragment_type":"issue_comment","sequence":4,"text":"I believe it's for the User Format. And the Model Format will either fill the defaults or leave things blank if unused. 🤔","author_login":"clizbe","author_association":"MEMBER","created_at":"2025-03-17T16:23:09+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2909350286,"issue_number":1081,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/1081","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2735628594","fragment_type":"issue_comment","sequence":5,"text":"@abelsiqueira and @clizbe The more I explain the model to people/users, the more it feels better to have files/tables with the bare minimum data (i.e., the primary keys of the tables) + some values to run the model and then fill the non-specified data with the defaults that we defined in the JSON (third point in the list) to create the Tulipa tables.\n\nOne first step is to have the same file schema but fill in the non-mandatory data that has not been specified with the defaults defined in the JSON. That would already remove many data from users to fill in (and even from our example files).\n\nA second step would be to decide whether these files are closer to the current User Files in the OBZ. That can be later based on the feedback we get in the TLC.","author_login":"datejada","author_association":"MEMBER","created_at":"2025-03-19T07:50:08+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2909350286,"issue_number":1081,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/1081","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2740565600","fragment_type":"issue_comment","sequence":6,"text":"I think we need to sit together to review the workflow and align this point. It also affects #415, and defines where this code will live and how TulipaIO and TulipaClustering interact TEM.","author_login":"abelsiqueira","author_association":"MEMBER","created_at":"2025-03-20T14:02:04+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2909350286,"issue_number":1081,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/1081","linked_issue_ids":[2086214232],"is_known_query_context":false},{"document_id":"gh_issue_2086214232","fragment_type":"issue_description","sequence":0,"text":"Create a diagram of the workflow\nCreate a diagram to help describe all steps and inputs of the workflow.\n\n#### Related Issues:\n#414 \n\n---\n\nLast update: 27/06/2024\n\nI've split the diagram into two parts. One for the pipeline and one for the DBs. They are both still WIP, and the DBs are mostly just showing the keys.\n\n## High level overview of compact usage\n\nmermaid\ngraph\n classDef db fill:#aaa,color:black,stroke:black,stroke-width:1px;\n classDef cls_tem fill:#0af,color:black;\n classDef cls_tio fill:#fc0,color:black;\n classDef cls_tc fill:#0f0,color:black;\n\n source[\"Some source (e.g. ESDL + EDR, CSV folder)\"]:::db\n\n %% DBs/DataFrames\n initial_data[(Initial data)]:::db\n clustering_data[(Clustering data)]:::db\n \n %% Connections\n source --> TIO.read_csv_folder:::cls_tio\n --> initial_data\n --> TC.split_into_periods:::cls_tc\n --> TC.find_representative_periods:::cls_tc\n --> TC.write_clustering_results_to_tables:::cls_tc\n --> clustering_data\n --> TEM.EnergyProblem:::cls_tem\n --> TEM.create_model!:::cls_tem\n --> TEM.solve_model!:::cls_tem\n\nmermaid\ngraph\n classDef db fill:#222,color:white,stroke:white,stroke-width:1px;\n classDef object fill:#09f,color:black;\n classDef cls_tem fill:#3d3,color:black;\n classDef cls_tio fill:#77f,color:black;\n classDef cls_tc fill:#77f,color:black;\n classDef undefined fill:#f33,color:black;\n\n source[\"Some source (e.g. ESDL + EDR, CSV folder)\"]\n scenario[\"Scenario specification ?\"]:::undefined\n\n %% Actions and packages\n TIO(\"TulipaIO\"):::cls_tio\n TEM(\"TulipaEnergyModel\"):::cls_tem\n TC(\"TulipaClustering\"):::cls_tc\n TP(\"Partitioner\"):::undefined\n create_input_dataframes(\"create_input_dataframes\"):::cls_tem\n create_internal_structures(\"create_internal_structures\"):::cls_tem\n compute_constraints_partitions(\"compute_constraints_partitions\"):::cls_tem\n create_model(\"create_model\"):::cls_tem\n solve_model(solve_model):::cls_tem\n construct_dataframes(construct_dataframes):::cls_tem\n \n %% Objects\n con{{DB connection}}:::object\n table_tree{{table_tree}}:::object\n _graph{{graph}}:::object\n rps{{representative_periods}}:::object\n timeframe{{timeframe}}:::object\n cps{{constraints_partitions}}:::object\n dfs{{dataframes}}:::object\n model{{model}}:::object\n solution{{solution}}:::object\n\n %% DBs/DataFrames\n static_data[(Graph Data)]:::db\n raw_profiles_data[(Raw Profiles Data)]:::db\n cluster_data[(RP & Timeframe Cluster Data)]:::db\n clustered_profiles_data[(Clustered Profiles Data)]:::db\n partition_data[(Partitioned Data)]:::db\n \n %% Connections\n source --> TIO\n --> static_data & raw_profiles_data\n --> TC\n --> cluster_data & clustered_profiles_data\n scenario --> TP\n --> partition_data\n TIO --> con\n static_data & raw_profiles_data & cluster_data & clustered_profiles_data & partition_data --> create_input_dataframes\n --> table_tree\n --> create_internal_structures\n --> _graph & rps & timeframe\n _graph & rps --> compute_constraints_partitions\n --> cps\n _graph & rps & cps & timeframe --> construct_dataframes\n --> dfs\n _graph & rps & dfs & timeframe --> create_model\n --> model\n --> solve_model\n --> solution\n\nThe DB diagram is not automatically generated, here is a snapshot, the code is below.\n\nTulipaDB\n\ndbml\n// Use DBML to define your database structure\n// Docs: URL \n\n// Types are limited to what is provided by SQL\nTable Asset {\n asset string [primary key]\n extra_stuff unknown\n}\n\nTable Flow {\n from_asset string [primary key, ref: > Asset.asset]\n to_asset string [primary key, ref: > Asset.asset]\n extra_stuff unknown\n}\n\nTable Profile {\n profile_name string [primary key]\n timestep int [primary key]\n value float\n}\n\nTable AssetProfileReference {\n asset string [primary key, ref: > Asset.asset]\n profile_type string [primary key]\n profile_name string [ref: > Profile.profile_name]\n}\n\nTable FlowProfileReference {\n from_asset string [primary key, ref: > Flow.from_asset]\n to_asset string [primary key, ref: > Flow.to_asset]\n profile_type string [primary key]\n profile_name string [ref: > Profile.profile_name]\n}\n\n// --------- \n// All DB above are used by Clustering. Everything below is Model specific\n// --------- \n\nTable RepPeriod {\n rep_period int [primary key]\n num_timesteps int\n resolution float\n}\n\nTable TimeframePeriod {\n period int [primary key]\n rep_period int [primary key, ref: > RepPeriod.rep_period]\n weight float\n}\n\nTable RepPeriodProfile {\n profile_name string [primary key, ref: > Profile.profile_name]\n rep_period int [primary key, ref: > RepPeriod.rep_period]\n profile_type string\n value float\n}\n\nTable TimeframeProfile {\n profile_name string [primary key]\n timestep int [primary key, ref: > TimeframePeriod.period]\n value float\n}\n\nTable AssetTimeframeProfileReference {\n asset string [primary key, ref: > Asset.asset]\n profile_name string [primary key, ref: > TimeframeProfile.profile_name]\n}\n\nTable AssetRepPeriodPartition {\n asset string [primary key, ref: > Asset.asset]\n rep_period int [primary key, ref: > RepPeriod.rep_period]\n specification enum\n partition string\n}\n\nTable FlowRepPeriodPartition {\n from_asset string [primary key, ref: > Flow.from_asset]\n to_asset string [primary key, ref: > Flow.to_asset]\n rep_period int [primary key, ref: > RepPeriod.rep_period]\n specification enum\n partition string\n}\n\nTable AssetTimeframePartition {\n asset string [primary key, ref: > Asset.asset]\n specification enum\n partition string\n}","author_login":"abelsiqueira","author_association":"MEMBER","created_at":"2024-01-17T13:38:02+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2086214232,"issue_number":415,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1898136886","fragment_type":"issue_comment","sequence":1,"text":"Is it normal that I have a \"Unable to render rich display\" error?","author_login":"clizbe","author_association":"MEMBER","created_at":"2024-01-18T09:46:49+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2086214232,"issue_number":415,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1945640386","fragment_type":"issue_comment","sequence":2,"text":"@abelsiqueira @suvayu Maybe this is a good candidate for a wiki? 🙃","author_login":"clizbe","author_association":"MEMBER","created_at":"2024-02-15T08:59:15+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2086214232,"issue_number":415,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1945682625","fragment_type":"issue_comment","sequence":3,"text":"Have we decided what use we'll be moving to the wiki? We have 6 places for prose right now:\n\n- README.md\n- README.dev.md\n- CONTRIBUTING\n- Docs = Website\n- Issues\n- Discussions\n\nSo it might be useful to redefine some things to give use to the wiki. Also, it is a good time to bring up URL since it relates to documentation and purpose.","author_login":"abelsiqueira","author_association":"MEMBER","created_at":"2024-02-15T09:25:26+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2086214232,"issue_number":415,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952178098","fragment_type":"issue_comment","sequence":4,"text":"Diataxis was a great read!\nI agree we're spreading out a bit, but this is something that doesn't seem to really belong in an issue... Maybe it can go into the docs? Right now it's pretty dev-related, but eventually might be useful to the user.","author_login":"clizbe","author_association":"MEMBER","created_at":"2024-02-19T10:45:00+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2086214232,"issue_number":415,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2047447420","fragment_type":"issue_comment","sequence":5,"text":"@abelsiqueira Is there a way we can have this generate with code? That way we can put it in the docs without screenshotting it and keep it updated in the future (maybe add it to our PR checklist?)","author_login":"clizbe","author_association":"MEMBER","created_at":"2024-04-10T12:45:55+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2086214232,"issue_number":415,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2047466152","fragment_type":"issue_comment","sequence":6,"text":"Thinking like an engineer @clizbe ;⁠-⁠)\n\nWe could explore using `Mermaid.js`. It's supported by GitHub. You can experiment @ URL","author_login":"suvayu","author_association":"MEMBER","created_at":"2024-04-10T12:54:45+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2086214232,"issue_number":415,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2056280955","fragment_type":"issue_comment","sequence":7,"text":"Great! Let's use that. It'll probably take some work for the first version but updating after that shouldn't be bad.","author_login":"clizbe","author_association":"MEMBER","created_at":"2024-04-15T08:54:13+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2086214232,"issue_number":415,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2728784264","fragment_type":"issue_comment","sequence":8,"text":"For my purposes (figuring out what to implement in the refactor), I eventually moved to Miro and abandoned this. \n\nHowever, it might be useful to have a visual explanation of how things work to some groups. Either for users or developers.\n@clizbe @datejada @gnawin @suvayu , do you see any diagram that would be useful to have?\n\n- For new users, it might be useful to have an overview of things, but not an overwhelming amount of info. Maybe the left side of the Miro board is enough?\n- For devs, it might be useful to have an overview of the functions or structures being created. But since there is no way to automate this, as far as I know, it might be quickly obsolete if we go into too much detail. It there a level of usefulness? (This was the one I was trying to make to drive the refactor)\n- A complete list of all the input tables should be useful for intermediate users. At least for the TEM side, this is part of the schema. What would be the useful thing that you want to extract from this?\n- A list of tables created within TEM might be useful for developers, which is the (possibly outdated) info in the Miro board. What would be the useful thing that you want to extract from this?","author_login":"abelsiqueira","author_association":"MEMBER","created_at":"2025-03-17T09:33:48+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2086214232,"issue_number":415,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2729911184","fragment_type":"issue_comment","sequence":9,"text":"I think we should have two overviews:\n1. The workflow for the user: \n - Raw to Processing options, Where TC comes in, Where does DuckDB come in, User vs Model schema if we have both... Similar to what's above but some more processing options/details.\n - This could be a Mermaid thing or basically just a ppt slide\n - GOAL: Easy overview of the workflow without reading any code or opening a notebook.\n2. The BASIC structure of the code. \n - This might just be the dev docs of how to add a constraint, or maybe a breakdown of the main files and how they relate to each other. Or maybe it's just TulipaEnergyModel.jl?\n - GOAL: Help new devs understand the flow of the code.","author_login":"clizbe","author_association":"MEMBER","created_at":"2025-03-17T15:14:51+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2086214232,"issue_number":415,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2733754125","fragment_type":"issue_comment","sequence":10,"text":"I'll work on a PR for these, but do you want them?\n\n- Maybe 1. go to `docs/src/10-how-to-use.md`, in an overview at the beginning?\n- Probably 2. should go to `docs/src/91-developer.md`, do you have a different suggestion?","author_login":"abelsiqueira","author_association":"MEMBER","created_at":"2025-03-18T15:46:59+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2086214232,"issue_number":415,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2734194906","fragment_type":"issue_comment","sequence":11,"text":"For 1, I think maybe the Beginner Tutorials would be better... Although it is kind of a technical reference... 🤔\nThe idea with the docs flow for new users is they click on Getting Started (install), which sends them to Beginner Tutorials, and later they read the How-Tos. The How-Tos even has a note that says it expects they've already followed the Beginner Tutorials.","author_login":"clizbe","author_association":"MEMBER","created_at":"2025-03-18T17:46:47+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2086214232,"issue_number":415,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2734200509","fragment_type":"issue_comment","sequence":12,"text":"But yeah How-To definitely makes more sense. I think put it there and we can reference it from wherever.","author_login":"clizbe","author_association":"MEMBER","created_at":"2025-03-18T17:48:07+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2086214232,"issue_number":415,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2734245759","fragment_type":"issue_comment","sequence":13,"text":"I created the following for the 2nd point. What do you think? I also sent in the internal teams chat so others can comment.\nTulipaEnergyModel overview.pdf","author_login":"abelsiqueira","author_association":"MEMBER","created_at":"2025-03-18T17:59:48+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2086214232,"issue_number":415,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2734307637","fragment_type":"issue_comment","sequence":14,"text":"I think it's a good start for the guts of the model. But I was thinking even more zoomed out.\nBasically:\nRaw -> User Format -> Conversion -> Model Format -> TEM (maybe with these details, maybe include that it uses DuckDB for its storage) -> Solution (in Julia or DuckDB?) -> Manipulation (optional) -> Export -> More manipulation (optional) -> Graphs\n\nAnd we can add details, but just to have the roadmap of what they're doing and where the tools come in.\nOtherwise they might get confused on what each tool (TIO, TEM, DDB, etc) is for and what's happening.","author_login":"clizbe","author_association":"MEMBER","created_at":"2025-03-18T18:17:44+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2086214232,"issue_number":415,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2734308410","fragment_type":"issue_comment","sequence":15,"text":"I created it using Canva, after struggling to try to make 10% in 10x more time in Mermaid.\n\nThis raises the issue of which solution to use, code-based or gui-based. Here are some points:\n\n- Code-based (Mermaid.js, GraphViz, TikZ, explicit plotting).\n Pros:\n - These should be better for incorporating in a (semi-)automated build script of the documentation.\n - It should be possible to ensure that it never gets outdated (but it is a lot of work).\n \n Cons:\n - It is hard to make them look nice. Sometimes impossible.\n - Any automation will require maintenance.\n- GUI-based (Canva, Miro, app.diagrams.net, paint, etc.)\n Pros:\n - It is much easier to use, and therefore much easier to (re)create.\n - They look much nicer.\n\n Cons:\n - Reproducibility is an issue because there is no code, so modifications. are harder.\n - If using a service, it requires account management and sharing.\n\nMy recommendation would be GUI-based because it is the best tool for the job. Even the static code-based solution takes many hours to do half as right.","author_login":"abelsiqueira","author_association":"MEMBER","created_at":"2025-03-18T18:18:06+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2086214232,"issue_number":415,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2734444189","fragment_type":"issue_comment","sequence":16,"text":"Here's a version of the 1st one, the user workflow. It includes functions that don't exist, and I haven't followed the current situation of the workflow, but it should be enough to evaluate the solution.\nTulipa User Workflow-2.pdf","author_login":"abelsiqueira","author_association":"MEMBER","created_at":"2025-03-18T19:09:36+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2086214232,"issue_number":415,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2757198937","fragment_type":"issue_comment","sequence":17,"text":"The method you're using looks great! :) Sounds like code is too much of a pain in this case.","author_login":"clizbe","author_association":"MEMBER","created_at":"2025-03-27T08:40:41+08:00","repo_name":"TulipaEnergy/TulipaEnergyModel.jl","issue_id":2086214232,"issue_number":415,"issue_url":"https://github.com/TulipaEnergy/TulipaEnergyModel.jl/issues/415","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0104","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Unify tagging for mirroring and release stages?","query_context":"Related to URL \n\nCurrently both mirroring and release stage are tagging the same build commit with the same tag and pushing it to a remote (mirroring to `dotnet-security-partners/dotnet`, release to the public `VMR`). They are also using two different scripts to achieve this.\n\nWe should unify this step under one logic to guarantee that we don't accidently change only one of them in the future, resulting in a miss-match between what we published publicly versus what we handed off to partners.\n\nWe could utilize the Release CLI for this by just adding a single command and using it in both stages.","known_context_document_ids":["gh_issue_1994455778"],"reference_answer":"[Triage] Closing as a duplicate of URL Even though this issue was logged first, URL has more detail.","answer_document_id":"gh_comment_2127600905","silver_evidence_path":["gh_comment_2037259445","gh_issue_2134531067","gh_comment_2127600905"],"evidence_issue_ids":[1994455778,2134531067],"source_repo_name":"dotnet/source-build","source_issue_id":1994455778,"source_issue_number":3736,"source_issue_url":"https://github.com/dotnet/source-build/issues/3736","target_repo_name":"dotnet/source-build","target_issue_id":2134531067,"target_issue_number":4131,"target_issue_url":"https://github.com/dotnet/source-build/issues/4131","reference_anchor_document_id":"gh_comment_2037259445","reference_answer_author":"MichaelSimons","reference_answer_author_association":"MEMBER","quality_score":91.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.1875,"target_answer_overlap":0.0},"issue_created_at":"2023-11-15T10:09:05+08:00","valid_comment_count":4,"fragments":[{"document_id":"gh_issue_1994455778","fragment_type":"issue_description","sequence":0,"text":"Unify tagging for mirroring and release stages\nRelated to URL \n\nCurrently both mirroring and release stage are tagging the same build commit with the same tag and pushing it to a remote (mirroring to `dotnet-security-partners/dotnet`, release to the public `VMR`). They are also using two different scripts to achieve this.\n\nWe should unify this step under one logic to guarantee that we don't accidently change only one of them in the future, resulting in a miss-match between what we published publicly versus what we handed off to partners.\n\nWe could utilize the Release CLI for this by just adding a single command and using it in both stages.","author_login":"oleksandr-didyk","author_association":"CONTRIBUTOR","created_at":"2023-11-15T10:09:05+08:00","repo_name":"dotnet/source-build","issue_id":1994455778,"issue_number":3736,"issue_url":"https://github.com/dotnet/source-build/issues/3736","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2037259445","fragment_type":"issue_comment","sequence":1,"text":"Given this only affect 6.0 and 7.0 there is limited ROI. Additionally URL covers testing to ensure the tags are consistent. Consider closing as won't fix.","author_login":"MichaelSimons","author_association":"MEMBER","created_at":"2024-04-04T13:41:26+08:00","repo_name":"dotnet/source-build","issue_id":1994455778,"issue_number":3736,"issue_url":"https://github.com/dotnet/source-build/issues/3736","linked_issue_ids":[2134531067],"is_known_query_context":false},{"document_id":"gh_comment_2037690802","fragment_type":"issue_comment","sequence":2,"text":"[Triage] Will use URL to track integrating this logic into the release CLI.","author_login":"MichaelSimons","author_association":"MEMBER","created_at":"2024-04-04T16:40:17+08:00","repo_name":"dotnet/source-build","issue_id":1994455778,"issue_number":3736,"issue_url":"https://github.com/dotnet/source-build/issues/3736","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2134531067","fragment_type":"issue_description","sequence":0,"text":"Look into additional validation for produced outputs\nDuring the February release we discovered several issues with tags and some of the produced outputs (like `release.json`) and could've been caught before hand.\n\nMaybe its worth investing into some additional validation at the end of the test/validation pipeline that would skim the produced outputs for some easy-to-catch issues, like empty or not expanded values. We already have unit tests covering some of the functionality that we have ported to the ReleaseCLI, but since we still use scripts / do substitutions from the pipeline, it might be worth the effort.","author_login":"oleksandr-didyk","author_association":"CONTRIBUTOR","created_at":"2024-02-14T14:52:53+08:00","repo_name":"dotnet/source-build","issue_id":2134531067,"issue_number":4131,"issue_url":"https://github.com/dotnet/source-build/issues/4131","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1946747170","fragment_type":"issue_comment","sequence":1,"text":"[Triage] As part of this, we should ensure the artifacts are identical as much as possible between the partner and GH releases.","author_login":"MichaelSimons","author_association":"MEMBER","created_at":"2024-02-15T17:47:33+08:00","repo_name":"dotnet/source-build","issue_id":2134531067,"issue_number":4131,"issue_url":"https://github.com/dotnet/source-build/issues/4131","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2127600905","fragment_type":"issue_comment","sequence":2,"text":"[Triage] Closing as a duplicate of URL Even though this issue was logged first, URL has more detail.","author_login":"MichaelSimons","author_association":"MEMBER","created_at":"2024-05-23T16:36:08+08:00","repo_name":"dotnet/source-build","issue_id":2134531067,"issue_number":4131,"issue_url":"https://github.com/dotnet/source-build/issues/4131","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0112","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Bug with Window Covers in Matter/SmartThings/Google Home Integration?","query_context":"Here is how you can explain your issue on GitHub in English:\n\nI have an issue with my window covers. These covers do not support percentage-based positioning; they only have commands for \"up,\" \"down,\" and \"stop.\" To manage their state, I added a sensor that indicates whether they are open or closed.\n\nI created a YAML configuration for these covers using the cover component with the generic platform.\n\nOn Homebridge and Home Assistant, everything works fine.\n\nOn Matter, SmartThings, or Google Home, the integration does not work properly.\n\nHowever, when I use Google Home via the cloud, it works as expected.\n\nIt seems like the problem is specifically related to how the configuration or functionality is handled in Matter/SmartThings/Google Home locally.\n\nvolet_louis:\n friendly_name: \"Volet Louis 2\"\n position_template: \"{{ (states('binary_sensor.lumi_lumi_sensor_magnet_aq2_opening_25') == 'off')|int * 100 }}\"\n open_cover:\n service: cover.open_cover\n data:\n entity_id: cover.volet_louis\n close_cover:\n service: cover.close_cover\n data:\n entity_id: cover.volet_louis\n stop_cover:\n service: cover.stop_cover\n data:\n entity_id: cover.volet_louis","known_context_document_ids":["gh_issue_2666439047"],"reference_answer":"🤦 \n \n\nCan you confirm that google home is always in sync with \"target position\" instead of \"current position\" ?\nWe don't have target position in home assistant, right? At least I don't have it. So i could sync target position with current position, but doesn't really make sense...\n \n\nFor ALL covers? As I mentioned earlier: \nMatter open = 0% and close = 100%\nHA open = 100% and close = 0%\n\nTherefore I am inverting. Can you test using \"open cover\" command (without percentage) to verify that it's REALLY inverted?\n \n\nYes, but users could be confused by it, when trying to set the position to 30% in GH 😀 \n \n \n\nBut isn't that a problem of the integration. If the cover supports it, shouldn't it be part of the cover entity?\nAnyway I am already using/used it for covers. I just need to re-add it for non-position-aware covers.\n\nTo make it clear:\nI don't have a problem with device based bridge, it's just a matter of effort vs. available time at the moment 😀","answer_document_id":"gh_comment_2495465968","silver_evidence_path":["gh_comment_2509725262","gh_issue_2663138981","gh_comment_2495465968"],"evidence_issue_ids":[2666439047,2663138981],"source_repo_name":"t0bst4r/home-assistant-matter-hub","source_issue_id":2666439047,"source_issue_number":164,"source_issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/164","target_repo_name":"t0bst4r/home-assistant-matter-hub","target_issue_id":2663138981,"target_issue_number":144,"target_issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","reference_anchor_document_id":"gh_comment_2509725262","reference_answer_author":"t0bst4r","reference_answer_author_association":"OWNER","quality_score":87.09,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0526,"anchor_target_overlap":0.0526,"target_answer_overlap":0.0638},"issue_created_at":"2024-11-17T20:26:01+08:00","valid_comment_count":46,"fragments":[{"document_id":"gh_issue_2666439047","fragment_type":"issue_description","sequence":0,"text":"Bug with Window Covers in Matter/SmartThings/Google Home Integration\nHere is how you can explain your issue on GitHub in English:\n\nI have an issue with my window covers. These covers do not support percentage-based positioning; they only have commands for \"up,\" \"down,\" and \"stop.\" To manage their state, I added a sensor that indicates whether they are open or closed.\n\nI created a YAML configuration for these covers using the cover component with the generic platform.\n\nOn Homebridge and Home Assistant, everything works fine.\n\nOn Matter, SmartThings, or Google Home, the integration does not work properly.\n\nHowever, when I use Google Home via the cloud, it works as expected.\n\nIt seems like the problem is specifically related to how the configuration or functionality is handled in Matter/SmartThings/Google Home locally.\n\nvolet_louis:\n friendly_name: \"Volet Louis 2\"\n position_template: \"{{ (states('binary_sensor.lumi_lumi_sensor_magnet_aq2_opening_25') == 'off')|int * 100 }}\"\n open_cover:\n service: cover.open_cover\n data:\n entity_id: cover.volet_louis\n close_cover:\n service: cover.close_cover\n data:\n entity_id: cover.volet_louis\n stop_cover:\n service: cover.stop_cover\n data:\n entity_id: cover.volet_louis","author_login":"Biohospitalix","author_association":"NONE","created_at":"2024-11-17T20:26:01+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2666439047,"issue_number":164,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/164","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2481578448","fragment_type":"issue_comment","sequence":1,"text":"Can you describe what exactly is not working?\nCan you share the attributes (Home Assistant -> dev tools -> state -> search for the entity) of the generic cover) ?\nAre there any error logs in the addon?","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-11-17T21:13:50+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2666439047,"issue_number":164,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2482061202","fragment_type":"issue_comment","sequence":2,"text":"image\n\nNothing works. In smartthings I have 3 buttons, open, close and stop and one position from 0 to 100%\nPosition is made by a sensor. When reach it's close.\n\n` volet_bureau:\n friendly_name: \"Volet Bureau 2\"\n unique_id: VWoQmdAes2Y8wZ0fsM13\n position_template: \"{{ (states('binary_sensor.lumi_lumi_sensor_magnet_aq2_opening_21') == 'off')|int * 100 }}\"\n open_cover:\n service: cover.open_cover\n data:\n entity_id: cover.volet_bureau\n close_cover:\n service: cover.close_cover\n data:\n entity_id: cover.volet_bureau\n stop_cover:\n service: cover.stop_cover\n data:\n entity_id: cover.volet_bureau`","author_login":"Biohospitalix","author_association":"NONE","created_at":"2024-11-18T06:27:43+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2666439047,"issue_number":164,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2482221932","fragment_type":"issue_comment","sequence":3,"text":"You don't need to fake the position attribute with a template on HA. Just keeping the open/closed state is sufficient.\n\n\"supported_feature\" will be 3 then.\n\nBecause if you add position, then HA will add the set position command too.","author_login":"KipK","author_association":"CONTRIBUTOR","created_at":"2024-11-18T08:09:51+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2666439047,"issue_number":164,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2482260225","fragment_type":"issue_comment","sequence":4,"text":"- Do you see the cover in the matter web ui?\n- If yes, do you **see** the cover in google home after pairing?\n- If yes, what buttons do you see? What happens when you press them?\n \n Please answer **all** of the above questions, and attach the addon logs and your bridge configuration from within the matter web ui.","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-11-18T08:28:35+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2666439047,"issue_number":164,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2485528205","fragment_type":"issue_comment","sequence":5,"text":"Yes but without a template i can't keep position when using cover trigger.","author_login":"Biohospitalix","author_association":"NONE","created_at":"2024-11-19T12:02:35+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2666439047,"issue_number":164,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2485532451","fragment_type":"issue_comment","sequence":6,"text":"Yes\nimage\n\nYes\nAll button are grey. I can't interact with them. When using google home cloud integration it's ok","author_login":"Biohospitalix","author_association":"NONE","created_at":"2024-11-19T12:04:39+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2666439047,"issue_number":164,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2485931463","fragment_type":"issue_comment","sequence":7,"text":"Smart blinds for me now show up only as UP and DOWN. In earlier versions I could set them at a specific height just like in home assistant. \nI could even use google assistant to specify the exact number between 0 and 100 to state how much I wanted the blinds to be open. \nNow there are just two options - fully open or fully closed. \nPreviously was better I think.","author_login":"MitoKafander","author_association":"NONE","created_at":"2024-11-19T14:51:08+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2666439047,"issue_number":164,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2504776595","fragment_type":"issue_comment","sequence":8,"text":"@t0bst4r maybe we need to consider the value of supported features. In my case in the state if the cover in HA it shows:\n\n`supported_features: 11`\n\nfrom here\n\n OPEN = 1\n CLOSE = 2\n SET_POSITION = 4\n STOP = 8\n OPEN_TILT = 16\n CLOSE_TILT = 32\n STOP_TILT = 64\n SET_TILT_POSITION = 128\n\nso mine is 11 in binary is 1011\n\nThen:\n\n| Constant | Decimal Value | Binary Representation |\n|---------------------|---------------|-----------------------|\n| OPEN | 1 | 0000 0001 |\n| CLOSE | 2 | 0000 0010 |\n| SET_POSITION | 4 | 0000 0100 |\n| STOP | 8 | 0000 1000 |\n| OPEN_TILT | 16 | 0001 0000 |\n| CLOSE_TILT | 32 | 0010 0000 |\n| STOP_TILT | 64 | 0100 0000 |\n| SET_TILT_POSITION | 128 | 1000 0000 |\n\nMy covers have OPEN, CLOSE and STOP, but not sure why it shows me just the percentage thing...","author_login":"digiolin","author_association":"NONE","created_at":"2024-11-27T21:12:16+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2666439047,"issue_number":164,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2509725262","fragment_type":"issue_comment","sequence":9,"text":"@Biohospitalix \n \n\nCan you please verify if IPv6 is enabled in your local network?\nAre your running HAOS with the addon, or do you run the docker image?\n\n---\n\n@digiolin \n \n\nThis is a different issue (#144), but it should be fixed with the latest version.","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-12-01T11:33:55+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2666439047,"issue_number":164,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/164","linked_issue_ids":[2663138981],"is_known_query_context":false},{"document_id":"gh_comment_2509741469","fragment_type":"issue_comment","sequence":10,"text":"Yes I use IPv6 and Matterhub as an add-on.\nThis works in the Samsung app by doing this:\nI indicate 0 or 100% closure and I start the predefined position (0 or 100) . This does not work by shutter when indicating open or close.\nScreenshot_20241201_131638_SmartThings\nScreenshot_20241201_131625_SmartThings","author_login":"Biohospitalix","author_association":"NONE","created_at":"2024-12-01T12:18:10+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2666439047,"issue_number":164,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2663138981","fragment_type":"issue_description","sequence":0,"text":"[Bug] Covers - positional and non-positional devices\nCover devices no longer seem to work with 3.0.0-alpha.32. \n\n[ 2024-11-15T21:03:32.276Z ] [ INFO ] [ matter.js / Behavior ]: Invoke a7593064a30d433a9930e4f7836e56b5.aggregator.cover_ratgdo_door.windowCovering.upOrOpen online#45f4f5a@95216b57 (no payload)\n[ 2024-11-15T21:03:32.287Z ] [ ERROR ] [ matter.js / Runtime ]: { code: \"home_assistant_error\", message: \"Entity cover.ratgdo_door does not support this service.\" }\n[ 2024-11-15T21:03:32.288Z ] [ INFO ] [ matter.js / Runtime ]: Shutting down\n[ 2024-11-15T21:03:32.288Z ] [ INFO ] [ matter.js / Node ]: a7593064a30d433a9930e4f7836e56b5 going offline\n[ 2024-11-15T21:03:32.298Z ] [ INFO ] [ matter.js / UdpMulticastServer ]: lo: send ENETUNREACH ff02::fb:5353\n[ 2024-11-15T21:03:32.406Z ] [ INFO ] [ matter.js / SecureSession ]: End CASE session secure/51346\n[ 2024-11-15T21:03:32.408Z ] [ INFO ] [ matter.js / SecureSession ]: End CASE session secure/51347\n[ 2024-11-15T21:03:32.408Z ] [ INFO ] [ matter.js / Node ]: a7593064a30d433a9930e4f7836e56b5 is offline\n[ 2024-11-15T21:03:32.476Z ] [ INFO ] [ matter.js / ServerNodeStore ]: Closed a7593064a30d433a9930e4f7836e56b5 storage at /config/data/a7593064a30d433a9930e4f7836e56b5","author_login":"mckennajp","author_association":"NONE","created_at":"2024-11-15T21:07:37+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2479951276","fragment_type":"issue_comment","sequence":1,"text":"Interesting. Somehow we are calling an action in home assistant which is not allowed for this cover. Did it work before?\n\nCan you set the log level to debug and then try again? It will then log the exact action it is trying to call.","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-11-15T21:23:28+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2480464703","fragment_type":"issue_comment","sequence":2,"text":"I saw some issue with covers. Mostly some were reversed. Was showing they were open while closed, and up/down command was inverted. \nFunny thing, I have 4 x covers which are the same brand devices , 2 of them were ok but 2 others were working inverted on GH. \n\nOn HA side they were having the same data, this looked a bit non sense. \n\nI'll track this down and get some debug data.","author_login":"KipK","author_association":"NONE","created_at":"2024-11-16T07:34:38+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2480466474","fragment_type":"issue_comment","sequence":3,"text":"Updated to the alpha. 32 and my smart blinds reversed direction in Google home. Before they worked normally but now the open and close direction and state is the opposite in Google home\n\n Open is closed and closed is open. Also 26% open in home assistant is now 74% open in Google home.","author_login":"MitoKafander","author_association":"NONE","created_at":"2024-11-16T07:41:51+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2480546739","fragment_type":"issue_comment","sequence":4,"text":"So first things first:\n- Matter specifies 0% as \"open\" and 100% as \"closed\".\n- Home Assistant specifies 100% as \"open\" and 0% as \"closed\".\n\nSo I needed to reverse covers in general. To indicate that it's reversed, i used the `configStatus.liftMovementReversed` flag (this is what has changed) - maybe it was wrong doing both.\n\nI'll remove that property to test it.","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-11-16T12:38:04+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2480646915","fragment_type":"issue_comment","sequence":5,"text":"Not sure it will be sufficient, as not all my covers here looks inverted. Some are reporting open when opened, I have one coming from HomeKit and this one is always inverted.\n\nI've tryed to set configStatus.liftMovementReversed to false, and then the working ones actions are working in reverse ( Opening close, and closing open.. But state looks eratic. Sometime it says it's open when close, and sometime it reports the correct state. I'm trying to find a logic behind that.","author_login":"KipK","author_association":"NONE","created_at":"2024-11-16T16:38:08+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2480732877","fragment_type":"issue_comment","sequence":6,"text":"Does your cover support positions, or does it only support open and close?\nAfter calling the `set_cover_position` it shows an error, that this service call is not supported.\n\nCan you try calling that service manually from the home assistant dev tools?\n- Service: `cover.set_cover_position`\n- Target: `{\"entity_id\":\"cover.ratgdo_door\"}`\n- Data: `{\"position\":100}'","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-11-16T18:44:28+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2480743283","fragment_type":"issue_comment","sequence":7,"text":"Yeah, I get the same error in dev tools: `Failed to perform the action cover.set_cover_position. Entity cover.ratgdo_door does not support this service.`\n\nThis cover if for a garage door and it only supports open/close/stop.","author_login":"mckennajp","author_association":"NONE","created_at":"2024-11-16T19:13:59+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2480746099","fragment_type":"issue_comment","sequence":8,"text":"Okay, can you post a screenshot of the attributes of this entity?\n(HA -> Dev Tools -> State -> search for your entity)\n\nIs there any indication where i can detect if it supports position awareness?","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-11-16T19:19:40+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2480749286","fragment_type":"issue_comment","sequence":9,"text":"okay got it. actually i hoped that i dont need to parse `supported_features` since its deprecated for other domains. 😀","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-11-16T19:27:22+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2480754850","fragment_type":"issue_comment","sequence":10,"text":"I have a cover with supported_feature 3. It only has up/down and state open/close, and probably stop. \nActually matter bridge only expose up down button but no state.","author_login":"KipK","author_association":"CONTRIBUTOR","created_at":"2024-11-16T19:40:56+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2480806493","fragment_type":"issue_comment","sequence":11,"text":"I've added support for \"not position aware\".\n\nAlso i reverted one change, which COULD be related to the missing percentage in GH. Just let me know.","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-11-16T20:50:37+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2480813948","fragment_type":"issue_comment","sequence":12,"text":"still the same here, all covers have only up down buttons and no feedback/state.\nWill try to catch some data tomorrow.","author_login":"KipK","author_association":"CONTRIBUTOR","created_at":"2024-11-16T21:24:14+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2480814773","fragment_type":"issue_comment","sequence":13,"text":"Just on thing I can give for now, Garage door now crash the bridge at startup:\n\nBehaviors have errors\n at file:///usr/local/lib/node_modules/home-assistant-matter-hub/node_modules/@matter/node/dist/esm/endpoint/properties/Behaviors.js:128:21\n at all (file:///usr/local/lib/node_modules/home-assistant-matter-hub/node_modules/@matter/general/dist/esm/util/Construction.js:375:17)\n at file:///usr/local/lib/node_modules/home-assistant-matter-hub/node_modules/@matter/general/dist/esm/util/Construction.js:365:11\n Cause #0: Error initializing 435459ea97854796829ca31284021754.aggregator.cover_porte_garage.windowCovering\n at crash (file:///usr/local/lib/node_modules/home-assistant-matter-hub/node_modules/@matter/node/dist/esm/behavior/internal/BehaviorBacking.js:48:13)\n Caused by: Validating 435459ea97854796829ca31284021754.aggregator.cover_porte_garage.windowCovering.state: Conformance \"LF & PA_LF\": Matter does not allow you to set this attribute (128)\n at disallowValue (file:///usr/local/lib/node_modules/home-assistant-matter-hub/node_modules/@matter/node/dist/esm/behavior/state/validation/conformance-compiler.js:305:13)\n at file:///usr/local/lib/node_modules/home-assistant-matter-hub/node_modules/@matter/node/dist/esm/behavior/state/validation/conformance.js:13:15\n at file:///usr/local/lib/node_modules/home-assistant-matter-hub/node_modules/@matter/node/dist/esm/behavior/state/managed/values/StructManager.js:135:13\n at Object.change (file:///usr/local/lib/node_modules/home-assistant-matter-hub/node_modules/@matter/node/dist/esm/behavior/state/managed/Datasource.js:172:7)\n at WindowCovering$State.set [as currentPositionLiftPercent100ths] (file:///usr/local/lib/node_modules/home-assistant-matter-hub/node_modules/@matter/node/dist/esm/behavior/state/managed/values/StructManager.js:105:32)\n at Function.assign ( )\n at applyPatchState (file:///usr/local/lib/node_modules/home-assistant-matter-hub/dist/backend/cli.js:888:14)\n at WindowCoveringServer.update (file:///usr/local/lib/node_modules/home-assistant-matter-hub/dist/backend/cli.js:1618:5)\n at WindowCoveringServer.initialize (file:///usr/local/lib/node_modules/home-assistant-matter-hub/dist/backend/cli.js:1609:10)","author_login":"KipK","author_association":"CONTRIBUTOR","created_at":"2024-11-16T21:27:45+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2480816597","fragment_type":"issue_comment","sequence":14,"text":"Also here are the data of one of my cover that only displays the up/down buttons and no state/position percent since alpha 33:\n\n{\n \"entityId\": \"cover.stores_buanderie\",\n \"endpointCode\": \"202\",\n \"endpointType\": \"WindowCovering\",\n \"state\": {\n \"identify\": {\n \"isIdentifying\": false,\n \"clusterRevision\": 4,\n \"identifyTime\": 0,\n \"identifyType\": 0,\n \"featureMap\": {\n\n },\n \"attributeList\": [0, 1, 65533, 65532, 65531, 65529, 65528],\n \"eventList\": [],\n \"acceptedCommandList\": [0],\n \"generatedCommandList\": []\n },\n \"bridgedDeviceBasicInformation\": {\n \"clusterRevision\": 3,\n \"vendorName\": \"t0bst4r\",\n \"vendorId\": 65521,\n \"productName\": \"MatterHub\",\n \"nodeLabel\": \"Stores Buanderie\",\n \"hardwareVersion\": 2024,\n \"softwareVersion\": 2024,\n \"productLabel\": \"Home Assistant Matter Hub\",\n \"reachable\": true,\n \"featureMap\": {\n\n },\n \"attributeList\": [1, 2, 3, 5, 7, 9, 14, 17, 65533, 65532, 65531, 65529, 65528],\n \"eventList\": [],\n \"acceptedCommandList\": [],\n \"generatedCommandList\": []\n },\n \"windowCovering\": {\n \"supportsCalibration\": false,\n \"supportsMaintenanceMode\": true,\n \"clusterRevision\": 5,\n \"featureMap\": {\n \"lift\": true,\n \"tilt\": false,\n \"positionAwareLift\": true,\n \"absolutePosition\": true,\n \"positionAwareTilt\": false\n },\n \"type\": 0,\n \"currentPositionLift\": 10000,\n \"configStatus\": {\n \"operational\": true,\n \"onlineReserved\": false,\n \"liftMovementReversed\": true,\n \"liftPositionAware\": true,\n \"tiltPositionAware\": false,\n \"liftEncoderControlled\": false,\n \"tiltEncoderControlled\": false\n },\n \"currentPositionLiftPercentage\": 100,\n \"operationalStatus\": {\n \"global\": 0,\n \"lift\": 0\n },\n \"targetPositionLiftPercent100ths\": 10000,\n \"endProductType\": 0,\n \"currentPositionLiftPercent100ths\": 10000,\n \"installedOpenLimitLift\": 0,\n \"installedClosedLimitLift\": 10000,\n \"mode\": {\n \"motorDirectionReversed\": false,\n \"calibrationMode\": false,\n \"maintenanceMode\": false,\n \"ledFeedback\": false\n },\n \"attributeList\": [0, 7, 10, 13, 23, 65533, 65532, 65531, 65529, 65528, 16, 17, 11, 14],\n \"eventList\": [],\n \"acceptedCommandList\": [0, 1, 2, 5, 4],\n \"generatedCommandList\": []\n },\n \"descriptor\": {\n \"clusterRevision\": 2,\n \"featureMap\": {\n \"tagList\": false\n },\n \"deviceTypeList\": [\n {\n \"deviceType\": 514,\n \"revision\": 3\n },\n {\n \"deviceType\": 19,\n \"revision\": 2\n }\n ],\n \"serverList\": [3, 57, 258, 29],\n \"clientList\": [],\n \"partsList\": [],\n \"attributeList\": [0, 1, 2, 3, 65533, 65532, 65531, 65529, 65528],\n \"eventList\": [],\n \"acceptedCommandList\": [],\n \"generatedCommandList\": []\n }\n }\n },\n\nimage","author_login":"KipK","author_association":"CONTRIBUTOR","created_at":"2024-11-16T21:35:55+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2480818215","fragment_type":"issue_comment","sequence":15,"text":"The crash during startup should be fixed.\n\nThe attributes don't look wrong tbh. I'll validate them tomorrow.","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-11-16T21:43:18+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2481197833","fragment_type":"issue_comment","sequence":16,"text":"I've made some test with previous version. \n\nWith alpha-32 I still have the cover position + closed/opened state on GH.\nimage\n\nStarting with alpha-33, only up/down button withtout state/position feedback.\nimage\n\nThe only differences I see from the dev tools log is \"targetPositionLiftPercent100ths\": 5000 with latest alpha, and \"targetPositionLiftPercent100ths\": 100, with alpha-32 working one","author_login":"KipK","author_association":"CONTRIBUTOR","created_at":"2024-11-17T11:40:08+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2481233358","fragment_type":"issue_comment","sequence":17,"text":"Hm. i was suspecting the `targetPositionLiftPercent100ths` to cause it, but that's why i reverted my change in `alpha.34`:\n\n URL \n\nHere is the diff between `alpha.32` and `alpha.36`:\n URL \n\nIn the end, i am always setting it if your cover is position aware.","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-11-17T12:09:57+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2481272133","fragment_type":"issue_comment","sequence":18,"text":"`targetPositionLiftPercent100ths` is not in percent. It’s `percent * 100`. \nSo 100 is 1% and 5000 is 50%.","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-11-17T13:43:41+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2481275946","fragment_type":"issue_comment","sequence":19,"text":"I see. It shouldn't be at 50% as it's open, and 32 reports 1% at the same time.","author_login":"KipK","author_association":"CONTRIBUTOR","created_at":"2024-11-17T13:55:33+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2482731357","fragment_type":"issue_comment","sequence":20,"text":"@t0bst4r , do you prefer I create a separated issue for this ?","author_login":"KipK","author_association":"CONTRIBUTOR","created_at":"2024-11-18T11:11:29+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2491436087","fragment_type":"issue_comment","sequence":21,"text":"no let's just do it here. 👍 \nI'm currently looking into it again.","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-11-21T14:50:08+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2491496359","fragment_type":"issue_comment","sequence":22,"text":"I just see no difference at all. With Alexa I get the level control, too.\n\nCan you please try pairing a whole new bridge?\nMaybe there is some kind of caching in place.","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-11-21T15:11:46+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2492155017","fragment_type":"issue_comment","sequence":23,"text":"Damn it. Do you still have your test-setup running? I just don't understand, that it's working for me with Alexa.\nCan you _again_ share the json from dev tools from both versions, 32 and current - for the SAME cover and with no changes to the cover in between of course 😁 \n \n \n\nI am not sure which attribute to use here.\nTo be honest: to \"know\" if its open or closed is already position aware, isn't it?\n\n---\n\ni just checked the matter specification and found that it is not recommended to use the \"AbsolutePosition\" feature. So I'll remove that, but keep the \"PositionAwareLift\" as it is for now.","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-11-21T20:03:03+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2492492590","fragment_type":"issue_comment","sequence":24,"text":"So something strange. I've just opened GH app, and see my covers have now the correct slider with position. \n\nSeems my GH speaker has updated to preview fw 444798.\n\nHowever, if I move the cover position from HA, it doesn't update the state on GH side .","author_login":"KipK","author_association":"CONTRIBUTOR","created_at":"2024-11-21T22:36:42+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2493796909","fragment_type":"issue_comment","sequence":25,"text":"I'm on the Matter specs now, I'm also surprised there's no dedicated cluster for open/close state.\nI think then it has to be simulated for devices with no position feedback by jumping CurrentPositionLiftPercentage to 100% when HA cover state is \"closed\" or 0% when \"open\".\n\nNot totally related, but I also saw this endpoint for moving state:\n\n- 5.3.5.3. OperationalStatusBitmap Type\nThis endpoint display opening/closing/not moving state\n\nI see a problem on current implementation as this value comes from another ha entity. \nCover devices have cover entity , + can have additional sensors entities:\n- moving state : STOP, UP, DOWN\n- open/close binary sensor ( ie garage doors have this separated , I had to create a cover template to add this sensor as the cover state value ) \n\nDunno on an entity based bridge how can it be implemented. \nDevice based bridge is probably needed for this ( this is how it's implemented on zigbee2mqtt matter bridge )","author_login":"KipK","author_association":"CONTRIBUTOR","created_at":"2024-11-22T13:41:24+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2495465968","fragment_type":"issue_comment","sequence":26,"text":"🤦 \n \n\nCan you confirm that google home is always in sync with \"target position\" instead of \"current position\" ?\nWe don't have target position in home assistant, right? At least I don't have it. So i could sync target position with current position, but doesn't really make sense...\n \n\nFor ALL covers? As I mentioned earlier: \nMatter open = 0% and close = 100%\nHA open = 100% and close = 0%\n\nTherefore I am inverting. Can you test using \"open cover\" command (without percentage) to verify that it's REALLY inverted?\n \n\nYes, but users could be confused by it, when trying to set the position to 30% in GH 😀 \n \n \n\nBut isn't that a problem of the integration. If the cover supports it, shouldn't it be part of the cover entity?\nAnyway I am already using/used it for covers. I just need to re-add it for non-position-aware covers.\n\nTo make it clear:\nI don't have a problem with device based bridge, it's just a matter of effort vs. available time at the moment 😀","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-11-23T12:39:11+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2495466995","fragment_type":"issue_comment","sequence":27,"text":"One more thing I'd like to test: \nat the moment, position aware covers get the following features: \"Lift\", \"PositionAwareLift\" and \"AbsolutePosition\".\nAs per matter specification \"Absolute Position\" should not be used anymore:\n \nfor new implementations.\n\nSo I'll remove it, so maybe thiings get better with that.","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-11-23T12:43:29+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2495480280","fragment_type":"issue_comment","sequence":28,"text":"I'm not sure how to check that. If I move a cover from HA, then it doesn't update on GH. Seems like GH is keeping its own states for whatever reason. \n Commands are only inverted when states are not in synch, like closed in HA and Open in GH. \n\nThis could be related to Absolute Positioning so let's try without. \n\nI have not much time this week end but I'll try to gather some data about what's happening.","author_login":"KipK","author_association":"CONTRIBUTOR","created_at":"2024-11-23T13:29:06+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2495483888","fragment_type":"issue_comment","sequence":29,"text":"I have already released it to `alpha.38`, so give it a try.\n\n--- \n\nAnyway i am now even more confused regarding inversion:\n \n \n\nAlexa: open = 0% and close = 100%\n\nAlexa shows as a title for the percentage: `Öffnungsgrad` (translates to `Degree of openness`)\nAs of my understanding `degree of openness` of `0%` would mean closed, but it's not 😀 \n\nSo when Asking it to \"close\", it sets the position to 100% - as specified.\nBut from a natural language perspective it is counter-intuitive. 😀","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-11-23T13:41:37+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2495497599","fragment_type":"issue_comment","sequence":30,"text":"Just tested, you won't like it ^^\n\n- Now all position aware covers have only 2 buttons, but with state: \nimage\nThat's the UI the garage door should have then, but it still have the 2 buttons without state:\nimage\n- State follows on HA when cover is triggered from GH But on the other way, when triggered from HA, states follows when achieving close or open, thereafter it switch back to the other state ( i.e. Cover is open, I close it from HA, I see cover state as closed when closed, then a sec after, it switch back to open state. \n- after upgrading to 38, all devices were recognised as new devices, I had to remap them to each room. Btw, not really important in alpha stage. Got this on log at startup for each device: \n` [ 2024-11-23T13:32:20.373Z ] [ WARN ] [ matter.js / EndpointStoreService ]: Stored number 42 is already allocated to another endpoint, ignoring\n`","author_login":"KipK","author_association":"CONTRIBUTOR","created_at":"2024-11-23T14:30:13+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2509024362","fragment_type":"issue_comment","sequence":31,"text":"Just adding my 2 cents here. I have ratgdo's on 2 garage door openers that are old so they are setup in dry contact configuration/firmware. These are MQTT only devices in this configuration so no esphome. These 2 devices show up in HA as covers and I can control them just fine within HA. I added them to matterhub to expose them to alexa and they always just say device unresponsive. Feature set shows 11 in dev tools. Running alpha 45","author_login":"KennyMarcum","author_association":"NONE","created_at":"2024-11-30T16:24:17+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2509195845","fragment_type":"issue_comment","sequence":32,"text":"i've added the absolute position feature again, since this seemed to remove the percentage in google home.\nalso i have added the position aware feature for non-position aware covers and (hopefully correctly) faked the open and close state.\n\nCan please someone test with alpha.48 ?","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-11-30T20:15:44+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2509394994","fragment_type":"issue_comment","sequence":33,"text":"In Alpha 49 My devices show available now. In alexa app I have only a slider and if I slide it all the way to 0 or 100% then I get an action on my door. 100% = closed 0% = open","author_login":"KennyMarcum","author_association":"NONE","created_at":"2024-11-30T21:47:44+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2509611860","fragment_type":"issue_comment","sequence":34,"text":"Yes position aware are back. And garage door is ok now with state feedback 👍","author_login":"KipK","author_association":"CONTRIBUTOR","created_at":"2024-12-01T07:24:25+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2509721054","fragment_type":"issue_comment","sequence":35,"text":"For covers which don't support position, i implemented the handler to consider every `percentage > 0` as \"close command\" and `percentage == 0` as \"open command\".\n \n\nSo can we finally close this issue?","author_login":"t0bst4r","author_association":"OWNER","created_at":"2024-12-01T11:22:28+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2509747125","fragment_type":"issue_comment","sequence":36,"text":"Here everything looks ok for what I could test so probably yes.","author_login":"KipK","author_association":"CONTRIBUTOR","created_at":"2024-12-01T12:32:49+08:00","repo_name":"t0bst4r/home-assistant-matter-hub","issue_id":2663138981,"issue_number":144,"issue_url":"https://github.com/t0bst4r/home-assistant-matter-hub/issues/144","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0113","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Brisanje nepremičnine?","query_context":"Potrebovale bi pomoč pri brisanju nepremičnine. Kljub temu, da smo uredile, da ko izbrišemo nepremičnino, da se izbriše tudi komitent, nam še vedno javlja napako, da izbris ni mogoč, ker se v komitentu sklicujemo na nepremičnino, ki bi jo rade izbrisale.\nŽe v naprej hvala za pomoč!","known_context_document_ids":["gh_issue_1277475311"],"reference_answer":"Hvala za opombe, `requests` smo odstranili url-je smo pa naredili tako kot smo se menili na vajah.\nImamo še eno vprašanje glede `binder`-ja, ali moramo spremeniti oz. dodati še kaj za delovanje le-tega \n(poleg povezave z _javnost_ na bazo).","answer_document_id":"gh_comment_1133666159","silver_evidence_path":["gh_comment_1162024452","gh_issue_1235096216","gh_comment_1133666159"],"evidence_issue_ids":[1277475311,1235096216],"source_repo_name":"nezakrzan/Nepremicninske-agencije","source_issue_id":1277475311,"source_issue_number":5,"source_issue_url":"https://github.com/nezakrzan/Nepremicninske-agencije/issues/5","target_repo_name":"MatejRojec/Gamma","target_issue_id":1235096216,"target_issue_number":1,"target_issue_url":"https://github.com/MatejRojec/Gamma/issues/1","reference_anchor_document_id":"gh_comment_1162024452","reference_answer_author":"MatejRojec","reference_answer_author_association":"OWNER","quality_score":82.67,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0333,"anchor_target_overlap":0.1954,"target_answer_overlap":0.1724},"issue_created_at":"2022-06-20T23:03:21+08:00","valid_comment_count":4,"fragments":[{"document_id":"gh_issue_1277475311","fragment_type":"issue_description","sequence":0,"text":"Brisanje nepremičnine\nPotrebovale bi pomoč pri brisanju nepremičnine. Kljub temu, da smo uredile, da ko izbrišemo nepremičnino, da se izbriše tudi komitent, nam še vedno javlja napako, da izbris ni mogoč, ker se v komitentu sklicujemo na nepremičnino, ki bi jo rade izbrisale.\nŽe v naprej hvala za pomoč!","author_login":"Nina2809","author_association":"COLLABORATOR","created_at":"2022-06-20T23:03:21+08:00","repo_name":"nezakrzan/Nepremicninske-agencije","issue_id":1277475311,"issue_number":5,"issue_url":"https://github.com/nezakrzan/Nepremicninske-agencije/issues/5","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1161825894","fragment_type":"issue_comment","sequence":1,"text":"### 1. Brisanje nepremičnine\nTežava je, da želite iz tabele `komitent` izbrisati vrstice, kjer se kupuje nepremičnina, ki jo želite izbrisati. Trenutno brišete iz tabele komitent vrstice, ki imajo v `id_komitent` vrednost `id`, namesto v `kupuje_nepremicnino`. To lahko rešite tako (namesto vaših vrstic 505-515):\n\npython\ncur.execute(\"DELETE FROM hisa WHERE id_hisa =%s\" % (id))\ncur.execute(\"DELETE FROM stanovanje WHERE id_stanovanje=%s\" % (id))\ncur.execute(\"DELETE FROM komitent WHERE kupuje_nepremicnino=%s\" % (id))\ncur.execute(\"DELETE FROM nepremicnina WHERE id =%s\" % (id))\nconn.commit()\n\n### 2. Težava z vpisovanjem emša\n\nPoleg tega sem opazil pri vas težavo: če med registracijo vpišem svoj emšo, mi vrne napako\n\npython\npsycopg2.errors.NumericValueOutOfRange: value \"1812999500000\" is out of range for type integer\nLINE 3: VALUES ('1812999500000', 'Maj', 'Gaberšček',...\n\nTo se zgodi, ker imate stolpec `id` v tabeli `oseba` tipa `SERIAL`, ki omogoča samo števila do $2^{31} - 1$. Svetujem vam, da stolpcu spremenite tip na `BIGINT`, ki omogoča precej večja števila (do $2^{63} - 1$). To lahko storite z ukazi:\n\nsql\nALTER TABLE oseba ALTER COLUMN id TYPE BIGINT;\nALTER TABLE agent ALTER COLUMN id_agent TYPE BIGINT;\nALTER TABLE komitent ALTER COLUMN id_komitent TYPE BIGINT;","author_login":"majbc1999","author_association":"NONE","created_at":"2022-06-21T14:30:42+08:00","repo_name":"nezakrzan/Nepremicninske-agencije","issue_id":1277475311,"issue_number":5,"issue_url":"https://github.com/nezakrzan/Nepremicninske-agencije/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1162024452","fragment_type":"issue_comment","sequence":2,"text":"Seveda pazite še na to, da ne odpirate možnosti napadov SQL injection - tako kot drugod podajte `id` v seznamu kot drugi argument metode `execute` (tj., ga ne vstavljate v niz s `%` ali na kak drug način), npr.\n\npython\ncur.execute(\"DELETE FROM hisa WHERE id_hisa = %s\", [id])\n\nKar se tiče EMŠOv, kot je opozoril @majbc1999, bi predlagal, da jih imate kar v poljih tipa `TEXT`. Morda bo celo bolje, da pustite `id` v tabeli `oseba` tipa `SERIAL` (in tako ostanejo nespremenjene reference na ta stolpec), sam EMŠO pa imate v svojem stolpcu (z omejitvijama `NOT NULL UNIQUE`, da se vrednosti ne bodo ponavljale), ID-je pa pustite, da se vam sami generirajo.\n\nŠe to: vidim, da na več mestih uporabljate funkcijo `url`, ki pa ji podaste kar pot (tj., začne se z `/`). Prvi argument funkcije `url` naj bo kar ime ustrezne funkcije - tako se bodo zgradile ustrezne poti tudi, ko boste aplikacijo poganjale na Binderju. Seveda na isti način gradite poti tudi v predlogah. Za več podrobnosti si poglejte MatejRojec/Gamma#1.","author_login":"jaanos","author_association":"NONE","created_at":"2022-06-21T17:06:09+08:00","repo_name":"nezakrzan/Nepremicninske-agencije","issue_id":1277475311,"issue_number":5,"issue_url":"https://github.com/nezakrzan/Nepremicninske-agencije/issues/5","linked_issue_ids":[1235096216],"is_known_query_context":false},{"document_id":"gh_comment_1163719479","fragment_type":"issue_comment","sequence":3,"text":"Hvala za pomoč, smo popravile tako izbris nepremičnine, kot tudi url povezave.","author_login":"Nina2809","author_association":"COLLABORATOR","created_at":"2022-06-22T22:40:14+08:00","repo_name":"nezakrzan/Nepremicninske-agencije","issue_id":1277475311,"issue_number":5,"issue_url":"https://github.com/nezakrzan/Nepremicninske-agencije/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1235096216","fragment_type":"issue_description","sequence":0,"text":"Grajenje URL-jev\nSvetujem, da za grajenje URL-jev (v predlogah in pri preusmeritvah) uporabite funkcijo `url`. Pri lokalnem poganjanju sicer ne bo nobene razlike, bodo pa tako povezave delovale pri poganjanju na Binderju. Za začetek bo tako treba namesto iz `bottle` uvažati iz `bottleext`:\n\npython\nfrom bottleext import *\n\nFunkciji `url` podaste ime funkcije, ki prikaže želeno stran (kot niz), nato pa po potrebi še ostale poimenovane parametre. Tako namesto\n URL \nnaredite\n\npython\n redirect(url('uporabnik_get', id_uporabnika=id_uporabnika))\n\nPodobno naredite tudi pri vseh povezavah v predlogah (tj., atributi `href`, `action`, `src`), npr.\n\nhtml\n \n\nMimogrede, da bo aplikacija tekla na Binderju, bo potrebno v `binder/start` popraviti ime glavnega programa:\n\nbash\nexport BOTTLE_RUNTIME=gama.py\n\nOpažam še, da v glavnem programu uvažate knjižnico `requests`, ki je pa nikjer ne uporabite, tako da svetujem, da njen uvoz odstranite. Če pa jo boste vendarle potrebovali (oziroma katerokoli knjižnico, ki ni privzeto nameščena s Pythonom), pa jo dodajte še v `binder/requirements.txt` (obstoječi vrstici seveda pustita), da se bo ustrezno pripravilo okolje za poganjanje. Ko boste želeli, lahko potem v `README.md` dodaste še povezavo za poganjanje v Binderju:\n\nmarkdown\nbottle.py","author_login":"jaanos","author_association":"NONE","created_at":"2022-05-13T11:05:09+08:00","repo_name":"MatejRojec/Gamma","issue_id":1235096216,"issue_number":1,"issue_url":"https://github.com/MatejRojec/Gamma/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1133666159","fragment_type":"issue_comment","sequence":1,"text":"Hvala za opombe, `requests` smo odstranili url-je smo pa naredili tako kot smo se menili na vajah.\nImamo še eno vprašanje glede `binder`-ja, ali moramo spremeniti oz. dodati še kaj za delovanje le-tega \n(poleg povezave z _javnost_ na bazo).","author_login":"MatejRojec","author_association":"OWNER","created_at":"2022-05-21T16:39:34+08:00","repo_name":"MatejRojec/Gamma","issue_id":1235096216,"issue_number":1,"issue_url":"https://github.com/MatejRojec/Gamma/issues/1","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0114","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Change Some expression that not contribute with inclusive language or antiracist language?","query_context":"### Summary\n\nHi community!\n\nIn the view Spam Filter when you are editing a domain.\n\nchange words \nWhite List for Enabled\nBlack List for Disabled\n\nIn Spanish \nLista Blanca: Habilitada\nLista Negra: Deshabilitada\n\nCaptura de pantalla de 2022-03-25 20-23-59\n\nCaptura de pantalla de 2022-03-25 20-22-02\n\n### Motivation\n\ncontribute to a non-racist language\n\n### Additional context\n\n_No response_","known_context_document_ids":["gh_issue_1181473654"],"reference_answer":"I don't think Mailcow is the right place for political discussions like this. While the intent may be laudable, it comes at a price in terms of clarity, brevity and unambiguity.\n\nFor example, replacing \"whitelist\" with \"allow list\" is ambiguous and unclear (you don't need to be on that list to be allowed to send mail) and \"spam filter bypass list\" is lengthy and not completely clear either.\n\nThere do not appear to be alternative terms in widespread use (Exchange has \"safe senders\", Gmail doesn't even have that feature), and as a small mail server platform, we are not in the position to define new terms. We need to make it as easy as possible for people migrating from other platforms. Once Exchange, Yahoo, Gmail, etc. converge on a new name, we will happily adopt it.","answer_document_id":"gh_comment_558603194","silver_evidence_path":["gh_comment_1079667256","gh_issue_524674898","gh_comment_558603194"],"evidence_issue_ids":[1181473654,524674898],"source_repo_name":"mailcow/mailcow-dockerized","source_issue_id":1181473654,"source_issue_number":4524,"source_issue_url":"https://github.com/mailcow/mailcow-dockerized/issues/4524","target_repo_name":"mailcow/mailcow-dockerized","target_issue_id":524674898,"target_issue_number":3155,"target_issue_url":"https://github.com/mailcow/mailcow-dockerized/issues/3155","reference_anchor_document_id":"gh_comment_1079667256","reference_answer_author":"mkuron","reference_answer_author_association":"MEMBER","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.1667,"target_answer_overlap":0.1471},"issue_created_at":"2022-03-26T02:35:54+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_1181473654","fragment_type":"issue_description","sequence":0,"text":"Change Some expression that not contribute with inclusive language or antiracist language\n### Summary\n\nHi community!\n\nIn the view Spam Filter when you are editing a domain.\n\nchange words \nWhite List for Enabled\nBlack List for Disabled\n\nIn Spanish \nLista Blanca: Habilitada\nLista Negra: Deshabilitada\n\nCaptura de pantalla de 2022-03-25 20-23-59\n\nCaptura de pantalla de 2022-03-25 20-22-02\n\n### Motivation\n\ncontribute to a non-racist language\n\n### Additional context\n\n_No response_","author_login":"nikolehn","author_association":"NONE","created_at":"2022-03-26T02:35:54+08:00","repo_name":"mailcow/mailcow-dockerized","issue_id":1181473654,"issue_number":4524,"issue_url":"https://github.com/mailcow/mailcow-dockerized/issues/4524","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1079648296","fragment_type":"issue_comment","sequence":1,"text":"I fear Mailcow maintainers aren't really sensitive to this, but maybe if you prepare a pull request with the newly translated strings it has better chances?","author_login":"mthld","author_association":"NONE","created_at":"2022-03-26T09:26:40+08:00","repo_name":"mailcow/mailcow-dockerized","issue_id":1181473654,"issue_number":4524,"issue_url":"https://github.com/mailcow/mailcow-dockerized/issues/4524","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1079667256","fragment_type":"issue_comment","sequence":2,"text":"Dupe of URL \n\nAlso Enabled and Disabled (which btw is also a 'racist' word against disabled people) doesn't fit at all","author_login":"MAGICCC","author_association":"MEMBER","created_at":"2022-03-26T11:33:21+08:00","repo_name":"mailcow/mailcow-dockerized","issue_id":1181473654,"issue_number":4524,"issue_url":"https://github.com/mailcow/mailcow-dockerized/issues/4524","linked_issue_ids":[524674898],"is_known_query_context":false},{"document_id":"gh_issue_524674898","fragment_type":"issue_description","sequence":0,"text":"rename \"whitelist/blacklist\" in spam settings to \"allowlist/blocklist\"\nUse of the words \"whitelist\" to denote \"good\" and \"blacklist\" to denote bad has negative connotations, and does not describe very well what the actual action is. \n\nplease can you replace them with \"Allow list\" to signify email addresses that will always be allowed, and \"block list\" or \"deny list\" for email addresses that will always be blocked or denied. \n\nThis will improve usability.","author_login":"burntout","author_association":"NONE","created_at":"2019-11-18T23:12:53+08:00","repo_name":"mailcow/mailcow-dockerized","issue_id":524674898,"issue_number":3155,"issue_url":"https://github.com/mailcow/mailcow-dockerized/issues/3155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_555373956","fragment_type":"issue_comment","sequence":1,"text":"I don't know. In mailing whitelist and blacklist are established terms.","author_login":"andryyy","author_association":"MEMBER","created_at":"2019-11-19T07:36:26+08:00","repo_name":"mailcow/mailcow-dockerized","issue_id":524674898,"issue_number":3155,"issue_url":"https://github.com/mailcow/mailcow-dockerized/issues/3155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_555414635","fragment_type":"issue_comment","sequence":2,"text":"No, it won't.\n\nPostmasters already know what a blacklist and a whitelist are. Do not invent new terms.","author_login":"marrco","author_association":"CONTRIBUTOR","created_at":"2019-11-19T09:31:13+08:00","repo_name":"mailcow/mailcow-dockerized","issue_id":524674898,"issue_number":3155,"issue_url":"https://github.com/mailcow/mailcow-dockerized/issues/3155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_558521220","fragment_type":"issue_comment","sequence":3,"text":"Racism was once widely established as well. I'm very sure that we all can agree that 'but it is established' shouldn't be used as an argument to avoid any improvements.\n \n\nIf those Postmasters won't be able to adapt to 2 (I repeat: **two**!) 'new' words they will probably have a bad time.\n\nJust a few examples why postmasters (or any other person in IT) will probably encounter replacements anyway:\n\n* have a look on this document the IETF recently published, which argues\n \n\n* or see what scientists think about it\n* or what Microsoft thinks about it and what they changed in the Chromium engine (you know, one of the popular browser engines)\n* what the Ruby on Rails members think about it (also this tweet)\n* or the folks at the graphite project\n* the HTML standard specification on whatwg\n* Rack attack\n* Roslyn\n* or the folks at GitLab\n\nSo my impression is, that if a company like Microsofts doesn't believe that those terms have to be established and manages to remove it for a code base like Chromium, it is _probably_ possible for others as well.","author_login":"alexanderadam","author_association":"NONE","created_at":"2019-11-26T08:35:28+08:00","repo_name":"mailcow/mailcow-dockerized","issue_id":524674898,"issue_number":3155,"issue_url":"https://github.com/mailcow/mailcow-dockerized/issues/3155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_558603194","fragment_type":"issue_comment","sequence":4,"text":"I don't think Mailcow is the right place for political discussions like this. While the intent may be laudable, it comes at a price in terms of clarity, brevity and unambiguity.\n\nFor example, replacing \"whitelist\" with \"allow list\" is ambiguous and unclear (you don't need to be on that list to be allowed to send mail) and \"spam filter bypass list\" is lengthy and not completely clear either.\n\nThere do not appear to be alternative terms in widespread use (Exchange has \"safe senders\", Gmail doesn't even have that feature), and as a small mail server platform, we are not in the position to define new terms. We need to make it as easy as possible for people migrating from other platforms. Once Exchange, Yahoo, Gmail, etc. converge on a new name, we will happily adopt it.","author_login":"mkuron","author_association":"MEMBER","created_at":"2019-11-26T12:16:35+08:00","repo_name":"mailcow/mailcow-dockerized","issue_id":524674898,"issue_number":3155,"issue_url":"https://github.com/mailcow/mailcow-dockerized/issues/3155","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0115","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Better integration with UI library: ...register() to pass e.g. error, helperText?","query_context":"**Is your feature request related to a problem? Please describe.**\nPardon me if I'm missing something, but it seems like a massive wasted opportunity not to let the register() function pass some additional props to the input component, such as in the case of MUI TextField `error` and `helperText`. Since it's already being spread anyway, it can just pass arbitrary props. Let me give an example. Currently our code looks like this:\n\njsx\n \n\nThat's a lot of boilerplate for every single input field, and our forms contain a lot of input fields. Given that DX is one of the goals of this project, I felt like this would be a great addition!\n\n**Describe the solution you'd like**\nInstead, the `register()` function passes `error` and `helperText` props to the component automatically. It already know we're dealing with the `first_name` here (because we pass that to `register()`) so it can use that to extract `error.first_name` and `errors.first_name.message`.\n\njsx\n \n\nOf course, different UI libraries use different props for `error` and `helperText`. There would need to be some way to tell react-hook-form what UI library the project is using so it can figure out which props to pass. Ideas? Also the `register()` function would need to be nicely typed so that you can spread it to your input component without unknown props errors.\n\n**Describe alternatives you've considered**\nThe alternative is to pass those props manually, which is error-prone, increases the SLOC of your component and thus decreases readability, and is just a waste of time for the developer.","known_context_document_ids":["gh_issue_1566221915"],"reference_answer":"<img width=\"613\" alt=\"image\" src=\" URL \n\nIt's working because there is no type check.","answer_document_id":"gh_comment_1174448809","silver_evidence_path":["gh_comment_1426504627","gh_issue_1291947895","gh_comment_1174448809"],"evidence_issue_ids":[1566221915,1291947895],"source_repo_name":"react-hook-form/react-hook-form","source_issue_id":1566221915,"source_issue_number":9851,"source_issue_url":"https://github.com/react-hook-form/react-hook-form/issues/9851","target_repo_name":"react-hook-form/react-hook-form","target_issue_id":1291947895,"target_issue_number":8619,"target_issue_url":"https://github.com/react-hook-form/react-hook-form/issues/8619","reference_anchor_document_id":"gh_comment_1426504627","reference_answer_author":"bluebill1049","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1077,"anchor_target_overlap":0.1692,"target_answer_overlap":0.3},"issue_created_at":"2023-02-01T14:31:26+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_1566221915","fragment_type":"issue_description","sequence":0,"text":"Better integration with UI library: ...register() to pass e.g. error, helperText\n**Is your feature request related to a problem? Please describe.**\nPardon me if I'm missing something, but it seems like a massive wasted opportunity not to let the register() function pass some additional props to the input component, such as in the case of MUI TextField `error` and `helperText`. Since it's already being spread anyway, it can just pass arbitrary props. Let me give an example. Currently our code looks like this:\n\njsx\n \n\nThat's a lot of boilerplate for every single input field, and our forms contain a lot of input fields. Given that DX is one of the goals of this project, I felt like this would be a great addition!\n\n**Describe the solution you'd like**\nInstead, the `register()` function passes `error` and `helperText` props to the component automatically. It already know we're dealing with the `first_name` here (because we pass that to `register()`) so it can use that to extract `error.first_name` and `errors.first_name.message`.\n\njsx\n \n\nOf course, different UI libraries use different props for `error` and `helperText`. There would need to be some way to tell react-hook-form what UI library the project is using so it can figure out which props to pass. Ideas? Also the `register()` function would need to be nicely typed so that you can spread it to your input component without unknown props errors.\n\n**Describe alternatives you've considered**\nThe alternative is to pass those props manually, which is error-prone, increases the SLOC of your component and thus decreases readability, and is just a waste of time for the developer.","author_login":"Lesik","author_association":"NONE","created_at":"2023-02-01T14:31:26+08:00","repo_name":"react-hook-form/react-hook-form","issue_id":1566221915,"issue_number":9851,"issue_url":"https://github.com/react-hook-form/react-hook-form/issues/9851","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1412780457","fragment_type":"issue_comment","sequence":1,"text":"I approached this issue slightly differently. I created a wrapper component for each general type of input field (text, checkbox, select, etc.) that combined the following features:\n\n- Renders components using the UI framework of my choice (react-bootstrap here)\n- Incorporates react-hook-form by passing in the **register** and **FieldError** objects for this particular field.\n\nThat way, I can pull whatever I need out of the RHF objects, and adapt to improvements in later versions without having to change my component's API.\n\nFull source for a TextField component for this (I made a reusable library for this kind of thing):\n\n URL \n\nExample of the use of this component in a form:","author_login":"craigmcc","author_association":"NONE","created_at":"2023-02-01T21:47:15+08:00","repo_name":"react-hook-form/react-hook-form","issue_id":1566221915,"issue_number":9851,"issue_url":"https://github.com/react-hook-form/react-hook-form/issues/9851","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1412856443","fragment_type":"issue_comment","sequence":2,"text":"Thanks for the feature request, unfortunately, this is currently out of scope within this library. If you are using MUI, this library may just be your friend: URL","author_login":"bluebill1049","author_association":"MEMBER","created_at":"2023-02-01T22:57:49+08:00","repo_name":"react-hook-form/react-hook-form","issue_id":1566221915,"issue_number":9851,"issue_url":"https://github.com/react-hook-form/react-hook-form/issues/9851","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1425425126","fragment_type":"issue_comment","sequence":3,"text":"Hi @craigmcc, thanks for your suggestion. Perhaps I'm not understanding it right, but it looks like with the approach you took, you would still need to pass the error object to the `error` prop to your custom component.\n \n \n \n \n \n \n \n\nWhile your approach eliminates one prop to pass (both the error state and the error text are handled in one prop), in this ticket, I was suggesting to include the `error` prop as one of the fields in the object that `register()` provides, in order to eliminate needing to pass the `error` prop entirely. RHF has the data of that `error` object anyway, just in a different place (`formState`), so all that would be needed to do is to also include it in `register()`'s return value.\n\nCombining this `register()` function that I'm suggesting with your approach of custom text field component, one gets two benefits:\n\n1. Reduce amount of props related to RHF to 1, namely the `register` prop.\n\n \njs\n \n \n\n2. No need to manually pick out the right error from the `errors` object based on the field's name, which is prone to error because it's up to the developer to make sure that the field name is the same as what they pick out from the `errors` object. There's nothing that would catch that oversight until it's deployed and noticed by a user entering the form. Especially bad for aria tags which might not be caught with the eye alone.\n\n \njs\n // this mistake is easily possible with the current version of RHF\n \n \n\nI'm guessing the reason why this library went with the a bit awkward approach of having to extract the errors from a separate object is because the idea was that `register()` would only include props that a native HTML `input` element can accept. Fair enough, but then perhaps a separate `registerAll()` function would be a nice idea, that would pass basically all the information that RHF has about a given field, and make it up to the developer to run it through a custom component and assign the right props to the right places? I'm not entirely sure about the specifics, but `registerAll()` could return an object with one field containing the original `register()` (so the props intended to be passed to the HTML input field) and some more fields like `error` (and potentially other in the future) that contain additional information about the field.\n\nExample usage:\n\njs\nexport const Form = () => {\n const { registerAll } = useForm();\n\n return (\n \n );\n}\n\nexport const MyTextField = ({ registerAll: {\n inputProps,\n error,\n}, label }) => (\n \n { label } \n \n {!!error && {error?.message} \n \n);","author_login":"Lesik","author_association":"NONE","created_at":"2023-02-10T08:43:02+08:00","repo_name":"react-hook-form/react-hook-form","issue_id":1566221915,"issue_number":9851,"issue_url":"https://github.com/react-hook-form/react-hook-form/issues/9851","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1426504627","fragment_type":"issue_comment","sequence":4,"text":"The reason I went to passing error was a compile error that RHF caused me\naround 7.33.1). I used to pass \"errors: FieldErrors\" so I could (for\nexample) pull out both error messages on something like a password mismatch\nwhen updating your user profile.\n\nI reported this on\n URL but, even\nafter supplying the requested CSB, it wasn't ever addressed. I was stuck\nnot being able to upgrade until I happened to see in a Stack Overflow post\nthat you could pass the individual error itself. That at least gave me a\nway to upgrade RHF versions (albeit requiring me to adjust the props for\nall my components in all my apps).\n\nI agree that incorporating the error property into what already has to be\npassed in would be an improvement.\n\nCraig\n\nOn Fri, Feb 10, 2023 at 12:43 AM Lesik ***@***.***> wrote:","author_login":"craigmcc","author_association":"NONE","created_at":"2023-02-10T23:53:14+08:00","repo_name":"react-hook-form/react-hook-form","issue_id":1566221915,"issue_number":9851,"issue_url":"https://github.com/react-hook-form/react-hook-form/issues/9851","linked_issue_ids":[1291947895],"is_known_query_context":false},{"document_id":"gh_issue_1291947895","fragment_type":"issue_description","sequence":0,"text":"issue: API Breakage on FieldErrors\n### Version Number\n\n7.33.1\n\n### Codesandbox/Expo snack\n\nCompile error, so no code sandbox is available.\n\n### Steps to reproduce\n\nI am building out a set of Typescript React components (based on react-hook-form and react-bootstrap). The source code for this library is at:\n\n URL \n\nWith react-hook-form 7.30.0, everything was fine.\nWith react-hook-form 7.33.1, I get compile errors trying to build the library (see the \"Relevant Log Output\" section below).\n\nIt looks like changes to the FieldErrors definition is what is triggering this.\n\nTO REPRODUCE:\n* Download the GItHub module mentioned above.\n* Run \"npm install\" to install the listed dependencies.\n* Run \"npm install react-hook-form@7.33.1\" to get the version that causes the problem.\n* Run \"npm build\" and see the compile errors (shown in the \"Relevant log output\" section below).\n\n### Expected behaviour\n\nNo compile errors.\n\n### What browsers are you seeing the problem on?\n\nChrome\n\n### Relevant log output\n\nshell\nCOMPILE OUTPUT:\n==============\n\nMacBook-Pro:shared-react craigmcc$ npm run build\n \n \n\nsrc/SelectField/SelectField.tsx:71:17 - error TS2322: Type 'Merge >> | undefined' is not assignable to type 'ReactNode'.\n Type 'Merge >>' is not assignable to type 'ReactNode'.\n Type 'Merge >>' is missing the following properties from type 'ReactPortal': key, children, type, props\n\n71 {props.errors[props.name]?.message}\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\n node_modules/@types/react/index.d.ts:1374:9\n 1374 children?: ReactNode | undefined;\n ~~~~~~~~\n The expected type comes from property 'children' which is declared here on type 'IntrinsicAttributes & Omit , HTMLDivElement>, \"key\" | keyof HTMLAttributes > & { ...; }, BsPrefixProps & FeedbackProps> & BsPrefixProps & FeedbackProps & { ...; }'\n\nsrc/TextField/TextField.tsx:66:17 - error TS2322: Type 'Merge >> | undefined' is not assignable to type 'ReactNode'.\n\n66 {props.errors[props.name]?.message}\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\n node_modules/@types/react/index.d.ts:1374:9\n 1374 children?: ReactNode | undefined;\n ~~~~~~~~\n The expected type comes from property 'children' which is declared here on type 'IntrinsicAttributes & Omit , HTMLDivElement>, \"key\" | keyof HTMLAttributes > & { ...; }, BsPrefixProps & FeedbackProps> & BsPrefixProps & FeedbackProps & { ...; }'\n\nFound 2 errors in 2 files.\n\nErrors Files\n 1 src/SelectField/SelectField.tsx:71\n 1 src/TextField/TextField.tsx:66\n\n### Code of Conduct\n\n- [X] I agree to follow this project's Code of Conduct","author_login":"craigmcc","author_association":"NONE","created_at":"2022-07-02T03:00:00+08:00","repo_name":"react-hook-form/react-hook-form","issue_id":1291947895,"issue_number":8619,"issue_url":"https://github.com/react-hook-form/react-hook-form/issues/8619","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1172826934","fragment_type":"issue_comment","sequence":1,"text":"please follow the issue template by providing a codesandbox to reproduce this issue then will reopen and look into it.","author_login":"bluebill1049","author_association":"MEMBER","created_at":"2022-07-02T03:48:21+08:00","repo_name":"react-hook-form/react-hook-form","issue_id":1291947895,"issue_number":8619,"issue_url":"https://github.com/react-hook-form/react-hook-form/issues/8619","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1172977961","fragment_type":"issue_comment","sequence":2,"text":"Codesandbox link: URL \n\nAlthough the app runs in the sandbox (it fails for me locally), if you open src/TextField.tsx and src/MyForm.tsx you will see the highlighted errors.\n\nChange the react-hook-form dependency to 7.32 and it makes those errors go away.","author_login":"craigmcc","author_association":"NONE","created_at":"2022-07-02T23:28:34+08:00","repo_name":"react-hook-form/react-hook-form","issue_id":1291947895,"issue_number":8619,"issue_url":"https://github.com/react-hook-form/react-hook-form/issues/8619","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1173190386","fragment_type":"issue_comment","sequence":3,"text":"Same problem. The typedef has some sort of breaking change where it no longer passes a string.","author_login":"shamilovtim","author_association":"NONE","created_at":"2022-07-03T23:16:40+08:00","repo_name":"react-hook-form/react-hook-form","issue_id":1291947895,"issue_number":8619,"issue_url":"https://github.com/react-hook-form/react-hook-form/issues/8619","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1173458369","fragment_type":"issue_comment","sequence":4,"text":"Same problem. Something is off with the typedef…\n\n`TS2367: This condition will always return 'false' since the types 'Merge >> | undefined' and 'string' have no overlap.\n 199 | maxLength: 110,\n 200 | }}\n \n | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n 202 | />`","author_login":"quadrifolia","author_association":"NONE","created_at":"2022-07-04T07:34:41+08:00","repo_name":"react-hook-form/react-hook-form","issue_id":1291947895,"issue_number":8619,"issue_url":"https://github.com/react-hook-form/react-hook-form/issues/8619","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1173485646","fragment_type":"issue_comment","sequence":5,"text":"can you provide a codesandbox to reproduce the issue or supply a test case to demonstrate the issue?\n\nScreen Shot 2022-07-04 at 6 02 15 pm","author_login":"bluebill1049","author_association":"MEMBER","created_at":"2022-07-04T08:02:38+08:00","repo_name":"react-hook-form/react-hook-form","issue_id":1291947895,"issue_number":8619,"issue_url":"https://github.com/react-hook-form/react-hook-form/issues/8619","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1174448809","fragment_type":"issue_comment","sequence":6,"text":"<img width=\"613\" alt=\"image\" src=\" URL \n\nIt's working because there is no type check.","author_login":"bluebill1049","author_association":"MEMBER","created_at":"2022-07-04T23:06:36+08:00","repo_name":"react-hook-form/react-hook-form","issue_id":1291947895,"issue_number":8619,"issue_url":"https://github.com/react-hook-form/react-hook-form/issues/8619","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0117","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Column access to tables?","query_context":"With #17 we have defined a simple table structure, but we have no simple way to get a numpy array of the columns, for instance, we might hope to be able to get\n\npython\nchild_left = TableCollection.intervals.child_left\n\nOr even set a whole column:\n\npython\nTableCollection.intervals.child_left = child_left +1\n\n(we can't even do the latter in tskit, though)","known_context_document_ids":["gh_issue_1919641073"],"reference_answer":"The two example tests in test_tables.py should show you (a) how to use fixtures (e.g. if you want to import a standard GIG for testing in multiple tests) and (b) how to use `@pytest.mark.parametrize` to test a range of parameter values. Both of these are useful idioms.","answer_document_id":"gh_comment_1744739365","silver_evidence_path":["gh_comment_1742788938","gh_issue_1919841089","gh_comment_1744739365"],"evidence_issue_ids":[1919641073,1919841089],"source_repo_name":"hyanwong/GeneticInheritanceGraph","source_issue_id":1919641073,"source_issue_number":19,"source_issue_url":"https://github.com/hyanwong/GeneticInheritanceGraph/issues/19","target_repo_name":"hyanwong/GeneticInheritanceGraph","target_issue_id":1919841089,"target_issue_number":20,"target_issue_url":"https://github.com/hyanwong/GeneticInheritanceGraph/issues/20","reference_anchor_document_id":"gh_comment_1742788938","reference_answer_author":"hyanwong","reference_answer_author_association":"OWNER","quality_score":84.34,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.087,"anchor_target_overlap":0.1961,"target_answer_overlap":0.0476},"issue_created_at":"2023-09-29T17:09:40+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_1919641073","fragment_type":"issue_description","sequence":0,"text":"Column access to tables\nWith #17 we have defined a simple table structure, but we have no simple way to get a numpy array of the columns, for instance, we might hope to be able to get\n\npython\nchild_left = TableCollection.intervals.child_left\n\nOr even set a whole column:\n\npython\nTableCollection.intervals.child_left = child_left +1\n\n(we can't even do the latter in tskit, though)","author_login":"hyanwong","author_association":"OWNER","created_at":"2023-09-29T17:09:40+08:00","repo_name":"hyanwong/GeneticInheritanceGraph","issue_id":1919641073,"issue_number":19,"issue_url":"https://github.com/hyanwong/GeneticInheritanceGraph/issues/19","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1742549886","fragment_type":"issue_comment","sequence":1,"text":"I'd be happy to take this one on. I will see if I can replicate how its done with tskit data.","author_login":"duncanMR","author_association":"COLLABORATOR","created_at":"2023-10-02T07:49:43+08:00","repo_name":"hyanwong/GeneticInheritanceGraph","issue_id":1919641073,"issue_number":19,"issue_url":"https://github.com/hyanwong/GeneticInheritanceGraph/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1742788938","fragment_type":"issue_comment","sequence":2,"text":"Great. We could probably do a bit better than `tskit` for the interface. For example, it would be good to have something like this:\n\n URL \n\nIt would be much better if we could use `tables.nodes.time[x]` to get direct memory access, rather than the somewhat clunky `ts.nodes_time[x]`. You might well want to talk to @benjeffery about this. \n\nDo make sure, however, that we aren' \"prematurely optimising\". For the size of datasets we are experimenting on, there's no need to make this fast (yet). It's better to get a slow API that can be sped up later, under the hood.\n\nOnce we get to this stage, it's vital to start setting up unit tests, so #20 is important to tackle at the same time.","author_login":"hyanwong","author_association":"OWNER","created_at":"2023-10-02T10:44:52+08:00","repo_name":"hyanwong/GeneticInheritanceGraph","issue_id":1919641073,"issue_number":19,"issue_url":"https://github.com/hyanwong/GeneticInheritanceGraph/issues/19","linked_issue_ids":[1919841089],"is_known_query_context":false},{"document_id":"gh_issue_1919841089","fragment_type":"issue_description","sequence":0,"text":"Create testing infrastructure\nNow that we have some draft code, we could probably do with setting up a simple testing infrastructure framework, using pytest. It would be nice if this was run automatically for any PR, but that doesn't have to be the case, I guess.\n\nPresumably copying something like the tskit testing framework would be sensible? Thoughts @duncanMR? Have you dealt with much unit testing before?","author_login":"hyanwong","author_association":"OWNER","created_at":"2023-09-29T20:02:10+08:00","repo_name":"hyanwong/GeneticInheritanceGraph","issue_id":1919841089,"issue_number":20,"issue_url":"https://github.com/hyanwong/GeneticInheritanceGraph/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1742547265","fragment_type":"issue_comment","sequence":1,"text":"We'll definitely need to do this at some point. I've written a few tests, but I've never set up a testing system before. I'd like to learn how, though, so I'd like to take this one on. I think it would be sensible to start by writing the tests with pytest, then later figure out how to automatically run them with any PR?","author_login":"duncanMR","author_association":"COLLABORATOR","created_at":"2023-10-02T07:47:45+08:00","repo_name":"hyanwong/GeneticInheritanceGraph","issue_id":1919841089,"issue_number":20,"issue_url":"https://github.com/hyanwong/GeneticInheritanceGraph/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1744626982","fragment_type":"issue_comment","sequence":2,"text":"The infrastructure is basically there now, although the tests aren't. I will leave this open until we've made a few PRs to test that it's all working.","author_login":"hyanwong","author_association":"OWNER","created_at":"2023-10-03T09:55:32+08:00","repo_name":"hyanwong/GeneticInheritanceGraph","issue_id":1919841089,"issue_number":20,"issue_url":"https://github.com/hyanwong/GeneticInheritanceGraph/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1744661812","fragment_type":"issue_comment","sequence":3,"text":"An easy task is to get coverage up to 100% in tables.py and util.py. See \n\n URL","author_login":"hyanwong","author_association":"OWNER","created_at":"2023-10-03T10:16:18+08:00","repo_name":"hyanwong/GeneticInheritanceGraph","issue_id":1919841089,"issue_number":20,"issue_url":"https://github.com/hyanwong/GeneticInheritanceGraph/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1744739365","fragment_type":"issue_comment","sequence":4,"text":"The two example tests in test_tables.py should show you (a) how to use fixtures (e.g. if you want to import a standard GIG for testing in multiple tests) and (b) how to use `@pytest.mark.parametrize` to test a range of parameter values. Both of these are useful idioms.","author_login":"hyanwong","author_association":"OWNER","created_at":"2023-10-03T11:07:19+08:00","repo_name":"hyanwong/GeneticInheritanceGraph","issue_id":1919841089,"issue_number":20,"issue_url":"https://github.com/hyanwong/GeneticInheritanceGraph/issues/20","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0120","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Password presence validation bizarre behaviour?","query_context":"User model\n\nruby\nclass User true\n\nfound_user = User.last\nfound_user.update!(name: \"Other\", password: \"\")\n# => Validation failed: Password can't be blank (ActiveRecord::RecordInvalid)\n\nMore info on:\nWhy would `has_secure_password` suppress password validation on update, but only if the object is newly created?\n\nMay I ask this behaviour is intended or it's a bug?","known_context_document_ids":["gh_issue_2388408787"],"reference_answer":"I don't think the problem is on those conditionals. `''` is empty so the password_digest would not be updated. The validation doesn't fail because the digest is still the same as before and no changes to the database will be made.\n\nWe have a test for it\n URL So an empty password doesn't change the current password so it is still valid.\n\nIf I remember correctly we tried to fix this before and I'm almost sure there is a reason for this behavior. But please investigate.","answer_document_id":"gh_comment_434361126","silver_evidence_path":["gh_comment_2207625700","gh_issue_375450743","gh_comment_434361126"],"evidence_issue_ids":[2388408787,375450743],"source_repo_name":"rails/rails","source_issue_id":2388408787,"source_issue_number":52264,"source_issue_url":"https://github.com/rails/rails/issues/52264","target_repo_name":"rails/rails","target_issue_id":375450743,"target_issue_number":34348,"target_issue_url":"https://github.com/rails/rails/issues/34348","reference_anchor_document_id":"gh_comment_2207625700","reference_answer_author":"rafaelfranca","reference_answer_author_association":"MEMBER","quality_score":93.71,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0714,"anchor_target_overlap":0.2857,"target_answer_overlap":0.2941},"issue_created_at":"2024-07-03T11:39:43+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_2388408787","fragment_type":"issue_description","sequence":0,"text":"Password presence validation bizarre behaviour\nUser model\n\nruby\nclass User true\n\nfound_user = User.last\nfound_user.update!(name: \"Other\", password: \"\")\n# => Validation failed: Password can't be blank (ActiveRecord::RecordInvalid)\n\nMore info on:\nWhy would `has_secure_password` suppress password validation on update, but only if the object is newly created?\n\nMay I ask this behaviour is intended or it's a bug?","author_login":"chiaraani","author_association":"NONE","created_at":"2024-07-03T11:39:43+08:00","repo_name":"rails/rails","issue_id":2388408787,"issue_number":52264,"issue_url":"https://github.com/rails/rails/issues/52264","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2205903056","fragment_type":"issue_comment","sequence":1,"text":"Repro:\n\nrb\n# frozen_string_literal: true\n\nrequire \"bundler/inline\"\n\ngemfile(true) do\n source \" URL \n\n gem \"rails\"\n # If you want to test against edge Rails replace the previous line with this:\n # gem \"rails\", github: \"rails/rails\", branch: \"main\"\n\n gem \"sqlite3\", \"~> 1.4\"\n gem 'bcrypt', '~> 3.1.7'\nend\n\nrequire \"active_record\"\nrequire \"minitest/autorun\"\nrequire \"logger\"\n\n# This connection will do for database-independent bug reports.\nActiveRecord::Base.establish_connection(adapter: \"sqlite3\", database: \":memory:\")\nActiveRecord::Base.logger = Logger.new(STDOUT)\n\nActiveRecord::Schema.define do\n create_table :users, force: true do |t|\n t.text :password_digest\n end\nend\n\nclass User < ActiveRecord::Base\n has_secure_password\n validates :password, presence: true\nend\n\nclass BugTest < Minitest::Test\n def test_create # ✅\n assert_raises(ActiveRecord::RecordInvalid) do\n User.create!(password: \"\")\n end\n end\n\n def test_update # ✅\n user = User.create!(password: \"abc123\")\n assert_raises(ActiveRecord::RecordInvalid) do\n user.update!(password: \"\")\n end\n end\n\n def test_update_reload # 💣\n User.create!(password: \"abc123\")\n user = User.last\n assert_raises(ActiveRecord::RecordInvalid) do\n user.update!(password: \"\")\n end\n end\nend","author_login":"Earlopain","author_association":"CONTRIBUTOR","created_at":"2024-07-03T11:56:00+08:00","repo_name":"rails/rails","issue_id":2388408787,"issue_number":52264,"issue_url":"https://github.com/rails/rails/issues/52264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2206196913","fragment_type":"issue_comment","sequence":2,"text":"The bizarre behaviour does not arise when I make a new model object, in other words, when I find a record, but only when I reload the new record.\n\nruby\ncreated_user = User.create!(name: \"Foo\", password: \"abc123\")\ncreated_user.reload.update!(name: \"Bar\", password: \"\")\n# => true\n\nfound_user = User.last\nfound_user.update!(name: \"Other\", password: \"\")\n# => Validation failed: Password can't be blank (ActiveRecord::RecordInvalid)","author_login":"chiaraani","author_association":"NONE","created_at":"2024-07-03T14:06:00+08:00","repo_name":"rails/rails","issue_id":2388408787,"issue_number":52264,"issue_url":"https://github.com/rails/rails/issues/52264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2207625700","fragment_type":"issue_comment","sequence":3,"text":"I'm afraid there's a discussion already about that topic on #34348, and the implementation is quite clear about it not raising errors and keeping the old password when it's empty here.","author_login":"ruyrocha","author_association":"CONTRIBUTOR","created_at":"2024-07-04T00:18:27+08:00","repo_name":"rails/rails","issue_id":2388408787,"issue_number":52264,"issue_url":"https://github.com/rails/rails/issues/52264","linked_issue_ids":[375450743],"is_known_query_context":false},{"document_id":"gh_issue_375450743","fragment_type":"issue_description","sequence":0,"text":"Updating password defined by `has_secured_password` with empty string does not trigger validation error\n### Steps to reproduce\n\nruby\n#!/usr/bin/env ruby\n# frozen_string_literal: true\n\nbegin\n require \"bundler/inline\"\nrescue LoadError => e\n $stderr.puts \"Bundler version 1.10 or later is required. Please update your Bundler\"\n raise e\nend\n\ngemfile(true) do\n source \" URL \n gem \"activerecord\", \"5.2.1\"\n gem \"sqlite3\"\n gem \"bcrypt\"\nend\n\nrequire \"active_record\"\nrequire \"minitest/autorun\"\n\nActiveRecord::Base.establish_connection(adapter: \"sqlite3\", database: \":memory:\")\n\nActiveRecord::Schema.define do\n create_table :users, force: true do |t|\n t.string \"password_digest\"\n end\nend\n\nclass User < ActiveRecord::Base\n has_secure_password\nend\n\nclass TestBlankPasswords < Minitest::Test\n def test_creating_with_nil_password\n user = User.create(password: nil)\n assert_equal 1, user.errors.count\n end\n\n def test_creating_with_empty_password\n user = User.create(password: '')\n assert_equal 1, user.errors.count\n end\n\n def test_updating_with_nil_password\n existing_user = User.create!(password: 'password')\n\n existing_user.update(password: nil)\n assert_equal 1, existing_user.errors.count\n end\n\n def test_updating_with_empty_password\n existing_user = User.create!(password: 'password')\n\n existing_user.update(password: '')\n assert_equal 1, existing_user.errors.count\n end\nend\n\n### Expected behavior\nActive Record classes that define a password with `has_secure_password`, when I try to update a record that already exists by setting the password to an empty string, I should get a validation error on password. \n\n### Actual behavior\nThe blank password is ignored and no validation errors are triggered.\n\n### System configuration\n**Rails version**: `5.2.1`\n\n**Ruby version**: `2.4.2`\n\n### Additional notes\nUpdating a password to an empty string should have the same behavior as setting it to `nil`, which is to trigger a validation error. The issue seems to be caused by these two if statements. I could submit the PR to fix the issue if needed.","author_login":"jordinl83","author_association":"NONE","created_at":"2018-10-30T11:53:42+08:00","repo_name":"rails/rails","issue_id":375450743,"issue_number":34348,"issue_url":"https://github.com/rails/rails/issues/34348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_434361126","fragment_type":"issue_comment","sequence":1,"text":"I don't think the problem is on those conditionals. `''` is empty so the password_digest would not be updated. The validation doesn't fail because the digest is still the same as before and no changes to the database will be made.\n\nWe have a test for it\n URL So an empty password doesn't change the current password so it is still valid.\n\nIf I remember correctly we tried to fix this before and I'm almost sure there is a reason for this behavior. But please investigate.","author_login":"rafaelfranca","author_association":"MEMBER","created_at":"2018-10-30T16:00:45+08:00","repo_name":"rails/rails","issue_id":375450743,"issue_number":34348,"issue_url":"https://github.com/rails/rails/issues/34348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_434569910","fragment_type":"issue_comment","sequence":2,"text":"I think that the reason the password is ignored for empty strings is that if a user has a form with multiple fields (including password) and they update details but don't enter the password, then we want to allow the other details to be updated without the password being effected.","author_login":"lsylvester","author_association":"CONTRIBUTOR","created_at":"2018-10-31T05:54:31+08:00","repo_name":"rails/rails","issue_id":375450743,"issue_number":34348,"issue_url":"https://github.com/rails/rails/issues/34348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_434844849","fragment_type":"issue_comment","sequence":3,"text":"In my opinion the current implentation has the least surprise when using `form.password_field` and `update(params.permit(:password))`, and would make the controller code ugly having to prepare the params by deleting the password param if it is blank.\n\nCan you outline the scenario where this behaviour is causing an issue? Maybe you could be clearing the password_digest before setting the password as it would force the blank validation to run.","author_login":"lsylvester","author_association":"CONTRIBUTOR","created_at":"2018-10-31T20:57:07+08:00","repo_name":"rails/rails","issue_id":375450743,"issue_number":34348,"issue_url":"https://github.com/rails/rails/issues/34348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_435028322","fragment_type":"issue_comment","sequence":4,"text":"@lsylvester this is for an API, so if I get an empty string I should return a validation error. There are obviously ways around this \"limitation\", I just find odd that rails ignores empty strings for password fields but it doesn't for other types of inputs.","author_login":"jordinl83","author_association":"NONE","created_at":"2018-11-01T12:40:12+08:00","repo_name":"rails/rails","issue_id":375450743,"issue_number":34348,"issue_url":"https://github.com/rails/rails/issues/34348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_435067335","fragment_type":"issue_comment","sequence":5,"text":"@lsylvester Or we can provide the user with an option of having no password by using a checkbox param for passwords, and ignore the password param on the basis of it.","author_login":"snpd25","author_association":"NONE","created_at":"2018-11-01T14:57:41+08:00","repo_name":"rails/rails","issue_id":375450743,"issue_number":34348,"issue_url":"https://github.com/rails/rails/issues/34348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_615856794","fragment_type":"issue_comment","sequence":6,"text":"I have a scenario. By default a minimum password length isn't enforced. I'd like to have the following:\n\nvalidates_length_of :password, minimum: 8, allow_nil: true, on: :update\n\nOn create I set the password to a random string and require the user to activate the account via an email link that they click to set their actual password.\n\nThe validation works fine provided the password has at least one character. An empty string causes the setter to bypass setting the password resulting in the validation being bypassed (due to `nil`).\n\nI don't see a way around this other than to override the setter so that an empty string still sets the instance variable then `super` from there. Am I missing something?","author_login":"brendon","author_association":"CONTRIBUTOR","created_at":"2020-04-18T12:17:15+08:00","repo_name":"rails/rails","issue_id":375450743,"issue_number":34348,"issue_url":"https://github.com/rails/rails/issues/34348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_630441387","fragment_type":"issue_comment","sequence":7,"text":"For those interested in finding a way through to fixing this, there is a discussion here: URL","author_login":"brendon","author_association":"CONTRIBUTOR","created_at":"2020-05-18T21:20:28+08:00","repo_name":"rails/rails","issue_id":375450743,"issue_number":34348,"issue_url":"https://github.com/rails/rails/issues/34348","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0121","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Support for setting an alternate subscriptionId as a resource parameter?","query_context":"### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n\n### Community Note\n\n \n\n* Please vote on this issue by adding a :thumbsup: reaction to the original issue to help the community and maintainers prioritize this request\n* Please do not leave \"+1\" or \"me too\" comments, they generate extra noise for issue followers and do not help prioritize the request\n* If you are interested in working on this issue or have submitted a pull request, please leave a comment\n\n \n\n### Description\n\nCurrently in order to support multiple subscriptions, one needs to specify multiple aliases as different providers, since currently the azurerm provider has a 1-to-1 relationship between the authentication credentials and subscriptions.\n\nHowever, from an Azure API perspective, the relationship between authentication credentials and subscriptions is actually a 1-to-N.\n\nThe main drawback of the current method used by azurerm is that the subscriptionIds must be known beforehand (to be declared); therefore it's not possible to work with multiple dynamic subscriptions, at least not without the usage of an external helper to declare them as provider aliases directly in the TF files.\n\nMy proposal is to allow any resource to specify an alternative subscriptionId (different from the one specified within the provider block) as part of the resource parameters.\n\nThis way, subscriptions can be created/updated/destroyed dynamically, and their values could be reused to populate such this resource parameter.\n\n### New or Affected Resource(s)/Data Source(s)\n\nazurerm_*\n\n### Potential Terraform Configuration\n\nhcl\nprovider \"azurerm\" {\n client_id = \"nono\"\n client_secret = \"nono\"\n subscription_id = \"XXX\" \n tenant_id = \"nono\"\n}\n\n# Sample resource using the default subscription (coming from provider block)\nresource \"azurerm_private_dns_zone\" \"zoneXXX\" {\n name = \"XXX.domain\"\n resource_group_name = azurerm_resource_group.xxx.name\n}\n\n# Sample resource using the custom subscription \nresource \"azurerm_private_dns_zone\" \"zoneYYY\" {\n name = \"YYY.domain\"\n subscription_id = \"YYY\"\n resource_group_name = azurerm_resource_group.yyy.name\n}\n\n### References\n\n_No response_","known_context_document_ids":["gh_issue_1473255289"],"reference_answer":"@bhupinder-azenix Can you use the provider alias of `subscriptionA` to create this resource and assign whatever you have in `${data.azurerm_client_config.this.subscription_id}` as `subscription_id`? That should be equivalent to above azapi config.","answer_document_id":"gh_comment_1336817682","silver_evidence_path":["gh_comment_1336790016","gh_issue_1470899703","gh_comment_1336817682"],"evidence_issue_ids":[1473255289,1470899703],"source_repo_name":"hashicorp/terraform-provider-azurerm","source_issue_id":1473255289,"source_issue_number":19539,"source_issue_url":"https://github.com/hashicorp/terraform-provider-azurerm/issues/19539","target_repo_name":"hashicorp/terraform-provider-azurerm","target_issue_id":1470899703,"target_issue_number":19520,"target_issue_url":"https://github.com/hashicorp/terraform-provider-azurerm/issues/19520","reference_anchor_document_id":"gh_comment_1336790016","reference_answer_author":"magodo","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1176,"anchor_target_overlap":0.2353,"target_answer_overlap":0.3571},"issue_created_at":"2022-12-02T18:08:58+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_1473255289","fragment_type":"issue_description","sequence":0,"text":"Support for setting an alternate subscriptionId as a resource parameter\n### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n\n### Community Note\n\n \n\n* Please vote on this issue by adding a :thumbsup: reaction to the original issue to help the community and maintainers prioritize this request\n* Please do not leave \"+1\" or \"me too\" comments, they generate extra noise for issue followers and do not help prioritize the request\n* If you are interested in working on this issue or have submitted a pull request, please leave a comment\n\n \n\n### Description\n\nCurrently in order to support multiple subscriptions, one needs to specify multiple aliases as different providers, since currently the azurerm provider has a 1-to-1 relationship between the authentication credentials and subscriptions.\n\nHowever, from an Azure API perspective, the relationship between authentication credentials and subscriptions is actually a 1-to-N.\n\nThe main drawback of the current method used by azurerm is that the subscriptionIds must be known beforehand (to be declared); therefore it's not possible to work with multiple dynamic subscriptions, at least not without the usage of an external helper to declare them as provider aliases directly in the TF files.\n\nMy proposal is to allow any resource to specify an alternative subscriptionId (different from the one specified within the provider block) as part of the resource parameters.\n\nThis way, subscriptions can be created/updated/destroyed dynamically, and their values could be reused to populate such this resource parameter.\n\n### New or Affected Resource(s)/Data Source(s)\n\nazurerm_*\n\n### Potential Terraform Configuration\n\nhcl\nprovider \"azurerm\" {\n client_id = \"nono\"\n client_secret = \"nono\"\n subscription_id = \"XXX\" \n tenant_id = \"nono\"\n}\n\n# Sample resource using the default subscription (coming from provider block)\nresource \"azurerm_private_dns_zone\" \"zoneXXX\" {\n name = \"XXX.domain\"\n resource_group_name = azurerm_resource_group.xxx.name\n}\n\n# Sample resource using the custom subscription \nresource \"azurerm_private_dns_zone\" \"zoneYYY\" {\n name = \"YYY.domain\"\n subscription_id = \"YYY\"\n resource_group_name = azurerm_resource_group.yyy.name\n}\n\n### References\n\n_No response_","author_login":"emerzon","author_association":"NONE","created_at":"2022-12-02T18:08:58+08:00","repo_name":"hashicorp/terraform-provider-azurerm","issue_id":1473255289,"issue_number":19539,"issue_url":"https://github.com/hashicorp/terraform-provider-azurerm/issues/19539","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1336790016","fragment_type":"issue_comment","sequence":1,"text":"Hi @emerzon, thank you for reaching out.\nThis problem is similar with this common issue. We will try to address it after the whole provider is migrated to use Hashicorp Azure SDK.","author_login":"ms-zhenhua","author_association":"CONTRIBUTOR","created_at":"2022-12-05T06:02:45+08:00","repo_name":"hashicorp/terraform-provider-azurerm","issue_id":1473255289,"issue_number":19539,"issue_url":"https://github.com/hashicorp/terraform-provider-azurerm/issues/19539","linked_issue_ids":[1470899703],"is_known_query_context":false},{"document_id":"gh_comment_1563142343","fragment_type":"issue_comment","sequence":2,"text":"hey @emerzon\n\nApologies thought I'd already replied to this one, I guess I wrote the comment but forgot to hit submit 😅\n\nInternally the Provider has a number of expectations/requirements where a Provider Instance has a 1:1 relationship with a Subscription - as such whilst this has come up a few times over the years, unfortunately this isn't something we plan to implement at this point in time.\n\nThat said I totally understand the use-case here, and there's a feature request on Terraform Core which I think will solve this for you in a different manner - as such whilst this isn't something we plan to support at the Provider level, I'd encourage you to comment on/subscribe to this upstream issue tracking support for Dynamic Providers, since once support for this is implemented there then this should be usable with every Provider rather than just being tied to AzureRM.\n\nWhilst I appreciate that's probably not the answer you're looking for, since this isn't something we plan to implement within the Provider I'm going to close this issue for the moment - but when this functionality is supported in Terraform (Core) then this should be usable across all Providers, which'll fix this in a different manner.\n\nThanks!","author_login":"tombuildsstuff","author_association":"MEMBER","created_at":"2023-05-25T15:54:04+08:00","repo_name":"hashicorp/terraform-provider-azurerm","issue_id":1473255289,"issue_number":19539,"issue_url":"https://github.com/hashicorp/terraform-provider-azurerm/issues/19539","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1470899703","fragment_type":"issue_description","sequence":0,"text":"azurerm_sentinel_data_connector_azure_security_center comes up with \"ResourceGroupNotFound\" when trying to enable azure_security_center connector on different subscription\n### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n\n### Community Note\n\n \n\n* Please vote on this issue by adding a :thumbsup: reaction to the original issue to help the community and maintainers prioritize this request\n* Please do not leave \"+1\" or \"me too\" comments, they generate extra noise for issue followers and do not help prioritize the request\n* If you are interested in working on this issue or have submitted a pull request, please leave a comment\n\n \n\n### Terraform Version\n\n1.3.6\n\n### AzureRM Provider Version\n\n3.33.0\n\n### Affected Resource(s)/Data Source(s)\n\nazurerm_sentinel_data_connector_azure_security_center\n\n### Terraform Configuration Files\n\nhcl\nresource \"azurerm_sentinel_data_connector_azure_security_center\" \"adfc\" {\n name = \"adfc\"\n log_analytics_workspace_id = data.azurerm_log_analytics_workspace.this.id\n subscription_id = data.azurerm_subscription.uat.subscription_id\n\n### Debug Output/Panic Output\n\nshell\nTF plan shows below and works well:\n\n+ resource \"azurerm_sentinel_data_connector_azure_security_center\" \"adfc\" {\n + id = (known after apply)\n + log_analytics_workspace_id = \"/subscriptions/xxx-xxx-xxxx-xxxx/resourceGroups/testing-rg/providers/Microsoft.OperationalInsights/workspaces/test-workspace\"\n + name = \"ADFC\"\n + subscription_id = \"xxx-xxx-xxxx-xxxx\"\n }\n\n### Expected Behaviour\n\nAzure Security Center (AKA Defender for cloud) data connector should have been enabled on different subscription.\n\n### Actual Behaviour\n\nazurerm_sentinel_data_connector_azure_security_center.this: Creating...\n╷\n│ Error: creating Data Connector: (Name \"ADFC\" / Workspace Name \"test-workspace\" / Resource Group \"testing-rg\"): securityinsight.DataConnectorsClient#CreateOrUpdate: Failure responding to request: StatusCode=404 -- Original Error: autorest/azure: Service returned an error. Status=404 Code=\"ResourceGroupNotFound\" Message=\"Resource group 'testing-rg' could not be found.\"\n\n### Steps to Reproduce\n\n1: Create a log analytics workspace in one subscription and enable \"azurerm_security_center_subscription_pricing\" within the same subscription.\n\n2: Create \"azurerm_log_analytics_solution\" for SecurityInsights (Sentinel) with in same subscription.\n\n3: Create \"azurerm_sentinel_data_connector_azure_security_center\" with in same subscription (Where log analytics workspace exist).\n\n4: No issue for above 3 steps However when we want to enable sentinel data connector \"azurerm_sentinel_data_connector_azure_security_center\" on different subscription by using log analytics workspace from another subscription then we get the error \"ResourceGroupNotFound\". Looks like TF is trying to find the resource Group in the same Subscription rather than in another subscription.\n\n### Important Factoids\n\n_No response_\n\n### References\n\nSimilar issue even it's for different resource URL","author_login":"bhupinder-azenix","author_association":"NONE","created_at":"2022-12-01T08:35:58+08:00","repo_name":"hashicorp/terraform-provider-azurerm","issue_id":1470899703,"issue_number":19520,"issue_url":"https://github.com/hashicorp/terraform-provider-azurerm/issues/19520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1334698607","fragment_type":"issue_comment","sequence":1,"text":"@bhupinder-azenix This is a common issue among the provider. The issue is because currently we are initializing the Azure SDK client with the subscription id bound the the provider when provider got initialized. Then every API call will bound to the that subscription.\n\nIn long term, we'll transfer to using the Hashicorp Azure SDK, which shall hopefully solve this limitation. In short term, you can use another provider block (with an alias), that is bound to the second subscription you want to use, for this data connector.","author_login":"magodo","author_association":"COLLABORATOR","created_at":"2022-12-02T02:54:33+08:00","repo_name":"hashicorp/terraform-provider-azurerm","issue_id":1470899703,"issue_number":19520,"issue_url":"https://github.com/hashicorp/terraform-provider-azurerm/issues/19520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1336677861","fragment_type":"issue_comment","sequence":2,"text":"@magodo thanks for looking into this issue. I did try using another provider(with an alias) but similar issue. We have a central log analytics workspace which sits in another subscription and we have enabled the sentinel solution in that log analytics workspace. we are trying to enable the azure security centre (Aka defender for cloud) data connector for another subscription by pointing to central log analytics workspace.","author_login":"bhupinder-azenix","author_association":"NONE","created_at":"2022-12-05T03:12:22+08:00","repo_name":"hashicorp/terraform-provider-azurerm","issue_id":1470899703,"issue_number":19520,"issue_url":"https://github.com/hashicorp/terraform-provider-azurerm/issues/19520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1336772211","fragment_type":"issue_comment","sequence":3,"text":"The resource id of the data connector is like: `/SUBSCRIPTIONS/{}/RESOURCEGROUPS/{}/PROVIDERS/MICROSOFT.OPERATIONALINSIGHTS/WORKSPACES/{}/PROVIDERS/MICROSOFT.SECURITYINSIGHTS/DATACONNECTORS/{}`, which implies that the data connector is a child resource of a log analytics workspace. So in your case, the central log analytics workspace is in `subscriptionA`, whilst you still need a log analytics workspace in `subscriptionB` to create this data connector?","author_login":"magodo","author_association":"COLLABORATOR","created_at":"2022-12-05T05:28:10+08:00","repo_name":"hashicorp/terraform-provider-azurerm","issue_id":1470899703,"issue_number":19520,"issue_url":"https://github.com/hashicorp/terraform-provider-azurerm/issues/19520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1336789704","fragment_type":"issue_comment","sequence":4,"text":"@magodo no we shouldn't need a log analytics workspace in subscriptionB as I was able to enable the data connector in subscriptionB without having a log analytics in subscriptionB using AzApi provider. code same below:\n\n URL \n\nresource \"azapi_resource\" \"adfc_data_connector\" {\n\n type = \"Microsoft.SecurityInsights/dataConnectors@2022-10-01-preview\"\n\n name = \"ADFC_dev\"\n\n parent_id = data.azurerm_log_analytics_workspace.this.id\n\n body = jsonencode({\n\n name = \"ADFC_dev\"\n\n kind = \"AzureSecurityCenter\"\n\n properties = {\n\n subscriptionId = \"${data.azurerm_client_config.this.subscription_id}\"\n\n dataTypes = {\n\n alerts = {\n\n state = \"enabled\"\n\n }\n\n }\n\n }\n\n })\n\n}","author_login":"bhupinder-azenix","author_association":"NONE","created_at":"2022-12-05T06:02:25+08:00","repo_name":"hashicorp/terraform-provider-azurerm","issue_id":1470899703,"issue_number":19520,"issue_url":"https://github.com/hashicorp/terraform-provider-azurerm/issues/19520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1336817682","fragment_type":"issue_comment","sequence":5,"text":"@bhupinder-azenix Can you use the provider alias of `subscriptionA` to create this resource and assign whatever you have in `${data.azurerm_client_config.this.subscription_id}` as `subscription_id`? That should be equivalent to above azapi config.","author_login":"magodo","author_association":"COLLABORATOR","created_at":"2022-12-05T06:37:17+08:00","repo_name":"hashicorp/terraform-provider-azurerm","issue_id":1470899703,"issue_number":19520,"issue_url":"https://github.com/hashicorp/terraform-provider-azurerm/issues/19520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1336864152","fragment_type":"issue_comment","sequence":6,"text":"@magodo I have just tested with AzureRm version 3.34.0 and it worked as expected. I didn't have to mention provider as well. Not sure if it's fixed in 3.34.0 version? I want to test this in other environment and will let you know with outcome tomorrow.\n\nresource \"azurerm_sentinel_data_connector_azure_security_center\" \"uat\" {\n name = \"uatdefender\"\n log_analytics_workspace_id = data.azurerm_log_analytics_workspace.this.id\n subscription_id = data.azurerm_subscription.uat.subscription_id\n}","author_login":"bhupinder-azenix","author_association":"NONE","created_at":"2022-12-05T07:33:37+08:00","repo_name":"hashicorp/terraform-provider-azurerm","issue_id":1470899703,"issue_number":19520,"issue_url":"https://github.com/hashicorp/terraform-provider-azurerm/issues/19520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1336878007","fragment_type":"issue_comment","sequence":7,"text":"@magodo tested with version 3.33.0 and it worked with previous version as well so I am not sure what has changed overnight? I will provide you with further update tomorrow.","author_login":"bhupinder-azenix","author_association":"NONE","created_at":"2022-12-05T07:42:07+08:00","repo_name":"hashicorp/terraform-provider-azurerm","issue_id":1470899703,"issue_number":19520,"issue_url":"https://github.com/hashicorp/terraform-provider-azurerm/issues/19520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2161597872","fragment_type":"issue_comment","sequence":8,"text":"Thanks for opening this issue. Since time has passed without an update and it is working based on the most recent comments, I am going to mark this issue closed. If you are able to provide more information we may re-open this issue or open a new issue, thanks!","author_login":"rcskosir","author_association":"CONTRIBUTOR","created_at":"2024-06-11T21:03:58+08:00","repo_name":"hashicorp/terraform-provider-azurerm","issue_id":1470899703,"issue_number":19520,"issue_url":"https://github.com/hashicorp/terraform-provider-azurerm/issues/19520","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0129","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Can we disable the Outlook warning when add-in closes the message from ItemSent event?","query_context":"Last week when using our add-in we started seeing this warning when our add-in tries to close a message being composed:\n\nImage\n\nOur add-in retrieves all the information of a message to later send it using the Graph API. Before it was seamless for the users, but now we are getting a lot of confusion from our users since they don't know if they should close the message or cancel. Also if they cancel our service will still send the message, but the draft isn't deleted and that creates even more confusion.\n\nWe were wondering if there was a way to disable this feature in the user's mailbox or disable the feature entirely in our add-in ?\n\nPlease take note that this warning was not there earlier last week and that it only happens when the `Office.context.mailbox.item.close()` line is executed from the `ItemSent` event. The mailbox item is closed without warning if called from a side panel.\n\nHere is a code example:\n\nXML:\n\n...\n \n \n \n...\n\nOnSendHandler function:\n\nfunction onSendHandler(event){\n //Process de data in the body\n ...\n \n //Close mailbox item to later be sent\n Office.context.mailbox.item.close() //Warning is triggered since the event based activation was from ItemSent\n}\n\n**Edit**\n\nI tried the `closeAsync` function with `discardItem: true`:\n\nmailboxItem?.closeAsync({ discardItem: true }, result => {\n console.log(result);\n});\n\nI don't get the previous close warning and the mailbox item is getting closed successfully, but now I get a new warning:\n\nImage\n\nI think again this message is linked to the `ItemSent` event and just to add, it says that the `email was moved to the Drafts folder`, but no drafts are present for the message that was closed.\n\nIs there a way to disable this new warning with the `ItemSent` event ?","known_context_document_ids":["gh_issue_2845562803"],"reference_answer":"Hi @victorcalarasu \n\nThank you for providing the logs. \nI can see repeated POST requests to \" URL \n\".\nThis endpoint if for Telemetry collection.\nNO_AUTH also suggests that requests are unauthenticated. \nIs the add-in explicitly sending excessive analytics data using Office.js APIs? You may re-try disabling them.","answer_document_id":"gh_comment_2643736897","silver_evidence_path":["gh_comment_2663148565","gh_issue_2825795142","gh_comment_2643736897"],"evidence_issue_ids":[2845562803,2825795142],"source_repo_name":"OfficeDev/office-js","source_issue_id":2845562803,"source_issue_number":5378,"source_issue_url":"https://github.com/OfficeDev/office-js/issues/5378","target_repo_name":"OfficeDev/office-js","target_issue_id":2825795142,"target_issue_number":5345,"target_issue_url":"https://github.com/OfficeDev/office-js/issues/5345","reference_anchor_document_id":"gh_comment_2663148565","reference_answer_author":"exextoc","reference_answer_author_association":"COLLABORATOR","quality_score":84.92,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2326,"anchor_target_overlap":0.1977,"target_answer_overlap":0.0385},"issue_created_at":"2025-02-11T14:27:46+08:00","valid_comment_count":35,"fragments":[{"document_id":"gh_issue_2845562803","fragment_type":"issue_description","sequence":0,"text":"Can we disable the Outlook warning when add-in closes the message from ItemSent event?\nLast week when using our add-in we started seeing this warning when our add-in tries to close a message being composed:\n\nImage\n\nOur add-in retrieves all the information of a message to later send it using the Graph API. Before it was seamless for the users, but now we are getting a lot of confusion from our users since they don't know if they should close the message or cancel. Also if they cancel our service will still send the message, but the draft isn't deleted and that creates even more confusion.\n\nWe were wondering if there was a way to disable this feature in the user's mailbox or disable the feature entirely in our add-in ?\n\nPlease take note that this warning was not there earlier last week and that it only happens when the `Office.context.mailbox.item.close()` line is executed from the `ItemSent` event. The mailbox item is closed without warning if called from a side panel.\n\nHere is a code example:\n\nXML:\n\n...\n \n \n \n...\n\nOnSendHandler function:\n\nfunction onSendHandler(event){\n //Process de data in the body\n ...\n \n //Close mailbox item to later be sent\n Office.context.mailbox.item.close() //Warning is triggered since the event based activation was from ItemSent\n}\n\n**Edit**\n\nI tried the `closeAsync` function with `discardItem: true`:\n\nmailboxItem?.closeAsync({ discardItem: true }, result => {\n console.log(result);\n});\n\nI don't get the previous close warning and the mailbox item is getting closed successfully, but now I get a new warning:\n\nImage\n\nI think again this message is linked to the `ItemSent` event and just to add, it says that the `email was moved to the Drafts folder`, but no drafts are present for the message that was closed.\n\nIs there a way to disable this new warning with the `ItemSent` event ?","author_login":"SE-Hubert","author_association":"NONE","created_at":"2025-02-11T14:27:46+08:00","repo_name":"OfficeDev/office-js","issue_id":2845562803,"issue_number":5378,"issue_url":"https://github.com/OfficeDev/office-js/issues/5378","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2654469387","fragment_type":"issue_comment","sequence":1,"text":"Also forgot mentioning, but this warning was not there until a week ago.","author_login":"SE-Hubert","author_association":"NONE","created_at":"2025-02-12T17:59:55+08:00","repo_name":"OfficeDev/office-js","issue_id":2845562803,"issue_number":5378,"issue_url":"https://github.com/OfficeDev/office-js/issues/5378","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2662376778","fragment_type":"issue_comment","sequence":2,"text":"Hey @SE-Hubert ,\n\nThank you for reporting this issue. It has been put in our backlog. Unfortunately, we have no timelines to share at this point.\nHere are a few points I wanted to call out:\n\n1. This issue does not reproduce for \"OnMessageSend\" using LaunchEvents, but only for `ItemSend`. Do you see this issue in `OnMessageSend`? If not, can this be used as a workaround?\n2. The documentation does call out that `item.close()` should not be called in on-send handler (although I agree that the reasoning might not be the same).\n\n \n\nI wanted to understand your reason for using `item.close()` instead of (for instance) `.completed({ allowEvent: false })` in this scenario.\n\nInternal tracking ID: 5412251","author_login":"mobisw-msft","author_association":"NONE","created_at":"2025-02-17T08:26:41+08:00","repo_name":"OfficeDev/office-js","issue_id":2845562803,"issue_number":5378,"issue_url":"https://github.com/OfficeDev/office-js/issues/5378","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2662759677","fragment_type":"issue_comment","sequence":3,"text":"@SE-Hubert - One clarification on the message above- the issue we are tracking relates to the dialog that appears with `{discardItem: true}` in this case. Do note, that calling `item.close()` is expected to show the dialog if there are unsaved changes as per our documentation). This should be the case regardless from where this is called.","author_login":"mobisw-msft","author_association":"NONE","created_at":"2025-02-17T10:58:51+08:00","repo_name":"OfficeDev/office-js","issue_id":2845562803,"issue_number":5378,"issue_url":"https://github.com/OfficeDev/office-js/issues/5378","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2663148565","fragment_type":"issue_comment","sequence":4,"text":"@mobisw-msft To answer your points, this issue is also present using the \"OnMessageSend\" from the \"LauchEvents\". Like you said I tried it as a workaround. \n\nLike you mentioned, it is not recommended to do `item.close()` on an `ItemSend` event, but in our case there is no other way of doing it. Since there is no background script available and the add-in can only be in `Read` or `Compose` mode, we are using a `Service Worker` to send the emails. We are doing end-to-end encryption and processing the email can take quite sometime depending on files , recipients and other.\n\nSo we basically collect all the data needed from the `ItemSend` event and then send it to the `Service Worker` will send the processed email through the `Graph API`. With this approach, we are unable to use the default `.completed({ allowEvent: false })` since it unload the function file declared in our `Manifest`, and we are unable to use the `.completed({ allowEvent: true })` since we only want the email to be sent later by the `Service Worker`. \n\nSo this is the reason why we are using the the `item.close()` and not the other recommended methods.\n\nAlso just to clarify, but before collecting and sending the email data to our `Service Worker`, we `SaveAsync` the current state of the email and keep the normal behavior of the drafts. So there should be no unsaved changes when we use `item.close()`. Could the `ItemSent` event not save the current changes like mentioned in the #5345 issue ?","author_login":"SE-Hubert","author_association":"NONE","created_at":"2025-02-17T13:30:18+08:00","repo_name":"OfficeDev/office-js","issue_id":2845562803,"issue_number":5378,"issue_url":"https://github.com/OfficeDev/office-js/issues/5378","linked_issue_ids":[2825795142],"is_known_query_context":false},{"document_id":"gh_comment_2663211596","fragment_type":"issue_comment","sequence":5,"text":"It could be the case, because ever since issue #5345 has been reproducible, I also started seeing this message.","author_login":"victorcalarasu","author_association":"NONE","created_at":"2025-02-17T13:56:49+08:00","repo_name":"OfficeDev/office-js","issue_id":2845562803,"issue_number":5378,"issue_url":"https://github.com/OfficeDev/office-js/issues/5378","linked_issue_ids":[2825795142],"is_known_query_context":false},{"document_id":"gh_comment_2674618372","fragment_type":"issue_comment","sequence":6,"text":"Hey @victorcalarasu ,\n\nYes- with the fix for `saveAsync` you should be unblocked when calling `saveAsync` along with `close()`.","author_login":"mobisw-msft","author_association":"NONE","created_at":"2025-02-21T13:56:09+08:00","repo_name":"OfficeDev/office-js","issue_id":2845562803,"issue_number":5378,"issue_url":"https://github.com/OfficeDev/office-js/issues/5378","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2680431090","fragment_type":"issue_comment","sequence":7,"text":"Fix for URL has been rolled out. Please verify if the issue persists and let us know.","author_login":"anjalitp","author_association":"COLLABORATOR","created_at":"2025-02-25T04:26:02+08:00","repo_name":"OfficeDev/office-js","issue_id":2845562803,"issue_number":5378,"issue_url":"https://github.com/OfficeDev/office-js/issues/5378","linked_issue_ids":[2825795142],"is_known_query_context":false},{"document_id":"gh_comment_2681993614","fragment_type":"issue_comment","sequence":8,"text":"Just did some tests and I indeed don't have the warning anymore.\n\nThanks for the update!","author_login":"SE-Hubert","author_association":"NONE","created_at":"2025-02-25T13:31:31+08:00","repo_name":"OfficeDev/office-js","issue_id":2845562803,"issue_number":5378,"issue_url":"https://github.com/OfficeDev/office-js/issues/5378","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2825795142","fragment_type":"issue_description","sequence":0,"text":"Office.context.mailbox.item.saveAsync fails during OnSend function on Outlook for web\nI have an Add-in created for Outlook Web which adds headers to emails in order to save them securely. It operated both through Task Pane and on the OnSend functionality of Outlook Web.\n\n## Your Environment\n \n* Platform [PC desktop, Mac, iOS, Office on the web]: Office on the web\n* Host [Excel, Word, PowerPoint, etc.]: Outlook\n* Office version number: ______\n* Operating System: Windows\n* Browser (if using Office on the web): Chrome/Edge/Firefox\n \n## Expected behavior\n \nWhen pressing the Outlook Send Button (OnSend function), the mail is sent successfully.\nWhat I want to do is get the draft ID in order to send the item using Microsoft Graph API\n\n## Current behavior\n \n \nWhen pressing the Outlook Send Button the Office.context.mailbox.item.saveAsync() function fails with :\n\nerror: OSF_DDA_Error\ncode: 9021\nmessage: \"Connection error occurred while trying to save the item on the server.\"\nname: \"SaveError\"\n\nthis wasn't happening before and we didn't do any change here. \nIf I save the draft manually, gets automatically saved by Outlook or do the same flow using the Task Pane (opening the add-in through the Apps button), it works correctly.\n\nIt is only happening on new emails.\n\n## Steps to reproduce\n \nCall the saveAsync() function during the onSend process.\n\n## Link to live example(s)\n \n \n \n1. ______\n2. ______\n3. ______\n\n# Provide additional details\n \n1. ______\n2. ______\n3. ______\n\n## Context\n \n \nMails can no longer be sent.\nWhat I want to do is get the draft ID in order to send the item using Microsoft Graph API\n\n## Useful logs\n \n\nImage","author_login":"victorcalarasu","author_association":"NONE","created_at":"2025-02-02T13:11:41+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2630996811","fragment_type":"issue_comment","sequence":1,"text":"Our telemetry indicates **high** amount of _hanging_ `Office.context.mailbox.item.saveAsync` requests. \n\nInternally we **Timeout** and Cancel them after **30 seconds**, but this API is a crucial peace of our UX, and we wish we could see less of such hanging calls.\n\nSimilar situation is with the following APIs:\n\n**`Office.CustomProperties.saveAsync`\n`Office.context.mailbox.item.loadCustomPropertiesAsync`\n`Office.context.mailbox.item.to.getAsync`\n`Office.context.mailbox.item.cc.getAsync`\n`Office.context.mailbox.item.bcc.getAsync`**\n\nIt comes together with the \n\n\"Error: [Office API error] name: Internal Error, code: 5001, message: An internal error has occurred., diagnostics: undefined\"\n\nand \n\n\"Error: [Office API error] name: GenericResponseError, code: 9020, message: An internal error has occurred., diagnostics: undefined\"\n\nerrors codes.","author_login":"dmitriikashin-outreach","author_association":"NONE","created_at":"2025-02-03T13:23:14+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2631212943","fragment_type":"issue_comment","sequence":2,"text":"Thank you @victorcalarasu for reporting this. \nWhile we check this from our end, could you please share the logs by following the process: URL and give the access to exextoc?","author_login":"patilganesh-msft","author_association":"NONE","created_at":"2025-02-03T14:48:27+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2631495783","fragment_type":"issue_comment","sequence":3,"text":"@patilganesh-msft Thank you for your response, I will ask for permissions to share the logs with exextoc.\nPlease keep me posted if you find anything in the meantime.","author_login":"victorcalarasu","author_association":"NONE","created_at":"2025-02-03T16:32:04+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2631865014","fragment_type":"issue_comment","sequence":4,"text":"@patilganesh-msft I've added exextoc to my private repository containing some logs. Let me know if I can help in any other way.","author_login":"victorcalarasu","author_association":"NONE","created_at":"2025-02-03T19:17:42+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2634746129","fragment_type":"issue_comment","sequence":5,"text":"Any updates regarding this topic? it's a bit important for us","author_login":"victorcalarasu","author_association":"NONE","created_at":"2025-02-04T18:25:36+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2641289071","fragment_type":"issue_comment","sequence":6,"text":"Hello, getting this behaviour as well - any ideas on what might be causing this or any fix or workaround that could facilitate the current situation..?","author_login":"AndreasDvrs","author_association":"NONE","created_at":"2025-02-06T22:43:05+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2643736897","fragment_type":"issue_comment","sequence":7,"text":"Hi @victorcalarasu \n\nThank you for providing the logs. \nI can see repeated POST requests to \" URL \n\".\nThis endpoint if for Telemetry collection.\nNO_AUTH also suggests that requests are unauthenticated. \nIs the add-in explicitly sending excessive analytics data using Office.js APIs? You may re-try disabling them.","author_login":"exextoc","author_association":"COLLABORATOR","created_at":"2025-02-07T18:56:21+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2644035696","fragment_type":"issue_comment","sequence":8,"text":"Thank you for your response @exextoc !\nRegarding the sending of excessive analytics, aren't these automatic diagnostic events? From the best of my knowledge, we don't do this manually. How do I disable them?\n\nThis still makes me wonder about this: Why did our code, between the 30th/31st of January stop working so suddenly? And why is it working fine through the Task Pane or if we save the draft manually?","author_login":"victorcalarasu","author_association":"NONE","created_at":"2025-02-07T20:12:56+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2647726207","fragment_type":"issue_comment","sequence":9,"text":"Could the release on the 30th of January impact this in any way? ( URL","author_login":"victorcalarasu","author_association":"NONE","created_at":"2025-02-10T11:35:09+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2649174305","fragment_type":"issue_comment","sequence":10,"text":"Having the same issue here... Saving the item from a side panel works fine but saving the item from the OnSend event causes the same issue. Error: 9021\n\nAnd like @victorcalarasu said, our code was working fine earlier but it stopped working around the 30/31 of January.\n\nAny work arounds?","author_login":"SE-Hubert","author_association":"NONE","created_at":"2025-02-10T20:34:28+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2650622033","fragment_type":"issue_comment","sequence":11,"text":"We are facing exactly the same issue. It's quite concerning because this is not the first time we are encountering problems of this kind. It used to work, but suddenly, from one day to the next, nothing works anymore. I understand that there is a big system behind it, but are you able to guarantee stability for your product to your clients?\n\nWithout wanting to sound accusatory, are you ready to welcome millions of users, or are you still in a testing phase?","author_login":"SecureExchanges","author_association":"NONE","created_at":"2025-02-11T12:09:45+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2653288362","fragment_type":"issue_comment","sequence":12,"text":"Hey @victorcalarasu , thanks for reporting this issue- we are able to reproduce the same. We have tracked this item in our backlog. However, we have no timelines to share at this point.\n\n@dmitriikashin-outreach - We have only tracked the issue with `item.saveAsync` failing. The issue with the latency with these and other APIs seem to be a different issue- it would be great if you could open a different Github issue for the same, with some telemetry numbers that you observe and other details you think would help.\n\nInternal Tracking ID: 5372914","author_login":"mobisw-msft","author_association":"NONE","created_at":"2025-02-12T10:22:49+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2653430722","fragment_type":"issue_comment","sequence":13,"text":"hello @mobisw-msft , thank you for you response. \nThis issue has a huge impact on us and we would greatly appreciate if you could prioritize this issue. \nPlease keep me posted about its status and when it is fixed.","author_login":"victorcalarasu","author_association":"NONE","created_at":"2025-02-12T11:25:00+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2653697668","fragment_type":"issue_comment","sequence":14,"text":"I concur with @victorcalarasu , this issue is impacting around 2000 of our users.\nPlease keep us updated. Thank you","author_login":"SE-Hubert","author_association":"NONE","created_at":"2025-02-12T13:20:37+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2654498444","fragment_type":"issue_comment","sequence":15,"text":"@mobisw-msft We are also getting issues with `saveAsync` method in `onSend` function. In our case, we are not getting any error but the current message is not getting saved. As per description,) this method should saves the current message as a draft. But nothing is saved. However, calling it via EBA or taskpane is working properly. We also changed nothing in our codebase. It was working fine previously.","author_login":"gauravsoni119","author_association":"NONE","created_at":"2025-02-12T18:13:04+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2654546970","fragment_type":"issue_comment","sequence":16,"text":"Also forgot to mention, but like @gauravsoni119 said, when saving from a taskpane it works properly. Its only from the ItemSent event that the issue is present.","author_login":"SE-Hubert","author_association":"NONE","created_at":"2025-02-12T18:36:15+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2655991906","fragment_type":"issue_comment","sequence":17,"text":"Hello @mobisw-msft , This issue is highly impactful for us as well, and we would greatly appreciate it if you could prioritize its resolution. It's impacting thousands of users using our add-in and is critical.","author_login":"MehakFatima24","author_association":"NONE","created_at":"2025-02-13T09:21:38+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2656288007","fragment_type":"issue_comment","sequence":18,"text":"Wow. This is a P0; not being able to send message or last information added to an email because save operation failed blocks all users from all operations and even a data leak risk. Can you ensure @exextoc and @mobisw-msft that this get's te highest prio, or let us know where to escalate to management, because all customers for all add-ins in the world being affected should be fixed within hours, not 13 days later still open....!","author_login":"rickgoud","author_association":"NONE","created_at":"2025-02-13T11:19:12+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2658568911","fragment_type":"issue_comment","sequence":19,"text":"@exextoc and @mobisw-msft ?! The lack of communication is also concerning tbh, as you guys push the new outlook as default now, these things CANNOT break / should be fixed ASAP!","author_login":"rickgoud","author_association":"NONE","created_at":"2025-02-14T08:22:25+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2658631851","fragment_type":"issue_comment","sequence":20,"text":"Hey everyone, we have picked up the fix for this item on priority and the fix is in progress. We will share updates on it soon.","author_login":"mobisw-msft","author_association":"NONE","created_at":"2025-02-14T08:47:16+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2658974594","fragment_type":"issue_comment","sequence":21,"text":"@DivyaPatidar Logs are shared with @exextoc in a private repository.","author_login":"gauravsoni119","author_association":"NONE","created_at":"2025-02-14T10:53:00+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2662898888","fragment_type":"issue_comment","sequence":22,"text":"@exextoc @mobisw-msft We need a concrete update on the progress of the issue. This has been outstanding for far too long, and the lack of resolution is now impacting our customers. Despite previous follow-ups, we have not yet seen meaningful movement or a clear ETA. Thanks!","author_login":"manaunl","author_association":"NONE","created_at":"2025-02-17T11:54:54+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2665502392","fragment_type":"issue_comment","sequence":23,"text":"Hey all, the fix has been checked in, pending rollout. It will be available in Outlook for Web build `20250217008` onwards.","author_login":"mobisw-msft","author_association":"NONE","created_at":"2025-02-18T12:07:21+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2668095032","fragment_type":"issue_comment","sequence":24,"text":"Could you indicate when you expect this build to be rolled out?","author_login":"jacket1976","author_association":"NONE","created_at":"2025-02-19T09:50:09+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2670735751","fragment_type":"issue_comment","sequence":25,"text":"@mobisw-msft It’s been a couple of days now, and there’s still no update on the rollout. Could we get some clarity on when this build will actually be available?","author_login":"Vrkzoxqj","author_association":"NONE","created_at":"2025-02-20T08:03:05+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2670738912","fragment_type":"issue_comment","sequence":26,"text":"@mobisw-msft It’s been a couple of days now, and there’s still no update on the rollout. Could we get some clarity on when this build will actually be available?","author_login":"manaunl","author_association":"NONE","created_at":"2025-02-20T08:04:43+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2675629197","fragment_type":"issue_comment","sequence":27,"text":"@exextoc we need an update on this. This is absolutely a critical function for on-send handlers. Not being able to ensure an item is saved before making Graph API calls (which with the deprecation of legacy tokens is now required) is a critical issue.\n\nWe are seeing thousands of errors an hour retrieving email contents using Graph API because the message is out of date, even when we are calling \nsaveAsync\n numerous times prior to making the call to Graph API.","author_login":"cody-lettau","author_association":"NONE","created_at":"2025-02-21T21:57:03+08:00","repo_name":"OfficeDev/office-js","issue_id":2825795142,"issue_number":5345,"issue_url":"https://github.com/OfficeDev/office-js/issues/5345","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0133","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Is there any way to bypass CSP?","query_context":"Related to URL \nIs there any way to bypass cross-origin objects?\nBecause this code\n\njs\ndocument.querySelector('iframe[title=\"Основное содержание испытания hCaptcha\"]').contentWindow.document \n\nreturns `Uncaught DOMException: Permission denied to access property \"document\" on cross-origin object`.\nSame in playwright:\n\npython\ncaptcha = await page.wait_for_selector('iframe[title=\"Основное содержание испытания hCaptcha\"]')\nframe = await captcha.content_frame()\n\nException:\n\njs\nElementHandle.content_frame: Protocol error (Page.describeNode): error in channel \"content::9/13/2\": exception while running method \"describeNode\" in namespace \"page\": Permission denied to access property \"docShell\" on cross-origin object _describeNode@chrome://juggler/content/content/PageAgent.js:417:62\n_onMessageInternal@chrome://juggler/content/SimpleChannel.js:237:37\n_onMessage@chrome://juggler/content/SimpleChannel.js:194:12\nbindToActor/actor.receiveMessage@chrome://juggler/content/SimpleChannel.js:39:44\nplaywright._impl._errors.Error: Protocol error (Page.describeNode): error in channel \"content::9/13/2\": exception while running method \"describeNode\" in namespace \"page\": Permission denied to access property \"docShell\" on cross-origin object _describeNode@chrome://juggler/content/content/PageAgent.js:417:62\n_onMessageInternal@chrome://juggler/content/SimpleChannel.js:237:37\n_onMessage@chrome://juggler/content/SimpleChannel.js:194:12\nbindToActor/actor.receiveMessage@chrome://juggler/content/SimpleChannel.js:39:44\n\nMethods like `bounding_box()` work and return everything correctly, but `page.mouse.click(x, y)` on iframe coordinates also doesn't work","known_context_document_ids":["gh_issue_2748192207"],"reference_answer":"Hello,\n\nI figured out that reason this issue doesn't happen when using the route solution is because headers aren't being passed to `route.fulfill`.\n\npython\nasync def handle_route(route):\n response = await route.fetch()\n await route.fulfill(\n body=await response.body(),\n headers=response.headers,\n status=response.status\n )\n\nSpecifically, the reason Turnstile passes is due because the `Cross-Origin-Opener-Policy` (or COOP) header is being removed. Seems like Playwright's click function does not support the latest security changes in FF133+.\n\nA workaround for this could be to use this preference which disables COOP from being handled:\n\npython\nfirefox_user_prefs={\n 'browser.tabs.remote.useCrossOriginOpenerPolicy': False,\n}\n\nHowever, this could potentially be detected by anti-bots, though I haven't seen this used in a production environment (all of the Camoufox testing sites still pass). I will consider adding a COOP toggle in the Python library until Playwright bumps to FF133+ 👍","answer_document_id":"gh_comment_2614137611","silver_evidence_path":["gh_comment_2575137583","gh_issue_2763156165","gh_comment_2614137611"],"evidence_issue_ids":[2748192207,2763156165],"source_repo_name":"daijro/camoufox","source_issue_id":2748192207,"source_issue_number":144,"source_issue_url":"https://github.com/daijro/camoufox/issues/144","target_repo_name":"daijro/camoufox","target_issue_id":2763156165,"target_issue_number":150,"target_issue_url":"https://github.com/daijro/camoufox/issues/150","reference_anchor_document_id":"gh_comment_2575137583","reference_answer_author":"daijro","reference_answer_author_association":"OWNER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.6,"target_answer_overlap":0.1806},"issue_created_at":"2024-12-18T15:56:24+08:00","valid_comment_count":20,"fragments":[{"document_id":"gh_issue_2748192207","fragment_type":"issue_description","sequence":0,"text":"Is there any way to bypass CSP?\nRelated to URL \nIs there any way to bypass cross-origin objects?\nBecause this code\n\njs\ndocument.querySelector('iframe[title=\"Основное содержание испытания hCaptcha\"]').contentWindow.document \n\nreturns `Uncaught DOMException: Permission denied to access property \"document\" on cross-origin object`.\nSame in playwright:\n\npython\ncaptcha = await page.wait_for_selector('iframe[title=\"Основное содержание испытания hCaptcha\"]')\nframe = await captcha.content_frame()\n\nException:\n\njs\nElementHandle.content_frame: Protocol error (Page.describeNode): error in channel \"content::9/13/2\": exception while running method \"describeNode\" in namespace \"page\": Permission denied to access property \"docShell\" on cross-origin object _describeNode@chrome://juggler/content/content/PageAgent.js:417:62\n_onMessageInternal@chrome://juggler/content/SimpleChannel.js:237:37\n_onMessage@chrome://juggler/content/SimpleChannel.js:194:12\nbindToActor/actor.receiveMessage@chrome://juggler/content/SimpleChannel.js:39:44\nplaywright._impl._errors.Error: Protocol error (Page.describeNode): error in channel \"content::9/13/2\": exception while running method \"describeNode\" in namespace \"page\": Permission denied to access property \"docShell\" on cross-origin object _describeNode@chrome://juggler/content/content/PageAgent.js:417:62\n_onMessageInternal@chrome://juggler/content/SimpleChannel.js:237:37\n_onMessage@chrome://juggler/content/SimpleChannel.js:194:12\nbindToActor/actor.receiveMessage@chrome://juggler/content/SimpleChannel.js:39:44\n\nMethods like `bounding_box()` work and return everything correctly, but `page.mouse.click(x, y)` on iframe coordinates also doesn't work","author_login":"yungd1plomat","author_association":"NONE","created_at":"2024-12-18T15:56:24+08:00","repo_name":"daijro/camoufox","issue_id":2748192207,"issue_number":144,"issue_url":"https://github.com/daijro/camoufox/issues/144","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2551726745","fragment_type":"issue_comment","sequence":1,"text":"seems to be only a playwright problem, puppeteer and selenium knows how to work with OOPIF, is there any way to connect them instead of playwright?","author_login":"yungd1plomat","author_association":"NONE","created_at":"2024-12-18T16:09:05+08:00","repo_name":"daijro/camoufox","issue_id":2748192207,"issue_number":144,"issue_url":"https://github.com/daijro/camoufox/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2575137583","fragment_type":"issue_comment","sequence":2,"text":"if your issue is not present in patchright then try my solution here #150 (Using the route thing alters the response somehow)","author_login":"D4Vinci","author_association":"CONTRIBUTOR","created_at":"2025-01-07T12:15:37+08:00","repo_name":"daijro/camoufox","issue_id":2748192207,"issue_number":144,"issue_url":"https://github.com/daijro/camoufox/issues/144","linked_issue_ids":[2763156165],"is_known_query_context":false},{"document_id":"gh_comment_2638247762","fragment_type":"issue_comment","sequence":3,"text":"Hello,\n\nA fix for this issue has been added in v135.0-beta.21 👍","author_login":"daijro","author_association":"OWNER","created_at":"2025-02-05T23:17:13+08:00","repo_name":"daijro/camoufox","issue_id":2748192207,"issue_number":144,"issue_url":"https://github.com/daijro/camoufox/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2763156165","fragment_type":"issue_description","sequence":0,"text":"Can't click interactive turnstile with Camoufox like patchright\nHey mate, there is this new script that can click interactive turnstile captcha: URL \nI tested it on URL and it worked\nThe main version uses Patchright and there's another one with nodriver. Both can only bypass it in headed mode.\n\nThe thing is I tried to make a version that does this with Camoufox but it doesn't work, here's my research results:\n1. Because the script depends on clicking on specific hard-coded dimensions on the page, it needs the browser to show with the default viewport/window size of Playwright's Chrome.\nI searched it and found it's OS dependent so for my MacOS it's `{'width': 1280, 'height': 720}`. I used the attribute `window=(width, height)` of Camoufox but the window keeps opening in different sizes every time.\nSo I used the `screen` argument as well like this `screen=Screen(max_width=width, min_width=width, max_height=height, min_height=height)` and the window now opens in the same size but still something doesn't look right.\nSo I added another test: \n`print(self.page.viewport_size)`\n`print(self.page.evaluate(\"({ width: window.innerWidth, height: window.innerHeight })\"))`\nand it turns out the height on the second print is always wrong!\n2. The page takes more time to load than Patchright and about double the time for the captcha spinner to disappear, something seems really off with the page on Camoufox. I think browserforge fingerprints are missing something, I was using it on Scrapling to inject headers to raw playwright and I had many issues with normal websites not loading that don't have protections and recaptcha not loading. In the end, it turns out the format used in browserforge headers is very old and different than the one used in Chrome now so just disabling it made all those websites load correctly.\n\nWith Camoufox the function called solve_challenge doesn't work at all no matter how I optimize it for Camoufox, it doesn't detect any of the elements.\n\nI guess all this problem revolves around Camoufox taking too much control over what's happening without too many options for the user to control the behavior. I don't know.\n\nLast month I made a script to click the turnstile interactive captcha the same way but depending on OpenCV for the dimensions and Camoufox as a browser but I had a big issue with the mouse click not registering and I think this happens here too. Maybe Camoufox handles nested iframes very differently than Patchright?","author_login":"D4Vinci","author_association":"CONTRIBUTOR","created_at":"2024-12-30T12:41:15+08:00","repo_name":"daijro/camoufox","issue_id":2763156165,"issue_number":150,"issue_url":"https://github.com/daijro/camoufox/issues/150","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2571272611","fragment_type":"issue_comment","sequence":1,"text":"To narrow the issue down even more, this script makes the mouse move to the captcha correctly every time but the click doesn't happen:\n\npython\nimport asyncio\nfrom camoufox.async_api import AsyncCamoufox\n\nasync def main():\n async with AsyncCamoufox(headless=False, humanize=True, window=(1280, 720)) as browser:\n page = await browser.new_page()\n await page.goto(' URL \n await page.wait_for_load_state(state=\"domcontentloaded\")\n await page.wait_for_load_state('networkidle')\n\n await asyncio.sleep(5)\n await page.mouse.click(210, 290)\n input('Press enter to close')\n await browser.close()\n\nif __name__ == \"__main__\":\n asyncio.run(main())","author_login":"D4Vinci","author_association":"CONTRIBUTOR","created_at":"2025-01-04T12:22:26+08:00","repo_name":"daijro/camoufox","issue_id":2763156165,"issue_number":150,"issue_url":"https://github.com/daijro/camoufox/issues/150","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2571308008","fragment_type":"issue_comment","sequence":2,"text":"@daijro \nA friend of mine managed to make the click work by simply doing this:\n\npython\nimport asyncio\nfrom camoufox.async_api import AsyncCamoufox\n\nasync def handle_route(route):\n response = await route.fetch()\n await route.fulfill(body=await response.body())\n\nasync def main():\n async with AsyncCamoufox(headless=False, humanize=True, window=(1280, 720)) as browser:\n page = await browser.new_page()\n await page.route(\"**/*\", handle_route)\n await page.goto(' URL \n await page.wait_for_load_state(state=\"domcontentloaded\")\n await page.wait_for_load_state('networkidle')\n\n await asyncio.sleep(5)\n await page.mouse.click(210, 290)\n await page.wait_for_timeout(30000)\n input('Press enter to close')\n await browser.close()\n\nif __name__ == \"__main__\":\n asyncio.run(main())\n\nDo you have any idea of WTF? 😄","author_login":"D4Vinci","author_association":"CONTRIBUTOR","created_at":"2025-01-04T13:39:56+08:00","repo_name":"daijro/camoufox","issue_id":2763156165,"issue_number":150,"issue_url":"https://github.com/daijro/camoufox/issues/150","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2571379512","fragment_type":"issue_comment","sequence":3,"text":"@daijro I have improved the script a lot so no constants or periods of sleep are used now but still, the route thing making the captcha clickable doesn't make sense so I will leave the issue open for you to see this, maybe it's a bug that needs fixing","author_login":"D4Vinci","author_association":"CONTRIBUTOR","created_at":"2025-01-04T18:40:19+08:00","repo_name":"daijro/camoufox","issue_id":2763156165,"issue_number":150,"issue_url":"https://github.com/daijro/camoufox/issues/150","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2571383551","fragment_type":"issue_comment","sequence":4,"text":"I'm just guessing but could it be:\n- adblock extension that's enabled by default blocking some requests and `route.fulfill ` fixing that\n- requests timing to for some other reason and `rote.fulfill` changing the default timeouts\n\nEither way try logging all requests to see if anything fails","author_login":"netdev1","author_association":"NONE","created_at":"2025-01-04T18:59:10+08:00","repo_name":"daijro/camoufox","issue_id":2763156165,"issue_number":150,"issue_url":"https://github.com/daijro/camoufox/issues/150","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2571385397","fragment_type":"issue_comment","sequence":5,"text":"@netdev1 I tried before to disable UBO and it didn't matter so it's not that. The 2nd point makes sense because before doing that route, the Turnstile page seemed laggy sometimes on Camoufox","author_login":"D4Vinci","author_association":"CONTRIBUTOR","created_at":"2025-01-04T19:06:56+08:00","repo_name":"daijro/camoufox","issue_id":2763156165,"issue_number":150,"issue_url":"https://github.com/daijro/camoufox/issues/150","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2575114635","fragment_type":"issue_comment","sequence":6,"text":"@daijro I will close this ticket as my issue is solved so you have one less ticket to worry about but I think you should have a look on the route solution when you have time as it's really weird behaviour from Camoufox.","author_login":"D4Vinci","author_association":"CONTRIBUTOR","created_at":"2025-01-07T12:02:50+08:00","repo_name":"daijro/camoufox","issue_id":2763156165,"issue_number":150,"issue_url":"https://github.com/daijro/camoufox/issues/150","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2606299022","fragment_type":"issue_comment","sequence":7,"text":"Thanks! Sorry for the long delay— I just got back from a long break (had exams, was sick for a bit, also been working on a new project for Camoufox). I'll start working on bug fixes this week. 👍 \n\nUsing `.route()` changes the behavior of network caching in the browser. Resources like JavaScript, CSS files, and images are fetched from the network on every request rather than being loaded into/from the cache. I think this issue happens because of changes introduced in FF133 that cause caching to affect the behavior of iframes (Camoufox is a couple versions ahead of the base Playwright FF release). Unfortunately, Playwright hasn't updated their Firefox fork since November 13th. I'll implement the route solution you provided in the Python library as a temporary fix (Thank you btw!)","author_login":"daijro","author_association":"OWNER","created_at":"2025-01-22T04:59:11+08:00","repo_name":"daijro/camoufox","issue_id":2763156165,"issue_number":150,"issue_url":"https://github.com/daijro/camoufox/issues/150","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2610140952","fragment_type":"issue_comment","sequence":8,"text":"Hi guys, I try to replicate the code example and I got into endless loop of verification. Did you encounter the same behavior?","author_login":"jezonek","author_association":"NONE","created_at":"2025-01-23T15:37:30+08:00","repo_name":"daijro/camoufox","issue_id":2763156165,"issue_number":150,"issue_url":"https://github.com/daijro/camoufox/issues/150","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2613278912","fragment_type":"issue_comment","sequence":9,"text":"Looks like a new commit for the latest FF has been pushed on Playwright's repo a few days ago:\n URL \n\nI'll implement it into Camoufox after class and check if this issue still exists.","author_login":"daijro","author_association":"OWNER","created_at":"2025-01-24T19:56:04+08:00","repo_name":"daijro/camoufox","issue_id":2763156165,"issue_number":150,"issue_url":"https://github.com/daijro/camoufox/issues/150","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2613684978","fragment_type":"issue_comment","sequence":10,"text":"Hello,\n\nI've merged the latest changes from Playwright's upstream patches, and it turned out their commit is still not compatible with FF133+ (turns out they're still patching FF132 release from Oct 21, 2024). However, I found a commit this FF commit made 4 days later that could have caused the regression in how `GetBoxQuads` functions. I will look into a potential workaround, or maybe reverting this commit and seeing if it fixes the issue.","author_login":"daijro","author_association":"OWNER","created_at":"2025-01-25T00:57:15+08:00","repo_name":"daijro/camoufox","issue_id":2763156165,"issue_number":150,"issue_url":"https://github.com/daijro/camoufox/issues/150","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2614137611","fragment_type":"issue_comment","sequence":11,"text":"Hello,\n\nI figured out that reason this issue doesn't happen when using the route solution is because headers aren't being passed to `route.fulfill`.\n\npython\nasync def handle_route(route):\n response = await route.fetch()\n await route.fulfill(\n body=await response.body(),\n headers=response.headers,\n status=response.status\n )\n\nSpecifically, the reason Turnstile passes is due because the `Cross-Origin-Opener-Policy` (or COOP) header is being removed. Seems like Playwright's click function does not support the latest security changes in FF133+.\n\nA workaround for this could be to use this preference which disables COOP from being handled:\n\npython\nfirefox_user_prefs={\n 'browser.tabs.remote.useCrossOriginOpenerPolicy': False,\n}\n\nHowever, this could potentially be detected by anti-bots, though I haven't seen this used in a production environment (all of the Camoufox testing sites still pass). I will consider adding a COOP toggle in the Python library until Playwright bumps to FF133+ 👍","author_login":"daijro","author_association":"OWNER","created_at":"2025-01-25T23:42:35+08:00","repo_name":"daijro/camoufox","issue_id":2763156165,"issue_number":150,"issue_url":"https://github.com/daijro/camoufox/issues/150","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2614310382","fragment_type":"issue_comment","sequence":12,"text":"Nice job @daijro ! I have just tested it on the same script without routing and it worked!","author_login":"D4Vinci","author_association":"CONTRIBUTOR","created_at":"2025-01-26T10:12:30+08:00","repo_name":"daijro/camoufox","issue_id":2763156165,"issue_number":150,"issue_url":"https://github.com/daijro/camoufox/issues/150","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2621898668","fragment_type":"issue_comment","sequence":13,"text":"Seems like there is a new issue to this?\nI've tried using the exact same setup as you guys, with the new routing, and it doesnt want to click at all.\n\nimport asyncio\nfrom camoufox.async_api import AsyncCamoufox\n\nasync def handle_route(route):\n response = await route.fetch()\n await route.fulfill(\n body=await response.body(),\n headers=response.headers, # Missing in example\n status=response.status\n )\n\nasync def main():\n async with AsyncCamoufox(headless=False, humanize=True, window=(1280, 720)) as browser:\n page = await browser.new_page()\n await page.route(\"**/*\", handle_route)\n await page.goto(' URL \n await page.wait_for_load_state(state=\"domcontentloaded\")\n await page.wait_for_load_state('networkidle')\n\n await asyncio.sleep(5)\n await page.mouse.click(210, 290)\n await page.wait_for_timeout(30000)\n input('Press enter to close')\n await browser.close()\n\nif __name__ == \"__main__\":\n asyncio.run(main())","author_login":"sebhansen","author_association":"NONE","created_at":"2025-01-29T15:00:45+08:00","repo_name":"daijro/camoufox","issue_id":2763156165,"issue_number":150,"issue_url":"https://github.com/daijro/camoufox/issues/150","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2623904673","fragment_type":"issue_comment","sequence":14,"text":"@daijro it's giving this error: TypeError: BrowserType.launch() got an unexpected keyword argument 'disable_coop'\n\nI have to pass this instead: firefox_user_prefs = {'browser.tabs.remote.useCrossOriginOpenerPolicy': False}","author_login":"sebhansen","author_association":"NONE","created_at":"2025-01-30T09:04:35+08:00","repo_name":"daijro/camoufox","issue_id":2763156165,"issue_number":150,"issue_url":"https://github.com/daijro/camoufox/issues/150","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2623911070","fragment_type":"issue_comment","sequence":15,"text":"I think your version is out of date. Try running `pip install -U camoufox` 👍","author_login":"daijro","author_association":"OWNER","created_at":"2025-01-30T09:07:29+08:00","repo_name":"daijro/camoufox","issue_id":2763156165,"issue_number":150,"issue_url":"https://github.com/daijro/camoufox/issues/150","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2623939463","fragment_type":"issue_comment","sequence":16,"text":"That's odd, I did python -m camoufox fetch and checked version, but apparently that didnt do the trick. Oh well, it works now.\n\nNow I just have issues with being sent straight back to the same challenge page after clicking #170","author_login":"sebhansen","author_association":"NONE","created_at":"2025-01-30T09:19:52+08:00","repo_name":"daijro/camoufox","issue_id":2763156165,"issue_number":150,"issue_url":"https://github.com/daijro/camoufox/issues/150","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2638234085","fragment_type":"issue_comment","sequence":17,"text":"Hello,\n\nA fix for this issue has been added in v135.0-beta.21 (without having to disable COOP).\n\nCamoufox won't have any issues interacting with cross origin iframes anymore. 👍","author_login":"daijro","author_association":"OWNER","created_at":"2025-02-05T23:07:17+08:00","repo_name":"daijro/camoufox","issue_id":2763156165,"issue_number":150,"issue_url":"https://github.com/daijro/camoufox/issues/150","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0134","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"NuGet publishing?","query_context":"Publish our OSS packages to NuGet. Individual issues for the same: URL URL URL \n\nFirst steps:\n\n- Set up the NuGet publishing with GitHub Actions of URL and URL These will then at a later point serve as models for the rest.\n- These two projects are special, and thus cover all important use cases, because Helpful Extensions depends on Helpful Libraries, and Helpful Libraries contains three csprojs that all need to be published (either as separate packages or one; perhaps the former because other projects may not depend on all of them).\n- We're developing such OSS projects as part of this OSOCE solution. In other projects of ours we use them as submodules too, so consuming and improving them is easier. We'll keep this, thus we need some way for this to not clash with NuGet references.\n\nSome criteria to keep in mind:\n\n- We can handle the whole thing from a build in OSOCE too somehow, it needn't be for each project, if it makes things easier.\n- Currently, we have about 30 projects that we'd like to publish to NuGet. This already necessitates the ability to manage NuGet publishing somehow centrally in a DRY manner (apart from credentials that can be stored in GitHub secrets) but we'll likely have many more. So, a solution where we need to maintain a pipeline in each of these repositories would be an issue","known_context_document_ids":["gh_issue_1069925276"],"reference_answer":"@scleaver @deanmarcussen it might be interesting for you what we've progressed with Node.js Extensions here. While we don't have the full functionality of Gulp Extensions yet, we actually have an NPM script-containing NuGet package working!","answer_document_id":"gh_comment_1109736143","silver_evidence_path":["gh_comment_1040840795","gh_issue_1130673631","gh_comment_1109736143"],"evidence_issue_ids":[1069925276,1130673631],"source_repo_name":"Lombiq/Open-Source-Orchard-Core-Extensions","source_issue_id":1069925276,"source_issue_number":23,"source_issue_url":"https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/issues/23","target_repo_name":"Lombiq/Open-Source-Orchard-Core-Extensions","target_issue_id":1130673631,"target_issue_number":48,"target_issue_url":"https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/issues/48","reference_anchor_document_id":"gh_comment_1040840795","reference_answer_author":"Piedone","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.4118,"anchor_target_overlap":0.4118,"target_answer_overlap":0.2105},"issue_created_at":"2021-12-02T19:51:22+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_1069925276","fragment_type":"issue_description","sequence":0,"text":"NuGet publishing\nPublish our OSS packages to NuGet. Individual issues for the same: URL URL URL \n\nFirst steps:\n\n- Set up the NuGet publishing with GitHub Actions of URL and URL These will then at a later point serve as models for the rest.\n- These two projects are special, and thus cover all important use cases, because Helpful Extensions depends on Helpful Libraries, and Helpful Libraries contains three csprojs that all need to be published (either as separate packages or one; perhaps the former because other projects may not depend on all of them).\n- We're developing such OSS projects as part of this OSOCE solution. In other projects of ours we use them as submodules too, so consuming and improving them is easier. We'll keep this, thus we need some way for this to not clash with NuGet references.\n\nSome criteria to keep in mind:\n\n- We can handle the whole thing from a build in OSOCE too somehow, it needn't be for each project, if it makes things easier.\n- Currently, we have about 30 projects that we'd like to publish to NuGet. This already necessitates the ability to manage NuGet publishing somehow centrally in a DRY manner (apart from credentials that can be stored in GitHub secrets) but we'll likely have many more. So, a solution where we need to maintain a pipeline in each of these repositories would be an issue","author_login":"Piedone","author_association":"MEMBER","created_at":"2021-12-02T19:51:22+08:00","repo_name":"Lombiq/Open-Source-Orchard-Core-Extensions","issue_id":1069925276,"issue_number":23,"issue_url":"https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/issues/23","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1015475098","fragment_type":"issue_comment","sequence":1,"text":"Think I covered the last of your feedback this morning, so yes think ready for review again","author_login":"deanmarcussen","author_association":"NONE","created_at":"2022-01-18T14:38:23+08:00","repo_name":"Lombiq/Open-Source-Orchard-Core-Extensions","issue_id":1069925276,"issue_number":23,"issue_url":"https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1015864309","fragment_type":"issue_comment","sequence":2,"text":"This should have closed itself really, keeping it open until we verified that everything works.","author_login":"Piedone","author_association":"MEMBER","created_at":"2022-01-18T21:47:47+08:00","repo_name":"Lombiq/Open-Source-Orchard-Core-Extensions","issue_id":1069925276,"issue_number":23,"issue_url":"https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1030972540","fragment_type":"issue_comment","sequence":3,"text":"These two are the trickiest (and the other projects using them). I'm not yet sure how and if we'll handle them because the NPM packages referenced in them need to be restored too. Loading something from NuGet that has a package.json which in","author_login":"Piedone","author_association":"MEMBER","created_at":"2022-02-07T01:10:58+08:00","repo_name":"Lombiq/Open-Source-Orchard-Core-Extensions","issue_id":1069925276,"issue_number":23,"issue_url":"https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1031945263","fragment_type":"issue_comment","sequence":4,"text":"You could import the package.json as part of the nuget, as a content spec.\n\nnot sure how / if you can kick of an npm install during the nuget install process though.","author_login":"deanmarcussen","author_association":"NONE","created_at":"2022-02-07T21:30:04+08:00","repo_name":"Lombiq/Open-Source-Orchard-Core-Extensions","issue_id":1069925276,"issue_number":23,"issue_url":"https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1031949221","fragment_type":"issue_comment","sequence":5,"text":"Yep, having the file there is doable but the rest seems tricky and/or really hackish. Gulp Extensions is pretty much an NPM package as well, so perhaps it should be as such too but I really don't want to go into that (perhaps only some local NPM package coming from NuGet-like trick).","author_login":"Piedone","author_association":"MEMBER","created_at":"2022-02-07T21:34:23+08:00","repo_name":"Lombiq/Open-Source-Orchard-Core-Extensions","issue_id":1069925276,"issue_number":23,"issue_url":"https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1032217960","fragment_type":"issue_comment","sequence":6,"text":"Apparently I didn't finish my reply to Seth. I wanted to add, that flat local files need to be referenced from Gulp Extensions from JS modules within the consumer project (namely, form a Gulpfile.js). I don't know how this can work well, I think you can only make those files end up in the build output folder (since you have to use the from JS, you can't used embedded files and such).","author_login":"Piedone","author_association":"MEMBER","created_at":"2022-02-08T05:04:34+08:00","repo_name":"Lombiq/Open-Source-Orchard-Core-Extensions","issue_id":1069925276,"issue_number":23,"issue_url":"https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1032295449","fragment_type":"issue_comment","sequence":7,"text":"While it is possible, it's not ideal. Here's a blog post URL \n\nThe problem is that using content files in a nuspec means they are just copied in during the install process.\nThey are not maintained by NuGet afterwards. So you can delete / modify them etc\n\nThey do get recopied during an upgrade.\n\nNot sure how you can do them without writing your own nuspec, i.e. from a csproj generated nuspec. Probably possible, but the last time I had to do this, was before we had csproj style nuspecs. Used to do it to copy linker .cs files in from Xamarin, which often needed further modification afterwards.","author_login":"deanmarcussen","author_association":"NONE","created_at":"2022-02-08T07:33:51+08:00","repo_name":"Lombiq/Open-Source-Orchard-Core-Extensions","issue_id":1069925276,"issue_number":23,"issue_url":"https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1032618089","fragment_type":"issue_comment","sequence":8,"text":"Hmm, I used contentFiles before (Lombiq.Tests.UI has them) and to me it seems that while they appear as local files in the project from the Solution Explorer of VS, they are actually referencing the files in the package. I.e. if you want a path to them from outside of your .NET project (where you can reference them with a relative path from C#) you'll need to use the absolute path to the package in the NuGet package cache. They can be made copied to the output folder but then you have to reference the output folder which isn't really a good solution either.","author_login":"Piedone","author_association":"MEMBER","created_at":"2022-02-08T13:37:20+08:00","repo_name":"Lombiq/Open-Source-Orchard-Core-Extensions","issue_id":1069925276,"issue_number":23,"issue_url":"https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1035506901","fragment_type":"issue_comment","sequence":9,"text":"We can work around by committing the wwwroot folder to the repo to be able to publish projects that utilize Gulp Extensions. However, GE itself and the Vue module won't be usable from NuGet.","author_login":"Piedone","author_association":"MEMBER","created_at":"2022-02-10T20:55:36+08:00","repo_name":"Lombiq/Open-Source-Orchard-Core-Extensions","issue_id":1069925276,"issue_number":23,"issue_url":"https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1040840795","fragment_type":"issue_comment","sequence":10,"text":"This, and thus the first, important phase of NuGet publishing is now done. Publishing Gulp (or generally, Node)-using projects is not yet possible. We'll see what we can do there: URL \n\nSee here for the announcement: URL","author_login":"Piedone","author_association":"MEMBER","created_at":"2022-02-15T22:02:48+08:00","repo_name":"Lombiq/Open-Source-Orchard-Core-Extensions","issue_id":1069925276,"issue_number":23,"issue_url":"https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/issues/23","linked_issue_ids":[1130673631],"is_known_query_context":false},{"document_id":"gh_issue_1130673631","fragment_type":"issue_description","sequence":0,"text":"Figure out how we can build and NuGet-publish projects that depend on Gulp Extensions (OSOE-84)\nCurrently, we commit the wwwroot folders instead of building them during publishing with Gulp Extensions, which is bad. Instead, we should build static resources as we do in the OSOCE build, but we can't really do exactly that.\n\n- Most possibly this needs changes to the affected projects and URL as well.\n- Remove the note about this issue in the root OSOCE Readme too.\n- This is a continuation of: URL An attempt was made and can be continued under URL \n- Adapt all GE-using projects of ours.\n- Perhaps we can use the Node.js Extensions project of ours that can make this easier.\n- See @Skrypt's remarks here: URL \n- Maybe we could `Exec` an NPM install or something? Perhaps the other NPM-related packages can be of some inspiration: URL \n\nJira issue","author_login":"Piedone","author_association":"MEMBER","created_at":"2022-02-10T18:50:04+08:00","repo_name":"Lombiq/Open-Source-Orchard-Core-Extensions","issue_id":1130673631,"issue_number":48,"issue_url":"https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/issues/48","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1106709051","fragment_type":"issue_comment","sequence":1,"text":"We're doing this with the URL project, WIP for full support of what Gulp Extensions does.","author_login":"Piedone","author_association":"MEMBER","created_at":"2022-04-22T17:15:48+08:00","repo_name":"Lombiq/Open-Source-Orchard-Core-Extensions","issue_id":1130673631,"issue_number":48,"issue_url":"https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/issues/48","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1109736143","fragment_type":"issue_comment","sequence":2,"text":"@scleaver @deanmarcussen it might be interesting for you what we've progressed with Node.js Extensions here. While we don't have the full functionality of Gulp Extensions yet, we actually have an NPM script-containing NuGet package working!","author_login":"Piedone","author_association":"MEMBER","created_at":"2022-04-26T12:29:21+08:00","repo_name":"Lombiq/Open-Source-Orchard-Core-Extensions","issue_id":1130673631,"issue_number":48,"issue_url":"https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/issues/48","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1404185925","fragment_type":"issue_comment","sequence":3,"text":"Projects using our new Node.js Extensions project can now be published to NuGet without further work.","author_login":"0liver","author_association":"CONTRIBUTOR","created_at":"2023-01-25T20:28:12+08:00","repo_name":"Lombiq/Open-Source-Orchard-Core-Extensions","issue_id":1130673631,"issue_number":48,"issue_url":"https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/issues/48","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0135","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"[LLD] symbol not found with PROVIDE script?","query_context":"I tried the following code. I expect lld to link successful while also removing unused symbols, but it reports `symbol not found: bar`.\n\na.s:\n\nasm\n.global _start\n_start:\n nop\n.section .text.foo,\"ax\",@progbits\n.global foo\nfoo:\n nop\n.section .text.bar,\"ax\",@progbits\n.global bar\nbar:\n nop\n\nscript.t:\n\nPROVIDE(foo = bar);\n\ncommands:\n\nbash\nllvm-mc -filetype=obj -triple=x86_64 a.s -o a.o\nld.lld -o a_gc a.o --gc-sections -T script.t\n\noutput:\n\nld.lld: error: script.t:1: symbol not found: bar\nld.lld: error: script.t:1: symbol not found: bar\nld.lld: error: script.t:1: symbol not found: bar\n\ncc @MaskRay ebb326a51fec37b5a47e5702e8ea157cd4f835cd","known_context_document_ids":["gh_issue_2572023365"],"reference_answer":"I have read the related code, maybe we need to add this symbol to the symbol table. Or change the code like this:\n\ndiff\ndiff --git a/lld/ELF/ScriptParser.cpp b/lld/ELF/ScriptParser.cpp\nindex 3febcfb87da4..44185c282ad7 100644\n--- a/lld/ELF/ScriptParser.cpp\n+++ b/lld/ELF/ScriptParser.cpp\n@@ -1660,10 +1660,11 @@ Expr ScriptParser::readPrimary() {\n tok = unquote(tok);\n else if (!isValidSymbolName(tok))\n setError(\"malformed number: \" + tok);\n- if (activeProvideSym)\n+ if (activeProvideSym) {\n ctx.script->provideMap[*activeProvideSym].push_back(tok);\n- else\n- ctx.script->referencedSymbols.push_back(tok);\n+ return [] { return 0; };\n+ }\n+ ctx.script->referencedSymbols.push_back(tok);\n return [=, s = ctx.script] { return s->getSymbolValue(tok, location); };\n }\n\nHowever, I'm not familiar with this part of the code. \n \n \n \n\nIn any case, I believe the upstream backport is likely to miss our backport process. I'm reverting this commit to our fork LLVM.","answer_document_id":"gh_comment_2399624148","silver_evidence_path":["gh_comment_2406615664","gh_issue_2562252541","gh_comment_2399624148"],"evidence_issue_ids":[2572023365,2562252541],"source_repo_name":"llvm/llvm-project","source_issue_id":2572023365,"source_issue_number":111478,"source_issue_url":"https://github.com/llvm/llvm-project/issues/111478","target_repo_name":"rust-lang/rust","target_issue_id":2562252541,"target_issue_number":131164,"target_issue_url":"https://github.com/rust-lang/rust/issues/131164","reference_anchor_document_id":"gh_comment_2406615664","reference_answer_author":"DianQK","reference_answer_author_association":"MEMBER","quality_score":92.44,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0556,"anchor_target_overlap":0.2778,"target_answer_overlap":0.1346},"issue_created_at":"2024-10-08T04:31:56+08:00","valid_comment_count":25,"fragments":[{"document_id":"gh_issue_2572023365","fragment_type":"issue_description","sequence":0,"text":"[LLD] symbol not found with PROVIDE script\nI tried the following code. I expect lld to link successful while also removing unused symbols, but it reports `symbol not found: bar`.\n\na.s:\n\nasm\n.global _start\n_start:\n nop\n.section .text.foo,\"ax\",@progbits\n.global foo\nfoo:\n nop\n.section .text.bar,\"ax\",@progbits\n.global bar\nbar:\n nop\n\nscript.t:\n\nPROVIDE(foo = bar);\n\ncommands:\n\nbash\nllvm-mc -filetype=obj -triple=x86_64 a.s -o a.o\nld.lld -o a_gc a.o --gc-sections -T script.t\n\noutput:\n\nld.lld: error: script.t:1: symbol not found: bar\nld.lld: error: script.t:1: symbol not found: bar\nld.lld: error: script.t:1: symbol not found: bar\n\ncc @MaskRay ebb326a51fec37b5a47e5702e8ea157cd4f835cd","author_login":"DianQK","author_association":"MEMBER","created_at":"2024-10-08T04:31:56+08:00","repo_name":"llvm/llvm-project","issue_id":2572023365,"issue_number":111478,"issue_url":"https://github.com/llvm/llvm-project/issues/111478","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2401330790","fragment_type":"issue_comment","sequence":1,"text":"Sorry, I mistakenly deleted the definition of `foo`. I may have forgotten to run the `llvm-mc` command to verify after the deletion. I have now fixed this description.","author_login":"DianQK","author_association":"MEMBER","created_at":"2024-10-09T05:12:09+08:00","repo_name":"llvm/llvm-project","issue_id":2572023365,"issue_number":111478,"issue_url":"https://github.com/llvm/llvm-project/issues/111478","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2406511264","fragment_type":"issue_comment","sequence":2,"text":"@llvm/issue-subscribers-lld-elf\n\nAuthor: DianQK (DianQK)\n\n \nI tried the following code. I expect lld to link successful while also removing unused symbols, but it reports `symbol not found: bar`.\n\na.s:\n\nasm\n.global _start\n_start:\n nop\n.section .text.foo,\"ax\",@ progbits\n.global foo\nfoo:\n nop\n.section .text.bar,\"ax\",@ progbits\n.global bar\nbar:\n nop\n\nscript.t:\n\nPROVIDE(foo = bar);\n\ncommands:\n\nbash\nllvm-mc -filetype=obj -triple=x86_64 a.s -o a.o\nld.lld -o a_gc a.o --gc-sections -T script.t\n\noutput:\n\nld.lld: error: script.t:1: symbol not found: bar\nld.lld: error: script.t:1: symbol not found: bar\nld.lld: error: script.t:1: symbol not found: bar\n\ncc @ MaskRay ebb326a51fec37b5a47e5702e8ea157cd4f835cd","author_login":"llvmbot","author_association":"COLLABORATOR","created_at":"2024-10-11T04:01:20+08:00","repo_name":"llvm/llvm-project","issue_id":2572023365,"issue_number":111478,"issue_url":"https://github.com/llvm/llvm-project/issues/111478","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2406615664","fragment_type":"issue_comment","sequence":3,"text":"I have verified that #111945 has fixed the build error in URL \n\nI’d like to ask for your advice on the backport. I reverted the related changes in URL What do you think is better, revert or cherry-pick the new patch?","author_login":"DianQK","author_association":"MEMBER","created_at":"2024-10-11T06:06:39+08:00","repo_name":"llvm/llvm-project","issue_id":2572023365,"issue_number":111478,"issue_url":"https://github.com/llvm/llvm-project/issues/111478","linked_issue_ids":[2562252541],"is_known_query_context":false},{"document_id":"gh_comment_2408306193","fragment_type":"issue_comment","sequence":4,"text":"Failed to cherry-pick: 1c6688ae3449da9c8fee1e1c12c892223496fb4c\n\n URL \n\nPlease manually backport the fix and push it to your github fork. Once this is done, please create a pull request","author_login":"llvmbot","author_association":"COLLABORATOR","created_at":"2024-10-12T02:13:36+08:00","repo_name":"llvm/llvm-project","issue_id":2572023365,"issue_number":111478,"issue_url":"https://github.com/llvm/llvm-project/issues/111478","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2562252541","fragment_type":"issue_description","sequence":0,"text":"non-pub function no longer compiled in debug profile, causing link errors on thumbv7em-none-eabihf with defmt\n### Code\n\nI tried this code:\n\nbash\n$ git clone URL \n$ cd rust-exercises\n$ git checkout v1.17.0\n$ cd nrf52_code/radio_app\n$ rustup target add thumbv7em-none-eabihf --toolchain=nightly\n$ cargo install flip-link (or change `.cargo/config.toml` to not use flip-link - either is fine)\n$ cargo +nightly build\n\nI expected to see this happen:\n\nThe binaries build like, they do on stable.\n\nInstead, this happened:\n\ntext\n = note: rust-lld: error: /Users/jonathan/Documents/clients/training/open-rust-embedded-2024-10-02/rust-exercises-v1.17.0/nrf52-code/radio-app/target/thumbv7em-none-eabihf/debug/build/defmt-36a2ab5d209daca3/out/defmt.x:7: symbol not found: __defmt_default_panic\n rust-lld: error: /Users/jonathan/Documents/clients/training/open-rust-embedded-2024-10-02/rust-exercises-v1.17.0/nrf52-code/radio-app/target/thumbv7em-none-eabihf/debug/build/defmt-36a2ab5d209daca3/out/defmt.x:7: symbol not found: __defmt_default_panic\n rust-lld: error: /Users/jonathan/Documents/clients/training/open-rust-embedded-2024-10-02/rust-exercises-v1.17.0/nrf52-code/radio-app/target/thumbv7em-none-eabihf/debug/build/defmt-36a2ab5d209daca3/out/defmt.x:7: symbol not found: __defmt_default_panic\n rust-lld: error: /Users/jonathan/Documents/clients/training/open-rust-embedded-2024-10-02/rust-exercises-v1.17.0/nrf52-code/radio-app/target/thumbv7em-none-eabihf/debug/build/defmt-36a2ab5d209daca3/out/defmt.x:7: symbol not found: __defmt_default_panic\n\nThat symbol is defined here: URL \n\n### Bisect\n\n@Dirbaio said:\n\nsearched nightlies: from nightly-2024-07-30 to nightly-2024-10-02\nregressed nightly: nightly-2024-08-01\nsearched commit range: URL \nregressed commit: URL \n\nThat's the LLVM 19 upgrade.","author_login":"jonathanpallant","author_association":"CONTRIBUTOR","created_at":"2024-10-02T17:25:32+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2389231139","fragment_type":"issue_comment","sequence":1,"text":"I also ran a bisect:\n\nsearched nightlies: from nightly-2024-07-01 to nightly-2024-10-02\nregressed nightly: nightly-2024-08-01\nsearched commit range: URL \nregressed commit: URL","author_login":"jonathanpallant","author_association":"CONTRIBUTOR","created_at":"2024-10-02T17:31:36+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2389439668","fragment_type":"issue_comment","sequence":2,"text":"WG-prioritization assigning priority (Zulip discussion).\n\nI can also reproduce on current beta so tagging accordingly\n\n@rustbot label -I-prioritize +P-medium +regression-from-stable-to-beta","author_login":"apiraino","author_association":"CONTRIBUTOR","created_at":"2024-10-02T18:39:35+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2389536598","fragment_type":"issue_comment","sequence":3,"text":"minimized, zero deps -> URL \n\n[dirbaio@mars defmt-repro]$ rustc --version\nrustc 1.83.0-nightly (06bb8364a 2024-10-01)\n[dirbaio@mars defmt-repro]$ cargo build\n Compiling radio_app v0.0.0 (/home/dirbaio/defmt-repro)\nerror: linking with `rust-lld` failed: exit status: 1\n |\n = note: LC_ALL=\"C\" PATH=\"/home/dirb(snip)47a\" \"--gc-sections\" \"-Tlol.x\"\n = note: rust-lld: error: lol.x:1: symbol not found: __defmt_default_panic\n rust-lld: error: lol.x:1: symbol not found: __defmt_default_panic\n rust-lld: error: lol.x:1: symbol not found: __defmt_default_panic\n\nerror: could not compile `radio_app` (bin \"radio_app\") due to 1 previous error\n[dirbaio@mars defmt-repro]$ rustc +stable --version\nrustc 1.81.0 (eeb90cda1 2024-09-04)\n[dirbaio@mars defmt-repro]$ cargo +stable build\n Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.06s","author_login":"Dirbaio","author_association":"CONTRIBUTOR","created_at":"2024-10-02T19:38:47+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2392419056","fragment_type":"issue_comment","sequence":4,"text":"It seems to all depend on the linker version, not the compiler itself. Using ldd from beta/nightly with a stable compiler triggers this issue. Using ldd from stable on a beta/nightly compiler doesn't.\n\nSo I compiled lld from llvm myself, and can confirm: With lld built from commit `ebb326a51fec37b5a47e5702e8ea157cd4f835cd` the build of Dirbaio's minimized example fails, whereas with `b6dfaf4c291ee186481f6c1dcab03874d931c307` it succeeds.\n\nSpecifically, it seems to be this change: URL \n\nIf I revert that change (by simply changeing the if condition to `if (false && activeProvideSym)`) the example also succeeds to build again.","author_login":"jannic","author_association":"CONTRIBUTOR","created_at":"2024-10-03T22:03:42+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2397064740","fragment_type":"issue_comment","sequence":5,"text":"the next stable release is in 9 days, at which point I believe the Ferrous Systems Embedded Rust exercises will stop compiling.","author_login":"jonathanpallant","author_association":"CONTRIBUTOR","created_at":"2024-10-07T14:17:56+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2399580802","fragment_type":"issue_comment","sequence":6,"text":"Is anyone aware of a workaround we could apply for defmt? We would like to avoid defmt being broken on stable with the release next week.\n\nI tried marking the `defmt::default_panic` function as `pub`, but this does not make a difference.\n\nIs there something we can add to the linker script? Something along the lines of `PLEASE_DONT_GARBAGE_COLLECT(__defmt_default_panic)`.\n\nOr can we pretend that this function is in fact used?","author_login":"Urhengulas","author_association":"CONTRIBUTOR","created_at":"2024-10-08T11:25:41+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2399588388","fragment_type":"issue_comment","sequence":7,"text":"Note that while the exercises are relatively small impact (as they are under our control), `defmt` is a widely popular solution in the embedded space.","author_login":"skade","author_association":"CONTRIBUTOR","created_at":"2024-10-08T11:29:33+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2399624148","fragment_type":"issue_comment","sequence":8,"text":"I have read the related code, maybe we need to add this symbol to the symbol table. Or change the code like this:\n\ndiff\ndiff --git a/lld/ELF/ScriptParser.cpp b/lld/ELF/ScriptParser.cpp\nindex 3febcfb87da4..44185c282ad7 100644\n--- a/lld/ELF/ScriptParser.cpp\n+++ b/lld/ELF/ScriptParser.cpp\n@@ -1660,10 +1660,11 @@ Expr ScriptParser::readPrimary() {\n tok = unquote(tok);\n else if (!isValidSymbolName(tok))\n setError(\"malformed number: \" + tok);\n- if (activeProvideSym)\n+ if (activeProvideSym) {\n ctx.script->provideMap[*activeProvideSym].push_back(tok);\n- else\n- ctx.script->referencedSymbols.push_back(tok);\n+ return [] { return 0; };\n+ }\n+ ctx.script->referencedSymbols.push_back(tok);\n return [=, s = ctx.script] { return s->getSymbolValue(tok, location); };\n }\n\nHowever, I'm not familiar with this part of the code. \n \n \n \n\nIn any case, I believe the upstream backport is likely to miss our backport process. I'm reverting this commit to our fork LLVM.","author_login":"DianQK","author_association":"MEMBER","created_at":"2024-10-08T11:48:12+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2399653568","fragment_type":"issue_comment","sequence":9,"text":"@DianQK said:\n \n\nWould this mean this issue will not land on stable? That would be great, then we do not need to find a workaround for defmt.","author_login":"Urhengulas","author_association":"CONTRIBUTOR","created_at":"2024-10-08T12:02:35+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2400724853","fragment_type":"issue_comment","sequence":10,"text":"Impact of the regression is this breaks all projects that\n- Use defmt\n- and do define a `#[defmt::panic_handler]`\n- and don't ever use `defmt::panic!()` or the other macros that panic (assert, todo, unreachable, etc.)\n\nA possible workaround defmt could do is adding `EXTERN(_defmt_panic)` to the linker script. The side effect is it'd prevent the panic handler from being optimized out when it's truly unused, I think.","author_login":"Dirbaio","author_association":"CONTRIBUTOR","created_at":"2024-10-08T20:06:09+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2401958819","fragment_type":"issue_comment","sequence":11,"text":"In case the fix ( URL does not make it into the next stable I'd think this is an okay compromise to make until it does get fixed. But let's hope it won't be necessary.","author_login":"Urhengulas","author_association":"CONTRIBUTOR","created_at":"2024-10-09T10:39:58+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2402448896","fragment_type":"issue_comment","sequence":12,"text":"I have submitted PR #131448. I apologize that I may have misspoken. I can't guarantee that this issue won't land on stable, and even reverting this change carries some risk. :)","author_login":"DianQK","author_association":"MEMBER","created_at":"2024-10-09T14:05:46+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2402489784","fragment_type":"issue_comment","sequence":13,"text":"Would it be possible to provide any actual project? :3 I think this will be helpful in determining whether to backport.","author_login":"DianQK","author_association":"MEMBER","created_at":"2024-10-09T14:21:49+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2404970102","fragment_type":"issue_comment","sequence":14,"text":"Most concrete projects of `defmt` are not public, but it has 415 reverse dependencies. URL","author_login":"skade","author_association":"CONTRIBUTOR","created_at":"2024-10-10T12:35:14+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2405246059","fragment_type":"issue_comment","sequence":15,"text":"The minimal reproduction is as follows:\n\n`main.rs`:\n\nrust\n#![no_main]\n#![no_std]\n\n#[panic_handler]\nfn panic(_: &core::panic::PanicInfo) -> ! {\n loop {}\n}\n\n#[no_mangle]\nfn foo() {}\n\n#[no_mangle]\nfn bar() {}\n\n`script.t`:\n\nPROVIDE(foo = bar);\n\nsh\n$ rustc +beta main.rs --target thumbv7em-none-eabihf -Clink-arg=-Tscript.t\nerror: linking with `rust-lld` failed: exit status: 1\n ...\n = note: rust-lld: error: script.t:1: symbol not found: bar\n rust-lld: error: script.t:1: symbol not found: bar\n rust-lld: error: script.t:1: symbol not found: bar\nerror: aborting due to 1 previous error\n\nWith small modifications, it can also be reproduced on x86.\n\n@rustbot label +S-has-mcve +A-linkage","author_login":"DianQK","author_association":"MEMBER","created_at":"2024-10-10T14:26:26+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2416315095","fragment_type":"issue_comment","sequence":16,"text":"I think this can be now closed, since #131448 has been backported and should have made it to the stable 1.82 release of tomorrrow.\n\nAm I right @jonathanpallant ? Can you check if we're all good here? thanks :)","author_login":"apiraino","author_association":"CONTRIBUTOR","created_at":"2024-10-16T09:56:06+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2416335715","fragment_type":"issue_comment","sequence":17,"text":"I can confirm nightly-2024-10-13 fixes it. nightly-2024-10-12 is the last one failing.\n\nBeta works as well.","author_login":"Dirbaio","author_association":"CONTRIBUTOR","created_at":"2024-10-16T10:05:17+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2416346325","fragment_type":"issue_comment","sequence":18,"text":"Upstream LLVM will not backport the relevant fixes, so I will add a test case.","author_login":"DianQK","author_association":"MEMBER","created_at":"2024-10-16T10:09:35+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2416779622","fragment_type":"issue_comment","sequence":19,"text":"Do you think there is a chance that this \"bug\" will come back to us? We are currently evaluating if we should apply a fix/safeguard in defmt.","author_login":"Urhengulas","author_association":"CONTRIBUTOR","created_at":"2024-10-16T13:01:51+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2416856796","fragment_type":"issue_comment","sequence":20,"text":"No. The main branch of LLVM has fixed. The next major update will include it.","author_login":"DianQK","author_association":"MEMBER","created_at":"2024-10-16T13:33:44+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2417449877","fragment_type":"issue_comment","sequence":21,"text":"Also tried with the stable prerelease from URL Problem is solved.","author_login":"jannic","author_association":"CONTRIBUTOR","created_at":"2024-10-16T17:19:21+08:00","repo_name":"rust-lang/rust","issue_id":2562252541,"issue_number":131164,"issue_url":"https://github.com/rust-lang/rust/issues/131164","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0140","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"[Impeller] Flaky impeller golden test in the engine?","query_context":"After URL there appears to be a flaky golden file test in the engine that is blocking other PRs from landing (example: URL \n\nScreenshot 2023-04-05 at 4 48 25 PM\n\nThe individual dots to the right show different colors, meaning a unique image was generated for each commit.\nThis is with the fuzzy matching algorithm set for this test:\n\nScreenshot 2023-04-05 at 4 51 07 PM\n\nAlso, it looks like this image is even flaking in post submit, because the same test is listed as untriaged on the main branch: URL \n\nIn the framework we have the tree go red if an unapproved image shows up in post submit, maybe the engine implementation should do the same.\n\ncc @mdebbar @dnfield @chinmaygarde @gaaclarke","known_context_document_ids":["gh_issue_1656350220"],"reference_answer":"The main problem with the configuration file updates is there are a lot of places that end up needing this, and some of those places don't allow comments, and no one seems to have a good way to make sure we're covering all of them short of watching for a new failure to pop up.","answer_document_id":"gh_comment_1509220947","silver_evidence_path":["gh_comment_1515095567","gh_issue_1668699070","gh_comment_1509220947"],"evidence_issue_ids":[1656350220,1668699070],"source_repo_name":"flutter/flutter","source_issue_id":1656350220,"source_issue_number":124277,"source_issue_url":"https://github.com/flutter/flutter/issues/124277","target_repo_name":"flutter/flutter","target_issue_id":1668699070,"target_issue_number":124877,"target_issue_url":"https://github.com/flutter/flutter/issues/124877","reference_anchor_document_id":"gh_comment_1515095567","reference_answer_author":"dnfield","reference_answer_author_association":"MEMBER","quality_score":75.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1481,"target_answer_overlap":0.0},"issue_created_at":"2023-04-05T22:00:13+08:00","valid_comment_count":18,"fragments":[{"document_id":"gh_issue_1656350220","fragment_type":"issue_description","sequence":0,"text":"[Impeller] Flaky impeller golden test in the engine\nAfter URL there appears to be a flaky golden file test in the engine that is blocking other PRs from landing (example: URL \n\nScreenshot 2023-04-05 at 4 48 25 PM\n\nThe individual dots to the right show different colors, meaning a unique image was generated for each commit.\nThis is with the fuzzy matching algorithm set for this test:\n\nScreenshot 2023-04-05 at 4 51 07 PM\n\nAlso, it looks like this image is even flaking in post submit, because the same test is listed as untriaged on the main branch: URL \n\nIn the framework we have the tree go red if an unapproved image shows up in post submit, maybe the engine implementation should do the same.\n\ncc @mdebbar @dnfield @chinmaygarde @gaaclarke","author_login":"Piinks","author_association":"CONTRIBUTOR","created_at":"2023-04-05T22:00:13+08:00","repo_name":"flutter/flutter","issue_id":1656350220,"issue_number":124277,"issue_url":"https://github.com/flutter/flutter/issues/124277","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1498224172","fragment_type":"issue_comment","sequence":1,"text":"@Piinks do you understand why these differences aren't filed as acceptable given the fuzzy parameters?\n\nIn the short term it was speculated that using an opaque background should make this test more stable so I'll try that out.","author_login":"gaaclarke","author_association":"MEMBER","created_at":"2023-04-05T22:11:07+08:00","repo_name":"flutter/flutter","issue_id":1656350220,"issue_number":124277,"issue_url":"https://github.com/flutter/flutter/issues/124277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1500360123","fragment_type":"issue_comment","sequence":2,"text":"Should pending engine PRs wait until this is handled, or should they land if everything else passes?","author_login":"yaakovschectman","author_association":"CONTRIBUTOR","created_at":"2023-04-07T14:54:12+08:00","repo_name":"flutter/flutter","issue_id":1656350220,"issue_number":124277,"issue_url":"https://github.com/flutter/flutter/issues/124277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1505671497","fragment_type":"issue_comment","sequence":3,"text":"I don't know why the test fails with the given parameters. However, I would recommend against using pixel percentages for delta thresholds. Frequently a golden will contain a lot of empty space that's irrelevant to the test (as is the case in the issue report) and using percentage would allow too many pixels to deviate. Instead, consider using the strategy of \"no more than P pixels can deviate, and no one pixel can deviate by more than C\", where P is the absolute number of pixels (usually a low number, like 20, and doesn't change from golden to golden), and C is the maximum allowed color delta (example).","author_login":"yjbanov","author_association":"CONTRIBUTOR","created_at":"2023-04-12T17:35:59+08:00","repo_name":"flutter/flutter","issue_id":1656350220,"issue_number":124277,"issue_url":"https://github.com/flutter/flutter/issues/124277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1515095567","fragment_type":"issue_comment","sequence":4,"text":"@zanderso Correct me if I am wrong but we are no longer gating rollers on these diffs, have a conservative fuzz factor on diffs but still expect manual intervention, reducing the noise by not running these tests on the Intel Iris 5100 which was known to be problematic (was it for the flakes or the shader compiler? 🤷). Closing this as done.","author_login":"chinmaygarde","author_association":"MEMBER","created_at":"2023-04-19T17:18:13+08:00","repo_name":"flutter/flutter","issue_id":1656350220,"issue_number":124277,"issue_url":"https://github.com/flutter/flutter/issues/124277","linked_issue_ids":[1668699070],"is_known_query_context":false},{"document_id":"gh_comment_1520584909","fragment_type":"issue_comment","sequence":5,"text":"The Iris 5100 change was because it doesn't support compute subgroups. However, it's also a small portion of our overall mac testing pool and may have had other strange issues specific to it.","author_login":"dnfield","author_association":"MEMBER","created_at":"2023-04-24T17:47:33+08:00","repo_name":"flutter/flutter","issue_id":1656350220,"issue_number":124277,"issue_url":"https://github.com/flutter/flutter/issues/124277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1668699070","fragment_type":"issue_description","sequence":0,"text":"Do not Macmini 7,1 (Intel Iris 5100) to run engine tests\nPlease remove these from engine infra configs.\n\n@ricardoamador @yusuf-goog as infra oncall\n\nThese bots are failing engine related tests, and we're finding we have to implement a bunch of work arounds in the infra config to try to avoid using them. There are only a few. \n\n URL and URL are the lists. None of these bots should run engine tests at all. They are fine for framework tests.\n\n@zanderso @chinmaygarde fyi","author_login":"dnfield","author_association":"MEMBER","created_at":"2023-04-14T17:53:04+08:00","repo_name":"flutter/flutter","issue_id":1668699070,"issue_number":124877,"issue_url":"https://github.com/flutter/flutter/issues/124877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1509094694","fragment_type":"issue_comment","sequence":1,"text":"The execution of unit tests is deeply embedded in the builds. I believe people from engine with a better understanding of the builds is better equipped to make these changes in .ci.yaml or build configurations.\n\nAn alternative is to provide a list of builds that should not use `Macmini 7,1` so that infra can help with the change.","author_login":"godofredoc","author_association":"CONTRIBUTOR","created_at":"2023-04-14T19:02:46+08:00","repo_name":"flutter/flutter","issue_id":1668699070,"issue_number":124877,"issue_url":"https://github.com/flutter/flutter/issues/124877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1509098853","fragment_type":"issue_comment","sequence":2,"text":"Note the way to work around this probably shouldn't be to specify `mac_model=Macmini8,1` since that's forcing us to use Intel `Macmini8,1` instead of giving the flexibility to run on either those bots or arm `Macmini9,1` bots, but not `Macmini7,1`.","author_login":"jmagman","author_association":"MEMBER","created_at":"2023-04-14T19:07:03+08:00","repo_name":"flutter/flutter","issue_id":1668699070,"issue_number":124877,"issue_url":"https://github.com/flutter/flutter/issues/124877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1509099718","fragment_type":"issue_comment","sequence":3,"text":"I think what @dnfield means is that `Macmini 7,1` should not be used by engine CI (try, staging, prod) for anything. Our assumption is that there is a global infra setting or configuration that can accomplish that rather than going over every sub-build individually.","author_login":"zanderso","author_association":"MEMBER","created_at":"2023-04-14T19:07:59+08:00","repo_name":"flutter/flutter","issue_id":1668699070,"issue_number":124877,"issue_url":"https://github.com/flutter/flutter/issues/124877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1509104330","fragment_type":"issue_comment","sequence":4,"text":"Definitely, I agree, would be good to remove them from the pool. I meant that our workarounds like #41203 and #41159 locking to `Macmini8,1` are preventing us from running those builds on either arm or Intel as capacity allows, and removing `Macmini7,1` from the pool would solve that problem.","author_login":"jmagman","author_association":"MEMBER","created_at":"2023-04-14T19:12:54+08:00","repo_name":"flutter/flutter","issue_id":1668699070,"issue_number":124877,"issue_url":"https://github.com/flutter/flutter/issues/124877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1509112226","fragment_type":"issue_comment","sequence":5,"text":"This can be achieved by adding a dimensions property here URL Dimensions are lists of values merged by `or` in the swarming service.\n\nPlease let us know if the functionality does not work out of the box.","author_login":"godofredoc","author_association":"CONTRIBUTOR","created_at":"2023-04-14T19:18:44+08:00","repo_name":"flutter/flutter","issue_id":1668699070,"issue_number":124877,"issue_url":"https://github.com/flutter/flutter/issues/124877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1509116399","fragment_type":"issue_comment","sequence":6,"text":"@godofredoc I can't see any documentation for what you're suggesting in the docs linked at the top of the ci.yaml here: URL \n\nCan you please like to documentation for what you're describing, or an example of something similar being done in another configuration? If neither of those exist, I would suggest that this issue is correctly on the infra ticket queue, and we need help from the infra gardener in order to get this done.","author_login":"zanderso","author_association":"MEMBER","created_at":"2023-04-14T19:23:38+08:00","repo_name":"flutter/flutter","issue_id":1668699070,"issue_number":124877,"issue_url":"https://github.com/flutter/flutter/issues/124877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1509132709","fragment_type":"issue_comment","sequence":7,"text":"@ricardoamador Thanks! I'm having trouble reconciling that example with what @godofredoc said above: \"Dimensions are lists of values merged by or in the swarming service.\" In the example, `dimensions` appears to be a map, but @godofredoc said it is a list, so I'm still not sure how to accomplish what this issue is asking for.","author_login":"zanderso","author_association":"MEMBER","created_at":"2023-04-14T19:41:14+08:00","repo_name":"flutter/flutter","issue_id":1668699070,"issue_number":124877,"issue_url":"https://github.com/flutter/flutter/issues/124877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1509149903","fragment_type":"issue_comment","sequence":8,"text":"Hmm, maybe he mistyped? They should be a map. You will need to specify the key and the value.","author_login":"ricardoamador","author_association":"CONTRIBUTOR","created_at":"2023-04-14T19:51:00+08:00","repo_name":"flutter/flutter","issue_id":1668699070,"issue_number":124877,"issue_url":"https://github.com/flutter/flutter/issues/124877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1509214002","fragment_type":"issue_comment","sequence":9,"text":"I think you might need to unindent the dimensions. The dimensions do not go under properties.","author_login":"ricardoamador","author_association":"CONTRIBUTOR","created_at":"2023-04-14T20:26:52+08:00","repo_name":"flutter/flutter","issue_id":1668699070,"issue_number":124877,"issue_url":"https://github.com/flutter/flutter/issues/124877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1509219169","fragment_type":"issue_comment","sequence":10,"text":"Could we move these bots to a separate pool and then not include that pool in engine builds/tests?","author_login":"dnfield","author_association":"MEMBER","created_at":"2023-04-14T20:30:55+08:00","repo_name":"flutter/flutter","issue_id":1668699070,"issue_number":124877,"issue_url":"https://github.com/flutter/flutter/issues/124877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1509220947","fragment_type":"issue_comment","sequence":11,"text":"The main problem with the configuration file updates is there are a lot of places that end up needing this, and some of those places don't allow comments, and no one seems to have a good way to make sure we're covering all of them short of watching for a new failure to pop up.","author_login":"dnfield","author_association":"MEMBER","created_at":"2023-04-14T20:32:25+08:00","repo_name":"flutter/flutter","issue_id":1668699070,"issue_number":124877,"issue_url":"https://github.com/flutter/flutter/issues/124877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1509233597","fragment_type":"issue_comment","sequence":12,"text":"We can ask chromium to remove them but we will be getting rid of ~10% of the try mac intel capacity. If we are ok with that we can follow up with a chromium bug but just to set expectation the queue time in try will increase considerably.","author_login":"godofredoc","author_association":"CONTRIBUTOR","created_at":"2023-04-14T20:42:18+08:00","repo_name":"flutter/flutter","issue_id":1668699070,"issue_number":124877,"issue_url":"https://github.com/flutter/flutter/issues/124877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1509249771","fragment_type":"issue_comment","sequence":13,"text":"We don't need them to be removed completely, we just need to make sure they're not used for engine builds.","author_login":"dnfield","author_association":"MEMBER","created_at":"2023-04-14T20:54:36+08:00","repo_name":"flutter/flutter","issue_id":1668699070,"issue_number":124877,"issue_url":"https://github.com/flutter/flutter/issues/124877","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0141","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Migrating/Integrating WebCrypto (possibly WASM) instead of Node Forge Crypto?","query_context":"### Specification\n\nThe work in #155 involving nativescript meant that we are starting to consider alternatives to Node forge crypto in order to standardise our crypto API and future proof to future JS-based platforms. There are number of reasons to look into webcrypto:\n\n* WebCrypto is a standard across ES platforms, thus enabling more potential native-implementations which can improve performance and security (prevent timing attacks)\n* WebCrypto API focuses on using ES-compliant buffers like `Uint8Array` and `ArrayBuffer` which can help us standardise our buffer usage across js-db, js-id, js-workers and more, especially as workers require `ArrayBuffer` to do zero-copy\n* There is existing work with WebCrypto API involving WASM to plug in functionality that isn't supported by the standard, such as providing ed25519 keys, and this will help us resolve the usage of ed25519 #168 \n* The `node-forge` source code isn't well maintained and doesn't have as many eyes watching and evaluating its security\n\nNow for some background:\n\nThis comment URL explains how we came to be using `node-forge` as opposed to other cryptographic libraries.\n\nI know that when Polykey project first started, we initially were thinking of using PGP and thus the kbpgp.js library ( URL We ended up going away from PGP due to its limited usage in a number of scenarios that we want PK to deal with. Namely end to end encrypted network communication which is a TLS issue, that makes use of X.509 certificates rather than PGP certificates. Furthermore we also had symmetric encryption/decryption scenarios like js-encryptedfs that again would not make use of PGP standards. Therefore it just lacked interoperability with many other cryptographic scenarios, it seemed like its own island of standards, the library can still be brought back in in the future if we find usecases for PK using PGP.\n\nHowever in choosing node-forge, we came across a few other problems. Mainly overall-cross platform compatibility planning for mobile devices. This is not just a problem with crypto, but also other libraries that are used in our `networking` domain such as utp-native.\n\nHere are something I found that may be relevant to us proceeding here:\n\n* The webcrypto standard ( URL is now the official standard for cryptographic operations in browser environments. It is now being supported by all major browsers and electron\n* This webcrypto standard is now taking over other deployment platforms such as in Nodejs: URL & URL \n* As a standardised API, switching over to this API gives us more cross-platform opportunity as the rest of the world's development ecosystem catches up and migrates over to webcrypto standard.\n* In particular are nativescript and react-native ecosystems. Currently none of them have official crypto APIs, they expect the developer to use underlying native iOS or Android crypto APIs.\n* However I found out that the GUN project URL claims to be able to use webcrypto on react-native and other platforms.\n* It does this through a \"webview\" trick. Basically this hooks into the browser runtimes that are on iOS and Android to perform the actual crypto and then return the results back to the main application. I have no idea about the performance characteristics of this trick. This trick is described here: URL and URL \n* The usage of webcrypto libraries is pioneered by \"PeculiarVentures\" which has these main libraries:\n - URL - this could be an alternative to node-forge for all of our PKI/X.509 and TLS related functionality (previously it was claimed this was overly complex compared to `node-forge`)\n - URL - this is a generic polyfill for webcrypto, not entirely sure how it wraps the native webcrypto inside nodejs or if smooths over the differences, there is a discussion about this library in relation to other webcrypto polyfills targeting nodejs URL because this is also mentioned with respect to the webview trick, there may also be a relationship between the webview trick and this polyfill\n - They have many other crypto related libraries that we should investigate\n\nAll of this will mean that we either replace node-forge, or end up creating a adapter pattern where we plugin different crypto implementions depending on our environment. At this point in time, the `keys` domain abstracts over most(all?) crypto operations for all other domains. Except in the case of EFS which is currently pinned to `node-forge` (it may be a good idea to abstract that and expect an interface of functions for EFS).\n\nCross platform compatibility here isn't just about the fundamental crypto library. It's also about other parts of PK. One closely related situation is the JOSE libraries. As they involve cryptographic operations, they currently seem to \"fix\" their underlying crypto library as well. It would be ideal that if we standardise on a crypto library for cross-platform deployment, that we can also ensure that our JOSE library is using the same crypto library to reduce our crypto attack surface. We are currently using URL which uses native crypto depending on the platform including webcrypto. Contenders include URL (which fixes on node-forge) and URL \n\n### Additional context\n\n* URL - js-id also should be using WebCrypto\n* #155 - will impact NativeScript deployment\n* URL - can help make use of the migration to `ArrayBuffer` and typed arrays\n* WebAssembly resources\n - There are 2 well supported runtimes for WASM:\n * wasm3 - supports interpretation\n * wasmer - supports JIT and AOT compilation\n - URL \n - URL \n - URL \n - URL - This describes how to use webcrypto together with webassembly when you need a custom crytographic functionality not supported inside webcrypto.\n - URL \n - URL and URL \n\nWasmer can compile WASM code to native code. But wasm3 is for interpretation. Why use interpetation?\n\nIt appears that in some cases interpretation can be more widely deployed. There are examples of iOS apps using wasm3. URL \n\nIt's becoming fast a standard target for many languages. Even TypeScript when ported to AssemblyScript can be compiled to WASM.\n\nOnce it is WASM, the only thing missing is broad adoption of WASI. If WASI is broadly adopted like it is in nodejs ( URL then pretty much we have a universal portable binary capable of doing relevant system operations. WASI is like a universal standard of system calls. Like a whole new POSIX standard.\n\nThen one would just use WASM and WASI for all platforms.\n\n### Tasks\n \n1. ...\n2. ...\n3. ...","known_context_document_ids":["gh_issue_1036078659"],"reference_answer":"We decided not to bother with preventing resource starvation, however an idea is like this.\n\n1. Take advantage of DB's natural key ordering.\n2. Create a bimap index of Priority/Timestamp -> Task Id AND Timestamp/Priority -> Task Id\n3. Now we can iterate task ids based on 2 compound indexes: highest priority + earliest timestamp AND earliest timestamp + highest priority\n4. Use dynamic programming/kinetic priority function that iterates through both sublevels (indexes) simultaneously to fill up a fixed concurrency pool (if unlimited, this policy is unnecessary, just iterate through as fast as posssible)\n\nSimultaneous iteration that uses the timestamp to weight the priority, where the timestamp delta starts from 0 and goes towards infinity. Once could say that this multiples the priority based on a \"rate\". A delta of 0 multiplies by 1. A delta of infinity multiplies by infinity. Therefore the rate produces a multiplier between 1 to infinity.","answer_document_id":"gh_comment_1223590432","silver_evidence_path":["gh_comment_1207685560","gh_issue_1128062883","gh_comment_1223590432"],"evidence_issue_ids":[1036078659,1128062883],"source_repo_name":"MatrixAI/Polykey","source_issue_id":1036078659,"source_issue_number":270,"source_issue_url":"https://github.com/MatrixAI/Polykey/issues/270","target_repo_name":"MatrixAI/Polykey","target_issue_id":1128062883,"target_issue_number":329,"target_issue_url":"https://github.com/MatrixAI/Polykey/issues/329","reference_anchor_document_id":"gh_comment_1207685560","reference_answer_author":"CMCDragonkai","reference_answer_author_association":"MEMBER","quality_score":94.08,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3929,"anchor_target_overlap":0.1071,"target_answer_overlap":0.0615},"issue_created_at":"2021-10-26T09:49:48+08:00","valid_comment_count":48,"fragments":[{"document_id":"gh_issue_1036078659","fragment_type":"issue_description","sequence":0,"text":"Migrating/Integrating WebCrypto (possibly WASM) instead of Node Forge Crypto\n### Specification\n\nThe work in #155 involving nativescript meant that we are starting to consider alternatives to Node forge crypto in order to standardise our crypto API and future proof to future JS-based platforms. There are number of reasons to look into webcrypto:\n\n* WebCrypto is a standard across ES platforms, thus enabling more potential native-implementations which can improve performance and security (prevent timing attacks)\n* WebCrypto API focuses on using ES-compliant buffers like `Uint8Array` and `ArrayBuffer` which can help us standardise our buffer usage across js-db, js-id, js-workers and more, especially as workers require `ArrayBuffer` to do zero-copy\n* There is existing work with WebCrypto API involving WASM to plug in functionality that isn't supported by the standard, such as providing ed25519 keys, and this will help us resolve the usage of ed25519 #168 \n* The `node-forge` source code isn't well maintained and doesn't have as many eyes watching and evaluating its security\n\nNow for some background:\n\nThis comment URL explains how we came to be using `node-forge` as opposed to other cryptographic libraries.\n\nI know that when Polykey project first started, we initially were thinking of using PGP and thus the kbpgp.js library ( URL We ended up going away from PGP due to its limited usage in a number of scenarios that we want PK to deal with. Namely end to end encrypted network communication which is a TLS issue, that makes use of X.509 certificates rather than PGP certificates. Furthermore we also had symmetric encryption/decryption scenarios like js-encryptedfs that again would not make use of PGP standards. Therefore it just lacked interoperability with many other cryptographic scenarios, it seemed like its own island of standards, the library can still be brought back in in the future if we find usecases for PK using PGP.\n\nHowever in choosing node-forge, we came across a few other problems. Mainly overall-cross platform compatibility planning for mobile devices. This is not just a problem with crypto, but also other libraries that are used in our `networking` domain such as utp-native.\n\nHere are something I found that may be relevant to us proceeding here:\n\n* The webcrypto standard ( URL is now the official standard for cryptographic operations in browser environments. It is now being supported by all major browsers and electron\n* This webcrypto standard is now taking over other deployment platforms such as in Nodejs: URL & URL \n* As a standardised API, switching over to this API gives us more cross-platform opportunity as the rest of the world's development ecosystem catches up and migrates over to webcrypto standard.\n* In particular are nativescript and react-native ecosystems. Currently none of them have official crypto APIs, they expect the developer to use underlying native iOS or Android crypto APIs.\n* However I found out that the GUN project URL claims to be able to use webcrypto on react-native and other platforms.\n* It does this through a \"webview\" trick. Basically this hooks into the browser runtimes that are on iOS and Android to perform the actual crypto and then return the results back to the main application. I have no idea about the performance characteristics of this trick. This trick is described here: URL and URL \n* The usage of webcrypto libraries is pioneered by \"PeculiarVentures\" which has these main libraries:\n - URL - this could be an alternative to node-forge for all of our PKI/X.509 and TLS related functionality (previously it was claimed this was overly complex compared to `node-forge`)\n - URL - this is a generic polyfill for webcrypto, not entirely sure how it wraps the native webcrypto inside nodejs or if smooths over the differences, there is a discussion about this library in relation to other webcrypto polyfills targeting nodejs URL because this is also mentioned with respect to the webview trick, there may also be a relationship between the webview trick and this polyfill\n - They have many other crypto related libraries that we should investigate\n\nAll of this will mean that we either replace node-forge, or end up creating a adapter pattern where we plugin different crypto implementions depending on our environment. At this point in time, the `keys` domain abstracts over most(all?) crypto operations for all other domains. Except in the case of EFS which is currently pinned to `node-forge` (it may be a good idea to abstract that and expect an interface of functions for EFS).\n\nCross platform compatibility here isn't just about the fundamental crypto library. It's also about other parts of PK. One closely related situation is the JOSE libraries. As they involve cryptographic operations, they currently seem to \"fix\" their underlying crypto library as well. It would be ideal that if we standardise on a crypto library for cross-platform deployment, that we can also ensure that our JOSE library is using the same crypto library to reduce our crypto attack surface. We are currently using URL which uses native crypto depending on the platform including webcrypto. Contenders include URL (which fixes on node-forge) and URL \n\n### Additional context\n\n* URL - js-id also should be using WebCrypto\n* #155 - will impact NativeScript deployment\n* URL - can help make use of the migration to `ArrayBuffer` and typed arrays\n* WebAssembly resources\n - There are 2 well supported runtimes for WASM:\n * wasm3 - supports interpretation\n * wasmer - supports JIT and AOT compilation\n - URL \n - URL \n - URL \n - URL - This describes how to use webcrypto together with webassembly when you need a custom crytographic functionality not supported inside webcrypto.\n - URL \n - URL and URL \n\nWasmer can compile WASM code to native code. But wasm3 is for interpretation. Why use interpetation?\n\nIt appears that in some cases interpretation can be more widely deployed. There are examples of iOS apps using wasm3. URL \n\nIt's becoming fast a standard target for many languages. Even TypeScript when ported to AssemblyScript can be compiled to WASM.\n\nOnce it is WASM, the only thing missing is broad adoption of WASI. If WASI is broadly adopted like it is in nodejs ( URL then pretty much we have a universal portable binary capable of doing relevant system operations. WASI is like a universal standard of system calls. Like a whole new POSIX standard.\n\nThen one would just use WASM and WASI for all platforms.\n\n### Tasks\n \n1. ...\n2. ...\n3. ...","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2021-10-26T09:49:48+08:00","repo_name":"MatrixAI/Polykey","issue_id":1036078659,"issue_number":270,"issue_url":"https://github.com/MatrixAI/Polykey/issues/270","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1153075792","fragment_type":"issue_comment","sequence":1,"text":"Note that `age` and wireguard both use URL \n\nIt's an alternative to AES GCM which has higher performance when the hardware doesn't support AES-NI instructions.\n\nAES GCM is still good for compliance though, some places like government require this.\n\nBut the algorithm apparently works and is designed for software-only implementations.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-06-12T05:27:01+08:00","repo_name":"MatrixAI/Polykey","issue_id":1036078659,"issue_number":270,"issue_url":"https://github.com/MatrixAI/Polykey/issues/270","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1179479436","fragment_type":"issue_comment","sequence":2,"text":"We will need to elevate this issue to a higher priority, we now have empirical results on how long it takes to generate a root key in multiple arenas:\n\n1. Tests\n2. AWS fargate\n\nOn fargate, using the 0.25 CPU containers, it takes 20 minutes to generate a root key pair. Se can be seen by this cloudwatch cpu utilisation graph:\n\ncpu\n\nAt the same time, key generation is using all cores by default. This doesn't even require the worker manager to be integrated, I think `node-forge` does this by default.\n\nWe believe that this is causing CPU starvation of all the other testing workers that jest creates and thus leading to test timeouts as can be seen in #394.\n\nAs we have deployed our testnet, and we expect the need to autoscale the agents, key generation is going to be an important workload, as it delay the scaling up process. Remember even if we pass in a recovery code, the keys must still be generated and this still takes time.\n\nFurthermore we want to get #168 done before going to mainnet, because at that point users will be using our system, and we don't want to get stuck on legacy RSA.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-07-09T04:53:02+08:00","repo_name":"MatrixAI/Polykey","issue_id":1036078659,"issue_number":270,"issue_url":"https://github.com/MatrixAI/Polykey/issues/270","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1179875110","fragment_type":"issue_comment","sequence":3,"text":"It's possible to override the number of workers that the `generateKeyPair` `src/keys/utils.ts:64` uses. We can provide `workers: 1` as part of the options.","author_login":"tegefaulkes","author_association":"CONTRIBUTOR","created_at":"2022-07-11T01:52:08+08:00","repo_name":"MatrixAI/Polykey","issue_id":1036078659,"issue_number":270,"issue_url":"https://github.com/MatrixAI/Polykey/issues/270","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207685560","fragment_type":"issue_comment","sequence":4,"text":"The `node-forge` has its own workers implementation it doesn't actually use `WorkerManager`. We are looking into refactoring `WorkerManager` with respect to the `Queue` and `Scheduler` implementation in #329. And replacing the crypto is important for our (second, our first one was back in around Jan - Mar 2021 which failed) beta launch, because we want users to be using #168.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-08T05:32:53+08:00","repo_name":"MatrixAI/Polykey","issue_id":1036078659,"issue_number":270,"issue_url":"https://github.com/MatrixAI/Polykey/issues/270","linked_issue_ids":[1128062883],"is_known_query_context":false},{"document_id":"gh_comment_1232580979","fragment_type":"issue_comment","sequence":5,"text":"Note that 16.17 has proper support for ed25519:\n\nimage\n\nCurrent latest 22.05 is still 16.16.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-31T07:43:17+08:00","repo_name":"MatrixAI/Polykey","issue_id":1036078659,"issue_number":270,"issue_url":"https://github.com/MatrixAI/Polykey/issues/270","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1245096539","fragment_type":"issue_comment","sequence":6,"text":"The commit that introduced 16.17 into nodejs is 6e2536f1b09863e984f0479ea4b162e4fe86493d.\n\nTo use it, one must use `nodejs-16_x` as `nodejs` will be `18.9.0` which may have some major differences.\n\nI'm going to try the latest master commit and see how we go. This will impact all of the nix-derived dependencies.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-09-13T08:48:50+08:00","repo_name":"MatrixAI/Polykey","issue_id":1036078659,"issue_number":270,"issue_url":"https://github.com/MatrixAI/Polykey/issues/270","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1272518236","fragment_type":"issue_comment","sequence":7,"text":"The benchmark results in #446 means that we do need webcrypto and due to iOS issues, we cannot use wasm. So we have moved to libsodium instead, and the benchmarks show that libsodium is 10x to 50x faster than webcrypto.\n\nWe are also going with native `Buffer`, and future usage will just use the `Buffer` polyfill.\n\nThere remains 2 uses of webcrypto:\n\n1. bip39 recovery code\n2. x509 signing\n\nThe first can be replaced with our own KDF mechanism. In that sense, we would no longer use bip39.\n\nThe second is a bit more difficult, it may be easier to create a webcrypto shim backed off libsodium and only for ed25519 signing.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-10-09T11:11:11+08:00","repo_name":"MatrixAI/Polykey","issue_id":1036078659,"issue_number":270,"issue_url":"https://github.com/MatrixAI/Polykey/issues/270","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1128062883","fragment_type":"issue_description","sequence":0,"text":"Generic Non-Blocking Task Management (\"Queue\") for discovery and nodes domains\n### Specification\nUnattended discovery was added in #320, however, there is no concept of priority within the queue. There are three ways that a vertex (a node or identity) can be added to the discovery queue, and they should follow this order of priority:\n1. Manually, via the discovery methods `queueDiscoveryByNode()` and `queueDiscoveryByIdentity()` (these are called in the commands `identities discover` (explicit discovery) and `identities trust` (explicitly setting a permission, so we want the Gestalt to be updated via discovery).\n2. As a step in the discovery process whereby child vertices are added into the discovery queue in order to discover the entire connected gestalt.\n3. Automatically by a process of rediscovery when we want to update existing Gestalts in the Gestalt Graph (to be addressed in #328).\n\nVertexes with a higher priority should be discovered first, either by being placed at the front of the queue or by modifying the traversal method of the queue. The priority queue could also be further optimised by grouping vertices from the same gestalt together when this is known (for example when adding child vertices).\n\n### Additional context\n\n* Original PR for implementing Unattended Discovery: URL \n* Issue for re-adding discovered vertices into the queue to update the gestalt graph URL \n* #188 - Indexing the LevelDB may be required to be able to implement a persistent priority queue\n* URL - general indexing into js-db\n* URL \n\n### Tasks\n1. Modify the existing Discovery Queue to be a Priority Queue\n2. Ensure that when a user interactively wants to discover a gestalt vertex that it becomes the highest priority and gets executed first\n3. Look into the potential for further optimising the priority queue, for example by having multiple points of comparison with varying levels of importance that can influence the priority of a particular vertex in the queue","author_login":"emmacasolin","author_association":"CONTRIBUTOR","created_at":"2022-02-09T05:12:24+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1039794027","fragment_type":"issue_comment","sequence":1,"text":"There's a go implementation of persistent priority queue backed by leveldb here: URL It can be used as a reference for this.\n\nOur priority queue needs to by default maintain order, because we do want to know the sorted list of jobs. But also allow us to add a special priority number on top.\n\nFrom my imagination:\n\nThis reminds me of the indexing problem, where you can ask for a list of rows sorted by several columns. The first column would dictate the base sort, then subsequent columns would sort any ambiguous sub-orders.\n\nImagine we had 2 indexes. The first being your priority index using an arbitrary number, the second being the monotonic time index using `IdSortable`. You could sort on the priority index first, then sort on `IdSortable` second.\n\nMaybe this then has a relationship to #188.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-02-15T02:48:09+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1040944042","fragment_type":"issue_comment","sequence":2,"text":"This can be done with a compound index. Prefix can be the priority number (lexinted), suffix can be IdSortable.\n\nThis means you can then stream results that are always ordered in terms of priority first then by time second.\n\nPriority can start at 0 by default, and one can increment priorities depending on the origin of the task. Like tasks emitted by user wanting to lookup something can be set to a higher priority number.\n\nWe could do this directly by changing the queue domain key. But I'd suggest first solving the indexing issue in general first then building a compound index on top.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-02-16T00:41:19+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1048403509","fragment_type":"issue_comment","sequence":3,"text":"We discovered that the priority queue can also benefit from a uniqueness index creating a uniqueness constraint: URL \n\nThis means that duplicate tasks cannot go into the priority queue. Not entirely sure if this is required because a queue can still say they should process the same task over and over.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-02-23T02:49:47+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1103469683","fragment_type":"issue_comment","sequence":4,"text":"We should have a concurrency bound in the queue. This means how many tasks should be executed at the same time. By default unbounded meaning all tasks gets executed immediately without waiting to be done.\n\nFor IO bound tasks, you might as well have unbounded concurrency. For CPU-bound it can be sent to the web worker pool which is bounded by core count. Battery usage optimisation may also affect our limit too.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-04-20T04:52:32+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1104776367","fragment_type":"issue_comment","sequence":5,"text":"A generic Queue class has been implemented here: URL \n\nThis queue is not persistent, or a priority queue, however, it is designed to be a generic queue that can eventually be used in all places that require this functionality (including the Discovery Queue). The generic Queue can be refactored to meet this issue and URL at some point in the future, potentially incorporating the DB.","author_login":"emmacasolin","author_association":"CONTRIBUTOR","created_at":"2022-04-21T06:44:30+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1109417044","fragment_type":"issue_comment","sequence":6,"text":"Renamed this issue to the general idea of non-blocking task management. It now has to solve for discovery, nodes management in terms of setting nodes, pinging nodes and garbage collection, as well as in relation to:\n\n* #354\n* #349\n* #345\n* #328\n* #297\n\nThere's a relationship between the queue design and the `EventBus` system, as well as our `WorkerManager`.\n\nMost important is for us to develop a `Task` abstraction. It can be a `class Task`, that represents a \"lazy promise\". Promises in JS are strictly evaluated, while these tasks will need to be lazily evaluated. Then our task management system can convert our lazy tasks to strict promises (which represents futures). More background info here: URL \n\nOur task manager will need to have configurable:\n\n* Concurrency limit - indicates the bound on the pool of currently executing tasks (can be 1 to unbounded/infinite)\n* Executor - choosing to execute by Node's event-loop, or by passing it into the `WorkerManager` to be executed in a separate thread or core, the former should be used for IO-bound tasks, the latter should be used for CPU-bound tasks. This could be specified by the task creator, rather than the task manager itself.\n\nStretch goal is to also incorporate \"time/calendar-scheduling\" so that tasks can be executed at a point in time like cron.\n\nInteraction between `EventBus` and task manager may be considered. The event bus is about communicating changes between domains, but the task manager is the one actually executing the tasks.\n\nTasks can be:\n\n* Re-ordered or reprioritised or given priorities\n* Can be observed for success or failure\n* Can have errors handled\n* Can be cancelled using our design for abort signal, and have their real side-effects cancelled\n* Can be monitored for progress\n* Can be persistent - backed by leveldb\n\nThis rabbit hole for this goes deep. So we should make sure not to feature creep our non-blocking task queuing needs.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-04-26T06:55:13+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1109418565","fragment_type":"issue_comment","sequence":7,"text":"Also to clarify, we are not creating a \"generic distributed job queue\", that's the realm of things like redis queue and URL There's so much of this already. We just need something in-process relative to Polykey.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-04-26T06:57:25+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1110480264","fragment_type":"issue_comment","sequence":8,"text":"Along with the configurable concurrency limit and executor, I think we should have an interface for the queue as well. Depending on the situation we may need just a simple queue, a priority queue, a persistent database queue like discovery uses, etc etc...\nSo far as the `Queue` cares it only needs to support `push` and `shift`. So we can make the `Queue` a generic class and pass it any implementation we want for storing the queue so long as it extends the interface.\n\nIt shouldn't be too hard to make the change. We just need to decide if this degree of control is desired. I can see a need for it though.","author_login":"tegefaulkes","author_association":"CONTRIBUTOR","created_at":"2022-04-27T03:01:11+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1153075318","fragment_type":"issue_comment","sequence":9,"text":"More prior work:\n\n* URL \n\nActually the entire modern-async library is quite interesting, as it has implemented some of the things that we've been working on as well. But I think we won't just bring in that library, but instead extract parts out of it for our own implementation.\n\nIt has interesting ideas for promise cancellation as well, `Delayer`, `Scheduler` and `Queue` can all help. I believe that our usage of async generators and decorators might be more advanced though.\n\nThe library also exports a bunch of collection combinators that can work with asynchronous execution. So instead of say `Array.map` mapping a synchronous function, it could map an asynchronous function, and then wait for all of them to finish. Basically we do this with `Promise.all` atm. It also works with asynchronous iterables like async generators. This I feel is a different kind of thing, and I'd only want to bring in these utility functions where it's relevant. Maybe if JS had better treeshaking and package specific imports ( URL it would work well.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-06-12T05:21:57+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1193509271","fragment_type":"issue_comment","sequence":10,"text":"Additional resources...\n\nRegarding delaying tasks (will be useful to understand how timeouts work and how we intend to persist them):\n\n* URL \n* URL \n* URL \n* URL \n\nRegarding serialisation and persistence of lazy tasks (the persisted task in the Queue backing the DB isn't a promise, it's just some data on disk, but we may give back a lazy promise as an in-memory reference to the task):\n\n* URL \n* URL \n\nWe may not actually be serialising arbitrary code, but instead allow domains to register function callbacks into the queue, and then the queue will then call back these registered functions. That way the functions are somewhat dynamic but not just arbitrary code execution.\n\nAs for the lazy promise representation, make sure to take some ideas from URL I'm wary of bringing in such a huge library and API, so we should just take ideas from it and implement it in our own promise abstractions.\n\nAs for the worker dispatch, we want the workers to pull in tasks from the queue when done. However threadsjs (used by js-workers) doesn't expose a complex queue to use. So we won't be able to use their own queue, instead, we would want to augment our workers or augment the `Pool` class to take work from our own persisted queue. See: URL","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-07-25T03:17:05+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1193509941","fragment_type":"issue_comment","sequence":11,"text":"During the testing of this it would be nice to incorporate URL ( URL into the model based checking of the queue functionality. Some background: URL","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-07-25T03:18:27+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1200439793","fragment_type":"issue_comment","sequence":12,"text":"So I'm thinking that rather than queueing arbitrary code, you have to first register handlers like `queue.registerHandler(fName, f);` Then subsequently when you push a task like `queue.pushTask(task);` the end result is that when the task gets executed, it ends up executing a \"static pointer\" which is the `fName`.\n\nBut then this is actually really similar to `EventEmitter` and our `EventBus`. Basically registering handlers is the same as adding event handlers, then pushing tasks is similar to emitting events. See: URL \n\nSo there are similarities, there are some differences, our scheduling of tasks is not just a simple synchronous call, nor is it an asynchronous call as we have in `EventBus.emitAsync`.\n\nThe queue is also persistent unlike the eventbus, the actual emission of the event may be delayed by an arbitrary amount of time that is also persisted. There's a controlled concurrency to dispatching tasks.... etc.\n\nSo similar, but different. In that sense, there's no need to extend from `EventEmitter` (especially since we need to change that to event target)...","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-07-31T14:48:15+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1200443247","fragment_type":"issue_comment","sequence":13,"text":"This URL has an interesting solution. They support static priorities. These priorities are set when an item is enqueued.\n\nOnce enqueued, the user gets back a ID.\n\nThere are 256 possible priorities from 0 to 255 inclusive.\n\nWhen the item is stored, a key is derived from both the priority level and its ID.\n\n // Create new PriorityItem.\n item := &PriorityItem{\n ID: level.tail + 1,\n Priority: priority,\n Key: pq.generateKey(priority, level.tail+1),\n Value: value,\n }\n\nAs you can see here, the IDs are generated by the queue, and they are a counter that is simply incremented.\n\nThe resulting database KEY is likely a concatenation of the priority level and the ID. Assuming lexicographic encoding, there's just basically `PRIORITY + SEQUENCE`.\n\nSo then in the database, we can always find the highest priority with just the ordered keys, as it will be ordered by the priority first then the sequence second.\n\nInterestingly, when dequeueing, it doesn't seem to consult the database, but some in-memory structure that indicates what is currently highest priority level to consider. But I wonder if this is necessary.\n\nSurely it can just take a row off the database, as the database is the source of truth of what is highest priority.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-07-31T15:08:26+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1200445031","fragment_type":"issue_comment","sequence":14,"text":"The URL has 2 interesting features:\n\n1. The ability to delay the dispatch of a job that is queued\n2. The ability to stream dispatch jobs\n\nThe first feature appears to be done by passing a handler that determines when a job is valid to be executed\n\nThis handler is simply checked repeatedly whenever a job is iterated over.\n\nThe second feature is an asynchronous loop that just iterates over the jobs. If a job isn't valid, it just sticks it back into the queue.\n\nIn that sense it is really using it like a queue, but I don't think it's very efficient as if a job that isn't valid, it just repeating a busy loop with a delay until it checks again when the job is valid.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-07-31T15:18:39+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1200446398","fragment_type":"issue_comment","sequence":15,"text":"The concept of URL is interesting as it indicates the idea of priority that can grow or decay as a function of time. So then when an item is inserted, it's inserted at time `T` rather than with a priority. But there's a priority function associated. Therefore, to know the priority of the item, apply the function to `T`. This is an abstract interface, the implementation might be more complex.\n\nBut it is interesting because we can definitely store `T` into the database, but our indexing of the queue becomes more complex. In the case of the go solution, the priority is part of the index, so it's easy to find what is the lowest priority just by getting a sorted key-value.\n\nOne way to do this, that upon first starting the queue, we scan the contents of the queue which is an O(n) procedure. This gives us an understanding of what is in the queue, and then to create in-memory twins of this data. In particular this would be useful for any persisted delayed jobs, where we put down the time it was inserted, and the desired amount of delay.\n\nThe queue is not meant to be big, so O(n) at the beginning when loading the queue should be fine.\n\nNow can this same mechanism be used to apply dynamic priorities, where because we know the time of the items in the queue, we can then re-sort them according to an in-memory priority? To do so, may seem to require some sorted partitioning of the jobs into their relative derived priorities.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-07-31T15:26:58+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1200447754","fragment_type":"issue_comment","sequence":16,"text":"The idea of scanning the priority queue database at launch is necessary because persisted start times with delays have no other way of being made available to the code.\n\nUnless one were to index the database by scheduled time. Schedule time would be `INSERTION TIME + DELAY`.\n\nThen the items would be indexed by this number.\n\nA numerically sorted key-values, upon which popping the lowest number, would be the item that is earliest to be scheduled for execution.\n\nAt the same time, because the program knows its own time, we can attempt to pop tasks only within a given range search.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-07-31T15:35:18+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1200449157","fragment_type":"issue_comment","sequence":17,"text":"Imagine index of `INSERTION TIME + DELAY`.\n\nTime is ticked 1 second at a time. Insertion time grows linearly.\n\nDelay can be 0 or more.\n\nAs tasks are inserted at linear time steps `1+100, 2+50, 3+10, 4+0`, this fills up a queue of:\n\n4\n13 \n52\n101\n\nThe dispatch, looks for all task where `index <= currentTime`.\n\nSuppose current time is 32, then you get `[4, 13]` which are tasks that are due to be executed. In particular you have 2 tasks are overdue. But that's ok, this is best-effort execution.\n\nBut when does this dispatch execute? Is it just polling every second? The database is not capable of triggering things. It's state, not a process.\n\nSo dispatch may check at each time-tick, but this is also inefficient.\n\nThe dispatch can instead look for lowest indexed item. Then set a timeout to be executed based on the scheduled time in-memory. This is assuming all times are in the future. If they are in the past, then they should be dispatched now.\n\nSo suppose the above queue.\n\nUpon the first lookup, it would see task 4. Assume current time to be at 2.\n\nThen it would `setTimeout` for `2` to pop a task at time 4, which would find all tasks `index <= 4`.\n\nHowever what happens if new tasks are entered into the system that should be executed even earlier. In that case, the insertion of new tasks should also trigger the dispatcher, but only if the new task `INSERTION TIME + DELAY` is earlier than task `4`.\n\nSo at any point in time, there will always be a `setTimeout` set to the earliest task that has to be executed. And this is reset every time a task is executed.\n\nThis avoids having to do an O(n) scan at the very beginning, and instead is more like an O(1) scan.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-07-31T15:43:40+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1200450263","fragment_type":"issue_comment","sequence":18,"text":"So that deals with tasks with delays and also no delays. No delays just mean a delay of 0.\n\nWhat we have is a list of tasks ordered by \"scheduled\" execution times.\n\nStatic priority is just a matter of adding a numeric prefix. Starvation may occur here.\n\nDynamic priority means tasks should start with an initial priority. But then as we pop tasks out we must execute a function to figure out its priority.\n\nSuppose there are 2 tasks, both are scheduled for immediate execution, that is a delay of 0. Which task should be executed assuming only 1 can be executed at a time?\n\nThe priority function is applied to both tasks, using the tasks's `INSERTION TIME` as a parameter.\n\nThe priority function will take into their account their initial priority, plus their dynamic priority returned by the function. This added up is weighed together, and the highest priority task is executed, the other task remains in the queue.\n\nThis means priority is not indexed at all, it's just a value. And we solve the starvation problem now.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-07-31T15:49:58+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1201155627","fragment_type":"issue_comment","sequence":19,"text":"We still need a `TaskId`, and if we use `IdSortable`, we pass in a `nodeId` into the `IdSortable` constructor. This is only used to to ensure that Ids can be generated uniquely and not conflict between different nodes. But this is only useful if the `TaskId` is going to share the same namespace.\n\nSince this is not going to happen, it doesn't really matter, and we should make the `nodeId` optional.\n\nNote that however, if the node ID changes, that should involve reassigning the `generateTaskId` function with the new node ID.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-01T12:46:21+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1201164755","fragment_type":"issue_comment","sequence":20,"text":"Note that since we are indexing by \"scheduled time\", we cannot just extract the time component of the `TaskId`.\n\nSo we have multiple sub levels here:\n\n1. `['Queue', 'tasks']` - `TaskId -> Task`\n2. `['Queue', 'time']` - `Time -> TaskId`\n\nWhen creating a task, we create a task id, insert it with the task, then also assign a time to the task to be executed.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-01T12:55:08+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207157448","fragment_type":"issue_comment","sequence":21,"text":"Found URL and URL and URL \n\nWe could replicate a little about the API design here.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-06T06:12:36+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207170286","fragment_type":"issue_comment","sequence":22,"text":"When scheduling a new task. The task object is created.\n\nThis task object needs to represent a lazy promise.\n\nA lazy promise in this case means that the promise doesn't mean that the execution has started. It's simply queued.\n\nBecause tasks are persisted into the DB, it's possible for the PK agent to be restarted, and one may wish to await for a given task ID. That means acquiring a promise for that task ID.\n\nI'm thinking that we can lazily create a promise, that is one to one for each task. Then you can await this promise's result.\n\nIf multiple calls to acquiring this promise is made, the same promise is shared among all callers. This means a single `resolve` or `reject` call will send all awaiters.\n\nHere's an example:\n\nts\nasync function main () {\n\n const p = new Promise((resolve, reject) => {\n setTimeout(() => {\n reject(new Error('oh no'))\n }, 500);\n setTimeout(resolve, 1000);\n });\n\n const f = async () => {\n await p;\n return 'f';\n };\n\n const g = async () => {\n await p;\n return 'g';\n };\n\n const r = await Promise.allSettled([\n f(),\n g()\n ]);\n\n console.log(r);\n\n // @ts-ignore\n console.log(r[0].reason === r[1].reason); // This is `true`\n\n // The same exception object is thrown to all awaiters\n\n}\n\nvoid main();\n\nThere are some constraints:\n\n1. You cannot acquire a promise for a task that does not exist in the queue.\n2. Creation of the promise may involve hitting the disk if the promise doesn't already exist relative to a task ID.\n3. Creation of the promises has to be protected against race conditions with the object locking map pattern.\n4. If you get a promise, it is guaranteed that within some finite amount of time that this promise will eventually resolve.\n\nHow is point 4 guaranteed? It is only possible to get a task promise in 2 ways:\n\n1. During creation of a new task, the promise can be created afterwards.\n2. One can ask `queue.getTask()`.\n\nNow because it's a lazy promise, this could mean that the task is already executed by the time you ask for a promise for the task. This is only possible if the task is no longer in the queue (or is in some invalid state).\n\nIn this situation, when asking for the promise, the promise should be immediately rejected. Alternatively since the acquisition of this promise is lazy, one may throw an exception at this point. The point is, if you do get a promise, the promise must be settled eventually.\n\nOne of the initial ways to do this is to add an event listener for every task as soon as it is put into the queue. The problem with this is that now you get in-memory space complexity of O(n), where you have 1 listener for every task.\n\nListeners aren't always necessary, and maybe lots of tasks are put into the queue. In such a case, we can make the promise/listener itself lazy.\n\ngetTask(): Promise {\n // if we give you back a Task\n // you can be guaranteed to have it resolved or rejected\n // if we cannot give you a Task, because it's already executed, then we throw an exception at this point\n}\n\nAlternatively we do something like:\n\ngetTask(): Promise ;\n\nAnd `undefined` means it's not possible to give you a promise to the task.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-06T07:59:22+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207172799","fragment_type":"issue_comment","sequence":23,"text":"Another problem is that exactly is a `Task`? Is a data structure, or is it a promise? Maybe it's both?\n\nThe `Task` could be a class instance with enumerable properties, along with a method that allows one to acquire the promise?\n\nI'm considering an API like this:\n\n// true means that you are tracking the task immediately\nconst task = await queue.pushTask(lazy: true);\n\n// Waits for the promise\nawait task;\n\n// false means you are not tracking the task\nconst task = await queue.pushTask(lazy: false);\n\n// Now it may result in an exception if the task is already executed\n// This has to distinguish from the task itself being rejected\n// ErrorTaskReference\n// ErrorTaskRejected\nawait task;\n\nSomething like this means `Task` is in fact an extension of the `Promise`. Or at least a class that has the `then` method. It doesn't actually have to satisfy the entire promise interface. Which would include `.catch` and `.finally`.\n\nEither way, the `lazy` boolean allows one to switch from a lazy promise to an eager promise.\n\nIn this sense, lazy simply means whether the task itself is being tracked or not. If it is being tracked, then `await task` is always guaranteed to either result in `ErrorTaskRejected` or the task's result. If it is not being tracked, then it only starts tracking when `await task` is called. Which calls the `then` method. At this point it may throw `ErrorTaskMissing` or `ErrorTaskRejected`... or anything else.\n\nI may have something like:\n\nErrorTaskMissing - task itself is no longer around, it may already been fulfilled\nErrorTaskReference - task handler was not found\nErrorTaskRejected - task was rejected, see the cause chain","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-06T08:16:11+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207173205","fragment_type":"issue_comment","sequence":24,"text":"Is there a utility in having `ErrorTaskRejected`? Maybe only to create a set of possible exceptions, as the cause chain can have anything that the task handler itself throws. Otherwise we are just rethrowing the exceptions. URL","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-06T08:19:43+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207188859","fragment_type":"issue_comment","sequence":25,"text":"So within `Queue`, we will have 2 methods that that are used as part of `start` and `stop`.\n\nprotected async startProcessing(): Promise ;\nprotected async stopProcessing(): Promise ;\n\nTheir job is to peek into the job schedule. (I've started to realise that this is more a \"schedule\" not a queue, since the priority doesn't apply until the tasks are due for execution).\n\nIn the job schedule, they find:\n\n* Tasks that are due for execution are dispatched the execution queue\n* The next task not due for execution will have its scheduled time set as a `setTimeout`\n\nThe `startProcessing` will also be called by the `scheduleTask` method. This is because there be no tasks in the schedule, and upon scheduling a task, we trigger the start processing again.\n\nCalling `startProcess` should be idempotent, as in, if the processing is already started, then nothing happens. It would only matter if the `setTimeout` delay should be made smaller because a more recent task has be scheduled.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-06T10:16:38+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207189793","fragment_type":"issue_comment","sequence":26,"text":"The queue now would have 2 \"queues\".\n\n1. Schedule - this is purely time based, by using `IdSortable` as the `TaskId`, this means all tasks have unique scheduling time (up to the maximum amount of ticks the `IdSortable` is capable of). Which means there will always be 1 task that is in front to be executed. Here priority does not matter, it is simply a matter of scheduling time\n2. Execution Queue - this is the queue of jobs that are actually pending execution right now, here is where priority actually matters. This can make use of dynamic priority assuming the number of tasks sitting here is not too much. One can just round robin here, or select the task that has sat here the longest. Perhaps a double index sort between initial priority and time of insertion.\n\nIf the task is never fulfilled (resolve/rejected), it should stay in the execution queue (which should still be persistent).","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-06T10:23:06+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207190947","fragment_type":"issue_comment","sequence":27,"text":"Originally in order to \"connect\" a lazy promise to a task execution, this was done with a callback that I called a \"listener\".\n\nNow I realised that the deconstructed promise is itself already a set of callbacks to be executed on the task execution.\n\nThis means during actual task dispatch, we could just do something like:\n\nts\ntaskHandlerExecution(...taskParameters).then(\n resolveTaskP,\n rejectTaskP\n).finally(() => {\n this.promises.delete(taskId.toString() as TaskIdString);\n});\n\nThat is, the promise that comes from executing the task handler gets connected to the deconstructed promise of the task abstraction.\n\nAnd at the end, the task promise is deleted once the task is done.\n\nThis only occurs IF the task promise was first created. If it was lazy promise, it may never get created in which, and if so, nothing is there to observe/await the task execution. That's fine as the task's side effects continues to be done.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-06T10:32:40+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207370498","fragment_type":"issue_comment","sequence":28,"text":"So now I have:\n\n* `Queue` - this is an _encapsulated_ dependency of `Scheduler`\n* `Scheduler` - this is the main access to the tasks domain\n\nDuring the `PolykeyAgent` start process, we expect that the `Scheduler` is going to be a *required* dependency of other relevant domains.\n\nts\nconst scheduler = new Scheduler();\nawait Discovery.createDiscovery({ scheduler });\nawait NodeGraph.createNodeGraph({ scheduler });\nawait scheduler.start();\n\nWhy not use `await Scheduler.createScheduler();`? This is because, this would require us to inject `handlers` from the very beginning, and these handlers are only known by the other domains. Which results in a circular dependency.\n\nHere we are directly constructing the `Scheduler` and using it like a `StartStop` system.\n\nHowever it is actually CDSS, as there is a `destroy` method too that removes all the persisted state.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-07T09:51:31+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207371028","fragment_type":"issue_comment","sequence":29,"text":"One of the issues with this is that certain methods must be possible by the time it is constructed, but not necessarily asynchronously started...\n\nBut at the same time asynchronous start is necessary to do any async setup such as creating the database levels... etc.\n\nSo now I'm thinking that `start` and `stop` is still used, and thus `createScheduler` is used, but when `Scheduler.start` just doesn't actually start the processing of tasks, necessitating one to call `scheduler.startProcessing()`.\n\nBut then it's not going to be symmetric if the `Scheduler.stop` does call `stopProcessing` but `start` doesn't call `startProcessing`.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-07T09:54:31+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207371549","fragment_type":"issue_comment","sequence":30,"text":"The alternative is that we use a callback/hook abstraction similar to the `EventBus`. So now instead function hooks is registered in the other domains first. These end up calling the `scheduler` system.\n\nAnother alternative is that `Scheduler` is only `StartStop` instead, but again this isn't nice, if there needs to be asynchronous creation routines.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-07T09:57:07+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207375920","fragment_type":"issue_comment","sequence":31,"text":"I've added a `delay` boolean to `Scheduler.start` in order to not start the processing. That way users can start scheduling with `Scheduler.startProcessing()` manually afterwards.\n\nBy default the `delay` is `false`, so that by default the processing does already start.\n\nThis means in the `PolykeyAgent.createPolykeyAgent`, we should instead see something like:\n\nts\nconst scheduler = await Scheduler.createScheduler({ delay: true });\nawait Discovery.createDiscovery({ scheduler });\nawait NodeGraph.createNodeGraph({ scheduler });\nawait scheduler.startProcessing();\n\nWhen stopping the processing this doesn't actually stop the execution of any tasks, it just stops the processing of the scheduler.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-07T10:21:28+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207385393","fragment_type":"issue_comment","sequence":32,"text":"The scheduler doesn't _execute_ the tasks. It _dispatches_ to the queue. The queue _assigns_ tasks to workers, workers is what _executes_ the task. At the same time, the workers may also _pull_ tasks from the queue when they are idle.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-07T11:19:58+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207599762","fragment_type":"issue_comment","sequence":33,"text":"The `Queue` will need to work with threadsjs queue too: URL I'm not sure yet if this means our `WorkerManager` will need to be changed to work with the `Queue`, since I don't really want there to be 2 queues. Maybe `Queue` is for managing the queue persistence, while embedding the `WorkerManager` in-memory queue that is one to one for each task that is persisted.\n\nAlternatively we actually don't use `WorkerManager` pool, and instead manage our own \"pool\" directly.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-08T03:04:53+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207600999","fragment_type":"issue_comment","sequence":34,"text":"I haven't completed the full design of `Task` class. But I suspect it needs to be similar to lazy promise here: URL and even threadsjs representation uses a `then` method to allow `await` to work on their objects. Their type is:\n\nts\n/**\n * Task that has been `pool.queued()`-ed.\n */\nexport interface QueuedTask {\n /** @private */\n id: number;\n /** @private */\n run: TaskRunFunction ;\n /**\n * Queued tasks can be cancelled until the pool starts running them on a worker thread.\n */\n cancel(): void;\n /**\n * `QueuedTask` is thenable, so you can `await` it.\n * Resolves when the task has successfully been executed. Rejects if the task fails.\n */\n then: Promise [\"then\"];\n}","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-08T03:07:06+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207605811","fragment_type":"issue_comment","sequence":35,"text":"If `Task` is in fact a `class Task extends Promise`, it would have properties that would be enumerable, and properties that are not. We may need to specify this explicitly: URL \n\nAlternative is to form an a plain object like threadsjs does instead of using classes.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-08T03:15:41+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207649608","fragment_type":"issue_comment","sequence":36,"text":"Note that since `TaskId` is a `IdSortable`, it's strictly monotonic due to our storing of the last task ID...\n\nBut this assumes the last Task ID is always stored, and we are intending on deleting tasks off the schedule once completed. I wasn't thinking keeping historical tasks are useful (except for maybe debugging? Although it seems like it would be dropped in production, and logging/tracing systems should be maintaining the audit log).\n\nThis means the last task ID may be undefined. So we would store the last Task ID regardless of whether there are any tasks left in the scheduler.\n\nFurthermore, when the clock is shifted backwards, the time will be incremented by 1 until it is greater than the last time. The 1 is the smallest unit of precision, in which case this would be 1 millisecond.\n\nAfterwards, it will be strictly monotonic ID but have a weakly monotonic timestamp up to 4096 IDs per millisecond. After 4096 it would roll over.\n\nThe expectation is that it's not possible to generate more than 4096 IDs in a millisecond, so by that time, the time must have increased by at least 1 millisecond.\n\nAnyway this means we need to store `lastTaskId` into the `Scheduler` under level separate from the `Scheduler/tasks` level.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-08T04:22:06+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207691067","fragment_type":"issue_comment","sequence":37,"text":"Benchmark in js-workers shows that the overhead to call the workers takes about 1.16 to 1.5ms.\n\nA CPU intensive task should be greater than that time to be worth sending to the worker.\n\nHowever most scheduling work seems it might not actually be CPU intensive. Like NodeGraph and Discovery is mostly IO. I suppose discovery may have have CPU work to pattern match the data to find the right data on the pages it loads, but this should be dominated by the time spent on IO.\n\nFurthermore sending it to a worker can introduce locking problems. The async locks do not work across the worker threads, they only work within the same event loop context. They are not thread-safe nor process-safe.\n\nThis should mean that we should not directly integrate `WorkerManager` into the `Queue`, instead individual domains may have their handlers directly pass work to the `WorkerManager`. The `Queue` does not decide this since it does not know the nature of the task. The domain that registers the handlers can decide the nature of the task. So they can execute within the main thread, or send it off to a web worker and await for it.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-08T05:42:24+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207691937","fragment_type":"issue_comment","sequence":38,"text":"This means naturally the `Queue` can have either 1 as a concurrency limit or `0` to indicate unbound concurrent limit. With an unbound concurrency limit, it just immediately proceeds to execute everything that is due for execution.\n\nPriority only comes into play with a concurrency limit so that things get put into priority order. Otherwise all tasks will be asynchronous and immediately executed.\n\nThe worker's concurrency/parallel limit is not a concern of the `Queue` then.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-08T05:44:07+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1223590432","fragment_type":"issue_comment","sequence":39,"text":"We decided not to bother with preventing resource starvation, however an idea is like this.\n\n1. Take advantage of DB's natural key ordering.\n2. Create a bimap index of Priority/Timestamp -> Task Id AND Timestamp/Priority -> Task Id\n3. Now we can iterate task ids based on 2 compound indexes: highest priority + earliest timestamp AND earliest timestamp + highest priority\n4. Use dynamic programming/kinetic priority function that iterates through both sublevels (indexes) simultaneously to fill up a fixed concurrency pool (if unlimited, this policy is unnecessary, just iterate through as fast as posssible)\n\nSimultaneous iteration that uses the timestamp to weight the priority, where the timestamp delta starts from 0 and goes towards infinity. Once could say that this multiples the priority based on a \"rate\". A delta of 0 multiplies by 1. A delta of infinity multiplies by infinity. Therefore the rate produces a multiplier between 1 to infinity.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-08-23T06:06:20+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1242997752","fragment_type":"issue_comment","sequence":40,"text":"Once we have the tasks system, all other domains should not have any kind of background processing implemented, they should delegate ALL of that functionality into the tasks system.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-09-11T16:22:39+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1245119053","fragment_type":"issue_comment","sequence":41,"text":"The task management is ready. However integration into discovery and nodes domains is being done in #445.\n\nPriority management is static, we won't bother with dynamic priority in URL before we see it be a problem.\n\nIssue description here is still relevant to #445, since it contains notes on how best to refactor the discovery system.","author_login":"CMCDragonkai","author_association":"MEMBER","created_at":"2022-09-13T09:08:26+08:00","repo_name":"MatrixAI/Polykey","issue_id":1128062883,"issue_number":329,"issue_url":"https://github.com/MatrixAI/Polykey/issues/329","linked_issue_ids":[1128062883],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0143","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"spire-agent gets OOMKilled after pod restart?","query_context":"* **Version**: up to 1.8.6\n* **Platform**: Linux 6.5.0-26-generic 26~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Mar 12 10:22:43 UTC 2 x86_64 GNU/Linux\n* **Subsystem**: agent\n\nWhen I delete a spire-agent pod in the cluster, it becomes unstable, the container gets `OOMKilled` a couple of times before becoming stable.\n\nThese are the resource settings currently:\n\n Limits:\n cpu: 1\n memory: 570Mi\n Requests:\n cpu: 800m\n memory: 512Mi\n\nThere is only a warning about a container ID that is not found at attestation then the agent exits with reason `OOMKilled`.\n\ntime=\"2024-04-11T13:40:53Z\" level=warning msg=\"Current umask 0022 is too permissive; setting umask 0027\"\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Starting agent with data directory: \"/run/spire/temp\"\"\ntime=\"2024-04-11T13:40:53Z\" level=warning msg=\"Agent is now configured to accept remote network connections for Prometheus stats collection. Please ensure access to this port is tightly controlled\" subsystem_name=telemetry\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Plugin loaded\" external=false plugin_name=k8s_psat plugin_type=NodeAttestor subsystem_name=catalog\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Plugin loaded\" external=false plugin_name=memory plugin_type=KeyManager subsystem_name=catalog\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Plugin loaded\" external=false plugin_name=k8s plugin_type=WorkloadAttestor subsystem_name=catalog\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Bundle loaded\" subsystem_name=attestor trust_domain_id=\"spiffe://infra\"\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"SVID is not found. Starting node attestation\" subsystem_name=attestor trust_domain_id=\"spiffe://infra\"\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Node attestation was successful\" rettestable=true spiffe_id=\"spiffe://infra/spire/agent/k8s_psat/infra-cluster/890be4ad-1618-4379-9bc9-c54bb55223d5\" subsystem_name=attestor trust_domain_id=\"spiffe://infra\"\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Renewing X509-SVID\" entry_id=28908b2f-d02b-4269-8ecf-de78d350bf5d spiffe_id=\"spiffe://infra/ns/infra/pod/nsmgr-72bjt\" subsystem_name=manager\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Renewing X509-SVID\" entry_id=deaeb5c6-ab93-4851-88c5-e13497486f09 spiffe_id=\"spiffe://infra/ns/infra/pod/forwarder-vpp-xgbgq\" subsystem_name=manager\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Renewing X509-SVID\" entry_id=610ecd0f-e2c9-4e38-922d-9e325a3dd6cb spiffe_id=\"spiffe://infra/ns/cndsc3/pod/proxy-vpn1-6vkn4\" subsystem_name=manager\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Renewing X509-SVID\" entry_id=0415f6a1-240c-49b3-8215-7e337bcead79 spiffe_id=\"spiffe://infra/ns/cndsc3/pod/proxy-vpn2-pvb7p\" subsystem_name=manager\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Renewing X509-SVID\" entry_id=0d2837cb-9aa8-4189-b2d7-c3ddeb4ee587 spiffe_id=\"spiffe://infra/ns/cndsc3/pod/stateless-lb-frontend-attr-vpn2-5444c987npdbt\" subsystem_name=manager\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Renewing X509-SVID\" entry_id=cfdb2a8a-e340-4cef-8d3f-8944af4e4758 spiffe_id=\"spiffe://infra/ns/cndsc3/pod/fdr-fdcb9f8f6-tqqcj\" subsystem_name=manager\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Renewing X509-SVID\" entry_id=14d49a0a-2b58-4a7c-a0de-551df85d2fc1 spiffe_id=\"spiffe://infra/ns/infra/pod/registry-k8s-5cc46b8bbf-bk6wc\" subsystem_name=manager\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Starting Workload and SDS APIs\" address=/run/spire/sockets/agent.sock network=unix subsystem_name=endpoints\ntime=\"2024-04-11T13:40:53Z\" level=warning msg=\"Container id not found\" attempt=1 container_id=0c2c4b591c6e68635a6cfff55c91a90244bfb85c2091d0f43874785ff39789a7 external=false plugin_name=k8s plugin_type=WorkloadAttestor pod_uid=1f39d257-6173-4a4e-ac25-3706dd13db63 retry_interval=500ms subsystem_name=catalog\n2024-04-11T13:40:58.743 Agent exit code: 137\n\nAs it can be seen on this graph, the average memory consumption is always below 200Mi but after restart there is a spike that causes the container restart:\nspire-agent-oomkilled\n\nCan you please help to understand if this behavior is normal? Is there any other way than further increasing the memory resource limit to make it stable?","known_context_document_ids":["gh_issue_2243116749"],"reference_answer":"Yes, @Rishikesh01. That is the correct package for the Kubernetes workload attestor code.","answer_document_id":"gh_comment_2111010080","silver_evidence_path":["gh_comment_2087237867","gh_issue_2272424957","gh_comment_2111010080"],"evidence_issue_ids":[2243116749,2272424957],"source_repo_name":"spiffe/spire","source_issue_id":2243116749,"source_issue_number":5067,"source_issue_url":"https://github.com/spiffe/spire/issues/5067","target_repo_name":"spiffe/spire","target_issue_id":2272424957,"target_issue_number":5111,"target_issue_url":"https://github.com/spiffe/spire/issues/5111","reference_anchor_document_id":"gh_comment_2087237867","reference_answer_author":"azdagron","reference_answer_author_association":"MEMBER","quality_score":80.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1111,"target_answer_overlap":0.4286},"issue_created_at":"2024-04-15T09:07:41+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_2243116749","fragment_type":"issue_description","sequence":0,"text":"spire-agent gets OOMKilled after pod restart\n* **Version**: up to 1.8.6\n* **Platform**: Linux 6.5.0-26-generic 26~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Mar 12 10:22:43 UTC 2 x86_64 GNU/Linux\n* **Subsystem**: agent\n\nWhen I delete a spire-agent pod in the cluster, it becomes unstable, the container gets `OOMKilled` a couple of times before becoming stable.\n\nThese are the resource settings currently:\n\n Limits:\n cpu: 1\n memory: 570Mi\n Requests:\n cpu: 800m\n memory: 512Mi\n\nThere is only a warning about a container ID that is not found at attestation then the agent exits with reason `OOMKilled`.\n\ntime=\"2024-04-11T13:40:53Z\" level=warning msg=\"Current umask 0022 is too permissive; setting umask 0027\"\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Starting agent with data directory: \"/run/spire/temp\"\"\ntime=\"2024-04-11T13:40:53Z\" level=warning msg=\"Agent is now configured to accept remote network connections for Prometheus stats collection. Please ensure access to this port is tightly controlled\" subsystem_name=telemetry\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Plugin loaded\" external=false plugin_name=k8s_psat plugin_type=NodeAttestor subsystem_name=catalog\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Plugin loaded\" external=false plugin_name=memory plugin_type=KeyManager subsystem_name=catalog\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Plugin loaded\" external=false plugin_name=k8s plugin_type=WorkloadAttestor subsystem_name=catalog\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Bundle loaded\" subsystem_name=attestor trust_domain_id=\"spiffe://infra\"\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"SVID is not found. Starting node attestation\" subsystem_name=attestor trust_domain_id=\"spiffe://infra\"\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Node attestation was successful\" rettestable=true spiffe_id=\"spiffe://infra/spire/agent/k8s_psat/infra-cluster/890be4ad-1618-4379-9bc9-c54bb55223d5\" subsystem_name=attestor trust_domain_id=\"spiffe://infra\"\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Renewing X509-SVID\" entry_id=28908b2f-d02b-4269-8ecf-de78d350bf5d spiffe_id=\"spiffe://infra/ns/infra/pod/nsmgr-72bjt\" subsystem_name=manager\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Renewing X509-SVID\" entry_id=deaeb5c6-ab93-4851-88c5-e13497486f09 spiffe_id=\"spiffe://infra/ns/infra/pod/forwarder-vpp-xgbgq\" subsystem_name=manager\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Renewing X509-SVID\" entry_id=610ecd0f-e2c9-4e38-922d-9e325a3dd6cb spiffe_id=\"spiffe://infra/ns/cndsc3/pod/proxy-vpn1-6vkn4\" subsystem_name=manager\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Renewing X509-SVID\" entry_id=0415f6a1-240c-49b3-8215-7e337bcead79 spiffe_id=\"spiffe://infra/ns/cndsc3/pod/proxy-vpn2-pvb7p\" subsystem_name=manager\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Renewing X509-SVID\" entry_id=0d2837cb-9aa8-4189-b2d7-c3ddeb4ee587 spiffe_id=\"spiffe://infra/ns/cndsc3/pod/stateless-lb-frontend-attr-vpn2-5444c987npdbt\" subsystem_name=manager\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Renewing X509-SVID\" entry_id=cfdb2a8a-e340-4cef-8d3f-8944af4e4758 spiffe_id=\"spiffe://infra/ns/cndsc3/pod/fdr-fdcb9f8f6-tqqcj\" subsystem_name=manager\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Renewing X509-SVID\" entry_id=14d49a0a-2b58-4a7c-a0de-551df85d2fc1 spiffe_id=\"spiffe://infra/ns/infra/pod/registry-k8s-5cc46b8bbf-bk6wc\" subsystem_name=manager\ntime=\"2024-04-11T13:40:53Z\" level=info msg=\"Starting Workload and SDS APIs\" address=/run/spire/sockets/agent.sock network=unix subsystem_name=endpoints\ntime=\"2024-04-11T13:40:53Z\" level=warning msg=\"Container id not found\" attempt=1 container_id=0c2c4b591c6e68635a6cfff55c91a90244bfb85c2091d0f43874785ff39789a7 external=false plugin_name=k8s plugin_type=WorkloadAttestor pod_uid=1f39d257-6173-4a4e-ac25-3706dd13db63 retry_interval=500ms subsystem_name=catalog\n2024-04-11T13:40:58.743 Agent exit code: 137\n\nAs it can be seen on this graph, the average memory consumption is always below 200Mi but after restart there is a spike that causes the container restart:\nspire-agent-oomkilled\n\nCan you please help to understand if this behavior is normal? Is there any other way than further increasing the memory resource limit to make it stable?","author_login":"szvincze","author_association":"CONTRIBUTOR","created_at":"2024-04-15T09:07:41+08:00","repo_name":"spiffe/spire","issue_id":2243116749,"issue_number":5067,"issue_url":"https://github.com/spiffe/spire/issues/5067","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2065092347","fragment_type":"issue_comment","sequence":1,"text":"I think this could be related to the fix introduced in #4231. The valyala/fastjson library has some pretty poor memory usage characteristics:\n \n\nIf there is a spike to the number of pods running on the kubelet, the pods response might be quite large. On a 64-bit platform, the size of fastjson.Value is 80 bytes. Even if we assume a 500KiB response, that is 40MiB. This is a per-attestation cost (we don't share the kubelet output, yet).\n\nFurther, fastjson has an outstanding bug that causes memory to be held onto a little longer, meaning that if you are undergoing many attestations at once, the GC might not be able to release memory fast enough. There is a PR open but fastjson may not be actively maintained ( URL Hard to know if/when this PR would land.\n\nWe've considered moving to another, more frequently maintained library...","author_login":"azdagron","author_association":"MEMBER","created_at":"2024-04-18T19:37:54+08:00","repo_name":"spiffe/spire","issue_id":2243116749,"issue_number":5067,"issue_url":"https://github.com/spiffe/spire/issues/5067","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2072776056","fragment_type":"issue_comment","sequence":2,"text":"We found that even if Spire v1.8.7 is much better than the older releases spire-agent got OOMKilled after a while. So, the spike is still there. Thus, I made a patched version with the parser from valyala/fastjson#101 and tested it. It seems to be working without issues. So, unfortunately it is not enough to upgrade to Spire v1.8.7 or later release.","author_login":"szvincze","author_association":"CONTRIBUTOR","created_at":"2024-04-23T15:45:59+08:00","repo_name":"spiffe/spire","issue_id":2243116749,"issue_number":5067,"issue_url":"https://github.com/spiffe/spire/issues/5067","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2072829983","fragment_type":"issue_comment","sequence":3,"text":"That's what I suspected. Unfortunately, fastjson seems to no longer be actively maintained. It's probably to the benefit of the project to move to a different json parsing library that is actively maintained.","author_login":"azdagron","author_association":"MEMBER","created_at":"2024-04-23T16:07:07+08:00","repo_name":"spiffe/spire","issue_id":2243116749,"issue_number":5067,"issue_url":"https://github.com/spiffe/spire/issues/5067","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2087237867","fragment_type":"issue_comment","sequence":4,"text":"I've opened #5109 and #5111 to track potential mitigations. I believe #5109 should be done no matter what, considering valyala/json is not actively maintained. If that isn't enough, we could consider #5111, though it is more complicated.","author_login":"azdagron","author_association":"MEMBER","created_at":"2024-04-30T20:50:08+08:00","repo_name":"spiffe/spire","issue_id":2243116749,"issue_number":5067,"issue_url":"https://github.com/spiffe/spire/issues/5067","linked_issue_ids":[2272424957],"is_known_query_context":false},{"document_id":"gh_issue_2272424957","fragment_type":"issue_description","sequence":0,"text":"Consider caching the Kubelet response\nThe Kubernetes Workload Attestor queries the Kubelet for pod information on each attestation attempt. Kubelet responses can be somewhat large (e.g. 1MiB). When many processes are concurrently under attestation, the large response can cause a spike in SPIRE agent memory usage.\n\nThis issue is to explore if and how we cache the kubelet response to share across attestation attempts.\n\nSome considerations:\n1. How long is this cached for?\n2. What events would actively invalidate the cache ahead of expiration? (e.g. expected pod/container not found in response)\n3. Each attestation invocation is looking for a different pod/container. Do we cache just the kubelet response and then use targeted parsing of the response to cherry-pick the specific pod/container (what we do today)? Or do we parse the whole response and then share the parsed version (maybe reduces load due to re-parsing)?\n\nAny decisions about the considerations above should ideally be backed by benchmarking to understand the tradeoffs.","author_login":"azdagron","author_association":"MEMBER","created_at":"2024-04-30T20:48:01+08:00","repo_name":"spiffe/spire","issue_id":2272424957,"issue_number":5111,"issue_url":"https://github.com/spiffe/spire/issues/5111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2098946080","fragment_type":"issue_comment","sequence":1,"text":"Hi @azdagron I am interested in helping out here. I am looking around to find code base where this caching needs to be done and I have found this `/pkg/agent/plugin/workloadattestor/k8s` package I hope this is where I should start looking.\n\nAlso about caching part you plan it to be in-memory thing ?","author_login":"Rishikesh01","author_association":"NONE","created_at":"2024-05-07T17:22:15+08:00","repo_name":"spiffe/spire","issue_id":2272424957,"issue_number":5111,"issue_url":"https://github.com/spiffe/spire/issues/5111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2111010080","fragment_type":"issue_comment","sequence":2,"text":"Yes, @Rishikesh01. That is the correct package for the Kubernetes workload attestor code.","author_login":"azdagron","author_association":"MEMBER","created_at":"2024-05-14T19:39:50+08:00","repo_name":"spiffe/spire","issue_id":2272424957,"issue_number":5111,"issue_url":"https://github.com/spiffe/spire/issues/5111","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0145","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Sokol-shdc segfaults with glsl:100 because of variable shadowing?","query_context":"The shader:\n\nglsl\n@module threedee\n\n@vs vs\nin vec3 pos_in;\nin vec2 uv_in;\n\nout vec3 pos;\nout vec2 uv;\nout vec4 light_space_fragment_position;\n\nuniform vs_params {\n mat4 model;\n mat4 view;\n mat4 projection;\n mat4 directional_light_space_matrix; \n};\n\nvoid main() {\n pos = pos_in;\n uv = uv_in;\n\n vec4 frag_pos = view * model * vec4(pos_in, 1.0);\n gl_Position = projection * frag_pos;\n\n light_space_fragment_position = directional_light_space_matrix * frag_pos;\n}\n@end\n\n@fs fs\nuniform sampler2D tex;\nuniform sampler2D shadow_map;\n\nin vec3 pos;\nin vec2 uv;\nin vec4 light_space_fragment_position;\n\nout vec4 frag_color;\n\nfloat decodeDepth(vec4 rgba) {\n return dot(rgba, vec4(1.0, 1.0/255.0, 1.0/65025.0, 1.0/16581375.0));\n}\n\nfloat calculate_shadow_factor(sampler2D shadowMap, vec4 light_space_fragment_position) {\n float shadow = 1.0;\n\n vec3 projected_coords = light_space_fragment_position.xyz / light_space_fragment_position.w;\n\n if(projected_coords.z > 1.0)\n return shadow;\n\n projected_coords = projected_coords * 0.5f + 0.5f;\n\n float current_depth = projected_coords.z;\n\n vec2 shadow_map_size = textureSize(shadow_map, 0);\n vec2 uv = projected_coords.xy * shadow_map_size;\n\n shadow = decodeDepth(texture(shadowMap, uv));\n\n return shadow;\n}\n\nvoid main() {\n vec4 col = texture(tex, uv);\n if(col.a < 0.5)\n {\n discard;\n }\n else\n {\n vec3 light_dir = normalize(vec3(1, -1, 0));\n\n float shadow_factor = 1.0;//In percentage of light remaining, i.e. 1.0 full-bright, 0.0 fully shadowed\n shadow_factor = calculate_shadow_factor(shadow_map, light_space_fragment_position);\n\n frag_color = vec4(col.rgb*shadow_factor, 1.0);\n }\n}\n@end\n\n@program program vs fs","known_context_document_ids":["gh_issue_1787072909"],"reference_answer":"I just implemented a fix to communicate the SPIRVCross error message instead of just crashing in branch `storage-buffer`. In case of your example shader the error message isn't very helpful, but better than nothing I guess:\n\n/Users/floh/projects/sokol-tools/test/issue_86.glsl:0:0: error: SPIRVCross exception: Access chains that result in an array can not be flattened\n\nUnfortunately I don't get line information back from SPIRVCross, only an error message. Closing this ticket (even though the fix isn't in the master branch yet).","answer_document_id":"gh_comment_2037763439","silver_evidence_path":["gh_comment_1620549656","gh_issue_1664663651","gh_comment_2037763439"],"evidence_issue_ids":[1787072909,1664663651],"source_repo_name":"floooh/sokol-tools","source_issue_id":1787072909,"source_issue_number":95,"source_issue_url":"https://github.com/floooh/sokol-tools/issues/95","target_repo_name":"floooh/sokol-tools","target_issue_id":1664663651,"target_issue_number":86,"target_issue_url":"https://github.com/floooh/sokol-tools/issues/86","reference_anchor_document_id":"gh_comment_1620549656","reference_answer_author":"floooh","reference_answer_author_association":"OWNER","quality_score":86.41,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.3333,"target_answer_overlap":0.0682},"issue_created_at":"2023-07-04T03:19:39+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_1787072909","fragment_type":"issue_description","sequence":0,"text":"Sokol-shdc segfaults with glsl:100 because of variable shadowing\nThe shader:\n\nglsl\n@module threedee\n\n@vs vs\nin vec3 pos_in;\nin vec2 uv_in;\n\nout vec3 pos;\nout vec2 uv;\nout vec4 light_space_fragment_position;\n\nuniform vs_params {\n mat4 model;\n mat4 view;\n mat4 projection;\n mat4 directional_light_space_matrix; \n};\n\nvoid main() {\n pos = pos_in;\n uv = uv_in;\n\n vec4 frag_pos = view * model * vec4(pos_in, 1.0);\n gl_Position = projection * frag_pos;\n\n light_space_fragment_position = directional_light_space_matrix * frag_pos;\n}\n@end\n\n@fs fs\nuniform sampler2D tex;\nuniform sampler2D shadow_map;\n\nin vec3 pos;\nin vec2 uv;\nin vec4 light_space_fragment_position;\n\nout vec4 frag_color;\n\nfloat decodeDepth(vec4 rgba) {\n return dot(rgba, vec4(1.0, 1.0/255.0, 1.0/65025.0, 1.0/16581375.0));\n}\n\nfloat calculate_shadow_factor(sampler2D shadowMap, vec4 light_space_fragment_position) {\n float shadow = 1.0;\n\n vec3 projected_coords = light_space_fragment_position.xyz / light_space_fragment_position.w;\n\n if(projected_coords.z > 1.0)\n return shadow;\n\n projected_coords = projected_coords * 0.5f + 0.5f;\n\n float current_depth = projected_coords.z;\n\n vec2 shadow_map_size = textureSize(shadow_map, 0);\n vec2 uv = projected_coords.xy * shadow_map_size;\n\n shadow = decodeDepth(texture(shadowMap, uv));\n\n return shadow;\n}\n\nvoid main() {\n vec4 col = texture(tex, uv);\n if(col.a < 0.5)\n {\n discard;\n }\n else\n {\n vec3 light_dir = normalize(vec3(1, -1, 0));\n\n float shadow_factor = 1.0;//In percentage of light remaining, i.e. 1.0 full-bright, 0.0 fully shadowed\n shadow_factor = calculate_shadow_factor(shadow_map, light_space_fragment_position);\n\n frag_color = vec4(col.rgb*shadow_factor, 1.0);\n }\n}\n@end\n\n@program program vs fs","author_login":"creikey","author_association":"NONE","created_at":"2023-07-04T03:19:39+08:00","repo_name":"floooh/sokol-tools","issue_id":1787072909,"issue_number":95,"issue_url":"https://github.com/floooh/sokol-tools/issues/95","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1619412436","fragment_type":"issue_comment","sequence":1,"text":"The issue is in shadowing the `uv` variable, causing a segfault","author_login":"creikey","author_association":"NONE","created_at":"2023-07-04T03:23:02+08:00","repo_name":"floooh/sokol-tools","issue_id":1787072909,"issue_number":95,"issue_url":"https://github.com/floooh/sokol-tools/issues/95","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1620540601","fragment_type":"issue_comment","sequence":2,"text":"I was running into a similar (but unrelated) thing yesterday. The reason is most likely an internal error reported by SPIRVCross, but the error handling in SPIRVCross in release mode and with C++ exceptions disabled just silently aborts:\n\n URL \n\nTL;DR: I need to find a way to report such internal compiler errors from SPIRVCross - for instance by enabling and then catching exceptions from out of SPIRVCross (at least as first step, the next problem will be that those messages won't be very useful in many cases).","author_login":"floooh","author_association":"OWNER","created_at":"2023-07-04T16:59:45+08:00","repo_name":"floooh/sokol-tools","issue_id":1787072909,"issue_number":95,"issue_url":"https://github.com/floooh/sokol-tools/issues/95","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1620547499","fragment_type":"issue_comment","sequence":3,"text":"PS: wrote a SPIRCross ticket here, but independently from whether that's fixed or not I'll need to find a workaround.\n\n URL","author_login":"floooh","author_association":"OWNER","created_at":"2023-07-04T17:08:09+08:00","repo_name":"floooh/sokol-tools","issue_id":1787072909,"issue_number":95,"issue_url":"https://github.com/floooh/sokol-tools/issues/95","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1620549656","fragment_type":"issue_comment","sequence":4,"text":"PS: this was the problem I was running into, also looked like a \"silent crash\", but was actually a SPIRCross error:\n\n URL \n\n...and this ticket is similar:\n\n URL","author_login":"floooh","author_association":"OWNER","created_at":"2023-07-04T17:11:20+08:00","repo_name":"floooh/sokol-tools","issue_id":1787072909,"issue_number":95,"issue_url":"https://github.com/floooh/sokol-tools/issues/95","linked_issue_ids":[1664663651],"is_known_query_context":false},{"document_id":"gh_comment_2037755684","fragment_type":"issue_comment","sequence":5,"text":"Once branch `storage-buffer` is merged, this type of problems (internal SPIRVCross compiler errors) will produce a proper error message. Interestingly I cannot reproduce the problem anymore with your shader though (I just did some small changes for the new separate texture/sampler stuff). Maybe updating the Khronos dependencies helped. Closing this ticket, even though the fix (better error message) isn't in master yet.","author_login":"floooh","author_association":"OWNER","created_at":"2024-04-04T17:12:39+08:00","repo_name":"floooh/sokol-tools","issue_id":1787072909,"issue_number":95,"issue_url":"https://github.com/floooh/sokol-tools/issues/95","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1664663651","fragment_type":"issue_description","sequence":0,"text":"sokol-shdc segfaults with --slang glsl330:hlsl5\nsokol-shdc crashes for me with the following invocations:\n\nsokol-shdc.exe --slang glsl330 --format sokol_zig -i src/shaders/texgrid.glsl -o src/shaders/texgrid.glsl.zig\nsokol-shdc.exe --slang glsl330:hlsl5 --format sokol_zig -i src/shaders/texgrid.glsl -o src/shaders/texgrid.glsl.zig\n\nThe contents of texgrid.glsl are as follows:\n\n#pragma sokol @vs vs\nuniform vs_params {\n vec4 mvp[4];\n};\n\nin vec4 position;\nin vec2 texcoord0;\n\nout vec2 uv;\n\nvec4 xform(vec4 mat[4], vec4 v) {\n return vec4(dot(mat[0], position), dot(mat[1], position), dot(mat[2], position), dot(mat[3], position));\n}\n\nvoid main() {\n gl_Position = xform(mvp, position);\n uv = texcoord0;\n}\n#pragma sokol @end\n\n#pragma sokol @fs fs\nuniform sampler2D tex;\n\nin vec2 uv;\nout vec4 frag_color;\n\nvoid main() {\n frag_color = texture(tex, uv);\n}\n#pragma sokol @end\n\n#pragma sokol @program texgrid vs fs\n\nI'm not really setup with a good debugger on this host, but looks like some unhandled exception? ->\n\nStarting program: C:\\Users\\janne\\dev\\workspace\\fips-deploy\\sokol-tools\\win64-vstudio-release\\sokol-shdc.exe --slang glsl330:hlsl5 --format sokol_zig -i src/shaders/texgrid.glsl -o src/shaders/texgrid.glsl.zig\ngdb: unknown target exception 0xc0000409 at 0x7ff665c43b7d\n\nI got the crash on Linux using sokol-tools prebuilt binaries and also on Windows when I built sokol-shdc myself.","author_login":"nurpax","author_association":"NONE","created_at":"2023-04-12T14:17:43+08:00","repo_name":"floooh/sokol-tools","issue_id":1664663651,"issue_number":86,"issue_url":"https://github.com/floooh/sokol-tools/issues/86","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1505817668","fragment_type":"issue_comment","sequence":1,"text":"Here's the stacktrace that I captured in Visual Studio debugger:\n\nsokol-shdc.exe!issue_debug_notification(const wchar_t * const message) Line 28\n at minkernel\\crts\\ucrt\\src\\appcrt\\internal\\report_runtime_error.cpp(28)\nsokol-shdc.exe!__acrt_report_runtime_error(const wchar_t * message) Line 154\n at minkernel\\crts\\ucrt\\src\\appcrt\\internal\\report_runtime_error.cpp(154)\nsokol-shdc.exe!abort() Line 61\n at minkernel\\crts\\ucrt\\src\\appcrt\\startup\\abort.cpp(61)\nsokol-shdc.exe!spirv_cross::report_and_abort(const std::string & msg) Line 58\n at C:\\Users\\janne\\dev\\workspace\\sokol-tools\\ext\\SPIRV-Cross\\spirv_cross_error_handling.hpp(58)\nsokol-shdc.exe!spirv_cross::CompilerGLSL::flattened_access_chain(unsigned int base, const unsigned int * indices, unsigned int count, const spirv_cross::SPIRType & target_type, unsigned int offset, unsigned int matrix_stride, unsigned int __formal, bool need_transpose) Line 9103\n at C:\\Users\\janne\\dev\\workspace\\sokol-tools\\ext\\SPIRV-Cross\\spirv_glsl.cpp(9103)\nsokol-shdc.exe!spirv_cross::CompilerGLSL::access_chain(unsigned int base, const unsigned int * indices, unsigned int count, const spirv_cross::SPIRType & target_type, spirv_cross::AccessChainMeta * meta, bool ptr_chain) Line 8992\n at C:\\Users\\janne\\dev\\workspace\\sokol-tools\\ext\\SPIRV-Cross\\spirv_glsl.cpp(8992)\nsokol-shdc.exe!spirv_cross::CompilerGLSL::emit_instruction(const spirv_cross::Instruction & instruction) Line 10159\n at C:\\Users\\janne\\dev\\workspace\\sokol-tools\\ext\\SPIRV-Cross\\spirv_glsl.cpp(10159)\nsokol-shdc.exe!spirv_cross::CompilerGLSL::emit_block_instructions(spirv_cross::SPIRBlock & block) Line 9860\n at C:\\Users\\janne\\dev\\workspace\\sokol-tools\\ext\\SPIRV-Cross\\spirv_glsl.cpp(9860)\nsokol-shdc.exe!spirv_cross::CompilerGLSL::emit_block_chain(spirv_cross::SPIRBlock & block) Line 14704\n at C:\\Users\\janne\\dev\\workspace\\sokol-tools\\ext\\SPIRV-Cross\\spirv_glsl.cpp(14704)\nsokol-shdc.exe!spirv_cross::CompilerGLSL::emit_function(spirv_cross::SPIRFunction & func, const spirv_cross::Bitset & return_flags) Line 13953\n at C:\\Users\\janne\\dev\\workspace\\sokol-tools\\ext\\SPIRV-Cross\\spirv_glsl.cpp(13953)\nsokol-shdc.exe!spirv_cross::CompilerGLSL::compile() Line 677\n at C:\\Users\\janne\\dev\\workspace\\sokol-tools\\ext\\SPIRV-Cross\\spirv_glsl.cpp(677)\nsokol-shdc.exe!shdc::to_glsl(const shdc::spirv_blob_t & blob, int glsl_version, bool is_gles, bool is_vulkan, unsigned int opt_mask, shdc::snippet_t::type_t type) Line 305\n at C:\\Users\\janne\\dev\\workspace\\sokol-tools\\src\\shdc\\spirvcross.cc(305)\nsokol-shdc.exe!shdc::spirvcross_t::translate(const shdc::input_t & inp, const shdc::spirv_t & spirv, shdc::slang_t::type_t slang) Line 470\n at C:\\Users\\janne\\dev\\workspace\\sokol-tools\\src\\shdc\\spirvcross.cc(470)\nsokol-shdc.exe!main(int argc, const char * * argv) Line 61\n at C:\\Users\\janne\\dev\\workspace\\sokol-tools\\src\\shdc\\main.cc(61)\n[External Code]","author_login":"nurpax","author_association":"NONE","created_at":"2023-04-12T19:34:29+08:00","repo_name":"floooh/sokol-tools","issue_id":1664663651,"issue_number":86,"issue_url":"https://github.com/floooh/sokol-tools/issues/86","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1505823965","fragment_type":"issue_comment","sequence":2,"text":"Perhaps it'd be fixed by upgrading some of the SPIR-V repos?","author_login":"nurpax","author_association":"NONE","created_at":"2023-04-12T19:40:04+08:00","repo_name":"floooh/sokol-tools","issue_id":1664663651,"issue_number":86,"issue_url":"https://github.com/floooh/sokol-tools/issues/86","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1507199332","fragment_type":"issue_comment","sequence":3,"text":"It's a bit surprising that SPIRVCross is throwing exceptions instead of a more traditional error reporting, I haven't seen that yet.\n\nIt's also strange that such a simple shader generates an error tbh... \n\nI'll try to have a quick look, but may need a couple of days before I can do a proper investigation and fix.","author_login":"floooh","author_association":"OWNER","created_at":"2023-04-13T15:46:46+08:00","repo_name":"floooh/sokol-tools","issue_id":1664663651,"issue_number":86,"issue_url":"https://github.com/floooh/sokol-tools/issues/86","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1507201893","fragment_type":"issue_comment","sequence":4,"text":"...I vaguely seem to remember problems with array function args though...","author_login":"floooh","author_association":"OWNER","created_at":"2023-04-13T15:48:45+08:00","repo_name":"floooh/sokol-tools","issue_id":1664663651,"issue_number":86,"issue_url":"https://github.com/floooh/sokol-tools/issues/86","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1507214830","fragment_type":"issue_comment","sequence":5,"text":"Yeah, I remembered right. As a quick workaround, you need to rewrite the xform() function to not take an array arg, e.g.:\n\nglsl\nvec4 xform(vec4 mx, vec4 my, vec4 mz, vec4 mw, vec4 v) {\n return vec4(dot(mx, position), dot(my, position), dot(mz, position), dot(mw, position));\n}\n\n...and call it like this:\n\nglsl\ngl_Position = xform(mvp[0], mvp[1], mvp[2], mvp[3], position);\n\n...doesn't help with the underlying problem of course, but hopefully unblocks you for now.\n\nThe error kinda makes sense unfortunately (I think I even reported this already to SPIRVCross, need to find the ticket though).\n\nThe GL backend flattens each uniform block into a vec4 array, but since GLSL has no array slices, it cannot access a range within this array for the function parameter (it could create a temporary array though, but I guess that's too much complexity for SPIRVCross for such an 'esoteric' feature).\n\nI'll still try to set aside a bit of time 'soon-ish' to investigate the problem, maybe there's at least a way to make the error less painful (e.g. not crashing, and reporting a more helpful error message).","author_login":"floooh","author_association":"OWNER","created_at":"2023-04-13T15:58:00+08:00","repo_name":"floooh/sokol-tools","issue_id":1664663651,"issue_number":86,"issue_url":"https://github.com/floooh/sokol-tools/issues/86","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1507220764","fragment_type":"issue_comment","sequence":6,"text":"PS: alternatively this also works, keep the xform() function as it is, but create a temporary array at the call site:\n\nglsl\n vec4 mat[4] = { mvp[0], mvp[1], mvp[2], mvp[3] };\n gl_Position = xform(mat, position)","author_login":"floooh","author_association":"OWNER","created_at":"2023-04-13T16:01:55+08:00","repo_name":"floooh/sokol-tools","issue_id":1664663651,"issue_number":86,"issue_url":"https://github.com/floooh/sokol-tools/issues/86","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1507344973","fragment_type":"issue_comment","sequence":7,"text":"Thanks for the help! I'll workaround it like above.. I'm mainly using HLSL5 where this was not a problem, just noticed this while I tried to run my code on Linux and OpenGL.\n\nIt's probably fine to have a catch all exception handler somewhere in your CLI, then report the exception text and exit. Right now shdc crashes and it's kind of hard to know what happened.\n\nFunny how my quest to go full row major snowballed into even problems like this.. :D","author_login":"nurpax","author_association":"NONE","created_at":"2023-04-13T17:26:02+08:00","repo_name":"floooh/sokol-tools","issue_id":1664663651,"issue_number":86,"issue_url":"https://github.com/floooh/sokol-tools/issues/86","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1509042107","fragment_type":"issue_comment","sequence":8,"text":"FWIW you also get a segfault when using uint and glsl100 (which doesn't support uint, as expected.) Something a skosh more user friendly than a segfault might be an ergonomic improvement.\n\nIMHO, because SPIRV-Cross seems to SPIRV_CROSS_THROW sort of zealously for error reporting, it might be worth it to just wire `report_and_abort` up to _always_ print the error message. I'm having trouble thinking of a scenario where a user would want sokol-shdc to abort, but not print the underlying error message.","author_login":"nmr8acme","author_association":"CONTRIBUTOR","created_at":"2023-04-14T18:10:31+08:00","repo_name":"floooh/sokol-tools","issue_id":1664663651,"issue_number":86,"issue_url":"https://github.com/floooh/sokol-tools/issues/86","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2037763439","fragment_type":"issue_comment","sequence":9,"text":"I just implemented a fix to communicate the SPIRVCross error message instead of just crashing in branch `storage-buffer`. In case of your example shader the error message isn't very helpful, but better than nothing I guess:\n\n/Users/floh/projects/sokol-tools/test/issue_86.glsl:0:0: error: SPIRVCross exception: Access chains that result in an array can not be flattened\n\nUnfortunately I don't get line information back from SPIRVCross, only an error message. Closing this ticket (even though the fix isn't in the master branch yet).","author_login":"floooh","author_association":"OWNER","created_at":"2024-04-04T17:16:09+08:00","repo_name":"floooh/sokol-tools","issue_id":1664663651,"issue_number":86,"issue_url":"https://github.com/floooh/sokol-tools/issues/86","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0147","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"[iOS] \"Original error: Command '/usr/bin/python' not found\" appear when use setLocation of a iOS Emulator on MAC Apple Silicon (M1)?","query_context":"## The problem\n\nWhen I call setLocation function appium return error \"Original error: Command '/usr/bin/python' not found\" and break test.\n<img width=\"820\" alt=\"Screen Shot 2022-08-08 at 23 10 18\" src=\" URL \n\n## Environment\n\n* Appium version (or git revision) that exhibits the issue: **Appium 1.22.3**\n* Last Appium version that did not exhibit the issue (if applicable): **N/A**\n* Desktop OS/version used to run Appium: **macOS Monterey 12.5 - M1Pro**\n* Node.js version (unless using Appium.app|exe): **v18.7.0**\n* Npm or Yarn package manager: **npm**\n* Mobile platform/version under test: iOS 15.5\n* Real device or emulator/simulator: XCode Emulator\n* Appium CLI or Appium.app|exe: Appium.app\n\n## Details\nThe error appear when I hit command: \n`driver.setLocation(new Location(0,0,0));`\n\n## Link to Appium logs\nGist\n\n## Code To Reproduce Issue [ Good To Have ]\n`driver.setLocation(new Location(0,0,0));`","known_context_document_ids":["gh_issue_1332101175"],"reference_answer":"Newer versions are available via appium 2. You can get it via npm as `appium@next`.","answer_document_id":"gh_comment_1145633607","silver_evidence_path":["gh_comment_1208354224","gh_issue_1258187940","gh_comment_1145633607"],"evidence_issue_ids":[1332101175,1258187940],"source_repo_name":"appium/appium","source_issue_id":1332101175,"source_issue_number":17334,"source_issue_url":"https://github.com/appium/appium/issues/17334","target_repo_name":"appium/appium","target_issue_id":1258187940,"target_issue_number":17031,"target_issue_url":"https://github.com/appium/appium/issues/17031","reference_anchor_document_id":"gh_comment_1208354224","reference_answer_author":"KazuCocoa","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.25,"anchor_target_overlap":0.25,"target_answer_overlap":0.2857},"issue_created_at":"2022-08-08T16:20:08+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_1332101175","fragment_type":"issue_description","sequence":0,"text":"[iOS] \"Original error: Command '/usr/bin/python' not found\" appear when use setLocation of a iOS Emulator on MAC Apple Silicon (M1)\n## The problem\n\nWhen I call setLocation function appium return error \"Original error: Command '/usr/bin/python' not found\" and break test.\n<img width=\"820\" alt=\"Screen Shot 2022-08-08 at 23 10 18\" src=\" URL \n\n## Environment\n\n* Appium version (or git revision) that exhibits the issue: **Appium 1.22.3**\n* Last Appium version that did not exhibit the issue (if applicable): **N/A**\n* Desktop OS/version used to run Appium: **macOS Monterey 12.5 - M1Pro**\n* Node.js version (unless using Appium.app|exe): **v18.7.0**\n* Npm or Yarn package manager: **npm**\n* Mobile platform/version under test: iOS 15.5\n* Real device or emulator/simulator: XCode Emulator\n* Appium CLI or Appium.app|exe: Appium.app\n\n## Details\nThe error appear when I hit command: \n`driver.setLocation(new Location(0,0,0));`\n\n## Link to Appium logs\nGist\n\n## Code To Reproduce Issue [ Good To Have ]\n`driver.setLocation(new Location(0,0,0));`","author_login":"peterlight90","author_association":"NONE","created_at":"2022-08-08T16:20:08+08:00","repo_name":"appium/appium","issue_id":1332101175,"issue_number":17334,"issue_url":"https://github.com/appium/appium/issues/17334","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1208354224","fragment_type":"issue_comment","sequence":1,"text":"Perhaps duplicate of URL Please try out latest xcuitest-driver with Appium 2.","author_login":"KazuCocoa","author_association":"MEMBER","created_at":"2022-08-08T16:38:20+08:00","repo_name":"appium/appium","issue_id":1332101175,"issue_number":17334,"issue_url":"https://github.com/appium/appium/issues/17334","linked_issue_ids":[1258187940],"is_known_query_context":false},{"document_id":"gh_comment_1208568468","fragment_type":"issue_comment","sequence":2,"text":"The issue has been fixed. Please use the recent driver release (only available as part of Appium2)","author_login":"mykola-mokhnach","author_association":"COLLABORATOR","created_at":"2022-08-08T20:18:10+08:00","repo_name":"appium/appium","issue_id":1332101175,"issue_number":17334,"issue_url":"https://github.com/appium/appium/issues/17334","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1258187940","fragment_type":"issue_description","sequence":0,"text":"Appium stop working with iOS on MacOS 12.3\n## The problem\n\nSince Mac OS 12.3 python 2 by path usr/bin/python was replaced by Python 3 with path usr/bin/python3\nDirectory usr/bin/python doesn't exist anymore and can't be created as a protected system directory.\n\nWhen trying to run any test on a real iOS device or iOS Simulator I get an error:\n\"org.openqa.selenium.WebDriverException: An unknown server-side error occurred while processing the command. Original error: Command '/usr/bin/python' not found. Is it installed?\"\n\nAny installation of Python2 and adding it to any System path didn't fix a problem.\n\nLooks like WebDriver is looking for usr/bin/python directory only ignoring any System variables and installed python2\n\nIssue reproduced on any call of embedded selenium-remote-driver (3.141.59)\nFor example: getDriver().setLocation(53.3453, -1.4532, 0);\n\n## Environment\n\n* Appium version (or git revision) that exhibits the issue: GUI appium version 1.22.3-4 + server 1.22.2 and appium console server 1.22.0\n* Last Appium version that did not exhibit the issue (if applicable): no one\n* Driver version that exhibits the issue (only for Appium2): all (Mac OS version depends)\n* Last driver version that did not exhibit the issue (if applicable, only for Appium2): no one\n* Desktop OS/version used to run Appium: Mac OS 12.3 (Doesn't reproduce on Mac OS 12.2 and older)\n* Node.js version (unless using Appium.app|exe):\n* Package manager name and version (we only officially support NPM):\n* Mobile platform/version under test: iOS any version\n* Real device or emulator/simulator: real device and simulator\n* Appium CLI or Appium.app|exe: io.appium java-client 8.1.0\n* Java 8\n\n## Details\n\nIf necessary, describe the problem you have been experiencing in more detail.\n\n## Link to Appium logs\nIntelij IDEA log\n URL \n\nAppium console server log\n URL","author_login":"Biloleg","author_association":"NONE","created_at":"2022-06-02T13:27:53+08:00","repo_name":"appium/appium","issue_id":1258187940,"issue_number":17031,"issue_url":"https://github.com/appium/appium/issues/17031","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1145582840","fragment_type":"issue_comment","sequence":1,"text":"Do I need to update Appium library for that ? as i am facing exact issue in mac while setting location \ngetDriver().setLocation()","author_login":"amar1989","author_association":"NONE","created_at":"2022-06-03T04:53:00+08:00","repo_name":"appium/appium","issue_id":1258187940,"issue_number":17031,"issue_url":"https://github.com/appium/appium/issues/17031","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1145617127","fragment_type":"issue_comment","sequence":2,"text":"I updated appium using `npm install appium -g` but still getting same error , I think appium did not get updated.","author_login":"amar1989","author_association":"NONE","created_at":"2022-06-03T06:06:08+08:00","repo_name":"appium/appium","issue_id":1258187940,"issue_number":17031,"issue_url":"https://github.com/appium/appium/issues/17031","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1145633607","fragment_type":"issue_comment","sequence":3,"text":"Newer versions are available via appium 2. You can get it via npm as `appium@next`.","author_login":"KazuCocoa","author_association":"MEMBER","created_at":"2022-06-03T06:33:31+08:00","repo_name":"appium/appium","issue_id":1258187940,"issue_number":17031,"issue_url":"https://github.com/appium/appium/issues/17031","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1145680966","fragment_type":"issue_comment","sequence":4,"text":"Thanks a lot for quick response !! Updated but seems lot of change is required for appium 2.0, had to revert that for now. Any other workaround plz for version 1.22.3?","author_login":"amar1989","author_association":"NONE","created_at":"2022-06-03T07:37:51+08:00","repo_name":"appium/appium","issue_id":1258187940,"issue_number":17031,"issue_url":"https://github.com/appium/appium/issues/17031","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1145738512","fragment_type":"issue_comment","sequence":5,"text":"No, it is impossible to resolve. Also setLocation() it is just an example but not only one method which crashing run by python path error","author_login":"Biloleg","author_association":"NONE","created_at":"2022-06-03T08:43:27+08:00","repo_name":"appium/appium","issue_id":1258187940,"issue_number":17031,"issue_url":"https://github.com/appium/appium/issues/17031","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1145745679","fragment_type":"issue_comment","sequence":6,"text":"Unfortunately we don't provide patches for older Appium versions. Closed as fixed","author_login":"mykola-mokhnach","author_association":"COLLABORATOR","created_at":"2022-06-03T08:51:34+08:00","repo_name":"appium/appium","issue_id":1258187940,"issue_number":17031,"issue_url":"https://github.com/appium/appium/issues/17031","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1145881496","fragment_type":"issue_comment","sequence":7,"text":"Currently the most recent xcuitest driver version is 4.4.5. It is only available as part of Appium2. Appium1 is is legacy and not maintained anymore","author_login":"mykola-mokhnach","author_association":"COLLABORATOR","created_at":"2022-06-03T11:46:38+08:00","repo_name":"appium/appium","issue_id":1258187940,"issue_number":17031,"issue_url":"https://github.com/appium/appium/issues/17031","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1219283816","fragment_type":"issue_comment","sequence":8,"text":"@KazuCocoa When I try set location on Appium2 this issue appear, do you have any advice?\n \nScreen Shot 2022-08-18 at 16 47 13","author_login":"peterlight90","author_association":"NONE","created_at":"2022-08-18T09:48:56+08:00","repo_name":"appium/appium","issue_id":1258187940,"issue_number":17031,"issue_url":"https://github.com/appium/appium/issues/17031","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1219364793","fragment_type":"issue_comment","sequence":9,"text":"It looks like Apple has excluded pyobjc from the standard python deployment\nWe need to avoid python usage in general for such scenarios","author_login":"mykola-mokhnach","author_association":"COLLABORATOR","created_at":"2022-08-18T11:11:44+08:00","repo_name":"appium/appium","issue_id":1258187940,"issue_number":17031,"issue_url":"https://github.com/appium/appium/issues/17031","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1221551160","fragment_type":"issue_comment","sequence":10,"text":"Thank you @mykola-mokhnach setLocation function is working well on MacOS latest version (12.5.1)","author_login":"peterlight90","author_association":"NONE","created_at":"2022-08-21T13:54:44+08:00","repo_name":"appium/appium","issue_id":1258187940,"issue_number":17031,"issue_url":"https://github.com/appium/appium/issues/17031","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0150","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Compressed, chunked response inhibits connection reuse?","query_context":"rust\nenv_logger::init();\nlet agent: Agent = ureq::AgentBuilder::new().build();\nfor _ in 0..2 {\n let resp = agent.get(\" URL \n println!(\"Connection: {}\", resp.header(\"connection\").unwrap());\n std::io::copy(&mut resp.into_reader(), &mut io::sink()).unwrap();\n}\n\nresults in (RUST_LOG=trace)\n\n[2022-10-17T01:02:37Z DEBUG ureq::stream] connecting to www.jammersreviews.com:443 at 172.67.140.111:443\n[2022-10-17T01:02:37Z DEBUG rustls::client::hs] No cached session for DnsName(DnsName(DnsName(\"www.jammersreviews.com\")))\n[...]\n[2022-10-17T01:02:37Z DEBUG ureq::stream] created stream: Stream(RustlsStream)\n[2022-10-17T01:02:37Z DEBUG ureq::unit] sending request GET URL \n[2022-10-17T01:02:37Z DEBUG ureq::unit] writing prelude: GET /st-tos/s1/dagger.php HTTP/1.1\n Host: www.jammersreviews.com\n User-Agent: ureq/2.5.0\n Accept: */*\n accept-encoding: gzip\n[2022-10-17T01:02:37Z DEBUG rustls::client::tls13] Ticket saved\n[2022-10-17T01:02:37Z DEBUG rustls::client::tls13] Ticket saved\n[2022-10-17T01:02:37Z DEBUG ureq::response] Chunked body in response\n[2022-10-17T01:02:37Z DEBUG ureq::unit] response 200 to GET URL \nConnection: keep-alive\n[2022-10-17T01:02:37Z DEBUG ureq::stream] dropping stream: Stream(RustlsStream)\n[2022-10-17T01:02:37Z DEBUG ureq::stream] connecting to www.jammersreviews.com:443 at 172.67.140.111:443\n[2022-10-17T01:02:37Z DEBUG rustls::client::hs] Resuming session\n[...]\n[2022-10-17T01:02:37Z DEBUG ureq::stream] created stream: Stream(RustlsStream)\n[2022-10-17T01:02:37Z DEBUG ureq::unit] sending request GET URL \n[2022-10-17T01:02:37Z DEBUG ureq::unit] writing prelude: GET /st-tos/s1/dagger.php HTTP/1.1\n Host: www.jammersreviews.com\n User-Agent: ureq/2.5.0\n Accept: */*\n accept-encoding: gzip\n[2022-10-17T01:02:37Z DEBUG rustls::client::tls13] Ticket saved\n[2022-10-17T01:02:37Z DEBUG rustls::client::tls13] Ticket saved\n[2022-10-17T01:02:37Z DEBUG ureq::response] Chunked body in response\n[2022-10-17T01:02:37Z DEBUG ureq::unit] response 200 to GET URL \nConnection: keep-alive\n[2022-10-17T01:02:37Z DEBUG ureq::stream] dropping stream: Stream(RustlsStream)\n\nAs can be seen, though TLS does session resumption, the TCP stream gets closed and reopened between requests. I believe this is caused by the fact that the `GzDecoder` knows when to expect the end of the gzip stream, never tries to read beyond it, and therefore never makes the read that causes the `ChunkDecoder` to give it Ok(0), which is what the `PoolReturnRead` looks for to know when to return the `Stream` to its pool. I was able to get it to work properly by using a `MultiGzDecoder` instead of a plain `GzDecoder`, at least in my private, heavily-modified version of ureq. But I don't think any such thing is available for Brotli.","known_context_document_ids":["gh_issue_1410754066"],"reference_answer":"When we return the Stream to the pool, we can check that the `inner` `BufReader`'s buffer is empty.","answer_document_id":"gh_comment_1328015846","silver_evidence_path":["gh_comment_1340380401","gh_issue_1465065439","gh_comment_1328015846"],"evidence_issue_ids":[1410754066,1465065439],"source_repo_name":"algesten/ureq","source_issue_id":1410754066,"source_issue_number":549,"source_issue_url":"https://github.com/algesten/ureq/issues/549","target_repo_name":"algesten/ureq","target_issue_id":1465065439,"target_issue_number":559,"target_issue_url":"https://github.com/algesten/ureq/issues/559","reference_anchor_document_id":"gh_comment_1340380401","reference_answer_author":"jsha","reference_answer_author_association":"COLLABORATOR","quality_score":85.67,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2,"anchor_target_overlap":0.0667,"target_answer_overlap":0.5},"issue_created_at":"2022-10-17T01:55:25+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_1410754066","fragment_type":"issue_description","sequence":0,"text":"Compressed, chunked response inhibits connection reuse\nrust\nenv_logger::init();\nlet agent: Agent = ureq::AgentBuilder::new().build();\nfor _ in 0..2 {\n let resp = agent.get(\" URL \n println!(\"Connection: {}\", resp.header(\"connection\").unwrap());\n std::io::copy(&mut resp.into_reader(), &mut io::sink()).unwrap();\n}\n\nresults in (RUST_LOG=trace)\n\n[2022-10-17T01:02:37Z DEBUG ureq::stream] connecting to www.jammersreviews.com:443 at 172.67.140.111:443\n[2022-10-17T01:02:37Z DEBUG rustls::client::hs] No cached session for DnsName(DnsName(DnsName(\"www.jammersreviews.com\")))\n[...]\n[2022-10-17T01:02:37Z DEBUG ureq::stream] created stream: Stream(RustlsStream)\n[2022-10-17T01:02:37Z DEBUG ureq::unit] sending request GET URL \n[2022-10-17T01:02:37Z DEBUG ureq::unit] writing prelude: GET /st-tos/s1/dagger.php HTTP/1.1\n Host: www.jammersreviews.com\n User-Agent: ureq/2.5.0\n Accept: */*\n accept-encoding: gzip\n[2022-10-17T01:02:37Z DEBUG rustls::client::tls13] Ticket saved\n[2022-10-17T01:02:37Z DEBUG rustls::client::tls13] Ticket saved\n[2022-10-17T01:02:37Z DEBUG ureq::response] Chunked body in response\n[2022-10-17T01:02:37Z DEBUG ureq::unit] response 200 to GET URL \nConnection: keep-alive\n[2022-10-17T01:02:37Z DEBUG ureq::stream] dropping stream: Stream(RustlsStream)\n[2022-10-17T01:02:37Z DEBUG ureq::stream] connecting to www.jammersreviews.com:443 at 172.67.140.111:443\n[2022-10-17T01:02:37Z DEBUG rustls::client::hs] Resuming session\n[...]\n[2022-10-17T01:02:37Z DEBUG ureq::stream] created stream: Stream(RustlsStream)\n[2022-10-17T01:02:37Z DEBUG ureq::unit] sending request GET URL \n[2022-10-17T01:02:37Z DEBUG ureq::unit] writing prelude: GET /st-tos/s1/dagger.php HTTP/1.1\n Host: www.jammersreviews.com\n User-Agent: ureq/2.5.0\n Accept: */*\n accept-encoding: gzip\n[2022-10-17T01:02:37Z DEBUG rustls::client::tls13] Ticket saved\n[2022-10-17T01:02:37Z DEBUG rustls::client::tls13] Ticket saved\n[2022-10-17T01:02:37Z DEBUG ureq::response] Chunked body in response\n[2022-10-17T01:02:37Z DEBUG ureq::unit] response 200 to GET URL \nConnection: keep-alive\n[2022-10-17T01:02:37Z DEBUG ureq::stream] dropping stream: Stream(RustlsStream)\n\nAs can be seen, though TLS does session resumption, the TCP stream gets closed and reopened between requests. I believe this is caused by the fact that the `GzDecoder` knows when to expect the end of the gzip stream, never tries to read beyond it, and therefore never makes the read that causes the `ChunkDecoder` to give it Ok(0), which is what the `PoolReturnRead` looks for to know when to return the `Stream` to its pool. I was able to get it to work properly by using a `MultiGzDecoder` instead of a plain `GzDecoder`, at least in my private, heavily-modified version of ureq. But I don't think any such thing is available for Brotli.","author_login":"OrIdow6","author_association":"NONE","created_at":"2022-10-17T01:55:25+08:00","repo_name":"algesten/ureq","issue_id":1410754066,"issue_number":549,"issue_url":"https://github.com/algesten/ureq/issues/549","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1282966458","fragment_type":"issue_comment","sequence":1,"text":"@OrIdow6 Thanks for reporting this! I've written a test case in #550 illustrating the problem. I don't have a solution yet, but it probably means the `Compression` wrapping of the `PoolReturnRead` needs to inform when it reaches the end.","author_login":"algesten","author_association":"OWNER","created_at":"2022-10-18T20:29:19+08:00","repo_name":"algesten/ureq","issue_id":1410754066,"issue_number":549,"issue_url":"https://github.com/algesten/ureq/issues/549","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1283371843","fragment_type":"issue_comment","sequence":2,"text":"@OrIdow6 also thanks for taking the time to write such a detailed report. I suspect the MultiGzDecoder only coincidentally fixes this because it will try additional reads after the first gzip stream is done.\n\nIn terms of how to fix this: the main problem is that the chunked encoding may have a few more bytes that it hasn't read. Specifically the `0\\r\\n\\r\\n` that terminates the response. It's not enough for the `GzDecoder` to say its done; if there are any unread bytes left in the response stream, we cant return it to the pool.\n\nWe also don't want to do any syscall-invoking reads in a `Drop` impl, since that could produce surprising hangs.\n\nProposal: fork chunked_transfer and make it aware of BufRead. When a read is finished, peek at the next 5 bytes in the buffer (if available). If those bytes are `0\\r\\n\\r\\n` consume them and set an internal piece of state saying \"this stream is done.\" Expose that state with a `done()` method that can be forwarded by ureq's internal `Done` trait. Implement `Done` for `chunked_transfer::Decoder`. I think we don't actually need to touch the `Compression` layer at all, since all we care about is \"did we read all the bytes from the chunked encoding yet.\"\n\nNote this approach is not perfect: it's possible we could land right on a chunk boundary, with no bytes left in the buffer, but _if_ we read more from the network, the next bytes we would read would be `0\\r\\n\\r\\n`. In that case we would fail to recognize we were almost at the end, and would therefore fail to pool the connection. That's probably okay.\n\nAnother approach, which would be more perfect: if `chunked_transfer::Decoder` receives a read that ends on a chunk boundary, and there are no more bytes left in the buffer, then it should try to fill the buffer and peek at the next five bytes before returning.","author_login":"jsha","author_association":"COLLABORATOR","created_at":"2022-10-19T03:34:54+08:00","repo_name":"algesten/ureq","issue_id":1410754066,"issue_number":549,"issue_url":"https://github.com/algesten/ureq/issues/549","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1284601951","fragment_type":"issue_comment","sequence":3,"text":"@jsha I pushed a commit URL which potentially fixes the problem without forking anything.\n\nMight be something I haven't thought about, but I think it should be ok.","author_login":"algesten","author_association":"OWNER","created_at":"2022-10-19T21:39:07+08:00","repo_name":"algesten/ureq","issue_id":1410754066,"issue_number":549,"issue_url":"https://github.com/algesten/ureq/issues/549","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1285088884","fragment_type":"issue_comment","sequence":4,"text":"I did some more thinking and reading about this. What should we do if there is extra garbage after a gzip stream ends? I tested and both curl and Go's net/http generate an error.\n\nAccording to URL gzip is defined in RFC 1952. In section 2.2:\n \n \n \n \n\nThe GzDecoder docs don't really make it clear, but that decoder only decodes a _single member_. The gzip specification (and therefore HTTP) specify a sequence of members. That's what's implemented by MultiGzDecoder. In other words, MultiGzDecoder is what you want if you actually want to read gzip response bodies, even though its documentation makes it sound like something esoteric.\n\nThat plays nicely with our intuition that extra garbage after a gzip member should cause an error. Once you've read a full member, the next thing you read must be either EOF or another fully-valid gzip member. So I take back what I said earlier: it's not really a coincidence that MultiGzDecoder repools, because it will keep reading to EOF.\n\nSo, I propose we switch to MultiGzDecoder, which I think should solve this problem in a simple way.","author_login":"jsha","author_association":"COLLABORATOR","created_at":"2022-10-20T07:45:53+08:00","repo_name":"algesten/ureq","issue_id":1410754066,"issue_number":549,"issue_url":"https://github.com/algesten/ureq/issues/549","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1286639797","fragment_type":"issue_comment","sequence":5,"text":"By the way, Brotli doesn't have the same convenient property, where streams happen to be terminated by end-of-file. AFAICT the Brotli decoder behaves similarly to how the `GzDecoder` does, and only consumes the compressed part of its input, possibly leaving some extra garbage on the end. So while `MultiGzDecoder` neatly solves this problem for gzip, we still need to solve it for Brotli.\n\nI think we should error if there is extra garbage. One way to do that: wrap `BrotliDecoder` in a `PreciseReader`. The `PreciseReader`, after getting an `Ok(0)` from the `BrotliDecoder`, calls `into_inner()` on it and does a one-byte read on the underlying reader. If that one-byte read produces anything other the `Ok(0)` that means there's extra garbage and `PreciseReader` should return an error (which leads to not pooling the connection).\n\nSome reasons to error on extra garbage:\n\n - Would prefer not to silently ignore bad input\n - It avoids an obligation to read arbitrarily many bytes during a single read call\n - curl does it :-D","author_login":"jsha","author_association":"COLLABORATOR","created_at":"2022-10-21T08:32:08+08:00","repo_name":"algesten/ureq","issue_id":1410754066,"issue_number":549,"issue_url":"https://github.com/algesten/ureq/issues/549","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1286934762","fragment_type":"issue_comment","sequence":6,"text":"@jsha great thoughts!\n\nI've pushed a revision of #550 that simplifies the impl somewhat and throws an error if we read anything but 0.","author_login":"algesten","author_association":"OWNER","created_at":"2022-10-21T13:03:59+08:00","repo_name":"algesten/ureq","issue_id":1410754066,"issue_number":549,"issue_url":"https://github.com/algesten/ureq/issues/549","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1340380401","fragment_type":"issue_comment","sequence":7,"text":"This is fixed (for the gzip case) by switching to MultiGzDecoder in #560! 🎉\n\nFor the Brotli case, this will require a little more work. See #559; we'll track the work over there.","author_login":"jsha","author_association":"COLLABORATOR","created_at":"2022-12-07T05:07:44+08:00","repo_name":"algesten/ureq","issue_id":1410754066,"issue_number":549,"issue_url":"https://github.com/algesten/ureq/issues/549","linked_issue_ids":[1465065439],"is_known_query_context":false},{"document_id":"gh_issue_1465065439","fragment_type":"issue_description","sequence":0,"text":"Redesigning PoolReturnRead\nPoolReturnRead is important because we need to be able to hand something back to the user that (a) implements Read and (b) returns the Stream to the Pool as soon as it is correct to do so. But it relies on a property of the Read interface that is not actually guaranteed and in fact is often not true. It relies on upstream Readers always reading until they get to `Ok(0)`. We tried to fix this with the `Done` trait, for the LimitedRead case. But it's come up again in URL and URL which makes me think we are using the wrong abstraction.\n\nPoolReturnRead only ever wraps two types: `LimitedRead` and `ChunkDecoder`. We can move the \"return to pool\" logic down a level and make those two types responsible for returning their Stream when it is viable. For instance, `LimitedRead` could have an `Option `, and so long as it has bytes left to read and that `Option` is `Some`, it would read from the inner reader. If any read would leave zero bytes left, it would `take()` the Option and return it to the pool before returning from `read()`. For `ChunkedDecoder` we would need a `BufRead` as the inner reader, so that it could look ahead and see if the next bytes are the end-of-stream indicator, and do the same thing.\n\nThe end result of these would be that in almost all cases, the stream would be returned to the pool on the second-to-last read (the one returning `Ok(n)`), not the last read (returning `Ok(0)`). And if the user never calls a read that returns `Ok(0)`, we don't have to care.","author_login":"jsha","author_association":"COLLABORATOR","created_at":"2022-11-26T06:29:02+08:00","repo_name":"algesten/ureq","issue_id":1465065439,"issue_number":559,"issue_url":"https://github.com/algesten/ureq/issues/559","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1328015222","fragment_type":"issue_comment","sequence":1,"text":"Sounds good overall.\n \n\nDoesn't this mean that we could have garbage data after the body? How do we \"guarantee\" the `Stream` is correct for the next pool reuse?","author_login":"algesten","author_association":"OWNER","created_at":"2022-11-26T09:42:27+08:00","repo_name":"algesten/ureq","issue_id":1465065439,"issue_number":559,"issue_url":"https://github.com/algesten/ureq/issues/559","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1328015846","fragment_type":"issue_comment","sequence":2,"text":"When we return the Stream to the pool, we can check that the `inner` `BufReader`'s buffer is empty.","author_login":"jsha","author_association":"COLLABORATOR","created_at":"2022-11-26T09:47:53+08:00","repo_name":"algesten/ureq","issue_id":1465065439,"issue_number":559,"issue_url":"https://github.com/algesten/ureq/issues/559","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0159","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Signal UI does not show on Debian Forky unless run with \"--disable-gpu\"?","query_context":"### Using a supported version?\n\n- [x] I have searched searched open and closed issues for duplicates.\n- [x] I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.\n\n### Overall summary\n\nFollowing me updating all my packages in apt yesterday, Signal's UI stopped working, the app would appear in my panel, and I'd get notifications, but no UI would show. Running signal-desktop with the --disable-gpu flag allows it to launch and work again. When running signal-desktop from the terminal, I can see a bunch of GPU errors. Since I can't get a debug log from the app directly due to it not launching, I've attached that terminal log to the debug log section\n\n### Steps to reproduce\n\n1. Run Debian Forky (with Wayland)\n2. Install signal-desktop from Signal's official apt repo\n3. Launch signal-desktop\n4. UI fails to load\n\n### Expected result\n\nExpected result is for the UI to show.\n\n### Actual result\n\nCurrent result is the UI does not show at all.\n\n### Screenshots\n\n_No response_\n\n### Signal version\n\n7.78.0\n\n### Operating system\n\nDebian Forky with KDE Plasma 6.5.1 (Wayland)\n\n### Version of Signal on your phone\n\n_No response_\n\n### Link to debug log\n\nNODE_ENV production\nNODE_CONFIG_DIR /opt/Signal/resources/app.asar/config\nNODE_CONFIG {}\nALLOW_CONFIG_MUTATIONS undefined\nHOSTNAME debian\nNODE_APP_INSTANCE undefined\nSUPPRESS_NO_CONFIG_WARNING undefined\nSIGNAL_ENABLE_HTTP undefined\nuserData: /home/ivy/.config/Signal\n(node:16128) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.\n(Use `signal-desktop --trace-deprecation ...` to show where the warning was created)\n[16403:1107/160301.991707:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=SCANOUT\n[16403:1107/160301.991816:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=GPU_READ\n[16403:1107/160301.991866:ERROR:gpu/command_buffer/service/shared_image/shared_image_factory.cc:931] CreateSharedImage: could not create backing.\n[16403:1107/160301.991926:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=SCANOUT\n[16403:1107/160301.991968:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=GPU_READ\n[16403:1107/160301.992016:ERROR:gpu/command_buffer/service/shared_image/shared_image_factory.cc:931] CreateSharedImage: could not create backing.\n[16403:1107/160301.992077:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=SCANOUT\n[16403:1107/160301.992125:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=GPU_READ\n[16403:1107/160301.992203:ERROR:gpu/command_buffer/service/shared_image/shared_image_factory.cc:931] CreateSharedImage: could not create backing.\n[16403:1107/160301.992308:ERROR:gpu/command_buffer/service/shared_image/shared_image_manager.cc:389] SharedImageManager::ProduceSkia: Trying to Produce a Skia representation from a non-existent mailbox.\n[16403:1107/160301.992388:ERROR:components/viz/service/gl/exit_code.cc:13] Restarting GPU process due to unrecoverable error. Context was lost.\n[16128:1107/160301.999767:ERROR:content/browser/gpu/gpu_process_host.cc:964] GPU process exited unexpectedly: exit_code=8704\n[16460:1107/160302.077249:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=SCANOUT\n[16460:1107/160302.077328:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=GPU_READ\n[16460:1107/160302.077377:ERROR:gpu/command_buffer/service/shared_image/shared_image_factory.cc:931] CreateSharedImage: could not create backing.\n[16460:1107/160302.077417:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=SCANOUT\n[16460:1107/160302.077453:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=GPU_READ\n[16460:1107/160302.077485:ERROR:gpu/command_buffer/service/shared_image/shared_image_factory.cc:931] CreateSharedImage: could not create backing.\n[16460:1107/160302.077530:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=SCANOUT\n[16460:1107/160302.077563:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=GPU_READ\n[16460:1107/160302.077593:ERROR:gpu/command_buffer/service/shared_image/shared_image_factory.cc:931] CreateSharedImage: could not create backing.\n[16460:1107/160302.077638:ERROR:gpu/command_buffer/service/shared_image/shared_image_manager.cc:389] SharedImageManager::ProduceSkia: Trying to Produce a Skia representation from a non-existent mailbox.\n[16460:1107/160302.077689:ERROR:components/viz/service/gl/exit_code.cc:13] Restarting GPU process due to unrecoverable error. Context was lost.\n[16128:1107/160302.084797:ERROR:content/browser/gpu/gpu_process_host.cc:964] GPU process exited unexpectedly: exit_code=8704\n[16505:1107/160302.166760:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=SCANOUT\n[16505:1107/160302.166840:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=GPU_READ\n[16505:1107/160302.166882:ERROR:gpu/command_buffer/service/shared_image/shared_image_factory.cc:931] CreateSharedImage: could not create backing.\n[16505:1107/160302.166925:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=SCANOUT\n[16505:1107/160302.166963:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=GPU_READ\n[16505:1107/160302.167005:ERROR:gpu/command_buffer/service/shared_image/shared_image_factory.cc:931] CreateSharedImage: could not create backing.\n[16505:1107/160302.167047:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=SCANOUT\n[16505:1107/160302.167084:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=GPU_READ\n[16505:1107/160302.167118:ERROR:gpu/command_buffer/service/shared_image/shared_image_factory.cc:931] CreateSharedImage: could not create backing.\n[16505:1107/160302.167180:ERROR:gpu/command_buffer/service/shared_image/shared_image_manager.cc:389] SharedImageManager::ProduceSkia: Trying to Produce a Skia representation from a non-existent mailbox.\n[16505:1107/160302.167243:ERROR:components/viz/service/gl/exit_code.cc:13] Restarting GPU process due to unrecoverable error. Context was lost.\n[16128:1107/160302.176041:ERROR:content/browser/gpu/gpu_process_host.cc:964] GPU process exited unexpectedly: exit_code=8704","known_context_document_ids":["gh_issue_3601735997"],"reference_answer":"Since this issue was opened, we started using `curve25519-n`, a native module. This should improve the performance of our curve25519 code by a lot.\n\nGiven that (and the fact that this issue has been inactive for over 3 years), I'm going to close. Happy to reopen if that's wrong.","answer_document_id":"gh_comment_689879564","silver_evidence_path":["gh_comment_3506753136","gh_issue_48250344","gh_comment_689879564"],"evidence_issue_ids":[3601735997,48250344],"source_repo_name":"signalapp/Signal-Desktop","source_issue_id":3601735997,"source_issue_number":7586,"source_issue_url":"https://github.com/signalapp/Signal-Desktop/issues/7586","target_repo_name":"signalapp/Signal-Desktop","target_issue_id":48250344,"target_issue_number":88,"target_issue_url":"https://github.com/signalapp/Signal-Desktop/issues/88","reference_anchor_document_id":"gh_comment_3506753136","reference_answer_author":"EvanHahn-Signal","reference_answer_author_association":"COLLABORATOR","quality_score":81.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.4111,"anchor_target_overlap":0.0,"target_answer_overlap":0.1364},"issue_created_at":"2025-11-07T19:33:12+08:00","valid_comment_count":4,"fragments":[{"document_id":"gh_issue_3601735997","fragment_type":"issue_description","sequence":0,"text":"Signal UI does not show on Debian Forky unless run with \"--disable-gpu\"\n### Using a supported version?\n\n- [x] I have searched searched open and closed issues for duplicates.\n- [x] I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.\n\n### Overall summary\n\nFollowing me updating all my packages in apt yesterday, Signal's UI stopped working, the app would appear in my panel, and I'd get notifications, but no UI would show. Running signal-desktop with the --disable-gpu flag allows it to launch and work again. When running signal-desktop from the terminal, I can see a bunch of GPU errors. Since I can't get a debug log from the app directly due to it not launching, I've attached that terminal log to the debug log section\n\n### Steps to reproduce\n\n1. Run Debian Forky (with Wayland)\n2. Install signal-desktop from Signal's official apt repo\n3. Launch signal-desktop\n4. UI fails to load\n\n### Expected result\n\nExpected result is for the UI to show.\n\n### Actual result\n\nCurrent result is the UI does not show at all.\n\n### Screenshots\n\n_No response_\n\n### Signal version\n\n7.78.0\n\n### Operating system\n\nDebian Forky with KDE Plasma 6.5.1 (Wayland)\n\n### Version of Signal on your phone\n\n_No response_\n\n### Link to debug log\n\nNODE_ENV production\nNODE_CONFIG_DIR /opt/Signal/resources/app.asar/config\nNODE_CONFIG {}\nALLOW_CONFIG_MUTATIONS undefined\nHOSTNAME debian\nNODE_APP_INSTANCE undefined\nSUPPRESS_NO_CONFIG_WARNING undefined\nSIGNAL_ENABLE_HTTP undefined\nuserData: /home/ivy/.config/Signal\n(node:16128) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.\n(Use `signal-desktop --trace-deprecation ...` to show where the warning was created)\n[16403:1107/160301.991707:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=SCANOUT\n[16403:1107/160301.991816:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=GPU_READ\n[16403:1107/160301.991866:ERROR:gpu/command_buffer/service/shared_image/shared_image_factory.cc:931] CreateSharedImage: could not create backing.\n[16403:1107/160301.991926:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=SCANOUT\n[16403:1107/160301.991968:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=GPU_READ\n[16403:1107/160301.992016:ERROR:gpu/command_buffer/service/shared_image/shared_image_factory.cc:931] CreateSharedImage: could not create backing.\n[16403:1107/160301.992077:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=SCANOUT\n[16403:1107/160301.992125:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=GPU_READ\n[16403:1107/160301.992203:ERROR:gpu/command_buffer/service/shared_image/shared_image_factory.cc:931] CreateSharedImage: could not create backing.\n[16403:1107/160301.992308:ERROR:gpu/command_buffer/service/shared_image/shared_image_manager.cc:389] SharedImageManager::ProduceSkia: Trying to Produce a Skia representation from a non-existent mailbox.\n[16403:1107/160301.992388:ERROR:components/viz/service/gl/exit_code.cc:13] Restarting GPU process due to unrecoverable error. Context was lost.\n[16128:1107/160301.999767:ERROR:content/browser/gpu/gpu_process_host.cc:964] GPU process exited unexpectedly: exit_code=8704\n[16460:1107/160302.077249:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=SCANOUT\n[16460:1107/160302.077328:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=GPU_READ\n[16460:1107/160302.077377:ERROR:gpu/command_buffer/service/shared_image/shared_image_factory.cc:931] CreateSharedImage: could not create backing.\n[16460:1107/160302.077417:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=SCANOUT\n[16460:1107/160302.077453:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=GPU_READ\n[16460:1107/160302.077485:ERROR:gpu/command_buffer/service/shared_image/shared_image_factory.cc:931] CreateSharedImage: could not create backing.\n[16460:1107/160302.077530:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=SCANOUT\n[16460:1107/160302.077563:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=GPU_READ\n[16460:1107/160302.077593:ERROR:gpu/command_buffer/service/shared_image/shared_image_factory.cc:931] CreateSharedImage: could not create backing.\n[16460:1107/160302.077638:ERROR:gpu/command_buffer/service/shared_image/shared_image_manager.cc:389] SharedImageManager::ProduceSkia: Trying to Produce a Skia representation from a non-existent mailbox.\n[16460:1107/160302.077689:ERROR:components/viz/service/gl/exit_code.cc:13] Restarting GPU process due to unrecoverable error. Context was lost.\n[16128:1107/160302.084797:ERROR:content/browser/gpu/gpu_process_host.cc:964] GPU process exited unexpectedly: exit_code=8704\n[16505:1107/160302.166760:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=SCANOUT\n[16505:1107/160302.166840:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=GPU_READ\n[16505:1107/160302.166882:ERROR:gpu/command_buffer/service/shared_image/shared_image_factory.cc:931] CreateSharedImage: could not create backing.\n[16505:1107/160302.166925:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=SCANOUT\n[16505:1107/160302.166963:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=GPU_READ\n[16505:1107/160302.167005:ERROR:gpu/command_buffer/service/shared_image/shared_image_factory.cc:931] CreateSharedImage: could not create backing.\n[16505:1107/160302.167047:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=SCANOUT\n[16505:1107/160302.167084:ERROR:ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc:82] Cannot create bo with format= RGBA_8888 and usage=GPU_READ\n[16505:1107/160302.167118:ERROR:gpu/command_buffer/service/shared_image/shared_image_factory.cc:931] CreateSharedImage: could not create backing.\n[16505:1107/160302.167180:ERROR:gpu/command_buffer/service/shared_image/shared_image_manager.cc:389] SharedImageManager::ProduceSkia: Trying to Produce a Skia representation from a non-existent mailbox.\n[16505:1107/160302.167243:ERROR:components/viz/service/gl/exit_code.cc:13] Restarting GPU process due to unrecoverable error. Context was lost.\n[16128:1107/160302.176041:ERROR:content/browser/gpu/gpu_process_host.cc:964] GPU process exited unexpectedly: exit_code=8704","author_login":"Lost-Entrepreneur439","author_association":"NONE","created_at":"2025-11-07T19:33:12+08:00","repo_name":"signalapp/Signal-Desktop","issue_id":3601735997,"issue_number":7586,"issue_url":"https://github.com/signalapp/Signal-Desktop/issues/7586","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_3505391092","fragment_type":"issue_comment","sequence":1,"text":"cannot replicate on 3x Debian unstable (forky) systems, 2 with Intel iGPUs and 1 with AMD Radeon RX 6600, all with KDE Plasma 6.5.2","author_login":"eepymeowers","author_association":"NONE","created_at":"2025-11-07T23:43:01+08:00","repo_name":"signalapp/Signal-Desktop","issue_id":3601735997,"issue_number":7586,"issue_url":"https://github.com/signalapp/Signal-Desktop/issues/7586","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3506753136","fragment_type":"issue_comment","sequence":2,"text":"Simmilar/same error here, signal desktop GUI wont show up, but alert for new message will show up. Running with `--disable-gpu` works.\n\n**Signal:**\noficial repository, version 7.78.0\n\n**GPU:**\nOpenGL renderer string: AMD Radeon RX 6900 XT\n\n**OS info:**\nPRETTY_NAME=\"Ubuntu 24.04.3 LTS\"\nNAME=\"Ubuntu\"\nVERSION_ID=\"24.04\"\nVERSION=\"24.04.3 LTS (Noble Numbat)\"\nVERSION_CODENAME=noble\n\n6.8.0-87-generic #88-Ubuntu SMP PREEMPT_DYNAMIC\n\n$XDG_SESSION_TYPE=wayland\n\n**output of `signal-desktop --trace-deprecation`:**\n\nNODE_ENV production\nNODE_CONFIG_DIR /opt/Signal/resources/app.asar/config\nNODE_CONFIG {}\nALLOW_CONFIG_MUTATIONS undefined\nHOSTNAME ai-overlord\nNODE_APP_INSTANCE undefined\nSUPPRESS_NO_CONFIG_WARNING undefined\nSIGNAL_ENABLE_HTTP undefined\nuserData: /home/ai-overlord/.config/Signal\n(node:5982) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.\n at asarStatsToFsStats (node:electron/js2c/node_init:2:1796)\n at t.lstat (node:electron/js2c/node_init:2:5284)\n at LOOP (node:fs:2937:15)\n at process.processTicksAndRejections (node:internal/process/task_queues:85:11)\n[6028:1108/183801.815645:ERROR:ui/gl/angle_platform_impl.cc:42] DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\nERR: DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\n[6028:1108/183801.815771:ERROR:ui/gl/angle_platform_impl.cc:42] DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\nERR: DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\n[6028:1108/183801.815824:ERROR:ui/gl/angle_platform_impl.cc:42] DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\nERR: DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\n[6028:1108/183801.815866:ERROR:ui/gl/angle_platform_impl.cc:42] DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\nERR: DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\n[6028:1108/183801.815903:ERROR:ui/gl/angle_platform_impl.cc:42] DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\nERR: DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\n[6028:1108/183801.815946:ERROR:ui/gl/angle_platform_impl.cc:42] DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\nERR: DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\n[6028:1108/183801.844463:ERROR:components/viz/service/main/viz_main_impl.cc:189] Exiting GPU process due to errors during initialization\n[6068:1108/183801.973868:ERROR:ui/gl/angle_platform_impl.cc:42] DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\nERR: DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\n[6068:1108/183801.973967:ERROR:ui/gl/angle_platform_impl.cc:42] DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\nERR: DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\n[6068:1108/183801.974029:ERROR:ui/gl/angle_platform_impl.cc:42] DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\nERR: DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\n[6068:1108/183801.974073:ERROR:ui/gl/angle_platform_impl.cc:42] DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\nERR: DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\n[6068:1108/183801.974113:ERROR:ui/gl/angle_platform_impl.cc:42] DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\nERR: DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\n[6068:1108/183801.974157:ERROR:ui/gl/angle_platform_impl.cc:42] DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\nERR: DisplayEGL.cpp:666 (generateConfigs): RGBA(32,32,32,32) not handled\n[6068:1108/183802.001775:ERROR:components/viz/service/main/viz_main_impl.cc:189] Exiting GPU process due to errors during initialization","author_login":"simunma","author_association":"NONE","created_at":"2025-11-08T17:50:38+08:00","repo_name":"signalapp/Signal-Desktop","issue_id":3601735997,"issue_number":7586,"issue_url":"https://github.com/signalapp/Signal-Desktop/issues/7586","linked_issue_ids":[48250344],"is_known_query_context":false},{"document_id":"gh_comment_3547045690","fragment_type":"issue_comment","sequence":3,"text":"Good chance this is: URL \n\nI saw this in both the Mattermost Desktop and Signal Desktop snaps that use later electron versions, and have worked around it to try and detect when there is no hardware acceleration and automatically use `--disable-gpu`.","author_login":"jnsgruk","author_association":"NONE","created_at":"2025-11-18T11:17:46+08:00","repo_name":"signalapp/Signal-Desktop","issue_id":3601735997,"issue_number":7586,"issue_url":"https://github.com/signalapp/Signal-Desktop/issues/7586","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_48250344","fragment_type":"issue_description","sequence":0,"text":"asm.js performance optimization\nOur emscripten-compiled curve25519 implementation is here. It can be compiled locally with `grunt build` and build details (compiler flags, sources, etc...) live in `Gruntfile.js`.\n\nIt works but is nowhere near native speed.\n\nWe should profile and optimize this code.\n URL","author_login":"liliakai","author_association":"CONTRIBUTOR","created_at":"2014-11-10T10:32:24+08:00","repo_name":"signalapp/Signal-Desktop","issue_id":48250344,"issue_number":88,"issue_url":"https://github.com/signalapp/Signal-Desktop/issues/88","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_689879564","fragment_type":"issue_comment","sequence":1,"text":"Since this issue was opened, we started using `curve25519-n`, a native module. This should improve the performance of our curve25519 code by a lot.\n\nGiven that (and the fact that this issue has been inactive for over 3 years), I'm going to close. Happy to reopen if that's wrong.","author_login":"EvanHahn-Signal","author_association":"COLLABORATOR","created_at":"2020-09-09T23:36:44+08:00","repo_name":"signalapp/Signal-Desktop","issue_id":48250344,"issue_number":88,"issue_url":"https://github.com/signalapp/Signal-Desktop/issues/88","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0162","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Some `cupyx.scipy.signal` APIs fall back to NumPy?","query_context":"Some `scipy.signal` APIs depend on `numpy.eigvals`, which computes the eigenvalues of a general matrix. However, cuSolver only provides the eigenvalue solver of a symmetric (Hermitian) matrix but does not the one of a general matrix. Therefore, the `cupyx.scipy.signal` counterparts of such APIs are currently implemented by falling back to `numpy.eigvals` or `numpy.roots`, which calls `numpy.eigvals`.\n\nSuch APIs include:\n- `cupyx.scipy.signal.findfreqs` #7641\n- `cupyx.scipy.signal.tf2zpk` #7652\n- `cupyx.scipy.signal.ss2tf` #7652\n\nSee:\n- URL \n- URL","known_context_document_ids":["gh_issue_1823849646"],"reference_answer":"Yes! The new routine was meant for CuPy and other projects to implement `eig` and `eigvals`.","answer_document_id":"gh_comment_2468209117","silver_evidence_path":["gh_comment_1664905336","gh_issue_1110834324","gh_comment_2468209117"],"evidence_issue_ids":[1823849646,1110834324],"source_repo_name":"cupy/cupy","source_issue_id":1823849646,"source_issue_number":7761,"source_issue_url":"https://github.com/cupy/cupy/issues/7761","target_repo_name":"cupy/cupy","target_issue_id":1110834324,"target_issue_number":6359,"target_issue_url":"https://github.com/cupy/cupy/issues/6359","reference_anchor_document_id":"gh_comment_1664905336","reference_answer_author":"leofang","reference_answer_author_association":"MEMBER","quality_score":83.8,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2222,"anchor_target_overlap":0.04,"target_answer_overlap":0.1111},"issue_created_at":"2023-07-27T08:14:15+08:00","valid_comment_count":18,"fragments":[{"document_id":"gh_issue_1823849646","fragment_type":"issue_description","sequence":0,"text":"Some `cupyx.scipy.signal` APIs fall back to NumPy\nSome `scipy.signal` APIs depend on `numpy.eigvals`, which computes the eigenvalues of a general matrix. However, cuSolver only provides the eigenvalue solver of a symmetric (Hermitian) matrix but does not the one of a general matrix. Therefore, the `cupyx.scipy.signal` counterparts of such APIs are currently implemented by falling back to `numpy.eigvals` or `numpy.roots`, which calls `numpy.eigvals`.\n\nSuch APIs include:\n- `cupyx.scipy.signal.findfreqs` #7641\n- `cupyx.scipy.signal.tf2zpk` #7652\n- `cupyx.scipy.signal.ss2tf` #7652\n\nSee:\n- URL \n- URL","author_login":"takagi","author_association":"MEMBER","created_at":"2023-07-27T08:14:15+08:00","repo_name":"cupy/cupy","issue_id":1823849646,"issue_number":7761,"issue_url":"https://github.com/cupy/cupy/issues/7761","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1654992525","fragment_type":"issue_comment","sequence":1,"text":"Lets add a warning in documentation of these routines regarding device synchronization","author_login":"emcastillo","author_association":"MEMBER","created_at":"2023-07-28T04:38:35+08:00","repo_name":"cupy/cupy","issue_id":1823849646,"issue_number":7761,"issue_url":"https://github.com/cupy/cupy/issues/7761","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1664905336","fragment_type":"issue_comment","sequence":2,"text":"Hi @takagi @ev-br @andfoy I could really pick your brains here regarding the general-matrix eigensolver. Why isn't it possible to rewrite the algorithms such that you generate a Hermitian matrix? What's special here? (Context: On the cuSOLVER side, I learned that there's great hesitation in adding the general solver because there's no serious use case. A lot of `eigvals` calls were done, in our opinion, only because people either didn't know `eigvalsh` exists or didn't know their matrix is Hermitian/symmetric. Also, `svd` might help for a lot of use cases ( URL We would love to know what's missing in this understanding.)","author_login":"leofang","author_association":"MEMBER","created_at":"2023-08-04T03:01:51+08:00","repo_name":"cupy/cupy","issue_id":1823849646,"issue_number":7761,"issue_url":"https://github.com/cupy/cupy/issues/7761","linked_issue_ids":[1110834324],"is_known_query_context":false},{"document_id":"gh_comment_1664962130","fragment_type":"issue_comment","sequence":3,"text":"Thanks @leofang for letting my head up. As for `numpy.roots`, the roots of a polynomial is found as the eigenvalues of its companion matrix, and the matrix is not symmetric/Hermitian.\n\n URL \n\nI suppose we need eigenvalues themselves, not just decomposition, so svd may not work.\n\nHowever, yes, we might use another algorithm for root finding on GPU that does not use eigenvalues.\n\n URL \n\nI’ll look into other lines that use eigvals...","author_login":"takagi","author_association":"MEMBER","created_at":"2023-08-04T04:47:24+08:00","repo_name":"cupy/cupy","issue_id":1823849646,"issue_number":7761,"issue_url":"https://github.com/cupy/cupy/issues/7761","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1664962231","fragment_type":"issue_comment","sequence":4,"text":"Thanks @leofang for letting my head up. As for `numpy.roots`, the roots of a polynomial is found as the eigenvalues of its companion matrix, and the matrix is not symmetric/Hermitian.\n\n URL \n\nI suppose we need eigenvalues themselves, not just decomposition, so svd may not work.\n\nHowever, yes, we might use another algorithm for root finding on GPU that does not use eigenvalues.\n\n URL \n\nI’ll look into other lines that use eigvals...","author_login":"takagi","author_association":"MEMBER","created_at":"2023-08-04T04:47:38+08:00","repo_name":"cupy/cupy","issue_id":1823849646,"issue_number":7761,"issue_url":"https://github.com/cupy/cupy/issues/7761","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1110834324","fragment_type":"issue_description","sequence":0,"text":"Implementation of `numpy.linalg.eigvals` equivalent\n### Description\n\nNumPy has a `numpy.linalg.eigvals` function, which is often used in real-life programs.\nPlease provide an equivalent of it for CuPy and name it `cupy.linalg.eigvals`.\n\n### Additional Information\n\n_No response_","author_login":"N0rbert","author_association":"NONE","created_at":"2022-01-21T19:42:59+08:00","repo_name":"cupy/cupy","issue_id":1110834324,"issue_number":6359,"issue_url":"https://github.com/cupy/cupy/issues/6359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1019626231","fragment_type":"issue_comment","sequence":1,"text":"CuPy relies on `cuSolver` for implementing these linear algebra routines. However, there are no routines in cuSolver for non-symmetric matrices, so this requires implementing Cuda kernels or custom routines to solve this.","author_login":"emcastillo","author_association":"MEMBER","created_at":"2022-01-24T01:18:40+08:00","repo_name":"cupy/cupy","issue_id":1110834324,"issue_number":6359,"issue_url":"https://github.com/cupy/cupy/issues/6359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1019630374","fragment_type":"issue_comment","sequence":2,"text":"I think we might be able to steal MAGMA's kernels for this purpose 😄","author_login":"leofang","author_association":"MEMBER","created_at":"2022-01-24T01:26:27+08:00","repo_name":"cupy/cupy","issue_id":1110834324,"issue_number":6359,"issue_url":"https://github.com/cupy/cupy/issues/6359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1019631132","fragment_type":"issue_comment","sequence":3,"text":"yeah, I njust checked and actually torch uses MAGMA for this!","author_login":"emcastillo","author_association":"MEMBER","created_at":"2022-01-24T01:27:53+08:00","repo_name":"cupy/cupy","issue_id":1110834324,"issue_number":6359,"issue_url":"https://github.com/cupy/cupy/issues/6359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1019917948","fragment_type":"issue_comment","sequence":4,"text":"I'm sorry to disappoint but MAGMA's eigenvalue solver for non-symmetric matrices is really bad. There's no specialized GPU-only path, it uses a mix of LAPACK calls with a tiny bit of CUDA kernels. Eigenvalues are computed using LAPACK.\nSee lots of `lapack77` calls in URL \n\nUp to about 3k x 3k matrices, it's faster to compute on CPU.","author_login":"IvanYashchuk","author_association":"CONTRIBUTOR","created_at":"2022-01-24T09:59:08+08:00","repo_name":"cupy/cupy","issue_id":1110834324,"issue_number":6359,"issue_url":"https://github.com/cupy/cupy/issues/6359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1020709284","fragment_type":"issue_comment","sequence":5,"text":"Thanks @IvanYashchuk!!\n\nI was looking into MAGMA code and saw the very same as you, I am just thinking of naively throwing this into a QR solver despite being slow just to avoid CPU sync.","author_login":"emcastillo","author_association":"MEMBER","created_at":"2022-01-25T01:12:57+08:00","repo_name":"cupy/cupy","issue_id":1110834324,"issue_number":6359,"issue_url":"https://github.com/cupy/cupy/issues/6359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1088371230","fragment_type":"issue_comment","sequence":6,"text":"@N0rbert @IvanYashchuk hi\n\nWe have discussed this internally, and some people suggest that it is better to use `svd` if possible. And if there is a case in your applications where `svd` can't be used and you really need `eigvals` no matter what.\n\nThanks","author_login":"emcastillo","author_association":"MEMBER","created_at":"2022-04-05T07:44:15+08:00","repo_name":"cupy/cupy","issue_id":1110834324,"issue_number":6359,"issue_url":"https://github.com/cupy/cupy/issues/6359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1985757694","fragment_type":"issue_comment","sequence":7,"text":"It seems to me that `cuSolver` now has the necessary implementations for non-symmetric matrices:\n\n URL \n\nIf I'm correct, could this request be revisited?\n\nThanks!","author_login":"FedorIVS","author_association":"NONE","created_at":"2024-03-08T14:06:00+08:00","repo_name":"cupy/cupy","issue_id":1110834324,"issue_number":6359,"issue_url":"https://github.com/cupy/cupy/issues/6359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2425994358","fragment_type":"issue_comment","sequence":8,"text":"It looks like the latest cusolver has an implementation for non-symmetric matrices. Is it possible to revisit this request? (Looks like it was added in cuSOLVER: Release 12.6 Update 2)\n URL","author_login":"byron158","author_association":"NONE","created_at":"2024-10-21T08:37:43+08:00","repo_name":"cupy/cupy","issue_id":1110834324,"issue_number":6359,"issue_url":"https://github.com/cupy/cupy/issues/6359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2468209117","fragment_type":"issue_comment","sequence":9,"text":"Yes! The new routine was meant for CuPy and other projects to implement `eig` and `eigvals`.","author_login":"leofang","author_association":"MEMBER","created_at":"2024-11-11T13:41:17+08:00","repo_name":"cupy/cupy","issue_id":1110834324,"issue_number":6359,"issue_url":"https://github.com/cupy/cupy/issues/6359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2497333847","fragment_type":"issue_comment","sequence":10,"text":"Hi, \n\nThis topic sounds quite interesting to me. Is there anyone already working on this? If not I would like to work on this (and #3255 as well) :)\n\nBR","author_login":"timzsu","author_association":"NONE","created_at":"2024-11-25T09:03:41+08:00","repo_name":"cupy/cupy","issue_id":1110834324,"issue_number":6359,"issue_url":"https://github.com/cupy/cupy/issues/6359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2584201776","fragment_type":"issue_comment","sequence":11,"text":"Remark 3 in the docs for `cusolverDnXgeev` says that it is \"a hybrid CPU-GPU algorithm\" with \"best performance attained with pinned host memory\", which leads me to suspect that cuSOLVER uses the same sort of code as MAGMA, with key steps of `geev` (reduction to upper Hessenberg form and the QR algorithm) not being GPU-accelerated. (Also there is no `cusolverDnXggev` to solve generalized non-symmetric/non-Hermitian eigenvalue problems.) Therefore this new routine is unlikely to achieve the kind of orders-of-magnitude performance improvement we get for symmetric/Hermitian eigenproblems. There are a few papers on GPU acceleration of the upper Hessenberg reduction, all many years old, none of which seem to have resulted in widely adopted implementations. This is regrettable, but perhaps not too surprising, as university departments which need to solve large non-symmetric/non-Hermitian eigenproblems tend to have access to compute clusters and need not side-track their scarce resources into developing GPU implementations.","author_login":"atykhyy","author_association":"NONE","created_at":"2025-01-10T21:08:47+08:00","repo_name":"cupy/cupy","issue_id":1110834324,"issue_number":6359,"issue_url":"https://github.com/cupy/cupy/issues/6359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2584910736","fragment_type":"issue_comment","sequence":12,"text":"Hi atykhyy,\n\nchiming in here, as I was one of the contributors for the implementation of cusolverDnXgeev.\n \n\ncusolverDnXgeev is a different implementation and the key steps are GPU accelerated. With eigenvector computation, I would expect a few x speedup compared to Magma.","author_login":"codecircuit","author_association":"NONE","created_at":"2025-01-10T23:47:59+08:00","repo_name":"cupy/cupy","issue_id":1110834324,"issue_number":6359,"issue_url":"https://github.com/cupy/cupy/issues/6359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2595292479","fragment_type":"issue_comment","sequence":13,"text":"@codecircuit I installed the most recent CUDA on my Windows machine (not the newest, a Thinkpad P52 with a discrete NVidia GPU Quadro P3200 with Max-Q design, CUDA compute version 6.1), installed cupy from the PR referenced in this thread, and tried the solver on a non-symmetric 10000x10000 matrix with a simple `w,v=cupy.linalg.eig(A)`. I can see that the solver is indeed GPU-accelerated - task manager showed the GPU's CUDA engine chugging at 100% using all 6Gb dedicated GPU RAM - and the solver found the same eigenvalues and eigenvectors of interest to me, but unexpectedly it took 23'40\" to complete where scipy's CPU-only solver using default settings (`w,v=scipy.linalg.eig(A)`) took 9'50\" on the exact same matrix. Is this too large a matrix size for this amount of GPU RAM, or is my hardware too old, or what's going on?","author_login":"atykhyy","author_association":"NONE","created_at":"2025-01-16T11:39:08+08:00","repo_name":"cupy/cupy","issue_id":1110834324,"issue_number":6359,"issue_url":"https://github.com/cupy/cupy/issues/6359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2605510511","fragment_type":"issue_comment","sequence":14,"text":"@atykhyy could it be that you do the computation in FP64? Your graphics card has very poor FP64 performance. Switching to FP32 should speed up the computation but has an effect on the convergence of the algorithm and could result into more iterations. You can see the number of iterations and used precision by enabling cuSOLVER logs by setting environment variable `CUSOLVERDN_LOG_MASK=18`.","author_login":"codecircuit","author_association":"NONE","created_at":"2025-01-21T18:56:53+08:00","repo_name":"cupy/cupy","issue_id":1110834324,"issue_number":6359,"issue_url":"https://github.com/cupy/cupy/issues/6359","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0163","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Inquiry Regarding LED Screen Procurement?","query_context":"(Please excuse my limited English proficiency; this message was translated with AI assistance.)\n\nDear Author,\n\nI am a DIY creator from China. While attempting to replicate your project, I encountered challenges in procuring the specific LED screen used. I would like to clarify the details of the LED panel you employed.\n\nFrom your referenced project link (about driving an LED screen with a Raspberry Pi 4), it seems you used a screen with a P1.875 pixel pitch, a 128x64 array, and FM6126 driver chips. ​Is this accurate?​​ (Note: This information might differ from your actual setup.)\n\nIf correct, manufacturers in China have informed me that FM6126-driven screens are discontinued. Could you provide guidance on driver alternatives? If your screen uses a different driver chip (which we sincerely hope is the case), please specify the chip model so we can source compatible panels from other suppliers.\n\nAdditionally, you shared a product link that directs to a flexible LED screen with a soft rubber base (now discontinued). However, your YouTube video appears to show a rigid screen. ​Did you actually use a flexible screen in your project?​​\n\nYour assistance would be immensely valuable. Thank you very much!","known_context_document_ids":["gh_issue_2995475862"],"reference_answer":"I think you should step back and start again from an unmodified repo. If you daisy chain two 64x64 panels together, they should work as a single 128x64 panel. Both variants (vortex and rotovox) use two 128x64 panels, so we know that part works. If the image is the wrong way up, it's because the panels are the wrong way up.\nYou can't adjust the rotation of the image in the software. The orientation of the scan lines, and the order they're addressed, is fundamental to how the device works. It times its output to where the current scanline is physically located in space.\n\nVortex assumes two 128x64 panels arranged with horizontal scanlines, placed back to back. In this configuration, both panels have line 0 at the top, and line 63 at the bottom.\n\nRotovox assumes two 128x64 panels arranged vertically (with their scanlines vertical), and both facing the same way. One of the panels is upside down compared with the other. The point of this arrangement is to ensure that each corresponding scanline is at the same radius. Line 0 of both panels is closest to the axis, line 63 is furthest from the axis.\n\nIf you want to replicate one of these setups using four 64x64 panels, arrange them in two chains of 2, with each chain arranged so that their horizontal scanlines are aligned. Check that this works using `rpi-rgb-led` with no display transforms applied. The panels have to be side by side, the same way up, with scanline 0 extending across the top of both panels.\n(If that doesn't work, check whether `--led-rows=64 --led-cols=64 --led-chain=2` behaves the same way as `--led-rows=64 --led-cols=128 --led-chain=1` - the assumption I'm making is that they're equivalent, but I've never tested that.)\n\nIf none of that helps, it may still be possible to use make a smaller display using the 64x64 panels without chaining.","answer_document_id":"gh_comment_2829013265","silver_evidence_path":["gh_comment_2822974454","gh_issue_3012583703","gh_comment_2829013265"],"evidence_issue_ids":[2995475862,3012583703],"source_repo_name":"AncientJames/VortexParts","source_issue_id":2995475862,"source_issue_number":5,"source_issue_url":"https://github.com/AncientJames/VortexParts/issues/5","target_repo_name":"AncientJames/multivox","target_issue_id":3012583703,"target_issue_number":5,"target_issue_url":"https://github.com/AncientJames/multivox/issues/5","reference_anchor_document_id":"gh_comment_2822974454","reference_answer_author":"AncientJames","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2917,"anchor_target_overlap":0.3333,"target_answer_overlap":0.1364},"issue_created_at":"2025-04-15T07:40:38+08:00","valid_comment_count":16,"fragments":[{"document_id":"gh_issue_2995475862","fragment_type":"issue_description","sequence":0,"text":"Inquiry Regarding LED Screen Procurement\n(Please excuse my limited English proficiency; this message was translated with AI assistance.)\n\nDear Author,\n\nI am a DIY creator from China. While attempting to replicate your project, I encountered challenges in procuring the specific LED screen used. I would like to clarify the details of the LED panel you employed.\n\nFrom your referenced project link (about driving an LED screen with a Raspberry Pi 4), it seems you used a screen with a P1.875 pixel pitch, a 128x64 array, and FM6126 driver chips. ​Is this accurate?​​ (Note: This information might differ from your actual setup.)\n\nIf correct, manufacturers in China have informed me that FM6126-driven screens are discontinued. Could you provide guidance on driver alternatives? If your screen uses a different driver chip (which we sincerely hope is the case), please specify the chip model so we can source compatible panels from other suppliers.\n\nAdditionally, you shared a product link that directs to a flexible LED screen with a soft rubber base (now discontinued). However, your YouTube video appears to show a rigid screen. ​Did you actually use a flexible screen in your project?​​\n\nYour assistance would be immensely valuable. Thank you very much!","author_login":"IceSakura0001","author_association":"NONE","created_at":"2025-04-15T07:40:38+08:00","repo_name":"AncientJames/VortexParts","issue_id":2995475862,"issue_number":5,"issue_url":"https://github.com/AncientJames/VortexParts/issues/5","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2804339545","fragment_type":"issue_comment","sequence":1,"text":"The panels I used were flexible - they were left over from another project. I removed the rubber backing and printed a rigid frame to hold them. There's no need for them to be flexible if you're sourcing new parts, you only need to be able to hold them back to back with around 20mm between them.\n\nThese panels use a shift register based addressing scheme on the `A` `B` and `C` pins. The code also supports panels using the more straightforward `ABCDE` addressing. You define which approach to use in the `gadget.h` file - `gadget_rotovox.h` uses `ABCDE`. If you get panels which use a different protocol, it's not a big job to add that. I've only implemented the protocols I was able to test on my own hardware.","author_login":"AncientJames","author_association":"OWNER","created_at":"2025-04-15T08:59:36+08:00","repo_name":"AncientJames/VortexParts","issue_id":2995475862,"issue_number":5,"issue_url":"https://github.com/AncientJames/VortexParts/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2822974454","fragment_type":"issue_comment","sequence":2,"text":"We sincerely appreciate your help. We tested new display panels and modified the pin configurations, ultimately succeeding in activating the screen. However, we encountered new issues. If you are reading this message, please proceed to URL where we have posted our questions.","author_login":"IceSakura0001","author_association":"NONE","created_at":"2025-04-23T03:37:38+08:00","repo_name":"AncientJames/VortexParts","issue_id":2995475862,"issue_number":5,"issue_url":"https://github.com/AncientJames/VortexParts/issues/5","linked_issue_ids":[3012583703],"is_known_query_context":false},{"document_id":"gh_issue_3012583703","fragment_type":"issue_description","sequence":0,"text":"Display content exhibits tiling misalignment\nWe are pleased to report that with your guidance on modifying the pin definitions, we have successfully lit up the screen. However, when attempting to run content on the display, numerous errors occurred. Despite trying parameter adjustments, the display performance remains unsatisfactory.\n\n​Critical constraint:​​\nIn Mainland China, the only screen suitable for this project is the P2 model with 64x64 resolution. This hardware limitation has forced us to make code adaptations.\n\nBelow is the set of modifications we implemented that may impact display artifacts. All other changes exclusively pertain to output pin definitions. No further modifications beyond those specified have been executed.\n\n#define PANEL_WIDTH 64\n#define PANEL_HEIGHT 64 \n//width must be higher than height\n//64*64 is the best\n//if 128*64 ,the image is mixed together (4 pixels up)\n#define PANEL_COUNT 4 \n//Cannot be lower than 2\n//tried 4 and the image is same as w=128 and h=64\n#define PANEL_MULTIPLEX 2 //Cannot be lower than 2\n//tried 4 and the image is depart into 4 and cannot connect together\n#define PANEL_FIELD_HEIGHT (PANEL_HEIGHT / PANEL_MULTIPLEX)\n\n//#define PANEL_0_ORDER(c) (PANEL_WIDTH - 1 - c)\n#define PANEL_0_ORDER(c) (c)\n//changed and means nothing with the image\n#define PANEL_1_ORDER(c) (c)\n\n//#define VOXELS_X 128\n//#define VOXELS_Y 128\n//#define VOXELS_Z 128\n\n#define VOXELS_X 64\n#define VOXELS_Y 64\n#define VOXELS_Z 64\n//All the pixels in the space\n#define VOXEL_Z_STRIDE 1\n//changed into 2 and the image is longer and turn into 4 piece\n//changed into 4 and the image is morre longer and turn into 8 piece\n//happen with Error\n#define VOXEL_X_STRIDE VOXELS_Z\n#define VOXEL_Y_STRIDE (VOXEL_X_STRIDE * VOXELS_X)\n#define VOXELS_COUNT (VOXELS_X*VOXELS_Y*VOXELS_Z)\n\n//#define PANEL_0_ECCENTRICITY 13.5\n//#define PANEL_1_ECCENTRICITY 0.375\n\n#define ROTATION_ZERO 160\n\n//#define VERTICAL_SCAN \n//this must be changed\n//tried to use when 64*64,and displayed well,but still a few pixels out of one 64*64 screen\n#define CLOCK_WAITS 5\n//#define CLOCK_WAITS 4\n#endif\n\nand this is what we get ↓\n\nImage\n\nWe attempted to run all toys, but clearly observed that the images were tiled across the screen with a downward pixel offset (for the 64x64 screens, their left and right halves were essentially swapped, allowing the two serially connected screens to piece together the actual image). We tried to identify the root cause of this misalignment, but reviewing the entire project codebase made this effort impractical.\n\nAdditionally, with ./flight, the image was visibly rotated 90 degrees. Despite switching between vertical and horizontal modes, the image orientation remained unaffected. When running ./fireworks, the fireworks' position shifted to barely visible areas. Furthermore, after testing the Mantis Shrimp model file downloaded from the YouTube-provided link, only a small cluster of light points appeared on-screen, with no clear cause identified.\n\nOur current hypothesis suggests potential incompatibility between our horizontally scanned screens and the project's intended display type. However, modifications attempting to address this mismatch proved ineffective.\n\nWe sincerely await your further assistance and greatly appreciate your support!\n\nImage\n\n（Our shrimp is still in its egg👇😢）\nImage\n\n（The panel we used）\nImage","author_login":"IceSakura0001","author_association":"NONE","created_at":"2025-04-23T03:24:48+08:00","repo_name":"AncientJames/multivox","issue_id":3012583703,"issue_number":5,"issue_url":"https://github.com/AncientJames/multivox/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2822964587","fragment_type":"issue_comment","sequence":1,"text":"If you require additional details, please do not hesitate to contact us, and we will provide a prompt response.","author_login":"IceSakura0001","author_association":"NONE","created_at":"2025-04-23T03:27:09+08:00","repo_name":"AncientJames/multivox","issue_id":3012583703,"issue_number":5,"issue_url":"https://github.com/AncientJames/multivox/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2822983767","fragment_type":"issue_comment","sequence":2,"text":"If you chain them together (connect the output from the first panel to the input of the second panel), they should work like a single 128x64 panel","author_login":"AncientJames","author_association":"OWNER","created_at":"2025-04-23T03:47:36+08:00","repo_name":"AncientJames/multivox","issue_id":3012583703,"issue_number":5,"issue_url":"https://github.com/AncientJames/multivox/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2823009965","fragment_type":"issue_comment","sequence":3,"text":"Actually we tried just like what you said,and we turned the panel physcally 90° to get the image.\nThis is what we get 👇\n\nImage\n\nImage\n\nImage","author_login":"IceSakura0001","author_association":"NONE","created_at":"2025-04-23T04:14:38+08:00","repo_name":"AncientJames/multivox","issue_id":3012583703,"issue_number":5,"issue_url":"https://github.com/AncientJames/multivox/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2823012149","fragment_type":"issue_comment","sequence":4,"text":"The images displayed on the screen are consistently bisected, resulting in significant perplexity to us.","author_login":"IceSakura0001","author_association":"NONE","created_at":"2025-04-23T04:16:51+08:00","repo_name":"AncientJames/multivox","issue_id":3012583703,"issue_number":5,"issue_url":"https://github.com/AncientJames/multivox/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2823027529","fragment_type":"issue_comment","sequence":5,"text":"I just used 128x64 P1.875 flexible displays from AliExpress, they shipped from China. Remove the flexible rubber, find some M2.5 screws and you'll be able to rigidly mount them with the 3D printed frame.","author_login":"bradylangdale","author_association":"NONE","created_at":"2025-04-23T04:31:45+08:00","repo_name":"AncientJames/multivox","issue_id":3012583703,"issue_number":5,"issue_url":"https://github.com/AncientJames/multivox/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2823051404","fragment_type":"issue_comment","sequence":6,"text":"@bradylangdale \n\nThank you for your assistance. But are you certain the display panels are compatible? In reality, we have sourced screens from multiple manufacturers, but most prove incompatible. We've attempted various methods, even purchasing corresponding drivers to analyze their output waveforms for adaptation, yet found no consistency. The project requires LED panels with FM6126/FM6124 driver chips. Despite testing numerous displays (at considerable expense), none could be activated.\n\nMany Chinese manufacturers focus on custom orders, often failing to properly adhere to HUB75 interface protocols. The sales personnel responsible for these panels often lack technical expertise, primarily handling retail operations rather than engineering details. Technical specifications typically require contacting corporate engineers, who generally refuse to provide further information before bulk orders. This forces reliance on proprietary adapters for compatibility.\n\nAttached is a screenshot from the adapter driver software we obtained, showing all supported driver types - demonstrating the complexity involved. Remarkably, during our search for Raspberry Pi DIY development solutions, we discovered the exact panel type shown in my photo. WAVESHARE has specifically developed LED panels for Raspberry Pi development.\n\nThe additional images show some of the other types of panels we procured (the rest are stored away, so these are the only ones I currently have on hand). All of these panels have been confirmed to be unactivatable on raspberry.\n\nImage\n\nImage\n\nImage\n\nImage","author_login":"IceSakura0001","author_association":"NONE","created_at":"2025-04-23T04:51:38+08:00","repo_name":"AncientJames/multivox","issue_id":3012583703,"issue_number":5,"issue_url":"https://github.com/AncientJames/multivox/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2823062694","fragment_type":"issue_comment","sequence":7,"text":"The panels above uses FM6253(For P1.875 ，the one without plastic frame) ，and LS9929N(P2 with plastic frame)","author_login":"IceSakura0001","author_association":"NONE","created_at":"2025-04-23T05:00:37+08:00","repo_name":"AncientJames/multivox","issue_id":3012583703,"issue_number":5,"issue_url":"https://github.com/AncientJames/multivox/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2823078022","fragment_type":"issue_comment","sequence":8,"text":"@IceSakura0001 \n\nThe panel you pictured above uses features ACBDE pins on the interface. The code provided in the project uses ABC panels. You could get these panels to work but you'd need to support the additional pins when you bit bang.","author_login":"bradylangdale","author_association":"NONE","created_at":"2025-04-23T05:11:28+08:00","repo_name":"AncientJames/multivox","issue_id":3012583703,"issue_number":5,"issue_url":"https://github.com/AncientJames/multivox/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2823096150","fragment_type":"issue_comment","sequence":9,"text":"Yes, they all adopt the ABCDE addressing method. We are using ​rotovox.h, which supports this approach.And we successfully powered on the screen, displaying correct (though incorrect coordinates) information.","author_login":"IceSakura0001","author_association":"NONE","created_at":"2025-04-23T05:24:56+08:00","repo_name":"AncientJames/multivox","issue_id":3012583703,"issue_number":5,"issue_url":"https://github.com/AncientJames/multivox/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2823103895","fragment_type":"issue_comment","sequence":10,"text":"Therefore, the primary issue we're currently facing is that the display is not rendering in the correct position, and the content appears tiled (with repeated sections at the edges).\n\nYou can see what happened above.","author_login":"IceSakura0001","author_association":"NONE","created_at":"2025-04-23T05:27:52+08:00","repo_name":"AncientJames/multivox","issue_id":3012583703,"issue_number":5,"issue_url":"https://github.com/AncientJames/multivox/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2823118154","fragment_type":"issue_comment","sequence":11,"text":"Ah apologies, I'm understanding the original issue. I'm not entirely sure what it could but it might be because rotovox assumes the panels are place tall side-by-side, with the rotational axis at the edge of each panel. vortex assumes the rotational axis is in the center of each panel. The horizontal and vertical scan section of the code affect this, but I haven't dug further and stuck with vortex for now.","author_login":"bradylangdale","author_association":"NONE","created_at":"2025-04-23T05:36:54+08:00","repo_name":"AncientJames/multivox","issue_id":3012583703,"issue_number":5,"issue_url":"https://github.com/AncientJames/multivox/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2825550036","fragment_type":"issue_comment","sequence":12,"text":"If I understand correctly, you want to implement the horizontal, back-to-back layout of Vortex, but using 4 64x64 panels instead of 2 128x64.\nIf you daisy chain the panels, they can be treated as 2 128x64 panels, so the setup would be the same as for gadget_vortex - \n\nPANEL_WIDTH 128\nPANEL_COUNT 2\nVOXELS_X 128\nVOXELS_Y 128\nVOXELS_Z 64\n\nleave `VERTICAL_SCAN` undefined\n\nYou say it's ABCDE addressing, so if you're starting with gadget_vortex, you'll need to undefine the shift register addressing and define the relevant pins for the address lines:\n\n//#define ADDR_CLK 4\n//#define ADDR_DAT 18\n//#define ADDR__EN 15\n//#define ADDR__EN_MASK (1<<ADDR__EN)\n\n#define ROW_A xx\n#define ROW_B xx\n#define ROW_C xx\n#define ROW_D xx\n#define ROW_E xx\n#define ADDR__EN_MASK (0)\n\nYou might also need to fiddle with `CLOCK_WAITS` - to get the highest framerate you want it as low as it will go without resulting in image corruption.","author_login":"AncientJames","author_association":"OWNER","created_at":"2025-04-23T21:34:13+08:00","repo_name":"AncientJames/multivox","issue_id":3012583703,"issue_number":5,"issue_url":"https://github.com/AncientJames/multivox/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2826607248","fragment_type":"issue_comment","sequence":13,"text":"Image\n\nI discovered that I must exchange P0_​RGB_1​ and ​P0_RGB_2, which were the root of the upside down problem. The original pin setup was correct in other programs, so there might be something wrong with the hardware.\n\nBut there is still something wrong with the image. As you can see:\n\nImage\n\nThe whole image seems moved 8 pixels right. \n\nJust now, while I was editing this reply, my colleague help me find an effective solution, so I'll document it here as well:\ngadget_rotovox.h :\n#define PANEL_0_ORDER(c) ((c + 8) % PANEL_WIDTH)\n#define PANEL_1_ORDER(c) ((c + 8) % PANEL_WIDTH)\n\nAfter modifying these parameters, the image in the left 8 columns of pixels became inverted. Our current hypothesis is that the most likely cause is a data exchange occurring in these 8 columns - the image information that should have been output to P0_RGB_1 was instead routed to P0_RGB_2. We attempted to fix this issue but were unsuccessful. This is what it looks like:\n\nImage\n\nImage\n\nIn short, we've largely achieved normal display functionality, but encountered issues when adjusting the image position to rotate around the correct axis.","author_login":"IceSakura0001","author_association":"NONE","created_at":"2025-04-24T07:12:48+08:00","repo_name":"AncientJames/multivox","issue_id":3012583703,"issue_number":5,"issue_url":"https://github.com/AncientJames/multivox/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2829013265","fragment_type":"issue_comment","sequence":14,"text":"I think you should step back and start again from an unmodified repo. If you daisy chain two 64x64 panels together, they should work as a single 128x64 panel. Both variants (vortex and rotovox) use two 128x64 panels, so we know that part works. If the image is the wrong way up, it's because the panels are the wrong way up.\nYou can't adjust the rotation of the image in the software. The orientation of the scan lines, and the order they're addressed, is fundamental to how the device works. It times its output to where the current scanline is physically located in space.\n\nVortex assumes two 128x64 panels arranged with horizontal scanlines, placed back to back. In this configuration, both panels have line 0 at the top, and line 63 at the bottom.\n\nRotovox assumes two 128x64 panels arranged vertically (with their scanlines vertical), and both facing the same way. One of the panels is upside down compared with the other. The point of this arrangement is to ensure that each corresponding scanline is at the same radius. Line 0 of both panels is closest to the axis, line 63 is furthest from the axis.\n\nIf you want to replicate one of these setups using four 64x64 panels, arrange them in two chains of 2, with each chain arranged so that their horizontal scanlines are aligned. Check that this works using `rpi-rgb-led` with no display transforms applied. The panels have to be side by side, the same way up, with scanline 0 extending across the top of both panels.\n(If that doesn't work, check whether `--led-rows=64 --led-cols=64 --led-chain=2` behaves the same way as `--led-rows=64 --led-cols=128 --led-chain=1` - the assumption I'm making is that they're equivalent, but I've never tested that.)\n\nIf none of that helps, it may still be possible to use make a smaller display using the 64x64 panels without chaining.","author_login":"AncientJames","author_association":"OWNER","created_at":"2025-04-24T22:39:58+08:00","repo_name":"AncientJames/multivox","issue_id":3012583703,"issue_number":5,"issue_url":"https://github.com/AncientJames/multivox/issues/5","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0169","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Add MiroTalk?","query_context":"_Best of JS_ is for the most popular open-source projects related to the web platform and Node.js.\n \nWhat is the URL of the project you'd like to add to _Best of JS_? \n\nGitHub: URL \nDemo: URL \n\nBefore submitting the request to add a new project, please check the following points:\n\n- ✅ The project is related to the web platform or Node.js\n- ✅ The project has more than 100 stars on GitHub\n- ✅ The project has thorough documentation in English\n- ✅ The project is not deprecated and actively maintained\n\nHow would this project be tagged? (Pick one or several existing tags from this list: URL \n\nWebRTC, Websocket, Real-Time\n \nAlso you can suggest new tags to add if you think _Best of JS_ is missing useful tags. \n\nself-hosted, sfu, p2p, web-app, video-conferencing, video-call, voip, streaming, file-sharing, screen-sharing, whiteboard","known_context_document_ids":["gh_issue_1096698404"],"reference_answer":"Hello @nitad54448, \nWhat do you mean by `I get a certificate error` ? \nIf you using the MiroTalk SSL default certificates on: URL \nAt most the browser could tell you that it is an unknown certificate, you accept it and you can use Mirotalk in HTTPS.\nI haven't tried caddy, I usually use Let's Encrypt for trusted certificates.\nRegards","answer_document_id":"gh_comment_1065859831","silver_evidence_path":["gh_comment_1007905910","gh_issue_1013759860","gh_comment_1065859831"],"evidence_issue_ids":[1096698404,1013759860],"source_repo_name":"michaelrambeau/bestofjs","source_issue_id":1096698404,"source_issue_number":448,"source_issue_url":"https://github.com/michaelrambeau/bestofjs/issues/448","target_repo_name":"miroslavpejic85/mirotalksfu","target_issue_id":1013759860,"target_issue_number":14,"target_issue_url":"https://github.com/miroslavpejic85/mirotalksfu/issues/14","reference_anchor_document_id":"gh_comment_1007905910","reference_answer_author":"miroslavpejic85","reference_answer_author_association":"OWNER","quality_score":93.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.8333,"anchor_target_overlap":0.1429,"target_answer_overlap":0.04},"issue_created_at":"2022-01-07T21:56:46+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_1096698404","fragment_type":"issue_description","sequence":0,"text":"Add MiroTalk\n_Best of JS_ is for the most popular open-source projects related to the web platform and Node.js.\n \nWhat is the URL of the project you'd like to add to _Best of JS_? \n\nGitHub: URL \nDemo: URL \n\nBefore submitting the request to add a new project, please check the following points:\n\n- ✅ The project is related to the web platform or Node.js\n- ✅ The project has more than 100 stars on GitHub\n- ✅ The project has thorough documentation in English\n- ✅ The project is not deprecated and actively maintained\n\nHow would this project be tagged? (Pick one or several existing tags from this list: URL \n\nWebRTC, Websocket, Real-Time\n \nAlso you can suggest new tags to add if you think _Best of JS_ is missing useful tags. \n\nself-hosted, sfu, p2p, web-app, video-conferencing, video-call, voip, streaming, file-sharing, screen-sharing, whiteboard","author_login":"miroslavpejic85","author_association":"NONE","created_at":"2022-01-07T21:56:46+08:00","repo_name":"michaelrambeau/bestofjs","issue_id":1096698404,"issue_number":448,"issue_url":"https://github.com/michaelrambeau/bestofjs/issues/448","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1007833587","fragment_type":"issue_comment","sequence":1,"text":"Hello Miroslav @miroslavpejic85 \nThank you for the suggestion, `MiroTalk` will be available on _Best of JS_ very soon.\n\nAbout tagging:\n\n- we have a `video` tag: URL \n- we don't have `p2p` but we have `decentralized`: URL does it make sense to assign it to `MiroTalk`? Or should I rename it `p2p`, it would be better?\n\nThank you for your help! (tagging is so difficult 😅 )","author_login":"michaelrambeau","author_association":"OWNER","created_at":"2022-01-08T00:10:59+08:00","repo_name":"michaelrambeau/bestofjs","issue_id":1096698404,"issue_number":448,"issue_url":"https://github.com/michaelrambeau/bestofjs/issues/448","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1007905910","fragment_type":"issue_comment","sequence":2,"text":"Hello @michaelrambeau, thank you very much.\n\nFor this version, in case you could also add the video tag, so \n\nbash\nWebRTC, Websocket, Video, Real-Time\n\nYou're right, sorry, decentralized is fine in place of p2p.\n\nIn theory there are two versions of MiroTalk, this one (SFU) and the MiroTalk P2P (Decentralized)\n\n## MiroTalk P2P\n\nBest of JS is for the most popular open-source projects related to the web platform and Node.js.\n\nWhat is the URL of the project you'd like to add to Best of JS?\n\nGitHub: URL \nDemo: URL \n\nBefore submitting the request to add a new project, please check the following points:\n\n- ✅ The project is related to the web platform or Node.js\n- ✅ The project has more than 100 stars on GitHub\n- ✅ The project has thorough documentation in English\n- ✅ The project is not deprecated and actively maintained\n\nHow would this project be tagged? (Pick one or several existing tags from this list: URL \n\nWebRTC, Decentralized, Websocket, Video, Real-Time\n\nAlso you can suggest new tags to add if you think Best of JS is missing useful tags.\n\n---\n\nDoes it make sense to add both of them, or just the first one ?\n\nThe difference between 2 you can check out here\n\nThanks to you and nice to meet you :)","author_login":"miroslavpejic85","author_association":"NONE","created_at":"2022-01-08T08:04:49+08:00","repo_name":"michaelrambeau/bestofjs","issue_id":1096698404,"issue_number":448,"issue_url":"https://github.com/michaelrambeau/bestofjs/issues/448","linked_issue_ids":[1013759860],"is_known_query_context":false},{"document_id":"gh_comment_1007987015","fragment_type":"issue_comment","sequence":3,"text":"@miroslavpejic85 Nice to meet you too 😄 \n\nThank you for the explanations.\n\nJust to confirm, there will be two projects on _Best of JS_:\n\n- MiroTalk SFU\n- MiroTalk P2P (this one will have the tag `decentralized`... that I should rename `P2P`maybe, I'm not sure which term makes more sense for most of the users)","author_login":"michaelrambeau","author_association":"OWNER","created_at":"2022-01-08T13:10:39+08:00","repo_name":"michaelrambeau/bestofjs","issue_id":1096698404,"issue_number":448,"issue_url":"https://github.com/michaelrambeau/bestofjs/issues/448","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1007987947","fragment_type":"issue_comment","sequence":4,"text":"@michaelrambeau Yeah :)\n\n`MiroTalk SFU` - Tags: WebRTC, Websocket, Video, Real-Time\n`MiroTalk P2P` - Tags: WebRTC, Decentralized (or p2p as you prefer), Websocket, Video, Real-Time\n\nThank you again!","author_login":"miroslavpejic85","author_association":"NONE","created_at":"2022-01-08T13:18:46+08:00","repo_name":"michaelrambeau/bestofjs","issue_id":1096698404,"issue_number":448,"issue_url":"https://github.com/michaelrambeau/bestofjs/issues/448","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1008446065","fragment_type":"issue_comment","sequence":5,"text":"Hello Miroslav @miroslavpejic85 , done, please check!\n\nYou look like the super star of the `Video` section 😄 : URL \n\nimage","author_login":"michaelrambeau","author_association":"OWNER","created_at":"2022-01-09T23:27:10+08:00","repo_name":"michaelrambeau/bestofjs","issue_id":1096698404,"issue_number":448,"issue_url":"https://github.com/michaelrambeau/bestofjs/issues/448","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1008446569","fragment_type":"issue_comment","sequence":6,"text":"...but sorry I made a mistake with the tagging, I'm going to fix it.","author_login":"michaelrambeau","author_association":"OWNER","created_at":"2022-01-09T23:30:56+08:00","repo_name":"michaelrambeau/bestofjs","issue_id":1096698404,"issue_number":448,"issue_url":"https://github.com/michaelrambeau/bestofjs/issues/448","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1008448545","fragment_type":"issue_comment","sequence":7,"text":"...done, please check again. The screenshot has been edited.","author_login":"michaelrambeau","author_association":"OWNER","created_at":"2022-01-09T23:45:41+08:00","repo_name":"michaelrambeau/bestofjs","issue_id":1096698404,"issue_number":448,"issue_url":"https://github.com/michaelrambeau/bestofjs/issues/448","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1013759860","fragment_type":"issue_description","sequence":0,"text":"SFU implementation vs mesh Mirotalk\nHi. As ever, thanks for sharing your impressive work. I hope you take a breather sometime too heh. \nIn addition to your different hosting environments for the two (Railway won't suffice for mediasoup SFU?), I'm curious as to your experience with tangible differences in the two implementations. Specifically, if one has aspirations for clubhouse like audio-centric use, might that sans-video approach work upon the mesh version? Other comparisons, based on your experience would also be interesting to learn. Thanks!","author_login":"pragmatech","author_association":"NONE","created_at":"2021-10-01T21:01:50+08:00","repo_name":"miroslavpejic85/mirotalksfu","issue_id":1013759860,"issue_number":14,"issue_url":"https://github.com/miroslavpejic85/mirotalksfu/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_932701999","fragment_type":"issue_comment","sequence":1,"text":"`MiroTalk P2P`: URL \n\nArchitecture: `WebRTC Mesh` (peer to peer between browsers)\n\nimage\n\n`Unlimited rooms, no limit of time`, supports `5 users in the single room` To have a good video-audio quality. The quality of the call is inversely proportional to the number of people on the call.\n\nRequired: `Client PC` (peers) must have a `good Bandwith and CPU`.\n\nDeploy: Any host that support `Node.js` like: railway or heroku (Free service) or DigitalOcean for personal vm server (for a fee) ...\n\nBonus: There are an option to use it directly from your `LOCAL PC` and thanks to Ngrok you will be able to have conference and will be reached outside your local network, no matter where you are! \n\n \n\n`MiroTalk SFU` (This one): URL \n\nArchitecture: `WebRTC SFU` (Server with Selective Forwarding Unit) using mediasoup\n\nimage\n\n`Unlimited rooms, no limit of time`, and in theory `no limit of users`. Routing is a multiparty topology, where each participant sends its media to this integrated server, and receives all other's media from it.\n\nRequired: `Server` must have a `very good Bandwidth`, and good RAM and CPU.\n\nDeploy: `VM` that support `Node.js and other stuff` like: DigitalOcean or amazon-aws (paid service) ...\n\nBonus: There are an Option to use it directly from your `LOCAL PC` by some extra settings and thanks to Ngrok you will be able to have conference and will be reached outside your local network, no matter where you are!\n\nBased on the amount of users you have, you can choose the right solution for you :)\n\nI hope I have clarified your doubts about the difference of the two versions? \n\nThanks and have a nice day.\n\nRegards","author_login":"miroslavpejic85","author_association":"OWNER","created_at":"2021-10-02T07:36:11+08:00","repo_name":"miroslavpejic85/mirotalksfu","issue_id":1013759860,"issue_number":14,"issue_url":"https://github.com/miroslavpejic85/mirotalksfu/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1061795001","fragment_type":"issue_comment","sequence":2,"text":"Hi\nI installed the SFU version on my LTS 20.04 selfhosted. It seems to work locally but not from outside. I did not get certificates but I use a caddy reverse proxy, which I configured correctly. I get a certificate error. Is there a way to use caddy's SSL certificates ?\nThanks","author_login":"nitad54448","author_association":"NONE","created_at":"2022-03-08T13:47:49+08:00","repo_name":"miroslavpejic85/mirotalksfu","issue_id":1013759860,"issue_number":14,"issue_url":"https://github.com/miroslavpejic85/mirotalksfu/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1065859831","fragment_type":"issue_comment","sequence":3,"text":"Hello @nitad54448, \nWhat do you mean by `I get a certificate error` ? \nIf you using the MiroTalk SSL default certificates on: URL \nAt most the browser could tell you that it is an unknown certificate, you accept it and you can use Mirotalk in HTTPS.\nI haven't tried caddy, I usually use Let's Encrypt for trusted certificates.\nRegards","author_login":"miroslavpejic85","author_association":"OWNER","created_at":"2022-03-12T10:41:27+08:00","repo_name":"miroslavpejic85/mirotalksfu","issue_id":1013759860,"issue_number":14,"issue_url":"https://github.com/miroslavpejic85/mirotalksfu/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1188729408","fragment_type":"issue_comment","sequence":4,"text":"Good afternoon Miroslav, I have a question, how can I place your application on hosting, not in the way that you indicated in the documentation, but with the standard npm run build command, but the problem is when I run it, I get an error, how can I run the npm run build comm\nNew Bitmap Image\nand here is an example what a normally compiled file looks like","author_login":"VladimirGorin","author_association":"NONE","created_at":"2022-07-19T08:01:36+08:00","repo_name":"miroslavpejic85/mirotalksfu","issue_id":1013759860,"issue_number":14,"issue_url":"https://github.com/miroslavpejic85/mirotalksfu/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1188796966","fragment_type":"issue_comment","sequence":5,"text":"Hello @VladimirGorin,\nFor questions please do not post here but join with us on Discord forum - `hepl-and-support channel`. Thank you!","author_login":"miroslavpejic85","author_association":"OWNER","created_at":"2022-07-19T09:07:34+08:00","repo_name":"miroslavpejic85/mirotalksfu","issue_id":1013759860,"issue_number":14,"issue_url":"https://github.com/miroslavpejic85/mirotalksfu/issues/14","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0192","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Usage of NonBondedForce.setIncludeDirectSpace(False)?","query_context":"Hi,\n\nI've created a very simple test case where I have 3 Coulomb forces:\n\n1) NonBondedForce with PME\n2) CustomNonbondedForce of a Coulomb potential with PeriodicCutoff\n3) NonBondedForce.setIncludeDirectSpace(False) with PME\n\nSo if I'm not mistaklen, Force1 should be the sum of Force2 and Force3\n\nForce1 and Force2 has values that I would except. Force3 seems completely off though.\n\nIs this a bug? or am I missing something?\n\nThanks!\n\ntest_includedirectspace.zip","known_context_document_ids":["gh_issue_2073429889"],"reference_answer":"Not exactly like that, but what you can do is have the NonbondedForce compute only the reciprocal space term. Do that by calling `setIncludeDirectSpace(False)`. Then you can use a CustomNonbondedForce to compute the direct space part, both Coulomb and LJ, in whatever way you want.","answer_document_id":"gh_comment_1850886150","silver_evidence_path":["gh_comment_1887762028","gh_issue_2036469035","gh_comment_1850886150"],"evidence_issue_ids":[2073429889,2036469035],"source_repo_name":"openmm/openmm","source_issue_id":2073429889,"source_issue_number":4387,"source_issue_url":"https://github.com/openmm/openmm/issues/4387","target_repo_name":"openmm/openmm","target_issue_id":2036469035,"target_issue_number":4349,"target_issue_url":"https://github.com/openmm/openmm/issues/4349","reference_anchor_document_id":"gh_comment_1887762028","reference_answer_author":"peastman","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.129,"anchor_target_overlap":0.1395,"target_answer_overlap":0.1579},"issue_created_at":"2024-01-10T01:33:04+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_2073429889","fragment_type":"issue_description","sequence":0,"text":"Usage of NonBondedForce.setIncludeDirectSpace(False)\nHi,\n\nI've created a very simple test case where I have 3 Coulomb forces:\n\n1) NonBondedForce with PME\n2) CustomNonbondedForce of a Coulomb potential with PeriodicCutoff\n3) NonBondedForce.setIncludeDirectSpace(False) with PME\n\nSo if I'm not mistaklen, Force1 should be the sum of Force2 and Force3\n\nForce1 and Force2 has values that I would except. Force3 seems completely off though.\n\nIs this a bug? or am I missing something?\n\nThanks!\n\ntest_includedirectspace.zip","author_login":"selimsami","author_association":"NONE","created_at":"2024-01-10T01:33:04+08:00","repo_name":"openmm/openmm","issue_id":2073429889,"issue_number":4387,"issue_url":"https://github.com/openmm/openmm/issues/4387","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1884187662","fragment_type":"issue_comment","sequence":1,"text":"The direct space part of PME is not the same as the total energy. It's scaled by $\\text{erfc}(\\alpha r)$. See the manual for details.","author_login":"peastman","author_association":"MEMBER","created_at":"2024-01-10T04:51:27+08:00","repo_name":"openmm/openmm","issue_id":2073429889,"issue_number":4387,"issue_url":"https://github.com/openmm/openmm/issues/4387","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1885410281","fragment_type":"issue_comment","sequence":2,"text":"Thanks Peter, I added the scaling to the direct space contribution Force2, but the Force3 is still extremely large and Force2 and Force3 do not sum up to Force1. What am I still missing? See the updated file.\n\ntest_includedirectspace2.zip\n\nAlso, I think you have small typo in the manual: Reciprocal space equation in 19.6.4 should be divided by k squared rather than m squared.","author_login":"selimsami","author_association":"NONE","created_at":"2024-01-10T18:36:52+08:00","repo_name":"openmm/openmm","issue_id":2073429889,"issue_number":4387,"issue_url":"https://github.com/openmm/openmm/issues/4387","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1885776862","fragment_type":"issue_comment","sequence":3,"text":"Yeah, this is kind of confusing. The difference comes from the exceptions. When you add an exception to a NonbondedForce, it means the interaction between a pair of particles should be computed with different parameters. But there's no way to do that in reciprocal space. PME spreads charge onto a grid and computes the interaction of the grid points with each other. There's no way to distinguish which bit of charge came from which particle. So it always includes all interactions, regardless of exceptions.\n\nTo compensate for that, we subtract them back off in real space. For most pairs of particles, we add $\\text{erfc}(\\alpha r)$ times the regular Coulomb energy. But for pairs that have exceptions, we instead *subtract* $\\text{erf}(\\alpha r)$ times the Coulomb energy, that being the energy that was incorrectly added in reciprocal space. You can use a CustomBondForce to do the same thing.\n\nBy the way, take a careful look at the API docs for `NonbondedForce.createExceptionsFromBonds()`. The second argument is the scale factor to apply to the Coulomb part of 1-4 interactions, *not* a number of bonds.","author_login":"peastman","author_association":"MEMBER","created_at":"2024-01-10T21:39:03+08:00","repo_name":"openmm/openmm","issue_id":2073429889,"issue_number":4387,"issue_url":"https://github.com/openmm/openmm/issues/4387","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1885997007","fragment_type":"issue_comment","sequence":4,"text":"Thanks, that makes sense, a bit fiddly though haha. \n\nHowever, I am still unable to get the right energy. Probably more things missing? \n\ntest_includedirectspace3.zip\n\nWouldn't it also make sense to do all these corrections automatically when someone requests NonBondedForce.setIncludeDirectSpace(False)?","author_login":"selimsami","author_association":"NONE","created_at":"2024-01-11T00:43:46+08:00","repo_name":"openmm/openmm","issue_id":2073429889,"issue_number":4387,"issue_url":"https://github.com/openmm/openmm/issues/4387","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1887740035","fragment_type":"issue_comment","sequence":5,"text":"You're almost there. You're just missing one exception in each molecule. Add this line\n\npython\n bond_force.addBond(h1.index, h2.index, [q_h*q_h])\n\nand then you get perfect agreement.\n\nPoint Electrostatics Combined -16738.596759002205 kJ/mol\nPoint Electrostatics SR -15283.173279924033 kJ/mol\nException correction 84096.7892801077 kJ/mol\nPoint Electrostatics LR -85552.21275918589 kJ/mol\n\ntotal combined: -16738.596759002205\ntotal split: -16738.59675900222","author_login":"peastman","author_association":"MEMBER","created_at":"2024-01-11T18:33:21+08:00","repo_name":"openmm/openmm","issue_id":2073429889,"issue_number":4387,"issue_url":"https://github.com/openmm/openmm/issues/4387","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1887743177","fragment_type":"issue_comment","sequence":6,"text":"The correction is computed in direct space, so if you say not to do direct space calculations, it doesn't get included. I know, it's confusing since it's a correction to the reciprocal space term and therefore conceptually seems like it should be part of the reciprocal space calculation. But that isn't where it's computed.","author_login":"peastman","author_association":"MEMBER","created_at":"2024-01-11T18:35:37+08:00","repo_name":"openmm/openmm","issue_id":2073429889,"issue_number":4387,"issue_url":"https://github.com/openmm/openmm/issues/4387","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1887762028","fragment_type":"issue_comment","sequence":7,"text":"Oh my bad, thanks for catching that.\n \n\nThat makes sense. And splitting the SR / LR Coulomb is special enough case that it's okay that it's involved to do it.\nBut considering my starting point was just adding a C6 PME term without C12 (#4349), I wonder if that should be somewhat easier (specially considering openmm already only uses C6 term for PME). \n\n(side note - actually now I'm thinking with respect to #4349 it might be better to have a normal LJ PME with both SR and LR with an arbitrary C12 and then just subtract the C12 term with a custom force)\n\nBut I don't really mind the additional steps - what I wonder is the computation cost. Do you think I'm accruing a lot more computational cost by for example splitting the Coulomb term this way with all the additional force terms? Or is that done efficiently inside openmm that it doesn't make much difference? Does it also depend on the platform?","author_login":"selimsami","author_association":"NONE","created_at":"2024-01-11T18:49:07+08:00","repo_name":"openmm/openmm","issue_id":2073429889,"issue_number":4387,"issue_url":"https://github.com/openmm/openmm/issues/4387","linked_issue_ids":[2036469035],"is_known_query_context":false},{"document_id":"gh_comment_1887798209","fragment_type":"issue_comment","sequence":8,"text":"That would certainly be the simplest way to implement it. The performance will be a bit worse because you're paying the cost of computing repulsion three times: once to add the C12 term, once to subtract it again, and once to compute whatever form you actually want to use.\n\nGenerally speaking, the cost of a CustomNonbondedForce is very similar to NonbondedForce, assuming they compute exactly the same function. There's one extra twist though, if you really want to get down into the details and get the fastest possible performance. erfc() is an expensive function to compute. When working in single precision, we instead use an approximation that's almost as accurate but a lot faster:\n\n URL","author_login":"peastman","author_association":"MEMBER","created_at":"2024-01-11T19:13:41+08:00","repo_name":"openmm/openmm","issue_id":2073429889,"issue_number":4387,"issue_url":"https://github.com/openmm/openmm/issues/4387","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2036469035","fragment_type":"issue_description","sequence":0,"text":"Supplying NonBondedForce LJ parameters where C12 = 0\nHi,\n\nI would like to use NonBondedForce for Coulomb and C6, because I'd like to use LJPME for long-range interactions.\n\nHowever, I have a completely different functional form instead of C12 to account for the repulsion, for which I use CustomNonBondedForce.\n\nMy question is - can I somehow supply LJ parameters so that C12 is equal to 0 while C6 is not? \n\nIf not, what alternative you would have for solving my case?","author_login":"selimsami","author_association":"NONE","created_at":"2023-12-11T20:25:37+08:00","repo_name":"openmm/openmm","issue_id":2036469035,"issue_number":4349,"issue_url":"https://github.com/openmm/openmm/issues/4349","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1850886150","fragment_type":"issue_comment","sequence":1,"text":"Not exactly like that, but what you can do is have the NonbondedForce compute only the reciprocal space term. Do that by calling `setIncludeDirectSpace(False)`. Then you can use a CustomNonbondedForce to compute the direct space part, both Coulomb and LJ, in whatever way you want.","author_login":"peastman","author_association":"MEMBER","created_at":"2023-12-11T21:05:10+08:00","repo_name":"openmm/openmm","issue_id":2036469035,"issue_number":4349,"issue_url":"https://github.com/openmm/openmm/issues/4349","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0196","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"[CoE Starter Kit - BUG] Audit Component Issue?","query_context":"### Does this bug already exist in our backlog?\n\n- [X] I have checked and confirm this is a new bug.\n\n### Describe the issue\n\nHI,\n\nwe are facing an issue in Audit component and would like to reinstall only audit component , can you please help me on this \n\n### Expected Behavior\n\nPost upgrade also , Flow is still show the old connectors in the flow\n\nThe flow is not upgraded and didn't change the connectors\n\n### What solution are you experiencing the issue with?\n\nAudit Log\n\n### What solution version are you using?\n\n3.3\n\n### What app or flow are you having the issue with?\n\nAdmin | Sync Audit Logs\n\n### What method are you using to get inventory and telemetry?\n\nCloud flows\n\n### Steps To Reproduce\n\nPost upgrade also , Flow is still show the old connectors in the flow\n\nThe flow is not upgraded and didn't change the connectors\n\n### Anything else?\n\nPost upgrade also , Flow is still show the old connectors in the flow\n\nThe flow is not upgraded and didn't change the connectors","known_context_document_ids":["gh_issue_1672394617"],"reference_answer":"You will need to hire someone that can sit with you to fix your situation then. Your environment is not in a state that I can assist in debugging remotely. \n\nThere are partners that specialize specifically in CoE Starter Kit, so you could reach out to them for assistance. You can find some via you can find them via AppSource\n\nAs a reminder, although the underlying features and components used to build the kit (such as Dataverse, admin APIs, and connectors) are fully supported, the kit itself represents sample implementations of these features. While we do our best to help people use them as is, they are not a supported feature.","answer_document_id":"gh_comment_1501903104","silver_evidence_path":["gh_comment_1512858519","gh_issue_1654114193","gh_comment_1501903104"],"evidence_issue_ids":[1672394617,1654114193],"source_repo_name":"microsoft/coe-starter-kit","source_issue_id":1672394617,"source_issue_number":5314,"source_issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5314","target_repo_name":"microsoft/coe-starter-kit","target_issue_id":1654114193,"target_issue_number":5191,"target_issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5191","reference_anchor_document_id":"gh_comment_1512858519","reference_answer_author":"Jenefer-Monroe","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1373,"anchor_target_overlap":0.8,"target_answer_overlap":0.1087},"issue_created_at":"2023-04-18T05:48:59+08:00","valid_comment_count":23,"fragments":[{"document_id":"gh_issue_1672394617","fragment_type":"issue_description","sequence":0,"text":"[CoE Starter Kit - BUG] Audit Component Issue\n### Does this bug already exist in our backlog?\n\n- [X] I have checked and confirm this is a new bug.\n\n### Describe the issue\n\nHI,\n\nwe are facing an issue in Audit component and would like to reinstall only audit component , can you please help me on this \n\n### Expected Behavior\n\nPost upgrade also , Flow is still show the old connectors in the flow\n\nThe flow is not upgraded and didn't change the connectors\n\n### What solution are you experiencing the issue with?\n\nAudit Log\n\n### What solution version are you using?\n\n3.3\n\n### What app or flow are you having the issue with?\n\nAdmin | Sync Audit Logs\n\n### What method are you using to get inventory and telemetry?\n\nCloud flows\n\n### Steps To Reproduce\n\nPost upgrade also , Flow is still show the old connectors in the flow\n\nThe flow is not upgraded and didn't change the connectors\n\n### Anything else?\n\nPost upgrade also , Flow is still show the old connectors in the flow\n\nThe flow is not upgraded and didn't change the connectors","author_login":"ApoorvaKantale","author_association":"NONE","created_at":"2023-04-18T05:48:59+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1672394617,"issue_number":5314,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5314","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1512677624","fragment_type":"issue_comment","sequence":1,"text":"This typically happens if the flow has unmanaged layers. If you open the CoE Admin Command Center app and navigate to CoE Flows, you can filter by area / search for the flow and it will show you an icon here if the flow has unmanaged layers - you can then click on \"Remove solution layers\" to remove the layers.\nimage","author_login":"manuelap-msft","author_association":"CONTRIBUTOR","created_at":"2023-04-18T08:31:23+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1672394617,"issue_number":5314,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1512720291","fragment_type":"issue_comment","sequence":2,"text":"I have removed the unmanaged layer and also upgrade the audit log component. the flows is still showing the old connectors \nimage","author_login":"ApoorvaKantale","author_association":"NONE","created_at":"2023-04-18T09:00:36+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1672394617,"issue_number":5314,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1512750929","fragment_type":"issue_comment","sequence":3,"text":"I'm not sure what you mean by showing old connectors? The screenshot is what the current version of the flow looks like.","author_login":"manuelap-msft","author_association":"CONTRIBUTOR","created_at":"2023-04-18T09:21:20+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1672394617,"issue_number":5314,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1512797004","fragment_type":"issue_comment","sequence":4,"text":"Actually when we upgrade the Audit log to version 3.3 , the Admin | Sync Audit Logs should look like \n\nimage\n\nBut when I have upgrade the version to 3.3 my flow looks like \n\nimage","author_login":"ApoorvaKantale","author_association":"NONE","created_at":"2023-04-18T10:01:50+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1672394617,"issue_number":5314,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1512806171","fragment_type":"issue_comment","sequence":5,"text":"You're right, I missed that. \n\nPlease share with me what you see when you open the solution layers of this flow\nimage\n\nPlease share with me what you see when you select the Solutions tab in the environment - you can filter this to only show solutions that start with Center of Excellence but please don't clip it and make sure the screenshot shows us all the Center of Excellence solutions in the environment including the version number\nimage","author_login":"manuelap-msft","author_association":"CONTRIBUTOR","created_at":"2023-04-18T10:07:47+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1672394617,"issue_number":5314,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1512858519","fragment_type":"issue_comment","sequence":6,"text":"Hello,\n\nit looks like you raised this with us in the past, and we informed you we were unable to assist any further due to complexity of your issues. Here's the thread URL \n\nYou will need to hire someone that can sit with you to fix your situation then. Your environment is not in a state that we can assist in debugging remotely.\n\nThere are partners that specialize specifically in CoE Starter Kit, so you could reach out to them for assistance. You can find some via you can find them via AppSource\n\nAs a reminder, although the underlying features and components used to build the kit (such as Dataverse, admin APIs, and connectors) are fully supported, the kit itself represents sample implementations of these features. While we do our best to help people use them as is, the kit itself is not a supported feature.","author_login":"manuelap-msft","author_association":"CONTRIBUTOR","created_at":"2023-04-18T10:45:43+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1672394617,"issue_number":5314,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5314","linked_issue_ids":[1654114193],"is_known_query_context":false},{"document_id":"gh_comment_1514399687","fragment_type":"issue_comment","sequence":7,"text":"But my question is different, I will not be able to take help from Appsource.\n\nI just need a one help, is it possible to delete the existing audit component and install new Audit component","author_login":"ApoorvaKantale","author_association":"NONE","created_at":"2023-04-19T09:14:23+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1672394617,"issue_number":5314,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1654114193","fragment_type":"issue_description","sequence":0,"text":"[CoE Starter Kit - BUG] Admin | Sync Audit Logs: Error from token exchange: Permission denied due to missing connection ACL: Connection\n### Describe the issue\n\nHi,\n\nI have upgraded Audit log component, Now when I turn on the flow and run. There is an error being throwed. \nError: Error from token exchange: Permission denied due to missing connection ACL: Connection URL version -9223372036854775808, connection=unitedstates-002/commondataservice/shared-commondataser-872ccec3-0baf-4ee2-8c29-bfca1c1a89c0\n\n\"body\": {\n \"status\": 403,\n \"source\": \" URL \n \"message\": \"Error from token exchange: Permission denied due to missing connection ACL: Connection URL version -9223372036854775808, connection=unitedstates-002/commondataservice/shared-commondataser-872ccec3-0baf-4ee2-8c29-bfca1c1a89c0\"\n }\n}\n\nCan you please help me to resolve this.\n\n### Expected Behavior\n\nThe flow should run successful and even the child flow should run successfully.\n\n### What solution are you experiencing the issue with?\n\nAudit Log\n\n### What solution version are you using?\n\n3.3\n\n### What app or flow are you having the issue with?\n\nAdmin | Sync Audit Logs\n\n### Steps To Reproduce\n\nPost upgraded.\nTurn on the Admin | Sync Audit Logs flow\nRun the flow\n\n### Anything else?\n\n_No response_","author_login":"ApoorvaKantale","author_association":"NONE","created_at":"2023-04-04T15:27:57+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1654114193,"issue_number":5191,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1496211934","fragment_type":"issue_comment","sequence":1,"text":"Hello. Connections to custom connectors get broken on solution upgrade. It sounds like you knew that and tried to fix though. \n\nIf the normal fix up steps did not resolve, then you likely ended up with a bad connection, perhaps due to the wrong identity provider being selected as in issue 4808\n\nIf that occurs please try the steps outlined in issue 4961\n\nSorry for the complexity here!","author_login":"Jenefer-Monroe","author_association":"COLLABORATOR","created_at":"2023-04-04T15:47:53+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1654114193,"issue_number":5191,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1496363363","fragment_type":"issue_comment","sequence":2,"text":"ListDefns-TenantIDEnvironmentVariable\nListDefns-TenantIDEnvironmentVariable\n\n{\n \"statusCode\": 403,\n \"headers\": {\n \"x-ms-failure-cause\": \"apihub-token-exchange\",\n \"x-ms-apihub-obo\": \"false\",\n \"x-ms-apihub-cached-response\": \"true\",\n \"Date\": \"Tue, 04 Apr 2023 17:45:08 GMT\",\n \"Content-Length\": \"523\",\n \"Content-Type\": \"application/json\"\n },\n \"body\": {\n \"status\": 403,\n \"source\": \" URL \n \"message\": \"Error from token exchange: Permission denied due to missing connection ACL: Connection URL version -9223372036854775808, connection=unitedstates-002/commondataservice/shared-commondataser-872ccec3-0baf-4ee2-8c29-bfca1c1a89c0\"\n }\n}","author_login":"ApoorvaKantale","author_association":"NONE","created_at":"2023-04-04T17:46:42+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1654114193,"issue_number":5191,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1496485494","fragment_type":"issue_comment","sequence":3,"text":"Hello, I'm afraid you appear to be on a very old version of the audit log solution or you have unmanaged layers preventing you from seeing our changes. We no longer fetch env vars that way. \n\nCan you please share a screenshot with what solutions you have installed in this environment? Be sure to expand the indicated columns so that we can see full names\nimage","author_login":"Jenefer-Monroe","author_association":"COLLABORATOR","created_at":"2023-04-04T19:26:42+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1654114193,"issue_number":5191,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1497438107","fragment_type":"issue_comment","sequence":4,"text":"Please remove the unmanaged layer manually instead of through our tooling for both this flow and the child (in case it has one too):\nimage\nimage","author_login":"Jenefer-Monroe","author_association":"COLLABORATOR","created_at":"2023-04-05T12:54:02+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1654114193,"issue_number":5191,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1497439549","fragment_type":"issue_comment","sequence":5,"text":"If you are on 3.3 and dont have unmanaged layers, then that call should not be present. It shoudl look like this\nimage","author_login":"Jenefer-Monroe","author_association":"COLLABORATOR","created_at":"2023-04-05T12:55:08+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1654114193,"issue_number":5191,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1497757816","fragment_type":"issue_comment","sequence":6,"text":"I have followed the same steps to remove unmanaged layer. Unmanaged layers are removed.\nBut still i see old model of flow \n\nimage\nimage\nimage","author_login":"ApoorvaKantale","author_association":"NONE","created_at":"2023-04-05T16:07:55+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1654114193,"issue_number":5191,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1497758573","fragment_type":"issue_comment","sequence":7,"text":"Please help me to resolve this, I need to fix this issue on priority","author_login":"ApoorvaKantale","author_association":"NONE","created_at":"2023-04-05T16:08:24+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1654114193,"issue_number":5191,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1497778696","fragment_type":"issue_comment","sequence":8,"text":"I'm afraid I don't know how to assist as if you've really removed the unmanaged layer, and really have 3.3 installed, then you would not see the old bits.\nCan you share this screenshot showing it not having unmanaged layers? \nimage\nimage","author_login":"Jenefer-Monroe","author_association":"COLLABORATOR","created_at":"2023-04-05T16:23:29+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1654114193,"issue_number":5191,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1497792527","fragment_type":"issue_comment","sequence":9,"text":"ok I've never seen that, where the core components are a layer on the flow. So I have no idea how you got there. \nIt should look like this\nimage","author_login":"Jenefer-Monroe","author_association":"COLLABORATOR","created_at":"2023-04-05T16:34:29+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1654114193,"issue_number":5191,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1497793708","fragment_type":"issue_comment","sequence":10,"text":"oh i thikn you didnt select the flow. You need to select the flow\nimage","author_login":"Jenefer-Monroe","author_association":"COLLABORATOR","created_at":"2023-04-05T16:35:28+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1654114193,"issue_number":5191,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1497801673","fragment_type":"issue_comment","sequence":11,"text":"ok from this, and the other bugs in your list, your environment is just in a broken and unknown state. I'm afraid we cannot help you get out of this. You should start from scratch in a clean environment.","author_login":"Jenefer-Monroe","author_association":"COLLABORATOR","created_at":"2023-04-05T16:40:30+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1654114193,"issue_number":5191,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1497805523","fragment_type":"issue_comment","sequence":12,"text":"All other flows in core are working fine.\n\nCan help me to fix Audit component","author_login":"ApoorvaKantale","author_association":"NONE","created_at":"2023-04-05T16:42:18+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1654114193,"issue_number":5191,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1497824285","fragment_type":"issue_comment","sequence":13,"text":"I'm afraid I cannot. From looking at this and through all your bugs you are just in a completely unknown state. You will need someone that can put their hands on it in order to resolve this, or you need to start from scratch. \n\nIf you chose the former, there are partners that specialize specifically in CoE Starter Kit, so you could reach out to them for assistance. You can find some via you can find them via AppSource\n\nAs a reminder, although the underlying features and components used to build the kit (such as Dataverse, admin APIs, and connectors) are fully supported, the kit itself represents sample implementations of these features. While we do our best to help people use them as is, they are not a supported feature.","author_login":"Jenefer-Monroe","author_association":"COLLABORATOR","created_at":"2023-04-05T16:54:24+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1654114193,"issue_number":5191,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1499016416","fragment_type":"issue_comment","sequence":14,"text":"Your options are to start from scratch in a new environment or find someone that can sit with you (internally or by hiring a partner)","author_login":"Jenefer-Monroe","author_association":"COLLABORATOR","created_at":"2023-04-06T12:50:07+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1654114193,"issue_number":5191,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1501829931","fragment_type":"issue_comment","sequence":15,"text":"I have to fix in this environment itself, We cannot create new environment","author_login":"ApoorvaKantale","author_association":"NONE","created_at":"2023-04-10T13:45:46+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1654114193,"issue_number":5191,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1501903104","fragment_type":"issue_comment","sequence":16,"text":"You will need to hire someone that can sit with you to fix your situation then. Your environment is not in a state that I can assist in debugging remotely. \n\nThere are partners that specialize specifically in CoE Starter Kit, so you could reach out to them for assistance. You can find some via you can find them via AppSource\n\nAs a reminder, although the underlying features and components used to build the kit (such as Dataverse, admin APIs, and connectors) are fully supported, the kit itself represents sample implementations of these features. While we do our best to help people use them as is, they are not a supported feature.","author_login":"Jenefer-Monroe","author_association":"COLLABORATOR","created_at":"2023-04-10T14:44:20+08:00","repo_name":"microsoft/coe-starter-kit","issue_id":1654114193,"issue_number":5191,"issue_url":"https://github.com/microsoft/coe-starter-kit/issues/5191","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0198","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"JXL->JXL processing (to remove alpha channel) drops color profile?","query_context":"### ImageMagick version\n\n7.1.1-44\n\n### Operating system\n\nLinux\n\n### Operating system, version and so on\n\nFedora 41 x86_64\n\n### Description\n\nThe Fedora 42 background images are going to be distributed in JXL format instead of the traditional PNG. Due to the limitations of the GNOME background system's timed-transition image blending, it's necessary that background images be stripped of their alpha channel before installation. We've been accomplishing that with a `magick -alpha off` command, which works fine on PNG images.\n\nIt works fairly well on JXL images as well (with an added `-quality 100`), but the output image no longer carries the same color profile as the input image.\n\n### Steps to Reproduce\n\n## 1. Unzip and examine the original file:\n\nbash\n$ unzip f42-01-day.zip\nArchive: f42-01-day.zip\n inflating: f42-01-day.jxl \n\n$ identify -verbose f42-01-day.jxl\nImage:\n Filename: f42-01-day.jxl\n Permissions: rw-r--r--\n Format: JXL (JPEG XL (ISO/IEC 18181))\n Mime type: image/jxl\n Class: DirectClass\n Geometry: 4032x3024+0+0\n Units: Undefined\n Colorspace: sRGB\n Type: TrueColorAlpha\n Base type: Undefined\n Endianness: Undefined\n Depth: 8-bit\n Channels: 4.0\n Channel depth:\n Red: 8-bit\n Green: 8-bit\n Blue: 8-bit\n Alpha: 1-bit\n Channel statistics:\n Pixels: 12192768\n Red:\n min: 12 (0.0470588)\n max: 214 (0.839216)\n mean: 126.731 (0.496982)\n median: 133 (0.521569)\n standard deviation: 43.3644 (0.170056)\n kurtosis: -0.324868\n skewness: 0.0404497\n entropy: 0.749915\n Green:\n min: 5 (0.0196078)\n max: 224 (0.878431)\n mean: 137.296 (0.538416)\n median: 142 (0.556863)\n standard deviation: 47.5222 (0.186362)\n kurtosis: -0.608794\n skewness: -0.11526\n entropy: 0.76154\n Blue:\n min: 5 (0.0196078)\n max: 221 (0.866667)\n mean: 105.595 (0.414096)\n median: 90 (0.352941)\n standard deviation: 54.5139 (0.21378)\n kurtosis: -0.439243\n skewness: 0.766023\n entropy: 0.752578\n Alpha:\n min: 255 (1)\n max: 255 (1)\n mean: 255 (1)\n median: 255 (1)\n standard deviation: 0 (0)\n kurtosis: 0\n skewness: 0\n entropy: 0\n Image statistics:\n Overall:\n min: 5 (0.0196078)\n max: 255 (1)\n mean: 156.155 (0.612374)\n median: 155 (0.607843)\n standard deviation: 36.3501 (0.14255)\n kurtosis: -0.343226\n skewness: 0.172803\n entropy: 0.566008\n Rendering intent: Perceptual\n Gamma: 0.454545\n Chromaticity:\n red primary: (0.64,0.33,0.03)\n green primary: (0.3,0.6,0.1)\n blue primary: (0.15,0.06,0.79)\n white point: (0.3127,0.329,0.3583)\n Matte color: grey74\n Background color: white\n Border color: srgb(223,223,223)\n Transparent color: black\n Interlace: None\n Intensity: Undefined\n Compose: Over\n Page geometry: 4032x3024+0+0\n Dispose: Undefined\n Iterations: 0\n Compression: Undefined\n Orientation: TopLeft\n Profiles:\n Profile-icc: 9080 bytes\n Properties:\n date:create: 2025-03-11T23:48:07+00:00\n date:modify: 2025-03-11T08:05:06+00:00\n date:timestamp: 2025-03-11T23:48:55+00:00\n icc:copyright: Copyright 2015, Elle Stone (website: URL email: ellestone@ninedegreesbelow.com). This ICC profile is licensed under a Creative Commons Attribution-ShareAlike 3.0 Unported License ( URL \n icc:description: sRGB-elle-V2-srgbtrc.icc\n mime:type: image/jxl\n signature: 6a090391cc3d126be6a5807503aeef4cfddce0c527120cbf76252cdaa7e4ddbd\n Artifacts:\n verbose: true\n Tainted: False\n Filesize: 1.93684MiB\n Number pixels: 12.1928M\n Pixel cache type: Memory\n Pixels per second: 13.1612MP\n User time: 2.440u\n Elapsed time: 0:01.926\n Version: ImageMagick 7.1.1-44 Q16-HDRI x86_64 22688 URL \n\nThe original image contains a 9k color profile, `sRGB-elle-V2-srgbtrc.icc`.\n\n## 2. Process the image using ImageMagick to remove alpha channel\n\nbash\n$ magick f42-01-day.jxl -quality 100 -alpha off f42-01-day_noalpha.jxl\n\n## 3. Examine the output file\n\nbash\n$ identify -verbose f42-01-day_noalpha.jxl\nImage:\n Filename: f42-01-day_noalpha.jxl\n Permissions: rw-r--r--\n Format: JXL (JPEG XL (ISO/IEC 18181))\n Mime type: image/jxl\n Class: DirectClass\n Geometry: 4032x3024+0+0\n Units: Undefined\n Colorspace: sRGB\n Type: TrueColor\n Base type: Undefined\n Endianness: Undefined\n Depth: 8-bit\n Channels: 3.0\n Channel depth:\n Red: 8-bit\n Green: 8-bit\n Blue: 8-bit\n Channel statistics:\n Pixels: 12192768\n Red:\n min: 12 (0.0470588)\n max: 214 (0.839216)\n mean: 126.731 (0.496982)\n median: 133 (0.521569)\n standard deviation: 43.3644 (0.170056)\n kurtosis: -0.324868\n skewness: 0.0404497\n entropy: 0.749915\n Green:\n min: 5 (0.0196078)\n max: 224 (0.878431)\n mean: 137.296 (0.538416)\n median: 142 (0.556863)\n standard deviation: 47.5222 (0.186362)\n kurtosis: -0.608794\n skewness: -0.11526\n entropy: 0.76154\n Blue:\n min: 5 (0.0196078)\n max: 221 (0.866667)\n mean: 105.595 (0.414096)\n median: 90 (0.352941)\n standard deviation: 54.5139 (0.21378)\n kurtosis: -0.439243\n skewness: 0.766023\n entropy: 0.752578\n Image statistics:\n Overall:\n min: 5 (0.0196078)\n max: 224 (0.878431)\n mean: 123.207 (0.483165)\n median: 121.667 (0.477124)\n standard deviation: 48.4668 (0.190066)\n kurtosis: -0.457635\n skewness: 0.230404\n entropy: 0.754678\n Rendering intent: Relative\n Gamma: 0.454545\n Chromaticity:\n red primary: (0.64,0.33,0.03)\n green primary: (0.3,0.6,0.1)\n blue primary: (0.15,0.06,0.79)\n white point: (0.3127,0.329,0.3583)\n Matte color: grey74\n Background color: white\n Border color: srgb(223,223,223)\n Transparent color: black\n Interlace: None\n Intensity: Undefined\n Compose: Over\n Page geometry: 4032x3024+0+0\n Dispose: Undefined\n Iterations: 0\n Compression: Undefined\n Orientation: TopLeft\n Profiles:\n Profile-icc: 536 bytes\n Properties:\n date:create: 2025-03-11T23:50:54+00:00\n date:modify: 2025-03-11T23:50:54+00:00\n date:timestamp: 2025-03-11T23:51:34+00:00\n icc:copyright: CC0\n icc:description: RGB_D65_SRG_Rel_SRG\n mime:type: image/jxl\n signature: bb19320a637ffbb342d9fcf381ea825659dbf8c10ac02fd768311252f2a68c33\n Artifacts:\n verbose: true\n Tainted: False\n Filesize: 1.9296MiB\n Number pixels: 12.1928M\n Pixel cache type: Memory\n Pixels per second: 14.5702MP\n User time: 2.270u\n Elapsed time: 0:01.836\n Version: ImageMagick 7.1.1-44 Q16-HDRI x86_64 22688 URL \n\nThe image no longer has an alpha channel (that's good!), but has lost the ICC profile and other metadata.\n\n## Delegate information:\n\nbash\n$ magick -list format|grep jxl\n JXL* JXL rw+ JPEG XL (ISO/IEC 18181) (libjxl 0.10.4)\n\n### Images\n\nHere's the first of the upcoming Fedora 42 background images, in source JXL format (with color profile): \n\nf42-01-day.zip","known_context_document_ids":["gh_issue_2912159490"],"reference_answer":"The `-x` flag in cjxl is only used for inputs that can't have color profiles embedded (PPM, ect), otherwise it's taken from the original file. \nJPEG XL can use Color Enums instead of ICC profiles for common color spaces (sRGB, P3, Rec2020, ect). Usually this is only used for lossy, but it seems ImageMagick is incorrectly using Enums for lossless too. This has little to no impact visually, but it does remove the original ICC profile.\n\nUsing cjxl to recompress the source file retains the ICC in Lossless, and uses the sRGB Enum when set to lossy, confirming it as an ImageMagick bug. @sboukortt might know what area needs to be fixed though, likely just a missing flag.","answer_document_id":"gh_comment_2760646384","silver_evidence_path":["gh_comment_2759932405","gh_issue_2954682159","gh_comment_2760646384"],"evidence_issue_ids":[2912159490,2954682159],"source_repo_name":"ImageMagick/ImageMagick","source_issue_id":2912159490,"source_issue_number":8022,"source_issue_url":"https://github.com/ImageMagick/ImageMagick/issues/8022","target_repo_name":"libjxl/libjxl","target_issue_id":2954682159,"target_issue_number":4164,"target_issue_url":"https://github.com/libjxl/libjxl/issues/4164","reference_anchor_document_id":"gh_comment_2759932405","reference_answer_author":"jonnyawsom3","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2308,"anchor_target_overlap":0.3462,"target_answer_overlap":0.2353},"issue_created_at":"2025-03-11T23:53:31+08:00","valid_comment_count":16,"fragments":[{"document_id":"gh_issue_2912159490","fragment_type":"issue_description","sequence":0,"text":"JXL->JXL processing (to remove alpha channel) drops color profile\n### ImageMagick version\n\n7.1.1-44\n\n### Operating system\n\nLinux\n\n### Operating system, version and so on\n\nFedora 41 x86_64\n\n### Description\n\nThe Fedora 42 background images are going to be distributed in JXL format instead of the traditional PNG. Due to the limitations of the GNOME background system's timed-transition image blending, it's necessary that background images be stripped of their alpha channel before installation. We've been accomplishing that with a `magick -alpha off` command, which works fine on PNG images.\n\nIt works fairly well on JXL images as well (with an added `-quality 100`), but the output image no longer carries the same color profile as the input image.\n\n### Steps to Reproduce\n\n## 1. Unzip and examine the original file:\n\nbash\n$ unzip f42-01-day.zip\nArchive: f42-01-day.zip\n inflating: f42-01-day.jxl \n\n$ identify -verbose f42-01-day.jxl\nImage:\n Filename: f42-01-day.jxl\n Permissions: rw-r--r--\n Format: JXL (JPEG XL (ISO/IEC 18181))\n Mime type: image/jxl\n Class: DirectClass\n Geometry: 4032x3024+0+0\n Units: Undefined\n Colorspace: sRGB\n Type: TrueColorAlpha\n Base type: Undefined\n Endianness: Undefined\n Depth: 8-bit\n Channels: 4.0\n Channel depth:\n Red: 8-bit\n Green: 8-bit\n Blue: 8-bit\n Alpha: 1-bit\n Channel statistics:\n Pixels: 12192768\n Red:\n min: 12 (0.0470588)\n max: 214 (0.839216)\n mean: 126.731 (0.496982)\n median: 133 (0.521569)\n standard deviation: 43.3644 (0.170056)\n kurtosis: -0.324868\n skewness: 0.0404497\n entropy: 0.749915\n Green:\n min: 5 (0.0196078)\n max: 224 (0.878431)\n mean: 137.296 (0.538416)\n median: 142 (0.556863)\n standard deviation: 47.5222 (0.186362)\n kurtosis: -0.608794\n skewness: -0.11526\n entropy: 0.76154\n Blue:\n min: 5 (0.0196078)\n max: 221 (0.866667)\n mean: 105.595 (0.414096)\n median: 90 (0.352941)\n standard deviation: 54.5139 (0.21378)\n kurtosis: -0.439243\n skewness: 0.766023\n entropy: 0.752578\n Alpha:\n min: 255 (1)\n max: 255 (1)\n mean: 255 (1)\n median: 255 (1)\n standard deviation: 0 (0)\n kurtosis: 0\n skewness: 0\n entropy: 0\n Image statistics:\n Overall:\n min: 5 (0.0196078)\n max: 255 (1)\n mean: 156.155 (0.612374)\n median: 155 (0.607843)\n standard deviation: 36.3501 (0.14255)\n kurtosis: -0.343226\n skewness: 0.172803\n entropy: 0.566008\n Rendering intent: Perceptual\n Gamma: 0.454545\n Chromaticity:\n red primary: (0.64,0.33,0.03)\n green primary: (0.3,0.6,0.1)\n blue primary: (0.15,0.06,0.79)\n white point: (0.3127,0.329,0.3583)\n Matte color: grey74\n Background color: white\n Border color: srgb(223,223,223)\n Transparent color: black\n Interlace: None\n Intensity: Undefined\n Compose: Over\n Page geometry: 4032x3024+0+0\n Dispose: Undefined\n Iterations: 0\n Compression: Undefined\n Orientation: TopLeft\n Profiles:\n Profile-icc: 9080 bytes\n Properties:\n date:create: 2025-03-11T23:48:07+00:00\n date:modify: 2025-03-11T08:05:06+00:00\n date:timestamp: 2025-03-11T23:48:55+00:00\n icc:copyright: Copyright 2015, Elle Stone (website: URL email: ellestone@ninedegreesbelow.com). This ICC profile is licensed under a Creative Commons Attribution-ShareAlike 3.0 Unported License ( URL \n icc:description: sRGB-elle-V2-srgbtrc.icc\n mime:type: image/jxl\n signature: 6a090391cc3d126be6a5807503aeef4cfddce0c527120cbf76252cdaa7e4ddbd\n Artifacts:\n verbose: true\n Tainted: False\n Filesize: 1.93684MiB\n Number pixels: 12.1928M\n Pixel cache type: Memory\n Pixels per second: 13.1612MP\n User time: 2.440u\n Elapsed time: 0:01.926\n Version: ImageMagick 7.1.1-44 Q16-HDRI x86_64 22688 URL \n\nThe original image contains a 9k color profile, `sRGB-elle-V2-srgbtrc.icc`.\n\n## 2. Process the image using ImageMagick to remove alpha channel\n\nbash\n$ magick f42-01-day.jxl -quality 100 -alpha off f42-01-day_noalpha.jxl\n\n## 3. Examine the output file\n\nbash\n$ identify -verbose f42-01-day_noalpha.jxl\nImage:\n Filename: f42-01-day_noalpha.jxl\n Permissions: rw-r--r--\n Format: JXL (JPEG XL (ISO/IEC 18181))\n Mime type: image/jxl\n Class: DirectClass\n Geometry: 4032x3024+0+0\n Units: Undefined\n Colorspace: sRGB\n Type: TrueColor\n Base type: Undefined\n Endianness: Undefined\n Depth: 8-bit\n Channels: 3.0\n Channel depth:\n Red: 8-bit\n Green: 8-bit\n Blue: 8-bit\n Channel statistics:\n Pixels: 12192768\n Red:\n min: 12 (0.0470588)\n max: 214 (0.839216)\n mean: 126.731 (0.496982)\n median: 133 (0.521569)\n standard deviation: 43.3644 (0.170056)\n kurtosis: -0.324868\n skewness: 0.0404497\n entropy: 0.749915\n Green:\n min: 5 (0.0196078)\n max: 224 (0.878431)\n mean: 137.296 (0.538416)\n median: 142 (0.556863)\n standard deviation: 47.5222 (0.186362)\n kurtosis: -0.608794\n skewness: -0.11526\n entropy: 0.76154\n Blue:\n min: 5 (0.0196078)\n max: 221 (0.866667)\n mean: 105.595 (0.414096)\n median: 90 (0.352941)\n standard deviation: 54.5139 (0.21378)\n kurtosis: -0.439243\n skewness: 0.766023\n entropy: 0.752578\n Image statistics:\n Overall:\n min: 5 (0.0196078)\n max: 224 (0.878431)\n mean: 123.207 (0.483165)\n median: 121.667 (0.477124)\n standard deviation: 48.4668 (0.190066)\n kurtosis: -0.457635\n skewness: 0.230404\n entropy: 0.754678\n Rendering intent: Relative\n Gamma: 0.454545\n Chromaticity:\n red primary: (0.64,0.33,0.03)\n green primary: (0.3,0.6,0.1)\n blue primary: (0.15,0.06,0.79)\n white point: (0.3127,0.329,0.3583)\n Matte color: grey74\n Background color: white\n Border color: srgb(223,223,223)\n Transparent color: black\n Interlace: None\n Intensity: Undefined\n Compose: Over\n Page geometry: 4032x3024+0+0\n Dispose: Undefined\n Iterations: 0\n Compression: Undefined\n Orientation: TopLeft\n Profiles:\n Profile-icc: 536 bytes\n Properties:\n date:create: 2025-03-11T23:50:54+00:00\n date:modify: 2025-03-11T23:50:54+00:00\n date:timestamp: 2025-03-11T23:51:34+00:00\n icc:copyright: CC0\n icc:description: RGB_D65_SRG_Rel_SRG\n mime:type: image/jxl\n signature: bb19320a637ffbb342d9fcf381ea825659dbf8c10ac02fd768311252f2a68c33\n Artifacts:\n verbose: true\n Tainted: False\n Filesize: 1.9296MiB\n Number pixels: 12.1928M\n Pixel cache type: Memory\n Pixels per second: 14.5702MP\n User time: 2.270u\n Elapsed time: 0:01.836\n Version: ImageMagick 7.1.1-44 Q16-HDRI x86_64 22688 URL \n\nThe image no longer has an alpha channel (that's good!), but has lost the ICC profile and other metadata.\n\n## Delegate information:\n\nbash\n$ magick -list format|grep jxl\n JXL* JXL rw+ JPEG XL (ISO/IEC 18181) (libjxl 0.10.4)\n\n### Images\n\nHere's the first of the upcoming Fedora 42 background images, in source JXL format (with color profile): \n\nf42-01-day.zip","author_login":"ferdnyc","author_association":"CONTRIBUTOR","created_at":"2025-03-11T23:53:31+08:00","repo_name":"ImageMagick/ImageMagick","issue_id":2912159490,"issue_number":8022,"issue_url":"https://github.com/ImageMagick/ImageMagick/issues/8022","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2715989183","fragment_type":"issue_comment","sequence":1,"text":"Note: I tried extracting the color profile to an external file and reapplying it during processing with `-profile`, but unfortunately `exiftool` can't find the profile in the JXL file, and `exiv2` doesn't even _recognize_ the JXL file as a valid image, so I got nowhere with that.","author_login":"ferdnyc","author_association":"CONTRIBUTOR","created_at":"2025-03-11T23:55:17+08:00","repo_name":"ImageMagick/ImageMagick","issue_id":2912159490,"issue_number":8022,"issue_url":"https://github.com/ImageMagick/ImageMagick/issues/8022","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2716014050","fragment_type":"issue_comment","sequence":2,"text":"I see no color changes with these two commands on IM 7.1.1.45 Mac OSX Ventura and libjxl 0.11.1. Please post your exact command line and your version of libjxl (see magick -list format)\n\nmagick f42-01-day.jxl -alpha off f42-01-day.png\nmagick f42-01-day.jxl -alpha off f42-01-day2.jxl","author_login":"fmw42","author_association":"NONE","created_at":"2025-03-12T00:12:05+08:00","repo_name":"ImageMagick/ImageMagick","issue_id":2912159490,"issue_number":8022,"issue_url":"https://github.com/ImageMagick/ImageMagick/issues/8022","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2716061089","fragment_type":"issue_comment","sequence":3,"text":"I posted both of those things.\n \n\nI agree there are no visible changes. Personally I'm not bothered that the profile is lost, for these images. But I feel it _shouldn't_ be, since there are definitely users who **will** be affected by the loss of their color profile.","author_login":"ferdnyc","author_association":"CONTRIBUTOR","created_at":"2025-03-12T00:33:46+08:00","repo_name":"ImageMagick/ImageMagick","issue_id":2912159490,"issue_number":8022,"issue_url":"https://github.com/ImageMagick/ImageMagick/issues/8022","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2730056724","fragment_type":"issue_comment","sequence":4,"text":"**I think there is a bug in either IM or libjxl.** When I copy the image, it changes the profile rather than preserving it on IM 7.1.1.45\n\nmagick f42-01-day.jxl f42-01-day2.jxl\n\nInput image:\nmagick identify -verbose f42-01-day.jxl\n icc:description: **sRGB-elle-V2-srgbtrc.icc**\n\nOutput image:\nmagick identify -verbose f42-01-day2.jxl\n icc:description: **RGB_D65_SRG_Rel_SRG**\n\n**Notice the change in profile names. But also the profile from the input image f42-01-day.jxl to the output image f42-01-day2.jxl has no suffix .icc**\n\n**I think the IM developers need to look into this.**","author_login":"fmw42","author_association":"NONE","created_at":"2025-03-17T16:00:21+08:00","repo_name":"ImageMagick/ImageMagick","issue_id":2912159490,"issue_number":8022,"issue_url":"https://github.com/ImageMagick/ImageMagick/issues/8022","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2730242338","fragment_type":"issue_comment","sequence":5,"text":"I suspect that's normal, and just indicates that the custom profile is being lost. `RGB_D65_SRG_Rel_SRG` is one of the JPEG XL standard/default colorspaces; it's mentioned in the help output I quoted above. The other option is `RGB_D65_202_Rel_PeQ`. But an `-x icc_pathname=` argument is supposed to override that, and doesn't seem to in my experience.","author_login":"ferdnyc","author_association":"CONTRIBUTOR","created_at":"2025-03-17T16:58:24+08:00","repo_name":"ImageMagick/ImageMagick","issue_id":2912159490,"issue_number":8022,"issue_url":"https://github.com/ImageMagick/ImageMagick/issues/8022","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2730289773","fragment_type":"issue_comment","sequence":6,"text":"I do not see -x icc_pathname= argument in the list of defines at URL","author_login":"fmw42","author_association":"NONE","created_at":"2025-03-17T17:14:07+08:00","repo_name":"ImageMagick/ImageMagick","issue_id":2912159490,"issue_number":8022,"issue_url":"https://github.com/ImageMagick/ImageMagick/issues/8022","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2731190464","fragment_type":"issue_comment","sequence":7,"text":"OK, but my main point was that there is no suffix \".icc\" appended to the name. That may be the issue???","author_login":"fmw42","author_association":"NONE","created_at":"2025-03-17T23:33:51+08:00","repo_name":"ImageMagick/ImageMagick","issue_id":2912159490,"issue_number":8022,"issue_url":"https://github.com/ImageMagick/ImageMagick/issues/8022","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2741580426","fragment_type":"issue_comment","sequence":8,"text":"I wouldn't expect it to be, I'd expect that it's mapped to `-profile` in ImageMagick. And from reading the delegate code, it seems like it is, or at least should be (using library API calls). The fact that it's not working for me in either `magick` OR `cjxl` makes me think it's the library.","author_login":"ferdnyc","author_association":"CONTRIBUTOR","created_at":"2025-03-20T20:24:11+08:00","repo_name":"ImageMagick/ImageMagick","issue_id":2912159490,"issue_number":8022,"issue_url":"https://github.com/ImageMagick/ImageMagick/issues/8022","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2759932405","fragment_type":"issue_comment","sequence":9,"text":"I was going to close this in favor of libjxl/libjxl#4164, because my inability to apply the same color profile using the `cjxl` encoder makes me suspect this is a libjxl bug more than an ImageMagick bug.\n\nHowever, the jury isn't COMPLETELY in on that. Because:\n\n1. I can use `djxl` and `cjxl` to convert the original file through JPEG (JXL->JPG->JXL), and the profile will be preserved at each step.\n2. When I use ImageMagick to do the same thing, the profile survives the JXL->JPG conversion, but is again lost in the JPG->JXL conversion.\n\nSo, there may indeed be issues with ImageMagick's JXL encoding not preserving color profile metadata in situations where the JXL reference tools would.","author_login":"ferdnyc","author_association":"CONTRIBUTOR","created_at":"2025-03-28T01:20:55+08:00","repo_name":"ImageMagick/ImageMagick","issue_id":2912159490,"issue_number":8022,"issue_url":"https://github.com/ImageMagick/ImageMagick/issues/8022","linked_issue_ids":[2954682159],"is_known_query_context":false},{"document_id":"gh_comment_2763285498","fragment_type":"issue_comment","sequence":10,"text":"I said it on the libjxl issue, but lossy encoding stores color space Enums (stripped down versions of common color spaces like sRGB, Rec2020, P3, ect) instead of the original ICC. It seems ImageMagick is allowing libjxl to use the Enums for lossless too. It shouldn't effect the visual representation, but it does delete the original ICC making it not truly lossless.","author_login":"jonnyawsom3","author_association":"NONE","created_at":"2025-03-29T10:34:02+08:00","repo_name":"ImageMagick/ImageMagick","issue_id":2912159490,"issue_number":8022,"issue_url":"https://github.com/ImageMagick/ImageMagick/issues/8022","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2764391206","fragment_type":"issue_comment","sequence":11,"text":"Thanks @jonnyawsom3 \n\nI see the issue now. The delegate's `WriteJXLImage()` _always_ calls `JXLEncoderSetColorEncoding()` (via `JXLWriteMetadata()`)... but the docs for that function clearly say that only one of `JXLEncoderSetColorEncoding()` or `JXLEncoderSetICCProfile()` can be used.\n\nThe delegate never calls `JXLEncoderSetICCProfile()` currently, and even if it did that would be invalid, because it's still going to unconditionally call `JXLEncoderSetColorEncoding()`.\n\n...It **will** attempt to preserve any EXIF or XMP metadata by applying it to the output image with `JXLEncoderAddBox()`, but that doesn't help if the profile _isn't in_ an EXIF or XMP blob (like when it comes from a JXL input file, but possibly also via a PNG `iCCP` chunk or other non-EXIF/XMP source)... and from what @jonnyawsom3 says about the overrides I'm not sure profiles from those metadata blobs would be used either, if `JXLEncoderSetColorEncoding()` is still called.\n\nThe delegate is treating `JXLEncoderSetColorEncoding()` as essential, required metadata that must always be set on an image to be encoded. But from what I can tell based on the documentation and @jonnyawsom3 's comments, nothing could be further from the truth, and it should ONLY be used when explicitly _not_ applying an ICC profile.","author_login":"ferdnyc","author_association":"CONTRIBUTOR","created_at":"2025-03-30T05:17:38+08:00","repo_name":"ImageMagick/ImageMagick","issue_id":2912159490,"issue_number":8022,"issue_url":"https://github.com/ImageMagick/ImageMagick/issues/8022","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2764394340","fragment_type":"issue_comment","sequence":12,"text":"Heh. The encoder even does this:\n\nc\n if (image_info->quality == 100)\n basic_info.uses_original_profile=JXL_TRUE;\n\n...But then makes a liar out of itself by never calling `JXLEncoderSetICCProfile()` to attach the original color profile that it's telling the decoder it's supposed to use.\n\n(I think the assumption might have been that this tells the _encoder_ to use the original profile... but IIUC from the docs, it's actually just a flag for the _decoder_ that tells it how to decode the JXL file that's output by the encoder. If the profile doesn't get attached to that output, the flag doesn't really mean anything.)","author_login":"ferdnyc","author_association":"CONTRIBUTOR","created_at":"2025-03-30T05:30:36+08:00","repo_name":"ImageMagick/ImageMagick","issue_id":2912159490,"issue_number":8022,"issue_url":"https://github.com/ImageMagick/ImageMagick/issues/8022","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2764491111","fragment_type":"issue_comment","sequence":13,"text":"Close, but the naming is throwing you off like many before. `basic_info.uses_original_profile` actually controls the internal color space, XYB for lossy and RGB for lossless. Libjxl will throw an error if you try to do lossless XYB.\n\nI think you're right about SetICC and SetColorEncoding though.","author_login":"jonnyawsom3","author_association":"NONE","created_at":"2025-03-30T10:25:49+08:00","repo_name":"ImageMagick/ImageMagick","issue_id":2912159490,"issue_number":8022,"issue_url":"https://github.com/ImageMagick/ImageMagick/issues/8022","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2954682159","fragment_type":"issue_description","sequence":0,"text":"losing color profile when ImageMagick converts JXL -> JXL to remove alpha, can't reapply with libjxl / cjxl\n**Describe the bug**\nWhen an input file in JXL format has an alpha channel and a color profile, removing the alpha channel using ImageMagick will also drop the color profile, which can't subsequently be reapplied with `magick` or `cjxl`.\n\n**To Reproduce**\nUsing the attached file `f42-01-day.jxl` as an example:\n\nconsole\n$ # Original file has alpha channel, embedded color profile\n$ magick identify -verbose f42-01-day.jxl |grep -E -i '(alpha|icc)'\n Type: TrueColorAlpha\n Alpha: 1-bit\n Alpha:\n Profile-icc: 9080 bytes\n icc:copyright: Copyright 2015, Elle Stone (website: URL email: ellestone@ninedegreesbelow.com). This ICC profile is licensed under a Creative Commons Attribution-ShareAlike 3.0 Unported License ( URL \n icc:description: sRGB-elle-V2-srgbtrc.icc\n\n$ # Remove alpha channel using ImageMagick\n$ magick f42-01-day.jxl -quality 100 -alpha off f42-01-day_noalpha.jxl\n\n$ # Resulting file has no alpha, but no profile as well\n$ magick identify -verbose f42-01-day_noalpha.jxl |grep -E -i '(alpha|icc)' \n Filename: f42-01-day_noalpha.jxl\n Profile-icc: 536 bytes\n icc:copyright: CC0\n icc:description: RGB_D65_SRG_Rel_SRG\n\n$ # Extract and attempt to reapply ICC profile\n$ djxl f42-01-day.jxl f42-01-day.exif --icc_out=f42-01-day.icc -v -v -v\nJPEG XL decoder v0.10.4 [SSE2]\nRead 2030921 compressed bytes.\nDecoded to pixels.\nEncoding decoded image\nWrote output to f42-01-day.exif\n4032 x 3024, 10758.651 MP/s [10758.65, 10758.65], , 1 reps, 2 threads.\n\n$ # (exif file is empty, but icc file contains profile:)\n$ file f42-01-day.icc\nf42-01-day.icc: color profile 2.1, type lcms, RGB/XYZ-mntr device by lcms, 9080 bytes, 10-11-2015 12:18:56 \"sRGB-elle-V2-srgbtrc.icc\"\n\n$ # Attempt to reapply to converted, alpha-stripped JXL using cjxl\n$ cjxl f42-01-day_noalpha.jxl f42-01-day_new.jxl --quality=100 \\\n --lossless_jpeg=1 -x icc_profile=f42-01-day.icc -v -v -v\nJPEG XL encoder v0.10.4 [SSE2]\nRead 4032x3024 image, 2165766 bytes, 8.9 MP/s\nEncoding [Modular, lossless, effort: 7]\nCompressed to 2165.8 kB (1.421 bpp).\n4032 x 3024, 0.663 MP/s [0.66, 0.66], , 1 reps, 2 threads.\n\n$ # Output file still has no embedded profile\n$ magick identify -verbose f42-01-day_new.jxl |grep -E -i '(alpha|icc)'\n Profile-icc: 536 bytes\n icc:copyright: CC0\n icc:description: RGB_D65_SRG_Rel_SRG\n\n**Expected behavior**\nProfile is preserved during initial conversion with ImageMagick, and/or reapplied by cjxl when requested.\n\nIn addition, if cjxl ignores or rejects `-x icc_profile=` or any other option, some sort of message to that effect (along with, ideally, an explanation why) should be included in at least `cjxl -v -v -v` output. Silently not applying options set during conversion isn't particularly helpful.\n\n**Input file**\n`f42-01-day.jxl` in zip container: f42-01-day.zip\n\n**Environment**\n - OS: Fedora 41\n - Compiler version: gcc 14.2.1\n - CPU type: x86_64\n - cjxl/djxl version string: cjxl v0.10.4 [SSE2]\n\n**Additional context**\nThe input file is one of the background images which will be included in the upcoming Fedora 42. The background format is changing from PNG to JXL with this release. \n\nHowever, due to a bug in the background handling code, to avoid graphical corruption PNG or JXL backgrounds _must not_ have an alpha channel.\n\nThe original source file is a Krita document, which is being exported to JXL from Krita. Krita's export process does not provide the option to export without an alpha channel -- if the output format supports alpha (as JXL does), it will be included in the export. Hence the need to remove the alpha channel post-export.","author_login":"ferdnyc","author_association":"NONE","created_at":"2025-03-27T23:47:56+08:00","repo_name":"libjxl/libjxl","issue_id":2954682159,"issue_number":4164,"issue_url":"https://github.com/libjxl/libjxl/issues/4164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2759842838","fragment_type":"issue_comment","sequence":1,"text":"(Note: I'd originally reported this to ImageMagick (ImageMagick/ImageMagick#8022). However, after discovering I can't apply the profile using `cjxl` either, I no longer think this is an ImageMagick bug.)","author_login":"ferdnyc","author_association":"NONE","created_at":"2025-03-27T23:53:00+08:00","repo_name":"libjxl/libjxl","issue_id":2954682159,"issue_number":4164,"issue_url":"https://github.com/libjxl/libjxl/issues/4164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2760646384","fragment_type":"issue_comment","sequence":2,"text":"The `-x` flag in cjxl is only used for inputs that can't have color profiles embedded (PPM, ect), otherwise it's taken from the original file. \nJPEG XL can use Color Enums instead of ICC profiles for common color spaces (sRGB, P3, Rec2020, ect). Usually this is only used for lossy, but it seems ImageMagick is incorrectly using Enums for lossless too. This has little to no impact visually, but it does remove the original ICC profile.\n\nUsing cjxl to recompress the source file retains the ICC in Lossless, and uses the sRGB Enum when set to lossy, confirming it as an ImageMagick bug. @sboukortt might know what area needs to be fixed though, likely just a missing flag.","author_login":"jonnyawsom3","author_association":"COLLABORATOR","created_at":"2025-03-28T09:18:42+08:00","repo_name":"libjxl/libjxl","issue_id":2954682159,"issue_number":4164,"issue_url":"https://github.com/libjxl/libjxl/issues/4164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2764682438","fragment_type":"issue_comment","sequence":3,"text":"I'm going to close this, as I have a PR open to fix IM's delegate code (ImageMagick/ImageMagick#8074), and it seems clear at this point that the bug lives there.\n\nI still think it's a bit weird you can't embed an ICC profile into an existing JXL file that lacks one by using some variation of a command like,\n\nbash\ncjxl input.jxl output.jxl --quality=100 -x icc_pathname=profile.icc\n\n...As that would be a handy feature for correcting files where the profile went missing. But, if it doesn't go missing in the first place, then I suppose it's not a worry.","author_login":"ferdnyc","author_association":"NONE","created_at":"2025-03-30T18:14:27+08:00","repo_name":"libjxl/libjxl","issue_id":2954682159,"issue_number":4164,"issue_url":"https://github.com/libjxl/libjxl/issues/4164","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0199","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"`__vite_ssr_import_meta__.glob is not a function` Error During SSR?","query_context":"### Related plugins\n\n- [x] plugin-vue\n\n- [ ] plugin-vue-jsx\n\n### Describe the bug\n\nThis bug is a very strange one. When using SSR, I cannot use dynamic imports more than once in my Vue SFC if I add `class=\"whatever\"` to the root element. Please see the minimal reproduction, but here is a brief rundown:\n\n1. I'd like to do some ``import(`./dynamicA/${name}.json`)`` and some ``import(`./dynamicB/${name}.json`)`` in my Vue SFC... in other words, I'd like to using dynamic importing multiple times.\n2. When I do, the second dynamic import fails if I add `class=\"whatever\"` to the root element of my SFC.\n3. This is very surprising outcome, because as a developer I wouldn't expect my `class` attribute and dynamic imports to have anything to do with each other.\n\n### Reproduction\n\n URL \n\n### Steps to reproduce\n\nPlease see the minimal reproduction `README.md` for reproduction steps.\n\n### System Info\n\nshell\nSystem:\n OS: macOS 12.5\n CPU: (10) arm64 Apple M1 Pro\n Memory: 99.11 MB / 16.00 GB\n Shell: 5.8.1 - /bin/zsh\n Binaries:\n Node: 16.19.0 - ~/.volta/tools/image/node/16.19.0/bin/node\n npm: 8.19.3 - ~/.volta/tools/image/node/16.19.0/bin/npm\n Browsers:\n Chrome: 109.0.5414.119\n Safari: 15.6\n npmPackages:\n @vitejs/plugin-vue: ^4.0.0 => 4.0.0 \n vite: ^4.0.4 => 4.0.4\n\n### Used Package Manager\n\nnpm\n\n### Logs\n\n \n Click to expand! \n\nshell\n/entrypoints/App.vue:8\n console.log(\"[dynamicB/test.json#message]\", (await __vite_ssr_import_0__.default((__vite_ssr_import_meta__.glob(\"./dynamicB/*.json\")), `./dynamicB/${name}.json`)).default.message);\n ^\n\nTypeError: __vite_ssr_import_meta__.glob is not a function\n at asyncWrapper (/entrypoints/App.vue:8:110)\n\n \n\n### Validations\n\n- [X] Follow our Code of Conduct\n- [X] Read the Contributing Guidelines.\n- [X] Read the docs.\n- [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.\n- [X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.\n- [X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.\n- [X] The provided reproduction is a minimal reproducible example of the bug.","known_context_document_ids":["gh_issue_1562914587"],"reference_answer":"When ran without the parser, the tokenizer _will_ fail to distinguish regexps from division operators in some cases (because JavaScript cannot be tokenized without parsing). This is a known limitation, and not something that's fixable.","answer_document_id":"gh_comment_1413454994","silver_evidence_path":["gh_comment_1413986695","gh_issue_1563228395","gh_comment_1413454994"],"evidence_issue_ids":[1562914587,1563228395],"source_repo_name":"vitejs/vite-plugin-vue","source_issue_id":1562914587,"source_issue_number":96,"source_issue_url":"https://github.com/vitejs/vite-plugin-vue/issues/96","target_repo_name":"acornjs/acorn","target_issue_id":1563228395,"target_issue_number":1191,"target_issue_url":"https://github.com/acornjs/acorn/issues/1191","reference_anchor_document_id":"gh_comment_1413986695","reference_answer_author":"marijnh","reference_answer_author_association":"MEMBER","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.3636,"anchor_target_overlap":0.303,"target_answer_overlap":0.0},"issue_created_at":"2023-01-30T17:59:55+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_1562914587","fragment_type":"issue_description","sequence":0,"text":"`__vite_ssr_import_meta__.glob is not a function` Error During SSR\n### Related plugins\n\n- [x] plugin-vue\n\n- [ ] plugin-vue-jsx\n\n### Describe the bug\n\nThis bug is a very strange one. When using SSR, I cannot use dynamic imports more than once in my Vue SFC if I add `class=\"whatever\"` to the root element. Please see the minimal reproduction, but here is a brief rundown:\n\n1. I'd like to do some ``import(`./dynamicA/${name}.json`)`` and some ``import(`./dynamicB/${name}.json`)`` in my Vue SFC... in other words, I'd like to using dynamic importing multiple times.\n2. When I do, the second dynamic import fails if I add `class=\"whatever\"` to the root element of my SFC.\n3. This is very surprising outcome, because as a developer I wouldn't expect my `class` attribute and dynamic imports to have anything to do with each other.\n\n### Reproduction\n\n URL \n\n### Steps to reproduce\n\nPlease see the minimal reproduction `README.md` for reproduction steps.\n\n### System Info\n\nshell\nSystem:\n OS: macOS 12.5\n CPU: (10) arm64 Apple M1 Pro\n Memory: 99.11 MB / 16.00 GB\n Shell: 5.8.1 - /bin/zsh\n Binaries:\n Node: 16.19.0 - ~/.volta/tools/image/node/16.19.0/bin/node\n npm: 8.19.3 - ~/.volta/tools/image/node/16.19.0/bin/npm\n Browsers:\n Chrome: 109.0.5414.119\n Safari: 15.6\n npmPackages:\n @vitejs/plugin-vue: ^4.0.0 => 4.0.0 \n vite: ^4.0.4 => 4.0.4\n\n### Used Package Manager\n\nnpm\n\n### Logs\n\n \n Click to expand! \n\nshell\n/entrypoints/App.vue:8\n console.log(\"[dynamicB/test.json#message]\", (await __vite_ssr_import_0__.default((__vite_ssr_import_meta__.glob(\"./dynamicB/*.json\")), `./dynamicB/${name}.json`)).default.message);\n ^\n\nTypeError: __vite_ssr_import_meta__.glob is not a function\n at asyncWrapper (/entrypoints/App.vue:8:110)\n\n \n\n### Validations\n\n- [X] Follow our Code of Conduct\n- [X] Read the Contributing Guidelines.\n- [X] Read the docs.\n- [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.\n- [X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.\n- [X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.\n- [X] The provided reproduction is a minimal reproducible example of the bug.","author_login":"AaronBeaudoin","author_association":"NONE","created_at":"2023-01-30T17:59:55+08:00","repo_name":"vitejs/vite-plugin-vue","issue_id":1562914587,"issue_number":96,"issue_url":"https://github.com/vitejs/vite-plugin-vue/issues/96","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1409455467","fragment_type":"issue_comment","sequence":1,"text":"# Detailed Update\n\nIt looks like the root cause of this issue is the output generated for `App.vue` before it is passed to `vite:import-glob` does not correctly quote the \"class\" attribute, causing it to be interpreted by Acorn incorrectly. Here is the relevant snippet from my output:\n\njs\nfunction _sfc_ssrRender(_ctx, _push, _parent, _attrs, $props, $setup, $data, $options) {\n _push(` ${\n _ssrInterpolate(new Date())\n } `)\n}\n\nI'm not sure where exactly in the Vite/Rollup pipeline this code is generated. Would someone from the team be willing to jump in here?","author_login":"AaronBeaudoin","author_association":"NONE","created_at":"2023-01-30T22:27:43+08:00","repo_name":"vitejs/vite-plugin-vue","issue_id":1562914587,"issue_number":96,"issue_url":"https://github.com/vitejs/vite-plugin-vue/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1413986695","fragment_type":"issue_comment","sequence":2,"text":"The Acorn author said the cause of this issue is \"not fixable\" on his end. That leaves us with a scenario where dynamic import cannot be used more than once (and maybe potentially other issues) if the root element of a component has a `class` attribute. I think this should be resolved by having Vue add quotes around the property name.","author_login":"AaronBeaudoin","author_association":"NONE","created_at":"2023-02-02T16:06:35+08:00","repo_name":"vitejs/vite-plugin-vue","issue_id":1562914587,"issue_number":96,"issue_url":"https://github.com/vitejs/vite-plugin-vue/issues/96","linked_issue_ids":[1563228395],"is_known_query_context":false},{"document_id":"gh_comment_1415474088","fragment_type":"issue_comment","sequence":3,"text":"Thanks for the detailed explanation! v1.0.1 should improve the regex to hand the cases. JS is complex 🤷","author_login":"antfu","author_association":"MEMBER","created_at":"2023-02-03T09:32:55+08:00","repo_name":"vitejs/vite-plugin-vue","issue_id":1562914587,"issue_number":96,"issue_url":"https://github.com/vitejs/vite-plugin-vue/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1563228395","fragment_type":"issue_description","sequence":0,"text":"[BUG] `SyntaxError: Unterminated regular expression`...but there is no regular expression.\nIn my Vite project, I found that I was unable to use the dynamic `import()` function more than once when I made an apparently completely unrelated code change, prompting me to open an issue at URL From my stepping through the source code later, I now think I've tracked the issue down to this acorn-related function.\n\nHere is the specific input I found which, when passed into the function, causes it to \"break\":\n\njs\nimport __variableDynamicImportRuntimeHelper from \"vite/dynamic-import-helper\";\nconst asyncWrapper = async () => {\n const name = \"test\";\n console.log(\"[dynamicA/test.json#message]\", (await __variableDynamicImportRuntimeHelper((import.meta.glob(\"./dynamicA/*.json\")), `./dynamicA/${name}.json`)).default.message);\n console.log(\"[dynamicB/test.json#message]\", (await __variableDynamicImportRuntimeHelper((import.meta.glob(\"./dynamicB/*.json\")), `./dynamicB/${name}.json`)).default.message);\n};\n\nasyncWrapper();\nconst _sfc_main = {};\n\nimport { mergeProps as _mergeProps } from \"vue\"\nimport { ssrRenderAttrs as _ssrRenderAttrs, ssrInterpolate as _ssrInterpolate } from \"vue/server-renderer\"\n\nfunction _sfc_ssrRender(_ctx, _push, _parent, _attrs, $props, $setup, $data, $options) {\n _push(` ${\n _ssrInterpolate(new Date())\n } `)\n}\n\nimport { useSSRContext as __vite_useSSRContext } from 'vue'\nconst _sfc_setup = _sfc_main.setup\n_sfc_main.setup = (props, ctx) => {\n const ssrContext = __vite_useSSRContext()\n ;(ssrContext.modules || (ssrContext.modules = new Set())).add(\"entrypoints/App.vue\")\n return _sfc_setup ? _sfc_setup(props, ctx) : undefined\n}\nimport _export_sfc from 'plugin-vue:export-helper'\nexport default /*#__PURE__*/_export_sfc(_sfc_main, [['ssrRender',_sfc_ssrRender],['__file',\"/Users/aryse/Projects/open-source/vite-ssr-issue-vue-sfc-dynamic-import/entrypoints/App.vue\"]])\n\nAnd here is the console output:\n\nfile:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:3454\n var err = new SyntaxError(message);\n ^\n\nSyntaxError: Unterminated regular expression (19:5)\n at Parser.pp$4.raise (file:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:3454:13)\n at Parser.pp.readRegexp (file:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:5136:36)\n at Parser.pp.readToken_slash (file:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:4929:51)\n at Parser.pp.getTokenFromCode (file:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:5092:17)\n at Parser.pp.readToken (file:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:4809:15)\n at Parser.pp.nextToken (file:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:4800:15)\n at Parser.pp.next (file:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:4761:8)\n at Parser.pp.getToken (file:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:4765:8)\n at Object.next (file:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:4776:30)\n at stripLiteralAcorn (file:///Users/aryse/Projects/open-source/acorn-test/index.mjs:22:42) {\n pos: 903,\n loc: Position { line: 19, column: 5 },\n raisedAt: 909\n}","author_login":"AaronBeaudoin","author_association":"NONE","created_at":"2023-01-30T21:22:19+08:00","repo_name":"acornjs/acorn","issue_id":1563228395,"issue_number":1191,"issue_url":"https://github.com/acornjs/acorn/issues/1191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1410589739","fragment_type":"issue_comment","sequence":1,"text":"The `strip-literal` library used internally by Vite appears to be using the `acorn.tokenizer` function.\n\nHere is my minimal reproduction:\n\njs\nimport { tokenizer } from \"acorn\";\n\n[...tokenizer(\"` `\", {\n ecmaVersion: \"latest\",\n sourceType: \"module\",\n allowHashBang: true,\n allowAwaitOutsideFunction: true,\n allowImportExportEverywhere: true\n})]\n\nWhich gives me the following error:\n\nfile:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:3454\n var err = new SyntaxError(message);\n ^\n\nSyntaxError: Unterminated regular expression (1:28)\n at Parser.pp$4.raise (file:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:3454:13)\n at Parser.pp.readRegexp (file:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:5134:47)\n at Parser.pp.readToken_slash (file:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:4929:51)\n at Parser.pp.getTokenFromCode (file:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:5092:17)\n at Parser.pp.readToken (file:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:4809:15)\n at Parser.pp.nextToken (file:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:4800:15)\n at Parser.pp.next (file:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:4761:8)\n at Parser.pp.getToken (file:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:4765:8)\n at Object.next (file:///Users/aryse/Projects/open-source/acorn-test/node_modules/acorn/dist/acorn.mjs:4776:30)\n at file:///Users/aryse/Projects/open-source/acorn-test/index.mjs:3:5 {\n pos: 28,\n loc: Position { line: 1, column: 28 },\n raisedAt: 33\n}","author_login":"AaronBeaudoin","author_association":"NONE","created_at":"2023-01-31T15:30:35+08:00","repo_name":"acornjs/acorn","issue_id":1563228395,"issue_number":1191,"issue_url":"https://github.com/acornjs/acorn/issues/1191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1410881033","fragment_type":"issue_comment","sequence":2,"text":"I get the same `Unterminated regular expression` message when I run your minimal reproduction. More minimal:\n\njs\n[...tokenizer(\"`${{ class: 5 }}></`\", {\n ecmaVersion: \"latest\",\n})]","author_login":"redblobgames","author_association":"NONE","created_at":"2023-01-31T18:34:57+08:00","repo_name":"acornjs/acorn","issue_id":1563228395,"issue_number":1191,"issue_url":"https://github.com/acornjs/acorn/issues/1191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1413454994","fragment_type":"issue_comment","sequence":3,"text":"When ran without the parser, the tokenizer _will_ fail to distinguish regexps from division operators in some cases (because JavaScript cannot be tokenized without parsing). This is a known limitation, and not something that's fixable.","author_login":"marijnh","author_association":"MEMBER","created_at":"2023-02-02T09:58:00+08:00","repo_name":"acornjs/acorn","issue_id":1563228395,"issue_number":1191,"issue_url":"https://github.com/acornjs/acorn/issues/1191","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0202","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Stack custom items even if NBT data order is different?","query_context":"### Terms\n\n- [x] I'm using the very latest version of ItemsAdder and its dependencies.\n- [x] I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.\n- [x] I've looked for already existing issues on the Issue Tracker and haven't found any.\n- [x] I already searched on the plugin wiki to know if a solution is already known.\n- [x] I searched the `#itemsadder-forum` channel on Discord for similar issues.\n- [x] I tested that this issue persists on a **bare-minimum Server** as described in #4187.\n\n### Discord Username (optional)\n\n_No response_\n\n### What happened?\n\nAfter the plugin update, many things broke. 1st problem is, that order of nbt tags has been randomly changed, so now the old items cannot stack with a new one.\n\nImage\n\ncauses issues like this (the purple item)\n\nImage\n\ngg\n\n### Steps to reproduce the issue\n\nIdk updete the plugin from 4.0.7 to 4.0.9\n\n### Server version\n\nPaper 1.21.1 v132\n\n### ItemsAdder Version\n\n4.0.9\n\n### ProtocolLib Version\n\nProtocolLib version 5.4.0-SNAPSHOT-741\n\n### LoneLibs Version\n\nLoneLibs version 1.0.65\n\n### Full Server Log\n\n URL \n\n### Error (optional)\n\nshell\n\n### Problematic items yml configuration file (optional)\n\nyaml\n\n### Other files, you can drag and drop them here to upload. (optional)\n\n_No response_\n\n### Screenshots/Videos (you can drag and drop files or paste links)\n\n_No response_","known_context_document_ids":["gh_issue_2900044991"],"reference_answer":"This seems to be a MMOitems bug not ItemsAdder bug.\nAs I said:\n \n\nThis is not an ItemsAdder bug.","answer_document_id":"gh_comment_1496225278","silver_evidence_path":["gh_comment_2730318151","gh_issue_1646868078","gh_comment_1496225278"],"evidence_issue_ids":[2900044991,1646868078],"source_repo_name":"PluginBugs/Issues-ItemsAdder","source_issue_id":2900044991,"source_issue_number":4497,"source_issue_url":"https://github.com/PluginBugs/Issues-ItemsAdder/issues/4497","target_repo_name":"PluginBugs/Issues-ItemsAdder","target_issue_id":1646868078,"target_issue_number":2473,"target_issue_url":"https://github.com/PluginBugs/Issues-ItemsAdder/issues/2473","reference_anchor_document_id":"gh_comment_2730318151","reference_answer_author":"LoneDev6","reference_answer_author_association":"COLLABORATOR","quality_score":83.5,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.3571,"anchor_target_overlap":0.0357,"target_answer_overlap":0.3333},"issue_created_at":"2025-03-06T10:46:34+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_2900044991","fragment_type":"issue_description","sequence":0,"text":"Stack custom items even if NBT data order is different\n### Terms\n\n- [x] I'm using the very latest version of ItemsAdder and its dependencies.\n- [x] I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.\n- [x] I've looked for already existing issues on the Issue Tracker and haven't found any.\n- [x] I already searched on the plugin wiki to know if a solution is already known.\n- [x] I searched the `#itemsadder-forum` channel on Discord for similar issues.\n- [x] I tested that this issue persists on a **bare-minimum Server** as described in #4187.\n\n### Discord Username (optional)\n\n_No response_\n\n### What happened?\n\nAfter the plugin update, many things broke. 1st problem is, that order of nbt tags has been randomly changed, so now the old items cannot stack with a new one.\n\nImage\n\ncauses issues like this (the purple item)\n\nImage\n\ngg\n\n### Steps to reproduce the issue\n\nIdk updete the plugin from 4.0.7 to 4.0.9\n\n### Server version\n\nPaper 1.21.1 v132\n\n### ItemsAdder Version\n\n4.0.9\n\n### ProtocolLib Version\n\nProtocolLib version 5.4.0-SNAPSHOT-741\n\n### LoneLibs Version\n\nLoneLibs version 1.0.65\n\n### Full Server Log\n\n URL \n\n### Error (optional)\n\nshell\n\n### Problematic items yml configuration file (optional)\n\nyaml\n\n### Other files, you can drag and drop them here to upload. (optional)\n\n_No response_\n\n### Screenshots/Videos (you can drag and drop files or paste links)\n\n_No response_","author_login":"pjindras","author_association":"NONE","created_at":"2025-03-06T10:46:34+08:00","repo_name":"PluginBugs/Issues-ItemsAdder","issue_id":2900044991,"issue_number":4497,"issue_url":"https://github.com/PluginBugs/Issues-ItemsAdder/issues/4497","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2730318151","fragment_type":"issue_comment","sequence":1,"text":"Sometimes the order of NBT data changes, this causes the game to think that they are a completely different items so they won't stack.\nI will implement a way to stack items even if their NBT data order is different.\n\nThis is a Minecraft limitation, as I pointed out on multiple issues pages (listing them just for future reference.\n- URL \n- URL \n- URL \n- URL","author_login":"LoneDev6","author_association":"COLLABORATOR","created_at":"2025-03-17T17:22:30+08:00","repo_name":"PluginBugs/Issues-ItemsAdder","issue_id":2900044991,"issue_number":4497,"issue_url":"https://github.com/PluginBugs/Issues-ItemsAdder/issues/4497","linked_issue_ids":[1646868078],"is_known_query_context":false},{"document_id":"gh_comment_2796856085","fragment_type":"issue_comment","sequence":2,"text":"New option `fix_unstackable_items_on_click` in `config.yml` will be added to enable this fix.\nItems will be merged when you click in inventory if their NBT is likely to be the same.\n\nIt will ignore merging if:\n- durability is different\n- usages are different\n- not same material\n- not same custom item id (obvious)\n- max stack is already reached","author_login":"LoneDev6","author_association":"COLLABORATOR","created_at":"2025-04-11T13:01:09+08:00","repo_name":"PluginBugs/Issues-ItemsAdder","issue_id":2900044991,"issue_number":4497,"issue_url":"https://github.com/PluginBugs/Issues-ItemsAdder/issues/4497","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1646868078","fragment_type":"issue_description","sequence":0,"text":"Item Tag Changed\n### Terms\n\n- [X] I'm using the very latest version of ItemsAdder and its dependencies.\n- [X] I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.\n- [X] I already searched on this Github page to check if the same issue was already reported.\n- [X] I already searched on the plugin wiki to know if a solution is already known.\n- [X] I already searched on the forums to check if anyone already has a solution for this.\n\n### Discord tag (optional)\n\n나인#1927\n\n### What happened?\n\n1. Acquire an item.\n2. Drop the item on the floor through the Q key.\n3. Acquire items dropped on the floor.\n4. The item tag has been changed.\n\n### Steps to reproduce the issue\n\n1. Acquire an item.\n2. Drop the item on the floor through the Q key.\n3. Acquire items dropped on the floor.\n4. The item tag has been changed.\n\n### Server version\n\n1.19.4\n\n### ItemsAdder Version\n\n3.4.1-r3\n\n### ProtocolLib Version\n\n`\n\n### LoneLibs Version\n\n`\n\n### FULL server log\n\n_No response_\n\n### Error (optional)\n\n_No response_\n\n### Problematic items yml configuration file (optional)\n\n_No response_\n\n### Other files, you can drag and drop them here to upload. (optional)\n\n_No response_\n\n### Screenshots/Videos (you can drag and drop files or paste links)\n\n_No response_","author_login":"ninesik","author_association":"NONE","created_at":"2023-03-30T03:58:47+08:00","repo_name":"PluginBugs/Issues-ItemsAdder","issue_id":1646868078,"issue_number":2473,"issue_url":"https://github.com/PluginBugs/Issues-ItemsAdder/issues/2473","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1490025487","fragment_type":"issue_comment","sequence":1,"text":"Remove every other plugin (keep LoneLibs, ProtocolLib and ItemsAdder) and test if it still happens.\nItemsAdder doesn't edit dropped items NBT tag.","author_login":"LoneDev6","author_association":"COLLABORATOR","created_at":"2023-03-30T09:57:54+08:00","repo_name":"PluginBugs/Issues-ItemsAdder","issue_id":1646868078,"issue_number":2473,"issue_url":"https://github.com/PluginBugs/Issues-ItemsAdder/issues/2473","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1490403525","fragment_type":"issue_comment","sequence":2,"text":"Cannot reproduce. NBT data is always the same otherwise they wouldn't stack.\n\n URL","author_login":"LoneDev6","author_association":"COLLABORATOR","created_at":"2023-03-30T14:26:16+08:00","repo_name":"PluginBugs/Issues-ItemsAdder","issue_id":1646868078,"issue_number":2473,"issue_url":"https://github.com/PluginBugs/Issues-ItemsAdder/issues/2473","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1493305181","fragment_type":"issue_comment","sequence":3,"text":"This problem occurs if you create an item using mmoitems plugin.\nia config\n\n items36:\n display_name: '&f&l욕망의 구슬'\n permission: items\n mmoitem:\n type: material\n id: test\n resource:\n material: STICK\n generate: true\n textures:\n - item/36.png\n\nmmoitems config\ntest:\n base:\n material: STICK\n\n1. Discard the item.","author_login":"ninesik","author_association":"NONE","created_at":"2023-04-02T11:26:34+08:00","repo_name":"PluginBugs/Issues-ItemsAdder","issue_id":1646868078,"issue_number":2473,"issue_url":"https://github.com/PluginBugs/Issues-ItemsAdder/issues/2473","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1493305711","fragment_type":"issue_comment","sequence":4,"text":"Item Tag Before Throwing Away\n\n{Count:9b,id:\"minecraft:stick\",tag:{AttributeModifiers:[{Amount:0.0d,AttributeName:\"minecraft:generic.attack_speed\",Name:\"mmoitemsDecoy\",Operation:0,UUID:[I;-2021319128,-1357757450,-1987131861,-563359508]}],CustomModelData:10098,HSTRY_ENCHANTS:'{\"Stat\":\"ENCHANTS\",\"OGStory\":[{\"MMOITEMS_ENCHANTS_ñstr\":\"[]\"}]}',HideFlags:2,MMOITEMS_DYNAMIC_LORE:'[\"&c재료\"]',MMOITEMS_ENCHANTS:\"[]\",MMOITEMS_ITEM_ID:\"욕망의구슬\",MMOITEMS_ITEM_TYPE:\"MATERIAL\",display:{Lore:['{\"italic\":false,\"color\":\"red\",\"text\":\"재료\"}'],Name:'{\"bold\":true,\"italic\":false,\"color\":\"white\",\"text\":\"욕망의 구슬\"}'},itemsadder:{id:\"items36\",namespace:\"inmc\"}}}\n\nItem tag after discarding\n\n{Count:1b,id:\"minecraft:stick\",tag:{AttributeModifiers:[{Amount:0.0d,AttributeName:\"minecraft:generic.attack_speed\",Name:\"mmoitemsDecoy\",Operation:0,UUID:[I;-2021319128,-1357757450,-1987131861,-563359508]}],CustomModelData:10098,HSTRY_ENCHANTS:'{\"Stat\":\"ENCHANTS\",\"OGStory\":[{\"MMOITEMS_ENCHANTS_ñstr\":\"[]\"}]}',HideFlags:2,MMOITEMS_DYNAMIC_LORE:'[\"&c재료\"]',MMOITEMS_ENCHANTS:\"[]\",MMOITEMS_ITEM_ID:\"욕망의구슬\",MMOITEMS_ITEM_TYPE:\"MATERIAL\",display:{Lore:['{\"extra\":[{\"bold\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"obfuscated\":false,\"color\":\"red\",\"text\":\"재료\"}],\"text\":\"\"}'],Name:'{\"bold\":true,\"italic\":false,\"color\":\"white\",\"text\":\"욕망의 구슬\"}'},itemsadder:{id:\"items36\",namespace:\"inmc\"}}}","author_login":"ninesik","author_association":"NONE","created_at":"2023-04-02T11:28:52+08:00","repo_name":"PluginBugs/Issues-ItemsAdder","issue_id":1646868078,"issue_number":2473,"issue_url":"https://github.com/PluginBugs/Issues-ItemsAdder/issues/2473","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1496225278","fragment_type":"issue_comment","sequence":5,"text":"This seems to be a MMOitems bug not ItemsAdder bug.\nAs I said:\n \n\nThis is not an ItemsAdder bug.","author_login":"LoneDev6","author_association":"COLLABORATOR","created_at":"2023-04-04T15:57:13+08:00","repo_name":"PluginBugs/Issues-ItemsAdder","issue_id":1646868078,"issue_number":2473,"issue_url":"https://github.com/PluginBugs/Issues-ItemsAdder/issues/2473","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0207","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"MCAD Multi-Cluster + KubeStellar Integration (Stage-1)?","query_context":"### Feature Description\n\nMCAD as one of the options for the job queuing and scheduling interface for KubeStellar.\n\n### Proposed Solution\n\nStage-1: MCAD dispatcher deploys appWrappers to MCAD agent clusters and collects AppWrapper status via KubeStellar\nStage-2: new MCAD observability paths (e.g., metrics collection: Prometheus, Thanos, Observatorium, etc.) enable by KubeStellar\n\n### Want to contribute?\n\n- [ ] I would like to work on this issue.\n\n### Additional Context\n\nThe gaps identified for stage-1 are the following:\n\ni) MCAD dispatcher needs to create a KubeStellar EdgePlacement objects. The EdgePlacement object is used to select a target cluster to deploy a workload (e.g., AppWrapper)\n\nii) MCAD dispatcher needs to deploy AppWrappers and EdgePlacement objects to KubeStellar Workload Management Workspaces (WMW)\n\niii) MCAD dispatcher needs to use an informer library to collect appWrapper status from KubeStellar","known_context_document_ids":["gh_issue_1826714794"],"reference_answer":"Thanks @dumb000!, \n\n@asm582 , I tagged this one as well with multi-cluster label.","answer_document_id":"gh_comment_1656249359","silver_evidence_path":["gh_comment_1656299812","gh_issue_1827007119","gh_comment_1656249359"],"evidence_issue_ids":[1826714794,1827007119],"source_repo_name":"project-codeflare/multi-cluster-app-dispatcher","source_issue_id":1826714794,"source_issue_number":521,"source_issue_url":"https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/521","target_repo_name":"project-codeflare/multi-cluster-app-dispatcher","target_issue_id":1827007119,"target_issue_number":524,"target_issue_url":"https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/524","reference_anchor_document_id":"gh_comment_1656299812","reference_answer_author":"dmatch01","reference_answer_author_association":"COLLABORATOR","quality_score":85.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0625,"anchor_target_overlap":0.1875,"target_answer_overlap":0.125},"issue_created_at":"2023-07-28T16:24:09+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_1826714794","fragment_type":"issue_description","sequence":0,"text":"MCAD Multi-Cluster + KubeStellar Integration (Stage-1)\n### Feature Description\n\nMCAD as one of the options for the job queuing and scheduling interface for KubeStellar.\n\n### Proposed Solution\n\nStage-1: MCAD dispatcher deploys appWrappers to MCAD agent clusters and collects AppWrapper status via KubeStellar\nStage-2: new MCAD observability paths (e.g., metrics collection: Prometheus, Thanos, Observatorium, etc.) enable by KubeStellar\n\n### Want to contribute?\n\n- [ ] I would like to work on this issue.\n\n### Additional Context\n\nThe gaps identified for stage-1 are the following:\n\ni) MCAD dispatcher needs to create a KubeStellar EdgePlacement objects. The EdgePlacement object is used to select a target cluster to deploy a workload (e.g., AppWrapper)\n\nii) MCAD dispatcher needs to deploy AppWrappers and EdgePlacement objects to KubeStellar Workload Management Workspaces (WMW)\n\niii) MCAD dispatcher needs to use an informer library to collect appWrapper status from KubeStellar","author_login":"dumb0002","author_association":"NONE","created_at":"2023-07-28T16:24:09+08:00","repo_name":"project-codeflare/multi-cluster-app-dispatcher","issue_id":1826714794,"issue_number":521,"issue_url":"https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/521","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1655976501","fragment_type":"issue_comment","sequence":1,"text":"@dumb0002 Thanks for creating this issue. We would need some more information on the gaps that you talk about.\n\n@astefanutti @anishasthana Should the integration step happen through the ADR process?","author_login":"asm582","author_association":"MEMBER","created_at":"2023-07-28T16:33:07+08:00","repo_name":"project-codeflare/multi-cluster-app-dispatcher","issue_id":1826714794,"issue_number":521,"issue_url":"https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/521","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1655979970","fragment_type":"issue_comment","sequence":2,"text":"Yep! We definitely shouldn't start any implementation work until that an ADR is approved.","author_login":"anishasthana","author_association":"MEMBER","created_at":"2023-07-28T16:36:30+08:00","repo_name":"project-codeflare/multi-cluster-app-dispatcher","issue_id":1826714794,"issue_number":521,"issue_url":"https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/521","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1655987950","fragment_type":"issue_comment","sequence":3,"text":"Thanks, @anishasthana can you help with pointers to ADR to get started?","author_login":"asm582","author_association":"MEMBER","created_at":"2023-07-28T16:41:27+08:00","repo_name":"project-codeflare/multi-cluster-app-dispatcher","issue_id":1826714794,"issue_number":521,"issue_url":"https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/521","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1656299812","fragment_type":"issue_comment","sequence":4,"text":"@asm582, I updated the information in this issue - let me know if additional changes are needed. Also, I created issue # #524 to focus on the k8s versioning issue only as suggested by @dmatch01 ,","author_login":"dumb0002","author_association":"NONE","created_at":"2023-07-28T20:31:23+08:00","repo_name":"project-codeflare/multi-cluster-app-dispatcher","issue_id":1826714794,"issue_number":521,"issue_url":"https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/521","linked_issue_ids":[1827007119],"is_known_query_context":false},{"document_id":"gh_comment_1656742460","fragment_type":"issue_comment","sequence":5,"text":"We have an ADR template (and repository) at URL Can you please raise a PR there? We track any major decisions in that repo.","author_login":"anishasthana","author_association":"MEMBER","created_at":"2023-07-29T14:27:03+08:00","repo_name":"project-codeflare/multi-cluster-app-dispatcher","issue_id":1826714794,"issue_number":521,"issue_url":"https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/521","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1667846096","fragment_type":"issue_comment","sequence":6,"text":"@dumb0002 @clubanderson could you folks work on an ADR proposing this integration before we proceed too far down the implementation path? Thanks!","author_login":"anishasthana","author_association":"MEMBER","created_at":"2023-08-07T13:19:50+08:00","repo_name":"project-codeflare/multi-cluster-app-dispatcher","issue_id":1826714794,"issue_number":521,"issue_url":"https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/521","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1670422917","fragment_type":"issue_comment","sequence":7,"text":"@anishasthana We're still flush out the details of what this integration would be. Once we have a good handle on it we can generate an ADR. For now I'm good with closing this work item until we complete our investigation/evaluation of the KubeStellar technology. \n\n@dumb0002 do you concur with my recommendation to close this work item for now and reopen once the initial investigation/evaluation is complete?","author_login":"dmatch01","author_association":"COLLABORATOR","created_at":"2023-08-08T22:58:52+08:00","repo_name":"project-codeflare/multi-cluster-app-dispatcher","issue_id":1826714794,"issue_number":521,"issue_url":"https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/521","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1671504637","fragment_type":"issue_comment","sequence":8,"text":"@dmatch01 yes, I agree! I am going to close this issue for now and let's reopen it later once our initial investigation is completed as you suggested.","author_login":"dumb0002","author_association":"NONE","created_at":"2023-08-09T14:32:58+08:00","repo_name":"project-codeflare/multi-cluster-app-dispatcher","issue_id":1826714794,"issue_number":521,"issue_url":"https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/521","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1827007119","fragment_type":"issue_description","sequence":0,"text":"MCAD Multi-Cluster using an old k8s version\n### Description\n\nMCAD Multi-Cluster uses the apiregistration.k8s.io/v1beta1 API version of APIService that is no longer served as of k8s v1.22.\n\n### Proposed Solution\n\nMCAD Multi-Cluster k8s version needs to be upgraded to a k8s version compatible with KubeStellar. \nKubeStellar requires k8s version: v1.24.3\n\n### Want to contribute?\n\n- [ ] I would like to work on this issue.\n\n### Additional Context","author_login":"dumb0002","author_association":"NONE","created_at":"2023-07-28T19:46:03+08:00","repo_name":"project-codeflare/multi-cluster-app-dispatcher","issue_id":1827007119,"issue_number":524,"issue_url":"https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/524","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1656249359","fragment_type":"issue_comment","sequence":1,"text":"Thanks @dumb000!, \n\n@asm582 , I tagged this one as well with multi-cluster label.","author_login":"dmatch01","author_association":"COLLABORATOR","created_at":"2023-07-28T20:00:36+08:00","repo_name":"project-codeflare/multi-cluster-app-dispatcher","issue_id":1827007119,"issue_number":524,"issue_url":"https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/524","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0210","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Show percentage?","query_context":"While using the app, I found that sometimes I need to finish pomodoro timer early. In that case, I want to record how much did I spend - 70%, 50% for example. Let's make this option\n\nThis is adding new column named percentage","known_context_document_ids":["gh_issue_1452514134"],"reference_answer":"Hello, @TheRustyPickle. I'm sorry that I'm so busy (😢) that I have not researched about this issue.\nSo correct me if I'm wrong. \nAs I commented above, I found clap supports `clap_complete`. Could you take a look and see if it solves this issue?","answer_document_id":"gh_comment_1445140347","silver_evidence_path":["gh_comment_1444761047","gh_issue_1236602971","gh_comment_1445140347"],"evidence_issue_ids":[1452514134,1236602971],"source_repo_name":"24seconds/rust-cli-pomodoro","source_issue_id":1452514134,"source_issue_number":126,"source_issue_url":"https://github.com/24seconds/rust-cli-pomodoro/issues/126","target_repo_name":"24seconds/rust-cli-pomodoro","target_issue_id":1236602971,"target_issue_number":63,"target_issue_url":"https://github.com/24seconds/rust-cli-pomodoro/issues/63","reference_anchor_document_id":"gh_comment_1444761047","reference_answer_author":"24seconds","reference_answer_author_association":"OWNER","quality_score":77.63,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1364,"target_answer_overlap":0.0526},"issue_created_at":"2022-11-17T00:49:13+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_1452514134","fragment_type":"issue_description","sequence":0,"text":"Show percentage\nWhile using the app, I found that sometimes I need to finish pomodoro timer early. In that case, I want to record how much did I spend - 70%, 50% for example. Let's make this option\n\nThis is adding new column named percentage","author_login":"24seconds","author_association":"OWNER","created_at":"2022-11-17T00:49:13+08:00","repo_name":"24seconds/rust-cli-pomodoro","issue_id":1452514134,"issue_number":126,"issue_url":"https://github.com/24seconds/rust-cli-pomodoro/issues/126","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1317896124","fragment_type":"issue_comment","sequence":1,"text":"Maybe adding flag to `ls` would be fine. For example, `ls -p` would show the table with percentage columns.\n\n#### The percentage calculation\nLet say 1 pomodoro is consisted of 25 minutes work and 5 minutes break. But during the percentage calculation, break is not considered. \nFor example, If the time passed 10 minutes from I started the timer then the percentage should be (10/25 * 100 = 40%).\nIf the time passed more than 25 minutes (that means it's in the break time), then the percentage should be 100%, because work time has gone.","author_login":"24seconds","author_association":"OWNER","created_at":"2022-11-17T00:54:11+08:00","repo_name":"24seconds/rust-cli-pomodoro","issue_id":1452514134,"issue_number":126,"issue_url":"https://github.com/24seconds/rust-cli-pomodoro/issues/126","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1444761047","fragment_type":"issue_comment","sequence":2,"text":"Hello @TheRustyPickle ! Thank you for making PR and leaving comment here. Yesterday, I gave this issue to other person (#140). So.. how about this issues ? (#63 or #52). If you choose one of them, I will give you a detail guide if you need. Thank you again!\n\n@docongminh","author_login":"24seconds","author_association":"OWNER","created_at":"2023-02-25T00:02:09+08:00","repo_name":"24seconds/rust-cli-pomodoro","issue_id":1452514134,"issue_number":126,"issue_url":"https://github.com/24seconds/rust-cli-pomodoro/issues/126","linked_issue_ids":[1236602971],"is_known_query_context":false},{"document_id":"gh_comment_1445042813","fragment_type":"issue_comment","sequence":3,"text":"I can try working on #63. If you have any guide or tips, it would be quite helpful as well. Thank you, @24seconds!","author_login":"TheRustyPickle","author_association":"NONE","created_at":"2023-02-25T09:45:35+08:00","repo_name":"24seconds/rust-cli-pomodoro","issue_id":1452514134,"issue_number":126,"issue_url":"https://github.com/24seconds/rust-cli-pomodoro/issues/126","linked_issue_ids":[1236602971],"is_known_query_context":false},{"document_id":"gh_comment_1475101282","fragment_type":"issue_comment","sequence":4,"text":"@TheRustyPickle Ooops sorry. I missed this. I will write some guide soon.","author_login":"24seconds","author_association":"OWNER","created_at":"2023-03-19T04:37:25+08:00","repo_name":"24seconds/rust-cli-pomodoro","issue_id":1452514134,"issue_number":126,"issue_url":"https://github.com/24seconds/rust-cli-pomodoro/issues/126","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1475101842","fragment_type":"issue_comment","sequence":5,"text":"[Update]\nFor anyone who is interested in this issue, please feel free to work on.","author_login":"24seconds","author_association":"OWNER","created_at":"2023-03-19T04:40:04+08:00","repo_name":"24seconds/rust-cli-pomodoro","issue_id":1452514134,"issue_number":126,"issue_url":"https://github.com/24seconds/rust-cli-pomodoro/issues/126","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1487058928","fragment_type":"issue_comment","sequence":6,"text":"Hello @24seconds, I can work on this issue but I need suggestions on how to proceed. It seems the `Tabled` trait is implemented for the `Notification` struct, how would you recommend I should proceed to add the extra column when the `-p` flag is passed?","author_login":"TheRustyPickle","author_association":"CONTRIBUTOR","created_at":"2023-03-28T15:01:19+08:00","repo_name":"24seconds/rust-cli-pomodoro","issue_id":1452514134,"issue_number":126,"issue_url":"https://github.com/24seconds/rust-cli-pomodoro/issues/126","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1487996542","fragment_type":"issue_comment","sequence":7,"text":"Hello @TheRustyPickle , thank you for being interested in this issue!\nYes, I also looked up the code and I think we can do this with latest `tabled` package version (v0.10.0)\n\nThere are two options. Take a look tabled README.md\nTo do this, we should upgrade the version of `tabled` package.\n\n### Option1: use Disabled\nModify the `impl Tabled for Notification` part. Length should be 8. New column named `percentage`. Value should be `0%` to `100%`.\n\nIf the `list` is given, Disable the last column (`percentage`). If the `list -p` is given, then do not disable.\n\n### Option2: use Merge\nDo not modify notification.\nWhen handling the `list -p`, create another table based on notification. The table has only one column named `percentage` and the values are `0%` to `100%`.\nMerge current table and new table.\n\nI think both are fine. What do yo think?","author_login":"24seconds","author_association":"OWNER","created_at":"2023-03-29T06:05:54+08:00","repo_name":"24seconds/rust-cli-pomodoro","issue_id":1452514134,"issue_number":126,"issue_url":"https://github.com/24seconds/rust-cli-pomodoro/issues/126","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1488099130","fragment_type":"issue_comment","sequence":8,"text":"If you agree than I guess it would be nice to separate PRs\n- one for upgrading `tabled` version\n- the other one for implementing `show percentage` feature","author_login":"24seconds","author_association":"OWNER","created_at":"2023-03-29T07:45:00+08:00","repo_name":"24seconds/rust-cli-pomodoro","issue_id":1452514134,"issue_number":126,"issue_url":"https://github.com/24seconds/rust-cli-pomodoro/issues/126","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1488321476","fragment_type":"issue_comment","sequence":9,"text":"Thank you so much! I haven't finished reading Tabled docs or readme yet. Sorry if the question came out as naive😅\n\nPerhaps this one would be easier as the trait implementation function already has the data readily available?\n \n\nOf course. Will work on upgrading the `tabled` version.","author_login":"TheRustyPickle","author_association":"CONTRIBUTOR","created_at":"2023-03-29T10:14:27+08:00","repo_name":"24seconds/rust-cli-pomodoro","issue_id":1452514134,"issue_number":126,"issue_url":"https://github.com/24seconds/rust-cli-pomodoro/issues/126","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1488571729","fragment_type":"issue_comment","sequence":10,"text":"It's up to you @TheRustyPickle . Option1 or Option2 are totally fine. Or any suggestions are welcome.\n \n\nThank you!","author_login":"24seconds","author_association":"OWNER","created_at":"2023-03-29T13:05:29+08:00","repo_name":"24seconds/rust-cli-pomodoro","issue_id":1452514134,"issue_number":126,"issue_url":"https://github.com/24seconds/rust-cli-pomodoro/issues/126","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1236602971","fragment_type":"issue_description","sequence":0,"text":"Feature: command auto complete\n### Description\nWhen I use the git command, git supports auto complete. For example, I typed `git sta` and pressed `tab` then git showed suggestions. I can select one of suggestions with arrow keys (up/down) and tab and enter. \n\n<img width=\"522\" alt=\"image\" src=\" URL \nFig 1. `git sta` example\n\nIt would be nice for pomodoro to support this feature also","author_login":"24seconds","author_association":"OWNER","created_at":"2022-05-16T04:27:16+08:00","repo_name":"24seconds/rust-cli-pomodoro","issue_id":1236602971,"issue_number":63,"issue_url":"https://github.com/24seconds/rust-cli-pomodoro/issues/63","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1445139381","fragment_type":"issue_comment","sequence":1,"text":"To-be\n\n \n# After pressing the tab, then the terminal should show like this","author_login":"24seconds","author_association":"OWNER","created_at":"2023-02-25T15:11:30+08:00","repo_name":"24seconds/rust-cli-pomodoro","issue_id":1236602971,"issue_number":63,"issue_url":"https://github.com/24seconds/rust-cli-pomodoro/issues/63","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1445139749","fragment_type":"issue_comment","sequence":2,"text":"Maybe using this can solve this issue?\n- URL \n- related blog: URL","author_login":"24seconds","author_association":"OWNER","created_at":"2023-02-25T15:13:37+08:00","repo_name":"24seconds/rust-cli-pomodoro","issue_id":1236602971,"issue_number":63,"issue_url":"https://github.com/24seconds/rust-cli-pomodoro/issues/63","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1445140347","fragment_type":"issue_comment","sequence":3,"text":"Hello, @TheRustyPickle. I'm sorry that I'm so busy (😢) that I have not researched about this issue.\nSo correct me if I'm wrong. \nAs I commented above, I found clap supports `clap_complete`. Could you take a look and see if it solves this issue?","author_login":"24seconds","author_association":"OWNER","created_at":"2023-02-25T15:17:01+08:00","repo_name":"24seconds/rust-cli-pomodoro","issue_id":1236602971,"issue_number":63,"issue_url":"https://github.com/24seconds/rust-cli-pomodoro/issues/63","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0216","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Could not open '/lib64/ld-linux-x86-64.so.2' during devcontainer build?","query_context":"I'm trying to create a small dev container via VS Code's \"Add Dev Container Configuration Files\" option. I have selected only a couple other features (\"docker-in-docker\", \"go\", \"python\", and \"pre-commit\"). \n\nEvery time I select the pre-commit feature (also happens when manually adding the `\"ghcr.io/devcontainers-contrib/features/pre-commit:2\": {}` feature to the devcontainer.json) I see the following error when trying to build the devcontainer:\n\n[2022-12-29T16:13:59.722Z] ------\n \n#0 0.134 ===========================================================================\n#0 0.134 Feature : Pre-Commit (via pipx)\n#0 0.134 Description : Pre-Commit is a framework for managing and maintaining multi-language pre-commit hooks.\n#0 0.134 Id : ghcr.io/devcontainers-contrib/features/pre-commit\n#0 0.134 Version : 2.0.0\n#0 0.134 Documentation : URL \n#0 0.134 Options :\n#0 0.134 VERSION=\"latest\"\n#0 0.134 ===========================================================================\n#0 0.792 featmake: OK\n#0 0.808 qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such file or directory\n[2022-12-29T16:13:59.722Z] #0 0.810 ERROR: Feature \"Pre-Commit (via pipx)\" (ghcr.io/devcontainers-contrib/features/pre-commit) failed to install! Look at the documentation at URL for help troubleshooting this error.\n------\n[2022-12-29T16:13:59.722Z] ERROR: failed to solve: executor failed running [/bin/sh -c cd /tmp/build-features/pre-commit_4 && chmod +x ./devcontainer-features-install.sh && ./devcontainer-features-install.sh]: exit code: 255\n\nFor reference I'm running this on a 2021 16-inch MacBookPro with Apple M1 Pro processor (could the error be related to running this on an ARM processor?). Might I be missing something? The devcontainer works fine when removing the pre-commit feature and installing pre-commit manually (using pip3, for example).","known_context_document_ids":["gh_issue_1514016009"],"reference_answer":"from version 0.0.16 and up featmake is now not a binary but a raw shell script, you can open it with any text editor","answer_document_id":"gh_comment_1399239126","silver_evidence_path":["gh_comment_1382044337","gh_issue_1515951110","gh_comment_1399239126"],"evidence_issue_ids":[1514016009,1515951110],"source_repo_name":"devcontainers-contrib/features","source_issue_id":1514016009,"source_issue_number":223,"source_issue_url":"https://github.com/devcontainers-contrib/features/issues/223","target_repo_name":"devcontainers-contrib/features","target_issue_id":1515951110,"target_issue_number":246,"target_issue_url":"https://github.com/devcontainers-contrib/features/issues/246","reference_anchor_document_id":"gh_comment_1382044337","reference_answer_author":"danielbraun89","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.25,"anchor_target_overlap":0.25,"target_answer_overlap":0.1818},"issue_created_at":"2022-12-29T20:00:15+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_1514016009","fragment_type":"issue_description","sequence":0,"text":"Could not open '/lib64/ld-linux-x86-64.so.2' during devcontainer build\nI'm trying to create a small dev container via VS Code's \"Add Dev Container Configuration Files\" option. I have selected only a couple other features (\"docker-in-docker\", \"go\", \"python\", and \"pre-commit\"). \n\nEvery time I select the pre-commit feature (also happens when manually adding the `\"ghcr.io/devcontainers-contrib/features/pre-commit:2\": {}` feature to the devcontainer.json) I see the following error when trying to build the devcontainer:\n\n[2022-12-29T16:13:59.722Z] ------\n \n#0 0.134 ===========================================================================\n#0 0.134 Feature : Pre-Commit (via pipx)\n#0 0.134 Description : Pre-Commit is a framework for managing and maintaining multi-language pre-commit hooks.\n#0 0.134 Id : ghcr.io/devcontainers-contrib/features/pre-commit\n#0 0.134 Version : 2.0.0\n#0 0.134 Documentation : URL \n#0 0.134 Options :\n#0 0.134 VERSION=\"latest\"\n#0 0.134 ===========================================================================\n#0 0.792 featmake: OK\n#0 0.808 qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such file or directory\n[2022-12-29T16:13:59.722Z] #0 0.810 ERROR: Feature \"Pre-Commit (via pipx)\" (ghcr.io/devcontainers-contrib/features/pre-commit) failed to install! Look at the documentation at URL for help troubleshooting this error.\n------\n[2022-12-29T16:13:59.722Z] ERROR: failed to solve: executor failed running [/bin/sh -c cd /tmp/build-features/pre-commit_4 && chmod +x ./devcontainer-features-install.sh && ./devcontainer-features-install.sh]: exit code: 255\n\nFor reference I'm running this on a 2021 16-inch MacBookPro with Apple M1 Pro processor (could the error be related to running this on an ARM processor?). Might I be missing something? The devcontainer works fine when removing the pre-commit feature and installing pre-commit manually (using pip3, for example).","author_login":"jeremydelacruz","author_association":"NONE","created_at":"2022-12-29T20:00:15+08:00","repo_name":"devcontainers-contrib/features","issue_id":1514016009,"issue_number":223,"issue_url":"https://github.com/devcontainers-contrib/features/issues/223","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1368602729","fragment_type":"issue_comment","sequence":1,"text":"Here's some more info from around the web on that error message for reference:\n \n \n \n\nFrom this StackOverflow question: URL \n\n \n\nIncidentally, in case it's helpful to another who lands here, I have the same\nissue on an M1 Max MacBook Pro laptop attempting to do a `docker build` from a\ncompany repo that should be a pretty well traveled path, but I might be the only\none (it's a small company) that has an ARM64 M1 \"Apple Silicon\" Mac. **_However\nI found the solution (well, a solution) to my situation was exactly the opposite\nof the solution to the OP's, and that was to\nadd_** `--platform=linux/amd64` **_to the FROM line of the docker file._**\n\nOtherwise it was using an ARM64 image to start from without me being the wiser\nbut then later in the Dockerfile the build attempts to install and execute code\ncompiled for x86_64. Starting the build process by requesting the base image\nbe `linux/amd64` ends up with then the base image\nhaving `/lib64/ld-linux-x86-64.so.2`. This probably means everything is being\nemulated as x86_64 on the ARM64 CPU via `qemu-x86_64` and so if you have the\noption to start from an ARM64 image and can compile within the container during\nbuild time any software you can't install as ARM64 binaries, it'll probably go\nfaster when you later run the container on the M1 based Mac. I'm not able to try\nthat myself just yet for this case.\n\n \n\nFrom this StackOverflow question: URL \n\n \n\nIf you are running this on an M1 macbook, it's possible that you are running a\nnative Arm image of ubuntu, instead of the emulated x86 image. If the\nelasticsearch distribution you are trying to install is for x86_64, then it\nattempts to link to the x86-64-native ld.so, which of course isn't present on\ndifferent platforms.\n\nEither install the package for the arm platform specifically if they provide\none, or - more likely - run docker explicitly as the emulated x86_64 platform:\n\ndocker run --platform linux/x86_64","author_login":"jcbhmr","author_association":"CONTRIBUTOR","created_at":"2023-01-02T01:51:35+08:00","repo_name":"devcontainers-contrib/features","issue_id":1514016009,"issue_number":223,"issue_url":"https://github.com/devcontainers-contrib/features/issues/223","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1382042497","fragment_type":"issue_comment","sequence":2,"text":"I've seen and dealt with that kind of issue before with other docker images, but I'm trying to use the VS Code built in options and UI for dev containers — not manually running `docker` from CLI, so the flag in this use case doesn't seem ideal. \n\nAlso, I'm curious as to why it might work fine out of the box with all the other features enabled except this one?","author_login":"jeremydelacruz","author_association":"NONE","created_at":"2023-01-13T15:50:00+08:00","repo_name":"devcontainers-contrib/features","issue_id":1514016009,"issue_number":223,"issue_url":"https://github.com/devcontainers-contrib/features/issues/223","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1382044337","fragment_type":"issue_comment","sequence":3,"text":"I think this is due to the fact that you are installing the amd64 binary of featmake.\nSee #246.","author_login":"eitsupi","author_association":"NONE","created_at":"2023-01-13T15:51:48+08:00","repo_name":"devcontainers-contrib/features","issue_id":1514016009,"issue_number":223,"issue_url":"https://github.com/devcontainers-contrib/features/issues/223","linked_issue_ids":[1515951110],"is_known_query_context":false},{"document_id":"gh_comment_1473930954","fragment_type":"issue_comment","sequence":4,"text":"Should be fixed now that featmake and oras usage has been deprecated. Installation of pre-commit feature should be ARM compatible as any utility (including featmake`s replacement - dcontainer) is being installed on ARM as vanila pipx install, instead of a binary.","author_login":"danielbraun89","author_association":"MEMBER","created_at":"2023-03-17T14:29:46+08:00","repo_name":"devcontainers-contrib/features","issue_id":1514016009,"issue_number":223,"issue_url":"https://github.com/devcontainers-contrib/features/issues/223","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1515951110","fragment_type":"issue_description","sequence":0,"text":"What is featmake?\nSome Features seem to install a binary called featmake, but the source code for this does not appear to be publicly available.\n\n URL \n\nInstalling binaries of unknown origin may be unwelcome.","author_login":"eitsupi","author_association":"NONE","created_at":"2023-01-02T01:45:32+08:00","repo_name":"devcontainers-contrib/features","issue_id":1515951110,"issue_number":246,"issue_url":"https://github.com/devcontainers-contrib/features/issues/246","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1368605630","fragment_type":"issue_comment","sequence":1,"text":"I think this is part of @danielbraun89's fancy new CLI that does some feature magic. I'm not personally on board, but it seems like this is the direction he's taking the project. 🤷‍♂️\n\nRegarding random binaries, yeah I think a link or something would be a good idea. The docs also need to be improved big time for this new direction too, both in this repo and in the CLI repo. @danielbraun89 I can help with that 😉📝\n\nRegarding the public/private I wholeheartedly agree. I can find the spot that hosts the asset: URL but I can't really find out what generated it... 🤔","author_login":"jcbhmr","author_association":"CONTRIBUTOR","created_at":"2023-01-02T02:02:34+08:00","repo_name":"devcontainers-contrib/features","issue_id":1515951110,"issue_number":246,"issue_url":"https://github.com/devcontainers-contrib/features/issues/246","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1368738349","fragment_type":"issue_comment","sequence":2,"text":"its a bunch of .sh files which uses oras to download and unpackage a feature package, set environment variable from its declared defaults, and then runs the features `install.sh` . I compiled the shell files using sch as a way of packaging them a single file without introducing another requirements( `unzip`) beyond `curl` and `oras` . In hindsight it doesnt add enough value to warrant it Ill just combine them all into a single merged .sh file and live with that 😄","author_login":"danielbraun89","author_association":"MEMBER","created_at":"2023-01-02T08:31:04+08:00","repo_name":"devcontainers-contrib/features","issue_id":1515951110,"issue_number":246,"issue_url":"https://github.com/devcontainers-contrib/features/issues/246","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1399239126","fragment_type":"issue_comment","sequence":3,"text":"from version 0.0.16 and up featmake is now not a binary but a raw shell script, you can open it with any text editor","author_login":"danielbraun89","author_association":"MEMBER","created_at":"2023-01-21T12:06:51+08:00","repo_name":"devcontainers-contrib/features","issue_id":1515951110,"issue_number":246,"issue_url":"https://github.com/devcontainers-contrib/features/issues/246","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1459429155","fragment_type":"issue_comment","sequence":4,"text":"For anyone looking like I was, the script mentioned above `merged_featmake.sh` is now just `featmake.sh` after (commit 3333faf)","author_login":"jarrodcolburn","author_association":"NONE","created_at":"2023-03-08T04:27:28+08:00","repo_name":"devcontainers-contrib/features","issue_id":1515951110,"issue_number":246,"issue_url":"https://github.com/devcontainers-contrib/features/issues/246","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1465091043","fragment_type":"issue_comment","sequence":5,"text":"@danielbraun89 @jcbhmr \n### From what I can tell `featmake` tries to make `features` more modular, a worthy DRY goal! But irnoically, I'm worried it is repetitive of efforts. \n\nBoth CLIs...\n* devcontainers/cli \n* decvontainers-contrib/cli \n\n...parse variables and pass/begin initialization (ex: `install.sh`).*\n\n`decvontainers-contrib/cli`, python, runs inside the container, while `devcontainers/cli`, javascript, has access to docker outside the container and many more features.\n\n**So why the duplication of efforts? Has anyone spoken to the maintainers of `devcontainers/cli` to see if they can modularize and extract the functionality we want to use for modularity and reused functionality?**\n---------\n\nA quick recap for those who don't know what `featmake` does. An exmaple...\n\nIf two separate features exists, A and B, such that...\n- A. installs `Homebrew` \n- B. installs `NeoVim` via `Homebrew`\n\n...`feature B` reuses `feature A` by doing the following step...\nFrom with Feature B's `docker/devcontainer`....\n1. download `oras`\n2. use `oras` to download and extract `feature A`\n3. `featmake` parses `json` and becins initialization of `feature A`.\n\n---------\n\nAll these steps seem to be implemented within the `devcontainers/cli` already.","author_login":"jarrodcolburn","author_association":"NONE","created_at":"2023-03-12T04:39:21+08:00","repo_name":"devcontainers-contrib/features","issue_id":1515951110,"issue_number":246,"issue_url":"https://github.com/devcontainers-contrib/features/issues/246","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0218","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Reference id not matching with documentElement id?","query_context":"**To Reproduce**\n\nReceiving this response from Azure AD:\n\nxml\n \n STRIPPED \n \n \n \n \n STRIPPED \n \n \n \n \n STRIPPED \n \n \n STRIPPED \n \n \n STRIPPED \n \n \n \n \n STRIPPED \n \n \n \n \n \n STRIPPED \n \n \n \n STRIPPED \n \n STRIPPED \n \n STRIPPED \n \n STRIPPED \n \n urn:oasis:names:tc:SAML:2.0:ac:classes:PasswordProtectedTransport \n URL \n \n STRIPPED \n STRIPPED \n STRIPPED \n \n STRIPPED \n \n STRIPPED \n \n STRIPPED \n \n STRIPPED \n \n \n \n \n urn:oasis:names:tc:SAML:2.0:ac:classes:PasswordProtectedTransport \n \n \n \n \n\nWhen validating the signature, the documentElement of the SAML response is used and the reference id tries to match with the id of it. But they don't match, instead the reference id matches with the ` `-Element id, thus successfully validating the signature is not possible.\n\n**Expected behavior**\nSignature should validate successfully.\n\n**Environment**\n\n- Node.js version: 16.14.0\n- `passport-saml` version: 4.0.4","known_context_document_ids":["gh_issue_1736068303"],"reference_answer":"The change was intended as it is in harmony with the secure-by-default philosophy that we have here. Please feel free to put up a PR to help us with our README.","answer_document_id":"gh_comment_1828405987","silver_evidence_path":["gh_comment_1572152351","gh_issue_1677161072","gh_comment_1828405987"],"evidence_issue_ids":[1736068303,1677161072],"source_repo_name":"node-saml/passport-saml","source_issue_id":1736068303,"source_issue_number":863,"source_issue_url":"https://github.com/node-saml/passport-saml/issues/863","target_repo_name":"node-saml/passport-saml","target_issue_id":1677161072,"target_issue_number":859,"target_issue_url":"https://github.com/node-saml/passport-saml/issues/859","reference_anchor_document_id":"gh_comment_1572152351","reference_answer_author":"cjbarth","reference_answer_author_association":"COLLABORATOR","quality_score":85.4,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0882,"anchor_target_overlap":0.0882,"target_answer_overlap":0.0833},"issue_created_at":"2023-06-01T11:09:11+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_1736068303","fragment_type":"issue_description","sequence":0,"text":"Reference id not matching with documentElement id\n**To Reproduce**\n\nReceiving this response from Azure AD:\n\nxml\n \n STRIPPED \n \n \n \n \n STRIPPED \n \n \n \n \n STRIPPED \n \n \n STRIPPED \n \n \n STRIPPED \n \n \n \n \n STRIPPED \n \n \n \n \n \n STRIPPED \n \n \n \n STRIPPED \n \n STRIPPED \n \n STRIPPED \n \n STRIPPED \n \n urn:oasis:names:tc:SAML:2.0:ac:classes:PasswordProtectedTransport \n URL \n \n STRIPPED \n STRIPPED \n STRIPPED \n \n STRIPPED \n \n STRIPPED \n \n STRIPPED \n \n STRIPPED \n \n \n \n \n urn:oasis:names:tc:SAML:2.0:ac:classes:PasswordProtectedTransport \n \n \n \n \n\nWhen validating the signature, the documentElement of the SAML response is used and the reference id tries to match with the id of it. But they don't match, instead the reference id matches with the ` `-Element id, thus successfully validating the signature is not possible.\n\n**Expected behavior**\nSignature should validate successfully.\n\n**Environment**\n\n- Node.js version: 16.14.0\n- `passport-saml` version: 4.0.4","author_login":"Kittenhunter","author_association":"NONE","created_at":"2023-06-01T11:09:11+08:00","repo_name":"node-saml/passport-saml","issue_id":1736068303,"issue_number":863,"issue_url":"https://github.com/node-saml/passport-saml/issues/863","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1571923848","fragment_type":"issue_comment","sequence":1,"text":"Setting `wantAuthnResponseSigned` to false \"solved\" the issue so far. But I would really like to keep it active, to grant the highest security possible.","author_login":"Kittenhunter","author_association":"NONE","created_at":"2023-06-01T12:02:21+08:00","repo_name":"node-saml/passport-saml","issue_id":1736068303,"issue_number":863,"issue_url":"https://github.com/node-saml/passport-saml/issues/863","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1571990376","fragment_type":"issue_comment","sequence":2,"text":"What did you get when testing over at URL If you got it to work, what options did you select on their web page?","author_login":"cjbarth","author_association":"COLLABORATOR","created_at":"2023-06-01T12:47:38+08:00","repo_name":"node-saml/passport-saml","issue_id":1736068303,"issue_number":863,"issue_url":"https://github.com/node-saml/passport-saml/issues/863","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1572144197","fragment_type":"issue_comment","sequence":3,"text":"Both Request and Response are valid. Do you have any other specific test in mind?","author_login":"Kittenhunter","author_association":"NONE","created_at":"2023-06-01T14:17:13+08:00","repo_name":"node-saml/passport-saml","issue_id":1736068303,"issue_number":863,"issue_url":"https://github.com/node-saml/passport-saml/issues/863","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1572152351","fragment_type":"issue_comment","sequence":4,"text":"The error comes not from upgrading of a previous version.\nThank you for your hint about the behavior of Azure AD. I will take a deeper look at the configuration of Azure AD to enable response signing.\nThis indeed looks like it is not a bug in the first place but rather a configuration error now.\nSo we likely can close this issue, but please wait until I looked the config tomorrow.","author_login":"Kittenhunter","author_association":"NONE","created_at":"2023-06-01T14:21:55+08:00","repo_name":"node-saml/passport-saml","issue_id":1736068303,"issue_number":863,"issue_url":"https://github.com/node-saml/passport-saml/issues/863","linked_issue_ids":[1677161072],"is_known_query_context":false},{"document_id":"gh_comment_1572190295","fragment_type":"issue_comment","sequence":5,"text":"@srd90 I've created a Wiki page that summarized this. Hopefully that will save you some time. Feel free to edit it, or let me know in an issue reply if you'd like some text added to it and I'll do it.\n\n URL","author_login":"cjbarth","author_association":"COLLABORATOR","created_at":"2023-06-01T14:44:20+08:00","repo_name":"node-saml/passport-saml","issue_id":1736068303,"issue_number":863,"issue_url":"https://github.com/node-saml/passport-saml/issues/863","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1573499686","fragment_type":"issue_comment","sequence":6,"text":"Thank you very much with your help.\nI've looked at the SAML configuration and found the option to enable the response and assertion signing option.\nIt can be found, when editing the SAML certificate.","author_login":"Kittenhunter","author_association":"NONE","created_at":"2023-06-02T10:20:14+08:00","repo_name":"node-saml/passport-saml","issue_id":1736068303,"issue_number":863,"issue_url":"https://github.com/node-saml/passport-saml/issues/863","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1677161072","fragment_type":"issue_description","sequence":0,"text":"[BUG] Invalid document signature\nCould you help me to know why I have this error after we updated from passport-saml to @node-saml/passport-saml:\n\nError: Invalid document signature\n at SAML.validatePostResponseAsync (/usr/src/server/node_modules/@node-saml/node-saml/lib/saml.js:510:23)\n at runMicrotasks ( )\n at processTicksAndRejections (node:internal/process/task_queues:96:5)","author_login":"royalcala","author_association":"NONE","created_at":"2023-04-20T17:49:43+08:00","repo_name":"node-saml/passport-saml","issue_id":1677161072,"issue_number":859,"issue_url":"https://github.com/node-saml/passport-saml/issues/859","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1516826940","fragment_type":"issue_comment","sequence":1,"text":"Perhaps your issue is the same as URL or URL If not, please post more information about the versions your running and a minimal test case. Ideally we'd like to see a PR with a test that fails.","author_login":"cjbarth","author_association":"COLLABORATOR","created_at":"2023-04-20T19:19:29+08:00","repo_name":"node-saml/passport-saml","issue_id":1677161072,"issue_number":859,"issue_url":"https://github.com/node-saml/passport-saml/issues/859","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1631803564","fragment_type":"issue_comment","sequence":2,"text":"We also encountered such error and the workaround was adding the following options:\n\njs\n // After updating from `passport-saml` to `@node-saml/passport-saml`,\n // it started throwing `Error: Invalid document signature`\n // when testing SSO using Acadeum's Google SAML server.\n // Turns out that's a common issue and the workaround is to pass\n // `wantAssertionsSigned: false` / `wantAuthnResponseSigned: false` flags.\n // URL \n // URL \n wantAssertionsSigned: false,\n wantAuthnResponseSigned: false,","author_login":"catamphetamine","author_association":"NONE","created_at":"2023-07-12T03:44:34+08:00","repo_name":"node-saml/passport-saml","issue_id":1677161072,"issue_number":859,"issue_url":"https://github.com/node-saml/passport-saml/issues/859","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1828346012","fragment_type":"issue_comment","sequence":3,"text":"I encountered the same issue and after quite some digging in code this seems to be indeed because in `validatePostResponseAsync` method, the default value in `this.options.wantAssertionsSigned` is true if not specified in SamlConfig whereas it was false in v3.\n\n@cjbarth are you sure this is an intended behavior ? I feel `wantAssertionsSigned` should be false if not specified in config","author_login":"edwandr","author_association":"NONE","created_at":"2023-11-27T17:58:39+08:00","repo_name":"node-saml/passport-saml","issue_id":1677161072,"issue_number":859,"issue_url":"https://github.com/node-saml/passport-saml/issues/859","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1828405987","fragment_type":"issue_comment","sequence":4,"text":"The change was intended as it is in harmony with the secure-by-default philosophy that we have here. Please feel free to put up a PR to help us with our README.","author_login":"cjbarth","author_association":"COLLABORATOR","created_at":"2023-11-27T18:37:48+08:00","repo_name":"node-saml/passport-saml","issue_id":1677161072,"issue_number":859,"issue_url":"https://github.com/node-saml/passport-saml/issues/859","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1829410605","fragment_type":"issue_comment","sequence":5,"text":"Ok I understand but then indeed it would be great to specify it in documentation, I can open a PR for that 👍\nWhat would have been really helpful also is to add it as a breaking change in the changelog, I don't know if it's automatically generated or if it's possible to also update it now","author_login":"edwandr","author_association":"NONE","created_at":"2023-11-28T09:21:15+08:00","repo_name":"node-saml/passport-saml","issue_id":1677161072,"issue_number":859,"issue_url":"https://github.com/node-saml/passport-saml/issues/859","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1830010638","fragment_type":"issue_comment","sequence":6,"text":"I agree this would be useful to highlight as a breaking change in the Changelog.","author_login":"markstos","author_association":"CONTRIBUTOR","created_at":"2023-11-28T14:54:57+08:00","repo_name":"node-saml/passport-saml","issue_id":1677161072,"issue_number":859,"issue_url":"https://github.com/node-saml/passport-saml/issues/859","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0227","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"FS22 Lumberjack nopt working in multiplayer/dedicated server?","query_context":"I noticed that deleting trees by using the chainsaw red ring no longer works in multiplayer. When the tree or stump is supposed to disappear the chainsaw snaps back a bit but just continues to saw and spew sahavings. Nothing else happens. In career mode it still works like a charm :)\n\nDo we know why this is?","known_context_document_ids":["gh_issue_1282979174"],"reference_answer":"Please let me know if this version has resolved the issue: URL \n\nI guess it will not do anything to your terrain issue caused by previously removed trees, but hopefully should prevent the problem occuring again.","answer_document_id":"gh_comment_1122211678","silver_evidence_path":["gh_comment_1164919482","gh_issue_1222204688","gh_comment_1122211678"],"evidence_issue_ids":[1282979174,1222204688],"source_repo_name":"loki79uk/FS22_LumberJack","source_issue_id":1282979174,"source_issue_number":5,"source_issue_url":"https://github.com/loki79uk/FS22_LumberJack/issues/5","target_repo_name":"loki79uk/FS22_LumberJack","target_issue_id":1222204688,"target_issue_number":4,"target_issue_url":"https://github.com/loki79uk/FS22_LumberJack/issues/4","reference_anchor_document_id":"gh_comment_1164919482","reference_answer_author":"loki79uk","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1053,"anchor_target_overlap":0.3158,"target_answer_overlap":0.1053},"issue_created_at":"2022-06-23T21:48:51+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_1282979174","fragment_type":"issue_description","sequence":0,"text":"FS22 Lumberjack nopt working in multiplayer/dedicated server\nI noticed that deleting trees by using the chainsaw red ring no longer works in multiplayer. When the tree or stump is supposed to disappear the chainsaw snaps back a bit but just continues to saw and spew sahavings. Nothing else happens. In career mode it still works like a charm :)\n\nDo we know why this is?","author_login":"billieidle","author_association":"NONE","created_at":"2022-06-23T21:48:51+08:00","repo_name":"loki79uk/FS22_LumberJack","issue_id":1282979174,"issue_number":5,"issue_url":"https://github.com/loki79uk/FS22_LumberJack/issues/5","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1164919482","fragment_type":"issue_comment","sequence":1,"text":"That must be due to the recent update to fix the un-deleted trees bug #4. I thought I tested that in MP, but I guess not! You can always go back to the previous release for now while I look into it: URL","author_login":"loki79uk","author_association":"OWNER","created_at":"2022-06-23T21:56:53+08:00","repo_name":"loki79uk/FS22_LumberJack","issue_id":1282979174,"issue_number":5,"issue_url":"https://github.com/loki79uk/FS22_LumberJack/issues/5","linked_issue_ids":[1222204688],"is_known_query_context":false},{"document_id":"gh_comment_1164978418","fragment_type":"issue_comment","sequence":2,"text":"Not sure how to download mods manually. Any chance you can point me in the right direction? Removing the mod from the server and uploading the previous release to the server and placing it in the mod folder on the harddrive seems like the logical way to go.","author_login":"billieidle","author_association":"NONE","created_at":"2022-06-23T22:34:45+08:00","repo_name":"loki79uk/FS22_LumberJack","issue_id":1282979174,"issue_number":5,"issue_url":"https://github.com/loki79uk/FS22_LumberJack/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1165331806","fragment_type":"issue_comment","sequence":3,"text":"I think it was the most embarrasing mistake I've ever made!\nimage\n\nAt least easy to fix. New release incoming.","author_login":"loki79uk","author_association":"OWNER","created_at":"2022-06-24T08:25:53+08:00","repo_name":"loki79uk/FS22_LumberJack","issue_id":1282979174,"issue_number":5,"issue_url":"https://github.com/loki79uk/FS22_LumberJack/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1222204688","fragment_type":"issue_description","sequence":0,"text":"[BUG] Removing trees is cosmetic only\nI used this mod to clear trees by waiting for the chainsaw indicator circle to turn red. Using the chainsaw will cause the tree to disappear. However, the tree is not actually removed but rather just made invisible.\n\nYou can test this by trying to change the elevation of the land where the tree is. Removing the tree the traditional way by cutting it down and then removing the stump with a machine allows the land to be changed. Unfortunately, if you use this mod to quickly remove the tree, it's impossible to cause the tree to not exist in ghost form.\n\nIs there a fix for this in the meantime while you fix the mod? I don't see where original map trees are stored in the save game folder, only manually planted trees.","author_login":"gSe7eN","author_association":"NONE","created_at":"2022-05-01T16:11:56+08:00","repo_name":"loki79uk/FS22_LumberJack","issue_id":1222204688,"issue_number":4,"issue_url":"https://github.com/loki79uk/FS22_LumberJack/issues/4","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1114277144","fragment_type":"issue_comment","sequence":1,"text":"I've been trying to find a permanent fix for this since FS19, but have given up now. As a workaround you can either cut down the tree, then delete the stump and tree separately OR you can delete the tree directly, save the game and reload. Either of those should work as expected.","author_login":"loki79uk","author_association":"OWNER","created_at":"2022-05-01T16:19:28+08:00","repo_name":"loki79uk/FS22_LumberJack","issue_id":1222204688,"issue_number":4,"issue_url":"https://github.com/loki79uk/FS22_LumberJack/issues/4","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1114277831","fragment_type":"issue_comment","sequence":2,"text":"Is there anything that can be done about about the trees I've already, for lack of a better term, ghosted? I'm not afraid to dive in and get my hands dirty editing the files directly IF only I knew where to look. I can't find them anywhere.\n\nIn the future, I'll be sure to do as you say so thank you for confirming that part.","author_login":"gSe7eN","author_association":"NONE","created_at":"2022-05-01T16:22:59+08:00","repo_name":"loki79uk/FS22_LumberJack","issue_id":1222204688,"issue_number":4,"issue_url":"https://github.com/loki79uk/FS22_LumberJack/issues/4","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1116682142","fragment_type":"issue_comment","sequence":3,"text":"It should be fine if you just save the game and reload. Once all of the trees are reloaded from the savegame, the deleted trees should not be in the far distance (LOD) view anymore. HOWEVER, I've actually spent some time on this over the last few days and now have a fix working in single player. Still need to rewrite and test for multiplayer, but thanks for reminding me about it! :D","author_login":"loki79uk","author_association":"OWNER","created_at":"2022-05-03T21:34:16+08:00","repo_name":"loki79uk/FS22_LumberJack","issue_id":1222204688,"issue_number":4,"issue_url":"https://github.com/loki79uk/FS22_LumberJack/issues/4","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1116700695","fragment_type":"issue_comment","sequence":4,"text":"That's really great news! I found that quitting and restarting the game does NOT fix the issue. (I did notice the LOD effect at first. It didn't bother me since I'm not a detailed oriented person, it was the terrain that was really messing up my plans). I did find a work around but it's not ideal. Removing a file in the saved game (I forget what one, but it's not a simple plain text file) restored all the default trees for the map. It took a LOT of time and work, but I was able to remove those tree properly and flatten or raise the terrain.\n\nI'm really glad you found a solution to the bug, this is a great mod!","author_login":"gSe7eN","author_association":"NONE","created_at":"2022-05-03T21:55:20+08:00","repo_name":"loki79uk/FS22_LumberJack","issue_id":1222204688,"issue_number":4,"issue_url":"https://github.com/loki79uk/FS22_LumberJack/issues/4","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1122211678","fragment_type":"issue_comment","sequence":5,"text":"Please let me know if this version has resolved the issue: URL \n\nI guess it will not do anything to your terrain issue caused by previously removed trees, but hopefully should prevent the problem occuring again.","author_login":"loki79uk","author_association":"OWNER","created_at":"2022-05-10T10:30:22+08:00","repo_name":"loki79uk/FS22_LumberJack","issue_id":1222204688,"issue_number":4,"issue_url":"https://github.com/loki79uk/FS22_LumberJack/issues/4","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0232","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Icecast only loading or no sound on iOS in Angular?","query_context":"Hello Ethan,\n\nfirst of all thank you for your hard work. I really like it and it works perfectly on Android. Unfortunately I can't get it to work on iOS. I am using Ionic and Angular. The stream is loading (network tab of developer console), but I can't hear anything. The event listener gives success on play, no error. The stream keeps on loading.\n\nIf I use a standard html5 audio without your script the stream plays fine. I really look forward to use your icecast-metadata-player.\n\nDo you have any idea?","known_context_document_ids":["gh_issue_1203245435"],"reference_answer":"After you've cloned the repo, and checked out the PR, you can point directly to the `icecast-metadata-player` folder in your `package.json`. Example: `\"icecast-metadata-player:\" \"file:path-to-icecast-metadata-js-clone/src/icecast-metadata-player\"`. I use this method every time I am testing with the demo page.","answer_document_id":"gh_comment_1073268546","silver_evidence_path":["gh_comment_1132359999","gh_issue_1154526730","gh_comment_1073268546"],"evidence_issue_ids":[1203245435,1154526730],"source_repo_name":"eshaz/icecast-metadata-js","source_issue_id":1203245435,"source_issue_number":119,"source_issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","target_repo_name":"eshaz/icecast-metadata-js","target_issue_id":1154526730,"target_issue_number":107,"target_issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/107","reference_anchor_document_id":"gh_comment_1132359999","reference_answer_author":"eshaz","reference_answer_author_association":"OWNER","quality_score":91.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2653,"anchor_target_overlap":0.1045,"target_answer_overlap":0.0},"issue_created_at":"2022-04-13T12:39:06+08:00","valid_comment_count":29,"fragments":[{"document_id":"gh_issue_1203245435","fragment_type":"issue_description","sequence":0,"text":"Icecast only loading or no sound on iOS in Angular\nHello Ethan,\n\nfirst of all thank you for your hard work. I really like it and it works perfectly on Android. Unfortunately I can't get it to work on iOS. I am using Ionic and Angular. The stream is loading (network tab of developer console), but I can't hear anything. The event listener gives success on play, no error. The stream keeps on loading.\n\nIf I use a standard html5 audio without your script the stream plays fine. I really look forward to use your icecast-metadata-player.\n\nDo you have any idea?","author_login":"wunschradio","author_association":"NONE","created_at":"2022-04-13T12:39:06+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1098071443","fragment_type":"issue_comment","sequence":1,"text":"Which version of iOS are you testing with? Also, could you try out the demo page of this repo on the iOS device you're testing with and see if that works?\n\nYou might want to look through some of the previous issues here regarding iOS, if you haven't already. There might be some information in there you would find helpful.","author_login":"eshaz","author_association":"OWNER","created_at":"2022-04-13T13:46:38+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1098178258","fragment_type":"issue_comment","sequence":2,"text":"Thank you for your reply. Using iOS 15.4 and latest cordova-ios@6.2. Tested with older cordova-ios versions, too.\nThe demo page works in the browser of the phone. I read all I could find about it. Been struggeling with it a couple of days now.","author_login":"wunschradio","author_association":"NONE","created_at":"2022-04-13T15:16:32+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1098215520","fragment_type":"issue_comment","sequence":3,"text":"I'm not familiar with Cordova.\n\nI would suggest putting together a test app using that tool with just a play button and a hardcoded stream URL and see if that works. Essentially to try narrowing down the issue if one exists in the library \n\nThere are also a few parameters you might for `IcecastMetadataPlayer` that you could try such as changing the `playbackMethod` and see if you get any more feedback from that.","author_login":"eshaz","author_association":"OWNER","created_at":"2022-04-13T15:50:56+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1098271791","fragment_type":"issue_comment","sequence":4,"text":"Unfortunately the same. I build a very minimalistic app. Stream loads, no play. As it is working in browser I think its because of my setup with Cordova. Maybe somewhen somebody might post a solution here.","author_login":"wunschradio","author_association":"NONE","created_at":"2022-04-13T16:48:55+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1129335428","fragment_type":"issue_comment","sequence":5,"text":"I have an icecast mp3 stream that does play with IcecastMetadataPlayer on iOS Safari and on iOS Firefox. I can't hear anything on iOS Chrome. Also, in none of these iOS browsers I am able to use AnalyserNode to read and visualize the sound levels (as bars that go up and down in a frequency spectrum). This visualization (data from analyser being all zeroes) seems to be a known issue and I can live without it. In desktop Chrome and Android Chrome the audio plays and I can also visualize the audio. On iOS I just use a generic animation that does not reflect the audio levels.\n\nI might be able to provide useful debug information. My goal at the moment is to get sound in iOS Chrome.","author_login":"jonathandv","author_association":"NONE","created_at":"2022-05-17T21:30:22+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1129420182","fragment_type":"issue_comment","sequence":6,"text":"That's very odd that there is no sound in only iOS Chrome, but other iOS browsers work fine. As far as I'm aware, iOS uses the same WebKit engine behind the scenes for all browsers.\n\nWhat version of iOS and Chrome are you testing with?\n\nIn iOS, MP3 and Opus streams are decoded in WASM and played through the WebAudio API. If you want to clone down the repo and debug, you'd probably have the best luck starting here where the AudioContext is set up before playback starts.\n\n URL","author_login":"eshaz","author_association":"OWNER","created_at":"2022-05-17T23:36:54+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1130569068","fragment_type":"issue_comment","sequence":7,"text":"Thanks for your reply!\n\nI'm testing on an iPad with iOS 15.3.1 and iOS Chrome 101.0.4951.58. I've noticed that with iOS Chrome I also can't hear sound in the demo on URL while iOS Safari does produce sound.\n\nI've set up my environment such that I can put breakpoints in iOS Safari and view the console of iOS Chrome (unfortunately I don't know how I can arrange breakpoints in iOS Chrome). I've added console.log()'s to IcecastMetadataPlayer though, and I can already see a difference in the logs between my app in iOS Safari and iOS Chrome.\n\niOS Safari: IcecastMetadataPlayer.play() gets called twice, and the sound works.\niOS Chrome: IcecastMetadataPlayer.play() gets called once, and then WebAudioPlayer._getAudioContext() gets called once, and the sound doesn't work.\n\nWebAudioPlayer._getAudioContext() does not get called in iOS Safari.\n\nThere is a chance that this difference is related to my implementation in my app, but I don't think I'm doing anything special. I've just followed the example from the documentation.\n\nI suppose now we just have to figure out where the code paths start to deviate for the 2 browsers. I'm not very familiar with IcecastMetadataPlayer but I'm willing to investigate further :) Any tips though are greatly appreciated!","author_login":"jonathandv","author_association":"NONE","created_at":"2022-05-18T21:28:42+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1132359999","fragment_type":"issue_comment","sequence":8,"text":"Would you be able to paste a stack trace that shows where the MediaSource error is being thrown? I have a guess where that's coming from, but I'm not entirely sure.\n\nCould you also try setting `playbackMethod` to `webaudio` and `html5` in the options when instantiating IcecastMetadataPlayer? You can also select the playback method in the HTML demo page.\n\nWorst case scenario, you should still get playback through the HTML5 audio element playback method. There are a few things that can prevent HTML5 audio playback, other than a bug in the library, such as not interacting with the page to start playback: see URL Sometimes there are quirks / differences in how browser enforce standards like this.\n\nMediaSource support has been absent in iOS for a very long time even though it's been a standard for many years now. (Probably not due to any technical reasons...) Now that you mention you're using an iPad, I remember reading somewhere that MediaSource support was added to some degree on the iPad. I've never tried MediaSource on an iPad, since I can't install Chrome on the iPad Simulator. It's possible there are quirks in how it's implemented.\n\n_Some background on how IcecastMetadataPlayer works:_\nIcecastMetadataPlayer tries to detect the supported playback method by reading the audio codec from the Icecast stream and then checking for MediaSource, WebAudio, and HTML5 support. If MediaSource and Web Audio aren't supported by the browser or the audio codec isn't supported, then HTML5 audio is used as a fallback. ICY and Ogg Metadata will still be read and displayed by the first request, and a second request is started to play the audio in the HTML5 Audio element. This isn't ideal, since there are two requests, one for metadata and another for audio playback, but it shouldn't really happen since MediaSource and WebAudio should be supported by all mainstream browsers.","author_login":"eshaz","author_association":"OWNER","created_at":"2022-05-20T01:40:41+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[1154526730],"is_known_query_context":false},{"document_id":"gh_comment_1133255718","fragment_type":"issue_comment","sequence":9,"text":"Thanks for the explanation! I've also read the code and I understand the flow now.\n\nHere is the stack trace for the thrown error in iOS Chrome:\n\nERROR ReferenceError: Can't find variable: MediaSource\ncanPlayType @ URL \n_buildPlayer @ URL \n @ URL \ngeneratorResume @[native code]\nOx @ URL \no @ URL \nonInvoke @ URL \nrun @ URL \n @ URL \nonInvokeTask @ URL \nrunTask @ URL \n_ @ URL \npromiseReactionJob @[native code]\n\nThis is in WebAudioPlayer.js on line 43:\n\n`new MediaSource();`\n\nEven though caniuse.com says MediaSource is supported by iOS Chrome (since iOS 13, I think), it's not working. Strangely in iOS Safari the constructor does work. I've also tried WebKitMediaSource but it cannot be found by iOS Chrome either.\n\nAssuming that iOS Chrome just doesn't work with MediaSource, I can try and get WebAudio to work. It seems possible because for at least 1 particular mp3 stream on the HTML Demo page, iOS Chrome DOES play sound (though not in the React app...). The HTML demo tells me that WebAudio is being used in that case.\n\nSetting HTML5 as player in my app does not work. No sound played, but I can try debug it later.\n\nNow, I'm trying WebAudio and adding console.logs to WebAudioPlayer._getAudioContext(). I can see that the audio context state is set to 'running' when resume() is called. But no sound yet. Any idea which property is good to inspect? In the meantime I'll investigate further.","author_login":"jonathandv","author_association":"NONE","created_at":"2022-05-20T19:34:03+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1133528374","fragment_type":"issue_comment","sequence":10,"text":"Thanks for the stack trace and the debugging so far. I fixed that MediaSource error and a bug in iOS playback #121.\n\nThere was a bug when using the Audio element controls in iOS where the AudioContext wouldn't start properly so there would be no sound. iOS prevents AudioContext from running when it's not triggered directly by a user interaction, even when the user clicks the \"play\" button on the Audio element controls. I'm not sure if was related to your issue.\n\nCould you give `icecast-metadata-player/1.11.7` a try and see if that helps or changes anything?","author_login":"eshaz","author_association":"OWNER","created_at":"2022-05-21T04:23:38+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1133643331","fragment_type":"issue_comment","sequence":11,"text":"I've tried version 1.11.7 but I can't hear sound yet in iOS Chrome. Looking at the changes in #121 I assume an audio element needs to be present in the html? I did not have that before. So I've now tried adding it and passing it on to the IcecastMetadataPlayer constructor but no luck. I do see in my logs that when I click on the play button of the audio element, the resume() promise in unlock() is being called and resolved. As an experiment I also tried removing the call to resume() in WebAudioPlayer._initAudioContext(), because it seems to me it shouldn't be used together with the other resume()?\n\nUnfortunately I don't know the ins and outs of the code and of playing audio on the web well enough to know what to do. But I can help with testing and experimenting when needed. For now I do have iOS Safari still available, which I assume most iOS users will use. But it would be great to support iOS Chrome as well. I still have hope that it can work, because the HTML demo page DOES play sound in iOS Chrome for some of the stream I tried.\n\nI appreciate your help so far. Let me know if I can be of further assistance. A clear head after taking a break might also help me :)","author_login":"jonathandv","author_association":"NONE","created_at":"2022-05-21T14:26:53+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1133645022","fragment_type":"issue_comment","sequence":12,"text":"Same here. I was hoping this would fix my problem, too. The stream is loading but I can't hear any sound. The log looks the same as on android, no errors - load, start buffer and play is triggered.","author_login":"wunschradio","author_association":"NONE","created_at":"2022-05-21T14:38:31+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1133650111","fragment_type":"issue_comment","sequence":13,"text":"@jonathandv Which streams work and don't work on the demo page? If there's some correlation to audio codec or something like that, it would help narrow down this issue. Could you also post a screenshot of the supported codecs table on the HTML Demo page that shows up on iOS Chrome? It's the table just below the player controls on the demo. What audio codec is the stream that you have on your page?\n\nThe Audio element isn't required to be in the HTML, it's just one of the ways to use IcecastMetadataPlayer. This is useful if someone just wants to use the controls on the Audio element to start and stop playback, rather than using the `.play()` and `.stop()` methods. Essentially this makes it a drop in library for a page that already has an Audio element on it.","author_login":"eshaz","author_association":"OWNER","created_at":"2022-05-21T15:10:59+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1133668974","fragment_type":"issue_comment","sequence":14,"text":"With latest versions of iOS Chrome and iOS Safari.\n\nStream: URL \niOS Chrome, HTML demo : ok\niOS Chrome, React demo: sound does not work (but does show stream metadata).\niOS Safari, HTML demo : ok\niOS Safari, React demo: ok\n \nStream: URL \niOS Chrome, HTML demo : ok\niOS Chrome, React demo: sound does not work (says: \"Waiting for metadata...\").\niOS Safari, HTML demo : ok\niOS Safari, React demo: ok\n\nStreams other than mp3 don't seem to play in iOS Chrome in the HTML demo (at least: no audio).\n\nMy stream I prefer not to share right now (not meant for public), but it is an icecast mp3 stream and I printed the codec to the console: 'audio/mpeg; codecs=\"mpeg\"'. It plays in iOS Safari using MediaSource, and does not play in iOS Chrome (using WebAudio). But I've been testing with the 2 public streams above, to make the scenario as close as possible in my app.\n\niOS Safari:\niOS_Safari\n\niOS Chrome:\niOS_Chrome","author_login":"jonathandv","author_association":"NONE","created_at":"2022-05-21T16:57:25+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1133994525","fragment_type":"issue_comment","sequence":15,"text":"I think I finally found the issue on this one.\n\nOne of my downstream dependencies had a compatibility issue with bundlers that polyfill ES6 classes. This was causing the web audio decoder to not serialize all of the code when it is loaded as a web worker. In the React demo, this error only happens in the production build, which is heavily minified and polyfilled by the create-react-app build pipeline. Additionally, it only shows up on platforms that don't support MediaSource, i.e. iOS.\n\nI've released a fix in icecast-metadata-player/1.11.8. Could you try that out?","author_login":"eshaz","author_association":"OWNER","created_at":"2022-05-22T22:01:52+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1136327692","fragment_type":"issue_comment","sequence":16,"text":"Untitled\n\nThank you so much! :) The sound now also works properly in iOS Chrome. I've tested your React demo app and my own app.\n\nI'll have a look at the changes and learn from them. Getting to know the code better will make it easier to contribute, maybe the next time.\n\nI did notice 2 things:\n- the first couple of times in my app sometimes the sound wouldn't play, but I haven't been able to reproduce it. It might have been a temporary caching issue.\n- when I stop the sound and try to start it again it doesn't play anymore (only in iOS Chrome, in my app). I haven't investigated this yet and is maybe easily solved. I'll report back if turns out to be something real.","author_login":"jonathandv","author_association":"NONE","created_at":"2022-05-24T19:03:15+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1140151375","fragment_type":"issue_comment","sequence":17,"text":"@wunschradio, have you had a chance to try out icecast-metadata-player/1.11.9 to see if that solves your issue?","author_login":"eshaz","author_association":"OWNER","created_at":"2022-05-28T03:03:57+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1140286399","fragment_type":"issue_comment","sequence":18,"text":"@wunschradio Excellent, thanks for confirming!\n \n\n@jonathandv If you think this is a problem with this library, could you open another issue? We can continue investigating there if needed.\n\nThank you both for helping work through this issue!","author_login":"eshaz","author_association":"OWNER","created_at":"2022-05-28T15:45:03+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1203245435,"issue_number":119,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/119","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1154526730","fragment_type":"issue_description","sequence":0,"text":"Handle autoplay exceptions\nHey,\n\nnewer browsers need a permission to play audio automatically on site load. I've made an audio player that remembers its latest play state and resumes playing on site reload. If the site doesn't have the autoplay enabled, calling `play()` will result in an unhandled promise exception:\n\nimage\n\nConsole message: Uncaught (in promise) DOMException: play() failed because the user didn't interact with the document first. URL \n\nYou might want to look into this and handle the exception properly so I can act on it from within my player code.\n\nThanks!","author_login":"karolyi","author_association":"NONE","created_at":"2022-02-28T20:38:16+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1154526730,"issue_number":107,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/107","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1056066920","fragment_type":"issue_comment","sequence":1,"text":"Are you able to catch this exception when you call `play()`? If so, I don't think there needs to be anything done in IcecastMetadataPlayer to handle this exception since it was thrown as expected. \n\nHandling browser autoplay is out of scope of this library. You might have some luck in solving this for your usecase by checking out this guide.","author_login":"eshaz","author_association":"OWNER","created_at":"2022-03-02T02:19:25+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1154526730,"issue_number":107,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/107","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1056595494","fragment_type":"issue_comment","sequence":2,"text":"Hey,\n\nI've tried catching it but neither a try-catch, nor a .catch() on the promise helped, hence why I'm posting this issue here. It's fine with me if I can catch it, the problem is I can't.","author_login":"karolyi","author_association":"NONE","created_at":"2022-03-02T08:48:40+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1154526730,"issue_number":107,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/107","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1058125400","fragment_type":"issue_comment","sequence":3,"text":"Do you have a code example of where the error happens after starting playback automatically that you could share?","author_login":"eshaz","author_association":"OWNER","created_at":"2022-03-03T14:57:12+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1154526730,"issue_number":107,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/107","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1058127103","fragment_type":"issue_comment","sequence":4,"text":"Yes.\n\nThe player I built ( URL is live on URL (although wepacked).\n\nYou can test it there.","author_login":"karolyi","author_association":"NONE","created_at":"2022-03-03T14:58:53+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1154526730,"issue_number":107,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/107","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1058844737","fragment_type":"issue_comment","sequence":5,"text":"Thanks for letting me know about this one! I really thought any exception here would be thrown, but it turns out that is not the case when it's thrown inside of an event listener.\n\nI created a new branch with a change that will send any errors from the `play()` call on the audio element through the `onError` callback. If you want to test it out, you can checkout the branch in #108. If you have the `enableLogging` option set, you will also see the error logged in the console:\n\nimage","author_login":"eshaz","author_association":"OWNER","created_at":"2022-03-04T05:34:37+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1154526730,"issue_number":107,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/107","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1073262583","fragment_type":"issue_comment","sequence":6,"text":"Hey,\n\nI'm trying to test this but for the love of god I can't check out the respective pull requests with npm as the package.json for the player is in a subdirectory and npm doesn't like that with a referred pull request.\n\nIf I clone the repo into a subdirectory, change to the referred pull head and give that path to NPM to install from, it will complain that it can't find modules since they're not within node_modules.\n\nHave you ever tried to do the same? I'm afraid I can't test your package as is now.","author_login":"karolyi","author_association":"NONE","created_at":"2022-03-20T14:25:46+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1154526730,"issue_number":107,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/107","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1073268546","fragment_type":"issue_comment","sequence":7,"text":"After you've cloned the repo, and checked out the PR, you can point directly to the `icecast-metadata-player` folder in your `package.json`. Example: `\"icecast-metadata-player:\" \"file:path-to-icecast-metadata-js-clone/src/icecast-metadata-player\"`. I use this method every time I am testing with the demo page.","author_login":"eshaz","author_association":"OWNER","created_at":"2022-03-20T14:57:00+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1154526730,"issue_number":107,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/107","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1073270362","fragment_type":"issue_comment","sequence":8,"text":"yeah, I managed it so far but webpack bails out hard when using it this way:\n\njavascript\nERROR in ../../opensource/icecast-metadata-js/src/icecast-metadata-player/src/IcecastMetadataPlayer.js 20:0-59\nModule not found: Error: Can't resolve 'icecast-metadata-js' in '/home/karolyi/Work/opensource/icecast-metadata-js/src/icecast-metadata-player/src'\n @ ./src/index.ts 1:0-60 77:38-59 82:29-50\n\nERROR in ../../opensource/icecast-metadata-js/src/icecast-metadata-player/src/PlayerFactory.js 1:0-60\nModule not found: Error: Can't resolve 'icecast-metadata-js' in '/home/karolyi/Work/opensource/icecast-metadata-js/src/icecast-metadata-player/src'\n @ ../../opensource/icecast-metadata-js/src/icecast-metadata-player/src/IcecastMetadataPlayer.js 26:0-47 186:37-50\n @ ./src/index.ts 1:0-60 77:38-59 82:29-50\n\nERROR in ../../opensource/icecast-metadata-js/src/icecast-metadata-player/src/PlayerFactory.js 2:0-39\nModule not found: Error: Can't resolve 'codec-parser' in '/home/karolyi/Work/opensource/icecast-metadata-js/src/icecast-metadata-player/src'\n @ ../../opensource/icecast-metadata-js/src/icecast-metadata-player/src/IcecastMetadataPlayer.js 26:0-47 186:37-50\n @ ./src/index.ts 1:0-60 77:38-59 82:29-50\n\nERROR in ../../opensource/icecast-metadata-js/src/icecast-metadata-player/src/players/MediaSourcePlayer.js 1:0-48\nModule not found: Error: Can't resolve 'mse-audio-wrapper' in '/home/karolyi/Work/opensource/icecast-metadata-js/src/icecast-metadata-player/src/players'\n @ ../../opensource/icecast-metadata-js/src/icecast-metadata-player/src/IcecastMetadataPlayer.js 27:0-63 197:19-48\n @ ./src/index.ts 1:0-60 77:38-59 82:29-50\n\nERROR in ../../opensource/icecast-metadata-js/src/icecast-metadata-player/src/players/WebAudioPlayer.js 1:0-52\nModule not found: Error: Can't resolve 'opus-decoder' in '/home/karolyi/Work/opensource/icecast-metadata-js/src/icecast-metadata-player/src/players'\n @ ../../opensource/icecast-metadata-js/src/icecast-metadata-player/src/IcecastMetadataPlayer.js 29:0-57 199:16-42\n @ ./src/index.ts 1:0-60 77:38-59 82:29-50\n\nERROR in ../../opensource/icecast-metadata-js/src/icecast-metadata-player/src/players/WebAudioPlayer.js 2:0-54\nModule not found: Error: Can't resolve 'mpg123-decoder' in '/home/karolyi/Work/opensource/icecast-metadata-js/src/icecast-metadata-player/src/players'\n @ ../../opensource/icecast-metadata-js/src/icecast-metadata-player/src/IcecastMetadataPlayer.js 29:0-57 199:16-42\n @ ./src/index.ts 1:0-60 77:38-59 82:29-50\n\nERROR in /home/karolyi/Work/private/karolyimusic-webplayer/src/index.ts\n./src/index.ts 15:12-18\n[tsl] ERROR in /home/karolyi/Work/private/karolyimusic-webplayer/src/index.ts(15,13)\n TS2345: Argument of type 'IconDefinition' is not assignable to parameter of type 'IconDefinitionOrPack'.\n Type 'IconDefinition' is not assignable to type 'IconPack'.\n Index signature for type 'string' is missing in type 'IconDefinition'.\n\nERROR in /home/karolyi/Work/private/karolyimusic-webplayer/src/index.ts\n./src/index.ts 202:14-205:5\n[tsl] ERROR in /home/karolyi/Work/private/karolyimusic-webplayer/src/index.ts(202,15)\n TS2554: Expected 0 arguments, but got 1.\n\nI'm clueless so far, working on it as we speak. Don't hesitate to tell me if you have an idea :)","author_login":"karolyi","author_association":"NONE","created_at":"2022-03-20T15:04:45+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1154526730,"issue_number":107,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/107","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1073272350","fragment_type":"issue_comment","sequence":9,"text":"Okay, so the missing modules are now installed with going under src/icecast-metadata-player and executing npm install.\n\nOne would think that that's executed automatically upon installing, doesn't seem to be the case.\n\nI'm gonna resolve the other issues and touch base with the results of my testing.","author_login":"karolyi","author_association":"NONE","created_at":"2022-03-20T15:13:52+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1154526730,"issue_number":107,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/107","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1073283165","fragment_type":"issue_comment","sequence":10,"text":"Thanks, I managed to update it and testing it with my player.\n\nWill continue adding remarks under the PR.","author_login":"karolyi","author_association":"NONE","created_at":"2022-03-20T16:12:15+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1154526730,"issue_number":107,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/107","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1073347504","fragment_type":"issue_comment","sequence":11,"text":"@karolyi, I've released this feature in icecast-metadata-player/1.11.5. Thanks for helping to improve this library!","author_login":"eshaz","author_association":"OWNER","created_at":"2022-03-20T20:58:28+08:00","repo_name":"eshaz/icecast-metadata-js","issue_id":1154526730,"issue_number":107,"issue_url":"https://github.com/eshaz/icecast-metadata-js/issues/107","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0244","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Double free() in global object destruction in 7.10.1 (regression from 7.10.0)?","query_context":"I'm getting double free() error of memory block allocated by **pqxx::internal::demangle_type_name**.\n\nSystem: Arch Linux\nlibpqxx version: 7.10.1\nUsed compiler: clang++ 20.1.6\n\nValgrind output:\n`[pavenis@ap test]$ valgrind ./CellTest \n==1688117== Memcheck, a memory error detector\n==1688117== Copyright (C) 2002-2024, and GNU GPL'd, by Julian Seward et al.\n==1688117== Using Valgrind-3.25.1 and LibVEX; rerun with -h for copyright info\n==1688117== Command: ./CellTest\n==1688117== \n\nCell tests\n==========\nRunning 2 test cases...\n+ [is_saddle(Cell)]\n+ [minmax(Cell)]\n\n*** No errors detected\n==1688117== Invalid free() / delete / delete[] / realloc()\n==1688117== at 0x496D8DD: operator delete(void*, unsigned long) (vg_replace_malloc.c:1181)\n==1688117== by 0x672C05F: __cxa_finalize (cxa_finalize.c:97)\n==1688117== by 0x9033B97: ??? (in /usr/lib/libpqxx-7.10.so)\n==1688117== by 0x4125FD1: _dl_call_fini (dl-call_fini.c:43)\n==1688117== by 0x41291B1: _dl_fini (dl-fini.c:120)\n==1688117== by 0x672C5E0: __run_exit_handlers (exit.c:118)\n==1688117== by 0x672C6BD: exit (exit.c:148)\n==1688117== by 0x67136BB: (below main) (libc_start_call_main.h:74)\n==1688117== Address 0xbd623c0 is 0 bytes inside a block of size 129 free'd\n==1688117== at 0x496D8DD: operator delete(void*, unsigned long) (vg_replace_malloc.c:1181)\n==1688117== by 0x4062D64: std::__new_allocator ::deallocate(char*, unsigned long) (new_allocator.h:172)\n==1688117== by 0x4062CCF: deallocate (allocator.h:215)\n==1688117== by 0x4062CCF: deallocate (alloc_traits.h:649)\n==1688117== by 0x4062CCF: std::__cxx11::basic_string , std::allocator >::_M_destroy(unsigned long) (basic_string.h:305)\n==1688117== by 0x4062BD9: std::__cxx11::basic_string , std::allocator >::_M_dispose() (basic_string.h:299)\n==1688117== by 0x404CB48: std::__cxx11::basic_string , std::allocator >::~basic_string() (basic_string.h:896)\n==1688117== by 0x672C05F: __cxa_finalize (cxa_finalize.c:97)\n==1688117== by 0x69B55E7: ??? (in /usr/lib/libsmartmet-macgyver.so)\n==1688117== by 0x4125FD1: _dl_call_fini (dl-call_fini.c:43)\n==1688117== by 0x41291B1: _dl_fini (dl-fini.c:120)\n==1688117== by 0x672C5E0: __run_exit_handlers (exit.c:118)\n==1688117== by 0x672C6BD: exit (exit.c:148)\n==1688117== by 0x67136BB: (below main) (libc_start_call_main.h:74)\n==1688117== Block was alloc'd at\n==1688117== at 0x4969F93: operator new(unsigned long) (vg_replace_malloc.c:487)\n==1688117== by 0x904ABC5: UnknownInlinedFun (new_allocator.h:151)\n==1688117== by 0x904ABC5: UnknownInlinedFun (alloc_traits.h:614)\n==1688117== by 0x904ABC5: UnknownInlinedFun (basic_string.h:142)\n==1688117== by 0x904ABC5: UnknownInlinedFun (basic_string.tcc:164)\n==1688117== by 0x904ABC5: UnknownInlinedFun (basic_string.tcc:235)\n==1688117== by 0x904ABC5: UnknownInlinedFun (basic_string.h:692)\n==1688117== by 0x904ABC5: pqxx::internal::demangle_type_nameabi:cxx11 (strconv.cxx:245)\n==1688117== by 0x69B47CB: __cxx_global_var_init.33 (strconv.hxx:80)\n==1688117== by 0x41292F6: call_init (dl-init.c:74)\n==1688117== by 0x41292F6: call_init (dl-init.c:26)\n==1688117== by 0x41293CC: _dl_init (dl-init.c:121)\n==1688117== by 0x414161F: ??? (in /usr/lib/ld-linux-x86-64.so.2)\n==1688117== \n==1688117== \n==1688117== HEAP SUMMARY:\n==1688117== in use at exit: 330 bytes in 5 blocks\n==1688117== total heap usage: 7,058 allocs, 7,054 frees, 1,461,985 bytes allocated\n==1688117== \n==1688117== LEAK SUMMARY:\n==1688117== definitely lost: 129 bytes in 1 blocks\n==1688117== indirectly lost: 0 bytes in 0 blocks\n==1688117== possibly lost: 0 bytes in 0 blocks\n==1688117== still reachable: 201 bytes in 4 blocks\n==1688117== suppressed: 0 bytes in 0 blocks\n==1688117== Rerun with --leak-check=full to see details of leaked memory\n==1688117== \n==1688117== For lists of detected and suppressed errors, rerun with: -s\n==1688117== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)\n`\n\nProgram was a one of the test of URL","known_context_document_ids":["gh_issue_3192217050"],"reference_answer":"No need to change compilers for this... Don't get me wrong, clang is an excellent compiler. But one of those tricks to producing top-quality code is to run it through as many compilers as you can, and pay attention to the errors or warnings they produce.\n\nSo... do both. :-)","answer_document_id":"gh_comment_1536803949","silver_evidence_path":["gh_comment_3027685448","gh_issue_1693971058","gh_comment_1536803949"],"evidence_issue_ids":[3192217050,1693971058],"source_repo_name":"jtv/libpqxx","source_issue_id":3192217050,"source_issue_number":1007,"source_issue_url":"https://github.com/jtv/libpqxx/issues/1007","target_repo_name":"jtv/libpqxx","target_issue_id":1693971058,"target_issue_number":681,"target_issue_url":"https://github.com/jtv/libpqxx/issues/681","reference_anchor_document_id":"gh_comment_3027685448","reference_answer_author":"jtv","reference_answer_author_association":"OWNER","quality_score":93.08,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.25,"target_answer_overlap":0.0417},"issue_created_at":"2025-07-01T12:08:46+08:00","valid_comment_count":38,"fragments":[{"document_id":"gh_issue_3192217050","fragment_type":"issue_description","sequence":0,"text":"Double free() in global object destruction in 7.10.1 (regression from 7.10.0)\nI'm getting double free() error of memory block allocated by **pqxx::internal::demangle_type_name**.\n\nSystem: Arch Linux\nlibpqxx version: 7.10.1\nUsed compiler: clang++ 20.1.6\n\nValgrind output:\n`[pavenis@ap test]$ valgrind ./CellTest \n==1688117== Memcheck, a memory error detector\n==1688117== Copyright (C) 2002-2024, and GNU GPL'd, by Julian Seward et al.\n==1688117== Using Valgrind-3.25.1 and LibVEX; rerun with -h for copyright info\n==1688117== Command: ./CellTest\n==1688117== \n\nCell tests\n==========\nRunning 2 test cases...\n+ [is_saddle(Cell)]\n+ [minmax(Cell)]\n\n*** No errors detected\n==1688117== Invalid free() / delete / delete[] / realloc()\n==1688117== at 0x496D8DD: operator delete(void*, unsigned long) (vg_replace_malloc.c:1181)\n==1688117== by 0x672C05F: __cxa_finalize (cxa_finalize.c:97)\n==1688117== by 0x9033B97: ??? (in /usr/lib/libpqxx-7.10.so)\n==1688117== by 0x4125FD1: _dl_call_fini (dl-call_fini.c:43)\n==1688117== by 0x41291B1: _dl_fini (dl-fini.c:120)\n==1688117== by 0x672C5E0: __run_exit_handlers (exit.c:118)\n==1688117== by 0x672C6BD: exit (exit.c:148)\n==1688117== by 0x67136BB: (below main) (libc_start_call_main.h:74)\n==1688117== Address 0xbd623c0 is 0 bytes inside a block of size 129 free'd\n==1688117== at 0x496D8DD: operator delete(void*, unsigned long) (vg_replace_malloc.c:1181)\n==1688117== by 0x4062D64: std::__new_allocator ::deallocate(char*, unsigned long) (new_allocator.h:172)\n==1688117== by 0x4062CCF: deallocate (allocator.h:215)\n==1688117== by 0x4062CCF: deallocate (alloc_traits.h:649)\n==1688117== by 0x4062CCF: std::__cxx11::basic_string , std::allocator >::_M_destroy(unsigned long) (basic_string.h:305)\n==1688117== by 0x4062BD9: std::__cxx11::basic_string , std::allocator >::_M_dispose() (basic_string.h:299)\n==1688117== by 0x404CB48: std::__cxx11::basic_string , std::allocator >::~basic_string() (basic_string.h:896)\n==1688117== by 0x672C05F: __cxa_finalize (cxa_finalize.c:97)\n==1688117== by 0x69B55E7: ??? (in /usr/lib/libsmartmet-macgyver.so)\n==1688117== by 0x4125FD1: _dl_call_fini (dl-call_fini.c:43)\n==1688117== by 0x41291B1: _dl_fini (dl-fini.c:120)\n==1688117== by 0x672C5E0: __run_exit_handlers (exit.c:118)\n==1688117== by 0x672C6BD: exit (exit.c:148)\n==1688117== by 0x67136BB: (below main) (libc_start_call_main.h:74)\n==1688117== Block was alloc'd at\n==1688117== at 0x4969F93: operator new(unsigned long) (vg_replace_malloc.c:487)\n==1688117== by 0x904ABC5: UnknownInlinedFun (new_allocator.h:151)\n==1688117== by 0x904ABC5: UnknownInlinedFun (alloc_traits.h:614)\n==1688117== by 0x904ABC5: UnknownInlinedFun (basic_string.h:142)\n==1688117== by 0x904ABC5: UnknownInlinedFun (basic_string.tcc:164)\n==1688117== by 0x904ABC5: UnknownInlinedFun (basic_string.tcc:235)\n==1688117== by 0x904ABC5: UnknownInlinedFun (basic_string.h:692)\n==1688117== by 0x904ABC5: pqxx::internal::demangle_type_nameabi:cxx11 (strconv.cxx:245)\n==1688117== by 0x69B47CB: __cxx_global_var_init.33 (strconv.hxx:80)\n==1688117== by 0x41292F6: call_init (dl-init.c:74)\n==1688117== by 0x41292F6: call_init (dl-init.c:26)\n==1688117== by 0x41293CC: _dl_init (dl-init.c:121)\n==1688117== by 0x414161F: ??? (in /usr/lib/ld-linux-x86-64.so.2)\n==1688117== \n==1688117== \n==1688117== HEAP SUMMARY:\n==1688117== in use at exit: 330 bytes in 5 blocks\n==1688117== total heap usage: 7,058 allocs, 7,054 frees, 1,461,985 bytes allocated\n==1688117== \n==1688117== LEAK SUMMARY:\n==1688117== definitely lost: 129 bytes in 1 blocks\n==1688117== indirectly lost: 0 bytes in 0 blocks\n==1688117== possibly lost: 0 bytes in 0 blocks\n==1688117== still reachable: 201 bytes in 4 blocks\n==1688117== suppressed: 0 bytes in 0 blocks\n==1688117== Rerun with --leak-check=full to see details of leaked memory\n==1688117== \n==1688117== For lists of detected and suppressed errors, rerun with: -s\n==1688117== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)\n`\n\nProgram was a one of the test of URL","author_login":"apavenis","author_association":"NONE","created_at":"2025-07-01T12:08:46+08:00","repo_name":"jtv/libpqxx","issue_id":3192217050,"issue_number":1007,"issue_url":"https://github.com/jtv/libpqxx/issues/1007","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_3026539261","fragment_type":"issue_comment","sequence":1,"text":"I was not running test program under Valgrind just for fun\n\nAll test executables of the same project crashed with error message like for the same tests without valgrind:\n`Running tests:\n\nCell tests\n==========\nRunning 2 test cases...\n+ [is_saddle(Cell)]\n+ [minmax(Cell)]\n\n*** No errors detected\nfree(): double free detected in tcache 2\n`\nSo I do not think that this is valgrind false positive.","author_login":"apavenis","author_association":"NONE","created_at":"2025-07-02T05:49:38+08:00","repo_name":"jtv/libpqxx","issue_id":3192217050,"issue_number":1007,"issue_url":"https://github.com/jtv/libpqxx/issues/1007","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3026834710","fragment_type":"issue_comment","sequence":2,"text":"Version 7.10.0 was skipped for ArchLinux (7.10.1 was next after 7.9.2).\n1) rebuilt 7.10.1 using PKGBUILD from URL - problem remains\n2) I modified PKGBUILD to use 7.10.0 instead and built it - no double free any more\n\nThat confirms, that the problem is regression in 7.10.1 from 7.10.0","author_login":"apavenis","author_association":"NONE","created_at":"2025-07-02T07:52:34+08:00","repo_name":"jtv/libpqxx","issue_id":3192217050,"issue_number":1007,"issue_url":"https://github.com/jtv/libpqxx/issues/1007","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3027685448","fragment_type":"issue_comment","sequence":3,"text":"Also... any chance that `tcache` is part of the problem? See #681 for instance.","author_login":"jtv","author_association":"OWNER","created_at":"2025-07-02T12:26:30+08:00","repo_name":"jtv/libpqxx","issue_id":3192217050,"issue_number":1007,"issue_url":"https://github.com/jtv/libpqxx/issues/1007","linked_issue_ids":[1693971058],"is_known_query_context":false},{"document_id":"gh_comment_3027746654","fragment_type":"issue_comment","sequence":4,"text":"It could be the same:\n`[pavenis@ap ~]$ ( echo \"#include \"; echo '#include '; echo 'int main() { return 0; };' ) | g++ -std=c++17 -O2 -x c++ - -o /tmp/do-nothing -lpqxx && /tmp/do-nothing\nIn file included from /usr/include/pqxx/internal/header-pre.hxx:70,\n from /usr/include/pqxx/pqxx:2,\n from :1:\n/usr/include/c++/15.1.1/ciso646:46:4: warning: #warning \" is deprecated in C++17, use to detect implementation-specific macros\" [-Wcpp]\n 46 | # warning \" is deprecated in C++17, use to detect implementation-specific macros\"\n | ^~~~~~~\nfree(): double free detected in tcache 2\nAborted (core dumped)\n`\n\nIn RockyLinux 10 the same command line does not cause SIGABRT \nIn part of earlier tests one module of used shared library included both pqxx/pqxx and iostream, and that was sufficient to cause failure. It did not matter that test program itself did not use.\n\nMore testing: installed gcc14 in ArchLinux:\n`[pavenis@ap ~]$ ( echo \"#include \"; echo '#include '; echo 'int main() { return 0; };' ) | g++-14 -std=c++17 -O2 -x c++ - -o /tmp/do-nothing -lpqxx && /tmp/do-nothing\n[pavenis@ap ~]$ \n`\nSo no error with g++14, only with gcc-15.\nCould possibly be regression in gcc","author_login":"apavenis","author_association":"NONE","created_at":"2025-07-02T12:46:36+08:00","repo_name":"jtv/libpqxx","issue_id":3192217050,"issue_number":1007,"issue_url":"https://github.com/jtv/libpqxx/issues/1007","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3036895116","fragment_type":"issue_comment","sequence":5,"text":"Thanks for spotting that @apavenis ! I thought the implementation would update `*length` to the string length. This function's API keeps messing with my head. It _looks_ like an output parameter, right?\n\nI think I wrote up something better: #1008. Could you have a look?","author_login":"jtv","author_association":"OWNER","created_at":"2025-07-04T17:05:51+08:00","repo_name":"jtv/libpqxx","issue_id":3192217050,"issue_number":1007,"issue_url":"https://github.com/jtv/libpqxx/issues/1007","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3070236457","fragment_type":"issue_comment","sequence":6,"text":"@apavenis I made one more update to the `master` implementation of this function... I doubt it'll fix the problem but I can't see anything else that I could improve there.\n\nThings may get better in libpqxx 8 which replaces the variable with a function, and in 9 the existing variable will disappear completely. In C++26 I hope I'll be able to eliminate the whole problem in a portable way by using Reflection.\n\nCan't really think of anything else to do about this... Shall we just close the ticket?","author_login":"jtv","author_association":"OWNER","created_at":"2025-07-14T16:38:36+08:00","repo_name":"jtv/libpqxx","issue_id":3192217050,"issue_number":1007,"issue_url":"https://github.com/jtv/libpqxx/issues/1007","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3086612688","fragment_type":"issue_comment","sequence":7,"text":"Rechecked with project where I initially found problem.\nUsed configure command for my own builds: ./configure --prefix=/usr --enable-shared --disable-static followed by **make -j...** and **sudo make install**\n- 7.10.1 from ArchLinux distribution: fails\n- 7.10.1 git tag, my own build: fails\n- current master (42ee59508f26cae1f0473122de311bf3e4641561), my own build: OK (no failure)\n\nSo it seems that the problem is however fixed.\nI guess there is no need to keep the ticket open","author_login":"apavenis","author_association":"NONE","created_at":"2025-07-18T03:48:05+08:00","repo_name":"jtv/libpqxx","issue_id":3192217050,"issue_number":1007,"issue_url":"https://github.com/jtv/libpqxx/issues/1007","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3088615502","fragment_type":"issue_comment","sequence":8,"text":"Tried. Initially had some configure issue - incorrectly complained that compiler must support c++20 as g++ 15 and clang++ 20 supports. **make distclean** and **autoreconf** resolved it. Tested with URL Only 1 source of it uses libpqxx, but all test executables have double free problem when 7.10.1 is installed, no problems with current master and start-8 branch","author_login":"apavenis","author_association":"NONE","created_at":"2025-07-18T08:53:10+08:00","repo_name":"jtv/libpqxx","issue_id":3192217050,"issue_number":1007,"issue_url":"https://github.com/jtv/libpqxx/issues/1007","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3090043559","fragment_type":"issue_comment","sequence":9,"text":"Excellent @apavenis , thanks again! I'll close this ticket then. And hope to release 7.10.2 pretty soon.","author_login":"jtv","author_association":"OWNER","created_at":"2025-07-18T16:43:42+08:00","repo_name":"jtv/libpqxx","issue_id":3192217050,"issue_number":1007,"issue_url":"https://github.com/jtv/libpqxx/issues/1007","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1693971058","fragment_type":"issue_description","sequence":0,"text":"header file seems to cause: free() double free issues\nSystem: Debian 10 (Buster) X86-64 bit system\nlibpqxx built with gcc/g++ version 12.2\nPostgres version 15.2\nThe following code produces this message: 'free(): double free detected in tcache 2'\n\ncxx\n#include \n#include // without this header the problem goes away\nint main(int argc char *argv[])\n{\n return 0;\n}","author_login":"dnewtonrichards","author_association":"NONE","created_at":"2023-05-03T12:22:51+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1533022121","fragment_type":"issue_comment","sequence":1,"text":"Thank you for reporting this. (I edited your message slightly to stop Github from trying to interpret the code as Markdown.)\n\nDid you also get a nonzero return code, or did the program seem to complete successfully?","author_login":"jtv","author_association":"OWNER","created_at":"2023-05-03T13:21:39+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1533115137","fragment_type":"issue_comment","sequence":2,"text":"Hello -\nMy SQL query was successful - query results were correct. But as I was\ntrying to isolate\nthe problem I began trimming down my code to try and find where the error\nwas coming from.\nIf I simply include the header and link with the libpqxx library with a\nbarebones main() I get that\nmessage when I run the binary...\nThanks!\nDave\n\nOn Wed, May 3, 2023 at 9:21 AM Jeroen Vermeulen ***@***.***>\nwrote:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\n-- \nRegards,\nDave","author_login":"dnewtonrichards","author_association":"NONE","created_at":"2023-05-03T14:20:29+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[1693971058],"is_known_query_context":false},{"document_id":"gh_comment_1533383186","fragment_type":"issue_comment","sequence":3,"text":"Ah, I'm not actually sure that I looked closely enough at the output. I was expecting to see an error as well. I'll try again.\n\nMy best guess at an explanation for now is that it's something to do with destruction and cleanup of a global constant, after `main()` returns. Which can be hard to debug because \"the code\" isn't really running when that happens.\n\nIn that murky execution environment it's possible to have subtle bugs, whether in libpqxx or in the infrastructure such as the libc implementation, or things that debugging tools can't quite oversee. I've had false positives of this kind even from very good tools (such as valgrind). So it's possible the message will just go away with a package upgrade — though of course we can't count on that.\n\nI'm kind of clutching at straws here, but it might be helpful to know...\n1. Does this indeed happen after `main()` completes?\n2. Can we narrow down which libpqxx headers trigger the message?\n\nIf I can reproduce the problem on my end now, then it's probably easiest if I check these.","author_login":"jtv","author_association":"OWNER","created_at":"2023-05-03T16:56:26+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1533398536","fragment_type":"issue_comment","sequence":4,"text":"Oh, another question! Did you build using CMake, or using the configure script?","author_login":"jtv","author_association":"OWNER","created_at":"2023-05-03T17:03:12+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1533727232","fragment_type":"issue_comment","sequence":5,"text":"Unfortunately I couldn't bring up a docker container for Debian's Stable or Unstable with the right packages — a package failed to install. So can't try those right now.","author_login":"jtv","author_association":"OWNER","created_at":"2023-05-03T20:47:09+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1533751671","fragment_type":"issue_comment","sequence":6,"text":"I used the configure script to build libpqxx.\nMy configure options as follows:\n--prefix=/usr/local --with-postgres-include=/opt/postgres/include\n--with-postgres-lib=/opt/postgres/lib --enable-shared\nThere is a file called compile_flags that has the following:\n-I/opt/postgres/include -g -O2 -fvisibility=hidden\n-fvisibility-inlines-hidden\n\nI used gcc/g++ version 12.2 which defaults to c++17.\n\nMy binutils is:\nld --version\nGNU ld (GNU Binutils for Debian) 2.31.1\nCopyright (C) 2018 Free Software Foundation, Inc.\n\n I searched for this in errno.h and the highest Linux goes is 133.\nI found a 134 in a postgres header: ./server/utils/fmgroids.h but this\ndoes not appear to be an error number.\nAlso, in my bare-bones main() code I do a 'return 0' so the fact that I'm\ngetting a return code of 134 suggests this is\nhappening after main().\n\nOn Wed, May 3, 2023 at 4:47 PM Jeroen Vermeulen ***@***.***>\nwrote:\n \n \n \n \n \n \n \n \n \n \n \n \n \n\n-- \nRegards,\nDave","author_login":"dnewtonrichards","author_association":"NONE","created_at":"2023-05-03T21:08:11+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[1693971058],"is_known_query_context":false},{"document_id":"gh_comment_1533762556","fragment_type":"issue_comment","sequence":7,"text":"Thanks. That should help me reproduce the problem once I get a working Debian image with the right versions.\n\nThere's one more thing that might be worth checking: whether this message also occurs when you include libpq's header `libpq-fe.h`, and link to libpq, and make no reference to libpqxx.","author_login":"jtv","author_association":"OWNER","created_at":"2023-05-03T21:17:15+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1533766159","fragment_type":"issue_comment","sequence":8,"text":"About the 134... Are you saying that the program's return code was 134? From what you said earlier I got the impression that the return code was 0.\n\nI think on Linux systems the higher return codes are normally used when the program terminates because of a signal.","author_login":"jtv","author_association":"OWNER","created_at":"2023-05-03T21:20:28+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1533787395","fragment_type":"issue_comment","sequence":9,"text":"Correct: my return code is 0 but when the program exits I do an 'echo $?'\nand it's telling me 134 - strange no?\nhere's my code:\n#include \n#include \n\nusing std::cout, std::endl;\n\nint main(int argc, char *argv[])\n{\n cout \nwrote:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\n-- \nRegards,\nDave","author_login":"dnewtonrichards","author_association":"NONE","created_at":"2023-05-03T21:38:51+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[1693971058],"is_known_query_context":false},{"document_id":"gh_comment_1533802997","fragment_type":"issue_comment","sequence":10,"text":"Ah, this is a terminology problem.\n\n_Your program's return code_ then is 134. It's completely usual for `main()` to return 0, but that's not always what ends up determining the return code.\n\nWhat's annoying about this is that when I tried to reproduce the problem before, I would definitely have noticed if the return code was non-zero. So we're back to me being unable to reproduce the problem.","author_login":"jtv","author_association":"OWNER","created_at":"2023-05-03T21:54:20+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1533830782","fragment_type":"issue_comment","sequence":11,"text":"Apologies for the confusion. What I should have said is my source code is\n\"trying\" to return zero but\nthe program is actually returning 134. The thing is, when I remove the\n#include the\nproblem goes away. Could there be a macro being executed inside the\nheader? Or perhaps\na macro in a header that pqxx is picking up from postgres? Very strange\nproblem.\nAppreciate you looking at this...\nDave\n\nOn Wed, May 3, 2023 at 5:54 PM Jeroen Vermeulen ***@***.***>\nwrote:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\n-- \nRegards,\nDave","author_login":"dnewtonrichards","author_association":"NONE","created_at":"2023-05-03T22:24:07+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[1693971058],"is_known_query_context":false},{"document_id":"gh_comment_1535272605","fragment_type":"issue_comment","sequence":12,"text":"Just a bit more info - and again, this does not happen when I remove the\nheader :\n\nBare-bones main():\n\n#include \n#include \nusing std::cout, std::endl, std::string;\nint main(int argc, char *argv[])\n{\n std::cout \n2 #include \n3\n4 using std::cout, std::endl, std::string;\n5\n6 int main(int argc, char *argv[])\n7 {\n8 std::cout \nwrote:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\n-- \nRegards,\nDave","author_login":"dnewtonrichards","author_association":"NONE","created_at":"2023-05-04T19:09:19+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[1693971058],"is_known_query_context":false},{"document_id":"gh_comment_1535497540","fragment_type":"issue_comment","sequence":13,"text":"This appears to be the same problem.\n URL \n\nWould building pqxx again with `libstdc++` work around the problem?","author_login":"tt4g","author_association":"CONTRIBUTOR","created_at":"2023-05-04T22:42:51+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1536169147","fragment_type":"issue_comment","sequence":14,"text":"Not sure what you mean by building with libstdc++ - I am building with\nlibstdc++ - it's a default link with g++\n\nOn Thu, May 4, 2023 at 6:43 PM tt4g ***@***.***> wrote:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\n-- \nRegards,\nDave","author_login":"dnewtonrichards","author_association":"NONE","created_at":"2023-05-05T12:12:58+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[1693971058],"is_known_query_context":false},{"document_id":"gh_comment_1536181596","fragment_type":"issue_comment","sequence":15,"text":"It is not important to build with libstdc++.\nI wanted to tell you that there is a known problem with core dumps caused by different versions of libstdc++ that the library and the application are linked to.\nPlease read the Stack Overflow question.","author_login":"tt4g","author_association":"CONTRIBUTOR","created_at":"2023-05-05T12:24:13+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1536195062","fragment_type":"issue_comment","sequence":16,"text":"I did read it - but I am not getting a core dump and I have core dumps\nenabled. Are you saying that libpqxx does not build with stdc++ ???\n\nOn Fri, May 5, 2023 at 8:24 AM tt4g ***@***.***> wrote:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\n-- \nRegards,\nDave","author_login":"dnewtonrichards","author_association":"NONE","created_at":"2023-05-05T12:33:13+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[1693971058],"is_known_query_context":false},{"document_id":"gh_comment_1536234925","fragment_type":"issue_comment","sequence":17,"text":"I suspect that it is undefined behavior because of the different libstdc++ versions.\nI wanted you to try to see if rebuilding libpqxx with the current libstdc++ would work around the problem.","author_login":"tt4g","author_association":"CONTRIBUTOR","created_at":"2023-05-05T13:05:41+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1536248954","fragment_type":"issue_comment","sequence":18,"text":"I have g++ 12.2 on my system (the latest is 13.1 which I have not built).\nIt's a very recent version of g++ (released last summer).\n\nOn Fri, May 5, 2023 at 9:05 AM tt4g ***@***.***> wrote:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\n-- \nRegards,\nDave","author_login":"dnewtonrichards","author_association":"NONE","created_at":"2023-05-05T13:16:41+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[1693971058],"is_known_query_context":false},{"document_id":"gh_comment_1536264558","fragment_type":"issue_comment","sequence":19,"text":"So it's possible that there's a bug there. But complacency is death, so I'm still eager to figure this one out.\n\n@dnewtonrichards another debugging question... what happens if you include ` ` but _don't link_ to either libpqxx or libpq?","author_login":"jtv","author_association":"OWNER","created_at":"2023-05-05T13:28:46+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1536346039","fragment_type":"issue_comment","sequence":20,"text":"Well, that's certainly a possibility - there's no such thing as bugless\nsoftware. If you need anything else from me please let me know...\nThanks,\nDave\n\nOn Fri, May 5, 2023 at 9:28 AM Jeroen Vermeulen ***@***.***>\nwrote:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\n-- \nRegards,\nDave","author_login":"dnewtonrichards","author_association":"NONE","created_at":"2023-05-05T14:27:43+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[1693971058],"is_known_query_context":false},{"document_id":"gh_comment_1536454682","fragment_type":"issue_comment","sequence":21,"text":"SUCCESS!!! You did it - many thanks for all of your help!!! Perhaps I\nshould install clang? Anyway, I will go with a static build...\n--Dave\n\nOn Fri, May 5, 2023 at 11:14 AM Jeroen Vermeulen ***@***.***>\nwrote:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\n-- \nRegards,\nDave","author_login":"dnewtonrichards","author_association":"NONE","created_at":"2023-05-05T15:52:52+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[1693971058],"is_known_query_context":false},{"document_id":"gh_comment_1536470116","fragment_type":"issue_comment","sequence":22,"text":"When I do the broken build (gcc 12 with `--enable-shared`) but also configure `--enable-audit` for extra run-time checking, it finds a memory leak:\n\nDirect leak of 31 byte(s) in 1 object(s) allocated from:\n #0 0x7f157c72d4c8 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:95\n #1 0x56090e94b717 in void std::__cxx11::basic_string , std::allocator >::_M_construct (char const*, char const*, std::forward_iterator_tag) (/libpqxx/test/.libs/runner+0xb77717)\n #2 0x7f157c134df6 in std::__cxx11::basic_string , std::allocator >::basic_string >(char const*, std::allocator const&) (/libpqxx/src/.libs/libpqxx-7.8.so+0x2c4df6)\n #3 0x7f157c1315d3 in __static_initialization_and_destruction_0(int, int) (/libpqxx/src/.libs/libpqxx-7.8.so+0x2c15d3)\n #4 0x7f157c13188f in _GLOBAL__sub_I_array.cxx (/libpqxx/src/.libs/libpqxx-7.8.so+0x2c188f)\n #5 0x7f157cd20abd in call_init elf/dl-init.c:70\n #6 0x7f157cd20abd in call_init elf/dl-init.c:26\n\nSUMMARY: AddressSanitizer: 31 byte(s) leaked in 1 allocation(s).\n\nOf course a leak is kind of the _opposite_ of a double-free. But again this problem happens with the shared library, not with the static one, which makes me think it's related.\n\nI think the search is on for suspicious handling of a `std::string` with static lifetime. I'll try bisecting headers and code.","author_login":"jtv","author_association":"OWNER","created_at":"2023-05-05T16:05:08+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1536511791","fragment_type":"issue_comment","sequence":23,"text":"**Found it!**\n\nTurns out ` ` is a good test case: if I `#include` that (along with some harmless boilerplate that it requires), the test crashes — but the header files that it in turn includes are all fine.\n\nSo there's something in `internal/encodings.hxx` that triggers the problem. And the only line I need to remove to fix it is...\n\ncxx\nPQXX_DECLARE_ENUM_CONVERSION(pqxx::internal::encoding_group);\n\nThe offending part of `PQXX_DECLARE_ENUM_CONVERSION()` (a macro defined in `strconv.hxx`) is:\n\ncxx\n template<> inline std::string const type_name \\\n { \\\n # ENUM \\\n } \\\n\n(The `# ENUM` looks a bit weird: that's just `#ENUM`, to stringize the name `ENUM` using the preprocessor, but my formatter seems to treat that like a preprocessor _directive.)_\n\nIf I remove the definition's `inline` keyword, the problem goes away. Even when including all of ` `. What a fuss over such a little thing!","author_login":"jtv","author_association":"OWNER","created_at":"2023-05-05T16:42:57+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1536803949","fragment_type":"issue_comment","sequence":24,"text":"No need to change compilers for this... Don't get me wrong, clang is an excellent compiler. But one of those tricks to producing top-quality code is to run it through as many compilers as you can, and pay attention to the errors or warnings they produce.\n\nSo... do both. :-)","author_login":"jtv","author_association":"OWNER","created_at":"2023-05-05T21:33:45+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[1693971058],"is_known_query_context":false},{"document_id":"gh_comment_1536810997","fragment_type":"issue_comment","sequence":25,"text":"Heh. Case in point: clang doesn't like the change I made! Making the variable non-inline seems to mean that every translation unit that contains the definition gets its own definition, and for some reason they clash. Something like that. It's a bit awkward to debug on my phone.\n\nI think I'll have to see about making it a `string_view` instead of a `string` or something.","author_login":"jtv","author_association":"OWNER","created_at":"2023-05-05T21:41:21+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[1693971058],"is_known_query_context":false},{"document_id":"gh_comment_1536960642","fragment_type":"issue_comment","sequence":26,"text":"Avery timely fix — Ubuntu 23.04 also ships with gcc 12 and has the same problem.\n\nThanks for the report @dnewtonrichards, and your patience in helping me resolve it.","author_login":"jtv","author_association":"OWNER","created_at":"2023-05-06T01:20:02+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1537139470","fragment_type":"issue_comment","sequence":27,"text":"Just an FYI: downloaded the latest and greatest; configured with\n'--enable-shared'; recompiled my code and voila - perfection!\nThank you!\n--Dave\n\nOn Fri, May 5, 2023 at 9:20 PM Jeroen Vermeulen ***@***.***>\nwrote:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\n-- \nRegards,\nDave","author_login":"dnewtonrichards","author_association":"NONE","created_at":"2023-05-06T13:10:22+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[1693971058],"is_known_query_context":false},{"document_id":"gh_comment_2882550523","fragment_type":"issue_comment","sequence":28,"text":"Hello from 2025! With 7.10.* is the workaround with --disable-shared still valid? I think I have tried every iteration I've read on this thread. to no success in avoiding the double free. The update says gcc is still broken... also valid?","author_login":"willettAMT","author_association":"NONE","created_at":"2025-05-15T05:38:35+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2882850165","fragment_type":"issue_comment","sequence":29,"text":"Best way to find out is to try! It's low-level weirdness, so routine fixes to tooling can be the answer. I made some changes in the `start-8` branch (my working branch for libpqxx 8.0) that could also make a difference.","author_login":"jtv","author_association":"OWNER","created_at":"2025-05-15T07:32:17+08:00","repo_name":"jtv/libpqxx","issue_id":1693971058,"issue_number":681,"issue_url":"https://github.com/jtv/libpqxx/issues/681","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0246","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"[Bug]: storage stopped working in termux:api 0.51.0?","query_context":"### Problem description\n\nStorage stopped working when updating Termux:API to 0.51.0\n\nDon't know what the old version was, it was probably like 3 months old but I'm not sure. \n`cd storage` works, but I cannot navigate to anything inside storage.\nQuote\n\nu0_a318@localhost:~$ cd storage/movies\nbash: cd: storage/movies: Permission denied\nu0_a318@localhost:~$ namei -l storage/movies\nf: storage/movies\ndrwx------ u0_a318 u0_a318 storage\nlrwxrwxrwx u0_a318 u0_a318 movies -> /storage/emulated/0/Movies\ndrwxr-xr-x root root /\ndrwx--x--x shell everybody storage\ndrwxrwx--- media_rw media_rw emulated\ndrwxrws--- media_rw media_rw 0\ndrwxrws--- u0_a309 media_rw Movies\nu0_a318@localhost:~$ id\nuid=10318(u0_a318) gid=10318(u0_a318) groups=10318(u0_a318),3003(inet),9997(everybody),20318(u0_a318_cache),50318(all_a318) context=u:r:untrusted_app_27:s0:c62,c257,c512,c768\n\nIt was working perfectly before the Termux:API update.\n\nSource: F-droid\nTermux 0.118.2\nTermux:API 0.51.0\nPhone: Samsung Galaxy S24 Ultra \nAndroid 14 \n\nStorage was working perfectly before the Termux:API update.\n\n### Steps to reproduce the behavior.\n\n- Update to Termux:API 0.51.0\n- cd storage/movies\nbash: cd: storage/movies: Permission denied\n\n### What is the expected behavior?\n\nNo error.\n\n### System information\n\n* Termux application version: 0.118.2\n* Android OS version: 14\n* Device model: Samsung Galaxy S24 Ultra","known_context_document_ids":["gh_issue_3006374922"],"reference_answer":"Seems like firmware related bug. Usually OS does not automatically revoke permissions day after user grants it.","answer_document_id":"gh_comment_2815556706","silver_evidence_path":["gh_comment_2816773924","gh_issue_2980104140","gh_comment_2815556706"],"evidence_issue_ids":[3006374922,2980104140],"source_repo_name":"termux/termux-app","source_issue_id":3006374922,"source_issue_number":4506,"source_issue_url":"https://github.com/termux/termux-app/issues/4506","target_repo_name":"termux/termux-app","target_issue_id":2980104140,"target_issue_number":4486,"target_issue_url":"https://github.com/termux/termux-app/issues/4486","reference_anchor_document_id":"gh_comment_2816773924","reference_answer_author":"twaik","reference_answer_author_association":"MEMBER","quality_score":86.57,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1786,"anchor_target_overlap":0.1071,"target_answer_overlap":0.0714},"issue_created_at":"2025-04-19T11:17:13+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_3006374922","fragment_type":"issue_description","sequence":0,"text":"[Bug]: storage stopped working in termux:api 0.51.0\n### Problem description\n\nStorage stopped working when updating Termux:API to 0.51.0\n\nDon't know what the old version was, it was probably like 3 months old but I'm not sure. \n`cd storage` works, but I cannot navigate to anything inside storage.\nQuote\n\nu0_a318@localhost:~$ cd storage/movies\nbash: cd: storage/movies: Permission denied\nu0_a318@localhost:~$ namei -l storage/movies\nf: storage/movies\ndrwx------ u0_a318 u0_a318 storage\nlrwxrwxrwx u0_a318 u0_a318 movies -> /storage/emulated/0/Movies\ndrwxr-xr-x root root /\ndrwx--x--x shell everybody storage\ndrwxrwx--- media_rw media_rw emulated\ndrwxrws--- media_rw media_rw 0\ndrwxrws--- u0_a309 media_rw Movies\nu0_a318@localhost:~$ id\nuid=10318(u0_a318) gid=10318(u0_a318) groups=10318(u0_a318),3003(inet),9997(everybody),20318(u0_a318_cache),50318(all_a318) context=u:r:untrusted_app_27:s0:c62,c257,c512,c768\n\nIt was working perfectly before the Termux:API update.\n\nSource: F-droid\nTermux 0.118.2\nTermux:API 0.51.0\nPhone: Samsung Galaxy S24 Ultra \nAndroid 14 \n\nStorage was working perfectly before the Termux:API update.\n\n### Steps to reproduce the behavior.\n\n- Update to Termux:API 0.51.0\n- cd storage/movies\nbash: cd: storage/movies: Permission denied\n\n### What is the expected behavior?\n\nNo error.\n\n### System information\n\n* Termux application version: 0.118.2\n* Android OS version: 14\n* Device model: Samsung Galaxy S24 Ultra","author_login":"divinity76","author_association":"NONE","created_at":"2025-04-19T11:17:13+08:00","repo_name":"termux/termux-app","issue_id":3006374922,"issue_number":4506,"issue_url":"https://github.com/termux/termux-app/issues/4506","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2816664835","fragment_type":"issue_comment","sequence":1,"text":"Looks to me like the friggin user id changed,\nIt was u0_a309 before the update and u0_a318 after the update,\nAnd u0_a318 is not allowed to access the files of u0_a309\n\n? Maybe?","author_login":"divinity76","author_association":"NONE","created_at":"2025-04-19T11:18:54+08:00","repo_name":"termux/termux-app","issue_id":3006374922,"issue_number":4506,"issue_url":"https://github.com/termux/termux-app/issues/4506","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2816773924","fragment_type":"issue_comment","sequence":2,"text":"`u0_a309` would be the uid of `com.google.android.providers.media.module` package or similar provider implementation, not Termux. Apps don't get to create files with their own uid under external storage directories.\n\nRun `pm dump-package com.google.android.providers.media.module` with root or adb.\n\nOr find provider package depending on uid with `dumpsys | grep -a -E -A 2 '^[ \\t]*(userId|appId)=10309'`\n\nYour issue is #4486.","author_login":"agnostic-apollo","author_association":"MEMBER","created_at":"2025-04-19T16:31:33+08:00","repo_name":"termux/termux-app","issue_id":3006374922,"issue_number":4506,"issue_url":"https://github.com/termux/termux-app/issues/4506","linked_issue_ids":[2980104140],"is_known_query_context":false},{"document_id":"gh_issue_2980104140","fragment_type":"issue_description","sequence":0,"text":"[Bug]: \"Permission denied\" on \"/storage/emulated/0/\"\n### Problem description\n\nAccessing the storage was working well before the current upgrade, but not anymore:\n\n~ $ ls /storage/emulated/0/Documents/\nls: cannot open directory '/storage/emulated/0/Documents/': Permission denied\n\n### Steps to reproduce the behavior.\n\n1. Upgrade to 0.118.2\n2. `ls /storage/emulated/0/Documents/`\n\n### What is the expected behavior?\n\n_No response_\n\n### System information\n\n~ $ termux-info\nTermux Variables: TERMUX_APK_RELEASE=F_DROID\nTERMUX_APP_PACKAGE_MANAGER=apt\nTERMUX_APP_PID=21280\nTERMUX_APP__BUILD_DATA_DIR=/data/data/com.termux\nTERMUX_APP__DATA_DIR=/data/user/0/com.termux\nTERMUX_APP__LEGACY_DATA_DIR=/data/data/com.termux\nTERMUX_APP__SE_FILE_CONTEXT=u:object_r:app_data_file:s0:c184,c257,c512,c768\nTERMUX_APP__SE_INFO=default:targetSdkVersion=28:complete TERMUX_IS_DEBUGGABLE_BUILD=0\nTERMUX_MAIN_PACKAGE_FORMAT=debian\nTERMUX_VERSION=0.118.2\nTERMUX__HOME=/data/data/com.termux/files/home\nTERMUX__PREFIX=/data/data/com.termux/files/usr\nTERMUX__ROOTFS=/data/data/com.termux/files\nTERMUX__SE_PROCESS_CONTEXT=u:r:untrusted_app_27:s0:c184,c257,c512,c768 TERMUX__USER_ID=0 Packages CPU architecture:\naarch64\nSubscribed repositories:\n# sources.list\ndeb URL stable main\n# root-repo (sources.list.d/root.list)\ndeb URL root stable\nUpdatable packages: abseil-cpp/stable 20250127.1 aarch64 [upgradable from: 20250127.0-1]\nclang/stable 20.1.2 aarch64 [upgradable from: 19.1.7] command-not-found/stable 2.4.0-70 aarch64 [upgradable from: 2.4.0-67]\ncoreutils/stable 9.6-1 aarch64 [upgradable from: 9.6]\ncurl/stable 8.13.0 aarch64 [upgradable from: 8.12.1]\ned/stable 1.21.1 aarch64 [upgradable from: 1.21]\ngawk/stable 5.3.1 aarch64 [upgradable from: 5.3.0]\nglib/stable 2.84.1 aarch64 [upgradable from: 2.84.0-1]\nlibcompiler-rt/stable 20.1.2 aarch64 [upgradable from: 19.1.7]\nlibcurl/stable 8.13.0 aarch64 [upgradable from: 8.12.1]\nlibexpat/stable 2.7.1 aarch64 [upgradable from: 2.7.0]\nlibllvm/stable 20.1.2 aarch64 [upgradable from: 19.1.7]\nliblzma/stable 5.8.1 aarch64 [upgradable from: 5.6.4]\nlibsqlite/stable 3.49.1-2 aarch64 [upgradable from: 3.49.1]\nlibxml2/stable 2.13.7 aarch64 [upgradable from: 2.13.6-1]\nlld/stable 20.1.2 aarch64 [upgradable from: 19.1.7]\nllvm/stable 20.1.2 aarch64 [upgradable from: 19.1.7]\nnano/stable 8.4 aarch64 [upgradable from: 8.3]\npatch/stable 2.8 aarch64 [upgradable from: 2.7.6-4]\ntermux-api/stable 0.59.1 aarch64 [upgradable from: 0.59.0]\ntermux-exec/stable 1:2.3.0 aarch64 [upgradable from: 1:1.0-1]\ntermux-tools/stable 1.45.0 aarch64 [upgradable from: 1.44.6]\nxz-utils/stable 5.8.1 aarch64 [upgradable from: 5.6.4]\ntermux-tools version:\n1.44.6\nAndroid version:\n15\nKernel build information:\nLinux localhost 6.1.99-android14-11-gd6f926cfde54-ab12786694 #1 SMP PREEMPT Wed Dec 11 21:44:40 UTC 2024 aarch64 Android\nDevice manufacturer:\nGoogle\nDevice model:\nPixel 7 Pro\nLD Variables:\nLD_LIBRARY_PATH=\nLD_PRELOAD=/data/data/com.termux/files/usr/lib/libtermux-exec.so","author_login":"eapo","author_association":"NONE","created_at":"2025-04-08T15:09:08+08:00","repo_name":"termux/termux-app","issue_id":2980104140,"issue_number":4486,"issue_url":"https://github.com/termux/termux-app/issues/4486","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2787184565","fragment_type":"issue_comment","sequence":1,"text":"I had the same problem after upgrade. It seems _removing _ the Files permission and then re-granting the permission resolves the issue for me.","author_login":"whiteinge","author_association":"NONE","created_at":"2025-04-08T17:31:39+08:00","repo_name":"termux/termux-app","issue_id":2980104140,"issue_number":4486,"issue_url":"https://github.com/termux/termux-app/issues/4486","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2787444922","fragment_type":"issue_comment","sequence":2,"text":"Komo aprendo a usar termux\n\nEl mar, 8 de abr de 2025, 3:12 p. m., anotherdoesnm escribió:","author_login":"04677","author_association":"NONE","created_at":"2025-04-08T19:18:37+08:00","repo_name":"termux/termux-app","issue_id":2980104140,"issue_number":4486,"issue_url":"https://github.com/termux/termux-app/issues/4486","linked_issue_ids":[2980104140],"is_known_query_context":false},{"document_id":"gh_comment_2815529204","fragment_type":"issue_comment","sequence":3,"text":"Please reopen this issue, re-granting the permission only fixes the problem temporarily. It fails again on the next day and I've reproduced this twice.","author_login":"s-cerevisiae","author_association":"NONE","created_at":"2025-04-18T14:12:20+08:00","repo_name":"termux/termux-app","issue_id":2980104140,"issue_number":4486,"issue_url":"https://github.com/termux/termux-app/issues/4486","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2815556706","fragment_type":"issue_comment","sequence":4,"text":"Seems like firmware related bug. Usually OS does not automatically revoke permissions day after user grants it.","author_login":"twaik","author_association":"MEMBER","created_at":"2025-04-18T14:29:11+08:00","repo_name":"termux/termux-app","issue_id":2980104140,"issue_number":4486,"issue_url":"https://github.com/termux/termux-app/issues/4486","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2816457161","fragment_type":"issue_comment","sequence":5,"text":"It's not revoked, it comes back to the old state of \"permission granted but can't access anything\". I ran `termux-setup-storage` again and let's see if that will help.","author_login":"s-cerevisiae","author_association":"NONE","created_at":"2025-04-19T01:53:06+08:00","repo_name":"termux/termux-app","issue_id":2980104140,"issue_number":4486,"issue_url":"https://github.com/termux/termux-app/issues/4486","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2816821735","fragment_type":"issue_comment","sequence":6,"text":"I think this issue should be re-opened.\nSame problem for me.\nSamsung S24 Ultra,\nAndroid 14,\nTermux 0.118.2,\nTermux:API 0.51.0.\n\n@whiteinge's workaround did resolve the issue,\nbut going by @s-cerevisiae it's probably just a temporary fix.","author_login":"divinity76","author_association":"NONE","created_at":"2025-04-19T18:44:28+08:00","repo_name":"termux/termux-app","issue_id":2980104140,"issue_number":4486,"issue_url":"https://github.com/termux/termux-app/issues/4486","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2816827513","fragment_type":"issue_comment","sequence":7,"text":"Hm, still all working for me\nAndroid 13, not rooted\nTermux 0.118.2\nTermux:API 0.51.0","author_login":"anotherdoesnm","author_association":"NONE","created_at":"2025-04-19T19:01:04+08:00","repo_name":"termux/termux-app","issue_id":2980104140,"issue_number":4486,"issue_url":"https://github.com/termux/termux-app/issues/4486","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2816853917","fragment_type":"issue_comment","sequence":8,"text":"@anotherdoesnm add your phone manufacturer to the post.\nSeems this may be a samsung-specific issue.\n\nCan anyone reproduce this on a not-Samsung phone?","author_login":"divinity76","author_association":"NONE","created_at":"2025-04-19T20:24:06+08:00","repo_name":"termux/termux-app","issue_id":2980104140,"issue_number":4486,"issue_url":"https://github.com/termux/termux-app/issues/4486","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2817032881","fragment_type":"issue_comment","sequence":9,"text":"Xiaomi here. Turns out the reason is that you need to grant permanent permission to Termux:API, not (only) Termux app itself.","author_login":"s-cerevisiae","author_association":"NONE","created_at":"2025-04-20T07:03:59+08:00","repo_name":"termux/termux-app","issue_id":2980104140,"issue_number":4486,"issue_url":"https://github.com/termux/termux-app/issues/4486","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2817928345","fragment_type":"issue_comment","sequence":10,"text":"Update: after I granted permission to Termux:API the problem seems to be resolved. I'll report back if this occurs again.","author_login":"s-cerevisiae","author_association":"NONE","created_at":"2025-04-21T08:26:27+08:00","repo_name":"termux/termux-app","issue_id":2980104140,"issue_number":4486,"issue_url":"https://github.com/termux/termux-app/issues/4486","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0257","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"[flang][LoongArch] Runtime error in spec2017 527.cam4_r with size=ref and optimization levels \"-O3\"/\"-Ofast\"?","query_context":"Tested OS: Debian sid/experimental loong64 installed with llvm 20.1.3\n\nOptimization setting:\n\n`COPTIMIZE = -g -Ofast -march=la464 -flto=auto`\n`FOPTIMIZE = -g -Ofast -march=la464 -flto=auto`\n\nWhen I test spec2017 527.cam4_r with above optimization setting and ref size, I met the following error:\n\nrun_base_refrate_mytest_llvm_20d1d3-m64.0000 -f compare.cmd -E -e compare.err -o compare.stdout'; no non-empty output files exist\n Command returned exit code 1\n****************************************\nContents of cam4_r_base.mytest_llvm_20d1d3-m64.err\n****************************************\nFortran STOP\nIEEE arithmetic exceptions signaled: DIVBYZERO INEXACT INVALID OVERFLOW UNDERFLOW\n\n****************************************\n*** Miscompare of cam4_validate.txt\n\nThe content in miscomparison file is:\n\n0001: PASS: 4 points. \n PASS: 0 points. \n ^\n\nThe above error still appears when I change the optimization level of Fortran part to `-O3`. If the optimization level of Fortran part is `-O2` or lower, the program can run smoothly.\n\nThe above error only appears with ref size, with test/train sizes the program can run smoothly at optimization level of Fortran part `-Ofast`.","known_context_document_ids":["gh_issue_3014322436"],"reference_answer":"@llvm/issue-subscribers-backend-loongarch\n\nAuthor: None (azuresky01)\n\n \nTested OS: Debian sid/experimental loong64 installed with llvm 20.1.3\n\nOptimization setting:\n\nCOPTIMIZE = -Ofast -march=la464 -flto=auto -fno-strict-aliasing\nFOPTIMIZE = -Ofast -march=la464 -flto=auto\n\nWhen I test spec2006 416.gamess with above optimization setting and ref size, I met the following error:\n\nrun_base_ref_llvm-64bit-test.0000 -c 1 -e compare.err -o compare.stdout -f compare.cmd\n\n****************************************\nContents of triazolium.err\n****************************************\nFortran STOP: IN ABRT\nIEEE arithmetic exceptions signaled: INEXACT INVALID\n\n****************************************\n\n****************************************\nContents of h2ocu2+.gradient.err\n****************************************\nFortran STOP\nIEEE arithmetic exceptions signaled: INEXACT INVALID UNDERFLOW\n\n****************************************\n\n****************************************\nContents of cytosine.2.err\n****************************************\nFortran STOP\nIEEE arithmetic exceptions signaled: INEXACT INVALID\n\n****************************************\n\n*** Miscompare of triazolium.out\n\nthe content of triazolium.out.mis in this example:\n\n0654: ----- FROZEN CORE ENERGY = -1092.06138801\n ----- FROZEN CORE ENERGY = -1089.34489867\n ^\n0679: STATE 1 ENERGY= -585.3957141489 S= 0.00 SZ= 0.00 SPACE SYM=A' \n STATE 1 ENERGY= -582.6821224495 S= 0.00 SZ= 0.00 SPACE SYM=A' \n ^\n0685: 0.9779593\n 0.9781004\n ^\n0686: -0.0838917\n -0.0834754\n ^\n0687: -0.0700851\n -0.0703953\n ^\n0688: -0.0681958\n -0.0681070\n ^\n0689: 0.0622926\n 0.0622399\n ^\n0690: 0.0622926\n 0.0622399\n ^\n0691: -0.0566227\n -0.0564314\n ^\n0703: STATE= 1 ENERGY= -585.3957141489 WEIGHT= 1.00000 S= 0.00\n STATE= 1 ENERGY= -582.6821224495 WEIGHT= 1.00000 S= 0.00\n\nThe above error still appears when I change the optimization level of Fortran part to `-O3` or `-O2`. If the optimization level of Fortran part is `-O1` or lower, the program can run smoothly.\n\nThe above error only appears with ref size, with test/train sizes the program can run smoothly at optimization level of Fortran part `-Ofast`.","answer_document_id":"gh_comment_2829288017","silver_evidence_path":["gh_comment_2832880508","gh_issue_3014357058","gh_comment_2829288017"],"evidence_issue_ids":[3014322436,3014357058],"source_repo_name":"llvm/llvm-project","source_issue_id":3014322436,"source_issue_number":136971,"source_issue_url":"https://github.com/llvm/llvm-project/issues/136971","target_repo_name":"llvm/llvm-project","target_issue_id":3014357058,"target_issue_number":137000,"target_issue_url":"https://github.com/llvm/llvm-project/issues/137000","reference_anchor_document_id":"gh_comment_2832880508","reference_answer_author":"llvmbot","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2963,"anchor_target_overlap":0.2963,"target_answer_overlap":0.9452},"issue_created_at":"2025-04-23T14:57:27+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_3014322436","fragment_type":"issue_description","sequence":0,"text":"[flang][LoongArch] Runtime error in spec2017 527.cam4_r with size=ref and optimization levels \"-O3\"/\"-Ofast\"\nTested OS: Debian sid/experimental loong64 installed with llvm 20.1.3\n\nOptimization setting:\n\n`COPTIMIZE = -g -Ofast -march=la464 -flto=auto`\n`FOPTIMIZE = -g -Ofast -march=la464 -flto=auto`\n\nWhen I test spec2017 527.cam4_r with above optimization setting and ref size, I met the following error:\n\nrun_base_refrate_mytest_llvm_20d1d3-m64.0000 -f compare.cmd -E -e compare.err -o compare.stdout'; no non-empty output files exist\n Command returned exit code 1\n****************************************\nContents of cam4_r_base.mytest_llvm_20d1d3-m64.err\n****************************************\nFortran STOP\nIEEE arithmetic exceptions signaled: DIVBYZERO INEXACT INVALID OVERFLOW UNDERFLOW\n\n****************************************\n*** Miscompare of cam4_validate.txt\n\nThe content in miscomparison file is:\n\n0001: PASS: 4 points. \n PASS: 0 points. \n ^\n\nThe above error still appears when I change the optimization level of Fortran part to `-O3`. If the optimization level of Fortran part is `-O2` or lower, the program can run smoothly.\n\nThe above error only appears with ref size, with test/train sizes the program can run smoothly at optimization level of Fortran part `-Ofast`.","author_login":"azuresky01","author_association":"NONE","created_at":"2025-04-23T14:57:27+08:00","repo_name":"llvm/llvm-project","issue_id":3014322436,"issue_number":136971,"issue_url":"https://github.com/llvm/llvm-project/issues/136971","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2826495918","fragment_type":"issue_comment","sequence":1,"text":"Thanks for reporting the issue.\n\n@tangaac Do you ever meet this issue? Is is caused by our recent optimizations?\n\n@llvm/pr-subscribers-loongarch","author_login":"SixWeining","author_association":"CONTRIBUTOR","created_at":"2025-04-24T06:14:23+08:00","repo_name":"llvm/llvm-project","issue_id":3014322436,"issue_number":136971,"issue_url":"https://github.com/llvm/llvm-project/issues/136971","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2826777251","fragment_type":"issue_comment","sequence":2,"text":"Never met, I suspect it's not caused by our recent optimizations.","author_login":"tangaac","author_association":"CONTRIBUTOR","created_at":"2025-04-24T08:24:40+08:00","repo_name":"llvm/llvm-project","issue_id":3014322436,"issue_number":136971,"issue_url":"https://github.com/llvm/llvm-project/issues/136971","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2832880508","fragment_type":"issue_comment","sequence":3,"text":"This issue and URL \n \n* I did more tests on Debian sid/experimental x86_64/aarch64 installed with llvm 20.1.3. Both are OK with optimization setting `-Ofast`, so this two issues should be loongarch64 specific problems.\n\n* And more tests on AOSC OS (12.1.3) loongarch64 with llvm 20.1.3 as well, I observed the same issues.\n\n@SixWeining @tangaac","author_login":"azuresky01","author_association":"NONE","created_at":"2025-04-27T01:53:57+08:00","repo_name":"llvm/llvm-project","issue_id":3014322436,"issue_number":136971,"issue_url":"https://github.com/llvm/llvm-project/issues/136971","linked_issue_ids":[3014357058],"is_known_query_context":false},{"document_id":"gh_comment_2835091023","fragment_type":"issue_comment","sequence":4,"text":"Thanks, we're trying to reproduce. BTW, have you tried the main branch?","author_login":"SixWeining","author_association":"CONTRIBUTOR","created_at":"2025-04-28T12:31:34+08:00","repo_name":"llvm/llvm-project","issue_id":3014322436,"issue_number":136971,"issue_url":"https://github.com/llvm/llvm-project/issues/136971","linked_issue_ids":[3014357058],"is_known_query_context":false},{"document_id":"gh_comment_2841373114","fragment_type":"issue_comment","sequence":5,"text":"I have reproduced the issue with 20.1.3 while the main branch pass. I will bisect the commit that fix the issue.","author_login":"SixWeining","author_association":"CONTRIBUTOR","created_at":"2025-04-30T09:31:06+08:00","repo_name":"llvm/llvm-project","issue_id":3014322436,"issue_number":136971,"issue_url":"https://github.com/llvm/llvm-project/issues/136971","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2856811303","fragment_type":"issue_comment","sequence":6,"text":"I found that URL fixed the issue for #136971. I'm not sure why x86-64/aarch64 are ok.\n\nFor URL I'm still debugging. But I find that with assertion enabled, flang will crash when build 416.gamess:\n\nflang: llvm-project/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7730: llvm::VectorizationFactor llvm::LoopVectorizationPlanner::computeBestVF(): Assertion `(BestFactor.Width == LegacyVF.Width || BestPlan.hasEarlyExit() || planContainsAdditionalSimplifications(getPlanFor(BestFactor.Width), CostCtx, OrigLoop) || planContainsAdditionalSimplifications(getPlanFor(LegacyVF.Width), CostCtx, OrigLoop)) && \" VPlan cost model and legacy cost model disagreed\"' failed.\nPLEASE submit a bug report to URL and include the crash backtrace.\nStack dump:\n0. Program arguments: llvm-project/_build/bin/flang -fc1 -triple loongarch64-unknown-linux-gnu -emit-llvm-bc -flto=full -mrelocation-model pic -pic-level 2 -pic-is-pie -target-cpu la464 -target-feature +64bit -target-feature +f -target-feature +d -target-feature +lsx -target-feature +lasx -target-feature +ual -vectorize-loops -vectorize-slp -fversion-loops-for-stride -resource-dir llvm-project/_build/lib/clang/21 -mframe-pointer=none -O3 -o chgpen.fppized.o -x f95 chgpen.fppized.f\n1. Running pass \"function (float2int,lower-constant-intrinsics,chr,loop(loop-rotate ,loop-deletion),loop-distribute,inject-tli-mappings,loop-vectorize ,infer-alignment,loop-load-elim,instcombine ,simplifycfg ,slp-vectorizer,vector-combine,instcombine ,loop-unroll ,transform-warning,sroa ,infer-alignment,instcombine ,loop-mssa(licm ),alignment-from-assumptions,loop-sink,instsimplify,div-rem-pairs,tailcallelim,simplifycfg )\" on module \"FIRModule\" \n2. Running pass \"loop-vectorize \" on function \"cgpinp_\"","author_login":"SixWeining","author_association":"CONTRIBUTOR","created_at":"2025-05-07T02:06:59+08:00","repo_name":"llvm/llvm-project","issue_id":3014322436,"issue_number":136971,"issue_url":"https://github.com/llvm/llvm-project/issues/136971","linked_issue_ids":[3014357058],"is_known_query_context":false},{"document_id":"gh_comment_2858040044","fragment_type":"issue_comment","sequence":7,"text":"I can also confirm it is OK with LLVM 20.1.4 if `-flto=auto` option is removed. So the issue of URL is related to conversion of floating point values into integers.","author_login":"azuresky01","author_association":"NONE","created_at":"2025-05-07T10:29:58+08:00","repo_name":"llvm/llvm-project","issue_id":3014322436,"issue_number":136971,"issue_url":"https://github.com/llvm/llvm-project/issues/136971","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2879378949","fragment_type":"issue_comment","sequence":8,"text":"This issue can be fixed by URL which has been cherry-picked to llvm20: URL","author_login":"SixWeining","author_association":"CONTRIBUTOR","created_at":"2025-05-14T08:55:52+08:00","repo_name":"llvm/llvm-project","issue_id":3014322436,"issue_number":136971,"issue_url":"https://github.com/llvm/llvm-project/issues/136971","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2880112617","fragment_type":"issue_comment","sequence":9,"text":"Great! Thanks very much for your guys' nice work. Now SPEC2017 tests should be OK on LoongArch with LLVM 20.","author_login":"azuresky01","author_association":"NONE","created_at":"2025-05-14T12:48:00+08:00","repo_name":"llvm/llvm-project","issue_id":3014322436,"issue_number":136971,"issue_url":"https://github.com/llvm/llvm-project/issues/136971","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_3014357058","fragment_type":"issue_description","sequence":0,"text":"[flang][LoongArch] Miscomparison error in spec2006 416.gamess with size=ref and optimization levels \"-O2\"/\"-O3\"/\"-Ofast\"\nTested OS: Debian sid/experimental loong64 installed with llvm 20.1.3\n\nOptimization setting:\n\nCOPTIMIZE = -Ofast -march=la464 -flto=auto -fno-strict-aliasing\nFOPTIMIZE = -Ofast -march=la464 -flto=auto\n\nWhen I test spec2006 416.gamess with above optimization setting and ref size, I met the following error:\n\nrun_base_ref_llvm-64bit-test.0000 -c 1 -e compare.err -o compare.stdout -f compare.cmd\n\n****************************************\nContents of triazolium.err\n****************************************\nFortran STOP: IN ABRT\nIEEE arithmetic exceptions signaled: INEXACT INVALID\n\n****************************************\n\n****************************************\nContents of h2ocu2+.gradient.err\n****************************************\nFortran STOP\nIEEE arithmetic exceptions signaled: INEXACT INVALID UNDERFLOW\n\n****************************************\n\n****************************************\nContents of cytosine.2.err\n****************************************\nFortran STOP\nIEEE arithmetic exceptions signaled: INEXACT INVALID\n\n****************************************\n\n*** Miscompare of triazolium.out\n\nthe content of triazolium.out.mis in this example:\n\n0654: ----- FROZEN CORE ENERGY = -1092.06138801\n ----- FROZEN CORE ENERGY = -1089.34489867\n ^\n0679: STATE 1 ENERGY= -585.3957141489 S= 0.00 SZ= 0.00 SPACE SYM=A' \n STATE 1 ENERGY= -582.6821224495 S= 0.00 SZ= 0.00 SPACE SYM=A' \n ^\n0685: 0.9779593\n 0.9781004\n ^\n0686: -0.0838917\n -0.0834754\n ^\n0687: -0.0700851\n -0.0703953\n ^\n0688: -0.0681958\n -0.0681070\n ^\n0689: 0.0622926\n 0.0622399\n ^\n0690: 0.0622926\n 0.0622399\n ^\n0691: -0.0566227\n -0.0564314\n ^\n0703: STATE= 1 ENERGY= -585.3957141489 WEIGHT= 1.00000 S= 0.00\n STATE= 1 ENERGY= -582.6821224495 WEIGHT= 1.00000 S= 0.00\n\nThe above error still appears when I change the optimization level of Fortran part to `-O3` or `-O2`. If the optimization level of Fortran part is `-O1` or lower, the program can run smoothly.\n\nThe above error only appears with ref size, with test/train sizes the program can run smoothly at optimization level of Fortran part `-Ofast`.","author_login":"azuresky01","author_association":"NONE","created_at":"2025-04-23T15:09:32+08:00","repo_name":"llvm/llvm-project","issue_id":3014357058,"issue_number":137000,"issue_url":"https://github.com/llvm/llvm-project/issues/137000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2826500115","fragment_type":"issue_comment","sequence":1,"text":"Seems there is no `issue` subscriber team for loongarch. So I use @llvm/pr-subscribers-backend-loongarch here.","author_login":"SixWeining","author_association":"CONTRIBUTOR","created_at":"2025-04-24T06:16:55+08:00","repo_name":"llvm/llvm-project","issue_id":3014357058,"issue_number":137000,"issue_url":"https://github.com/llvm/llvm-project/issues/137000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2829288017","fragment_type":"issue_comment","sequence":2,"text":"@llvm/issue-subscribers-backend-loongarch\n\nAuthor: None (azuresky01)\n\n \nTested OS: Debian sid/experimental loong64 installed with llvm 20.1.3\n\nOptimization setting:\n\nCOPTIMIZE = -Ofast -march=la464 -flto=auto -fno-strict-aliasing\nFOPTIMIZE = -Ofast -march=la464 -flto=auto\n\nWhen I test spec2006 416.gamess with above optimization setting and ref size, I met the following error:\n\nrun_base_ref_llvm-64bit-test.0000 -c 1 -e compare.err -o compare.stdout -f compare.cmd\n\n****************************************\nContents of triazolium.err\n****************************************\nFortran STOP: IN ABRT\nIEEE arithmetic exceptions signaled: INEXACT INVALID\n\n****************************************\n\n****************************************\nContents of h2ocu2+.gradient.err\n****************************************\nFortran STOP\nIEEE arithmetic exceptions signaled: INEXACT INVALID UNDERFLOW\n\n****************************************\n\n****************************************\nContents of cytosine.2.err\n****************************************\nFortran STOP\nIEEE arithmetic exceptions signaled: INEXACT INVALID\n\n****************************************\n\n*** Miscompare of triazolium.out\n\nthe content of triazolium.out.mis in this example:\n\n0654: ----- FROZEN CORE ENERGY = -1092.06138801\n ----- FROZEN CORE ENERGY = -1089.34489867\n ^\n0679: STATE 1 ENERGY= -585.3957141489 S= 0.00 SZ= 0.00 SPACE SYM=A' \n STATE 1 ENERGY= -582.6821224495 S= 0.00 SZ= 0.00 SPACE SYM=A' \n ^\n0685: 0.9779593\n 0.9781004\n ^\n0686: -0.0838917\n -0.0834754\n ^\n0687: -0.0700851\n -0.0703953\n ^\n0688: -0.0681958\n -0.0681070\n ^\n0689: 0.0622926\n 0.0622399\n ^\n0690: 0.0622926\n 0.0622399\n ^\n0691: -0.0566227\n -0.0564314\n ^\n0703: STATE= 1 ENERGY= -585.3957141489 WEIGHT= 1.00000 S= 0.00\n STATE= 1 ENERGY= -582.6821224495 WEIGHT= 1.00000 S= 0.00\n\nThe above error still appears when I change the optimization level of Fortran part to `-O3` or `-O2`. If the optimization level of Fortran part is `-O1` or lower, the program can run smoothly.\n\nThe above error only appears with ref size, with test/train sizes the program can run smoothly at optimization level of Fortran part `-Ofast`.","author_login":"llvmbot","author_association":"MEMBER","created_at":"2025-04-25T03:22:24+08:00","repo_name":"llvm/llvm-project","issue_id":3014357058,"issue_number":137000,"issue_url":"https://github.com/llvm/llvm-project/issues/137000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2879563316","fragment_type":"issue_comment","sequence":3,"text":"I think it should be caused by some bug of lasx (-march=la464 enables it) but I haven't figured it out. Maybe turn it off as a workaround.","author_login":"SixWeining","author_association":"CONTRIBUTOR","created_at":"2025-05-14T09:52:55+08:00","repo_name":"llvm/llvm-project","issue_id":3014357058,"issue_number":137000,"issue_url":"https://github.com/llvm/llvm-project/issues/137000","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0258","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Topcoder Archive issue?","query_context":"This is not actually issue, it is actually a suggestion that TopCoder single round matches(SRM) archive has a lot of good quality questions as it is now shutdown, we are unable to submit the solutions and judge the code.\nThe archive now is available with a questions and all the testcases. It is difficult to manually check all the testcases if we could make something for it which is similar to that we have for codeforces and atcoder it would be good.","known_context_document_ids":["gh_issue_3409553686"],"reference_answer":"I understand your use case of having quick access to a local file in an environment that's all set to get going, but it's not what this extension is built for, and easily something that external tools can provide on their own.\n \n\nI don't agree. I'm not willing to drop the aforementioned consistency for the sake of adding partial parsers that are (in my opinion) out-of-scope for this extension.","answer_document_id":"gh_comment_1157063428","silver_evidence_path":["gh_comment_3366108544","gh_issue_1244089211","gh_comment_1157063428"],"evidence_issue_ids":[3409553686,1244089211],"source_repo_name":"jmerle/competitive-companion","source_issue_id":3409553686,"source_issue_number":636,"source_issue_url":"https://github.com/jmerle/competitive-companion/issues/636","target_repo_name":"jmerle/competitive-companion","target_issue_id":1244089211,"target_issue_number":245,"target_issue_url":"https://github.com/jmerle/competitive-companion/issues/245","reference_anchor_document_id":"gh_comment_3366108544","reference_answer_author":"jmerle","reference_answer_author_association":"OWNER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.5556,"target_answer_overlap":0.4375},"issue_created_at":"2025-09-12T09:00:14+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_3409553686","fragment_type":"issue_description","sequence":0,"text":"Topcoder Archive issue\nThis is not actually issue, it is actually a suggestion that TopCoder single round matches(SRM) archive has a lot of good quality questions as it is now shutdown, we are unable to submit the solutions and judge the code.\nThe archive now is available with a questions and all the testcases. It is difficult to manually check all the testcases if we could make something for it which is similar to that we have for codeforces and atcoder it would be good.","author_login":"SathvikReddy0330","author_association":"NONE","created_at":"2025-09-12T09:00:14+08:00","repo_name":"jmerle/competitive-companion","issue_id":3409553686,"issue_number":636,"issue_url":"https://github.com/jmerle/competitive-companion/issues/636","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_3337004829","fragment_type":"issue_comment","sequence":1,"text":"Yes, I also have same problem, a lot of good problems are in the archive.","author_login":"taovuzu","author_association":"NONE","created_at":"2025-09-26T06:40:39+08:00","repo_name":"jmerle/competitive-companion","issue_id":3409553686,"issue_number":636,"issue_url":"https://github.com/jmerle/competitive-companion/issues/636","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3366056843","fragment_type":"issue_comment","sequence":2,"text":"It's like a mini Online judge on your pc,\nso we basically get the test cases and then we parse it to CPH Judge built\nby Divyanshu Agrawal\n wrote:","author_login":"SathvikReddy0330","author_association":"NONE","created_at":"2025-10-03T14:57:27+08:00","repo_name":"jmerle/competitive-companion","issue_id":3409553686,"issue_number":636,"issue_url":"https://github.com/jmerle/competitive-companion/issues/636","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3366068577","fragment_type":"issue_comment","sequence":3,"text":"@touhidurrr URL at this link you can find all the problems list.","author_login":"SathvikReddy0330","author_association":"NONE","created_at":"2025-10-03T15:00:02+08:00","repo_name":"jmerle/competitive-companion","issue_id":3409553686,"issue_number":636,"issue_url":"https://github.com/jmerle/competitive-companion/issues/636","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3366108544","fragment_type":"issue_comment","sequence":4,"text":"Like LeetCode, Topcoder is not supported because of its I/O format. The Topcoder Archive uses the same format, as mentioned by @touhidurrr. See #245 for more information, I'm closing this issue as out-of-scope.","author_login":"jmerle","author_association":"OWNER","created_at":"2025-10-03T15:08:40+08:00","repo_name":"jmerle/competitive-companion","issue_id":3409553686,"issue_number":636,"issue_url":"https://github.com/jmerle/competitive-companion/issues/636","linked_issue_ids":[1244089211],"is_known_query_context":false},{"document_id":"gh_comment_3366108548","fragment_type":"issue_comment","sequence":5,"text":"I also have another idea, we can make a simple cli tool that runs the testcases and writes output to a file and compares it to original answers.","author_login":"SathvikReddy0330","author_association":"NONE","created_at":"2025-10-03T15:08:40+08:00","repo_name":"jmerle/competitive-companion","issue_id":3409553686,"issue_number":636,"issue_url":"https://github.com/jmerle/competitive-companion/issues/636","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1244089211","fragment_type":"issue_description","sequence":0,"text":"On the topic of websites like LeetCode\nHi there,\n\nBecause of the existence of many issues asking for support for certain online judges, I decided to create a more elaborate issue explaining the reasons behind rejecting these feature requests every time. This issue concerns all online judges that require you to write your code in predefined functions or classes, like LeetCode, GeeksforGeeks, Topcoder, InterviewBit, CodeStudio, and binarysearch.\n\nCompetitive Companion's most important feature is its ability to provide access to the problem data of 60+ online judges in a generic way. It's able to do this because the online judges it currently supports all follow roughly the same format, where you are free in how you structure your code, where all input/output is string-based, and where input/output is communicated via stdin/stdout or via files.\n\nThis consistency makes it possible for Competitive Companion to aid external tools in 2 important tasks: generating relevant skeleton files and running sample cases locally. All parsers in Competitive Companion are able to aid in both of those tasks, and I expect all future parsers to be able to do so as well.\n\nThe primary reason why feature requests for the aforementioned websites are rejected every time is because their \"complete this function or class, don't use your own template\" format is completely different from these 60+ other judges. You are not free in how you structure your code, and these websites usually provide template code that is not able to compile in your local environment, let alone run the sample cases locally (missing `main` function, missing imports, missing class definitions, etc.). In other words, the problem format these websites use does not fit within Competitive Companion's set of supported problem formats.\n\nTheoretically it is possible for a browser extension to fix the previously mentioned problems automatically. Such an extension would have to parse problem pages like Competitive Companion does, but also needs to convert the template code so that it can compile and run sample cases in a local environment. It'd have to be generic so that it works with all problems (it's not always just a single function call with a trivially constructed argument), for multiple programming languages (LeetCode alone already supports many popular languages), and for multiple websites.\n\nHowever, I consider such functionality to be way outside the scope of Competitive Companion, and totally worthy of being a standalone project (not created by me though).\n\nAnother issue that affects several of these websites is that their sample case format is inconsistent. This makes it very hard for any extension to consistently parse the provided input/output samples correctly.\n\nPlease know that creating new issues requesting support for these websites won't help. The answer hasn't changed since 2018 and isn't likely to change any time soon.","author_login":"jmerle","author_association":"OWNER","created_at":"2022-05-21T21:52:32+08:00","repo_name":"jmerle/competitive-companion","issue_id":1244089211,"issue_number":245,"issue_url":"https://github.com/jmerle/competitive-companion/issues/245","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1133814231","fragment_type":"issue_comment","sequence":1,"text":"I do understand what you mean when you say that competitive companion wouldn't be as consistent when we add parsers for websites which require code to be in a predetermined format and the rest cases are not stdin/stdout. \n\nHowever, when I use the extension I usually just want to code the problem using my local ide to get faster compilations and use the debugger. Just a click on the extension opens my editor and I can start the problem there. If it is sometimes not able to get the boiler plate code or the test cases, it still helped me to get on my ide and create a file without any effort. \n\nA perfect solution for such websites may not exist but we can still provide this partial support instead of avoiding then. Some extra info can be shown when the user tries to parse a problem from unsupported website.","author_login":"KorigamiK","author_association":"NONE","created_at":"2022-05-22T04:07:45+08:00","repo_name":"jmerle/competitive-companion","issue_id":1244089211,"issue_number":245,"issue_url":"https://github.com/jmerle/competitive-companion/issues/245","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1157063428","fragment_type":"issue_comment","sequence":2,"text":"I understand your use case of having quick access to a local file in an environment that's all set to get going, but it's not what this extension is built for, and easily something that external tools can provide on their own.\n \n\nI don't agree. I'm not willing to drop the aforementioned consistency for the sake of adding partial parsers that are (in my opinion) out-of-scope for this extension.","author_login":"jmerle","author_association":"OWNER","created_at":"2022-06-15T23:15:13+08:00","repo_name":"jmerle/competitive-companion","issue_id":1244089211,"issue_number":245,"issue_url":"https://github.com/jmerle/competitive-companion/issues/245","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1340809645","fragment_type":"issue_comment","sequence":3,"text":"Wish someone will make an extension to parse from those sites.","author_login":"Sakib62","author_association":"NONE","created_at":"2022-12-07T11:08:50+08:00","repo_name":"jmerle/competitive-companion","issue_id":1244089211,"issue_number":245,"issue_url":"https://github.com/jmerle/competitive-companion/issues/245","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2113898621","fragment_type":"issue_comment","sequence":4,"text":"hi! thanks a lot for creating this extension and also for sharing this writeup.\n\ni completely understand your concern, and totally agree with points raised. i also was feelng the same regarding quoted part.\nso, would u mind sharing a recommendation for any such site which's supported by competitive-companion?\n\ni tried codeforces, but that doesn't really fit (or say i don't know how to tune it to) the problems that leetcode offer. it gives abstract names to problems - which works if doing things recreationally, but not when using it as a guided syllabus.\n\ni also tried hackerrank too, but similar problem as above.","author_login":"goyalyashpal","author_association":"NONE","created_at":"2024-05-16T02:27:52+08:00","repo_name":"jmerle/competitive-companion","issue_id":1244089211,"issue_number":245,"issue_url":"https://github.com/jmerle/competitive-companion/issues/245","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0266","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Search broken in docs?","query_context":"# Bug report\n\n## Describe the bug\n\nLooks like searching documentation is broken!\n\n## To Reproduce\n\nSteps to reproduce the behavior, please provide code snippets or a repository:\n1. Go to URL \n2. Click on the Search box\n3. Type anything in the search box\n\n## Expected behavior\nResults\n\n## Actual behavior\nThe UI says I'm offline, the console is full of net::ERR_NAME_NOT_RESOLVED\n\n## Screenshots\nScreen Shot 2022-03-22 at 11 04 08 AM\n\n## System information\nMac, Chrome","known_context_document_ids":["gh_issue_1177126839"],"reference_answer":"You're welcome to help here @Hallidayo - I don't know what the `appId` should be in this case - perhaps just `supabase`?","answer_document_id":"gh_comment_1073799317","silver_evidence_path":["gh_comment_1075699912","gh_issue_1157355690","gh_comment_1073799317"],"evidence_issue_ids":[1177126839,1157355690],"source_repo_name":"supabase/supabase","source_issue_id":1177126839,"source_issue_number":6007,"source_issue_url":"https://github.com/supabase/supabase/issues/6007","target_repo_name":"supabase/supabase","target_issue_id":1157355690,"target_issue_number":5762,"target_issue_url":"https://github.com/supabase/supabase/issues/5762","reference_anchor_document_id":"gh_comment_1075699912","reference_answer_author":"kiwicopple","reference_answer_author_association":"MEMBER","quality_score":86.15,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0769,"anchor_target_overlap":0.2308,"target_answer_overlap":0.1111},"issue_created_at":"2022-03-22T18:07:45+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_1177126839","fragment_type":"issue_description","sequence":0,"text":"Search broken in docs\n# Bug report\n\n## Describe the bug\n\nLooks like searching documentation is broken!\n\n## To Reproduce\n\nSteps to reproduce the behavior, please provide code snippets or a repository:\n1. Go to URL \n2. Click on the Search box\n3. Type anything in the search box\n\n## Expected behavior\nResults\n\n## Actual behavior\nThe UI says I'm offline, the console is full of net::ERR_NAME_NOT_RESOLVED\n\n## Screenshots\nScreen Shot 2022-03-22 at 11 04 08 AM\n\n## System information\nMac, Chrome","author_login":"whalesync-ryder","author_association":"NONE","created_at":"2022-03-22T18:07:45+08:00","repo_name":"supabase/supabase","issue_id":1177126839,"issue_number":6007,"issue_url":"https://github.com/supabase/supabase/issues/6007","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1075699912","fragment_type":"issue_comment","sequence":1,"text":"@kiwicopple @Isaiah-Hamilton - I think this is related to #5762.\n\nLooking at the Docusaurus docs the `appId` has to be the `The application ID provided by Algolia` at the moment the appId is :\n\n`appId: 'supabase'`","author_login":"Hallidayo","author_association":"NONE","created_at":"2022-03-22T22:22:16+08:00","repo_name":"supabase/supabase","issue_id":1177126839,"issue_number":6007,"issue_url":"https://github.com/supabase/supabase/issues/6007","linked_issue_ids":[1157355690],"is_known_query_context":false},{"document_id":"gh_comment_1077734004","fragment_type":"issue_comment","sequence":2,"text":"@kiwicopple - I've tried the new details but I'm getting an error `Index supabase does not exist` when doing any search on the documentation:\n\n<img width=\"477\" alt=\"Screenshot 2022-03-24 at 15 06 46\" src=\" URL \n\n<img width=\"341\" alt=\"Screenshot 2022-03-24 at 15 07 37\" src=\" URL","author_login":"Hallidayo","author_association":"NONE","created_at":"2022-03-24T15:08:29+08:00","repo_name":"supabase/supabase","issue_id":1177126839,"issue_number":6007,"issue_url":"https://github.com/supabase/supabase/issues/6007","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1079908806","fragment_type":"issue_comment","sequence":3,"text":"OK I just created an index called `supabase`. Let's hope that's the final step!","author_login":"kiwicopple","author_association":"MEMBER","created_at":"2022-03-27T11:19:00+08:00","repo_name":"supabase/supabase","issue_id":1177126839,"issue_number":6007,"issue_url":"https://github.com/supabase/supabase/issues/6007","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1080021595","fragment_type":"issue_comment","sequence":4,"text":"Ran a build locally and I'm getting no errors in the console now. Shall I create a pull request so you guys can test your end?","author_login":"Hallidayo","author_association":"NONE","created_at":"2022-03-27T21:21:37+08:00","repo_name":"supabase/supabase","issue_id":1177126839,"issue_number":6007,"issue_url":"https://github.com/supabase/supabase/issues/6007","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1081352212","fragment_type":"issue_comment","sequence":5,"text":"@Hallidayo it would be great if you could open a pull request.","author_login":"Isaiah-Hamilton","author_association":"COLLABORATOR","created_at":"2022-03-29T03:06:19+08:00","repo_name":"supabase/supabase","issue_id":1177126839,"issue_number":6007,"issue_url":"https://github.com/supabase/supabase/issues/6007","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1109139318","fragment_type":"issue_comment","sequence":6,"text":"Yes we're still working on this issue, a support ticket has already been sent to Algolia.","author_login":"burmecia","author_association":"CONTRIBUTOR","created_at":"2022-04-25T23:32:46+08:00","repo_name":"supabase/supabase","issue_id":1177126839,"issue_number":6007,"issue_url":"https://github.com/supabase/supabase/issues/6007","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1157355690","fragment_type":"issue_description","sequence":0,"text":"Docs Server Build Error - algolia.appId is required\n# Bug report\n\n## Describe the bug\n\nI've recently forked supabase to work on an issue. I've cloned the repository to my local system and followed this guide. When I run `yarn build` for the docs development server I get the following error in my terminal:\n\n<img width=\"569\" alt=\"Screenshot 2022-03-02 at 15 20 48\" src=\" URL \n\n## To Reproduce\n\nSteps to reproduce the behavior, please provide code snippets or a repository:\n\n1. Follow this guide up until Start a Development Server\n2. Go to the Supabase Docs Development Server section\n3. Run the `yarn build` command\n4. The error I am experiencing should appear\n\n## Expected behavior\n\nThe development server should build and then the command `yarn start` is ran which should start the development server.\n\n## Screenshots\n<img width=\"569\" alt=\"Screenshot 2022-03-02 at 15 20 48\" src=\" URL \n\n## System information\n\n- OS: macOS\n- Version of Node.js: 16.4.0 LTS","author_login":"Hallidayo","author_association":"NONE","created_at":"2022-03-02T15:33:25+08:00","repo_name":"supabase/supabase","issue_id":1157355690,"issue_number":5762,"issue_url":"https://github.com/supabase/supabase/issues/5762","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1061064947","fragment_type":"issue_comment","sequence":1,"text":"I'm not sure anyone on the team is using yarn at the moment with these sites, so I can't really confirm if there's any issue with that.\n\n@Hallidayo have you followed these steps yet?","author_login":"MildTomato","author_association":"CONTRIBUTOR","created_at":"2022-03-07T19:42:22+08:00","repo_name":"supabase/supabase","issue_id":1157355690,"issue_number":5762,"issue_url":"https://github.com/supabase/supabase/issues/5762","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1061123392","fragment_type":"issue_comment","sequence":2,"text":"@MildTomato - Thank you for the reply.\n \n@Hallidayo have you followed these steps yet?\n\nI've just done the above now and then tried `yarn build` but again the same error is appearing for me.\n\nI've also tried with npm as well but same error as with yarn.\n\nError I am getting: `[ERROR] ValidationError: \"algolia.appId\" is required. If you haven't migrated to the new DocSearch infra, please refer to the blog post for instructions: URL \n\nIs their an Algolia appId that I could try?","author_login":"Hallidayo","author_association":"NONE","created_at":"2022-03-07T20:50:42+08:00","repo_name":"supabase/supabase","issue_id":1157355690,"issue_number":5762,"issue_url":"https://github.com/supabase/supabase/issues/5762","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1063618192","fragment_type":"issue_comment","sequence":3,"text":"The problem seems to be that we upgraded the docSreach but forgot to add `appId` to the `docusaurus.config.js` file.\n\nThe `docusaurus.config.js` file should look like this:\n\njs\nalgolia: {\n appId: ' ',\n apiKey: ' ',\n},\n\nBut currently we have it like this:\n\njs\nalgolia: {\n apiKey: '766d56f13dd1e82f43253559b7c86636',\n indexName: 'supabase',\n},\n\nThere is more information in the docusaurus docs.","author_login":"Isaiah-Hamilton","author_association":"COLLABORATOR","created_at":"2022-03-10T03:35:59+08:00","repo_name":"supabase/supabase","issue_id":1157355690,"issue_number":5762,"issue_url":"https://github.com/supabase/supabase/issues/5762","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1073799317","fragment_type":"issue_comment","sequence":4,"text":"You're welcome to help here @Hallidayo - I don't know what the `appId` should be in this case - perhaps just `supabase`?","author_login":"kiwicopple","author_association":"MEMBER","created_at":"2022-03-21T11:48:51+08:00","repo_name":"supabase/supabase","issue_id":1157355690,"issue_number":5762,"issue_url":"https://github.com/supabase/supabase/issues/5762","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0267","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Firefox browser extention does not automatically or manually lock anymore?","query_context":"### Steps To Reproduce\n\n1. Restart Firefox\n2. Unlock Bitwarden\n3. Use the browser a bit\n4. Try to lock Bitwarden\n\n### Expected Result\n\nExpected the extention to lock and require password/PIN.\n\n### Actual Result\n\nDoes not do anything.\n\n### Screenshots or Videos\n\n_No response_\n\n### Additional Context\n\nWhen I try to to it manually in the Settings in the extension it also does nothing.\n\n### Operating System\n\nmacOS\n\n### Operating System Version\n\n12.5.1\n\n### Web Browser\n\nFirefox\n\n### Browser Version\n\n104.0.2\n\n### Build Version\n\n2022.8.0","known_context_document_ids":["gh_issue_1379995556"],"reference_answer":"Since this issue has been open for quite some time without recent activity, I'm curious if anyone is still experiencing this problem. If the issue persists, please share any updated details. Thanks, everyone, for your contributions and feedback!","answer_document_id":"gh_comment_2309979711","silver_evidence_path":["gh_comment_1257027550","gh_issue_1334980463","gh_comment_2309979711"],"evidence_issue_ids":[1379995556,1334980463],"source_repo_name":"bitwarden/clients","source_issue_id":1379995556,"source_issue_number":3570,"source_issue_url":"https://github.com/bitwarden/clients/issues/3570","target_repo_name":"bitwarden/clients","target_issue_id":1334980463,"target_issue_number":3274,"target_issue_url":"https://github.com/bitwarden/clients/issues/3274","reference_anchor_document_id":"gh_comment_1257027550","reference_answer_author":"Greenderella","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.25,"target_answer_overlap":0.2609},"issue_created_at":"2022-09-20T21:06:22+08:00","valid_comment_count":28,"fragments":[{"document_id":"gh_issue_1379995556","fragment_type":"issue_description","sequence":0,"text":"Firefox browser extention does not automatically or manually lock anymore\n### Steps To Reproduce\n\n1. Restart Firefox\n2. Unlock Bitwarden\n3. Use the browser a bit\n4. Try to lock Bitwarden\n\n### Expected Result\n\nExpected the extention to lock and require password/PIN.\n\n### Actual Result\n\nDoes not do anything.\n\n### Screenshots or Videos\n\n_No response_\n\n### Additional Context\n\nWhen I try to to it manually in the Settings in the extension it also does nothing.\n\n### Operating System\n\nmacOS\n\n### Operating System Version\n\n12.5.1\n\n### Web Browser\n\nFirefox\n\n### Browser Version\n\n104.0.2\n\n### Build Version\n\n2022.8.0","author_login":"timharek","author_association":"NONE","created_at":"2022-09-20T21:06:22+08:00","repo_name":"bitwarden/clients","issue_id":1379995556,"issue_number":3570,"issue_url":"https://github.com/bitwarden/clients/issues/3570","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1254001626","fragment_type":"issue_comment","sequence":1,"text":"Thanks for letting me know, for some reason I can't copy my browser version from the settings 😅","author_login":"timharek","author_association":"NONE","created_at":"2022-09-21T17:17:42+08:00","repo_name":"bitwarden/clients","issue_id":1379995556,"issue_number":3570,"issue_url":"https://github.com/bitwarden/clients/issues/3570","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1257027550","fragment_type":"issue_comment","sequence":2,"text":"Hi @timharek and @mrlinuxfish, thank you for your reports.\n\nIs it possible a popped out window of the extension was open or Bitwarden was open in the Firefox sidebar? If one of those were the case then this has previously been reported with URL \n\nIf not, then it's possibly a duplicate of URL \n\nPlease close this issue, if its a duplicate to one of the mentioned issues.","author_login":"djsmith85","author_association":"CONTRIBUTOR","created_at":"2022-09-24T17:43:38+08:00","repo_name":"bitwarden/clients","issue_id":1379995556,"issue_number":3570,"issue_url":"https://github.com/bitwarden/clients/issues/3570","linked_issue_ids":[1334980463],"is_known_query_context":false},{"document_id":"gh_comment_1257041804","fragment_type":"issue_comment","sequence":3,"text":"Thanks for the reply!\n \n\nNo, I regularly quit my browser and this happens every time now. It may be a duplicate of #3274, but I don't know for sure.","author_login":"timharek","author_association":"NONE","created_at":"2022-09-24T18:46:05+08:00","repo_name":"bitwarden/clients","issue_id":1379995556,"issue_number":3570,"issue_url":"https://github.com/bitwarden/clients/issues/3570","linked_issue_ids":[1334980463],"is_known_query_context":false},{"document_id":"gh_comment_1257291863","fragment_type":"issue_comment","sequence":4,"text":"@djsmith85 I have closed my browser a few times and I definitely don't have bitwarden open in the sidebar or a floating window","author_login":"mrlinuxfish","author_association":"NONE","created_at":"2022-09-25T22:23:47+08:00","repo_name":"bitwarden/clients","issue_id":1379995556,"issue_number":3570,"issue_url":"https://github.com/bitwarden/clients/issues/3570","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1266612851","fragment_type":"issue_comment","sequence":5,"text":"I never had a locking issue and I can't reproduce.\nimage\nimage","author_login":"Camusensei","author_association":"NONE","created_at":"2022-10-04T08:48:13+08:00","repo_name":"bitwarden/clients","issue_id":1379995556,"issue_number":3570,"issue_url":"https://github.com/bitwarden/clients/issues/3570","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1275917856","fragment_type":"issue_comment","sequence":6,"text":"My vault is also permantly unlocked despite having a vault timeout of \"1 minute\", and vault timeout action of \"Lock\". Even pressing on the \"Lock Now\" does nothing. Wonderful security.\n\nOS: macOS Monterey 12.4\nBrowser: Firefox 104.0.2\nExtension: 2022.9.1","author_login":"OliverPearmain","author_association":"NONE","created_at":"2022-10-12T10:06:41+08:00","repo_name":"bitwarden/clients","issue_id":1379995556,"issue_number":3570,"issue_url":"https://github.com/bitwarden/clients/issues/3570","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1275926418","fragment_type":"issue_comment","sequence":7,"text":"It works for me on (I will edit my message later to add the version of the browser on windows):\nFirefox 105.0 + Ubuntu 20.04.5 LTS\nFirefox + Windows 10\nEdge + Windows 10\n\nBe careful, being arrogant like this may make people not want to help anymore.\nHave you tried re-installing the extension?\nWhat about logout as a timeout action, does it work?","author_login":"Camusensei","author_association":"NONE","created_at":"2022-10-12T10:13:26+08:00","repo_name":"bitwarden/clients","issue_id":1379995556,"issue_number":3570,"issue_url":"https://github.com/bitwarden/clients/issues/3570","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1275961385","fragment_type":"issue_comment","sequence":8,"text":"Restarting the browser entirely has solved the issue for me. However if its possible to put the extension in this state it seems like a siginificany security vulnerability (hence my sarcastic comment, I apologise for this it was inappropriate).","author_login":"OliverPearmain","author_association":"NONE","created_at":"2022-10-12T10:44:54+08:00","repo_name":"bitwarden/clients","issue_id":1379995556,"issue_number":3570,"issue_url":"https://github.com/bitwarden/clients/issues/3570","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1338602286","fragment_type":"issue_comment","sequence":9,"text":"@nortti0 good job finding this. Same behaviour on windows.\nWith this, I guess someone will be able to figure out where the problem is coming from.\nBut beware: being in the middle of creating a new login is probably ONLY ONE of the triggers which can lead to this tricky situation.","author_login":"Camusensei","author_association":"NONE","created_at":"2022-12-06T01:36:59+08:00","repo_name":"bitwarden/clients","issue_id":1379995556,"issue_number":3570,"issue_url":"https://github.com/bitwarden/clients/issues/3570","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1341961135","fragment_type":"issue_comment","sequence":10,"text":"I can confirm @nrotti0's steps work on macOS - well done! Specifically, this is how I do it:\n\n1. Ensure the Bitwarden extension is logged into a vault, but is locked\n1. Browse to a page with a URL that doesn't have a vault entry associated with it, e.g., Firefox's new tab page\n1. Click the toolbar button to open the Bitwarden popup\n1. Enter the master password to unlock the vault\n1. Click the \"Add a Login\" button\n1. Command-Tab away from Firefox to a different application that's running, causing the popup to close\n1. Command-Tab back to Firefox\n1. Click the toolbar button again to re-open the Bitwarden popup\n1. In the popup, click Settings -> Lock Now and observe that the vault does not lock\n\nEchoing @Camusensei's point, I don't recall the circumstances that caused me to stumble upon this issue originally, so I can't say for sure if this is the only way to induce it.\n\nAs of now, I'm using:\n- Firefox 107.0.1 \n- Bitwarden extension 2022.10.1\n- macOS 10.15.7","author_login":"calvinrw","author_association":"NONE","created_at":"2022-12-08T04:03:22+08:00","repo_name":"bitwarden/clients","issue_id":1379995556,"issue_number":3570,"issue_url":"https://github.com/bitwarden/clients/issues/3570","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2286415592","fragment_type":"issue_comment","sequence":11,"text":"Hello,\n\nWe can no longer reproduce this issue. Please try a clean installation by removing any leftover data ( URL \n\nAdditionally, you might want to refresh your Firefox profile (instructions here: URL \n\nWe use GitHub issues as a place to track bugs and other development related issues. If your issue persists, please write us back using our “Contact support” form located on our Help Center ( URL \n\nYou can include a link to this issue in the message content.\n\nAlternatively, you can also search for an answer in our help documentation or get help from other Bitwarden users on our community forums ( URL \n\nThe issue here will be closed.\n\nThanks!","author_login":"Greenderella","author_association":"MEMBER","created_at":"2024-08-13T14:34:56+08:00","repo_name":"bitwarden/clients","issue_id":1379995556,"issue_number":3570,"issue_url":"https://github.com/bitwarden/clients/issues/3570","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1334980463","fragment_type":"issue_description","sequence":0,"text":"Major Security Issue: Browser Plugin DID NOT LOCK\n### Steps To Reproduce\n\nI'm not sure what produced this or how/if I can reproduce it. \n\nI just noticed upon unlocking my Win 10 desktop where Firefox was already open, opening a tab, and logging into a new web site, that BW did not prompt me for a PIN.\n\nI EXPECT that a browser restart will correct this issue, but it will not help plug this security flaw.\n\n### Expected Result\n\nIn similar situations, I would have had to enter a PIN to unlock BW.\n\n### Actual Result\n\nBW remained unlock overnight, even with a LOCK timeout of 5 minutes, and Unlock with PIN checked.\n\n### Screenshots or Videos\n\nimage\n\n### Additional Context\n\nI have NEVER had this happen before. Firefox has been running for about 24 hours since launch, with only one tab open. Even as I write this, BW has still not locked, which is a SERIOUS security issue. Before I noticed this, I had been adjusting some Firefox settings (menu, not config) in an attempt to get videos to appear in my Twitter feed, which have recently started showing as black image with no sound, even though the play bar showed movement.\n\nI will leave this up for a while in case you would like me to do any further testing.\n\n### Operating System\n\nWindows\n\n### Operating System Version\n\n10 Pro 21H1 19043.1826x64\n\n### Web Browser\n\nFirefox\n\n### Browser Version\n\n101.0.1\n\n### Build Version\n\n2022.8.0","author_login":"GrizzlyAK","author_association":"NONE","created_at":"2022-08-10T17:56:41+08:00","repo_name":"bitwarden/clients","issue_id":1334980463,"issue_number":3274,"issue_url":"https://github.com/bitwarden/clients/issues/3274","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1211121857","fragment_type":"issue_comment","sequence":1,"text":"Hi @GrizzlyAK and thank you for your report.\n\nI was unable to reproduce this on a similar setup (Win10, Firefox, Bitwarden 2022.08).\n\nCould it be possible that the popup was still open, a popped out window of the extension was open or Bitwarden was open in the Firefox sidebar? If the answer to any is yes, then this has previously been reported with URL \n\nYou also mention changing some settings on Firefox, do you remember which settings you changed, in case the above mentioned does not resolve this.\n\nPlease report back and provide further information or close this issue if it has been resolved.\n\nKind regards,\nDaniel","author_login":"djsmith85","author_association":"CONTRIBUTOR","created_at":"2022-08-10T18:47:21+08:00","repo_name":"bitwarden/clients","issue_id":1334980463,"issue_number":3274,"issue_url":"https://github.com/bitwarden/clients/issues/3274","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1211284718","fragment_type":"issue_comment","sequence":2,"text":"`Could it be possible that the popup was still open`\nNo.\n\nI do not remember exactly which settings I changed, but I was flipping a lot of them off/on sequentially, although I do believe that all of the settings are as they originally were. I was testing to see if I could find ONE that was causing the issue with Twitter. I do know that I disabled all of my add-ons, except, I believe, BW. \n\nAs expected, I disabled the BW add-on, and after re-enabling it, I had to supply the Master PW. I will try to see if I can reproduce this problem. But I can attest that BW was in a \"resting\" state in my browser overnight (i.e., not open, but previously unlocked and used for logins) and failed to lock during that period.","author_login":"GrizzlyAK","author_association":"NONE","created_at":"2022-08-10T21:17:51+08:00","repo_name":"bitwarden/clients","issue_id":1334980463,"issue_number":3274,"issue_url":"https://github.com/bitwarden/clients/issues/3274","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1214854498","fragment_type":"issue_comment","sequence":3,"text":"I've experienced this once so far (this is how I found this bug).\nBW 2022.8.0\nFF 103.0.1, 64bit, Fedora\n\nWhen this occured I had not changed any FF settings, or done any changes to extensions. I just noticed that the extension was still unlocked when it should not have been. Manually selecting \"Lock now\" from the settings menu also did not lock the vault.\nI had unlocked the vault, and used it, I believe, only in private windows, through the Right click->Bitwarden->Auto fill functionality.\nI've not been able to reproduce this so far, but if it ever happens again, are there logs/debug information that I could collect?","author_login":"Lalufu","author_association":"NONE","created_at":"2022-08-15T10:14:57+08:00","repo_name":"bitwarden/clients","issue_id":1334980463,"issue_number":3274,"issue_url":"https://github.com/bitwarden/clients/issues/3274","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1216843592","fragment_type":"issue_comment","sequence":4,"text":"I have started experiencing this issue recently. \nBW: 2022.8.0\nFF: 103.0.2, 64bit\nSystem: macOS\n\nI have the settings to lock from the day one & it used to lock automatically after inactivity. Now it hasn't locked from 2 days. \"Lock Now\" failed for me as well.","author_login":"gsaran","author_association":"NONE","created_at":"2022-08-16T16:04:55+08:00","repo_name":"bitwarden/clients","issue_id":1334980463,"issue_number":3274,"issue_url":"https://github.com/bitwarden/clients/issues/3274","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1221492636","fragment_type":"issue_comment","sequence":5,"text":"What happened to the Bitwarden browser plugin? Not only will my BW client in Firefox no longer lock after the timeout has lapsed, but it won't lock using the Lock Now command in Settings either. I've also noticed that Search is fracked and returns NOTHING when entering anything. \n\nFor example, I search for \"github\" and...\n\nimage\n\nand I just used it to log into to Github to post this! You can see, the little \"1\" on the BW badge indicating that Github knows it's there yet... 🤷‍♂️ \n\nI'm quickly losing confidence in the security of BitWarden. I hope this can be resolved soon. None of these issues affect the Desktop App. It locks after the timeout and Search works fine. Is anybody seeing this in any other browsers than Firefox?\n\n Is there a way to install a previous version in FF, maybe?\n\nI saw there was an \"Info Needed\" tag added. What Info do you need? I thought this would get a little more attention.","author_login":"GrizzlyAK","author_association":"NONE","created_at":"2022-08-21T07:53:07+08:00","repo_name":"bitwarden/clients","issue_id":1334980463,"issue_number":3274,"issue_url":"https://github.com/bitwarden/clients/issues/3274","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1227173266","fragment_type":"issue_comment","sequence":6,"text":"Like @GrizzlyAK, my FF Lock Now button wasn't working, and toggling extension enabled fixed it. \n\nLike the others, this morning I experienced an unlocked vault without re-entering my password. Vault timeout set to 1 hour.","author_login":"DustinWehr","author_association":"NONE","created_at":"2022-08-25T12:10:22+08:00","repo_name":"bitwarden/clients","issue_id":1334980463,"issue_number":3274,"issue_url":"https://github.com/bitwarden/clients/issues/3274","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1227183011","fragment_type":"issue_comment","sequence":7,"text":"@djsmith85 I see this error in my browser console from `vaultTimeout.service.ts`:","author_login":"DustinWehr","author_association":"NONE","created_at":"2022-08-25T12:20:29+08:00","repo_name":"bitwarden/clients","issue_id":1334980463,"issue_number":3274,"issue_url":"https://github.com/bitwarden/clients/issues/3274","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1275993624","fragment_type":"issue_comment","sequence":8,"text":"I had some similar problems before. If I used the browser with a memory-intensive site for a while (sites with unending feeds), my vault wouldn't time-out, the lock-now didn't work, the folders disappeared, etc. After I removed the extension, and reinstalled, all the said problems went away and haven't happened again. Hope this help.","author_login":"Tipoff4317","author_association":"NONE","created_at":"2022-10-12T11:14:27+08:00","repo_name":"bitwarden/clients","issue_id":1334980463,"issue_number":3274,"issue_url":"https://github.com/bitwarden/clients/issues/3274","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1276660992","fragment_type":"issue_comment","sequence":9,"text":"@Tipoff4317 thanks for reporting this. Although I haven't noticed my vault in FF _not_ locking for a little while now, I went ahead and uninstalled BW and reinstalled it as suggested. It won't hurt. I'll report back if I see it again. Please do the same. Cheers.","author_login":"GrizzlyAK","author_association":"NONE","created_at":"2022-10-12T19:49:57+08:00","repo_name":"bitwarden/clients","issue_id":1334980463,"issue_number":3274,"issue_url":"https://github.com/bitwarden/clients/issues/3274","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1342248421","fragment_type":"issue_comment","sequence":10,"text":"Hi all. thanks for the additional context you have provided. I'm going to raise this internally, and we will look into this. Will provide feedback once we have a known ETA. Thanks for the patience!","author_login":"dbosompem","author_association":"NONE","created_at":"2022-12-08T08:15:03+08:00","repo_name":"bitwarden/clients","issue_id":1334980463,"issue_number":3274,"issue_url":"https://github.com/bitwarden/clients/issues/3274","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1397302568","fragment_type":"issue_comment","sequence":11,"text":"We have recently moved over around 150 users to Bitwarden from Lastpass. Set the organization policy for Vault Timeout to 2 hours max, but users are reporting that their extensions are still unlocked on login after several days of being away from the device. This is a major concern for us. Any update on a timeline for a fix?","author_login":"DeskDude47","author_association":"NONE","created_at":"2023-01-19T16:57:04+08:00","repo_name":"bitwarden/clients","issue_id":1334980463,"issue_number":3274,"issue_url":"https://github.com/bitwarden/clients/issues/3274","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1398817789","fragment_type":"issue_comment","sequence":12,"text":"Hi @DeskDude47 and welcome to Bitwarden. This issue is something we have been researching into, to ensure we tackle the root cause. Efforts are still being made to ensure it's resolved. I will update this thread once an ETA is confirmed. Thank you for the patience!","author_login":"dbosompem","author_association":"NONE","created_at":"2023-01-20T19:08:26+08:00","repo_name":"bitwarden/clients","issue_id":1334980463,"issue_number":3274,"issue_url":"https://github.com/bitwarden/clients/issues/3274","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1435186867","fragment_type":"issue_comment","sequence":13,"text":"As of today, this issue still exists (Firefox V109.0.1, BW Add-on V2023.1.0), where my vault did not lock overnight. I have it set to Lock after 5 mins and reopen with PIN. Lock Now does not work. The only thing that seems to reset it, as mentioned by others, is to disable the Add-on and re-enable it in Firefox Add-ons and Themes. During the time this has occurred, I have basically been using Windows 10x64 to read PDF files using Acrobat Reader X Pro (v10.1.16) and reading email via Thunderbird V102.8.0), and have, at times, had two/three different instances of Firefox running, launched by moving a tab to another screen. The latter may be significant.","author_login":"GrizzlyAK","author_association":"NONE","created_at":"2023-02-17T20:09:01+08:00","repo_name":"bitwarden/clients","issue_id":1334980463,"issue_number":3274,"issue_url":"https://github.com/bitwarden/clients/issues/3274","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2309979711","fragment_type":"issue_comment","sequence":14,"text":"Since this issue has been open for quite some time without recent activity, I'm curious if anyone is still experiencing this problem. If the issue persists, please share any updated details. Thanks, everyone, for your contributions and feedback!","author_login":"Greenderella","author_association":"MEMBER","created_at":"2024-08-26T11:28:18+08:00","repo_name":"bitwarden/clients","issue_id":1334980463,"issue_number":3274,"issue_url":"https://github.com/bitwarden/clients/issues/3274","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2310680014","fragment_type":"issue_comment","sequence":15,"text":"I've personally not experienced this in months. Seems fixed to me.","author_login":"OliverPearmain","author_association":"NONE","created_at":"2024-08-26T17:12:36+08:00","repo_name":"bitwarden/clients","issue_id":1334980463,"issue_number":3274,"issue_url":"https://github.com/bitwarden/clients/issues/3274","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2310702503","fragment_type":"issue_comment","sequence":16,"text":"I have not experienced this in a while. Appears to be fixed. Thank you!Sent from my iPhoneOn Aug 26, 2024, at 9:12 AM, Oliver Pearmain ***@***.***> wrote:\n\nSince this issue has been open for quite some time without recent activity, I'm curious if anyone is still experiencing this problem. If the issue persists, please share any updated details. Thanks, everyone, for your contributions and feedback!\n\nI've personally not experienced this in months. Seems fixed to me.\n\n—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>","author_login":"GrizzlyAK","author_association":"NONE","created_at":"2024-08-26T17:25:23+08:00","repo_name":"bitwarden/clients","issue_id":1334980463,"issue_number":3274,"issue_url":"https://github.com/bitwarden/clients/issues/3274","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2360140806","fragment_type":"issue_comment","sequence":17,"text":"I have to report that this issue appeared to resurface, but there may be more to it. I have been using V127 of Firefox, up until yesterday, when I was told that Bitwarden was updated and needed me to \"log in\" to give the extension permission in FF. I found this suspicious, so I decided to finally upgrade FF to the latest (v130.0), which I did yesterday. Bitwarden did not originally appear in the FF upper right side toolbar, so I went to extensions, Bitwarden, Manage, and noticed that the Allow in Private Windows was not selected (which I always have selected - the update must have reset it). I don't know why these settings were reset. I changed it and Bitwarden then appeared top right as it should. Subsequently, I noticed that Bitwarden DID NOT LOCK anymore as it did in the previous version. Going into settings in the extension top right, Account Security, I see that the Vault Timeout is set to Browser Restart. I NEVER have used that setting, yet that is what it was set to after all of this, and is probably the reason why I was not seeing BW lock anymore. I changed the timeout to my standard setting and it now locks as it should. Although this issue has not actually resurfaced, it appeared to, because all of my settings following an update had been reset to defaults. I don't think that is wise and was definitely NOT expected. Just an FYI.","author_login":"GrizzlyAK","author_association":"NONE","created_at":"2024-09-19T06:54:57+08:00","repo_name":"bitwarden/clients","issue_id":1334980463,"issue_number":3274,"issue_url":"https://github.com/bitwarden/clients/issues/3274","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0275","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"CONAN_BASE_PROFILE_BUILD is not correctly passed to Docker?","query_context":"### Description of Problem, Request, or Question\n\nConanMultiPackager(use_docker=True) doesn't correctly handle build profile settings. If I set `CONAN_BASE_PROFILE_BUILD=my_build_profile`, CPT adds\n\n-e CPT_PROFILE_BUILD=\"@@include(my_build_profile)@@@@[settings]@@@@[options]@@@@[env]@@@@[build_requires]@@@@\"\n\nto Docker command line, but the build fails inside Docker because `my_build_profile` does not exist there:\n\n File \"c:\\python39\\lib\\site-packages\\conans\\client\\profile_loader.py\", line 132, in read_profile\n return _load_profile(text, profile_path, default_folder)\n File \"c:\\python39\\lib\\site-packages\\conans\\client\\profile_loader.py\", line 151, in _load_profile\n profile, included_vars = read_profile(include, cwd, default_folder)\n File \"c:\\python39\\lib\\site-packages\\conans\\client\\profile_loader.py\", line 119, in read_profile\n profile_path = get_profile_path(profile_name, default_folder, cwd)\n File \"c:\\python39\\lib\\site-packages\\conans\\client\\profile_loader.py\", line 107, in get_profile_path\n raise ConanException(\"Profile not found: %s\" % profile_name)\nconans.errors.ConanException: Profile not found: my_build_profile\n\nAnother problem is that in the absence of CONAN_BASE_PROFILE_BUILD CPT passes empty settings for the build profile:\n\n-e CPT_PROFILE=\"@@include(default)@@@@[settings]@@arch=x86_64@@build_type=Release@@compiler=Visual Studio@@compiler.runtime=MD@@compiler.version=15@@os=Windows@@[options]@@@@[env]@@@@[build_requires]@@@@\"\n-e CPT_PROFILE_BUILD=\"@@include(default)@@@@[settings]@@@@[options]@@@@[env]@@@@[build_requires]@@@@\"\n\nThat breaks my build that worked before with CPT 0.35.0. Why not pass the same settings in CPT_PROFILE_BUILD as in CPT_PROFILE if CONAN_BASE_PROFILE_BUILD is not set?\n\n### Environment Details\n* Conan Package Tools Version: **0.37.0**\n* Conan version: **conan 1.43.0**","known_context_document_ids":["gh_issue_1082247057"],"reference_answer":"@jmarrec have you already tried asking in m4 mail list, as it was discussed in #7369? it seems like there is no configure option to bypass the check, and proper fix may require to patch m4 sources.","answer_document_id":"gh_comment_1016462518","silver_evidence_path":["gh_comment_1015389623","gh_issue_1103697906","gh_comment_1016462518"],"evidence_issue_ids":[1082247057,1103697906],"source_repo_name":"conan-io/conan-package-tools","source_issue_id":1082247057,"source_issue_number":595,"source_issue_url":"https://github.com/conan-io/conan-package-tools/issues/595","target_repo_name":"conan-io/conan-center-index","target_issue_id":1103697906,"target_issue_number":8920,"target_issue_url":"https://github.com/conan-io/conan-center-index/issues/8920","reference_anchor_document_id":"gh_comment_1015389623","reference_answer_author":"SSE4","reference_answer_author_association":"COLLABORATOR","quality_score":85.78,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2115,"anchor_target_overlap":0.25,"target_answer_overlap":0.0556},"issue_created_at":"2021-12-16T14:15:32+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_1082247057","fragment_type":"issue_description","sequence":0,"text":"CONAN_BASE_PROFILE_BUILD is not correctly passed to Docker\n### Description of Problem, Request, or Question\n\nConanMultiPackager(use_docker=True) doesn't correctly handle build profile settings. If I set `CONAN_BASE_PROFILE_BUILD=my_build_profile`, CPT adds\n\n-e CPT_PROFILE_BUILD=\"@@include(my_build_profile)@@@@[settings]@@@@[options]@@@@[env]@@@@[build_requires]@@@@\"\n\nto Docker command line, but the build fails inside Docker because `my_build_profile` does not exist there:\n\n File \"c:\\python39\\lib\\site-packages\\conans\\client\\profile_loader.py\", line 132, in read_profile\n return _load_profile(text, profile_path, default_folder)\n File \"c:\\python39\\lib\\site-packages\\conans\\client\\profile_loader.py\", line 151, in _load_profile\n profile, included_vars = read_profile(include, cwd, default_folder)\n File \"c:\\python39\\lib\\site-packages\\conans\\client\\profile_loader.py\", line 119, in read_profile\n profile_path = get_profile_path(profile_name, default_folder, cwd)\n File \"c:\\python39\\lib\\site-packages\\conans\\client\\profile_loader.py\", line 107, in get_profile_path\n raise ConanException(\"Profile not found: %s\" % profile_name)\nconans.errors.ConanException: Profile not found: my_build_profile\n\nAnother problem is that in the absence of CONAN_BASE_PROFILE_BUILD CPT passes empty settings for the build profile:\n\n-e CPT_PROFILE=\"@@include(default)@@@@[settings]@@arch=x86_64@@build_type=Release@@compiler=Visual Studio@@compiler.runtime=MD@@compiler.version=15@@os=Windows@@[options]@@@@[env]@@@@[build_requires]@@@@\"\n-e CPT_PROFILE_BUILD=\"@@include(default)@@@@[settings]@@@@[options]@@@@[env]@@@@[build_requires]@@@@\"\n\nThat breaks my build that worked before with CPT 0.35.0. Why not pass the same settings in CPT_PROFILE_BUILD as in CPT_PROFILE if CONAN_BASE_PROFILE_BUILD is not set?\n\n### Environment Details\n* Conan Package Tools Version: **0.37.0**\n* Conan version: **conan 1.43.0**","author_login":"db4","author_association":"NONE","created_at":"2021-12-16T14:15:32+08:00","repo_name":"conan-io/conan-package-tools","issue_id":1082247057,"issue_number":595,"issue_url":"https://github.com/conan-io/conan-package-tools/issues/595","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1015389623","fragment_type":"issue_comment","sequence":1,"text":"I'm having a similar issue. I'm trying to force docker to use a build profile that would force build_requirements to be in Release mode even if the recipe itself is built in Debug mode (for 1) performance reasons, and 2) working around an issue I have with m4 that throws debug asserts URL \n\nThe idea to pass a build profile like so\n\ninclude(default)\n[settings]\nbuild_type=Release\n\nI've been uselessly trying to patch conan-package-tools to correctly pass `CONAN_BASE_PROFILE_BUILD` to docker but I haven't managed to make it work. I have opened a draft PR with my failed attempts at URL in the hope that it'll spark a conversation. #596 will be either cleaned if possible, or just closed if not.","author_login":"jmarrec","author_association":"NONE","created_at":"2022-01-18T13:00:58+08:00","repo_name":"conan-io/conan-package-tools","issue_id":1082247057,"issue_number":595,"issue_url":"https://github.com/conan-io/conan-package-tools/issues/595","linked_issue_ids":[1103697906],"is_known_query_context":false},{"document_id":"gh_comment_1234144514","fragment_type":"issue_comment","sequence":2,"text":"I also have encountered some problems with the changes introduced in commit 830e84a79c2c32b57824a227bc88b95406c3944d.\nIt forces Conan to always be called with a build profile. This changes some of the internal behavior of Conan and prevents the imports() method from copying files of private requirements of my top-level package (I am not sure if this might be a bug in Conan or if it is desired behavior, haven't looked into it, yet)\n\nI have a implemented a workaround that removes the \"default\" base profile when creating the Docker runner. This should now behave like the non-Docker path (pull request #604)","author_login":"sbannier","author_association":"CONTRIBUTOR","created_at":"2022-09-01T11:25:24+08:00","repo_name":"conan-io/conan-package-tools","issue_id":1082247057,"issue_number":595,"issue_url":"https://github.com/conan-io/conan-package-tools/issues/595","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1234347684","fragment_type":"issue_comment","sequence":3,"text":"The Release 0.38.1 includes the hotfix the PR #604. Please, update your local copy: URL","author_login":"uilianries","author_association":"MEMBER","created_at":"2022-09-01T14:18:04+08:00","repo_name":"conan-io/conan-package-tools","issue_id":1082247057,"issue_number":595,"issue_url":"https://github.com/conan-io/conan-package-tools/issues/595","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1103697906","fragment_type":"issue_description","sequence":0,"text":"[package] m4/1.4.19: Runtime assertion windows pops up on MSVC in Debug mode\n### Package and Environment Details (include every applicable attribute)\n * Package Name/Version: **m4/1.4.19**\n * Operating System+version: **Windows 10**\n * Compiler+version: **MSVC 2017, 2019 in DEBUG**\n * Conan version: **conan 1.44.0**\n * Python version: **Python 3.9.5**\n\nI have a recipe that depends on bison. 3.7.6 gives me parse errors, so I keep it at 3.7.1. I had pinned the exact bison/3.7.1 recipe and all worked well. I am trying to update my dependencies, so I tried the newest bison/3.7.1 revision, and I am now getting an assertion popup in m4.\n\nI have tried various combinations to see if I could pinpoint what changed. My conclusion is that it's the move from m4/1.4.18 to m4/1.4.19 (I have tried the newest recipe revision of m4/1.4.18 and it worked, and the only m4/1.4.19 available fails).\n\npython\n # Latest bison/3.7.1 with m4/1.4.18\n #self.build_requires(\"bison/3.7.1#dcffa3dd9204cb79ac7ca09a7f19bb8b\") # Works\n\n # First bison/3.7.1 with m4/1.4.19\n self.build_requires(\"bison/3.7.1#47f49e709ddb9f8e055471c4e3c4e67d\"): # Fails\n\n # Latest bison/3.7.1\n #self.build_requires(\"bison/3.7.1#ad29e804e82c8b6d58765096676b5a5e\") # Fails\n\n ` if custom profile is in use)\n\n[settings]\narch=x86_64\narch_build=x86_64\nbuild_type=Debug\ncompiler=Visual Studio\ncompiler.runtime=MDd\ncompiler.version=16\nos=Windows\nos_build=Windows\n[options]\n[build_requires]\n[env]\n\n### Steps to reproduce (Include if Applicable)\n\ngit clone git@github.com:NREL/conan-openstudio-ruby.git\ngit checkout update_ruby_installer_and_remotes\n\n'C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Community\\VC\\Auxiliary\\Build\\vcvarsall.bat' x64\n\nconan create . openstudio_ruby/2.7.2@nrel/testing -b missing -b openstudio_ruby -s build_type=Debug\n\n### Logs (Include/Attach if Applicable)\n\nExample of a failed run: URL","author_login":"jmarrec","author_association":"CONTRIBUTOR","created_at":"2022-01-14T14:16:39+08:00","repo_name":"conan-io/conan-center-index","issue_id":1103697906,"issue_number":8920,"issue_url":"https://github.com/conan-io/conan-center-index/issues/8920","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1015888609","fragment_type":"issue_comment","sequence":1,"text":"@madebr is this `\"reb\"` on purpose? URL \n\nThe 1.4.18 version has `\"rb\"` (which is familar to me, unlike reb...): URL","author_login":"jmarrec","author_association":"CONTRIBUTOR","created_at":"2022-01-18T22:23:39+08:00","repo_name":"conan-io/conan-center-index","issue_id":1103697906,"issue_number":8920,"issue_url":"https://github.com/conan-io/conan-center-index/issues/8920","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1015930599","fragment_type":"issue_comment","sequence":2,"text":"The patch is adding `'b'` (it is already `\"re\"`).\nIt looks like it is a GNU extension:\n\n e (since glibc 2.7)\n Open the file with the O_CLOEXEC flag. See open(2) for more information. This flag is ignored for\n fdopen().\n\nThe problem you're seeing with debug 2019 is probably the same we saw when adding m4/1.4.19.\nSee URL for our analysis at that time.\n\nWe have a short reproducer.","author_login":"madebr","author_association":"CONTRIBUTOR","created_at":"2022-01-18T23:36:01+08:00","repo_name":"conan-io/conan-center-index","issue_id":1103697906,"issue_number":8920,"issue_url":"https://github.com/conan-io/conan-center-index/issues/8920","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1015941014","fragment_type":"issue_comment","sequence":3,"text":"I just got the same issue building bison/3.7.6 in debug FYI\n\nimage","author_login":"jmarrec","author_association":"CONTRIBUTOR","created_at":"2022-01-18T23:58:31+08:00","repo_name":"conan-io/conan-center-index","issue_id":1103697906,"issue_number":8920,"issue_url":"https://github.com/conan-io/conan-center-index/issues/8920","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1015942648","fragment_type":"issue_comment","sequence":4,"text":"The problem is with m4. The bison version is kinda irrelevant.\nm4 is only used as a build requirement since it provides no library.\nI think you can work around the problem by adding `-s:b m4:build_type=Release`.","author_login":"madebr","author_association":"CONTRIBUTOR","created_at":"2022-01-19T00:01:29+08:00","repo_name":"conan-io/conan-center-index","issue_id":1103697906,"issue_number":8920,"issue_url":"https://github.com/conan-io/conan-center-index/issues/8920","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1016430011","fragment_type":"issue_comment","sequence":5,"text":"I'd like to do that, but unfortunately all my attemps of forcing the build_requires to be in Release mode failed when using CPT and docker (locally it works plently fine if I issue the conan create command manually)\n\n URL","author_login":"jmarrec","author_association":"CONTRIBUTOR","created_at":"2022-01-19T12:42:48+08:00","repo_name":"conan-io/conan-center-index","issue_id":1103697906,"issue_number":8920,"issue_url":"https://github.com/conan-io/conan-center-index/issues/8920","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1016462518","fragment_type":"issue_comment","sequence":6,"text":"@jmarrec have you already tried asking in m4 mail list, as it was discussed in #7369? it seems like there is no configure option to bypass the check, and proper fix may require to patch m4 sources.","author_login":"SSE4","author_association":"COLLABORATOR","created_at":"2022-01-19T13:24:05+08:00","repo_name":"conan-io/conan-center-index","issue_id":1103697906,"issue_number":8920,"issue_url":"https://github.com/conan-io/conan-center-index/issues/8920","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1016606056","fragment_type":"issue_comment","sequence":7,"text":"Both URL and URL when built locally allow me to build bison/3.7.6 (both in debug) without the popup","author_login":"jmarrec","author_association":"CONTRIBUTOR","created_at":"2022-01-19T15:53:18+08:00","repo_name":"conan-io/conan-center-index","issue_id":1103697906,"issue_number":8920,"issue_url":"https://github.com/conan-io/conan-center-index/issues/8920","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1016608349","fragment_type":"issue_comment","sequence":8,"text":"Not sure which solution we prefer. Perhaps combining them both actually...","author_login":"jmarrec","author_association":"CONTRIBUTOR","created_at":"2022-01-19T15:55:38+08:00","repo_name":"conan-io/conan-center-index","issue_id":1103697906,"issue_number":8920,"issue_url":"https://github.com/conan-io/conan-center-index/issues/8920","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1016615837","fragment_type":"issue_comment","sequence":9,"text":"I personally prefer URL as it doesn't require patching sources","author_login":"SSE4","author_association":"COLLABORATOR","created_at":"2022-01-19T16:03:02+08:00","repo_name":"conan-io/conan-center-index","issue_id":1103697906,"issue_number":8920,"issue_url":"https://github.com/conan-io/conan-center-index/issues/8920","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1016667497","fragment_type":"issue_comment","sequence":10,"text":"I'm less certain that this HAVE_MSVC_INVALID_PARAMETER_HANDLER actually fixes it in all cases though. And you wrote on URL","author_login":"jmarrec","author_association":"CONTRIBUTOR","created_at":"2022-01-19T16:56:33+08:00","repo_name":"conan-io/conan-center-index","issue_id":1103697906,"issue_number":8920,"issue_url":"https://github.com/conan-io/conan-center-index/issues/8920","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0277","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"[DOC] Provide guideline to setup an 'air-gapped' repository and how to enable Harvester UI extension in Rancher v2.10.x?","query_context":"**Is your doc request related to a problem? Please describe or add the related issue ID.**\nStarting from Rancher v2.10.0, we introduce the Harvester UI extension on Rancher.\n\n* Currently we provide the automatic install UI extension under regular network environment. \n\n* It extremely important we need to consider the use case of `air-gapped` environment since still many user and customer required this feature.\n\n* Thus we need to provide the guideline steps for how to properly setup an `air-gapped` local repository for user in their own environment. \n\n**Describe the solution you'd like**\n \n\nThe document could include these content\n\n1. Steps for to setup an air-ggaped repository \n2. Steps to add airgapped UI extension repository in Rancher\n3. Whether it support automatic install or always require to manually install the extension\n4. Anything we need to consider when upgrade Rancher from v2.10.x before. \n\n**Additional context**\n \n* For the air-ggaped repository setup, we can refer and extend from the test issue.\n - URL","known_context_document_ids":["gh_issue_2759216263"],"reference_answer":"Now I'm using vagrant to setup rancher, and follow the steps in URL to install harvester-ui-extenstion, but I'm still encountering the same installation failed issue, though I can use the workaround mentioned in URL to mitigate the installation failed issue. I'm wondering is this expected? Or should we consider it as a bug? c.c @khushboo-rancher, @noahgildersleeve.\n\nNote: the endpoint in harvester UIPlugin seems wrong, and should be ` URL instead.","answer_document_id":"gh_comment_2739170632","silver_evidence_path":["gh_comment_2585377698","gh_issue_2782073730","gh_comment_2739170632"],"evidence_issue_ids":[2759216263,2782073730],"source_repo_name":"harvester/harvester","source_issue_id":2759216263,"source_issue_number":7258,"source_issue_url":"https://github.com/harvester/harvester/issues/7258","target_repo_name":"harvester/harvester","target_issue_id":2782073730,"target_issue_number":7353,"target_issue_url":"https://github.com/harvester/harvester/issues/7353","reference_anchor_document_id":"gh_comment_2585377698","reference_answer_author":"brandboat","reference_answer_author_association":"MEMBER","quality_score":92.79,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2,"anchor_target_overlap":0.3091,"target_answer_overlap":0.0357},"issue_created_at":"2024-12-26T03:09:32+08:00","valid_comment_count":19,"fragments":[{"document_id":"gh_issue_2759216263","fragment_type":"issue_description","sequence":0,"text":"[DOC] Provide guideline to setup an 'air-gapped' repository and how to enable Harvester UI extension in Rancher v2.10.x\n**Is your doc request related to a problem? Please describe or add the related issue ID.**\nStarting from Rancher v2.10.0, we introduce the Harvester UI extension on Rancher.\n\n* Currently we provide the automatic install UI extension under regular network environment. \n\n* It extremely important we need to consider the use case of `air-gapped` environment since still many user and customer required this feature.\n\n* Thus we need to provide the guideline steps for how to properly setup an `air-gapped` local repository for user in their own environment. \n\n**Describe the solution you'd like**\n \n\nThe document could include these content\n\n1. Steps for to setup an air-ggaped repository \n2. Steps to add airgapped UI extension repository in Rancher\n3. Whether it support automatic install or always require to manually install the extension\n4. Anything we need to consider when upgrade Rancher from v2.10.x before. \n\n**Additional context**\n \n* For the air-ggaped repository setup, we can refer and extend from the test issue.\n - URL","author_login":"TachunLin","author_association":"NONE","created_at":"2024-12-26T03:09:32+08:00","repo_name":"harvester/harvester","issue_id":2759216263,"issue_number":7258,"issue_url":"https://github.com/harvester/harvester/issues/7258","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2567332989","fragment_type":"issue_comment","sequence":1,"text":"We should also include the following user scenarios for air-gapped UI extension repository.\n\n1. Should we support the automatic install UI extension from the air-gapped repository ? (Since the current steps based on manually install from Extension page)\n \n2. When user need to update the UI extension version, what would be the expected manner to follow (Support automatic or manual install or both)","author_login":"TachunLin","author_association":"NONE","created_at":"2025-01-02T06:31:59+08:00","repo_name":"harvester/harvester","issue_id":2759216263,"issue_number":7258,"issue_url":"https://github.com/harvester/harvester/issues/7258","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2585377698","fragment_type":"issue_comment","sequence":2,"text":"I have a PR up to add some documentation.\n\nI found 2 possible improvements (one is a bug):\n- I created this ticket to automatically build the Extension Catalog Image. It could be useful when users want to use GitHub as registry URL \n- The installation button doesn't work properly in air-gapped environments URL The Rancher UI checks if the community repository is imported as Harvester Catalog, but for air gapped the Catalog's link will be different.\nAs result of this, a Missing Repo error is displayed. However, the extension can still be installed manually. \n@TachunLin do you know if there is a way to identify if an environment is air-gapped? We whould add this check to the install button","author_login":"torchiaf","author_association":"NONE","created_at":"2025-01-11T19:03:22+08:00","repo_name":"harvester/harvester","issue_id":2759216263,"issue_number":7258,"issue_url":"https://github.com/harvester/harvester/issues/7258","linked_issue_ids":[2782073730],"is_known_query_context":false},{"document_id":"gh_comment_2631481001","fragment_type":"issue_comment","sequence":3,"text":"I'm concerned at the amount of extra steps someone has to go through just to host the ui extension for harvester in an airgap. \n\nIt was something that was built-in and worked in an airgap now has unannounced dependencies like hosting the chart internally and creating a manual Extension resource to point at it. \n\nWhatever solution is chosen, can we possibly tie it into existing airgap-friendly flags that Rancher's helmchart already makes use of? `useSystemBundledCharts` is a good example. Adding extra steps to host a chart breaks a lot of airgapping processes and will require not-insignificant engineering hours that the customer has to spend to fix it.\n\nI think its best to follow this:\n1. Harvester cluster\n2. Rancher\n3. Private registry hosting rancher images\n4. UI extension charts hosted internally by Rancher just like other charts","author_login":"bcdurden","author_association":"NONE","created_at":"2025-02-03T16:26:23+08:00","repo_name":"harvester/harvester","issue_id":2759216263,"issue_number":7258,"issue_url":"https://github.com/harvester/harvester/issues/7258","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2631864596","fragment_type":"issue_comment","sequence":4,"text":"+3 to @bcdurden comments about implementing an automated fix using existing components of the helm chart like `useSystemBundledCharts=true`","author_login":"zackbradys","author_association":"NONE","created_at":"2025-02-03T19:17:26+08:00","repo_name":"harvester/harvester","issue_id":2759216263,"issue_number":7258,"issue_url":"https://github.com/harvester/harvester/issues/7258","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2734451477","fragment_type":"issue_comment","sequence":5,"text":"@irishgordo Assigning this to you as URL is already assigned to you. This can be tested while you do the setup for Airgap.\nPS: The same setup can be used for Airgap upgrade tests during release testing later.","author_login":"khushboo-rancher","author_association":"CONTRIBUTOR","created_at":"2025-03-18T19:12:55+08:00","repo_name":"harvester/harvester","issue_id":2759216263,"issue_number":7258,"issue_url":"https://github.com/harvester/harvester/issues/7258","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2782073730","fragment_type":"issue_description","sequence":0,"text":"[FEATURE] Add build catalog job to harvester-ui-extension CI\n**Is your feature request related to a problem? Please describe.**\n \n\nIt would be useful for users how want to use air-gapped environment to build the registry in the CI URL when we publish new verisons.\nThis way the users could just download the docker image and push the images to their own registry","author_login":"torchiaf","author_association":"NONE","created_at":"2025-01-11T18:45:49+08:00","repo_name":"harvester/harvester","issue_id":2782073730,"issue_number":7353,"issue_url":"https://github.com/harvester/harvester/issues/7353","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2647479339","fragment_type":"issue_comment","sequence":1,"text":"Not necessary to include this CI flow in v1.5.0. Update milestone to v1.6.0.","author_login":"a110605","author_association":"NONE","created_at":"2025-02-10T09:54:20+08:00","repo_name":"harvester/harvester","issue_id":2782073730,"issue_number":7353,"issue_url":"https://github.com/harvester/harvester/issues/7353","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2652871464","fragment_type":"issue_comment","sequence":2,"text":"Need re-prioritize to include this CI flow in v1.5.0 or not.","author_login":"a110605","author_association":"NONE","created_at":"2025-02-12T07:31:26+08:00","repo_name":"harvester/harvester","issue_id":2782073730,"issue_number":7353,"issue_url":"https://github.com/harvester/harvester/issues/7353","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2652875730","fragment_type":"issue_comment","sequence":3,"text":"@a110605 We need every item that can ease the extension deployment for our users.\nWhat's the drawback if this issue is not implemented?","author_login":"bk201","author_association":"MEMBER","created_at":"2025-02-12T07:33:55+08:00","repo_name":"harvester/harvester","issue_id":2782073730,"issue_number":7353,"issue_url":"https://github.com/harvester/harvester/issues/7353","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2723872844","fragment_type":"issue_comment","sequence":4,"text":"Done. \n\n- Tag: rancher/harvester-ui-catalog:1.5.0-rc1\n- Action: URL \n\nDemo\n\nImage\n\nImage\n\ncc @a110605 @bk201","author_login":"Yu-Jack","author_association":"CONTRIBUTOR","created_at":"2025-03-14T07:37:51+08:00","repo_name":"harvester/harvester","issue_id":2782073730,"issue_number":7353,"issue_url":"https://github.com/harvester/harvester/issues/7353","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2739018628","fragment_type":"issue_comment","sequence":5,"text":"Hi @Yu-Jack, I followed the test steps in URL but after clicking the install button in Extensions, an error showed up. Am I do something wrong?\n\nImage","author_login":"brandboat","author_association":"MEMBER","created_at":"2025-03-20T03:09:58+08:00","repo_name":"harvester/harvester","issue_id":2782073730,"issue_number":7353,"issue_url":"https://github.com/harvester/harvester/issues/7353","linked_issue_ids":[2782073730],"is_known_query_context":false},{"document_id":"gh_comment_2739021694","fragment_type":"issue_comment","sequence":6,"text":"@brandboat This one URL can help you. I think v-cluster might not have this kind of questions. Let me do some experiment with v-cluster.","author_login":"Yu-Jack","author_association":"CONTRIBUTOR","created_at":"2025-03-20T03:13:01+08:00","repo_name":"harvester/harvester","issue_id":2782073730,"issue_number":7353,"issue_url":"https://github.com/harvester/harvester/issues/7353","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2739061368","fragment_type":"issue_comment","sequence":7,"text":"Thank you @Yu-Jack, the doc really helps!\n \n---\nThe harvester UIPlugin object in my environment\n\nyaml\napiVersion: catalog.cattle.io/v1\nkind: UIPlugin\nmetadata:\n...\n name: harvester\n namespace: cattle-ui-plugin-system\n...\nspec:\n plugin:\n endpoint: URL \n...\n\nBut I can't find the `ui-extension-harvester-ui-extension-svc` endpoint in `cattle-ui-plugin-system` namespace, only `harvester-ui-catalog-svc` shows up.\n\nbash-4.4# k get endpoints -n cattle-ui-plugin-system\nNAME ENDPOINTS AGE\nharvester-ui-catalog-svc 10.42.0.35:8080 61m\n\nAfter changing the endpoint to ` URL I can access the harvester ui.","author_login":"brandboat","author_association":"MEMBER","created_at":"2025-03-20T03:56:09+08:00","repo_name":"harvester/harvester","issue_id":2782073730,"issue_number":7353,"issue_url":"https://github.com/harvester/harvester/issues/7353","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2739170632","fragment_type":"issue_comment","sequence":8,"text":"Now I'm using vagrant to setup rancher, and follow the steps in URL to install harvester-ui-extenstion, but I'm still encountering the same installation failed issue, though I can use the workaround mentioned in URL to mitigate the installation failed issue. I'm wondering is this expected? Or should we consider it as a bug? c.c @khushboo-rancher, @noahgildersleeve.\n\nNote: the endpoint in harvester UIPlugin seems wrong, and should be ` URL instead.","author_login":"brandboat","author_association":"MEMBER","created_at":"2025-03-20T05:11:57+08:00","repo_name":"harvester/harvester","issue_id":2782073730,"issue_number":7353,"issue_url":"https://github.com/harvester/harvester/issues/7353","linked_issue_ids":[2782073730],"is_known_query_context":false},{"document_id":"gh_comment_2739211660","fragment_type":"issue_comment","sequence":9,"text":"@brandboat The endpoint is not quite wrong. It's from the image name. If your image name is `harvester-ui-catalog`, it'll be `harvester-ui-catalog-svc`. If image name is `ui-plugin-catalog`, it'll be `ui-plugin-catalog-svc`. I'll revise the endpoint part and use template to describe that.\n\nFor the installation failed, currently I can't use v-cluster to install it. I'll keep trying that.","author_login":"Yu-Jack","author_association":"CONTRIBUTOR","created_at":"2025-03-20T05:31:05+08:00","repo_name":"harvester/harvester","issue_id":2782073730,"issue_number":7353,"issue_url":"https://github.com/harvester/harvester/issues/7353","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2739311361","fragment_type":"issue_comment","sequence":10,"text":"After discussion with @brandboat.\n \nThis one has been verified by @brandboat. Please paste the endpoint of UIPlugin here. Thanks!\n\nThe endpoint in the Harvester documentation is correct because customers uses `rancher/ui-plugin-catalog` to install Harvester UI Extension in air-gapped environment.\n\nHowever, `rancher/harvester-ui-catalog` should be only used by QAs. So, you shouldn't see `rancher/harvester-ui-plugin` in Harvester document.\n\nSo, if you try to verify this issue with Harvester document, you need to treat all `ui-plugin-catalog` as `harvester-ui-plugin`. Otherwise, it might be weird for you.","author_login":"Yu-Jack","author_association":"CONTRIBUTOR","created_at":"2025-03-20T06:09:54+08:00","repo_name":"harvester/harvester","issue_id":2782073730,"issue_number":7353,"issue_url":"https://github.com/harvester/harvester/issues/7353","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2739344030","fragment_type":"issue_comment","sequence":11,"text":"Thank for the explanation @Yu-Jack.\n\nTest OK, will close the issue.\n\n### Test environment\n- ipxe environment\n- harvester v1.5-head ( URL single node\n- rancher: v2.11.0-rc5, below is my rancher config in settings.yml\n \n\n rancher_config:\n enabled: false\n version: v2.11-head\n \n # IP should be out of harvester_network_config.dhcp_server.range and does not\n # conflict with other static IPs (e.g. Harvester).\n ip: 192.168.100.141\n password: rancher\n \n # Refer resource requirements to\n # URL \n cpu: 2\n memory: 4096\n \n\n### Test steps\n- Go to extension, and click Manage Extension Catalogs on right top corner.\n- Import this image rancher/harvester-ui-catalog:1.5.0-rc1\n- Wait until harvester ui extension pop up in available tab \n- Click install in harvester ui extenstion\n- Search `UIPlugins`, and switch to `All Namespaces`, click harvester UIPlugin.\n- Click `Edit YAML`, modify the endpoint to ` URL \nImage\n- Verify the error message is gone in harvester ui extension\nImage\n- Import harvester to rancher, and verify the harvester dashboard shows up.\nImage","author_login":"brandboat","author_association":"MEMBER","created_at":"2025-03-20T06:29:58+08:00","repo_name":"harvester/harvester","issue_id":2782073730,"issue_number":7353,"issue_url":"https://github.com/harvester/harvester/issues/7353","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2739392148","fragment_type":"issue_comment","sequence":12,"text":"Sorry. I thought endpoint is correct by using `rancher/harvester-ui-catalog`. I was wrong and misunderstood before.\n\nDue to this reason, I'll reopen issue. It seems that it would be better to use `rancher/ui-extension-harvester-ui-extension` as image repo name. Otherwise, QA needs to modify endpoint **each time**. I don't think it's a good idea. \n\nThanks @a110605 @brandboat","author_login":"Yu-Jack","author_association":"CONTRIBUTOR","created_at":"2025-03-20T06:57:52+08:00","repo_name":"harvester/harvester","issue_id":2782073730,"issue_number":7353,"issue_url":"https://github.com/harvester/harvester/issues/7353","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2781866523","fragment_type":"issue_comment","sequence":13,"text":"Please use this tag `rancher/ui-extension-harvester-ui-extension:1.5.0-rc3`. \n\nThe result is:\n\nbash-4.4# k get svc -A | grep extension\ncattle-system api-extension ClusterIP 10.43.103.53 5555/TCP,6666/TCP 64s\ncattle-system imperative-api-extension ClusterIP 10.43.222.83 6666/TCP 7m55s\ncattle-ui-plugin-system ui-extension-harvester-ui-extension-svc ClusterIP 10.43.228.45 8080/TCP 6m19s\nbash-4.4# k get uiplugins harvester -n cattle-ui-plugin-system -o yaml | grep endpoint\n endpoint: URL \nbash-4.4#","author_login":"Yu-Jack","author_association":"CONTRIBUTOR","created_at":"2025-04-07T02:24:12+08:00","repo_name":"harvester/harvester","issue_id":2782073730,"issue_number":7353,"issue_url":"https://github.com/harvester/harvester/issues/7353","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2782405141","fragment_type":"issue_comment","sequence":14,"text":"Test successful!\n\n### Test environment\n- ipxe environment\n- harvester v1.5.0-rc3, single node\n- rancher: v2.11-head, below is my rancher config in settings.yml\n \n\n rancher_config:\n enabled: true\n \n version: v2.11-head\n k3s_channel: v1.30\n repo: URL \n \n # Reserved IP for Rancher. Do not conflict with DHCP range and other reserved IPs.\n ip: 192.168.100.141\n hostname: rancher.192.168.100.141.sslip.io\n password: rancher\n cpu: 2\n memory: 4096\n \n\n### Test steps\n- Go to extension, click `Manage Extension Catalogs` on right top corner.\n- Import image `rancher/ui-extension-harvester-ui-extension:1.5.0-rc3`\n- Wait until harvester ui extension pop up in the `available` tab \n- Click `install` in harvester ui extension\n- Import harvester to rancher, and verify the harvester dashboard shows up.\n\nImage\nImage","author_login":"brandboat","author_association":"MEMBER","created_at":"2025-04-07T08:15:19+08:00","repo_name":"harvester/harvester","issue_id":2782073730,"issue_number":7353,"issue_url":"https://github.com/harvester/harvester/issues/7353","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0283","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"When attempting to set a wallpaper i recieve a segmentation fault. run with sudo the same.","query_context":"[luke@fedora build]$ ./wallengine /home/luke/.local/share/Steam/steamapps/workshop/content/431960/2677437153/\nDetected scene.pkg file at /home/luke/.local/share/Steam/steamapps/workshop/content/431960/2677437153/scene.pkg. Adding to list of searchable paths\nFound wallpaper engine's assets at /home/luke/.local/share/Steam/steamapps/common/wallpaper_engine/assets\nSegmentation fault (core dumped)\n[luke@fedora build]$ \n\nfixed location of program and retested still having the issue.","known_context_document_ids":["gh_issue_1216605480"],"reference_answer":"wp::video::node is the base class for all the different types of nodes the scene can have. right now only the materials are implemented, so if your scene uses models, web-browser or video the content won't be displayed (in fact you should be seeing an error in the log).\n\nAs I haven't implemented the Wallpaper engine texture format yet only PNG/JPG textures are supported. #1 \nRight now this is as far as you can get with any background: URL \nThis is the background I'm loading in that picture: URL \n\nYou'll notice that for every material, there is a png or jpg file with the actual texture.\n\nShaders support is implemented but they aren't loaded yet from the project.json file as I still have to implement the parser for them.","answer_document_id":"gh_comment_475576330","silver_evidence_path":["gh_comment_1120475633","gh_issue_424094176","gh_comment_475576330"],"evidence_issue_ids":[1216605480,424094176],"source_repo_name":"Almamu/linux-wallpaperengine","source_issue_id":1216605480,"source_issue_number":89,"source_issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","target_repo_name":"Almamu/linux-wallpaperengine","target_issue_id":424094176,"target_issue_number":2,"target_issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/2","reference_anchor_document_id":"gh_comment_1120475633","reference_answer_author":"Almamu","reference_answer_author_association":"OWNER","quality_score":94.83,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.4884,"anchor_target_overlap":0.0833,"target_answer_overlap":0.2},"issue_created_at":"2022-04-26T23:49:23+08:00","valid_comment_count":23,"fragments":[{"document_id":"gh_issue_1216605480","fragment_type":"issue_description","sequence":0,"text":"When attempting to set a wallpaper i recieve a segmentation fault. run with sudo the same.\n[luke@fedora build]$ ./wallengine /home/luke/.local/share/Steam/steamapps/workshop/content/431960/2677437153/\nDetected scene.pkg file at /home/luke/.local/share/Steam/steamapps/workshop/content/431960/2677437153/scene.pkg. Adding to list of searchable paths\nFound wallpaper engine's assets at /home/luke/.local/share/Steam/steamapps/common/wallpaper_engine/assets\nSegmentation fault (core dumped)\n[luke@fedora build]$ \n\nfixed location of program and retested still having the issue.","author_login":"L-m-b","author_association":"NONE","created_at":"2022-04-26T23:49:23+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1110355306","fragment_type":"issue_comment","sequence":1,"text":"and sorry for weird build location i forgot to CD back before building when i tried to use a KDE plugin earlier.","author_login":"L-m-b","author_association":"NONE","created_at":"2022-04-26T23:50:26+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1111329840","fragment_type":"issue_comment","sequence":2,"text":"I'll need some extra information. What DE are you using?\nCould you please run it with GDB attached and give a backtrace of where the segfault is?","author_login":"Almamu","author_association":"OWNER","created_at":"2022-04-27T18:14:30+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1111522851","fragment_type":"issue_comment","sequence":3,"text":"I am using gnome on x-11 as my DE, running on fedora. pardon me for asking but how do i run it with GDB and backtrace it?","author_login":"L-m-b","author_association":"NONE","created_at":"2022-04-27T21:57:42+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1114068317","fragment_type":"issue_comment","sequence":4,"text":"You will need to run the software with gdb, just like you'd do with sudo:\n\ngdb ./wallengine /home/luke/.local/share/Steam/steamapps/workshop/content/431960/2677437153/\n\nThat should give you a command prompt, if you write start and press enter the software will run as normal, once it hits the segfault you'll be back to the gdb's command prompt.\nYou can use the command \"bt\" to get some better information of what happened.","author_login":"Almamu","author_association":"OWNER","created_at":"2022-04-30T23:03:09+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1114129143","fragment_type":"issue_comment","sequence":5,"text":"so far i have installed 2 sets of debug packages and it is asking me for more:\n[luke@fedora build]$ gdb ./wallengine /home/luke/.local/share/Steam/steamapps/workshop/content/431960/2677437153/\nGNU gdb (GDB) Fedora 11.2-2.fc35\nCopyright (C) 2022 Free Software Foundation, Inc.\nLicense GPLv3+: GNU GPL version 3 or later < URL \nThis is free software: you are free to change and redistribute it.\nThere is NO WARRANTY, to the extent permitted by law.\nType \"show copying\" and \"show warranty\" for details.\nThis GDB was configured as \"x86_64-redhat-linux-gnu\".\nType \"show configuration\" for configuration details.\nFor bug reporting instructions, please see:\n< URL \nFind the GDB manual and other documentation resources online at:\n < URL \n\nFor help, type \"help\".\nType \"apropos word\" to search for commands related to \"word\"...\nReading symbols from ./wallengine...\n\nThis GDB supports auto-downloading debuginfo from the following URLs:\n URL \nEnable debuginfod for this session? (y or [n]) \nDebuginfod has been disabled.\nTo make this setting permanent, add 'set debuginfod enabled off' to .gdbinit.\n(No debugging symbols found in ./wallengine)\n\"/home/luke/.local/share/Steam/steamapps/workshop/content/431960/2677437153/\" is not a core dump: file format not recognized\n(gdb) start\nTemporary breakpoint 1 at 0x4c4276\nStarting program: /home/luke/wallengine/build/wallengine \n[Thread debugging using libthread_db enabled]\nUsing host libthread_db library \"/lib64/libthread_db.so.1\".\nMissing separate debuginfo for /lib64/libOpenCL.so.1\nTry: dnf --enablerepo='*debug*' install /usr/lib/debug/.build-id/8b/1a5b9feb2f73098a0b3cc1fe1b7da5b32c1015.debug\nMissing separate debuginfo for /lib64/libwbclient.so.0\nTry: dnf --enablerepo='*debug*' install /usr/lib/debug/.build-id/7e/4d98ae1b739d161227923719ff0c12e2a4cf2b.debug\n\nTemporary breakpoint 1, 0x00000000004c4276 in main ()\nMissing separate debuginfos, use: dnf debuginfo-install LibRaw-0.20.2-3.fc35.x86_64 SDL2-2.0.20-1.fc35.x86_64 SDL_mixer-1.2.12-23.fc35.x86_64 bzip2-libs-1.0.8-9.fc35.x86_64 cairo-1.17.4-4.fc35.x86_64 cyrus-sasl-lib-2.1.27-14.fc35.x86_64 fftw-libs-double-3.3.8-11.fc35.x86_64 fontconfig-2.13.94-5.fc35.x86_64 freeglut-3.2.2-1.fc35.x86_64 freeimage-3.19.0-0.7.svn1889.fc35.x86_64 freetype-2.11.0-3.fc35.x86_64 fribidi-1.0.11-3.fc35.x86_64 gdk-pixbuf2-2.42.6-2.fc35.x86_64 glfw-3.3.4-3.fc35.x86_64 glib2-2.70.5-1.fc35.x86_64 glibc-2.34-30.fc35.x86_64 gmp-6.2.0-7.fc35.x86_64 gnutls-3.7.2-3.fc35.x86_64 gsm-1.0.19-6.fc35.x86_64 harfbuzz-2.9.1-1.fc35.x86_64 ilbc-1.1.1-21.fc35.x86_64 imath-3.1.5-1.fc35.x86_64 jasper-libs-2.0.33-1.fc35.x86_64 jbigkit-libs-2.1-22.fc35.x86_64 jxrlib-1.1-17.fc35.x86_64 keyutils-libs-1.6.1-3.fc35.x86_64 krb5-libs-1.19.2-6.fc35.x86_64 lame-libs-3.100-11.fc35.x86_64 lcms2-2.12-2.fc35.x86_64 libGLEW-2.1.0-10.fc35.x86_64 libICE-1.0.10-7.fc35.x86_64 libSM-1.2.3-9.fc35.x86_64 libX11-1.7.3.1-1.fc35.x86_64 libXext-1.3.4-7.fc35.x86_64 libXrandr-1.5.2-7.fc35.x86_64 libXrender-0.9.10-15.fc35.x86_64 libXxf86vm-1.1.4-17.fc35.x86_64 libaom-3.2.0-2.fc35.x86_64 libbluray-1.3.1-1.fc35.x86_64 libchromaprint-1.5.0-3.fc35.x86_64 libcom_err-1.46.3-1.fc35.x86_64 libdav1d-0.9.2-1.fc35.x86_64 libdrm-2.4.110-1.fc35.x86_64 libgcc-11.3.1-2.fc35.x86_64 libgcrypt-1.9.4-1.fc35.x86_64 libglvnd-1.3.4-2.fc35.x86_64 libglvnd-glx-1.3.4-2.fc35.x86_64 libgomp-11.3.1-2.fc35.x86_64 libgpg-error-1.43-1.fc35.x86_64 libicu-69.1-2.fc35.x86_64 libidn2-2.3.2-3.fc35.x86_64 libjpeg-turbo-2.1.0-3.fc35.x86_64 libldb-2.4.2-1.fc35.x86_64 libmodplug-0.8.9.0-13.fc35.x86_64 libmount-2.37.4-1.fc35.x86_64 libogg-1.3.5-2.fc35.x86_64 libopenmpt-0.5.15-1.fc35.x86_64 libpng-1.6.37-11.fc35.x86_64 librsvg2-2.52.8-1.fc35.x86_64 libsmbclient-4.15.6-0.fc35.x86_64 libssh-0.9.6-1.fc35.x86_64 libstdc++-11.3.1-2.fc35.x86_64 libtalloc-2.3.3-2.fc35.x86_64 libtdb-1.4.4-3.fc35.x86_64 libthai-0.1.28-7.fc35.x86_64 libtheora-1.1.1-30.fc35.x86_64 libudfread-1.1.2-2.fc35.x86_64 libunwind-1.5.0-1.fc35.x86_64 libuuid-2.37.4-1.fc35.x86_64 libva-2.13.0-3.fc35.x86_64 libvdpau-1.5-1.fc35.x86_64 libvmaf-2.1.1-3.fc35.x86_64 libvorbis-1.3.7-4.fc35.x86_64 libvpx-1.10.0-2.fc35.x86_64 libxcb-1.13.1-8.fc35.x86_64 libzstd-1.5.2-1.fc35.x86_64 lz4-libs-1.9.3-3.fc35.x86_64 mesa-libGLU-9.0.1-5.fc35.x86_64 mpg123-libs-1.26.5-2.fc35.x86_64 nettle-3.7.3-2.fc35.x86_64 openexr-libs-3.1.5-1.fc35.x86_64 openjpeg2-2.4.0-5.fc35.x86_64 openpgm-5.2.122-27.fc35.x86_64 openssl-libs-1.1.1n-1.fc35.x86_64 pango-1.50.4-1.fc35.x86_64 pixman-0.40.0-4.fc35.x86_64 rav1e-libs-0.5.0-1.fc35.x86_64 sdl12-compat-0.0.1~git.20211125.4e4527a-1.fc35.x86_64 speex-1.2.0-9.fc35.x86_64 srt-libs-1.4.4-1.fc35.x86_64 svt-av1-libs-0.8.7-2.fc35.x86_64 twolame-libs-0.3.13-18.fc35.x86_64 vapoursynth-libs-51-4.fc35.x86_64 xz-libs-5.2.5-9.fc35.x86_64 zlib-1.2.11-30.fc35.x86_64 zvbi-0.2.35-15.fc35.x86_64\n(gdb)","author_login":"L-m-b","author_association":"NONE","created_at":"2022-05-01T04:26:07+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1114129680","fragment_type":"issue_comment","sequence":6,"text":"ok after installing 3rd and 4th set of packages this is the output after start\n\n(gdb) start\nTemporary breakpoint 1 at 0x4c4276\nStarting program: /home/luke/wallengine/build/wallengine \n[Thread debugging using libthread_db enabled]\nUsing host libthread_db library \"/lib64/libthread_db.so.1\".\nDownloading separate debug info for /lib64/libOpenCL.so.1...\nMissing separate debuginfo for /lib64/libOpenCL.so.1\nTry: dnf --enablerepo='*debug*' install /usr/lib/debug/.build-id/8b/1a5b9feb2f73098a0b3cc1fe1b7da5b32c1015.debug\n\nTemporary breakpoint 1, 0x00000000004c4276 in main ()\n(gdb)","author_login":"L-m-b","author_association":"NONE","created_at":"2022-05-01T04:30:30+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1120328225","fragment_type":"issue_comment","sequence":7,"text":"You need to run the \"bt\" command once you get back to the (gdb) prompt so it can show you where it actually crashed. It might be deep within opengl or something, but the crash has to originate from somewhere in my code.","author_login":"Almamu","author_association":"OWNER","created_at":"2022-05-08T01:19:35+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1120475633","fragment_type":"issue_comment","sequence":8,"text":"Hello! I am facing the same issue as the other person is. Here's the output of GDB\n\n(gdb) run /hdd0/SteamLibrary/steamapps/workshop/content/431960/2638696675/\nStarting program: /home/kris/git/linux-wallpaperengine/build/wallengine /hdd0/SteamLibrary/steamapps/workshop/content/431960/2638696675/\n[Thread debugging using libthread_db enabled]\nUsing host libthread_db library \"/usr/lib/libthread_db.so.1\".\nDetected scene.pkg file at /hdd0/SteamLibrary/steamapps/workshop/content/431960/2638696675/scene.pkg. Adding to list of searchable paths\nFound assets folder alongside the binary: /home/kris/git/linux-wallpaperengine/build/assets\n[New Thread 0x7fffb827f640 (LWP 293361)]\n\nThread 1 \"wallengine\" received signal SIGSEGV, Segmentation fault.\n0x000055555562d3b5 in WallpaperEngine::Audio::CAudioStream::loadCustomContent(char const*) ()\n(gdb) bt\n#0 0x000055555562d3b5 in WallpaperEngine::Audio::CAudioStream::loadCustomContent(char const*) ()\n#1 0x000055555562d1fd in WallpaperEngine::Audio::CAudioStream::CAudioStream(void*, int) ()\n#2 0x000055555565d7c3 in WallpaperEngine::Render::Objects::CSound::load() ()\n#3 0x000055555565d673 in WallpaperEngine::Render::Objects::CSound::CSound(WallpaperEngine::Render::CScene*, WallpaperEngine::Core::Objects::CSound*) ()\n#4 0x0000555555654693 in WallpaperEngine::Render::CScene::CScene(WallpaperEngine::Core::CScene*, WallpaperEngine::Assets::CContainer*, WallpaperEngine::Render::CContext*) ()\n#5 0x000055555565322b in WallpaperEngine::Render::CWallpaper::fromWallpaper(WallpaperEngine::Core::CWallpaper*, WallpaperEngine::Assets::CContainer*, WallpaperEngine::Render::CContext*) ()\n#6 0x000055555561c3b6 in main ()","author_login":"t1stm","author_association":"NONE","created_at":"2022-05-08T19:38:49+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[424094176],"is_known_query_context":false},{"document_id":"gh_comment_1120491913","fragment_type":"issue_comment","sequence":9,"text":"I am at Tafe this week, so I will try running the BT command in GDB when I am back Friday night or Saturday","author_login":"L-m-b","author_association":"NONE","created_at":"2022-05-08T21:43:57+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1120505724","fragment_type":"issue_comment","sequence":10,"text":"@t1stm your stack traces are interesting, both seem to happen on ffmpeg-related code (either audio or video) but I can load both backgrounds properly. What OS and version are you using? What ffmpeg version do you have installed?\n\n@mihawk90 that's weird, you should at least be able to get the stacktrace up to the last call that happens in the wallpaper engine binary. I'm sorry but I'm no expert on GDB :/ Maybe you can try it in an IDE like VScode or CLion that have an interactive debugger?\n\n@L-m-b no problem, ping me when you have it and i'll look into it ;)","author_login":"Almamu","author_association":"OWNER","created_at":"2022-05-08T23:18:59+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1120510733","fragment_type":"issue_comment","sequence":11,"text":"@Almamu I use Arch Linux, and use Openbox as my window manager with the picom compositor. I am using the latest FFmpeg version on the AUR - ffmpeg-full, but the version from the official repo gives me the exact same error after removing the build directory and building again. The FFmpeg version is 5.0.1 from the AUR and 5.0.0 from the repo. FFmpeg works just fine encoding and decoding the videos. I tested the decoding using a pipe to MPV.","author_login":"t1stm","author_association":"NONE","created_at":"2022-05-08T23:49:10+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1120515760","fragment_type":"issue_comment","sequence":12,"text":"@Almamu I decided to start to look for problems, and found files in the /usr/local directory which came from an old FFmpeg build I compiled a year ago and removed some time after that. For some reason CMake was detecting these files and not the ones in the /usr directory, so if anyone here has compiled FFmpeg from source before, be sure to check your /usr/local directory for any old files. Anyways with that being fixed the wallpapers start normally, but my tint2 dock has an issue where the icons are flickering.","author_login":"t1stm","author_association":"NONE","created_at":"2022-05-09T00:14:42+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1120956513","fragment_type":"issue_comment","sequence":13,"text":"Me neither :/\nThis is as far as I get:\n\nz% gdb wallengine ~/.local/share/Steam/steamapps/workshop/content/431960/2677437153\nGNU gdb (GDB) Fedora 11.2-3.fc36\nCopyright (C) 2022 Free Software Foundation, Inc.\nLicense GPLv3+: GNU GPL version 3 or later < URL \nThis is free software: you are free to change and redistribute it.\nThere is NO WARRANTY, to the extent permitted by law.\nType \"show copying\" and \"show warranty\" for details.\nThis GDB was configured as \"x86_64-redhat-linux-gnu\".\nType \"show configuration\" for configuration details.\nFor bug reporting instructions, please see:\n< URL \nFind the GDB manual and other documentation resources online at:\n < URL \n\nFor help, type \"help\".\nType \"apropos word\" to search for commands related to \"word\"...\nReading symbols from wallengine...\nReading symbols from /usr/lib/debug/usr/bin/wallengine-0.0.1.28f0868-1.fc36.x86_64.debug...\n\"/home/tarulia/.local/share/Steam/steamapps/workshop/content/431960/2677437153\" is not a core dump: file format not recognized\n(gdb) start\nTemporary breakpoint 1 at 0x22620: file /usr/src/debug/linux-wallpaperengine-0.0.1.28f0868-1.fc36.x86_64/main.cpp, line 95.\nStarting program: /usr/bin/wallengine \n\nThis GDB supports auto-downloading debuginfo from the following URLs:\n URL \nEnable debuginfod for this session? (y or [n]) y\nDebuginfod has been enabled.\nTo make this setting permanent, add 'set debuginfod enabled on' to .gdbinit.\nDownloading separate debug info for /home/tarulia/system-supplied DSO at 0x7ffff7fc4000...\n[Thread debugging using libthread_db enabled]\nUsing host libthread_db library \"/lib64/libthread_db.so.1\".\nDownloading separate debug info for /lib64/liblzma.so.5...\nDownloading separate debug info for /lib64/libcrypto.so.3...\nDownloading separate debug info for /home/tarulia/.cache/debuginfod_client/00404b8982ab681e4d574a5fa286c28f3844aeb6/debuginfo...\nDownloading separate debug info for /lib64/libssl.so.3...\n\nTemporary breakpoint 1, main (argc=1, argv=0x7fffffffdce8) at /usr/src/debug/linux-wallpaperengine-0.0.1.28f0868-1.fc36.x86_64/main.cpp:95\n95 {\n(gdb) bt\n#0 main (argc=1, argv=0x7fffffffdce8) at /usr/src/debug/linux-wallpaperengine-0.0.1.28f0868-1.fc36.x86_64/main.cpp:95\n(gdb)\n\n \n\nI'm on F36 KDE spin.","author_login":"mihawk90","author_association":"CONTRIBUTOR","created_at":"2022-05-09T11:04:28+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1120979332","fragment_type":"issue_comment","sequence":14,"text":"Your backtrace is from a breakpoint placed on the start of the app, not from the actual crash. You should be able to continue execution until the app actually crashes (if I recall correctly the command is \"continue\").","author_login":"Almamu","author_association":"OWNER","created_at":"2022-05-09T11:29:23+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1124117892","fragment_type":"issue_comment","sequence":15,"text":"That stacktrace isn't really that helpful... For some reason it's happening in one of the std::string methods, but there should be some calling code somewhere :/ Maybe \nbt full\n will give some more precise information? @mihawk90","author_login":"Almamu","author_association":"OWNER","created_at":"2022-05-11T18:08:10+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1124856903","fragment_type":"issue_comment","sequence":16,"text":"@mihawk90 that's a really useful stacktrace. I'll look into it today and fix it, seems a simple enough thing.","author_login":"Almamu","author_association":"OWNER","created_at":"2022-05-12T11:05:11+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1126614875","fragment_type":"issue_comment","sequence":17,"text":"so starting off today i redownloaded the package, build the cmake side of things, then ran make.\n[ 41%] Building CXX object CMakeFiles/wallengine.dir/src/WallpaperEngine/Render/CFBO.cpp.o\n/home/luke/linux-wallpaperengine-main/src/WallpaperEngine/Render/CFBO.cpp: In member function ‘virtual const std::vector & WallpaperEngine::Render::CFBO::getFrames() const’:\n/home/luke/linux-wallpaperengine-main/src/WallpaperEngine/Render/CFBO.cpp:98:17: warning: returning reference to temporary [-Wreturn-local-addr]\n 98 | return std::vector ();\n | ^~~~~~~~~~~~~~~~~~~~~~~~\n[ 43%] Building CXX object CMakeFiles/wallengine.dir/src/WallpaperEngine/Render/Objects/Effects/CPass.cpp.o\nthis warning came up during the setup.\nbut aside from that program installed and launched OK, but window was not on the background, but luckily kde allowed me to make it so.\nyou must have fixed it.","author_login":"L-m-b","author_association":"NONE","created_at":"2022-05-14T02:21:17+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1126615129","fragment_type":"issue_comment","sequence":18,"text":"some of the scenes i have result in seg fault still, actually, old reactor is a good one to test that on","author_login":"L-m-b","author_association":"NONE","created_at":"2022-05-14T02:22:51+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1126615733","fragment_type":"issue_comment","sequence":19,"text":"none of the shaders work, all wallpapers that do work end up still because of the lack of shaders, and the ones not entirely reliant on it don't launch, at least out of my library. the non scene backgrounds or scenes that only rely on html and etc, don't play at all.","author_login":"L-m-b","author_association":"NONE","created_at":"2022-05-14T02:26:40+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1302803361","fragment_type":"issue_comment","sequence":20,"text":"Closing this one, please feel free to open one issue by background so I can delve a bit closer into what makes each one fail. Make sure to have the latest version downloaded.","author_login":"Almamu","author_association":"OWNER","created_at":"2022-11-03T23:56:03+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":1216605480,"issue_number":89,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/89","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_424094176","fragment_type":"issue_description","sequence":0,"text":"wp::video::node::render() is empty?\nThe program gives me a solid black output, even after I modified the path to WallPaper Engine Projects folder, I see the `render()` method is empty, what does it (or at least should) do?","author_login":"lhy0403","author_association":"NONE","created_at":"2019-03-22T08:23:40+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":424094176,"issue_number":2,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_475576330","fragment_type":"issue_comment","sequence":1,"text":"wp::video::node is the base class for all the different types of nodes the scene can have. right now only the materials are implemented, so if your scene uses models, web-browser or video the content won't be displayed (in fact you should be seeing an error in the log).\n\nAs I haven't implemented the Wallpaper engine texture format yet only PNG/JPG textures are supported. #1 \nRight now this is as far as you can get with any background: URL \nThis is the background I'm loading in that picture: URL \n\nYou'll notice that for every material, there is a png or jpg file with the actual texture.\n\nShaders support is implemented but they aren't loaded yet from the project.json file as I still have to implement the parser for them.","author_login":"Almamu","author_association":"OWNER","created_at":"2019-03-22T10:56:39+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":424094176,"issue_number":2,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_475826885","fragment_type":"issue_comment","sequence":2,"text":"Okay, finally I tried the scene you provided and it works fine, but it's weird that I didn't receive any error message when I was using the *default scenes of Wallpaper Engine (like that car, and some DNA structure thing)*.","author_login":"lhy0403","author_association":"NONE","created_at":"2019-03-23T01:15:07+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":424094176,"issue_number":2,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_479187838","fragment_type":"issue_comment","sequence":3,"text":"Thank you for the heads up, hopefully I'll be able to start testing with other wallpapers soon so I can fix more bugs and implement things like the the decompress routine for final backgrounds downloaded from the steam store.","author_login":"Almamu","author_association":"OWNER","created_at":"2019-04-02T20:31:34+08:00","repo_name":"Almamu/linux-wallpaperengine","issue_id":424094176,"issue_number":2,"issue_url":"https://github.com/Almamu/linux-wallpaperengine/issues/2","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0286","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Update release GitHub workflows?","query_context":"I think the release workflows could be simplified.\n\n* Use a single machine to publish everything - `macos-latest` can build all Kotlin targets.\n* Just trigger `./gradlew publish` instead of listing all of the publish tasks separately. \n\nIn URL I introduced a BuildService with limited concurrency to try to avoid issues with Maven Central and parallel uploads. If it doesn't work, then the quickest and easiest fix is to add the flags `--no-configuration-cache org.gradle.parallel=false -Dorg.gradle.workers.max=1`.\n\nWe could also look into creating a staging repository before releasing - then Maven Central won't get confused about parallel uploads.","known_context_document_ids":["gh_issue_2337738681"],"reference_answer":"`maven-publish` itself supports cc since 7.6 and the `signing` plugin will in Gradle 8.1. However there is one big open blocker when publishing to maven central URL When configuration cache is enabled the repository url will be evaluated eagerly and not when the publishing tasks are executed. Since we are computing that url based on the output of the task that creates the staging repo the build will fail with this:\n\nConfiguration cache state could not be cached: field `repository` of `org.gradle.api.publish.maven.tasks.PublishToMavenRepository$PublishSpec` bean found in field `value` of `org.gradle.internal.Try$Success` bean found in field `result` of `org.gradle.internal.serialization.Cached$Fixed` bean found in field `spec` of task `:nexus:publishMavenPublicationToMavenCentralRepository` of type `org.gradle.api.publish.maven.tasks.PublishToMavenRepository`: error writing value of type 'org.gradle.api.publish.maven.tasks.PublishToMavenRepository$RepositorySpec$Configured'\n \n The value of this provider is derived from:\n - task ':nexus:createStagingRepository' property 'stagingRepositoryId'\n\nSo current status: \n- Gradle 7.6: publishing to local or non maven central remote repositories works with cc when signing is disabled\n- Gradle 8.1: publishing to local or non maven central remote repositories works with cc with signing enabled\n- TBD: publishing to maven central works with cc","answer_document_id":"gh_comment_1367968935","silver_evidence_path":["gh_comment_2152038495","gh_issue_897637877","gh_comment_1367968935"],"evidence_issue_ids":[2337738681,897637877],"source_repo_name":"kotest/kotest","source_issue_id":2337738681,"source_issue_number":4067,"source_issue_url":"https://github.com/kotest/kotest/issues/4067","target_repo_name":"vanniktech/gradle-maven-publish-plugin","target_issue_id":897637877,"target_issue_number":259,"target_issue_url":"https://github.com/vanniktech/gradle-maven-publish-plugin/issues/259","reference_anchor_document_id":"gh_comment_2152038495","reference_answer_author":"gabrielittner","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.2381,"target_answer_overlap":0.2273},"issue_created_at":"2024-06-06T09:00:51+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_2337738681","fragment_type":"issue_description","sequence":0,"text":"Update release GitHub workflows\nI think the release workflows could be simplified.\n\n* Use a single machine to publish everything - `macos-latest` can build all Kotlin targets.\n* Just trigger `./gradlew publish` instead of listing all of the publish tasks separately. \n\nIn URL I introduced a BuildService with limited concurrency to try to avoid issues with Maven Central and parallel uploads. If it doesn't work, then the quickest and easiest fix is to add the flags `--no-configuration-cache org.gradle.parallel=false -Dorg.gradle.workers.max=1`.\n\nWe could also look into creating a staging repository before releasing - then Maven Central won't get confused about parallel uploads.","author_login":"aSemy","author_association":"CONTRIBUTOR","created_at":"2024-06-06T09:00:51+08:00","repo_name":"kotest/kotest","issue_id":2337738681,"issue_number":4067,"issue_url":"https://github.com/kotest/kotest/issues/4067","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2151795500","fragment_type":"issue_comment","sequence":1,"text":"What are the problems with parallel uploads to Maven central? I've heard of it multiple times but don't know the details.","author_login":"Kantis","author_association":"MEMBER","created_at":"2024-06-06T09:12:37+08:00","repo_name":"kotest/kotest","issue_id":2337738681,"issue_number":4067,"issue_url":"https://github.com/kotest/kotest/issues/4067","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2151915811","fragment_type":"issue_comment","sequence":2,"text":"Should we also consider using URL I think it would automate the (otherwise) manual steps in Nexus as well?","author_login":"Kantis","author_association":"MEMBER","created_at":"2024-06-06T10:14:50+08:00","repo_name":"kotest/kotest","issue_id":2337738681,"issue_number":4067,"issue_url":"https://github.com/kotest/kotest/issues/4067","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2152038495","fragment_type":"issue_comment","sequence":3,"text":"When publishing, Maven Central creates a private, temporary, staging repository to collect the files. It does this automatically when it receives the first artifact. However, if there are multiple artifacts being published from multiple machines, it may create multiple staging repositories. The result is the files are split across multiple staging repos, so no staging repo is valid.\n\n URL \n\nThis can be avoided by not publishing in parallel, or manually creating the staging repo first (maybe there's an API to create a staging repo though?).\n\nPossibly the new method of publishing to Maven Central is better? URL \n \n\nIt's not config-cache compatible :(\n\n URL","author_login":"aSemy","author_association":"CONTRIBUTOR","created_at":"2024-06-06T11:04:18+08:00","repo_name":"kotest/kotest","issue_id":2337738681,"issue_number":4067,"issue_url":"https://github.com/kotest/kotest/issues/4067","linked_issue_ids":[897637877],"is_known_query_context":false},{"document_id":"gh_comment_2155992595","fragment_type":"issue_comment","sequence":4,"text":"It looks like the release is broken because of parallel uploads.\n\n URL \n\n[...]\n\nBUILD FAILED in 4m 24s\n281 actionable tasks: 251 executed, 30 from cache\nConfiguration cache entry discarded with 6 problems.\nError: Process completed with exit code 1.\n\n[...]\n\nWith the provided path, there will be 1 file uploaded\nArtifact name is valid!\nRoot directory input is valid!\nError: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run\n\nI'm working on updating the release config today.","author_login":"aSemy","author_association":"CONTRIBUTOR","created_at":"2024-06-08T11:10:37+08:00","repo_name":"kotest/kotest","issue_id":2337738681,"issue_number":4067,"issue_url":"https://github.com/kotest/kotest/issues/4067","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2156054360","fragment_type":"issue_comment","sequence":5,"text":"If #4076 doesn't work, then we can try these GitHub actions to manually create/close staging repositories.\n\n URL","author_login":"aSemy","author_association":"CONTRIBUTOR","created_at":"2024-06-08T14:18:48+08:00","repo_name":"kotest/kotest","issue_id":2337738681,"issue_number":4067,"issue_url":"https://github.com/kotest/kotest/issues/4067","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_897637877","fragment_type":"issue_description","sequence":0,"text":"Configuration cache problems\nLooks like there are some issues with using this plugin when the configuration cache is enabled. Not sure if any of this is internal to Gradle or part of the plugin, but figured I'd record it here.\n\nHere's a build of mine that failed because of it.","author_login":"eygraber","author_association":"CONTRIBUTOR","created_at":"2021-05-21T03:16:27+08:00","repo_name":"vanniktech/gradle-maven-publish-plugin","issue_id":897637877,"issue_number":259,"issue_url":"https://github.com/vanniktech/gradle-maven-publish-plugin/issues/259","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_845706799","fragment_type":"issue_comment","sequence":1,"text":"I'll add support for it once the underlying Maven Publish and Signing plugins support configuration caching on the Gradle side URL","author_login":"gabrielittner","author_association":"COLLABORATOR","created_at":"2021-05-21T06:55:18+08:00","repo_name":"vanniktech/gradle-maven-publish-plugin","issue_id":897637877,"issue_number":259,"issue_url":"https://github.com/vanniktech/gradle-maven-publish-plugin/issues/259","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1367968935","fragment_type":"issue_comment","sequence":2,"text":"`maven-publish` itself supports cc since 7.6 and the `signing` plugin will in Gradle 8.1. However there is one big open blocker when publishing to maven central URL When configuration cache is enabled the repository url will be evaluated eagerly and not when the publishing tasks are executed. Since we are computing that url based on the output of the task that creates the staging repo the build will fail with this:\n\nConfiguration cache state could not be cached: field `repository` of `org.gradle.api.publish.maven.tasks.PublishToMavenRepository$PublishSpec` bean found in field `value` of `org.gradle.internal.Try$Success` bean found in field `result` of `org.gradle.internal.serialization.Cached$Fixed` bean found in field `spec` of task `:nexus:publishMavenPublicationToMavenCentralRepository` of type `org.gradle.api.publish.maven.tasks.PublishToMavenRepository`: error writing value of type 'org.gradle.api.publish.maven.tasks.PublishToMavenRepository$RepositorySpec$Configured'\n \n The value of this provider is derived from:\n - task ':nexus:createStagingRepository' property 'stagingRepositoryId'\n\nSo current status: \n- Gradle 7.6: publishing to local or non maven central remote repositories works with cc when signing is disabled\n- Gradle 8.1: publishing to local or non maven central remote repositories works with cc with signing enabled\n- TBD: publishing to maven central works with cc","author_login":"gabrielittner","author_association":"COLLABORATOR","created_at":"2022-12-30T15:19:56+08:00","repo_name":"vanniktech/gradle-maven-publish-plugin","issue_id":897637877,"issue_number":259,"issue_url":"https://github.com/vanniktech/gradle-maven-publish-plugin/issues/259","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1509878175","fragment_type":"issue_comment","sequence":3,"text":"With Gradle 8.1 being out the updated status is\n- Publishing releases to Maven Central (snapshots are fine), blocked by Gradle issue #22779.\n- Kotlin Multiplatform projects, blocked by KT-49933.","author_login":"gabrielittner","author_association":"COLLABORATOR","created_at":"2023-04-15T15:56:51+08:00","repo_name":"vanniktech/gradle-maven-publish-plugin","issue_id":897637877,"issue_number":259,"issue_url":"https://github.com/vanniktech/gradle-maven-publish-plugin/issues/259","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2599505903","fragment_type":"issue_comment","sequence":4,"text":"Had to diable the configuration cache (`gradle-8.12`) as build was failing with the following error. Is this issue still blocked by URL ?\n\nConfiguration cache state could not be cached: field `repository` of `org.gradle.api.publish.maven.tasks.PublishToMavenRepository$PublishSpec` bean found in field `value` of `org.gradle.internal.Try$Success` bean found in field `result` of `org.gradle.internal.serialization.Cached$Fixed` bean found in field `spec` of task `:catalog:publishMavenPublicationToMavenCentralRepository` of type `org.gradle.api.publish.maven.tasks.PublishToMavenRepository`: error writing value of type 'org.gradle.api.publish.maven.tasks.PublishToMavenRepository$RepositorySpec$Configured'","author_login":"sureshg","author_association":"NONE","created_at":"2025-01-18T03:34:56+08:00","repo_name":"vanniktech/gradle-maven-publish-plugin","issue_id":897637877,"issue_number":259,"issue_url":"https://github.com/vanniktech/gradle-maven-publish-plugin/issues/259","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2994321531","fragment_type":"issue_comment","sequence":5,"text":"Actually, just saw URL which seems like it might remove the issue altogether?","author_login":"eygraber","author_association":"CONTRIBUTOR","created_at":"2025-06-22T16:57:21+08:00","repo_name":"vanniktech/gradle-maven-publish-plugin","issue_id":897637877,"issue_number":259,"issue_url":"https://github.com/vanniktech/gradle-maven-publish-plugin/issues/259","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2994330199","fragment_type":"issue_comment","sequence":6,"text":"Yes with that PR we are compatible without any changes on Gradle's side needed.","author_login":"gabrielittner","author_association":"COLLABORATOR","created_at":"2025-06-22T17:14:55+08:00","repo_name":"vanniktech/gradle-maven-publish-plugin","issue_id":897637877,"issue_number":259,"issue_url":"https://github.com/vanniktech/gradle-maven-publish-plugin/issues/259","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0316","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Step not saved (clash with precision?) (was: Add step editing (was: Slider min/max/step editing))?","query_context":"This is step 2 from URL \n\nAdd the ability to edit the start/stop/round attributes of a slider (triple-click or shift-click, probably, popping up a dialog). This will be saved to a shared table, with options:\n\n- just apply to this slider\n- apply to all [cfg] sliders on [KSampler] nodes\n- apply to all [cfg] sliders on any node\n\nAt this point the old mechanism will be retired (maybe auto converted, maybe not!)","known_context_document_ids":["gh_issue_2574697599"],"reference_answer":"Yup. There is a weird interplay between precision, round, and step. I think I've got it working...","answer_document_id":"gh_comment_2430431842","silver_evidence_path":["gh_comment_2430463263","gh_issue_2603989066","gh_comment_2430431842"],"evidence_issue_ids":[2574697599,2603989066],"source_repo_name":"chrisgoringe/cg-controller","source_issue_id":2574697599,"source_issue_number":61,"source_issue_url":"https://github.com/chrisgoringe/cg-controller/issues/61","target_repo_name":"chrisgoringe/cg-controller","target_issue_id":2603989066,"target_issue_number":181,"target_issue_url":"https://github.com/chrisgoringe/cg-controller/issues/181","reference_anchor_document_id":"gh_comment_2430463263","reference_answer_author":"chrisgoringe","reference_answer_author_association":"OWNER","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.2778,"anchor_target_overlap":0.1111,"target_answer_overlap":0.1111},"issue_created_at":"2024-10-09T04:09:37+08:00","valid_comment_count":26,"fragments":[{"document_id":"gh_issue_2574697599","fragment_type":"issue_description","sequence":0,"text":"Step not saved (clash with precision?) (was: Add step editing (was: Slider min/max/step editing))\nThis is step 2 from URL \n\nAdd the ability to edit the start/stop/round attributes of a slider (triple-click or shift-click, probably, popping up a dialog). This will be saved to a shared table, with options:\n\n- just apply to this slider\n- apply to all [cfg] sliders on [KSampler] nodes\n- apply to all [cfg] sliders on any node\n\nAt this point the old mechanism will be retired (maybe auto converted, maybe not!)","author_login":"chrisgoringe","author_association":"OWNER","created_at":"2024-10-09T04:09:37+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2574697599,"issue_number":61,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/61","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2402333839","fragment_type":"issue_comment","sequence":1,"text":"Can you detect if a FLOAT or Primitive node is connected to a \"cfg\" input ?\nAnd also apply the settings to these sliders.\n\nIf so, Step 3 ( the global slider table ) may not be necessary.\n\ncfg","author_login":"JorgeR81","author_association":"NONE","created_at":"2024-10-09T13:20:45+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2574697599,"issue_number":61,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/61","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2424974260","fragment_type":"issue_comment","sequence":2,"text":"I think it's the lack of a slider editing system, that keeps sliders from being added to ComfyUI.\n\nBecause, apparently, you can already add a slider to a specific widget, if you change the code, and add the slider parameters:\n URL ( but your changes will be lost, the next time you update ComfyUI ).\n\nIf ComfyUI adds sliders, the Controller could use the same slider Settings.\nBut have no idea if/when they will add sliders ( or if they plan an editing system ).\nAt least they've moved my slider feature request to the litegraph issues ( URL )","author_login":"JorgeR81","author_association":"NONE","created_at":"2024-10-20T13:54:07+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2574697599,"issue_number":61,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/61","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2426467522","fragment_type":"issue_comment","sequence":3,"text":"@chrisgoringe In the documentation I suggest adding that the range you set on the controller slider will also be applied on the node widget.","author_login":"LukeG89","author_association":"NONE","created_at":"2024-10-21T11:58:14+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2574697599,"issue_number":61,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/61","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2428647218","fragment_type":"issue_comment","sequence":4,"text":"I have the new edit GUI.\nBut the new step size is not applied to the slider.\n\nThe step size is not saved. \nWhen open the edit GUI again, it shows the old step value.\n\nstp","author_login":"JorgeR81","author_association":"NONE","created_at":"2024-10-22T08:43:34+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2574697599,"issue_number":61,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/61","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2428823993","fragment_type":"issue_comment","sequence":5,"text":"I found another issue. When you set a min/max range, it becomes difficult to change values on the widget using the arrows; many clicks to just change of 1 step\n\n URL","author_login":"LukeG89","author_association":"NONE","created_at":"2024-10-22T09:53:08+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2574697599,"issue_number":61,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/61","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2430375907","fragment_type":"issue_comment","sequence":6,"text":"The new slider steps are being used in the slider.\n\nBut I still can't use the arrows in the node widgets, once the step is changed.","author_login":"JorgeR81","author_association":"NONE","created_at":"2024-10-22T21:48:10+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2574697599,"issue_number":61,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/61","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2430390567","fragment_type":"issue_comment","sequence":7,"text":"OK, I can see what's the issue.\n\nI have the slider step size at 0.05, but the arrows change at 0.01 steps, so the resulting value is not allowed. \n\nWhen I click down in the arrow it goes from 0.35 to 0.36\nBut on click up, it returns to 0.35","author_login":"JorgeR81","author_association":"NONE","created_at":"2024-10-22T21:57:25+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2574697599,"issue_number":61,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/61","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2430449114","fragment_type":"issue_comment","sequence":8,"text":"All the issues described above seem solved with the latest update.","author_login":"JorgeR81","author_association":"NONE","created_at":"2024-10-22T22:41:15+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2574697599,"issue_number":61,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/61","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2430463263","fragment_type":"issue_comment","sequence":9,"text":"Now I'm able to save step the slider settings. And they are kept when switching workflows.\nAnd I can also use the widget arrows.\n\n---\n\nBut I now have other issues: URL \n\nI tried mostly with min (0), max (1) and step (0.05)","author_login":"JorgeR81","author_association":"NONE","created_at":"2024-10-22T22:55:14+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2574697599,"issue_number":61,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/61","linked_issue_ids":[2603989066],"is_known_query_context":false},{"document_id":"gh_comment_2430467303","fragment_type":"issue_comment","sequence":10,"text":"@JorgeR81 Have you tried saving step to 1 and then lowering to 0.1? Because I got the problem in the video","author_login":"LukeG89","author_association":"NONE","created_at":"2024-10-22T22:59:18+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2574697599,"issue_number":61,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/61","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2430469221","fragment_type":"issue_comment","sequence":11,"text":"Yes, with Apply ControlNet I can use `min (0), max (1) and step (1)`, I had not issues\n\nBut with `min (0), max (1) and step (0.1)` the rounding is broken.\n\ncn","author_login":"JorgeR81","author_association":"NONE","created_at":"2024-10-22T23:01:07+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2574697599,"issue_number":61,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/61","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2430486425","fragment_type":"issue_comment","sequence":12,"text":"@JorgeR81 Watch my video here URL I always had 1 decimal digit","author_login":"LukeG89","author_association":"NONE","created_at":"2024-10-22T23:13:36+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2574697599,"issue_number":61,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/61","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2430493600","fragment_type":"issue_comment","sequence":13,"text":"Yeah\n\nIf you don't set the precision in the main comfy controls, cfg has a precision of 0.1, but a step size of 0.01, which makes no sense at all.","author_login":"chrisgoringe","author_association":"OWNER","created_at":"2024-10-22T23:20:55+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2574697599,"issue_number":61,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/61","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2430495725","fragment_type":"issue_comment","sequence":14,"text":"If you set step to 1, it gets confused into thinking the widget is an integer! I'll raise a new issue.\n\nNot sure what's happened with the rounding.","author_login":"chrisgoringe","author_association":"OWNER","created_at":"2024-10-22T23:23:13+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2574697599,"issue_number":61,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/61","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2603989066","fragment_type":"issue_description","sequence":0,"text":"Can't move slider with scroll if step less than precision (was: Setting to require shift-scroll for sliders)\nBy default the sliders respond to the scrollwheel.\n\nThis can be changed to make it so they require the shift key to be pressed.","author_login":"chrisgoringe","author_association":"OWNER","created_at":"2024-10-22T01:18:23+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2603989066,"issue_number":181,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2428724609","fragment_type":"issue_comment","sequence":1,"text":"I think there is a problem with the cfg, I can change all the other sliders except for cfg ones...\n\n URL","author_login":"LukeG89","author_association":"NONE","created_at":"2024-10-22T09:11:55+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2603989066,"issue_number":181,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2428786625","fragment_type":"issue_comment","sequence":2,"text":"It's working for me.\n\nMaybe that's a custom node ?\n\nThe `shift` key as another function on one of my custom nodes ( URL )","author_login":"JorgeR81","author_association":"NONE","created_at":"2024-10-22T09:37:44+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2603989066,"issue_number":181,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2428855220","fragment_type":"issue_comment","sequence":3,"text":"@JorgeR81 It can't be since the problem only occurs on CFG sliders. \n \n\nThis is a frontend function.","author_login":"LukeG89","author_association":"NONE","created_at":"2024-10-22T10:06:09+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2603989066,"issue_number":181,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2428863054","fragment_type":"issue_comment","sequence":4,"text":"It doesn't work even in always mode, to it's not due to shift key","author_login":"LukeG89","author_association":"NONE","created_at":"2024-10-22T10:08:56+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2603989066,"issue_number":181,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2428903337","fragment_type":"issue_comment","sequence":5,"text":"Could it be related to the default step size of 0.01?\n\nstep_size\n\n(I tried scrolling as much as I can but it doesn't change a single value...)","author_login":"LukeG89","author_association":"NONE","created_at":"2024-10-22T10:28:00+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2603989066,"issue_number":181,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2428921415","fragment_type":"issue_comment","sequence":6,"text":"I'll look at it. My guess is that there is a clash between step size and rounding (if it's rounded to 1 decimal place, but taking steps of 0.01).","author_login":"chrisgoringe","author_association":"OWNER","created_at":"2024-10-22T10:36:21+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2603989066,"issue_number":181,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2430431842","fragment_type":"issue_comment","sequence":7,"text":"Yup. There is a weird interplay between precision, round, and step. I think I've got it working...","author_login":"chrisgoringe","author_association":"OWNER","created_at":"2024-10-22T22:27:04+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2603989066,"issue_number":181,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2430440249","fragment_type":"issue_comment","sequence":8,"text":"After this fix, the other 2 issues I had are also fixed !\n\n URL \n URL","author_login":"JorgeR81","author_association":"NONE","created_at":"2024-10-22T22:34:25+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2603989066,"issue_number":181,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2430446870","fragment_type":"issue_comment","sequence":9,"text":"Ah, but now there is a different problem:\n\nWhen dragging the slider, the new step interval is not used. It's only used with scroll.","author_login":"JorgeR81","author_association":"NONE","created_at":"2024-10-22T22:38:57+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2603989066,"issue_number":181,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2430480651","fragment_type":"issue_comment","sequence":10,"text":"Cfg now it's working, but they are all 2 decimal digits instead of 1","author_login":"LukeG89","author_association":"NONE","created_at":"2024-10-22T23:10:07+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2603989066,"issue_number":181,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2430493906","fragment_type":"issue_comment","sequence":11,"text":"This with the latest update:\n\n- When dragging the slider, the new step interval ( 0.05 ) is not used. - **NOT FIXED**\n\n- The widget arrows, in the node, don't use the new step interval. - FIXED","author_login":"JorgeR81","author_association":"NONE","created_at":"2024-10-22T23:21:17+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2603989066,"issue_number":181,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2430607658","fragment_type":"issue_comment","sequence":12,"text":"Everything seems to work:\n- I can apply the new step size to multiple nodes.\n- The new step size is applied, when scrolling and dragging sliders or using the widget arrows.\n- The new min / max are applied to the widgets","author_login":"JorgeR81","author_association":"NONE","created_at":"2024-10-23T01:23:04+08:00","repo_name":"chrisgoringe/cg-controller","issue_id":2603989066,"issue_number":181,"issue_url":"https://github.com/chrisgoringe/cg-controller/issues/181","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0321","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Syntax issue using PREFERRED PARAMETER?","query_context":"Hello,\n\nI have syntax errors in my abaplint result set, that a importing parameter IV_STRING is not given into the method.\nSyntax_error_prefered_parameter_1\n\nThe importing parameter IV_STRING is definied as prefered parameter.\nSyntax_error_prefered_parameter_3\n\nAccording to SAP help this option \"prefered parameter\" says, that parameter is implicitly set to optional.\nSyntax_error_prefered_parameter_2\n\nTherefore abaplint should not return an error in that case. SAP himself is not raising issues.\n\nThanks.\n\nBest regards,\nDominik","known_context_document_ids":["gh_issue_1528811973"],"reference_answer":"if you change the code to use functional writing, I think it should work, as a workaround.... URL","answer_document_id":"gh_comment_1385631950","silver_evidence_path":["gh_comment_1379348978","gh_issue_1519036695","gh_comment_1385631950"],"evidence_issue_ids":[1528811973,1519036695],"source_repo_name":"abaplint/abaplint","source_issue_id":1528811973,"source_issue_number":2841,"source_issue_url":"https://github.com/abaplint/abaplint/issues/2841","target_repo_name":"abaplint/abaplint","target_issue_id":1519036695,"target_issue_number":2826,"target_issue_url":"https://github.com/abaplint/abaplint/issues/2826","reference_anchor_document_id":"gh_comment_1379348978","reference_answer_author":"larshp","reference_answer_author_association":"MEMBER","quality_score":91.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1053,"anchor_target_overlap":0.2105,"target_answer_overlap":0.0},"issue_created_at":"2023-01-11T10:43:53+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_1528811973","fragment_type":"issue_description","sequence":0,"text":"Syntax issue using PREFERRED PARAMETER\nHello,\n\nI have syntax errors in my abaplint result set, that a importing parameter IV_STRING is not given into the method.\nSyntax_error_prefered_parameter_1\n\nThe importing parameter IV_STRING is definied as prefered parameter.\nSyntax_error_prefered_parameter_3\n\nAccording to SAP help this option \"prefered parameter\" says, that parameter is implicitly set to optional.\nSyntax_error_prefered_parameter_2\n\nTherefore abaplint should not return an error in that case. SAP himself is not raising issues.\n\nThanks.\n\nBest regards,\nDominik","author_login":"dpuerner","author_association":"NONE","created_at":"2023-01-11T10:43:53+08:00","repo_name":"abaplint/abaplint","issue_id":1528811973,"issue_number":2841,"issue_url":"https://github.com/abaplint/abaplint/issues/2841","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1378574544","fragment_type":"issue_comment","sequence":1,"text":"You can reproduce by adding this code to playground.\n\nREPORT zfoobar.\n\nCLASS lcl_tele_mapping DEFINITION.\n\n PUBLIC SECTION.\n\n CLASS-METHODS replaceit\n IMPORTING\n !iv_new_char TYPE char1 OPTIONAL\n !iv_old_char TYPE char1 DEFAULT '.'\n !iv_string TYPE char100\n PREFERRED PARAMETER iv_string\n RETURNING\n VALUE(rv_string) TYPE char100.\n\n PROTECTED SECTION.\n PRIVATE SECTION.\nENDCLASS.\n\nCLASS lcl_tele_mapping IMPLEMENTATION.\n\n METHOD replaceit.\n IF iv_new_char = iv_old_char.\n RETURN.\n ENDIF.\n ENDMETHOD.\n\nENDCLASS.\n\nFIELD-SYMBOLS TYPE char100.\n = lcl_tele_mapping=>replaceit( iv_new_char = 'A'\n iv_old_char = 'B' ).","author_login":"dpuerner","author_association":"NONE","created_at":"2023-01-11T10:59:43+08:00","repo_name":"abaplint/abaplint","issue_id":1528811973,"issue_number":2841,"issue_url":"https://github.com/abaplint/abaplint/issues/2841","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1378633740","fragment_type":"issue_comment","sequence":2,"text":"Thanks for the hint :-) Now example code looks good I suppose ;-)","author_login":"dpuerner","author_association":"NONE","created_at":"2023-01-11T11:50:50+08:00","repo_name":"abaplint/abaplint","issue_id":1528811973,"issue_number":2841,"issue_url":"https://github.com/abaplint/abaplint/issues/2841","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1378757582","fragment_type":"issue_comment","sequence":3,"text":"add \"abap\" after the first 3 pings then it will also syntax highlight \n\nabap\nWRITE highlighted.","author_login":"larshp","author_association":"MEMBER","created_at":"2023-01-11T13:31:43+08:00","repo_name":"abaplint/abaplint","issue_id":1528811973,"issue_number":2841,"issue_url":"https://github.com/abaplint/abaplint/issues/2841","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1379125962","fragment_type":"issue_comment","sequence":4,"text":"shorter reproduced as\n\nabap\nCLASS lcl_tele_mapping DEFINITION.\n PUBLIC SECTION.\n CLASS-METHODS replaceit\n IMPORTING\n iv_new TYPE i OPTIONAL\n iv_string TYPE string\n PREFERRED PARAMETER iv_string.\nENDCLASS.\n\nCLASS lcl_tele_mapping IMPLEMENTATION.\n METHOD replaceit.\n ENDMETHOD.\nENDCLASS.\n\nSTART-OF-SELECTION.\n lcl_tele_mapping=>replaceit( iv_new = 2 ).\n lcl_tele_mapping=>replaceit( 'A' ).","author_login":"larshp","author_association":"MEMBER","created_at":"2023-01-11T16:41:34+08:00","repo_name":"abaplint/abaplint","issue_id":1528811973,"issue_number":2841,"issue_url":"https://github.com/abaplint/abaplint/issues/2841","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1379348978","fragment_type":"issue_comment","sequence":5,"text":"Working well now - thank you! \nI have checked syntax now for our namespace with about 20.000 objects and only have 4 issues left (all same type of issue - see ticket #2826). That's really great!","author_login":"dpuerner","author_association":"NONE","created_at":"2023-01-11T19:00:36+08:00","repo_name":"abaplint/abaplint","issue_id":1528811973,"issue_number":2841,"issue_url":"https://github.com/abaplint/abaplint/issues/2841","linked_issue_ids":[1519036695],"is_known_query_context":false},{"document_id":"gh_issue_1519036695","fragment_type":"issue_description","sequence":0,"text":"Syntax issue - Method importing parameter \"IV_...\" does not exist (check_syntax) [E]\nHello,\n\nI have a syntax issue which is not explainable and shouldn't be an issue in real.\nSyntax_error_import_parameter_1\n\nProblem is, that IV_DOCID seems to be not existing.\nSyntax_error_import_parameter_2\n\nThe attribute MO_SRV_DLV_INB himself is from type class /MYCOMP/CL_SRV_DLV_INB. This class himself does not include the method BO_UPDATE_BATCH because this method will be inherited from the super class which is /MYCOMP/CL_SRV_DLV_BASE. But also there the interface /MYCOMP/IF_SRV_DLV is used which includes the method interface.\nSyntax_error_import_parameter_3\nSyntax_error_import_parameter_4\n\nSo for me everything looks fine and also within SAP system there is no syntax issue. I have a couple of such issues in the syntax check via abaplint (via gitlab). This is my JSON config file.\n\nabaplint_syntax_json\n\nThanks for checking.\n\nBest regards,\nDominik","author_login":"dpuerner","author_association":"NONE","created_at":"2023-01-04T14:04:54+08:00","repo_name":"abaplint/abaplint","issue_id":1519036695,"issue_number":2826,"issue_url":"https://github.com/abaplint/abaplint/issues/2826","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1377394815","fragment_type":"issue_comment","sequence":1,"text":"I reproduced this issue with the playground. Just add the namespace /MYCOMP/ to the error namespace and paste coding below.\nimage\n\nFor me it seems, that abaplint will try to run BO_UPDATE_BATCH of class /MYCOMP/CL_SRV_BATCH in line 99 instead of calling method BO_UPDATE_BATCH of attribut MO_SRV_DLV_INBOUND (which is class /MYCOMP/CL_SRV_DLV_INB). So the expected result is, that BO_UPDATE_BATCH is not found because class /MYCOMP/CL_SRV_DLV_INB is unknown (not part of the playground).\n\nTo test my theory, try to comment line 101, 102 and 104 and then result set says, that IV_PRODUCTNO is expected and thats for me the indicator that abaplint is trying to run BO_UPDATE_BATCH of class /MYCOMP/CL_SRV_BATCH.\n\nimage\n\nThanks a lot!\n\nBR\nDominik\n\n_REPORT zfoobar.\n\ninterface /MYCOMP/IF_SRV_BATCH\n public.\n\n methods BO_UPDATE_BATCH\n importing\n !IV_PRODUCTNO type /SCWM/DE_MATNR\n !IV_BATCHNO type /SCWM/DE_CHARG\n !IV_SLED type /SCWM/SLED optional\n !IV_REREAD_BATCH type XFELD default ABAP_FALSE\n !IV_RETRIES type I default '10'\n !IV_COMMIT type XFELD default ABAP_FALSE\n !IV_WAIT type XFELD default ABAP_FALSE\n !IV_ENTITLED type /SCWM/DE_ENTITLED optional\n !IT_VAL_NUM type TT_BAPI1003_ALLOC_VALUES_NUM optional\n !IT_VAL_CHAR type TT_BAPI1003_ALLOC_VALUES_CHAR optional\n !IT_VAL_CURR type TT_BAPI1003_ALLOC_VALUES_CURR optional\n exporting\n !EV_BATCHNO type /SCWM/DE_CHARG\n !EO_BATCH type ref to /SCWM/CL_BATCH_APPL\n !EV_NOT_EXISTS type XFELD\n raising\n /MYCOMP/CX_SRV_ROOT .\n \n methods BO_UPDATE_BATCH_ON_HU_ITEM\n importing\n !IV_BATCHID type /SCWM/DE_BATCHID optional\n !IV_BATCHNO type /SCWM/DE_CHARG optional\n !IV_PROCTY type /SCWM/DE_PROCTY\n !IV_REASON type /SCWM/DE_REASON optional\n !IV_GUID_PARENT_HU type /LIME/GUID_PARENT\n !IV_GUID_STOCK type /LIME/GUID_STOCK\n !IV_COMMIT type XFELD default ABAP_FALSE\n !IV_WAIT type XFELD default ABAP_FALSE\n exporting\n !ET_LTAP_VB type /SCWM/TT_LTAP_VB\n !ET_BAPIRET type BAPIRETTAB\n raising\n /MYCOMP/CX_SRV_ROOT .\n \n methods BO_UPDATE_BATCH_ON_DLV_ITEM\n importing\n !IV_DOCCAT type /SCDL/DL_DOCCAT\n !IV_DOCID type /SCDL/DL_DOCID\n !IV_ITEMID type /SCDL/DL_ITEMID\n !IV_BATCHNO type /SCWM/DE_CHARG\n !IV_COMMIT_WORK type XFELD default ABAP_FALSE\n !IV_WAIT type XFELD default ABAP_FALSE\n raising\n /MYCOMP/CX_SRV_ROOT .\n \nendinterface.\n\nclass /MYCOMP/CL_SRV_BATCH definition\n public\n create protected\n\n global friends /MYCOMP/CL_SRV_FACTORY .\n\npublic section.\n\n interfaces /MYCOMP/IF_SRV_BATCH .\n\n aliases BO_UPDATE_BATCH\n for /MYCOMP/IF_SRV_BATCH~BO_UPDATE_BATCH .\n aliases BO_UPDATE_BATCH_ON_DLV_ITEM\n for /MYCOMP/IF_SRV_BATCH~BO_UPDATE_BATCH_ON_DLV_ITEM .\n aliases BO_UPDATE_BATCH_ON_HU_ITEM\n for /MYCOMP/IF_SRV_BATCH~BO_UPDATE_BATCH_ON_HU_ITEM .\n \n methods CONSTRUCTOR\n importing\n !IO_LOG type ref to /MYCOMP/CL_LOG optional\n !IV_LGNUM type /SCWM/LGNUM\n !IV_NO_LOG type XFELD default ABAP_FALSE\n raising\n /MYCOMP/CX_SRV_INPUT_INITIAL .\n\n PROTECTED SECTION.\n\n data MO_SRV_DLV_INB type ref to /MYCOMP/CL_SRV_DLV_INB .\n data MO_SRV_HU type ref to /MYCOMP/CL_SRV_HU .\n\n PRIVATE SECTION.\n\nENDCLASS.\n\nCLASS /MYCOMP/CL_SRV_BATCH IMPLEMENTATION.\n\n METHOD constructor.\n ENDMETHOD.\n\n METHOD bo_update_batch.\n ENDMETHOD.\n\n METHOD bo_update_batch_on_dlv_item.\n\n CALL METHOD me->mo_srv_dlv_inb->bo_update_batch\n EXPORTING\n iv_docid = iv_docid\n iv_itemid = iv_itemid\n iv_batchno = iv_batchno\n iv_commit_work = iv_commit_work\n iv_wait = iv_wait. \n\n ENDMETHOD.\n\n METHOD bo_update_batch_on_hu_item.\n\n CALL METHOD me->mo_srv_hu->bo_update_batch_on_hu_item(\n EXPORTING\n iv_batchid = iv_batchid\n iv_batchno = iv_batchno\n iv_procty = iv_procty\n iv_reason = iv_reason\n iv_guid_parent_hu = iv_guid_parent_hu\n iv_guid_stock = iv_guid_stock\n iv_commit = iv_commit\n iv_wait = iv_wait\n IMPORTING\n et_ltap_vb = et_ltap_vb\n et_bapiret = et_bapiret ).\n\n ENDMETHOD.\n\nENDCLASS._","author_login":"dpuerner","author_association":"NONE","created_at":"2023-01-10T14:51:42+08:00","repo_name":"abaplint/abaplint","issue_id":1519036695,"issue_number":2826,"issue_url":"https://github.com/abaplint/abaplint/issues/2826","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383162741","fragment_type":"issue_comment","sequence":2,"text":"so, something like the below reproduces the same issue?\n\nabap\nINTERFACE if_srv.\n METHODS update_batch.\n METHODS update_line.\nENDINTERFACE.\n\nCLASS cl_srv_batch DEFINITION.\n PUBLIC SECTION.\n INTERFACES if_srv.\n ALIASES update_batch FOR if_srv~update_batch.\n ALIASES update_line FOR if_srv~update_line.\n \n PROTECTED SECTION.\n DATA foobar TYPE REF TO voided.\nENDCLASS.\n\nCLASS cl_srv_batch IMPLEMENTATION.\n METHOD update_batch.\n ENDMETHOD.\n\n METHOD update_line.\n CALL METHOD me->foobar->update_batch\n EXPORTING\n iv_docid = 2.\n ENDMETHOD.\nENDCLASS.\n\nimage","author_login":"larshp","author_association":"MEMBER","created_at":"2023-01-15T14:18:51+08:00","repo_name":"abaplint/abaplint","issue_id":1519036695,"issue_number":2826,"issue_url":"https://github.com/abaplint/abaplint/issues/2826","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383993170","fragment_type":"issue_comment","sequence":3,"text":"I doublecheck your example and yes same principle issue. Object _foobar_ is referenced to another class and abaplint seems to identify the method call (signature) in line 23 as the method which is in the interface _if_srv_, but that's not true. Because w/o assigning _iv_docid_ no syntax issue. On the other hand you can typ _foobar_ ref to any kind of z-class e.g. and there is no error shown, that class is unknown. This is the expected behavior, also in your example above.","author_login":"dpuerner","author_association":"NONE","created_at":"2023-01-16T12:37:31+08:00","repo_name":"abaplint/abaplint","issue_id":1519036695,"issue_number":2826,"issue_url":"https://github.com/abaplint/abaplint/issues/2826","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1385631950","fragment_type":"issue_comment","sequence":4,"text":"if you change the code to use functional writing, I think it should work, as a workaround.... URL","author_login":"larshp","author_association":"MEMBER","created_at":"2023-01-17T15:49:15+08:00","repo_name":"abaplint/abaplint","issue_id":1519036695,"issue_number":2826,"issue_url":"https://github.com/abaplint/abaplint/issues/2826","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1386050696","fragment_type":"issue_comment","sequence":5,"text":"You are right - It's working with the functional writing. Thank you 👍 Is it planned to provide a long term fix?","author_login":"dpuerner","author_association":"NONE","created_at":"2023-01-17T21:06:30+08:00","repo_name":"abaplint/abaplint","issue_id":1519036695,"issue_number":2826,"issue_url":"https://github.com/abaplint/abaplint/issues/2826","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1386521031","fragment_type":"issue_comment","sequence":6,"text":"long term fix: yes, just takes time, and I need to concentrate for rewriting stuff 😅","author_login":"larshp","author_association":"MEMBER","created_at":"2023-01-18T05:44:21+08:00","repo_name":"abaplint/abaplint","issue_id":1519036695,"issue_number":2826,"issue_url":"https://github.com/abaplint/abaplint/issues/2826","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1396691833","fragment_type":"issue_comment","sequence":7,"text":"Hello,\nI have rechecked with old calling variant and with the newest abaplint version (2.9.53) and finally the issue is fixed. So thanks a lot for providing also a bugfix for that :-) It was a very short term long term fix ;-)\nBest regards,\nDominik","author_login":"dpuerner","author_association":"NONE","created_at":"2023-01-19T09:41:14+08:00","repo_name":"abaplint/abaplint","issue_id":1519036695,"issue_number":2826,"issue_url":"https://github.com/abaplint/abaplint/issues/2826","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1396695325","fragment_type":"issue_comment","sequence":8,"text":"yea, well, sometimes its difficult to get stuff working, ABAP is a messed up language","author_login":"larshp","author_association":"MEMBER","created_at":"2023-01-19T09:44:24+08:00","repo_name":"abaplint/abaplint","issue_id":1519036695,"issue_number":2826,"issue_url":"https://github.com/abaplint/abaplint/issues/2826","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0323","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"App not opening on Windows 11?","query_context":"I downloaded the app from both the Microsoft store, as well as the manual .zip installation. It is not opening from either place. My cursor shows the blue circle loading icon for about half a second and then nothing happens. I am not able to replicate this issue on any Windows 10 machines.","known_context_document_ids":["gh_issue_1433886944"],"reference_answer":"So assuming that's fixed, I believe the original issue this thread is based on is a problem with the 2022 version that is not present in the main branch. Here's a pre-release build of the main branch for anyone else finding this issue later: \npathplanner-windows.zip\n\nI'll close this after the 2023 version is released.","answer_document_id":"gh_comment_1283239772","silver_evidence_path":["gh_comment_1301466008","gh_issue_1392899383","gh_comment_1283239772"],"evidence_issue_ids":[1433886944,1392899383],"source_repo_name":"mjansen4857/pathplanner","source_issue_id":1433886944,"source_issue_number":141,"source_issue_url":"https://github.com/mjansen4857/pathplanner/issues/141","target_repo_name":"mjansen4857/pathplanner","target_issue_id":1392899383,"target_issue_number":117,"target_issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","reference_anchor_document_id":"gh_comment_1301466008","reference_answer_author":"mjansen4857","reference_answer_author_association":"OWNER","quality_score":87.35,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.2857,"target_answer_overlap":0.087},"issue_created_at":"2022-11-02T22:50:57+08:00","valid_comment_count":28,"fragments":[{"document_id":"gh_issue_1433886944","fragment_type":"issue_description","sequence":0,"text":"App not opening on Windows 11\nI downloaded the app from both the Microsoft store, as well as the manual .zip installation. It is not opening from either place. My cursor shows the blue circle loading icon for about half a second and then nothing happens. I am not able to replicate this issue on any Windows 10 machines.","author_login":"pratyush-p","author_association":"NONE","created_at":"2022-11-02T22:50:57+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1433886944,"issue_number":141,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/141","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1301466008","fragment_type":"issue_comment","sequence":1,"text":"Did you download the 2023 beta version? This sounds like a duplicate of #117 which is fixed.","author_login":"mjansen4857","author_association":"OWNER","created_at":"2022-11-02T22:52:44+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1433886944,"issue_number":141,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/141","linked_issue_ids":[1392899383],"is_known_query_context":false},{"document_id":"gh_comment_1301470273","fragment_type":"issue_comment","sequence":2,"text":"I am using 2023.0.1 pathplanner lib, but only 2023.0.0 is working. 2023.0.1 doesn't work still","author_login":"pratyush-p","author_association":"NONE","created_at":"2022-11-02T22:59:24+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1433886944,"issue_number":141,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/141","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1392899383","fragment_type":"issue_description","sequence":0,"text":"Pathplanner doesn't launch on my computer\nPathplanner will no longer launch on my Windows 11 computer. It definitely hasn't worked since updating to the newest Windows version (22H2), but I honestly don't know if the update caused it to not work. I know it was working some time (like a month) before updating, and it isn't working now (like a week after updating). I've tried uninstalling and re-installing from the windows store, as well as downloading the exe directly and running it, but the app didn't launch in either of those cases.","author_login":"J-Barta","author_association":"NONE","created_at":"2022-09-30T19:30:59+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1264432259","fragment_type":"issue_comment","sequence":1,"text":"This is really hard to diagnose so can you install flutter and run the app in debug mode? If it still crashes this should give you some error output.","author_login":"mjansen4857","author_association":"OWNER","created_at":"2022-10-01T17:35:24+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1276811113","fragment_type":"issue_comment","sequence":2,"text":"We (3467) are also experiencing the same issue, Windows 11 22H2. Can you post more specific instructions on how to grab the debug info you need?","author_login":"ehamwey","author_association":"NONE","created_at":"2022-10-12T22:50:21+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1276816531","fragment_type":"issue_comment","sequence":3,"text":"Follow these instructions: URL \n\nMake sure you use `flutter run` to run in debug mode. I'm assuming this is an issue with the 22H2 update messing up some dependency needed to run. Building manually could potentially install these dependencies and work fine. If that doesn't work you could try installing Visual Studio Community (make sure the \"Desktop Development with C++\" module is installed with it) which might fix it as well. If all that fails then I don't think there's much I can do besides wait for a flutter update to fix the issue.","author_login":"mjansen4857","author_association":"OWNER","created_at":"2022-10-12T22:59:42+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1276823091","fragment_type":"issue_comment","sequence":4,"text":"Some initial searching led me to this issue: URL \n\nWorking on building from source now.","author_login":"ehamwey","author_association":"NONE","created_at":"2022-10-12T23:10:20+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1276824689","fragment_type":"issue_comment","sequence":5,"text":"It looks like Bitsdojo Window library was removed in May, but there hasn't been a release since March. Is it possible to send a newer Windows binary over? The Flutter setup is taking quite a while.","author_login":"ehamwey","author_association":"NONE","created_at":"2022-10-12T23:12:47+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1276855284","fragment_type":"issue_comment","sequence":6,"text":"After running the latest version with `flutter run` this confirmed my suspicions. The issue was likely bitsdojo_window. I'll build a new version for Windows and post it here for anyone still having this problem.","author_login":"ehamwey","author_association":"NONE","created_at":"2022-10-12T23:53:54+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1276858645","fragment_type":"issue_comment","sequence":7,"text":"Yeah that sounds right. Here's the one i built that includes some redistributables that some people might not have so its better to use this one. Keep in mind this version might have unknown issues and pathplanner lib doesn't support all of the functionality if you're using the release version.\n\nPathPlanner-windows.zip","author_login":"mjansen4857","author_association":"OWNER","created_at":"2022-10-13T00:01:20+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1276858922","fragment_type":"issue_comment","sequence":8,"text":"Beat me to it! We'll use this one for now. Thanks for your help.","author_login":"ehamwey","author_association":"NONE","created_at":"2022-10-13T00:01:51+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1277591572","fragment_type":"issue_comment","sequence":9,"text":"I have the same problem, here is what I got after running in debug mode.\n\nLaunching lib\\main.dart on Windows in debug mode...\nBuilding Windows application...\n[ERROR:flutter/shell/platform/windows/direct_manipulation.cc(137)] CoCreateInstance(CLSID_DirectManipulationManager, nullptr, CLSCTX_INPROC_SERVER, IID_IDirectManipulationManager, &manager_) failed\nSyncing files to device Windows... 518ms\n\nFlutter run key commands.\nr Hot reload. 🔥🔥🔥\nR Hot restart.\nh List all available interactive commands.\nd Detach (terminate \"flutter run\" but leave application running).\nc Clear the screen\nq Quit (terminate the application on the device).\n\n💪 Running with sound null safety 💪\n\nAn Observatory debugger and profiler on Windows is available at: URL \nflutter: ┌───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────\nflutter: │ RangeError (index): Invalid value: Valid value range is empty: 0\nflutter: ├┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄\nflutter: │ #0 List.[] (dart:core-patch/growable_array.dart:264:36)\nflutter: │ #1 Trajectory.calculateVelocity (package:pathplanner/services/generator/trajectory.dart:187:13)\nflutter: │ #2 Trajectory.generateSingleTrajectory (package:pathplanner/services/generator/trajectory.dart:87:5)\nflutter: │ #3 Trajectory.generateFullTrajectory (package:pathplanner/services/generator/trajectory.dart:67:30)\nflutter: │ #4 RobotPath.generateTrajectory. (package:pathplanner/robot_path/robot_path.dart:79:46)\nflutter: │ #5 new Future. (dart:async/future.dart:253:37)\nflutter: │ #6 _rootRun (dart:async/zone.dart:1383:47)\nflutter: │ #7 _CustomZone.run (dart:async/zone.dart:1293:19)\nflutter: ├┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄\nflutter: │ 08:10:16.131 (+0:00:01.484156)\nflutter: ├┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄\nflutter: │ ⛔ Dart Error\nflutter: └───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────\nLost connection to device.","author_login":"Gameknight77YT","author_association":"NONE","created_at":"2022-10-13T13:15:00+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1278285532","fragment_type":"issue_comment","sequence":10,"text":"Just tried to run the same application since yesterday and can't get it to start nor the version I built, but running with `flutter run` in debug mode starts fine.","author_login":"ehamwey","author_association":"NONE","created_at":"2022-10-13T23:35:12+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1278287823","fragment_type":"issue_comment","sequence":11,"text":"Can `flutter run` build the app without an Internet connection?","author_login":"ehamwey","author_association":"NONE","created_at":"2022-10-13T23:39:53+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1278553816","fragment_type":"issue_comment","sequence":12,"text":"@Gameknight77YT it looks like one of your path files is messed up for some reason. Try removing them from your robot project and see if it will launch then. \n\n@ehamwey No idea why it would work in debug mode but not release mode. Only thing I could think of would be to run in debug mode and just don’t close it. I guess worst case you can just connect to a hotspot or Wi-Fi to run it again. Unfortunately flutter checks for dependencies every time you run so you need to be online. There should be a log file in C:/Users/{YOUR USER}/AppData/Roaming/pathplanner something (don’t remember the exact folder) check that after trying to open the built app and maybe it will have something.","author_login":"mjansen4857","author_association":"OWNER","created_at":"2022-10-14T06:41:49+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1278981640","fragment_type":"issue_comment","sequence":13,"text":"I did that and it is working now. I then readded them one at a time. The problem was one of them had an endpoint that was also a stop point.","author_login":"Gameknight77YT","author_association":"NONE","created_at":"2022-10-14T13:02:28+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1279795300","fragment_type":"issue_comment","sequence":14,"text":"That probably happened when you deleted another point in the path. I'll make a separate issue to fix that.","author_login":"mjansen4857","author_association":"OWNER","created_at":"2022-10-15T17:59:34+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1281755857","fragment_type":"issue_comment","sequence":15,"text":"@ehamwey when you get a chance can you pull changes for the repo and see if builds you make will run now? I fixed a crash that *may* have been what caused your builds to crash but I'm not sure. If not then I'm really not sure what's going on there unless you can find some error output.","author_login":"mjansen4857","author_association":"OWNER","created_at":"2022-10-18T03:11:17+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1283168528","fragment_type":"issue_comment","sequence":16,"text":"We had to `flutter pub upgrade` to get the builds working, but once it was built we have an offline version that works. Thanks for your help again. I think I may have moved the Release folder out of the build directory originally which messed with the binary paths.","author_login":"ehamwey","author_association":"NONE","created_at":"2022-10-19T00:18:59+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1283177117","fragment_type":"issue_comment","sequence":17,"text":"Looks like after a reboot the built binary does not run. Any thoughts?","author_login":"ehamwey","author_association":"NONE","created_at":"2022-10-19T00:29:55+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1283181357","fragment_type":"issue_comment","sequence":18,"text":"Is there anything in `%AppData%/com.mjansen4857/pathplanner/log.txt`?","author_login":"mjansen4857","author_association":"OWNER","created_at":"2022-10-19T00:34:20+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1283182689","fragment_type":"issue_comment","sequence":19,"text":"Negative - it's empty. \nWe were getting an error relating to how the built directories were moved, which seemed to have fixed itself once we connected to WiFi? So I'm trying a clean and build in the final destination directory to see if that resolves things, then we're rebooting and testing offline.","author_login":"ehamwey","author_association":"NONE","created_at":"2022-10-19T00:36:22+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1283184120","fragment_type":"issue_comment","sequence":20,"text":"Moving the built app shouldn't do anything. Just to confirm, after building you're running the exe in `pathplanner/build/windows/runner/Release` right?","author_login":"mjansen4857","author_association":"OWNER","created_at":"2022-10-19T00:38:01+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1283195790","fragment_type":"issue_comment","sequence":21,"text":"Yep - moving the entire `pathplanner` folder. \n\nSeems like it will run on WiFi, but not with WiFi off.","author_login":"ehamwey","author_association":"NONE","created_at":"2022-10-19T00:50:00+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1283197525","fragment_type":"issue_comment","sequence":22,"text":"By WiFi on/off do you mean connected/disconnected from a network or actually turning the WiFi off in the settings?","author_login":"mjansen4857","author_association":"OWNER","created_at":"2022-10-19T00:51:23+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1283203414","fragment_type":"issue_comment","sequence":23,"text":"Never mind, I can reproduce it. This is something, thanks. I'll look into it.","author_login":"mjansen4857","author_association":"OWNER","created_at":"2022-10-19T00:56:52+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1283210140","fragment_type":"issue_comment","sequence":24,"text":"I'm going to try on Flutter 3.3.4, we're currently running 3.5.0 because of the method we installed it by. I don't think that should fix the problem but will try anyway.","author_login":"ehamwey","author_association":"NONE","created_at":"2022-10-19T01:01:23+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1283228990","fragment_type":"issue_comment","sequence":25,"text":"Found the issue and fixed it. Was a quirk of how dart try/catch blocks work so checking for PathPlannerLib updates would crash. Pull changes and try again.\n\nI'd definitely use 3.3.4 as well since 3.5 is a beta and I'm currently using 3.3.4.","author_login":"mjansen4857","author_association":"OWNER","created_at":"2022-10-19T01:15:39+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1283239772","fragment_type":"issue_comment","sequence":26,"text":"So assuming that's fixed, I believe the original issue this thread is based on is a problem with the 2022 version that is not present in the main branch. Here's a pre-release build of the main branch for anyone else finding this issue later: \npathplanner-windows.zip\n\nI'll close this after the 2023 version is released.","author_login":"mjansen4857","author_association":"OWNER","created_at":"2022-10-19T01:21:50+08:00","repo_name":"mjansen4857/pathplanner","issue_id":1392899383,"issue_number":117,"issue_url":"https://github.com/mjansen4857/pathplanner/issues/117","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0328","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Access to AWS to test gdalcubes in large collections?","query_context":"Dear Marius:\n\nDo you have access to AWS to test gdalcubes? We had problems when regularizing large image collections. The problems are not simple to reproduce, because they occur when trying to run `gdalcubes` on big data.","known_context_document_ids":["gh_issue_1148414934"],"reference_answer":"This might be caused by the GDAL error handler defined by the `sf` package. The GDAL error handler (set with \n`CPLSetErrorHandler`) might be called from threads created by gdalcubes but the error handler calls `Rf_warning()` (see URL which is not thread-safe. However, a single-thread test, where all computations run in the main thread should clarify further.","answer_document_id":"gh_comment_1030926650","silver_evidence_path":["gh_comment_1049101611","gh_issue_1042460965","gh_comment_1030926650"],"evidence_issue_ids":[1148414934,1042460965],"source_repo_name":"appelmar/gdalcubes_R","source_issue_id":1148414934,"source_issue_number":55,"source_issue_url":"https://github.com/appelmar/gdalcubes_R/issues/55","target_repo_name":"appelmar/gdalcubes_R","target_issue_id":1042460965,"target_issue_number":48,"target_issue_url":"https://github.com/appelmar/gdalcubes_R/issues/48","reference_anchor_document_id":"gh_comment_1049101611","reference_answer_author":"appelmar","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2,"anchor_target_overlap":0.1129,"target_answer_overlap":0.1111},"issue_created_at":"2022-02-23T18:02:59+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_1148414934","fragment_type":"issue_description","sequence":0,"text":"Access to AWS to test gdalcubes in large collections\nDear Marius:\n\nDo you have access to AWS to test gdalcubes? We had problems when regularizing large image collections. The problems are not simple to reproduce, because they occur when trying to run `gdalcubes` on big data.","author_login":"gilbertocamara","author_association":"NONE","created_at":"2022-02-23T18:02:59+08:00","repo_name":"appelmar/gdalcubes_R","issue_id":1148414934,"issue_number":55,"issue_url":"https://github.com/appelmar/gdalcubes_R/issues/55","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1049101611","fragment_type":"issue_comment","sequence":1,"text":"Dear Gilberto, I've fixed two major issues that might be related:\n\n1. The stack overflow crash (see #48)\n2. If images on Amazon S3 are not available but STAC points to them (resulting in 404 errors in GDALOpen), these are now simply ignored. Previously, the errors stopped the computation of the current chunk and hence may have caused _corrupt_ chunks.\n\nThat being said, I do have access to AWS and successfully computed a Sentinel-2 composite over Germany at 10m resolution using approx. 500 Sentinel-2 images. \n \nI am still doing some more tests but plan to do a CRAN release next week or so. If you have any examples with sits, I'd be happy to try it out with the new gdalcubes version.","author_login":"appelmar","author_association":"OWNER","created_at":"2022-02-23T18:50:21+08:00","repo_name":"appelmar/gdalcubes_R","issue_id":1148414934,"issue_number":55,"issue_url":"https://github.com/appelmar/gdalcubes_R/issues/55","linked_issue_ids":[1042460965],"is_known_query_context":false},{"document_id":"gh_comment_1061582242","fragment_type":"issue_comment","sequence":2,"text":"@gilbertocamara New CRAN version just released (binary package builds may take some more days).","author_login":"appelmar","author_association":"OWNER","created_at":"2022-03-08T09:36:07+08:00","repo_name":"appelmar/gdalcubes_R","issue_id":1148414934,"issue_number":55,"issue_url":"https://github.com/appelmar/gdalcubes_R/issues/55","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1042460965","fragment_type":"issue_description","sequence":0,"text":"Stack overflow: Error : C stack usage * is too close to the limit\nOccasionally, creating a data cube crashes with a stack overflow and/or a corrupt result file. Unfortunately, this happens mostly after performing several operations but there is no reproducible example yet. Some tests to find out the source include the following:\n\n1. The behavior was never observed outside of R (i.e. when using the simple gdalcubes command line client to create cubes).\n2. Disabling the progress bar does not solve the issue\n3. Using RcppThread for creating C++ threads does not solve the issue","author_login":"appelmar","author_association":"OWNER","created_at":"2021-11-02T14:47:24+08:00","repo_name":"appelmar/gdalcubes_R","issue_id":1042460965,"issue_number":48,"issue_url":"https://github.com/appelmar/gdalcubes_R/issues/48","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_957771145","fragment_type":"issue_comment","sequence":1,"text":"It seems that increasing the maximum stack size with `ulimit -s` can _solve_ the issue","author_login":"appelmar","author_association":"OWNER","created_at":"2021-11-02T15:03:34+08:00","repo_name":"appelmar/gdalcubes_R","issue_id":1042460965,"issue_number":48,"issue_url":"https://github.com/appelmar/gdalcubes_R/issues/48","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1030926650","fragment_type":"issue_comment","sequence":2,"text":"This might be caused by the GDAL error handler defined by the `sf` package. The GDAL error handler (set with \n`CPLSetErrorHandler`) might be called from threads created by gdalcubes but the error handler calls `Rf_warning()` (see URL which is not thread-safe. However, a single-thread test, where all computations run in the main thread should clarify further.","author_login":"appelmar","author_association":"OWNER","created_at":"2022-02-06T22:19:02+08:00","repo_name":"appelmar/gdalcubes_R","issue_id":1042460965,"issue_number":48,"issue_url":"https://github.com/appelmar/gdalcubes_R/issues/48","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1032318919","fragment_type":"issue_comment","sequence":3,"text":"Commit e79f4ed seems to fix the issue by calling `CPLPushErrorHandler()` before threads are started (or as a first call within a thread). Hoever, the issue will remain open until changes are merged into master.","author_login":"appelmar","author_association":"OWNER","created_at":"2022-02-08T08:05:11+08:00","repo_name":"appelmar/gdalcubes_R","issue_id":1042460965,"issue_number":48,"issue_url":"https://github.com/appelmar/gdalcubes_R/issues/48","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1048704666","fragment_type":"issue_comment","sequence":4,"text":"Time for a new CRAN release? @rhijmans this might also be of interest to terra development.","author_login":"edzer","author_association":"NONE","created_at":"2022-02-23T11:53:04+08:00","repo_name":"appelmar/gdalcubes_R","issue_id":1042460965,"issue_number":48,"issue_url":"https://github.com/appelmar/gdalcubes_R/issues/48","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1061580772","fragment_type":"issue_comment","sequence":5,"text":"v0.6.0 is now on CRAN (binary package builds may take some more days)","author_login":"appelmar","author_association":"OWNER","created_at":"2022-03-08T09:34:27+08:00","repo_name":"appelmar/gdalcubes_R","issue_id":1042460965,"issue_number":48,"issue_url":"https://github.com/appelmar/gdalcubes_R/issues/48","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0331","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Consider pushing out a new release?","query_context":"### Steps to reproduce\n\n \n\n \n\nrails new demo\ncd demo\nDOCKER_BUILDKIT=1 docker build .\n\n### Expected behavior\n\nBuild succeeds.\n\n### Actual behavior\n\nFails with Ruby 3.4.2 (obtained via brew)\n\n10.42 Gem::Ext::BuildError: ERROR: Failed to build gem native extension.\n10.42 \n10.42 current directory: /usr/local/bundle/ruby/3.4.0/gems/psych-5.2.3/ext/psych\n10.42 /usr/local/bin/ruby extconf.rb\n10.42 checking for pkg-config for yaml-0.1... not found\n10.42 checking for yaml.h... no\n10.42 yaml.h not found\n10.42 *** extconf.rb failed ***\n\n### System configuration\n\n**Rails version**: `Rails 8.0.1`\n\n**Ruby version**: `ruby 3.4.2 (2025-02-15 revision d2930f8e7a) +PRISM [arm64-darwin24]`\n\n### See also\n\n URL","known_context_document_ids":["gh_issue_2869092863"],"reference_answer":"Similar report just came in #435, too.\n\nI believe something changed in the alpine image, since we test alpine in the CI pipeline and it passed last week, but started failing yesterday with the new image\n\n- pass URL \n- fail URL \n\nWill investigate. In the meantime, a workaround is to use `ruby:3-alpine3.18`","answer_document_id":"gh_comment_1852044793","silver_evidence_path":["gh_comment_2751441316","gh_issue_2037156404","gh_comment_1852044793"],"evidence_issue_ids":[2869092863,2037156404],"source_repo_name":"rails/rails","source_issue_id":2869092863,"source_issue_number":54588,"source_issue_url":"https://github.com/rails/rails/issues/54588","target_repo_name":"sparklemotion/sqlite3-ruby","target_issue_id":2037156404,"target_issue_number":434,"target_issue_url":"https://github.com/sparklemotion/sqlite3-ruby/issues/434","reference_anchor_document_id":"gh_comment_2751441316","reference_answer_author":"flavorjones","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2222,"anchor_target_overlap":0.2222,"target_answer_overlap":0.2593},"issue_created_at":"2025-02-21T13:53:46+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_2869092863","fragment_type":"issue_description","sequence":0,"text":"Consider pushing out a new release\n### Steps to reproduce\n\n \n\n \n\nrails new demo\ncd demo\nDOCKER_BUILDKIT=1 docker build .\n\n### Expected behavior\n\nBuild succeeds.\n\n### Actual behavior\n\nFails with Ruby 3.4.2 (obtained via brew)\n\n10.42 Gem::Ext::BuildError: ERROR: Failed to build gem native extension.\n10.42 \n10.42 current directory: /usr/local/bundle/ruby/3.4.0/gems/psych-5.2.3/ext/psych\n10.42 /usr/local/bin/ruby extconf.rb\n10.42 checking for pkg-config for yaml-0.1... not found\n10.42 checking for yaml.h... no\n10.42 yaml.h not found\n10.42 *** extconf.rb failed ***\n\n### System configuration\n\n**Rails version**: `Rails 8.0.1`\n\n**Ruby version**: `ruby 3.4.2 (2025-02-15 revision d2930f8e7a) +PRISM [arm64-darwin24]`\n\n### See also\n\n URL","author_login":"rubys","author_association":"CONTRIBUTOR","created_at":"2025-02-21T13:53:46+08:00","repo_name":"rails/rails","issue_id":2869092863,"issue_number":54588,"issue_url":"https://github.com/rails/rails/issues/54588","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2715816128","fragment_type":"issue_comment","sequence":1,"text":"I had to add `libyaml-dev` to the `Dockerfile`, so that the install line change from:\n\nRUN apt-get update -qq && \\\n apt-get install --no-install-recommends -y build-essential git libpq-dev pkg-config && \\\n rm -rf /var/lib/apt/lists /var/cache/apt/archives\n\nto:\n\nRUN apt-get update -qq && \\\n apt-get install --no-install-recommends -y build-essential git libyaml-dev libpq-dev pkg-config && \\\n rm -rf /var/lib/apt/lists /var/cache/apt/archives","author_login":"pas256","author_association":"CONTRIBUTOR","created_at":"2025-03-11T22:10:54+08:00","repo_name":"rails/rails","issue_id":2869092863,"issue_number":54588,"issue_url":"https://github.com/rails/rails/issues/54588","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2715839481","fragment_type":"issue_comment","sequence":2,"text":"@pas256 indeed. That fix was already merged (on January 14th!) in URL ; all we need now is a release.","author_login":"rubys","author_association":"CONTRIBUTOR","created_at":"2025-03-11T22:25:14+08:00","repo_name":"rails/rails","issue_id":2869092863,"issue_number":54588,"issue_url":"https://github.com/rails/rails/issues/54588","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2751441316","fragment_type":"issue_comment","sequence":3,"text":"URL can produce a Dockerfile for your Rails application as it exists now, as opposed to when it was first created. It works for all current releases of Rails and Ruby, and has options to produce an Alpine dockerfile.\n\nRails = 3.18.","author_login":"rubys","author_association":"CONTRIBUTOR","created_at":"2025-03-25T14:24:03+08:00","repo_name":"rails/rails","issue_id":2869092863,"issue_number":54588,"issue_url":"https://github.com/rails/rails/issues/54588","linked_issue_ids":[2037156404],"is_known_query_context":false},{"document_id":"gh_issue_2037156404","fragment_type":"issue_description","sequence":0,"text":"\"symbol not found\" on alpine 3.19\n**TL;DR from the maintainers -- read me first!**\n\nYou can work around this issue in two ways:\n\n1. pin to alpine 3.18\n2. compile the gem from source, see INSTALLATION.md\n\nPick one! Permanent fix is being worked on upstream in rake-compiler-dock URL \n\nThanks for your patience :heart: \n\n(The original bug description follows)\n\n-----\n\nOn the latest ruby image with alpine 3.19, I can install `sqlite3` ruby gem, but it emits \"symbol not found\" errors at runtime.\n\nThis is a quick test on alpine 3.18:\n\n$ docker run --rm -it ruby:3.2.2-alpine3.18 /bin/sh\n/ # gem install sqlite3\nFetching sqlite3-1.6.9-x86_64-linux.gem\nSuccessfully installed sqlite3-1.6.9-x86_64-linux\n1 gem installed\n\nA new release of RubyGems is available: 3.4.10 → 3.4.22!\nRun `gem update --system 3.4.22` to update your installation.\n\n/ # ruby -rsqlite3 -e 'puts SQLite3::SQLITE_LOADED_VERSION'\n4.44.2\n/ # \n\nAnd here's the same on 3.19:\n\n$ docker run --rm -it ruby:3.2.2-alpine3.19 /bin/sh\n/ # gem install sqlite3\nFetching sqlite3-1.6.9-x86_64-linux.gem\nSuccessfully installed sqlite3-1.6.9-x86_64-linux\n1 gem installed\n\nA new release of RubyGems is available: 3.4.10 → 3.4.22!\nRun `gem update --system 3.4.22` to update your installation.\n\n/ # ruby -rsqlite3 -e 'puts SQLite3::SQLITE_LOADED_VERSION'\n :85:in `require': cannot load such file -- sqlite3/sqlite3_native (LoadError)\n from :85:in `require'\n from /usr/local/bundle/gems/sqlite3-1.6.9-x86_64-linux/lib/sqlite3.rb:6:in `rescue in '\n from /usr/local/bundle/gems/sqlite3-1.6.9-x86_64-linux/lib/sqlite3.rb:2:in ` '\n from :159:in `require'\n from :159:in `rescue in require'\n from :39:in `require'\n :85:in `require': Error relocating /usr/local/bundle/gems/sqlite3-1.6.9-x86_64-linux/lib/sqlite3/3.2/sqlite3_native.so: posix_fallocate64: symbol not found - /usr/local/bundle/gems/sqlite3-1.6.9-x86_64-linux/lib/sqlite3/3.2/sqlite3_native.so (LoadError)\n from :85:in `require'\n from /usr/local/bundle/gems/sqlite3-1.6.9-x86_64-linux/lib/sqlite3.rb:4:in ` '\n from :159:in `require'\n from :159:in `rescue in require'\n from :39:in `require'\n :85:in `require': cannot load such file -- sqlite3 (LoadError)\n from :85:in `require'\n/ # \n\nI'm not sure if this is the gem or the docker image causing the issue here.","author_login":"rickselby","author_association":"NONE","created_at":"2023-12-12T07:34:31+08:00","repo_name":"sparklemotion/sqlite3-ruby","issue_id":2037156404,"issue_number":434,"issue_url":"https://github.com/sparklemotion/sqlite3-ruby/issues/434","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1852044793","fragment_type":"issue_comment","sequence":1,"text":"Similar report just came in #435, too.\n\nI believe something changed in the alpine image, since we test alpine in the CI pipeline and it passed last week, but started failing yesterday with the new image\n\n- pass URL \n- fail URL \n\nWill investigate. In the meantime, a workaround is to use `ruby:3-alpine3.18`","author_login":"flavorjones","author_association":"MEMBER","created_at":"2023-12-12T13:34:16+08:00","repo_name":"sparklemotion/sqlite3-ruby","issue_id":2037156404,"issue_number":434,"issue_url":"https://github.com/sparklemotion/sqlite3-ruby/issues/434","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1852757063","fragment_type":"issue_comment","sequence":2,"text":"I copied `/lib/ld-musl-x86_64.so.1` from `ruby:3-alpine3.18` Docker image and that seems to fix the problem, so it would appear that the problem is related to some change in Musl libc or how Musl is compiled.\n\nBy looking the exported symbols from the library (e.g., `readelf -Ws --dyn-syms /lib/ld-musl-x86_64.so.1 | grep posix_fallocate64`) I've confirmed that the symbol `posix_fallocate64` is present in the previous version but missing in the new version. I'm not sure yet if this was intended or if it was an oversight. I'll try to dig more.","author_login":"pdfrod","author_association":"NONE","created_at":"2023-12-12T20:30:11+08:00","repo_name":"sparklemotion/sqlite3-ruby","issue_id":2037156404,"issue_number":434,"issue_url":"https://github.com/sparklemotion/sqlite3-ruby/issues/434","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1853042235","fragment_type":"issue_comment","sequence":3,"text":"Just a note: the symbol missing for the user in #435 is `fcntl64`, where the one reported missing in this issue is `posix_fallocate64`.","author_login":"flavorjones","author_association":"MEMBER","created_at":"2023-12-12T23:49:17+08:00","repo_name":"sparklemotion/sqlite3-ruby","issue_id":2037156404,"issue_number":434,"issue_url":"https://github.com/sparklemotion/sqlite3-ruby/issues/434","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1853139650","fragment_type":"issue_comment","sequence":4,"text":"OK, it seems this was an intentional breaking change in Musl 1.24:\n \n\nSo if I understood correctly, functions with the `64` suffix were dropped and the correct fix is to use the unsuffixed versions instead.\n\nHere are examples of other projects that were also affected by this:\n- URL \n- URL","author_login":"pdfrod","author_association":"NONE","created_at":"2023-12-13T01:48:29+08:00","repo_name":"sparklemotion/sqlite3-ruby","issue_id":2037156404,"issue_number":434,"issue_url":"https://github.com/sparklemotion/sqlite3-ruby/issues/434","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1853204270","fragment_type":"issue_comment","sequence":5,"text":"@pdfrod Thank you so much for doing this research! I should have time tomorrow to investigate if I can work around this in the native (precompiled) gems.","author_login":"flavorjones","author_association":"MEMBER","created_at":"2023-12-13T03:19:23+08:00","repo_name":"sparklemotion/sqlite3-ruby","issue_id":2037156404,"issue_number":434,"issue_url":"https://github.com/sparklemotion/sqlite3-ruby/issues/434","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1855067044","fragment_type":"issue_comment","sequence":6,"text":"I'm not sure there's a fix for this other than for rake-compiler-dock to support generating native musl-specific gems. Upstream issue is URL","author_login":"flavorjones","author_association":"MEMBER","created_at":"2023-12-14T03:26:31+08:00","repo_name":"sparklemotion/sqlite3-ruby","issue_id":2037156404,"issue_number":434,"issue_url":"https://github.com/sparklemotion/sqlite3-ruby/issues/434","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1857454356","fragment_type":"issue_comment","sequence":7,"text":"Thanks for looking into this; I did wonder if it was upstream.\n\nI'll pin to alpine-3.18 for now.","author_login":"rickselby","author_association":"NONE","created_at":"2023-12-15T08:10:55+08:00","repo_name":"sparklemotion/sqlite3-ruby","issue_id":2037156404,"issue_number":434,"issue_url":"https://github.com/sparklemotion/sqlite3-ruby/issues/434","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1862832988","fragment_type":"issue_comment","sequence":8,"text":"I've updated the issue description with a TLDR summary of the workarounds.","author_login":"flavorjones","author_association":"MEMBER","created_at":"2023-12-19T14:12:59+08:00","repo_name":"sparklemotion/sqlite3-ruby","issue_id":2037156404,"issue_number":434,"issue_url":"https://github.com/sparklemotion/sqlite3-ruby/issues/434","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1873135269","fragment_type":"issue_comment","sequence":9,"text":"Confirm a breaking change in the Alpine image. I redeployed the same app with no change to the `Gemfile` or `Dockerfile` and now receive this error:\n\n[info] /usr/local/bundle/gems/sqlite3-1.7.0-x86_64-linux/lib/sqlite3.rb:6:in `require': cannot load such file -- sqlite3/sqlite3_native (LoadError)\n[info] Did you mean? sqlite3/3.3/sqlite3_native\n[info] sqlite3/3.2/sqlite3_native\n[info] sqlite3/3.1/sqlite3_native\n[info] sqlite3/3.0/sqlite3_native\n[info] from /usr/local/bundle/gems/sqlite3-1.7.0-x86_64-linux/lib/sqlite3.rb:6:in `rescue in '\n...\n\nAnd that this diff got my deploy working again:\n\ndiff\n--- a/Dockerfile\n+++ b/Dockerfile\n@@ -1,4 +1,4 @@\n-FROM ruby:3.2.2-alpine AS base\n+FROM ruby:3.2.2-alpine3.18 AS base\n\n( :wave: :wave: Hi Mike)","author_login":"kmcphillips","author_association":"NONE","created_at":"2024-01-01T03:47:50+08:00","repo_name":"sparklemotion/sqlite3-ruby","issue_id":2037156404,"issue_number":434,"issue_url":"https://github.com/sparklemotion/sqlite3-ruby/issues/434","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0334","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"'quarto publish gh-pages' does not respect output-dir?","query_context":"### Bug description\n\nQuarto docs specify to set `output-dir: docs` for gh-pages: URL -- and set `docs/` as the target directory in the Github Pages config.\n\nHowever, running `quarto publish gh-pages` appears to ignore the `output-dir` setting.\n- input: URL \n- `gh-pages` after running `quarto publish gh-pages` locally (successfully): URL \n\nThis means I need to set the Github Pages config to use ` ` instead of `docs/`.\n\nRunning `quarto render` locally puts the output in `docs/` as expected.\n\n---\n\n- macOS 12.4\n\n- quarto version:\n\nbase ❯ quarto check\n\n \n\n[✓] Checking Quarto installation......OK\n Version: 0.9.629\n Path: /Applications/quarto/bin\n\n[✓] Checking basic markdown render....OK\n\n[✓] Checking Python 3 installation....OK\n Version: 3.9.13 (Conda)\n Path: /Users/inorton/opt/conda/bin/python\n Jupyter: (None)\n\n Jupyter is not available in this Python installation.\n Install with conda install jupyter\n\n[✓] Checking R installation...........OK\n Version: 4.1.0\n Path: /Library/Frameworks/R.framework/Resources\n LibPaths:\n - /Users/inorton/Library/R/x86_64/4.1/library\n - /Library/Frameworks/R.framework/Versions/4.1/Resources/library\n rmarkdown: 2.9\n\n[✓] Checking Knitr engine render......OK\n\n \n\n### Checklist\n\n- [X] formatted your issue so it is easier for us to read?\n- [X] included a minimal, self-contained, and reproducible example?\n- [X] documented the quarto version you're running, by providing the output produced by `quarto check` in a terminal in your issue?\n- [ ] documented the RStudio IDE version you're running (if applicable), by providing the value displayed in the \"About RStudio\" main menu dialog?\n- [X] documented which operating system you're running? If on Linux, please provide the specific distribution as well.\n- [ ] upgraded to the latest version, including your versions of R, the RStudio IDE, and relevant R packages?","known_context_document_ids":["gh_issue_1288930178"],"reference_answer":"@tg-x Please open a new thread ( URL with sufficient details for your request after double checking it's not something already possible, if there are alternatives. Thank you!\nNote that `quarto publish` is not intended to cover all possible use cases, *i.e.*, you can can use `quarto render` and then take control of the publishing part to do whatever you need to do.\nGitHub Pages does not care about branches other than `gh-pages`, so adding a parameter to publish to GitHub Pages on another branch does not make sense.","answer_document_id":"gh_comment_1965479875","silver_evidence_path":["gh_comment_1965481746","gh_issue_1325867468","gh_comment_1965479875"],"evidence_issue_ids":[1288930178,1325867468],"source_repo_name":"quarto-dev/quarto-cli","source_issue_id":1288930178,"source_issue_number":1246,"source_issue_url":"https://github.com/quarto-dev/quarto-cli/issues/1246","target_repo_name":"quarto-dev/quarto-cli","target_issue_id":1325867468,"target_issue_number":1640,"target_issue_url":"https://github.com/quarto-dev/quarto-cli/issues/1640","reference_anchor_document_id":"gh_comment_1965481746","reference_answer_author":"mcanouil","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.25,"target_answer_overlap":0.2},"issue_created_at":"2022-06-29T15:51:57+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_1288930178","fragment_type":"issue_description","sequence":0,"text":"'quarto publish gh-pages' does not respect output-dir\n### Bug description\n\nQuarto docs specify to set `output-dir: docs` for gh-pages: URL -- and set `docs/` as the target directory in the Github Pages config.\n\nHowever, running `quarto publish gh-pages` appears to ignore the `output-dir` setting.\n- input: URL \n- `gh-pages` after running `quarto publish gh-pages` locally (successfully): URL \n\nThis means I need to set the Github Pages config to use ` ` instead of `docs/`.\n\nRunning `quarto render` locally puts the output in `docs/` as expected.\n\n---\n\n- macOS 12.4\n\n- quarto version:\n\nbase ❯ quarto check\n\n \n\n[✓] Checking Quarto installation......OK\n Version: 0.9.629\n Path: /Applications/quarto/bin\n\n[✓] Checking basic markdown render....OK\n\n[✓] Checking Python 3 installation....OK\n Version: 3.9.13 (Conda)\n Path: /Users/inorton/opt/conda/bin/python\n Jupyter: (None)\n\n Jupyter is not available in this Python installation.\n Install with conda install jupyter\n\n[✓] Checking R installation...........OK\n Version: 4.1.0\n Path: /Library/Frameworks/R.framework/Resources\n LibPaths:\n - /Users/inorton/Library/R/x86_64/4.1/library\n - /Library/Frameworks/R.framework/Versions/4.1/Resources/library\n rmarkdown: 2.9\n\n[✓] Checking Knitr engine render......OK\n\n \n\n### Checklist\n\n- [X] formatted your issue so it is easier for us to read?\n- [X] included a minimal, self-contained, and reproducible example?\n- [X] documented the quarto version you're running, by providing the output produced by `quarto check` in a terminal in your issue?\n- [ ] documented the RStudio IDE version you're running (if applicable), by providing the value displayed in the \"About RStudio\" main menu dialog?\n- [X] documented which operating system you're running? If on Linux, please provide the specific distribution as well.\n- [ ] upgraded to the latest version, including your versions of R, the RStudio IDE, and relevant R packages?","author_login":"ihnorton","author_association":"NONE","created_at":"2022-06-29T15:51:57+08:00","repo_name":"quarto-dev/quarto-cli","issue_id":1288930178,"issue_number":1246,"issue_url":"https://github.com/quarto-dev/quarto-cli/issues/1246","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1170248147","fragment_type":"issue_comment","sequence":1,"text":"The docs on the website need to be updated. `quarto publish gh-pages` is specifically made to work with the `gh-pages` branch not a docs directory. We will do this soon.","author_login":"jjallaire","author_association":"COLLABORATOR","created_at":"2022-06-29T17:06:04+08:00","repo_name":"quarto-dev/quarto-cli","issue_id":1288930178,"issue_number":1246,"issue_url":"https://github.com/quarto-dev/quarto-cli/issues/1246","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1965479632","fragment_type":"issue_comment","sequence":2,"text":"It would be useful to be able to specify an output path inside the gh-pages branch,\nto support publishing different branches to different paths from github actions","author_login":"tg-x","author_association":"NONE","created_at":"2024-02-26T22:58:14+08:00","repo_name":"quarto-dev/quarto-cli","issue_id":1288930178,"issue_number":1246,"issue_url":"https://github.com/quarto-dev/quarto-cli/issues/1246","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1965481746","fragment_type":"issue_comment","sequence":3,"text":"@tg-x Please don't post multiple times the exact same message. It does not help.\nSee < URL","author_login":"mcanouil","author_association":"COLLABORATOR","created_at":"2024-02-26T23:00:01+08:00","repo_name":"quarto-dev/quarto-cli","issue_id":1288930178,"issue_number":1246,"issue_url":"https://github.com/quarto-dev/quarto-cli/issues/1246","linked_issue_ids":[1325867468],"is_known_query_context":false},{"document_id":"gh_comment_1966118414","fragment_type":"issue_comment","sequence":4,"text":"Both issues are/were about output directory. You are talking about branches.","author_login":"mcanouil","author_association":"COLLABORATOR","created_at":"2024-02-27T09:23:00+08:00","repo_name":"quarto-dev/quarto-cli","issue_id":1288930178,"issue_number":1246,"issue_url":"https://github.com/quarto-dev/quarto-cli/issues/1246","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1325867468","fragment_type":"issue_description","sequence":0,"text":"`quarto publish gh-pages`does not respect `output-dir: _site`\n### Bug description\n\nRelated to #1246, `quarto publish gh-pages`does not respect `output-dir: _site`\ninstead renders to `./`.\n\n`_quarto.yml` full [here]\n\nyml\nproject:\n type: website\n output-dir: _site\n\nThe last `quarto publish` call results can be seen here\n\n~/G/eyayaw.github.io (main)> quarto publish gh-pages\n\n`\n? Update site at URL (Y/n) › Yes\nFrom URL \n * branch gh-pages -> FETCH_HEAD\nRendering for publish:\n\n[1/6] bio.qmd\n[2/6] posts/2022-07-31_welcome/index.qmd\n[3/6] posts/2022-08-01_ten-baser-tips/index.qmd\n[4/6] blog.qmd\n[5/6] research.qmd\n[6/6] index.qmd\n\nPreparing worktree (resetting branch 'gh-pages'; was at b76bb45)\nBranch 'gh-pages' set up to track remote branch 'gh-pages' from 'origin'.\nHEAD is now at b76bb45 publish gh-pages\n[gh-pages 087d8da] Built site for gh-pages\n 32 files changed, 6880 insertions(+), 41 deletions(-)\n create mode 100644 bio.html\n create mode 100644 blog.html\n create mode 100644 index.html\n create mode 100644 posts/2022-07-31_welcome/index.html\n create mode 100644 posts/2022-08-01_ten-baser-tips/index.html\n create mode 100644 research.html\n create mode 100644 site_libs/bootstrap/bootstrap-dark.min.css\n create mode 100644 site_libs/bootstrap/bootstrap-icons.css\n create mode 100644 site_libs/bootstrap/bootstrap-icons.woff\n create mode 100644 site_libs/bootstrap/bootstrap.min.css\n create mode 100644 site_libs/bootstrap/bootstrap.min.js\n create mode 100644 site_libs/clipboard/clipboard.min.js\n create mode 100644 site_libs/quarto-html/anchor.min.js\n create mode 100644 site_libs/quarto-html/popper.min.js\n create mode 100644 site_libs/quarto-html/quarto-syntax-highlighting-dark.css\n create mode 100644 site_libs/quarto-html/quarto-syntax-highlighting.css\n create mode 100644 site_libs/quarto-html/quarto.js\n create mode 100644 site_libs/quarto-html/tippy.css\n create mode 100644 site_libs/quarto-html/tippy.umd.min.js\n create mode 100644 site_libs/quarto-html/zenscroll-min.js\n create mode 100644 site_libs/quarto-listing/list.min.js\n create mode 100644 site_libs/quarto-listing/quarto-listing.js\n create mode 100644 site_libs/quarto-nav/headroom.min.js\n create mode 100644 site_libs/quarto-nav/quarto-nav.js\n create mode 100644 site_libs/quarto-search/autocomplete.umd.js\n create mode 100644 site_libs/quarto-search/fuse.min.js\n create mode 100644 site_libs/quarto-search/quarto-search.js\n rewrite sitemap.xml (75%)\norigin URL (fetch)\norigin URL (push)\nremote: This repository moved. Please use the new location: \nremote: URL \nTo URL \n b76bb45..087d8da HEAD -> gh-pages\n\n[✓] Published to URL \n\nTo complete publishing, change the source branch for this site to gh-pages.\n\nSet the source branch at: URL \n\n`\n\n### `quarto check` Output\n\nbash\n[✓] Checking Quarto installation......OK\n Version: 1.0.37\n Path: /opt/quarto/bin\n\n[✓] Checking basic markdown render....OK\n\n[✓] Checking Python 3 installation....OK\n Version: 3.10.4\n Path: /usr/bin/python3\n Jupyter: 4.10.0\n Kernels: python3\n\n[✓] Checking Jupyter engine render....OK\n\n[✓] Checking R installation...........OK\n Version: 4.2.0\n Path: /opt/R/4.2.0/lib/R\n LibPaths:\n - /home/eyayaw/R/x86_64-pc-linux-gnu-library/4.2\n - /opt/R/4.2.0/lib/R/library\n rmarkdown: 2.14\n\n[✓] Checking Knitr engine render......OK\n\n### `quarto tools check` Output\n\nbash\n[✓] Inspecting tools\n\nTool Status Installed Latest \nchromium Not installed --- 869685 \ntinytex Update available v2022.05 v2022.08\nWARNING: TeX Live not on path.\n\n### Checklist\n\n- [X] formatted your issue so it is easier for us to read?\n- [ ] included a minimal, fully reproducible example in a single .qmd file? Please provide the whole file rather than the snippet you believe is causing the issue.\n- [X] documented the quarto version you're running, by pasting the output from running `quarto check` in the \"Quarto Check Output\" text area?\n- [X] documented the version of the quarto tools you're running, by providing the output from running `quarto tools check` in the \"Quarto Tools Check Output\" text area?\n- [ ] documented the RStudio IDE version you're running (if applicable), by providing the value displayed in the \"About RStudio\" main menu dialog?\n- [X] documented which operating system you're running? If on Linux, please provide the specific distribution as well.\n- [X] upgraded to the latest version, including your versions of R, the RStudio IDE, and relevant R packages?","author_login":"eyayaw","author_association":"NONE","created_at":"2022-08-02T13:33:46+08:00","repo_name":"quarto-dev/quarto-cli","issue_id":1325867468,"issue_number":1640,"issue_url":"https://github.com/quarto-dev/quarto-cli/issues/1640","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1214271072","fragment_type":"issue_comment","sequence":1,"text":"Publishing to `gh-pages` always uses the root because that's the default content location for GitHub Pages sites that use the `gh-pages` branch. Remember that the `gh-pages` branch created using `quarto publish` will have no other content in it so it's not really important that a subdirectory be used","author_login":"jjallaire","author_association":"COLLABORATOR","created_at":"2022-08-14T02:29:12+08:00","repo_name":"quarto-dev/quarto-cli","issue_id":1325867468,"issue_number":1640,"issue_url":"https://github.com/quarto-dev/quarto-cli/issues/1640","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1965474878","fragment_type":"issue_comment","sequence":2,"text":"It would be useful to be able to specify an output path inside the gh-pages branch,\nto support publishing different branches to different paths from github actions","author_login":"tg-x","author_association":"NONE","created_at":"2024-02-26T22:53:57+08:00","repo_name":"quarto-dev/quarto-cli","issue_id":1325867468,"issue_number":1640,"issue_url":"https://github.com/quarto-dev/quarto-cli/issues/1640","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1965479875","fragment_type":"issue_comment","sequence":3,"text":"@tg-x Please open a new thread ( URL with sufficient details for your request after double checking it's not something already possible, if there are alternatives. Thank you!\nNote that `quarto publish` is not intended to cover all possible use cases, *i.e.*, you can can use `quarto render` and then take control of the publishing part to do whatever you need to do.\nGitHub Pages does not care about branches other than `gh-pages`, so adding a parameter to publish to GitHub Pages on another branch does not make sense.","author_login":"mcanouil","author_association":"COLLABORATOR","created_at":"2024-02-26T22:58:26+08:00","repo_name":"quarto-dev/quarto-cli","issue_id":1325867468,"issue_number":1640,"issue_url":"https://github.com/quarto-dev/quarto-cli/issues/1640","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1966025504","fragment_type":"issue_comment","sequence":4,"text":"yes i figured with render & custom publishing it would be possible, will try that approach","author_login":"tg-x","author_association":"NONE","created_at":"2024-02-27T08:29:46+08:00","repo_name":"quarto-dev/quarto-cli","issue_id":1325867468,"issue_number":1640,"issue_url":"https://github.com/quarto-dev/quarto-cli/issues/1640","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0335","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"[2.5] Audio delay on fresh install when running three parallel Kurento media servers?","query_context":"I was installing BBB 2.5 on a new server and dealing with high audio delay (**audio and video where totally out of sync**).\nI had copied `/etc/bigbluebutton/bbb-conf/apply-config.sh` file from the old server to the new one, without much changing it. There was called the function `enableMultipleKurentos` in it, based on here to run three parallel KMS. \n\nI reinstalled it again and noticed that using `enableMultipleKurentos` function in `apply-config.sh` file may be causing this problem. \nadding `disableMultipleKurentos` didn't solve the problem. So I ended up removing all files and installing again, without adding that function into apply-config fie. And it's solved now. \n\nP.S. I'm not sure if it's been cause of the problem! I just decided to report it here, for more investigations. \nSince I'm not currently able to reproduce it on another server.\n \n**To Reproduce**\nSteps to reproduce the behavior:\n1. fresh installation of BBB 2.5\n2. add `enableMultipleKurentos` to file `/etc/bigbluebutton/bbb-conf/apply-config.sh`\n3. Run `sudo bbb-conf --restart`\n4. Turn on audio and camera\n5. Check on another device to see if it has any delay or not\n\nVersion: **BigBlueButton Server 2.5.1 (3020)**","known_context_document_ids":["gh_issue_1269320628"],"reference_answer":"@mokazemi Would you be able to do some more testing on your end to see if the audio is out of sync before you make either of those two changes (server time or `60:120:20`, then make one of the changes, and test again. \n\nWe would be very interested if you can do a specific before/after comparison of making only those these changes.","answer_document_id":"gh_comment_1251430382","silver_evidence_path":["gh_comment_1254180701","gh_issue_1362382618","gh_comment_1251430382"],"evidence_issue_ids":[1269320628,1362382618],"source_repo_name":"bigbluebutton/bigbluebutton","source_issue_id":1269320628,"source_issue_number":15172,"source_issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","target_repo_name":"bigbluebutton/bigbluebutton","target_issue_id":1362382618,"target_issue_number":15644,"target_issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15644","reference_anchor_document_id":"gh_comment_1254180701","reference_answer_author":"ffdixon","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1625,"anchor_target_overlap":0.3478,"target_answer_overlap":0.1852},"issue_created_at":"2022-06-13T11:49:05+08:00","valid_comment_count":34,"fragments":[{"document_id":"gh_issue_1269320628","fragment_type":"issue_description","sequence":0,"text":"[2.5] Audio delay on fresh install when running three parallel Kurento media servers\nI was installing BBB 2.5 on a new server and dealing with high audio delay (**audio and video where totally out of sync**).\nI had copied `/etc/bigbluebutton/bbb-conf/apply-config.sh` file from the old server to the new one, without much changing it. There was called the function `enableMultipleKurentos` in it, based on here to run three parallel KMS. \n\nI reinstalled it again and noticed that using `enableMultipleKurentos` function in `apply-config.sh` file may be causing this problem. \nadding `disableMultipleKurentos` didn't solve the problem. So I ended up removing all files and installing again, without adding that function into apply-config fie. And it's solved now. \n\nP.S. I'm not sure if it's been cause of the problem! I just decided to report it here, for more investigations. \nSince I'm not currently able to reproduce it on another server.\n \n**To Reproduce**\nSteps to reproduce the behavior:\n1. fresh installation of BBB 2.5\n2. add `enableMultipleKurentos` to file `/etc/bigbluebutton/bbb-conf/apply-config.sh`\n3. Run `sudo bbb-conf --restart`\n4. Turn on audio and camera\n5. Check on another device to see if it has any delay or not\n\nVersion: **BigBlueButton Server 2.5.1 (3020)**","author_login":"mokazemi","author_association":"NONE","created_at":"2022-06-13T11:49:05+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1153893100","fragment_type":"issue_comment","sequence":1,"text":"I'm not sure, but I'd used `data=\"jitterbuffer_msec=60:120:20\"` based on this.","author_login":"mokazemi","author_association":"NONE","created_at":"2022-06-13T13:08:37+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1153901536","fragment_type":"issue_comment","sequence":2,"text":"Other than documented, looking at the actual implementation, the third parameter seems to be ignored: URL -> maxlen is set if there is a colon, but that's it. A second colon does not do anything.","author_login":"defnull","author_association":"CONTRIBUTOR","created_at":"2022-06-13T13:15:56+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1153923420","fragment_type":"issue_comment","sequence":3,"text":"Also, ` ` and ` ` do different things if I understand that correctly. The first one controls the RTP jitterbuffer within freeswitch, the second one sets parameters for the opus codec, which also has a jitterbuffer. They may both have an impact.","author_login":"defnull","author_association":"CONTRIBUTOR","created_at":"2022-06-13T13:35:10+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1154082490","fragment_type":"issue_comment","sequence":4,"text":"Thanks for mentioning this. I hadn't noticed the difference. \nBy the way, I wonder why the problem is solved after not calling `enableMultipleKurentos` function. \nI thought it might do some overwrite that causes media to become out of sync, since I've read that BBB 2.5 uses mediasoup instead. (I'm not a developer, so it's just a guess!)","author_login":"mokazemi","author_association":"NONE","created_at":"2022-06-13T15:42:15+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1156100353","fragment_type":"issue_comment","sequence":5,"text":"We changed the setting back to ` ` and could not reproduce the high-delay issue since then. Still not 100%, but we'll keep the `60:120` setting for now.","author_login":"defnull","author_association":"CONTRIBUTOR","created_at":"2022-06-15T07:34:43+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1156223227","fragment_type":"issue_comment","sequence":6,"text":"This jitterbuffer setting doesn't cause any problem for me. Since it's now 120 and everything is alright. \nand when I was facing described problem, it was 60:120, and still not fixed (more than 2 seconds delay.)","author_login":"mokazemi","author_association":"NONE","created_at":"2022-06-15T09:21:40+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1196312461","fragment_type":"issue_comment","sequence":7,"text":"Hello\nWe also have a relatively similar problem but without any change or modification to settings and configuration files. \nAfter installing new fresh BBB 2.5.4 on a dedicated server (12 core + 64 ram) (also I tested before in vps ( 8 core + 16 ram) with the same issue):\n- Sometimes when we have about 3-5 concurrent web came sharing with presentation enabled, we have unsynced sound for about 3-10 seconds delay from the video, and it may be continued for a while for some of the attendees or moderators from 1 minute to much more minutes. \n- No special Errors in --status and --check but this one : \n URL \nRegards","author_login":"ho30hero","author_association":"NONE","created_at":"2022-07-27T06:22:14+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1229522224","fragment_type":"issue_comment","sequence":8,"text":"I have exactly this problem on dedicated server (32 core CPU + 16 GB Ram)","author_login":"MobinDev","author_association":"NONE","created_at":"2022-08-28T18:10:38+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1229531643","fragment_type":"issue_comment","sequence":9,"text":"Can you check the audio delay on \n\n URL \n\nand let us know if you encounter the same delay. You can use\n\n URL \n\nto join with multiple users.","author_login":"ffdixon","author_association":"MEMBER","created_at":"2022-08-28T19:00:55+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1229539393","fragment_type":"issue_comment","sequence":10,"text":"This does not always happen to everyone! But I have a session recorded on my server that shows it happening to one person in a session with 6 people.","author_login":"MobinDev","author_association":"NONE","created_at":"2022-08-28T19:43:56+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1250717456","fragment_type":"issue_comment","sequence":11,"text":"we also have the delay Problem since 2.5.5. Sometimes it happens in meetings with only two users and some times with more.","author_login":"sonerd","author_association":"NONE","created_at":"2022-09-19T08:26:39+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1253645564","fragment_type":"issue_comment","sequence":12,"text":"I am also following this issue, because we have these problems in some conferences. We were able to find out that people suffering from high delay, at some time in the conference have had very short connection issues (e.g. high ping or high packet loss). This often was due to an unstable wifi connection. It made us curious, why the problems did not happen with 2.4, but with 2.5.x only.\n\nWhat was the exact intention of URL \n\nThe documentation ( URL states: \"The jitter buffer has three params that control its behavior: length, max length, and max drift. Length is the initial size of the jitter buffer in milliseconds. Max length is the upper bound for how big the jitter buffer can grow. [...]\"\n\nIn the referenced commit, @ffdixon changed the JitterBuffer params from \"60:120\" (Initial: 60ms, Max: 120ms) to \"120\" (Initial: 120). Then max is not specified and can grow as big as it wants, or am I wrong? So my understanding is, that when there is no upper bound for the jitter buffer, everything works as expected. But when a client has a temporary problem with its network connection (e.g. wifi unstable), then the jitterbuffer might be increased so much, that there is a huuuge delay.\n\nThus, I do not understand, why the changes to the jitterbuffer have been made....","author_login":"lordwebbie","author_association":"NONE","created_at":"2022-09-21T12:34:20+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1254180701","fragment_type":"issue_comment","sequence":13,"text":"Hello. @ffdixon Today I did some experiments on what discussed here. \n\nHere's my investigations:\n\n**1. jitter buffer on `120` vs `60:120:20`**\n\n a) When it's set to `60:120:20` audio is a little bit cracky in case of packet loss, but there's much unusual delay.\n\n b) When it's set to `120` everything is normal for good connection. **But when there's packet loss**, There would be much **delay** in sending audio. Such when you make a sound, and after two or three seconds the name is indicated at the top of the screen and it receives to the other side. But the video receives without any delay. So it would be out of sync. consequently, people start interrupting each other. \n\n* NOTE: I wasn't able to simulate packet loss. But it sounds the delay gradually appears in bad connections. \n_________\n**2. Server clock out of sync**\n- First disable ntp with `timedatectl set-ntp no`\n- Then change the time a few seconds with `sudo timedatectl set-time`\n- Record something!\n- Don't forget to enable ntp after experiment with `timedatectl set-ntp yes`\n\n**Result:**\n**There was nothing out of sync in the recording.** I'm not sure what was the problem before. Maybe the problem described here has been something else. I'll try to make more investigations if it happened again.","author_login":"mokazemi","author_association":"NONE","created_at":"2022-09-21T20:13:30+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[1362382618],"is_known_query_context":false},{"document_id":"gh_comment_1254194878","fragment_type":"issue_comment","sequence":14,"text":"This is exactly what I wrote above. And it all makes sense regarding the issue.\n\nJitterbuffer will always add a delay, because it is a buffer that can be used when there are very short connection issues.\nSo you generally want the jitterbuffer to be as small as possible, but as long as it needs to be to overcome connectivity issues. Now, jitterbuffers may be dynamically increased by the application, so people with good connections have low latency, and people with bad connection have higher latency but uninterrupted audio/video.\n\nProblem is: There has to be an upper bound for the jitterbuffer size. It does not make much sense to have a jitterbuffer (= delay) of 4 seconds in real-time communication. Instead, one would accept crackling audio sometimes (especially, if the connectivity issues are only very short, because of wifi or whatever)\n\nSo this is why I asked above, why @ffdixon changed the setting with \"improving audio\" as a commit message. It does not make any sense in my understanding.","author_login":"lordwebbie","author_association":"NONE","created_at":"2022-09-21T20:28:55+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1254207448","fragment_type":"issue_comment","sequence":15,"text":"I also noticed the delay gets shorter gradually when the connections become stable. \nSo I think that's somehow a correct behavior. But in some other applications (Like Google Meet) the audio plays slower in bad connection (instead of becoming cracky) and the delay disappears right after the connection becomes stable by playing audio a bit faster.","author_login":"mokazemi","author_association":"NONE","created_at":"2022-09-21T20:42:40+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1254487588","fragment_type":"issue_comment","sequence":16,"text":"I opened a pull request to set a maximum jitterbuffer again. We are using \"100:250\" (100ms default, 250ms max) and it works well. These params are increased compared to the original ones @ffdixon changed (60:120).\n\nBasically, if a client has a bad internet connection, the client will gradually increase the jitterbuffer value to be prepared for future connection problems. Jitterbuffers will always add delay.\nThis issue here is about people suffering from very sporadic connection problems: Not specifiying a maximum results in huge delays, even if a client has just a very short connection issue.","author_login":"invokablegmbh","author_association":"NONE","created_at":"2022-09-22T03:52:28+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1254618889","fragment_type":"issue_comment","sequence":17,"text":"I can confirm that the problem occurs for users with packet loss. During a test meeting where it happened we checked the connection status and saw packet loss at the affected user.","author_login":"sonerd","author_association":"NONE","created_at":"2022-09-22T07:09:39+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1255327518","fragment_type":"issue_comment","sequence":18,"text":"We can confirm, that issues appeared directly after switching from 2.4 to 2.5.4. So we did a check on what changed and came across your jitterbuffer change. We reverted to 60:120 and the problem did not occur anymore. Thus, we had a look at the exact documentation and thought, that it might be a good idea to have the jitterbuffer increased to 100:250, so we are accepting a quarter of a second delay on bad connections. But we do not accept it to grow any further. In worst case this means that there will be crackling audio or some short interruptions. But it turned out that for the majority of the users the connection problems are very very short. So after the connection is OK again, there will be no big delay. This is more satisfying for the users.\n\nEdit: I at first wrote with my personal account. This is why I deleted my first message here.","author_login":"invokablegmbh","author_association":"NONE","created_at":"2022-09-22T17:23:14+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1273988000","fragment_type":"issue_comment","sequence":19,"text":"Hi, we also experienced the delay problem since we upgraded into 2.5.6. I hope URL will be included on 2.5.x soon.","author_login":"galupa","author_association":"NONE","created_at":"2022-10-11T01:58:35+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1284972654","fragment_type":"issue_comment","sequence":20,"text":"we also have massive problems with BBB 2.5 and audio delay getting worse and worse with seconds what makes it unusable...","author_login":"laserrapt0r","author_association":"NONE","created_at":"2022-10-20T05:47:43+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1269320628,"issue_number":15172,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1362382618","fragment_type":"issue_description","sequence":0,"text":"Suddenly video has too much delay with audio in the recording\n**Describe the bug**\nI'm facing a problem which I don't know the reason. In our today's session recording, I noticed the **video is too much out of sync** with the audio. Everything was alright in the live meeting (everything was in sync) but in the one-hour recording, video is more than 8 minutes behind! \nThere wasn't any problem before. It just appeared today. Nothing was changed in the server. \n\n**Notes:**\n- I thought it's related to #8815 but I've checked and the clock is correct (set with systemd-timesyncd with a near server)\n- Rebooting the server and restarting BBB didn't help\n- The problem seems to be with the video. It's too much early (Such that even the presenter says good-bye in the video and stops the recording, but the audio is correct). \n\n**To Reproduce**\nSteps to reproduce the behavior:\n1. Start a meeting and join with audio\n2. Turn on the camera and share your screen\n3. wait for a few minutes\n4. Start the recording\n5. Stop the recording, then end the meeting\n\n**Details**:\n\n$ sudo bbb-conf --check\n\nBigBlueButton Server 2.5.5 (3091)\n Kernel version: 5.4.0-125-generic\n Distribution: Ubuntu 20.04.5 LTS (64-bit)\n Memory: 12263 MB\n CPU cores: 8\n\n/etc/bigbluebutton/bbb-web.properties (override for bbb-web)\n/usr/share/bbb-web/WEB-INF/classes/bigbluebutton.properties (bbb-web)\n bigbluebutton.web.serverURL: URL \n defaultGuestPolicy: ALWAYS_ACCEPT\n svgImagesRequired: true\n defaultMeetingLayout: CUSTOM_LAYOUT\n\n/etc/nginx/sites-available/bigbluebutton (nginx)\n server_name: vhall.scischool.ir\n port: 80, [::]:80\n port: 443 ssl\n\n/opt/freeswitch/etc/freeswitch/vars.xml (FreeSWITCH)\n local_ip_v4: 130.185.75.197\n external_rtp_ip: 130.185.75.197\n external_sip_ip: 130.185.75.197\n\n/opt/freeswitch/etc/freeswitch/sip_profiles/external.xml (FreeSWITCH)\n ext-rtp-ip: $${local_ip_v4}\n ext-sip-ip: $${local_ip_v4}\n ws-binding: 130.185.75.197:5066\n wss-binding: 130.185.75.197:7443\n\n/usr/local/bigbluebutton/core/scripts/bigbluebutton.yml (record and playback)\n playback_host: vhall.scischool.ir\n playback_protocol: https\n ffmpeg: 4.2.7-0ubuntu0.1\n\n/usr/share/bigbluebutton/nginx/sip.nginx (sip.nginx)\n proxy_pass: 130.185.75.197\n protocol: http\n\n/usr/local/bigbluebutton/bbb-webrtc-sfu/config/default.yml (Kurento SFU)\n/etc/bigbluebutton/bbb-webrtc-sfu/production.yml (Kurento SFU - override)\n kurento.ip: 130.185.75.197\n kurento.url: ws://127.0.0.1:8888/kurento\n kurento.sip_ip: 130.185.75.197\n recordScreenSharing: true\n recordWebcams: true\n codec_video_main: VP8\n codec_video_content: VP8\n\n/usr/share/meteor/bundle/programs/server/assets/app/config/settings.yml (HTML5 client)\n/etc/bigbluebutton/bbb-html5.yml (HTML5 client config override)\n build: 2846\n kurentoUrl: wss://vhall.scischool.ir/bbb-webrtc-sfu\n enableListenOnly: true\n sipjsHackViaWs: true\n\n/usr/share/bbb-web/WEB-INF/classes/spring/turn-stun-servers.xml (STUN Server)\n stun: stun.l.google.com:19302\n\n# Potential problems described below","author_login":"mokazemi","author_association":"NONE","created_at":"2022-09-05T18:49:59+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1362382618,"issue_number":15644,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15644","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1237429470","fragment_type":"issue_comment","sequence":1,"text":"But since it was working properly till a few days ago, what is caused the problem?","author_login":"mokazemi","author_association":"NONE","created_at":"2022-09-05T20:08:22+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1362382618,"issue_number":15644,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15644","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1237434540","fragment_type":"issue_comment","sequence":2,"text":"hmm, missed \"til a few days ago\" part in the original description.\nStill might have to do with the PR I mentioned since some of the issues it tackles are intermittent by nature.","author_login":"prlanzarin","author_association":"MEMBER","created_at":"2022-09-05T20:17:17+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1362382618,"issue_number":15644,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15644","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1237746477","fragment_type":"issue_comment","sequence":3,"text":"It's an example of the problem:\n URL \n(Note that the recording starts when the timer is 7 seconds. and in the video, it's shown that I press the stop and it says the meeting is no longer being recorded, but since the video is too behind, It's even shown after that I end the meeting!)","author_login":"mokazemi","author_association":"NONE","created_at":"2022-09-06T07:11:40+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1362382618,"issue_number":15644,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15644","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1238443272","fragment_type":"issue_comment","sequence":4,"text":"I think I was able to reproduce this issue with BBB 2.6 demo server. Sounds to be a bug! @prlanzarin \n\nIt is the result: URL \n\n**steps:**\n - start the meeting\n - share your screen\n - wait for about a minute\n - start recording\n - after a little, stop the recording and close the room as fast as possible!","author_login":"mokazemi","author_association":"NONE","created_at":"2022-09-06T17:17:04+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1362382618,"issue_number":15644,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15644","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1241169018","fragment_type":"issue_comment","sequence":5,"text":"Had issues with 2.5.5 as well. Recording webcam and audio were extremely out of sync, and during the meeting everything seemed fine, mostly. For one test recording, for example, the webcam video stopped long before the audio did. Reverting to 2.5.4 was our solution.","author_login":"kurjajuur666","author_association":"NONE","created_at":"2022-09-08T19:57:02+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1362382618,"issue_number":15644,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15644","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1247526686","fragment_type":"issue_comment","sequence":6,"text":"I've got this issue too, on 2.5.5. Hour recording is about 2m50s out.\n@kurjajuur666 did you simply install 2.5.4 using the script, or use a fresh OS install?","author_login":"jarrodjay","author_association":"NONE","created_at":"2022-09-15T03:11:56+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1362382618,"issue_number":15644,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15644","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1248438100","fragment_type":"issue_comment","sequence":7,"text":"That's interesting and a good lead. Thanks for letting us known, I'll forward that internally.","author_login":"prlanzarin","author_association":"MEMBER","created_at":"2022-09-15T18:11:28+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1362382618,"issue_number":15644,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15644","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1249536040","fragment_type":"issue_comment","sequence":8,"text":"I'm taking a look at the changes in #15149 - I'll let you know if I can figure out the cause. The difference seems to be surprisingly larger.\n\n@mokazemi thanks for reproducing on the demo server - I'll be able to grab the data and logs from your meeting to help debug.\n\nOne of the changes made in #15149 was switching from using the \"movie\" filter input to read video files to using separate inputs to the ffmpeg command. My current theory is that a mistake was made in this conversion, and the seek point calculation is not being done correctly.","author_login":"kepstin","author_association":"CONTRIBUTOR","created_at":"2022-09-16T16:00:59+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1362382618,"issue_number":15644,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15644","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1249552884","fragment_type":"issue_comment","sequence":9,"text":"I have reprocessed the recording URL with the fix from #15702 manually applied on the test server. If you clear your browser cache and reload, you'll see that the correct portion of the screenshare video is now showing.","author_login":"kepstin","author_association":"CONTRIBUTOR","created_at":"2022-09-16T16:18:29+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1362382618,"issue_number":15644,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15644","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1250721641","fragment_type":"issue_comment","sequence":10,"text":"@kepstin, @mokazemi is the mentioned fix only for the building process of the recording or would it also fix the audio/video delay problem during the video conference? Since 2.5.5. we are facing delay problems during video conferences. Video is behind audio.","author_login":"sonerd","author_association":"NONE","created_at":"2022-09-19T08:30:58+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1362382618,"issue_number":15644,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15644","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1250792202","fragment_type":"issue_comment","sequence":11,"text":"If I'm not mistaken, BBB deletes raw files of the recordings after 14 days, but for recordings in the last two weeks, you can rebuilt them again after applying the fix. \nI don't have any ideas for recordings older than that (Maybe repairing by a video editing software to sync with audio)","author_login":"mokazemi","author_association":"NONE","created_at":"2022-09-19T09:36:18+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1362382618,"issue_number":15644,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15644","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1250797002","fragment_type":"issue_comment","sequence":12,"text":"yes rebuilt would work for recordings. The other problem we have is during video conferences. After one time the video and audio of a user is getting out of sync. There is a issue reported also here: URL \nMy hope was, that the above fix would be also the solution for the delay issue during meetings.","author_login":"sonerd","author_association":"NONE","created_at":"2022-09-19T09:41:28+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1362382618,"issue_number":15644,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15644","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1250885568","fragment_type":"issue_comment","sequence":13,"text":"We also had that problem but it didn't happen again after: \n- syncing the server time (Based on what discussed in #8815)\n- Setting these values to `60:120:20` instead of `120` (based ot a suggestion discussed in #15172 But I don't know how it's effective)","author_login":"mokazemi","author_association":"NONE","created_at":"2022-09-19T11:17:44+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1362382618,"issue_number":15644,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15644","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1251430382","fragment_type":"issue_comment","sequence":14,"text":"@mokazemi Would you be able to do some more testing on your end to see if the audio is out of sync before you make either of those two changes (server time or `60:120:20`, then make one of the changes, and test again. \n\nWe would be very interested if you can do a specific before/after comparison of making only those these changes.","author_login":"ffdixon","author_association":"MEMBER","created_at":"2022-09-19T19:07:32+08:00","repo_name":"bigbluebutton/bigbluebutton","issue_id":1362382618,"issue_number":15644,"issue_url":"https://github.com/bigbluebutton/bigbluebutton/issues/15644","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0336","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"[Bug/Support]: \"End of file during parsing\" error: how to see whole log, including commands?","query_context":"### Confirmation\n\n- [X] I have checked the documentation (README, Wiki, docstrings, etc)\n- [ ] I am checking these without reading them.\n- [X] I have searched previous issues to see if my question is a duplicate.\n\n### Elpaca Version\n\nElpaca 43ec2d8 grafted, HEAD -> master, origin/master, origin/HEAD\ninstaller: 0.7\nemacs-version: GNU Emacs 30.0.50 (build 1, x86_64-w64-mingw32)\n of 2024-04-08\ngit --version: git version 2.44.0.windows.1\n\n### Operating System\n\nWindows 11\n\n### Description\n\nI'm getting errors building a few packages. Not sure how to track them down because the log doesn't have the actual subprocess command executed to build:\n\nvertico [MELPA|GNU-devel ELPA]\nVERTical Interactive COmpletion\n\nsource: MELPA\nurl: URL \nmenu item recipe:\n( :package \"vertico\"\n :repo \"minad/vertico\"\n :files (:defaults \"extensions/vertico-*.el\")\n :fetcher github\n :source \"MELPA\")\nfull recipe:\n( :package \"vertico\" \n ;; Inherited from declaration.\n :files (:defaults \"extensions/*\")\n ;; Inherited from elpaca-order-functions.\n :depth 1\n :inherit t\n :protocol https\n ;; Inherited from elpaca-menu-item.\n :source \"MELPA\"\n :fetcher github\n :repo \"minad/vertico\")\ndependencies: \n emacs >= 27.1\n compat >= 29.1.4.4\ndependents: nil\ninstalled version: 1.8 1def56a\nstatuses:\n (failed autoloads linking unblocked ref-checked-out unthrottled blocked queue-throttled unthrottled blocked queue-throttled queued)\nfiles:\n $REPOS/vertico/extensions/vertico-buffer.el → $BUILDS/vertico/vertico-buffer.el\n $REPOS/vertico/extensions/vertico-directory.el → $BUILDS/vertico/vertico-directory.el\n $REPOS/vertico/extensions/vertico-flat.el → $BUILDS/vertico/vertico-flat.el\n $REPOS/vertico/extensions/vertico-grid.el → $BUILDS/vertico/vertico-grid.el\n $REPOS/vertico/extensions/vertico-indexed.el → $BUILDS/vertico/vertico-indexed.el\n $REPOS/vertico/extensions/vertico-mouse.el → $BUILDS/vertico/vertico-mouse.el\n $REPOS/vertico/extensions/vertico-multiform.el → $BUILDS/vertico/vertico-multiform.el\n $REPOS/vertico/extensions/vertico-quick.el → $BUILDS/vertico/vertico-quick.el\n $REPOS/vertico/extensions/vertico-repeat.el → $BUILDS/vertico/vertico-repeat.el\n $REPOS/vertico/extensions/vertico-reverse.el → $BUILDS/vertico/vertico-reverse.el\n $REPOS/vertico/extensions/vertico-suspend.el → $BUILDS/vertico/vertico-suspend.el\n $REPOS/vertico/extensions/vertico-unobtrusive.el → $BUILDS/vertico/vertico-unobtrusive.el\n $REPOS/vertico/vertico.el → $BUILDS/vertico/vertico.el\nlog:\n [2024-05-02 09:33:03] Package queued\n [2024-05-02 09:33:03] Continued by: elpaca--process\n [2024-05-02 09:33:03] elpaca-queue-limit exceeded\n [2024-05-02 09:33:03] Continued by: elpaca--finalize\n [2024-05-02 09:33:03] elpaca-queue-limit exceeded\n [2024-05-02 09:33:04] Continued by: elpaca--finalize\n [2024-05-02 09:33:04] Continued by: elpaca--configure-remotes\n [2024-05-02 09:33:04] Continued by: elpaca--checkout-ref\n [2024-05-02 09:33:04] Continued by: elpaca--dispatch-build-commands\n [2024-05-02 09:33:04] Continued by: elpaca--queue-dependencies\n [2024-05-02 09:33:04] No external dependencies\n [2024-05-02 09:33:04] Checking dependency versions\n [2024-05-02 09:33:04] Continued by: elpaca--check-version\n [2024-05-02 09:33:04] Linking build files\n [2024-05-02 09:33:04] Continued by: elpaca--link-build-files\n [2024-05-02 09:33:04] Build files linked\n [2024-05-02 09:33:04] Generating autoloads: c:/Users/garyo/AppData/Roaming/.config/emacs/elpaca/builds/vertico\n [2024-05-02 09:33:04] End of file during parsing\n [2024-05-02 09:33:04] Subprocess error (see previous log entries)\n\nI set `elpaca-verbosity` to 100 but don't see anything more in that log.","known_context_document_ids":["gh_issue_2275583763"],"reference_answer":"Thanks for taking the time to fill out a support ticket. \n \n \n \n \n \n \n \n \n \n \n\nYes. That does look like a circular dependency.\nI've squashed that bug several times, so perhaps there's a case I missed.\n \n \n\nMaybe they're related.\nYou can prevent the \"too many open file\" error by setting the `elpaca-queue-limit` option prior to processing any queues. e.g.\n\n emacs-lisp\n(setq elpaca-queue-limit 30)\n\nIf you search the issue tracker there are other Windows users who have hit this limit.\nI don't recall exactly where they ended up with that value, but I think it was closer to 12-20. Allegedly there are ways to allow more open file handles at the OS level, but I don't use Windows enough to give any advice on how to do it.\n\nI would try:\n\n1. saving `(setq elpaca-queue-limit 12)` in you init file just after the elpaca installer.\n2. `M-x restart-emacs`\n\nThen, in a fresh Emacs session, try another `elpaca-update-all` and see if the issue persists.","answer_document_id":"gh_comment_2090642074","silver_evidence_path":["gh_comment_2100897793","gh_issue_2275508432","gh_comment_2090642074"],"evidence_issue_ids":[2275583763,2275508432],"source_repo_name":"progfolio/elpaca","source_issue_id":2275583763,"source_issue_number":303,"source_issue_url":"https://github.com/progfolio/elpaca/issues/303","target_repo_name":"progfolio/elpaca","target_issue_id":2275508432,"target_issue_number":302,"target_issue_url":"https://github.com/progfolio/elpaca/issues/302","reference_anchor_document_id":"gh_comment_2100897793","reference_answer_author":"progfolio","reference_answer_author_association":"OWNER","quality_score":89.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1429,"anchor_target_overlap":0.0,"target_answer_overlap":0.1644},"issue_created_at":"2024-05-02T13:45:13+08:00","valid_comment_count":16,"fragments":[{"document_id":"gh_issue_2275583763","fragment_type":"issue_description","sequence":0,"text":"[Bug/Support]: \"End of file during parsing\" error: how to see whole log, including commands?\n### Confirmation\n\n- [X] I have checked the documentation (README, Wiki, docstrings, etc)\n- [ ] I am checking these without reading them.\n- [X] I have searched previous issues to see if my question is a duplicate.\n\n### Elpaca Version\n\nElpaca 43ec2d8 grafted, HEAD -> master, origin/master, origin/HEAD\ninstaller: 0.7\nemacs-version: GNU Emacs 30.0.50 (build 1, x86_64-w64-mingw32)\n of 2024-04-08\ngit --version: git version 2.44.0.windows.1\n\n### Operating System\n\nWindows 11\n\n### Description\n\nI'm getting errors building a few packages. Not sure how to track them down because the log doesn't have the actual subprocess command executed to build:\n\nvertico [MELPA|GNU-devel ELPA]\nVERTical Interactive COmpletion\n\nsource: MELPA\nurl: URL \nmenu item recipe:\n( :package \"vertico\"\n :repo \"minad/vertico\"\n :files (:defaults \"extensions/vertico-*.el\")\n :fetcher github\n :source \"MELPA\")\nfull recipe:\n( :package \"vertico\" \n ;; Inherited from declaration.\n :files (:defaults \"extensions/*\")\n ;; Inherited from elpaca-order-functions.\n :depth 1\n :inherit t\n :protocol https\n ;; Inherited from elpaca-menu-item.\n :source \"MELPA\"\n :fetcher github\n :repo \"minad/vertico\")\ndependencies: \n emacs >= 27.1\n compat >= 29.1.4.4\ndependents: nil\ninstalled version: 1.8 1def56a\nstatuses:\n (failed autoloads linking unblocked ref-checked-out unthrottled blocked queue-throttled unthrottled blocked queue-throttled queued)\nfiles:\n $REPOS/vertico/extensions/vertico-buffer.el → $BUILDS/vertico/vertico-buffer.el\n $REPOS/vertico/extensions/vertico-directory.el → $BUILDS/vertico/vertico-directory.el\n $REPOS/vertico/extensions/vertico-flat.el → $BUILDS/vertico/vertico-flat.el\n $REPOS/vertico/extensions/vertico-grid.el → $BUILDS/vertico/vertico-grid.el\n $REPOS/vertico/extensions/vertico-indexed.el → $BUILDS/vertico/vertico-indexed.el\n $REPOS/vertico/extensions/vertico-mouse.el → $BUILDS/vertico/vertico-mouse.el\n $REPOS/vertico/extensions/vertico-multiform.el → $BUILDS/vertico/vertico-multiform.el\n $REPOS/vertico/extensions/vertico-quick.el → $BUILDS/vertico/vertico-quick.el\n $REPOS/vertico/extensions/vertico-repeat.el → $BUILDS/vertico/vertico-repeat.el\n $REPOS/vertico/extensions/vertico-reverse.el → $BUILDS/vertico/vertico-reverse.el\n $REPOS/vertico/extensions/vertico-suspend.el → $BUILDS/vertico/vertico-suspend.el\n $REPOS/vertico/extensions/vertico-unobtrusive.el → $BUILDS/vertico/vertico-unobtrusive.el\n $REPOS/vertico/vertico.el → $BUILDS/vertico/vertico.el\nlog:\n [2024-05-02 09:33:03] Package queued\n [2024-05-02 09:33:03] Continued by: elpaca--process\n [2024-05-02 09:33:03] elpaca-queue-limit exceeded\n [2024-05-02 09:33:03] Continued by: elpaca--finalize\n [2024-05-02 09:33:03] elpaca-queue-limit exceeded\n [2024-05-02 09:33:04] Continued by: elpaca--finalize\n [2024-05-02 09:33:04] Continued by: elpaca--configure-remotes\n [2024-05-02 09:33:04] Continued by: elpaca--checkout-ref\n [2024-05-02 09:33:04] Continued by: elpaca--dispatch-build-commands\n [2024-05-02 09:33:04] Continued by: elpaca--queue-dependencies\n [2024-05-02 09:33:04] No external dependencies\n [2024-05-02 09:33:04] Checking dependency versions\n [2024-05-02 09:33:04] Continued by: elpaca--check-version\n [2024-05-02 09:33:04] Linking build files\n [2024-05-02 09:33:04] Continued by: elpaca--link-build-files\n [2024-05-02 09:33:04] Build files linked\n [2024-05-02 09:33:04] Generating autoloads: c:/Users/garyo/AppData/Roaming/.config/emacs/elpaca/builds/vertico\n [2024-05-02 09:33:04] End of file during parsing\n [2024-05-02 09:33:04] Subprocess error (see previous log entries)\n\nI set `elpaca-verbosity` to 100 but don't see anything more in that log.","author_login":"garyo","author_association":"NONE","created_at":"2024-05-02T13:45:13+08:00","repo_name":"progfolio/elpaca","issue_id":2275583763,"issue_number":303,"issue_url":"https://github.com/progfolio/elpaca/issues/303","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2090572968","fragment_type":"issue_comment","sequence":1,"text":"I wonder if it could be related to this error regarding `generated-autoload-file` being redefined as dynamic?\n\n% emacs --batch --eval '(let ((generated-autoload-file \"autoloads.el\")) (update-directory-autoloads \"builds/vertico\n\"))'\n\nError: error (\"Defining as dynamic an already lexical var\" generated-autoload-file)\n (defvar generated-autoload-file nil \"File into which to write autoload definitions.\\nA Lisp file can set this in its local variables section to make\\nits autoloads go somewhere else.\\n\\nIf this is a relative file name, the directory is determined as\\nfollows:\\n - If a Lisp file defined `generated-autoload-file' as a\\n file-local variable, use its containing directory.\\n - Otherwise use the \\\"lisp\\\" subdirectory of `source-directory'.\\n\\nThe autoload file is assumed to contain a trailer starting with a\\nFormFeed character.\")\n require(loaddefs-gen)\n byte-code(\"\\300\\301!\\210\\300\\302!\\210\\300\\303!\\210\\300\\304!\\207\" [require lisp-mode lisp-mnt cl-lib loaddefs-gen] 2)\n (update-directory-autoloads \"builds/vertico\")\n (let ((generated-autoload-file \"autoloads.el\")) (update-directory-autoloads \"builds/vertico\"))\n eval((let ((generated-autoload-file \"autoloads.el\")) (update-directory-autoloads \"builds/vertico\")) t)\n command-line-1((\"--eval\" \"(let ((generated-autoload-file \\\"autoloads.el\\\")) (update-directory-autoloads \\\"builds/vertico\\\"))\"))\n command-line()\n normal-top-level()\nDefining as dynamic an already lexical var: generated-autoload-file\n\nwhereas this version without the `let` binding works for me:\n\n% emacs --batch --eval '(progn (setq generated-autoload-file \"autoloads.el\") (update-directory-autoloads \"builds/ve\nrtico\"))'\nPackage autoload is deprecated\n INFO Scraping files for autoloads.el...\n INFO Scraping files for autoloads.el...done\n\nIt looks to me like elpaca's `elpaca-generate-autoloads` uses the let-binding method, so maybe that's causing it but the error is suppressed, or it could be something else. Note that I am using a bleeding-edge emacs built from source.","author_login":"garyo","author_association":"NONE","created_at":"2024-05-02T14:00:00+08:00","repo_name":"progfolio/elpaca","issue_id":2275583763,"issue_number":303,"issue_url":"https://github.com/progfolio/elpaca/issues/303","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2091521261","fragment_type":"issue_comment","sequence":2,"text":"I'm not 100% certain but doing this in my shell after the first elpaca pass with all the autoload failures seems to help:\n\ngaryo@tower1 (~/.config/emacs/elpaca/builds [main]) 4:38PM 4200=>\n% for d in *(/); do emacs --batch --eval \"(loaddefs-generate \\\"$d\\\" \\\"$d/$d-autoloads.el\\\")\"; done\n INFO Scraping files for loaddefs...\n INFO Scraping files for loaddefs...done\n INFO Scraping files for loaddefs...\n INFO Scraping files for loaddefs...done\n...\n\nthen I restart emacs and things seem to go better.","author_login":"garyo","author_association":"NONE","created_at":"2024-05-02T20:43:35+08:00","repo_name":"progfolio/elpaca","issue_id":2275583763,"issue_number":303,"issue_url":"https://github.com/progfolio/elpaca/issues/303","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2091972142","fragment_type":"issue_comment","sequence":3,"text":"Sorry about that.\nThe entry is logged just after the process is kicked off.\nIn this case, the error beats the log to the punch.\nThat should be fixed on the master branch now.\n \n\nDo you get the same error with a very simple configuration using `elpaca-test`?\n\nHow to run this test?\n\nemacs-lisp\n(elpaca-test\n :init (elpaca (vertico :wait t))\n (elpaca-test-log \"#unique\"))\n\n \n \n \n\nYes, it should be defvar'd in elpaca.el.\n \n \n \n \n \n \n \n \n \n \n\nThat may or may not work. When a package's build-dir is already on disk, Elpaca takes an optimistic path to reduce startup time. In that case only `elpaca--pre-built-steps` are run.\nSo it may just be skipping the issue. You could try a different operation like ` lpaca-rebuild`, which should attempt to regenerate the autoloads, after a restart to see if you hit the same error.","author_login":"progfolio","author_association":"OWNER","created_at":"2024-05-03T00:59:46+08:00","repo_name":"progfolio/elpaca","issue_id":2275583763,"issue_number":303,"issue_url":"https://github.com/progfolio/elpaca/issues/303","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2092998569","fragment_type":"issue_comment","sequence":4,"text":"In this case, the error beats the log to the punch.\nThat should be fixed on the master branch now.\n\nHmm, no difference in the logs with elpaca 06ee3a6. Just \"End of file during parsing\" after \"Generating autoloads\".\n \n\nWow, I love your test harness!!! Here's the results:\n\n \n Test Case \n\nHow to run this test?\n\nemacs-lisp\n(elpaca-test\n :init (elpaca (vertico :wait t))\n (elpaca-test-log \"#unique\"))\n\n \n Host Env \n\n \n elpaca 06ee3a6 grafted, HEAD -> master, origin/master, origin/HEAD \n installer 0.7 \n emacs GNU Emacs 30.0.50 (build 1, x86_64-w64-mingw32) of 2024-04-08 \n git git version 2.44.0.windows.1 \n \n \n\n Output \n\nemacs-lisp\n\nError: end-of-file nil\n\n command-line-1((\"--eval\" \"(setq debug-on-error t after-init-time nil)\" \"--eval\" \"(setq user-emacs-directory \\\"d:/tmp/elpaca.K94MA9) --eval (run-hooks\" \"'before-init-hook) -l ./init.el --eval (setq\" \"after-init-time\" \"(current-time)) --eval (run-hooks\" \"'after-init-hook) --eval (run-hooks\" \"'emacs-startup-hook) --eval (message\" \"\\n\" \"Test\" \"Env\\n) --eval (elpaca-version\" \"'message)\"))\n\n command-line()\n\n normal-top-level()\n\nEnd of file during parsing\n\n \n\nFrom that output, I can see there's a missing escaped close-quote after the tmpdir. But I don't think it's getting to the point of trying to install vertico (or any of the other packages that fail -- about 50 fail for me, so it's not about the package itself). Also note this only happens on Windows. Maybe it's a path thing due to something like the \"d:/\" drive name?\n\nThe command seems to be OK (properly quoted) in `elpaca-test--make-process` :\n\n(\"d:/emacs/emacs/bin/emacs\" \"--debug-init\" \"--batch\" \"-Q\" #1=\"--eval\" \"(setq debug-on-error t after-init-time nil)\" #1# \"(setq user-emacs-directory \\\"d:/tmp/elpaca.iShFzl\\\")\" \"--eval\" \"(run-hooks 'before-init-hook)\" \"-l\" \"./init.el\" \"--eval\" \"(setq after-init-time (current-time))\" \"--eval\" \"(run-hooks 'after-init-hook)\" \"--eval\" \"(run-hooks 'emacs-startup-hook)\" \"--eval\" \"(message \\\"\\n Test Env\\n\\\")\" \"--eval\" \"(elpaca-version 'message)\")\n\nso I don't yet see where the trailing quote in the tmpdir is getting stripped off. (If that is indeed the problem.)","author_login":"garyo","author_association":"NONE","created_at":"2024-05-03T13:15:28+08:00","repo_name":"progfolio/elpaca","issue_id":2275583763,"issue_number":303,"issue_url":"https://github.com/progfolio/elpaca/issues/303","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2093908242","fragment_type":"issue_comment","sequence":5,"text":"Ah, it was actually being over-written in the log due to me not accounting for DOS/Linux line ending differences in `elpaca--process-filter`. Should be fixed (for real this time) on master. I'm seeing the commands in the log in my Win10 VM now.\n \n \n \n\nThank you. It's been very handy for working out bugs.\n \n \n \n \n \n \n \n \n \n\nInteresting! Indeed, I get the same error in my VM. I'm not sure what's causing that, but at least we've gotten to what seems like the root of the issue.\n \n\nHere's my hypothesis:\nWindows file-path separator is being interpreted as an escape character \"\\\" in the printed command.\nIt escapes the closing quote for that string.\nThat seems to make sense with what we're observing.","author_login":"progfolio","author_association":"OWNER","created_at":"2024-05-04T00:18:53+08:00","repo_name":"progfolio/elpaca","issue_id":2275583763,"issue_number":303,"issue_url":"https://github.com/progfolio/elpaca/issues/303","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2093929997","fragment_type":"issue_comment","sequence":6,"text":"Here's a test independent of Elpaca:\n\nemacs-lisp\n(make-process\n :name \"*test*\"\n :filter (lambda (process output) (message \"%S\" output))\n :sentinel (lambda (process event) (message \"%S\" event))\n :command (list (elpaca--emacs-path)\n \"--batch\" \"--eval\" (format \"(print %S)\" user-emacs-directory)))\n\nOn my Linux machine I get:\n\n# \n\"\n\\\"~/.emacs.d/\\\"\n\"\n\"finished\n\"\n\nOn Windows I get the error we're seeing.\nSo it's either a bug with how Emacs handles command line args,\nor perhaps there's a better way to format the command string.\nI'll try reporting upstream tomorrow and see if anyone has any insight.","author_login":"progfolio","author_association":"OWNER","created_at":"2024-05-04T00:58:32+08:00","repo_name":"progfolio/elpaca","issue_id":2275583763,"issue_number":303,"issue_url":"https://github.com/progfolio/elpaca/issues/303","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2094531315","fragment_type":"issue_comment","sequence":7,"text":"Noting this here:\n\n URL \n \n \n \n \n \n \n \n\nI noticed you've changed default-process-coding-system in your config.\nHowever, I still get the same error with `emacs -q` on Windows.\nStill unsure whether this is Elpaca's or Emacs's bug.","author_login":"progfolio","author_association":"OWNER","created_at":"2024-05-05T01:02:28+08:00","repo_name":"progfolio/elpaca","issue_id":2275583763,"issue_number":303,"issue_url":"https://github.com/progfolio/elpaca/issues/303","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2095021303","fragment_type":"issue_comment","sequence":8,"text":"Apologies, must've not been running the test in the instance I thought I was last night.\nWith `emacs -q` I no longer get the error.","author_login":"progfolio","author_association":"OWNER","created_at":"2024-05-06T00:35:12+08:00","repo_name":"progfolio/elpaca","issue_id":2275583763,"issue_number":303,"issue_url":"https://github.com/progfolio/elpaca/issues/303","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2100644597","fragment_type":"issue_comment","sequence":9,"text":"I concur, your non-elpaca test works for me with `emacs -Q`. I tried setting `(setq default-process-coding-system '(utf-8-unix . utf-8-unix))` before running the test in `emacs -Q` and it still succeeds.\n\nThere is some very hairy quoting code in emacs's `w32proc.c` but at the moment I can't debug into that.","author_login":"garyo","author_association":"NONE","created_at":"2024-05-08T13:59:10+08:00","repo_name":"progfolio/elpaca","issue_id":2275583763,"issue_number":303,"issue_url":"https://github.com/progfolio/elpaca/issues/303","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2100764798","fragment_type":"issue_comment","sequence":10,"text":"Good idea. I'll try and isolate a minimal reproduction case.\n \n \n\nOnce we have a solid reproduction case, if I'm confident it's not something on Elpaca's end, I'll open a bug report upstream.\nEli uses Windows, so he may have some knowledge of the inner workings there.\n \n \n \n \n \n\nGood catch and sorry about that!\nI refactored `elpaca-info` to make it easier to use in tests, and as you've noticed, missed that call site in `elpaca-ui-info`.\nShould be fixed on master now.\n \n\nYou can add the \"#verbosity\" search tag to your search query to temporarily set `elpaca-verbosity` to a maximum in the log buffer.\nThe `elpaca-info` buffer should normally display the whole log, too.\n \n\nI recently refactored `elpaca-log` to make it easier to use from lisp programs as well.\nThe following should write the full log to a file: \n\n emacs-lisp\n(with-temp-buffer \n (insert (elpaca-log \".*\"))\n (write-file \"/tmp/test.log\"))","author_login":"progfolio","author_association":"OWNER","created_at":"2024-05-08T14:48:36+08:00","repo_name":"progfolio/elpaca","issue_id":2275583763,"issue_number":303,"issue_url":"https://github.com/progfolio/elpaca/issues/303","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2100806319","fragment_type":"issue_comment","sequence":11,"text":"I seem to have a fix for this issue! Since forever (maybe 15 or 20 years anyway), I've had this in my init file: `(setq w32-quote-process-args ?\\\")`\nIf I remove that, my elpaca setup runs to completion. \nI have no idea why I had to have that, all those years ago; I expect the default value of `t` is fine.\nI also can't explain why you *can* repro it, unless you have the same setting.","author_login":"garyo","author_association":"NONE","created_at":"2024-05-08T15:08:16+08:00","repo_name":"progfolio/elpaca","issue_id":2275583763,"issue_number":303,"issue_url":"https://github.com/progfolio/elpaca/issues/303","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2100842689","fragment_type":"issue_comment","sequence":12,"text":"Aha! I figured it might've been a user option.\n \n\nI was running your config on Windows :).","author_login":"progfolio","author_association":"OWNER","created_at":"2024-05-08T15:26:57+08:00","repo_name":"progfolio/elpaca","issue_id":2275583763,"issue_number":303,"issue_url":"https://github.com/progfolio/elpaca/issues/303","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2100897793","fragment_type":"issue_comment","sequence":13,"text":"Thank you!\nLet me know if that also takes care of URL for you.","author_login":"progfolio","author_association":"OWNER","created_at":"2024-05-08T15:55:19+08:00","repo_name":"progfolio/elpaca","issue_id":2275583763,"issue_number":303,"issue_url":"https://github.com/progfolio/elpaca/issues/303","linked_issue_ids":[2275508432],"is_known_query_context":false},{"document_id":"gh_issue_2275508432","fragment_type":"issue_description","sequence":0,"text":"[Bug/Support]: git-commit blocked on magit, and magit blocked on git-commit: circular dep?\n### Confirmation\n\n- [X] I have checked the documentation (README, Wiki, docstrings, etc)\n- [ ] I am checking these without reading them.\n- [X] I have searched previous issues to see if my question is a duplicate.\n\n### Elpaca Version\n\nElpaca 43ec2d8 grafted, HEAD -> master, origin/master, origin/HEAD\ninstaller: 0.7\nemacs-version: GNU Emacs 30.0.50 (build 1, x86_64-w64-mingw32)\n of 2024-04-08\ngit --version: git version 2.44.0.windows.1\n\n### Operating System\n\nWindows 11\n\n### Description\n\nDoing `elpaca-update-all` on my Windows machine, with recent Emacs 30 and latest elpaca, I have what seems like a circular dependency that prevents elpaca from finishing: magit depends on git-commit, and git-commit is inside the magit repo so is blocked on magit. I'm not sure how to proceed.\n\ngit-commit blocked Waiting for mono-repo magit 27.152611\nmagit-section blocked Waiting for mono-repo magit 27.152635\nmagit blocked Blocked by: (git-commit) \n\n(I'm also having unrelated issues with \"too many open files\" errors, still working on those, but wanted to report this one.)","author_login":"garyo","author_association":"NONE","created_at":"2024-05-02T13:11:09+08:00","repo_name":"progfolio/elpaca","issue_id":2275508432,"issue_number":302,"issue_url":"https://github.com/progfolio/elpaca/issues/302","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2090642074","fragment_type":"issue_comment","sequence":1,"text":"Thanks for taking the time to fill out a support ticket. \n \n \n \n \n \n \n \n \n \n \n\nYes. That does look like a circular dependency.\nI've squashed that bug several times, so perhaps there's a case I missed.\n \n \n\nMaybe they're related.\nYou can prevent the \"too many open file\" error by setting the `elpaca-queue-limit` option prior to processing any queues. e.g.\n\n emacs-lisp\n(setq elpaca-queue-limit 30)\n\nIf you search the issue tracker there are other Windows users who have hit this limit.\nI don't recall exactly where they ended up with that value, but I think it was closer to 12-20. Allegedly there are ways to allow more open file handles at the OS level, but I don't use Windows enough to give any advice on how to do it.\n\nI would try:\n\n1. saving `(setq elpaca-queue-limit 12)` in you init file just after the elpaca installer.\n2. `M-x restart-emacs`\n\nThen, in a fresh Emacs session, try another `elpaca-update-all` and see if the issue persists.","author_login":"progfolio","author_association":"OWNER","created_at":"2024-05-02T14:32:01+08:00","repo_name":"progfolio/elpaca","issue_id":2275508432,"issue_number":302,"issue_url":"https://github.com/progfolio/elpaca/issues/302","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2100949552","fragment_type":"issue_comment","sequence":2,"text":"This specific issue seems to be gone now since I applied a user fix (see #303) but I'm still getting an issue with transient; magit-commit requires a very recent version of transient (>=20240421) but elpaca doesn't install that, so the magit-commit install fails.\nThe log is:\n\ngit-commit [MELPA|NonGNU-devel ELPA]\nEdit Git commit messages.\n\nsource: MELPA\nurl: URL \nmenu item recipe:\n( :package \"git-commit\"\n :fetcher github\n :repo \"magit/magit\"\n :files (\"lisp/git-commit.el\" \"lisp/git-commit-pkg.el\")\n :old-names (git-commit-mode)\n :source \"MELPA\")\nfull recipe:\n( :package \"git-commit\" \n ;; Inherited from elpaca-order-functions.\n :depth 1\n :inherit t\n :protocol https\n ;; Inherited from elpaca-menu-item.\n :source \"MELPA\"\n :old-names (git-commit-mode)\n :files (\"lisp/git-commit.el\" \"lisp/git-commit-pkg.el\")\n :repo \"magit/magit\"\n :fetcher github)\ndependencies:\n emacs >= 26.1\n compat >= 29.1.4.5\n transient >= 20240421\n with-editor >= 20240415\ndependents: \n magit\ninstalled version: 3.3.0.50-git f7cba11\nstatuses:\n (failed unblocked blocked continued-dep queued)\nfiles:\n $REPOS/magit/lisp/git-commit-pkg.el ! $BUILDS/git-commit/git-commit-pkg.el\n $REPOS/magit/lisp/git-commit.el ! $BUILDS/git-commit/git-commit.el\nlog:\n [2024-05-08 12:20:41] Package queued\n [2024-05-08 12:20:41] Continued by: elpaca--continue-dependency\n [2024-05-08 12:20:41] Continued by: elpaca--dispatch-build-commands\n [2024-05-08 12:20:41] Queueing Dependencies\n [2024-05-08 12:20:44] Continued by: elpaca--check-status\n [2024-05-08 12:20:44] Unblocked by: with-editor\n [2024-05-08 12:20:44] Checking dependency versions\n [2024-05-08 12:20:44] transient installed version (20240408) lower than min required 20240421\n [2024-05-08 12:20:44] Continued by: elpaca--check-version\n\nIf I do `(use-package transient)` before `(use-package magit)` it works, but I don't think I should need to do that -- maybe it's due to the older version of transient being built-in, so elpaca doesn't want to silently override it on my behalf?","author_login":"garyo","author_association":"NONE","created_at":"2024-05-08T16:24:27+08:00","repo_name":"progfolio/elpaca","issue_id":2275508432,"issue_number":302,"issue_url":"https://github.com/progfolio/elpaca/issues/302","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2101377616","fragment_type":"issue_comment","sequence":3,"text":"Glad to hear it.\n \n\nYou're correct. Currently, Elpaca will not install a built-in package unless you explicitly request it.\nThere's a feature request for automatically updating built-in packages and some previous discussion here: URL \n \n\nWhat's specifically happening in this situation is:\n\ngit-commit requires transient with a \"YYYYMMDD\" timestamp version (which MELPA introduced, and very few package authors use to declare dependencies).\nSince transient is built-in, we have no reliable way of getting the exact date it was last modified.\nElpaca's compromise is to maintain an alist of Emacs release dates for stable versions and fall back to `emacs-build-time` for unstable versions when available.\nThat value is stored in `elpaca-core-date` which is used as the timestamp version for any built-in package.\nMy hunch is that your `elpaca-core-date` is \"20240408\" considering:\n\nemacs-version: GNU Emacs 30.0.50 (build 1, x86_64-w64-mingw32) of 2024-04-08\n\nRebuilding Emacs should bump that value and transient will pass the version check.\nIt's also possible to work around the issue by lying to Elpaca about the version date (via the `:version` recipe keyword), or disabling the check altogether, but that may lead to breakage.","author_login":"progfolio","author_association":"OWNER","created_at":"2024-05-08T20:33:15+08:00","repo_name":"progfolio/elpaca","issue_id":2275508432,"issue_number":302,"issue_url":"https://github.com/progfolio/elpaca/issues/302","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0338","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Evaluate data quality when saving and loading feather and parquet files?","query_context":"Evaluate add difference in resulting loaded dataframe when using to read_csv and to_csv versus comparable feather and parquet functions:\n\n- URL \n- URL \n- URL \n- URL \n\nThis can be tested with these CSV files: \n\n- URL \n- URL \n- URL \n-","known_context_document_ids":["gh_issue_3054485107"],"reference_answer":"#332 was accepted and closed with a caveat. Please see final comment with implementation notes and testing instructions.","answer_document_id":"gh_comment_2905988271","silver_evidence_path":["gh_comment_2905987388","gh_issue_3054482249","gh_comment_2905988271"],"evidence_issue_ids":[3054485107,3054482249],"source_repo_name":"openpolicedata/openpolicedata","source_issue_id":3054485107,"source_issue_number":332,"source_issue_url":"https://github.com/openpolicedata/openpolicedata/issues/332","target_repo_name":"openpolicedata/openpolicedata","target_issue_id":3054482249,"target_issue_number":330,"target_issue_url":"https://github.com/openpolicedata/openpolicedata/issues/330","reference_anchor_document_id":"gh_comment_2905987388","reference_answer_author":"sowdm","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2857,"anchor_target_overlap":0.2456,"target_answer_overlap":0.1818},"issue_created_at":"2025-05-10T19:34:33+08:00","valid_comment_count":4,"fragments":[{"document_id":"gh_issue_3054485107","fragment_type":"issue_description","sequence":0,"text":"Evaluate data quality when saving and loading feather and parquet files\nEvaluate add difference in resulting loaded dataframe when using to read_csv and to_csv versus comparable feather and parquet functions:\n\n- URL \n- URL \n- URL \n- URL \n\nThis can be tested with these CSV files: \n\n- URL \n- URL \n- URL \n-","author_login":"sowdm","author_association":"COLLABORATOR","created_at":"2025-05-10T19:34:33+08:00","repo_name":"openpolicedata/openpolicedata","issue_id":3054485107,"issue_number":332,"issue_url":"https://github.com/openpolicedata/openpolicedata/issues/332","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2899413212","fragment_type":"issue_comment","sequence":1,"text":"import os\nimport pandas as pd\nimport pyarrow as pa\n\nimport openpolicedata as opd\n\ndatasets = [('State Patrol', 'Arizona', 'STOPS', 'MULTIPLE'),\n ('New York City', 'New York', 'PEDESTRIAN STOPS', 2014),\n ('Chandler', 'Arizona', 'CALLS FOR SERVICE', 'MULTIPLE')]\n\nfor sname, state, tbl, year in datasets:\n src = opd.Source(sname, state)\n\n t = src.load(tbl, year)\n\n df = t.table\n\n df.to_feather('out.feather')\n df_comp = pd.read_feather('out.feather')\n os.remove('out.feather')\n\n assert df.equals(df_comp)\n\n df.to_parquet('out.parquet')\n df_comp = pd.read_parquet('out.parquet')\n os.remove('out.parquet')\n\n assert df.equals(df_comp)","author_login":"sowdm","author_association":"COLLABORATOR","created_at":"2025-05-21T22:31:28+08:00","repo_name":"openpolicedata/openpolicedata","issue_id":3054485107,"issue_number":332,"issue_url":"https://github.com/openpolicedata/openpolicedata/issues/332","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2899416813","fragment_type":"issue_comment","sequence":2,"text":"The above code gives the following error:\n\nException has occurred: ArrowTypeError\n(\"Expected bytes, got a 'int' object\", 'Conversion failed for column perstop with type object')\n File \"C:\\Users\\matth\\repos\\openpolicedata\\opddev\\test_feather_parquet_accuracy.py\", line 17, in \n df.to_feather('out.feather')\n ~~~~~~~~~~~~~^^^^^^^^^^^^^^^\npyarrow.lib.ArrowTypeError: (\"Expected bytes, got a 'int' object\", 'Conversion failed for column perstop with type object')\n\nIt is due to a column with mixed data types of strings and integers. This type of thing is common in some datasets where the data quality is imperfect. \n\nHowever, we could catch the error and notify the user what the issues is and direct them to use CSV file output instead","author_login":"sowdm","author_association":"COLLABORATOR","created_at":"2025-05-21T22:33:39+08:00","repo_name":"openpolicedata/openpolicedata","issue_id":3054485107,"issue_number":332,"issue_url":"https://github.com/openpolicedata/openpolicedata/issues/332","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2905987388","fragment_type":"issue_comment","sequence":3,"text":"The quality of the data when reading out and in with feather/parquet has no issues.\n\nThere are challenges when writing data that to_csv can deal with.\n\nThere are issues if there are columns with mixed data types. A known reason that mixed data types occur is that we don't use the low_memory=False option in calls to pd.read_csv in csv_class.py. This results in dtypes being processed and set in chunks for efficiency but occasionally, at the cost of having a columns that has both numeric and string values. In these cases, if low_memory=False, those same columns would have been read in as strings instead of strings and numbers. I recommend the following to handle this case:\n- Include a mixed input that defaults to False\n- If mixed is False, function fails if mixed dtypes exist\n- If mixed is True, function finds all mixed dtype columns and converts them to strings prior to writing the data out\n\nAnother issue occurs when there are unknown characters (or bytes) in the data. Pandas to_csv has a errors=\"surrogateescape\" option that handles these values. This input is used in to_csv in data.py. to_feather and to_parquet don't have this options. I recommend catching the unicode errors and displaying a message instructing that they will need to use to_csv.\n\nTesting only 3 datasets was sufficient to find the 2 above issues. There could be other issues. I'm going to close this issue and recommend continuation of #330 with the caveat that many more datasets should be run through the final candidate version of the data prior to acceptance into the code.\n\nimport os\nimport pandas as pd\nimport pyarrow as pa\nimport re\n\nimport openpolicedata as opd\n\ndatasets = [('New York City', 'New York', 'PEDESTRIAN STOPS', 2014),\n ('State Patrol', 'Arizona', 'STOPS', 'MULTIPLE'), \n ('Chandler', 'Arizona', 'CALLS FOR SERVICE', 'MULTIPLE')]\n\nfor sname, state, tbl, year in datasets:\n print(f'Running {sname}')\n src = opd.Source(sname, state)\n\n t = src.load(tbl, year)\n\n df = t.table\n\n try:\n df.to_feather('out.feather')\n except pa.lib.ArrowTypeError as e:\n print(f\"Converting mixed types: {sname}\")\n # pyarrow can't handle mixed data types. Convert columns to str so they will save\n mixed_dtypes = {c: dtype for c in df.columns if (dtype := pd.api.types.infer_dtype(df[c])).startswith(\"mixed\")}\n assert [x=='mixed-integer' for x in mixed_dtypes.values()]\n\n for c in mixed_dtypes.keys():\n df[c] = df[c].apply(str)\n\n df.to_feather('out.feather')\n except UnicodeEncodeError:\n print('Failure due to unicode error. Advise csv usage')\n continue\n\n df_comp = pd.read_feather('out.feather')\n os.remove('out.feather')\n\n assert df.equals(df_comp)\n\n df.to_parquet('out.parquet')\n df_comp = pd.read_parquet('out.parquet')\n os.remove('out.parquet')\n\n assert df.equals(df_comp)","author_login":"sowdm","author_association":"COLLABORATOR","created_at":"2025-05-23T22:59:00+08:00","repo_name":"openpolicedata/openpolicedata","issue_id":3054485107,"issue_number":332,"issue_url":"https://github.com/openpolicedata/openpolicedata/issues/332","linked_issue_ids":[3054482249],"is_known_query_context":false},{"document_id":"gh_issue_3054482249","fragment_type":"issue_description","sequence":0,"text":"Explore using alternatives to CSV files for import and export of data from local file system\nThis is the parent task of several sub-tasks to evaluate and potentially implement this feature. If interested in taking on this issue, please request to be assigned to a sub-task.\n\nIn `data.py`, OPD provides `load_from_csv` and `to_csv` capabilities for loading and storing files locally. Feather and parquet files may be more efficient for storing dataframes (See here).\n\nThis task involves evaluating alternatives and if there are no issues found, implement comparable functions to `load_from_csv` and `to_csv` for the new file types.","author_login":"sowdm","author_association":"COLLABORATOR","created_at":"2025-05-10T19:27:24+08:00","repo_name":"openpolicedata/openpolicedata","issue_id":3054482249,"issue_number":330,"issue_url":"https://github.com/openpolicedata/openpolicedata/issues/330","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2905988271","fragment_type":"issue_comment","sequence":1,"text":"#332 was accepted and closed with a caveat. Please see final comment with implementation notes and testing instructions.","author_login":"sowdm","author_association":"COLLABORATOR","created_at":"2025-05-23T23:00:13+08:00","repo_name":"openpolicedata/openpolicedata","issue_id":3054482249,"issue_number":330,"issue_url":"https://github.com/openpolicedata/openpolicedata/issues/330","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0341","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"dart_plugin_registrant.dart + AOT + --obfuscation?","query_context":"### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n- [X] I have read the guide to filing a bug\n\n### Steps to reproduce\n\nManually build AOT components where you can control use of the --obfuscate flag.\n\nBuild sequences:\n URL \n URL \n\n### Expected results\n\ncorrectly register plugins regardless of obfuscate flag\n\n### Actual results\n\nwithout passing --obfuscate to `gen_snapshot`:\n* Flutter Package examples - correctly register plugins\n* Gallery - does not register plugins\n* Wonderous - does not register plugins\n\npassing --obfuscate to `gen_snapshot`:\n* Flutter Package examples - correctly register plugins\n* Gallery - correctly register plugins\n* Wonderous - correctly register plugins\n\nDumping symbols from AOT in both cases using readelf, the expected entry points are present:\n\nworking\n\n 11673: 000000000059914c 116 FUNC LOCAL DEFAULT 7 _PluginRegistrant.register\n 11674: 00000000005991c0 44 FUNC LOCAL DEFAULT 7 _PluginRegistrant.register\n 11675: 00000000005991ec 8 FUNC LOCAL DEFAULT 7 dartPluginRegistrantLibrary\n 11676: 00000000005991f4 8 FUNC LOCAL DEFAULT 7 dartPluginRegistrantLibrary\n 11677: 00000000005991fc 48 FUNC LOCAL DEFAULT 7 main\n\nnot working\n\n131825: 0000000001e991e0 8 FUNC LOCAL DEFAULT 7 dartPluginRegistrantLibrary\n131826: 0000000001e991e8 8 FUNC LOCAL DEFAULT 7 dartPluginRegistrantLibrary\n131827: 0000000001e991f0 320 FUNC LOCAL DEFAULT 7 _PluginRegistrant.register\n131828: 0000000001e99330 44 FUNC LOCAL DEFAULT 7 _PluginRegistrant.register\n131829: 0000000001e9935c 96 FUNC LOCAL DEFAULT 7 main\n131830: 0000000001e993bc 44 FUNC LOCAL DEFAULT 7 main\n\n### Code sample\n\nNA\n\n### Screenshots or Video\n\nNA\n\n### Logs\n\nNA\n\n### Flutter Doctor output\n\n Doctor output \n\nconsole\n[!] Flutter (Channel [user-branch], 3.13.9, on Fedora Linux 38 (Workstation Edition) 6.5.8-200.fc38.x86_64, locale en_US.UTF-8)\n ! Flutter version 3.13.9 on channel [user-branch] at /mnt/raid10/workspace-automation/flutter\n Currently on an unknown channel. Run `flutter channel` to switch to an official channel.\n If that doesn't fix the issue, reinstall Flutter by following instructions at URL \n ! Upstream repository unknown source is not a standard remote.\n Set environment variable \"FLUTTER_GIT_URL\" to unknown source to dismiss this error.\n • Framework revision d211f42860 (12 days ago), 2023-10-25 13:42:25 -0700\n • Engine revision 0545f8705d\n • Dart version 3.1.5\n • DevTools version 2.25.0\n • If those were intentional, you can disregard the above warnings; however it is recommended to use \"git\" directly to perform update checks and upgrades.\n\n[✓] Linux toolchain - develop for Linux desktop\n • clang version 16.0.6 (Fedora 16.0.6-3.fc38)\n • cmake version 3.27.7\n • ninja version 1.11.1\n • pkg-config version 1.8.0\n\n[✓] VS Code (version 1.84.1)\n • VS Code at /usr/share/code\n • Flutter extension version 3.76.0\n\n[✓] Connected device (2 available)\n • Linux (desktop) • linux • linux-x64 • Fedora Linux 38 (Workstation Edition) 6.5.8-200.fc38.x86_64\n • Toyota homescreen (mobile) • desktop-homescreen • linux-x64 • homescreen x86_64\n\n[✓] Network resources\n • All expected network resources are available.\n\n! Doctor found issues in 1 category.\nList of custom devices in \"/mnt/raid10/workspace-automation/.config/flutter/custom_devices.json\":\n id: desktop-homescreen, label: Toyota homescreen, enabled: true\n[joel@air workspace-automation]$ flutter doctor\nDoctor summary (to see all details, run flutter doctor -v):\n[!] Flutter (Channel [user-branch], 3.13.9, on Fedora Linux 38 (Workstation Edition) 6.5.8-200.fc38.x86_64, locale en_US.UTF-8)\n ! Flutter version 3.13.9 on channel [user-branch] at /mnt/raid10/workspace-automation/flutter\n Currently on an unknown channel. Run `flutter channel` to switch to an official channel.\n If that doesn't fix the issue, reinstall Flutter by following instructions at URL \n ! Upstream repository unknown source is not a standard remote.\n Set environment variable \"FLUTTER_GIT_URL\" to unknown source to dismiss this error.\n[✓] Linux toolchain - develop for Linux desktop\n[✓] VS Code (version 1.84.1)\n[✓] Connected device (2 available)\n[✓] Network resources\n\n! Doctor found issues in 1 category.","known_context_document_ids":["gh_issue_1980262763"],"reference_answer":"@jwinarske Thanks for filing the bug. For the record, @stuartmorgan is the TL for this area of the code so he's the one who should make the final call on this.\n\nIt sounds like there's an ambiguity in your request. We support several Linux-based platforms, for example Android and GTK. Plugins for different platforms are quite different (for example, plugins on Android are typically in Java, whereas on GTK they are in C!).\n\nThe core problem, I think, is that we don't yet have extensible logic in the tool so that you can easily add new platforms. We should definitely work on that. URL is where we're tracking that issue. You can discuss this in #hackers-tool on our Discord. As a heavy user of a custom embedding, you may be interested in getting involved in this work; we haven't really started on it in earnest yet but it is an area we are very interested in.","answer_document_id":"gh_comment_1189394597","silver_evidence_path":["gh_comment_1809369517","gh_issue_1306642461","gh_comment_1189394597"],"evidence_issue_ids":[1980262763,1306642461],"source_repo_name":"flutter/flutter","source_issue_id":1980262763,"source_issue_number":137972,"source_issue_url":"https://github.com/flutter/flutter/issues/137972","target_repo_name":"flutter/flutter","target_issue_id":1306642461,"target_issue_number":107762,"target_issue_url":"https://github.com/flutter/flutter/issues/107762","reference_anchor_document_id":"gh_comment_1809369517","reference_answer_author":"Hixie","reference_answer_author_association":"MEMBER","quality_score":95.17,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3333,"anchor_target_overlap":0.1667,"target_answer_overlap":0.0833},"issue_created_at":"2023-11-06T23:30:21+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_1980262763","fragment_type":"issue_description","sequence":0,"text":"dart_plugin_registrant.dart + AOT + --obfuscation\n### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n- [X] I have read the guide to filing a bug\n\n### Steps to reproduce\n\nManually build AOT components where you can control use of the --obfuscate flag.\n\nBuild sequences:\n URL \n URL \n\n### Expected results\n\ncorrectly register plugins regardless of obfuscate flag\n\n### Actual results\n\nwithout passing --obfuscate to `gen_snapshot`:\n* Flutter Package examples - correctly register plugins\n* Gallery - does not register plugins\n* Wonderous - does not register plugins\n\npassing --obfuscate to `gen_snapshot`:\n* Flutter Package examples - correctly register plugins\n* Gallery - correctly register plugins\n* Wonderous - correctly register plugins\n\nDumping symbols from AOT in both cases using readelf, the expected entry points are present:\n\nworking\n\n 11673: 000000000059914c 116 FUNC LOCAL DEFAULT 7 _PluginRegistrant.register\n 11674: 00000000005991c0 44 FUNC LOCAL DEFAULT 7 _PluginRegistrant.register\n 11675: 00000000005991ec 8 FUNC LOCAL DEFAULT 7 dartPluginRegistrantLibrary\n 11676: 00000000005991f4 8 FUNC LOCAL DEFAULT 7 dartPluginRegistrantLibrary\n 11677: 00000000005991fc 48 FUNC LOCAL DEFAULT 7 main\n\nnot working\n\n131825: 0000000001e991e0 8 FUNC LOCAL DEFAULT 7 dartPluginRegistrantLibrary\n131826: 0000000001e991e8 8 FUNC LOCAL DEFAULT 7 dartPluginRegistrantLibrary\n131827: 0000000001e991f0 320 FUNC LOCAL DEFAULT 7 _PluginRegistrant.register\n131828: 0000000001e99330 44 FUNC LOCAL DEFAULT 7 _PluginRegistrant.register\n131829: 0000000001e9935c 96 FUNC LOCAL DEFAULT 7 main\n131830: 0000000001e993bc 44 FUNC LOCAL DEFAULT 7 main\n\n### Code sample\n\nNA\n\n### Screenshots or Video\n\nNA\n\n### Logs\n\nNA\n\n### Flutter Doctor output\n\n Doctor output \n\nconsole\n[!] Flutter (Channel [user-branch], 3.13.9, on Fedora Linux 38 (Workstation Edition) 6.5.8-200.fc38.x86_64, locale en_US.UTF-8)\n ! Flutter version 3.13.9 on channel [user-branch] at /mnt/raid10/workspace-automation/flutter\n Currently on an unknown channel. Run `flutter channel` to switch to an official channel.\n If that doesn't fix the issue, reinstall Flutter by following instructions at URL \n ! Upstream repository unknown source is not a standard remote.\n Set environment variable \"FLUTTER_GIT_URL\" to unknown source to dismiss this error.\n • Framework revision d211f42860 (12 days ago), 2023-10-25 13:42:25 -0700\n • Engine revision 0545f8705d\n • Dart version 3.1.5\n • DevTools version 2.25.0\n • If those were intentional, you can disregard the above warnings; however it is recommended to use \"git\" directly to perform update checks and upgrades.\n\n[✓] Linux toolchain - develop for Linux desktop\n • clang version 16.0.6 (Fedora 16.0.6-3.fc38)\n • cmake version 3.27.7\n • ninja version 1.11.1\n • pkg-config version 1.8.0\n\n[✓] VS Code (version 1.84.1)\n • VS Code at /usr/share/code\n • Flutter extension version 3.76.0\n\n[✓] Connected device (2 available)\n • Linux (desktop) • linux • linux-x64 • Fedora Linux 38 (Workstation Edition) 6.5.8-200.fc38.x86_64\n • Toyota homescreen (mobile) • desktop-homescreen • linux-x64 • homescreen x86_64\n\n[✓] Network resources\n • All expected network resources are available.\n\n! Doctor found issues in 1 category.\nList of custom devices in \"/mnt/raid10/workspace-automation/.config/flutter/custom_devices.json\":\n id: desktop-homescreen, label: Toyota homescreen, enabled: true\n[joel@air workspace-automation]$ flutter doctor\nDoctor summary (to see all details, run flutter doctor -v):\n[!] Flutter (Channel [user-branch], 3.13.9, on Fedora Linux 38 (Workstation Edition) 6.5.8-200.fc38.x86_64, locale en_US.UTF-8)\n ! Flutter version 3.13.9 on channel [user-branch] at /mnt/raid10/workspace-automation/flutter\n Currently on an unknown channel. Run `flutter channel` to switch to an official channel.\n If that doesn't fix the issue, reinstall Flutter by following instructions at URL \n ! Upstream repository unknown source is not a standard remote.\n Set environment variable \"FLUTTER_GIT_URL\" to unknown source to dismiss this error.\n[✓] Linux toolchain - develop for Linux desktop\n[✓] VS Code (version 1.84.1)\n[✓] Connected device (2 available)\n[✓] Network resources\n\n! Doctor found issues in 1 category.","author_login":"jwinarske","author_association":"NONE","created_at":"2023-11-06T23:30:21+08:00","repo_name":"flutter/flutter","issue_id":1980262763,"issue_number":137972,"issue_url":"https://github.com/flutter/flutter/issues/137972","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1798037369","fragment_type":"issue_comment","sequence":1,"text":"Just to confirm: are you saying that if you pass `--obfuscate` to `gen_snapshot` then thing work _correctly_ and if you do **not** pass `--obfuscate` then things work _incorrectly_? I am a bit puzzled.","author_login":"mraleph","author_association":"MEMBER","created_at":"2023-11-07T08:35:16+08:00","repo_name":"flutter/flutter","issue_id":1980262763,"issue_number":137972,"issue_url":"https://github.com/flutter/flutter/issues/137972","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1798572057","fragment_type":"issue_comment","sequence":2,"text":"@mraleph \n\nCorrect. It's as if in the non-working case it's taking an alternate entry. Non-working cases default to platform channel.\n\nThe other pattern I determined is the working cases are all \"local\" packages. The non-working case use \"remote\" packages.\n\nNot sure if Android and iOS default to having obfuscation set. If so that might explain why it's now showing up.\n\nThere was another issue a while back about obfuscation breaking dart registration I was looking at. Which introduced the --source solution.","author_login":"jwinarske","author_association":"NONE","created_at":"2023-11-07T13:57:33+08:00","repo_name":"flutter/flutter","issue_id":1980262763,"issue_number":137972,"issue_url":"https://github.com/flutter/flutter/issues/137972","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1809184696","fragment_type":"issue_comment","sequence":3,"text":"@jwinarske , would it be possible for you to make actual repro out of URL for example? This should help understand better where in the stack there is obfuscate vs non-obfuscate confusion.\n\ncc'ing @stuartmorgan since it seems to be in plugins/packages realm.","author_login":"aam","author_association":"MEMBER","created_at":"2023-11-13T21:50:16+08:00","repo_name":"flutter/flutter","issue_id":1980262763,"issue_number":137972,"issue_url":"https://github.com/flutter/flutter/issues/137972","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1809369517","fragment_type":"issue_comment","sequence":4,"text":"It is unclear to me what the expected outcome of this issue is given that URL and URL both explained that what this issue lists under \"expected results\" is in fact a bug that we intend to fix.\n\nAs far as I can tell this is a duplicate of URL","author_login":"stuartmorgan","author_association":"CONTRIBUTOR","created_at":"2023-11-14T00:53:27+08:00","repo_name":"flutter/flutter","issue_id":1980262763,"issue_number":137972,"issue_url":"https://github.com/flutter/flutter/issues/137972","linked_issue_ids":[1306642461],"is_known_query_context":false},{"document_id":"gh_comment_1809619283","fragment_type":"issue_comment","sequence":5,"text":"@stuartmorgan this is a new issue. Which in everything I've read should not behave this way. There is also another issue that drove the --source option; where dart plugin registrant was ignored only when obfuscated was set. Which indicated this might be a leftover corner case. Cross compiling an AOT by script or manually on a host machine is a valid use case. Dart pluginn registrant (vm entry) works today if I enable obsfucation when dealing with \"remote package\" definitions. In all cases of \"local packages\" plug-in references work with or without obfuscation.","author_login":"jwinarske","author_association":"NONE","created_at":"2023-11-14T06:30:11+08:00","repo_name":"flutter/flutter","issue_id":1980262763,"issue_number":137972,"issue_url":"https://github.com/flutter/flutter/issues/137972","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1810014416","fragment_type":"issue_comment","sequence":6,"text":"It would be helpful if you could add more detail to the STR then. Right now the STR section is just links to a script that appear to be part of a build process rather than actual steps, so I was trying to extrapolate from that, and it appeared that you were describing a situation where—when building for a third-party embedding—the `flutter`-tool-generated first-party registrant code is sometimes being run and sometimes not (which in the important respects would be the same as URL","author_login":"stuartmorgan","author_association":"CONTRIBUTOR","created_at":"2023-11-14T11:17:55+08:00","repo_name":"flutter/flutter","issue_id":1980262763,"issue_number":137972,"issue_url":"https://github.com/flutter/flutter/issues/137972","linked_issue_ids":[1306642461],"is_known_query_context":false},{"document_id":"gh_comment_1810580032","fragment_type":"issue_comment","sequence":7,"text":"I understand that the exact details of what you are saying is different between the case where the registration runs and the case where it doesn't are different. That's why I said it would be the same \"in the important respects\".\n\nI'm still not clear whether my understanding of the issue described in my last comment is correct or not. Please provide actual *steps* to reproduce the issue so that it's clear what the scenario is here.","author_login":"stuartmorgan","author_association":"CONTRIBUTOR","created_at":"2023-11-14T16:14:14+08:00","repo_name":"flutter/flutter","issue_id":1980262763,"issue_number":137972,"issue_url":"https://github.com/flutter/flutter/issues/137972","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1306642461","fragment_type":"issue_description","sequence":0,"text":"Linux AOT via `flutter build bundle`\nBuilding an application on a Linux machine using `flutter build bundle` is problematic.\n\n1) The debug build will register and run the Linux Dart code. Stuart Morgan has stated this is definitely a bug. I'm building the bundle on Linux why would it not include Linux platform specific code?\n2) Using the built bundle to create an AOT will drop the Linux Dart code, and the Linux specific Dart code is not executed.\n\nWhen running `flutter build bundle` on a Linux machine (platform type is literally Linux), why would it not include the Linux specific Dart code?\n\nGiven `flutter build linux` is currently not capable of cross compiling, one cannot run `flutter build linux` and use the libapp.so (it's host only).\n\nThis is impacting developers targeting AGL Flutter. We (AGL/Toyota) want support for Linux specific Dart when using `flutter build bundle` for both Debug images and AOT images.\n\nWe want `flutter build bundle` and AOT generation to build/run the Linux specific Dart code regardless of the native CMake stuff.\n\n@Hixie @timsneath @cmc5788","author_login":"jwinarske","author_association":"NONE","created_at":"2022-07-16T00:16:14+08:00","repo_name":"flutter/flutter","issue_id":1306642461,"issue_number":107762,"issue_url":"https://github.com/flutter/flutter/issues/107762","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1186140754","fragment_type":"issue_comment","sequence":1,"text":"I have answered this at length in both URL and our discussion in Discord. Capturing the core bit from the latter:\n \n\nContinuing to conflate \"Linux-specific Dart\" and \"Flutter-1P-Linux-embedding-specific Dart\" isn't constructive.\n \n\nThat support already exists; you can write Linux-specific Dart using `Platform.isLinux` checks.\n\nIf what you want is the ability to auto-generate Dart plugin registration code for your custom embedding, as I've said before we're happy to review designs for such a system, as part of the custom embedding hook support in the tool.\n\nWhat you are specifically requesting here though, which is for your embedding to get Flutter-1P-Linux-embedding-specific Dart, is a wontfix.","author_login":"stuartmorgan","author_association":"CONTRIBUTOR","created_at":"2022-07-16T10:08:43+08:00","repo_name":"flutter/flutter","issue_id":1306642461,"issue_number":107762,"issue_url":"https://github.com/flutter/flutter/issues/107762","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1189394597","fragment_type":"issue_comment","sequence":2,"text":"@jwinarske Thanks for filing the bug. For the record, @stuartmorgan is the TL for this area of the code so he's the one who should make the final call on this.\n\nIt sounds like there's an ambiguity in your request. We support several Linux-based platforms, for example Android and GTK. Plugins for different platforms are quite different (for example, plugins on Android are typically in Java, whereas on GTK they are in C!).\n\nThe core problem, I think, is that we don't yet have extensible logic in the tool so that you can easily add new platforms. We should definitely work on that. URL is where we're tracking that issue. You can discuss this in #hackers-tool on our Discord. As a heavy user of a custom embedding, you may be interested in getting involved in this work; we haven't really started on it in earnest yet but it is an area we are very interested in.","author_login":"Hixie","author_association":"MEMBER","created_at":"2022-07-19T18:03:10+08:00","repo_name":"flutter/flutter","issue_id":1306642461,"issue_number":107762,"issue_url":"https://github.com/flutter/flutter/issues/107762","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1194819075","fragment_type":"issue_comment","sequence":3,"text":"@Hixie Thanks for the constructive response, I'll look into the referenced issue and Discord channel.","author_login":"jwinarske","author_association":"NONE","created_at":"2022-07-26T00:31:36+08:00","repo_name":"flutter/flutter","issue_id":1306642461,"issue_number":107762,"issue_url":"https://github.com/flutter/flutter/issues/107762","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1793449664","fragment_type":"issue_comment","sequence":4,"text":"Just a heads up. This was a tooling issue. Resolved in my AOT generation sequence:\n URL \n\nWhat I did uncover in my investigation to resolving this was that some apps worked fine with gen_snapshot obfuscation disabled, some did not. The Flutter Package examples worked, while Gallery and Wonders did not. Enabling obfuscation enabled Gallery and Wonders to work as expected. I raised this on the hacker-tools discord channel.","author_login":"jwinarske","author_association":"NONE","created_at":"2023-11-04T13:51:01+08:00","repo_name":"flutter/flutter","issue_id":1306642461,"issue_number":107762,"issue_url":"https://github.com/flutter/flutter/issues/107762","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0345","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"General questions?","query_context":"Hi Soroosh, \n\nSorry I've got some more general questions about OCSmesh and didn't know the best way to contact you. I hope this is okay.\n\nIs there any functionality in OCSmesh to allow a review of the CFL number, to ensure the grid won't create numerical diffusion?\n\nCheers,\n\nTom","known_context_document_ids":["gh_issue_1364463217"],"reference_answer":"@TPCollings, I was wondering if you had the chance to test the updates? If not, I can merge them to the `main` branch and you can just test it there whenever you get the chance to.","answer_document_id":"gh_comment_1265671004","silver_evidence_path":["gh_comment_1252918981","gh_issue_1366594020","gh_comment_1265671004"],"evidence_issue_ids":[1364463217,1366594020],"source_repo_name":"noaa-ocs-modeling/OCSMesh","source_issue_id":1364463217,"source_issue_number":24,"source_issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/24","target_repo_name":"noaa-ocs-modeling/OCSMesh","target_issue_id":1366594020,"target_issue_number":25,"target_issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/25","reference_anchor_document_id":"gh_comment_1252918981","reference_answer_author":"SorooshMani-NOAA","reference_answer_author_association":"COLLABORATOR","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1111,"target_answer_overlap":0.0},"issue_created_at":"2022-09-07T10:43:15+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_1364463217","fragment_type":"issue_description","sequence":0,"text":"General questions\nHi Soroosh, \n\nSorry I've got some more general questions about OCSmesh and didn't know the best way to contact you. I hope this is okay.\n\nIs there any functionality in OCSmesh to allow a review of the CFL number, to ensure the grid won't create numerical diffusion?\n\nCheers,\n\nTom","author_login":"TPCollings","author_association":"NONE","created_at":"2022-09-07T10:43:15+08:00","repo_name":"noaa-ocs-modeling/OCSMesh","issue_id":1364463217,"issue_number":24,"issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/24","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1239353709","fragment_type":"issue_comment","sequence":1,"text":"Hi Tom, right now such a capability does **not** exist. However, I'd like to add new functionalities (where possible) based on the need. \n\nOCSMesh uses `Jigasw`'s Python wrapper as the meshing engine, and as far as I know `Jigsaw` doesn't accept custom error function. So the best way I can think of to add this functionality is to fiddle with the size function. A method can be added to the `hfun` objects to make sure the specified size is within a given bound or criteria. Right now size constraint based on the topobathy exists; it shouldn't be too hard to add one that gets a reference velocity and timestep to constraint based on CFL as well. For example depending on the model being implicit or explicit you'd do something like:\n\npython\nhfun = ...\nhfun.add_contours(...)\n...\nhfun.add_cfl_constraint(cfl_upper=1 , cfl_lower=-np.inf, ref_vel=10, ref_dt=150, rate=0.1)\n...\n\nwhich means *after* applying all refinements, it will check the specified sizes and if it falls outside the specified CFL bounds it will modify it and for regions adjacent to the adjusted location it will propagate based on the distance from the adjusted location.\n\nDo you have a specific way of achieving the CFL check in mind? Is what I described above useful for your use case?","author_login":"SorooshMani-NOAA","author_association":"COLLABORATOR","created_at":"2022-09-07T12:55:54+08:00","repo_name":"noaa-ocs-modeling/OCSMesh","issue_id":1364463217,"issue_number":24,"issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/24","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1239610314","fragment_type":"issue_comment","sequence":2,"text":"Hi Soroosh, thanks for your quick response. \n\nThat's a good suggestion you've made. I wonder how dependent it would be on the reference velocity and dt values that are chosen. \n\nHaving read the documentation of OceanMesh2d, they deal with the CFL number not by changing the grid size, but by suggesting the timestep for the model run using the minimum current number. This could potentially be an easier solution to changing the mesh itself?\n\nThey also also estimate u as a function of sea surface elevation and depth (|u| = ssh/sqrt(g/h)), taking ssh as 2m which is probably suitable for most regions. I've included an image of the documentation as they describe it better than I can . \n\nHaving some form of CFL check would be extremely useful. I'm looking to generate meshes over large basins, so manually estimating the CFL number for selected points isn't really feasible. \n\nimage","author_login":"TPCollings","author_association":"NONE","created_at":"2022-09-07T16:19:59+08:00","repo_name":"noaa-ocs-modeling/OCSMesh","issue_id":1364463217,"issue_number":24,"issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/24","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1239691722","fragment_type":"issue_comment","sequence":3,"text":"@TPCollings, I think it really depends on what solver you're using and how you want to set it up; for example for implicit solvers we might actually have to be careful for Courant number to remain above 1. In either case, one either has to choose what their Courant number is and what time step they'd like to use, then find the mesh size from it; or already have the mesh size and Courant number and would like to know what time step is suitable.\n\n- For the first functionality it makes sense to have a method that manipulates the *size function* - as described in this comment - where it gets input η or velocity reference as well as dt and the bound on Courant number.\n- For the second functionality it is more sensible to add a method to *mesh* object. So that when you already have a mesh, pass in the bounds on Courant number and get an estimate for dt.\n\n@WPringle I haven't really worked with OceanMesh2D, can you please comment on this? Does what I'm saying make sense based on your experience?","author_login":"SorooshMani-NOAA","author_association":"COLLABORATOR","created_at":"2022-09-07T17:41:13+08:00","repo_name":"noaa-ocs-modeling/OCSMesh","issue_id":1364463217,"issue_number":24,"issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/24","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1240404243","fragment_type":"issue_comment","sequence":4,"text":"@SorooshMani-NOAA Yeah I see your point. I'll be using Schism (more specifically PySchism), so I believe the minimum Courant number shouldn't be less than 0.4 for most modelling applications. How long do you think it might take to add the first functionality described above, which involves manipulating the size function?","author_login":"TPCollings","author_association":"NONE","created_at":"2022-09-08T08:35:23+08:00","repo_name":"noaa-ocs-modeling/OCSMesh","issue_id":1364463217,"issue_number":24,"issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/24","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1240853710","fragment_type":"issue_comment","sequence":5,"text":"Yes there are two ways to do it, both we try to do in OM2D. First is try to manipulate the size function beforehand estimating what the Courant number would be based on size function and depth there and what timestep you want to use. Second way is to post-process the mesh based on final Courant number by deleting or adding in new points and locally remeshing. We did add the second for SCHISM type meshes where we want to provide a lower bound on Courant number, and so therefore we try to add in more points, as well as deleting points to make the upper bound on Courant number which is usually more important for ADCIRC.","author_login":"WPringle","author_association":"NONE","created_at":"2022-09-08T15:11:34+08:00","repo_name":"noaa-ocs-modeling/OCSMesh","issue_id":1364463217,"issue_number":24,"issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/24","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1240926259","fragment_type":"issue_comment","sequence":6,"text":"@SorooshMani-NOAA That would be great thanks. There's no super urgency, but it would be great to have it before the end of the month. Cheers!","author_login":"TPCollings","author_association":"NONE","created_at":"2022-09-08T16:09:34+08:00","repo_name":"noaa-ocs-modeling/OCSMesh","issue_id":1364463217,"issue_number":24,"issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/24","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1249406769","fragment_type":"issue_comment","sequence":7,"text":"@WPringle, I have a technical question. Why is the Courant number calculation in the referenced text from OceanMesh2D calculated with an additional $\\sqrt{g H}$? Is this some kind of *corrected* Courant number for shallow water equation?","author_login":"SorooshMani-NOAA","author_association":"COLLABORATOR","created_at":"2022-09-16T14:04:47+08:00","repo_name":"noaa-ocs-modeling/OCSMesh","issue_id":1364463217,"issue_number":24,"issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/24","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1249465596","fragment_type":"issue_comment","sequence":8,"text":"Yes. Courant number can be calculated from the characteristic velocity: |u| + sqrt(gh). Here, u is the particle velocity which is unknown but from linear wave theory can be approximated as H*sqrt(g/h), where H is wave height. Now here we just assume wave height of 1 m, but that this could be different. However, generally have found this restriction to work pretty well. Now overland we use a 1 m minimum depth (h). In doing so we have 1*sqrt(g/h) = sqrt(gh) = sqrt(g), i.e., a Froude number (=u/sqrt(gh)) of 1 is the restriction. Perhaps a Froude number of two could be a more conservative restriction for overland flow in which case setting H=2 would work well.","author_login":"WPringle","author_association":"NONE","created_at":"2022-09-16T14:50:23+08:00","repo_name":"noaa-ocs-modeling/OCSMesh","issue_id":1364463217,"issue_number":24,"issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/24","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1252918981","fragment_type":"issue_comment","sequence":9,"text":"I'll close this ticket since the other two created (#25 & #26) are going to cover what was discussed here","author_login":"SorooshMani-NOAA","author_association":"COLLABORATOR","created_at":"2022-09-20T21:12:51+08:00","repo_name":"noaa-ocs-modeling/OCSMesh","issue_id":1364463217,"issue_number":24,"issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/24","linked_issue_ids":[1366594020],"is_known_query_context":false},{"document_id":"gh_issue_1366594020","fragment_type":"issue_description","sequence":0,"text":"Add CFL constraint for size function\nRelated to requests in #24. \n\nExamples:\n\npython\nhfun = ...\nhfun.add_contours(...)\n...\nhfun.add_cfl_constraint(cfl_upper=1 , cfl_lower=-np.inf, ref_vel=10, ref_dt=150, rate=0.1)\n...\n\n \n\nwhere instead of `ref_vel` one can use the estimates discussed in the issue referenced at the top","author_login":"SorooshMani-NOAA","author_association":"COLLABORATOR","created_at":"2022-09-08T15:46:41+08:00","repo_name":"noaa-ocs-modeling/OCSMesh","issue_id":1366594020,"issue_number":25,"issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/25","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1252791419","fragment_type":"issue_comment","sequence":1,"text":"@TPCollings, can you please get the `feature/cflconstraint` branch and test the newly added functionality? I added some basic tests, but I didn't really test it on a large model. Please let me know if you see any issues so that I can fix before merging. Thanks!\nPlease see: URL and URL for the new methods. Also you can look at the tests added at URL","author_login":"SorooshMani-NOAA","author_association":"COLLABORATOR","created_at":"2022-09-20T19:07:29+08:00","repo_name":"noaa-ocs-modeling/OCSMesh","issue_id":1366594020,"issue_number":25,"issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/25","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1252814188","fragment_type":"issue_comment","sequence":2,"text":"@WPringle if you have time at some point can you please take a look at the functions implemented here to see if everything seems right for CFL constraint:\n URL","author_login":"SorooshMani-NOAA","author_association":"COLLABORATOR","created_at":"2022-09-20T19:32:11+08:00","repo_name":"noaa-ocs-modeling/OCSMesh","issue_id":1366594020,"issue_number":25,"issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/25","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1254609751","fragment_type":"issue_comment","sequence":3,"text":"Hi @SorooshMani-NOAA, I've got a workshop till friday and am away till Wednesday next week but will do it by the end of next week if that's okay? Thanks again for your help.\n\nCheers,\n\nTom","author_login":"TPCollings","author_association":"NONE","created_at":"2022-09-22T06:59:15+08:00","repo_name":"noaa-ocs-modeling/OCSMesh","issue_id":1366594020,"issue_number":25,"issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/25","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1254964451","fragment_type":"issue_comment","sequence":4,"text":"Hi @TPCollings, there's no rush for merge, please take your time :)","author_login":"SorooshMani-NOAA","author_association":"COLLABORATOR","created_at":"2022-09-22T12:38:04+08:00","repo_name":"noaa-ocs-modeling/OCSMesh","issue_id":1366594020,"issue_number":25,"issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/25","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1265671004","fragment_type":"issue_comment","sequence":5,"text":"@TPCollings, I was wondering if you had the chance to test the updates? If not, I can merge them to the `main` branch and you can just test it there whenever you get the chance to.","author_login":"SorooshMani-NOAA","author_association":"COLLABORATOR","created_at":"2022-10-03T15:50:41+08:00","repo_name":"noaa-ocs-modeling/OCSMesh","issue_id":1366594020,"issue_number":25,"issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/25","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1265729876","fragment_type":"issue_comment","sequence":6,"text":"Hi Soroosh,\n\nSorry I still haven't had a chance to test this! Yeah probably best to\nmerge it and I can let you know if there's an issue. Cheers\n---------------------------------------------------------------\n*Thomas Collings* | *Fathom™*\nDeveloper | www.fathom.global | @fathom_global\n \nwrote:","author_login":"TPCollings","author_association":"NONE","created_at":"2022-10-03T16:37:13+08:00","repo_name":"noaa-ocs-modeling/OCSMesh","issue_id":1366594020,"issue_number":25,"issue_url":"https://github.com/noaa-ocs-modeling/OCSMesh/issues/25","linked_issue_ids":[1366594020],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0347","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"[Critical] Attackers may craft invalid domain bundle/execution receipt with excessive fraud proof size, making it impossible to submit a fraud proof on consensus chain?","query_context":"# Issue description\n\nWhen a bundle/execution receipt with an invalid execution result is constructed, someone will have to generate a fraud proof for it and submit it by dispatching a `submit_fraud_proof` call on the consensus chain. For the case of an invalid extrinsic execution result, the fraud proof will be of type `InvalidStateTransitionProof` and this fraud proof will contain one or two storage proofs (`InvalidStateTransitionProof.proof` and `InvalidStateTransitionProof.execution_phase.ApplyExtrinsic.extrinsic_proof`).\n\nIf the failing extrinsic is doing a lot of storage access, this will lead to large storage proofs, possibly to an extent where the fraud proof exceeds the consensus chain `MAX_BLOCK_LENGTH = 5 MiB`. If this is the case, honest domain operators may know that the block is invalid but they can never successfully dispatch a `submit_fraud_proof` for it.\n\nIn order to limit the amount of storage changes, the 2D weight system should be used with an appropriate limit for the `proof_size` weight in order to ensure that it is always possible to submit a fraud proof when needed. As of now the `MAXIMUM_BLOCK_WEIGHT` is configured to `Weight::from_parts(u64::MAX, u64::MAX)`, so there is effectively no limit at all.\n\n# Risk\n\nIf an invalid bundle/execution receipt cannot be discarded via a fraud proof due to this, it will eventually be considered final. If the storage root after executing the invalid bundle contains outgoing transfer messages minting SSC out of thin air, these transfers will be accepted by the consensus chain or sibling domains, effectively allowing an attacker to mint arbitrary amounts of SSC.\n\n# Mitigation suggestion\n\nUse an appropriate limit for the `proof_size` weight (with some safety margin to the consensus chain block length) to ensure that it is always possible to submit a fraud proof for an invalid bundle. Extra care needs to be taken to ensure that no calls can lead to a proof size larger than the predicted value from the weight calculation since this may directly lead to a situation where an invalid execution receipt is accepted since nobody can submit a fraud proof for it.","known_context_document_ids":["gh_issue_2088725488"],"reference_answer":"There's also #2365. Can we have bundle limit in domain config instead of block limit? Especially since domain block limit is not enforced.\nSo in domain config we would have `target_bundles_per_slot` (1 or less, or more) and `max_bundle_weight`. Then the average domain block weight would be `target_bundles_per_slot * max_bundle_weight/SLOT_PROBABILITY` and each domain should have hardware requirements to be able to achieve that.","answer_document_id":"gh_comment_2023964506","silver_evidence_path":["gh_comment_2135123497","gh_issue_2065778987","gh_comment_2023964506"],"evidence_issue_ids":[2088725488,2065778987],"source_repo_name":"autonomys/subspace","source_issue_id":2088725488,"source_issue_number":2425,"source_issue_url":"https://github.com/autonomys/subspace/issues/2425","target_repo_name":"subspace/subspace","target_issue_id":2065778987,"target_issue_number":2387,"target_issue_url":"https://github.com/subspace/subspace/issues/2387","reference_anchor_document_id":"gh_comment_2135123497","reference_answer_author":"dariolina","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.274,"anchor_target_overlap":0.2727,"target_answer_overlap":0.3182},"issue_created_at":"2024-01-18T17:13:07+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_2088725488","fragment_type":"issue_description","sequence":0,"text":"[Critical] Attackers may craft invalid domain bundle/execution receipt with excessive fraud proof size, making it impossible to submit a fraud proof on consensus chain\n# Issue description\n\nWhen a bundle/execution receipt with an invalid execution result is constructed, someone will have to generate a fraud proof for it and submit it by dispatching a `submit_fraud_proof` call on the consensus chain. For the case of an invalid extrinsic execution result, the fraud proof will be of type `InvalidStateTransitionProof` and this fraud proof will contain one or two storage proofs (`InvalidStateTransitionProof.proof` and `InvalidStateTransitionProof.execution_phase.ApplyExtrinsic.extrinsic_proof`).\n\nIf the failing extrinsic is doing a lot of storage access, this will lead to large storage proofs, possibly to an extent where the fraud proof exceeds the consensus chain `MAX_BLOCK_LENGTH = 5 MiB`. If this is the case, honest domain operators may know that the block is invalid but they can never successfully dispatch a `submit_fraud_proof` for it.\n\nIn order to limit the amount of storage changes, the 2D weight system should be used with an appropriate limit for the `proof_size` weight in order to ensure that it is always possible to submit a fraud proof when needed. As of now the `MAXIMUM_BLOCK_WEIGHT` is configured to `Weight::from_parts(u64::MAX, u64::MAX)`, so there is effectively no limit at all.\n\n# Risk\n\nIf an invalid bundle/execution receipt cannot be discarded via a fraud proof due to this, it will eventually be considered final. If the storage root after executing the invalid bundle contains outgoing transfer messages minting SSC out of thin air, these transfers will be accepted by the consensus chain or sibling domains, effectively allowing an attacker to mint arbitrary amounts of SSC.\n\n# Mitigation suggestion\n\nUse an appropriate limit for the `proof_size` weight (with some safety margin to the consensus chain block length) to ensure that it is always possible to submit a fraud proof for an invalid bundle. Extra care needs to be taken to ensure that no calls can lead to a proof size larger than the predicted value from the weight calculation since this may directly lead to a situation where an invalid execution receipt is accepted since nobody can submit a fraud proof for it.","author_login":"jakoblell","author_association":"NONE","created_at":"2024-01-18T17:13:07+08:00","repo_name":"autonomys/subspace","issue_id":2088725488,"issue_number":2425,"issue_url":"https://github.com/autonomys/subspace/issues/2425","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1898912198","fragment_type":"issue_comment","sequence":1,"text":"I think there might be an issue for this already and there was some progress done on this, which wasn't quite finished","author_login":"nazar-pc","author_association":"MEMBER","created_at":"2024-01-18T17:26:32+08:00","repo_name":"autonomys/subspace","issue_id":2088725488,"issue_number":2425,"issue_url":"https://github.com/autonomys/subspace/issues/2425","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1900046835","fragment_type":"issue_comment","sequence":2,"text":"This issue tracks the same case described here - URL \n\nWe partially solved it for using frontiers `POV` size ratio. Corresponding code is here - URL \nThis ensures on the EVM side the gas limit is split between storage access and compute. Currently set to `1/4` of the gas limit.\nOn the substrate end, since team writes the pallets, we de-prioritzed this until we have add benchmarks to each pallet used and come back if we there would be a scenario where this could happen.\n\nHaving said that, I'm curious if there is a scenario you have come up with","author_login":"vedhavyas","author_association":"MEMBER","created_at":"2024-01-19T09:23:58+08:00","repo_name":"autonomys/subspace","issue_id":2088725488,"issue_number":2425,"issue_url":"https://github.com/autonomys/subspace/issues/2425","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1926640514","fragment_type":"issue_comment","sequence":3,"text":"Can provide an update on the domain block weight limits? As of now we still have `MAXIMUM_BLOCK_WEIGHT: Weight = Weight::from_parts(u64::MAX, u64::MAX)` and without an actual limit it can't be guaranteed that a fraud proof will fit into the conensus chain block size limit.","author_login":"jakoblell","author_association":"NONE","created_at":"2024-02-05T10:16:02+08:00","repo_name":"autonomys/subspace","issue_id":2088725488,"issue_number":2425,"issue_url":"https://github.com/autonomys/subspace/issues/2425","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1928988066","fragment_type":"issue_comment","sequence":4,"text":"@jakoblell We are aware of this. We will prioritse this change soon and post a follow-up pr with proper extrinsics limits. Thank you!","author_login":"vedhavyas","author_association":"MEMBER","created_at":"2024-02-06T08:15:39+08:00","repo_name":"autonomys/subspace","issue_id":2088725488,"issue_number":2425,"issue_url":"https://github.com/autonomys/subspace/issues/2425","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2101369935","fragment_type":"issue_comment","sequence":5,"text":"@vedhavyas is the issue not fixed between #2568 and #2651 by setting up bundle weight limits that in turn limit extrinsics?","author_login":"dariolina","author_association":"MEMBER","created_at":"2024-05-08T20:28:30+08:00","repo_name":"autonomys/subspace","issue_id":2088725488,"issue_number":2425,"issue_url":"https://github.com/autonomys/subspace/issues/2425","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2111948667","fragment_type":"issue_comment","sequence":6,"text":"@jakoblell\nFor substrate based chains, we ensure the total weight of all transactions in a given Bundle are at most BundleWeightLimit. More here - URL \nThis should not allow FP storage proofs to blow up since the all the reads are accounted in individual tx_weight.\n\nOne thing note here is that if the txn weights are outdated or wrong, this would be a problem since actual execution weight could be completely different. This may not be a problem for Runtimes we provide like EVM or AutoID but poses a bigger issue if and when we allow custom domain runtimes where they could completely give wrong weight for a given transaction.\nIn such case, this issue will come back where honest operator wont be able to submit a FP.\n\nIdeal solution would be to get the actual execution weight for a given transaction and then use it in BundleWeightLimit. But getting such a would require us to execute the txn, collect the actual weight. This would be in-efficient but necessary unfortunately. \n \n\nThis might not be necessary if we get the actual execution weight but simply limiting the proof size will not solve the issue since proof sizes can go over anyway and fraud proof will not submitted due to size limits","author_login":"vedhavyas","author_association":"MEMBER","created_at":"2024-05-15T08:58:18+08:00","repo_name":"autonomys/subspace","issue_id":2088725488,"issue_number":2425,"issue_url":"https://github.com/autonomys/subspace/issues/2425","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2122479146","fragment_type":"issue_comment","sequence":7,"text":"URL \n \n \n\nTo me it looks like this is just in the domain block/bundle production code used by honest domain operators - but this weight limit isn't actually enforced on chain. A malicious domain operator can trivially patch out this check and submit an invalid and overweight domain block. This can lead to a situation where a fraud proof cannot be submitted due to the size of the required storage proof.\n\nIn order to prevent that, the domain runtime should directly reject blocks exceeding a reasonable weight limit (including a proof size weight). Enforcing a block weight limit on a substrate-based chain is typically implemented via `frame_system::CheckWeight` based on the `BlockWeights` configuration, which is currently still configured to `u64::MAX`:\n\n* URL \n* URL \n* URL \n \n \n \n\nWell there may be some gaps/inaccuracies in the proof size weighting but in theory it should be sufficient to limit the required size for the storage proof required in a fraud proof. In practice there should be some safety factor between the allowable domain block proof size weight and the consensus chain block length limit so that a fraud proof will always fit into the limit.","author_login":"jakoblell","author_association":"NONE","created_at":"2024-05-21T12:02:51+08:00","repo_name":"autonomys/subspace","issue_id":2088725488,"issue_number":2425,"issue_url":"https://github.com/autonomys/subspace/issues/2425","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2135123497","fragment_type":"issue_comment","sequence":8,"text":"Correct. This should be handled with this Fraud proof - URL \n \n\nWe have set the Max limit for the Domain block because we have seen ExhaustResources during the Domain block import. Ideally, we want to ensure all the domain transactions in Consensus bundles should be executed on Domain. We are okay if the domain block import is slower but nonetheless executed. In order to avoid the excessive size coming from each extrinsics, we have introduced the POV size for EVM specifically and then we introduced MAX_BUNDLE_WEIGHT on consensus chain. One regression introduced with MAX domain Block limit is max extrinsic weight. We have an issue to fix the max_extrinsic_weight on domains while keeping the MAX domain block weight.\n\nOnce this above issue is fixed, there is reduced weight for each extrinsic and operators use that to calculate Domain Bundle weight. If the malicious operator do skip it, fraud proof will come into picture to slash that specific operator.\n\nLet me know if that make sense @jakoblell","author_login":"vedhavyas","author_association":"MEMBER","created_at":"2024-05-28T12:41:53+08:00","repo_name":"autonomys/subspace","issue_id":2088725488,"issue_number":2425,"issue_url":"https://github.com/autonomys/subspace/issues/2425","linked_issue_ids":[2065778987],"is_known_query_context":false},{"document_id":"gh_comment_2140083195","fragment_type":"issue_comment","sequence":9,"text":"@jakoblell I have a PR up here - URL \nThat should fix the limits for proof size for domains","author_login":"vedhavyas","author_association":"MEMBER","created_at":"2024-05-30T16:05:54+08:00","repo_name":"autonomys/subspace","issue_id":2088725488,"issue_number":2425,"issue_url":"https://github.com/autonomys/subspace/issues/2425","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2527962751","fragment_type":"issue_comment","sequence":10,"text":"@jakoblell Can you confirm if this is still an issue post #2801","author_login":"vedhavyas","author_association":"MEMBER","created_at":"2024-12-09T13:30:35+08:00","repo_name":"autonomys/subspace","issue_id":2088725488,"issue_number":2425,"issue_url":"https://github.com/autonomys/subspace/issues/2425","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2065778987","fragment_type":"issue_description","sequence":0,"text":"The `max_extrinsic` weight limit for domain extrinsic seems to be too large\nThe `max_extrinsic` weight limit seems to become too large since we set the max domain block weight to `u64::MAX` due to `max_extrinsic` is derived from `max_total`:\n URL \n\nThis may be an issue, especially for the evm transaction whose weight is computed from the `gas_limit` and it is provided by the user, if `gas_limit` is set to a large value the evm transaction will enter the operator's tx pool while it will fail to include in the bundle as it exceeds the bundle weight limit, thus it may stay at the tx pool forever.\n\ncc @vedhavyas","author_login":"NingLin-P","author_association":"MEMBER","created_at":"2024-01-04T14:40:11+08:00","repo_name":"subspace/subspace","issue_id":2065778987,"issue_number":2387,"issue_url":"https://github.com/subspace/subspace/issues/2387","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1877303917","fragment_type":"issue_comment","sequence":1,"text":"True, I initially wanted to limit max_extrinsic weight to a sane value but somehow missed to update that in the previous PR. This was not straight forward since the BlockWeights max_block_weight was used to derive this. I think we need to manually create the Block weight unfortunately.","author_login":"vedhavyas","author_association":"MEMBER","created_at":"2024-01-04T15:37:07+08:00","repo_name":"subspace/subspace","issue_id":2065778987,"issue_number":2387,"issue_url":"https://github.com/subspace/subspace/issues/2387","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2023500338","fragment_type":"issue_comment","sequence":2,"text":"This is getting a bit more tricky since we introduced bundle limit in URL because the `max_extrinsic` weight needs to be smaller than the max bundle weight limit while the bundle limit is calculated from the domain config which is a param of the `instantiate_domain` call and is not a constant value. So different domain instances may need different `max_extrinsic` values, as a result, we may need to store the bundle limit in the domain state either via genesis state (like domain id) or inherent extrinsic (like XDM channel allow list).\n\nAlso, in gemini-3h, the bundle limit of domain 0 is now `DomainBundleLimit { max_bundle_size: 357469, max_bundle_weight: Weight { ref_time: 136363636363, proof_size: 1257732550480196701 } }`, meaning the `max_extrinsic` is ~136ms compare to previous 1500ms with domain block weight limit. cc @dariolina","author_login":"NingLin-P","author_association":"MEMBER","created_at":"2024-03-27T18:17:27+08:00","repo_name":"subspace/subspace","issue_id":2065778987,"issue_number":2387,"issue_url":"https://github.com/subspace/subspace/issues/2387","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2023964506","fragment_type":"issue_comment","sequence":3,"text":"There's also #2365. Can we have bundle limit in domain config instead of block limit? Especially since domain block limit is not enforced.\nSo in domain config we would have `target_bundles_per_slot` (1 or less, or more) and `max_bundle_weight`. Then the average domain block weight would be `target_bundles_per_slot * max_bundle_weight/SLOT_PROBABILITY` and each domain should have hardware requirements to be able to achieve that.","author_login":"dariolina","author_association":"MEMBER","created_at":"2024-03-27T20:52:05+08:00","repo_name":"subspace/subspace","issue_id":2065778987,"issue_number":2387,"issue_url":"https://github.com/subspace/subspace/issues/2387","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0356","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"some warnning happened when i run manipulation.ipynb?","query_context":"/home/ubuntu/miniconda3/envs/mujoco_playground/lib/python3.10/site-packages/jax/_src/interpreters/xla.py:132: RuntimeWarning: overflow encountered in cast\n return np.asarray(x, dtypes.canonicalize_dtype(x.dtype))\n/home/ubuntu/miniconda3/envs/mujoco_playground/lib/python3.10/site-packages/jax/_src/interpreters/xla.py:132: RuntimeWarning: overflow encountered in cast\n return np.asarray(x, dtypes.canonicalize_dtype(x.dtype))\n/home/ubuntu/miniconda3/envs/mujoco_playground/lib/python3.10/site-packages/jax/_src/interpreters/xla.py:132: RuntimeWarning: overflow encountered in cast\n return np.asarray(x, dtypes.canonicalize_dtype(x.dtype))\n2025-01-16 18:44:38.791223: E external/xla/xla/service/slow_operation_alarm.cc:73] \n********************************\n[Compiling module jit_generate_eval_unroll] Very slow compile? If you want to file a bug, run with envvar XLA_FLAGS=--xla_dump_to=/tmp/foo and attach the results.","known_context_document_ids":["gh_issue_2792373426"],"reference_answer":"Closing, as it looks like this issue has been resolved. Please re-open if this is not the case. Thanks!","answer_document_id":"gh_comment_2784628622","silver_evidence_path":["gh_comment_2787856493","gh_issue_2816754787","gh_comment_2784628622"],"evidence_issue_ids":[2792373426,2816754787],"source_repo_name":"google-deepmind/mujoco_playground","source_issue_id":2792373426,"source_issue_number":11,"source_issue_url":"https://github.com/google-deepmind/mujoco_playground/issues/11","target_repo_name":"jax-ml/jax","target_issue_id":2816754787,"target_issue_number":26162,"target_issue_url":"https://github.com/jax-ml/jax/issues/26162","reference_anchor_document_id":"gh_comment_2787856493","reference_answer_author":"jburnim","reference_answer_author_association":"COLLABORATOR","quality_score":91.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2,"anchor_target_overlap":0.24,"target_answer_overlap":0.0},"issue_created_at":"2025-01-16T10:48:51+08:00","valid_comment_count":20,"fragments":[{"document_id":"gh_issue_2792373426","fragment_type":"issue_description","sequence":0,"text":"some warnning happened when i run manipulation.ipynb\n/home/ubuntu/miniconda3/envs/mujoco_playground/lib/python3.10/site-packages/jax/_src/interpreters/xla.py:132: RuntimeWarning: overflow encountered in cast\n return np.asarray(x, dtypes.canonicalize_dtype(x.dtype))\n/home/ubuntu/miniconda3/envs/mujoco_playground/lib/python3.10/site-packages/jax/_src/interpreters/xla.py:132: RuntimeWarning: overflow encountered in cast\n return np.asarray(x, dtypes.canonicalize_dtype(x.dtype))\n/home/ubuntu/miniconda3/envs/mujoco_playground/lib/python3.10/site-packages/jax/_src/interpreters/xla.py:132: RuntimeWarning: overflow encountered in cast\n return np.asarray(x, dtypes.canonicalize_dtype(x.dtype))\n2025-01-16 18:44:38.791223: E external/xla/xla/service/slow_operation_alarm.cc:73] \n********************************\n[Compiling module jit_generate_eval_unroll] Very slow compile? If you want to file a bug, run with envvar XLA_FLAGS=--xla_dump_to=/tmp/foo and attach the results.","author_login":"kassasin","author_association":"NONE","created_at":"2025-01-16T10:48:51+08:00","repo_name":"google-deepmind/mujoco_playground","issue_id":2792373426,"issue_number":11,"issue_url":"https://github.com/google-deepmind/mujoco_playground/issues/11","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2600582723","fragment_type":"issue_comment","sequence":1,"text":"@kassasin \n\nI just ran the colab using a colab instance, and can't repro. Does everything train as expected or is JIT hanging for too long?","author_login":"btaba","author_association":"COLLABORATOR","created_at":"2025-01-19T03:55:07+08:00","repo_name":"google-deepmind/mujoco_playground","issue_id":2792373426,"issue_number":11,"issue_url":"https://github.com/google-deepmind/mujoco_playground/issues/11","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2601205385","fragment_type":"issue_comment","sequence":2,"text":"Yes， it has running two days！\nI am using 4090 to run this tutorial .","author_login":"kassasin","author_association":"NONE","created_at":"2025-01-20T02:38:16+08:00","repo_name":"google-deepmind/mujoco_playground","issue_id":2792373426,"issue_number":11,"issue_url":"https://github.com/google-deepmind/mujoco_playground/issues/11","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2601634675","fragment_type":"issue_comment","sequence":3,"text":"Ok that's super interesting and also a bummer. I can't repro on 1x RTX 4090. This sounds like it's related to URL Will have to open a bug with the JAX team.\n\nCan you try lowering `num_evals_envs` to something like 32 in the brax PPO call for now?","author_login":"btaba","author_association":"COLLABORATOR","created_at":"2025-01-20T07:39:45+08:00","repo_name":"google-deepmind/mujoco_playground","issue_id":2792373426,"issue_number":11,"issue_url":"https://github.com/google-deepmind/mujoco_playground/issues/11","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2603774884","fragment_type":"issue_comment","sequence":4,"text":"Hello, I still meet this problem.\nMy ppo_params is:\n\naction_repeat: 1\nbatch_size: 512\ndiscounting: 0.97\nentropy_cost: 0.02\nepisode_length: 150\nlearning_rate: 0.001\nnetwork_factory:\n policy_hidden_layer_sizes: !!python/tuple\n - 32\n - 32\n - 32\n - 32\n policy_obs_key: state\n value_hidden_layer_sizes: !!python/tuple\n - 256\n - 256\n - 256\n - 256\n - 256\n value_obs_key: state\nnormalize_observations: true\nnum_envs: 32\nnum_evals: 4\nnum_minibatches: 32\nnum_timesteps: 20000000\nnum_updates_per_batch: 8\nreward_scaling: 1.0\nunroll_length: 10","author_login":"kassasin","author_association":"NONE","created_at":"2025-01-21T06:34:07+08:00","repo_name":"google-deepmind/mujoco_playground","issue_id":2792373426,"issue_number":11,"issue_url":"https://github.com/google-deepmind/mujoco_playground/issues/11","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2616164986","fragment_type":"issue_comment","sequence":5,"text":"Hi, I have the same problem. I ran it on Colab and my local RTX4090 and had the same problem. On my local RTX4090, there is one more warning about \"Very slow compile\". \n \naction_repeat: 1\naction_scale: 0.04\nctrl_dt: 0.02\nepisode_length: 150\nreward_config:\n scales:\n box_target: 8.0\n gripper_box: 4.0\n no_floor_collision: 0.25\n robot_target_qpos: 0.3\nsim_dt: 0.005\n\naction_repeat: 1\nbatch_size: 512\ndiscounting: 0.97\nentropy_cost: 0.02\nepisode_length: 150\nlearning_rate: 0.001\nnetwork_factory:\n policy_hidden_layer_sizes: !!python/tuple\n - 32\n - 32\n - 32\n - 32\n policy_obs_key: state\n value_hidden_layer_sizes: !!python/tuple\n - 256\n - 256\n - 256\n - 256\n - 256\n value_obs_key: state\nnormalize_observations: true\nnum_envs: 2048\nnum_evals: 4\nnum_minibatches: 32\nnum_timesteps: 20000000\nnum_updates_per_batch: 8\nreward_scaling: 1.0\nunroll_length: 10\n\n/home/ /anaconda3/envs/ mjc/lib/python3.13/site-packages/jax/_src/interpreters/xla.py:132: RuntimeWarning: overflow encountered in cast\n return np.asarray(x, dtypes.canonicalize_dtype(x.dtype))\n2025-01-27 17:01:38.465476: E external/xla/xla/service/slow_operation_alarm.cc:73] \n********************************\n[Compiling module jit_generate_eval_unroll] Very slow compile? If you want to file a bug, run with envvar XLA_FLAGS=--xla_dump_to=/tmp/foo and attach the results.\n********************************","author_login":"Elfits","author_association":"NONE","created_at":"2025-01-27T16:04:04+08:00","repo_name":"google-deepmind/mujoco_playground","issue_id":2792373426,"issue_number":11,"issue_url":"https://github.com/google-deepmind/mujoco_playground/issues/11","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2619994828","fragment_type":"issue_comment","sequence":6,"text":"Hi @Elfits and @kassasin , I just tried on my RTX 4090 locally, and I cannot reproduce. I tried multiple environments (PandaRobotiqPushCube, PandaPickCubeOrientation, LeapCubeReorient).\n\nCan y'all give a minimal reproducible example, and ideally open an issue here with the XLA dump: URL using latest JAX version?","author_login":"btaba","author_association":"COLLABORATOR","created_at":"2025-01-28T20:29:58+08:00","repo_name":"google-deepmind/mujoco_playground","issue_id":2792373426,"issue_number":11,"issue_url":"https://github.com/google-deepmind/mujoco_playground/issues/11","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2619999256","fragment_type":"issue_comment","sequence":7,"text":"Ok never mind! Was able to repro with `PandaRobotiqPushCube`. Will open a bug and post here.","author_login":"btaba","author_association":"COLLABORATOR","created_at":"2025-01-28T20:32:34+08:00","repo_name":"google-deepmind/mujoco_playground","issue_id":2792373426,"issue_number":11,"issue_url":"https://github.com/google-deepmind/mujoco_playground/issues/11","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2622463308","fragment_type":"issue_comment","sequence":8,"text":"Hi @Elfits that warning has been happening for some time and is mostly benign","author_login":"btaba","author_association":"COLLABORATOR","created_at":"2025-01-29T18:01:51+08:00","repo_name":"google-deepmind/mujoco_playground","issue_id":2792373426,"issue_number":11,"issue_url":"https://github.com/google-deepmind/mujoco_playground/issues/11","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2641932599","fragment_type":"issue_comment","sequence":9,"text":"another data point, I am experiencing the same issue when running `PandaRobotiqPushCube ` with RTX 4090.","author_login":"yun-long","author_association":"NONE","created_at":"2025-02-07T04:40:49+08:00","repo_name":"google-deepmind/mujoco_playground","issue_id":2792373426,"issue_number":11,"issue_url":"https://github.com/google-deepmind/mujoco_playground/issues/11","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2723305729","fragment_type":"issue_comment","sequence":10,"text":"Is this issue fixed? the same warninng when running PandaRobotiqPushCube with RTX 3060\n`mujoco==3.2.7\njax==0.5.2\nbrax==0.12.1`","author_login":"AvalonGuo","author_association":"NONE","created_at":"2025-03-14T03:20:40+08:00","repo_name":"google-deepmind/mujoco_playground","issue_id":2792373426,"issue_number":11,"issue_url":"https://github.com/google-deepmind/mujoco_playground/issues/11","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2787856493","fragment_type":"issue_comment","sequence":11,"text":"@yun-long @AvalonGuo if y'all are experience a slow operation alarm, please open a new bug with some details to reproduce!\n\n URL fixed the original issue a while ago and the \"RuntimeWarning overflow\" is benign, so I'm closing the issue for now","author_login":"btaba","author_association":"COLLABORATOR","created_at":"2025-04-08T23:24:28+08:00","repo_name":"google-deepmind/mujoco_playground","issue_id":2792373426,"issue_number":11,"issue_url":"https://github.com/google-deepmind/mujoco_playground/issues/11","linked_issue_ids":[2816754787],"is_known_query_context":false},{"document_id":"gh_comment_2787938177","fragment_type":"issue_comment","sequence":12,"text":"Thanks! It is really helpful. Should I need reinstall some packages?","author_login":"kassasin","author_association":"NONE","created_at":"2025-04-09T00:32:50+08:00","repo_name":"google-deepmind/mujoco_playground","issue_id":2792373426,"issue_number":11,"issue_url":"https://github.com/google-deepmind/mujoco_playground/issues/11","linked_issue_ids":[2816754787],"is_known_query_context":false},{"document_id":"gh_issue_2816754787","fragment_type":"issue_description","sequence":0,"text":"Operation very slow to compile since jax 0.4.36\n### Description\n\nHi folks,\n\nWe've been having slow compilation issues since jax 0.4.36 with some of our JAX code. The slow compilation (i.e. takes O(hours) to run instead of \n Install packages \n \npip install --upgrade jax[cuda] jaxlib \npip install --upgrade mujoco\npip install --upgrade mujoco_mjx\npip install --upgrade brax\n \n \n\nmujoco==3.2.7\nmujoco-mjx==3.2.7\nbrax==0.12.1\n\nRun this Python code:\n\npython\nimport functools\nfrom mujoco_playground import registry\nfrom mujoco_playground import wrapper\nfrom mujoco_playground.config import manipulation_params\nfrom brax.training.agents.ppo import train as ppo\nfrom brax.training.agents.ppo import networks as ppo_networks\n\nenv_name = 'PandaRobotiqPushCube'\nenv = registry.load(env_name)\nenv_cfg = registry.get_default_config(env_name)\n\nppo_params = manipulation_params.brax_ppo_config(env_name)\nppo_training_params = dict(ppo_params)\nnetwork_factory = ppo_networks.make_ppo_networks\nif \"network_factory\" in ppo_params:\n del ppo_training_params[\"network_factory\"]\n network_factory = functools.partial(\n ppo_networks.make_ppo_networks,\n **ppo_params.network_factory\n )\n\ntrain_fn = functools.partial(\n ppo.train, **dict(ppo_training_params),\n network_factory=network_factory,\n)\nmake_inference_fn, params, metrics = train_fn(\n environment=env,\n wrap_env_fn=wrapper.wrap_for_brax_training,\n)\n\nThe corresponding XLA dump is attached.\n\nI also reran the same script with `num_evals=0` within `train_fn`, and the code runs fine (the slow compilation occurs somewhere here). I'm attaching both the working and non-working XLA dumps. We would really appreciate any help on this issue.\n\nxla_dump_hanging_compilation.tar.gz\nxla_dump_working.tar.gz\n\n### System info (python version, jaxlib version, accelerator, etc.)\n\njax: 0.5.0\njaxlib: 0.5.0\nnumpy: 1.26.4\npython: 3.12.3 (main, Sep 10 2024, 15:47:39) [GCC 13.2.0]\ndevice info: NVIDIA GeForce RTX 4090-1, 1 local devices\"\nprocess_count: 1\nplatform: uname_result(system='Linux', node='btaba.mtv.corp.google.com', release='6.10.11-1rodete2-amd64', version='#1 SMP PREEMPT_DYNAMIC Debian 6.10.11-1rodete2 (2024-10-16)', machine='x86_64')\n\n$ nvidia-smi\nTue Jan 28 13:30:18 2025 \n+---------------------------------------------------------------------------------------+\n| NVIDIA-SMI 535.216.01 Driver Version: 535.216.01 CUDA Version: 12.2 |\n|-----------------------------------------+----------------------+----------------------+\n| GPU Name Persistence-M | Bus-Id Disp.A | Volatile Uncorr. ECC |\n| Fan Temp Perf Pwr:Usage/Cap | Memory-Usage | GPU-Util Compute M. |\n| | | MIG M. |\n|=========================================+======================+======================|\n| 0 NVIDIA GeForce RTX 4090 Off | 00000000:61:00.0 Off | Off |\n| 0% 50C P2 22W / 450W | 397MiB / 24564MiB | 0% Default |\n| | | N/A |\n+-----------------------------------------+----------------------+----------------------+\n \n+---------------------------------------------------------------------------------------+\n| Processes: |\n| GPU GI CI PID Type Process name GPU Memory |\n| ID ID Usage |\n|=======================================================================================|\n| 0 N/A N/A 2663746 C .../.pyenv/versions/mjx-312/bin/python 390MiB |\n+---------------------------------------------------------------------------------------+","author_login":"btaba","author_association":"NONE","created_at":"2025-01-28T21:31:36+08:00","repo_name":"jax-ml/jax","issue_id":2816754787,"issue_number":26162,"issue_url":"https://github.com/jax-ml/jax/issues/26162","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2626514720","fragment_type":"issue_comment","sequence":1,"text":"HLO reproducer: URL \n\nbazel run --config=cuda //xla/tools:run_hlo_module -c opt -- --xla_disable_all_hlo_passes --input_format=hlo --random_init_input_literals --platform=CUDA /opt/repro.hlo\n\nI'll take a look which pass is blowing up. Hopefully it's not in LLVM :-).","author_login":"jreiffers","author_association":"CONTRIBUTOR","created_at":"2025-01-31T07:54:04+08:00","repo_name":"jax-ml/jax","issue_id":2816754787,"issue_number":26162,"issue_url":"https://github.com/jax-ml/jax/issues/26162","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2627043529","fragment_type":"issue_comment","sequence":2,"text":"The quick hack did not work. I'll try to migrate us to the indexing maps next week.","author_login":"pifon2a","author_association":"CONTRIBUTOR","created_at":"2025-01-31T12:01:36+08:00","repo_name":"jax-ml/jax","issue_id":2816754787,"issue_number":26162,"issue_url":"https://github.com/jax-ml/jax/issues/26162","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2628048904","fragment_type":"issue_comment","sequence":3,"text":"Thanks @jreiffers and @pifon2a for taking a look, really appreciate it!","author_login":"btaba","author_association":"NONE","created_at":"2025-01-31T18:34:20+08:00","repo_name":"jax-ml/jax","issue_id":2816754787,"issue_number":26162,"issue_url":"https://github.com/jax-ml/jax/issues/26162","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2659776736","fragment_type":"issue_comment","sequence":4,"text":"So, i have a new version of a computation partitioner that completely relies on indexing maps. That did not help and it even outlines the same number of functions. Disabling the inliner helps and it compiles quickly. I will check, what's happening there.","author_login":"pifon2a","author_association":"CONTRIBUTOR","created_at":"2025-02-14T16:30:45+08:00","repo_name":"jax-ml/jax","issue_id":2816754787,"issue_number":26162,"issue_url":"https://github.com/jax-ml/jax/issues/26162","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2665304098","fragment_type":"issue_comment","sequence":5,"text":"Ok, the issue was within the inliner itself. I will upload the fix today.","author_login":"pifon2a","author_association":"CONTRIBUTOR","created_at":"2025-02-18T11:02:07+08:00","repo_name":"jax-ml/jax","issue_id":2816754787,"issue_number":26162,"issue_url":"https://github.com/jax-ml/jax/issues/26162","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2666320336","fragment_type":"issue_comment","sequence":6,"text":"The fix makes compilation of one of the tests in JAX slow. Everything else became better... Looking.","author_login":"pifon2a","author_association":"CONTRIBUTOR","created_at":"2025-02-18T17:04:50+08:00","repo_name":"jax-ml/jax","issue_id":2816754787,"issue_number":26162,"issue_url":"https://github.com/jax-ml/jax/issues/26162","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2678871513","fragment_type":"issue_comment","sequence":7,"text":"Indexing map-based partitioner and Tweaked inliner fixed the issue. Let me know if you still have problems with this.","author_login":"pifon2a","author_association":"CONTRIBUTOR","created_at":"2025-02-24T15:45:33+08:00","repo_name":"jax-ml/jax","issue_id":2816754787,"issue_number":26162,"issue_url":"https://github.com/jax-ml/jax/issues/26162","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2784628622","fragment_type":"issue_comment","sequence":8,"text":"Closing, as it looks like this issue has been resolved. Please re-open if this is not the case. Thanks!","author_login":"jburnim","author_association":"COLLABORATOR","created_at":"2025-04-07T21:06:35+08:00","repo_name":"jax-ml/jax","issue_id":2816754787,"issue_number":26162,"issue_url":"https://github.com/jax-ml/jax/issues/26162","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0359","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Name of project/tool?","query_context":"- [x] 1. Name the service as SyBValS (**Sy**stems **B**iology **Val**idation **S**ervice) everywhere in the sample application, including the About dialog\n- [x] 2. Name this repository as \"sybvals\"\n- [x] 3. Write a README introducing the service (use a format similar to this)","known_context_document_ids":["gh_issue_2207975296"],"reference_answer":"@ugurdogrusoz item 6 ( test.sbgn) is now working. Reason of error is that test.sbgn does not include mapProperties, so there is undefined errors in code, it is fixed by adding if else statement.","answer_document_id":"gh_comment_2202800112","silver_evidence_path":["gh_comment_2192924373","gh_issue_2281602434","gh_comment_2202800112"],"evidence_issue_ids":[2207975296,2281602434],"source_repo_name":"iVis-at-Bilkent/sybvals","source_issue_id":2207975296,"source_issue_number":1,"source_issue_url":"https://github.com/iVis-at-Bilkent/sybvals/issues/1","target_repo_name":"iVis-at-Bilkent/sybvals","target_issue_id":2281602434,"target_issue_number":8,"target_issue_url":"https://github.com/iVis-at-Bilkent/sybvals/issues/8","reference_anchor_document_id":"gh_comment_2192924373","reference_answer_author":"YusufZiyaOzgul","reference_answer_author_association":"COLLABORATOR","quality_score":91.81,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0476,"anchor_target_overlap":0.4828,"target_answer_overlap":0.125},"issue_created_at":"2024-03-26T11:25:30+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_2207975296","fragment_type":"issue_description","sequence":0,"text":"Name of project/tool\n- [x] 1. Name the service as SyBValS (**Sy**stems **B**iology **Val**idation **S**ervice) everywhere in the sample application, including the About dialog\n- [x] 2. Name this repository as \"sybvals\"\n- [x] 3. Write a README introducing the service (use a format similar to this)","author_login":"ugurdogrusoz","author_association":"CONTRIBUTOR","created_at":"2024-03-26T11:25:30+08:00","repo_name":"iVis-at-Bilkent/sybvals","issue_id":2207975296,"issue_number":1,"issue_url":"https://github.com/iVis-at-Bilkent/sybvals/issues/1","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2192924373","fragment_type":"issue_comment","sequence":1,"text":"I went over the README, revised the options and examples in the Usage section. I also added small explanations to the first part that the sbgn file with corrected errors is produced. The only issue is that the small test file that I used in README works for validation query, but gives error we try to resolve errors. I added this to issue #8.","author_login":"hasanbalci","author_association":"CONTRIBUTOR","created_at":"2024-06-27T02:18:06+08:00","repo_name":"iVis-at-Bilkent/sybvals","issue_id":2207975296,"issue_number":1,"issue_url":"https://github.com/iVis-at-Bilkent/sybvals/issues/1","linked_issue_ids":[2281602434],"is_known_query_context":false},{"document_id":"gh_comment_2205077583","fragment_type":"issue_comment","sequence":2,"text":"It would be good if we change the screenshots since now we are applying incremental layout between validation and error fix.","author_login":"hasanbalci","author_association":"CONTRIBUTOR","created_at":"2024-07-03T04:28:24+08:00","repo_name":"iVis-at-Bilkent/sybvals","issue_id":2207975296,"issue_number":1,"issue_url":"https://github.com/iVis-at-Bilkent/sybvals/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2281602434","fragment_type":"issue_description","sequence":0,"text":"Errors in deployment\n- [x] When I click on \"Errors\" download button when no file is uploaded, it throws an error in the console. It doesn't prevent the program from running, but let's fix it anyway.\n- [x] After I resolve errors in Sample 1 & 2, download the SBGNML files and then try to open them in Newt, it throws an error in the console and the maps cannot be loaded.\n- [x] When I tried to validate \"Insulin-like growth factor (IGF) signaling\" map from Newt samples, it gives error \"Error detail: SyntaxError: Unexpected token '<', \"\". \n- [x] When I tried to validate \"Drosophila cell cycle\" map from Newt samples, even though Newt shows 3 errors, sybvals shows 6 errors (I think it also adds the reverse version of each error) and doesn't highlight the errors. Additionally, when tried to resolve errors, it returns an error dialog.\n- [x] vitamins_b6_activation_to_pyridoxal_phosphate.sbgn.txt When we validate this file, service finds 25 errors but error numbers start from 15 and go to 39. In addition, resolving errors give error. \n- [x] For the examples given in README, I used test.sbgn.txt. it is a small file with only 3 nodes and two edges. When I test it, validation works correctly, but error resolving gives error.","author_login":"hasanbalci","author_association":"CONTRIBUTOR","created_at":"2024-05-06T19:33:20+08:00","repo_name":"iVis-at-Bilkent/sybvals","issue_id":2281602434,"issue_number":8,"issue_url":"https://github.com/iVis-at-Bilkent/sybvals/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2156152313","fragment_type":"issue_comment","sequence":1,"text":"Now, sample SBGNML files( after error resolving) successfully opened in Newt. I tried to click \"Errors\" download button when there is no file uploaded and I didn't get any error. Third error is related to #3. Reason of this error is \"submap\" is not handled in stylesheet.","author_login":"YusufZiyaOzgul","author_association":"COLLABORATOR","created_at":"2024-06-08T19:39:17+08:00","repo_name":"iVis-at-Bilkent/sybvals","issue_id":2281602434,"issue_number":8,"issue_url":"https://github.com/iVis-at-Bilkent/sybvals/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2156650189","fragment_type":"issue_comment","sequence":2,"text":"In item 1, I still see the mentioned error.\nI also added a new item (item 4).","author_login":"hasanbalci","author_association":"CONTRIBUTOR","created_at":"2024-06-09T15:14:28+08:00","repo_name":"iVis-at-Bilkent/sybvals","issue_id":2281602434,"issue_number":8,"issue_url":"https://github.com/iVis-at-Bilkent/sybvals/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2165600459","fragment_type":"issue_comment","sequence":3,"text":"I see that only item 1 is resolved. I ignored item 3, but there is no change in item 4.","author_login":"hasanbalci","author_association":"CONTRIBUTOR","created_at":"2024-06-13T12:59:41+08:00","repo_name":"iVis-at-Bilkent/sybvals","issue_id":2281602434,"issue_number":8,"issue_url":"https://github.com/iVis-at-Bilkent/sybvals/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2167835060","fragment_type":"issue_comment","sequence":4,"text":"For item 4, we now show 3 errors and highlight them, it is ok. But when I try to resolve errors in \ndrosophila_cell_cycle.nwt.txt it works but if I try drosophila_cell_cycle.sbgn.txt it gives error. I generated the first file with save in Newt and the second one by exporting as SBGN-ML Plain. Please remove .txt from the extensions to test the files.","author_login":"hasanbalci","author_association":"CONTRIBUTOR","created_at":"2024-06-14T11:35:40+08:00","repo_name":"iVis-at-Bilkent/sybvals","issue_id":2281602434,"issue_number":8,"issue_url":"https://github.com/iVis-at-Bilkent/sybvals/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2202794115","fragment_type":"issue_comment","sequence":5,"text":"@hasanbalci item5( vitamin b6) is working now. It is related to listing pd10102 errors.","author_login":"YusufZiyaOzgul","author_association":"COLLABORATOR","created_at":"2024-07-02T11:12:27+08:00","repo_name":"iVis-at-Bilkent/sybvals","issue_id":2281602434,"issue_number":8,"issue_url":"https://github.com/iVis-at-Bilkent/sybvals/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2202800112","fragment_type":"issue_comment","sequence":6,"text":"@ugurdogrusoz item 6 ( test.sbgn) is now working. Reason of error is that test.sbgn does not include mapProperties, so there is undefined errors in code, it is fixed by adding if else statement.","author_login":"YusufZiyaOzgul","author_association":"COLLABORATOR","created_at":"2024-07-02T11:13:51+08:00","repo_name":"iVis-at-Bilkent/sybvals","issue_id":2281602434,"issue_number":8,"issue_url":"https://github.com/iVis-at-Bilkent/sybvals/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2202803532","fragment_type":"issue_comment","sequence":7,"text":"it is working for both .sbgn and .nwt files now. @hasanbalci","author_login":"YusufZiyaOzgul","author_association":"COLLABORATOR","created_at":"2024-07-02T11:14:39+08:00","repo_name":"iVis-at-Bilkent/sybvals","issue_id":2281602434,"issue_number":8,"issue_url":"https://github.com/iVis-at-Bilkent/sybvals/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2202984864","fragment_type":"issue_comment","sequence":8,"text":"@YusufZiyaOzgul Thanks, droshophila example works now. However, after we resolve its errors, if we download the SBGN file and try to validate again, it finds a new error with an element unrelated to the previous ones. This doesn't happen in Newt.","author_login":"hasanbalci","author_association":"CONTRIBUTOR","created_at":"2024-07-02T12:01:20+08:00","repo_name":"iVis-at-Bilkent/sybvals","issue_id":2281602434,"issue_number":8,"issue_url":"https://github.com/iVis-at-Bilkent/sybvals/issues/8","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0360","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Version 1.10+ no longer finds checkpoints in custom install folder.","query_context":"Error: _The checkpoint used by this style is not installed_.\n\nMy ComfyUI install is a Windows portable version with custom .yaml paths. It had been working flawlessly with the plugin until 1.10/11.\nUpdating caused missing Python errors likely caused by ComfyUI's portable version Python folder being called _python embeded_, while the Krita plugin searches for _python_ instead. Although this had been working and is unrelated.\n\nNow it can only detect SDXL models and no 1.5 models. If I remove the custom checkpoint path from the .yaml file it no longer detects any checkpoints at all. Every other folder path in the .yaml (LoRAs, etc.) is detected except for checkpoints. ComfyUI itself can read the checkpoint folder.","known_context_document_ids":["gh_issue_2055809104"],"reference_answer":"Okay, but the issue is that SD1.5 checkpoints are detected as \"stab\" for some reason.\nYou said you updated ComfyUI and custom nodes, but what are the exact versions of ComfyUI and comfyui-tooling-nodes you are using? \nI have both on latest (Comfy: a252963f956a7d76344e3f0ce24b1047480a25af, comfyui-tooling-nodes: b2496a3f132f8c3f7d452a0960c422f55c33d128) and can't reproduce this...","answer_document_id":"gh_comment_1868480483","silver_evidence_path":["gh_comment_1869147495","gh_issue_2054835489","gh_comment_1868480483"],"evidence_issue_ids":[2055809104,2054835489],"source_repo_name":"Acly/krita-ai-diffusion","source_issue_id":2055809104,"source_issue_number":276,"source_issue_url":"https://github.com/Acly/krita-ai-diffusion/issues/276","target_repo_name":"Acly/krita-ai-diffusion","target_issue_id":2054835489,"target_issue_number":267,"target_issue_url":"https://github.com/Acly/krita-ai-diffusion/issues/267","reference_anchor_document_id":"gh_comment_1869147495","reference_answer_author":"Acly","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.15,"anchor_target_overlap":0.2,"target_answer_overlap":0.2609},"issue_created_at":"2023-12-25T18:09:42+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_2055809104","fragment_type":"issue_description","sequence":0,"text":"Version 1.10+ no longer finds checkpoints in custom install folder.\nError: _The checkpoint used by this style is not installed_.\n\nMy ComfyUI install is a Windows portable version with custom .yaml paths. It had been working flawlessly with the plugin until 1.10/11.\nUpdating caused missing Python errors likely caused by ComfyUI's portable version Python folder being called _python embeded_, while the Krita plugin searches for _python_ instead. Although this had been working and is unrelated.\n\nNow it can only detect SDXL models and no 1.5 models. If I remove the custom checkpoint path from the .yaml file it no longer detects any checkpoints at all. Every other folder path in the .yaml (LoRAs, etc.) is detected except for checkpoints. ComfyUI itself can read the checkpoint folder.","author_login":"brainhaver","author_association":"NONE","created_at":"2023-12-25T18:09:42+08:00","repo_name":"Acly/krita-ai-diffusion","issue_id":2055809104,"issue_number":276,"issue_url":"https://github.com/Acly/krita-ai-diffusion/issues/276","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1869147495","fragment_type":"issue_comment","sequence":1,"text":"That was intentional, the comfy-managed-by-plugin option isn't meant to manage a custom install (bad things can happen, use at your own risk)\n \n\nMaybe the same as #267, make sure you have the latest version of comfyui-tooling-nodes","author_login":"Acly","author_association":"OWNER","created_at":"2023-12-25T23:13:22+08:00","repo_name":"Acly/krita-ai-diffusion","issue_id":2055809104,"issue_number":276,"issue_url":"https://github.com/Acly/krita-ai-diffusion/issues/276","linked_issue_ids":[2054835489],"is_known_query_context":false},{"document_id":"gh_comment_1869148697","fragment_type":"issue_comment","sequence":2,"text":"Just as you responded I saw that someone had brought this issue up before, oops!\nThe files in the link you posted fixed the problem.","author_login":"brainhaver","author_association":"NONE","created_at":"2023-12-25T23:19:14+08:00","repo_name":"Acly/krita-ai-diffusion","issue_id":2055809104,"issue_number":276,"issue_url":"https://github.com/Acly/krita-ai-diffusion/issues/276","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2054835489","fragment_type":"issue_description","sequence":0,"text":"Missing SD 1.5 workflow even with all the models installed.\nCapture\nIt's been like this since I updated ComfyUI nightly along with its prerequisites and custom nodes to their latest version.\n\nOnly SDXL workflows work, SD 1.5 is missing \"Stable Diffusion Checkpoint\" even though I've got the same sd 1.5 based checkpoints in the same directory as usual.","author_login":"vidiotgameboss","author_association":"NONE","created_at":"2023-12-23T16:28:21+08:00","repo_name":"Acly/krita-ai-diffusion","issue_id":2054835489,"issue_number":267,"issue_url":"https://github.com/Acly/krita-ai-diffusion/issues/267","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1868361129","fragment_type":"issue_comment","sequence":1,"text":"I thought maybe ComfyUI update broke the checkpoint base model detection somehow, but at least for me it's still working with latest version.\nCan you check the output of URL \nAre your checkpoints listed? And is the base model detected correctly (\"sd15\" if it's SD1.5 checkpoint)?","author_login":"Acly","author_association":"OWNER","created_at":"2023-12-23T20:01:34+08:00","repo_name":"Acly/krita-ai-diffusion","issue_id":2054835489,"issue_number":267,"issue_url":"https://github.com/Acly/krita-ai-diffusion/issues/267","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1868412672","fragment_type":"issue_comment","sequence":2,"text":"yes every model is listed there in etn/model_info but as base_model: \"stab\"","author_login":"vidiotgameboss","author_association":"NONE","created_at":"2023-12-24T01:56:52+08:00","repo_name":"Acly/krita-ai-diffusion","issue_id":2054835489,"issue_number":267,"issue_url":"https://github.com/Acly/krita-ai-diffusion/issues/267","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1868480483","fragment_type":"issue_comment","sequence":3,"text":"Okay, but the issue is that SD1.5 checkpoints are detected as \"stab\" for some reason.\nYou said you updated ComfyUI and custom nodes, but what are the exact versions of ComfyUI and comfyui-tooling-nodes you are using? \nI have both on latest (Comfy: a252963f956a7d76344e3f0ce24b1047480a25af, comfyui-tooling-nodes: b2496a3f132f8c3f7d452a0960c422f55c33d128) and can't reproduce this...","author_login":"Acly","author_association":"OWNER","created_at":"2023-12-24T10:07:40+08:00","repo_name":"Acly/krita-ai-diffusion","issue_id":2054835489,"issue_number":267,"issue_url":"https://github.com/Acly/krita-ai-diffusion/issues/267","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1868511998","fragment_type":"issue_comment","sequence":4,"text":"ive pulled everything to the latest commit again just now, i tend to do this every couple of days/a week, its still detecting sd 1.5 as \"stab\", could it be a python dependency issue?","author_login":"vidiotgameboss","author_association":"NONE","created_at":"2023-12-24T13:02:09+08:00","repo_name":"Acly/krita-ai-diffusion","issue_id":2054835489,"issue_number":267,"issue_url":"https://github.com/Acly/krita-ai-diffusion/issues/267","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1868516948","fragment_type":"issue_comment","sequence":5,"text":"No, my guess is still that comfyui-tooling-nodes is outdated (for some reason).\n\nReason: previous versions just used the first 4 letters lower case of comfy's name for a base model. Recently comfy added support for `Stable_Zero123` base model, and your SD1.5 checkpoints are probably being misdetected as that.\n\nBut I just don't see how the current code would ever return \"stab\", even if the detection didn't work. It no longer does the first-4-letters thing...","author_login":"Acly","author_association":"OWNER","created_at":"2023-12-24T13:25:30+08:00","repo_name":"Acly/krita-ai-diffusion","issue_id":2054835489,"issue_number":267,"issue_url":"https://github.com/Acly/krita-ai-diffusion/issues/267","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1868539053","fragment_type":"issue_comment","sequence":6,"text":"ive deleted comfyui-tooling-nodes and manually downloaded instead of pulling or cloning it, now it works, bases_model detects as sd15\n\nthanks","author_login":"vidiotgameboss","author_association":"NONE","created_at":"2023-12-24T15:12:55+08:00","repo_name":"Acly/krita-ai-diffusion","issue_id":2054835489,"issue_number":267,"issue_url":"https://github.com/Acly/krita-ai-diffusion/issues/267","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0367","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Improve gas estimation for create transactions?","query_context":"### Component\n\nForge\n\n### Describe the feature you would like\n\nfollowup for URL \n\n- [ ] estimate gas for `executor.deploy`\n\n### Additional context\n\n_No response_","known_context_document_ids":["gh_issue_1334947793"],"reference_answer":"Hi all,\n\nI've tried reproducing this on Optimism, Optimism Sepolia, Arbitrum and Arbitrum Sepolia on both Anvil forks and actual deployments and am unable to reproduce it.\n\nOn Arbitrum and Arbitrum Sepolia (live) we flag it as an exception, estimate via RPC and trigger slow mode.\n\nSee: URL \n\nGiven that the issue does not occur anymore or cannot be reproduced reliably I'm marking this as `resolved`.\n\nThe existing workaround of `--with-gas-multiplier` exists if one happens to run into this issue.","answer_document_id":"gh_comment_2507303056","silver_evidence_path":["gh_comment_1504187325","gh_issue_1273968058","gh_comment_2507303056"],"evidence_issue_ids":[1334947793,1273968058],"source_repo_name":"foundry-rs/foundry","source_issue_id":1334947793,"source_issue_number":2700,"source_issue_url":"https://github.com/foundry-rs/foundry/issues/2700","target_repo_name":"foundry-rs/foundry","target_issue_id":1273968058,"target_issue_number":2002,"target_issue_url":"https://github.com/foundry-rs/foundry/issues/2002","reference_anchor_document_id":"gh_comment_1504187325","reference_answer_author":"zerosnacks","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1111,"anchor_target_overlap":0.1111,"target_answer_overlap":0.2143},"issue_created_at":"2022-08-10T17:24:52+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_1334947793","fragment_type":"issue_description","sequence":0,"text":"Improve gas estimation for create transactions\n### Component\n\nForge\n\n### Describe the feature you would like\n\nfollowup for URL \n\n- [ ] estimate gas for `executor.deploy`\n\n### Additional context\n\n_No response_","author_login":"mattsse","author_association":"MEMBER","created_at":"2022-08-10T17:24:52+08:00","repo_name":"foundry-rs/foundry","issue_id":1334947793,"issue_number":2700,"issue_url":"https://github.com/foundry-rs/foundry/issues/2700","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1504187325","fragment_type":"issue_comment","sequence":1,"text":"@mattsse What did you have in mind here? Is this related to item 3 in URL Unsure if we should keep this open and track it in #4444","author_login":"mds1","author_association":"COLLABORATOR","created_at":"2023-04-11T22:07:36+08:00","repo_name":"foundry-rs/foundry","issue_id":1334947793,"issue_number":2700,"issue_url":"https://github.com/foundry-rs/foundry/issues/2700","linked_issue_ids":[1273968058],"is_known_query_context":false},{"document_id":"gh_comment_2265161915","fragment_type":"issue_comment","sequence":2,"text":"Marking as `resolved` as I think it is likely resolved or, if not, will be handled by other tickets detailing specific issues with individual chains or configurations\n\nFeel free to re-open if this is still an issue we should address","author_login":"zerosnacks","author_association":"MEMBER","created_at":"2024-08-02T11:30:00+08:00","repo_name":"foundry-rs/foundry","issue_id":1334947793,"issue_number":2700,"issue_url":"https://github.com/foundry-rs/foundry/issues/2700","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1273968058","fragment_type":"issue_description","sequence":0,"text":"bug(`forge script`): tx succeeds during simulation but fails on any regular function call that occurs in a script after contract creation\n### Component\n\nAnvil\n\n### Have you ensured that all of these are up to date?\n\n- [X] Foundry\n- [X] Foundryup\n\n### What version of Foundry are you on?\n\nforge 0.2.0 (0962fd3 2022-06-16T18:19:05.497315Z)\n\n### What command(s) is the bug in?\n\n_No response_\n\n### Operating System\n\nmacOS (Apple Silicon)\n\n### Describe the bug\n\nExecuting a contract func that updates storage on a contract that doesn't have a constructor fails on a forked instance of optimism or arbitrum (using anvil). On mainnet and polygon forks, there's no issue.\n\nsolidity\n// SPDX-License-Identifier: UNLICENSED\npragma solidity ^0.8.13;\n\ncontract Contract {\n address public test;\n\n function initialize(address _test) external {\n test = _test;\n }\n}\n\nsolidity\n// SPDX-License-Identifier: UNLICENSED\npragma solidity ^0.8.13;\n\nimport \"forge-std/Script.sol\";\n\nimport {Contract} from \"src/Contract.sol\";\n\ncontract ContractScript is Script {\n\n Contract public testContract;\n\n function run() public {\n vm.broadcast();\n testContract = new Contract();\n\n vm.broadcast();\n testContract.initialize(address(1));\n }\n}\n\nWhat's interesting is the simulation is successful, but the actual broadcast tx fails:\n\n$ forge script script/Contract.s.sol --rpc-url \" URL --private-key $ANVIL_ACCT_9 --broadcast -vvvv [14:41:16]\n[⠒] Compiling...\nNothing to compile\nTraces:\n [93261] ContractScript::run() \n ├─ [0] VM::broadcast() \n │ └─ ← ()\n ├─ [49699] → new Contract@0x700b6a60ce7eaaea56f065753d8dcb9653dbad35\n │ └─ ← 248 bytes of code\n ├─ [0] VM::broadcast() \n │ └─ ← ()\n ├─ [2502] Contract::initialize(0x0000000000000000000000000000000000000000) \n │ └─ ← ()\n └─ ← ()\n\nScript ran successfully.\nGas used: 93261\n==========================\nSimulated On-chain Traces:\n\n [106971] → new Contract@0x700b6a60ce7eaaea56f065753d8dcb9653dbad35\n └─ ← 248 bytes of code\n\n [23694] Contract::initialize(0x0000000000000000000000000000000000000000) \n └─ ← ()\n\n==========================\n\nEstimated total gas used for script: 131151\n\nAmount required: 0.000262302 ETH\n\n==========================\n\n###\nFinding wallets for all the necessary addresses...\n##\nSending transactions [0 - 1].\n⠉ [00:00:00] [#################################################################################################################################################################################################################################################] 2/2 txes (0.0s)\nTransactions saved to: broadcast/Contract.s.sol/10/run-latest.json\n\n##\nWaiting for receipts.\n⠙ [00:00:07] [#############################################################################################################################################################################################################################################] 2/2 receipts (0.0s)\n#####\n✅ Hash: 0x616898701db8efc33e972bfb36467311b28cfc49ed863f70dfe2f4a1d48a4c71\nContract Address: 0x700b6a60ce7eaaea56f065753d8dcb9653dbad35\nBlock: 12064970\nPaid: 0.000213942 ETH (106971 gas * 2 gwei)\n\n#####\n❌ Hash: 0x03db02d9ff00fb3f4e1c6550670aa6c57e8a9361d1e406a34e391e0de5ee0b21\nBlock: 12064971\nPaid: 0.0000469 ETH (23450 gas * 2 gwei)\n\nTransactions saved to: broadcast/Contract.s.sol/10/run-latest.json\n\nError: \n 0: [\"Transaction Failure: 0x03db…0b21\"]\n\nLocation:\n cli/src/cmd/forge/script/receipts.rs:75\n\nIf you remove logic that updates any storage state, the tx succeeds.","author_login":"chad-js","author_association":"CONTRIBUTOR","created_at":"2022-06-16T19:01:14+08:00","repo_name":"foundry-rs/foundry","issue_id":1273968058,"issue_number":2002,"issue_url":"https://github.com/foundry-rs/foundry/issues/2002","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1158116444","fragment_type":"issue_comment","sequence":1,"text":"I just gave the script I put above a try on prod optimism, the tx for the initialize call fails there as well:\n\n$ forge script script/Contract.s.sol --rpc-url $OPTIMISM_RPC_URL --private-key --broadcast --slow -vvvv [16:33:43]\n[⠢] Compiling...\nNothing to compile\nTraces:\n [113155] ContractScript::run() \n ├─ [0] VM::broadcast() \n │ └─ ← ()\n ├─ [49699] → new Contract@0x8eb4600bbab2286a46103f4923866de9653b737b\n │ └─ ← 248 bytes of code\n ├─ [0] VM::broadcast() \n │ └─ ← ()\n ├─ [22402] Contract::initialize(0x0000000000000000000000000000000000000001) \n │ └─ ← ()\n └─ ← ()\n\nScript ran successfully.\nGas used: 113155\n==========================\nSimulated On-chain Traces:\n\n [106971] → new Contract@0x8eb4600bbab2286a46103f4923866de9653b737b\n └─ ← 248 bytes of code\n\n [43606] Contract::initialize(0x0000000000000000000000000000000000000001) \n └─ ← ()\n\n==========================\n\nEstimated total gas used for script: 128175\n\nAmount required: 0.000000128175 ETH\n\n==========================\n\n###\nFinding wallets for all the necessary addresses...\n##\nSending transactions [0 - 1].\n⠁ [00:00:00] [########################################################################################################################>------------------------------------------------------------------------------------------------------------------------] 1/2 txes (0.4s)⠉ [00:00:07] [#############################################################################################################################################################################################################################################] 1/1 receipts (0.0s)\n#####\n✅ Hash: 0x1a972cf266cbfd61a028e1fdd694686130ce4b6dc0c7202bd21212ef775c8589\nContract Address: 0x8eb4600bbab2286a46103f4923866de9653b737b\nBlock: 12073464\nGas Used: 106971\n\n⠉ [00:00:07] [#################################################################################################################################################################################################################################################] 2/2 txes (0.0s)⠉ [00:00:07] [#############################################################################################################################################################################################################################################] 1/1 receipts (0.0s)\n#####\n❌ Hash: 0x1b07ca2cce8b7302dbdb0e4a257c07d19689647c50de8df8a3549a2eedd1a3ff\nBlock: 12073469\nGas Used: 21204\n\nTransactions saved to: broadcast/Contract.s.sol/10/run-latest.json\n\nError: \n 0: [\"Transaction Failure: 0x1b07…a3ff\"]\n \n\nThe failed tx.\n\nBut, notice that executing a tx with the same args but with `cast` and a gas limit of `75000` results in success:\n\n$ cast send 0x8eb4600bbab2286a46103f4923866de9653b737b \"initialize(address)\" 0x0000000000000000000000000000000000000001 --gas 75000 --rpc-url $OPTIMISM_RPC_URL --private-key [16:41:41]\n\nblockHash 0xf6c411ec971b21c1ec5c41487929b814bad5be151f4831de7b07d0e36c6a44c0\nblockNumber 12074683\ncontractAddress \ncumulativeGasUsed 43606\neffectiveGasPrice \ngasUsed 43606\nlogs []\nlogsBloom 0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000\nroot \nstatus 1\ntransactionHash 0x1493c477c18629ab75f6759f95bed118517f6a4e66602460a2c3643c93486801\ntransactionIndex 0\ntype \n\nSo, seems like this is a gas estimation issue","author_login":"chad-js","author_association":"NONE","created_at":"2022-06-16T20:49:46+08:00","repo_name":"foundry-rs/foundry","issue_id":1273968058,"issue_number":2002,"issue_url":"https://github.com/foundry-rs/foundry/issues/2002","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1158138997","fragment_type":"issue_comment","sequence":2,"text":"Per @mds1 suggestion let's go with the following 2 steps:\n\n1 Add a broadcast overload that lets you specify the gas limit for the tx, `vm.broadcast(uint256 gasLimit)` and `vm.broadcast(address sender, uint256 gasLimit)`\n2. add bespoke logic for each L2, determined by chainId, this will need to be fork-aware when #1715 is merged\n\ncc @joshieDo","author_login":"gakonst","author_association":"MEMBER","created_at":"2022-06-16T21:18:29+08:00","repo_name":"foundry-rs/foundry","issue_id":1273968058,"issue_number":2002,"issue_url":"https://github.com/foundry-rs/foundry/issues/2002","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1158185606","fragment_type":"issue_comment","sequence":3,"text":"We should probably add those broadcast interfaces. However, this is actually a result from another issue. \n\nSince L2s have different gas calculations, we discard the gas estimated locally, and request a new one from the RPC. To support batching, they're happening at the same time for tx1 and tx2. However, tx2 needs tx1 to be submitted and accepted first.\n\nWe should probably force `--slow` on L2s or any other transaction that requires `--slow`. In this case, even with `--slow` won't work, since we estimate everything before we start sending, which needs to be fixed.","author_login":"joshieDo","author_association":"COLLABORATOR","created_at":"2022-06-16T22:16:03+08:00","repo_name":"foundry-rs/foundry","issue_id":1273968058,"issue_number":2002,"issue_url":"https://github.com/foundry-rs/foundry/issues/2002","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1158188333","fragment_type":"issue_comment","sequence":4,"text":"I was under the impression Arbitrum and Optimism had different gas metering, but it seems that only Arbitrum has.","author_login":"joshieDo","author_association":"COLLABORATOR","created_at":"2022-06-16T22:21:00+08:00","repo_name":"foundry-rs/foundry","issue_id":1273968058,"issue_number":2002,"issue_url":"https://github.com/foundry-rs/foundry/issues/2002","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1158936417","fragment_type":"issue_comment","sequence":5,"text":"Just summarizing what we ended up on as the path forward:\n1. Remove Optimism from the `has_different_gas_calc` function\n\n URL \n URL \n\n2. Force `--slow` on Arbitrum and Optimism. Both of don't have mempools like L1's so if you send multiple txs they get rejected with `nonce too low`.\n\n3. Move RPC gas estimation right before sending the intended tx, and add a note to the output indicating the \"total gas/ETH cost estimates\" shown beforehand aren't guaranteed to be accurate (since we don't estimate Optimism costs correctly)\n\n4. This one wasn't settled on, but I think we should change the broadcast overloads to specify margin on the gas estimate, instead of absolute limits. So if I'm estimating gas for a uniswap v2 trade where cost varies by block position, I can do `vm.broadcast(20)` to mean \"add 20% margin to the gas estimate\". IMO this is better UX than needing to harcode gas limits directly.","author_login":"mds1","author_association":"CONTRIBUTOR","created_at":"2022-06-17T14:37:12+08:00","repo_name":"foundry-rs/foundry","issue_id":1273968058,"issue_number":2002,"issue_url":"https://github.com/foundry-rs/foundry/issues/2002","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1160815236","fragment_type":"issue_comment","sequence":6,"text":"For accurate fee estimation on Optimism, the L2 (execution) fee and the L1 (availability) fee needs to be taken into account. See here for how to do so. If special logic is added that is chain aware, perhaps handling this could just be abstracted away from users. See URL for a higher level explanation","author_login":"tynes","author_association":"CONTRIBUTOR","created_at":"2022-06-20T20:17:02+08:00","repo_name":"foundry-rs/foundry","issue_id":1273968058,"issue_number":2002,"issue_url":"https://github.com/foundry-rs/foundry/issues/2002","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1172622177","fragment_type":"issue_comment","sequence":7,"text":"Of the 4 items listed in my above comment, I believe 1 and 2 are implemented, 3 and 4 are not.","author_login":"mds1","author_association":"CONTRIBUTOR","created_at":"2022-07-01T18:46:02+08:00","repo_name":"foundry-rs/foundry","issue_id":1273968058,"issue_number":2002,"issue_url":"https://github.com/foundry-rs/foundry/issues/2002","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1206990534","fragment_type":"issue_comment","sequence":8,"text":"Just a small note on all of this, recently stumped me and had to use the `-g` flag.\n\nCould we also get a better error message if the transaction runs out of gas? `Transaction Failure: 0x1b07…a3ff` is not the most obvious. I'm down to implement this myself, just curious if others would agree or there's some reason we don't currently do that.","author_login":"devanonon","author_association":"CONTRIBUTOR","created_at":"2022-08-05T22:11:01+08:00","repo_name":"foundry-rs/foundry","issue_id":1273968058,"issue_number":2002,"issue_url":"https://github.com/foundry-rs/foundry/issues/2002","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207080993","fragment_type":"issue_comment","sequence":9,"text":"+1 on @devanonon's comment, haven't gotten around to opening an issue yet but here's a related repro with other issues: URL","author_login":"mds1","author_association":"CONTRIBUTOR","created_at":"2022-08-05T23:11:19+08:00","repo_name":"foundry-rs/foundry","issue_id":1273968058,"issue_number":2002,"issue_url":"https://github.com/foundry-rs/foundry/issues/2002","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1958685106","fragment_type":"issue_comment","sequence":10,"text":"This issue still exists, and I believe it applies to any regular function call that occurs in a script after contract creation (i.e. not necessarily limited to an initialization call). I used `--with-gas-multiplier` to resolve it.","author_login":"simplyoptimistic","author_association":"NONE","created_at":"2024-02-22T04:36:30+08:00","repo_name":"foundry-rs/foundry","issue_id":1273968058,"issue_number":2002,"issue_url":"https://github.com/foundry-rs/foundry/issues/2002","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2263007569","fragment_type":"issue_comment","sequence":11,"text":"Optimistically marking this ticket as resolved. We've since moved to Alloy and URL indicated a similar issue has been resolved.\n\nFeel free to re-open if there are still outstanding issues or alternatively open a new ticket that is specific to your situation.","author_login":"zerosnacks","author_association":"MEMBER","created_at":"2024-08-01T13:11:44+08:00","repo_name":"foundry-rs/foundry","issue_id":1273968058,"issue_number":2002,"issue_url":"https://github.com/foundry-rs/foundry/issues/2002","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2330409740","fragment_type":"issue_comment","sequence":12,"text":"Can confirm this is still an issue. My instance occurred while running a script aimed at optimism sepolia. I second that it does apply to any regular function call that occurs in a script after contract creation as @simplyoptimistic offered. I also used `--with-gas-multiplier` to resolve the issue.","author_login":"captnseagraves","author_association":"NONE","created_at":"2024-09-05T01:13:25+08:00","repo_name":"foundry-rs/foundry","issue_id":1273968058,"issue_number":2002,"issue_url":"https://github.com/foundry-rs/foundry/issues/2002","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2507303056","fragment_type":"issue_comment","sequence":13,"text":"Hi all,\n\nI've tried reproducing this on Optimism, Optimism Sepolia, Arbitrum and Arbitrum Sepolia on both Anvil forks and actual deployments and am unable to reproduce it.\n\nOn Arbitrum and Arbitrum Sepolia (live) we flag it as an exception, estimate via RPC and trigger slow mode.\n\nSee: URL \n\nGiven that the issue does not occur anymore or cannot be reproduced reliably I'm marking this as `resolved`.\n\nThe existing workaround of `--with-gas-multiplier` exists if one happens to run into this issue.","author_login":"zerosnacks","author_association":"MEMBER","created_at":"2024-11-29T08:21:46+08:00","repo_name":"foundry-rs/foundry","issue_id":1273968058,"issue_number":2002,"issue_url":"https://github.com/foundry-rs/foundry/issues/2002","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0374","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Resetting Rewards doesn't reset Ads count?","query_context":"### Description\n\nWhile verifying the CR 134 manual pass, noticed resetting rewards doesn't reset ad count. Except for Ads data, other data is reset/wiped out. Tried few times and was able to reproduce every time. However, I could not reproduce in 1.75.x. Reproduced in 1.76.63. \n\n### Steps to reproduce\n\n1. Install 1.77.52\n2. launch Brave\n3. enabled Rewards\n4. connected uphold\n5. contributed BAT via rewards panel\n6. waited for few ads\n7. opened brave://rewards\n8. clicked ... menu\n9. clicked `Disable and reset Rewards`\n10. Rejoined Rewards\n\n### Actual result\n\nThe ads count still shown \n\n URL \n\n### Expected result\n\nAd count from before resetting rewards should not be shown\n\n### Reproduces how often\n\nEasily reproduced\n\n### Brave version (brave://version info)\n\nBrave | 1.77.52 Chromium: 134.0.6998.15 (Official Build) nightly (64-bit)\n-- | --\nRevision | d2b1e97cd8ae806f9aa05a0204a9b953536c5bce\nOS | Windows 11 Version 24H2 (Build 26100.2894)\n\n### Channel information\n\n- [ ] release (stable)\n- [x] beta\n- [x] nightly\n\n### Reproducibility\n\n- [ ] with Brave Shields disabled\n- [ ] with Brave Rewards disabled\n- [ ] in the latest version of Chrome\n\n### Miscellaneous information\n\n@Miyayes @zenparsing \ncc: @brave/qa-team","known_context_document_ids":["gh_issue_2867354832"],"reference_answer":"Verification in progress with\n\nBrave | 1.76.74 Chromium: 134.0.6998.89 (Official Build) (x86_64)\n-- | --\nRevision | f529926c39ddc08b1e0873f4b8befdca4984b492\nOS | macOS Version 14.7.4 (Build 23H420)","answer_document_id":"gh_comment_2713949764","silver_evidence_path":["gh_comment_2713370313","gh_issue_2851121226","gh_comment_2713949764"],"evidence_issue_ids":[2867354832,2851121226],"source_repo_name":"brave/brave-browser","source_issue_id":2867354832,"source_issue_number":44138,"source_issue_url":"https://github.com/brave/brave-browser/issues/44138","target_repo_name":"brave/brave-browser","target_issue_id":2851121226,"target_issue_number":43946,"target_issue_url":"https://github.com/brave/brave-browser/issues/43946","reference_anchor_document_id":"gh_comment_2713370313","reference_answer_author":"LaurenWags","reference_answer_author_association":"MEMBER","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.3778,"anchor_target_overlap":0.2,"target_answer_overlap":0.0},"issue_created_at":"2025-02-20T21:54:16+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_2867354832","fragment_type":"issue_description","sequence":0,"text":"Resetting Rewards doesn't reset Ads count\n### Description\n\nWhile verifying the CR 134 manual pass, noticed resetting rewards doesn't reset ad count. Except for Ads data, other data is reset/wiped out. Tried few times and was able to reproduce every time. However, I could not reproduce in 1.75.x. Reproduced in 1.76.63. \n\n### Steps to reproduce\n\n1. Install 1.77.52\n2. launch Brave\n3. enabled Rewards\n4. connected uphold\n5. contributed BAT via rewards panel\n6. waited for few ads\n7. opened brave://rewards\n8. clicked ... menu\n9. clicked `Disable and reset Rewards`\n10. Rejoined Rewards\n\n### Actual result\n\nThe ads count still shown \n\n URL \n\n### Expected result\n\nAd count from before resetting rewards should not be shown\n\n### Reproduces how often\n\nEasily reproduced\n\n### Brave version (brave://version info)\n\nBrave | 1.77.52 Chromium: 134.0.6998.15 (Official Build) nightly (64-bit)\n-- | --\nRevision | d2b1e97cd8ae806f9aa05a0204a9b953536c5bce\nOS | Windows 11 Version 24H2 (Build 26100.2894)\n\n### Channel information\n\n- [ ] release (stable)\n- [x] beta\n- [x] nightly\n\n### Reproducibility\n\n- [ ] with Brave Shields disabled\n- [ ] with Brave Rewards disabled\n- [ ] in the latest version of Chrome\n\n### Miscellaneous information\n\n@Miyayes @zenparsing \ncc: @brave/qa-team","author_login":"MadhaviSeelam","author_association":"NONE","created_at":"2025-02-20T21:54:16+08:00","repo_name":"brave/brave-browser","issue_id":2867354832,"issue_number":44138,"issue_url":"https://github.com/brave/brave-browser/issues/44138","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2672799688","fragment_type":"issue_comment","sequence":1,"text":"I could not reproduce using `1.77.55`. @zenparsing mentioned maybe some kind of race condition?\n\n URL","author_login":"LaurenWags","author_association":"MEMBER","created_at":"2025-02-20T22:08:08+08:00","repo_name":"brave/brave-browser","issue_id":2867354832,"issue_number":44138,"issue_url":"https://github.com/brave/brave-browser/issues/44138","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2679780898","fragment_type":"issue_comment","sequence":2,"text":"Just adding some context re: running into the above issue when I asked @Miyayes to help me change my desktop `Nightly` installation from `Uphold` -> `Solana` on chain. Once I restarted my `Rewards`, everything was cleared/disconnected from Uphold other than the ads that I viewed. They were still listed as ~160 ads seen this month even though `rewards` was restarted. I connected my Solana wallet without any issues but the ads never cleared. So I'm currently at ~180 ads. So it definitely wasn't cleared when I reset `rewards`. Basically what @GeetaSarvadnya reported above.\n\nOn the other hand, when I did the same thing on `Android` re: restarting my `rewards` to get a new `Payment ID` to get whitelisted, it cleared the ads count without any issues.","author_login":"kjozwiak","author_association":"MEMBER","created_at":"2025-02-24T22:13:54+08:00","repo_name":"brave/brave-browser","issue_id":2867354832,"issue_number":44138,"issue_url":"https://github.com/brave/brave-browser/issues/44138","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2680530883","fragment_type":"issue_comment","sequence":3,"text":"The issue is reproducible on\n\nBrave | 1.77.61 Chromium: 134.0.6998.24 (Official Build) nightly (64-bit)\n-- | --\nRevision | f5bab96d17b03e45c0253dc2b822f4706ff2739b\nOS | Windows 10 Version 22H2 (Build 19045.5487)\n\nImage\n\n<","author_login":"GeetaSarvadnya","author_association":"NONE","created_at":"2025-02-25T05:06:12+08:00","repo_name":"brave/brave-browser","issue_id":2867354832,"issue_number":44138,"issue_url":"https://github.com/brave/brave-browser/issues/44138","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2682418749","fragment_type":"issue_comment","sequence":4,"text":"This issue seems to be reproducible on Windows but not MacOS.\n\nOn Windows, I saw this intermittently in `Rewards.log` immediately after resetting.\n\n[Feb 25, 2025 3:24:07.3 PM GMT:INFO:account.cc(204)] Initialize confirmations\n[Feb 25, 2025 3:24:07.3 PM GMT:INFO:ads_impl.cc(69)] Initializing ads\n[Feb 25, 2025 3:24:07.6 PM GMT:ERROR:database_manager.cc(88)] Failed to create or open database\n[Feb 25, 2025 3:24:07.6 PM GMT:ERROR:ads_impl.cc(417)] Failed to create or open database\n[Feb 25, 2025 3:24:07.6 PM GMT:ERROR:ads_impl.cc(430)] Failed to initialize ads\n\nThis occurs using both the new and old Rewards pages.","author_login":"zenparsing","author_association":"NONE","created_at":"2025-02-25T15:40:31+08:00","repo_name":"brave/brave-browser","issue_id":2867354832,"issue_number":44138,"issue_url":"https://github.com/brave/brave-browser/issues/44138","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2702492862","fragment_type":"issue_comment","sequence":5,"text":"The above requires `1.76.74` or higher for `1.76.x` verification 👍","author_login":"kjozwiak","author_association":"MEMBER","created_at":"2025-03-06T01:30:26+08:00","repo_name":"brave/brave-browser","issue_id":2867354832,"issue_number":44138,"issue_url":"https://github.com/brave/brave-browser/issues/44138","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2713370313","fragment_type":"issue_comment","sequence":6,"text":"Verification **PASSED** on\n\nBrave | 1.76.74 Chromium: 134.0.6998.89 (Official Build) (64-bit)\n-- | --\nRevision | f529926c39ddc08b1e0873f4b8befdca4984b492\nOS | Windows 10 Version 22H2 (Build 19045.5555)\n\n- Verified the test plan from URL \n- Verified the Test pan via URL \n\n \n Case 1: View ads in non-connected state and reset rewards_PASSED \n\n1. Clean profile `1.78.18`\n2. Enable rewards \n3. View couple of ads\n4. Confirmed that ads count is shown on the brave://rewards page\n5. Reset rewards via `more...`\n6. Re-enable rewards\n7. Confirmed that ads counter is reset to Zero \n\nAds count | Reset rewards | Re-enable rewards | Ads count reset to zero\n-------------|-----------------|---------------------|----------------------\nimage | image | image | image\n\n \n\n \n Case 2: View ads in connected state and reset rewards_PASSED \n\n1. Clean profile `1.78.18`\n2. Enable rewards \n3. View couple of ads\n4. Confirmed that ads count is shown on the brave://rewards page\n5. Reset rewards via `more...`\n6. Re-enable rewards\n7. Confirmed that ads counter is reset to Zero \n\nAds count | Reset rewards | Re-enable rewards | Ads count reset to zero\n-------------|-----------------|---------------------|----------------------\nimage | image | image | image\n\n \n\n \n Case 3: Upgrade from broken profile_PASSED \n\n1. Clean profile `1.76.61`\n2. Enable rewards and connect to a custodian \n3. View couple of ads\n4. Confirmed that ads count is shown on the brave://rewards page\n5. Reset rewards via `more...`\n6. Re-enable rewards\n7. Confirmed that ads counter is NOT reset to Zero \n\n `1.76.61` - Ads count | `1.76.61`- Reset rewards | `1.76.61` - Re-enable rewards | `1.76.61` - Ads count NOT reset to zero\n-------------|-----|------|-----\nimage | image | image | image\n\n8. Upgrade the profile to `1.78.18`\n9. Confirmed that ads count is shown on the brave://rewards page\n10. Reset rewards via `more...`\n11. Re-enable rewards\n12. Confirmed that ads counter is reset to Zero as expected\n\n `1.78.18` - Ads count | `1.78.18`- Reset rewards | `1.78.18` - Re-enable rewards | `1.78.18` - Ads count reset to zero\n-------------|-----|------|-----\nimage | image | image | image","author_login":"GeetaSarvadnya","author_association":"NONE","created_at":"2025-03-11T09:41:28+08:00","repo_name":"brave/brave-browser","issue_id":2867354832,"issue_number":44138,"issue_url":"https://github.com/brave/brave-browser/issues/44138","linked_issue_ids":[2851121226],"is_known_query_context":false},{"document_id":"gh_issue_2851121226","fragment_type":"issue_description","sequence":0,"text":"[ads] Crash `brave_ads::GetNextPaymentDate`\n### Description\n\n[ 00 ] brave_ads::GetAdsClient() ( immediate_crash.h:188 )\n[ 01 ] brave_ads::GetProfileTimePref(std::__Cr::basic_string , std::__Cr::allocator > const&) ( pref_util.cc:110 )\n[ 02 ] brave_ads::GetNextPaymentDate(std::__Cr::vector > const&) ( statement_util.cc:41 )\n[ 03 ] brave_ads::BuildStatement(base::OnceCallback )>)::$_0::operator()(base::OnceCallback )>, bool, std::__Cr::vector > const&) const ( statement.cc:48 )\n[ 04 ] void base::internal::DecayedFunctorTraits )>)::$_0, base::OnceCallback )>&&>::Invoke )>)::$_0, base::OnceCallback )>, bool, std::__Cr::vector > const&>(brave_ads::BuildStatement(base::OnceCallback )>)::$_0&&, base::OnceCallback )>&&, bool&&, std::__Cr::vector > const&) ( bind_internal.h:647 )\n[ 05 ] void base::internal::InvokeHelper )>)::$_0&&, base::OnceCallback )>&&>, void, 0ul>::MakeItSo )>)::$_0, std::__Cr::tuple )>>, bool, std::__Cr::vector > const&>(brave_ads::BuildStatement(base::OnceCallback )>)::$_0&&, std::__Cr::tuple )>>&&, bool&&, std::__Cr::vector > const&) ( bind_internal.h:921 )\n[ 06 ] void base::internal::Invoker )>)::$_0&&, base::OnceCallback )>&&>, base::internal::BindState )>)::$_0, base::OnceCallback )>>, void (bool, std::__Cr::vector > const&)>::RunImpl )>)::$_0, std::__Cr::tuple )>>, 0ul>(brave_ads::BuildStatement(base::OnceCallback )>)::$_0&&, std::__Cr::tuple )>>&&, std::__Cr::integer_sequence , bool&&, std::__Cr::vector > const&) ( bind_internal.h:1058 )\n[ 07 ] base::internal::Invoker )>)::$_0&&, base::OnceCallback )>&&>, base::internal::BindState )>)::$_0, base::OnceCallback )>>, void (bool, std::__Cr::vector > const&)>::RunOnce(base::internal::BindStateBase*, bool, std::__Cr::vector > const&) ( bind_internal.h:971 )\n[ 08 ] base::OnceCallback ::Run(bool) && ( callback.h:156 )\n[ 09 ] content::RenderFrameHostImpl::RunModalConfirmDialog(std::__Cr::basic_string , std::__Cr::allocator > const&, bool, base::OnceCallback )::$_0::operator()(base::OnceCallback , bool, std::__Cr::basic_string , std::__Cr::allocator > const&) const ( render_frame_host_impl.cc:6468 )","author_login":"tmancey","author_association":"CONTRIBUTOR","created_at":"2025-02-13T13:57:38+08:00","repo_name":"brave/brave-browser","issue_id":2851121226,"issue_number":43946,"issue_url":"https://github.com/brave/brave-browser/issues/43946","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2713034916","fragment_type":"issue_comment","sequence":1,"text":"Verification INPROGRESS on\n\nBrave | 1.76.74 Chromium: 134.0.6998.89 (Official Build) (64-bit)\n-- | --\nRevision | f529926c39ddc08b1e0873f4b8befdca4984b492\nOS | Windows 10 Version 22H2 (Build 19045.5555)\n\n \n Test case 1 - PASSED \n\n* Start browser with fresh install\n EXPECTATION: `Brave Ads` is successfully started.\n* Open search.brave.software and search for `giraffe`\n\n \n\n* Click a search result ad\n EXPECTATION: Conversion URL patterns was added on brave://ads-internals page\n\n \n\n* Click `Clear Ads Data` button\n EXPECTATION: Brave Ads conversion URL patterns list becomes empty. Browser didn't crash.\n\n \n\n* Close the browser\n EXPECTATION: Browser didn't crash.\n\n \n\n \n\n \n Test case 2 - PASSED \n\n* Start browser with fresh install\n* Join Brave Rewards\n EXPECTATION: `Brave Ads` is successfully started.\n\n[14967:259:0310/133845.006751:VERBOSE1:ads_impl.cc(75)] Initializing ads\n[14967:259:0310/133845.061081:VERBOSE1:database_manager.cc(214)] Database is up to date on schema version 49\n[14967:259:0310/133845.061586:VERBOSE1:database_maintenance.cc(49)] Scheduled database maintenance in 0 hours, 1 minute, 0 seconds at 13:39:45.061\n[14967:259:0310/133845.061707:VERBOSE3:client_state_manager.cc(37)] Loading client state\n[14967:259:0310/133845.061726:VERBOSE3:ad_events_database_table_util.cc(32)] Successfully purged all orphaned ad events\n[14967:259:0310/133845.062150:VERBOSE3:client_state_manager.cc(129)] Successfully loaded client state\n[14967:259:0310/133845.062202:VERBOSE3:confirmation_state_manager.cc(40)] Loading confirmation state\n[14967:259:0310/133845.063042:VERBOSE3:confirmation_state_manager.cc(66)] Successfully loaded confirmation state\n[14967:259:0310/133845.063068:VERBOSE1:ads_impl.cc(446)] Successfully initialized ads\n\n* View any Brave ad\n* Open brave://rewards page\n EXPECTATION: Ads count is more then 0\n\n \n\n* Click `...` and `Disable and reset Rewards` button\n EXPECTATION: Brave Rewards was reset. Browser didn't crash.\n\n \n\n* Close the browser\n EXPECTATION: Browser didn't crash.","author_login":"GeetaSarvadnya","author_association":"NONE","created_at":"2025-03-11T07:51:24+08:00","repo_name":"brave/brave-browser","issue_id":2851121226,"issue_number":43946,"issue_url":"https://github.com/brave/brave-browser/issues/43946","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2713753738","fragment_type":"issue_comment","sequence":2,"text":"Verified with\n\nBrave | 1.76.74 Chromium: 134.0.6998.89 (Official Build) (64-bit)\n-- | --\nRevision | f529926c39ddc08b1e0873f4b8befdca4984b492\nOS | Linux\n\n \n Test case 1 - PASSED \n\n* Start browser with fresh install\n EXPECTATION: `Brave Ads` is successfully started.\n\n[71422:71422:0311/115836.573213:VERBOSE1:ads_impl.cc(424)] Successfully initialized ads\n\n* Open search.brave.software and search for `giraffe`\n\nImage\n\n* Click a search result ad\n EXPECTATION: Conversion URL patterns was added on brave://ads-internals page\n\nImage\n\n* Click `Clear Ads Data` button\n EXPECTATION: Brave Ads conversion URL patterns list becomes empty. Browser didn't crash.\n\nImage\n\n* Close the browser\n EXPECTATION: Browser didn't crash.\n\n \n\n \n Test case 2 - PASSED \n\n* Start browser with fresh install\n* Join Brave Rewards\n EXPECTATION: `Brave Ads` is successfully started.\n\n[72503:72503:0311/121454.386392:VERBOSE1:ads_impl.cc(424)] Successfully initialized ads\n\n* View any Brave ad\n* Open brave://rewards page\n EXPECTATION: Ads count is more then 0\n\nImage\n\n* Click `...` and `Disable and reset Rewards` button\n EXPECTATION: Brave Rewards was reset. Browser didn't crash.\n\nImage|Image\n--|--\n\n* Close the browser\n EXPECTATION: Browser didn't crash.","author_login":"btlechowski","author_association":"NONE","created_at":"2025-03-11T11:18:08+08:00","repo_name":"brave/brave-browser","issue_id":2851121226,"issue_number":43946,"issue_url":"https://github.com/brave/brave-browser/issues/43946","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2713905452","fragment_type":"issue_comment","sequence":3,"text":"Verification **PASSED** on\n\nBrave | 1.76.74 Chromium: 134.0.6998.89 (Official Build) (arm64)\n-- | --\nRevision | f529926c39ddc08b1e0873f4b8befdca4984b492\nOS | macOS Version 15.3.1 (Build 24D70)\n\n \n Test case 1 - PASSED \n\n* Start browser with fresh install\n EXPECTATION: `Brave Ads` is successfully started.\n* Open search.brave.software and search for `giraffe`\n\n \n\n* Click a search result ad\n EXPECTATION: Conversion URL patterns was added on brave://ads-internals page\n\n \n\n* Click `Clear Ads Data` button\n EXPECTATION: Brave Ads conversion URL patterns list becomes empty. Browser didn't crash.\n\n \n\n* Close the browser\n EXPECTATION: Browser didn't crash.\n\n \n\n \n\n \n Test case 2 - PASSED \n\n* Start browser with fresh install\n* Join Brave Rewards\n EXPECTATION: `Brave Ads` is successfully started.\n\n[2256:259:0311/171918.859798:VERBOSE1:ads_impl.cc(68)] Initializing ads\n[2256:259:0311/171918.971162:VERBOSE1:database_manager.cc(146)] Create database for schema version 45\n[2256:259:0311/171918.978499:VERBOSE1:database_manager.cc(172)] Created database for schema version 45\n[2256:259:0311/171918.979876:VERBOSE1:database_maintenance.cc(49)] Scheduled database maintenance in 0 hours, 1 minute, 0 seconds at 17:20:18.978\n[2256:259:0311/171918.982516:VERBOSE3:ad_events_database_table_util.cc(32)] Successfully purged all orphaned ad events\n[2256:259:0311/171918.983326:VERBOSE3:client_state_manager.cc(37)] Loading client state\n[2256:259:0311/171918.983500:VERBOSE3:client_state_manager.cc(116)] Client state does not exist, creating default state\n[2256:259:0311/171918.985724:VERBOSE3:confirmation_state_manager.cc(40)] Loading confirmation state\n[2256:259:0311/171918.985837:VERBOSE3:confirmation_state_manager.cc(54)] Confirmation state does not exist, creating default state\n[2256:259:0311/171918.985858:VERBOSE1:ads_impl.cc(424)] Successfully initialized ads\n\n* View any Brave ad\n* Open brave://rewards page\n EXPECTATION: Ads count is more then 0\n\nImage\n\n* Click `...` and `Disable and reset Rewards` button\n EXPECTATION: Brave Rewards was reset. Browser didn't crash.\n\n \n\n* Close the browser\n EXPECTATION: Browser didn't crash.","author_login":"GeetaSarvadnya","author_association":"NONE","created_at":"2025-03-11T12:00:13+08:00","repo_name":"brave/brave-browser","issue_id":2851121226,"issue_number":43946,"issue_url":"https://github.com/brave/brave-browser/issues/43946","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2713949764","fragment_type":"issue_comment","sequence":4,"text":"Verification in progress with\n\nBrave | 1.76.74 Chromium: 134.0.6998.89 (Official Build) (x86_64)\n-- | --\nRevision | f529926c39ddc08b1e0873f4b8befdca4984b492\nOS | macOS Version 14.7.4 (Build 23H420)","author_login":"LaurenWags","author_association":"MEMBER","created_at":"2025-03-11T12:11:18+08:00","repo_name":"brave/brave-browser","issue_id":2851121226,"issue_number":43946,"issue_url":"https://github.com/brave/brave-browser/issues/43946","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2714760951","fragment_type":"issue_comment","sequence":5,"text":"Verification passed on Brave v1.76.74 on Lenovo TB-8506FS (Android 11.0)\n\n#### Test case 3 (Android)\n\n \n\nStart browser with fresh install\nEXPECTATION: Brave Ads is successfully started.\n\n16:19:03.287 V [VERBOSE1:ads_impl.cc(424)] Successfully initialized ads\n\nOpen search.brave.software and search for giraffe\n\nImage\n\nClick a search result ad\nOpen brave://ads-internals page\nEXPECTATION: Conversion URL patterns was added on brave://ads-internals page\n\nImage\n\nClick Clear Ads Data button\nEXPECTATION: Brave Ads conversion URL patterns list becomes empty. Browser didn't crash.\n\nImage\n\nJoin Brave Rewards\nEXPECTATION: Brave Ads is successfully started.\n\nView any Brave ad\nOpen brave://rewards page\nEXPECTATION: Ads count is more then 0\n\nImage\n\nTap Reset button\nEXPECTATION: Brave Rewards was reset. Browser didn't crash.\n\nImage","author_login":"btlechowski","author_association":"NONE","created_at":"2025-03-11T15:27:00+08:00","repo_name":"brave/brave-browser","issue_id":2851121226,"issue_number":43946,"issue_url":"https://github.com/brave/brave-browser/issues/43946","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2717723127","fragment_type":"issue_comment","sequence":6,"text":"Verification passed on 1.76.76 on iPhone 13 Pro Max (iOS 18.3.1)\n\n#### Test case 4 (iOS)\n\n \n\nStart browser with fresh install\nEXPECTATION: Brave Ads is successfully started.\n\ninfo 13:21:37.416675+0100 Client [ads] Successfully initialized ads\n\nOpen search.brave.software and search for giraffe\nClick a search result ad\nOpen brave://ads-internals page\nEXPECTATION: Conversion URL patterns was added on brave://ads-internals page\n\nImage\n\nClick Clear Ads Data button\nEXPECTATION: Brave Ads conversion URL patterns list becomes empty. Browser didn't crash.\n\nImage","author_login":"btlechowski","author_association":"NONE","created_at":"2025-03-12T12:26:48+08:00","repo_name":"brave/brave-browser","issue_id":2851121226,"issue_number":43946,"issue_url":"https://github.com/brave/brave-browser/issues/43946","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0376","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Question: How many threads can there be by default?","query_context":"Hi\nDoes RestAssured have a limit on the number of threads?\nIf so, how is it installed and what is the default?\n\nAlso a question about the maximum waiting time for a request to be completed.\nWhat is it like? How can I set a different value?","known_context_document_ids":["gh_issue_1904922028"],"reference_answer":"I'm closing this for now, I've done a bit of research and running the tests and monitoring using `netstat -a` didn't show any obvious problems here.\n\nWill reopen when new information emerges or when a problem is reported by a user.","answer_document_id":"gh_comment_1882711458","silver_evidence_path":["gh_comment_1728944839","gh_issue_1872902001","gh_comment_1882711458"],"evidence_issue_ids":[1904922028,1872902001],"source_repo_name":"basdijkstra/rest-assured-net","source_issue_id":1904922028,"source_issue_number":108,"source_issue_url":"https://github.com/basdijkstra/rest-assured-net/issues/108","target_repo_name":"basdijkstra/rest-assured-net","target_issue_id":1872902001,"target_issue_number":107,"target_issue_url":"https://github.com/basdijkstra/rest-assured-net/issues/107","reference_anchor_document_id":"gh_comment_1728944839","reference_answer_author":"basdijkstra","reference_answer_author_association":"OWNER","quality_score":91.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3529,"anchor_target_overlap":0.1333,"target_answer_overlap":0.0},"issue_created_at":"2023-09-20T12:46:44+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_1904922028","fragment_type":"issue_description","sequence":0,"text":"Question: How many threads can there be by default?\nHi\nDoes RestAssured have a limit on the number of threads?\nIf so, how is it installed and what is the default?\n\nAlso a question about the maximum waiting time for a request to be completed.\nWhat is it like? How can I set a different value?","author_login":"workmichsem","author_association":"NONE","created_at":"2023-09-20T12:46:44+08:00","repo_name":"basdijkstra/rest-assured-net","issue_id":1904922028,"issue_number":108,"issue_url":"https://github.com/basdijkstra/rest-assured-net/issues/108","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1728774173","fragment_type":"issue_comment","sequence":1,"text":"There is one more question\nCan I see the response size in kilobytes?","author_login":"workmichsem","author_association":"NONE","created_at":"2023-09-21T04:40:40+08:00","repo_name":"basdijkstra/rest-assured-net","issue_id":1904922028,"issue_number":108,"issue_url":"https://github.com/basdijkstra/rest-assured-net/issues/108","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1728944839","fragment_type":"issue_comment","sequence":2,"text":"Hey @workmichsem,\n\nregarding the maximum number of connections: since I'm using `Sytem.Net.Http.HttpClient` under the hood, this is probably the default value for `System.Net.Http.HttpClientHandler.MaxConnectionsPerServer`, which defaults to `int.MaxValue`: URL \n\nThis might change due to #107, but I haven't had the time to work on that yet.\n\nThe maximum waiting time, or rather the `HttpClient` timeout, defaults to 100 seconds, but can be changed: URL \n\nThe response size in bytes can typically be found in the `Content-Length` header of the response. You can write a verification against it: URL (this uses the actual response body length, by the way, not the value of the `Content-Length` header). You can also calculate the length yourself by extracting the response body as a `string` and calculating its value. See also #92.\n\nHope that helps, if not, feel free to ask :)","author_login":"basdijkstra","author_association":"OWNER","created_at":"2023-09-21T06:41:07+08:00","repo_name":"basdijkstra/rest-assured-net","issue_id":1904922028,"issue_number":108,"issue_url":"https://github.com/basdijkstra/rest-assured-net/issues/108","linked_issue_ids":[1872902001],"is_known_query_context":false},{"document_id":"gh_comment_1729043093","fragment_type":"issue_comment","sequence":3,"text":"Thank you very much for your answers!\n\nRegarding the number of threads. So there is no way to change this value now? If not, will it be possible in the future?","author_login":"workmichsem","author_association":"NONE","created_at":"2023-09-21T07:53:36+08:00","repo_name":"basdijkstra/rest-assured-net","issue_id":1904922028,"issue_number":108,"issue_url":"https://github.com/basdijkstra/rest-assured-net/issues/108","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1729097350","fragment_type":"issue_comment","sequence":4,"text":"No, there is no way to change this at the moment. What is your use case for this? It shouldn't be too hard to add a method to configure this, but I'm curious to see why you would need it.\n\nAlso, once I start working on #107 this might become possible, too.","author_login":"basdijkstra","author_association":"OWNER","created_at":"2023-09-21T08:27:14+08:00","repo_name":"basdijkstra/rest-assured-net","issue_id":1904922028,"issue_number":108,"issue_url":"https://github.com/basdijkstra/rest-assured-net/issues/108","linked_issue_ids":[1872902001],"is_known_query_context":false},{"document_id":"gh_comment_1729129361","fragment_type":"issue_comment","sequence":5,"text":"Just trying to understand what the limitations are\nThank you very much for the information","author_login":"workmichsem","author_association":"NONE","created_at":"2023-09-21T08:47:29+08:00","repo_name":"basdijkstra/rest-assured-net","issue_id":1904922028,"issue_number":108,"issue_url":"https://github.com/basdijkstra/rest-assured-net/issues/108","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1729143081","fragment_type":"issue_comment","sequence":6,"text":"No problem!\n\nI just remembered something: you _can_ configure the maximum number of connections yourself by injecting an `HttpClient` of your own and configuring the `MaxConnectionsPerServer` property on the `HttpClientHandler` associated with the client.\n\nSee URL \n\nIf this is enough information for you, please close the issue. If not, leave it open and ask away :)","author_login":"basdijkstra","author_association":"OWNER","created_at":"2023-09-21T08:56:29+08:00","repo_name":"basdijkstra/rest-assured-net","issue_id":1904922028,"issue_number":108,"issue_url":"https://github.com/basdijkstra/rest-assured-net/issues/108","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1872902001","fragment_type":"issue_description","sequence":0,"text":"See if there’s a more efficient way of dealing with HttpClient\nSee URL for more information.","author_login":"basdijkstra","author_association":"OWNER","created_at":"2023-08-30T04:57:12+08:00","repo_name":"basdijkstra/rest-assured-net","issue_id":1872902001,"issue_number":107,"issue_url":"https://github.com/basdijkstra/rest-assured-net/issues/107","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1700370226","fragment_type":"issue_comment","sequence":1,"text":"First step would be to see if HttpClientFactory provides a solution to this.","author_login":"basdijkstra","author_association":"OWNER","created_at":"2023-08-31T05:01:03+08:00","repo_name":"basdijkstra/rest-assured-net","issue_id":1872902001,"issue_number":107,"issue_url":"https://github.com/basdijkstra/rest-assured-net/issues/107","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1882711458","fragment_type":"issue_comment","sequence":2,"text":"I'm closing this for now, I've done a bit of research and running the tests and monitoring using `netstat -a` didn't show any obvious problems here.\n\nWill reopen when new information emerges or when a problem is reported by a user.","author_login":"basdijkstra","author_association":"OWNER","created_at":"2024-01-09T09:34:58+08:00","repo_name":"basdijkstra/rest-assured-net","issue_id":1872902001,"issue_number":107,"issue_url":"https://github.com/basdijkstra/rest-assured-net/issues/107","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0386","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Deploying from `x86_64-linux` to `aarch64-linux`?","query_context":"Hello,\n\nI would like to deploy updates to my Raspberry router using Deploy-rs. A work-in-progress commit has been made in my config, you can find it here.\n\nWhen I run the command: `deploy .#router` (_`router` is my raspberry machine_), it downloaded ~1.2Gb and then, I got this issue.\n\n$ deploy .#router\n🚀 ℹ [deploy] [INFO] Running checks for flake in .\nwarning: unknown flake output 'deploy'\n🚀 ℹ [deploy] [INFO] Evaluating flake in .\n🚀 ℹ [deploy] [INFO] The following profiles are going to be deployed:\n[router.system]\nuser = \"root\"\nssh_user = \"pol\"\npath = \"/nix/store/xlz3rd2dfkya33rjr1q6l1j849mh4lyw-activatable-nixos-system-router-23.11.20230607.381e92a\"\nhostname = \"router\"\nssh_opts = []\n\n🚀 ℹ [deploy] [INFO] Building profile `system` for node `router`\nerror: a 'aarch64-linux' with features {} is required to build '/nix/store/c6mljancr1wmnc0vqgwwwi8ic86krix4-builder.pl.drv', but I am a 'x86_64-linux' with features {benchmark, big-parallel, kvm, nixos-test}\n🚀 ❌ [deploy] [ERROR] Failed to push profile: Nix build command resulted in a bad exit code: Some(1)\n\nCould you please help me by telling me if the `deploy-rs` has been correctly done (based on the commit) and if you have a solution on the issue I currently have ?\n\nThanks in advance.","known_context_document_ids":["gh_issue_1749447893"],"reference_answer":"Oh, AFAICS, build failure happens during checks build, which indeed needs target system capability for building the profile locally as a part of the check. A solution to this is to provide `--skip-checks` option","answer_document_id":"gh_comment_1590761310","silver_evidence_path":["gh_comment_1589022531","gh_issue_1669828363","gh_comment_1590761310"],"evidence_issue_ids":[1749447893,1669828363],"source_repo_name":"serokell/deploy-rs","source_issue_id":1749447893,"source_issue_number":219,"source_issue_url":"https://github.com/serokell/deploy-rs/issues/219","target_repo_name":"serokell/deploy-rs","target_issue_id":1669828363,"target_issue_number":200,"target_issue_url":"https://github.com/serokell/deploy-rs/issues/200","reference_anchor_document_id":"gh_comment_1589022531","reference_answer_author":"rvem","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1429,"anchor_target_overlap":0.2381,"target_answer_overlap":0.15},"issue_created_at":"2023-06-09T08:52:45+08:00","valid_comment_count":18,"fragments":[{"document_id":"gh_issue_1749447893","fragment_type":"issue_description","sequence":0,"text":"Deploying from `x86_64-linux` to `aarch64-linux`\nHello,\n\nI would like to deploy updates to my Raspberry router using Deploy-rs. A work-in-progress commit has been made in my config, you can find it here.\n\nWhen I run the command: `deploy .#router` (_`router` is my raspberry machine_), it downloaded ~1.2Gb and then, I got this issue.\n\n$ deploy .#router\n🚀 ℹ [deploy] [INFO] Running checks for flake in .\nwarning: unknown flake output 'deploy'\n🚀 ℹ [deploy] [INFO] Evaluating flake in .\n🚀 ℹ [deploy] [INFO] The following profiles are going to be deployed:\n[router.system]\nuser = \"root\"\nssh_user = \"pol\"\npath = \"/nix/store/xlz3rd2dfkya33rjr1q6l1j849mh4lyw-activatable-nixos-system-router-23.11.20230607.381e92a\"\nhostname = \"router\"\nssh_opts = []\n\n🚀 ℹ [deploy] [INFO] Building profile `system` for node `router`\nerror: a 'aarch64-linux' with features {} is required to build '/nix/store/c6mljancr1wmnc0vqgwwwi8ic86krix4-builder.pl.drv', but I am a 'x86_64-linux' with features {benchmark, big-parallel, kvm, nixos-test}\n🚀 ❌ [deploy] [ERROR] Failed to push profile: Nix build command resulted in a bad exit code: Some(1)\n\nCould you please help me by telling me if the `deploy-rs` has been correctly done (based on the commit) and if you have a solution on the issue I currently have ?\n\nThanks in advance.","author_login":"drupol","author_association":"NONE","created_at":"2023-06-09T08:52:45+08:00","repo_name":"serokell/deploy-rs","issue_id":1749447893,"issue_number":219,"issue_url":"https://github.com/serokell/deploy-rs/issues/219","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1589022531","fragment_type":"issue_comment","sequence":1,"text":"Hi! Looks similar to URL \nCurrently, there are two solutions: either enable aarch64 cross-compilation on a machine you're deploying from (by setting `boot.binfmt.emulatedSystems = [ \"aarch64-linux\" ]`), or using `remoteBuild = true;` in case your target machine is powerful enough","author_login":"rvem","author_association":"MEMBER","created_at":"2023-06-13T10:33:28+08:00","repo_name":"serokell/deploy-rs","issue_id":1749447893,"issue_number":219,"issue_url":"https://github.com/serokell/deploy-rs/issues/219","linked_issue_ids":[1669828363],"is_known_query_context":false},{"document_id":"gh_comment_1677761203","fragment_type":"issue_comment","sequence":2,"text":"@rvem Can we use crossSystem(instead of emulatedSystems) here?","author_login":"ryan4yin","author_association":"NONE","created_at":"2023-08-14T17:25:47+08:00","repo_name":"serokell/deploy-rs","issue_id":1749447893,"issue_number":219,"issue_url":"https://github.com/serokell/deploy-rs/issues/219","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2343269533","fragment_type":"issue_comment","sequence":3,"text":"Anyone got a working example on how to do cross builds and deploys?\nI am looking for all combination of:\n\n**Host**:\nx86_64-linux\naarch64-darwin\n\n**Target**:\naarch64-linux\nx86_64-linux","author_login":"tcurdt","author_association":"NONE","created_at":"2024-09-11T10:33:46+08:00","repo_name":"serokell/deploy-rs","issue_id":1749447893,"issue_number":219,"issue_url":"https://github.com/serokell/deploy-rs/issues/219","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2344004197","fragment_type":"issue_comment","sequence":4,"text":"@tcurdt The solution I found is switch to colmena, which supports custom `nixpkgs` instance by its `meta.nixpkgs` & `meta.nodeNixpkgs` parameters.","author_login":"ryan4yin","author_association":"NONE","created_at":"2024-09-11T15:32:02+08:00","repo_name":"serokell/deploy-rs","issue_id":1749447893,"issue_number":219,"issue_url":"https://github.com/serokell/deploy-rs/issues/219","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1669828363","fragment_type":"issue_description","sequence":0,"text":"Aarch64 cross compilation errors\nI'm trying to deploy some configurations to Aarch64 nodes from an X86_64 node running Linux.\n\nI managed to cross compile my configuration without issued but it failed with the following error:\n\n🚀 ℹ️ [deploy] [INFO] Activating profile `system` for node `nixpi`\n[sudo] password for pi:\n/nix/store/kwic2s1xgzl3j7spjvqsl0xswaa9p2w2-activatable-nixos-system-nixpi-23.05.20230412.fe2ecaf/activate-rs: line 2: /nix/store/5zcrj0jp36ckjbxw5j4nj6b18nzid5rv-deploy-rs-0.1.0/bin/activate: cannot execute binary file: Exec format error\n/nix/store/kwic2s1xgzl3j7spjvqsl0xswaa9p2w2-activatable-nixos-system-nixpi-23.05.20230412.fe2ecaf/activate-rs: line 2: /nix/store/5zcrj0jp36ckjbxw5j4nj6b18nzid5rv-deploy-rs-0.1.0/bin/activate: Success\nConnection to 192.168.1.251 closed.\n\nHere is the corresponding deploy-rs node configuration:\n\nnix\nnixpi = {\n hostname = \"192.168.1.251\";\n sshUser = \"pi\";\n sshOpts = [\"-t\"];\n magicRollback = false; # In order for sshOpts \"-t\" to work, see URL \n profiles.system = {\n user = \"root\";\n # path = deploy-rs.lib.aarch64-linux.activate.nixos self.nixosConfigurations.nixpi;\n path = deploy-rs.lib.x86_64-linux.activate.nixos self.nixosConfigurations.nixpi;\n };\n};\n\nAs you might notice I'm using \"deploy-rs.lib.**x86_64-linux**.activate.nixos self.nixosConfigurations.nixpi\". From what I understand while all my configuration has been cross-compiled, the final binary to run `activate` has been compiled native to my builder node so x86_64 instead of aarch64.\n\nWhen I try to use \"deploy-rs.lib.**aarch64-linux**.activate.nixos self.nixosConfigurations.nixpi\" I get this error:\n\nerror: a 'aarch64-linux' with features {} is required to build '/nix/store/c6mljancr1wmnc0vqgwwwi8ic86krix4-builder.pl.drv', but I am a 'x86_64-linux' with features {benchmark, big-parallel, kvm, nixos-test}\n🚀 ❌ [deploy] [ERROR] Failed to push profile: Nix build command resulted in a bad exit code: Some(1)\n\nWhile I could activate binfmt emulation using `boot.binfmt.emulatedSystems = [ \"aarch64-linux\" ]` and make this work the build time are atrociously slow to the point where a small config from scratch is taking almost 24h to build.\n\nIs there a way to tell deploy-rs to use `pkgsCross.aarch64-multiplatform` instead?","author_login":"Skallwar","author_association":"NONE","created_at":"2023-04-16T10:01:23+08:00","repo_name":"serokell/deploy-rs","issue_id":1669828363,"issue_number":200,"issue_url":"https://github.com/serokell/deploy-rs/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1510679168","fragment_type":"issue_comment","sequence":1,"text":"As a temporary workaround, you can try to use `deploy-rs.lib.aarch64-linux.activate.nixos` with `remoteBuild = true` in order to build the entire profile on the target machine","author_login":"rvem","author_association":"MEMBER","created_at":"2023-04-17T04:28:30+08:00","repo_name":"serokell/deploy-rs","issue_id":1669828363,"issue_number":200,"issue_url":"https://github.com/serokell/deploy-rs/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1511073391","fragment_type":"issue_comment","sequence":2,"text":"Thanks for tip. This will work on some of my nodes, but some of them won't as they have less than 1G ram and just dies trying to build something","author_login":"Skallwar","author_association":"NONE","created_at":"2023-04-17T10:14:35+08:00","repo_name":"serokell/deploy-rs","issue_id":1669828363,"issue_number":200,"issue_url":"https://github.com/serokell/deploy-rs/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1514591273","fragment_type":"issue_comment","sequence":3,"text":"did you actually try this out? I tried something similar before and I don't remember it taking that long to build. what processor are you running this on?","author_login":"PhilTaken","author_association":"CONTRIBUTOR","created_at":"2023-04-19T11:47:14+08:00","repo_name":"serokell/deploy-rs","issue_id":1669828363,"issue_number":200,"issue_url":"https://github.com/serokell/deploy-rs/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1515289630","fragment_type":"issue_comment","sequence":4,"text":"Yes I tried. I'm running a i7-1185G7 but it's clocking a bit low (1.2Ghz, I need to take some time to configure throttled). When I have the bare minimum it's okish, around 8h but when I tried to add more stuff (an editor, nginx, ...) it is not manageable, build time explode.\n\nFor now I don't have a choice so that's what I'm doing, not updating often and not clearing my nix store. But it is not a solution in my opinion","author_login":"Skallwar","author_association":"NONE","created_at":"2023-04-19T19:49:01+08:00","repo_name":"serokell/deploy-rs","issue_id":1669828363,"issue_number":200,"issue_url":"https://github.com/serokell/deploy-rs/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1515963909","fragment_type":"issue_comment","sequence":5,"text":"do you what it's building? it should pull most stuff from the binary cache","author_login":"PhilTaken","author_association":"COLLABORATOR","created_at":"2023-04-20T08:53:27+08:00","repo_name":"serokell/deploy-rs","issue_id":1669828363,"issue_number":200,"issue_url":"https://github.com/serokell/deploy-rs/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1518566608","fragment_type":"issue_comment","sequence":6,"text":"@Skallwar \n \n\nI may be mixed up or there's some issues in the way of it, but I am pretty sure this is not the case. The `activate` functions create an activatable derivation, an activatable derivation is the same as the original, but with the activation script, and `activate` binary included. The `activate` binary is executed on the remote host and manages the activation (stuff like rolling back when unconfirmed), so will need to be native to the target, and doesn't get used at all locally.","author_login":"notgne2","author_association":"CONTRIBUTOR","created_at":"2023-04-22T08:47:00+08:00","repo_name":"serokell/deploy-rs","issue_id":1669828363,"issue_number":200,"issue_url":"https://github.com/serokell/deploy-rs/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1519033000","fragment_type":"issue_comment","sequence":7,"text":"Sadly this doesn't work for me - I tried `remoteBuild = true;` and cli flag, but still get:\n\n$ deploy --remote-build -d .#raspi-workshop\n🚀 ❓ [deploy] [DEBUG] Checking for flake support\n🚀 ℹ️ [deploy] [INFO] Running checks for flake in .\nerror: a 'aarch64-linux' with features {} is required to build '/nix/store/c6mljancr1wmnc0vqgwwwi8ic86krix4-builder.pl.drv', but I am a 'x86_64-linux' with features {benchmark, big-parallel, ca-derivations, kvm, nixos-test, uid-range}\n🚀 ❌ [deploy] [ERROR] Failed to check deployment: Nix checking command resulted in a bad exit code: Some(1)\n\nAnd I don't know how to use binfmt idea as I'm not on NixOS... :cry: \n\nIn case anyone finds a solution, please let me know (I will too :yum: )","author_login":"tennox","author_association":"NONE","created_at":"2023-04-23T10:55:17+08:00","repo_name":"serokell/deploy-rs","issue_id":1669828363,"issue_number":200,"issue_url":"https://github.com/serokell/deploy-rs/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1523357178","fragment_type":"issue_comment","sequence":8,"text":"@notgne2 \n \n\nBut the activate binary was built on the host pc not the remote one right? So if my host pc is x86_64 and the remote one is aarch64, the activate binary might be a x86_64 binary trying to run on an aarch64 machine?","author_login":"Skallwar","author_association":"NONE","created_at":"2023-04-26T12:43:18+08:00","repo_name":"serokell/deploy-rs","issue_id":1669828363,"issue_number":200,"issue_url":"https://github.com/serokell/deploy-rs/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1523912500","fragment_type":"issue_comment","sequence":9,"text":"`deploy-rs.lib.x86_64-linux.activate.nixos [derivation]` will give you an x86_64 activate binary, `deploy-rs.lib.aarch64-linux.activate.nixos [derivation]` will give you an aarch64 activate binary. There may or may not be errors attempting cross compiling it if you do it the latter way, but activation will fail if you don't.","author_login":"notgne2","author_association":"CONTRIBUTOR","created_at":"2023-04-26T19:07:12+08:00","repo_name":"serokell/deploy-rs","issue_id":1669828363,"issue_number":200,"issue_url":"https://github.com/serokell/deploy-rs/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1524028739","fragment_type":"issue_comment","sequence":10,"text":"I was using this one `deploy-rs.lib.x86_64-linux.activate.nixos` and it failed during activation. \n\nAnyway, at stated in a previous comment, the error was on my configuration which forced cross compilation. Using `boot.binfmt.emulatedSystems = [ \"aarch64-linux\" ]` without the 2 lines mentioned work correctly and is fast enough using the cache.\n\nThanks for your help everyone","author_login":"Skallwar","author_association":"NONE","created_at":"2023-04-26T20:50:11+08:00","repo_name":"serokell/deploy-rs","issue_id":1669828363,"issue_number":200,"issue_url":"https://github.com/serokell/deploy-rs/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1524030684","fragment_type":"issue_comment","sequence":11,"text":"@tennox \n \n\nYour distribution should have a package for this. For example on ubuntu: URL Installing this should fix your issue I think","author_login":"Skallwar","author_association":"NONE","created_at":"2023-04-26T20:52:15+08:00","repo_name":"serokell/deploy-rs","issue_id":1669828363,"issue_number":200,"issue_url":"https://github.com/serokell/deploy-rs/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1590338646","fragment_type":"issue_comment","sequence":12,"text":"Is there a reason `remoteBuild = true` doesn't solve this issue? I understand in some cases you want to build on the deploying machine with qemu, but as @tennox suggests, using remote build still throws an error complaining about the capabilities of the deploying machine.","author_login":"mattvaughan","author_association":"NONE","created_at":"2023-06-14T02:15:32+08:00","repo_name":"serokell/deploy-rs","issue_id":1669828363,"issue_number":200,"issue_url":"https://github.com/serokell/deploy-rs/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1590550661","fragment_type":"issue_comment","sequence":13,"text":"The activation script still needs to be built on the deploying machine, as far as I understand.","author_login":"tennox","author_association":"NONE","created_at":"2023-06-14T06:25:36+08:00","repo_name":"serokell/deploy-rs","issue_id":1669828363,"issue_number":200,"issue_url":"https://github.com/serokell/deploy-rs/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1590761310","fragment_type":"issue_comment","sequence":14,"text":"Oh, AFAICS, build failure happens during checks build, which indeed needs target system capability for building the profile locally as a part of the check. A solution to this is to provide `--skip-checks` option","author_login":"rvem","author_association":"MEMBER","created_at":"2023-06-14T08:51:45+08:00","repo_name":"serokell/deploy-rs","issue_id":1669828363,"issue_number":200,"issue_url":"https://github.com/serokell/deploy-rs/issues/200","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0402","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Vite CJS build warning caused by import of `unoCSSConfig` from `@tutorialkit/astro`?","query_context":"### Describe the bug\n\nWhen TutorialKit is started in development or build mode, Vite's CJS build entrypoint error is shown:\n\n$ pnpm dev\n...\nThe CJS build of Vite's Node API is deprecated. See URL for more details.\n\n### Steps to reproduce\n\nsh\n$ pnpm create tutorial\n\n$ pnpm dev\n...\nThe CJS build of Vite's Node API is deprecated. See URL for more details.\n\ndiff\n$ code uno.config.ts\n\n- import { unoCSSConfig } from '@tutorialkit/astro';\n\nexport default defineConfig({\n- ...unoCSSConfig,\n\nsh\n$ pnpm dev\n\n# No warnings\n\n### Expected behavior\n\nNo warning should be shown\n\n### Platform\n\n- TutorialKit version: 0.1.4","known_context_document_ids":["gh_issue_2465458144"],"reference_answer":"@Barbapapazes Thanks for the pointer! This `mergeConfigs` function from `unocss` seems to be what we're looking for 👀","answer_document_id":"gh_comment_2273794340","silver_evidence_path":["gh_comment_2288811681","gh_issue_2411671343","gh_comment_2273794340"],"evidence_issue_ids":[2465458144,2411671343],"source_repo_name":"stackblitz/tutorialkit","source_issue_id":2465458144,"source_issue_number":244,"source_issue_url":"https://github.com/stackblitz/tutorialkit/issues/244","target_repo_name":"stackblitz/tutorialkit","target_issue_id":2411671343,"target_issue_number":144,"target_issue_url":"https://github.com/stackblitz/tutorialkit/issues/144","reference_anchor_document_id":"gh_comment_2288811681","reference_answer_author":"Nemikolh","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1714,"anchor_target_overlap":0.2571,"target_answer_overlap":0.25},"issue_created_at":"2024-08-14T10:25:10+08:00","valid_comment_count":4,"fragments":[{"document_id":"gh_issue_2465458144","fragment_type":"issue_description","sequence":0,"text":"Vite CJS build warning caused by import of `unoCSSConfig` from `@tutorialkit/astro`\n### Describe the bug\n\nWhen TutorialKit is started in development or build mode, Vite's CJS build entrypoint error is shown:\n\n$ pnpm dev\n...\nThe CJS build of Vite's Node API is deprecated. See URL for more details.\n\n### Steps to reproduce\n\nsh\n$ pnpm create tutorial\n\n$ pnpm dev\n...\nThe CJS build of Vite's Node API is deprecated. See URL for more details.\n\ndiff\n$ code uno.config.ts\n\n- import { unoCSSConfig } from '@tutorialkit/astro';\n\nexport default defineConfig({\n- ...unoCSSConfig,\n\nsh\n$ pnpm dev\n\n# No warnings\n\n### Expected behavior\n\nNo warning should be shown\n\n### Platform\n\n- TutorialKit version: 0.1.4","author_login":"AriPerkkio","author_association":"MEMBER","created_at":"2024-08-14T10:25:10+08:00","repo_name":"stackblitz/tutorialkit","issue_id":2465458144,"issue_number":244,"issue_url":"https://github.com/stackblitz/tutorialkit/issues/244","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2288788670","fragment_type":"issue_comment","sequence":1,"text":"Not sure why but seems to be caused by spreading `...unoCSSConfig` instead of using the variables from `import { rules, shortcuts, theme } from \"@tutorialkit/theme\";`\n\nThe UnoCSS config could also be made into a preset if that's easier:\n\n`presetTutorialKit.ts`\n\nts\nimport { definePreset } from \"unocss\"\nimport { rules, shortcuts, theme } from \"@tutorialkit/theme\";\n\nexport default definePreset(() => {\n return {\n name: 'presetTutorialKit',\n rules,\n shortcuts,\n theme\n }\n})\n\n`uno.config.ts` (removing `...unoCSSConfig`)\n\nts\n presets: [\n presetUno({\n dark: {\n dark: '[data-theme=\"dark\"]',\n },\n }),\n presetTutorialKit(),","author_login":"henrikvilhelmberglund","author_association":"CONTRIBUTOR","created_at":"2024-08-14T13:40:27+08:00","repo_name":"stackblitz/tutorialkit","issue_id":2465458144,"issue_number":244,"issue_url":"https://github.com/stackblitz/tutorialkit/issues/244","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2288811681","fragment_type":"issue_comment","sequence":2,"text":"I think this is happening when `unocss` imports the `uno.config.ts`, and that file imports `'@tutorialkit/astro'` that has imports for Astro stuff. Not sure why `unocss` decides to use CJS here.\n\nWe are planning to move most, if not all (?) `uno.config.ts` inside `@tutorialkit/*` packages so that end-users wouldn't have to maintain that file. Ideally tutorials wouldn't even have to create `uno.config.ts` unless they explicitly wanted to extend that. There's some discussion on URL","author_login":"AriPerkkio","author_association":"MEMBER","created_at":"2024-08-14T13:49:07+08:00","repo_name":"stackblitz/tutorialkit","issue_id":2465458144,"issue_number":244,"issue_url":"https://github.com/stackblitz/tutorialkit/issues/244","linked_issue_ids":[2411671343],"is_known_query_context":false},{"document_id":"gh_issue_2411671343","fragment_type":"issue_description","sequence":0,"text":"Roadmap to 1.0\nHey there! \n\nThanks for showing interest in using TutorialKit! We are currently planning to do a 1.0 release and we're excited to share a list of the changes that we are intending to make before the release.\n\n#### Planned Changes\n\n* [x] :rotating_light: Renaming `tutorialkit` to `@tutorialkit/cli`. So we can use that name for the vscode extension and also because the `npm create tutorial` command is the recommended way to create a new tutorial.\n * URL \n* [x] :rotating_light: Renaming `@tutorialkit/components-react` to `@tutorialkit/react` and move it from `components/react` to `react`. Simpler name and descriptive enough.\n * URL \n* [x] :rotating_light: Update `src/content/config.ts` to import the full schema from `@tutorialkit/types`.\n * URL \n* [x] :rotating_light: UnoCSS config:\n * [x] Use a deep merge strategy and move default presets and transformers in `@tutorialkit/theme`.\n * URL \n * [x] Find a way to remove `content.inline`\n * URL \n* [x] :book: Document docs on how tow write your own component with `tutorialkit:store`\n * URL \n* [x] :book: Document that `tutorialkit:core` provide low level access to webcontainer and is to be used only as a last resort\n * URL \n* [x] :book: Document that using `@tutorialkit/react` without TutorialKit is experimental\n * URL \n* [x] Have `create-tutorial` depend on `\"@tutorialkit/cli\": \"latest\"` and release a fire and forget version.\n * URL \n* [x] Remove `.vscode/settings.json`.\n * URL \n* [x] Add TutorialKit extension to the list of recommended extension in the generated template.\n * URL \n* [x] Extension: \n * [x] Frontmatter autocomplete:\n * #143 \n * [x] Support folder-based and config-based ordering\n * #223\n * [x] Part, chapter, lesson deletion\n * #223\n\n#### Nice to have, some post 1.0.0 launch:\n\n* [ ] Have the default tutorial generated showcase all of the features of TutorialKit (ala slidev)\n* [x] JSDocs on `TutorialStore` class\n* [ ] VSCode Extension\n * [ ] Automated releases\n * [ ] Inheritance information\n * [ ] Drag and drop ordering for lesson / chapter / parts\n* [ ] \"Checks\" to prevent navigation to next lesson until current checks have passed\n* [ ] Syntax highlighting for\n * [x] Vue\n * #256 \n * [x] Svelte\n * #212 \n * [ ] Astro\n* [ ] Monaco as an alternative option to CodeMirror\n* [ ] Opt-in TypeScript intellisense","author_login":"Nemikolh","author_association":"MEMBER","created_at":"2024-07-16T17:19:19+08:00","repo_name":"stackblitz/tutorialkit","issue_id":2411671343,"issue_number":144,"issue_url":"https://github.com/stackblitz/tutorialkit/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2270948576","fragment_type":"issue_comment","sequence":1,"text":"For the UnoCSS part, a similar solution to this one, URL used in Slidev could be used? This could help to simplify the DX and the starter.","author_login":"Barbapapazes","author_association":"NONE","created_at":"2024-08-06T10:32:26+08:00","repo_name":"stackblitz/tutorialkit","issue_id":2411671343,"issue_number":144,"issue_url":"https://github.com/stackblitz/tutorialkit/issues/144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2273794340","fragment_type":"issue_comment","sequence":2,"text":"@Barbapapazes Thanks for the pointer! This `mergeConfigs` function from `unocss` seems to be what we're looking for 👀","author_login":"Nemikolh","author_association":"MEMBER","created_at":"2024-08-07T15:51:38+08:00","repo_name":"stackblitz/tutorialkit","issue_id":2411671343,"issue_number":144,"issue_url":"https://github.com/stackblitz/tutorialkit/issues/144","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0405","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Update GOVERNANCE to include sub project voting?","query_context":"Outside of it being easier to find the governance of the project (e.g., I usually look for a GOVERNANCE.md file or a community repo), I'd like to ensure the voting is done in a transparent way.\n\nAs I understand it, all the governance is currently here: URL \n\nI see that it is being followed by adding maintainers, e.g., URL \n\nThere's been confusion in public how certain decisions have been made in the project which is an opportunity for clarity and growth imho: URL \n\nFor tetragon, do you have an example of where the vote happened for this? I recall that when the project was being moved to CNCF, some of the votes were happening in the Cilium Slack which isn't a best practice and we recommended recording everything on github and/or mailing list. If a vote can't be dug up, the CNCF requests that you correct things to reflect what is stated in your governance. If you need help on how to do this, look at other CNCF projects e.g., URL \n\nIf you want to use a tool that helps, we have URL in CNCF that can help with voting.","known_context_document_ids":["gh_issue_2102398540"],"reference_answer":"Something else that I think would help with this discussion is: What do we need beyond just having a maintainer create the repo? What expectations or obligations are there that we need to satisfy for any new repo (whether freshly created due to contributions within the Cilium organization, or as a fork from an external repo for Cilium organization usage).","answer_document_id":"gh_comment_1910942150","silver_evidence_path":["gh_comment_1912274548","gh_issue_1715466325","gh_comment_1910942150"],"evidence_issue_ids":[2102398540,1715466325],"source_repo_name":"cilium/community","source_issue_id":2102398540,"source_issue_number":82,"source_issue_url":"https://github.com/cilium/community/issues/82","target_repo_name":"cilium/community","target_issue_id":1715466325,"target_issue_number":27,"target_issue_url":"https://github.com/cilium/community/issues/27","reference_anchor_document_id":"gh_comment_1912274548","reference_answer_author":"joestringer","reference_answer_author_association":"MEMBER","quality_score":80.17,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.1918,"anchor_target_overlap":0.102,"target_answer_overlap":0.0435},"issue_created_at":"2024-01-26T15:21:26+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_2102398540","fragment_type":"issue_description","sequence":0,"text":"Update GOVERNANCE to include sub project voting\nOutside of it being easier to find the governance of the project (e.g., I usually look for a GOVERNANCE.md file or a community repo), I'd like to ensure the voting is done in a transparent way.\n\nAs I understand it, all the governance is currently here: URL \n\nI see that it is being followed by adding maintainers, e.g., URL \n\nThere's been confusion in public how certain decisions have been made in the project which is an opportunity for clarity and growth imho: URL \n\nFor tetragon, do you have an example of where the vote happened for this? I recall that when the project was being moved to CNCF, some of the votes were happening in the Cilium Slack which isn't a best practice and we recommended recording everything on github and/or mailing list. If a vote can't be dug up, the CNCF requests that you correct things to reflect what is stated in your governance. If you need help on how to do this, look at other CNCF projects e.g., URL \n\nIf you want to use a tool that helps, we have URL in CNCF that can help with voting.","author_login":"caniszczyk","author_association":"NONE","created_at":"2024-01-26T15:21:26+08:00","repo_name":"cilium/community","issue_id":2102398540,"issue_number":82,"issue_url":"https://github.com/cilium/community/issues/82","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1912274548","fragment_type":"issue_comment","sequence":1,"text":"Thanks for opening this issue, we are always trying to improve our governance process. We've gone through two governance reviews from TAG Contributor Strategy. See the latest one here. During the first one last January, it was pointed out that having votes in slack was not a best practice because they are quickly lost to the sands of capitalism. Since then, we have started to record the votes in the git history so we have a record of them. Unfortunately, the Tetragon vote was done before we made this switch.\n\nI'm going to be working with an LFX mentee in the next quarter to update and improve the governance process for Cilium URL This will also be related to the work we will be doing for repo lifecycle URL I'll add this issue as a part of what we will be working on. Once we have this in place, I'll work with the committers to make sure we have a recorded history of the votes and continue to do so going forward.","author_login":"xmulligan","author_association":"MEMBER","created_at":"2024-01-26T15:43:42+08:00","repo_name":"cilium/community","issue_id":2102398540,"issue_number":82,"issue_url":"https://github.com/cilium/community/issues/82","linked_issue_ids":[1715466325],"is_known_query_context":false},{"document_id":"gh_comment_1954299088","fragment_type":"issue_comment","sequence":2,"text":"Envoy seems to have a pretty simple process for this here URL","author_login":"xmulligan","author_association":"MEMBER","created_at":"2024-02-20T14:11:38+08:00","repo_name":"cilium/community","issue_id":2102398540,"issue_number":82,"issue_url":"https://github.com/cilium/community/issues/82","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1715466325","fragment_type":"issue_description","sequence":0,"text":"Repo lifecycle\nAs the project continues to grow and expand more repos are coming under the organization. It would be great to more formally define the lifecycle of repos under the project. We could take the work from Falco as an example. We should also consider how we handle forked repos.","author_login":"xmulligan","author_association":"MEMBER","created_at":"2023-05-18T11:21:03+08:00","repo_name":"cilium/community","issue_id":1715466325,"issue_number":27,"issue_url":"https://github.com/cilium/community/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1571578415","fragment_type":"issue_comment","sequence":1,"text":"Falco's repo lifecycle doesn't mention forks and it seems it's more targeted for \"big projects\" something that we would be expecting to see for things like hubble, tetragon, cilium-cli. However, we might need to define a process for smaller projects similar to URL URL and URL for example.","author_login":"aanm","author_association":"MEMBER","created_at":"2023-06-01T08:16:45+08:00","repo_name":"cilium/community","issue_id":1715466325,"issue_number":27,"issue_url":"https://github.com/cilium/community/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1576516784","fragment_type":"issue_comment","sequence":2,"text":"We should also add how handle experimental and unmaintained/archived repos.","author_login":"xmulligan","author_association":"MEMBER","created_at":"2023-06-05T10:13:30+08:00","repo_name":"cilium/community","issue_id":1715466325,"issue_number":27,"issue_url":"https://github.com/cilium/community/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1893103750","fragment_type":"issue_comment","sequence":3,"text":"Hi @xmulligan \nI liked the lifecycle structure of falcosecurity\n\nWe can add more information about the repositories for better understanding of contributors","author_login":"sambhavgupta0705","author_association":"NONE","created_at":"2024-01-16T05:42:09+08:00","repo_name":"cilium/community","issue_id":1715466325,"issue_number":27,"issue_url":"https://github.com/cilium/community/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1908871716","fragment_type":"issue_comment","sequence":4,"text":"Handling folks will depend on the purpose of the folk , some folks are intended for personal exploration, contributing back to the original repository and alternative development or distribution. If the fork aims to become a separate project with its own development and maintenance, the developer should treat it as a distinct entity from the original cilium repository. If the fork is simply for personal use or experimentation, there's no need for any specific governance. \n\nWe can only handle forks whose intentions are to contribute changes back to the original repository. It would be nice to place rules that fight against spam in pull requests and misleading forks. Please , is there any thing else we should consider with forks ?","author_login":"gailsuccess","author_association":"NONE","created_at":"2024-01-24T20:34:03+08:00","repo_name":"cilium/community","issue_id":1715466325,"issue_number":27,"issue_url":"https://github.com/cilium/community/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1910942150","fragment_type":"issue_comment","sequence":5,"text":"Something else that I think would help with this discussion is: What do we need beyond just having a maintainer create the repo? What expectations or obligations are there that we need to satisfy for any new repo (whether freshly created due to contributions within the Cilium organization, or as a fork from an external repo for Cilium organization usage).","author_login":"joestringer","author_association":"MEMBER","created_at":"2024-01-25T20:22:27+08:00","repo_name":"cilium/community","issue_id":1715466325,"issue_number":27,"issue_url":"https://github.com/cilium/community/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1925283308","fragment_type":"issue_comment","sequence":6,"text":"Hello Everyone!\nI would like to work on this issue as part of the LFX Mentorship.","author_login":"dhruvmehtaaa","author_association":"NONE","created_at":"2024-02-03T11:11:51+08:00","repo_name":"cilium/community","issue_id":1715466325,"issue_number":27,"issue_url":"https://github.com/cilium/community/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1925313928","fragment_type":"issue_comment","sequence":7,"text":"Hi @xmulligan! I'm Abhay. First and foremost, the project is thriving. I have successfully applied to the mentorship program and completed all the pre-tasks. I am eagerly awaiting the opportunity to work with you, learn more about the projects, and delve into interesting challenges.","author_login":"professorabhay","author_association":"NONE","created_at":"2024-02-03T12:56:57+08:00","repo_name":"cilium/community","issue_id":1715466325,"issue_number":27,"issue_url":"https://github.com/cilium/community/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1926808658","fragment_type":"issue_comment","sequence":8,"text":"Hi there! I am Rudraksh, the project on Cilium governance documentation looks pretty interesting to me. While considering the points mentioned by @xmulligan @joestringer & @aanm. I performed a data analysis on the repos under Cilium project using Pandas. I came up with some figures with Cilium as:\n\nimage\n\nI am looking forward to leveraging it further, to get more details about the individual projects which can help while defining lifecycle. While I found the Falco project repo lifecycle structure to be an excellent reference, I understand that we may need to make certain adjustments in the context of Cilium. I also came across CNCF governance templates which has been incredibly helpful in learning about governance in open source. \n\nIn the latest, review of Cilium governance the essence of contributor ladder was one of the major feedback/reviews by TOC, is this an aspect we should prioritize in the context of the Cilium governance project?","author_login":"rudrakshkarpe","author_association":"NONE","created_at":"2024-02-05T11:49:48+08:00","repo_name":"cilium/community","issue_id":1715466325,"issue_number":27,"issue_url":"https://github.com/cilium/community/issues/27","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0407","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"provide one method or api so that the upper layer can know the backup progress?","query_context":"## Is your feature request related to a problem? Please describe.\n\nCurrently myapp.exe will call rdiff-backup.exe, but did not know the progress on the backup\n\n## Describe the solution you'd like\nsimple solution is: rdiff-backup.exe write the progress info to one log file \nmyapp.exe can read the real time log from that file.\n\n## Describe alternatives you've considered\n\n## Additional context","known_context_document_ids":["gh_issue_1597754342"],"reference_answer":"The issue is that rdiff-backup expects the target directory to it alone. A system directory like this `.WD...` directory can only create issues. Either remove it or backup to some sub- directory of W:.\n\nAt this stage, I don't see any other short term solution. Longer term would be the implementation of #790 or a new enhancement to simply ignore certain files.","answer_document_id":"gh_comment_1442394257","silver_evidence_path":["gh_comment_1442874492","gh_issue_1596171988","gh_comment_1442394257"],"evidence_issue_ids":[1597754342,1596171988],"source_repo_name":"rdiff-backup/rdiff-backup","source_issue_id":1597754342,"source_issue_number":856,"source_issue_url":"https://github.com/rdiff-backup/rdiff-backup/issues/856","target_repo_name":"rdiff-backup/rdiff-backup","target_issue_id":1596171988,"target_issue_number":855,"target_issue_url":"https://github.com/rdiff-backup/rdiff-backup/issues/855","reference_anchor_document_id":"gh_comment_1442874492","reference_answer_author":"ericzolf","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3478,"anchor_target_overlap":0.2174,"target_answer_overlap":0.2727},"issue_created_at":"2023-02-24T01:36:30+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_1597754342","fragment_type":"issue_description","sequence":0,"text":"provide one method or api so that the upper layer can know the backup progress\n## Is your feature request related to a problem? Please describe.\n\nCurrently myapp.exe will call rdiff-backup.exe, but did not know the progress on the backup\n\n## Describe the solution you'd like\nsimple solution is: rdiff-backup.exe write the progress info to one log file \nmyapp.exe can read the real time log from that file.\n\n## Describe alternatives you've considered\n\n## Additional context","author_login":"aisnote","author_association":"NONE","created_at":"2023-02-24T01:36:30+08:00","repo_name":"rdiff-backup/rdiff-backup","issue_id":1597754342,"issue_number":856,"issue_url":"https://github.com/rdiff-backup/rdiff-backup/issues/856","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1442862725","fragment_type":"issue_comment","sequence":1,"text":"I'm not sure what you expect. rdiff-backup doesn't know of a progress in terms of percentage or time. And each processed file is already listed, starting with verbosity 5. And there is already a logfile with this information.","author_login":"ericzolf","author_association":"MEMBER","created_at":"2023-02-24T06:22:23+08:00","repo_name":"rdiff-backup/rdiff-backup","issue_id":1597754342,"issue_number":856,"issue_url":"https://github.com/rdiff-backup/rdiff-backup/issues/856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1442874492","fragment_type":"issue_comment","sequence":2,"text":"1. like a big file copying, can we know the percentage?\n2. where is the current log saved?\n\nwhat I want is to show the progress when starting backup.\n\nthe call flow is: myapp.exe launch rdiff-backup.exe as I posted on another issue. \n URL","author_login":"aisnote","author_association":"NONE","created_at":"2023-02-24T06:41:35+08:00","repo_name":"rdiff-backup/rdiff-backup","issue_id":1597754342,"issue_number":856,"issue_url":"https://github.com/rdiff-backup/rdiff-backup/issues/856","linked_issue_ids":[1596171988],"is_known_query_context":false},{"document_id":"gh_comment_1444053798","fragment_type":"issue_comment","sequence":3,"text":"Thanks. And I think **backup.log** is good enough for my case. \nOne more thing is this log file will be rotation or not?\nCurrently as I checked, it has 20M+ size.","author_login":"aisnote","author_association":"NONE","created_at":"2023-02-24T17:11:11+08:00","repo_name":"rdiff-backup/rdiff-backup","issue_id":1597754342,"issue_number":856,"issue_url":"https://github.com/rdiff-backup/rdiff-backup/issues/856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1596171988","fragment_type":"issue_description","sequence":0,"text":"backup failed by \"PermissionError: [WinError 5] Access is denied: b'W:/.WDSyncHistory/.WD Hidden Files'\"\n## Bug summary\n\nrdiff-backup.exe --force -v5 --print-statistics D:/imagebk W:/\nfailed by access denied on hidden files.\n\n## Version, Python, Operating System\n\nyaml\nexec:\n api_version:\n actual: 0\n default: 200\n max: 201\n min: 200\n argv:\n - *****/rdiff-backup/rdiff-backup.exe\n - info\n parsed: null\n version: 2.2.3\npython:\n executable: *****\\rdiff-backup\\rdiff-backup.exe\n name: cpython\n version: 3.10.7\nsystem:\n fs_encoding: utf-8\n platform: Windows-10-10.0.22000-SP0\n\n## rdiff-backup call\n\nrdiff-backup.exe --force -v5 --print-statistics D:/imagebk W:/\n\n## What happened and what did you expect?\n\ncopy the folder from D:/imagebk to W:/\n\n## More information\n\nWARNING: this command line interface is deprecated and will disappear, start using the new one as described with '--new --help'.\n* Using repository 'W:/'\nWARNING: Target path 'W:/' does not look like a rdiff-backup repository but will be force overwritten\n* Hardlinks disabled by default on Windows\n* Unable to import module (py)xattr. Extended attributes not supported on filesystem at path D:/imagebk\n* Unable to import module posix1e from pylibacl package. POSIX ACLs not supported on filesystem at path D:/imagebk\n* -----------------------------------------------------------------\nDetected abilities for source (read only) file system:\n Access control lists Off\n Extended attributes Off\n Windows access control lists On\n Case sensitivity Off\n Escape DOS devices On\n Escape trailing spaces On\n Mac OS X style resource forks Off\n Mac OS X Finder information Off\n-----------------------------------------------------------------\n* Directories on file system at path W:/rdiff-backup-data/rdiff-backup.tmp.0 are not fsyncable. Assuming it's unnecessary.\n* Unable to import module (py)xattr. Extended attributes not supported on filesystem at path W:/rdiff-backup-data/rdiff-backup.tmp.0\n* Unable to import module posix1e from pylibacl package. POSIX ACLs not supported on filesystem at path W:/rdiff-backup-data/rdiff-backup.tmp.0\n* -----------------------------------------------------------------\nDetected abilities for destination (read/write) file system:\n Ownership changing Off\n Hard linking On\n fsync() directories Off\n Directory inc permissions Off\n High-bit permissions On\n Symlink permissions Off\n Extended filenames On\n Windows reserved filenames On\n Access control lists Off\n Extended attributes Off\n Windows access control lists On\n Case sensitivity Off\n Escape DOS devices On\n Escape trailing spaces On\n Mac OS X style resource forks Off\n Mac OS X Finder information Off\n-----------------------------------------------------------------\n* Backup: escape_dos_devices = False\n* Backup: escape_trailing_spaces = False\n* Enabled use_compatible_timestamps\nNOTE: Symbolic links excluded by default on Windows\n* Given repository doesn't need to be regressed\nNOTE: Starting mirror from source path D:/imagebk to destination path W:/\n* Processing file .\n* Processing file .WDSyncHistory\n* Processing file .WDSyncHistory/.WD Hidden Files\n* Processing file Garbage Dispenser2.mp4\n* Cleaning up\nTraceback (most recent call last):\n File \"rdiffbackup\\run.py\", line 170, in \n File \"rdiffbackup\\run.py\", line 37, in main\n File \"rdiffbackup\\run.py\", line 105, in main_run\n File \"rdiffbackup\\actions\\backup.py\", line 159, in run\n File \"rdiff_backup\\backup.py\", line 39, in mirror_compat200\n File \"rdiff_backup\\backup.py\", line 197, in patch\n File \"rdiff_backup\\rorpiter.py\", line 142, in __call__\n File \"rdiff_backup\\rorpiter.py\", line 179, in _finish_branches\n File \"rdiff_backup\\backup.py\", line 641, in end_process_directory\n File \"rdiff_backup\\rpath.py\", line 807, in rmdir\nPermissionError: [WinError 5] Access is denied: b'W:/.WDSyncHistory/.WD Hidden Files'\n[16948] Failed to execute script 'run' due to unhandled exception!","author_login":"aisnote","author_association":"NONE","created_at":"2023-02-23T03:53:47+08:00","repo_name":"rdiff-backup/rdiff-backup","issue_id":1596171988,"issue_number":855,"issue_url":"https://github.com/rdiff-backup/rdiff-backup/issues/855","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1441281459","fragment_type":"issue_comment","sequence":1,"text":"Were the three files listed before the \"cleaning up\" message existing on W: before you started the first backup? What does `dir /s w:` show? You're aware that you're going to lose everything previously present on this drive?","author_login":"ericzolf","author_association":"MEMBER","created_at":"2023-02-23T06:51:47+08:00","repo_name":"rdiff-backup/rdiff-backup","issue_id":1596171988,"issue_number":855,"issue_url":"https://github.com/rdiff-backup/rdiff-backup/issues/855","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1441304866","fragment_type":"issue_comment","sequence":2,"text":"what do you mean? \nThe 2 of 3 files are not actually files. They are dot and one folder begin with dot","author_login":"aisnote","author_association":"NONE","created_at":"2023-02-23T07:24:04+08:00","repo_name":"rdiff-backup/rdiff-backup","issue_id":1596171988,"issue_number":855,"issue_url":"https://github.com/rdiff-backup/rdiff-backup/issues/855","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1442198044","fragment_type":"issue_comment","sequence":3,"text":"Definitely, I want to get help. \n The W:\\ disk is map from network disk. And I do did some backup before. But now I just want to copy from **D:/imagebk to W:/**, and meet the issue as I posted.\n\nimage\n\nThere is one hidden folder:\n\nimage\n\nCould you help to check? thanks.","author_login":"aisnote","author_association":"NONE","created_at":"2023-02-23T17:55:31+08:00","repo_name":"rdiff-backup/rdiff-backup","issue_id":1596171988,"issue_number":855,"issue_url":"https://github.com/rdiff-backup/rdiff-backup/issues/855","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1442394257","fragment_type":"issue_comment","sequence":4,"text":"The issue is that rdiff-backup expects the target directory to it alone. A system directory like this `.WD...` directory can only create issues. Either remove it or backup to some sub- directory of W:.\n\nAt this stage, I don't see any other short term solution. Longer term would be the implementation of #790 or a new enhancement to simply ignore certain files.","author_login":"ericzolf","author_association":"MEMBER","created_at":"2023-02-23T20:33:11+08:00","repo_name":"rdiff-backup/rdiff-backup","issue_id":1596171988,"issue_number":855,"issue_url":"https://github.com/rdiff-backup/rdiff-backup/issues/855","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0409","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"[webView_flutter] screen blank on some Huawei devices with Flutter 3.29?","query_context":"### Steps to reproduce\n\n1.Create a new Flutter project with WebView:\nflutter create webview_test\ncd webview_test\nflutter pub add webview_flutter\n\n2.Edit main.dart to include a simple WebView\n\ndart\nimport 'package:flutter/material.dart';\nimport 'package:webview_flutter/webview_flutter.dart';\n\nvoid main() {\n runApp(MyApp());\n}\n\nclass MyApp extends StatefulWidget {\n @override\n _MyAppState createState() => _MyAppState();\n}\n\nclass _MyAppState extends State {\n late final WebViewController _controller;\n\n @override\n void initState() {\n super.initState();\n _controller = WebViewController()\n ..loadRequest(Uri.parse(' URL \n }\n\n @override\n Widget build(BuildContext context) {\n return MaterialApp(\n home: Scaffold(\n appBar: AppBar(title: Text(\"WebView Test\")),\n body: WebViewWidget(controller: _controller),\n ),\n );\n }\n}\n\n3.Execute flutter run\n\n### Expected results\n\nThe web page ( URL should display correctly in the WebView.\nThe user must be able to interact with the page (scroll, clicks, etc.).\n\n### Actual results\n\nOn some Huawei devices ( y8p, y9s, p30 pro, p40 pro ..) :\n\n-The WebView screen stay blank.\n-Sometimes the application crashes immediately when opening the WebView.\n\n### Code sample\n\n(The code provided in the \"Steps to reproduce\" section can be used as a minimal, reproducible example.)\n\n### Screenshots or Video\n\n \n Screenshots / Video demonstration \n\n[Upload media here]\n\n \n\n### Logs\n\n Logs \n\nconsole\n[Paste your logs here]\n\n \n\n### Flutter Doctor output\n\nDoctor summary (to see all details, run flutter doctor -v):\n[✓] Flutter (Channel stable, 3.27.3, on Microsoft Windows [version 10.0.26100.3194], locale fr-FR)\n[✓] Windows Version (Installed version of Windows is version 10 or higher)\n[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)\n[✓] Chrome - develop for the web\n[✗] Visual Studio - develop Windows apps\n ✗ Visual Studio not installed; this is necessary to develop Windows apps.\n Download at URL \n Please install the \"Desktop development with C++\" workload, including all of its default components\n[✓] Android Studio (version 2022.3)\n[!] Android Studio (version 2024.2)\n ✗ Unable to determine bundled Java version.\n[✓] Connected device (3 available)\n[✓] Network resources","known_context_document_ids":["gh_issue_2906724872"],"reference_answer":"I've landed some changes to master that changes how we do selection of platform views and rendering backend choice on mediatek devices that I believe should fix these issues.","answer_document_id":"gh_comment_2691019245","silver_evidence_path":["gh_comment_2712092908","gh_issue_2852148373","gh_comment_2691019245"],"evidence_issue_ids":[2906724872,2852148373],"source_repo_name":"flutter/flutter","source_issue_id":2906724872,"source_issue_number":164897,"source_issue_url":"https://github.com/flutter/flutter/issues/164897","target_repo_name":"flutter/flutter","target_issue_id":2852148373,"target_issue_number":163262,"target_issue_url":"https://github.com/flutter/flutter/issues/163262","reference_anchor_document_id":"gh_comment_2712092908","reference_answer_author":"jonahwilliams","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.4,"anchor_target_overlap":0.2667,"target_answer_overlap":0.2},"issue_created_at":"2025-03-10T10:08:04+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_2906724872","fragment_type":"issue_description","sequence":0,"text":"[webView_flutter] screen blank on some Huawei devices with Flutter 3.29\n### Steps to reproduce\n\n1.Create a new Flutter project with WebView:\nflutter create webview_test\ncd webview_test\nflutter pub add webview_flutter\n\n2.Edit main.dart to include a simple WebView\n\ndart\nimport 'package:flutter/material.dart';\nimport 'package:webview_flutter/webview_flutter.dart';\n\nvoid main() {\n runApp(MyApp());\n}\n\nclass MyApp extends StatefulWidget {\n @override\n _MyAppState createState() => _MyAppState();\n}\n\nclass _MyAppState extends State {\n late final WebViewController _controller;\n\n @override\n void initState() {\n super.initState();\n _controller = WebViewController()\n ..loadRequest(Uri.parse(' URL \n }\n\n @override\n Widget build(BuildContext context) {\n return MaterialApp(\n home: Scaffold(\n appBar: AppBar(title: Text(\"WebView Test\")),\n body: WebViewWidget(controller: _controller),\n ),\n );\n }\n}\n\n3.Execute flutter run\n\n### Expected results\n\nThe web page ( URL should display correctly in the WebView.\nThe user must be able to interact with the page (scroll, clicks, etc.).\n\n### Actual results\n\nOn some Huawei devices ( y8p, y9s, p30 pro, p40 pro ..) :\n\n-The WebView screen stay blank.\n-Sometimes the application crashes immediately when opening the WebView.\n\n### Code sample\n\n(The code provided in the \"Steps to reproduce\" section can be used as a minimal, reproducible example.)\n\n### Screenshots or Video\n\n \n Screenshots / Video demonstration \n\n[Upload media here]\n\n \n\n### Logs\n\n Logs \n\nconsole\n[Paste your logs here]\n\n \n\n### Flutter Doctor output\n\nDoctor summary (to see all details, run flutter doctor -v):\n[✓] Flutter (Channel stable, 3.27.3, on Microsoft Windows [version 10.0.26100.3194], locale fr-FR)\n[✓] Windows Version (Installed version of Windows is version 10 or higher)\n[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)\n[✓] Chrome - develop for the web\n[✗] Visual Studio - develop Windows apps\n ✗ Visual Studio not installed; this is necessary to develop Windows apps.\n Download at URL \n Please install the \"Desktop development with C++\" workload, including all of its default components\n[✓] Android Studio (version 2022.3)\n[!] Android Studio (version 2024.2)\n ✗ Unable to determine bundled Java version.\n[✓] Connected device (3 available)\n[✓] Network resources","author_login":"Bouchka99","author_association":"NONE","created_at":"2025-03-10T10:08:04+08:00","repo_name":"flutter/flutter","issue_id":2906724872,"issue_number":164897,"issue_url":"https://github.com/flutter/flutter/issues/164897","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2712092908","fragment_type":"issue_comment","sequence":1,"text":"Hi @Bouchka99, Thanks for filing the issue. Can you share more details about the device (Android version) and the output that you are seeing? \n\nLooks similar to URL","author_login":"maheshj01","author_association":"MEMBER","created_at":"2025-03-10T23:44:04+08:00","repo_name":"flutter/flutter","issue_id":2906724872,"issue_number":164897,"issue_url":"https://github.com/flutter/flutter/issues/164897","linked_issue_ids":[2852148373],"is_known_query_context":false},{"document_id":"gh_comment_2713944009","fragment_type":"issue_comment","sequence":2,"text":"@maheshj01 Hello,\nThanks for your response. In fact, I notice the problem especially on Huawei devices that probably don't have Google services (though I can't be sure if it's related). For example, on Android 10 with the Huawei P40 Pro:\n\nAndroid Version: 10 (EMUI 10.1)","author_login":"Bouchka99","author_association":"NONE","created_at":"2025-03-11T12:09:04+08:00","repo_name":"flutter/flutter","issue_id":2906724872,"issue_number":164897,"issue_url":"https://github.com/flutter/flutter/issues/164897","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2715750762","fragment_type":"issue_comment","sequence":3,"text":"@Bouchka99 Please share the visual output (Screenshot/recording) that you are seeing along with the output of `flutter run -v`","author_login":"maheshj01","author_association":"MEMBER","created_at":"2025-03-11T21:30:06+08:00","repo_name":"flutter/flutter","issue_id":2906724872,"issue_number":164897,"issue_url":"https://github.com/flutter/flutter/issues/164897","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2733296275","fragment_type":"issue_comment","sequence":4,"text":"@maheshj01 Hi, i'm facing the same issue and could provide a video i've got from one of our customers. I can send you a link via email if you like, but i can't do that in public. \n\nBut i can't provide the output of `flutter run -v` for that device as its just a video i got sent from one of the users.","author_login":"oegv","author_association":"NONE","created_at":"2025-03-18T13:42:30+08:00","repo_name":"flutter/flutter","issue_id":2906724872,"issue_number":164897,"issue_url":"https://github.com/flutter/flutter/issues/164897","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2852148373","fragment_type":"issue_description","sequence":0,"text":"Flutter_Webview not working on API 30 or lower after latest upgrade of flutter\n### Steps to reproduce\n\nIssue: WebView Not Displaying Content on Android API 30 or Lower After Flutter Upgrade\n\nDescription\n\nAfter upgrading Flutter to the latest version, the WebView (webview_flutter package) is not displaying any content on Android devices running API 30 or lower. Instead of rendering the web content, the WebView shows a blank screen. This issue does not occur on iOS devices or Android devices with API 32\n and above.\n\nSteps to Reproduce\n\n1. Upgrade Flutter to the latest version:\n\nflutter upgrade\n\n2. Ensure that the webview_flutter package is updated in pubspec.yaml:\n\ndependencies:\n webview_flutter: ^latest_version\n\n3. Run the app on an Android device with API 30 or lower.\n\n4. Load a WebView in your app and observe the behavior.\n\nExpected Behavior\n\nThe WebView should load and display web content on all devices, including those with API 30 and lower.\n\nActual Behavior\n\nOn Android devices with API 30 or lower, the WebView results in a blank screen, and no content is displayed.\n\nEnvironment\n\nFlutter Version: X.X.X (Replace with actual version)\n\nDart Version: X.X.X\n\nwebview_flutter Version: X.X.X\n\nAndroid API Level: 30 or lower\n\nDevice/Emulator: (Specify if tested on physical device or emulator)\n\nPossible Causes\n\nRecent changes in Flutter or WebView dependencies that affect compatibility with lower Android APIs.\n\nIssues with Android WebView updates in API 30 or below.\n\nIncorrect or missing configuration for WebView in AndroidManifest.xml.\n\nWorkarounds Tried\n\nUpdating to the latest WebView package version.\n\nModifying Android manifest to allow cleartext traffic.\n\nUsing an older version of the WebView package for compatibility.\n\nLogs & Errors\n\n(Include any relevant logs from flutter run or adb logcat)\n\nTemporary Solution (if any)\n\n(Provide any workarounds that were found, if applicable.)\n\nReferences & Related Issues\n\n(Include any related GitHub issues or forum discussions.)\n\nPlease help us resolve this issue for devices running Android API 30 and lower.\n\n### Expected results\n\nIssue: WebView Not Displaying Content on Android API 30 or Lower After Flutter Upgrade\n\nDescription\n\nAfter upgrading Flutter to the latest version, the WebView (webview_flutter package) is not displaying any content on Android devices running API 30 or lower. Instead of rendering the web content, the WebView shows a blank screen. This issue does not occur on iOS devices or Android devices with API 30 and above.\n\nSteps to Reproduce\n\n1. Upgrade Flutter to the latest version:\n\nflutter upgrade\n\n2. Ensure that the webview_flutter package is updated in pubspec.yaml:\n\ndependencies:\n webview_flutter: ^latest_version\n\n3. Run the app on an Android device with API 30 or lower.\n\n4. Load a WebView in your app and observe the behavior.\n\nExpected Behavior\n\nThe WebView should load and display web content on all devices, including those with API 30 and lower.\n\nActual Behavior\n\nOn Android devices with API 30 or lower, the WebView results in a blank screen, and no content is displayed.\n\nEnvironment\n\nFlutter Version: X.X.X (Replace with actual version)\n\nDart Version: X.X.X\n\nwebview_flutter Version: X.X.X\n\nAndroid API Level: 30 or lower\n\nDevice/Emulator: (Specify if tested on physical device or emulator)\n\nPossible Causes\n\nRecent changes in Flutter or WebView dependencies that affect compatibility with lower Android APIs.\n\nIssues with Android WebView updates in API 30 or below.\n\nIncorrect or missing configuration for WebView in AndroidManifest.xml.\n\nWorkarounds Tried\n\nUpdating to the latest WebView package version.\n\nModifying Android manifest to allow cleartext traffic.\n\nUsing an older version of the WebView package for compatibility.\n\nLogs & Errors\n\n(Include any relevant logs from flutter run or adb logcat)\n\nTemporary Solution (if any)\n\n(Provide any workarounds that were found, if applicable.)\n\nReferences & Related Issues\n\n(Include any related GitHub issues or forum discussions.)\n\nPlease help us resolve this issue for devices running Android API 30 and lower.\n\n### Actual results\n\nBlank Screen \n\n### Code sample\n\n Code sample \n\ndart\n[Paste your code here]\n\n \n\n### Screenshots or Video\n\n \n Screenshots / Video demonstration \n\n[Upload media here]\n\n \n\n### Logs\n\n Logs \n\nconsole\n[Paste your logs here]\n\n \n\n### Flutter Doctor output\n\n Doctor output \n\nconsole\n[Paste your output here]","author_login":"sanzeh2014","author_association":"NONE","created_at":"2025-02-13T21:30:47+08:00","repo_name":"flutter/flutter","issue_id":2852148373,"issue_number":163262,"issue_url":"https://github.com/flutter/flutter/issues/163262","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2657802453","fragment_type":"issue_comment","sequence":1,"text":"Can you please include the phone model you are seeing this problem on? This is probably a device specific problem, and sounds similar to :\n\n URL \n URL \n URL","author_login":"jonahwilliams","author_association":"MEMBER","created_at":"2025-02-13T22:02:05+08:00","repo_name":"flutter/flutter","issue_id":2852148373,"issue_number":163262,"issue_url":"https://github.com/flutter/flutter/issues/163262","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2659732696","fragment_type":"issue_comment","sequence":2,"text":"URL this one? Can you confirm its running Android 9.0. If so this is not similar to the other issues, as this device is having problems on the OpenGLES backend.","author_login":"jonahwilliams","author_association":"MEMBER","created_at":"2025-02-14T16:10:33+08:00","repo_name":"flutter/flutter","issue_id":2852148373,"issue_number":163262,"issue_url":"https://github.com/flutter/flutter/issues/163262","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2659796214","fragment_type":"issue_comment","sequence":3,"text":"I was facing a similar issue as described in #160804, where the rendering was blank, and videos were only playing audio without displaying visuals. After following the suggestions here, I was able to fix the issue by disabling Impeller.\n\nIt worked like a charm! 🎉\nThank you so much @jonahwilliams \n\nFor now, disabling Impeller is the recommended workaround until the PR mentioned by Jonah (#163265) is merged into the main branch and included in a new Flutter release.\n\nHope this helps others facing the same problem! 🚀","author_login":"sanzeh2014","author_association":"NONE","created_at":"2025-02-14T16:40:12+08:00","repo_name":"flutter/flutter","issue_id":2852148373,"issue_number":163262,"issue_url":"https://github.com/flutter/flutter/issues/163262","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2659858945","fragment_type":"issue_comment","sequence":4,"text":"Issue Description:\nAfter upgrading Flutter, the WebView in your app stopped displaying content correctly on devices running Android API 30 or lower (like OPPO F11 with Android 11 and OPPO A15 with Android 10). Instead of showing the web content, the WebView displays a blank screen or becomes blurry with no rendered content.\n\nHowever, this issue does not occur on devices with API 32 or higher (like Android 12L).\n\nSteps Taken:\nFlutter Upgrade: Upgraded Flutter to the latest version.\nwebview_flutter Update: The webview_flutter package was also updated to the latest version.\nDevice Testing: The issue was observed on OPPO F11 (Android 11, API 30) and OPPO A15 (Android 10, API 29), while WebView functions fine on devices with API 32 and above.\nTemporary Workaround:\nTo fix the issue temporarily, I disabled Impeller as a rendering engine. This workaround was effective, but it's not ideal long-term because Impeller is being phased out.\n\nLogs and Errors:\nI tried updating the webview_flutter package and modifying your AndroidManifest.xml, but the issue persists. The behavior observed is similar to the one discussed in issue #160804, where rendering issues occurred due to a blank screen, and videos were playing audio without visuals.\n\nConclusion:\nWhile the workaround is currently functional, the problem appears to be related to the interaction between Flutter, WebView, and certain Android versions, especially on devices with API 30 and lower. I'm seeking a permanent solution and asking for insights into how this can be fixed without relying on the Impeller workaround.\n\nAdditional Information:\nDevice Models: OPPO A15 (Android 10, API 29) and OPPO F11 (Android 11, API 30).\nThe issue is observed when the app is launched on these devices, with WebView failing to display content, and the display breaking or being blurry.\n\nWhile that is a good workaround, we need information on how to fix the bug, because long term we plan to remove the ability to disable impeller","author_login":"sanzeh2014","author_association":"NONE","created_at":"2025-02-14T17:11:26+08:00","repo_name":"flutter/flutter","issue_id":2852148373,"issue_number":163262,"issue_url":"https://github.com/flutter/flutter/issues/163262","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2659861098","fragment_type":"issue_comment","sequence":5,"text":"Thanks for the update, @jonahwilliams. I’m seeing the same issue on OPPO F11 (API 30) and OPPO A15 (API 29) with WebView and video playback. The Impeller workaround works temporarily, but I'd prefer a long-term solution since it doesn’t work on all devices, especially those with API 30 and lower. Is there an upcoming fix for this?","author_login":"sanzeh2014","author_association":"NONE","created_at":"2025-02-14T17:12:38+08:00","repo_name":"flutter/flutter","issue_id":2852148373,"issue_number":163262,"issue_url":"https://github.com/flutter/flutter/issues/163262","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2691019245","fragment_type":"issue_comment","sequence":6,"text":"I've landed some changes to master that changes how we do selection of platform views and rendering backend choice on mediatek devices that I believe should fix these issues.","author_login":"jonahwilliams","author_association":"MEMBER","created_at":"2025-02-28T16:03:44+08:00","repo_name":"flutter/flutter","issue_id":2852148373,"issue_number":163262,"issue_url":"https://github.com/flutter/flutter/issues/163262","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2724889761","fragment_type":"issue_comment","sequence":7,"text":"What's the expected release version that these changes will be included in?","author_login":"joelsuite","author_association":"NONE","created_at":"2025-03-14T14:31:37+08:00","repo_name":"flutter/flutter","issue_id":2852148373,"issue_number":163262,"issue_url":"https://github.com/flutter/flutter/issues/163262","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0419","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"commit `Implement Quick Dungeons Select` seems to have broken the desktop version of `additionalvisualsettings`?","query_context":"ended up leaving a comment on the commit, but thought I should throw up an issue about it as well. Upon updating scripts, the latest version of `additionalvisualsettings` seems to be broken and no longer loading in the desktop version of the game.\n\nIf I go and put it in the `scripts` folder and change it back to the older version it seems to work again, but obviously I end up missing the reason for the update.\n\nI'm just wondering if you are just no longer supporting the desktop version? as there are a couple scripts as of recent that just don't work in the desktop version at all.\n\nScript that don't show up in desktop version are as followed:\nadditionalvisualsettings (broken within recent commit)\ncatchfilterfantasia\nperkypokeruspandemic","known_context_document_ids":["gh_issue_1289442289"],"reference_answer":"The scripts should update automatically and should also support new scripts, at least this is the design of it and how I made the client edit initially work, but then again ever since catchfilterfantasia got introduced, that has also been causing problems.\n\nIt's likely that the custom edit needs to be updated and needs to be looked at, but then again I haven't touched this or have been wanting to maintain this since January.","answer_document_id":"gh_comment_1167823338","silver_evidence_path":["gh_comment_1170663574","gh_issue_1285789701","gh_comment_1167823338"],"evidence_issue_ids":[1289442289,1285789701],"source_repo_name":"Ephenia/Pokeclicker-Scripts","source_issue_id":1289442289,"source_issue_number":163,"source_issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","target_repo_name":"Ephenia/Pokeclicker-Scripts","target_issue_id":1285789701,"target_issue_number":158,"target_issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/158","reference_anchor_document_id":"gh_comment_1170663574","reference_answer_author":"Ephenia","reference_answer_author_association":"OWNER","quality_score":87.36,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1136,"anchor_target_overlap":0.0909,"target_answer_overlap":0.1034},"issue_created_at":"2022-06-30T00:46:14+08:00","valid_comment_count":22,"fragments":[{"document_id":"gh_issue_1289442289","fragment_type":"issue_description","sequence":0,"text":"commit `Implement Quick Dungeons Select` seems to have broken the desktop version of `additionalvisualsettings`\nended up leaving a comment on the commit, but thought I should throw up an issue about it as well. Upon updating scripts, the latest version of `additionalvisualsettings` seems to be broken and no longer loading in the desktop version of the game.\n\nIf I go and put it in the `scripts` folder and change it back to the older version it seems to work again, but obviously I end up missing the reason for the update.\n\nI'm just wondering if you are just no longer supporting the desktop version? as there are a couple scripts as of recent that just don't work in the desktop version at all.\n\nScript that don't show up in desktop version are as followed:\nadditionalvisualsettings (broken within recent commit)\ncatchfilterfantasia\nperkypokeruspandemic","author_login":"JourneyOver","author_association":"NONE","created_at":"2022-06-30T00:46:14+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1289442289,"issue_number":163,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1170638891","fragment_type":"issue_comment","sequence":1,"text":"I can confirm that there is problems with some newer scripts.\n\nThe last additionalvisualsettings is just broken. It doesn't load, OR it loads but other scripts don't. Seems to be random on every reload of the desktop app.\n\nSome goes for catchfilterfantasia. Sometimes it just load alone, or 99% of the time it doesn't load at all. (and even before the last additionalvisualsettings update)\n\nAlso, perkypokeruspandemic seems to never load.","author_login":"Erwanito92","author_association":"NONE","created_at":"2022-06-30T01:01:27+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1289442289,"issue_number":163,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1170642544","fragment_type":"issue_comment","sequence":2,"text":"Haven't had the issue it loading but not other scripts loading for any of them, the ones I mentioned just outright refuse to load anymore.\n\nFrom what I can tell it's something to do with a `var` to `const` change, because if I put them into the `scripts` folder and do a rename for every `const` to be `var` instead it works perfectly and loads, same with the other two scripts (changing all `const` to `var).","author_login":"JourneyOver","author_association":"NONE","created_at":"2022-06-30T01:09:06+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1289442289,"issue_number":163,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1170663574","fragment_type":"issue_comment","sequence":3,"text":"About where things are currently with Desktop support: URL (well thought I'd include this in for transparency)\n\nAs for the changes being mentioned, I suspect it's maybe the changes being done to the initialization portion (unable to test these myself atm and hadn't prior).\n\nTry reverting just this portion of the script and keep the rest of the variable declaration (const & let) changes throughout the rest of the script:\nimage\n\nIf this is the issue I can revert it in the next revision being worked on at the moment, and changing this in a few other scripts where it may be problematic.","author_login":"Ephenia","author_association":"OWNER","created_at":"2022-06-30T01:54:17+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1289442289,"issue_number":163,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","linked_issue_ids":[1285789701],"is_known_query_context":false},{"document_id":"gh_comment_1170679798","fragment_type":"issue_comment","sequence":4,"text":"@Ephenia Yep that's exactly it from the looks of things, as reverting that portion back to the previous revision seems to make things work and load correctly, can also confirm that it changing that partion in the other scripts that I mentioned above works as well.","author_login":"JourneyOver","author_association":"NONE","created_at":"2022-06-30T02:28:23+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1289442289,"issue_number":163,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1170683638","fragment_type":"issue_comment","sequence":5,"text":"@Ephenia actually scratch that, it's causing other issues and idk why I didn't notice >.< for some reason or another it's now only loading a portion of the scripts. So many others just seem to disappear..\n\nGoing to test a bit more to see what is causing this new issue.","author_login":"JourneyOver","author_association":"NONE","created_at":"2022-06-30T02:35:47+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1289442289,"issue_number":163,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1170691905","fragment_type":"issue_comment","sequence":6,"text":"Okay after a bit more testing I have found these things:\n\ndoing the above does work correctly but there seems to be more changes needed in at least the `additionalvisualsettings` script, from what I can tell I needed to change the\n\nlet checkWildPokeName;\nlet checkWildPokeDefeat;\nlet checkWildPokeImg;\nlet checkWildPokeHealth;\nlet checkWildPokeCatch;\nlet checkAllNotification;\nconst notificFunc = Notifier.notify;\nlet newSave;\nlet trainerCards;\n\nto be\n\nvar checkWildPokeName;\nvar checkWildPokeDefeat;\nvar checkWildPokeImg;\nvar checkWildPokeHealth;\nvar checkWildPokeCatch;\nvar checkAllNotification;\nconst notificFunc = Notifier.notify;\nvar newSave;\nvar trainerCards;\n\nto actually make it work and stop the whole other scripts randomly disappearing act also seems that only needing to change the `const scriptName` and `const scriptElement` to be `var scriptName` and `var scriptElement` is what is needed for the loadscript function (from what I can tell)","author_login":"JourneyOver","author_association":"NONE","created_at":"2022-06-30T02:51:47+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1289442289,"issue_number":163,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1170707347","fragment_type":"issue_comment","sequence":7,"text":"oof I can't seem to test now as I'm now randomly getting this error for some reason >.<\n06-29-2022_22-23-32","author_login":"JourneyOver","author_association":"NONE","created_at":"2022-06-30T03:24:03+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1289442289,"issue_number":163,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1170717977","fragment_type":"issue_comment","sequence":8,"text":"@Ephenia Okay back to normal, from my latest testings everything is now working correctly from the looks of it, other than `catchfilterfantasia` is the only one missing.","author_login":"JourneyOver","author_association":"NONE","created_at":"2022-06-30T03:47:24+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1289442289,"issue_number":163,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1170731694","fragment_type":"issue_comment","sequence":9,"text":"Loving all this information and all the testing that you're doing, you're a huge help and I really appreciate it as well as your time! I must say that you're great with providing quality testing. You're always free to hit me up personally too if you want by the way, if it would also be easier or more convenient.\n\nAnyway, are you happening to load all of the scripts by the way?","author_login":"Ephenia","author_association":"OWNER","created_at":"2022-06-30T04:07:10+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1289442289,"issue_number":163,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1170741406","fragment_type":"issue_comment","sequence":10,"text":"@Ephenia it's not a problem at all, I try my best to test things and figure things out as I go along with issuing bug reports and such :p\n \n\nSounds good :D\n \n\nas for loading all the scripts, the only one that seems to be missing/not loading currently on multiple refreshes is the `infiniteseasonalevents` script. Everything else seems to be at least loading correctly now for the most part from my multiple refreshes from what I can tell.","author_login":"JourneyOver","author_association":"NONE","created_at":"2022-06-30T04:25:34+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1289442289,"issue_number":163,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1170764434","fragment_type":"issue_comment","sequence":11,"text":"Maybe the simpleweatherchanger could be bugging it out or interfering with it, since it also had the slight change to initialization. But, if that isn't it, then loading the script standalone would definitely tell if the script itself is the issue, probably.","author_login":"Ephenia","author_association":"OWNER","created_at":"2022-06-30T04:59:30+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1289442289,"issue_number":163,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1170778244","fragment_type":"issue_comment","sequence":12,"text":"yea shit so confusing, because if I go to put `infiniteseasonalevents` script into the scripts folder to load it standalone, it then makes the `catchfilterfantasia` stop loading instead xD","author_login":"JourneyOver","author_association":"NONE","created_at":"2022-06-30T05:24:44+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1289442289,"issue_number":163,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1170782625","fragment_type":"issue_comment","sequence":13,"text":"You should be able to override all the scripts with blank ones with the same names and just have `infiniteseasonalevents` load, at least this should still be doable (I think) ;p","author_login":"Ephenia","author_association":"OWNER","created_at":"2022-06-30T05:32:43+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1289442289,"issue_number":163,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1170792976","fragment_type":"issue_comment","sequence":14,"text":"okay so did a little bit of testing with everything blanked out in scripts and then moving between these last 3 (infiniteseasonalevents/simpleweatherchanger/catchfilterfantasia) these are the things I noticed:\n\nWith `infiniteseasonalevents` and `simpleweatherchanger` being the only two that wasn't blanked out, they loaded fine, if I re-added `catchfilterfantasia` it stopped loading the `infiniteseasonalevents` but `simpleweatherchanger` would still load, blanking out `simpleweatherchanger` didn't seem to bring back `infiniteseasonalevents` however if I was do that, if I was to blank out `catchfilterfantasia` again `infiniteseasonalevents` would however load just fine again.\n\nso from this bit of testing it seems to be something to do with `catchfilterfantasia` causing issues atm.","author_login":"JourneyOver","author_association":"NONE","created_at":"2022-06-30T05:50:41+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1289442289,"issue_number":163,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1170794673","fragment_type":"issue_comment","sequence":15,"text":"Hm... quite interesting...\n\nI wonder if it has something to do with the use of `window`, which may be unfortunate if that's actually the case.","author_login":"Ephenia","author_association":"OWNER","created_at":"2022-06-30T05:53:18+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1289442289,"issue_number":163,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1170801182","fragment_type":"issue_comment","sequence":16,"text":"hmm yea that could possibly be it, sadly with how late it is getting here and the fact I sadly have to work in the morning I may need to call it a night on testing for now and come back to testing things again once I return from work tomorrow. I'll throw you an add on disc tomorrow once I'm around and we can see if we can figure things out.","author_login":"JourneyOver","author_association":"NONE","created_at":"2022-06-30T06:01:33+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1289442289,"issue_number":163,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1171660500","fragment_type":"issue_comment","sequence":17,"text":"Sent you a FR on discord, and should be around for most of the day.","author_login":"JourneyOver","author_association":"NONE","created_at":"2022-06-30T20:46:28+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1289442289,"issue_number":163,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/163","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1285789701","fragment_type":"issue_description","sequence":0,"text":"Auto Hatchery stopped working on desktop on version 0.9.5\nI play on the Windows desktop version. I haven't updated to 0.9.6, but auto hatchery has stopped working. The buttons show up, but no eggs are added to the hatchery. The Auto Fossil and Auto Egg features do work, though. I tried to restart the game, to enable and disable the script (with their respective restarts) and to overwrite the app.asar file, but none of these worked.","author_login":"quik2903","author_association":"NONE","created_at":"2022-06-27T13:12:38+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1285789701,"issue_number":158,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/158","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1167696987","fragment_type":"issue_comment","sequence":1,"text":"Which version of the auto hatchery script are you using ?\nIf you dont want to update, you will need to use a version before the commits on the 26th\n URL","author_login":"Dionisos94","author_association":"CONTRIBUTOR","created_at":"2022-06-27T18:06:34+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1285789701,"issue_number":158,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/158","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1167746705","fragment_type":"issue_comment","sequence":2,"text":"The script version is 1.6, which seems to correspond with the latest version. Do these scripts update automatically? That would explain it. Is there a way to avoid this update process? Thank you very much!","author_login":"quik2903","author_association":"NONE","created_at":"2022-06-27T18:46:43+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1285789701,"issue_number":158,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/158","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1167764411","fragment_type":"issue_comment","sequence":3,"text":"V1.6 contains yesterday changes which were made for pokeclicker v0.9.6 and are unhappily not retroactive.\nI do not know how the scripts work for windows and how they are updated so I am not of a great help here :(","author_login":"Dionisos94","author_association":"CONTRIBUTOR","created_at":"2022-06-27T19:03:44+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1285789701,"issue_number":158,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/158","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1167823338","fragment_type":"issue_comment","sequence":4,"text":"The scripts should update automatically and should also support new scripts, at least this is the design of it and how I made the client edit initially work, but then again ever since catchfilterfantasia got introduced, that has also been causing problems.\n\nIt's likely that the custom edit needs to be updated and needs to be looked at, but then again I haven't touched this or have been wanting to maintain this since January.","author_login":"Ephenia","author_association":"OWNER","created_at":"2022-06-27T20:01:52+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1285789701,"issue_number":158,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/158","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1168678124","fragment_type":"issue_comment","sequence":5,"text":"I think I'll update to 0.9.7, since now the XP nerf isn't that bad, and everything should work ok. Thanks for taking the time of looking into it.","author_login":"quik2903","author_association":"NONE","created_at":"2022-06-28T12:47:48+08:00","repo_name":"Ephenia/Pokeclicker-Scripts","issue_id":1285789701,"issue_number":158,"issue_url":"https://github.com/Ephenia/Pokeclicker-Scripts/issues/158","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0431","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Multiple Formbuilder Forms on a single page not working properly.","query_context":"### Description: Two Formbuilder forms on a single page not working properly when clicking on the save button.\n\n### Environment Details: I am working on a staging environment having PHP on the stack side\n\n - formBuilder Version: Latest one\n - Browser: Chrome\n - OS: Windows\n\n### Expected Behavior: No matter how many formbuilder forms we use on a single page if the ids of that formbuilder form are different. Each action should work with respect to individual forms. \n\n### Actual Behavior: Right now once I click on the save button of the first formbuilder form it throws some error \"Uncaught TypeError: formBuilder.actions.getData is not a function\"\n\n### Steps to Reproduce: Below is complete code which I am working on:\n**JS** \n\njQuery(function($) {\n var fbTemplate = document.getElementById('fb-editor');\n var options = {\n disabledActionButtons: ['data','clear','save']\n };\n var formBuilder = $(fbTemplate).formBuilder(options);\n document.getElementById('getJSON').addEventListener('click', function() {\n alert(formBuilder.actions.getData('json'));\n });\n var fbTemplate1 = document.getElementById('fb-editor1');\n var options1 = {\n disabledActionButtons: ['data','clear','save']\n };\n var formBuilder2 = $(fbTemplate1).formBuilder(options1);\n document.getElementById('getJSON1').addEventListener('click', function() {\n alert(formBuilder2.actions.getData('json'));\n });\n});\n\n**HTML**\n\n \n Get JSON Data \n \n Get JSON Data","known_context_document_ids":["gh_issue_1427498041"],"reference_answer":"formRender does not have the promise interface, only multiple formBuilder instances need to be created via awaiting the promise interface.","answer_document_id":"gh_comment_1689106147","silver_evidence_path":["gh_comment_1654833720","gh_issue_638416841","gh_comment_1689106147"],"evidence_issue_ids":[1427498041,638416841],"source_repo_name":"kevinchappell/formBuilder","source_issue_id":1427498041,"source_issue_number":1340,"source_issue_url":"https://github.com/kevinchappell/formBuilder/issues/1340","target_repo_name":"kevinchappell/formBuilder","target_issue_id":638416841,"target_issue_number":1087,"target_issue_url":"https://github.com/kevinchappell/formBuilder/issues/1087","reference_anchor_document_id":"gh_comment_1654833720","reference_answer_author":"lucasnetau","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.4561,"anchor_target_overlap":0.2182,"target_answer_overlap":0.1667},"issue_created_at":"2022-10-28T16:30:01+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_1427498041","fragment_type":"issue_description","sequence":0,"text":"Multiple Formbuilder Forms on a single page not working properly.\n### Description: Two Formbuilder forms on a single page not working properly when clicking on the save button.\n\n### Environment Details: I am working on a staging environment having PHP on the stack side\n\n - formBuilder Version: Latest one\n - Browser: Chrome\n - OS: Windows\n\n### Expected Behavior: No matter how many formbuilder forms we use on a single page if the ids of that formbuilder form are different. Each action should work with respect to individual forms. \n\n### Actual Behavior: Right now once I click on the save button of the first formbuilder form it throws some error \"Uncaught TypeError: formBuilder.actions.getData is not a function\"\n\n### Steps to Reproduce: Below is complete code which I am working on:\n**JS** \n\njQuery(function($) {\n var fbTemplate = document.getElementById('fb-editor');\n var options = {\n disabledActionButtons: ['data','clear','save']\n };\n var formBuilder = $(fbTemplate).formBuilder(options);\n document.getElementById('getJSON').addEventListener('click', function() {\n alert(formBuilder.actions.getData('json'));\n });\n var fbTemplate1 = document.getElementById('fb-editor1');\n var options1 = {\n disabledActionButtons: ['data','clear','save']\n };\n var formBuilder2 = $(fbTemplate1).formBuilder(options1);\n document.getElementById('getJSON1').addEventListener('click', function() {\n alert(formBuilder2.actions.getData('json'));\n });\n});\n\n**HTML**\n\n \n Get JSON Data \n \n Get JSON Data","author_login":"Sharad2390","author_association":"NONE","created_at":"2022-10-28T16:30:01+08:00","repo_name":"kevinchappell/formBuilder","issue_id":1427498041,"issue_number":1340,"issue_url":"https://github.com/kevinchappell/formBuilder/issues/1340","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1298054756","fragment_type":"issue_comment","sequence":1,"text":"Hi @kevinchappell,\nPlease help me with this as I am totally stuck with this issue.\nThanks!","author_login":"Sharad2390","author_association":"NONE","created_at":"2022-11-01T05:40:04+08:00","repo_name":"kevinchappell/formBuilder","issue_id":1427498041,"issue_number":1340,"issue_url":"https://github.com/kevinchappell/formBuilder/issues/1340","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1306416802","fragment_type":"issue_comment","sequence":2,"text":"Take a look at URL and use the result of the initialisation promise","author_login":"lucasnetau","author_association":"CONTRIBUTOR","created_at":"2022-11-08T00:27:30+08:00","repo_name":"kevinchappell/formBuilder","issue_id":1427498041,"issue_number":1340,"issue_url":"https://github.com/kevinchappell/formBuilder/issues/1340","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1517282884","fragment_type":"issue_comment","sequence":3,"text":"I can see this in Section. But when I use promise and store the objects in an array, all the other objects get overridden by the last object.\n\ncoffee\n @formBuilder = []\n for element in $('#tab1, #tab2')\n dataElement = JSON.parse($(element).children('span').text())\n _initProgramBuilder(element, (dataElement || []))\n \n _initProgramBuilder = (element, data) ->\n $(element).formBuilder().promise.then (fb) ->\n @formBuilder.push fb","author_login":"kirykr","author_association":"NONE","created_at":"2023-04-21T05:30:49+08:00","repo_name":"kevinchappell/formBuilder","issue_id":1427498041,"issue_number":1340,"issue_url":"https://github.com/kevinchappell/formBuilder/issues/1340","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1529715552","fragment_type":"issue_comment","sequence":4,"text":"Same here @kirykr \nDid you find a solution, i have two form builder, and calling \"actions.getData()\" only return last one..\nI am already using promises...","author_login":"Abacaxi-Nelson","author_association":"NONE","created_at":"2023-05-01T13:33:45+08:00","repo_name":"kevinchappell/formBuilder","issue_id":1427498041,"issue_number":1340,"issue_url":"https://github.com/kevinchappell/formBuilder/issues/1340","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1654628236","fragment_type":"issue_comment","sequence":5,"text":"Hello. Who was able to solve this problem? I ran into it and all methods do not help","author_login":"Repechinskyi","author_association":"NONE","created_at":"2023-07-27T21:47:02+08:00","repo_name":"kevinchappell/formBuilder","issue_id":1427498041,"issue_number":1340,"issue_url":"https://github.com/kevinchappell/formBuilder/issues/1340","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1654833720","fragment_type":"issue_comment","sequence":6,"text":"You can only initialise a single formBuilder instance at a time and need to wait for the promise to resolve before moving onto initialising the next instance.\n\nThis can be done either via a recursive function per URL \n\nor via awaiting the promise per the documentation.\n\nThe initial code by @Sharad2390 can be rewritten with the ready callback being async and the initialisation await the promise object of formBuilder\n\njs\njQuery(async function($) {\n var fbTemplate = document.getElementById('fb-editor');\n var options = {\n disabledActionButtons: ['data','clear','save']\n };\n var formBuilder = await $(fbTemplate).formBuilder(options).promise;\n document.getElementById('getJSON').addEventListener('click', function() {\n alert(formBuilder.actions.getData('json'));\n });\n var fbTemplate1 = document.getElementById('fb-editor1');\n var options1 = {\n disabledActionButtons: ['data','clear','save']\n };\n var formBuilder2 = await $(fbTemplate1).formBuilder(options1).promise;\n document.getElementById('getJSON1').addEventListener('click', function() {\n alert(formBuilder2.actions.getData('json'));\n });\n});","author_login":"lucasnetau","author_association":"CONTRIBUTOR","created_at":"2023-07-28T01:16:58+08:00","repo_name":"kevinchappell/formBuilder","issue_id":1427498041,"issue_number":1340,"issue_url":"https://github.com/kevinchappell/formBuilder/issues/1340","linked_issue_ids":[638416841],"is_known_query_context":false},{"document_id":"gh_comment_1656154290","fragment_type":"issue_comment","sequence":7,"text":"Hello. Thank you for giving a hint, which helped partially, but now I have encountered another problem in the form, the fields are displayed correctly, but when I want to get data from the form in json format, I have the same code on page 2 and 3. I've been struggling with this code for several days, I don't know what to do anymore.\n\nI have 3 pages now:\n1 - Text field\n2 - Date field\n3 - Header fields\n\nThese fields in the form will visually display correctly. There is no error with \"actions.getData\" now, but when I view the result var json = fb.actions.getData('json', true); then I get\n\n1 - Text field\n2 - Header fields\n3 - Header fields\n\nAfter the first it is duplicated\n\ndocument.addEventListener('DOMContentLoaded', async function() {\n jQuery( function ($) {\n\n var fbOptions = {...};\n\n fbInstances.push($(\".build-wrap\").formBuilder(fbOptions));\n\n setTimeout(function() {\n $.each(setFormData, function(i, item) {\n\n if(fbInstances[i]) {\n fbInstances[i].actions.setData(item);\n } else {\n addPageLoading(item);\n }\n });\n }, 2000);\n\n // add pages form \n async function addPageLoading(data){\n console.log('addPageLoading')\n const tabCount = document.getElementById(\"tabs\").children.length;\n const tabId = \"page\" + tabCount.toString();\n const newPageTemplate = document.getElementById(\"new-page\");\n const newTabTemplate = document.getElementById(\"add-page-tab\");\n const newPage = newPageTemplate.cloneNode(true);\n newPage.setAttribute(\"id\", tabId);\n newPage.classList.add(\"build-wrap\");\n const $newTab = newTabTemplate.cloneNode(true);\n $newTab.removeAttribute(\"id\");\n const tabLink = $newTab.querySelector(\"a\");\n tabLink.setAttribute(\"href\", \"#\" + tabId);\n tabLink.innerText = \"Page \" + tabCount;\n $newTab.append($(\" X \")[0])\n\n newPageTemplate.parentElement.insertBefore(newPage, newPageTemplate);\n newTabTemplate.parentElement.insertBefore($newTab, newTabTemplate);\n\n fbPages.tabs(\"refresh\");\n fbPages.tabs(\"option\", \"active\", tabCount - 1);\n\n if(data.length){\n fbOptions.formData = data;\n }else{\n fbOptions.formData = [];\n }\n\n var formBuilder_load = await $(newPage).formBuilder(fbOptions).promise;\n fbInstances.push(formBuilder_load);\n\n } \n\n // Get JSON and send form\n $(document.getElementById(\"getJSON\")).click(function () {\n\n const allData = fbInstances.map((fb) => {\n var json = fb.actions.getData('json', true);\n return json;\n });\n $(\"input[name='json']\").val(\"[\"+allData+\"]\");\n $(\"#design-form\").submit();\n \n });\n\n });\n});","author_login":"Repechinskyi","author_association":"NONE","created_at":"2023-07-28T18:29:48+08:00","repo_name":"kevinchappell/formBuilder","issue_id":1427498041,"issue_number":1340,"issue_url":"https://github.com/kevinchappell/formBuilder/issues/1340","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1657996187","fragment_type":"issue_comment","sequence":8,"text":"Hi @Abacaxi-Nelson here is what I did \n \ncoffee\n@formBuilder = []\nstartIndex = 0\n _initMultipleFormBuilder = (startIndex, elements) ->\n if startIndex \n form.element = elements[startIndex]\n @formBuilder.push form\n startIndex++\n _initMultipleFormBuilder(startIndex, elements)\n )\n\nI use a recursive function. I haven't tracked it down why it works this way yet. Let me know if there is still a problem.","author_login":"kirykr","author_association":"NONE","created_at":"2023-07-31T09:23:42+08:00","repo_name":"kevinchappell/formBuilder","issue_id":1427498041,"issue_number":1340,"issue_url":"https://github.com/kevinchappell/formBuilder/issues/1340","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1687403981","fragment_type":"issue_comment","sequence":9,"text":"@Repechinskyi the first time you initialise formBuilder you don't use the promise\n\n`fbInstances.push($(\".build-wrap\").formBuilder(fbOptions));`\n\nand then further on you use do \n\njavascript\nvar formBuilder_load = await $(newPage).formBuilder(fbOptions).promise;\nfbInstances.push(formBuilder_load);\n\nFix up the first initialisation and it should work for you.\n\n@kirykr The recursive method works well too.","author_login":"lucasnetau","author_association":"COLLABORATOR","created_at":"2023-08-22T04:36:19+08:00","repo_name":"kevinchappell/formBuilder","issue_id":1427498041,"issue_number":1340,"issue_url":"https://github.com/kevinchappell/formBuilder/issues/1340","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_638416841","fragment_type":"issue_description","sequence":0,"text":"Multiple forms on the same page\n### Description:\n\nHi,\n\nI try to have multiples forms on the same page (one for each language).\nHowever, when I try to get data, it's always the data from the last form.\n\nThanks.\n\n### Environment Details:\n\n - formBuilder Version: 3.4.2\n - Browser: Chrome 83\n - OS: MacOS\n\n### Expected Behavior\n\nData of all forms\n\n### Actual Behavior\n\nI get data of last form instead of data of each form.\n\n### Example\n\n URL \n\n Save \n \n \n \n\nvar formsBuilder = [];\n\n$(function() {\n $('.form-editor').each(function() {\n var culture = $(this).attr('data-culture');\n formsBuilder[culture] = $(this).formBuilder();\n });\n\n $(document).on('click', '#save', function() {\n $('.render').html('');\n for (var culture in formsBuilder)\n {\n $('.render').append(culture + ' ');\n var data = formsBuilder[culture].formData;\n $('.render').append(data + ' ');\n }\n });\n});","author_login":"florent-dehanne","author_association":"NONE","created_at":"2020-06-14T19:40:27+08:00","repo_name":"kevinchappell/formBuilder","issue_id":638416841,"issue_number":1087,"issue_url":"https://github.com/kevinchappell/formBuilder/issues/1087","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_646898877","fragment_type":"issue_comment","sequence":1,"text":"I have the same issue, however I am trying to render multiple forms on one page, and formRender.('userData') only retrieves the user data from the last form as well.","author_login":"ngjulia","author_association":"NONE","created_at":"2020-06-19T23:41:25+08:00","repo_name":"kevinchappell/formBuilder","issue_id":638416841,"issue_number":1087,"issue_url":"https://github.com/kevinchappell/formBuilder/issues/1087","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_647912433","fragment_type":"issue_comment","sequence":2,"text":"Only initiate multiple form builder instance with promise & recursive function. Check example here.\n\n URL","author_login":"myowinthein","author_association":"NONE","created_at":"2020-06-23T05:13:52+08:00","repo_name":"kevinchappell/formBuilder","issue_id":638416841,"issue_number":1087,"issue_url":"https://github.com/kevinchappell/formBuilder/issues/1087","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_648609752","fragment_type":"issue_comment","sequence":3,"text":"Sure, here is the sample of my usage.\n\n### Initiate Multiple Instances\n\njavascript\nlet formIDs = ['#form1', '#form2']\nlet fbInstances = []\nlet options = [............]\n\nlet init = function(i) {\n if (i {\n fbInstances.push(res)\n i++\n init(i)\n })\n }\n}\n\ninit(0)\n\n \n\n### Get Data from All Instances on Submit\n\njavascript\nconst formData = []\n\nfbInstances.forEach(fbInstance => {\n formData.push(fbInstance.actions.getData())\n})","author_login":"myowinthein","author_association":"NONE","created_at":"2020-06-24T06:02:43+08:00","repo_name":"kevinchappell/formBuilder","issue_id":638416841,"issue_number":1087,"issue_url":"https://github.com/kevinchappell/formBuilder/issues/1087","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_890145161","fragment_type":"issue_comment","sequence":4,"text":"when I do this, I get `Cannot read property 'then' of undefined`. the first form id in `#form1` gets rendered, but the second one never does. any advice?","author_login":"maximus1127","author_association":"NONE","created_at":"2021-07-30T20:46:52+08:00","repo_name":"kevinchappell/formBuilder","issue_id":638416841,"issue_number":1087,"issue_url":"https://github.com/kevinchappell/formBuilder/issues/1087","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1689106147","fragment_type":"issue_comment","sequence":5,"text":"formRender does not have the promise interface, only multiple formBuilder instances need to be created via awaiting the promise interface.","author_login":"lucasnetau","author_association":"COLLABORATOR","created_at":"2023-08-23T00:52:31+08:00","repo_name":"kevinchappell/formBuilder","issue_id":638416841,"issue_number":1087,"issue_url":"https://github.com/kevinchappell/formBuilder/issues/1087","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0434","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"waardelijst soortblusinstallaties, niet compleet?","query_context":"Onderstaand de huidige inhoud van de waardelijst soortblusinstallaties V1.0.\nDaaronder de lijst zoals in BKL, bijlage VII tabel B.3.\nVraagt dat om een uitbreiding van de waarden in de IMEV lijst?\n\nimage\n\n \nInformatie over blusinstallaties uit BKL VII tabel B.3\n\n**Beschermingsniveau volgens PGS 15, blussysteem en stikstofgehalte** \n\n**Beschermingsniveau 1** \n(Semi-)automatische monitorinstallatie \nAutomatische deluge installatie \nAutomatische hi-ex outside-air installatie, stikstofgehalte 10% \nBedrijfsbrandweer met ter plaatse blussen, stikstofgehalte 10% \n\n**Beschermingsniveau 2a, stikstofgehalte 10 %**\nADR-klasse 3 in kunststof \nADR-klasse 3 niet in kunststof \nGeen ADR-klasse 3 \n\n**Beschermingsniveau 3**\nStikstofgehalte 10%\n\n**Alle beschermingsniveaus** \n Gasflessen","known_context_document_ids":["gh_issue_1084691551"],"reference_answer":"Gesloten, omdat het verwerkt is in versie 1.2 en omdat die versie goedgekeurd is.","answer_document_id":"gh_comment_1155304054","silver_evidence_path":["gh_comment_1029849854","gh_issue_889781390","gh_comment_1155304054"],"evidence_issue_ids":[1084691551,889781390],"source_repo_name":"Geonovum/imev-werkomgeving","source_issue_id":1084691551,"source_issue_number":37,"source_issue_url":"https://github.com/Geonovum/imev-werkomgeving/issues/37","target_repo_name":"Geonovum/imev-werkomgeving","target_issue_id":889781390,"target_issue_number":18,"target_issue_url":"https://github.com/Geonovum/imev-werkomgeving/issues/18","reference_anchor_document_id":"gh_comment_1029849854","reference_answer_author":"PB-GNM","reference_answer_author_association":"COLLABORATOR","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.2885,"anchor_target_overlap":0.3814,"target_answer_overlap":0.125},"issue_created_at":"2021-12-20T11:42:59+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_1084691551","fragment_type":"issue_description","sequence":0,"text":"waardelijst soortblusinstallaties, niet compleet?\nOnderstaand de huidige inhoud van de waardelijst soortblusinstallaties V1.0.\nDaaronder de lijst zoals in BKL, bijlage VII tabel B.3.\nVraagt dat om een uitbreiding van de waarden in de IMEV lijst?\n\nimage\n\n \nInformatie over blusinstallaties uit BKL VII tabel B.3\n\n**Beschermingsniveau volgens PGS 15, blussysteem en stikstofgehalte** \n\n**Beschermingsniveau 1** \n(Semi-)automatische monitorinstallatie \nAutomatische deluge installatie \nAutomatische hi-ex outside-air installatie, stikstofgehalte 10% \nBedrijfsbrandweer met ter plaatse blussen, stikstofgehalte 10% \n\n**Beschermingsniveau 2a, stikstofgehalte 10 %**\nADR-klasse 3 in kunststof \nADR-klasse 3 niet in kunststof \nGeen ADR-klasse 3 \n\n**Beschermingsniveau 3**\nStikstofgehalte 10%\n\n**Alle beschermingsniveaus** \n Gasflessen","author_login":"PalmJanssen","author_association":"CONTRIBUTOR","created_at":"2021-12-20T11:42:59+08:00","repo_name":"Geonovum/imev-werkomgeving","issue_id":1084691551,"issue_number":37,"issue_url":"https://github.com/Geonovum/imev-werkomgeving/issues/37","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1029849854","fragment_type":"issue_comment","sequence":1,"text":"reactie Manuel Betermans (RWS)\nIk ben het met jullie eens dat de lijst in de tabel van het Bkl en die uit het IMEV overeen zouden moeten komen; mij is niet bekend waarom hier een verschil in zou moeten zitten. Een tijd geleden hebben Hans de Waal en Wim Makaske (nu niet meer bij ministerie en bij ons werkzaam) een inventarisatie gemaakt van kenmerken die in de IMEV’s moesten. Op pagina 5 hebben ze dit voor tabel B3 gedaan, maar daar mis ik bijvoorbeeld in hun opsomming ook een Automatische hi-ex outside-air installatie; mij is niet duidelijk waarom dat zo is. Ik zou dus toch tabel B3 en de aanvullingen die Paul heeft gedaan als uitgangspunt nemen. \nWat uit dit document wel naar voren komt, is dat bijvoorbeeld een veld als ‘Oppervlakte opslagplaats in m2’ ook in het IMEV terug zou moeten komen. De uiteindelijk afstand uit tabel B3 hangt namelijk ook mede daarvan af; daarom is ook het beschermingsniveau als extra kenmerk voorgesteld (zie issue Opname Beschermingsniveau #18).\n\nzie ook doc:","author_login":"PalmJanssen","author_association":"CONTRIBUTOR","created_at":"2022-02-04T10:37:00+08:00","repo_name":"Geonovum/imev-werkomgeving","issue_id":1084691551,"issue_number":37,"issue_url":"https://github.com/Geonovum/imev-werkomgeving/issues/37","linked_issue_ids":[889781390],"is_known_query_context":false},{"document_id":"gh_comment_1034810410","fragment_type":"issue_comment","sequence":2,"text":"Werkgroep:\n- wat is de argumentatie achter keuze van de huidige waarden in de waardelijst\n- alleen die (11) opnemen waar niet te berekenen achterstaat (tabel B3, Bkl) blz 264, bijlage VII\n- kom met voorstel","author_login":"PalmJanssen","author_association":"CONTRIBUTOR","created_at":"2022-02-10T11:30:40+08:00","repo_name":"Geonovum/imev-werkomgeving","issue_id":1084691551,"issue_number":37,"issue_url":"https://github.com/Geonovum/imev-werkomgeving/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1057797410","fragment_type":"issue_comment","sequence":3,"text":"Klopt het dat het er 12 zijn en niet 11 zoals eerder in dit issue genoemd?","author_login":"PB-GNM","author_association":"COLLABORATOR","created_at":"2022-03-03T08:28:46+08:00","repo_name":"Geonovum/imev-werkomgeving","issue_id":1084691551,"issue_number":37,"issue_url":"https://github.com/Geonovum/imev-werkomgeving/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1058268339","fragment_type":"issue_comment","sequence":4,"text":"Werkgroep.\n\nBekijk dit opnieuw.\n- Wat is de bedoeling van dit attribuut? Je wilt weten op welke waarde uit tabel B3 de afstand is gebaseerd.\n- In feite is dat de eerste kolom van de tabel.\n- In die tabel zit structuur. Dat is nu vertaald naar meerdere attributen\n- voorstel: kijk of je een enumeratie kan maken waar die structuur in zit. Voorstel naam van de enumeratie. ..... Tabel B3.....","author_login":"PalmJanssen","author_association":"CONTRIBUTOR","created_at":"2022-03-03T17:05:25+08:00","repo_name":"Geonovum/imev-werkomgeving","issue_id":1084691551,"issue_number":37,"issue_url":"https://github.com/Geonovum/imev-werkomgeving/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1061918023","fragment_type":"issue_comment","sequence":5,"text":"Voorstel voor enumeratie waar de inhoud van tabel b3 in is verwerkt.\n\nimage","author_login":"PalmJanssen","author_association":"CONTRIBUTOR","created_at":"2022-03-08T15:43:36+08:00","repo_name":"Geonovum/imev-werkomgeving","issue_id":1084691551,"issue_number":37,"issue_url":"https://github.com/Geonovum/imev-werkomgeving/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1066504661","fragment_type":"issue_comment","sequence":6,"text":"Bericht Boudewijn:\nNaar de mening van Rogier en mijzelf is het niet nodig of gewenst om - naast de nieuwe tabel - andere attributen te behouden. Stikstofgehalte, ADR in kunststof verpakking, etc. zijn alleen relevant bij bepaalde systemen en uit de nieuwe tabel blijkt duidelijk wanneer een specifiek aspect relevant is.\nDus alleen de enumeratie van de nieuwe tabel (BeschermingsniveauTabelB3) en daarnaast de 'oppervlakte' zijn relevant voor de aan te houden vaste 'afstand'.\nDe andere attributen (SoortBlusinstallatie, CategorieStikstofgehalte, OpslagADRklasse3, opslagGasflessen) kunnen dus worden verwijderd.","author_login":"PalmJanssen","author_association":"CONTRIBUTOR","created_at":"2022-03-14T08:27:50+08:00","repo_name":"Geonovum/imev-werkomgeving","issue_id":1084691551,"issue_number":37,"issue_url":"https://github.com/Geonovum/imev-werkomgeving/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1156122193","fragment_type":"issue_comment","sequence":7,"text":"Gesloten, omdat het verwerkt is in versie 1.2 en omdat die versie goedgekeurd is.","author_login":"PB-GNM","author_association":"COLLABORATOR","created_at":"2022-06-15T07:55:01+08:00","repo_name":"Geonovum/imev-werkomgeving","issue_id":1084691551,"issue_number":37,"issue_url":"https://github.com/Geonovum/imev-werkomgeving/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_889781390","fragment_type":"issue_description","sequence":0,"text":"Opname Beschermingsniveau\nIndiener: Manuel Beterams\n\nBeantwoord door: Frank Zwiers\n\n**Vraag:**\nKlopt het dat er in het IMEV voor de opslag van verpakte gevaarlijke stoffen met vergunningplicht (en het gegevenswoordenboek) het beschermingsniveau van de opslag niet is opgenomen?\n\nWe hebben nog naar de tabel B.3 uit het Bkl bijlage VII gekeken en in lijn met wat Wim Makaske en Hans de Waal ook hadden geconstateerd, lijkt het ons belangrijk om het beschermingsniveau toch op te nemen in het informatiemodel. \n\n**Antwoord:**\nDe keuze om dit niet oorspronkelijk niet op te nemen is wel wat te verklaren denk ik. Bij dit kenmerk is in de BKL geen enkele afstand genoemd. Dit kan je dan zien als ‘kopjes’ in de tabel.\nAlle kenmerken waar een een afstand wordt bepaald staan er wel in en dat was de reden dat de lijst is opgesteld.\nRinus de Bruijne heeft het beschermingsniveau kenmerk volgens mij ook al eens benoemd in 1 van zijn mails. \nTot zover de analyse, lijkt me dat als dit een nuttig kenmerk is dit op de changelist moet zodat het toegevoegd kan worden.","author_login":"PalmJanssen","author_association":"CONTRIBUTOR","created_at":"2021-05-12T07:45:22+08:00","repo_name":"Geonovum/imev-werkomgeving","issue_id":889781390,"issue_number":18,"issue_url":"https://github.com/Geonovum/imev-werkomgeving/issues/18","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_874821756","fragment_type":"issue_comment","sequence":1,"text":"Bij welk object hoort dit attribuut potentieel? Bij IMEV:OpslagVerpakt_TeBerekenenAfstandVergunningsplicht","author_login":"PalmJanssen","author_association":"CONTRIBUTOR","created_at":"2021-07-06T14:41:53+08:00","repo_name":"Geonovum/imev-werkomgeving","issue_id":889781390,"issue_number":18,"issue_url":"https://github.com/Geonovum/imev-werkomgeving/issues/18","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_880775329","fragment_type":"issue_comment","sequence":2,"text":"is dit wat er wordt bedoeld? Alle classificatie informatie is nu in het objecttype vastgelegd, inclusief het beschermingsniveau:\nimage","author_login":"PalmJanssen","author_association":"CONTRIBUTOR","created_at":"2021-07-15T15:11:16+08:00","repo_name":"Geonovum/imev-werkomgeving","issue_id":889781390,"issue_number":18,"issue_url":"https://github.com/Geonovum/imev-werkomgeving/issues/18","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_887310609","fragment_type":"issue_comment","sequence":3,"text":"Beste Paul, hierbij zoals verzocht de reactie van Geodan:\n\nTechnische impact: De REV API specificatie moet gewijzigd worden.","author_login":"BrittvanWaveren","author_association":"NONE","created_at":"2021-07-27T08:17:27+08:00","repo_name":"Geonovum/imev-werkomgeving","issue_id":889781390,"issue_number":18,"issue_url":"https://github.com/Geonovum/imev-werkomgeving/issues/18","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1032561136","fragment_type":"issue_comment","sequence":4,"text":"Bovenstaande laatste opmerking beschrijft het wijzigingsverzoek.\nDeze 2 objecttypen komen voor als subtype van BLKActiviteit:\n<img width=\"420\" alt=\"image\" src=\" URL","author_login":"PB-GNM","author_association":"COLLABORATOR","created_at":"2022-02-08T12:34:44+08:00","repo_name":"Geonovum/imev-werkomgeving","issue_id":889781390,"issue_number":18,"issue_url":"https://github.com/Geonovum/imev-werkomgeving/issues/18","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1058186675","fragment_type":"issue_comment","sequence":5,"text":"- alle beschermingsniveaus kan weg.\n- alleen opnemen bij te berekenen afstanden. optioneel\n- Beschermingsniveau 1: Beschermingsniveau 1 volgens PGS 15","author_login":"PalmJanssen","author_association":"CONTRIBUTOR","created_at":"2022-03-03T15:53:38+08:00","repo_name":"Geonovum/imev-werkomgeving","issue_id":889781390,"issue_number":18,"issue_url":"https://github.com/Geonovum/imev-werkomgeving/issues/18","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1155304054","fragment_type":"issue_comment","sequence":6,"text":"Gesloten, omdat het verwerkt is in versie 1.2 en omdat die versie goedgekeurd is.","author_login":"PB-GNM","author_association":"COLLABORATOR","created_at":"2022-06-14T14:53:36+08:00","repo_name":"Geonovum/imev-werkomgeving","issue_id":889781390,"issue_number":18,"issue_url":"https://github.com/Geonovum/imev-werkomgeving/issues/18","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0436","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Scala 3 generated @main function is generated in package scope?","query_context":"## Compiler version\n\nScala 3\n\n## Minimized code\n\nSuppose you are converting a Scala 2 application that has 2 main methods in the same package. This is not that uncommon as you may put applications in a `app` package. Here is the code, put in the same file for simplicity for the issue.\n\nscala\npackage app\n\nobject Foo {\n def main(args: Array[String]): Unit = println(\"Foo\")\n}\n\nobject Bar {\n def main(args: Array[String]): Unit = println(\"Bar\")\n}\n\nNow you are converting this Scala 3 or just happen to want to add another application and you like the name `main` for your entry point as you are used to that convention. You convert the `args` using the documentation as you would get an conversion error **No given instance ...** if you left it as an `Array[String]`.\n\nscala\npackage app\n\nobject Foo {\n @main def main(args: String*): Unit = println(\"Foo\")\n}\n\nobject Bar {\n @main def main(args: String*): Unit = println(\"Bar\")\n}\n\n## Output\n\nNow this second example doesn't compile with a **main is already defined as main ...** error pointing to one or the other application that was compiled first.\n\n## Expectation\n\nGenerated or synthetic code should be scoped to the scope it is found in. It seems weird that code found in `object` scope is generated in package scope. This may be a more advanced way of thinking about this. The overall point is this is really surprising and bound to catch people because of the overall ergonomics.\n\nThere is also an additional surprise as follows:\n\nscala\npackage baz\n\nobject Bar {\n @main def main(): Unit = println(\"main Bar\")\n @main def bar(): Unit = println(\"bar Bar\")\n}\n\nResults in a warning (maybe for case insensitive file systems or something).\n\nscala\nwarn] 9 |object Bar {\n[warn] | ^\n[warn] |Not generating the static forwarders of Top(baz.Bar) because its name differs only in case from the name of another class or trait in this compilation unit.\n\nNote that main functions are not really special in Java except for the signature. They can be called by other code like a normal function. \n\nI know the intent was to try and make entry points easier, nicer, and more flexible with less boiler plate. These sort of \"edge\" cases or just stuff people may try to do will be very unexpected.\n\nThanks.","known_context_document_ids":["gh_issue_2453969514"],"reference_answer":"@EugeneFlesselle @jan-pieter @nmcb we will use the following Zoom link for today:\n URL","answer_document_id":"gh_comment_2286483270","silver_evidence_path":["gh_comment_2283672714","gh_issue_2460683482","gh_comment_2286483270"],"evidence_issue_ids":[2453969514,2460683482],"source_repo_name":"scala/scala3","source_issue_id":2453969514,"source_issue_number":21348,"source_issue_url":"https://github.com/scala/scala3/issues/21348","target_repo_name":"scala/scala3","target_issue_id":2460683482,"target_issue_number":21365,"target_issue_url":"https://github.com/scala/scala3/issues/21365","reference_anchor_document_id":"gh_comment_2283672714","reference_answer_author":"bracevac","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2778,"anchor_target_overlap":0.1944,"target_answer_overlap":0.125},"issue_created_at":"2024-08-07T17:20:46+08:00","valid_comment_count":16,"fragments":[{"document_id":"gh_issue_2453969514","fragment_type":"issue_description","sequence":0,"text":"Scala 3 generated @main function is generated in package scope\n## Compiler version\n\nScala 3\n\n## Minimized code\n\nSuppose you are converting a Scala 2 application that has 2 main methods in the same package. This is not that uncommon as you may put applications in a `app` package. Here is the code, put in the same file for simplicity for the issue.\n\nscala\npackage app\n\nobject Foo {\n def main(args: Array[String]): Unit = println(\"Foo\")\n}\n\nobject Bar {\n def main(args: Array[String]): Unit = println(\"Bar\")\n}\n\nNow you are converting this Scala 3 or just happen to want to add another application and you like the name `main` for your entry point as you are used to that convention. You convert the `args` using the documentation as you would get an conversion error **No given instance ...** if you left it as an `Array[String]`.\n\nscala\npackage app\n\nobject Foo {\n @main def main(args: String*): Unit = println(\"Foo\")\n}\n\nobject Bar {\n @main def main(args: String*): Unit = println(\"Bar\")\n}\n\n## Output\n\nNow this second example doesn't compile with a **main is already defined as main ...** error pointing to one or the other application that was compiled first.\n\n## Expectation\n\nGenerated or synthetic code should be scoped to the scope it is found in. It seems weird that code found in `object` scope is generated in package scope. This may be a more advanced way of thinking about this. The overall point is this is really surprising and bound to catch people because of the overall ergonomics.\n\nThere is also an additional surprise as follows:\n\nscala\npackage baz\n\nobject Bar {\n @main def main(): Unit = println(\"main Bar\")\n @main def bar(): Unit = println(\"bar Bar\")\n}\n\nResults in a warning (maybe for case insensitive file systems or something).\n\nscala\nwarn] 9 |object Bar {\n[warn] | ^\n[warn] |Not generating the static forwarders of Top(baz.Bar) because its name differs only in case from the name of another class or trait in this compilation unit.\n\nNote that main functions are not really special in Java except for the signature. They can be called by other code like a normal function. \n\nI know the intent was to try and make entry points easier, nicer, and more flexible with less boiler plate. These sort of \"edge\" cases or just stuff people may try to do will be very unexpected.\n\nThanks.","author_login":"ekrich","author_association":"CONTRIBUTOR","created_at":"2024-08-07T17:20:46+08:00","repo_name":"scala/scala3","issue_id":2453969514,"issue_number":21348,"issue_url":"https://github.com/scala/scala3/issues/21348","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2274381769","fragment_type":"issue_comment","sequence":1,"text":"I wouldn't say this is a bug - it was documented to behave this way: URL","author_login":"bishabosha","author_association":"MEMBER","created_at":"2024-08-07T21:29:16+08:00","repo_name":"scala/scala3","issue_id":2453969514,"issue_number":21348,"issue_url":"https://github.com/scala/scala3/issues/21348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2274445482","fragment_type":"issue_comment","sequence":2,"text":"Yes, I agree. Feel free to categorize it appropriately.\n\nOverall to me, it seems to just sort of defy the normal idea of scope. Top level scope is a different thing. Like I said above, I don't think it is that unusual to have more than one app in the same package. \n\nI like the typed arguments but I'm wondering if this will cause others troubles too, when the whole idea was to make things easier with less boilerplate.","author_login":"ekrich","author_association":"CONTRIBUTOR","created_at":"2024-08-07T22:19:40+08:00","repo_name":"scala/scala3","issue_id":2453969514,"issue_number":21348,"issue_url":"https://github.com/scala/scala3/issues/21348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2275085899","fragment_type":"issue_comment","sequence":3,"text":"I'm not sure if we want to change this behaviour, effectively breaking backwards compatibility... And I'm not even convinced if having multiple functions annotated as `@main` in a single codebase is even a good idea. But I see what you mean, there definitely would be a usecase.\n\nAs a middleground what I'm thinking is, maybe it'd be sufficient to improve the warnings to make this predictable?\nWhat I mean is, for this example:\n\nscala\npackage baz\n\nobject Bar {\n @main def main(): Unit = println(\"main Bar\")\n @main def bar(): Unit = println(\"bar Bar\")\n}\n\nWe currently (3.6.0-RC1-bin-20240807-54344a1-NIGHTLY) warn like this:\n\nscala\n[warn] ./repro.scala:3:8\n[warn] Generated class baz.Bar differs only in case from baz.bar.\n[warn] Such classes will overwrite one another on case-insensitive filesystems.\n[warn] object Bar {\n[warn] ^\n\nThe warning about generated classes doesn't explain the core issue to the user, maybe we could warn specifically for the duplicated `@main` here?","author_login":"Gedochao","author_association":"CONTRIBUTOR","created_at":"2024-08-08T06:56:33+08:00","repo_name":"scala/scala3","issue_id":2453969514,"issue_number":21348,"issue_url":"https://github.com/scala/scala3/issues/21348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2275674528","fragment_type":"issue_comment","sequence":4,"text":"My students have made all sorts of unaniticipated usages of @main-funcs over the last semesters with Scala 3 -- I try to solve this by saying that the should not name their @main `main` and have unique name. **A good warning with good hints of how to solve the issue would be nice.** (We use top-level @main almost always now, but the story on the legacy with actual main with string array in relation to what the JVM requires needs to be told eventually when they have gotten a bit further, so that students now how to interpret what a main actually is and how to get out of strange edge cases like this...)","author_login":"bjornregnell","author_association":"CONTRIBUTOR","created_at":"2024-08-08T12:14:47+08:00","repo_name":"scala/scala3","issue_id":2453969514,"issue_number":21348,"issue_url":"https://github.com/scala/scala3/issues/21348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2275905180","fragment_type":"issue_comment","sequence":5,"text":"Realistically, you can't have 2 mains (functions with the same signature) at any scope level so if `@main` is at the top level, it makes sense that you can't have 2 `main`s. At a different level, like scope inside an `object` we could always have a `main` per object. Now that we are having the annotation for main, we should just allow that to continue. In the end, generating a main or not, the semantics of what is written as a function, should really just act like a function. How the code is generated should not really alter the concept of the code that is written.\n\nIn this case it is just a warning but otherwise I can run this in VSCode and Metals.\n\nscala\npackage baz\n\nobject Bar {\n @main def main(): Unit = println(\"main Bar\")\n @main def bar(): Unit = println(\"bar Bar\")\n}\n\nWhat concerns me about this is I have written `baz.Bar.bar` and `baz.Bar.main` so without the annotation this seems like normal code. How that works I have no idea - I haven't looked at the generated byte code. If that isn't allowed I understand but it works - not sure why the `bar` function is lifted so the compiler sees the `object baz.Bar` and then the function `baz.Bar.bar` becomes `baz.bar` so then there is a warning. A child or beginner is unlikely to understand the file system case insensitive issue.\n\nThe following example works perfectly fine. Maybe I wasn't clear. My objection was that I couldn't have 2 `main` with the same signature inside different `object`s in the same package - I can rewrite those as a normal `main`s and have as many as I want but then I can't take advantage of the `@main` functionality.\n\nscala\nobject Foo {\n @main def main(args: String*): Unit = println(\"Foo\")\n}\n\nPerhaps I should have put my first example that works - but with the warning. I even get like `run` lenses so I can run them all.\n\nscala\npackage baz\n\npackage foo {\n object Foo {\n @main def main(): Unit = println(\"Foo\")\n }\n}\n\nobject Bar {\n @main def main(): Unit = println(\"main Bar\")\n @main def bar(): Unit = println(\"bar Bar\")\n}\n\nThe 2 `main`s are ok because they are in different packages. That was a modification from my original try with 2 `object`s with `main`s in the same package that didn't convert directly across from actual code in the wild.\n\nI am unclear on the compatibility issue of the generated mains unless it is tool or TASTY related.","author_login":"ekrich","author_association":"CONTRIBUTOR","created_at":"2024-08-08T13:58:41+08:00","repo_name":"scala/scala3","issue_id":2453969514,"issue_number":21348,"issue_url":"https://github.com/scala/scala3/issues/21348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2277714135","fragment_type":"issue_comment","sequence":6,"text":"I imagine this could be a problem since naming is difficult and a lot of people will just do `@main def main =...` everywhere :sweat_smile: \n\nWould it be possible to automatically resolve such conflicts? I see two options:\n- if we have the same named methods with `@main` annotation then add some synthetic number to the name?\n- or if leave the second method inside it's current scope, generate the object inside the current object where the method is defined\n\nThis should be largely compatible, since currently this is an error, but I am not sure if it's doable?","author_login":"tgodzik","author_association":"CONTRIBUTOR","created_at":"2024-08-09T11:12:36+08:00","repo_name":"scala/scala3","issue_id":2453969514,"issue_number":21348,"issue_url":"https://github.com/scala/scala3/issues/21348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2278598757","fragment_type":"issue_comment","sequence":7,"text":"Adding trailing numbers 1.. to disambiguate sounds like a simple and useful enhancement. (Similar to scala-cli and the sbt shell when you run and there are multiple mains)","author_login":"bjornregnell","author_association":"CONTRIBUTOR","created_at":"2024-08-09T19:22:15+08:00","repo_name":"scala/scala3","issue_id":2453969514,"issue_number":21348,"issue_url":"https://github.com/scala/scala3/issues/21348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2283672714","fragment_type":"issue_comment","sequence":8,"text":"I extracted the warning for 2 `@main` annotations for differently named methods in a single object to #21365, as that seems like a separate, reporting issue.\n\nThe requirements for this is to:\n- try to support `@main` annotation for multiple methods under the same name\n- not break backwards compatibility\n\nMethods to achieve this have been discussed above, we're not sure what (and if anything) would turn out feasible. It may turn out we end up not supporting this, but it may be worth a try.","author_login":"Gedochao","author_association":"CONTRIBUTOR","created_at":"2024-08-12T11:04:56+08:00","repo_name":"scala/scala3","issue_id":2453969514,"issue_number":21348,"issue_url":"https://github.com/scala/scala3/issues/21348","linked_issue_ids":[2460683482],"is_known_query_context":false},{"document_id":"gh_comment_2367804279","fragment_type":"issue_comment","sequence":9,"text":"Just to re-clarify, as noted in #21365, having multiple `@main` methods with different names _is_ already supported:\n\nscala\n// ~/scala-snippets-6/multi_main.scala\nobject Bar {\n @main def main1(): Unit = println(\"main 1\")\n @main def main2(): Unit = println(\"main 2\")\n}\n\n➜ ~/scala-snippets-6 scala multi_main.scala --main-class main1\nCompiling project (Scala 3.5.0, JVM (17))\nCompiled project (Scala 3.5.0, JVM (17))\nmain 1\n➜ ~/scala-snippets-6 scala multi_main.scala --main-class main2\nCompiling project (Scala 3.5.0, JVM (17))\nCompiled project (Scala 3.5.0, JVM (17))\nmain 2\n➜ ~/scala-snippets-6 scala --version\nScala code runner version: 1.4.0\nScala version (default): 3.5.0\n\nHowever, as each `@main` method results in a class with the method's name, this name must be different than other objects or classes. This is not the case for `object Bar` and `@main def bar` in the example above: ignoring case, these are the same.","author_login":"mbovel","author_association":"MEMBER","created_at":"2024-09-23T10:24:58+08:00","repo_name":"scala/scala3","issue_id":2453969514,"issue_number":21348,"issue_url":"https://github.com/scala/scala3/issues/21348","linked_issue_ids":[2460683482],"is_known_query_context":false},{"document_id":"gh_comment_2367810122","fragment_type":"issue_comment","sequence":10,"text":"What does _not_ work is other have two `@main` methods with the same name:\n\nscala\nobject Foo {\n @main def main(): Unit = println(\"main 1\")\n}\n\nobject Bar {\n @main def main(): Unit = println(\"main 2\")\n // error: main is already defined as class main\n\nThis is expected and spec'd that way: `class main` thus is already defined by the first `@main` so cannot be redefined.\n\nTo circumvent this issue, we would need to follow one of @tgodzik suggestions:\n \n \n \n \n \n \n\nHowever:\n\n- Synthetic numbers seem confusing to me: if there are several main methods, the user will ultimately need to specify which one to run using `--main-class`, so it better not be a generated name.\n- Conditionally leaving the method in an inner scope seems hard to specify. Would that be done only if the method name would result in a clash in an outer scope?\n\nAll in all, it seems to me that the current behavior is probably okay.\n\nWhatever we decide, it needs to be spec'd before someone can tackle this issue during an issue spree.","author_login":"mbovel","author_association":"MEMBER","created_at":"2024-09-23T10:27:48+08:00","repo_name":"scala/scala3","issue_id":2453969514,"issue_number":21348,"issue_url":"https://github.com/scala/scala3/issues/21348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2379549339","fragment_type":"issue_comment","sequence":11,"text":"I guess this is pretty disappointing as methods with the same name and signature in 2 differently named `object`s in the same package are always allowed including standard `main` methods like `def main(args: Array[String]): Unit = ???`. Adding the `@main` to these and changing the signature to `String*` doesn't work. This doesn't pass the least surprise test and the user walks away wondering what synthetic code is generated.","author_login":"ekrich","author_association":"CONTRIBUTOR","created_at":"2024-09-27T15:29:18+08:00","repo_name":"scala/scala3","issue_id":2453969514,"issue_number":21348,"issue_url":"https://github.com/scala/scala3/issues/21348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2381433485","fragment_type":"issue_comment","sequence":12,"text":"I think that at least a good errormessage or warning should be given when problems arise. @mbovel Perhaps re-open this issue and rename it to something related to \"improved error messages and warnings\" ? There could be help included in the message how to cover the use cases outlined by @ekrich","author_login":"bjornregnell","author_association":"CONTRIBUTOR","created_at":"2024-09-29T17:21:18+08:00","repo_name":"scala/scala3","issue_id":2453969514,"issue_number":21348,"issue_url":"https://github.com/scala/scala3/issues/21348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2385597082","fragment_type":"issue_comment","sequence":13,"text":"How would you improve the error message? It currently says:\n\n// error: main is already defined as class main\n\nWould you special case it for `@main` methods?\n\n// error: main is already defined as @main method main\n\nI guess we could re-purpose this issue, or open a new one.","author_login":"mbovel","author_association":"MEMBER","created_at":"2024-10-01T12:04:09+08:00","repo_name":"scala/scala3","issue_id":2453969514,"issue_number":21348,"issue_url":"https://github.com/scala/scala3/issues/21348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2460683482","fragment_type":"issue_description","sequence":0,"text":"Unexpected warning when `@main` is used twice within a single object\n## Compiler version\n3.4.2, 3.3.3, 3.6.0-RC1-bin-20240810-ba2c731-NIGHTLY\n\n## Minimized code\n\nscala\npackage baz\n\nobject Bar {\n @main def main(): Unit = println(\"main Bar\")\n @main def bar(): Unit = println(\"bar Bar\")\n}\n\n## Output\n\nscala\n[warn] ./repro.scala:3:8\n[warn] object Bar differs only in case from class bar in package baz. Such classes will overwrite one another on case-insensitive filesystems.\n[warn] object Bar {\n[warn] ^\n\n## Expectation\nOne of two:\n- a better warning about using the `@main` annotation twice, if needed\n- no warning, as this particular code is valid and both main methods (`baz.bar` & `baz.main`) can be accessed.\n\nbash\nscala-cli run repro.scala --main-class-ls\n# [warn] ./repro.scala:3:8\n# [warn] Generated class baz.Bar differs only in case from baz.bar.\n# [warn] Such classes will overwrite one another on case-insensitive filesystems.\n# [warn] object Bar {\n# [warn] ^\n# baz.bar baz.main\n\n## Context\nExtracted out of:\n- URL","author_login":"Gedochao","author_association":"CONTRIBUTOR","created_at":"2024-08-12T11:01:14+08:00","repo_name":"scala/scala3","issue_id":2460683482,"issue_number":21365,"issue_url":"https://github.com/scala/scala3/issues/21365","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2284230605","fragment_type":"issue_comment","sequence":1,"text":"This issue was picked for the Scala Issue Spree of tomorrow, August 13th. @EugeneFlesselle @bracevac @jan-pieter and @nmcb will be working on it. If you have any insight into the issue or guidance on how to fix it, please leave it here.","author_login":"mbovel","author_association":"MEMBER","created_at":"2024-08-12T15:05:23+08:00","repo_name":"scala/scala3","issue_id":2460683482,"issue_number":21365,"issue_url":"https://github.com/scala/scala3/issues/21365","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2286483270","fragment_type":"issue_comment","sequence":2,"text":"@EugeneFlesselle @jan-pieter @nmcb we will use the following Zoom link for today:\n URL","author_login":"bracevac","author_association":"COLLABORATOR","created_at":"2024-08-13T15:05:17+08:00","repo_name":"scala/scala3","issue_id":2460683482,"issue_number":21365,"issue_url":"https://github.com/scala/scala3/issues/21365","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2286523959","fragment_type":"issue_comment","sequence":3,"text":"The issue has nothing to do with multiple `@main` annotations. As the warning correctly points out, the naming will cause issues with non-casesensitive filenames. So there is nothing to be done here.","author_login":"bracevac","author_association":"COLLABORATOR","created_at":"2024-08-13T15:23:46+08:00","repo_name":"scala/scala3","issue_id":2460683482,"issue_number":21365,"issue_url":"https://github.com/scala/scala3/issues/21365","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0443","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Adding UNITASK_DOTWEEN_SUPPORT scripting define results in a ton of warnings about not awaiting a tween/sequence?","query_context":"I'm using DOTween for tweens and UniTask for async. I didn't realize for a while that DOTween was supported directly but a script define had to be added. So I went to add it today and it results in a ton of warnings on my tweens/sequences saying \"Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.\". Some examples of code:\n\nSequence s = DOTween.Sequence();\n// every line after this shows the warning\ns.Append(container.DOFade(1, 0.75f));\ns.AppendInterval(this.mediaDuration);\ns.Append(container.DOFade(0, 0.75f));\ns.SetId(this.GetInstanceID());\n\nTween t = container.DOFade(0, 0.25f);\nbool wasKilled = false;\n// the following line shows the warning\nt.OnKill(() => wasKilled = true);\n\n// all regular tweens show it too\nthis.rightQuestion.DOFade(1, 1);\n\nAny way to make these warnings go away? I think the issue is that Tweens are directly awaitable (`await this.rightQuestion.DOFade(1, 1)`). I wonder if it would make more sense to require calling a function on the tween/sequence in order to await the tween. For example, without the script define, you have to do `this.rightQuestion.DOFade(1, 1).AsyncWaitForCompletion()` in order to await the tween. For UnityWebRequests, you have to call `SendWebRequest` in order to await it. Seems like it would be more consistent with other objects if you had to call a function and it would remove all the warnings.","known_context_document_ids":["gh_issue_1888875846"],"reference_answer":"Ah yeah. I don't think that's too bad.\n\nHowever, isn't it a bit confusing that the presence or absence of `using UniTask` changes whether or not a discard is required?","answer_document_id":"gh_comment_1909423767","silver_evidence_path":["gh_comment_1718674004","gh_issue_1641551589","gh_comment_1909423767"],"evidence_issue_ids":[1888875846,1641551589],"source_repo_name":"Cysharp/UniTask","source_issue_id":1888875846,"source_issue_number":502,"source_issue_url":"https://github.com/Cysharp/UniTask/issues/502","target_repo_name":"Cysharp/UniTask","target_issue_id":1641551589,"target_issue_number":452,"target_issue_url":"https://github.com/Cysharp/UniTask/issues/452","reference_anchor_document_id":"gh_comment_1718674004","reference_answer_author":"hadashiA","reference_answer_author_association":"MEMBER","quality_score":86.12,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1875,"anchor_target_overlap":0.1875,"target_answer_overlap":0.0625},"issue_created_at":"2023-09-09T21:15:15+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_1888875846","fragment_type":"issue_description","sequence":0,"text":"Adding UNITASK_DOTWEEN_SUPPORT scripting define results in a ton of warnings about not awaiting a tween/sequence\nI'm using DOTween for tweens and UniTask for async. I didn't realize for a while that DOTween was supported directly but a script define had to be added. So I went to add it today and it results in a ton of warnings on my tweens/sequences saying \"Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.\". Some examples of code:\n\nSequence s = DOTween.Sequence();\n// every line after this shows the warning\ns.Append(container.DOFade(1, 0.75f));\ns.AppendInterval(this.mediaDuration);\ns.Append(container.DOFade(0, 0.75f));\ns.SetId(this.GetInstanceID());\n\nTween t = container.DOFade(0, 0.25f);\nbool wasKilled = false;\n// the following line shows the warning\nt.OnKill(() => wasKilled = true);\n\n// all regular tweens show it too\nthis.rightQuestion.DOFade(1, 1);\n\nAny way to make these warnings go away? I think the issue is that Tweens are directly awaitable (`await this.rightQuestion.DOFade(1, 1)`). I wonder if it would make more sense to require calling a function on the tween/sequence in order to await the tween. For example, without the script define, you have to do `this.rightQuestion.DOFade(1, 1).AsyncWaitForCompletion()` in order to await the tween. For UnityWebRequests, you have to call `SendWebRequest` in order to await it. Seems like it would be more consistent with other objects if you had to call a function and it would remove all the warnings.","author_login":"Stever1388","author_association":"NONE","created_at":"2023-09-09T21:15:15+08:00","repo_name":"Cysharp/UniTask","issue_id":1888875846,"issue_number":502,"issue_url":"https://github.com/Cysharp/UniTask/issues/502","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1715246016","fragment_type":"issue_comment","sequence":1,"text":"I was just thinking about the same problem.\nFor safety reasons, I would like to treat CS4014 as an error, but it is difficult to correct all the parts that use DOTween.\nIs it possible to provide a define symbol for disable the `GetAwaiter` extension method?","author_login":"takumi-shimomura","author_association":"NONE","created_at":"2023-09-12T08:28:06+08:00","repo_name":"Cysharp/UniTask","issue_id":1888875846,"issue_number":502,"issue_url":"https://github.com/Cysharp/UniTask/issues/502","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1718674004","fragment_type":"issue_comment","sequence":2,"text":"Duplicate of #452 .\n\nUnfortunately it seems difficult to support anything officially.\nThere is an option to use `#pragma warning disable CS4014` . And if you want to convert to UniTask you can use `.Forget()`.","author_login":"hadashiA","author_association":"MEMBER","created_at":"2023-09-14T02:48:58+08:00","repo_name":"Cysharp/UniTask","issue_id":1888875846,"issue_number":502,"issue_url":"https://github.com/Cysharp/UniTask/issues/502","linked_issue_ids":[1641551589],"is_known_query_context":false},{"document_id":"gh_comment_1720338696","fragment_type":"issue_comment","sequence":3,"text":"Yeah, not impossible, but breaking changes with significant impact.\nApparently, when this library was created, the compiler did not warn about the extension methods. So at the time, the API seemed reasonable. However, making a major change to this is a big deal.\n \n\nI wonder if this is a method provided by DOTWeen. This uses System.Threading.Task; UniTask provides a more optimized implementation than Task.\n \n\n`SendWebRequest()` has exactly the same problem as this issue. It returns Unity's AsyncOperation, which Unity is not designed to await, but UniTask provides an extension that allows it to await.\nIf an object representing an asynchronous operation has been created and is running, being able to await it as is is certainly easier to use. I think the problem is that tween is used in a way that does not wait for completion. Your suggestion is one way to do it, but I think it has a lot of impact and is something to consider.","author_login":"hadashiA","author_association":"MEMBER","created_at":"2023-09-15T00:54:49+08:00","repo_name":"Cysharp/UniTask","issue_id":1888875846,"issue_number":502,"issue_url":"https://github.com/Cysharp/UniTask/issues/502","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1721818025","fragment_type":"issue_comment","sequence":4,"text":"Hmm, yeah that makes sense. I wonder how many people use this package with DOTween enabled? I didn't even realize it could be enabled and I've been using this for awhile. Sometimes breaking changes for the betterment of the package is necessary... sometimes I wish Unity would just break some things to make their APIs better, like the fact that actions (like OnClick) don't return the sender as the first parameter (which is what Microsoft recommends for events). But I could see an argument for not breaking it... but honestly my preference would be to break it with a major version update.\n \n \n \n\nYes, this is a function that DOTween provides that can be directed awaited. I usually call `AsUniTask()` on it, not really sure if that's needed it makes it more optimized or not, so it looks something like `await aCanvasGroup.DOFade(1, 0.75f).AsyncWaitForCompletion().AsUniTask();`. Right now, since I don't have the DOTween part enabled, if I want to add a cancellation token to it, I then chain `.AttachExternalCancellation(token);` to it, and in the `catch` part I kill the tween manually (since the cancellation doesn't cancel it itself, I'm assuming because it's an \"external\" cancellation). If I enable DOTween support, I can do just the regular `WithCancellation(token)` (I think) and it will kill the tween without me having to do it.\n \n \n \n\nHmmm, I think Unity's AsyncOperations are allowed to be awaited. I've done `await www.SendWebRequest()` even without UniTask installed and it works as expected. With UniTask installed, I don't know if it's better to leave it like that or do `.ToUnitTask()` on it and await that. If I need to add a cancellation token to it, I do `await await www.SendWebRequest().WithCancellation(token);`\n\nBut in general, I would still support just breaking it and letting people know it's going to change/break. As an alternative, I wonder if a fork could be created that has these breaking changes in it? I don't know if there's another solution. Maybe a different scripting define? So you have two versions of the DOTween extensions, one that is the original and one that changes the way it works and then the scripting define can be like UNITASK_DOTWEEN_SUPPORT_ALT or something. So people can choose to stick with what they are using or use the new one.","author_login":"Stever1388","author_association":"NONE","created_at":"2023-09-15T20:19:56+08:00","repo_name":"Cysharp/UniTask","issue_id":1888875846,"issue_number":502,"issue_url":"https://github.com/Cysharp/UniTask/issues/502","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1641551589","fragment_type":"issue_description","sequence":0,"text":"DOTween CS4014\nI get an error `warning CS4014: Because this call is not awaited, \nexecution of the current method continues before the call is completed. \nConsider applying the 'await' operator to the result of the call.`\n\nIn the following code:\n\ncsharp\nprivate async UniTask DoMagic()\n{\n // await logic here\n ...\n // DOTween\n var seq = DOTween.Sequence();\n for (int i = 0; i < n; ++i) {\n seq.Insert(time, transform.DOScale(0.3f, 0.1f); // CS4014\n .Insert(time, transform.DOMove(Vector3.zero, 0.1f);\n }\n}\n\nHow to suppress it?","author_login":"truenoob141","author_association":"NONE","created_at":"2023-03-27T07:31:41+08:00","repo_name":"Cysharp/UniTask","issue_id":1641551589,"issue_number":452,"issue_url":"https://github.com/Cysharp/UniTask/issues/452","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1615303195","fragment_type":"issue_comment","sequence":1,"text":"Use something like:\n\n#pragma warning disable CS4014 // disable warning\n\nprivate async UniTask DoMagic()\n{\n // await logic here\n ...\n // DOTween\n var seq = DOTween.Sequence();\n for (int i = 0; i < n; ++i) {\n seq.Insert(time, transform.DOScale(0.3f, 0.1f); // CS4014\n .Insert(time, transform.DOMove(Vector3.zero, 0.1f);\n }\n}\n\n#pragma warning restore CS4014 // restore warning\n\nYou could also just use a single pragma at the top of the file.","author_login":"desmondfernando","author_association":"NONE","created_at":"2023-07-01T00:25:26+08:00","repo_name":"Cysharp/UniTask","issue_id":1641551589,"issue_number":452,"issue_url":"https://github.com/Cysharp/UniTask/issues/452","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1619021654","fragment_type":"issue_comment","sequence":2,"text":"@desmondfernando thanks for reply! But it's not the best solution to write pragma everywhere :(","author_login":"truenoob141","author_association":"NONE","created_at":"2023-07-03T19:07:32+08:00","repo_name":"Cysharp/UniTask","issue_id":1641551589,"issue_number":452,"issue_url":"https://github.com/Cysharp/UniTask/issues/452","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1694508946","fragment_type":"issue_comment","sequence":3,"text":"Thanks for the trick! A permanent solution would even better :)","author_login":"loto","author_association":"NONE","created_at":"2023-08-26T21:56:27+08:00","repo_name":"Cysharp/UniTask","issue_id":1641551589,"issue_number":452,"issue_url":"https://github.com/Cysharp/UniTask/issues/452","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1702236309","fragment_type":"issue_comment","sequence":4,"text":"Hmm.. there seems to be no better way than `#pragma ` .\n\nNote: \nC# does not make extension methods a warning until after UniTask was released.\nIf extension method is in a different namespace, it may be possible to control the use of extension method only when you want to wait, but it is difficult to change it now.","author_login":"hadashiA","author_association":"MEMBER","created_at":"2023-09-01T06:29:59+08:00","repo_name":"Cysharp/UniTask","issue_id":1641551589,"issue_number":452,"issue_url":"https://github.com/Cysharp/UniTask/issues/452","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1908858582","fragment_type":"issue_comment","sequence":5,"text":"@hadashiA What about using discards? URL \n\nThis line gives me the compiler warning about not awaiting a tween:\n`myGameObject.transform.DOLocalMoveY(1, .5f).SetEase(Ease.InBack);`\n\nBut the compiler warning goes away when I use a discard, like this:\n`_ = myGameObject.transform.DOLocalMoveY(1, .5f).SetEase(Ease.InBack);`","author_login":"joelbschwartz","author_association":"NONE","created_at":"2024-01-24T20:23:00+08:00","repo_name":"Cysharp/UniTask","issue_id":1641551589,"issue_number":452,"issue_url":"https://github.com/Cysharp/UniTask/issues/452","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1909423767","fragment_type":"issue_comment","sequence":6,"text":"Ah yeah. I don't think that's too bad.\n\nHowever, isn't it a bit confusing that the presence or absence of `using UniTask` changes whether or not a discard is required?","author_login":"hadashiA","author_association":"MEMBER","created_at":"2024-01-25T06:16:50+08:00","repo_name":"Cysharp/UniTask","issue_id":1641551589,"issue_number":452,"issue_url":"https://github.com/Cysharp/UniTask/issues/452","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1924879723","fragment_type":"issue_comment","sequence":7,"text":"I agree that it's confusing, and seems to leave the compiler as a guide to where to use the discards because it's not readily apparent where and why they are used. Maybe at best it's a preferable alternative to `#pragma warning disable CS4014` and at worst, it's confusing without a comment in the code to explain the purpose?","author_login":"joelbschwartz","author_association":"NONE","created_at":"2024-02-02T23:02:34+08:00","repo_name":"Cysharp/UniTask","issue_id":1641551589,"issue_number":452,"issue_url":"https://github.com/Cysharp/UniTask/issues/452","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2239053158","fragment_type":"issue_comment","sequence":8,"text":"If this happens because of UniTask, another way to handle this is to convert it `ToUniTask`, and then `Forget` it , like `myGameObject.transform.DOLocalMoveY(1, .5f).SetEase(Ease.InBack).ToUniTask().Forget();`","author_login":"brinca","author_association":"NONE","created_at":"2024-07-19T12:41:53+08:00","repo_name":"Cysharp/UniTask","issue_id":1641551589,"issue_number":452,"issue_url":"https://github.com/Cysharp/UniTask/issues/452","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0448","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Carthage Xcode >=12 compatibility?","query_context":"Generate xcframework for the next version in order to avoid using carthage workaround\n\n URL \n\n@cbaker6","known_context_document_ids":["gh_issue_780775604"],"reference_answer":"@mman I've been bashing my head against against something for a minute now... I've got my branch rebased with mainline, but it seems like no matter what I do, I can't get the tests to see the main source files. You're doing it with cSettings I gather, but when I do similar, they seem to be ignored.\n\nDo you know of any reason why this might be? The only differences I can see are that I use the path and publicHeadersPath attributes.","answer_document_id":"gh_comment_1027982635","silver_evidence_path":["gh_comment_1017476827","gh_issue_496619883","gh_comment_1027982635"],"evidence_issue_ids":[780775604,496619883],"source_repo_name":"parse-community/Parse-SDK-iOS-OSX","source_issue_id":780775604,"source_issue_number":1591,"source_issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1591","target_repo_name":"parse-community/Parse-SDK-iOS-OSX","target_issue_id":496619883,"target_issue_number":1453,"target_issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","reference_anchor_document_id":"gh_comment_1017476827","reference_answer_author":"drdaz","reference_answer_author_association":"MEMBER","quality_score":92.56,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.3,"target_answer_overlap":0.0312},"issue_created_at":"2021-01-06T18:57:41+08:00","valid_comment_count":49,"fragments":[{"document_id":"gh_issue_780775604","fragment_type":"issue_description","sequence":0,"text":"Carthage Xcode >=12 compatibility\nGenerate xcframework for the next version in order to avoid using carthage workaround\n\n URL \n\n@cbaker6","author_login":"jesusmateos1234","author_association":"NONE","created_at":"2021-01-06T18:57:41+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":780775604,"issue_number":1591,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1591","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1017454197","fragment_type":"issue_comment","sequence":1,"text":"We may be moving straight to SPM support and skip fixing the carthage build altogether, see discussion in URL In the meantime, I found a rather complex way to build with carthage on Xcode 13.2.1:\n\n1. Use carthage build script `carthage.sh` for Xcode >12 compatibility\n2. Build all xcframeworks; do not use `--no-use-binaries` as `facebook-ios-sdk` is required as dependency of Parse SDK but cannot be built from source in Xcode 13; run: `./carthage.sh update --use-xcframeworks --platform iOS`\n3. Add built xcframeworks to Xcode project, except `Parse.xcframework`\n4. Open `Carthage/Checkouts/facebook-ios-sdk/samples/SmoketestSPM/SmoketestSPM.xcodeproj` and wait for SMP to download the dependency; see here.\n5. Build Parse SDK frameworks because `ParseFacebookUtilsV4.xcframework` requires `Parse.framework` (not as xcframework), so it needs to be built and added via `carthage copy-frameworks` in the Xcode project's build phases; run: `./carthage.sh update Parse-SDK-iOS-OSX --platform iOS`","author_login":"mtrezza","author_association":"MEMBER","created_at":"2022-01-20T12:35:46+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":780775604,"issue_number":1591,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1591","linked_issue_ids":[496619883],"is_known_query_context":false},{"document_id":"gh_comment_1017476827","fragment_type":"issue_comment","sequence":2,"text":"I'm keeping this issue open as a thread to look for help when building with carthage, but with a note that we intend to focus on Swift Package Manager support ( URL instead of fixing carthage build process.","author_login":"mtrezza","author_association":"MEMBER","created_at":"2022-01-20T12:53:49+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":780775604,"issue_number":1591,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1591","linked_issue_ids":[496619883],"is_known_query_context":false},{"document_id":"gh_comment_1407652466","fragment_type":"issue_comment","sequence":3,"text":"Closing as release 2.0.0 supports import via Swift Package Manager.","author_login":"mtrezza","author_association":"MEMBER","created_at":"2023-01-29T12:37:30+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":780775604,"issue_number":1591,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1591","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_496619883","fragment_type":"issue_description","sequence":0,"text":"Support Swift Package Manager\nParse has two dependencies, **Bolts** and **OCMock**.\n\nI think Bolts is not maintainability, so If we want to keep the Parse-Objc or support latest tech stacks like SPM, I think fork the Bolts is a better option.\n\nHere is my suggestion.\n\n1. Fork Bolts and OCMock into the parse-community.\n2. Make a Package.swift for Bolts and OCMock to support SPM.\n3. Make a Package.swift for Parse-SDK-iOS-OSX.\n\nThat's it.\n\nWhat do you think about this?\n\nAnother option is to focus on the **Parse-Swift** like Parse Dart SDK.\n\nPS. FireBase also has dependencies with OCMock. URL","author_login":"ShawnBaek","author_association":"CONTRIBUTOR","created_at":"2019-09-21T06:21:53+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_533902237","fragment_type":"issue_comment","sequence":1,"text":"Would we actually need to do anything to OCMock? It's not part of the distribution as far as I can tell; it's a development dependency.\n\nFYI I don't know anything about SPM yet, but I assume it would be used to install the client to projects. Just using the SDK in a project doesn't require OCMock.","author_login":"drdaz","author_association":"CONTRIBUTOR","created_at":"2019-09-22T17:45:46+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_534139164","fragment_type":"issue_comment","sequence":2,"text":"This sounds like a great idea. Do you want to open a PR for the iOS part of the process?","author_login":"mrmarcsmith","author_association":"COLLABORATOR","created_at":"2019-09-23T15:01:32+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_534395753","fragment_type":"issue_comment","sequence":3,"text":"@mrmrcsmith I can’t fork into the area repository. Could you fork it? I’ll make a PR","author_login":"ShawnBaek","author_association":"CONTRIBUTOR","created_at":"2019-09-24T05:31:54+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_534414585","fragment_type":"issue_comment","sequence":4,"text":"sure! It would be great if your PR included some instructions in the README on how to use SPM with Parse since this would be my first experience using SPM so I'm sure lots of other people are curious how to use it too.","author_login":"mrmarcsmith","author_association":"COLLABORATOR","created_at":"2019-09-24T06:41:34+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_534853105","fragment_type":"issue_comment","sequence":5,"text":"Anyone should be able to fork parse. Thats super weird. \n\nSo, I'm curious if we could talk to the bolts guys about just turning the repo to us. Like Parse, Bolts was previously maintained by Facebook and at around the same time as Parse they turned over Bolts to community contributors. So, theres probably at least a little report with them. Not to mention Parse is probably the largest application to use Bolts.","author_login":"noobs2ninjas","author_association":"MEMBER","created_at":"2019-09-25T05:02:33+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_644765031","fragment_type":"issue_comment","sequence":6,"text":"SPM is getting more popular recently and with WWDC and Xcode updates coming soon I'm guessing it will only increase.\n\nJust bringing this up to see if we can re-open and figure out what to do with Bolts.","author_login":"Vortec4800","author_association":"NONE","created_at":"2020-06-16T13:27:43+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_651158677","fragment_type":"issue_comment","sequence":7,"text":"@noobs2ninjas has been communicating with FB open source so if someone wants to make a PR to bolts to support SPM we could probably get it merged now.","author_login":"TomWFox","author_association":"MEMBER","created_at":"2020-06-29T14:29:07+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_700710399","fragment_type":"issue_comment","sequence":8,"text":"Just to clarify, the PR is needed to Bolts-ObjC as the Swift version of Bolts is already SPM compatible.","author_login":"paulfreeman","author_association":"NONE","created_at":"2020-09-29T13:39:52+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_758686438","fragment_type":"issue_comment","sequence":9,"text":"Definitely bumping for support especially since now SwiftPM has a gui and has been updated to handle frameworks better. Its far easier and less cumbersome then pods at this point.","author_login":"EliteTechnicalCare","author_association":"NONE","created_at":"2021-01-12T14:21:37+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_762218600","fragment_type":"issue_comment","sequence":10,"text":"We would gladly accept a PR for this, as I understand we still need SPM support from Bolts-obj.","author_login":"TomWFox","author_association":"MEMBER","created_at":"2021-01-18T12:26:39+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_842960811","fragment_type":"issue_comment","sequence":11,"text":"Right now I'm working on a fork of our dependency Bolts-Objc with SPM support. Once that works, I'll see if I can do the same to the SDK.\n\nI can't give you an estimate on completion, sorry.","author_login":"drdaz","author_association":"MEMBER","created_at":"2021-05-18T08:17:16+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_846131347","fragment_type":"issue_comment","sequence":12,"text":"I've got a PR open against Bolts that adds SPM support.\n\nStarted looking at this library today.","author_login":"drdaz","author_association":"MEMBER","created_at":"2021-05-21T17:46:46+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_855874854","fragment_type":"issue_comment","sequence":13,"text":"For real though, if they announce that Objective-C imports will soon just work with SPM at WWDC this week... I'm gonna scream so loud.","author_login":"drdaz","author_association":"MEMBER","created_at":"2021-06-07T12:15:42+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_860103963","fragment_type":"issue_comment","sequence":14,"text":"Maybe not an option for everyone but there is a rebuild of the Parse API for iOS in Swift: URL","author_login":"funkenstrahlen","author_association":"NONE","created_at":"2021-06-12T20:18:54+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_916068006","fragment_type":"issue_comment","sequence":15,"text":"There's nothing newer than what's on my branch right now that I'm aware of. But the main Parse SDK imports properly using SPM in that branch IIRC.\n\nI do plan on getting it working, but I need to find time. \n\nI'd welcome any help. PR is here.","author_login":"drdaz","author_association":"MEMBER","created_at":"2021-09-09T12:58:36+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_962504428","fragment_type":"issue_comment","sequence":16,"text":"Problem is, its currently missing a lot of features and because they renamed a bunch of methods new users may struggle to implement it until documentation is updated accordingly.","author_login":"EliteTechnicalCare","author_association":"NONE","created_at":"2021-11-06T20:15:34+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_962511732","fragment_type":"issue_comment","sequence":17,"text":"It's not difficult to implement. And what features are you missing?","author_login":"vdkdamian","author_association":"NONE","created_at":"2021-11-06T21:23:10+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_962515237","fragment_type":"issue_comment","sequence":18,"text":"A quick example would be say you have a new user starting with back4app and in the tutorial to confirm you set it up right they have this code:\n\nvar person = PFObject(className:\"Person\")\nperson[\"name\"] = \"John Snow\"\nperson[\"age\"] = 27\nperson.saveInBackground {\n (success: Bool, error: Error?) in\n if (success) {\n // The object has been saved.\n } else {\n // There was a problem, check error.description\n }\n}\n\n//Reading your First Data Object from Back4App\nvar query = PFQuery(className:\"Person\")\nquery.getObjectInBackgroundWithId(\"mhPFDlCahj\") {\n (person: PFObject?, error: NSError?) -> Void in\n if error == nil && person != nil {\n print(person)\n } else {\n print(error)\n }\n}\n\nThis will fail because IIRC Parse-Swift doesn't use PFObject. I am not saying ParseSwift is difficult to implement, in fact its easier given SPM. However renaming methods etc make it more difficult to follow older parse tutorials. I could be completely wrong here, I have limited parse experience personally.","author_login":"EliteTechnicalCare","author_association":"NONE","created_at":"2021-11-06T21:56:59+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_962518495","fragment_type":"issue_comment","sequence":19,"text":"Yes, that's correct, but it's more Back4App that needs to update their docs for ParseSwift also. I came from Parse for objective c, and then switched to ParseSwift. \n\nThere is a playground example in ParseSwift that show you how to use it. It's actually really easy. The documentation for ParseSwift is also well written.\n\nI personally strongly advice to switch to ParseSwift. But that's my opinion.","author_login":"vdkdamian","author_association":"NONE","created_at":"2021-11-06T22:32:43+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_962526223","fragment_type":"issue_comment","sequence":20,"text":"That's not a bad idea ill give the playground a shot because I hate dealing with CocoaPods etc. I appreciate the offer and will give it a shot.","author_login":"EliteTechnicalCare","author_association":"NONE","created_at":"2021-11-07T00:00:48+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1016590836","fragment_type":"issue_comment","sequence":21,"text":"I have started prototyping swift package manager support for Bolts and Parse-SDK-iOS-OSX in a similar way as @drdaz.\n\n_[For new projects it may be the obvious choice to use URL but for existing projects migrating to a new client side SDK may pose more troubles then integrating subset of old Objective-C SDK via swift package manager.]_\n\nTo simplify things I removed all Carthage, Cocoapods, rake, and Xcode related scripts and files and only left the headers, sources, and added super simple Package.swift.\n\nMy version of Bolts is here: URL \n\nYou can `swift build` and `swift test` it, I temporarily removed all the app link and webkit stuff. If you compare it against the parse-community forked main branch of Bolts-ObjC, you will see that I basically only fixed all includes to be fully qualified.\n\nMy version of Parse-SDK-iOS-OSX is here: URL \n\nYou can `swift build` it for all platforms. Tests are not yet incorporated. Build is not clean and produces warnings, mainly because it always tries to compiles all files for all platforms, and many files are platform specific and should be excluded. \n\nFacebookUtils, TwitterUtils, and ParseUI are ignored and not supported for now. \n\nLooking at tree comparison, I again only left sources, headers, and added simple Package.swift file, fixing all public API includes to be fully qualified.\n\nI will continue using these branches in my own projects and keep them up to date over time. If you are interested I can open a PR against master and try to continue working on getting this integrated, but first we probably need to agree on scope and goals for the effort. Parse-SDK-iOS-OSX is rather complex and contains lot of things that I believe should be split out as separate packages that depend on Parse.\n\nFacebookUtils, TwitterUtils, and ParseUI are obvious choices.\n\nMy personal goal is to make `swift build` and `swift test` pass cleanly on all supported platforms, that is iOS, macOS, tvOS, watchOS, macCatalyst. \n\nJust my .2 euro cents, opinions?","author_login":"mman","author_association":"CONTRIBUTOR","created_at":"2022-01-19T15:37:59+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1017509456","fragment_type":"issue_comment","sequence":22,"text":"Due to the accumulating difficulties regarding carthage and xcframework building on Xcode >=12 I've added a bounty to SPM support in the hopes to incentivize and revive this effort. I've also marked the issue Carthage Xcode >=12 compatibility as bug that won't be fixed, so we can fully focus on SPM support.","author_login":"mtrezza","author_association":"MEMBER","created_at":"2022-01-20T13:33:52+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1017664135","fragment_type":"issue_comment","sequence":23,"text":"I have been able to re-introduce Parse SDK test files into URL and make them compile for macOS, and iOS. tvOS, and watchOS need to be done.\n\nQuick run of `swift test` makes majority of the tests pass, with couple failing for various \"assumption\" reasons that were valid in the Xcode days (always present Info.plist, always having hosting UIApplication, etc).\n\nWill continue working on them","author_login":"mman","author_association":"CONTRIBUTOR","created_at":"2022-01-20T16:07:35+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1018509679","fragment_type":"issue_comment","sequence":24,"text":"@EliteTechnicalCare can you either “correct” or “delete” your comments about the Swift SDK? Neither were true when you posted them. This particular issue is currently pinned and will get more attention. I don’t want people coming across your comments perceiving them as facts when they are not. This is synonymous to when people tweet or post saying, “parse server is dead,” and others believe it.\n\nWhat is true is what @mman posted:","author_login":"cbaker6","author_association":"MEMBER","created_at":"2022-01-21T13:34:02+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1018518947","fragment_type":"issue_comment","sequence":25,"text":"@cbaker6 Have you come across any plans / demands for adding SPM support to the Parse Swift SDK? I think once we support SPM, we could also end support for all other dependency managers such as cocoapods and carthage? The 2 repos (ObjC, Swift) don't have to be aligned, but it would be interesting to know.","author_login":"mtrezza","author_association":"MEMBER","created_at":"2022-01-21T13:46:42+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1018521391","fragment_type":"issue_comment","sequence":26,"text":"The Swift SDK has always supported SPM along with Cocoapods and Carthage. More info in the readme: URL SPM has always been labeled as the preferred way for the Swift SDK.","author_login":"cbaker6","author_association":"MEMBER","created_at":"2022-01-21T13:50:08+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1018528235","fragment_type":"issue_comment","sequence":27,"text":"Amazing, I haven't noticed that. Maybe @drdaz could get in touch in case there are any obstacles in URL","author_login":"mtrezza","author_association":"MEMBER","created_at":"2022-01-21T13:59:13+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1018569626","fragment_type":"issue_comment","sequence":28,"text":"They are just there for people who don't want to use SPM and are more comfortable the others. For the Swift SDK, it's not hard to keep support for Cocoapods and Carthage. SPM is definitely the easiest to use.","author_login":"cbaker6","author_association":"MEMBER","created_at":"2022-01-21T14:44:08+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1018636374","fragment_type":"issue_comment","sequence":29,"text":"This is kind of a big deal. It means I won't have to dig into the challenges I was describing here. Running the tests using swift test make an awful lot more sense than what I was talking about 👍🏼\n \n \n \n\nThese things used to be separate GitHub projects not too many years ago, and I think they got reincluded in the main package because the other thing was a PITA - multiple CI's, dependencies to be maintained etc. Also, nobody is going to be interested in those packages that aren't using the main Parse SDK. Can you explain what benefits you see in splitting them out?","author_login":"drdaz","author_association":"MEMBER","created_at":"2022-01-21T15:57:42+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1019953178","fragment_type":"issue_comment","sequence":30,"text":"Both of these depend on 3rd party SDKs that may get broken at various stages of life blocking the updates and release of core Parse iOS SDK. It also makes the resulting binary bigger, it also then links your project to SDKs that you do not use and perhaps do not want to have linked at all (for example if I am not mistaken, just linking a facebook SDK to your app did in the past trigger various red flags during review, like linking against location, ads frameworks, etc., and IIRC facebook SDK used to track app usage and correlate with other apps usage just by being included in the app). /me do not like that.\n\nJust my .2 cents, I like things to be lean and focused (my UNIX roots :)","author_login":"mman","author_association":"CONTRIBUTOR","created_at":"2022-01-24T10:36:55+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1020298209","fragment_type":"issue_comment","sequence":31,"text":"SPM allows to select only the needed subpackages. Would that allow to add only the main Parse SDK without Facebook Utils and without the FB SDK as 3rd party dependency?","author_login":"mtrezza","author_association":"MEMBER","created_at":"2022-01-24T16:39:37+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1021069249","fragment_type":"issue_comment","sequence":32,"text":"As @mman says, yes it should. I believe the only install route that suffers from everything always being installed is Carthage.\n \n\nIt's a legitimate concern, but since we specify which version of the FBSDK we use, the breakage generally won't catch us unawares. Moving between FB dep versions is an explicit, conscious action, and the developer should be able to see if the update breaks anything.\n\nThe only place I see this causing issues is when an Apple SDK update breaks whatever version of the FB SDK we're using. And if that happens, it's likely to be because we're hanging on an old version; FB seems to keep up to speed with Apple's newest stuff pretty well. Even then, the move to a newer Apple SDK is a conscious move.","author_login":"drdaz","author_association":"MEMBER","created_at":"2022-01-25T11:04:05+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1027982635","fragment_type":"issue_comment","sequence":33,"text":"@mman I've been bashing my head against against something for a minute now... I've got my branch rebased with mainline, but it seems like no matter what I do, I can't get the tests to see the main source files. You're doing it with cSettings I gather, but when I do similar, they seem to be ignored.\n\nDo you know of any reason why this might be? The only differences I can see are that I use the path and publicHeadersPath attributes.","author_login":"drdaz","author_association":"MEMBER","created_at":"2022-02-02T14:15:18+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1028024933","fragment_type":"issue_comment","sequence":34,"text":"@drdaz Do you have any error messages?\n\nThe line: URL here shows that tests must depend on Parse, Bolts, and OCMock, and we only use .headersSearchPath to actually lookup internal header files that are not public","author_login":"mman","author_association":"CONTRIBUTOR","created_at":"2022-02-02T14:57:55+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1143391707","fragment_type":"issue_comment","sequence":35,"text":"hello everyone. is there any kind of update on this?\nI currently have a `Package Resolution Failed` error\nimage","author_login":"danipralea","author_association":"NONE","created_at":"2022-06-01T09:58:52+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1143421416","fragment_type":"issue_comment","sequence":36,"text":"@danipralea What URL you specified as a dependency? I guess the way to the future is to use Parse Swift SDK implementation and fall back to this legacy repository only when you really need it and know what you are doing.\n\nFeel free to use the `spm` branch of my fork from URL that should resolve and work just fine but the question is whether this will ever get merged at all? CC @drdaz ?","author_login":"mman","author_association":"CONTRIBUTOR","created_at":"2022-06-01T10:27:35+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1143528691","fragment_type":"issue_comment","sequence":37,"text":"Got it. I think as long s this repo is embeddable with in some way, I think we're good. We made carthage work recently, so it's available I'd say.","author_login":"mtrezza","author_association":"MEMBER","created_at":"2022-06-01T12:13:24+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1232348160","fragment_type":"issue_comment","sequence":38,"text":"Has there been any progress in adding SPM support? Is this something anyone would be interested to pick up?","author_login":"mtrezza","author_association":"MEMBER","created_at":"2022-08-31T01:36:15+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1246005012","fragment_type":"issue_comment","sequence":39,"text":"@mman Could you open a PR from your `spm` branch, so others can see the diffs you had to do to get it work and build upon it?","author_login":"mtrezza","author_association":"MEMBER","created_at":"2022-09-13T22:16:58+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1247779266","fragment_type":"issue_comment","sequence":40,"text":"Thanks, if you find some time, could you resolve the conflicts, so that these show the latest state compared to the target branches?","author_login":"mtrezza","author_association":"MEMBER","created_at":"2022-09-15T08:41:49+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1249063448","fragment_type":"issue_comment","sequence":41,"text":"Hi everyone, @ricky641b will give it a shot to add full SPM support.\n\nLuckily he can build on the PRs and investigations already done by you.\n\nLet's support him with whatever questions he may have, to get this over the finish line - thanks especially to @mman, @drdaz!","author_login":"mtrezza","author_association":"MEMBER","created_at":"2022-09-16T08:18:33+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1249696843","fragment_type":"issue_comment","sequence":42,"text":"Notes:\n\n- cocoapods and carthage support can (or even should) be dropped when implementing SPM support. We are implementing SPM support because they actually don't work anymore in some scenarios. SPM solves this. Removing carthage & cocoapods should also make it easier for you to implement SPM, because it reduces the code base.\n\n- The ParseFacebookUtils are required. The SPM implementation must make it optional to install it though, since not everyone may need it. Same with ParseTwitterUtils.","author_login":"mtrezza","author_association":"MEMBER","created_at":"2022-09-16T18:49:08+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1371555292","fragment_type":"issue_comment","sequence":43,"text":"Could someone try out URL to add the SDK via Swift Package Manager?","author_login":"mtrezza","author_association":"MEMBER","created_at":"2023-01-04T23:51:17+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1371555622","fragment_type":"issue_comment","sequence":44,"text":"Could someone try out URL to add the SDK via Swift Package Manager?\n\ncc @drdaz @mman","author_login":"mtrezza","author_association":"MEMBER","created_at":"2023-01-04T23:52:00+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1371807210","fragment_type":"issue_comment","sequence":45,"text":"I can try it once again if you allow me to\n\nOn Thu, 5 Jan 2023 at 5:22 AM, Manuel ***@***.***> wrote:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n-- \nWarm Regards\n*Bhavesh Gupta*\nOwner @ Atikin Technologies\n URL","author_login":"ricky641b","author_association":"NONE","created_at":"2023-01-05T05:44:42+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[496619883],"is_known_query_context":false},{"document_id":"gh_comment_1372104979","fragment_type":"issue_comment","sequence":46,"text":"@ricky641b The SPM integration should be done with this PR; with try out I meant to try to add the Parse Apple SDK via SPM in Xcode using this branch.","author_login":"mtrezza","author_association":"MEMBER","created_at":"2023-01-05T11:33:46+08:00","repo_name":"parse-community/Parse-SDK-iOS-OSX","issue_id":496619883,"issue_number":1453,"issue_url":"https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1453","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0451","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Support Root-Relative Links (Absolute Links)?","query_context":"Hi @wooorm ! 👋\n\n### Subject of the feature\n\nWhat do you think about supporting root-relative links such as in the example below?\n\nmd\nabc\nabc\n\nI suppose this could be configured with a configuration option, maybe named like `basedir`.\n\n### Problem\n\nOn large sites with a lot of moving files or large directory structures, updating relative links can be a pain.\n\nRoot relative links can also avoid any ambiguity that can be caused by using the same path ending and file name between multiple files.\n\n### Expected behaviour\n\nIt would be nice for these links to also be checked.\n\n### Alternatives\n\ngatsby-remark-check-links, but:\n\n1. It's Gatsby-specific\n2. It runs as a Gatsby plugin and only warns in the console :(\n\ngh-action-check-broken-links, but:\n\n1. It's wrapped in a GitHub Action\n2. It assumes everything is in a `pages` directory","known_context_document_ids":["gh_issue_678998792"],"reference_answer":"I recommend adding an option to `urlConfig`, similar to `lines: boolean`, which is then checked for here. Something along the lines of: `resolveAbsolutePathsInRepo: boolean`? That way, folks can configure whether their hosted git supports this or not.\n\nFurthermore, you are now creating a *path* inside `value`, in your `if` branch.\nBut the value we are making is a (serialized) *URL*.\n`path.resolve` and `config.root` are all about paths. (note: see my last paragraph of this comment later touches on this again)\n\nFor reference, I checked the following in a private repo (`wooorm/private`) on GitHub:\n\n`readme.md`\n\nmarkdown\nalpha\nbravo\ncharlie\ndelta\necho\nfoxtrot\n\n`x/y/z.md` (empty)\n\nmarkdown\n\nGithub generates the following HTML for the readme:\n\nhtml\n alpha \n bravo \n charlie \n delta \n echo \n foxtrot \n\nThat is to say, all absolute paths are prefixed with `/wooorm/private/blob/main`.\nso `!config.urlConfig.prefix.startsWith(value)` and the current handling are not needed.\nThe information needed to construct `/wooorm/private/blob/main`, other than the branch,\nis in `urlConfig.prefix`.\nMissing a branch is fine, we don’t use it yet: URL \n\nSo, I personally would do something like the following pseudocode:\n\njs\n // Absolute paths: `/path/to/file.md`.\n if (value.charAt(0) === slash) {\n if (!config.urlConfig.hostname) {\n return\n }\n\n // Create a URL.\n const pathname = config.urlConfig.resolveAbsolutePathsInRepo && config.urlConfig.prefix\n ? config.urlConfig.prefix + 'unknown' + value\n : value.slice(1)\n value = https + slashes + config.urlConfig.hostname + pathname\n }\n\n…where `unknown` is a temporary value for a branch name, which is dropped later!\n\nFinally, the function as I look at it now is a bit of a mix between path and URL handling.\nThat’s ambiguous and probably points to some bugs.\nIt’s probably better to investigate all that and look at it some more some other time though!","answer_document_id":"gh_comment_1508684337","silver_evidence_path":["gh_comment_2450152500","gh_issue_1660806613","gh_comment_1508684337"],"evidence_issue_ids":[678998792,1660806613],"source_repo_name":"remarkjs/remark-validate-links","source_issue_id":678998792,"source_issue_number":57,"source_issue_url":"https://github.com/remarkjs/remark-validate-links/issues/57","target_repo_name":"remarkjs/remark-validate-links","target_issue_id":1660806613,"target_issue_number":75,"target_issue_url":"https://github.com/remarkjs/remark-validate-links/issues/75","reference_anchor_document_id":"gh_comment_2450152500","reference_answer_author":"wooorm","reference_answer_author_association":"MEMBER","quality_score":87.29,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.25,"anchor_target_overlap":0.5,"target_answer_overlap":0.0857},"issue_created_at":"2020-08-14T08:36:03+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_678998792","fragment_type":"issue_description","sequence":0,"text":"Support Root-Relative Links (Absolute Links)?\nHi @wooorm ! 👋\n\n### Subject of the feature\n\nWhat do you think about supporting root-relative links such as in the example below?\n\nmd\nabc\nabc\n\nI suppose this could be configured with a configuration option, maybe named like `basedir`.\n\n### Problem\n\nOn large sites with a lot of moving files or large directory structures, updating relative links can be a pain.\n\nRoot relative links can also avoid any ambiguity that can be caused by using the same path ending and file name between multiple files.\n\n### Expected behaviour\n\nIt would be nice for these links to also be checked.\n\n### Alternatives\n\ngatsby-remark-check-links, but:\n\n1. It's Gatsby-specific\n2. It runs as a Gatsby plugin and only warns in the console :(\n\ngh-action-check-broken-links, but:\n\n1. It's wrapped in a GitHub Action\n2. It assumes everything is in a `pages` directory","author_login":"karlhorky","author_association":"NONE","created_at":"2020-08-14T08:36:03+08:00","repo_name":"remarkjs/remark-validate-links","issue_id":678998792,"issue_number":57,"issue_url":"https://github.com/remarkjs/remark-validate-links/issues/57","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1789393885","fragment_type":"issue_comment","sequence":1,"text":"So in case `urlConfig` or some other configuration setting would be changed in `remark-validate-links` (unlikely, given that this project is GitHub / GitLab / Bitbucket focused), maybe it could work like this:\n\nConfig:\n\njs\nbaseDir: '/src/pages',\nextension: 'mdx',\n\n`src/pages/lib-1/index.mdx`\n\nmdx\nTo read more, check out the docs about `lib-2`!\n\nThe link above would be resolved to the file ` /src/pages/lib-2/docs.mdx`","author_login":"karlhorky","author_association":"NONE","created_at":"2023-11-01T17:48:59+08:00","repo_name":"remarkjs/remark-validate-links","issue_id":678998792,"issue_number":57,"issue_url":"https://github.com/remarkjs/remark-validate-links/issues/57","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2278376639","fragment_type":"issue_comment","sequence":2,"text":"Having this feature would be extremely useful, especially in monorepos where some markdowns reference other projects. Any news on this? 👀","author_login":"LuchoTurtle","author_association":"NONE","created_at":"2024-08-09T17:05:21+08:00","repo_name":"remarkjs/remark-validate-links","issue_id":678998792,"issue_number":57,"issue_url":"https://github.com/remarkjs/remark-validate-links/issues/57","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2450152500","fragment_type":"issue_comment","sequence":3,"text":"Absolute paths are now supported like GitHub again, per URL \nFor arbitrary websites, so not markdown files on GitHub/Gitlab/Bitbucket, use `remark-lint-no-dead-urls`","author_login":"wooorm","author_association":"MEMBER","created_at":"2024-10-31T15:20:25+08:00","repo_name":"remarkjs/remark-validate-links","issue_id":678998792,"issue_number":57,"issue_url":"https://github.com/remarkjs/remark-validate-links/issues/57","linked_issue_ids":[1660806613],"is_known_query_context":false},{"document_id":"gh_issue_1660806613","fragment_type":"issue_description","sequence":0,"text":"Does not catch bad links that use absolute paths to repo root\n### Initial checklist\n\n- [X] I read the support docs\n- [X] I read the contributing guide\n- [X] I agree to follow the code of conduct\n- [X] I searched issues and couldn’t find anything (or linked relevant results below)\n\n### Affected packages and versions\n\n12.1.0\n\n### Link to runnable example\n\n_No response_\n\n### Steps to reproduce\n\nI have a repo: URL If you run `./remark-check.sh` it will catch one bad link but not another bad link.\n\n$ cat README.md\nlink\n\nThis should fail\nlink\n\nBut only this one actually fails\nlink\n\n### Expected behavior\n\nGitHub allows you to use absolute paths starting with `/` to mean the root directory of the repo. remark-validate-links should handle looking at the repo root to resolve these files.\n\n### Actual behavior\n\nRoot-absolute paths are not validated.\n\n### Runtime\n\n_No response_\n\n### Package manager\n\n_No response_\n\n### OS\n\n_No response_\n\n### Build and bundle tools\n\n_No response_","author_login":"eatonphil","author_association":"NONE","created_at":"2023-04-10T13:45:57+08:00","repo_name":"remarkjs/remark-validate-links","issue_id":1660806613,"issue_number":75,"issue_url":"https://github.com/remarkjs/remark-validate-links/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1501831011","fragment_type":"issue_comment","sequence":1,"text":"This looks like URL but I think #57 is talking about the ability to rewrite certain root paths.\n\nI'm not talking about that. I just want to be able to resolve files relative to the root of the same repo. No rewrites.","author_login":"eatonphil","author_association":"NONE","created_at":"2023-04-10T13:46:58+08:00","repo_name":"remarkjs/remark-validate-links","issue_id":1660806613,"issue_number":75,"issue_url":"https://github.com/remarkjs/remark-validate-links/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1501843846","fragment_type":"issue_comment","sequence":2,"text":"Hey!\n\nI don’t think this was supported before.\nBut your repo shows that it does work.\nI was under the impressions that they used to be related to `github.com`, like normal.\n\nSee this handling: URL \n\nA PR to solve it would likely around that line.\n\nAnd it might need some more testing, to see if `/wooorm/markdown-rs/...` still points to some other repo on GH, or to a file in the current repo.\nAnd perhaps some testing on Gitlab / Bitbucket?\n\nInterested in working on this?","author_login":"wooorm","author_association":"MEMBER","created_at":"2023-04-10T13:58:58+08:00","repo_name":"remarkjs/remark-validate-links","issue_id":1660806613,"issue_number":75,"issue_url":"https://github.com/remarkjs/remark-validate-links/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1502114675","fragment_type":"issue_comment","sequence":3,"text":"I've got it working with this diff, but you're right there are some edge cases. I don't really care to test on gitlab/bitbucket since I'm not as familiar with them. So how do you feel about this?\n\ngit diff\ndiff --git a/lib/find/find-references.js b/lib/find/find-references.js\nindex 953dec3..f930f4d 100644\n--- a/lib/find/find-references.js\n+++ b/lib/find/find-references.js\n@@ -217,14 +217,21 @@ export async function findReferences(ctx) {\n */\n // eslint-disable-next-line complexity\n function urlToPath(value, config, type) {\n- // Absolute paths: `/wooorm/test/blob/main/directory/example.md`.\n+ // Absolute paths: `/wooorm/test/blob/main/directory/example.md` or `/directory/example.md`.\n if (value.charAt(0) === slash) {\n if (!config.urlConfig.hostname) {\n return\n }\n\n- // Create a URL.\n- value = https + slashes + config.urlConfig.hostname + value\n+ // A root absolute path without the repo, \"blob\", and branch name: `/directory/example.md`.\n+ // TODO: Figure out how this applies, if at all, to GitLab and Bitbucket.\n+ if (!config.urlConfig.prefix.startsWith(value) && config.urlConfig.hostname === 'github.com') {\n+ const valueRelativeToRoot = value.slice(1)\n+ value = path.resolve(config.root, valueRelativeToRoot)\n+ } else {\n+ // Create a URL.\n+ value = https + slashes + config.urlConfig.hostname + value\n+ }\n }\n\n /** @type {URL|undefined} */\n\nIf that's ok I'll open a PR.","author_login":"eatonphil","author_association":"NONE","created_at":"2023-04-10T17:53:34+08:00","repo_name":"remarkjs/remark-validate-links","issue_id":1660806613,"issue_number":75,"issue_url":"https://github.com/remarkjs/remark-validate-links/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1508684337","fragment_type":"issue_comment","sequence":4,"text":"I recommend adding an option to `urlConfig`, similar to `lines: boolean`, which is then checked for here. Something along the lines of: `resolveAbsolutePathsInRepo: boolean`? That way, folks can configure whether their hosted git supports this or not.\n\nFurthermore, you are now creating a *path* inside `value`, in your `if` branch.\nBut the value we are making is a (serialized) *URL*.\n`path.resolve` and `config.root` are all about paths. (note: see my last paragraph of this comment later touches on this again)\n\nFor reference, I checked the following in a private repo (`wooorm/private`) on GitHub:\n\n`readme.md`\n\nmarkdown\nalpha\nbravo\ncharlie\ndelta\necho\nfoxtrot\n\n`x/y/z.md` (empty)\n\nmarkdown\n\nGithub generates the following HTML for the readme:\n\nhtml\n alpha \n bravo \n charlie \n delta \n echo \n foxtrot \n\nThat is to say, all absolute paths are prefixed with `/wooorm/private/blob/main`.\nso `!config.urlConfig.prefix.startsWith(value)` and the current handling are not needed.\nThe information needed to construct `/wooorm/private/blob/main`, other than the branch,\nis in `urlConfig.prefix`.\nMissing a branch is fine, we don’t use it yet: URL \n\nSo, I personally would do something like the following pseudocode:\n\njs\n // Absolute paths: `/path/to/file.md`.\n if (value.charAt(0) === slash) {\n if (!config.urlConfig.hostname) {\n return\n }\n\n // Create a URL.\n const pathname = config.urlConfig.resolveAbsolutePathsInRepo && config.urlConfig.prefix\n ? config.urlConfig.prefix + 'unknown' + value\n : value.slice(1)\n value = https + slashes + config.urlConfig.hostname + pathname\n }\n\n…where `unknown` is a temporary value for a branch name, which is dropped later!\n\nFinally, the function as I look at it now is a bit of a mix between path and URL handling.\nThat’s ambiguous and probably points to some bugs.\nIt’s probably better to investigate all that and look at it some more some other time though!","author_login":"wooorm","author_association":"MEMBER","created_at":"2023-04-14T14:43:41+08:00","repo_name":"remarkjs/remark-validate-links","issue_id":1660806613,"issue_number":75,"issue_url":"https://github.com/remarkjs/remark-validate-links/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1594637383","fragment_type":"issue_comment","sequence":5,"text":"Just discovered that this is missing! I thought it was working until I renamed the file that was referenced by relative-to-repo-root syntax. Looking forward to a fix.","author_login":"iainelder","author_association":"NONE","created_at":"2023-06-16T12:58:38+08:00","repo_name":"remarkjs/remark-validate-links","issue_id":1660806613,"issue_number":75,"issue_url":"https://github.com/remarkjs/remark-validate-links/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2278360177","fragment_type":"issue_comment","sequence":6,"text":"Is it possible to get this merged? This would be really useful for my project (it's not really checking links that use absolute paths from the repo root) when running `remark`.","author_login":"LuchoTurtle","author_association":"NONE","created_at":"2024-08-09T16:54:42+08:00","repo_name":"remarkjs/remark-validate-links","issue_id":1660806613,"issue_number":75,"issue_url":"https://github.com/remarkjs/remark-validate-links/issues/75","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0454","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"throughput of the stream is too low?","query_context":"Hello, I'm testing the throughput of the quic stream on the localhost.\n \nIn my test, I can only obtain a throughput of approximately 5MBps. \n\nTest environments:\n quic-go version: 0.51.0, 0.48.0, and the perf tool\n OS: window11 or ubuntu2204\n go version: go1.23\n\nThe results of throughput tests obtained on these platforms are roughly the same, all very low. I want to know what might be the reason for this? \n\nThank you!\n\nThe following is my test code:\n\n \n// client\ndata := make([]byte, 8192)\nfor i := 0; i < 8192; i++ {\n data[i] = byte(i)\n}\ncnt := 100000\n\nstream, err := conn.OpenStreamSync(context.Background())\nif err != nil {\n return err\n}\ndefer stream.Close()\n\nfor i := 0; i < cnt; i++ {\n _, err = stream.Write(data)\n if err != nil {\n return err\n }\n}\n\n \n// server\nconn, err := listener.Accept(context.Background())\nif err != nil {\n return err\n}\n\nvar totalBytes int64\nvar started bool\nvar startTime time.Time\n\nstream, err := conn.AcceptStream(context.Background())\nif err != nil {\n log.Printf(\"AcceptStream error: %v\", err)\n}\ndefer stream.Close()\n\nbuf := make([]byte, 8192)\nfor {\n n, err := stream.Read(buf)\n if err != nil {\n if err != io.EOF {\n log.Printf(\"Stream %d error: %v\", stream.StreamID(), err)\n }\n break\n }\n if !started {\n started = true\n startTime = time.Now()\n }\n totalBytes += int64(n)\n elapsed := time.Since(startTime).Seconds()\n currentBandwidth := float64(totalBytes) / (elapsed * 1e6)\n fmt.Printf(\"\\rCurrent throughput: %.2f MBps\", currentBandwidth)\n}\nreturn nil\n\nI also conducted tests on up to 32 streams, and the obtained throughput was approximately the same.","known_context_document_ids":["gh_issue_3026831815"],"reference_answer":"We're currently not using batched writes, so it's not unexpected that you can't fill a 10 Gbit link.\n\nThere's been work on using the `sendmmsg` API in URL which surfaced that we were allocating like crazy, which was killing performance due to GC constantly kicking in. In the mean time, we've done a lot of work to reduce allocs, and we'll be done >80% once we merge all the outstanding PRs linked in URL \nThere's also some subtle issues with how Go delivers packets from the kernel to the QUIC layer, which affect how timely we can acknowledge incoming packets, which has complicated implications on the congestion controller.\n\nOther than that, there's a new Go API in the works to allow batched writes in a more efficient way: URL I expect huge performance improvements from this, but obviously we'll have to wait for this API to actually be implemented before we can put numbers on this.","answer_document_id":"gh_comment_1374622785","silver_evidence_path":["gh_comment_2837326551","gh_issue_1522202081","gh_comment_1374622785"],"evidence_issue_ids":[3026831815,1522202081],"source_repo_name":"quic-go/quic-go","source_issue_id":3026831815,"source_issue_number":5091,"source_issue_url":"https://github.com/quic-go/quic-go/issues/5091","target_repo_name":"quic-go/quic-go","target_issue_id":1522202081,"target_issue_number":3670,"target_issue_url":"https://github.com/quic-go/quic-go/issues/3670","reference_anchor_document_id":"gh_comment_2837326551","reference_answer_author":"marten-seemann","reference_answer_author_association":"COLLABORATOR","quality_score":94.26,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1795,"anchor_target_overlap":0.2308,"target_answer_overlap":0.0652},"issue_created_at":"2025-04-29T02:40:59+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_3026831815","fragment_type":"issue_description","sequence":0,"text":"throughput of the stream is too low\nHello, I'm testing the throughput of the quic stream on the localhost.\n \nIn my test, I can only obtain a throughput of approximately 5MBps. \n\nTest environments:\n quic-go version: 0.51.0, 0.48.0, and the perf tool\n OS: window11 or ubuntu2204\n go version: go1.23\n\nThe results of throughput tests obtained on these platforms are roughly the same, all very low. I want to know what might be the reason for this? \n\nThank you!\n\nThe following is my test code:\n\n \n// client\ndata := make([]byte, 8192)\nfor i := 0; i < 8192; i++ {\n data[i] = byte(i)\n}\ncnt := 100000\n\nstream, err := conn.OpenStreamSync(context.Background())\nif err != nil {\n return err\n}\ndefer stream.Close()\n\nfor i := 0; i < cnt; i++ {\n _, err = stream.Write(data)\n if err != nil {\n return err\n }\n}\n\n \n// server\nconn, err := listener.Accept(context.Background())\nif err != nil {\n return err\n}\n\nvar totalBytes int64\nvar started bool\nvar startTime time.Time\n\nstream, err := conn.AcceptStream(context.Background())\nif err != nil {\n log.Printf(\"AcceptStream error: %v\", err)\n}\ndefer stream.Close()\n\nbuf := make([]byte, 8192)\nfor {\n n, err := stream.Read(buf)\n if err != nil {\n if err != io.EOF {\n log.Printf(\"Stream %d error: %v\", stream.StreamID(), err)\n }\n break\n }\n if !started {\n started = true\n startTime = time.Now()\n }\n totalBytes += int64(n)\n elapsed := time.Since(startTime).Seconds()\n currentBandwidth := float64(totalBytes) / (elapsed * 1e6)\n fmt.Printf(\"\\rCurrent throughput: %.2f MBps\", currentBandwidth)\n}\nreturn nil\n\nI also conducted tests on up to 32 streams, and the obtained throughput was approximately the same.","author_login":"OnlyTsukii","author_association":"NONE","created_at":"2025-04-29T02:40:59+08:00","repo_name":"quic-go/quic-go","issue_id":3026831815,"issue_number":5091,"issue_url":"https://github.com/quic-go/quic-go/issues/5091","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2837301810","fragment_type":"issue_comment","sequence":1,"text":"It's not very helpful to open an issue saying \"things are slow\". For some definition of \"slow\". Slow? Slow compared to what?\n\nThings you could look into: flow control (and the respective tuning parameters) and congestion control.","author_login":"marten-seemann","author_association":"MEMBER","created_at":"2025-04-29T02:50:42+08:00","repo_name":"quic-go/quic-go","issue_id":3026831815,"issue_number":5091,"issue_url":"https://github.com/quic-go/quic-go/issues/5091","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2837326551","fragment_type":"issue_comment","sequence":2,"text":"Sorry for not describing the problem clearly.\n\nI saw that in the descriptions of some previous issues (#3670), the throughput they tested could reach 1100Mbps, while my test results were far lower than this value. I want to know what the maximum throughput that quic-go can achieve is without changing any code. I think a throughput of 5MBps is obviously unreasonable.\n\nI tried to increase the congestion window and the flow control window, but there was no obvious change in throughput.","author_login":"OnlyTsukii","author_association":"NONE","created_at":"2025-04-29T03:16:10+08:00","repo_name":"quic-go/quic-go","issue_id":3026831815,"issue_number":5091,"issue_url":"https://github.com/quic-go/quic-go/issues/5091","linked_issue_ids":[1522202081],"is_known_query_context":false},{"document_id":"gh_comment_2837332511","fragment_type":"issue_comment","sequence":3,"text":"How?\n \n\nThe specific value will obviously depend on your benchmarking setup. For example, if you're still in the early phases of slow start, throughput might still be slow. If you're blocked by flow control, things might be slow. If you're running on localhost, things might be slow due to oscillating RTTs. Lots of potential culprits...","author_login":"marten-seemann","author_association":"MEMBER","created_at":"2025-04-29T03:21:58+08:00","repo_name":"quic-go/quic-go","issue_id":3026831815,"issue_number":5091,"issue_url":"https://github.com/quic-go/quic-go/issues/5091","linked_issue_ids":[1522202081],"is_known_query_context":false},{"document_id":"gh_comment_2837395444","fragment_type":"issue_comment","sequence":4,"text":"Oh, I found that printing logs has a significant impact on throughput. When I turned off log output, the throughput reached 500MBps!\n\nThank you for your reply!","author_login":"OnlyTsukii","author_association":"NONE","created_at":"2025-04-29T04:10:27+08:00","repo_name":"quic-go/quic-go","issue_id":3026831815,"issue_number":5091,"issue_url":"https://github.com/quic-go/quic-go/issues/5091","linked_issue_ids":[1522202081],"is_known_query_context":false},{"document_id":"gh_comment_2837402139","fragment_type":"issue_comment","sequence":5,"text":"Oh wow, that's a lot!\n\nJust out of curiosity, were you printing logs using `QUIC_GO_LOG_LEVEL=debug`, or were you using qlog?","author_login":"marten-seemann","author_association":"MEMBER","created_at":"2025-04-29T04:14:43+08:00","repo_name":"quic-go/quic-go","issue_id":3026831815,"issue_number":5091,"issue_url":"https://github.com/quic-go/quic-go/issues/5091","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1522202081","fragment_type":"issue_description","sequence":0,"text":"Throughput of quic-go\nHi community,\n\nI am testing the maximum achievable throughput of quic-go and for this purpose I've modified the `echo.go` example to read a large file (>15GB) and send it to a server. The client and server are running on two different hosts (Ubuntu 22) with a unused 10Gigabit link between them. I am achieving a maximum throughput of ca. 1100 Mbit/s. Would be this number expect by anyone else or should quic-go actually be able to achieve more? I'm open to feedback to improve my example so that we can see a better throughput.\nThanks in advance.","author_login":"alexj0l","author_association":"NONE","created_at":"2023-01-06T08:47:54+08:00","repo_name":"quic-go/quic-go","issue_id":1522202081,"issue_number":3670,"issue_url":"https://github.com/quic-go/quic-go/issues/3670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1373384468","fragment_type":"issue_comment","sequence":1,"text":"I haven't looked at the echo code, but you might be limited by this single payload scenario. In a more request-heavy scenario I've been able to push 10-15 Gbits from a single host quite easily (even with some added complexity, not just copying bytes back and forth) and I believe I've seen people do even more (check past issues here).","author_login":"kokes","author_association":"NONE","created_at":"2023-01-06T09:19:30+08:00","repo_name":"quic-go/quic-go","issue_id":1522202081,"issue_number":3670,"issue_url":"https://github.com/quic-go/quic-go/issues/3670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1373442094","fragment_type":"issue_comment","sequence":2,"text":"@kokes Thank you for your reply, would you share with me your example where you were able to push that big amount of Gbit per second? Sounds very interesting to me and would be very handful proof of quic-go for my thesis. Thanks in advance.","author_login":"alexj0l","author_association":"NONE","created_at":"2023-01-06T10:24:58+08:00","repo_name":"quic-go/quic-go","issue_id":1522202081,"issue_number":3670,"issue_url":"https://github.com/quic-go/quic-go/issues/3670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1373445316","fragment_type":"issue_comment","sequence":3,"text":"It's a pretty complex codebase, so I can't quite extract the logic into a minimal example. But simply open up multiple streams and push (smaller) payloads through them. You should see much higher aggregate tput then.\n\nLooking at the echo example - you'll need to dispatch the handlers in the server part (right now it sequentially processes the first stream on one connection at a time), that should be just a goroutine with some coordination. And same on the client side - launch multiple requests through new bidirectional streams.","author_login":"kokes","author_association":"NONE","created_at":"2023-01-06T10:28:49+08:00","repo_name":"quic-go/quic-go","issue_id":1522202081,"issue_number":3670,"issue_url":"https://github.com/quic-go/quic-go/issues/3670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1373451042","fragment_type":"issue_comment","sequence":4,"text":"I'm not a big expert in Go, could you give me a hint how many streams should I open?","author_login":"alexj0l","author_association":"NONE","created_at":"2023-01-06T10:33:54+08:00","repo_name":"quic-go/quic-go","issue_id":1522202081,"issue_number":3670,"issue_url":"https://github.com/quic-go/quic-go/issues/3670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1374429745","fragment_type":"issue_comment","sequence":5,"text":"I tried with multiple streams(up to 32) by sending smaller files (200MB and 2GB) and I get almost always a throughput around 1100Mbit/s.","author_login":"alexj0l","author_association":"NONE","created_at":"2023-01-07T10:01:29+08:00","repo_name":"quic-go/quic-go","issue_id":1522202081,"issue_number":3670,"issue_url":"https://github.com/quic-go/quic-go/issues/3670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1374622785","fragment_type":"issue_comment","sequence":6,"text":"We're currently not using batched writes, so it's not unexpected that you can't fill a 10 Gbit link.\n\nThere's been work on using the `sendmmsg` API in URL which surfaced that we were allocating like crazy, which was killing performance due to GC constantly kicking in. In the mean time, we've done a lot of work to reduce allocs, and we'll be done >80% once we merge all the outstanding PRs linked in URL \nThere's also some subtle issues with how Go delivers packets from the kernel to the QUIC layer, which affect how timely we can acknowledge incoming packets, which has complicated implications on the congestion controller.\n\nOther than that, there's a new Go API in the works to allow batched writes in a more efficient way: URL I expect huge performance improvements from this, but obviously we'll have to wait for this API to actually be implemented before we can put numbers on this.","author_login":"marten-seemann","author_association":"COLLABORATOR","created_at":"2023-01-07T21:44:10+08:00","repo_name":"quic-go/quic-go","issue_id":1522202081,"issue_number":3670,"issue_url":"https://github.com/quic-go/quic-go/issues/3670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1374879038","fragment_type":"issue_comment","sequence":7,"text":"Just a hint. Running into a bottleneck due to encryption is a real concern at 10G. You need to make sure, that you can encrypt traffic at a rate of at least 10G.\n\nWe performed similar tests in a 10G network years ago, probably even on the same Network. If I could remember correctly, we archived thru-puts of around 350 Mbit/s. We linked the limit to a bottleneck in the encryption/decryption of the network traffic. Enabling AES-NI in Bios resulted in a real improvement. After enabling it, we archived thru-puts similar to yours.","author_login":"Lemonn","author_association":"NONE","created_at":"2023-01-08T16:50:04+08:00","repo_name":"quic-go/quic-go","issue_id":1522202081,"issue_number":3670,"issue_url":"https://github.com/quic-go/quic-go/issues/3670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1586310323","fragment_type":"issue_comment","sequence":8,"text":"This is quite important.\n\nSingle stream HTTP/1.1 with TLS 1.2/1.3 (AESGCM128 afaik), can do about 360MB/s (3600Mbps) on a single core (no ktls). C (openssl, wget, curl), Go (`net/http`), Python (`requests`) all show me about 350MB/s one way over single stream (Python about 220MB/s). I was not able to reach 25Gbps, not even close.\n\nIn theory QUIC maybe could do even better by exploiting more CPU parallelism. But very fat streams are a bit niche. Still, QUIC should not regress compared to HTTP/1.1 with TLS 1.3.\n\nAMD Threadripper 2950X, Zen+, 3.2GHz. So a bit dated.","author_login":"baryluk","author_association":"NONE","created_at":"2023-06-11T19:35:26+08:00","repo_name":"quic-go/quic-go","issue_id":1522202081,"issue_number":3670,"issue_url":"https://github.com/quic-go/quic-go/issues/3670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1704007184","fragment_type":"issue_comment","sequence":9,"text":"quic-go now enables GSO by default. This should bring down CPU load quite a bit, and improve throughput on connections that were previously CPU-limited.","author_login":"marten-seemann","author_association":"MEMBER","created_at":"2023-09-03T04:59:54+08:00","repo_name":"quic-go/quic-go","issue_id":1522202081,"issue_number":3670,"issue_url":"https://github.com/quic-go/quic-go/issues/3670","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0461","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Parsing error: Cannot use keyword 'await' outside an async function?","query_context":"**What version of this package are you using?**\n\n14.3.4\n\n**What operating system, Node.js, and npm version?**\n\nNode: 14.13.0\nnpm: 6.14.8\nOS: macOS Catalina 10.15.5\n\n**What happened?**\n\nGiven code:\n\njs\nimport { fileURLToPath } from 'url'\nimport fs from 'fs'\nconst file = await fs.promise.readFile(fileURLToPath(import.meta.url))\nconsole.log(file.toString())\n\nOutput is:\n\nstandard: Use JavaScript Standard Style ( URL \n example.mjs:3:14: Parsing error: Cannot use keyword 'await' outside an async function\n\n**What did you expect to happen?**\n\n`Top-level await` is a stage 3 proposal (see URL but is enabled by default in from Node 14.8.0 (see URL \n\nThis is going to mean that linting with apps written for Node 14+ will be problematic, as top-level await is bound to be used. \n\nSince Node 14 is becoming Active LTS in a few weeks I think TLA should pass linting\n\n**Are you willing to submit a pull request to fix this bug?**\n\nyes","known_context_document_ids":["gh_issue_716873209"],"reference_answer":"I can try to roll one later, but if there’s no _need_ for you to run with a newer version of `eslint-plugin-n` then you can simply downgrade it to the version that `standard` expects.","answer_document_id":"gh_comment_1062025961","silver_evidence_path":["gh_comment_1014753723","gh_issue_1096525083","gh_comment_1062025961"],"evidence_issue_ids":[716873209,1096525083],"source_repo_name":"standard/standard","source_issue_id":716873209,"source_issue_number":1548,"source_issue_url":"https://github.com/standard/standard/issues/1548","target_repo_name":"standard/eslint-config-standard","target_issue_id":1096525083,"target_issue_number":208,"target_issue_url":"https://github.com/standard/eslint-config-standard/issues/208","reference_anchor_document_id":"gh_comment_1014753723","reference_answer_author":"voxpelli","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2857,"anchor_target_overlap":0.2857,"target_answer_overlap":0.3077},"issue_created_at":"2020-10-07T21:47:11+08:00","valid_comment_count":25,"fragments":[{"document_id":"gh_issue_716873209","fragment_type":"issue_description","sequence":0,"text":"Parsing error: Cannot use keyword 'await' outside an async function\n**What version of this package are you using?**\n\n14.3.4\n\n**What operating system, Node.js, and npm version?**\n\nNode: 14.13.0\nnpm: 6.14.8\nOS: macOS Catalina 10.15.5\n\n**What happened?**\n\nGiven code:\n\njs\nimport { fileURLToPath } from 'url'\nimport fs from 'fs'\nconst file = await fs.promise.readFile(fileURLToPath(import.meta.url))\nconsole.log(file.toString())\n\nOutput is:\n\nstandard: Use JavaScript Standard Style ( URL \n example.mjs:3:14: Parsing error: Cannot use keyword 'await' outside an async function\n\n**What did you expect to happen?**\n\n`Top-level await` is a stage 3 proposal (see URL but is enabled by default in from Node 14.8.0 (see URL \n\nThis is going to mean that linting with apps written for Node 14+ will be problematic, as top-level await is bound to be used. \n\nSince Node 14 is becoming Active LTS in a few weeks I think TLA should pass linting\n\n**Are you willing to submit a pull request to fix this bug?**\n\nyes","author_login":"davidmarkclements","author_association":"NONE","created_at":"2020-10-07T21:47:11+08:00","repo_name":"standard/standard","issue_id":716873209,"issue_number":1548,"issue_url":"https://github.com/standard/standard/issues/1548","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1014749822","fragment_type":"issue_comment","sequence":1,"text":"With AWS Lambda now supporting top level await ( URL I imagine a lot more will run into this parsing error. It looks like `eslint@8` ( URL has been released.","author_login":"willfarrell","author_association":"NONE","created_at":"2022-01-17T17:14:27+08:00","repo_name":"standard/standard","issue_id":716873209,"issue_number":1548,"issue_url":"https://github.com/standard/standard/issues/1548","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1014753723","fragment_type":"issue_comment","sequence":2,"text":"@willfarrell you can follow Standard 17 (which uses ESLint 8) progress here: URL","author_login":"NemoStein","author_association":"NONE","created_at":"2022-01-17T17:19:02+08:00","repo_name":"standard/standard","issue_id":716873209,"issue_number":1548,"issue_url":"https://github.com/standard/standard/issues/1548","linked_issue_ids":[1096525083],"is_known_query_context":false},{"document_id":"gh_comment_1026202216","fragment_type":"issue_comment","sequence":3,"text":"Prerelease `17.0.0-0` of `standard` is now released, containing ESLint 8 support, which should fix this issue. See: URL \n\nWould love if you could all test this and report back here if this is still an issue 🙏 We'll reopen this if its still an issue.","author_login":"voxpelli","author_association":"MEMBER","created_at":"2022-01-31T20:57:50+08:00","repo_name":"standard/standard","issue_id":716873209,"issue_number":1548,"issue_url":"https://github.com/standard/standard/issues/1548","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1026210498","fragment_type":"issue_comment","sequence":4,"text":"@voxpelli Something wrong is not right\n\njs\n// main.js\nawait new Promise(resolve => resolve())\n\nsh\nSandbox $ standard --version \n17.0.0-0\nSandbox $ standard .\\main.js\nstandard: Use JavaScript Standard Style ( URL \n .\\Sandbox\\main.js:1:1: Parsing error: Cannot use keyword 'await' outside an async function (null)\n\nFurthermore, VSCode (`standard.vscode-standard v2.0.1`) don't show Standard errors anymore.","author_login":"NemoStein","author_association":"NONE","created_at":"2022-01-31T21:07:46+08:00","repo_name":"standard/standard","issue_id":716873209,"issue_number":1548,"issue_url":"https://github.com/standard/standard/issues/1548","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1026213868","fragment_type":"issue_comment","sequence":5,"text":"@NemoStein Right, thanks, I'll reopen. Have you tested in plain ESLint 8 and seen if it works there? Maybe we need to explicitly allow it?\n\nIn regards to the VSCode extension, that one needs an update, I highlighted that in URL now 🙏","author_login":"voxpelli","author_association":"MEMBER","created_at":"2022-01-31T21:11:45+08:00","repo_name":"standard/standard","issue_id":716873209,"issue_number":1548,"issue_url":"https://github.com/standard/standard/issues/1548","linked_issue_ids":[1096525083],"is_known_query_context":false},{"document_id":"gh_comment_1026217965","fragment_type":"issue_comment","sequence":6,"text":"just had a quick look and standard 17 doesn't support class instance fields, either (which eslint 8 does)\n\njs\nclass Test {\n something = 1\n}\n\nexport default Test\n\n$ standard instance-field.js\nstandard: Use JavaScript Standard Style ( URL \n /Users/lloyd/Documents/instance-field:2:13: Parsing error: Unexpected token = (null)","author_login":"75lb","author_association":"NONE","created_at":"2022-01-31T21:16:17+08:00","repo_name":"standard/standard","issue_id":716873209,"issue_number":1548,"issue_url":"https://github.com/standard/standard/issues/1548","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1026235864","fragment_type":"issue_comment","sequence":7,"text":"@voxpelli Ok, here goes my 2 cents.\nUsing only ESLint, if you don't set the `parserOptions.ecmaVersion` to `\"latest\"` it also triggers the error\n\njs\n// .eslintrc.js\n\nmodule.exports = {\n env: {\n es2021: true,\n },\n parserOptions: {\n ecmaVersion: 'latest', // resolve())\n\nWith `parserOptions.ecmaVersion: \"latest\"`\n\nsh\n$ eslint .\\main.js\n$\n\nWithout\n\nsh\n$ eslint .\\main.js\n\n.\\main.js\n 1:1 error Parsing error: Cannot use keyword 'await' outside an async function\n\n✖ 1 problem (1 error, 0 warnings)\n\n$","author_login":"NemoStein","author_association":"NONE","created_at":"2022-01-31T21:36:42+08:00","repo_name":"standard/standard","issue_id":716873209,"issue_number":1548,"issue_url":"https://github.com/standard/standard/issues/1548","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1026238074","fragment_type":"issue_comment","sequence":8,"text":"@NemoStein Yeah, I arrived at the same conclusion, will merge and release URL when another maintainer gives me a review 👍","author_login":"voxpelli","author_association":"MEMBER","created_at":"2022-01-31T21:39:26+08:00","repo_name":"standard/standard","issue_id":716873209,"issue_number":1548,"issue_url":"https://github.com/standard/standard/issues/1548","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1026255802","fragment_type":"issue_comment","sequence":9,"text":"@NemoStein @75lb We just released `17.0.0-1` with a fix for this. Unless URL overrides that fix, then it should work now, else we'll try to get a fix in for that issue and releases a `17.0.0-2` tomorrow. Both me and @Divlo needs some sleep now 😅","author_login":"voxpelli","author_association":"MEMBER","created_at":"2022-01-31T22:02:27+08:00","repo_name":"standard/standard","issue_id":716873209,"issue_number":1548,"issue_url":"https://github.com/standard/standard/issues/1548","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1026353083","fragment_type":"issue_comment","sequence":10,"text":"Sadly it does, but I can confirm that updating the `eslint-config-standard-jsx/eslintrc.json` to `\"ecmaVersion\": 2022` works.","author_login":"NemoStein","author_association":"NONE","created_at":"2022-02-01T00:36:08+08:00","repo_name":"standard/standard","issue_id":716873209,"issue_number":1548,"issue_url":"https://github.com/standard/standard/issues/1548","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1029302767","fragment_type":"issue_comment","sequence":11,"text":"`17.0.0-2` should finally be fixing this + we now have tests that ensures that ensures that's the case","author_login":"voxpelli","author_association":"MEMBER","created_at":"2022-02-03T18:59:12+08:00","repo_name":"standard/standard","issue_id":716873209,"issue_number":1548,"issue_url":"https://github.com/standard/standard/issues/1548","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1096525083","fragment_type":"issue_description","sequence":0,"text":"Ship final version of `17.0.0`\nMe and @Divlo shipped `17.0.0-0` today, #203, following the merge of #193.\n\n`17.0.0-0` is a _prerelease_.\n\nOne can install it using `eslint-config-standard@next`\n\nBeing a pre-release, `17.0.0-0` comes with no guarantees in regards to support / breaking changes etc. It exists to facilitate early feedback, from the wider community as well from our selves.\n\nNext steps before we will ship a stable release of `17.0.0` are:\n\n* [x] Merge new `standard-engine` into `standard`: URL \n* [x] Ship a new major of `eslint-config-standard-jsx`\n* [x] Update `standard` to `17.0.0-0` of this module + the new major of `eslint-config-standard-jsx`\n* [x] Ship a `17.0.0-0` of `standard` to start getting some feedback on ecosystem compatibility\n* [x] When we're confident that the ecosystem is ready for a stable `17.0.0`, roll one for this module...\n * [x] Ship a `17.x` compliant update to `vscode-standard` ( URL \n * [x] All of the external tests in `standard` passes ( URL \n * [x] `standard-engine` generated types ( URL + CI succeeds\n* [x] ...and then a stable `11.0.0` of `eslint-config-standard-jsx`\n* [x] ~~...and then a stable `12.0.0` of `eslint-config-standard-react`~~ **Not used, skipped**\n* [x] ...and then a stable `15.0.0` of `standard-engine`\n* [ ] ...and then a stable `17.0.0` of `standard`...\n* [ ] ...and then new version of the long tail of `standard`-siblings, like `semistandard`...\n* [ ] ...then close this issue and the `17.0.0` milestone\n\nIn the meanwhile, please report any breakage you discover 🙏","author_login":"voxpelli","author_association":"MEMBER","created_at":"2022-01-07T17:36:39+08:00","repo_name":"standard/eslint-config-standard","issue_id":1096525083,"issue_number":208,"issue_url":"https://github.com/standard/eslint-config-standard/issues/208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1026200834","fragment_type":"issue_comment","sequence":1,"text":"Prerelease `17.0.0-0` of `standard` is now released: URL \n\nWe will be checking the stability of this ourselves, but would love for as many of our users to test it out as well and report back to us whether it's time to party or time to head back into the workshop and reshape things. Thanks 🙏","author_login":"voxpelli","author_association":"MEMBER","created_at":"2022-01-31T20:56:01+08:00","repo_name":"standard/eslint-config-standard","issue_id":1096525083,"issue_number":208,"issue_url":"https://github.com/standard/eslint-config-standard/issues/208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1055413565","fragment_type":"issue_comment","sequence":2,"text":"Any update on the final 17? Working with it since 3 weeks, looking good to me...","author_login":"JanFellner","author_association":"NONE","created_at":"2022-03-01T12:54:32+08:00","repo_name":"standard/eslint-config-standard","issue_id":1096525083,"issue_number":208,"issue_url":"https://github.com/standard/eslint-config-standard/issues/208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1057007803","fragment_type":"issue_comment","sequence":3,"text":"@feross \nunderstand that there are many moving parts here before full release\n\ncould 'latest' tag, at least, be bumped to pick up dep change @ \n\n URL \n\n? it's currently causing breakage, e.g. in VSCode's Redhat Dependency Analytics / snyk usage.","author_login":"pgnd","author_association":"NONE","created_at":"2022-03-02T14:44:04+08:00","repo_name":"standard/eslint-config-standard","issue_id":1096525083,"issue_number":208,"issue_url":"https://github.com/standard/eslint-config-standard/issues/208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1061943732","fragment_type":"issue_comment","sequence":4,"text":"@pgnd What breakage is caused where?\n\nThe `latest` tag will and should always be pointing to the newest stable release.\n\n@Divlo We can release a stable before @feross chimes in, since its just a dependency update. We still have URL to fix though","author_login":"voxpelli","author_association":"MEMBER","created_at":"2022-03-08T16:08:13+08:00","repo_name":"standard/eslint-config-standard","issue_id":1096525083,"issue_number":208,"issue_url":"https://github.com/standard/eslint-config-standard/issues/208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1061962424","fragment_type":"issue_comment","sequence":5,"text":"@voxpelli understood. if i can get RH tool working in my env, I'll readd it and get the details to you. Atm, it's a 'doorstop'.\n\nyarn add --dev eslint-config-standard@next\n\ninstalls 17.0.0-1, from Jan 31 tag\n\nwhich does NOT yet contain the relevant fix from\n\n URL","author_login":"pgnd","author_association":"NONE","created_at":"2022-03-08T16:26:31+08:00","repo_name":"standard/eslint-config-standard","issue_id":1096525083,"issue_number":208,"issue_url":"https://github.com/standard/eslint-config-standard/issues/208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1062018920","fragment_type":"issue_comment","sequence":6,"text":"a pre-release 17.0.0-2 tag could allow building transient dependencies that rely on eslint-config-n@latest without getting npm errors, that's all. We build an in-house eslint library for vue-cli5, and as of right now we have a breakage because of conflicting versions ubtil 17.0.0 i s released or a new beta tag is posted. If possible, we'd like to not do yet another fork of an eslint-related project 😅","author_login":"christophernruud","author_association":"CONTRIBUTOR","created_at":"2022-03-08T17:22:43+08:00","repo_name":"standard/eslint-config-standard","issue_id":1096525083,"issue_number":208,"issue_url":"https://github.com/standard/eslint-config-standard/issues/208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1062025961","fragment_type":"issue_comment","sequence":7,"text":"I can try to roll one later, but if there’s no _need_ for you to run with a newer version of `eslint-plugin-n` then you can simply downgrade it to the version that `standard` expects.","author_login":"voxpelli","author_association":"MEMBER","created_at":"2022-03-08T17:30:46+08:00","repo_name":"standard/eslint-config-standard","issue_id":1096525083,"issue_number":208,"issue_url":"https://github.com/standard/eslint-config-standard/issues/208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1070840575","fragment_type":"issue_comment","sequence":8,"text":"Ping :) I always need to manually handle the result of npm outdated for this repo. Any chance to get that done?\ngrafik","author_login":"JanFellner","author_association":"NONE","created_at":"2022-03-17T12:02:42+08:00","repo_name":"standard/eslint-config-standard","issue_id":1096525083,"issue_number":208,"issue_url":"https://github.com/standard/eslint-config-standard/issues/208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1070843820","fragment_type":"issue_comment","sequence":9,"text":"@JanFellner Feel free to help going through URL :) That's the main blocker.\n\nWe won't release this as stable without having passing integration tests for the wider community as failures there can just as much mean that we had unintended rule changes in the ESLint 8 move as it can mean that the external projects have gone bad themselves.\n\nAlso: If you know of large projects using this that aren't present in the external tests there, then please make an issue or PR there to suggest adding them. The more insight we can get into community breakage / support, the more confident we can become in shipping things quickly.\n\n(Right now I myself am pretty busy with my paid job, so haven't had time to look at the mentioned issues in a while)","author_login":"voxpelli","author_association":"MEMBER","created_at":"2022-03-17T12:06:46+08:00","repo_name":"standard/eslint-config-standard","issue_id":1096525083,"issue_number":208,"issue_url":"https://github.com/standard/eslint-config-standard/issues/208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1083717615","fragment_type":"issue_comment","sequence":10,"text":"looking, the aparently still open issues are\n\n LAST COMMIT\n _____________\n URL 2022-03-17\n URL 2022-03-30\n URL 2021-05-07\n URL 2020-10-29\n URL 2022-03-16\n URL 2020-10-29\n URL 2022-02-27\n URL 2021-08-01\n\nSome are recently active, some, clearly ... aren't.\n\niiuc, no eslint8-ready `eslint-config-standard` v17x final release until each/all of those are updated?","author_login":"pgnd","author_association":"NONE","created_at":"2022-03-30T22:53:58+08:00","repo_name":"standard/eslint-config-standard","issue_id":1096525083,"issue_number":208,"issue_url":"https://github.com/standard/eslint-config-standard/issues/208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1084652096","fragment_type":"issue_comment","sequence":11,"text":"@pgnd \n \n\nI don't think strictly that we should fix all the `test-external` before releasing v17, even if it would be better for sure, I don't think this is necessary as most of the failing ones are unmaintained repo with no activity recently, and also most of the repo in `test-external` still use `var` keyword to declare variables (they are mostly old codebases)...\n\nI think it would be worth disabling some of them (see this file: URL \nAlso, we might consider doing a major \"refactoring\" for this, and only do `test-external` for a repo that at least use v16 of `standard` and that is actively maintained (I know actively might be subjective but I think we should define what is \"active\" and we can pretty much agree that repo with no commits since 3 years is unmaintained), I saw some of them still using `standard` v14.","author_login":"Divlo","author_association":"MEMBER","created_at":"2022-03-31T14:18:45+08:00","repo_name":"standard/eslint-config-standard","issue_id":1096525083,"issue_number":208,"issue_url":"https://github.com/standard/eslint-config-standard/issues/208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1090541537","fragment_type":"issue_comment","sequence":12,"text":"I agree, this also seems to be the backwards way of doing this, it's after all a major upgrade, so maybe there should be a PR for those projects to ease their upgrade, but if that PR is discarded or the project is not even using an up to date version of standard or their is no activity on the project they should definitely not block the upgrade in itself. I know some projects will be reluctant to change from var to const because they want to keep backward compatibility with the super old nodejs versions, and well we can't blame them for not wanting to release a major over code style\n\nAdoption won't happen until it is fully released, and those forgotten projects will either update in their own time or get forked into oblivion","author_login":"Tofandel","author_association":"NONE","created_at":"2022-04-06T17:37:31+08:00","repo_name":"standard/eslint-config-standard","issue_id":1096525083,"issue_number":208,"issue_url":"https://github.com/standard/eslint-config-standard/issues/208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1102180793","fragment_type":"issue_comment","sequence":13,"text":"@voxpelli whats your thinking about removing outdated packages as mentioned by @Divlo and @Tofandel.\nThis currently seems to block the final shipment of v17?","author_login":"JanFellner","author_association":"NONE","created_at":"2022-04-19T07:17:14+08:00","repo_name":"standard/eslint-config-standard","issue_id":1096525083,"issue_number":208,"issue_url":"https://github.com/standard/eslint-config-standard/issues/208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1102202756","fragment_type":"issue_comment","sequence":14,"text":"I'm 👍 on that, though I want to go through them to see if the failures are because of an unintended change or because of eg. lack of maintenance on their path.\n\nI'll try to find time soon to look at what eg. @Tofandel summarised here. Main blocker from my side has been my time 🙈","author_login":"voxpelli","author_association":"MEMBER","created_at":"2022-04-19T07:31:33+08:00","repo_name":"standard/eslint-config-standard","issue_id":1096525083,"issue_number":208,"issue_url":"https://github.com/standard/eslint-config-standard/issues/208","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0462","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"[Issue]: The provided authorization code or refresh token is revoked.","query_context":"I installed v4 yesterday (upgrade from v3 via delete v3 -> install v4) and it seemd to work fine, but this morning it is not working anymore with the following error:\n \n\nDeleting the configuration incl. credentials and re-adding them to re-do the OAuth-flow solved the problem.\nI'll update this issue if it happens again, but maybe an option to manually re-do OAuth without deleting would be good?\n\nThanks for your work and regards,\nChristoph","known_context_document_ids":["gh_issue_2162721039"],"reference_answer":"Maybe Daikin changed something for the old API, you are using that. Btw, change your daikin password, this was listed plain text in your json (which I just removed)","answer_document_id":"gh_comment_2004315404","silver_evidence_path":["gh_comment_1972620054","gh_issue_2139900425","gh_comment_2004315404"],"evidence_issue_ids":[2162721039,2139900425],"source_repo_name":"jwillemsen/daikin_onecta","source_issue_id":2162721039,"source_issue_number":62,"source_issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/62","target_repo_name":"jwillemsen/daikin_onecta","target_issue_id":2139900425,"target_issue_number":41,"target_issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","reference_anchor_document_id":"gh_comment_1972620054","reference_answer_author":"jwillemsen","reference_answer_author_association":"OWNER","quality_score":91.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3333,"anchor_target_overlap":0.1667,"target_answer_overlap":0.0},"issue_created_at":"2024-03-01T06:43:32+08:00","valid_comment_count":250,"fragments":[{"document_id":"gh_issue_2162721039","fragment_type":"issue_description","sequence":0,"text":"[Issue]: The provided authorization code or refresh token is revoked.\nI installed v4 yesterday (upgrade from v3 via delete v3 -> install v4) and it seemd to work fine, but this morning it is not working anymore with the following error:\n \n\nDeleting the configuration incl. credentials and re-adding them to re-do the OAuth-flow solved the problem.\nI'll update this issue if it happens again, but maybe an option to manually re-do OAuth without deleting would be good?\n\nThanks for your work and regards,\nChristoph","author_login":"chrfin","author_association":"NONE","created_at":"2024-03-01T06:43:32+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2162721039,"issue_number":62,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/62","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1972620054","fragment_type":"issue_comment","sequence":1,"text":"Same as #41. Do you have another integration which supports a re-do OAuth-flow?","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-01T07:01:50+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2162721039,"issue_number":62,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/62","linked_issue_ids":[2139900425],"is_known_query_context":false},{"document_id":"gh_comment_1972653226","fragment_type":"issue_comment","sequence":2,"text":"Ups, sorry - I looked at the old issues, but did not see this. Must be too early in the morning 🙈...\n\nBut no, I do not remember having any other extensions using such an OAuth-flow...\n\nI'll close this issue in favor of the other one.","author_login":"chrfin","author_association":"NONE","created_at":"2024-03-01T07:22:27+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2162721039,"issue_number":62,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/62","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1972657886","fragment_type":"issue_comment","sequence":3,"text":"I am using some other integrations using OAuth2 but they don't have a re-do option also. I am learning more and more about HA and its internal each day, will continue to look at this, hopefully Daikin finds something soon, I don't have this problem with my installation, runs stable for several days now","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-01T07:24:15+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2162721039,"issue_number":62,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/62","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1972735613","fragment_type":"issue_comment","sequence":4,"text":"The other integrations that I am using with oauth2 also don't have a renew option. It seems I can't delete credentials when they are used by an installed integration","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-01T08:27:39+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2162721039,"issue_number":62,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/62","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1976154529","fragment_type":"issue_comment","sequence":5,"text":"Hi, I'm a new user of this integration (added yesterday), and after working for a few hours I'm getting the exact same messages and obvioulsy everything is now offline.\n\nJust happened overnight, no reboot, no special requests.\n\nNevertheless the client ID seems to be the same than the one quoted above \"daikin_onecta_emu20...\" : is it the normal behaviour ?","author_login":"arpel","author_association":"NONE","created_at":"2024-03-04T09:47:04+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2162721039,"issue_number":62,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/62","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1976164029","fragment_type":"issue_comment","sequence":6,"text":"The client id is currently shared by everyone, you can't create your own application, waiting on @Daikin-Europe for that. Some users who had this same issue had the same, but it works for them now, see URL Please contact Daikin, their email address is on the Certification page at the Daikin Developer Portal website","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-04T09:50:20+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2162721039,"issue_number":62,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/62","linked_issue_ids":[2139900425],"is_known_query_context":false},{"document_id":"gh_comment_1976501272","fragment_type":"issue_comment","sequence":7,"text":"Ok, went through the entire #41 but still unclear what they've actually done to make it work (and last). \nAs I just stepped in yesterday I guess there's nothing linked to integration version ... so appart from removing / redoing the configuration I have no clue what to do.","author_login":"arpel","author_association":"NONE","created_at":"2024-03-04T12:43:15+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2162721039,"issue_number":62,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/62","linked_issue_ids":[2139900425],"is_known_query_context":false},{"document_id":"gh_comment_1980610694","fragment_type":"issue_comment","sequence":8,"text":"I'm still seeing the authentication start failing after about 12 hours with the latest version (4.0.7). Removing and re-adding gets me another 12 hours. I can see others have reported this on this thread but can't tell if there was a definite resolution or not?\n\nScreenshot 2024-03-06 at 10 51 30\n\nThe error in the log at 8:01 when it failed was:\nError requesting daikin_onecta data: 400, message='Bad Request', url=URL(' URL \n\nAnd then a couple of these at various points afterwards as you'd expect when the token has expired:\nToken request for daikin_onecta_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.","author_login":"sOckhamSter","author_association":"NONE","created_at":"2024-03-06T11:00:43+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2162721039,"issue_number":62,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/62","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2139900425","fragment_type":"issue_description","sequence":0,"text":"The provided authorization code or refresh token is revoked.\nThe integration did not survive an upgrade from 2024.2.1 to 2024.2.2 :-(\n\nLogger: homeassistant.helpers.config_entry_oauth2_flow\nSource: helpers/config_entry_oauth2_flow.py:211\nFirst occurred: 8:29:08 am (11 occurrences)\nLast logged: 8:32:34 am\n\nToken request for daikin_residential_altherma_xxxxxxx failed (invalid_grant): The provided authorization code or refresh token is revoked.\n\n*** update ***\n\ndeleted and added back ok, I guess this is not ideal for future HA upgrades","author_login":"neildsb","author_association":"NONE","created_at":"2024-02-17T08:39:03+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1951036937","fragment_type":"issue_comment","sequence":1,"text":"Are you sure you are using the latest github version on master, I made a fix last Friday for token refresh, just updated my test HA from 2024.2.0 to 2024.2.2 and that didn't gave a probem, see URL for the fix. Do you have that?","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-18T09:07:22+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1951046617","fragment_type":"issue_comment","sequence":2,"text":"ah I have a21d8cc, will pull the latest master, thanks\n\nimage","author_login":"neildsb","author_association":"NONE","created_at":"2024-02-18T09:33:42+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952219564","fragment_type":"issue_comment","sequence":3,"text":"It seems like the same problem to me. After half a day, data collection stops again. Click on reload the application, then follow the message below!\ndaikin prob","author_login":"Waling1961","author_association":"NONE","created_at":"2024-02-19T11:08:57+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952475718","fragment_type":"issue_comment","sequence":4,"text":"Could you enable debug logging to your configuration.yaml, it should have at least these loggers enabled:\n\nlogger:\n logs:\n custom_components.daikin_residential_altherma: debug\n homeassistant.helpers.config_entry_oauth2_flow: debug","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-19T13:39:41+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952493585","fragment_type":"issue_comment","sequence":5,"text":"According to Daikin the refresh_token is valid for 1 year, but it can only be used once, on a refresh you get a new refresh_token. Hopefully the logging will tell us more what is happening.","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-19T13:49:34+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952633370","fragment_type":"issue_comment","sequence":6,"text":"Below is a logging of the first time the authorization does not work.\nThe clientid is in the logging with only lowercase letters. The assigned client ID also contains uppercase letters.\n\n**`2024-02-18 23:58:07.086 ERROR (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Token request for daikin_residential_altherma_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.\n2024-02-18 23:58:07.087 ERROR (MainThread) [homeassistant.helpers.entity] Update for climate.room_temperature fails\nTraceback (most recent call last):\n File \"/usr/src/homeassistant/homeassistant/helpers/entity.py\", line 942, in async_update_ha_state\n await self.async_device_update()\n File \"/usr/src/homeassistant/homeassistant/helpers/entity.py\", line 1259, in async_device_update\n await self.async_update()\n File \"/config/custom_components/daikin_residential_altherma/climate.py\", line 614, in async_update\n await self._device.api.async_update()\n File \"/config/custom_components/daikin_residential_altherma/daikin_api.py\", line 126, in async_update\n self.json_data = await self.getCloudDeviceDetails()\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/config/custom_components/daikin_residential_altherma/daikin_api.py\", line 103, in getCloudDeviceDetails\n json_puredata = await self.doBearerRequest(\"/v1/gateway-devices\")\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/config/custom_components/daikin_residential_altherma/daikin_api.py\", line 57, in doBearerRequest\n token = await self.async_get_access_token()\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/config/custom_components/daikin_residential_altherma/daikin_api.py\", line 53, in async_get_access_token\n await self.session.async_ensure_token_valid()\n File \"/usr/src/homeassistant/homeassistant/helpers/config_entry_oauth2_flow.py\", line 518, in async_ensure_token_valid\n new_token = await self.implementation.async_refresh_token(self.token)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/usr/src/homeassistant/homeassistant/helpers/config_entry_oauth2_flow.py\", line 94, in async_refresh_token\n new_token = await self._async_refresh_token(token)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/usr/src/homeassistant/homeassistant/helpers/config_entry_oauth2_flow.py\", line 184, in _async_refresh_token\n new_token = await self._token_request(\n ^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/usr/src/homeassistant/homeassistant/helpers/config_entry_oauth2_flow.py\", line 217, in _token_request\n resp.raise_for_status()\n File \"/usr/local/lib/python3.12/site-packages/aiohttp/client_reqrep.py\", line 1060, in raise_for_status\n raise ClientResponseError(\naiohttp.client_exceptions.ClientResponseError: 400, message='Bad Request', url=URL(' URL","author_login":"Waling1961","author_association":"NONE","created_at":"2024-02-19T15:02:00+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952644118","fragment_type":"issue_comment","sequence":7,"text":"Can you check the log one hour earlier @Waling1961, is there a token renew call there?","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-19T15:05:37+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952681211","fragment_type":"issue_comment","sequence":8,"text":"Strange, is there no other logging with `config_entry_oauth2_flow`? I have just pushed a change to log the token before and after the refresh call when it is not valid anymore, maybe that helps more. Not sure why this is failing? On a restart of HA here I don't have a problem with the token","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-19T15:22:56+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952721514","fragment_type":"issue_comment","sequence":9,"text":"I also had a case where this happened, did a few times a restart of HA. Added some more logging to the code with the token and expiration date, but I had to remove and add the integration and now I get a `no Route matched with those values`, so maybe something on the Daikin side @Daikin-Europe?\n\nIn order to test someone has to download each log before the restart so that we can check the token before and after a restart and see if something is maybe not stored?","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-19T15:39:46+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952775830","fragment_type":"issue_comment","sequence":10,"text":"Have reinstalled the Home Assistant Integration for Daikin devices including Daikin Altherma 3 Heat Pump. Strange thing is that I'm still using the same authorization token!","author_login":"Waling1961","author_association":"NONE","created_at":"2024-02-19T16:04:42+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952918214","fragment_type":"issue_comment","sequence":11,"text":"with version URL the integration survives restarts now, fingers crossed :-)","author_login":"neildsb","author_association":"NONE","created_at":"2024-02-19T17:23:40+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1953011570","fragment_type":"issue_comment","sequence":12,"text":"When it is still valid I think we don't need a new one on restart, only when it is not valid anymore we need to renew it","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-19T18:43:59+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1953119030","fragment_type":"issue_comment","sequence":13,"text":"Token refresh seems happy for around 12 hours, then BANG! Token has survived a restart of HA to upgrade the integration to the latest version.\n\n2024-02-19 19:40:53.352 DEBUG (MainThread) [custom_components.daikin_residential_altherma.daikin_api] Token still valid until 1708372253.5379262 eyJ0eXAiOiJhdCtKV1QiLCJhbGciOiJSUzI1NiIsImtpZCI6Ik1FVkdRa0l5TXprNE0wRTRNVFkzTnpJM1FUYzBNek16T0RRd05FRkVRVUpCTTBFd1EwRkZRZyJ9.eyJzY29wZSI6Im9wZW5pZCBvbmVjdGE6YmFzaWMuaW50ZWdyYXRpb24iLCJpYXQiOjE3MDgzNjg2NTMsImV4cCI6MTcwODM3MjI1MywiY2xpZW50X2lkIjoiZW1VMjBHZEpEaWlVeElfSG5GR3o2OWREIiwiYXVkIjpbImh0dHBzOi8vaWRwLm9uZWN0YS5kYWlraW5ldXJvcGUuY29tIiwiaHR0cHM6Ly9hcGkub25lY3RhLmRhaWtpbmV1cm9wZS5jb20iLCJlbVUyMEdkSkRpaVV4SV9IbkZHejY5ZEQiXSwiaXNzIjoiaHR0cHM6Ly9jZGMuZGFpa2luLmV1L29pZGMvb3AvdjEuMC8zX3hSQjNqYVE2MmJWanFYVTFvbWFFc1BEVllDMFR3aTF6ZnExekhQdV81SEZUMHpXa0R2WkpTOTdZdzFsb0puVG0vIiwic3ViIjoiYjU4NDU4YjQ3M2MwNGYwYjgwYzA3Y2RlZmY1MWNhNmMiLCJzaWQiOiI5NjQ2MjY4MzU3OThfUURpQzBXbjBUZ3cxUzZYQkpTcmZBUW5RTVdJIiwianRpIjoic3QyLnMuQXRMdDh3dHRWQS4wRThXU2dyM0Riel9fVVoyRVROMkQyZldvclBqTC05TFF2cFB5NVQwbEgzcjhob2pwZ2RaWGhYaXpOYV9QT2xkbzI2YjVtUkRCSEswY0ZUd1JnYllSaUNoQ1JuSUFOVjJYS3V0Zm5IREQyNTlBS2pSaEg4Y0N2TWxNWGtpSXROTS4zZUFucTlTbEI1OXlTTFI4XzNTLWw3Vk01YXlaUDZFVThGTTJzRFpRdmhIYU9RWUNjTUVfelhEY0FHRGdVcHVtcy0ycllRVXUtNmF6VG1ZRFZKNmJxZy5zYzMiLCJhenAiOiJlbVUyMEdkSkRpaVV4SV9IbkZHejY5ZEQifQ.C7rfvQEHkpLaywHr8Ba7StFLmTTzEtOf1hQGtGC2SCUH1_s84wMnzQv08QoajXE8gZ7Ec9lHQMYueNVubnU0_tzvtA7RwSInqdKZpTtqGiolD1aTQeE3NgOMV5uDEfO8HrZ-SgqdY-oH_-TKu48rCH8jSzdYTzvwZJChD0fTN9zK499G3x20IShPsv3ZcnvxPc6PT-uCNGz7wplJ_eLN5X33pG1BCtXn0e6fAEqzWxe9XyQkBP1UceMf2S-_eOFl1cmMZC3yQxZSUiNAqqQNB5Q2Lzl0lCGDB6mEmBszc66ttoPxH_JOO7GRXdycYolBPH0D2NH0Lr07-bWABoyoHA\n2024-02-19 19:50:53.363 DEBUG (MainThread) [custom_components.daikin_residential_altherma.daikin_api] Token not valid before renew 1708372253.5379262 eyJ0eXAiOiJhdCtKV1QiLCJhbGciOiJSUzI1NiIsImtpZCI6Ik1FVkdRa0l5TXprNE0wRTRNVFkzTnpJM1FUYzBNek16T0RRd05FRkVRVUpCTTBFd1EwRkZRZyJ9.eyJzY29wZSI6Im9wZW5pZCBvbmVjdGE6YmFzaWMuaW50ZWdyYXRpb24iLCJpYXQiOjE3MDgzNjg2NTMsImV4cCI6MTcwODM3MjI1MywiY2xpZW50X2lkIjoiZW1VMjBHZEpEaWlVeElfSG5GR3o2OWREIiwiYXVkIjpbImh0dHBzOi8vaWRwLm9uZWN0YS5kYWlraW5ldXJvcGUuY29tIiwiaHR0cHM6Ly9hcGkub25lY3RhLmRhaWtpbmV1cm9wZS5jb20iLCJlbVUyMEdkSkRpaVV4SV9IbkZHejY5ZEQiXSwiaXNzIjoiaHR0cHM6Ly9jZGMuZGFpa2luLmV1L29pZGMvb3AvdjEuMC8zX3hSQjNqYVE2MmJWanFYVTFvbWFFc1BEVllDMFR3aTF6ZnExekhQdV81SEZUMHpXa0R2WkpTOTdZdzFsb0puVG0vIiwic3ViIjoiYjU4NDU4YjQ3M2MwNGYwYjgwYzA3Y2RlZmY1MWNhNmMiLCJzaWQiOiI5NjQ2MjY4MzU3OThfUURpQzBXbjBUZ3cxUzZYQkpTcmZBUW5RTVdJIiwianRpIjoic3QyLnMuQXRMdDh3dHRWQS4wRThXU2dyM0Riel9fVVoyRVROMkQyZldvclBqTC05TFF2cFB5NVQwbEgzcjhob2pwZ2RaWGhYaXpOYV9QT2xkbzI2YjVtUkRCSEswY0ZUd1JnYllSaUNoQ1JuSUFOVjJYS3V0Zm5IREQyNTlBS2pSaEg4Y0N2TWxNWGtpSXROTS4zZUFucTlTbEI1OXlTTFI4XzNTLWw3Vk01YXlaUDZFVThGTTJzRFpRdmhIYU9RWUNjTUVfelhEY0FHRGdVcHVtcy0ycllRVXUtNmF6VG1ZRFZKNmJxZy5zYzMiLCJhenAiOiJlbVUyMEdkSkRpaVV4SV9IbkZHejY5ZEQifQ.C7rfvQEHkpLaywHr8Ba7StFLmTTzEtOf1hQGtGC2SCUH1_s84wMnzQv08QoajXE8gZ7Ec9lHQMYueNVubnU0_tzvtA7RwSInqdKZpTtqGiolD1aTQeE3NgOMV5uDEfO8HrZ-SgqdY-oH_-TKu48rCH8jSzdYTzvwZJChD0fTN9zK499G3x20IShPsv3ZcnvxPc6PT-uCNGz7wplJ_eLN5X33pG1BCtXn0e6fAEqzWxe9XyQkBP1UceMf2S-_eOFl1cmMZC3yQxZSUiNAqqQNB5Q2Lzl0lCGDB6mEmBszc66ttoPxH_JOO7GRXdycYolBPH0D2NH0Lr07-bWABoyoHA\n2024-02-19 19:50:53.594 ERROR (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Token request for daikin_residential_altherma_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.\n\nDeleted the integration, included the credentials saved in HA, then re-added using previously saved (outside of HA) client ID and client secret. Now successfully refreshing every 10 minutes.","author_login":"whitebarns","author_association":"NONE","created_at":"2024-02-19T20:25:04+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1953157096","fragment_type":"issue_comment","sequence":14,"text":"Can you check whether the renew token that is logged when the access token is not valid is maybe used for a renew earlier, maybe there are 2 renews directly after each other one hour earlier?","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-19T21:04:58+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1953582108","fragment_type":"issue_comment","sequence":15,"text":"Just pushed a change to move the token renew within the _cloud_lock scope, maybe we got two token renews at some point in parallel, now this is synchronized","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-20T06:48:06+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1953674957","fragment_type":"issue_comment","sequence":16,"text":"@whitebarns Can you update your local copy to the latest from master and retest, before each restart please save your log so that in case of a failure we can see when a token was refreshed and to which value","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-20T08:10:11+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1954751711","fragment_type":"issue_comment","sequence":17,"text":"Access/refresh tokens may not be shared, doing so is prohibited by the daikin developer terms and could give someone else control over your units","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-20T17:51:50+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1954850163","fragment_type":"issue_comment","sequence":18,"text":"Closing, should be fixed by the token refresh within the lock part","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-20T18:43:50+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1959313385","fragment_type":"issue_comment","sequence":19,"text":"Still have that after 12 hours the data is no longer retrieved. I downloaded and installed the latest version yesterday and the day before.\ndaikin failed","author_login":"Waling1961","author_association":"NONE","created_at":"2024-02-22T12:05:31+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1959470369","fragment_type":"issue_comment","sequence":20,"text":"Did you restart HA or was it just running? I have still no clue why this is happening on your installation","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-22T13:37:51+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1959528341","fragment_type":"issue_comment","sequence":21,"text":"HA was running.\n\nIs it possible because I'm running two devices in the same onecta app?\n\n \n\nVan: Johnny Willemsen ***@***.***> \nVerzonden: donderdag 22 februari 2024 14:38\nAan: jwillemsen/daikin_onecta ***@***.***>\nCC: Waling1961 ***@***.***>; Mention ***@***.***>\nOnderwerp: Re: [jwillemsen/daikin_onecta] The provided authorization code or refresh token is revoked. (Issue #41)\n\n \n\nDid you restart HA or was it just running? I have still no clue why this is happening on your installation\n\n—\nReply to this email directly, view it on GitHub >","author_login":"Waling1961","author_association":"NONE","created_at":"2024-02-22T14:08:42+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[2139900425],"is_known_query_context":false},{"document_id":"gh_comment_1959545381","fragment_type":"issue_comment","sequence":22,"text":"I have 5 devices and no problems until now, I am working again on the code, maybe I see something","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-22T14:17:35+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1961121198","fragment_type":"issue_comment","sequence":23,"text":"I have gone again through the code and before any http call to daikin we refresh the token when necessary. I have searched other HA integrations using OAuth2 and they do exactly the same. I have made one small change to check if we have a invalid token before calling into the OAuth2 helpers, maybe some race condition.","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-23T10:58:52+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1962933335","fragment_type":"issue_comment","sequence":24,"text":"Ok, please check your log around 9:48:56, around that time there should be the last working refresh, does it do some logging there?","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-25T13:03:32+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1962939043","fragment_type":"issue_comment","sequence":25,"text":"Sorry, there are no more logs.\nHave done some updates.\nI have registered daikin_onecta again, I will know more in 12 hours.","author_login":"Waling1961","author_association":"NONE","created_at":"2024-02-25T13:21:03+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1963491718","fragment_type":"issue_comment","sequence":26,"text":"And again the authorization has been broken. Below are the details from the logging:\ndaikin prob_3\ndaikin prob_3_detail\ndaikin prob_3_detail_1","author_login":"Waling1961","author_association":"NONE","created_at":"2024-02-26T07:42:53+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1963502864","fragment_type":"issue_comment","sequence":27,"text":"Is there any error around 00:44:54, that is the last renew that probably succeeded","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-26T07:50:33+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1963537452","fragment_type":"issue_comment","sequence":28,"text":"Please don't use images but add the plain text, always easier to use find searching for code","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-26T08:11:10+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1963551826","fragment_type":"issue_comment","sequence":29,"text":"There are no other errors around that time (00:44:54).\n\n------------------------------------------------------------------------------------------------------------------------------------\n**Logger: homeassistant.helpers.config_entry_oauth2_flow\nSource: helpers/config_entry_oauth2_flow.py:211\nFirst occurred: 01:44:54 (45 occurrences)\nLast logged: 09:04:55\n\nToken request for daikin_onecta_xxxxxxxxxxxxx failed (invalid_grant): The provided authorization code or refresh token is revoked.**\n-------------------------------------------------------------------------------------------------------------------------------------\nDeze fout is ontstaan door een aangepaste integratie.\n\nLogger: custom_components.daikin_onecta.coordinator\nSource: helpers/update_coordinator.py:326\nIntegration: Daikin Onecta (documentation, issues)\nFirst occurred: 01:44:54 (1 occurrences)\nLast logged: 01:44:54\n\nError requesting daikin_onecta data: 400, message='Bad Request', url=URL(' URL \n--------------------------------------------------------------------------------------------------------------------------------------------","author_login":"Waling1961","author_association":"NONE","created_at":"2024-02-26T08:20:21+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1965895629","fragment_type":"issue_comment","sequence":30,"text":"I installed the v4 on my main HA installation yesterday and still running without problems. Do you have anything in your network @Waling1961 that could block some traffic, maybe a pihole? Running stable here for 20 hours, each hour I see a token refresh happening without errors","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-27T06:52:10+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1966064107","fragment_type":"issue_comment","sequence":31,"text":"I also installed version 4 yesterday.\nEverything worked well (including the Cloud polling settings) until the 12 hours. Then the error message again!\nI do not consciously have any traffic hindering measures in my network. But if that were the case, why does everything go well for 12 hours? I've asked this before, but I have 2 identical devices. One of these two is at a different location. Could this also cause problems with the number of times the data is requested? Added some files from the debug logging. Please let us know if any more debug logging data is needed.\n\n2024-02-26 DEBUG Daikin.txt\nDEBUG Daikin Bearer code.txt\n\n---------------------------------------------------------------------------------------------------------------------------------------\nLogger: homeassistant.helpers.config_entry_oauth2_flow\nSource: helpers/config_entry_oauth2_flow.py:211\nFirst occurred: 05:03:49 (9 occurrences)\nLast logged: 09:03:49\n\nToken request for daikin_onecta_xxxxxxxxxxxxxxxxx failed (invalid_grant): The provided authorization code or refresh token is revoked.\n-----------------------------------------------------------------------------------------------------------------------------------------","author_login":"Waling1961","author_association":"NONE","created_at":"2024-02-27T08:53:06+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1966107043","fragment_type":"issue_comment","sequence":32,"text":"@Waling1961 Can you send an email to `developer@daikineurope.com` to ask for their support with your issue?","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-27T09:17:37+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1968729945","fragment_type":"issue_comment","sequence":33,"text":"I have exactly same issue: after 12 hours token becomes invalid and renewal fails (same error message as in title). OAuth debug loggin is not really helpful. There has to be something on our environments/configuration that is different and is causing the problem (failure to renew token). Any idea how to figure this out?\nShould we conside re-opening this issue? Or opening new issue?","author_login":"BigFoot2020","author_association":"NONE","created_at":"2024-02-28T10:55:47+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1968745915","fragment_type":"issue_comment","sequence":34,"text":"Is there another integration that you are using that uses oauth2? Do you only see the token refresh logging from oauth2 when daikin_onecta is triggered or also at another time?","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-28T11:05:14+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1968747467","fragment_type":"issue_comment","sequence":35,"text":"When you download the integration diagnostics when it has failed, what is the value of the oauth2_token_valid in the json?","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-28T11:06:12+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1968769068","fragment_type":"issue_comment","sequence":36,"text":"I have netatmo and home_connect installed in the same HA setup, they both seem to use oauth2 also, no problems with that","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-28T11:19:27+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1968780590","fragment_type":"issue_comment","sequence":37,"text":"No other oauth2 usage, only Daikin Onecta.\nWhen it fails , then \"oauth2_token_valid\": false\n\nLog entries when adding:\n\n2024-02-28 12:40:38.505 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Resumed OAuth configuration flow\n2024-02-28 12:40:38.523 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Creating config entry from external data\n2024-02-28 12:40:38.523 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Sending token request to URL \n2024-02-28 12:40:38.837 INFO (MainThread) [custom_components.daikin_onecta.config_flow] Successfully authenticated\n2024-02-28 12:40:38.837 INFO (MainThread) [custom_components.daikin_onecta.daikin_api] Daikin Onecta API initialized.\n\nLog entries when failing:\n\n2024-02-28 12:08:59.037 INFO (MainThread) [custom_components.daikin_onecta.daikin_api] Daikin Onecta API initialized.\n2024-02-28 12:08:59.037 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Sending token request to URL \n2024-02-28 12:08:59.459 ERROR (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Token request for daikin_onecta_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.","author_login":"BigFoot2020","author_association":"NONE","created_at":"2024-02-28T11:26:34+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1968830632","fragment_type":"issue_comment","sequence":38,"text":"@BigFoot2020 Can you also contact Daikin, see above, I have gone another time through the oauth2 code and can't find anything at the HA or daikin_onecta integration, maybe Daikin can see something in their logs.\n\nBtw, when looking at the second log, is that after a HA restart or integration reload? The text \"Daikin Onecta API initialized.\" is something I only see when I start HA","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-02-28T11:58:41+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1968856796","fragment_type":"issue_comment","sequence":39,"text":"That log was after HA restart. Logs before restart:\n\n2024-02-27 22:06:03.202 DEBUG (MainThread) [custom_components.daikin_onecta.coordinator] Daikin coordinator start _async_update_data.\n2024-02-27 22:06:03.203 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Sending token request to URL \n2024-02-27 22:06:03.539 ERROR (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Token request for daikin_onecta_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.\n2024-02-27 22:06:03.540 DEBUG (MainThread) [custom_components.daikin_onecta.coordinator] Finished fetching daikin_onecta data in 0.337 seconds (success: False)\n\nWill contact Daikin.","author_login":"BigFoot2020","author_association":"NONE","created_at":"2024-02-28T12:14:18+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1971138892","fragment_type":"issue_comment","sequence":40,"text":"**Daikin's response:**\nThanks for the data! I've submitted an investigation ticket at our identity provider to check it out.\nIf I know more I'll let you know.","author_login":"Waling1961","author_association":"NONE","created_at":"2024-02-29T13:27:46+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1976097999","fragment_type":"issue_comment","sequence":41,"text":"v4.0.4 has been stable for over 2 days now\n\nCore\n2024.2.5\nSupervisor\n2024.02.1\nOperating System\n12.0\nFrontend\n20240207.1","author_login":"neildsb","author_association":"NONE","created_at":"2024-03-04T09:21:02+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1976111516","fragment_type":"issue_comment","sequence":42,"text":"Great to hear that @neildsb, would be interesting to hear from @Daikin-Europe whether they changed something","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-04T09:28:34+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1976501208","fragment_type":"issue_comment","sequence":43,"text":"Still using version 4.0.1! Still have that after 12 hours authorization no longer works.\nAlso reported the problem to Daikin, but have not received any feedback yet! Now install v 4.0.5 and see if the authorization problems now go well","author_login":"Waling1961","author_association":"NONE","created_at":"2024-03-04T12:43:12+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1980614975","fragment_type":"issue_comment","sequence":44,"text":"I'm still seeing the authentication start failing after about 12 hours with the latest version (4.0.7). Removing and re-adding gets me another 12 hours. I can see others have reported this on this thread but can't tell if there was a definite resolution or not?\n\nScreenshot 2024-03-06 at 10 51 30\n\nThe error in the log at 8:01 when it failed was:\nError requesting daikin_onecta data: 400, message='Bad Request', url=URL(' URL \n\nAnd then a couple of these at various points afterwards as you'd expect when the token has expired:\nToken request for daikin_onecta_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.","author_login":"sOckhamSter","author_association":"NONE","created_at":"2024-03-06T11:03:06+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1980670816","fragment_type":"issue_comment","sequence":45,"text":"Is it a known thing that they are aware of and have sorted for others, or are we just contacting them to pile on the pressure?","author_login":"sOckhamSter","author_association":"NONE","created_at":"2024-03-06T11:32:23+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1980674067","fragment_type":"issue_comment","sequence":46,"text":"Some people who had this same issue contacted daikin and at some point it worked but I don't know whether daikin changed something","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-06T11:34:22+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1980894234","fragment_type":"issue_comment","sequence":47,"text":"Hi,\nSeems like I have the same issue that the authentication started to fail after some time.\nI reinstalled the Daikin Onecta integration v4.0.7 and I have to wait the next hours how it will behave.\n\nBut I made an observation that might give another indication.\nWhile working on other issues on HA I reladed the YAML several times during a short period and suddenly the data from Daikin Onecta was not updated.\n\nLogfile reports:\n \n \n \n \n \n \n \n \n\nAfter about 7 minutes I reloaded teh integration and data was fetched again.\n \n \n \n \n \n \n \n \n \n \n\nWhen reloading YAML too frequently will kind of refuse ruther API reqeuest.\nDont know if it would \"heal\" itself without reload from this kind of situations.","author_login":"ziggypin","author_association":"NONE","created_at":"2024-03-06T13:37:38+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1980899255","fragment_type":"issue_comment","sequence":48,"text":"Reloading the yaml will always trigger a call, very likely you made 6 calls in a minute, have a look at the returned limits the last call succeeded before it failed.","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-06T13:40:10+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1980979260","fragment_type":"issue_comment","sequence":49,"text":"You are right, for sure I reloaded yaml about 6 times a minute.\nThe fetching was interrupted between 12:42:18 and 12:49:45\n\nThe last successful fetching in the log was this:","author_login":"ziggypin","author_association":"NONE","created_at":"2024-03-06T14:21:02+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1981929706","fragment_type":"issue_comment","sequence":50,"text":"Hi, having this exact same issue, after few hours of run time (no yaml reload) : \n`Token request for daikin_onecta_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.\n`\n\nRemoving / re-adding the integration (with the bounce to dev site and \"Accept\") is going a new half day of run time.","author_login":"arpel","author_association":"NONE","created_at":"2024-03-06T22:21:33+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1985175268","fragment_type":"issue_comment","sequence":51,"text":"Just a short update:\nSince my my last reload the Onecta integration is working now since 44 hours.\n\nDuring the reload or during the add on of the integration the user will be redirected to the Daikin portal.\nAt this last reload I changed my procedure compared to the other trials where the authentication started to fail after some time:\n1. HA: Initiate reload\n2. Redirection to Daikin\n3. Daikin: Entered my credentials at Daikin developer portal\n4. Daikin: Authorize the application\n5. HA: Enter the temp. Oauth client data\n\nThe other times when the authorization failed after some time was:\n1. Followed the links to the Daikin Developer portal\n2. Daikin: Entered my credentials at Daikin developer portal\n3. HA: Initiate reload\n4. Redirection to Daikin\n5. Daikin: Authorize the application\n6. HA: Enter the temp. Oauth client data\n\nMaybe it is worth to try?\nDon't know if this really made the difference or if Daikin improved in the meantime some things on their side.","author_login":"ziggypin","author_association":"NONE","created_at":"2024-03-08T07:22:03+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1985210736","fragment_type":"issue_comment","sequence":52,"text":"I have tried it the same way now, but it seems Daikin did change something, as the login page is different now...","author_login":"chrfin","author_association":"NONE","created_at":"2024-03-08T07:51:45+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1985561102","fragment_type":"issue_comment","sequence":53,"text":"I can confirm the above.\nSince my last reload the Oncta integration is working now since 44 hours. I didn't do anything special during the reload.\nI have had no feedback from Daikin.","author_login":"Waling1961","author_association":"NONE","created_at":"2024-03-08T11:51:54+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1985671354","fragment_type":"issue_comment","sequence":54,"text":"Closing now again, looks something has changed somewhere which improved the behavior","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-08T13:10:50+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1986470633","fragment_type":"issue_comment","sequence":55,"text":"Still failing for me after 12 hours despite the refreshed logon process from Daikin :(","author_login":"sOckhamSter","author_association":"NONE","created_at":"2024-03-08T21:52:01+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1986796611","fragment_type":"issue_comment","sequence":56,"text":"Failed also ... and I had the new consent on the Daikin login page.","author_login":"arpel","author_association":"NONE","created_at":"2024-03-09T08:43:38+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1986827221","fragment_type":"issue_comment","sequence":57,"text":"Can you please clarify how you ended up with this order ? I also have the problem that my integration stops after 12 hours. \nIn my case the order is:\n1, Add integration to HA\n2. Oauth data is asked by HA\n3. Get credentials by logging into Daikin portal - just to be sure I logged out after copying (latest attempt, before I just stayed logged in)\n4. Enter Oauth data in HA\n5. Redirection by HA to Daikin to authorize the application\n6. Daikin: Authorize application\n\nSo in my case, I always have to enter the Oauth data in HA before authorize. Any idea why this order is different ? Could this be why it stops working after 12 hours ?","author_login":"XanderNijhuis","author_association":"NONE","created_at":"2024-03-09T11:09:05+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1987158495","fragment_type":"issue_comment","sequence":58,"text":"Here is the sequence of \"\" from configuration to failure :\n\n`2024-03-09 12:50:18.409 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Resumed OAuth configuration flow\n2024-03-09 12:50:18.432 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Creating config entry from external data\n2024-03-09 12:50:18.432 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Sending token request to URL \n2024-03-09 13:50:19.335 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Sending token request to URL \n2024-03-09 14:50:21.335 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Sending token request to URL \n2024-03-09 15:50:22.335 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Sending token request to URL \n2024-03-09 16:50:23.335 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Sending token request to URL \n2024-03-09 17:50:24.335 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Sending token request to URL \n2024-03-09 18:50:26.335 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Sending token request to URL \n2024-03-09 19:50:27.335 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Sending token request to URL \n2024-03-09 20:50:29.334 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Sending token request to URL \n2024-03-09 21:50:30.335 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Sending token request to URL \n2024-03-09 23:00:31.335 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Sending token request to URL \n2024-03-10 00:00:33.335 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Sending token request to URL \n2024-03-10 01:00:34.335 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Sending token request to URL \n2024-03-10 01:00:34.762 ERROR (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Token request for daikin_onecta_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.`\n\nIt seems that only the last request is actually granted with an answer which is \"invalid grant\", is it normal not to have \"replies\" logged for the various \"Sending token request to ...\" before that ?\n\nIs one hour the right setting for sending those ?","author_login":"arpel","author_association":"NONE","created_at":"2024-03-10T09:28:24+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1987181301","fragment_type":"issue_comment","sequence":59,"text":"Another thought (sorry ...), linked to #45 : I'm hosted locally and have a custom domain, accessible from outside, nevertheless, while authorizing the integration the only allowed callback is URL which is linked to a locally defined (local DNS entry) of URL and this _bounce_ is actually stored in the browser (visit directly URL to have it stated).\n\nWhat about the token refresh ? \nThey seem to be also using the redirect_uri, but as they are made out of the browser how could this work ?","author_login":"arpel","author_association":"NONE","created_at":"2024-03-10T10:46:06+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1987677705","fragment_type":"issue_comment","sequence":60,"text":"Finally got integration working for more than 12 hours. Difference is that now I did not go to the Daikin developer site to get the Oauth codes, but used the ones from the previous failed attempt which timed out after 12 hours. As a result, during the authentication, I had to log in - before, the Daikin site recognized me and skipped the login process and directly went to the approval.\n\nSo what worked for me:\n1, Add integration to HA\n2. Oauth data is asked by HA\n3. Enter Oauth data in HA\n4. Redirection by HA to Daikin to first log in and then authorize the application \n5. Daikin: Authorize application\n\nIf in step 4 you are not asked for your Daikin login/password, the token expires after 12 hours apparently.\nSo it is important to get your Oauth data before adding the integration and make sure the Daikin site does not recognize you in step 4 and skips the login process.","author_login":"XanderNijhuis","author_association":"NONE","created_at":"2024-03-11T05:49:55+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1987797731","fragment_type":"issue_comment","sequence":61,"text":"Ciao, same problem here since yesterday. And i was already using \"copy pasted\" Oauth data (i get outh data first time and copy pasted them into a notepad file). So in a certain way i was already following your procedure and yesterday morning i was still facing the token issue.\nBut yesterday at 1:00 PM i did again the procedure and at 10:00 PM i switched off my raspberry with home assistant .. today morning when i switched on I found the Daikin still connected. So, since we had both the connection working for more than 12 hours i suppose that is not our way of logging in but is just that someone fixed ... but again.. better to cross our fingers and I'm still waiting to look at other users feedback.","author_login":"sisco1983","author_association":"NONE","created_at":"2024-03-11T07:43:47+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1988374838","fragment_type":"issue_comment","sequence":62,"text":"I tried configuring the integration in the same way as people here mentioned before, but it seems that the Daikin Developer Portal is facing issues. I'm trying to log in from a fresh browser (private/incognito) window, but it is not working.\n\nNice for Daikin to remove the old 'API', without having the new API completely working","author_login":"SietseT","author_association":"NONE","created_at":"2024-03-11T12:53:43+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1988467550","fragment_type":"issue_comment","sequence":63,"text":"Try to contact Daikin, their contact details are on the Certification page of the developer portal.","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-11T13:39:44+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1988478530","fragment_type":"issue_comment","sequence":64,"text":"I can't even log in to the developer portal at the moment. I'm being redirected to the login page with this URL, indicating there is some kind of server error: URL","author_login":"SietseT","author_association":"NONE","created_at":"2024-03-11T13:44:38+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1990937972","fragment_type":"issue_comment","sequence":65,"text":"You think they care about their customers? That they are invested in providing a good product? No the only thing that counts is Money, euhrm, I mean Data ofcourse.\n\nIt's a big pile of bullshit. My daikin installation is the only one I truly regret buying","author_login":"tokke100","author_association":"NONE","created_at":"2024-03-12T07:24:43+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1990975079","fragment_type":"issue_comment","sequence":66,"text":"Yay! Working for more than 12 hours so far with the 'force logon' method. I grabbed the keys using one browser, then set up the HA integration with another which forced that process to ask for my credentials. Has been stable for almost 24 hours now which is the longest so far.","author_login":"sOckhamSter","author_association":"NONE","created_at":"2024-03-12T07:52:31+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1991076434","fragment_type":"issue_comment","sequence":67,"text":"I just noticed that Daikin has increased the minute rate limit from 6 to 20, you can find your limits at the bottom of the integration diagnostics","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-12T08:57:13+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1991335926","fragment_type":"issue_comment","sequence":68,"text":"This integration is driving me nuts. I followed the procedure as @jwillemsen described.\n\nMy 6 Daikin units work well for a few hours and then the next morning, I get again the dreaded \"400, Bad request\" message and none work.\nIf I then delete the integration, add it again, go again through the token authorization procedure, it works again... for a few hours.\nI have been through the thread and really don't get any wiser on how to solve this issue.\n\nThese are my settings :\n\nScreenshot 2024-03-12 11 37 21\n\nScreenshot 2024-03-12 11 37 00","author_login":"migueldc73","author_association":"NONE","created_at":"2024-03-12T10:41:08+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1991696715","fragment_type":"issue_comment","sequence":69,"text":"Exactly the same issue here. Auth error in less than 24h. Let's hope for a solution from Daikin soon as I rely on this connection on a daily basis.","author_login":"kimme1024","author_association":"NONE","created_at":"2024-03-12T13:48:53+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1991709908","fragment_type":"issue_comment","sequence":70,"text":"You should NEVER rely on a cloud-connection 🤓.\nIf you do rely on such connection I recommend using the LAN-Gateway and using the local connection for it - that's what I'm planning, I have the hardware already installed, just did not have any time to set it up in HA...","author_login":"chrfin","author_association":"NONE","created_at":"2024-03-12T13:55:16+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1991723473","fragment_type":"issue_comment","sequence":71,"text":"Maybe \"rely\" is a bit too much of a word but I use it daily to switch the units off when the windows are open to get fresh air into the bedrooms. Also I use it to set the correct temperature at certain hours of the day but that can be fixed by using the app as well...\nAnyway it would be way better if it'd just work again as my wife just doesn't check that the units are switched off when she opens the windows :)","author_login":"kimme1024","author_association":"NONE","created_at":"2024-03-12T14:01:23+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1991736344","fragment_type":"issue_comment","sequence":72,"text":"In any case, I also ordered 1x Faikin ESP32 module so I can test next week how the local API through the Faikin integration works.","author_login":"migueldc73","author_association":"NONE","created_at":"2024-03-12T14:07:11+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1993736245","fragment_type":"issue_comment","sequence":73,"text":"Something to try when it keeps failing after 12 hours. Try to logout from URL after you have copied the client id/secret (click on your email address in the upper right corner) and before you add the daikin_onecta integration.","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-13T07:38:08+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1994062809","fragment_type":"issue_comment","sequence":74,"text":"I have the same issue here. token is not valid after 12 hours.","author_login":"Logicsystem360","author_association":"NONE","created_at":"2024-03-13T10:32:08+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1995325327","fragment_type":"issue_comment","sequence":75,"text":"I have exactly the same issue. When I remove the integration and re-install it, it works again for only 12 hours unfortunately.","author_login":"krammie","author_association":"NONE","created_at":"2024-03-13T18:37:05+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1995987476","fragment_type":"issue_comment","sequence":76,"text":"Same issue here. Succesfully installed and configured the integration yesterday (coming from the daikin residential plugin), no more data coming in to HA since this morning. Reloading the integration gives a \"failed setup - will retry\" error","author_login":"RutgerBeyen","author_association":"NONE","created_at":"2024-03-13T22:17:13+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1996711495","fragment_type":"issue_comment","sequence":77,"text":"Ciao All,\nFirst of all please note that I'm a HA newcomer so far away from GOAT :-).\nAs you can see above, my integration is still working since Sunday at 13:00 (1:00 PM) but i've no clue why after 2 consecutive days having same \"12 hours\" issue my integration started working properly.\nHow can I understand why my integration is working so we can fins solution for all?\n\nI can only share again what i did differently:\n\n on Sunday at 13:00 I re-installed again the integration and since 12 hours were occurring at 1:00 in the night i switched off the Raspberry from 22:00 (3 hours before 12 hours expired) and i switched on Raspberry at 7:00 in the morning.\n \n So i tried to keep HA switched off at assumed 12 hours expiring time.. and from Monday (almost 4 days) integration is constantly working even if i keep raspberry switched on 24 hours or if i shut down it.\n \n Can someone try if this solution solve the problem ? Or can someone help me how to understand why my integration is working?\n Hoping this will support","author_login":"sisco1983","author_association":"NONE","created_at":"2024-03-14T07:15:13+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1996773098","fragment_type":"issue_comment","sequence":78,"text":"Same here, have setup the integration yesterday, but now I have the error The provided authorization code or refresh token is revoked.\n\nAnyone already have a solution?","author_login":"Tazmanian79","author_association":"NONE","created_at":"2024-03-14T07:59:23+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1997004952","fragment_type":"issue_comment","sequence":79,"text":"Same issue here, authentication stops after 12 hours and no new data is being transfered.","author_login":"landonmb","author_association":"NONE","created_at":"2024-03-14T09:25:03+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1997013534","fragment_type":"issue_comment","sequence":80,"text":"@Daikin-Europ is investigating this issue but until now they haven't found the reason why it fails. I have also checked all relevant Home Assistant code and can't find any reason why the token renew works for 12 hours and then fails.","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-14T09:29:45+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1997025263","fragment_type":"issue_comment","sequence":81,"text":"They f'd up, they had to have control over our data. That's what's wrong. Local API when?","author_login":"tokke100","author_association":"NONE","created_at":"2024-03-14T09:36:05+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1997036395","fragment_type":"issue_comment","sequence":82,"text":"This didn't work\n \n \n \n \n \n \n \n \n \n \n \n\nBut will try this tonight\n\nI still believe the Faikin local control would be the best solution, but it does not support the more advanced features like comfort airflow and streamer (yet)...","author_login":"migueldc73","author_association":"NONE","created_at":"2024-03-14T09:42:19+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1997258823","fragment_type":"issue_comment","sequence":83,"text":"@jwillemsen but the token is in fact not revoked, right? I'm trying to understand the issue. I checked the site where I copied the credentials from, and those do not seem to change/regenerate. So why does it start working again if the integration is reinstalled? And what changes in the API calls after 12 hours? Different answers start coming from the server?","author_login":"Gollam","author_association":"NONE","created_at":"2024-03-14T11:43:58+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1997281462","fragment_type":"issue_comment","sequence":84,"text":"You will get a (new)refresh token on each request which should be used in the next request. This token seems to be revoked\n\n_Token request for daikin_onecta failed (invalid_grant): The provided authorization code or refresh token is revoked._\n\n invalid_grant\n The provided authorization grant (e.g., authorization\n code, resource owner credentials) or refresh token is\n invalid, expired, revoked, does not match the redirection\n URI used in the authorization request, or was issued to\n another client.\n\nCould it be an timezone issue? seems to happen around night time.","author_login":"jeffreyr2","author_association":"NONE","created_at":"2024-03-14T11:58:26+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1997354405","fragment_type":"issue_comment","sequence":85,"text":"Does anyone else have issues even logging into the Developer Portal? After pressing the `Continue with SSO` button, I keep coming back to the same page.","author_login":"SietseT","author_association":"NONE","created_at":"2024-03-14T12:35:17+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1997384939","fragment_type":"issue_comment","sequence":86,"text":"Yes, I've tried multiple browsers and devices, clearing cookies and cache etc, but nothing works for me.","author_login":"SietseT","author_association":"NONE","created_at":"2024-03-14T12:49:33+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1997430962","fragment_type":"issue_comment","sequence":87,"text":"Maybe this helps. After retrying several times. I have copied the client ID + secret as suggested. And then used an incognito window to setup integration in HA and confirmed authentication on the Daikin Developer site.\nIntegration is now working for about 48h without any issues","author_login":"BjornHoorelbeke","author_association":"NONE","created_at":"2024-03-14T13:11:31+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1997498410","fragment_type":"issue_comment","sequence":88,"text":"@Tazmanian79 the token you have is invalid, the restart will not resolve it, you need to remove the integration, and add it again so that you get a new token from Daikin.","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-14T13:45:45+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1999095588","fragment_type":"issue_comment","sequence":89,"text":"The disabling of the refresh token rotation is now more than 12 hours ago, does it work for everyone now? Or do people still have problems after 12 hours?","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-15T07:40:09+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1999100884","fragment_type":"issue_comment","sequence":90,"text":"for me it broke again last night:\n2024-03-14 23:19:14.572 ERROR (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Token request for daikin_onecta_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.\n2024-03-14 23:19:14.572 ERROR (MainThread) [custom_components.daikin_onecta.coordinator] Error requesting daikin_onecta data: 400, message='Bad Request', url=URL(' URL \n\nbtw, i fixed the integration about at 13:00 yesterday afternoon, so it failed not after 12 hours but again around 23:00 like the day before(it was 23:04).","author_login":"jeffreyr2","author_association":"NONE","created_at":"2024-03-15T07:44:42+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1999106547","fragment_type":"issue_comment","sequence":91,"text":"If have deleted, and reinstalled everything yesterday afternoon. It was working but now again these errors:\n\n`Logger: custom_components.daikin_onecta.coordinator\nBron: helpers/update_coordinator.py:331\nintegratie: Daikin Onecta (documentation, issues)\nFirst occurred: 03:02:52 (1 gebeurtenissen)\nLaatst gelogd: 03:02:52\n\nError requesting daikin_onecta data: 400, message='Bad Request', url=URL(' URL \n\n`Logger: homeassistant.helpers.config_entry_oauth2_flow\nBron: helpers/config_entry_oauth2_flow.py:211\nFirst occurred: 03:02:52 (12 gebeurtenissen)\nLaatst gelogd: 08:32:52\n\nToken request for daikin_onecta_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.`","author_login":"Tazmanian79","author_association":"NONE","created_at":"2024-03-15T07:49:22+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1999117625","fragment_type":"issue_comment","sequence":92,"text":"My integration is still working .\n did someone tested my procedure? just to try to understand why mine is still working since 5 days.","author_login":"sisco1983","author_association":"NONE","created_at":"2024-03-15T07:58:19+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1999136055","fragment_type":"issue_comment","sequence":93,"text":"This morning, it refused again to connect, so whatever Daikin Europe did on their server didn't work out.\n\nLast night, I tried to install the freshly arrived Faikin. \nMade a cable with Dupont connectors, struggled 2hours to open the Emura 3 (screws are now hidden under very hard to find screw covers), only to find out the S21 connector on the Emura motherboard is smaller than Dupont, so had to order the Daikin EKRS21 cable.","author_login":"migueldc73","author_association":"NONE","created_at":"2024-03-15T08:12:19+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1999153585","fragment_type":"issue_comment","sequence":94,"text":"This didn't work for me.\nI reinstalled the integration last night and this morning it is no longer communicating.","author_login":"sherkan-666","author_association":"NONE","created_at":"2024-03-15T08:25:02+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1999208129","fragment_type":"issue_comment","sequence":95,"text":"2024-03-15 08:53:01.526 ERROR (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Token request for daikin_onecta_emuxxxx failed (invalid_grant): The provided authorization code or refresh token is revoked.\n2024-03-15 08:53:51.881 DEBUG (MainThread) [custom_components.daikin_onecta.daikin_api] Initialing Daikin Onecta API...\n2024-03-15 08:53:51.881 INFO (MainThread) [custom_components.daikin_onecta.daikin_api] Daikin Onecta API initialized.\n2024-03-15 08:53:52.064 ERROR (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Token request for daikin_onecta_emu20xxx failed (invalid_grant): The provided authorization code or refresh token is revoked.\n\nintegration suddenly stopped working :( do you guys have the same problem?","author_login":"ward0","author_association":"NONE","created_at":"2024-03-15T08:59:19+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1999224456","fragment_type":"issue_comment","sequence":96,"text":"Reinstalled the integration yesterday around 15:00h, stopped working last night with the first message appearing at 05:00\n\n2024-03-15 05:01:50.064 ERROR (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Token request for daikin_onecta_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.","author_login":"RutgerBeyen","author_association":"NONE","created_at":"2024-03-15T09:08:36+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1999340653","fragment_type":"issue_comment","sequence":97,"text":"Just tried this method, it's been more than 12 hours now and still working","author_login":"liquidv","author_association":"NONE","created_at":"2024-03-15T10:13:33+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1999350183","fragment_type":"issue_comment","sequence":98,"text":"Did you tried keeping switch off the system during the night ? if I'm not wrong you wrote that you were going to test my procedure","author_login":"sisco1983","author_association":"NONE","created_at":"2024-03-15T10:19:20+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1999353064","fragment_type":"issue_comment","sequence":99,"text":"Mine's been stable over 96 hours now since I used the 'different browsers' trick. It's even survived a reboot.","author_login":"sOckhamSter","author_association":"NONE","created_at":"2024-03-15T10:21:10+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1999362193","fragment_type":"issue_comment","sequence":100,"text":"Same here, after maybe 10 failed attempts where the integration stopped working due to the expiring token after 12 hours, it is now working for 6 days without any issue. Making sure the Daikin developer site did not recognize me and forced me to login (entering both username and password) via HA after I entered the Oauth codes, solved the problem for me. That is the only thing I changed compared to the failed attempts.","author_login":"XanderNijhuis","author_association":"NONE","created_at":"2024-03-15T10:26:30+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1999378483","fragment_type":"issue_comment","sequence":101,"text":"Mine still failing after 12 hours, even trying Chrome Incognito mode trick","author_login":"liquidv","author_association":"NONE","created_at":"2024-03-15T10:36:45+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1999381634","fragment_type":"issue_comment","sequence":102,"text":"Same for me, 4 days straight with a reboot (update of HA and this integration).","author_login":"arpel","author_association":"NONE","created_at":"2024-03-15T10:38:52+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1999518371","fragment_type":"issue_comment","sequence":103,"text":"I installed this integration yesterday evening and by midday today it had stopped working because of token issues... :-(","author_login":"matteustace","author_association":"NONE","created_at":"2024-03-15T12:04:36+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2000011224","fragment_type":"issue_comment","sequence":104,"text":"I don't see how turning it off at night is a solution, especially when we need our HA running 24/7 without interruption.","author_login":"liquidv","author_association":"NONE","created_at":"2024-03-15T16:22:40+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2000048140","fragment_type":"issue_comment","sequence":105,"text":"same here.. installed the integration yesterday and it worked. \nNow im getting \"The provided authorization code or refresh token is revoked.\"","author_login":"ryelle07","author_association":"NONE","created_at":"2024-03-15T16:43:15+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2000425387","fragment_type":"issue_comment","sequence":106,"text":"Just thinking it back I did something different during the last test : as we are using the \" URL redirect URL, I changed it to actually point (redirection stored in the browser) to my \"real\" FQDN (accessible from the internet) rather than the homeassistan.local local DNS entry (with which the first OAuth also works).\nI don't know if this is playing any role in subsequent OAuth token requests from HA ...","author_login":"arpel","author_association":"NONE","created_at":"2024-03-15T20:52:53+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2000479647","fragment_type":"issue_comment","sequence":107,"text":"Same error again tonight, exactly 12hrs after reinstalling the plugin this morning. Will try the browser-incognito mode next...","author_login":"RutgerBeyen","author_association":"NONE","created_at":"2024-03-15T21:38:18+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2001888437","fragment_type":"issue_comment","sequence":108,"text":"Ok, tonight it seemed to survive after new integration setup with incognito browser.","author_login":"jeffreyr2","author_association":"NONE","created_at":"2024-03-16T07:21:48+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2001889183","fragment_type":"issue_comment","sequence":109,"text":"Hmmm, I did something similar.\nI had the 12hour bug. But was remotely connected through vpn. So I changed from homeassistant.local to the actual local IP. And it has been working since 3 days now","author_login":"tokke100","author_association":"NONE","created_at":"2024-03-16T07:24:01+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2001928421","fragment_type":"issue_comment","sequence":110,"text":"It looks like Daikin is working hard on their devportal. I have the most problems with logging into the portal. Now, after 12h bug, I removed the integration and tried to add it again, but I'm stuck on the Daikin \"Proxy\" redirect page and I can't add integration to HA. I hope they fix it as soon as possible.","author_login":"tomasbarton-com","author_association":"NONE","created_at":"2024-03-16T09:35:58+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2002352119","fragment_type":"issue_comment","sequence":111,"text":"Maybe this debuglogging helps?\n`2024-03-16 06:10:52.182 ERROR (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Token request for daikin_onecta_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.\n2024-03-16 06:10:52.183 ERROR (MainThread) [custom_components.daikin_onecta.coordinator] Error requesting daikin_onecta data: 400, message='Bad Request', url=URL(' URL \n2024-03-16 06:40:52.195 ERROR (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Token request for daikin_onecta_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.\n2024-03-16 07:10:52.204 ERROR (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Token request for daikin_onecta_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.\n2024-03-16 07:40:52.171 ERROR (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Token request for daikin_onecta_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.\n`","author_login":"ridderr","author_association":"NONE","created_at":"2024-03-17T08:00:21+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2002372096","fragment_type":"issue_comment","sequence":112,"text":"I run also on the \"12 hours bug\" I tried removal a add it again but this gave me only a new set of 12 hours alive:\nI have HAOS updated up to yesterday 17 march. I wonder if the máximum call rate limits protection indicated in Daikin web: 200 per day 20 per mimute, activate removal of token grants. \nI have two units and ignore if two units generate double number of calls to the Daikin cloud and makes the situation harder. The temporay fix of switching off by night points in this direction since helps to maintain a lower \"call rate\".\nIs there a way to decrease the integration call rate to Daikin cloud?","author_login":"ALAMILLA1","author_association":"NONE","created_at":"2024-03-17T09:06:13+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2002372578","fragment_type":"issue_comment","sequence":113,"text":"I've added the integration yesterday, unfortunately I've also stumbled on this issue. \nFor now I've deleted the integration and re-added the integration with making a slight change after reading these comments. \n\nThe first time around I've used my public HTTPS URL with DNS name to set it up.\nThis time I've used my internal HTTP URL with local IP address, to see if this will make any difference to the token renewal. \n\nI'll update again later to let everyone know what the results are.","author_login":"JacquesRodrigues","author_association":"NONE","created_at":"2024-03-17T09:07:36+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2002373025","fragment_type":"issue_comment","sequence":114,"text":"See the configure button of the daikin integration, you can configure the polling settings, see also the readme","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-17T09:09:05+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2002377106","fragment_type":"issue_comment","sequence":115,"text":"I tried this, both breaks after 12 hours\n\nOn Sun, 17 Mar 2024, 09:08 JacquesRodrigues, ***@***.***>\nwrote:","author_login":"liquidv","author_association":"NONE","created_at":"2024-03-17T09:23:25+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[2139900425],"is_known_query_context":false},{"document_id":"gh_comment_2002394101","fragment_type":"issue_comment","sequence":116,"text":"Yesterday I added the integration by remote url and in incognito browser but the integration is broken again, so this doesn't make any difference for me.","author_login":"Tazmanian79","author_association":"NONE","created_at":"2024-03-17T10:16:07+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2002403505","fragment_type":"issue_comment","sequence":117,"text":"Same issue for me. Broke twice now after 12h. First time I reinstalled and entered auth again.","author_login":"kimchiii0411","author_association":"NONE","created_at":"2024-03-17T10:45:23+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2002468154","fragment_type":"issue_comment","sequence":118,"text":"I am stil on version 3.4.0 (and that's not working anymore). Clicking in HACS/integrations on the daikin tile I am redirected to \"Daikin Residential including Altherma 3 Heat Pump\" site on github\n\nTried to update to 4.0.15. That still does not work (link to diakin auth does not show up). \nTries also to delete the whole integration and start all over, but that also did not bring me to de diakin-site for auth.\n\nWhen I click on the tile in HACS/integrations after install/update tot 4.0.15, I will be directed to \"daikin onecta\" in stead of \"Daikin Residential including Altherma 3 Heat Pump\". \nEarlier I learned that I need the \"including Altherna\" version. Is that still needed on 4.0.15? If so: how do I get that.\n\nBTW: I manage HS to control the daikin now via google assistant. Setting things works, reading things not so far. So kind of first aid solution. Using the integration is much better.","author_login":"brinkgit","author_association":"NONE","created_at":"2024-03-17T13:23:38+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2002504544","fragment_type":"issue_comment","sequence":119,"text":"I can't even add the devices back in now HA, only get this with nothing else\n\nimage","author_login":"liquidv","author_association":"NONE","created_at":"2024-03-17T15:13:13+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2002514938","fragment_type":"issue_comment","sequence":120,"text":"Remove the integration including application credentials, remove the custom code from disk, reboot, and try to install it again","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-17T15:47:01+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2003484195","fragment_type":"issue_comment","sequence":121,"text":"I also did by FQDN and incognito but it broke also after 12h.","author_login":"Tazmanian79","author_association":"NONE","created_at":"2024-03-18T10:20:48+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2003484532","fragment_type":"issue_comment","sequence":122,"text":"Well, interesting update.. last night it broke and I quickly deleted the integration and re-added the integration via Mobile phone.. due to me wanting to go to bed and the AC's needed to be turned off. \n\nWhen I added via Mobile, I did not get to choose which URL was used.. it was a quick next, next, finish kinda thing.. now however I'm passed the first 12 hour mark.. and it still works without issues. \n\nKinda happy about that is works, little annoyed that I don't know why.","author_login":"JacquesRodrigues","author_association":"NONE","created_at":"2024-03-18T10:20:56+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2003515332","fragment_type":"issue_comment","sequence":123,"text":"Mine is still working after 3 days, used the incognito trick with local ip. It even survived some HA reboots (for a different reason).\nOnly thing I see now with the ratelimit value available in HA is that my counter doesn't get reset to 200 every 24hrs. It rather increases during periods of low polling and slowly depletes during high polling. Anybody else has this ?","author_login":"RutgerBeyen","author_association":"NONE","created_at":"2024-03-18T10:29:48+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2003518577","fragment_type":"issue_comment","sequence":124,"text":"Used no incognito but is now working for almost 20 hours withpout issue. Not using local ip.","author_login":"brinkgit","author_association":"NONE","created_at":"2024-03-18T10:30:43+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2003538873","fragment_type":"issue_comment","sequence":125,"text":"Surely this can't be a browser issue?\nEven tried using Edge and still doesnt' work","author_login":"liquidv","author_association":"NONE","created_at":"2024-03-18T10:36:35+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2003595419","fragment_type":"issue_comment","sequence":126,"text":"Reinstalled after losing one heatpump after 12 hours. Will see how long it works with the temp keys.","author_login":"fransh47","author_association":"NONE","created_at":"2024-03-18T10:54:58+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2003641140","fragment_type":"issue_comment","sequence":127,"text":"I have removed everything and copy again the integration with the same result. Error in authentication, the integration does not install","author_login":"jrevuelta-pleiades","author_association":"NONE","created_at":"2024-03-18T11:17:06+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2003710874","fragment_type":"issue_comment","sequence":128,"text":"The limit works with a 24 hours moving window, not with counter reset at fixed time.\nSee URL","author_login":"Mark-64","author_association":"NONE","created_at":"2024-03-18T11:52:44+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2003725407","fragment_type":"issue_comment","sequence":129,"text":"This happen to me too.\nTurned out to be that the API limit was grossly exceeded with all my attempts and I was sort of temporarily banned. I had to wait one full day and then the integration succeeded installing and now it is running stable since few days already.\nPlease check \"retry after\" parameter in the API JSON reply","author_login":"Mark-64","author_association":"NONE","created_at":"2024-03-18T12:00:17+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2003728298","fragment_type":"issue_comment","sequence":130,"text":"All limit values are available as diagnostics sensor as part of the daikin devices, no need anymore to check the json","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-18T12:01:47+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2003856364","fragment_type":"issue_comment","sequence":131,"text":"I tested the intall from differents browsers Edge, Chrome and Firefox, also tested incognito mode, with mail/password and tokens always with the same result: the integration fail to install.\nMy sw releases are:\nCore 2024.3.1\nSupervisor 2024.03.0\nOperating System 12.1\nFrontend 20240307.0","author_login":"jrevuelta-pleiades","author_association":"NONE","created_at":"2024-03-18T13:04:52+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2003917206","fragment_type":"issue_comment","sequence":132,"text":"Pls check in the integration dignostic if you have not exceeded the daily API quota.\nIf you did, please wait at least one day and try again, multiple attempts will only make things worse.\nSee API documentation\nimmagine","author_login":"Mark-64","author_association":"NONE","created_at":"2024-03-18T13:32:46+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2004275219","fragment_type":"issue_comment","sequence":133,"text":"Strange, I don't see any limit value as diagnostics sensors. If I download diagnostic data as json and search for 'limit' or 'rate' there is not hit.\nIs there any place else where the limits can be found?\n\nThings work fine, more than 24 hours after update. The integration is named in the HS Integration page \"Daikin Residential Controller including Altherma\" as it was before update.","author_login":"brinkgit","author_association":"NONE","created_at":"2024-03-18T15:46:07+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2004285053","fragment_type":"issue_comment","sequence":134,"text":"You have the old integration, you need to use URL and at least the v4.0.14 release.","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-18T15:48:38+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2004299311","fragment_type":"issue_comment","sequence":135,"text":"But all things work fine, HACS shows version 4.0.15. Is an update needed then, or can I let it go and see when this stuck?","author_login":"brinkgit","author_association":"NONE","created_at":"2024-03-18T15:52:55+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2004303765","fragment_type":"issue_comment","sequence":136,"text":"The integration page should show \"Daikin Onecta\". Please attach your integration diagnostics here","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-18T15:54:21+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2004306070","fragment_type":"issue_comment","sequence":137,"text":"config_entry-daikin_residential_altherma-1eebccb4fb1daf3dc960a7bb243caabb.json","author_login":"brinkgit","author_association":"NONE","created_at":"2024-03-18T15:55:21+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2004312091","fragment_type":"issue_comment","sequence":138,"text":"You are using \"daikin_residential_altherma\", remove first \"daikin_residential_altherma\", \"daikin_residential\", and \"daikin_onecta\" from the integrations page, remove the code for them from disk, reboot HA, and add \"daikin_onecta\" again","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-18T15:57:31+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2004312833","fragment_type":"issue_comment","sequence":139,"text":"How come it works again. Day before yesterday I got code 400, then did update, started up daikin developper thing and then it worked again. No problem so far, more than 24 hours after the update.","author_login":"brinkgit","author_association":"NONE","created_at":"2024-03-18T15:57:50+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2004315404","fragment_type":"issue_comment","sequence":140,"text":"Maybe Daikin changed something for the old API, you are using that. Btw, change your daikin password, this was listed plain text in your json (which I just removed)","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-18T15:58:58+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2004516874","fragment_type":"issue_comment","sequence":141,"text":"May be the inegration setup fails because I am using the Daikin Onecta skill with my Amazon Echo Dot? Is it posssible to have Home assistant inegration and Alexa skill at the same time?","author_login":"jrevuelta-pleiades","author_association":"NONE","created_at":"2024-03-18T17:23:58+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2005017737","fragment_type":"issue_comment","sequence":142,"text":"I reínstalled onecta more than 36 hours ago, my approach to keep it going has been to switch off the integration when i dont need it, in the morning and at night. And also I lowered to the minimum the call rate. So far is working","author_login":"ALAMILLA1","author_association":"NONE","created_at":"2024-03-18T21:23:54+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2005039242","fragment_type":"issue_comment","sequence":143,"text":"2024-03-18 22:08:43.952 INFO (MainThread) [custom_components.daikin_onecta.daikin_api] Daikin Onecta API initialized.\n2024-03-18 22:08:43.952 DEBUG (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Sending token request to URL \n2024-03-18 22:08:44.159 ERROR (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Token request for daikin_onecta_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.\n\nI am encountering the same issues. It has been approximately 12 hours since setting up the integration. Just now, I restarted HAOS and then encountered the issue. It is possible though that the issue appeared previously already.","author_login":"cstmth","author_association":"NONE","created_at":"2024-03-18T21:29:26+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2005040813","fragment_type":"issue_comment","sequence":144,"text":"Am I understanding correctly that there is no confirmed workaround to this?","author_login":"cstmth","author_association":"NONE","created_at":"2024-03-18T21:29:53+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2005859966","fragment_type":"issue_comment","sequence":145,"text":"Just a heads up: Wenn i try to login into the daikin dev are, i receive this message:\nimage\n\nFurther: I´ve registered a new user with different Email Adress. After Login, i got the same message. Seems there´s something broken @Daikin´s Dev area.","author_login":"PapaErde","author_association":"NONE","created_at":"2024-03-19T06:11:17+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2006098851","fragment_type":"issue_comment","sequence":146,"text":"Same as yesterday. Kicked out after around 12 hours. \nScherm­afbeelding 2024-03-19 om 08 26 25\nWill wait for a couple of days till this issue with the Daikin server is solved; not in the mood the reinstall the integration every thelve hours.\nScherm­afbeelding 2024-03-19 om 08 30 37","author_login":"fransh47","author_association":"NONE","created_at":"2024-03-19T07:31:26+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2006116872","fragment_type":"issue_comment","sequence":147,"text":"Mine appears to be still working after 12 hours using my FQDN instead of local IP, however this is the second time I've tried it so there isn't any difference from the first time it failed. My assumption is this doesn't make a difference.\n\nI assume Daikin must be doing something at their end manually in batches for it to work for certain people, until they get around to everyone.","author_login":"liquidv","author_association":"NONE","created_at":"2024-03-19T07:36:50+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2006466125","fragment_type":"issue_comment","sequence":148,"text":"I included the ip address but no change. Same issue with FQDN.","author_login":"fransh47","author_association":"NONE","created_at":"2024-03-19T09:21:52+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2006705340","fragment_type":"issue_comment","sequence":149,"text":"2024-03-18 23:01:54.607 DEBUG (MainThread) [custom_components.daikin_onecta.water_heater] Device 'Verwarming AD' hot water tank supports modes ['off', 'heat_pump']\n2024-03-18 23:01:54.607 DEBUG (MainThread) [custom_components.daikin_onecta.water_heater] Device 'Verwarming AD' hot water tank current mode 'off'\n2024-03-18 23:06:34.213 ERROR (MainThread) [homeassistant.components.shelly] Error fetching AD Verwarming Aan/uit data: Error fetching data: DeviceConnectionError()\n2024-03-18 23:16:20.874 WARNING (MainThread) [dsmr_parser.clients.protocol] keep-alive check failed\n2024-03-18 23:28:11.205 ERROR (MainThread) [homeassistant.components.shelly] Error fetching AD Verwarming Aan/uit data: Error fetching data: DeviceConnectionError()\n2024-03-18 23:31:54.351 DEBUG (MainThread) [custom_components.daikin_onecta.coordinator] Daikin coordinator start _async_update_data.\n2024-03-18 23:31:54.737 ERROR (MainThread) [homeassistant.helpers.config_entry_oauth2_flow] Token request for daikin_onecta_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.\n\nJust some lines around the time the error started.","author_login":"fransh47","author_association":"NONE","created_at":"2024-03-19T10:20:59+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2006943749","fragment_type":"issue_comment","sequence":150,"text":"Is there anyone subscribed to this issue which has a Altherma with a hot water tank which doesn't provide a current temperature to HA. Someone reported an issue with such a hot water tank in the past and I added some support for it, but now looking for the integration json so that I can add it to the unit tests I am working on","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-19T11:32:56+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2006976602","fragment_type":"issue_comment","sequence":151,"text":"If this helps? See below but it is clear that the disconnect occurs at the same time. \nScherm­afbeelding 2024-03-19 om 12 47 03","author_login":"fransh47","author_association":"NONE","created_at":"2024-03-19T11:49:28+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2007332454","fragment_type":"issue_comment","sequence":152,"text":"I have a water tank, temperature is reported well. The ability to set the temperature, however, is not available. Hope this can be added so I can manage the heating depending on solar power.","author_login":"XanderNijhuis","author_association":"NONE","created_at":"2024-03-19T14:28:38+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2007335797","fragment_type":"issue_comment","sequence":153,"text":"Setting the tank temperature should be possible, can you do it from the onecta app? I can control it here, could be that you have some setting in the device itself preventing it?","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-19T14:30:08+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2007445127","fragment_type":"issue_comment","sequence":154,"text":"I can set the temperature in the ONECTA app. In the HA integration it is not present as a control. Only set points I have are for the room temperature and the leaving water offset temperature.","author_login":"XanderNijhuis","author_association":"NONE","created_at":"2024-03-19T15:07:54+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2007455219","fragment_type":"issue_comment","sequence":155,"text":"@XanderNijhuis please open an issue with the integration diagnostics and a debug log so that I can check why it doesn’t work","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-19T15:11:37+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2007602728","fragment_type":"issue_comment","sequence":156,"text":"An update, it's stlll up and running for more than 12 hours. I installed the latest release and did a new autothorisation at the Daikin site. I notice during the registration at Daikin it was adressing to my internal ip/port and not the external exposed interface on my router. \nSo two changes, but it is still working :-)","author_login":"ridderr","author_association":"NONE","created_at":"2024-03-19T16:15:28+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2008856463","fragment_type":"issue_comment","sequence":157,"text":"Token request for daikin_onecta_XXXXXX failed (invalid_grant): The provided authorization code or refresh token is revoked.\n400, message='Bad Request', url=URL(' URL \n\nSame here :-(\n\nit is really cheeky of @Daikin-Europe to unleash something like this on the users and simply switch off the old interface.\nI paid so much money for my system and nothing works anymore!\nThe support from Daikin is also just bad, this will definitely be my last system from Daikin.","author_login":"mbay0r","author_association":"NONE","created_at":"2024-03-20T07:01:47+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2008934332","fragment_type":"issue_comment","sequence":158,"text":"What old interface? There was no official API util now...\nOr do you mean the local-API of the old devices? (and even that was no official AFAIK)","author_login":"chrfin","author_association":"NONE","created_at":"2024-03-20T07:20:00+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2008951106","fragment_type":"issue_comment","sequence":159,"text":"Then just the ability to send HTTP commands to the cloud.\n\nDaikin simply threw a new API onto the market, touted it as great news, allowed far too few requests, made all previously available integrations unusable and now nothing works at all.\n\nAnd then their support doesn't even work, a disgrace.","author_login":"mbay0r","author_association":"NONE","created_at":"2024-03-20T07:34:03+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2008963119","fragment_type":"issue_comment","sequence":160,"text":"So I tried.\n\nRemote URL and incognito.\nLocal IP.\n\nAll breaks after 12h","author_login":"Tazmanian79","author_association":"NONE","created_at":"2024-03-20T07:44:04+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2008980291","fragment_type":"issue_comment","sequence":161,"text":"After the first few days of breaking after 12 hours, mine appears to be finally stable now with 2+ days going strong.\nOnly thing I did was change it to my FQDN name opposed to the local IP, did not use Incognito mode.\n\nI believe it is something Daikin are fixing on their end in batches, nothing we can do on ourside until then.","author_login":"liquidv","author_association":"NONE","created_at":"2024-03-20T07:58:29+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2009033723","fragment_type":"issue_comment","sequence":162,"text":"I have the same experience. 3 days with 12h bug. Now the connection is stable for more than 36 hours. No special settings, no incognito mode, local IP. For others, the only option is to wait for Daikin to fix users accounts on their end. \n\nBtw: Daikin products have a very good reputation, but this is a big fail. Decision to stop the previous API and not release a functional replacement. I don't understand.","author_login":"tomasbarton-com","author_association":"NONE","created_at":"2024-03-20T08:36:45+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2009044590","fragment_type":"issue_comment","sequence":163,"text":"Around the 12 hours bug, I found building an automation that a service called: ´Daikin Onecta: Reload' is available\nAccording to the text provided the action performed by this service is:\n Retrieve new access TokenSet by logging in again to Daikin Cloud.\n\nWhen is supposed to be used this service? Is it a way to solve the \"12 hours\" revoked token situation?","author_login":"ALAMILLA1","author_association":"NONE","created_at":"2024-03-20T08:44:08+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2011609244","fragment_type":"issue_comment","sequence":164,"text":"I just want to state that after maybe the 10th time of re-adding the integration, it is now running for 24 hours. I did not do any incognito window tricks.","author_login":"Gollam","author_association":"NONE","created_at":"2024-03-21T08:18:32+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2011669709","fragment_type":"issue_comment","sequence":165,"text":"Same here. After I reinstalled yesterday, now still up and running. Must have been an Daikin fault.","author_login":"MeJebus","author_association":"NONE","created_at":"2024-03-21T08:55:07+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2014516003","fragment_type":"issue_comment","sequence":166,"text":"Mine failed again after 12 hours, so I was trying to connect the Faikin ESP32 module with local API, but it seems my Emura 3 has a different S21 connector than the one indicated on the Faikin main page \n \n\nThe connector on my Emura 3 board is clearly smaller with probably 1.5 or 2mm pitch, still 5 way though.\n\n247945450-99f36b85-2d08-4d3e-a90a-7216cb1714fb\n\nMaybe this is not the right thread for it, but I am sure many other users are as desperate as myself trying to get a local API working.","author_login":"migueldc73","author_association":"NONE","created_at":"2024-03-22T07:40:16+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2014608248","fragment_type":"issue_comment","sequence":167,"text":"Just jumping in here to get updates. Currently also seeing the 12hr breakage with a 400 Bad Request error. I scanned through the hundreds of comments, but can't see any definitive workaround or solution, but will keep my eye out. \n<img width=\"1061\" alt=\"Screenshot 2024-03-21 at 12 15 48\" src=\" URL","author_login":"Webreaper","author_association":"NONE","created_at":"2024-03-22T08:33:00+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2014751827","fragment_type":"issue_comment","sequence":168,"text":"Maybe a kind of workaround: \nI am still using the old integration without any problems (Daikin Residential Controller including Altherma). After one time a 400 error, reinstall the old integration, created an account on the Daikin Developer Portal, and activated the connection there. Since then no problem anymore so far.","author_login":"brinkgit","author_association":"NONE","created_at":"2024-03-22T10:05:27+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2014847017","fragment_type":"issue_comment","sequence":169,"text":"Daikin drives me nuts :) Can you help to see if I'm wrong? I'm using the credentials from this page: URL \n\nOr is there a way to generate a more permanent set of credentials?\n\nAPI Credentials\n\nTo access the ONECTA Cloud API and ensure secure authorization, you'll need to create an application through this developer portal. While the functionality to request credentials for your application is not yet available, we are actively working on enhancing our developer portal to accommodate this feature of self-service in the near future. Self-service will allow you to create an application with a name, description and redirect URI you can specify yourself.\n\nTo provide you with a temporary solution, you can utilize the following credentials for authorization:\n\nclientId: \"xx\"\nclientSecret: \"xxx\"\n\nCopy\nThese credentials require the use of onectaintegration://callback/ as redirect URI in the authorization flow.\n\n⚠️Please Note: These temporary credentials will have a limited lifespan and are expected to be deprecated by Spring 2024. The deprecation will occur once we introduce the creation of applications through the developer portal, allowing every developer to register their own application and obtain their own credentials. A specific date for revocation of the temporary credentials will be shared later.","author_login":"Marcel030nl","author_association":"NONE","created_at":"2024-03-22T11:02:47+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2014847373","fragment_type":"issue_comment","sequence":170,"text":"I removed the integration as I did several times before. But now I can't add it anymore.\n\nI have the screen to enter the Daikin API codes all going good. But when I link it to my account I have only this screen.\n\nSchermafbeelding 2024-03-22 120123\n\nNormally that should be the screen where I can see my Daikin units and add them to the correct room. But now it's empty.\n\nTried it again but always the same.\nI removed the integration completely but no change. Also I do not get the screen anymore where I need to add the API codes, it's goes straight to the Daikin SSO site.","author_login":"Tazmanian79","author_association":"NONE","created_at":"2024-03-22T11:02:59+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2014850570","fragment_type":"issue_comment","sequence":171,"text":"@Marcel030nl We have to wait on Daikin\n\n@Tazmanian79 Have you removed the old credentials, see for how to see which credentials you have, you can remove them from there","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-22T11:05:01+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2014851803","fragment_type":"issue_comment","sequence":172,"text":"@Marcel030nl that's what we all use. After 12 hours, it expires, delete the integration and re-add. Repeat until it suddenly goes longer than 12 hours.","author_login":"Gollam","author_association":"NONE","created_at":"2024-03-22T11:05:50+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2014855246","fragment_type":"issue_comment","sequence":173,"text":"Thank you so much for the quick replies. And I'm on your team then @Gollam, the every 12h delete and re-add the integration.. :D :D","author_login":"Marcel030nl","author_association":"NONE","created_at":"2024-03-22T11:08:07+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2014872023","fragment_type":"issue_comment","sequence":174,"text":"@jwillemsen yes that did the trick. Thanks for you help and i'm good again for 12h :-)","author_login":"Tazmanian79","author_association":"NONE","created_at":"2024-03-22T11:19:03+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2015088548","fragment_type":"issue_comment","sequence":175,"text":"Although ESPALtherma can do much better (this is the other HP):\n\nScherm­afbeelding 2024-03-22 om 14 19 26","author_login":"fransh47","author_association":"NONE","created_at":"2024-03-22T13:20:47+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2015227181","fragment_type":"issue_comment","sequence":176,"text":"Update. Mine now just works. Didn't do anything new, Just readded it. Now it didn't break. Added it yesterday evening. It's on 16+ hours atm.","author_login":"kimchiii0411","author_association":"NONE","created_at":"2024-03-22T14:29:04+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2015636453","fragment_type":"issue_comment","sequence":177,"text":"Still working here for some days now. The only thing I changed was after the sw update to specify the external HA port which should be accessable by Daikin. I'm reading that some people are using the internal IP address but this is causing the issues (I think)","author_login":"ridderr","author_association":"NONE","created_at":"2024-03-22T18:01:37+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2015941717","fragment_type":"issue_comment","sequence":178,"text":"Expired here 2 times already, no improvement.\n\nI have written an email to Daikin, no reply, really unbelievable.","author_login":"mbay0r","author_association":"NONE","created_at":"2024-03-22T21:18:07+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2016463101","fragment_type":"issue_comment","sequence":179,"text":"I don't know, but mine configuration/setup is still woking. Ones I notices it was at the Daikin site refering to an internal link (home network) and I changed that to the external network (via https), it is running for many days.","author_login":"ridderr","author_association":"NONE","created_at":"2024-03-23T11:37:25+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2016463618","fragment_type":"issue_comment","sequence":180,"text":"Must have to do with the id and secret being shared as temp fix; there may be a limit the number of requests from different IP addresses that the server can handle. Mine is up and running voor 50 hours now after several reinstalls.","author_login":"fransh47","author_association":"NONE","created_at":"2024-03-23T11:38:59+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2016484273","fragment_type":"issue_comment","sequence":181,"text":"I was not so lucky, had to remove and add it again to get it working. I'm almost at the point to automate it.. Do we have a contact at Daikin which we can reach out to?","author_login":"Marcel030nl","author_association":"NONE","created_at":"2024-03-23T12:47:25+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2016497963","fragment_type":"issue_comment","sequence":182,"text":"Of course they are. They got us locked in, they got our data. That was the goal. If they cared, a local api would have been made available. Fucking cloud shit. It's MY data, MY electricity, MY control. So why do I need THEIR servers","author_login":"tokke100","author_association":"NONE","created_at":"2024-03-23T13:38:07+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2016511288","fragment_type":"issue_comment","sequence":183,"text":"Eh? They always had the data. It got sent to their cloud regardless of the local API being available.\n\nThis isn't nefarious, it's just incompetence.","author_login":"Webreaper","author_association":"NONE","created_at":"2024-03-23T14:33:24+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2016729834","fragment_type":"issue_comment","sequence":184,"text":"old [Daikin Residential for Altherma 3] started working again, and this one new [Daikin Onecta] gets rejected on every 12h. If you reload, it will work for another 12hours.\ndaikin temporary enabled old api, while this new one are not stable?","author_login":"bugac","author_association":"NONE","created_at":"2024-03-24T08:10:14+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2016828219","fragment_type":"issue_comment","sequence":185,"text":"😂😂\n\nUnbelievable, what an indictment and then not even communicated.","author_login":"mbay0r","author_association":"NONE","created_at":"2024-03-24T14:30:28+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2016876689","fragment_type":"issue_comment","sequence":186,"text":"Same issue still happening today\n\nLogger: homeassistant.helpers.config_entry_oauth2_flow\nSource: helpers/config_entry_oauth2_flow.py:211\nFirst occurred: 6:09:36 PM (3 occurrences)\nLast logged: 6:09:49 PM\n\nToken request for daikin_onecta_emu20 failed (invalid_grant): The provided authorization code or refresh token is revoked.\n\nIt's also not clear how to force regenerate the token, the UI doesn't provide any way to delete / recreate it.\nI am using version 4.0.21 (updated today) using all latest HA (no new update for today).\n\nCore 2024.3.3\nSupervisor 2024.03.0\nOperating System 12.1\nFrontend 20240307.0","author_login":"tyge68","author_association":"NONE","created_at":"2024-03-24T17:18:05+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2016879450","fragment_type":"issue_comment","sequence":187,"text":"known problem, just wait while daikin will make its own homework","author_login":"bugac","author_association":"NONE","created_at":"2024-03-24T17:28:53+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2016913396","fragment_type":"issue_comment","sequence":188,"text":"To force regenerate, you have to remove the integration, including the access credentials, then re-add everything.","author_login":"Gollam","author_association":"NONE","created_at":"2024-03-24T19:22:24+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2016932230","fragment_type":"issue_comment","sequence":189,"text":"It's great to see such a successful and confidence-inspiring launch of the new APIs and developer portal from Daikin. Good job guys! 🤦‍♂️","author_login":"Webreaper","author_association":"NONE","created_at":"2024-03-24T20:21:26+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2016984546","fragment_type":"issue_comment","sequence":190,"text":"Same here. Through reverse proxy and my WAN domain name. About 12hours up then it is a broken token. I'm not exposing my internal port for Daikin like someone says here to fix. NO WAY. \nNever EVER i buy a DAIKIN thing in my house again. This is the 3rd time for my Daikin changing control over the AC. From local IP control to residential to this. I have a other Chinese Tuya connected AC. Only 1 time it needed a hard reset in 4 years and i can local connect it if i want. \nInteresting note i saw in HA logs was that my token was all lower case when i got an error. Can it be something that HA/daikin_onecta changing upper case to lower case?","author_login":"james-1987","author_association":"NONE","created_at":"2024-03-24T23:19:04+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017409302","fragment_type":"issue_comment","sequence":191,"text":"Maybe someone where the token renew fails and who has some python experience can patch helpers/config_entry_oauth2_flow.py:211 locally and add some logging of the access and refresh token before and after just to validate that HA doesn't change the token. All oauth2 support is generic HA support, nothing special in the daikin_onecta integration","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-25T07:53:17+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017555169","fragment_type":"issue_comment","sequence":192,"text":"Daikin is aware of reports regarding refresh token expiration after 12 hours, impacting 3rd party integrations. Some users may encounter a \"400 Bad Request\" response when refreshing their access token. We're actively investigating with our IT department for a solution. Stay updated on URL \n\nWe appreciate your patience as we work to ensure the ONECTA API meets user expectations. Thank you for your understanding.","author_login":"Daikin-Europe","author_association":"NONE","created_at":"2024-03-25T09:24:53+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017827007","fragment_type":"issue_comment","sequence":193,"text":"I suspect that at least in some cases the 12 hour bug is related to the rate limit. Currently I have it working without stop for 4 days.\n I did two things:\nReduce the high rate polling to 20 minute Reduce the low rate to 60 minutes\nInclude in the dashboard the sensor: \"sensor.your_device_name_ratelimit_remaing_day\"\n\nI obtained from HA above sensor graphic :\ncall remaining\n\nYou may see that during the day, every day the \"remaining call available is decreasing\" with the 20 minutes set up ¡3 CALLS PER HOUR! during the night I recover remaining calls expending just 1 call per hour.\n\nI realized that on top of this is neccesary to add the daily calls for each request to start and stop the units. (6 calls per day in theory).\n\nMy needs for \"call requests\" are limited and repetitive currently for testing purposes. I only have an automated start and stop per day for two units.\n\nThe graphic above does not show fully repetitive pattern for every day despite I do the same things everyday. It seems that something beyond 24 hours is part of the calculation. I tried to understand better how is supposed to work and I found in the DAIKIN ONECTA Cloud API documentation> \"GENERAL API GUIDELINES\" (available in the DAIKIN developper cloud repository). A reference to the rules used as referenced in:\n URL \nThese rules talk about \"Dynamic limits and throttling the rates\" which I am afraid Daikin is using and makes difficult to predict how this simple rule of \"200 calls per day\" is going to behave in each particular case.\n\nBtw I suspect that simply opening ONECTA with the phone adds also 1 call.\n\nIt will be helpful to have more information from DAIKIN on how this seemingly simple rule is actually applied.","author_login":"ALAMILLA1","author_association":"NONE","created_at":"2024-03-25T11:49:24+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017840107","fragment_type":"issue_comment","sequence":194,"text":"nice, maybe you found out what rate limit are on old api? (which can't be changeable)\nstrange why daikin not mention this in docs, and, instead, register this as a issue","author_login":"bugac","author_association":"NONE","created_at":"2024-03-25T11:57:31+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017848542","fragment_type":"issue_comment","sequence":195,"text":"The polling rate may be managed if you \"open\" in HA the DAIKIN integration and once is opened \"click\" on \"configuration\"","author_login":"ALAMILLA1","author_association":"NONE","created_at":"2024-03-25T12:01:25+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017850413","fragment_type":"issue_comment","sequence":196,"text":"@Daikin-Europe the rate limit is really terrible and far too small.\n\nI have 3 devices and can't even begin to get by with the permitted calls!\nI don't understand why they only allow such a small limit, it simply can't be true!","author_login":"mbay0r","author_association":"NONE","created_at":"2024-03-25T12:02:32+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017854783","fragment_type":"issue_comment","sequence":197,"text":"@bugac \nI suspect that the old api did not have a rate limit, but I do not have solid information about it","author_login":"ALAMILLA1","author_association":"NONE","created_at":"2024-03-25T12:05:05+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017877967","fragment_type":"issue_comment","sequence":198,"text":"I have the 400 Bad request issue as well.\nAny fixes in the meantime besides removing and adding again? Because I have 6 devices and integrated in a multitude of locations and automations - I'd rather avoid having to configure everything again and again.","author_login":"Threesa","author_association":"NONE","created_at":"2024-03-25T12:18:54+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017895828","fragment_type":"issue_comment","sequence":199,"text":"To add to that, the rate limit is insensible from a business standpoint. \n\nWhy offer an API, when people can't use it in a sensible way that in turn generated valuable data? \n\nIf @Daikin-Europe wanted to learn from the API access patterns how their devices are used, then they need to allow the users to use the API in the way they want. In short: The business goals of providing a free API are severely undermined by the incredibly low rate limit.\n\nAs it is right now, no real benefit is created. @Daikin-Europe has an API that costs them money to run but they do not get valuable user data back because the rate limit is was to low to expose interesting patterns.\n\nI do not understand what the motive is here or it the rate limit was a misinformed decision to reduce power usage in which case this whole API makes absolutely zero sense.\n\nImho, the rate limit should at least enable getting sensor information of all devices every minute (24*60 = 1440 calls/day) and some more requests for changing settings on the devices. That would make sense, would make everybody happy and not significantly increase costs majorly. After all, how many people will actively integrate the API themselves and not access their DAIKIN Devices through the app? The costs generated by external API accesses even with significantly higher rate limits should not influence operating costs that significantly.\n\n---\n\nI do not endorse data collection through the API but that is the only sensible business motive I can come up with. So that's what I base my thoughts on.","author_login":"cstmth","author_association":"NONE","created_at":"2024-03-25T12:29:55+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017903156","fragment_type":"issue_comment","sequence":200,"text":"100% \n\n@Daikin-Europe do your job and finally open the api for more requests, at the moment it is useless","author_login":"mbay0r","author_association":"NONE","created_at":"2024-03-25T12:34:08+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017905732","fragment_type":"issue_comment","sequence":201,"text":"I suspect it's an attempt by Daikin to reduce their server overheads, and to avoid any risk of DDoS. However, it seems like they've just picked an arbitrary number, without considering a) whether that's even useful to end-users, b) whether it should be per device/serial number and c) whether it should be counted separately from their own application software limits. \n\nMy hunch (and hope) is that some people in Daikin are sitting in a room with their software dev team right now, and hopefully reconsidering their course of action. A much more sensible approach would be:\n\n- Rate-limit per period (e.g., no more than 10 calls per second, to avoid DDoS\n- Rate-limit per device serial number (so that people who've bought multiple devices can use the API for all of them without needing register each against a different account\n- Rate-limit their own app (over which they have control) to a separate limit\n- Provide useful diagnostics from the API call - e.g., a 'Too Many requests' response with data on when more requests will be allowed, instead of this poor 400 Bad Request.","author_login":"Webreaper","author_association":"NONE","created_at":"2024-03-25T12:35:43+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2018024147","fragment_type":"issue_comment","sequence":202,"text":"No stupid people work at Daikin, they understand everything.\nBy the way, as you have probably read, it was written that in the future it will be possible to create as many APIs as needed. So each of your devices will have its own API and its own limits.\nNow it just takes time for daikin to find the optimal solution. And that can take time.\nit's just weird to me, is to release a temporary API that can't work normally, temp solutions must work to its limits, without limits, to test it properly. it's just homework not done. This is not a serious step for a company like Daikin","author_login":"bugac","author_association":"NONE","created_at":"2024-03-25T13:36:07+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2018040940","fragment_type":"issue_comment","sequence":203,"text":"You cannot create multiple APIs because that is per-definition not possible. You may however, and that is what I think you are referring to, create multiple applications that access that API with distinct rate limits.\n\nHowever, that is not the solution to the issue because **one application is meant for one service (like HA)** accessing all devices. That is how their architecture is laid out (and what is the industry standard for the described application system). For example, the `/gateway-devices` endpoint would make absolutelty no sense if each device had a single application assigned to it because then it would always return just one device.\n\nYou would have multiple applications if completely different services, for example HomeAssistant and your own custom script, access the Daikin servers. Then however I presume, one device may only be connected to one application (this is speculative) because otherwise dodging the rate limits would be super easy.","author_login":"cstmth","author_association":"NONE","created_at":"2024-03-25T13:45:02+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2018170037","fragment_type":"issue_comment","sequence":204,"text":"Yeah, what I was referring to was that you'd have to have something to distinguish each device - it could be any of:\n- pass the device ID/serial in the payload\n- prefix all the API endpoints with the device identifier\n- create a separate secret for each device, so that each request is seen as a different source/dest\n- something else.\n\nAnyway, I'm not worried about all this - I'm sure Daikin engineers have considered all these use-cases and haven't structured their API in such a way that calls for one device can't be distinguished from those associated with another. I have no concerns about that, or Daikin prematurely publishing an API that's so unfit-for-purpose that they need to revoke it and reinstate the old one, because somebody elsewhere in the thread confirmed that no stupid people work at Daikin. ;)","author_login":"Webreaper","author_association":"NONE","created_at":"2024-03-25T14:45:14+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2018731673","fragment_type":"issue_comment","sequence":205,"text":"This is still working for me since March 17th, I haven't done any changes since\n\nimage","author_login":"BjornHoorelbeke","author_association":"NONE","created_at":"2024-03-25T19:16:59+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2019482458","fragment_type":"issue_comment","sequence":206,"text":"About API limits.\nyesterday, i moved all limit sliders to the right side (max allowed) and today, after about 12hours, onecta app not responding anymore. Old one still working.\nYou guys sure about API usage limits?","author_login":"bugac","author_association":"NONE","created_at":"2024-03-26T06:16:33+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2020345868","fragment_type":"issue_comment","sequence":207,"text":"Wonderful new API, worked for 12h and now everything is broken since 24h.\nI know why I installed a heat and power meter on the heatpump to fetch my own data by second!\nWhy oh why can't we get a local API in addition? For us strange'lingy wanting to poll more often and fast?\n\nPS: If I want to change the token I have to remove and add the integration? Was that serious or some joke?","author_login":"Sesshoumaru-sama","author_association":"NONE","created_at":"2024-03-26T12:51:27+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2020426485","fragment_type":"issue_comment","sequence":208,"text":"I am so tired of this shitstorm, so I bought the Faikin ESP32 module, but then had to wait for the EKRS21 cable.\nCable finally arrived today, connected it and... nothing. \n\nI start discussing with the Faikin developer on another thread and it seemed the problem is with my Emura :\n- Faikin works perfectly fine if I feed with 5V over USB\n- there is simply no voltage between Pin 5 (ground) and Pin 4 of the S21 board, where there should be anything between 12V and 15V\n- then I checked in detail the behaviour of my Emura and it does indeed do weird things. It is e.g. not possible to choose anything but Auto Fan mode in Heating mode. In other modes it works.\n\nSo I suspect something is broken on my Emura 3 unit and now comes the fun...\n\nDaikin Support refuses to replace the board under warranty (unit was installed 2 months ago) because I opened it up to connect my \"own device\" on the S21 port. 2 arguments that is BS \n1) the problems with the fan modes already occurred when the unit was just installed, but I didn't flag it because I thought it was a Onecta app issue (we never use the remote)\n2) if Daikin wouldn't have broken the Cloud API, I would never had to seek my resort to a Faikin... they called this upon themselves.\n\nI am really upset about this total cynism of the Daikin support team. Premium prices, but they refuse to take any responsability whatsoever and try to blame everything on the customer.\nIt seems they forgot we are actually doing them a favour being the alfa/beta tester of their s***.","author_login":"migueldc73","author_association":"NONE","created_at":"2024-03-26T13:25:54+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2020471101","fragment_type":"issue_comment","sequence":209,"text":"I would not put it on Daikin Devs, but probabl on \"good'old\" product management.\nI like the idea that the same API which is hosted in the cloud for dah'lazy people if also available locally. So I am thinking about getting a BRP069A61/2.","author_login":"Sesshoumaru-sama","author_association":"NONE","created_at":"2024-03-26T13:44:30+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2021132103","fragment_type":"issue_comment","sequence":210,"text":"OK, so things cooled a bit down here. I still don't have any voltage on Pin 4 of my S21 connector (Emura 3), but I took the 5V from Pin 1 and fed that into the Pin 4 of the Faikin.\n\nEverything seems to work fine and most importantly ALL LOCAL !!! Yippee\n- on/off\n- changing mode : auto/cool/heat/fan/dry\n- changing temp\n- changing fan (even silent mode), but still a small bug there, see URL \n- lot of settings that the cloud API does not offer are available : \n - Eco\n - Boost\n - Comfort mode (yep !)\n - Streamer (another yep!)\n - Quiet outdoor\n - Sensor mode (no idea what that is)\n\nIt's funny to see that any change with this Local Faikin integration is instantaneous and the Onecta app only following like 30-60 seconds later...\n\nStill a bit worried about not having voltage on Pin 4 of the S21. Do I have a defective board or did Daikin somehow change that ? I have to admit it was one of the first Emura 3 delivered...","author_login":"migueldc73","author_association":"NONE","created_at":"2024-03-26T17:58:59+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2021181363","fragment_type":"issue_comment","sequence":211,"text":"@BjornHoorelbeke :\n\nBut then you did remove it all and installed it again to be able to do so in Incognito mode?\nDidn't you loose all your devices and entities and thus all your configuration?","author_login":"Threesa","author_association":"NONE","created_at":"2024-03-26T18:26:03+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2021325870","fragment_type":"issue_comment","sequence":212,"text":"On my side I found out I could control my Daikin with my eMylo device which works with local tuya, it can use infrared to control the indoor unit. Just I wouldn't have the consumption, but anyway I could use another shelly device on my electric board to monitor locally too.\n\nSo if Daikin don't open source or make it stable I think I will look into this alternative ( already did it for my old Toshiba AC units), anyway there is no guarantee Daikin will provide the cloud service forever or for the life time of the AC unit.","author_login":"tyge68","author_association":"NONE","created_at":"2024-03-26T19:42:52+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2022241133","fragment_type":"issue_comment","sequence":213,"text":"I also have the same error.\n(And know suddenly the old custom integration starts working again)\n\nIs there a possibility to make some kind of repair function? I renamed some entities, so I don't like to keep doing this when reinstalling the integration","author_login":"djfanatix","author_association":"NONE","created_at":"2024-03-27T08:55:07+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2022280731","fragment_type":"issue_comment","sequence":214,"text":"@djfanatix I don't have had this issue at all, so I can't test this, but maybe you can try URL I have done some searching and there is some reauth support in HA, but not sure if this is the right way because I can't test it. The access tokens are normally valid for a year so this is a use case other integrations probably ignore.","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-27T09:16:54+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2022327812","fragment_type":"issue_comment","sequence":215,"text":"Just released v4.0.23 which should trigger the reauth config flow again on the access token refresh error. I did a quick hack locally to raise this exception always and at that moment I can reauthorize daikin again, let me know whether this works when you have this 400 error on your system.","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-27T09:43:13+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2022371229","fragment_type":"issue_comment","sequence":216,"text":"Installed latest version. The API was revoked already.\nAfter re-authentication it start working again (without the need of removing and setup the integration again)","author_login":"Tazmanian79","author_association":"NONE","created_at":"2024-03-27T10:05:08+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2022377415","fragment_type":"issue_comment","sequence":217,"text":"Great, that at least simplifies the re-authentication, learned again more from HA than I wanted to learn ;-)","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-27T10:08:18+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2022380945","fragment_type":"issue_comment","sequence":218,"text":"So what I'm hearing you say here is that you're now *the* Home Assistant integration development expert that we can all turn to with our many and varied questions? :) Thanks for all the hard work on sorting this it's really appreciated.","author_login":"sOckhamSter","author_association":"NONE","created_at":"2024-03-27T10:10:09+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2022385353","fragment_type":"issue_comment","sequence":219,"text":"This is my experience too. I just had this 1 minute ago. \n\nThank you @jwillemsen for all the hard work and patience.","author_login":"SolarEdgeUser","author_association":"NONE","created_at":"2024-03-27T10:12:14+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2022388356","fragment_type":"issue_comment","sequence":220,"text":"Do you see the original exception also a part of the log? Just curious what HA logs at this moment, just for reference for others","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-03-27T10:13:55+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2023938307","fragment_type":"issue_comment","sequence":221,"text":"I also confirm it works for me with 4.0.23 , lets hope it stay stable like it used to be :)","author_login":"tyge68","author_association":"NONE","created_at":"2024-03-27T20:35:40+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2025093578","fragment_type":"issue_comment","sequence":222,"text":"Since the last version I'm now over the 12h it's running .. so fingers crossed it keeps on working.","author_login":"Tazmanian79","author_association":"NONE","created_at":"2024-03-28T12:40:45+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2025658813","fragment_type":"issue_comment","sequence":223,"text":"Mine is actually working since the last update. It just popped up once (yesterday morning) to say that my credentials expired, but the new version automatically sent me to the Daikin SSO pag and after going through the acceptation, it just ran fine ever since.\n\nSo I am happy although it's a bit (too) late because I just got my Faikin local control working, so I'm using local now.","author_login":"migueldc73","author_association":"NONE","created_at":"2024-03-28T16:41:48+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2026946531","fragment_type":"issue_comment","sequence":224,"text":"Same issue with me. Just updated to 4.0.23 ...fingers crossed","author_login":"techadrian","author_association":"NONE","created_at":"2024-03-29T09:33:58+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2028594099","fragment_type":"issue_comment","sequence":225,"text":"Did not work for me. Single HVAC with standard pulling settings. Bind to my WAN url through reverse proxy. Got a HA alert that i need to re authorize (it was new) and it up again (for the next 12 hour...).","author_login":"james-1987","author_association":"NONE","created_at":"2024-03-31T08:04:51+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2031878760","fragment_type":"issue_comment","sequence":226,"text":"This still isn't working for me, have deleted and reinstalled but still no joy. Hopefully a fix or work around soon","author_login":"Majikmonke","author_association":"NONE","created_at":"2024-04-02T12:12:15+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2031910024","fragment_type":"issue_comment","sequence":227,"text":"But others are still having issue with it? or it is just me :(","author_login":"Majikmonke","author_association":"NONE","created_at":"2024-04-02T12:26:54+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2031969869","fragment_type":"issue_comment","sequence":228,"text":"Check you really are running the latest version. 4.0.23 didn't come up as an automatic update that I was prompted to install. In the end I had to do this to get the latest:\n\n1. HACS\n2. Search for Onecta\n3. Click 3-dots on the right hand side\n4. Choose 'Redownload'\n5. Then I was prompted for 4.0.23\n6. Redownloaded\n7. Restarted HA\n8. Got an error on the Onecta integration about auth\n9. Re-did the OAuth flow\n10. Been working now for 5 days.","author_login":"Webreaper","author_association":"NONE","created_at":"2024-04-02T12:55:13+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2032452522","fragment_type":"issue_comment","sequence":229,"text":"Hi\n\nYes upgraded and it worked for 12 hours or so.\n\nWill try again when home tonight.\n\nKind regards\n\nDan Scate\n\nSent from my Samsung Galaxy smartphone.\n\n-------- Original message --------\nFrom: vevs ***@***.***>\nDate: 02/04/2024 16:59 (GMT+00:00)\nTo: jwillemsen/daikin_onecta ***@***.***>\nCc: Majikmonke ***@***.***>, Comment ***@***.***>\nSubject: Re: [jwillemsen/daikin_onecta] The provided authorization code or refresh token is revoked. (Issue #41)\n\nstill working fine for almost a week. latest version FTW 😅👍\n\nBut others are still having issue with it? or it is just me :(\n\nso, did you upgraded?\n\n—\nReply to this email directly, view it on GitHub","author_login":"Majikmonke","author_association":"NONE","created_at":"2024-04-02T16:01:15+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[2139900425],"is_known_query_context":false},{"document_id":"gh_comment_2032609495","fragment_type":"issue_comment","sequence":230,"text":"Just deleted it all and tried again and we have a connection. Let's hope its still working tomorrow.\n\nKind regards\n\nDan Scate\n\nSent from my Samsung Galaxy smartphone.\n\n-------- Original message --------\nFrom: vevs ***@***.***>\nDate: 02/04/2024 16:59 (GMT+00:00)\nTo: jwillemsen/daikin_onecta ***@***.***>\nCc: Majikmonke ***@***.***>, Comment ***@***.***>\nSubject: Re: [jwillemsen/daikin_onecta] The provided authorization code or refresh token is revoked. (Issue #41)\n\nstill working fine for almost a week. latest version FTW 😅👍\n\nBut others are still having issue with it? or it is just me :(\n\nso, did you upgraded?\n\n—\nReply to this email directly, view it on GitHub","author_login":"Majikmonke","author_association":"NONE","created_at":"2024-04-02T17:14:01+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[2139900425],"is_known_query_context":false},{"document_id":"gh_comment_2032614106","fragment_type":"issue_comment","sequence":231,"text":"Still working for me as well, 1 week now. Does anyone managed to update the devices to 1.30 to see has problem? Trying to update my devices but it fails.","author_login":"PskNorz","author_association":"NONE","created_at":"2024-04-02T17:16:56+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2033764199","fragment_type":"issue_comment","sequence":232,"text":"Failed again after around 12 hours. Error authentication expired","author_login":"Majikmonke","author_association":"NONE","created_at":"2024-04-03T07:31:07+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2034042976","fragment_type":"issue_comment","sequence":233,"text":"logs that I can see\n\nLogger: homeassistant.helpers.config_entry_oauth2_flow\nSource: helpers/config_entry_oauth2_flow.py:211\nFirst occurred: 06:35:44 (1 occurrences)\nLast logged: 06:35:44\n\nToken request for daikin_onecta_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.\n\nThis error originated from a custom integration.\n\nLogger: custom_components.daikin_onecta.coordinator\nSource: helpers/update_coordinator.py:371\nintegration: Daikin Onecta (documentation, issues)\nFirst occurred: 06:35:44 (1 occurrences)\nLast logged: 06:35:44\n\nAuthentication failed while fetching daikin_onecta data: Problem refreshing token: 400, message='Bad Request', url=URL(' URL \n\nRegards\n\nDan Scate\n\n________________________________\nFrom: vevs ***@***.***>\nSent: 03 April 2024 10:15\nTo: jwillemsen/daikin_onecta ***@***.***>\nCc: Majikmonke ***@***.***>; Comment ***@***.***>\nSubject: Re: [jwillemsen/daikin_onecta] The provided authorization code or refresh token is revoked. (Issue #41)\n\nFailed again after around 12 hours. Error authentication expired\n\nthats new, never seen this error message\n\n—\nReply to this email directly, view it on GitHub","author_login":"Majikmonke","author_association":"NONE","created_at":"2024-04-03T09:32:32+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[2139900425],"is_known_query_context":false},{"document_id":"gh_comment_2041070228","fragment_type":"issue_comment","sequence":234,"text":"Since yesterday i have the same issues. Log says:\n\nToken request for daikin_onecta_emu20gdjdiiuxi_hnfgz69dd failed (invalid_grant): The provided authorization code or refresh token is revoked.\n\nAlso the login at Daikin isn't working for me, maybe they are working on something?\n\n URL does not work, page has errors and doesn't show up correctly\n\nBest,\nJens","author_login":"jens-dambruch","author_association":"NONE","created_at":"2024-04-06T12:32:44+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2041297965","fragment_type":"issue_comment","sequence":235,"text":"@jwillemsen I’m also receiving this error. In the issue in the other repo from where you linked to this one, a user wrote:\n\n‘’’\nONECTA Cloud API: Refresh tokens expire after approximately 12 hours\nInvestigating\nDaikin is aware of reports regarding refresh token expiration after 12 hours, impacting 3rd party integrations. Some users may encounter a \"400 Bad Request\" response when refreshing their access token. We're actively investigating with our IT department for a solution.\n\nWe appreciate your patience as we work to ensure the ONECTA API meets user expectations. Thank you for your understanding.\nPosted 7 days ago. Mar 25, 2024 - 10:23 CET\n‘’’\n\nDoes this mean there’s nothing we can do while waiting for Daikin to resolve the issue?","author_login":"sraka1","author_association":"NONE","created_at":"2024-04-07T03:45:12+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2047117898","fragment_type":"issue_comment","sequence":236,"text":"Got just my first token refresh failed error, but using the Onecta app which I am using for more than 2 years now. The HA integration still runs stable on my systems.","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-04-10T10:07:09+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2059867458","fragment_type":"issue_comment","sequence":237,"text":"I tried to install the onecta intgration. \nDid the onecta integration in HACS via extra repositories,\nafter restart downloaded the integration in HACS,\nafter another restart tried to add integration.\nThan the daikin site is started, password asked.\nWhen loged in I have to accept something, and set the link to the application.\nThen click on 'link account'. \nThen only a white screen on the daikin site and in HA on the integration site one option: 'close' \n\n<img width=\"484\" alt=\"Scherm­afbeelding 2024-04-16 om 22 22 13\" src=\" URL \n\nNo asking for any token at all.","author_login":"brinkgit","author_association":"NONE","created_at":"2024-04-16T20:25:47+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2060032733","fragment_type":"issue_comment","sequence":238,"text":"Hi! Here another user trying to get this integration in my HA.\nI saw in the API documentation that by Spring 2024 the given clientId and token will be deprecated, so this should have happen already or it will be happening in a few days...\nAnyway I could not get further than the integration asking me the name, clientid and token (which I copied from the API documentation right away). I get redirected to a url which tells me that something went wrong with the authentication (maybe I did not understand the \"Using config flow\" or maybe the clientid and token are already outdated).\nAlso I did not see anywhere a form to ask for my clientId and token... I did subscribe for the onecta developer site but nothing is there but the documentation how to user their API.\nThanks anyway for the effort, this integration looks promising!","author_login":"juagicre","author_association":"NONE","created_at":"2024-04-16T22:46:29+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2060544760","fragment_type":"issue_comment","sequence":239,"text":"Try to remove the daikin credentials under Settings/Devices and the three dots in the upper right corner and try to add it again","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-04-17T07:15:26+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2061141648","fragment_type":"issue_comment","sequence":240,"text":"I did, no better result.\n\nWhat I found as a probable reason: On the developer.cloud.daikineurope site, there is 1 product and that is the onecta cloud api.\nBut when I look at 'myapss' on that site, there is no connected app. And it's a;so not possible to add one, the site says:\n------------\n_You cannot create an application as this developer portal has no available application auth strategies. Please contact a developer portal admin.__\n------------\n\nI don't know if that a sort of reason and if yes how to solve it. Can anyone help with this?\n\nAnother possibility:\nWhen I click on the onecta icloud api (on the developer site) I come on another page where I can click on authorize, the system asks for a 'Access token retrieved from token endpoint'. Where do I find that?","author_login":"brinkgit","author_association":"NONE","created_at":"2024-04-17T12:25:40+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2061145366","fragment_type":"issue_comment","sequence":241,"text":"Check the getting started page at the developer website, there is a client id/secret which everyone has to use at this moment","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-04-17T12:27:43+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2076695910","fragment_type":"issue_comment","sequence":242,"text":"Daikin reported that they have implemented a fix, see URL When you have this problem within 12 hours from now please re-initiate the authentication. When you have this problem again after 24 hours from now please let us and Daikin know! \n\nHopefully we can close this issue after the weekend!","author_login":"jwillemsen","author_association":"OWNER","created_at":"2024-04-25T08:55:05+08:00","repo_name":"jwillemsen/daikin_onecta","issue_id":2139900425,"issue_number":41,"issue_url":"https://github.com/jwillemsen/daikin_onecta/issues/41","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0463","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Introduce flow control between partitions?","query_context":"**Description**\n\nPartitions send commands between each for the following cases:\n\n- Message correlation (including correlation)\n- Deployment distribution\n\nIn both cases, since communication is assumed to be unreliable, we have built-in retry mechanisms. In the event of a failure in these, or a bug on either side, it can happen that the sender overloads the receiver. Or it can be that the receiver is generally overloaded and the sender shouldn't send anything until the situation resolves itself.\n\nThere's no way for the receiver to notify the sender at the moment that it should slow down. We saw this in one incident, where the deployment distributor kept retrying deployments at a faster rate than the receiving partition could process, resulting in the build up of an incredibly large log and that partition being effectively unavailable from a user point of view.\n\nIdeally, we should see a solution which satisfies the following:\n\n- [ ] Commands from other partitions can be rejected based on the current load, sharing the same rate limiter as external commands\n- [ ] Certain commands may need to be whitelisted (e.g. backup/checkpoint related commands)\n- [ ] The receiving partition can provide information about when to retry\n- [ ] The sending partition does not buffer commands for retry in an unbounded way\n\nThe last point is to ensure we don't run out of memory by buffering commands to be sent to a given partition which is unable to process any commands for a longer period of time.","known_context_document_ids":["gh_issue_1341358608"],"reference_answer":"We're working on another solution for that in parallel. URL \n\nI know the issue specifies IPC, but the proposed solution will enforce rate limits between the different categories, user submitted commands, internal/scheduled commands, and remote ones.","answer_document_id":"gh_comment_1806797939","silver_evidence_path":["gh_comment_1802371153","gh_issue_1846746772","gh_comment_1806797939"],"evidence_issue_ids":[1341358608,1846746772],"source_repo_name":"camunda/camunda","source_issue_id":1341358608,"source_issue_number":10087,"source_issue_url":"https://github.com/camunda/camunda/issues/10087","target_repo_name":"camunda/zeebe","target_issue_id":1846746772,"target_issue_number":13870,"target_issue_url":"https://github.com/camunda/zeebe/issues/13870","reference_anchor_document_id":"gh_comment_1802371153","reference_answer_author":"npepinpe","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1963,"anchor_target_overlap":0.1538,"target_answer_overlap":0.2609},"issue_created_at":"2022-08-17T08:13:56+08:00","valid_comment_count":25,"fragments":[{"document_id":"gh_issue_1341358608","fragment_type":"issue_description","sequence":0,"text":"Introduce flow control between partitions\n**Description**\n\nPartitions send commands between each for the following cases:\n\n- Message correlation (including correlation)\n- Deployment distribution\n\nIn both cases, since communication is assumed to be unreliable, we have built-in retry mechanisms. In the event of a failure in these, or a bug on either side, it can happen that the sender overloads the receiver. Or it can be that the receiver is generally overloaded and the sender shouldn't send anything until the situation resolves itself.\n\nThere's no way for the receiver to notify the sender at the moment that it should slow down. We saw this in one incident, where the deployment distributor kept retrying deployments at a faster rate than the receiving partition could process, resulting in the build up of an incredibly large log and that partition being effectively unavailable from a user point of view.\n\nIdeally, we should see a solution which satisfies the following:\n\n- [ ] Commands from other partitions can be rejected based on the current load, sharing the same rate limiter as external commands\n- [ ] Certain commands may need to be whitelisted (e.g. backup/checkpoint related commands)\n- [ ] The receiving partition can provide information about when to retry\n- [ ] The sending partition does not buffer commands for retry in an unbounded way\n\nThe last point is to ensure we don't run out of memory by buffering commands to be sent to a given partition which is unable to process any commands for a longer period of time.","author_login":"npepinpe","author_association":"MEMBER","created_at":"2022-08-17T08:13:56+08:00","repo_name":"camunda/camunda","issue_id":1341358608,"issue_number":10087,"issue_url":"https://github.com/camunda/camunda/issues/10087","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1220439680","fragment_type":"issue_comment","sequence":1,"text":"Probably a M size issue (up to 6 weeks), and it is not urgent if not something else goes wrong. We should look at it as an improvement for next quarter, and evaluate if there is any overlap with other initiatives around inter-partitions communication, i.e. switching to gRPC.","author_login":"menski","author_association":"MEMBER","created_at":"2022-08-19T09:09:00+08:00","repo_name":"camunda/camunda","issue_id":1341358608,"issue_number":10087,"issue_url":"https://github.com/camunda/camunda/issues/10087","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1772152923","fragment_type":"issue_comment","sequence":2,"text":"affected partition stability in an incident URL \n2 partitions got overloaded with message subscription create commands and the backlog was growing at a higher rate than the processing","author_login":"megglos","author_association":"CONTRIBUTOR","created_at":"2023-10-20T06:21:47+08:00","repo_name":"camunda/camunda","issue_id":1341358608,"issue_number":10087,"issue_url":"https://github.com/camunda/camunda/issues/10087","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1774805043","fragment_type":"issue_comment","sequence":3,"text":"Planning:\n\n- Time box 8 hours to propose a solution/breakdown for this\n\n@oleschoenburg and @deepthidevaki will look into it in the next two weeks","author_login":"npepinpe","author_association":"MEMBER","created_at":"2023-10-23T09:39:17+08:00","repo_name":"camunda/camunda","issue_id":1341358608,"issue_number":10087,"issue_url":"https://github.com/camunda/camunda/issues/10087","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1802371153","fragment_type":"issue_comment","sequence":4,"text":"@deepthidevaki and I looked into this a bit from the angle of \"let's improve flow control in general\". In particular, URL was at the back of our minds.\n\nWe think that a first step in the right direction would be to remove the `LogStorageAppender` in general and replace it with a simple limiter that sits in front of the `Sequencer` to protect the raft thread from overloading it with too many writes. We think that a fixed limit or a simple RTT based limit would work well for this.\n\nAs a second step, we can move the flow control for user commands away from the `CommandApi` and implement it in front of the `Sequencer` instead. The idea here is to have one common place where flow control for commands is implemented. User commands would then acquire permits from two limiters, the configured one for user commands (AIMD by default), and the raft thread limiter.\nTo implement this, I propose a new class that sits in front of the `Sequencer`. The `Mixer` would decide which flow control to use, based on the _source_ of records. Sources would be _User Commands_, _Processing Results_, _Internal Commands_ and _Remote Commands_. \n\n**After implementing the first two steps, the system behavior should remain almost the same**. User commands go through a configurable limit while other records such as processing results, internal commands (e.g. timer triggers), and remote commands (e.g. message correlation) are only held back by the limiter that protects the raft thread.\n\nBuilding on top of this, we can think about adding flow control for _Remote Commands_. The challenge here is that we probably can't just drop commands silently. Let's take message correlation as an example: When a _Correlate_ command is sent to a remote partition, the sent time is updated immediately and the correlation is only attempted again after 10 seconds. If we were to introduce a limiter for remote commands, we might run into problems because every dropped command will result in at least 10 seconds of delay. Ultimately, a solution similar to URL would be desirable. The difference here is that we must wait for the command to be received, written _and committed_ on the remote partition. Currently, this is not possible because inter-partition communication is a one-way channel from sender to receiver.\nInstead, we can extend the inter-partition command sender to take a completion callback that is executed whenever the command is written on the remote partition. We can then use that for message correlation (and possibly other performance sensitive features such as signals) to shorten the retry interval for messages that were not written on the receiver.\n\n[tasklist]\n## Refactoring flow control\n- [ ] Let the `Sequencer` write directly to the raft thread\n- [ ] Implement a `Mixer` component in front of the `Sequencer` \n- [ ] The `Mixer` protects the raft thread from overloading\n- [ ] The `Mixer` provides metrics for flow control state\n- [ ] Record writers are categorized by use-case\n- [ ] The `Mixer` applies flow control for user commands\n- [ ] Cleanup: Building a `LogStreamWriter` should not be async","author_login":"oleschoenburg","author_association":"MEMBER","created_at":"2023-11-08T17:47:57+08:00","repo_name":"camunda/camunda","issue_id":1341358608,"issue_number":10087,"issue_url":"https://github.com/camunda/camunda/issues/10087","linked_issue_ids":[1846746772],"is_known_query_context":false},{"document_id":"gh_comment_1805272321","fragment_type":"issue_comment","sequence":5,"text":"A prequel to Ole's comment above.\n\nWe prototyped flow control in Sequencer. We added separate request limiters for user commands, remote commands and internal commands. Processing result from stream processor is never rejected. All limiters are configured to use AIMD. Limiters for internal and remote commands are configured to be more lenient to ensure internal backlog can make progress even if there is high load from users, but this is up for discussion.\n\nAlthough our main goal is to limit remote commands, we first evaluated with a high load of timers because it was the easiest to setup a benchmark with timers. **Result: The cluster with the limiters for internal-commands is still running strong after a couple of days. The reference benchmark is almost dead now with 400Mil of processing queue size.** \n\nReference\nimage\n\nPOC with flow control for user, remote and internal commands.\nimage\n\nNext question is how this type of flow control works for remote commands. As Ole explained before, rejecting remote commands can cause higher delay in message correlation mainly because we are not retrying aggressively enough. In a very high load, similar to what we saw in the support incident, it is probably fine. But in a normal load scenario we have to ensure that the messages are still correlated in real-time. We have not evaluated this yet. So as a next step, I would like to evaluate the impact of flow control for remote commands. Based on the results, we can decide whether we want to add request limiters for remote commands in the Sequencer (together with better retry strategy on the sender) or add caching similar to the timers proposed for #13870 or a combination of both. \n\nNevertheless, we should take the next steps proposed by Ole above.","author_login":"deepthidevaki","author_association":"CONTRIBUTOR","created_at":"2023-11-10T08:09:07+08:00","repo_name":"camunda/camunda","issue_id":1341358608,"issue_number":10087,"issue_url":"https://github.com/camunda/camunda/issues/10087","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1805355125","fragment_type":"issue_comment","sequence":6,"text":"@deepthidevaki just want to mention that we already implemented caching for the writes in URL","author_login":"Zelldon","author_association":"MEMBER","created_at":"2023-11-10T09:12:17+08:00","repo_name":"camunda/camunda","issue_id":1341358608,"issue_number":10087,"issue_url":"https://github.com/camunda/camunda/issues/10087","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1805358304","fragment_type":"issue_comment","sequence":7,"text":"I think caching for remote commands is gonna be really tricky. I suppose you could do it on the receiver side :thinking: That would reduce a bit the load on the remote commands for back pressure I guess.","author_login":"npepinpe","author_association":"MEMBER","created_at":"2023-11-10T09:14:41+08:00","repo_name":"camunda/camunda","issue_id":1341358608,"issue_number":10087,"issue_url":"https://github.com/camunda/camunda/issues/10087","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1805397732","fragment_type":"issue_comment","sequence":8,"text":"True. We don't have a prototype for it yet.\n\nWe discussed the following for backpressure approach\n1. Buffering in the receiver and receiver can retry (limit the number of retries) if the write was rejected due to backpressure. This can put more pressure on receiver which might be already overloaded.\n2. Buffering in the Inter-partition sender and retry if the write was rejected due to backpressure. (limit the number of retries). The record is already buffered in the engine, but we have to buffer it again in inter-partition sender.\n3. Somehow the recurrent checkers in engine should know to retry faster if it was rejected due to backpressure. Needs more information exchange between the inter-partition transport and the checkers.\n\n1 and 2 is in the direction of providing more reliable transport for inter-partition.\n\nAlternate is to follow the caching approach used for timers, to reduce the chance of backpressure due to sender repeatedly trying to send the same commands. But here the most tricky is that the we can mark it as written only when the receiver has written and committed the command. Also how to handle if the command was rejected -> should retry again?\n\nAdding backpressure will be the easiest part to implement, but the problem is that in specific workloads there is a chance that a few messages get delayed forever because they were unlucky and get caught in the backpressure loop.","author_login":"deepthidevaki","author_association":"CONTRIBUTOR","created_at":"2023-11-10T09:42:46+08:00","repo_name":"camunda/camunda","issue_id":1341358608,"issue_number":10087,"issue_url":"https://github.com/camunda/camunda/issues/10087","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1807694122","fragment_type":"issue_comment","sequence":9,"text":"It was unclear to me before whether we want to add flow control for internal commands now that we have the caching solution. It seems caching did not fully solve the problem encountered by a user. Flow control for internal commands would likely solve the reported issue.\n\nSo I'm putting this issue back to inbox to discuss it in next traige/planning. It would make sense to start implementing the changes proposed in the above comment even if we don't have a completed solution for IPC.","author_login":"deepthidevaki","author_association":"CONTRIBUTOR","created_at":"2023-11-13T08:48:01+08:00","repo_name":"camunda/camunda","issue_id":1341358608,"issue_number":10087,"issue_url":"https://github.com/camunda/camunda/issues/10087","linked_issue_ids":[1846746772],"is_known_query_context":false},{"document_id":"gh_comment_1820831245","fragment_type":"issue_comment","sequence":10,"text":"@deepthidevaki can you link the prototype PR/branch here? thanks!","author_login":"megglos","author_association":"CONTRIBUTOR","created_at":"2023-11-21T12:27:27+08:00","repo_name":"camunda/camunda","issue_id":1341358608,"issue_number":10087,"issue_url":"https://github.com/camunda/camunda/issues/10087","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1824293391","fragment_type":"issue_comment","sequence":11,"text":"Hi.\n\nI've tested this case URL Seems like queue size is really capped now (was up to 1mil events, now up to 500k events). But this the only good news. Overall performance became lower, windows of unavailability became wider. It's reasonable, because number of timer events doesn't change it's just processed slower now.\n\nimage\n\nI've expected that with limited processing of timer events - there will be some \"bandwidth\" for processing new events (create new PIs). That' doesn't happen.","author_login":"dddpaul","author_association":"NONE","created_at":"2023-11-23T11:50:52+08:00","repo_name":"camunda/camunda","issue_id":1341358608,"issue_number":10087,"issue_url":"https://github.com/camunda/camunda/issues/10087","linked_issue_ids":[1846746772],"is_known_query_context":false},{"document_id":"gh_comment_1824605150","fragment_type":"issue_comment","sequence":12,"text":"This could be because in the poc, we deliberately configured flow control for user commands and internal commands differently. We are more aggressively rejecting user commands while accepting more internal commands.","author_login":"deepthidevaki","author_association":"CONTRIBUTOR","created_at":"2023-11-23T15:20:29+08:00","repo_name":"camunda/camunda","issue_id":1341358608,"issue_number":10087,"issue_url":"https://github.com/camunda/camunda/issues/10087","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1846746772","fragment_type":"issue_description","sequence":0,"text":"Scheduled tasks should avoid overloading the streamprocessor\n**Description**\n\nThe workflow engine employs the help of several scheduled tasks that periodically append commands to the log stream. This helps offload time-consuming work that could otherwise block the actual workflow processing. \n\nFor example, job deadlines are checked for expiration by the `JobTimeoutTrigger`, which will append commands for each job to time them out. The stream processor will then process this command asynchronously. Eventually, the job changes state to `TIMED_OUT` when the command is processed. \n\nIn the meantime, the `JobTimeoutTrigger` continues to check for expired job deadlines periodically. If the stream processor is blocked, it may happen that the `JobTimeoutTrigger` continues to append the same `Job:TIME_OUT` command. There is nothing that stops it from overloading the stream processor.\n\nIn fact, many of the scheduled tasks suffer from a similar problem.\n\n**Proposed solution**\n\nScheduled tasks need to keep a cache of recently appended commands (or something similar) that can be used to avoid appending the same command multiple times.\n\nThis should be available in a generic way, so all scheduled tasks can easily add support for this.\n\n**Incident**\n\nFollow up issue from incident: INC-274: Streamprocessor lagging behind\n\nSupport: \n- URL \n- URL","author_login":"korthout","author_association":"MEMBER","created_at":"2023-08-11T12:33:23+08:00","repo_name":"camunda/zeebe","issue_id":1846746772,"issue_number":13870,"issue_url":"https://github.com/camunda/zeebe/issues/13870","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1674703649","fragment_type":"issue_comment","sequence":1,"text":"Marking this as high impact, as it is a recurring pain. Resolving this would lower the load on clusters experiencing problems where timers, buffered messages, or job timeouts play a role. This would help in the investigation as well as ease recovery.","author_login":"korthout","author_association":"MEMBER","created_at":"2023-08-11T12:37:24+08:00","repo_name":"camunda/zeebe","issue_id":1846746772,"issue_number":13870,"issue_url":"https://github.com/camunda/zeebe/issues/13870","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1719064056","fragment_type":"issue_comment","sequence":2,"text":"I'm increasing the priority of this issue/feature to 'upcoming' since there is a support case waiting for it. \nStill, it is highly unlikely to be able to work on this before 8.4. However, we will update the issue once we plan to work on it.","author_login":"abbasadel","author_association":"CONTRIBUTOR","created_at":"2023-09-14T09:11:29+08:00","repo_name":"camunda/zeebe","issue_id":1846746772,"issue_number":13870,"issue_url":"https://github.com/camunda/zeebe/issues/13870","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1733336320","fragment_type":"issue_comment","sequence":3,"text":"ZDP-Planning:\n- pushing into the inbox of ZPA to get an update on this as it relates to #14003","author_login":"megglos","author_association":"CONTRIBUTOR","created_at":"2023-09-25T09:53:02+08:00","repo_name":"camunda/zeebe","issue_id":1846746772,"issue_number":13870,"issue_url":"https://github.com/camunda/zeebe/issues/13870","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1733516517","fragment_type":"issue_comment","sequence":4,"text":"The ZPA-team discussed this issue again and now considers this a bug. Originally, I felt it was a feature, as we have never supported many timers triggering at once (i.e., there's always a limit somewhere). However, the team feels that outages should not occur from existing features, irrespective of how they are used. Add to this that we don't have documentation about some artibrary limit to the number of timers. Lastly, users feel that this is a bug, and so should we.\n\nAs a bug, it may be easier to prioritize and release a fix for this as we can backport and patch previous versions.","author_login":"korthout","author_association":"MEMBER","created_at":"2023-09-25T11:54:55+08:00","repo_name":"camunda/zeebe","issue_id":1846746772,"issue_number":13870,"issue_url":"https://github.com/camunda/zeebe/issues/13870","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1761334325","fragment_type":"issue_comment","sequence":5,"text":"@korthout Hi!\n\nIs there any updates for this bug? I would be nice to have a due date )","author_login":"dddpaul","author_association":"NONE","created_at":"2023-10-13T11:08:30+08:00","repo_name":"camunda/zeebe","issue_id":1846746772,"issue_number":13870,"issue_url":"https://github.com/camunda/zeebe/issues/13870","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1764378450","fragment_type":"issue_comment","sequence":6,"text":"Hi @dddpaul, the team plans to spend time on this in our current iteration. There's a chance that we can fit a solution in the upcoming patch releases, but we cannot promise this.\n\nWe'll need to consider different solutions. For example, the proposed cache reduces the load on the system in most cases but will not remove the problem completely. Alternatively, ideas like #12560 could help but come with other downsides. The developer(s) working on this issue should consider whether caching is enough or whether another solution might be more fitting. As this is not yet clear, it's possible that a solution will not be ready before the upcoming patch releases. However, we plan to spend time on this issue now.","author_login":"korthout","author_association":"MEMBER","created_at":"2023-10-16T12:34:09+08:00","repo_name":"camunda/zeebe","issue_id":1846746772,"issue_number":13870,"issue_url":"https://github.com/camunda/zeebe/issues/13870","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1784069384","fragment_type":"issue_comment","sequence":7,"text":"There was an L1 blocker again because of this URL \n\nHandled by @npepinpe","author_login":"Zelldon","author_association":"MEMBER","created_at":"2023-10-29T11:09:46+08:00","repo_name":"camunda/zeebe","issue_id":1846746772,"issue_number":13870,"issue_url":"https://github.com/camunda/zeebe/issues/13870","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1795453935","fragment_type":"issue_comment","sequence":8,"text":"Users are heavily impacted by this, so I would like to bump this to critical, with a focus on fixing timers. Timers are different from message correlation has they don't involve inter-partition communication, which may help narrow the scope of the fix for now (i.e. writes are guaranteed to succeed).\n\nThat said, I noticed some possible concurrency issues with the `DueDateTimerChecker`, which could lead to more timers than required being scheduled under high load.\n\nIf enabled, the `DueDateTimerChecker` runs in the asynchronous scheduler actor, separately from the stream processor.\n\nHowever, both actors will access the `DueDateTimerChecker`:\n\n`DueDateTimerChecker#scheduleTimer` is called from the engine/side-effects, i.e. processing actor. It then:\n\n- Accesses the following state: `shouldRescheduleChecker`, `checkerRunning`, `nextDueDate` (rw)\n- Checks if the checker is currently running. This is a non-volatile boolean check.\n- If it's not running, it schedules a task.\n\nAt the same time, scheduling is done on the async scheduler actor. This is the `TriggerEntitiesTask`. It:\n\n- Accesses the following state: `shouldRescheduleChecker`, `checkerRunning` (rw), `nextDueDate` (rw)\n\nIs this correct? If so we have non-volatile state being accessed by two different actors, and possibly some race conditions on when and if to schedule the next timer.\n\nMoving on the the possible solution. In order to keep it light of course, we'd need to to have a way to identify a timer trigger uniquely. Since every time instance can only be scheduled for trigger once in the state, it should be enough to distinguish them with the timer key, which is a single long. \n\nThe general idea, then, is to cache locally in the `DueDateTimerChecker` state (or some state) which commands have been written, so as to avoid writing them again. A perfect cache would be unbounded - you'd have to possibly store as many timers in there as could possibly exist (worst case scenario). But a lossy cache is probably acceptable. Take `LongHashSet` from Agrona - an empty, pre-initialized set instance of 1 million keys takes 8MB of memory. Filled, it takes about twice, ~16MB. It's a bit hard to add LRU behavior to such a set however. Eviction could be random to keep things simple/fast, or we can use a `SortedSet`. However, a `TreeSet` takes about ~60MB for 1 million longs, so it's already substantially heavier - but it's pretty easy/fast to add LRU eviction to it. So on the off chance the key was evicted _before_ it was removed explicitly from the cache, you'd potentially still write a second trigger command. But the bigger the cache, the less likely this is to happen.\n\nI sync'd with @Zelldon today about this, and we decided to move forward with the local cache, only for checkers which perform no inter-partition communication.\n\nFor timers, we'll use the timer key as the unique cache ID. When iterating of timers, if the timer key is in the cache, then we skip it. Once the task result is built, we can populate the cache with all the timer keys we will be writing. Since the scheduler (even async) is sequenced, we're guaranteed that this write will succeed, or the whole thing will fail (and the cache would be \"restarted\"). We won't be touching things like leader election and so on. On recovery, it's still possible that the same timers would be triggered twice, but the overload load will be greatly reduced.\n\nThis solution is likely adaptable to other checkers which run locally, such as job timeout and message expiry. For messages we can easily use the key. For jobs, we can't use the job key, since you can have multiple activations/time outs. We could use the job key if we can guarantee that the cache is properly cleaned up whenever the job is activated.\n\nAnyway, long winded comment to say we'll get started on a bounded lossy cache-based prototype.","author_login":"npepinpe","author_association":"MEMBER","created_at":"2023-11-06T16:45:46+08:00","repo_name":"camunda/zeebe","issue_id":1846746772,"issue_number":13870,"issue_url":"https://github.com/camunda/zeebe/issues/13870","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1802241351","fragment_type":"issue_comment","sequence":9,"text":"So in the end, we'll build the cache on the stream processor side. I describe the approach we ended up with in the description of this PR: URL \n\nLet me know if you have questions. For now it's entirely on the stream platform/ZDP side, but it's still useful to know how it works. Plus, if you want to cache future scheduled commands in the future, you'll need to know where to add them :upside_down_face:","author_login":"npepinpe","author_association":"MEMBER","created_at":"2023-11-08T16:27:49+08:00","repo_name":"camunda/zeebe","issue_id":1846746772,"issue_number":13870,"issue_url":"https://github.com/camunda/zeebe/issues/13870","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1803891746","fragment_type":"issue_comment","sequence":10,"text":"See some benchmark results courtesy of @Zelldon - URL :tada:","author_login":"npepinpe","author_association":"MEMBER","created_at":"2023-11-09T14:03:20+08:00","repo_name":"camunda/zeebe","issue_id":1846746772,"issue_number":13870,"issue_url":"https://github.com/camunda/zeebe/issues/13870","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1805701556","fragment_type":"issue_comment","sequence":11,"text":"We took it off the ZPA board, as ZDP has found a solution on their side 🙇 Thanks again @Zelldon and @npepinpe","author_login":"korthout","author_association":"MEMBER","created_at":"2023-11-10T13:09:57+08:00","repo_name":"camunda/zeebe","issue_id":1846746772,"issue_number":13870,"issue_url":"https://github.com/camunda/zeebe/issues/13870","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1806793306","fragment_type":"issue_comment","sequence":12,"text":"Hi!\n\nThis looks like a wonderful job. But this new timer cache doesn't solve my problem with bunch of UNIQUE timers from DIFFERENT process instances. I've illustrated my problem here URL My comment was stated as duplicate of this issue which was likely fixed with timer cache solution in PR #15136 (for 8.3).\n\nI could not understand how this cache solution will help me but had some hope and belief. Well, there no miracle happened.\nI've just tested on 8.3-stable\nimage\n\nThousands or millions of unique timer events still overload brokers:\nimage\n\nThis is my process with timer:\nimage","author_login":"dddpaul","author_association":"NONE","created_at":"2023-11-11T11:40:14+08:00","repo_name":"camunda/zeebe","issue_id":1846746772,"issue_number":13870,"issue_url":"https://github.com/camunda/zeebe/issues/13870","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1806797939","fragment_type":"issue_comment","sequence":13,"text":"We're working on another solution for that in parallel. URL \n\nI know the issue specifies IPC, but the proposed solution will enforce rate limits between the different categories, user submitted commands, internal/scheduled commands, and remote ones.","author_login":"npepinpe","author_association":"MEMBER","created_at":"2023-11-11T12:01:22+08:00","repo_name":"camunda/zeebe","issue_id":1846746772,"issue_number":13870,"issue_url":"https://github.com/camunda/zeebe/issues/13870","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0474","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Graceful shutdown consistently takes 90 seconds?","query_context":"Jan 13 02:50:04 azalea systemd[1]: Reached target System Power Off.\n░░ Subject: A start job for unit poweroff.target has finished successfully\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ A start job for unit poweroff.target has finished successfully.\n░░\n░░ The job identifier is 6768.\nJan 13 02:50:04 azalea systemd[1]: Shutting down.\nJan 13 02:50:04 azalea systemd-shutdown[1]: Syncing filesystems and block devices.\nJan 13 02:50:04 azalea systemd-shutdown[1]: Sending SIGTERM to remaining processes...\nJan 13 02:50:04 azalea systemd-journald[662]: Received SIGTERM from PID 1 (systemd-shutdow).\nJan 13 02:50:04 azalea systemd-journald[662]: Journal stopped\n░░ Subject: The journal has been stopped\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ The system journal process has shut down and closed all currently\n░░ active journal files.\n░░ The unit UNIT completed and consumed the indicated resources.\nJan 13 02:48:47 azalea kernel: ucsi_acpi USBC000:00: unknown error 256\nJan 13 02:48:47 azalea kernel: ucsi_acpi USBC000:00: GET_CABLE_PROPERTY failed (-5)\nJan 13 02:50:03 azalea systemd[1]: session-3.scope: Stopping timed out. Killing.\nJan 13 02:50:03 azalea systemd[1]: session-3.scope: Killing process 1879 (cosmic-settings) with signal SIGKILL.\nJan 13 02:50:03 azalea systemd[1]: session-3.scope: Killing process 1882 (ctrl-c) with signal SIGKILL.\nJan 13 02:50:03 azalea systemd[1]: session-3.scope: Failed with result 'timeout'.\n░░ Subject: Unit failed\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ The unit session-3.scope has entered the 'failed' state with result 'timeout'.\nJan 13 02:50:03 azalea systemd[1]: Stopped Session 3 of User sebastian.\n░░ Subject: A stop job for unit session-3.scope has finished\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ A stop job for unit session-3.scope has finished.\n░░\n░░ The job identifier is 6778 and the job result is done.\n\nI'm not entirely sure if this is something related to my hardware or with this flake. Has anybody else been able to reproduce?","known_context_document_ids":["gh_issue_2783393923"],"reference_answer":"Should be fixed now on main branch, please update this flake and remove any workarounds you might have had. Feel free to reopen if you're still having issues!","answer_document_id":"gh_comment_2565662751","silver_evidence_path":["gh_comment_2586604430","gh_issue_2707381654","gh_comment_2565662751"],"evidence_issue_ids":[2783393923,2707381654],"source_repo_name":"lilyinstarlight/nixos-cosmic","source_issue_id":2783393923,"source_issue_number":588,"source_issue_url":"https://github.com/lilyinstarlight/nixos-cosmic/issues/588","target_repo_name":"lilyinstarlight/nixos-cosmic","target_issue_id":2707381654,"target_issue_number":498,"target_issue_url":"https://github.com/lilyinstarlight/nixos-cosmic/issues/498","reference_anchor_document_id":"gh_comment_2586604430","reference_answer_author":"lilyinstarlight","reference_answer_author_association":"OWNER","quality_score":92.58,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0909,"anchor_target_overlap":0.0909,"target_answer_overlap":0.0588},"issue_created_at":"2025-01-13T09:07:54+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_2783393923","fragment_type":"issue_description","sequence":0,"text":"Graceful shutdown consistently takes 90 seconds\nJan 13 02:50:04 azalea systemd[1]: Reached target System Power Off.\n░░ Subject: A start job for unit poweroff.target has finished successfully\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ A start job for unit poweroff.target has finished successfully.\n░░\n░░ The job identifier is 6768.\nJan 13 02:50:04 azalea systemd[1]: Shutting down.\nJan 13 02:50:04 azalea systemd-shutdown[1]: Syncing filesystems and block devices.\nJan 13 02:50:04 azalea systemd-shutdown[1]: Sending SIGTERM to remaining processes...\nJan 13 02:50:04 azalea systemd-journald[662]: Received SIGTERM from PID 1 (systemd-shutdow).\nJan 13 02:50:04 azalea systemd-journald[662]: Journal stopped\n░░ Subject: The journal has been stopped\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ The system journal process has shut down and closed all currently\n░░ active journal files.\n░░ The unit UNIT completed and consumed the indicated resources.\nJan 13 02:48:47 azalea kernel: ucsi_acpi USBC000:00: unknown error 256\nJan 13 02:48:47 azalea kernel: ucsi_acpi USBC000:00: GET_CABLE_PROPERTY failed (-5)\nJan 13 02:50:03 azalea systemd[1]: session-3.scope: Stopping timed out. Killing.\nJan 13 02:50:03 azalea systemd[1]: session-3.scope: Killing process 1879 (cosmic-settings) with signal SIGKILL.\nJan 13 02:50:03 azalea systemd[1]: session-3.scope: Killing process 1882 (ctrl-c) with signal SIGKILL.\nJan 13 02:50:03 azalea systemd[1]: session-3.scope: Failed with result 'timeout'.\n░░ Subject: Unit failed\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ The unit session-3.scope has entered the 'failed' state with result 'timeout'.\nJan 13 02:50:03 azalea systemd[1]: Stopped Session 3 of User sebastian.\n░░ Subject: A stop job for unit session-3.scope has finished\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ A stop job for unit session-3.scope has finished.\n░░\n░░ The job identifier is 6778 and the job result is done.\n\nI'm not entirely sure if this is something related to my hardware or with this flake. Has anybody else been able to reproduce?","author_login":"sebastianrasor","author_association":"NONE","created_at":"2025-01-13T09:07:54+08:00","repo_name":"lilyinstarlight/nixos-cosmic","issue_id":2783393923,"issue_number":588,"issue_url":"https://github.com/lilyinstarlight/nixos-cosmic/issues/588","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2586569625","fragment_type":"issue_comment","sequence":1,"text":"The `ucsi_acpi` stuff is a Framework laptop red herring.\n\nJan 13 03:10:14 azalea cosmic-session[1831]: EXITING: received request to terminate\nJan 13 03:10:14 azalea cosmic-session[1831]: process 'ProcessKey(2v1)' cancelled\nJan 13 03:10:14 azalea systemd[1]: Stopping Session 3 of User sebastian...\n░░ Subject: A stop job for unit session-3.scope has begun execution\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ A stop job for unit session-3.scope has begun execution.\n░░\n░░ The job identifier is 2118.\nJan 13 03:11:44 azalea systemd[1]: session-3.scope: Stopping timed out. Killing.\nJan 13 03:11:44 azalea systemd[1]: session-3.scope: Killing process 1893 (cosmic-settings) with signal SIGKILL.\nJan 13 03:11:44 azalea systemd[1]: session-3.scope: Failed with result 'timeout'.\n░░ Subject: Unit failed\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ The unit session-3.scope has entered the 'failed' state with result 'timeout'.\nJan 13 03:11:44 azalea systemd[1]: Stopped Session 3 of User sebastian.\n░░ Subject: A stop job for unit session-3.scope has finished\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ A stop job for unit session-3.scope has finished.\n░░\n░░ The job identifier is 2118 and the job result is done.\nJan 13 03:11:44 azalea systemd[1]: session-3.scope: Consumed 57.600s CPU time, 1.6G memory peak, 364M read from disk, 348K written to disk.\n░░ Subject: Resources consumed by unit runtime\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ The unit session-3.scope completed and consumed the indicated resources.\n\nIt looks like for some reason `cosmic-settings` is holding up the graceful termination of the user session?","author_login":"sebastianrasor","author_association":"NONE","created_at":"2025-01-13T09:16:12+08:00","repo_name":"lilyinstarlight/nixos-cosmic","issue_id":2783393923,"issue_number":588,"issue_url":"https://github.com/lilyinstarlight/nixos-cosmic/issues/588","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2586580694","fragment_type":"issue_comment","sequence":2,"text":"Some more seemingly relevant logs:\n\nJan 13 03:10:14 azalea cosmic-session[1831]: EXITING: received request to terminate\nJan 13 03:10:14 azalea cosmic-session[1831]: process 'ProcessKey(2v1)' cancelled\nJan 13 03:10:14 azalea pipewire[2149]: mod.x11-bell: X11 I/O error handler called on display :1\nJan 13 03:10:14 azalea pipewire[2149]: mod.x11-bell: X11 display (:1) has encountered a fatal I/O error\nJan 13 03:10:14 azalea .xdg-desktop-po[2488]: Error reading events from display: Broken pipe\nJan 13 03:10:14 azalea org.freedesktop.secrets[2545]: discover_other_daemon: 1\nJan 13 03:10:14 azalea systemd[1786]: xdg-desktop-portal-gtk.service: Main process exited, code=exited, status=1/FAILURE\nJan 13 03:10:14 azalea systemd[1786]: xdg-desktop-portal-gtk.service: Failed with result 'exit-code'.\nJan 13 03:10:14 azalea systemd[1786]: cosmic-app-library.scope: Consumed 171ms CPU time, 67M memory peak.\nJan 13 03:10:14 azalea systemd[1786]: cosmic-osd.scope: Consumed 177ms CPU time, 70.2M memory peak.\nJan 13 03:10:14 azalea systemd[1786]: cosmic-bg.scope: Consumed 298ms CPU time, 129.9M memory peak.\nJan 13 03:10:14 azalea systemd[1786]: xdg-desktop-portal-cosmic.scope: Consumed 221ms CPU time, 64M memory peak.\nJan 13 03:10:14 azalea systemd[1786]: cosmic-files-applet.scope: Consumed 540ms CPU time, 65.3M memory peak.\nJan 13 03:10:14 azalea pipewire[2149]: pw.node: (alsa_output.pci-0000_c1_00.6.analog-stereo-59) graph xrun not-triggered (0 suppressed)\nJan 13 03:10:14 azalea pipewire[2149]: pw.node: (alsa_output.pci-0000_c1_00.6.analog-stereo-59) xrun state:0x7ff18403b008 pending:1/1 s:934034164248 a:934034287623 f:9>\nJan 13 03:10:14 azalea systemd[1786]: app-cosmic-com.system76.CosmicAppList-2759.scope: Consumed 4min 29.541s CPU time, 4.1G memory peak.\nJan 13 03:11:44 azalea systemd[1786]: Activating special unit Exit the Session...\nJan 13 03:11:44 azalea systemd[1786]: Stopped target Main User Target.\nJan 13 03:11:44 azalea systemd[1786]: Stopped target Current graphical user session.\nJan 13 03:11:44 azalea systemd[1786]: Stopped target Startup of XDG autostart applications.\nJan 13 03:11:44 azalea systemd[1786]: Stopped target Cosmic Session Target.\nJan 13 03:11:44 azalea systemd[1786]: Stopped target Session services which should run early before the graphical session is brought up.\n\nI'm not really sure why `Activating special unit Exit the Session...` is delayed by 90 seconds.","author_login":"sebastianrasor","author_association":"NONE","created_at":"2025-01-13T09:21:22+08:00","repo_name":"lilyinstarlight/nixos-cosmic","issue_id":2783393923,"issue_number":588,"issue_url":"https://github.com/lilyinstarlight/nixos-cosmic/issues/588","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2586597116","fragment_type":"issue_comment","sequence":3,"text":"I think this `cosmic-session[1831]: process 'ProcessKey(2v1)' cancelled` is the key line here. Not sure what `ProcessKey(2v1)` means but that's the last line for `cosmic-session` in that boot. I think this line indicates that for some reason, `cosmic-session`'s graceful shutdown handling is getting interrupted by something so it can't tell systemd that it's done shutting down.","author_login":"sebastianrasor","author_association":"NONE","created_at":"2025-01-13T09:28:54+08:00","repo_name":"lilyinstarlight/nixos-cosmic","issue_id":2783393923,"issue_number":588,"issue_url":"https://github.com/lilyinstarlight/nixos-cosmic/issues/588","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2586604430","fragment_type":"issue_comment","sequence":4,"text":"Just saw URL looks like i'm currently on an older commit than the fix for that so I'm gonna update and see if that fixes things.\n\n├───nixos-cosmic: github:lilyinstarlight/nixos-cosmic/847b93e3b63bcea9a477dd86bb4b56ce7e051f0e?narHash=sha256-Tm%2BBsKXJS/EdJd9DvLxDbw%2BchPI1o7A9RHKIFxho36I%3D (2024-12-25 01:36:23)","author_login":"sebastianrasor","author_association":"NONE","created_at":"2025-01-13T09:32:32+08:00","repo_name":"lilyinstarlight/nixos-cosmic","issue_id":2783393923,"issue_number":588,"issue_url":"https://github.com/lilyinstarlight/nixos-cosmic/issues/588","linked_issue_ids":[2707381654],"is_known_query_context":false},{"document_id":"gh_issue_2707381654","fragment_type":"issue_description","sequence":0,"text":"Shutdown takes a long time if GeoClue2 service is not enabled\nNot sure if this is a bug or not, but I noticed that shutdown my machine would take a long time (around 1 to 2 minutes) because I didn't have the `GeoClue2` service running and because of that I would get these error messages:\n\ncosmic-session[1938]: Failed to watch theme org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.GeoClue2 was not provided by any .service files. Will try again in 25s\n\nThis would make systemd timeout trying to stop session 3 of my user. Taking around 1m 30s during the shutdown process.\n\nAdding this to my config seems to fix the issue:\n\nservices.geoclue2.enable = true;\n\nMaybe a note about this should be in the troubleshot part of the README?","author_login":"sezaru","author_association":"NONE","created_at":"2024-11-30T13:49:29+08:00","repo_name":"lilyinstarlight/nixos-cosmic","issue_id":2707381654,"issue_number":498,"issue_url":"https://github.com/lilyinstarlight/nixos-cosmic/issues/498","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2537808616","fragment_type":"issue_comment","sequence":1,"text":"Thank you for finding out the reason for session 3 interrupting shutdown!","author_login":"wramalho","author_association":"NONE","created_at":"2024-12-12T04:49:50+08:00","repo_name":"lilyinstarlight/nixos-cosmic","issue_id":2707381654,"issue_number":498,"issue_url":"https://github.com/lilyinstarlight/nixos-cosmic/issues/498","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2565662751","fragment_type":"issue_comment","sequence":2,"text":"Should be fixed now on main branch, please update this flake and remove any workarounds you might have had. Feel free to reopen if you're still having issues!","author_login":"lilyinstarlight","author_association":"OWNER","created_at":"2024-12-30T16:04:14+08:00","repo_name":"lilyinstarlight/nixos-cosmic","issue_id":2707381654,"issue_number":498,"issue_url":"https://github.com/lilyinstarlight/nixos-cosmic/issues/498","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0486","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Confusing which Xcode I'm using with a nightly toolchain?","query_context":"Now that Xcode 16 Beta is out I have two Xcodes installed on my machine. I have also downloaded the nightly build of the 6.0 Swift toolchain. Sometimes I want to use it with Xcode 15, sometimes with Xcode 16 Beta. When I use the command to select a Swift toolchain it's confusing which Xcode it's actually using. It would be nice if I could select that separately from the toolchain selection. At the end of they day, they are different environment variables on Mac, DEVELOPER_DIR and TOOLCHAINS.","known_context_document_ids":["gh_issue_2360603876"],"reference_answer":"There's also the option of just adding to the terminal environment directly using the `ExtensionContext`:\n\ntypescript\ncontext.environmentVariableCollection.clear();\ncontext.environmentVariableCollection.prepend(\n \"PATH\",\n \"/path/to/usr/bin:\",\n { applyAtShellIntegration: true }\n);\nfor (const variable in configuration.swiftEnvironmentVariables) {\n context.environmentVariableCollection.replace(\n variable,\n configuration.swiftEnvironmentVariables[variable],\n { applyAtShellIntegration: true }\n );\n}\n\nUsing this approach the user will have the environment automatically populated in their VS Code terminal without having to launch a special profile. The only minor annoyance being that modifying certain variables (e.g. `PATH`) triggers a warning before the terminal will be updated:\n\n<img width=\"522\" alt=\"Screenshot 2024-06-27 at 2 30 02 PM\" src=\" URL","answer_document_id":"gh_comment_2195430213","silver_evidence_path":["gh_comment_2179046624","gh_issue_2362568103","gh_comment_2195430213"],"evidence_issue_ids":[2360603876,2362568103],"source_repo_name":"swiftlang/vscode-swift","source_issue_id":2360603876,"source_issue_number":911,"source_issue_url":"https://github.com/swiftlang/vscode-swift/issues/911","target_repo_name":"swiftlang/vscode-swift","target_issue_id":2362568103,"target_issue_number":914,"target_issue_url":"https://github.com/swiftlang/vscode-swift/issues/914","reference_anchor_document_id":"gh_comment_2179046624","reference_answer_author":"matthewbastien","reference_answer_author_association":"MEMBER","quality_score":87.65,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1562,"anchor_target_overlap":0.2059,"target_answer_overlap":0.093},"issue_created_at":"2024-06-18T19:58:57+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_2360603876","fragment_type":"issue_description","sequence":0,"text":"Confusing which Xcode I'm using with a nightly toolchain\nNow that Xcode 16 Beta is out I have two Xcodes installed on my machine. I have also downloaded the nightly build of the 6.0 Swift toolchain. Sometimes I want to use it with Xcode 15, sometimes with Xcode 16 Beta. When I use the command to select a Swift toolchain it's confusing which Xcode it's actually using. It would be nice if I could select that separately from the toolchain selection. At the end of they day, they are different environment variables on Mac, DEVELOPER_DIR and TOOLCHAINS.","author_login":"dschaefer2","author_association":"NONE","created_at":"2024-06-18T19:58:57+08:00","repo_name":"swiftlang/vscode-swift","issue_id":2360603876,"issue_number":911,"issue_url":"https://github.com/swiftlang/vscode-swift/issues/911","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2177049849","fragment_type":"issue_comment","sequence":1,"text":"When you select an Xcode installation you are selecting the toolchain from that Xcode install. If you select a toolchain install it isn't using your Xcode install at all, outside of one thing, the xctest library. I'm not certain offhand which Xcode version of xctest it would be using. Maybe @matthewbastien who wrote the toolchain select can answer that. \n\nIf you are using swift-testing selecting a toolchain install should mean you aren't using an Xcode install at all. In theory you shouldn't even need Xcode installed. I haven't tested that though. \n\nWe are not using the DEVELOPER_DIR or TOOLCHAINS environment variables.","author_login":"adam-fowler","author_association":"CONTRIBUTOR","created_at":"2024-06-18T21:32:42+08:00","repo_name":"swiftlang/vscode-swift","issue_id":2360603876,"issue_number":911,"issue_url":"https://github.com/swiftlang/vscode-swift/issues/911","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2177187089","fragment_type":"issue_comment","sequence":2,"text":"Just for clarity, swift-testing is included in the Xcode 16 Beta. This means that if you are using Xcode and then switch to a toolchain install you may need to explicitly specify swift-testing as a dependency.","author_login":"plemarquand","author_association":"CONTRIBUTOR","created_at":"2024-06-18T22:21:55+08:00","repo_name":"swiftlang/vscode-swift","issue_id":2360603876,"issue_number":911,"issue_url":"https://github.com/swiftlang/vscode-swift/issues/911","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2177981294","fragment_type":"issue_comment","sequence":3,"text":"You'd need to do the same if your package is compiled on Linux. I am assuming this will not be necessary once Swift 6 has a proper release though.","author_login":"adam-fowler","author_association":"CONTRIBUTOR","created_at":"2024-06-19T07:41:02+08:00","repo_name":"swiftlang/vscode-swift","issue_id":2360603876,"issue_number":911,"issue_url":"https://github.com/swiftlang/vscode-swift/issues/911","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2178876706","fragment_type":"issue_comment","sequence":4,"text":"I wonder if that's what we should be doing on macOS. That would allow us to be consistent with the command line experience.\n\nThough as it is, if you swift build from the terminal inside VSCode you actually get different settings right now.","author_login":"dschaefer2","author_association":"NONE","created_at":"2024-06-19T14:38:20+08:00","repo_name":"swiftlang/vscode-swift","issue_id":2360603876,"issue_number":911,"issue_url":"https://github.com/swiftlang/vscode-swift/issues/911","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2179046624","fragment_type":"issue_comment","sequence":5,"text":"Yeah not ideal\n\nEven if we used DEVELOPER_DIR we'd have this situation. We cannot affect the environment variables for the whole of VSCode, only the processes we start eg swift build etc. The terminals are setup by VSCode not the extension. There is a thing called a terminal profile, which can be used to setup a custom environment See #914 , I don't know if that affects all terminals, or add a new type of terminal.","author_login":"adam-fowler","author_association":"CONTRIBUTOR","created_at":"2024-06-19T16:03:55+08:00","repo_name":"swiftlang/vscode-swift","issue_id":2360603876,"issue_number":911,"issue_url":"https://github.com/swiftlang/vscode-swift/issues/911","linked_issue_ids":[2362568103],"is_known_query_context":false},{"document_id":"gh_comment_2189954095","fragment_type":"issue_comment","sequence":6,"text":"My thoughts so far are that there are two scenarios here when the user selects a toolchain:\n\n1. An Xcode toolchain is selected in which case we should be setting `DEVELOPER_DIR` to the Xcode path.\n2. A public/nightly toolchain is selected which is a bit trickier. If there are multiple Xcodes installed on the system then we should ask the user which Xcode they want to select - like the `Swift: Select Xcode Developer Dir...` command we used to have before the toolchain selection obsoleted it.\n\nIt really boils down to the fact that we should be setting `DEVELOPER_DIR` if there are multiple Xcodes installed on the system. The `TOOLCHAINS` environment variable is also straightforward to set alongside our `swift.path` configuration which I can experiment with. I'm working on a PR to push up that folks can try out.","author_login":"matthewbastien","author_association":"MEMBER","created_at":"2024-06-25T20:56:22+08:00","repo_name":"swiftlang/vscode-swift","issue_id":2360603876,"issue_number":911,"issue_url":"https://github.com/swiftlang/vscode-swift/issues/911","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2191997077","fragment_type":"issue_comment","sequence":7,"text":"A twist in all this is that the CommandLineTools doesn't support the `TOOLCHAINS` env var. That makes me much less enthusiastic about relying on it.\n\nFor cross platform, I can see a scenario where the user does an `xcode-select --install` to get a minimal development environment and then installs the latest Swift toolchain for things like Swift Embedded. But we'll need to actually set the PATH to the toolchain to pick that up properly.","author_login":"dschaefer2","author_association":"NONE","created_at":"2024-06-26T15:28:16+08:00","repo_name":"swiftlang/vscode-swift","issue_id":2360603876,"issue_number":911,"issue_url":"https://github.com/swiftlang/vscode-swift/issues/911","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2362568103","fragment_type":"issue_description","sequence":0,"text":"Swift terminal profile\n**Is your feature request related to a problem? Please describe.**\nI've made the mistake a few times where I have select a toolchain in vscode and it has been built for via tasks. I then go to the integrated vscode terminal to issue to run some swift command that is a different version of swift.\n\n**Describe the solution you'd like**\nYou can provide different terminal profiles URL so we could provide a Swift terminal profile with selected toolchain in the PATH so that user can select this swift profile in settings, for example `terminal.integrated.defaultProfile.osx`\n\n**Describe alternatives you've considered**\nN/A\n\n**Additional context**\nN/A","author_login":"award999","author_association":"CONTRIBUTOR","created_at":"2024-06-19T14:46:33+08:00","repo_name":"swiftlang/vscode-swift","issue_id":2362568103,"issue_number":914,"issue_url":"https://github.com/swiftlang/vscode-swift/issues/914","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2195430213","fragment_type":"issue_comment","sequence":1,"text":"There's also the option of just adding to the terminal environment directly using the `ExtensionContext`:\n\ntypescript\ncontext.environmentVariableCollection.clear();\ncontext.environmentVariableCollection.prepend(\n \"PATH\",\n \"/path/to/usr/bin:\",\n { applyAtShellIntegration: true }\n);\nfor (const variable in configuration.swiftEnvironmentVariables) {\n context.environmentVariableCollection.replace(\n variable,\n configuration.swiftEnvironmentVariables[variable],\n { applyAtShellIntegration: true }\n );\n}\n\nUsing this approach the user will have the environment automatically populated in their VS Code terminal without having to launch a special profile. The only minor annoyance being that modifying certain variables (e.g. `PATH`) triggers a warning before the terminal will be updated:\n\n<img width=\"522\" alt=\"Screenshot 2024-06-27 at 2 30 02 PM\" src=\" URL","author_login":"matthewbastien","author_association":"MEMBER","created_at":"2024-06-27T18:32:37+08:00","repo_name":"swiftlang/vscode-swift","issue_id":2362568103,"issue_number":914,"issue_url":"https://github.com/swiftlang/vscode-swift/issues/914","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2200045572","fragment_type":"issue_comment","sequence":2,"text":"@matthewbastien so that appears every time you start up a terminal window or only for existing terminal windows?","author_login":"adam-fowler","author_association":"CONTRIBUTOR","created_at":"2024-07-01T12:43:28+08:00","repo_name":"swiftlang/vscode-swift","issue_id":2362568103,"issue_number":914,"issue_url":"https://github.com/swiftlang/vscode-swift/issues/914","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2206283258","fragment_type":"issue_comment","sequence":3,"text":"@adam-fowler the warning will only appear for existing terminal windows that need to be reloaded to capture new environment variables.","author_login":"matthewbastien","author_association":"MEMBER","created_at":"2024-07-03T14:26:01+08:00","repo_name":"swiftlang/vscode-swift","issue_id":2362568103,"issue_number":914,"issue_url":"https://github.com/swiftlang/vscode-swift/issues/914","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2206877363","fragment_type":"issue_comment","sequence":4,"text":"@matthewbastien if I disable `swift.enableTerminalEnvironment` and then create a new terminal with the swift profile, `swift.swiftEnvironmentVariables` values are added but `which swift` still indicates `/usr/bin/swift` is being used not the selected toolchain path.","author_login":"award999","author_association":"CONTRIBUTOR","created_at":"2024-07-03T17:37:53+08:00","repo_name":"swiftlang/vscode-swift","issue_id":2362568103,"issue_number":914,"issue_url":"https://github.com/swiftlang/vscode-swift/issues/914","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0487","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Better ways to introspect? --> JSON representation of HDC-API?","query_context":"Currently it's a cumbersome mixture of very specific Commands and Properties, which don't scale nicely.\nIt also feels as if it weren't tailored to its use-cases.\n\nDiscarded as bad Idea: A single command with multiple arguments: \n - GetIntrospection(item_type=command, item_id=0xF0, aspect_id=0xF0)\n - That's cumbersome, too, because we need to introduce new tables for item_types and aspect_ids\n - Command returns var data-type\n\nPotentially better idea: A single command without any arguments, which returns a machine-parseable syntax detailing all details about a whole feature. What could such a simple enough syntax be, which …\n - … a microcontroller can generate on the fly, by composing it directly into the TX buffer.\n - … a tool can translate into source-code for proxy-stubs or for descriptors for devices implemented in other languages, i.e. a \"digital twin\" implemented in Python.\n - … a host can use to dynamically create proxy objects.\n - … is human readable.\n\n How about JSON?\nFind out by implementing a proof-of-concept firmware that generates it on-the-fly from descriptor data.","known_context_document_ids":["gh_issue_1437547785"],"reference_answer":"Thanks to the improvements obtained in #21, we should certainly allow this.\nThe reason being, that custom feature states are much more valuable if their meaning is documented. \n(Lesson learned from the \"Architecting a Bridge\" manifesto: Automate documentation!)\n\nNote how there's no need to make this mandatory. Firmware developers who do not need this feature can just omit it.","answer_document_id":"gh_comment_1312065329","silver_evidence_path":["gh_comment_1304905800","gh_issue_1436967946","gh_comment_1312065329"],"evidence_issue_ids":[1437547785,1436967946],"source_repo_name":"kiksotik/hdc","source_issue_id":1437547785,"source_issue_number":21,"source_issue_url":"https://github.com/kiksotik/hdc/issues/21","target_repo_name":"kiksotik/hdc","target_issue_id":1436967946,"target_issue_number":18,"target_issue_url":"https://github.com/kiksotik/hdc/issues/18","reference_anchor_document_id":"gh_comment_1304905800","reference_answer_author":"kiksotik","reference_answer_author_association":"OWNER","quality_score":85.33,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0667,"anchor_target_overlap":0.4,"target_answer_overlap":0.1333},"issue_created_at":"2022-11-06T21:34:23+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_1437547785","fragment_type":"issue_description","sequence":0,"text":"Better ways to introspect? --> JSON representation of HDC-API\nCurrently it's a cumbersome mixture of very specific Commands and Properties, which don't scale nicely.\nIt also feels as if it weren't tailored to its use-cases.\n\nDiscarded as bad Idea: A single command with multiple arguments: \n - GetIntrospection(item_type=command, item_id=0xF0, aspect_id=0xF0)\n - That's cumbersome, too, because we need to introduce new tables for item_types and aspect_ids\n - Command returns var data-type\n\nPotentially better idea: A single command without any arguments, which returns a machine-parseable syntax detailing all details about a whole feature. What could such a simple enough syntax be, which …\n - … a microcontroller can generate on the fly, by composing it directly into the TX buffer.\n - … a tool can translate into source-code for proxy-stubs or for descriptors for devices implemented in other languages, i.e. a \"digital twin\" implemented in Python.\n - … a host can use to dynamically create proxy objects.\n - … is human readable.\n\n How about JSON?\nFind out by implementing a proof-of-concept firmware that generates it on-the-fly from descriptor data.","author_login":"kiksotik","author_association":"OWNER","created_at":"2022-11-06T21:34:23+08:00","repo_name":"kiksotik/hdc","issue_id":1437547785,"issue_number":21,"issue_url":"https://github.com/kiksotik/hdc/issues/21","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1304905800","fragment_type":"issue_comment","sequence":1,"text":"Related to #16 and #18, which might benefit from a more scalable solution that may allow to include or omit those aspects, without having to change the API of mandatory Commands/Properties.","author_login":"kiksotik","author_association":"OWNER","created_at":"2022-11-06T22:03:49+08:00","repo_name":"kiksotik/hdc","issue_id":1437547785,"issue_number":21,"issue_url":"https://github.com/kiksotik/hdc/issues/21","linked_issue_ids":[1436967946],"is_known_query_context":false},{"document_id":"gh_comment_1310295173","fragment_type":"issue_comment","sequence":2,"text":"To get a feeling about how it would look like, I quickly implemented a descriptor serializer that produces strict JSON in Python:\nJSON_minimal_device.txt","author_login":"kiksotik","author_association":"OWNER","created_at":"2022-11-10T13:38:48+08:00","repo_name":"kiksotik/hdc","issue_id":1437547785,"issue_number":21,"issue_url":"https://github.com/kiksotik/hdc/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1311788032","fragment_type":"issue_comment","sequence":3,"text":"It is surprisingly feasible and convenient to have a C implementation of the HDC packetizer, which is able to cope with a stream of data whose length is unknown ahead of time. This is a prerequisite for the device firmware to be able to reply with a dynamically generated JSON representation of its HDC interface. \nImplemented it as HDC_Compose_Packets_From_Stream(), which in 812b171ac8158b3d6aeacde0243294a39d32e64c still coexists with its predecessor HDC_Compose_Packets_From_Pieces(), but will soon replace it.\n\nSurprisingly the new implementation is not only more capable, but also has a smaller footprint:\nimage","author_login":"kiksotik","author_association":"OWNER","created_at":"2022-11-11T14:54:21+08:00","repo_name":"kiksotik/hdc","issue_id":1437547785,"issue_number":21,"issue_url":"https://github.com/kiksotik/hdc/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1311998026","fragment_type":"issue_comment","sequence":4,"text":"Although re-implementing the C packetizer was initially motivated to enable the streaming of dynamically generated JSON, it turns out that it also had advantages for the existing use-cases. \nThe new implementation has a smaller footprint and its source-code is much more readable.\nSee commit: 47afdbb0eab29e84bc4a1c698975a1f2c8738cfa \nimage","author_login":"kiksotik","author_association":"OWNER","created_at":"2022-11-11T17:53:57+08:00","repo_name":"kiksotik/hdc","issue_id":1437547785,"issue_number":21,"issue_url":"https://github.com/kiksotik/hdc/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1436967946","fragment_type":"issue_description","sequence":0,"text":"Name and docstring for each State a Feature may be at.\nWhich are the states and their meanings that each featrure's state-machine implements?\nCurrently reference-implementations use an poor in between: A free-form string Feature.FeatureStatesDescription property with a recommendation on how the syntax could be. That's a recipe for disaster.\nThis is similar to #16 , the actual question is: How much introspection do we need? Is it sufficient to address it like a free-form docstring, or shoul we go for strict machine-readable API? How much of it should be mandatory? Can we relax some aspects to be just optional?","author_login":"kiksotik","author_association":"OWNER","created_at":"2022-11-05T10:44:32+08:00","repo_name":"kiksotik/hdc","issue_id":1436967946,"issue_number":18,"issue_url":"https://github.com/kiksotik/hdc/issues/18","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1312065329","fragment_type":"issue_comment","sequence":1,"text":"Thanks to the improvements obtained in #21, we should certainly allow this.\nThe reason being, that custom feature states are much more valuable if their meaning is documented. \n(Lesson learned from the \"Architecting a Bridge\" manifesto: Automate documentation!)\n\nNote how there's no need to make this mandatory. Firmware developers who do not need this feature can just omit it.","author_login":"kiksotik","author_association":"OWNER","created_at":"2022-11-11T18:45:43+08:00","repo_name":"kiksotik/hdc","issue_id":1436967946,"issue_number":18,"issue_url":"https://github.com/kiksotik/hdc/issues/18","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0491","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"úložiště - zobrazení struktury ve stromu?","query_context":"V úložišti v panelu se zobrazením Tabulka a Mřížka by se hodila i možnost zobrazení ve stromu, aby se nemuselo postupně proklikávat po úrovních.","known_context_document_ids":["gh_issue_1434530878"],"reference_answer":"No ona to nebyla vteřina, bez refreshe nám to nešlo. Ale dneska už je to OK, tak nevím, jestli už jsi s tím něco dělal, nebo se ProArc jen potřeboval prospat.","answer_document_id":"gh_comment_1558566604","silver_evidence_path":["gh_comment_1486767192","gh_issue_1509052415","gh_comment_1558566604"],"evidence_issue_ids":[1434530878,1509052415],"source_repo_name":"proarc/proarc-client","source_issue_id":1434530878,"source_issue_number":258,"source_issue_url":"https://github.com/proarc/proarc-client/issues/258","target_repo_name":"proarc/proarc-client","target_issue_id":1509052415,"target_issue_number":282,"target_issue_url":"https://github.com/proarc/proarc-client/issues/282","reference_anchor_document_id":"gh_comment_1486767192","reference_answer_author":"luckajirku","reference_answer_author_association":"COLLABORATOR","quality_score":75.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.0,"anchor_target_overlap":0.375,"target_answer_overlap":0.15},"issue_created_at":"2022-11-03T11:50:17+08:00","valid_comment_count":57,"fragments":[{"document_id":"gh_issue_1434530878","fragment_type":"issue_description","sequence":0,"text":"úložiště - zobrazení struktury ve stromu\nV úložišti v panelu se zobrazením Tabulka a Mřížka by se hodila i možnost zobrazení ve stromu, aby se nemuselo postupně proklikávat po úrovních.","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2022-11-03T11:50:17+08:00","repo_name":"proarc/proarc-client","issue_id":1434530878,"issue_number":258,"issue_url":"https://github.com/proarc/proarc-client/issues/258","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1347954885","fragment_type":"issue_comment","sequence":1,"text":"Vyberu si ve stromu číslo periodika, udělám změnu v popisu strany, dám uložit - a strom se mi sbalí. Nejde to udělat tak, aby zůstal rozbalený, jak byl?","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2022-12-13T08:57:08+08:00","repo_name":"proarc/proarc-client","issue_id":1434530878,"issue_number":258,"issue_url":"https://github.com/proarc/proarc-client/issues/258","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1352705806","fragment_type":"issue_comment","sequence":2,"text":"Ještě se zeptám. Je technicky možné to potom předělat tak, aby ten strom nefungoval jen jako informativní zobrazení té struktury, ale že by se v něm dalo pracovat? Aby měl stejnou lištu jako tabulka a šlo v něm třeba vytvářet a přesouvat objekty (typicky ročníky a čísla u periodik)? Jen se ptám, jestli by to vůbec šlo.","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2022-12-15T08:19:25+08:00","repo_name":"proarc/proarc-client","issue_id":1434530878,"issue_number":258,"issue_url":"https://github.com/proarc/proarc-client/issues/258","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1352748250","fragment_type":"issue_comment","sequence":3,"text":"Pujde to. Ale nebude to okamzite. Ted jsem pouzil strom, ktery mame od zacatku.\nPro implementaci vsech tech funkcionalit bych mel vytvorit uplne nove. Ale, slo by to :)","author_login":"albertoh","author_association":"CONTRIBUTOR","created_at":"2022-12-15T09:02:01+08:00","repo_name":"proarc/proarc-client","issue_id":1434530878,"issue_number":258,"issue_url":"https://github.com/proarc/proarc-client/issues/258","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1352923877","fragment_type":"issue_comment","sequence":4,"text":"Tak to je super. Ono se to bude hodit mj. pro zjednodušení zakládání nových ročníků/čísel/příloh periodik (kde to nejde udělat přes \"vytvořit více\") a rozřazování stran do objektů... že už by pak nebylo nutné pracovat ve dvou záložkách.\nMám na to zakládat nové issue, nebo budeme pokračovat tady?","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2022-12-15T11:27:05+08:00","repo_name":"proarc/proarc-client","issue_id":1434530878,"issue_number":258,"issue_url":"https://github.com/proarc/proarc-client/issues/258","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1352950509","fragment_type":"issue_comment","sequence":5,"text":"Klidne tady. Muzeme definovat vsechno co bude umet ten strom.","author_login":"albertoh","author_association":"CONTRIBUTOR","created_at":"2022-12-15T11:53:23+08:00","repo_name":"proarc/proarc-client","issue_id":1434530878,"issue_number":258,"issue_url":"https://github.com/proarc/proarc-client/issues/258","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1363715912","fragment_type":"issue_comment","sequence":6,"text":"Teď jsem narazila na další věc. Jsem v periodiku, mám otevřené různé panely vč. stromu. Udělám na úrovni ročníku změnu v metadatech, uložím. Změna se mi ukáže okamžitě v tabulce, mřížce... Ale ve stromu se ukáže jen v případě, že v tom panelu mám označenou právě tu úroveň, kterou měním. Pokud mám tam označenou jinou úroveň, musí dát refresh, aby se změna ukázala i ve stromu. \nstrom_akt1\nstrom_akt2","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2022-12-23T08:06:36+08:00","repo_name":"proarc/proarc-client","issue_id":1434530878,"issue_number":258,"issue_url":"https://github.com/proarc/proarc-client/issues/258","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1367209833","fragment_type":"issue_comment","sequence":7,"text":"@SmejkalovaAnna Prosím, koukni se na tuhle novou funkci - díky.","author_login":"ZdenkaSera","author_association":"NONE","created_at":"2022-12-29T10:10:48+08:00","repo_name":"proarc/proarc-client","issue_id":1434530878,"issue_number":258,"issue_url":"https://github.com/proarc/proarc-client/issues/258","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1376823009","fragment_type":"issue_comment","sequence":8,"text":"Oprava metadat už se propíše hned i do stromu, to už je OK.\nAle ještě se strom neaktualizuje, pokud přesunu sken na jinou pozici. Abych to ve stromu viděla, musím dát refresh.","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-01-10T07:10:04+08:00","repo_name":"proarc/proarc-client","issue_id":1434530878,"issue_number":258,"issue_url":"https://github.com/proarc/proarc-client/issues/258","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1376995684","fragment_type":"issue_comment","sequence":9,"text":"To bych probral na schuzce... Me se nelibi, a myslim si, ze bude delat problemy pravem se stromem stavajici zpusob chovani: menime poradi, ale jen docasne nez ulozime zmeny. Pro strom je to problem, proto, ze pri kliknuti na polozku stazneme data z jadra, a tam nejsou zmeny. To je duvod proc jsem pri tahani objektu do stromu hned se objevi hlasku pro podtvrzeni zmen.","author_login":"albertoh","author_association":"CONTRIBUTOR","created_at":"2023-01-10T09:53:18+08:00","repo_name":"proarc/proarc-client","issue_id":1434530878,"issue_number":258,"issue_url":"https://github.com/proarc/proarc-client/issues/258","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1422138302","fragment_type":"issue_comment","sequence":10,"text":"Trochu nás překvapilo, že nastavení sloupců stromu, které mají být vidět, funguje jen v Hledat, ale u stromu v panelu ne. Nedalo by se to přebírat i sem? Nebo to bude potřeba řešit jako extra nastavení?","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-02-08T07:23:32+08:00","repo_name":"proarc/proarc-client","issue_id":1434530878,"issue_number":258,"issue_url":"https://github.com/proarc/proarc-client/issues/258","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1486767192","fragment_type":"issue_comment","sequence":11,"text":"tohle bychom určitě měli řešit minimálně při rozřazování stran - viz URL","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-03-28T12:11:35+08:00","repo_name":"proarc/proarc-client","issue_id":1434530878,"issue_number":258,"issue_url":"https://github.com/proarc/proarc-client/issues/258","linked_issue_ids":[1509052415],"is_known_query_context":false},{"document_id":"gh_comment_1495742593","fragment_type":"issue_comment","sequence":12,"text":"Prosím, proberete to na schůzce 18.3.? Dávám sem štítek redesign a odebírám k testu.","author_login":"ZdenkaSera","author_association":"NONE","created_at":"2023-04-04T10:41:28+08:00","repo_name":"proarc/proarc-client","issue_id":1434530878,"issue_number":258,"issue_url":"https://github.com/proarc/proarc-client/issues/258","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1744450254","fragment_type":"issue_comment","sequence":13,"text":"@luckajirku @albertoh Navrhuji tohle řešit společně s issue URL - do rozvoje bychom to zahrnuli jako společný bod něcoi ve smyslu rozvoje funkcí stromového zobrazení v klientovi. Souhlasíte?","author_login":"ZdenkaSera","author_association":"NONE","created_at":"2023-10-03T08:21:34+08:00","repo_name":"proarc/proarc-client","issue_id":1434530878,"issue_number":258,"issue_url":"https://github.com/proarc/proarc-client/issues/258","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2399245834","fragment_type":"issue_comment","sequence":14,"text":"Domluva na schůzce 8.10.2024: zavíráme, budeme zakládat issues na jednotlivé požadavky úpravy chování stromu.","author_login":"ZdenkaSera","author_association":"NONE","created_at":"2024-10-08T08:49:35+08:00","repo_name":"proarc/proarc-client","issue_id":1434530878,"issue_number":258,"issue_url":"https://github.com/proarc/proarc-client/issues/258","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1509052415","fragment_type":"issue_description","sequence":0,"text":"Řešení ukládání stran do různých objektů - rozřazování do čísel per. apod.\nSoučasné řešení ukládání stran do jiných objektů klikáním na Přesunout dost zdržuje. Ta fce je fajn, když člověk potřebuje jen výjimečně přesunout pár špatně umístěných stran, ale třeba na rozukládání celého ročníku periodika do čísel to není.\nVe starém člověk přepnul do editoru, tam měl rozbalený strom toho periodika a postupně uložil vše do jednotlivých čísel. Přitom krásně viděl celé per. a mohl si to kontrolovat, strom zůstával rozbalený. Jak by to šlo řešit tady? Současné řešení je nepoužitelné - resp. je to pomalé a méně přehledné - a spíš se takhle udělá chyba, že se uloží ty strany jinam než patří. \nMrkněte na to prosím vás z jiných knihoven, já si moc nedovedu představit takhle dělat nějakou větší dávku.","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2022-12-23T08:28:15+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1367215610","fragment_type":"issue_comment","sequence":1,"text":"@nezbedova @SmejkalovaAnna Prosím, mohly byste se na tohle podívat z pohledu rutinního provozu - periodika, stt přívazky ... ? Moc děkuji.","author_login":"ZdenkaSera","author_association":"NONE","created_at":"2022-12-29T10:19:52+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1370905674","fragment_type":"issue_comment","sequence":2,"text":"Já se na to podívám, až to bude zase fungovat, teď jsem zadávala issue URL nicméně @luckajirku Lucko nestačilo by jen to vyřešit tak, kdyby při dalším otevřením okna (klepnutím na šipičku) tam zůstalo naposledy otevřený (resp. cílový objekt) v rozbaleném stromě? Jako dřív?","author_login":"SmejkalovaAnna","author_association":"NONE","created_at":"2023-01-04T13:04:13+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1372176991","fragment_type":"issue_comment","sequence":3,"text":"To je ale jenom část. Jedna věc je, že si to má pamatovat, kam jsem naposledy přesouvala. Druhá pak, že pokud přesouvám třeba 300 stran do 50 výtisků nebo příloh, potřebuju mít tu agendu otevřenou, dokud nepřesunu poslední strany. A ne padesátkrát klikat na přesouvací ikonu. Vyskakovací okno dává smysl, pokud se dá pracovat jen v něm - pokud musím překlikávat, tak je to zdlouhavější než ve starém, kde se to dělalo po přepnutí do editoru nadřazených objektů.\n@albertoh, nedalo by se to vyskakovací okně rozdělit (stejně jako u fce Označit řadu), abychom tam pak měli v levém sloupci otevřený ten původní objekt s uloženou celou dávkou, a až ve druhém sloupci pak hledání v úložišti? A v levém bych si to označila, v pravém našla, kam to chci uložit, uložila, zaktualizovaly by se automaticky oba sloupce, zas bych vlevo označila další strany, vpravo bych naklikla další výtisk atd. A okno by se zavřelo až po posledním přesunu.","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-01-05T12:52:38+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1372199611","fragment_type":"issue_comment","sequence":4,"text":"A tohle je ještě ten jednodušší případ, kdy jde čísla vytvořit přes více a nachystat si je předem - a v tomhle kroku se \"jen\" rozřazuje. \nPak je ten případ, kdy se čísla zakládají jednotlivě a je potřeba mít k tomu skeny a opisovat údaje z nich - to se teď dělá ve dvou záložkách (v jedné otevřené skeny, ve druhé periodikum - struktura + metadata) a bylo by fajn najít způsob, jak to moci dělat v jedné obrazovce a hned ukládat do nově vytvořeného objektu i ty skeny.","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-01-05T13:11:52+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1375219969","fragment_type":"issue_comment","sequence":5,"text":"Nasadil jsem novou verzi kde je mozne menit nadrazeneho pomoci pretahovani objektu z panelu vazeb do panelu se stromem.\nPri pohybu se mozne cile obarvy zelene nebo cervene podle povolenych vazeb. (@pkudela udela peknejsi disajn, zatim jde o funkcnosti)\n\nimage\n\n Zaroven, dialog zmeny nadrazeneho objektu jsem zmenil tak, ze lze hledat vsechny modely, ale tlacitko \"presunout\" je aktivni jen pri vyberu objektu s povolenou vazbou\n\nimage\n\nimage","author_login":"albertoh","author_association":"CONTRIBUTOR","created_at":"2023-01-09T07:51:54+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1376888717","fragment_type":"issue_comment","sequence":6,"text":"To hledání a (ne)umožnění uložení podle vazeb je super.\nAle to rozukládávání do čísel je pořád nevyřešené.","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-01-10T08:21:06+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1376999832","fragment_type":"issue_comment","sequence":7,"text":"Rozukladavani jsem resil pomoci tahani z panelu vazeb na strom","author_login":"albertoh","author_association":"CONTRIBUTOR","created_at":"2023-01-10T09:56:43+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1377036629","fragment_type":"issue_comment","sequence":8,"text":"On problém je v tom, že ten strom zrcadlí tabulku/náhledy..., kdežto ten editor nadřazených objektů ve starém umožňoval mít to PŘEHLEDNĚ otevřené na jiné úrovni. \nA je otázka, nakolik je to tahání myší dobré (je to rychlé, ale zas snadněji se strany uloží jinam, než patří) - k tomu už kdysi probíhala diskuse:-).","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-01-10T10:25:01+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1424230488","fragment_type":"issue_comment","sequence":9,"text":"Předělat dialog ukládání do objektu tak, aby zůstal označený poslední objekt, do kterého bylo uloženo. Pokud ukládám poprvé není označené nic, ale musím objekt vyhledat.","author_login":"SykoraLukas","author_association":"CONTRIBUTOR","created_at":"2023-02-09T13:57:51+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1468032579","fragment_type":"issue_comment","sequence":10,"text":"Toto je opravdu potřeba dodělat - pro instituce, které dělají periodika, je to dost zásadní.","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-03-14T12:40:25+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1471623753","fragment_type":"issue_comment","sequence":11,"text":"Na schůzce 15.3. potvrzeno, že zadání je v této fázi postačující.","author_login":"ZdenkaSera","author_association":"NONE","created_at":"2023-03-16T09:46:37+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1473972040","fragment_type":"issue_comment","sequence":12,"text":"Predelal jsem chovani dialogu pro vyberu nadrazeneho objekta.\nTed si pamatuje posledni pouzivany, a pri otevreni se automaticky vybere.","author_login":"albertoh","author_association":"CONTRIBUTOR","created_at":"2023-03-17T14:58:17+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1477727241","fragment_type":"issue_comment","sequence":13,"text":"@albertoh pořád to není ono:-). Člověk musí označit strany, kliknout na přesunout atd. a pak zase označit další, zase kliknout na přesunout... Zbytečné klikání - a pro rozukládávání velkého množství stran je to nepoužitelné. Už jsem to psala tady URL","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-03-21T12:08:36+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[1509052415],"is_known_query_context":false},{"document_id":"gh_comment_1481196594","fragment_type":"issue_comment","sequence":14,"text":"@albertoh je k tomu od nás potřeba ještě něco dovysvětlit, ukázat, jak se to používá atd.? a bude to v té verzi, která bude od pondělí k testu, už dořešené?","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-03-23T13:29:04+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1481262108","fragment_type":"issue_comment","sequence":15,"text":"Ne ne, uz na tom delam. \nJakmile budu mit funkcionalitu, predam Petrovi aby to dal do krasy.\nKazdopadne, pracuju na tom tak, ze nove, ten dialog bude mit tri casti (jako Oznacit radu):\n - vlevo seznam objektu na presouvani v tabulce\n - uprostred hledani\n - vpravo strom hledaneho objekta\n -\nPri posouvani objektu zustavame tam, aby se dalo vybirat dalsi v leve tabulce.\n\nJe to ono?","author_login":"albertoh","author_association":"CONTRIBUTOR","created_at":"2023-03-23T14:06:45+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1481292413","fragment_type":"issue_comment","sequence":16,"text":"možná bych to radši zkoukla dřív, než se to \"dá do krásy\", ať se to kdyžtak nečeše zbytečně:-). nevím, jestli to dobře chápu.\nteď v tom vyskakovacím okně bude ve druhém a třetím sloupci to, co je teď ve starém pod sebou? uprostřed bude jen výběr titulu a vpravo bude strom toho vybraného?","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-03-23T14:23:54+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1481341352","fragment_type":"issue_comment","sequence":17,"text":"Ošklivé je v pohodě, jen je tam dost cestování po obrazovce. Označím vlevo, najdu uprostřed, pak musím úplně doprava, tam si označím, pak zas úplně doleva potvrdit přesun. Ve starém bylo celé to hledání vč. stromu pod sebou. Málokdy se jedna dávka rozřazuje do různých titulů, takže tu prostřední část využiješ na začátku a pak už ne. No, dá se to asi řešit tak, že si vyhledám titul a pak ten prostřední sloupec zúžím tak, že už nepřekáží, ale zas tím přijdu o takovou tu ujišťovací pohledovou kontrolu, že jsem ve správném titulu...","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-03-23T14:54:24+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1481345027","fragment_type":"issue_comment","sequence":18,"text":"Takze radsi vlevo vyber objektu k presouvani, a vpravo hledani a pod nim cil?","author_login":"albertoh","author_association":"CONTRIBUTOR","created_at":"2023-03-23T14:56:32+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1482438436","fragment_type":"issue_comment","sequence":19,"text":"Tak ještě něco - chybí tam náhled. Takže přeci jen by tam měl být třetí sloupec, ale v něm by měl být náhled (poslední nakliknuté) stránky. (Stejně jako to je v tom okně pro Označit řadu.)\n\nA další věc - bylo by možné, aby v hlavičce toho prvního sloupce bylo vidět, odkud se to přesouvá? Ve starém vidím číslo a datum vydání - ideální by teda bylo, kdyby tam byl vidět i titul. Šlo by to tam přidat? Aby tam bylo něco takového, jak je to na liště v Hledat, když se proklikávám níž:\nhlavickazdroj","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-03-24T08:38:33+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1482439736","fragment_type":"issue_comment","sequence":20,"text":"@albertoh \n\n`Málokdy se jedna dávka rozřazuje do různých titulů, takže tu prostřední část využiješ na začátku a pak už ne.` \n\nA u nás z jedné dávky STT rozdělujeme do různých titulů (i 80 adligátů), takže jsem to chtěla vyzkoušet, ale nejde mi to. Naskočí tabulka a točí se kolečko. Nevím, zda postupuji správně.","author_login":"nezbedova","author_association":"NONE","created_at":"2023-03-24T08:39:40+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1482867535","fragment_type":"issue_comment","sequence":21,"text":"@luckajirku jak se ma prosim jmenovat ten dialog? \"Vyberte nadrazeny\" nebo \"Vyberte nadrazeny objekt\" nebo neco jineho?\n\n<img width=\"302\" alt=\"image\" src=\" URL","author_login":"pkudela","author_association":"CONTRIBUTOR","created_at":"2023-03-24T14:10:52+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1483223093","fragment_type":"issue_comment","sequence":22,"text":"@pkudela Mám problém při testování. Po zavření okna mám mlhu.\n\nobrazek\n\nA když jsem chtěla připojit soubory po novém importu k titulu pomocí tlačítka Pokračovat, tak mám chybu. A nevídím Orázek. \n\n@albertoh Netestuji brzy? Neděláte na tom ještě?","author_login":"nezbedova","author_association":"NONE","created_at":"2023-03-24T18:13:31+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1483252673","fragment_type":"issue_comment","sequence":23,"text":"@albertoh Zkusila jsem. Mám i nové okno i anonymní okno. Po pokusu o změnu nastavení rozložení oken pro editaci mám mlhu. Musím dát refresh nebo kliknout jinam (např. Správa dávek). Pak se vrátím/pokračuji k metadatovému popisu a to už vidím zobrazení jak jsem to nastavila. obrázek nevidím ani při editaci ani při přesunu.\nPo Pokračovat mám chybu.\nobrazek\n\nChrom i Mozila.","author_login":"nezbedova","author_association":"NONE","created_at":"2023-03-24T18:38:29+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1483306009","fragment_type":"issue_comment","sequence":24,"text":"@albertoh Obrázek vidím, ale nemohu připojit do objektu.\n\nobrazek","author_login":"nezbedova","author_association":"NONE","created_at":"2023-03-24T19:26:14+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1484699284","fragment_type":"issue_comment","sequence":25,"text":"@nezbedova @luckajirku Prosím, máme chtít s tímhle omezením vydat verzi klienta? Osobně bych byla pro ji vydat a tento týden testovat podle plánu. Děkuji.","author_login":"ZdenkaSera","author_association":"NONE","created_at":"2023-03-27T08:12:19+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1484704269","fragment_type":"issue_comment","sequence":26,"text":"@ZdenkaSera za nás je to v pořádku, i ve starém se celá dávka ukládá na jedno místo - a to, jestli by to šlo rozřazovat už třeba v importu, a jak přesně by to mělo fungovat, to je na další vývoj.","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-03-27T08:15:57+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1484732926","fragment_type":"issue_comment","sequence":27,"text":"Ne, toto v současnosti není možné a bylo by to velmi komplikované to dovolit už v importu. \n\nBuďto je možnost si to rozřadit ještě před importem nebo to udělat až když je uloženo do aplikace.","author_login":"SykoraLukas","author_association":"CONTRIBUTOR","created_at":"2023-03-27T08:35:32+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1484776728","fragment_type":"issue_comment","sequence":28,"text":"Tak pokud tohle není příprava na tu možnost už v importu, tak by se to mělo chovat a vypadat asi malinko jinak - jestli tam jdu z importu přes Pokračovat, nebo jestli rozukládávám v úložišti přes Přesunout. V importu by měla být jiná obrazovka, kde nebude Přesunout, ale Uložit dávku atd. \nJinak teď nevím, kam to psát, protože se to týká toho prvotního uložení z importu, ale teď je to tak divně spojené tím stejným vyskakovacím oknem. Narazili jsme ještě na to, že když dám uložit/přesunout tu dávku v importu a po uložení dám Otevřít v editoru, tak se to pod tím otevře, ale to vyskakovací okno tam zůstává viset. Zavřít ho můžu, ale pokud volím možnost otevřít v editoru, očekávám, že se mi tohle zavře a ocitnu se hned v tom objektu v editoru.","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-03-27T09:06:24+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1484781548","fragment_type":"issue_comment","sequence":29,"text":"@luckajirku @nezbedova Můžeme se v tom případě domluvit, že tohle bude k diskusi na schůzce 18.4.?","author_login":"ZdenkaSera","author_association":"NONE","created_at":"2023-03-27T09:09:22+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1484919230","fragment_type":"issue_comment","sequence":30,"text":"Děkuji za reakce.\n\n@albertoh Prosím, vydáš tedy během dneška verzi, abychom mohli nasadit s novým jádrem? Děkuji.","author_login":"ZdenkaSera","author_association":"NONE","created_at":"2023-03-27T10:46:35+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1485074727","fragment_type":"issue_comment","sequence":31,"text":"Nejde vydat release. Asi github ma problemy. Zkusim jeste pozdeji","author_login":"albertoh","author_association":"CONTRIBUTOR","created_at":"2023-03-27T13:11:50+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1485084482","fragment_type":"issue_comment","sequence":32,"text":"Třeba se github kousl, protože tuší, že je tam potřeba ještě nějaké věci opravit:-)","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-03-27T13:22:58+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1486623383","fragment_type":"issue_comment","sequence":33,"text":"V základu to funguje dobře, ale měl by se po uložení stran zaktualizovat strom. Uživatel by měl mít možnost si hned zkontrolovat, že se tam ty strany přesunuly. Ve starém po přesunu sice ten editor s uložením zmizí, ale po vybrání další strany se tam objeví a přesunuté strany jsou už vidět na novém místě. V klientovi zmizí ze starého umístění, ale v novém vidět nejsou.","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-03-28T10:40:54+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1487125769","fragment_type":"issue_comment","sequence":34,"text":"Souhlasím s @luckajirku. Při rozřazení např. do čísel periodik je třeba kontrolovat, jestli se to přesunulo správně a logičtější je to dělat přímo v tom vyskakovacím okně. Jinak ostatní chování otestováno a je OK.","author_login":"katerinasirova","author_association":"NONE","created_at":"2023-03-28T15:31:03+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1490149940","fragment_type":"issue_comment","sequence":35,"text":"@albertoh prosím tě, jak tohle vidíš? vím, že jsi v tom issue pro strom psal, že je problém s aktualizací, pokud se přesune objekt v tabulce a ještě není uložená změna, ale tady k uložení změny už došlo, takže to je trochu jiný případ a problém by tam být neměl, ne?","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-03-30T11:37:56+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1490166637","fragment_type":"issue_comment","sequence":36,"text":"Tenhle je jiny strom. On neovlivnuje veci editoru. Tady to udelam. Ale ne tenhle tyden, jak jsme se domluvili","author_login":"albertoh","author_association":"CONTRIBUTOR","created_at":"2023-03-30T11:48:24+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1498555077","fragment_type":"issue_comment","sequence":37,"text":"Pořád ne:-). Strom se obnovuje, ale po uložení není vybraný poslední objekt, do kterého se přesouvalo. Pokud okno zavřu a znovu otevřu, pak se to posune na ten správný, ale jinak si to drží ten poslední objekt z předchozího použití fce Přesunout. Potřebujeme, aby se to posouvalo na poslední vybraný objekt už během toho jednoho rozukládávání, jako to funguje ve starém.","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-04-06T06:25:13+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1503251567","fragment_type":"issue_comment","sequence":38,"text":"Jo, tohle už je ono, aktualizuje se to správně a označuje se to, co má. \nJen ta hláška asi musí ještě dozrát... Zatím se ukazuje tohle:\neditor.children.relocate_dialog.titleRepo\neditor.children.relocate_dialog.messageRepo","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-04-11T12:38:29+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1557190692","fragment_type":"issue_comment","sequence":39,"text":"tak už se nám to zase rozbilo - asi s tou opravou posouvání lišty. Když přesunu strany, uložím a dám zavřít, tak mám v úložišti krásně šedé prázdno - až po F5 se obsah načte.","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-05-22T13:07:28+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1557249655","fragment_type":"issue_comment","sequence":40,"text":"Funguje to dal. Akorat je tam vterina v sede. Nesouvisi to s tim posouvanim. \nStava se kdyz mam editor metadat. Hledam pricinu","author_login":"albertoh","author_association":"CONTRIBUTOR","created_at":"2023-05-22T13:45:15+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1558566604","fragment_type":"issue_comment","sequence":41,"text":"No ona to nebyla vteřina, bez refreshe nám to nešlo. Ale dneska už je to OK, tak nevím, jestli už jsi s tím něco dělal, nebo se ProArc jen potřeboval prospat.","author_login":"luckajirku","author_association":"COLLABORATOR","created_at":"2023-05-23T05:45:59+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1558689311","fragment_type":"issue_comment","sequence":42,"text":"Zatim nic nedelal, ale chci to zlepsit. Ten editor metadat ted se nacita hodne dlouho. To je kvuli to rozbaleni...","author_login":"albertoh","author_association":"CONTRIBUTOR","created_at":"2023-05-23T07:26:42+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1560704764","fragment_type":"issue_comment","sequence":43,"text":"Ted se pri obnoveni objevuje \"loading bar\" nahore, aby bylo jasne, ze obrazovka neztuhla, jen dumaaa :)","author_login":"albertoh","author_association":"CONTRIBUTOR","created_at":"2023-05-24T08:47:57+08:00","repo_name":"proarc/proarc-client","issue_id":1509052415,"issue_number":282,"issue_url":"https://github.com/proarc/proarc-client/issues/282","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0493","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Support arrays in generated equals function?","query_context":"`toString` and `hashCode` already support this. `data class`es do not, and have an IDE warning about it.\n\nIt should be fairly trivial to add support, I'm just not sure if it's a good idea to. It may be unexpected behavior?","known_context_document_ids":["gh_issue_577568685"],"reference_answer":"Or if not, we could make it `compileOnly` for non-native targets only, I imagine.\n\nAnnoying that end-consumers will have to download the Poko deps for no reason, but I agree it's not a deal-breaker and can be a future optimization. Closing!","answer_document_id":"gh_comment_1668408861","silver_evidence_path":["gh_comment_1563359450","gh_issue_1726316390","gh_comment_1668408861"],"evidence_issue_ids":[577568685,1726316390],"source_repo_name":"drewhamilton/Poko","source_issue_id":577568685,"source_issue_number":1,"source_issue_url":"https://github.com/drewhamilton/Poko/issues/1","target_repo_name":"drewhamilton/Poko","target_issue_id":1726316390,"target_issue_number":142,"target_issue_url":"https://github.com/drewhamilton/Poko/issues/142","reference_anchor_document_id":"gh_comment_1563359450","reference_answer_author":"drewhamilton","reference_answer_author_association":"OWNER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1176,"anchor_target_overlap":0.1765,"target_answer_overlap":0.1176},"issue_created_at":"2020-03-08T21:25:03+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_577568685","fragment_type":"issue_description","sequence":0,"text":"Support arrays in generated equals function\n`toString` and `hashCode` already support this. `data class`es do not, and have an IDE warning about it.\n\nIt should be fairly trivial to add support, I'm just not sure if it's a good idea to. It may be unexpected behavior?","author_login":"drewhamilton","author_association":"OWNER","created_at":"2020-03-08T21:25:03+08:00","repo_name":"drewhamilton/Poko","issue_id":577568685,"issue_number":1,"issue_url":"https://github.com/drewhamilton/Poko/issues/1","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1547993425","fragment_type":"issue_comment","sequence":1,"text":"Would you consider making it opt-in with some mechanism? Probably with an annotation like `@ByContent` or `@ContentBased` or something?","author_login":"JakeWharton","author_association":"NONE","created_at":"2023-05-15T14:35:39+08:00","repo_name":"drewhamilton/Poko","issue_id":577568685,"issue_number":1,"issue_url":"https://github.com/drewhamilton/Poko/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1548235671","fragment_type":"issue_comment","sequence":2,"text":"Yeah I'll consider it. I've held on to a \"just do what data classes do except for the one thing\" approach for this long, but there's an ever-growing list of interesting features to consider adding so maybe it's time to bite that bullet.\n\nOne small challenge is that I currently include the `poko-annotations` dep by default, but allow substituting a custom annotation. If I add more annotations, do I want to allow them to all be customizable, or just drop that feature and force the default annotations dep? Probably the latter but that's a breaking change.\n\nIs Redwood using arrays for performance or another reason? I had the thought of wrapping your arrays in value classes with custom `equals` overrides, but that isn't supported yet and may be syntactically annoying for your use case.","author_login":"drewhamilton","author_association":"OWNER","created_at":"2023-05-15T17:08:14+08:00","repo_name":"drewhamilton/Poko","issue_id":577568685,"issue_number":1,"issue_url":"https://github.com/drewhamilton/Poko/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1548249515","fragment_type":"issue_comment","sequence":3,"text":"It is for performance, yes. Some of our code runs inside a JS engine where `Array` translates directly to JS's native array whereas `List` is a few Kotlin classes wrapped around an `Array` which adds a lot of copies for things like expansion. Since the only types which interact with these arrays are generated classes, we don't need to worry about the ergonomics as much.","author_login":"JakeWharton","author_association":"NONE","created_at":"2023-05-15T17:18:34+08:00","repo_name":"drewhamilton/Poko","issue_id":577568685,"issue_number":1,"issue_url":"https://github.com/drewhamilton/Poko/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1548258671","fragment_type":"issue_comment","sequence":4,"text":"So Poko being JVM-only is probably going to block your adoption too? 😬","author_login":"drewhamilton","author_association":"OWNER","created_at":"2023-05-15T17:26:15+08:00","repo_name":"drewhamilton/Poko","issue_id":577568685,"issue_number":1,"issue_url":"https://github.com/drewhamilton/Poko/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1548263332","fragment_type":"issue_comment","sequence":5,"text":"Well, yes. But that's fixable with some PRs!\n\nWanted to make sure use cases were covered first. Although we only need this for two or _maybe_ three types so writing equals/hashCode manually for them wouldn't have been the end of the world.","author_login":"JakeWharton","author_association":"NONE","created_at":"2023-05-15T17:28:28+08:00","repo_name":"drewhamilton/Poko","issue_id":577568685,"issue_number":1,"issue_url":"https://github.com/drewhamilton/Poko/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1550362474","fragment_type":"issue_comment","sequence":6,"text":"Kotlin's decision to avoid special array-handling in data class equals functions is for JVM-specific reasons. Is it the case that JS native arrays are also not compared by content? Or are the Redwood classes targeting JVM along with JS?","author_login":"drewhamilton","author_association":"OWNER","created_at":"2023-05-16T21:06:05+08:00","repo_name":"drewhamilton/Poko","issue_id":577568685,"issue_number":1,"issue_url":"https://github.com/drewhamilton/Poko/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1550581787","fragment_type":"issue_comment","sequence":7,"text":"Correct. They mirror the JVM semantics. You must use contentEquals/HashCode/ToString to get the contents rather than the array reference to be used.\n \n\nWe target JVM, JS, and many native targets with this code, yes. The efficiency gains are paltry on non-JS platforms.","author_login":"JakeWharton","author_association":"NONE","created_at":"2023-05-17T02:03:54+08:00","repo_name":"drewhamilton/Poko","issue_id":577568685,"issue_number":1,"issue_url":"https://github.com/drewhamilton/Poko/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1552328388","fragment_type":"issue_comment","sequence":8,"text":"Some notes as I dive deeper – everything I mention here for data classes is also true for Poko classes:\n* Data classes do consider content for array-typed properties when computing `hashCode` and `toString`. `equals` is the only one for which array content is ignored.\n* Data classes do *not* consider content for `Any`-typed properties that are arrays at runtime when computing `hashCode` and `toString`, so Poko would need to implement its own handling for this.\n* Data class handling of `hashCode` and `toString` for arrays is specifically built in to the IR compiler. Poko would need its own `arrayMemberEqualsSymbol`, and figure out how to map that to the platform-specific `Array.equals` equivalent (I think this is called \"lowering\"?).\n* Need to decide whether to handle nested array types (`Array >`) – that would be `Arrays.deepEquals` on JVM, and the `hashCode` and `toString` implementations would need to be updated to do this too since they currently don't handle nested arrays. Incidentally, `deepEquals` *does* handle Array members even if they are typed `Any`.\n* Kotlin's stdlib has `contentEquals` and friends defined in common code, so mayyybe this can be referenced without any platform-specific handling?\n\nI added #135 to test the current handling of arrays in the sample project.","author_login":"drewhamilton","author_association":"OWNER","created_at":"2023-05-18T02:42:29+08:00","repo_name":"drewhamilton/Poko","issue_id":577568685,"issue_number":1,"issue_url":"https://github.com/drewhamilton/Poko/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1560308648","fragment_type":"issue_comment","sequence":9,"text":"Confirmed that calling common-code stdlib functions from generated IR code is supported, which simplifies this a lot. 🎉\n\nI plan to:\n1. Add the new annotation as an experimental API.\n2. Implement `contentEquals` for all typed and primitive array types.\n3. Handle `contentDeepEquals` for nested array types, updating `hashCode` and `toString` accordingly.\n4. Handle `Any` properties that are arrays at runtime.\n5. Flesh out the path forward for custom annotation consumers – probably deprecate this feature.","author_login":"drewhamilton","author_association":"OWNER","created_at":"2023-05-24T00:58:15+08:00","repo_name":"drewhamilton/Poko","issue_id":577568685,"issue_number":1,"issue_url":"https://github.com/drewhamilton/Poko/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1563359450","fragment_type":"issue_comment","sequence":10,"text":"Simple array content support is enabled in the latest `0.14.0-SNAPSHOT`, implemented in #141. Not sure if it's possible for Redwood to try it out on just the JVM, otherwise I filed #142 for multiplatform support.","author_login":"drewhamilton","author_association":"OWNER","created_at":"2023-05-25T18:48:12+08:00","repo_name":"drewhamilton/Poko","issue_id":577568685,"issue_number":1,"issue_url":"https://github.com/drewhamilton/Poko/issues/1","linked_issue_ids":[1726316390],"is_known_query_context":false},{"document_id":"gh_issue_1726316390","fragment_type":"issue_description","sequence":0,"text":"Support multiplatform\nI never really knew what `data class` did on other platforms, but it sounds like they generate the exact same functions that they do on the JVM. Since Poko is implemented in IR, it should theoretically \"just work\" for other platform targets.\n\nHaven't done much with Kotlin multiplatform so help and/or PRs are welcome.\n\nSteps to support multiplatform:\n- [x] Update annotation module structure to multiplatform\n- [x] Update Gradle plugin to apply to all platforms\n- [x] Add compiler tests for additional platforms\n- [x] Create sample project(s) for additional platform(s)\n- [x] Update CI to build and test all platforms\n- [x] Determine best use of `implementation` vs. `compileOnly`\n- [x] Update CI to publish all platforms","author_login":"drewhamilton","author_association":"OWNER","created_at":"2023-05-25T18:44:58+08:00","repo_name":"drewhamilton/Poko","issue_id":1726316390,"issue_number":142,"issue_url":"https://github.com/drewhamilton/Poko/issues/142","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1655034464","fragment_type":"issue_comment","sequence":1,"text":"Oh yeah, forgot I switched to the publish plugin that does that for free","author_login":"drewhamilton","author_association":"OWNER","created_at":"2023-07-28T05:16:30+08:00","repo_name":"drewhamilton/Poko","issue_id":1726316390,"issue_number":142,"issue_url":"https://github.com/drewhamilton/Poko/issues/142","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1668408861","fragment_type":"issue_comment","sequence":2,"text":"Or if not, we could make it `compileOnly` for non-native targets only, I imagine.\n\nAnnoying that end-consumers will have to download the Poko deps for no reason, but I agree it's not a deal-breaker and can be a future optimization. Closing!","author_login":"drewhamilton","author_association":"OWNER","created_at":"2023-08-07T18:45:14+08:00","repo_name":"drewhamilton/Poko","issue_id":1726316390,"issue_number":142,"issue_url":"https://github.com/drewhamilton/Poko/issues/142","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0498","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"ParseOptions: Add `read_tags`?","query_context":"### Summary\n\nUnexpectedly, many projects pull in Lofty *solely* for its property reading. Each time it is used for this purpose, however, all of the tags are still being parsed unnecessarily.\n\nJust as one can skip property reading with `ParseOptions::read_properties(false)`, it may be worth adding `ParseOptions::read_tags()`.\n\n### API design\n\nrust\nimpl ParseOptions {\n pub fn read_tags(&mut self, read_tags: bool) -> Self;\n}","known_context_document_ids":["gh_issue_1893302202"],"reference_answer":"Kid3 puts markers to show that you can add another tag to the file, not necessarily that it's present, BTW.\n \n\nYeah, I haven't actually seen anyone make use of TagLib's `StringHandler`. I imagine in most cases no errors are noticed since Picard (and likely other tools) add an ID3v2 tag for compatibility. The real issue here is that in Lofty it's a hard error, rather than a discard & warn.","answer_document_id":"gh_comment_2466916028","silver_evidence_path":["gh_comment_2156182298","gh_issue_2235598020","gh_comment_2466916028"],"evidence_issue_ids":[1893302202,2235598020],"source_repo_name":"Serial-ATA/lofty-rs","source_issue_id":1893302202,"source_issue_number":251,"source_issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/251","target_repo_name":"Serial-ATA/lofty-rs","target_issue_id":2235598020,"target_issue_number":373,"target_issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/373","reference_anchor_document_id":"gh_comment_2156182298","reference_answer_author":"Serial-ATA","reference_answer_author_association":"OWNER","quality_score":94.15,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0769,"anchor_target_overlap":0.1538,"target_answer_overlap":0.1026},"issue_created_at":"2023-09-12T21:26:53+08:00","valid_comment_count":19,"fragments":[{"document_id":"gh_issue_1893302202","fragment_type":"issue_description","sequence":0,"text":"ParseOptions: Add `read_tags`\n### Summary\n\nUnexpectedly, many projects pull in Lofty *solely* for its property reading. Each time it is used for this purpose, however, all of the tags are still being parsed unnecessarily.\n\nJust as one can skip property reading with `ParseOptions::read_properties(false)`, it may be worth adding `ParseOptions::read_tags()`.\n\n### API design\n\nrust\nimpl ParseOptions {\n pub fn read_tags(&mut self, read_tags: bool) -> Self;\n}","author_login":"Serial-ATA","author_association":"OWNER","created_at":"2023-09-12T21:26:53+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":1893302202,"issue_number":251,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/251","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2155894037","fragment_type":"issue_comment","sequence":1,"text":"hello, it would be great to be able to do `ParseOptions::read_tags()`. Or wouldn't we have to use a [features] for this? Because in my case I wouldn't need the tags at all.","author_login":"vincehi","author_association":"NONE","created_at":"2024-06-08T09:37:51+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":1893302202,"issue_number":251,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/251","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2156033772","fragment_type":"issue_comment","sequence":2,"text":"@vincehi Hello!\n\nThere wouldn't need to be a feature for this. Since `read_properties` already exists, this would act the same. When parsing, the tags will just be skipped and stored as their defaults (`Id3v2Tag::default()`, etc.).","author_login":"Serial-ATA","author_association":"OWNER","created_at":"2024-06-08T13:15:32+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":1893302202,"issue_number":251,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/251","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2156054745","fragment_type":"issue_comment","sequence":3,"text":"Does this seem complicated to you? I preferred to use taglib even though it also analyses tags even though I don't need it, but it doesn't crash on the file format (UTF-...). On the other hand, the length recovered is in milisecond on lofty, which is very convenient for me.","author_login":"vincehi","author_association":"NONE","created_at":"2024-06-08T14:20:05+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":1893302202,"issue_number":251,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/251","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2156056464","fragment_type":"issue_comment","sequence":4,"text":"No, it'd be a pretty quick feature to add. I just haven't bothered since I've been working on more requested features.\n \n\nCan you make issues for any crashes you have with Lofty? There haven't been any text encoding issues that I'm aware of.","author_login":"Serial-ATA","author_association":"OWNER","created_at":"2024-06-08T14:25:56+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":1893302202,"issue_number":251,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/251","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2156182298","fragment_type":"issue_comment","sequence":5,"text":"I think I had the same problem as this person URL But if I understand correctly, it's on the read tags, not on the read properties. So if in future I could bypass the read tags that would be great.","author_login":"vincehi","author_association":"NONE","created_at":"2024-06-08T21:01:44+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":1893302202,"issue_number":251,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/251","linked_issue_ids":[2235598020],"is_known_query_context":false},{"document_id":"gh_comment_2156682190","fragment_type":"issue_comment","sequence":6,"text":"Yeah, this would avoid the error in #373 entirely. I'll see about getting this in 0.21.0.","author_login":"Serial-ATA","author_association":"OWNER","created_at":"2024-06-09T16:10:10+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":1893302202,"issue_number":251,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/251","linked_issue_ids":[2235598020],"is_known_query_context":false},{"document_id":"gh_issue_2235598020","fragment_type":"issue_description","sequence":0,"text":"Wav: Failed to read RIFF INFO item value\n### Reproducer\n\nI tried this code:\n\nrust \nlet tagged_file: Option = match lofty::read_from_path(\n \"C:\\\\Users\\\\ferry\\\\Music\\\\test\\\\大哉乾元(洛天依人声版)_MMM.wav\",\n ) {\n Ok(value) => Some(value),\n Err(err) => {\n // Wav: Failed to read RIFF INFO item value\n println!(\"{}\", err);\n None\n }\n };\n\nThe lofty version is \"0.18.2\" \nimage\n\n### Summary\n\nThere is an error \"Wav: Failed to read RIFF INFO item value\" \n\nThe Windows Properties page can read the tags in it. I can also play it on Windows Media Player.\n\nCan anyone provide some information about this? Thanks.\n\n### Expected behavior\n\nRead tag correctly.\n\n### Assets\n\n大哉乾元(洛天依人声版)_MMM.wav","author_login":"Ferry-200","author_association":"NONE","created_at":"2024-04-10T13:25:27+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":2235598020,"issue_number":373,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/373","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2047599391","fragment_type":"issue_comment","sequence":1,"text":"Hello!\n\nYour file has items that are not UTF-8 encoded. What is your local character encoding? If Windows is able to read it, that means the file is using your system encoding.","author_login":"Serial-ATA","author_association":"OWNER","created_at":"2024-04-10T13:47:57+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":2235598020,"issue_number":373,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/373","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2047712466","fragment_type":"issue_comment","sequence":2,"text":"UTF-16.\nAnd the file's title, artist, ... tag are UTF-16 LE encoded.","author_login":"Ferry-200","author_association":"NONE","created_at":"2024-04-10T14:29:18+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":2235598020,"issue_number":373,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/373","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2048133477","fragment_type":"issue_comment","sequence":3,"text":"Hm. It's unfortunate that RIFF doesn't specify a text encoding. We would be able to *somewhat* reliably detect UTF-16 LE, but there's no BOM either. The only way for us to know ahead of time how to decode the text would be using GetACP() from Windows. Don't know how I feel about having platform-specific code in Lofty, though.","author_login":"Serial-ATA","author_association":"OWNER","created_at":"2024-04-10T17:45:44+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":2235598020,"issue_number":373,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/373","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2048618571","fragment_type":"issue_comment","sequence":4,"text":"Maybe we can simply set the way to decode text when read riff info. Obviously it is not a good way to fix it though.","author_login":"Ferry-200","author_association":"NONE","created_at":"2024-04-10T23:57:03+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":2235598020,"issue_number":373,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/373","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2051019839","fragment_type":"issue_comment","sequence":5,"text":"That would also work. Gonna have to think about this one. For now I'd just recommend changing the encoding of your files to UTF-8, that's what most libraries (outside of TagLib) will exclusively support.","author_login":"Serial-ATA","author_association":"OWNER","created_at":"2024-04-12T05:43:12+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":2235598020,"issue_number":373,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/373","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2466453480","fragment_type":"issue_comment","sequence":6,"text":"Being able to use alternate encodings would be nice. In my project I need to build an index of all tag data (title/artist/genre/etc). I'm guessing these files are in UTF16 so I'm having the same issue.\n\nThey are able to be read in KDE Elisa. I think that project uses taglib though.","author_login":"aMytho","author_association":"NONE","created_at":"2024-11-09T20:40:33+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":2235598020,"issue_number":373,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/373","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2466570773","fragment_type":"issue_comment","sequence":7,"text":"Do your files have other tags? In the case of the file provided in this issue, it has both a RIFF INFO and an ID3v2 tag. Elisa ends up just using the data from the ID3v2 tag and logs UTF-8 errors for the RIFF INFO tag.","author_login":"Serial-ATA","author_association":"OWNER","created_at":"2024-11-10T03:49:28+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":2235598020,"issue_number":373,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/373","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2466841797","fragment_type":"issue_comment","sequence":8,"text":"I added metadata to several .wav files with musicbrainz picard. I think picard adds ID3v2 tags and RIFF Info tags to wavs by default. How would I check the tag types?\n\nRunning `ffprobe` against it shows the metadata with a warning simlar to: `[json @ 0x5664cd0010c0] 1 invalid UTF-8 sequence(s) found in string 'Example�s', replaced with '�'`. The missing character should be an apostrophe.\n\nI have another file with the ellipses character. It also fails in lofty. No errors in ffprobe or elisa.\n\nI have other files with non-english characters. They play in Elisa and I can view the metadata correctly there. When I pass the files into lofty, I get the following error: `FileDecoding(Wav: \"Failed to read RIFF INFO item value\")`","author_login":"aMytho","author_association":"NONE","created_at":"2024-11-10T18:42:38+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":2235598020,"issue_number":373,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/373","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2466851282","fragment_type":"issue_comment","sequence":9,"text":"That's probably it. Most serious music players will check all tags to fill in any missing fields. Trying to load a non UTF-8 RIFF INFO tag with Elisa will log errors, and it will fallback to the info it can get from the ID3v2 tag. Elisa just depends on `KFileMetaData` which uses TagLib, and as far as I can tell they don't set a `StringHandler`.\n\nI will say, a hard error shouldn't be the case outside of `ParsingMode::Strict`. That's something I can fix (just ignore it and log a warning, like TagLib).\n \n\nI use kid3 to see what tags a file has. It uses TagLib, and with the asset provided in the issue, it ignores any field in the RIFF INFO tag that it can't parse as UTF-8.","author_login":"Serial-ATA","author_association":"OWNER","created_at":"2024-11-10T19:13:26+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":2235598020,"issue_number":373,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/373","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2466908212","fragment_type":"issue_comment","sequence":10,"text":"I downloaded the kid3 program. The files that failed to read in lofy had an ID3 **and** a RIFF tag. Some also had extra tags, but it didn't list a type or any info. \n\nI noticed some files display the data correctly in the ID3 tag, but show an empty entry in the RIFF tag. For example, the file with the invalid UTF8 warning when inspected with ffprobe had an apostrophe in the title. It is visible in the ID3 tag, but the RIFF tag shows the title as empty (key exists, no value). Other values were replaced instead. ID3 has a - (dash) in the artist entry while RIFF has a ? (question mark).","author_login":"aMytho","author_association":"NONE","created_at":"2024-11-10T20:34:01+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":2235598020,"issue_number":373,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/373","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2466916028","fragment_type":"issue_comment","sequence":11,"text":"Kid3 puts markers to show that you can add another tag to the file, not necessarily that it's present, BTW.\n \n\nYeah, I haven't actually seen anyone make use of TagLib's `StringHandler`. I imagine in most cases no errors are noticed since Picard (and likely other tools) add an ID3v2 tag for compatibility. The real issue here is that in Lofty it's a hard error, rather than a discard & warn.","author_login":"Serial-ATA","author_association":"OWNER","created_at":"2024-11-10T21:00:32+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":2235598020,"issue_number":373,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/373","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2466990132","fragment_type":"issue_comment","sequence":12,"text":"From above, I think in the future, `ParsingMode::Strict = false` will cause `read_from` to log Err instead of returning Err when encountering a tag that cannot be parsed correctly. If at least one tag is parsed properly, read_from will still return OK. Otherwise, the Err will be returned.","author_login":"Ferry-200","author_association":"NONE","created_at":"2024-11-10T23:41:32+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":2235598020,"issue_number":373,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/373","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2469484124","fragment_type":"issue_comment","sequence":13,"text":"Interesting! I've never heard of this app, but I think it will be helpful for my project. I was using picard to inspect metadata but this one seems better for what I need.","author_login":"aMytho","author_association":"NONE","created_at":"2024-11-12T02:49:25+08:00","repo_name":"Serial-ATA/lofty-rs","issue_id":2235598020,"issue_number":373,"issue_url":"https://github.com/Serial-ATA/lofty-rs/issues/373","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0500","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"dev","query":"Container crashing when trying to retrieve VPN configs?","query_context":"### Is there a pinned issue for this?\n\n- [X] I have read the pinned issues\n\n### Is there an existing or similar issue for this?\n\n- [X] I have searched the existing issues\n\n### Is there any comment in the documentation for this?\n\n- [X] I have read the documentation, especially the FAQ and Troubleshooting parts\n\n### Is this related to the container/transmission?\n\n- [X] I have checked the container repo for issues\n\n### Are you using the latest release?\n\n- [X] I am using the latest release\n\n### Have you tried using the dev branch latest?\n\n- [X] I have tried using dev branch\n\n### Config used\n\nyaml\nversion: '3.8'\nservices:\n transmission-openvpn:\n container_name: 'haugene'\n cap_add:\n - NET_ADMIN\n devices:\n - '/dev/net/tun'\n volumes:\n - /volume1/data/transmission-data/:/data\n - /volume1/data/haugene/resolv.conf:/etc/resolv.conf\n - /volume1/data/haugene/:/config\n environment:\n - OPENVPN_PROVIDER=PROTONVPN\n - OPENVPN_CONFIG=dk.protonvpn.net.udp\n - OPENVPN_USERNAME=**None**\n - OPENVPN_PASSWORD=**None**\n - LOCAL_NETWORK=192.168.1.0/24\n - OVERRIDE_DNS_1=94.140.14.14\n - OVERRIDE_DNS_2=149.112.112.112\n - OPENVPN_OPTS=--inactive 3600 --ping 10 --ping-exit 60\n #- TRANSMISSION_RATIO_LIMIT=3\n #- TRANSMISSION_RATIO_LIMIT_ENABLED=true\n - TRANSMISSION_SPEED_LIMIT_UP_ENABLED=true\n - TRANSMISSION_SPEED_LIMIT_UP=1000\n logging:\n driver: json-file\n options:\n max-size: 10m\n sysctls:\n - net.ipv6.conf.all.disable_ipv6=0\n ports:\n - '9091:9091'\n image: haugene/transmission-openvpn:dev\n\nnetworks:\n default:\n external:\n name: mybridge\n\n### Current Behavior\n\nContainer crashes at start with this error:\n \n \n \n\nThe issue started somewhere in the last 8 days, it was working fine 8 days ago and as far as I can tell ourobouros did not upgrade this container in the last 8 days.\n\n### Expected Behavior\n\ncontainer starting normally\n\n### How have you tried to solve the problem?\n\n1. tried the dev channel\n2. DNS seems to work because I can see this in the logs:\n \n \n\n### Log output\n\nStarting container with revision: 52d432ddca774080040627e3b6ec61fc9e6b0ac7\nTRANSMISSION_HOME is currently set to: /config/transmission-home\nOne or more OVERRIDE_DNS addresses found. Will use them to overwrite /etc/resolv.conf\nCreating TUN device /dev/net/tun\nUsing OpenVPN provider: PROTONVPN\nRunning with VPN_CONFIG_SOURCE auto\nNo bundled config script found for PROTONVPN. Defaulting to external config\nWill get configs from URL \nRepository is already cloned, checking for update\nerror: Your local changes to the following files would be overwritten by merge:\n openvpn/privado/updateConfigs.sh\nPlease commit your changes or stash them before you merge.\nAborting\nUpdating 45cc9b305..35ec20293\n\n### Environment\n\nmarkdown\n- OS: DSM 7.2\n- Docker: 20.10.23\n\n### Anything else?\n\n_No response_","known_context_document_ids":["gh_issue_1916921713"],"reference_answer":"Exactly, the clones repo is stored in config so check that the git clone\ndeleted\n\nOn Wed, 27 Sep 2023 at 07:10, Niels Morf ***@***.***> wrote:","answer_document_id":"gh_comment_1736374402","silver_evidence_path":["gh_comment_1738938132","gh_issue_1913323259","gh_comment_1736374402"],"evidence_issue_ids":[1916921713,1913323259],"source_repo_name":"haugene/vpn-configs-contrib","source_issue_id":1916921713,"source_issue_number":241,"source_issue_url":"https://github.com/haugene/vpn-configs-contrib/issues/241","target_repo_name":"haugene/docker-transmission-openvpn","target_issue_id":1913323259,"target_issue_number":2727,"target_issue_url":"https://github.com/haugene/docker-transmission-openvpn/issues/2727","reference_anchor_document_id":"gh_comment_1738938132","reference_answer_author":"pkishino","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2857,"anchor_target_overlap":0.2857,"target_answer_overlap":0.2143},"issue_created_at":"2023-09-28T07:51:20+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_1916921713","fragment_type":"issue_description","sequence":0,"text":"Container crashing when trying to retrieve VPN configs\n### Is there a pinned issue for this?\n\n- [X] I have read the pinned issues\n\n### Is there an existing or similar issue for this?\n\n- [X] I have searched the existing issues\n\n### Is there any comment in the documentation for this?\n\n- [X] I have read the documentation, especially the FAQ and Troubleshooting parts\n\n### Is this related to the container/transmission?\n\n- [X] I have checked the container repo for issues\n\n### Are you using the latest release?\n\n- [X] I am using the latest release\n\n### Have you tried using the dev branch latest?\n\n- [X] I have tried using dev branch\n\n### Config used\n\nyaml\nversion: '3.8'\nservices:\n transmission-openvpn:\n container_name: 'haugene'\n cap_add:\n - NET_ADMIN\n devices:\n - '/dev/net/tun'\n volumes:\n - /volume1/data/transmission-data/:/data\n - /volume1/data/haugene/resolv.conf:/etc/resolv.conf\n - /volume1/data/haugene/:/config\n environment:\n - OPENVPN_PROVIDER=PROTONVPN\n - OPENVPN_CONFIG=dk.protonvpn.net.udp\n - OPENVPN_USERNAME=**None**\n - OPENVPN_PASSWORD=**None**\n - LOCAL_NETWORK=192.168.1.0/24\n - OVERRIDE_DNS_1=94.140.14.14\n - OVERRIDE_DNS_2=149.112.112.112\n - OPENVPN_OPTS=--inactive 3600 --ping 10 --ping-exit 60\n #- TRANSMISSION_RATIO_LIMIT=3\n #- TRANSMISSION_RATIO_LIMIT_ENABLED=true\n - TRANSMISSION_SPEED_LIMIT_UP_ENABLED=true\n - TRANSMISSION_SPEED_LIMIT_UP=1000\n logging:\n driver: json-file\n options:\n max-size: 10m\n sysctls:\n - net.ipv6.conf.all.disable_ipv6=0\n ports:\n - '9091:9091'\n image: haugene/transmission-openvpn:dev\n\nnetworks:\n default:\n external:\n name: mybridge\n\n### Current Behavior\n\nContainer crashes at start with this error:\n \n \n \n\nThe issue started somewhere in the last 8 days, it was working fine 8 days ago and as far as I can tell ourobouros did not upgrade this container in the last 8 days.\n\n### Expected Behavior\n\ncontainer starting normally\n\n### How have you tried to solve the problem?\n\n1. tried the dev channel\n2. DNS seems to work because I can see this in the logs:\n \n \n\n### Log output\n\nStarting container with revision: 52d432ddca774080040627e3b6ec61fc9e6b0ac7\nTRANSMISSION_HOME is currently set to: /config/transmission-home\nOne or more OVERRIDE_DNS addresses found. Will use them to overwrite /etc/resolv.conf\nCreating TUN device /dev/net/tun\nUsing OpenVPN provider: PROTONVPN\nRunning with VPN_CONFIG_SOURCE auto\nNo bundled config script found for PROTONVPN. Defaulting to external config\nWill get configs from URL \nRepository is already cloned, checking for update\nerror: Your local changes to the following files would be overwritten by merge:\n openvpn/privado/updateConfigs.sh\nPlease commit your changes or stash them before you merge.\nAborting\nUpdating 45cc9b305..35ec20293\n\n### Environment\n\nmarkdown\n- OS: DSM 7.2\n- Docker: 20.10.23\n\n### Anything else?\n\n_No response_","author_login":"Qhilm","author_association":"NONE","created_at":"2023-09-28T07:51:20+08:00","repo_name":"haugene/vpn-configs-contrib","issue_id":1916921713,"issue_number":241,"issue_url":"https://github.com/haugene/vpn-configs-contrib/issues/241","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1738788710","fragment_type":"issue_comment","sequence":1,"text":"I erased the content of the `vpn-configs-contrib` folder to test, and the error is now:\n \n \n\nI also tried removing `OVERRIDE_DNS_1` and `OVERRIDE_DNS_2`, it doesn't seem to change much.","author_login":"Qhilm","author_association":"NONE","created_at":"2023-09-28T09:20:39+08:00","repo_name":"haugene/vpn-configs-contrib","issue_id":1916921713,"issue_number":241,"issue_url":"https://github.com/haugene/vpn-configs-contrib/issues/241","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1738938132","fragment_type":"issue_comment","sequence":2,"text":"URL \ndelete vpn-configs-contrib\nthen delete container and restart..\nit's a git thing..","author_login":"pkishino","author_association":"COLLABORATOR","created_at":"2023-09-28T11:05:59+08:00","repo_name":"haugene/vpn-configs-contrib","issue_id":1916921713,"issue_number":241,"issue_url":"https://github.com/haugene/vpn-configs-contrib/issues/241","linked_issue_ids":[1913323259],"is_known_query_context":false},{"document_id":"gh_comment_1751641969","fragment_type":"issue_comment","sequence":3,"text":"Ha. I had to delete the entire `vpn-configs-contrib` folder. I had previously deleted the contents only but not the folder itself, which was somehow not helping. Maybe some hidden files I missed. Thanks.","author_login":"Qhilm","author_association":"NONE","created_at":"2023-10-07T07:53:40+08:00","repo_name":"haugene/vpn-configs-contrib","issue_id":1916921713,"issue_number":241,"issue_url":"https://github.com/haugene/vpn-configs-contrib/issues/241","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1913323259","fragment_type":"issue_description","sequence":0,"text":"openvpn/privado loop\n### Is there a pinned issue for this?\n\n- [X] I have read the pinned issues and could not find my issue\n\n### Is there an existing or similar issue/discussion for this?\n\n- [X] I have searched the existing issues\n- [X] I have searched the existing discussions\n\n### Is there any comment in the documentation for this?\n\n- [X] I have read the documentation, especially the FAQ and Troubleshooting parts\n\n### Is this related to a provider?\n\n- [X] I have checked the provider repo for issues\n- [X] My issue is NOT related to a provider\n\n### Are you using the latest release?\n\n- [X] I am using the latest release\n\n### Have you tried using the dev branch latest?\n\n- [ ] I have tried using dev branch\n\n### Docker run config used\n\nversion: '3.3'\nservices:\n transmission-openvpn:\n cap_add:\n - NET_ADMIN\n volumes:\n - '/mnt/downloads:/data'\n - '/opt/transmission/config:/config'\n sysctls:\n - \"net.ipv6.conf.all.disable_ipv6=0\" \n environment:\n - OPENVPN_PROVIDER=HIDEME\n - OPENVPN_CONFIG=UK\n - OPENVPN_USERNAME=************\n - OPENVPN_PASSWORD=************\n - LOCAL_NETWORK=192.168.1.0/24\n logging:\n driver: json-file\n options:\n max-size: 10m\n ports:\n - '9091:9091'\n image: haugene/transmission-openvpn\n\n### Current Behavior\n\nI am not using Privado, I am using Hide.me. Upon start, the container starts and shows port in list. The port disappears once the container goes from starting to running status. I check the log and I get a loop then it aborts as seen in the logfile attached below.\n\n### Expected Behavior\n\nAll functions load and are accessible and transmission connected behind Hide.me VPN\n\n### How have you tried to solve the problem?\n\nRestarted container\nStopped & restarted VPN\nRebooted machine where container is housed\n\n### Log output\n\n_transmission-openvpn-transmission-openvpn-1_logs.txt\n\n### HW/SW Environment\n\nmarkdown\n- OS:Unbuntu 22.04.2\n- Docker:24.0.5, build ced0996\n\n### Anything else?\n\n_No response_","author_login":"Xsatc77","author_association":"NONE","created_at":"2023-09-26T11:41:28+08:00","repo_name":"haugene/docker-transmission-openvpn","issue_id":1913323259,"issue_number":2727,"issue_url":"https://github.com/haugene/docker-transmission-openvpn/issues/2727","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1735513997","fragment_type":"issue_comment","sequence":1,"text":"That put me in the same state... still on the loop of a VPN i dont even use","author_login":"Xsatc77","author_association":"NONE","created_at":"2023-09-26T13:10:23+08:00","repo_name":"haugene/docker-transmission-openvpn","issue_id":1913323259,"issue_number":2727,"issue_url":"https://github.com/haugene/docker-transmission-openvpn/issues/2727","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1736322100","fragment_type":"issue_comment","sequence":2,"text":"If you deleted the container completely it wouldn’t have a git cache of\ndownloaded profiles..\n\nOn Tue, 26 Sep 2023 at 22:10, Xsatc77 ***@***.***> wrote:","author_login":"pkishino","author_association":"COLLABORATOR","created_at":"2023-09-26T21:22:51+08:00","repo_name":"haugene/docker-transmission-openvpn","issue_id":1913323259,"issue_number":2727,"issue_url":"https://github.com/haugene/docker-transmission-openvpn/issues/2727","linked_issue_ids":[1913323259],"is_known_query_context":false},{"document_id":"gh_comment_1736371068","fragment_type":"issue_comment","sequence":3,"text":"@Xsatc77 if you delete the config from the opt/transmission/config directory the configuration gets freshly cloned and the issue disapears :)\nYou have mapped the config as volume and therfore just recreating the container does not work.","author_login":"Aniel","author_association":"NONE","created_at":"2023-09-26T22:09:52+08:00","repo_name":"haugene/docker-transmission-openvpn","issue_id":1913323259,"issue_number":2727,"issue_url":"https://github.com/haugene/docker-transmission-openvpn/issues/2727","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1736374402","fragment_type":"issue_comment","sequence":4,"text":"Exactly, the clones repo is stored in config so check that the git clone\ndeleted\n\nOn Wed, 27 Sep 2023 at 07:10, Niels Morf ***@***.***> wrote:","author_login":"pkishino","author_association":"COLLABORATOR","created_at":"2023-09-26T22:11:28+08:00","repo_name":"haugene/docker-transmission-openvpn","issue_id":1913323259,"issue_number":2727,"issue_url":"https://github.com/haugene/docker-transmission-openvpn/issues/2727","linked_issue_ids":[1913323259],"is_known_query_context":false}],"human_reviewed":false}